[PATCH net-next RFC WIP] Patch for XDP support for virtio_net

2016-10-21 Thread Shrijeet Mukherjee
This patch adds support for xdp ndo and also inserts the xdp program call into the merged RX buffers and big buffers paths * The small packet skb receive is skipped for now * No TX for now Signed-off-by: Shrijeet Mukherjee --- drivers/net/virtio_net.c | 133

Re: [Patch net] net: saving irq context for peernet2id()

2016-10-21 Thread Cong Wang
On Fri, Oct 21, 2016 at 1:33 PM, David Miller wrote: > From: Paul Moore > Date: Fri, 21 Oct 2016 16:15:00 -0400 > >> However, that's not the case is it? Unless I missed something, the >> fix that Cong Wang is advocating (rework the audit multicast

Re: [PATCH] netns: revert "netns: avoid disabling irq for netns id"

2016-10-21 Thread Cong Wang
On Fri, Oct 21, 2016 at 6:49 PM, Paul Moore wrote: > Eventually we should be able to reintroduce this code once we have > rewritten the audit multicast code to queue messages much the same > way we do for unicast messages. A tracking issue for this can be > found below: NAK.

Re: [Patch net] net: saving irq context for peernet2id()

2016-10-21 Thread Cong Wang
On Fri, Oct 21, 2016 at 6:55 PM, Paul Moore wrote: > It's the end of my day, and commitments over the weekend will limit > how much additional testing/work I can do so I went ahead and just > posted a simple revert to netdev, it should be in your inbox already. > Please fix

Re: [Patch net] net: saving irq context for peernet2id()

2016-10-21 Thread Cong Wang
On Fri, Oct 21, 2016 at 1:03 PM, Paul Moore wrote: > On Fri, Oct 21, 2016 at 2:02 PM, Cong Wang wrote: >> On Fri, Oct 21, 2016 at 9:19 AM, Paul Moore wrote: >>> On Thu, Oct 20, 2016 at 7:35 PM, Cong Wang

Re: [Patch net] net: saving irq context for peernet2id()

2016-10-21 Thread Paul Moore
On Fri, Oct 21, 2016 at 4:53 PM, Paul Moore wrote: > On Fri, Oct 21, 2016 at 4:33 PM, David Miller wrote: >> From: Paul Moore >> Date: Fri, 21 Oct 2016 16:15:00 -0400 >> >>> However, that's not the case is it? Unless I missed

[PATCH] netns: revert "netns: avoid disabling irq for netns id"

2016-10-21 Thread Paul Moore
From: Paul Moore This reverts commit bc51dddf98c9 ("netns: avoid disabling irq for netns id") as it was found to cause problems with systems running SELinux/audit, see the mailing list thread below: * http://marc.info/?t=14769465392=1=2 Eventually we should be able to

Re: [PATCH] flow_dissector: avoid uninitialized variable access

2016-10-21 Thread Linus Torvalds
On Fri, Oct 21, 2016 at 9:31 AM, Jiri Pirko wrote: > > I don't see how vlan could be used uninitialized. But I understand that > this is impossible for gcc to track it. Please just use uninitialized_var() Actually, I think we should never use "uninitialized_var()" except

Re: [PATCH 1/2] net: phy: broadcom: Update Auxiliary Control Register macros

2016-10-21 Thread Joel Stanley
On Sat, Oct 22, 2016 at 3:50 AM, Xo Wang wrote: > Add the RXD-to-RXC skew (delay) time bit in the Miscellaneous Control > shadow register and a mask for the shadow selector field. > > Remove a re-definition of MII_BCM54XX_AUXCTL_SHDWSEL_AUXCTL. > > Signed-off-by: Xo Wang

Re: [PATCH 2/2] net: phy: broadcom: Add support for BCM54612E

2016-10-21 Thread Joel Stanley
On Sat, Oct 22, 2016 at 3:50 AM, Xo Wang wrote: > This PHY has internal delays enabled after reset. This clears the > internal delay enables unless the interface specifically requests them. > > Signed-off-by: Xo Wang Reviewed-by: Joel Stanley

Re: [PATCH] flow_dissector: avoid uninitialized variable access

2016-10-21 Thread Arnd Bergmann
On Friday, October 21, 2016 11:05:45 PM CEST Arnd Bergmann wrote: > > Can you explain why "dissector_uses_key(flow_dissector, > FLOW_DISSECTOR_KEY_VLAN) && skb_vlan_tag_present(skb)" implies > "eth_type_vlan(proto))"? > > If I add uninitialized_var() here, I would at least put that in > a

Re: [PATCH 2/2] net: phy: broadcom: Add support for BCM54612E

2016-10-21 Thread Florian Fainelli
On 10/21/2016 10:20 AM, Xo Wang wrote: > This PHY has internal delays enabled after reset. This clears the > internal delay enables unless the interface specifically requests them. > > Signed-off-by: Xo Wang Reviewed-by: Florian Fainelli Cross checked

Re: [PATCH 1/2] net: phy: broadcom: Update Auxiliary Control Register macros

2016-10-21 Thread Florian Fainelli
On 10/21/2016 10:20 AM, Xo Wang wrote: > Add the RXD-to-RXC skew (delay) time bit in the Miscellaneous Control > shadow register and a mask for the shadow selector field. > > Remove a re-definition of MII_BCM54XX_AUXCTL_SHDWSEL_AUXCTL. > > Signed-off-by: Xo Wang Reviewed-by:

[PATCH net 2/2] net: dsa: bcm_sf2: Do not rely on kexec_in_progress

2016-10-21 Thread Florian Fainelli
After discussing with Eric, it turns out that, while using kexec_in_progress is a nice optimization, which prevents us from always powering on the integrated PHY, let's just turn it on in the shutdown path. This removes a dependency on kexec_in_progress which, according to Eric should not be used

[PATCH net 1/2] Revert "kexec: Export kexec_in_progress to modules"

2016-10-21 Thread Florian Fainelli
This reverts commit 97dcaa0fcfd24daa9a36c212c1ad1d5a97759212. Based on the review discussion with Eric, we will come up with a different fix for the bcm_sf2 driver which does not make it rely on the kexec_in_progress value. Signed-off-by: Florian Fainelli ---

[PATCH net 0/2] net: dsa: bcm_sf2: Do not rely on kexec_in_progress

2016-10-21 Thread Florian Fainelli
David, Eric, These are the two patches following the discussing we had on kexec_in_progress. Feel free to apply or discard them, thanks! Florian Fainelli (2): Revert "kexec: Export kexec_in_progress to modules" net: dsa: bcm_sf2: Do not rely on kexec_in_progress drivers/net/dsa/bcm_sf2.c

Re: [PATCH net-next v6 3/3] udp: use it's own memory accounting schema

2016-10-21 Thread Eric Dumazet
On Fri, 2016-10-21 at 13:55 +0200, Paolo Abeni wrote: > Completely avoid default sock memory accounting and replace it > with udp-specific accounting. > > Since the new memory accounting model encapsulates completely > the required locking, remove the socket lock on both enqueue and > dequeue,

Re: [PATCH net-next v6 2/3] udp: implement memory accounting helpers

2016-10-21 Thread Eric Dumazet
On Fri, 2016-10-21 at 13:55 +0200, Paolo Abeni wrote: > Avoid using the generic helpers. > Use the receive queue spin lock to protect the memory > accounting operation, both on enqueue and on dequeue. > > On dequeue perform partial memory reclaiming, trying to > leave a quantum of forward

Re: [PATCH net-next v6 1/3] net/socket: factor out helpers for memory and queue manipulation

2016-10-21 Thread Eric Dumazet
On Fri, 2016-10-21 at 13:55 +0200, Paolo Abeni wrote: > Basic sock operations that udp code can use with its own > memory accounting schema. No functional change is introduced > in the existing APIs. > > v4 -> v5: > - avoid whitespace changes > > v2 -> v4: > - avoid exporting

Re: [PATCH] flow_dissector: avoid uninitialized variable access

2016-10-21 Thread Arnd Bergmann
On Friday, October 21, 2016 6:31:18 PM CEST Jiri Pirko wrote: > Fri, Oct 21, 2016 at 05:55:53PM CEST, a...@arndb.de wrote: > >gcc warns about an uninitialized pointer dereference in the vlan > >priority handling: > > > >net/core/flow_dissector.c: In function '__skb_flow_dissect': >

Re: [RFC PATCH 09/13] net: phy: Add Meson GXL Internal PHY driver

2016-10-21 Thread Florian Fainelli
On 10/21/2016 07:40 AM, Neil Armstrong wrote: > Add driver for the Internal RMII PHY found in the Amlogic Meson GXL SoCs. > > This PHY seems to only implement some standard registers and need some > workarounds to provide autoneg values from vendor registers. > > Some magic values are currently

Re: [Patch net] net: saving irq context for peernet2id()

2016-10-21 Thread Paul Moore
On Fri, Oct 21, 2016 at 4:33 PM, David Miller wrote: > From: Paul Moore > Date: Fri, 21 Oct 2016 16:15:00 -0400 > >> However, that's not the case is it? Unless I missed something, the >> fix that Cong Wang is advocating (rework the audit multicast

Re: [Patch net] net: saving irq context for peernet2id()

2016-10-21 Thread David Miller
From: Paul Moore Date: Fri, 21 Oct 2016 16:15:00 -0400 > However, that's not the case is it? Unless I missed something, the > fix that Cong Wang is advocating (rework the audit multicast code), is > a change that I have said I'm not going to accept during the -rc > phase.

Re: [Patch net] net: saving irq context for peernet2id()

2016-10-21 Thread Paul Moore
On Fri, Oct 21, 2016 at 3:39 PM, Richard Guy Briggs wrote: > On 2016-10-21 11:02, Cong Wang wrote: >> On Fri, Oct 21, 2016 at 9:19 AM, Paul Moore wrote: >> > On Thu, Oct 20, 2016 at 7:35 PM, Cong Wang >> > wrote: >> >> This is

Re: [Patch net] net: saving irq context for peernet2id()

2016-10-21 Thread Paul Moore
On Fri, Oct 21, 2016 at 2:02 PM, Cong Wang wrote: > On Fri, Oct 21, 2016 at 9:19 AM, Paul Moore wrote: >> On Thu, Oct 20, 2016 at 7:35 PM, Cong Wang wrote: >>> This is what I did in the follow up patch. I attach the

[PATCH iproute2 net-next] tc: m_mirred: Fix parsing of 'index' optional argument

2016-10-21 Thread Shmulik Ladkani
Code in parse_mirred() suggests "index" argument can be placed either after the "egress" clause, or as the first argument (after "action mirred"). However, parse_egress() fails to correctly parse "index" if it's the first argument. For example: # tc filter add ... action mirred index 5

Re: [Patch net] net: saving irq context for peernet2id()

2016-10-21 Thread Richard Guy Briggs
On 2016-10-21 11:02, Cong Wang wrote: > On Fri, Oct 21, 2016 at 9:19 AM, Paul Moore wrote: > > On Thu, Oct 20, 2016 at 7:35 PM, Cong Wang wrote: > >> This is what I did in the follow up patch. I attach the updated version > >> in this email for you

Re: [PATCH] kexec: Export kexec_in_progress to modules

2016-10-21 Thread Florian Fainelli
On 10/21/2016 11:37 AM, Eric W. Biederman wrote: > David Miller writes: > >> From: ebied...@xmission.com (Eric W. Biederman) >> Date: Fri, 21 Oct 2016 00:26:55 -0500 >> >>> So as far as I can tell you are advocating for a change to support a >>> driver doing something that

Re: Pure polling mode for netdevices

2016-10-21 Thread Eric Dumazet
On Fri, 2016-10-21 at 13:03 -0500, Zach Brown wrote: > Is there a way to get NAPI to poll all the time? > Or just any way to get netdevices to use only polling and no interrupts? > > We have some rt targets where the jitter can be improved by disabling > interrupts and using just polling. In

Re: [PATCH] kexec: Export kexec_in_progress to modules

2016-10-21 Thread Eric W. Biederman
David Miller writes: > From: ebied...@xmission.com (Eric W. Biederman) > Date: Fri, 21 Oct 2016 00:26:55 -0500 > >> So as far as I can tell you are advocating for a change to support a >> driver doing something that is completely pointless. So no let's not >> export this

Pure polling mode for netdevices

2016-10-21 Thread Zach Brown
Is there a way to get NAPI to poll all the time? Or just any way to get netdevices to use only polling and no interrupts? We have some rt targets where the jitter can be improved by disabling interrupts and using just polling. In these cases we're okay with the performance downsides that come

Re: [Patch net] net: saving irq context for peernet2id()

2016-10-21 Thread Cong Wang
On Fri, Oct 21, 2016 at 9:19 AM, Paul Moore wrote: > On Thu, Oct 20, 2016 at 7:35 PM, Cong Wang wrote: >> This is what I did in the follow up patch. I attach the updated version >> in this email for you to review ... > > I think there is still some

Re: [PATCH net] net: remove MTU limits on a few ether_setup callers

2016-10-21 Thread David Miller
From: Jarod Wilson Date: Thu, 20 Oct 2016 23:25:27 -0400 > These few drivers call ether_setup(), but have no ndo_change_mtu, and thus > were overlooked for changes to MTU range checking behavior. They > previously had no range checks, so for feature-parity, set their min_mtu >

Re: network packet kernel rate limit

2016-10-21 Thread Cong Wang
On Thu, Oct 20, 2016 at 11:17 PM, YUAN Linyu wrote: > User space application require linux kernel to do rate limit to some type of > Ethernet packet(ARP, ICMP, TCP, for example 1000 packet/s) when system run > under Ethernet packet flooding test. > Do you know

[PATCH 2/2] net: phy: broadcom: Add support for BCM54612E

2016-10-21 Thread Xo Wang
This PHY has internal delays enabled after reset. This clears the internal delay enables unless the interface specifically requests them. Signed-off-by: Xo Wang --- drivers/net/phy/broadcom.c | 48 ++ include/linux/brcmphy.h| 1 +

[PATCH 1/2] net: phy: broadcom: Update Auxiliary Control Register macros

2016-10-21 Thread Xo Wang
Add the RXD-to-RXC skew (delay) time bit in the Miscellaneous Control shadow register and a mask for the shadow selector field. Remove a re-definition of MII_BCM54XX_AUXCTL_SHDWSEL_AUXCTL. Signed-off-by: Xo Wang --- include/linux/brcmphy.h | 3 ++- 1 file changed, 2

[PATCH 0/2] Broadcom BCM54612E support

2016-10-21 Thread Xo Wang
This series is based on tip of torvalds/master. The first patch adds register definitions from Broadcom docs. The second patch adds the BCM54612E PHY ID, flags, and device-specific RGMII internal delay initialization. I tested on a custom board with an Aspeed AST2500 SOC with its second MAC

Re: [PATCH] flow_dissector: avoid uninitialized variable access

2016-10-21 Thread Jiri Pirko
Fri, Oct 21, 2016 at 05:55:53PM CEST, a...@arndb.de wrote: >gcc warns about an uninitialized pointer dereference in the vlan >priority handling: > >net/core/flow_dissector.c: In function '__skb_flow_dissect': >net/core/flow_dissector.c:281:61: error: 'vlan' may be used uninitialized in >this

Re: [Patch net] net: saving irq context for peernet2id()

2016-10-21 Thread Paul Moore
On Thu, Oct 20, 2016 at 7:35 PM, Cong Wang wrote: > On Thu, Oct 20, 2016 at 12:07 PM, Paul Moore wrote: >> On Thu, Oct 20, 2016 at 2:29 PM, Cong Wang wrote: >>> On Thu, Oct 20, 2016 at 7:58 AM, Stephen Smalley

Re: [PATCH net-next v2 7/9] net: use core MTU range checking in misc drivers

2016-10-21 Thread Sebastian Reichel
Hi, On Thu, Oct 20, 2016 at 01:55:22PM -0400, Jarod Wilson wrote: > hsi/clients/ssi_protocol: > - use core MTU range checking > - remove now redundant ssip_pn_set_mtu Acked-By: Sebastian Reichel -- Sebastian signature.asc Description: PGP signature

Re: [RFC PATCH 08/13] dwmac-meson8b: add support for phy selection

2016-10-21 Thread Andrew Lunn
Hi Neil > Yes this would be a good idea if we were able to scan the internal > and external PHYs at the same time, but with our limited knowledge > the values we write in the register seems to switch a mux for the > whole RMII and MDIO signals to either interface. Ah, O.K. So you need something

[PATCH] flow_dissector: avoid uninitialized variable access

2016-10-21 Thread Arnd Bergmann
gcc warns about an uninitialized pointer dereference in the vlan priority handling: net/core/flow_dissector.c: In function '__skb_flow_dissect': net/core/flow_dissector.c:281:61: error: 'vlan' may be used uninitialized in this function [-Werror=maybe-uninitialized] >From all I can tell, this

[PATCH net-next] sch_htb: do not report fake rate estimators

2016-10-21 Thread Eric Dumazet
From: Eric Dumazet When I prepared commit d250a5f90e53 ("pkt_sched: gen_estimator: Dont report fake rate estimators"), htb still had an implicit rate estimator for all its classes. Then later, I made this rate estimator optional in commit 64153ce0a7b6 ("net_sched: htb: do

Re: [PATCH net] net: remove MTU limits on a few ether_setup callers

2016-10-21 Thread Andrew Lunn
> I'm all for fine-tuning things to be more correct, but my initial > approach here was to restore the ranges that were previously there, > and DSA had no upper or lower bounds checks. I'm not at all familiar > with DSA either way. Please just restore the old behaviour. We can consider changes

Re: [RFC PATCH 08/13] dwmac-meson8b: add support for phy selection

2016-10-21 Thread Neil Armstrong
On 10/21/2016 05:54 PM, Andrew Lunn wrote: > On Fri, Oct 21, 2016 at 04:40:33PM +0200, Neil Armstrong wrote: >> The Meson GXL dwmac Glue Layer also provides switching between an external >> PHY >> and an internal RMII 10/100 PHY. >> Add a way to setup the correct PHY switching from a device tree

Re: [RFC PATCH 08/13] dwmac-meson8b: add support for phy selection

2016-10-21 Thread Andrew Lunn
On Fri, Oct 21, 2016 at 04:40:33PM +0200, Neil Armstrong wrote: > The Meson GXL dwmac Glue Layer also provides switching between an external PHY > and an internal RMII 10/100 PHY. > Add a way to setup the correct PHY switching from a device tree attribute. Humm, actually. Maybe PHY_IS_INTERNAL in

Re: [PATCH net] net: remove MTU limits on a few ether_setup callers

2016-10-21 Thread Jarod Wilson
On Fri, Oct 21, 2016 at 10:44:41AM +0200, Andrew Lunn wrote: > On Thu, Oct 20, 2016 at 08:42:46PM -0700, Florian Fainelli wrote: > > Le 20/10/2016 à 20:25, Jarod Wilson a écrit : > > > These few drivers call ether_setup(), but have no ndo_change_mtu, and thus > > > were overlooked for changes to

Re: [RFC PATCH 08/13] dwmac-meson8b: add support for phy selection

2016-10-21 Thread Andrew Lunn
On Fri, Oct 21, 2016 at 04:40:33PM +0200, Neil Armstrong wrote: > The Meson GXL dwmac Glue Layer also provides switching between an external PHY > and an internal RMII 10/100 PHY. > Add a way to setup the correct PHY switching from a device tree attribute. Hi Neil Can this be made automatic?

Re: [PATCH] net: sched: make default fifo qdiscs appear in the dump

2016-10-21 Thread Eric Dumazet
On Fri, 2016-10-21 at 11:03 -0400, David Miller wrote: > If this is changing default behavior we should approach this the other > way around. > > Keep behaving the way we do, user asks for new behavior with the attribute. SGTM

Re: [Patch net v2] ipv6: fix a potential deadlock in do_ipv6_setsockopt()

2016-10-21 Thread David Miller
From: Cong Wang Date: Wed, 19 Oct 2016 23:35:12 -0700 > Baozeng reported this deadlock case: > >CPU0CPU1 > > lock([ 165.136033] sk_lock-AF_INET6); >lock([ 165.136033]

Re: [PATCH net-next] hv_netvsc: fix a race between netvsc_send() and netvsc_init_buf()

2016-10-21 Thread David Miller
From: Vitaly Kuznetsov Date: Fri, 21 Oct 2016 17:17:18 +0200 > David Miller writes: > >> From: Vitaly Kuznetsov >> Date: Fri, 21 Oct 2016 13:15:53 +0200 >> >>> David Miller writes: >>> From: Vitaly

Re: [PATCH net-next] hv_netvsc: fix a race between netvsc_send() and netvsc_init_buf()

2016-10-21 Thread David Miller
From: Vitaly Kuznetsov Date: Wed, 19 Oct 2016 15:53:01 +0200 > Fix in commit 880988348270 ("hv_netvsc: set nvdev link after populating > chn_table") turns out to be incomplete. A crash in > netvsc_get_next_send_section() is observed on mtu change when the device > is under

Re: [PATCH] net: sched: make default fifo qdiscs appear in the dump

2016-10-21 Thread Eric Dumazet
On Fri, 2016-10-21 at 10:55 -0400, David Miller wrote: > From: Eric Dumazet > Date: Fri, 21 Oct 2016 04:36:57 -0700 > > > I guess we'll need to not pull this patch in our kernels. > > Eric, quite frankly, this whole "we won't pull this patch into Google > kernels" threat

Re: [PATCH net-next] hv_netvsc: fix a race between netvsc_send() and netvsc_init_buf()

2016-10-21 Thread Vitaly Kuznetsov
David Miller writes: > From: Vitaly Kuznetsov > Date: Fri, 21 Oct 2016 13:15:53 +0200 > >> David Miller writes: >> >>> From: Vitaly Kuznetsov >>> Date: Thu, 20 Oct 2016 10:51:04 +0200 >>> Stephen

RE: [PATCH v8 0/8] thunderbolt: Introducing Thunderbolt(TM) Networking

2016-10-21 Thread Mario.Limonciello
> -Original Message- > From: Amir Levy [mailto:amir.jer.l...@intel.com] > Sent: Wednesday, September 28, 2016 9:44 AM > To: gre...@linuxfoundation.org > Cc: andreas.noe...@gmail.com; bhelg...@google.com; cor...@lwn.net; > linux-ker...@vger.kernel.org; linux-...@vger.kernel.org; >

Re: [PATCH] net: sched: make default fifo qdiscs appear in the dump

2016-10-21 Thread David Miller
From: Eric Dumazet Date: Fri, 21 Oct 2016 06:14:23 -0700 > On Fri, 2016-10-21 at 14:56 +0200, Jiri Kosina wrote: >> On Fri, 21 Oct 2016, Eric Dumazet wrote: >> >> > Some of us are dealing with huge HTB hierarchies, so adding default fifo >> > in the dump will add more

Re: [PATCH net] tipc: Guard against tiny MTU in tipc_msg_build()

2016-10-21 Thread Ben Hutchings
On Fri, 2016-10-21 at 14:57 +, Jon Maloy wrote: > > -Original Message- > > > > From: Ben Hutchings [mailto:b...@decadent.org.uk] > > Sent: Thursday, 20 October, 2016 12:40 > > > > To: Jon Maloy ; Ying Xue > > > > > > Cc:

Re: [PATCH] net: sched: make default fifo qdiscs appear in the dump

2016-10-21 Thread David Miller
From: Jiri Kosina Date: Fri, 21 Oct 2016 14:56:33 +0200 (CEST) > I'd really like to unhide the default qdiscs, it makes little sense to be > inconsistent in this way. Something that's been invisible for such a long time... there is no way applications need or require this.

RE: [PATCH net] tipc: Guard against tiny MTU in tipc_msg_build()

2016-10-21 Thread Jon Maloy
> -Original Message- > From: Ben Hutchings [mailto:b...@decadent.org.uk] > Sent: Thursday, 20 October, 2016 12:40 > To: Jon Maloy ; Ying Xue > Cc: netdev@vger.kernel.org; Qian Zhang ; Eric Dumazet > >

Re: [PATCH] net: sched: make default fifo qdiscs appear in the dump

2016-10-21 Thread David Miller
From: Eric Dumazet Date: Fri, 21 Oct 2016 04:36:57 -0700 > I guess we'll need to not pull this patch in our kernels. Eric, quite frankly, this whole "we won't pull this patch into Google kernels" threat is getting _REALLY_ _OLD_. If you have a valid technical argument

Re: [PATCH] net: stmmac: Add OXNAS Glue Driver

2016-10-21 Thread Neil Armstrong
On 10/21/2016 01:53 PM, Giuseppe CAVALLARO wrote: > Hello > > some my minor cents below > > On 10/21/2016 12:20 PM, Joachim Eastwood wrote: >> Hi Neil, >> >> On 21 October 2016 at 10:44, Neil Armstrong wrote: >>> Add Synopsys Designware MAC Glue layer for the Oxford

Re: [PATCH net-next] hv_netvsc: fix a race between netvsc_send() and netvsc_init_buf()

2016-10-21 Thread David Miller
From: Vitaly Kuznetsov Date: Fri, 21 Oct 2016 13:15:53 +0200 > David Miller writes: > >> From: Vitaly Kuznetsov >> Date: Thu, 20 Oct 2016 10:51:04 +0200 >> >>> Stephen Hemminger writes: >>> Do we

[RFC PATCH 01/13] pinctrl: meson: Add GXL pinctrl definitions

2016-10-21 Thread Neil Armstrong
Add support for the Amlogic Meson GXL SoC, this is a partially complete definition only based on the Amlogic Vendor tree. This definition differs a lot from the GXBB and needs a separate entry. Signed-off-by: Neil Armstrong ---

[RFC PATCH 07/13] ARM64: dts: meson-gxl-p23x: Add uart pinctrl

2016-10-21 Thread Neil Armstrong
Add pinctrl attribute to p23x uart node. Signed-off-by: Neil Armstrong --- arch/arm64/boot/dts/amlogic/meson-gxl-s905d-p23x.dtsi | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/arm64/boot/dts/amlogic/meson-gxl-s905d-p23x.dtsi

[RFC PATCH 00/13] ARM64: meson-gxl: Add extended support

2016-10-21 Thread Neil Armstrong
This RFC patchset provides extended peripheral support for the Amlogix GXL SoCs. The final patchs will be split among the correct subsystems. In order to support more functionalities, this patchset : - Moves peripheral nodes to the common Meson arm64 dtsi - Add i2c, mmc, sd, sdio, pinctrl and

Re: [PATCH] net: stmmac: Add OXNAS Glue Driver

2016-10-21 Thread Neil Armstrong
On 10/21/2016 12:20 PM, Joachim Eastwood wrote: > Hi Neil, > > On 21 October 2016 at 10:44, Neil Armstrong wrote: >> Add Synopsys Designware MAC Glue layer for the Oxford Semiconductor OX820. >> >> Signed-off-by: Neil Armstrong >> --- >>

[RFC PATCH 02/13] ARM64: dts: meson-gxbb: Move common nodes to meson-gx

2016-10-21 Thread Neil Armstrong
Move common nodes between GXBB and GXL in to the common GX dtsi. Leave the clock attributes in the GXBB dtsi for now. Signed-off-by: Neil Armstrong --- arch/arm64/boot/dts/amlogic/meson-gx.dtsi | 131 +++ arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi

[RFC PATCH 04/13] ARM64: dts: meson-gxl: Add clock nodes

2016-10-21 Thread Neil Armstrong
Add clock node for Amlogic Meson GXL. The GXBB compatible is retained since the GXBB clock tree is used for now. Signed-off-by: Neil Armstrong --- arch/arm64/boot/dts/amlogic/meson-gxl.dtsi | 9 + 1 file changed, 9 insertions(+) diff --git

[RFC PATCH 10/13] ARM64: dts: meson-gxl: Add ethernet nodes with internal PHY

2016-10-21 Thread Neil Armstrong
Add Ethernet node with Internal PHY selection for the Amlogic GXL SoCs Signed-off-by: Neil Armstrong --- arch/arm64/boot/dts/amlogic/meson-gxl.dtsi | 28 1 file changed, 28 insertions(+) diff --git

[RFC PATCH 11/13] ARM64: dts: meson-gxl-p23x: Enable ethernet

2016-10-21 Thread Neil Armstrong
Enable Ethernet on the p23x board, pinctrl attribute are not added since the current setup uses the Internal PHY. Signed-off-by: Neil Armstrong --- arch/arm64/boot/dts/amlogic/meson-gxl-s905d-p23x.dtsi | 4 1 file changed, 4 insertions(+) diff --git

[RFC PATCH 05/13] ARM64: dts: meson-gxl: Add i2c nodes

2016-10-21 Thread Neil Armstrong
Add i2c nodes clock attributes for Amlogic Meson GXL. Signed-off-by: Neil Armstrong --- arch/arm64/boot/dts/amlogic/meson-gxl.dtsi | 12 1 file changed, 12 insertions(+) diff --git a/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi

[RFC PATCH 06/13] ARM64: dts: meson-gxl: Add MMC/SD/SDIO nodes

2016-10-21 Thread Neil Armstrong
Add MMC/SD/SDIO nodes clock attributes for Amlogic Meson GXL. Signed-off-by: Neil Armstrong --- arch/arm64/boot/dts/amlogic/meson-gxl.dtsi | 21 + 1 file changed, 21 insertions(+) diff --git a/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi

[RFC PATCH 12/13] ARM64: dts: meson-gxl-p23x: Add SD/SDIO/MMC and PWM nodes

2016-10-21 Thread Neil Armstrong
Add SD/SDIO/MMC nodes and PWM 32768Hz clock configuration to provide storage and WiFi functionality on the p23x boards. Signed-off-by: Neil Armstrong --- .../boot/dts/amlogic/meson-gxl-s905d-p23x.dtsi | 112 + 1 file changed, 112 insertions(+)

[RFC PATCH 08/13] dwmac-meson8b: add support for phy selection

2016-10-21 Thread Neil Armstrong
The Meson GXL dwmac Glue Layer also provides switching between an external PHY and an internal RMII 10/100 PHY. Add a way to setup the correct PHY switching from a device tree attribute. Currently, the register format is unknown and this is a temporary workaround until a clarification on the

[RFC PATCH 03/13] ARM64: dts: meson-gxl: Add pinctrl nodes

2016-10-21 Thread Neil Armstrong
Add pinctrl nodes and pin definitions for Amlogic Meson GXL. Signed-off-by: Neil Armstrong --- arch/arm64/boot/dts/amlogic/meson-gxl.dtsi | 168 + 1 file changed, 168 insertions(+) diff --git a/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi

[RFC PATCH 09/13] net: phy: Add Meson GXL Internal PHY driver

2016-10-21 Thread Neil Armstrong
Add driver for the Internal RMII PHY found in the Amlogic Meson GXL SoCs. This PHY seems to only implement some standard registers and need some workarounds to provide autoneg values from vendor registers. Some magic values are currently used to configure the PHY, and this a temporary setup

[RFC PATCH 13/13] ARM64: dts: meson-gxl-p23x: Enable IR receiver

2016-10-21 Thread Neil Armstrong
Enable the Infraread Receiver on the p23x board. Signed-off-by: Neil Armstrong --- arch/arm64/boot/dts/amlogic/meson-gxl-s905d-p23x.dtsi | 6 ++ 1 file changed, 6 insertions(+) diff --git a/arch/arm64/boot/dts/amlogic/meson-gxl-s905d-p23x.dtsi

pull request: bluetooth 2016-10-21

2016-10-21 Thread Johan Hedberg
Hi Dave, Here are some more Bluetooth fixes for the 4.9 kernel: - Fix to btwilink driver probe function return value - Power management fix to hci_bcm - Fix to encoding name in scan response data Please let me know if there are any issues pulling. Thanks. Johan --- The following changes

Re: [PATCH 00/13] Netfilter fixes for net

2016-10-21 Thread David Miller
From: Pablo Neira Ayuso Date: Fri, 21 Oct 2016 12:12:10 +0200 > The following patchset contains Netfilter fixes for your net tree, > they are: ... > You can pull these changes from: > > git://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf.git Pulled, thanks!

[patch net-next 6/6] mlxsw: Convert resources into array

2016-10-21 Thread Jiri Pirko
From: Jiri Pirko Since the number of resources is going to get much bigger, ease up the addition by simly defining IDs. Convert the existing structure members to a set array, one for validity, one for values. Introduce a set of getters and setters for easy access.

[patch net-next 5/6] mlxsw: cmd: Push resource query defines to cmd.h

2016-10-21 Thread Jiri Pirko
From: Jiri Pirko Push cmd resource query related defines to cmd.h where they belong. Signed-off-by: Jiri Pirko Reviewed-by: Ido Schimmel --- drivers/net/ethernet/mellanox/mlxsw/cmd.h | 5 +

Re: [PATCH] kexec: Export kexec_in_progress to modules

2016-10-21 Thread David Miller
From: ebied...@xmission.com (Eric W. Biederman) Date: Fri, 21 Oct 2016 00:26:55 -0500 > So as far as I can tell you are advocating for a change to support a > driver doing something that is completely pointless. So no let's not > export this symbol. Please fix the driver to do something less >

[PATCH net-next] lwt: Remove unused len field

2016-10-21 Thread Thomas Graf
The field is initialized by ILA and MPLS but never used. Remove it. Signed-off-by: Thomas Graf --- include/net/lwtunnel.h | 3 +-- net/ipv6/ila/ila_lwt.c | 4 +--- net/mpls/mpls_iptunnel.c | 5 + 3 files changed, 3 insertions(+), 9 deletions(-) diff --git

[patch net-next 4/6] mlxsw: reg: Generare register names automatically

2016-10-21 Thread Jiri Pirko
From: Jiri Pirko Extend the MLXSW_REG_DEFINE macro to store register name in string form. Use this string later on instead of hard coded string values. Signed-off-by: Jiri Pirko Acked-by: Ido Schimmel ---

[patch net-next 2/6] mlxsw: item: Make char *buf arg constant for getters

2016-10-21 Thread Jiri Pirko
From: Jiri Pirko Enforce const for getter buf args. Signed-off-by: Jiri Pirko Acked-by: Ido Schimmel --- drivers/net/ethernet/mellanox/mlxsw/item.h | 31 ++ drivers/net/ethernet/mellanox/mlxsw/pci.c |

[patch net-next 1/6] mlxsw: item: Make struct mlxsw_item args const

2016-10-21 Thread Jiri Pirko
From: Jiri Pirko These should be const, so enforce it. Signed-off-by: Jiri Pirko Acked-by: Ido Schimmel --- drivers/net/ethernet/mellanox/mlxsw/item.h | 27 +++ 1 file changed, 15 insertions(+), 12

[patch net-next 3/6] mlxsw: reg: Use helper macro to define registers

2016-10-21 Thread Jiri Pirko
From: Jiri Pirko Save some code and also prepare to easily carry name in string form. Signed-off-by: Jiri Pirko Acked-by: Ido Schimmel --- drivers/net/ethernet/mellanox/mlxsw/reg.h | 306 +++--- 1 file

[patch net-next 0/6] mlxsw: Driver update

2016-10-21 Thread Jiri Pirko
From: Jiri Pirko Mostly cosmetics and small resource values management rewrite. Jiri Pirko (6): mlxsw: item: Make struct mlxsw_item args const mlxsw: item: Make char *buf arg constant for getters mlxsw: reg: Use helper macro to define registers mlxsw: reg: Generare

Re: [Patch net] net: saving irq context for peernet2id()

2016-10-21 Thread Stephen Smalley
On 10/21/2016 12:47 AM, Cong Wang wrote: > On Thu, Oct 20, 2016 at 4:35 PM, Cong Wang wrote: >> Since you want to test SELinux anyway, please test the attached one. >> > > Finally my kernel config is friendly to SELinux, and now there are several > tests fails: > > >

Re: commit-3ac72b7b63d5 breaks networking on iMX28

2016-10-21 Thread Eric Nelson
Thanks Fabio. On 10/21/2016 06:43 AM, Fabio Estevam wrote: > Hi Eric, > > On Fri, Oct 21, 2016 at 11:39 AM, Eric Nelson wrote: > >> Reading the i.MX28 reference manual, it appears that this SoC doesn't >> have the RACC bit, and I missed removal of the FEC_QUIRK_HAS_RACC flag.

Re: commit-3ac72b7b63d5 breaks networking on iMX28

2016-10-21 Thread Eric Nelson
Hi Henri, On 10/21/2016 06:39 AM, Eric Nelson wrote: > Hi Henri, > > On 10/21/2016 02:19 AM, Henri Roosen wrote: >> Hi, >> >> Unfortunately commit-3ac72b7b63d5 "net: fec: align IP header in >> hardware" breaks networking on an iMX28 system. >> >> The commit seems valid for iMX6, where it is

Re: commit-3ac72b7b63d5 breaks networking on iMX28

2016-10-21 Thread Fabio Estevam
Hi Eric, On Fri, Oct 21, 2016 at 11:39 AM, Eric Nelson wrote: > Reading the i.MX28 reference manual, it appears that this SoC doesn't > have the RACC bit, and I missed removal of the FEC_QUIRK_HAS_RACC flag. On MX28 the register is called HW_ENET_MAC_IPACCRXCONF. I sent a

Re: [PATCH net-next v6 2/3] udp: implement memory accounting helpers

2016-10-21 Thread Eric Dumazet
On Fri, 2016-10-21 at 15:34 +0200, Paolo Abeni wrote: > Updating sk_rmem_alloc would still need an atomic operation, > because it is touched also by the error queue path: we will end up > adding an atomic operation (or two, when reclaiming the fwd allocated > memory) inside the critical section.

Re: commit-3ac72b7b63d5 breaks networking on iMX28

2016-10-21 Thread Eric Nelson
Hi Henri, On 10/21/2016 02:19 AM, Henri Roosen wrote: > Hi, > > Unfortunately commit-3ac72b7b63d5 "net: fec: align IP header in > hardware" breaks networking on an iMX28 system. > > The commit seems valid for iMX6, where it is tested okay and solves the > unaligned accesses. > > On iMX28 I

Re: [PATCH net-next v6 2/3] udp: implement memory accounting helpers

2016-10-21 Thread Paolo Abeni
On Fri, 2016-10-21 at 05:24 -0700, Eric Dumazet wrote: > On Fri, 2016-10-21 at 13:55 +0200, Paolo Abeni wrote: > > Avoid using the generic helpers. > > Use the receive queue spin lock to protect the memory > > accounting operation, both on enqueue and on dequeue. > > > > On dequeue perform

Re: [PATCH net-next v2 6/9] net: use core MTU range checking in virt drivers

2016-10-21 Thread Aaron Conole
"Michael S. Tsirkin" writes: > On Thu, Oct 20, 2016 at 10:37:20PM -0400, Jarod Wilson wrote: >> On Thu, Oct 20, 2016 at 11:23:54PM +0300, Michael S. Tsirkin wrote: >> > On Thu, Oct 20, 2016 at 01:55:21PM -0400, Jarod Wilson wrote: >> ... >> > > diff --git

Re: [PATCH] net: sched: make default fifo qdiscs appear in the dump

2016-10-21 Thread Eric Dumazet
On Fri, 2016-10-21 at 14:56 +0200, Jiri Kosina wrote: > On Fri, 21 Oct 2016, Eric Dumazet wrote: > > > Some of us are dealing with huge HTB hierarchies, so adding default fifo > > in the dump will add more data pumped from the kernel. > > > > BwE [1] for instance dumps qdisc/classes every 5

Re: [PATCH] net: sched: make default fifo qdiscs appear in the dump

2016-10-21 Thread Jiri Kosina
On Fri, 21 Oct 2016, Eric Dumazet wrote: > Some of us are dealing with huge HTB hierarchies, so adding default fifo > in the dump will add more data pumped from the kernel. > > BwE [1] for instance dumps qdisc/classes every 5 seconds. > > I guess we'll need to not pull this patch in our

Re: [PATCH] net: sctp, forbid negative length

2016-10-21 Thread Neil Horman
On Fri, Oct 21, 2016 at 02:13:24PM +0200, Jiri Slaby wrote: > Most of getsockopt handlers in net/sctp/socket.c check len against > sizeof some structure like: > if (len < sizeof(int)) > return -EINVAL; > > On the first look, the check seems to be correct. But since len is

Re: [PATCH net-next v6 2/3] udp: implement memory accounting helpers

2016-10-21 Thread Eric Dumazet
On Fri, 2016-10-21 at 13:55 +0200, Paolo Abeni wrote: > Avoid using the generic helpers. > Use the receive queue spin lock to protect the memory > accounting operation, both on enqueue and on dequeue. > > On dequeue perform partial memory reclaiming, trying to > leave a quantum of forward

  1   2   >