Re: [net-next PATCH v2 1/5] net: virtio dynamically disable/enable LRO

2016-11-22 Thread John Fastabend
On 16-11-21 03:23 PM, Michael S. Tsirkin wrote: > On Sat, Nov 19, 2016 at 06:49:34PM -0800, John Fastabend wrote: >> This adds support for dynamically setting the LRO feature flag. The >> message to control guest features in the backend uses the >> CTRL_GUEST_OFFLOADS msg type. >> >> Signed-off-by:

Re: [net-next PATCH v2 4/5] virtio_net: add dedicated XDP transmit queues

2016-11-22 Thread John Fastabend
On 16-11-21 03:13 PM, Michael S. Tsirkin wrote: > On Sat, Nov 19, 2016 at 06:51:04PM -0800, John Fastabend wrote: >> XDP requires using isolated transmit queues to avoid interference >> with normal networking stack (BQL, NETDEV_TX_BUSY, etc). This patch >> adds a XDP queue per cpu when a XDP progra

Re: linux-next: build warnings after merge of the net-next tree

2016-11-22 Thread Thomas Petazzoni
Hello, On Mon, 21 Nov 2016 17:28:39 -0800, Florian Fainelli wrote: > +Thomas, Gregory, > > On 11/21/2016 05:22 PM, Stephen Rothwell wrote: > [snip] > > > > Introduced by commit > > > > a0627f776a45 ("net: marvell: Allow drivers to be built with COMPILE_TEST") > > > > "a few warnings" is a ma

Re: [net-next PATCH v2 3/5] virtio_net: Add XDP support

2016-11-22 Thread John Fastabend
On 16-11-21 03:20 PM, Michael S. Tsirkin wrote: > On Sat, Nov 19, 2016 at 06:50:33PM -0800, John Fastabend wrote: >> From: Shrijeet Mukherjee >> >> This adds XDP support to virtio_net. Some requirements must be >> met for XDP to be enabled depending on the mode. First it will >> only be supported

net/can: use-after-free in bcm_rx_thr_flush

2016-11-22 Thread Andrey Konovalov
Hi, I've got the following error report while fuzzing the kernel with syzkaller. A reproducer is attached. You may need to run it a few times. On commit 9c763584b7c8911106bb77af7e648bef09af9d80 (4.9-rc6, Nov 20). == BUG: KASAN: use

Re: net/l2tp: use-after-free write in l2tp_ip6_close

2016-11-22 Thread Andrey Konovalov
Hi Guillaume, Sorry, I was on vacation last week, couldn't reply. As I can see a fix was already sent upstream. Thanks! On Thu, Nov 10, 2016 at 6:44 PM, Guillaume Nault wrote: > On Mon, Nov 07, 2016 at 11:35:26PM +0100, Andrey Konovalov wrote: >> Hi, >> >> I've got the following error report w

Re: [PATCH net 1/1] net sched filters: pass netlink message flags in event notification

2016-11-22 Thread Daniel Borkmann
On 11/22/2016 06:23 AM, Cong Wang wrote: On Thu, Nov 17, 2016 at 1:02 PM, Cong Wang wrote: On Wed, Nov 16, 2016 at 2:16 PM, Roman Mashak wrote: Userland client should be able to read an event, and reflect it back to the kernel, therefore it needs to extract complete set of netlink flags. For

mlx5 "syndrome" errors in kernel log

2016-11-22 Thread Jesper Dangaard Brouer
Hi Saeed, I'm seeing below dmesg errors, after pulling net-next at commit e796f49d826aad, before I was not seeing these errors, where my tree was based on top of commit 319b0534b95. mlx5_core :02:00.1: mlx5_cmd_check:698:(pid 8788): ACCESS_REG(0x805) op_mod(0x1) failed, status bad parameter

[PATCH v2] net/phy: add trace events for mdio accesses

2016-11-22 Thread Uwe Kleine-König
Make it possible to generate trace events for mdio read and write accesses. Signed-off-by: Uwe Kleine-König --- Changes since (implicit) v1: - make use of TRACE_EVENT_CONDITION Alternatively to this patch the condition could be + TP_CONDITION(err == 0), but then we'd need in the read c

Re: [RFC PATCH net v2 2/3] dt: bindings: add ethernet phy eee-disable-advert option documentation

2016-11-22 Thread Jerome Brunet
On Mon, 2016-11-21 at 21:35 -0800, Florian Fainelli wrote: > Le 21/11/2016 à 08:47, Andrew Lunn a écrit : > > > > > > > > What I did not realize when doing this patch for the realtek > > > driver is > > > that there is already 6 valid modes defined in the kernel > > > > > > #define MDIO_EEE_100T

net/icmp: null-ptr-deref in icmp6_send

2016-11-22 Thread Andrey Konovalov
Hi, I've got the following error report while fuzzing the kernel with syzkaller. It seems that skb_dst(skb) may end up being NULL. As far as I can see the bug was introduced in commit 5d41ce29e ("net: icmp6_send should use dst dev to determine L3 domain"). ICMP v4 probaly has similar issue due t

[patch net-next 0/2] mlxsw: core: Implement thermal zone

2016-11-22 Thread Jiri Pirko
From: Jiri Pirko Implement thermal zone for mlxsw based HW. The first patch is just a register dependency for the second patch. Ivan Vecera (1): mlxsw: core: Implement thermal zone Jiri Pirko (1): mlxsw: reg: Add Management Fan Speed Limit register drivers/net/ethernet/mellanox/mlxsw/Kcon

[patch net-next 1/2] mlxsw: reg: Add Management Fan Speed Limit register

2016-11-22 Thread Jiri Pirko
From: Jiri Pirko The MFSL register is used to configure the fan speed event / interrupt notification mechanism. Fan speed threshold are defined for both under-speed and over-speed. Signed-off-by: Jiri Pirko Reviewed-by: Ido Schimmel --- drivers/net/ethernet/mellanox/mlxsw/reg.h | 49 +

[patch net-next 2/2] mlxsw: core: Implement thermal zone

2016-11-22 Thread Jiri Pirko
From: Ivan Vecera Implement thermal zone for mlxsw based HW. It uses temperature sensor provided by ASIC (the same as mlxsw hwmon interface) to report current temp to thermal core. The ASIC's PWM is then used to control speed of system fans registered as cooling devices. Signed-off-by: Ivan Vece

[PATCH] net: dsa: mv88e6xxx: add MV88E6097 switch

2016-11-22 Thread Stefan Eichenberger
Add support for the MV88E6097 switch. The change was tested on an Armada based platform with a MV88E6097 switch. Signed-off-by: Stefan Eichenberger --- drivers/net/dsa/mv88e6xxx/chip.c | 19 +++ drivers/net/dsa/mv88e6xxx/mv88e6xxx.h | 2 ++ 2 files changed, 21 insertions(+)

[PATCH] net: dsa: mv88e6xxx: egress all frames

2016-11-22 Thread Stefan Eichenberger
Egress multicast and egress unicast is only enabled for CPU/DSA ports but for switching operation it seems it should be enabled for all ports. Do I miss something here? I did the following test: brctl addbr br0 brctl addif br0 lan0 brctl addif br0 lan1 In this scenario the unicast and multicast p

[PATCH v8] mac80211: multicast to unicast conversion

2016-11-22 Thread Michael Braun
Add the ability for an AP (and associated VLANs) to perform multicast-to-unicast conversion for ARP, IPv4 and IPv6 frames (possibly within 802.1Q). If enabled, such frames are to be sent to each station separately, with the DA replaced by their own MAC address rather than the group address. Note t

[PATCH v5] iproute2: macvlan: add "source" mode

2016-11-22 Thread Michael Braun
Adjusting iproute2 utility to support new macvlan link type mode called "source". Example of commands that can be applied: ip link add link eth0 name macvlan0 type macvlan mode source ip link set link dev macvlan0 type macvlan macaddr add 00:11:11:11:11:11 ip link set link dev macvlan0 type

[PATCH] net: ipv6: avoid errors due to per-cpu atomic alloc

2016-11-22 Thread Mike Manning
Bursts of failures may occur when adding IPv6 routes via Netlink to the kernel when testing under scale (e.g. 500 routes lost out of 1M). The reason is that percpu.c:pcpu_balance_workfn() is not guaranteed to have extended the area map in time for the atomic allocation using percpu.c: pcpu_alloc()

[PATCH] fec: Always write MAC address to controller register

2016-11-22 Thread Daniel Krüger
On non-FEC_QUIRK_ENET_MAC types the MAC address needs to be set in FEC during initialisation, if not done by bootloader already. Especially random MACs or MAC addresses provided by kernel parameter must be set. Signed-off-by: Daniel Krueger --- drivers/net/ethernet/freescale/fec_main.c | 14 ++

net/udp: bug in skb_pull_rcsum

2016-11-22 Thread Andrey Konovalov
Hi, I've got the following error report while fuzzing the kernel with syzkaller. A reproducer is attached. On commit 9c763584b7c8911106bb77af7e648bef09af9d80 (4.9-rc6, Nov 20). [ cut here ] kernel BUG at net/core/skbuff.c:3029! invalid opcode: [#1] SMP KASAN Modules

Re: mlx5 "syndrome" errors in kernel log

2016-11-22 Thread Saeed Mahameed
On Tue, Nov 22, 2016 at 11:59 AM, Jesper Dangaard Brouer wrote: > > Hi Saeed, > > I'm seeing below dmesg errors, after pulling net-next at commit > e796f49d826aad, before I was not seeing these errors, where my tree was > based on top of commit 319b0534b95. > > mlx5_core :02:00.1: mlx5_cmd_che

Re: [PATCH] net: ipv6: avoid errors due to per-cpu atomic alloc

2016-11-22 Thread Hannes Frederic Sowa
On 22.11.2016 11:34, Mike Manning wrote: > Bursts of failures may occur when adding IPv6 routes via Netlink to the > kernel when testing under scale (e.g. 500 routes lost out of 1M). The > reason is that percpu.c:pcpu_balance_workfn() is not guaranteed to have > extended the area map in time for th

Re: [PATCH] ipv6:ipv6_pinfo dereferenced after NULL check

2016-11-22 Thread Hannes Frederic Sowa
On 22.11.2016 07:27, Manjeet Pawar wrote: > From: Rohit Thapliyal > > np checked for NULL and then dereferenced. It should be modified > for NULL case. > > Signed-off-by: Rohit Thapliyal > Signed-off-by: Manjeet Pawar > --- > net/ipv6/ip6_output.c | 9 + > 1 file changed, 5 insertions

Re: [RFC net-next 0/3] net: bridge: Allow CPU port configuration

2016-11-22 Thread Jiri Pirko
Mon, Nov 21, 2016 at 08:09:22PM CET, f.faine...@gmail.com wrote: >Hi all, > >This patch series allows using the bridge master interface to configure >an Ethernet switch port's CPU/management port with different VLAN attributes >than >those of the bridge downstream ports/members. > >Jiri, Ido, Andr

Re: [PATCH net 1/2] r8152: fix the sw rx checksum is unavailable

2016-11-22 Thread Mark Lord
On 16-11-18 07:03 AM, Mark Lord wrote: On 16-11-18 02:57 AM, Hayes Wang wrote: .. Besides, the maximum data length which the RTL8152 would send to the host is 16KB. That is, if the agg_buf_sz is 16KB, the host wouldn't split it. However, you still see problems for it. How does the RTL8152 know

Re: [PATCH] net: ipv6: avoid errors due to per-cpu atomic alloc

2016-11-22 Thread Mike Manning
On 11/22/2016 12:18 PM, Hannes Frederic Sowa wrote: > On 22.11.2016 11:34, Mike Manning wrote: >> Bursts of failures may occur when adding IPv6 routes via Netlink to the >> kernel when testing under scale (e.g. 500 routes lost out of 1M). The >> reason is that percpu.c:pcpu_balance_workfn() is not

[PATCH] iproute2: Nr. of packets and octets for macsec tx stats were swapped.

2016-11-22 Thread Daniel . Hopf
Signed-off-by: Daniel Hopf --- ip/ipmacsec.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/ip/ipmacsec.c b/ip/ipmacsec.c index c9252bb..aa89a00 100644 --- a/ip/ipmacsec.c +++ b/ip/ipmacsec.c @@ -634,10 +634,10 @@ static void print_one_stat(const char **names, struct

Re: [PATCH] iproute2: Nr. of packets and octets for macsec tx stats were swapped.

2016-11-22 Thread Sabrina Dubroca
Hi Daniel, Thanks for fixing this. I noticed it some time ago but it seems I forgot to send the patch :( Acked-by: Sabrina Dubroca Your subject line should be: Subject: [PATCH iproute2] macsec: Nr.of packets and octets for macsec tx stats were swapped. with "iproute2" between the brackets.

Re: Synopsys Ethernet QoS Driver

2016-11-22 Thread Joao Pinto
Hi Lars and Peppe, On 21-11-2016 16:11, Joao Pinto wrote: > On 21-11-2016 15:43, Lars Persson wrote: >> >> >>> 21 nov. 2016 kl. 16:06 skrev Joao Pinto : >>> On 21-11-2016 14:25, Giuseppe CAVALLARO wrote: > On 11/21/2016 2:28 PM, Lars Persson wrote: > > >> 21 nov. 2016 kl. 13:

[PATCH net] net/mlx4_en: Free netdev resources under state lock

2016-11-22 Thread Tariq Toukan
Make sure mlx4_en_free_resources is called under the netdev state lock. This is needed since RCU dereference of XDP prog should be protected. Fixes: 326fe02d1ed6 ("net/mlx4_en: protect ring->xdp_prog with rcu_read_lock") Signed-off-by: Tariq Toukan Reported-by: Sagi Grimberg CC: Brenden Blanco

[PATCH net-next] marvell: mark mvneta and mvpp2 32-bit only

2016-11-22 Thread Arnd Bergmann
Both of these drivers won't work on 64-bit architectures unless they are redesigned, since they store a virtual address pointer in a 32-bit field of the descriptors: drivers/net/ethernet/marvell/mvneta_bm.c: In function 'mvneta_bm_construct': drivers/net/ethernet/marvell/mvneta_bm.c:103:16: error:

[PATCH net-next] net/sched: cls_flower: verify root pointer before dereferncing it

2016-11-22 Thread Roi Dayan
tp->root is being allocated in init() time and kfreed in destroy() however it is being dereferenced in classify() path. We could be in classify() path after destroy() was called and thus tp->root is null. Verifying if tp->root is null in classify() path is enough because it's being freed with kf

Re: [PATCH v2] net/phy: add trace events for mdio accesses

2016-11-22 Thread Steven Rostedt
On Tue, 22 Nov 2016 11:01:27 +0100 Uwe Kleine-König wrote: > diff --git a/include/trace/events/mdio.h b/include/trace/events/mdio.h > new file mode 100644 > index ..468e2d095d19 > --- /dev/null > +++ b/include/trace/events/mdio.h > @@ -0,0 +1,42 @@ > +#undef TRACE_SYSTEM > +#define TR

Re: [v5,1/5] soc: qcom: smem_state: Fix include for ERR_PTR()

2016-11-22 Thread Valo, Kalle
Bjorn Andersson writes: > On Wed 16 Nov 10:49 PST 2016, Kalle Valo wrote: > >> Bjorn Andersson wrote: >> > The correct include file for getting errno constants and ERR_PTR() is >> > linux/err.h, rather than linux/errno.h, so fix the include. >> > >> > Fixes: e8b123e60084 ("soc: qcom: smem_state

Re: [PATCHv2 net-next 00/11] Start adding support for mv88e6390

2016-11-22 Thread David Miller
From: Andrew Lunn Date: Mon, 21 Nov 2016 23:26:54 +0100 > This is the first patchset implementing support for the mv88e6390 > family. This is a new generation of switch devices and has numerous > incompatible changes to the registers. These patches allow the switch > to the detected during probe

Re: [net-next PATCH v2 3/5] virtio_net: Add XDP support

2016-11-22 Thread Michael S. Tsirkin
On Tue, Nov 22, 2016 at 12:27:03AM -0800, John Fastabend wrote: > On 16-11-21 03:20 PM, Michael S. Tsirkin wrote: > > On Sat, Nov 19, 2016 at 06:50:33PM -0800, John Fastabend wrote: > >> From: Shrijeet Mukherjee > >> > >> This adds XDP support to virtio_net. Some requirements must be > >> met for

Re: [net-next PATCH v2 4/5] virtio_net: add dedicated XDP transmit queues

2016-11-22 Thread Michael S. Tsirkin
On Tue, Nov 22, 2016 at 12:17:40AM -0800, John Fastabend wrote: > On 16-11-21 03:13 PM, Michael S. Tsirkin wrote: > > On Sat, Nov 19, 2016 at 06:51:04PM -0800, John Fastabend wrote: > >> XDP requires using isolated transmit queues to avoid interference > >> with normal networking stack (BQL, NETDEV

Re: [PATCH] net: dsa: mv88e6xxx: egress all frames

2016-11-22 Thread Andrew Lunn
On Tue, Nov 22, 2016 at 11:39:44AM +0100, Stefan Eichenberger wrote: > Egress multicast and egress unicast is only enabled for CPU/DSA ports > but for switching operation it seems it should be enabled for all ports. > Do I miss something here? > > I did the following test: > brctl addbr br0 > brct

Re: [patch net-next 0/2] mlxsw: core: Implement thermal zone

2016-11-22 Thread David Miller
From: Jiri Pirko Date: Tue, 22 Nov 2016 11:24:11 +0100 > Implement thermal zone for mlxsw based HW. > The first patch is just a register dependency for the second patch. Looks good, series applied, thanks.

Re: [PATCH net-next] net/sched: cls_flower: verify root pointer before dereferncing it

2016-11-22 Thread Jiri Pirko
Tue, Nov 22, 2016 at 03:25:26PM CET, r...@mellanox.com wrote: >tp->root is being allocated in init() time and kfreed in destroy() >however it is being dereferenced in classify() path. > >We could be in classify() path after destroy() was called and thus >tp->root is null. Verifying if tp->root is

Re: [PATCH] ipv6:ipv6_pinfo dereferenced after NULL check

2016-11-22 Thread David Miller
From: Hannes Frederic Sowa Date: Tue, 22 Nov 2016 13:26:45 +0100 > On 22.11.2016 07:27, Manjeet Pawar wrote: >> From: Rohit Thapliyal >> >> np checked for NULL and then dereferenced. It should be modified >> for NULL case. >> >> Signed-off-by: Rohit Thapliyal >> Signed-off-by: Manjeet Pawar

Re: [PATCH] net: dsa: mv88e6xxx: add MV88E6097 switch

2016-11-22 Thread Andrew Lunn
On Tue, Nov 22, 2016 at 11:28:36AM +0100, Stefan Eichenberger wrote: > Add support for the MV88E6097 switch. The change was tested on an Armada > based platform with a MV88E6097 switch. Hi Stefan Please can you based your patches on net-next. You will then find the ops structure has gained a few

Re: [PATCH] fec: Always write MAC address to controller register

2016-11-22 Thread David Miller
This change is already in the tree via commit b82d44d78480faff7456e9e0999acb9d38666057 made nearly two months ago: commit b82d44d78480faff7456e9e0999acb9d38666057 Author: Gavin Schenk Date: Fri Sep 30 11:46:10 2016 +0200 net: fec: set mac address unconditionally If the mac addres

Re: [PATCH net-next] marvell: mark mvneta and mvpp2 32-bit only

2016-11-22 Thread Gregory CLEMENT
Hi Arnd, On mar., nov. 22 2016, Arnd Bergmann wrote: > Both of these drivers won't work on 64-bit architectures unless they > are redesigned, since they store a virtual address pointer in a 32-bit > field of the descriptors: > > drivers/net/ethernet/marvell/mvneta_bm.c: In function 'mvneta_bm_

Re: [PATCH v2] net/phy: add trace events for mdio accesses

2016-11-22 Thread Andrew Lunn
On Tue, Nov 22, 2016 at 09:55:21AM -0500, Steven Rostedt wrote: > On Tue, 22 Nov 2016 11:01:27 +0100 > Uwe Kleine-König wrote: > > > diff --git a/include/trace/events/mdio.h b/include/trace/events/mdio.h > > new file mode 100644 > > index ..468e2d095d19 > > --- /dev/null > > +++ b/inc

Re: wl1251 & mac address & calibration data

2016-11-22 Thread Michal Kazior
On 21 November 2016 at 16:51, Pali Rohár wrote: > On Friday 11 November 2016 18:20:50 Pali Rohár wrote: >> Hi! I will open discussion about mac address and calibration data for >> wl1251 wireless chip again... >> >> Problem: Mac address & calibration data for wl1251 chip on Nokia N900 >> are store

Re: [PATCH net-next] marvell: mark mvneta and mvpp2 32-bit only

2016-11-22 Thread David Miller
From: Arnd Bergmann Date: Tue, 22 Nov 2016 15:21:22 +0100 > Both of these drivers won't work on 64-bit architectures unless they > are redesigned, since they store a virtual address pointer in a 32-bit > field of the descriptors: > > drivers/net/ethernet/marvell/mvneta_bm.c: In function 'mvneta_

Re: [RFC net-next 0/3] net: bridge: Allow CPU port configuration

2016-11-22 Thread Vivien Didelot
Hi Florian, Florian Fainelli writes: > This patch series allows using the bridge master interface to configure > an Ethernet switch port's CPU/management port with different VLAN attributes > than > those of the bridge downstream ports/members. > > Jiri, Ido, Andrew, Vivien, please review the i

Re: wl1251 & mac address & calibration data

2016-11-22 Thread Pali Rohár
On Tuesday 22 November 2016 16:22:57 Michal Kazior wrote: > On 21 November 2016 at 16:51, Pali Rohár wrote: > > On Friday 11 November 2016 18:20:50 Pali Rohár wrote: > >> Hi! I will open discussion about mac address and calibration data for > >> wl1251 wireless chip again... > >> > >> Problem: Mac

Re: [PATCH net-next] net/sched: cls_flower: verify root pointer before dereferncing it

2016-11-22 Thread David Miller
From: Jiri Pirko Date: Tue, 22 Nov 2016 15:48:44 +0100 > Tue, Nov 22, 2016 at 03:25:26PM CET, r...@mellanox.com wrote: >>tp->root is being allocated in init() time and kfreed in destroy() >>however it is being dereferenced in classify() path. >> >>We could be in classify() path after destroy() wa

Re: [PATCH v3 3/5] net: asix: Fix AX88772x resume failures

2016-11-22 Thread Jon Hunter
Hi Allan, On 18/11/16 15:09, Jon Hunter wrote: > Hi Allan, > > On 14/11/16 09:45, ASIX_Allan [Office] wrote: >> Hi Jon, >> >> Please help to double check if the USB host controller of your Terga >> platform had been powered OFF while running the ax88772_suspend() routine or >> not? > > Sorry fo

[PATCH] net: mvneta: Only disable mvneta_bm for 64-bits

2016-11-22 Thread Gregory CLEMENT
Actually only the mvneta_bm support is not 64-bits compatible. The mvneta code itself can run on 64-bits architecture. Signed-off-by: Gregory CLEMENT --- drivers/net/ethernet/marvell/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/marvell/Kconfi

Re: [RFC net-next 1/3] net: bridge: Allow bridge master device to configure switch CPU port

2016-11-22 Thread Vivien Didelot
Hi Florian, Florian Fainelli writes: > bridge vlan add vid 2 dev br0 self > -> CPU port gets programmed > bridge vlan add vid 2 dev port0 > -> port0 (switch port 0) gets programmed Although this is not specific to this patch, I'd like to point out that this seems not to be the behav

[PATCH v3] net/phy: add trace events for mdio accesses

2016-11-22 Thread Uwe Kleine-König
Make it possible to generate trace events for mdio read and write accesses. Signed-off-by: Uwe Kleine-König --- drivers/net/phy/mdio_bus.c | 11 +++ include/trace/events/mdio.h | 42 ++ 2 files changed, 53 insertions(+) create mode 100644 include

Re: [PATCH] fec: Always write MAC address to controller register

2016-11-22 Thread Daniel Krüger
Sorry, I missed it. But thanks for the fast answer. cu, Daniel Am 22.11.2016 um 16:07 schrieb David Miller: > > This change is already in the tree via commit > b82d44d78480faff7456e9e0999acb9d38666057 made nearly > two months ago: > [...]

Re: [PATCH v3] net/phy: add trace events for mdio accesses

2016-11-22 Thread Steven Rostedt
On Tue, 22 Nov 2016 16:47:11 +0100 Uwe Kleine-König wrote: > Make it possible to generate trace events for mdio read and write accesses. > > Signed-off-by: Uwe Kleine-König For the tracing side. Acked-by: Steven Rostedt -- Steve

[PATCH net] ipv6: bump genid when the IFA_F_TENTATIVE flag is clear

2016-11-22 Thread Paolo Abeni
When an ipv6 address has the tentative flag set, it can't be used as source for egress traffic, while the associated route, if any, can be looked up and even stored into some dst_cache. In the latter scenario, the source ipv6 address selected and stored in the cache is most probably wrong (e.g. wi

Re: [PATCH net 1/1] net sched filters: pass netlink message flags in event notification

2016-11-22 Thread Roman Mashak
Daniel Borkmann writes: > On 11/22/2016 06:23 AM, Cong Wang wrote: >> On Thu, Nov 17, 2016 at 1:02 PM, Cong Wang wrote: >>> On Wed, Nov 16, 2016 at 2:16 PM, Roman Mashak wrote: Userland client should be able to read an event, and reflect it back to the kernel, therefore it needs to ex

Re: [PATCH net-next] net/sched: cls_flower: verify root pointer before dereferncing it

2016-11-22 Thread Daniel Borkmann
[ + John ] On 11/22/2016 03:48 PM, Jiri Pirko wrote: Tue, Nov 22, 2016 at 03:25:26PM CET, r...@mellanox.com wrote: tp->root is being allocated in init() time and kfreed in destroy() however it is being dereferenced in classify() path. We could be in classify() path after destroy() was called a

[PATCH net-next] net: mvneta: Only disable mvneta_bm for 64-bits

2016-11-22 Thread Gregory CLEMENT
Actually only the mvneta_bm support is not 64-bits compatible. The mvneta code itself can run on 64-bits architecture. Signed-off-by: Gregory CLEMENT --- drivers/net/ethernet/marvell/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/marvell/Kconfi

Re: [PATCH] net: mvneta: Only disable mvneta_bm for 64-bits

2016-11-22 Thread Gregory CLEMENT
Hi, On mar., nov. 22 2016, Gregory CLEMENT wrote: > Actually only the mvneta_bm support is not 64-bits compatible. > The mvneta code itself can run on 64-bits architecture. I have just realized that my topic prefix was wrong (net-next was missing), I am send a new email with the correct pref

Re: [PATCH net-next] net/sched: cls_flower: verify root pointer before dereferncing it

2016-11-22 Thread Jiri Pirko
Tue, Nov 22, 2016 at 05:04:11PM CET, dan...@iogearbox.net wrote: >[ + John ] > >On 11/22/2016 03:48 PM, Jiri Pirko wrote: >> Tue, Nov 22, 2016 at 03:25:26PM CET, r...@mellanox.com wrote: >> > tp->root is being allocated in init() time and kfreed in destroy() >> > however it is being dereferenced in

Re: [PATCH net-next] net/sched: cls_flower: verify root pointer before dereferncing it

2016-11-22 Thread Jiri Pirko
Tue, Nov 22, 2016 at 04:37:42PM CET, da...@davemloft.net wrote: >From: Jiri Pirko >Date: Tue, 22 Nov 2016 15:48:44 +0100 > >> Tue, Nov 22, 2016 at 03:25:26PM CET, r...@mellanox.com wrote: >>>tp->root is being allocated in init() time and kfreed in destroy() >>>however it is being dereferenced in c

Re: wl1251 & mac address & calibration data

2016-11-22 Thread Michal Kazior
On 22 November 2016 at 16:31, Pali Rohár wrote: > On Tuesday 22 November 2016 16:22:57 Michal Kazior wrote: >> On 21 November 2016 at 16:51, Pali Rohár wrote: >> > On Friday 11 November 2016 18:20:50 Pali Rohár wrote: >> >> Hi! I will open discussion about mac address and calibration data for >>

Re: [PATCH net-next] net: mvneta: Only disable mvneta_bm for 64-bits

2016-11-22 Thread David Miller
From: Gregory CLEMENT Date: Tue, 22 Nov 2016 17:00:37 +0100 > Actually only the mvneta_bm support is not 64-bits compatible. > The mvneta code itself can run on 64-bits architecture. > > Signed-off-by: Gregory CLEMENT No it cannot, it emits warnings because it casts pointers to and from 32-bit

Re: [PATCH] iproute2: Nr. of packets and octets for macsec tx stats were swapped.

2016-11-22 Thread Rami Rosen
Hi, Daniel Acked-by: Rami Rosen Agreed about Sabrina comments about adding iproute2 and about the newlines. Regards, R

Re: [PATCH net-next] net: mvneta: Only disable mvneta_bm for 64-bits

2016-11-22 Thread Gregory CLEMENT
Hi David, On mar., nov. 22 2016, David Miller wrote: > From: Gregory CLEMENT > Date: Tue, 22 Nov 2016 17:00:37 +0100 > >> Actually only the mvneta_bm support is not 64-bits compatible. >> The mvneta code itself can run on 64-bits architecture. >> >> Signed-off-by: Gregory CLEMENT > > No it

Re: net/udp: bug in skb_pull_rcsum

2016-11-22 Thread Eric Dumazet
On Tue, Nov 22, 2016 at 3:58 AM, Andrey Konovalov wrote: > Hi, > > I've got the following error report while fuzzing the kernel with syzkaller. > > A reproducer is attached. > > On commit 9c763584b7c8911106bb77af7e648bef09af9d80 (4.9-rc6, Nov 20). > > [ cut here ] > kernel

[PATCH net-next 0/4] Extend mvneta to support Armada 3700 (ARM 64)

2016-11-22 Thread Gregory CLEMENT
Hi, This series enable the use of mvneta driver on the Armada 3700 SoCs. Armada 3700 is a new ARMv8 SoC from Marvell using same network controller as older Armada 370/38x/XP. Besides the changes needed to be used on 64-bits architecture done in the 1st patch, there are also few difference related

[PATCH net-next 1/4] net: mvneta: Convert to be 64 bits compatible

2016-11-22 Thread Gregory CLEMENT
From: Marcin Wojtas Prepare the mvneta driver in order to be usable on the 64 bits platform such as the Armada 3700. [gregory.clem...@free-electrons.com]: this patch was extract from a larger one to ease review and maintenance. Signed-off-by: Marcin Wojtas Signed-off-by: Gregory CLEMENT ---

[PATCH net-next 2/4] net: mvneta: Only disable mvneta_bm for 64-bits

2016-11-22 Thread Gregory CLEMENT
Actually only the mvneta_bm support is not 64-bits compatible. The mvneta code itself can run on 64-bits architecture. Signed-off-by: Gregory CLEMENT --- drivers/net/ethernet/marvell/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/marvell/Kconfi

[PATCH net-next 4/4] ARM64: dts: marvell: Add network support for Armada 3700

2016-11-22 Thread Gregory CLEMENT
Add neta nodes for network support both in device tree for the SoC and the board. Signed-off-by: Gregory CLEMENT --- arch/arm64/boot/dts/marvell/armada-3720-db.dts | 23 +++ arch/arm64/boot/dts/marvell/armada-37xx.dtsi | 23 +++ 2 files changed, 46 inser

[PATCH net-next 3/4] net: mvneta: Add network support for Armada 3700 SoC

2016-11-22 Thread Gregory CLEMENT
From: Marcin Wojtas Armada 3700 is a new ARMv8 SoC from Marvell using same network controller as older Armada 370/38x/XP. There are however some differences that needed taking into account when adding support for it: * open default MBUS window to 4GB of DRAM - Armada 3700 SoC's Mbus configurat

[PATCH v2] net: dsa: mv88e6xxx: add MV88E6097 switch

2016-11-22 Thread Stefan Eichenberger
Add support for the MV88E6097 switch. The change was tested on an Armada based platform with a MV88E6097 switch. Signed-off-by: Stefan Eichenberger --- drivers/net/dsa/mv88e6xxx/chip.c | 26 ++ drivers/net/dsa/mv88e6xxx/mv88e6xxx.h | 2 ++ 2 files changed, 28 insert

Re: [RFC 02/10] IB/hfi-vnic: Virtual Network Interface Controller (VNIC) Bus driver

2016-11-22 Thread Jason Gunthorpe
On Mon, Nov 21, 2016 at 05:53:04PM -0800, Vishwanathapura, Niranjana wrote: > There are many example drivers in kernel which are using bus_register() in > an initcall. There really are not, certainly not in major subsystems. > We could add a custom Interface between HFI1 driver and hfi_vnic drive

Re: [RFC net-next 2/3] net: dsa: Propagate VLAN add/del to CPU port(s)

2016-11-22 Thread Vivien Didelot
Hi Florian, Open question: will we need to do the same for FDB and MDB objects? Florian Fainelli writes: > Now that the bridge layer can call into switchdev to signal programming > requests targeting the bridge master device itself, allow the switch > drivers to implement separate programming o

[PATCH net] udplite: call proper backlog handlers

2016-11-22 Thread Eric Dumazet
From: Eric Dumazet In commits 93821778def10 ("udp: Fix rcv socket locking") and f7ad74fef3af ("net/ipv6/udp: UDP encapsulation: break backlog_rcv into __udpv6_queue_rcv_skb") UDP backlog handlers were renamed, but UDPlite was forgotten. This leads to crashes if UDPlite header is pulled twice, wh

Re: [PATCHv2 net-next 00/11] Start adding support for mv88e6390

2016-11-22 Thread Vivien Didelot
Hi, Andrew Lunn writes: > This is the first patchset implementing support for the mv88e6390 > family. This is a new generation of switch devices and has numerous > incompatible changes to the registers. These patches allow the switch > to the detected during probe, and makes the statistics unit

Re: [PATCH v9 0/8] thunderbolt: Introducing Thunderbolt(TM) Networking

2016-11-22 Thread Simon Guinot
On Fri, Nov 18, 2016 at 12:20:07PM +0100, Simon Guinot wrote: > On Fri, Nov 18, 2016 at 08:48:36AM +, Levy, Amir (Jer) wrote: > > On Tue, Nov 15 2016, 12:59 PM, Simon Guinot wrote: > > > On Wed, Nov 09, 2016 at 03:42:53PM +, Levy, Amir (Jer) wrote: > > > > On Wed, Nov 9 2016, 04:36 PM, Simo

Re: net/can: use-after-free in bcm_rx_thr_flush

2016-11-22 Thread Oliver Hartkopp
Hi Andrey, thanks for the report. Although I can't see the issue in the code ... On 11/22/2016 10:22 AM, Andrey Konovalov wrote: == BUG: KASAN: use-after-free in bcm_rx_thr_flush+0x284/0x2b0 Read of size 1 at addr 88006c1faae

RE: [PATCH v9 0/8] thunderbolt: Introducing Thunderbolt(TM) Networking

2016-11-22 Thread Mario.Limonciello
> Here are a couple of additional questions: > > - When the network interface is created, there is no IP address > assigned (or negotiated ?) on the Linux side. But it is done on the > MacOS side. And in the Linux kernel logs I can also read the message: > "ready for ThunderboltIP negotiatio

Re: net/can: use-after-free in bcm_rx_thr_flush

2016-11-22 Thread Andrey Konovalov
On Tue, Nov 22, 2016 at 6:29 PM, Oliver Hartkopp wrote: > Hi Andrey, > > thanks for the report. > > Although I can't see the issue in the code ... > > On 11/22/2016 10:22 AM, Andrey Konovalov wrote: > >> == >> BUG: KASAN: use-after-fr

Re: [RFC net-next 0/3] net: bridge: Allow CPU port configuration

2016-11-22 Thread Andrew Lunn
Hi Ido > First of all, I want to be sure that when we say "CPU port", we're > talking about the same thing. In mlxsw, the CPU port is a pipe between > the device and the host, through which all packets trapped to the host > go through. So, when a packet is trapped, the driver reads its Rx > descr

Re: [RFC net-next 0/3] net: bridge: Allow CPU port configuration

2016-11-22 Thread Ido Schimmel
Hi Florian, On Mon, Nov 21, 2016 at 11:09:22AM -0800, Florian Fainelli wrote: > Hi all, > > This patch series allows using the bridge master interface to configure > an Ethernet switch port's CPU/management port with different VLAN attributes > than > those of the bridge downstream ports/members

Re: wl1251 & mac address & calibration data

2016-11-22 Thread Pali Rohár
On Tuesday 22 November 2016 17:14:28 Michal Kazior wrote: > On 22 November 2016 at 16:31, Pali Rohár wrote: > > On Tuesday 22 November 2016 16:22:57 Michal Kazior wrote: > >> On 21 November 2016 at 16:51, Pali Rohár > >> wrote: > >> > On Friday 11 November 2016 18:20:50 Pali Rohár wrote: > >> >>

Re: net/icmp: null-ptr-deref in icmp6_send

2016-11-22 Thread Cong Wang
On Tue, Nov 22, 2016 at 2:23 AM, Andrey Konovalov wrote: > Hi, > > I've got the following error report while fuzzing the kernel with syzkaller. > > It seems that skb_dst(skb) may end up being NULL. > > As far as I can see the bug was introduced in commit 5d41ce29e ("net: > icmp6_send should use ds

Re: [RFC net-next 0/3] net: bridge: Allow CPU port configuration

2016-11-22 Thread Florian Fainelli
On 11/22/2016 09:41 AM, Ido Schimmel wrote: > Hi Florian, > > On Mon, Nov 21, 2016 at 11:09:22AM -0800, Florian Fainelli wrote: >> Hi all, >> >> This patch series allows using the bridge master interface to configure >> an Ethernet switch port's CPU/management port with different VLAN attributes

[PATCH/RFC -next] net: phy: Fix double free in phy_detach()

2016-11-22 Thread Geert Uytterhoeven
During "poweroff" on sh73a0/kzm9g: WARNING: CPU: 0 PID: 1271 at drivers/base/devres.c:889 phy_detach+0x44/0x60 Modules linked in: CPU: 0 PID: 1271 Comm: halt Not tainted 4.9.0-rc6-kzm9g-05637-gb090128865050239 #823 Hardware name: Generic SH73A0 (Flattened Device Tree) [] (unwi

[PATCH net] bnxt: do not busy-poll when link is down

2016-11-22 Thread Andy Gospodarek
When busy polling while a link is down (during a link-flap test), TX timeouts were observed as well as the following messages in the ring buffer: bnxt_en 0008:01:00.2 enP8p1s0f2d2: Resp cmpl intr err msg: 0x51 bnxt_en 0008:01:00.2 enP8p1s0f2d2: hwrm_ring_free tx failed. rc:-1 bnxt_en 0008:01:00.2

List pre vas

2016-11-22 Thread Paní KLeung
Ahoj. Dobre rano, a jak to delate? Jen rychly jedno, je tu oficialni prilezitosti bych chtel diskutovat s vami soukrome. Ocenil bych vasi rychlou reakci tady na mem osobnim soukromeho e-mailu nize pro dalsi komunikaci. S pratelskym pozdravem, Paní Ko May Leung email: lngkoma...@gmail.

Re: [PATCH net] bnxt: do not busy-poll when link is down

2016-11-22 Thread Eric Dumazet
On Tue, 2016-11-22 at 13:14 -0500, Andy Gospodarek wrote: > When busy polling while a link is down (during a link-flap test), TX > timeouts were observed as well as the following messages in the ring > buffer: > > bnxt_en 0008:01:00.2 enP8p1s0f2d2: Resp cmpl intr err msg: 0x51 > bnxt_en 0008:01:00

Re: [PATCH] net: dsa: mv88e6xxx: egress all frames

2016-11-22 Thread Stefan Eichenberger
Hi Andrew On Tue, Nov 22, 2016 at 04:03:30PM +0100, Andrew Lunn wrote: > On Tue, Nov 22, 2016 at 11:39:44AM +0100, Stefan Eichenberger wrote: > > Egress multicast and egress unicast is only enabled for CPU/DSA ports > > but for switching operation it seems it should be enabled for all ports. > > D

Re: [PATCH net] bnxt: do not busy-poll when link is down

2016-11-22 Thread Michael Chan
On Tue, Nov 22, 2016 at 10:38 AM, Eric Dumazet wrote: > On Tue, 2016-11-22 at 13:14 -0500, Andy Gospodarek wrote: >> When busy polling while a link is down (during a link-flap test), TX >> timeouts were observed as well as the following messages in the ring >> buffer: >> >> bnxt_en 0008:01:00.2 en

Re: [PATCH] net: dsa: mv88e6xxx: egress all frames

2016-11-22 Thread Andrew Lunn
On Tue, Nov 22, 2016 at 07:37:33PM +0100, Stefan Eichenberger wrote: > Hi Andrew > > On Tue, Nov 22, 2016 at 04:03:30PM +0100, Andrew Lunn wrote: > > On Tue, Nov 22, 2016 at 11:39:44AM +0100, Stefan Eichenberger wrote: > > > Egress multicast and egress unicast is only enabled for CPU/DSA ports > >

Re: [PATCH net] bnxt: do not busy-poll when link is down

2016-11-22 Thread Eric Dumazet
On Tue, 2016-11-22 at 10:55 -0800, Michael Chan wrote: > On Tue, Nov 22, 2016 at 10:38 AM, Eric Dumazet wrote: > > > > Any plans removing this busy polling stuff, now it is done in core > > networking stack ? > > > > This would remove bnxt_lock_napi() extra overhead in normal path ( napi > > poll

Re: net/icmp: null-ptr-deref in icmp6_send

2016-11-22 Thread David Ahern
Sent from my iPhone > On Nov 22, 2016, at 1:11 PM, Cong Wang wrote: > >> On Tue, Nov 22, 2016 at 2:23 AM, Andrey Konovalov >> wrote: >> Hi, >> >> I've got the following error report while fuzzing the kernel with syzkaller. >> >> It seems that skb_dst(skb) may end up being NULL. >> >> As f

Re: [PATCH net-next] tcp: enhance tcp_collapse_retrans() with skb_shift()

2016-11-22 Thread Eric Dumazet
On Tue, 2016-11-15 at 12:51 -0800, Eric Dumazet wrote: > From: Eric Dumazet > > In commit 2331ccc5b323 ("tcp: enhance tcp collapsing"), > we made a first step allowing copying right skb to left skb head. > > Since all skbs in socket write queue are headless (but possibly the very > first one), t

[PATCH net] flow_dissect: call init_default_flow_dissectors() earlier

2016-11-22 Thread Eric Dumazet
From: Eric Dumazet Andre Noll reported panics after my recent fix (commit 34fad54c2537 "net: __skb_flow_dissect() must cap its return value") After some more headaches, Alexander root caused the problem to init_default_flow_dissectors() being called too late, in case a network driver like IGB is

Re: [PATCH net-next] net/sched: cls_flower: verify root pointer before dereferncing it

2016-11-22 Thread Cong Wang
On Tue, Nov 22, 2016 at 8:11 AM, Jiri Pirko wrote: > Tue, Nov 22, 2016 at 05:04:11PM CET, dan...@iogearbox.net wrote: >>Hmm, I don't think we want to have such an additional test in fast >>path for each and every classifier. Can we think of ways to avoid that? >> >>My question is, since we unlink

  1   2   >