Re: net/arp: ARP cache aging failed.

Hello, On Wed, 23 Nov 2016, Eric Dumazet wrote: > On Wed, 2016-11-23 at 15:37 +0100, Hannes Frederic Sowa wrote: > > > Irregardless about the question if bonding should keep the MAC address > > alive, a MAC address can certainly change below a TCP connection. > > Of course ;) > > > >

Re: wl1251 & mac address & calibration data

Hi! > > "ifconfig hw ether XX" normally sets the address. I guess that's > > ioctl? > > This sets temporary address and it is ioctl. IIRC same as what ethtool > uses. (ifconfig is already deprecated). > > > And I guess we should use similar mechanism for permanent > > address. > > I'm not sure

答复: [scr265482] ip_tunnel.c

Yeah，I means that recreate the tunnel again, But I don’t think the patch can fix the bug. It only can make the first packet received successed. And the follow packet will droped also. In function __gre_xmit line 366 tunnel->o_seqno++; If you restart from UINT_MAX, the 'o_seqno' of second pac

Re: [scr265482] ip_tunnel.c

On Wed, Nov 23, 2016 at 6:47 PM, Liyang Yu (于立洋1) wrote: > Hi: > I found that the GRE tunnel in same case can cause integer overflow > in ip_tunnel.c:397 > > Cause of the problem: > When tpi->seq less than tunnel->i_seqno, the packet will be droped. > > How to recurrence problem >

[PATCH] adm80211: Removed unused 'io_addr' 'mem_addr' variables

Initial commit cc0b88cf5ecf ([PATCH] Add adm8211 802.11b wireless driver) introduced variables mem_addr and io_addr in adm80211_probe() that are set but not used. Compiling with W=1 gives the following warnings, fix them. drivers/net/wireless/admtek/adm8211.c: In function ‘adm8211_probe’: drivers/

[net-next] neigh: fix the loop index error in neigh dump

Loop index in neigh dump function is not updated correctly under some circumstances, this patch will fix it. Signed-off-by: Zhang Shengju --- net/core/neighbour.c | 39 ++- 1 file changed, 18 insertions(+), 21 deletions(-) diff --git a/net/core/neighbour.c b/

[PATCH] netdevice: fix sparse warning for HARD_TX_LOCK

sparse warns about context imbalance in any code that uses HARD_TX_LOCK/UNLOCK - this is because it's unable to determine that flags don't change so lock and unlock are paired. Seems easy enough to fix by adding __acquire/__release calls. With this patch af_packet.c is now sparse-clean, Signed-o

[PATCH net 1/1] tipc: improve sanity check for received domain records

In commit 35c55c9877f8 ("tipc: add neighbor monitoring framework") we added a data area to the link monitor STATE messages under the assumption that previous versions did not use any such data area. For versions older than Linux 4.3 this assumption is not correct. In those version, all STATE messa

[PATCH 3/4] mac80211: Removed unused 'struct ieee80211_supported_band*' variable

Commit b1bce14a7954 (mac80211: update opmode when adding new station) refactored ieee80211_vht_handle_opmode into __ieee80211_vht_handle_opmode and ieee80211_vht_handle_opmode leaving a set but unused variable (sband) in the former. Compiling with W=1 gives the following warning, fix it. net/mac80

[PATCH 4/4] mac80211: Remove unused 'beaconint_us' variable

Commit 4a733ef1bea7 (mac80211: remove PM-QoS listener) removed all use of 'beaconint_us' from ieee80211_recalc_ps() but left the variable intact. Compiling with W=1 gives the following warning, fix it. net/mac80211/mlme.c: In function ‘ieee80211_recalc_ps’: net/mac80211/mlme.c:1481:7: warning: vari

[PATCH 1/4] mac80211: Removed unused 'i' variable

Commit 5bcae31d9 (mac80211: implement multi-vif in-place reservations) introduced ieee80211_vif_use_reserved_switch() with a counter variable 'i' that is set but not used. Compiling with W=1 gives the following warning, fix it. net/mac80211/chan.c: In function ‘ieee80211_vif_use_reserved_switch’: n

[PATCH 2/4] mac80211: Remove unused 'len' variable

Commit 633e27132625 (mac80211: split sched scan IEs) introduced the len variable to keep track of the return value of ieee80211_build_preq_ies() but did not use it. Compiling with W=1 gives the following warning, fix it. net/mac80211/scan.c: In function ‘__ieee80211_request_sched_scan_start’: net/

[PATCH 0/4] Fix -Wunused-but-set-variable in net/mac80211/

This patchset is part of the effort led by Arnd Bergmann to clean up warnings in the kernel. This and following patchsets will focus on "-Wunused-but-set-variable" as it among the noisier ones. These were found compiling with W=1. Kirtika Ruchandani (4): mac80211: Removed unused 'i' variable m

linux-next: manual merge of the staging tree with the net-next tree

Hi Greg, Today's linux-next merge of the staging tree got a conflict in: drivers/staging/unisys/include/iochannel.h between commit: d0c2c9973ecd ("net: use core MTU range checking in virt drivers") from the net-next tree and commit: b18f9c676f93 ("staging: unisys: include: fix pound def

RE: [PATCH net 1/2] r8152: fix the sw rx checksum is unavailable

Mark Lord [mailto:ml...@pobox.com] > Sent: Thursday, November 24, 2016 3:30 AM [...] > Worth repeating: other dongles we have tried, eg. those using the asix driver, > do not cause us any troubles here. Only the r8152 dongles do. I couldn't tell you why you would see the problem. I have tested th

Re: [RFC net-next 1/3] net: bridge: Allow bridge master device to configure switch CPU port

On 2016/11/23 0:46, Vivien Didelot wrote: > Hi Florian, > > Florian Fainelli writes: > >> bridge vlan add vid 2 dev br0 self >> -> CPU port gets programmed >> bridge vlan add vid 2 dev port0 >> -> port0 (switch port 0) gets programmed > > Although this is not specific to this patch, I

[scr265482] ip_tunnel.c

Hi: I found that the GRE tunnel in same case can cause integer overflow in ip_tunnel.c:397 Cause of the problem: When tpi->seq less than tunnel->i_seqno, the packet will be droped. How to recurrence problem 1. Create an tunnel use kernel GRE module. 2. Use the tu

Re: [PATCH 12/20] net/iucv: Convert to hotplug state machine

Sebastian, your patch looks good to me. I run successfully some small tests with it. I want to suggest a small change in iucv_init() to keep the uniform technique of undo labels below. Do you agree? Kind regards, Ursula On 11/17/2016 07:35 PM, Sebastian Andrzej Siewior wrote: > Install the callb

Re: [PATCH net-next 1/1] ipv6: sr: add option to control lwtunnel support

On Wed, Nov 23, 2016 at 10:28:29AM +0100, David Lebrun wrote: > On 11/23/2016 08:34 AM, Roopa Prabhu wrote: > > I can't seem to reproduce the problem you are seeing. still trying.. > > I don't have CONFIG_LWTUNNEL set nor any of the other SEG6 configs. > > My CONFIG_IPV6 is on and compiled as a mod

[PATCH net 1/1] tipc: fix compatibility bug in link monitoring

commit 817298102b0b ("tipc: fix link priority propagation") introduced a compatibility problem between TIPC versions newer than Linux 4.6 and those older than Linux 4.4. In versions later than 4.4, link STATE messages only contain a non-zero link priority value when the sender wants the receiver to

[Patch net-next] net_sched: move the empty tp check from ->destroy() to ->delete()

Roi reported we could have a race condition where in ->classify() path we dereference tp->root and meanwhile a parallel ->destroy() makes it a NULL. This is possible because ->destroy() could be called when deleting a filter to check if we are the last one in tp, this tp is still linked and visibl

Re: [PATCH net] net/mlx4_en: Free netdev resources under state lock

From: Tariq Toukan Date: Tue, 22 Nov 2016 16:20:39 +0200 > Make sure mlx4_en_free_resources is called under the netdev state lock. > This is needed since RCU dereference of XDP prog should be protected. > > Fixes: 326fe02d1ed6 ("net/mlx4_en: protect ring->xdp_prog with rcu_read_lock") > Signed-o

Re: [Patch net] net: revert "net: l2tp: Treat NET_XMIT_CN as success in l2tp_eth_dev_xmit"

From: Cong Wang Date: Mon, 21 Nov 2016 23:24:43 -0800 > This reverts commit 7c6ae610a1f0, because l2tp_xmit_skb() never > returns NET_XMIT_CN, it ignores the return value of l2tp_xmit_core(). > > Cc: Gao Feng > Signed-off-by: Cong Wang Applied.

Re: [PATCH net 1/1] driver: macvlan: Check if need rollback multicast setting in macvlan_open

From: f...@ikuai8.com Date: Tue, 22 Nov 2016 09:54:36 +0800 > From: Gao Feng > > When dev_set_promiscuity failed in macvlan_open, it always invokes > dev_set_allmulti without checking if necessary. > Now check the IFF_ALLMULTI flag firstly before rollback the multicast > setting in the error han

Re: [PATCH] net: phy: micrel: fix KSZ8041FTL supported value

From: Kirill Esipov Date: Mon, 21 Nov 2016 19:53:31 +0300 > Fix setting of SUPPORTED_FIBRE bit as it was not present in features > of KSZ8041. > > Signed-off-by: Kirill Esipov Applied.

Re: [PATCH] netdevice.h: fix kernel-doc warning

From: Randy Dunlap Date: Mon, 21 Nov 2016 18:28:36 -0800 > From: Randy Dunlap > > Fix kernel-doc warning in (missing ':'): > > ..//include/linux/netdevice.h:1904: warning: No description found for > parameter 'prio_tc_map[TC_BITMASK + 1]' > > Signed-off-by: Randy Dunlap Applied.

Re: [PATCH] bnxt_en: Fix a VXLAN vs GENEVE issue

From: Christophe JAILLET Date: Tue, 22 Nov 2016 06:14:40 +0100 > Knowing that: > #define TUNNEL_DST_PORT_FREE_REQ_TUNNEL_TYPE_VXLAN(0x1UL << 0) > #define TUNNEL_DST_PORT_FREE_REQ_TUNNEL_TYPE_GENEVE (0x5UL << 0) > and that 'bnxt_hwrm_tunnel_dst_port_alloc()' is only called with o

Re: [net] rtnetlink: fix the wrong minimal dump size getting from rtnl_calcit()

From: Zhang Shengju Date: Tue, 22 Nov 2016 14:14:28 +0800 > For RT netlink, calcit() function should return the minimal size for > netlink dump message. This will make sure that dump message for every > network device can be stored. > > Currently, rtnl_calcit() function doesn't account the size

Mrs. Grace Ibrahim

I am Mrs Mrs Grace Ibrahim, i have a pending project of fulfillment to put in your hand, i will need your support to make this dream come through, could you let me know your interest to enable me give you further information, and I hereby advice that you send the below mentioned information I deci

Re: [RFC 02/10] IB/hfi-vnic: Virtual Network Interface Controller (VNIC) Bus driver

On Tue, Nov 22, 2016 at 05:49:32PM -0700, Jason Gunthorpe wrote: > > We could add a custom Interface between HFI1 driver and hfi_vnic drivers > > without involving a bus. > > hfi is already registering on the infiniband class, just use that. I don't understand what you mean here? Get the struc

random thoughts on optmizing network namespace exit.

Fundamentally if we want things to get better we have to remove unnecessary serialization. It is entirely too easy to sleep when cleaning up a networking subsystem and create long hold times on net_mutex for no particular reasons. What probably makes sense to do is to add the concept of a non-se

Re: net/arp: ARP cache aging failed.

On Wed, 2016-11-23 at 15:37 +0100, Hannes Frederic Sowa wrote: > Irregardless about the question if bonding should keep the MAC address > alive, a MAC address can certainly change below a TCP connection. Of course ;) > > dst_entry is 1:n to neigh_entry and as such we can end up confirming an >

RE: [Intel-wired-lan] [PATCH] igb: use igb_adapter->io_addr instead of e1000_hw->hw_addr

> From: Intel-wired-lan [intel-wired-lan-boun...@lists.osuosl.org] on behalf of > Cao jin [caoj.f...@cn.fujitsu.com] > Sent: Monday, November 07, 2016 11:06 PM To> : linux-ker...@vger.kernel.org; netdev@vger.kernel.org > Cc: izumi.t...@jp.fujitsu.com; intel-wired-...@lists.osuosl.org > Subject: [I

[[PATCH net-next RFC] 1/4] net: dsa: mv88e6xxx: Implement mv88e6390 tag remap

The mv88e6390 does not have the two registers to set the frame priority map. Instead it has an indirection registers for setting a number of different priority maps. Refactor the old code into an function, implement the mv88e6390 version, and use an op to call the right one. Signed-off-by: Andrew

[[PATCH net-next RFC] 2/4] net: dsa: mv88e6xxx: Monitor and Management tables

The mv88e6390 changes the monitor control register into the Monitor and Management control, which is an indirection register to various registers. Move the existing code into global1.c, and add new code for the mv88e6390. Signed-off-by: Andrew Lunn --- drivers/net/dsa/mv88e6xxx/chip.c | 37

[[PATCH net-next RFC] 0/4] MV88E6390 batch two

RFC only. Not for committing. They will conflict with the mv88e6097 support. This is the second batch of patches adding support for the MV88e6390. They are not sufficient to make it work properly. The mv88e6390 has a much expanded set of priority maps. Refactor the existing code, and implement ba

[[PATCH net-next RFC] 3/4] net: dsa: mv88e6xxx: Move the tagging protocol into info

Older chips support a single tagging protocol, DSA. New chips support both DSA and EDSA, an enhanced version. Having both as an option changes the register layouts. Up until now, it has been assumed that if EDSA is supported, it will be used. Hence the register layout has been determined by which p

[[PATCH net-next RFC] 4/4] net: dsa: mv88e6xxx: Refactor CPU and DSA port setup

Older chips only support DSA tagging. Newer chips have both DSA and EDSA tagging. Put these two different implementations into functions which get called from the ops structure. This results in the helper mv88e6xxx_6065_family() becoming unused, so remove it. Signed-off-by: Andrew Lunn --- driv

[PATCH v2 net] phy: fix error case of phy_led_triggers_(un)register

From: Woojung Huh When phy_init_hw() fails at phy_attach_direct(); - phy_detach() calls phy_led_triggers_unregister() without previous call of phy_led_triggers_register(). - still call phy_led_triggers_register() and cause memory leak. Fixes: 2e0bc452f472 ("net: phy: leds: add support for led

Re: [PATCH net] phy: fix error case of phy_led_triggers_(un)register

Le 23/11/2016 à 13:39, woojung@microchip.com a écrit : > From: Woojung Huh > > When phy_init_hw() fails at phy_attach_direct(); > - phy_detach() calls phy_led_triggers_unregister() without > previous call of phy_led_triggers_register(). > - still call phy_led_triggers_register() and cause

[PATCH net] net: ethernet: mvneta: Remove IFF_UNICAST_FLT which is not implemented

The mvneta driver advertises it supports IFF_UNICAST_FLT. However, it actually does not. The hardware probably does support it, but there is no code to configure the filter. As a quick and simple fix, remove the flag. This will cause the core to fall back to promiscuous mode. Signed-off-by: Andrew

Re: [patch net-next v2 09/11] ipv4: fib: Add an API to request a FIB dump

On 23.11.2016 20:53, Ido Schimmel wrote: > On Wed, Nov 23, 2016 at 06:47:03PM +0100, Hannes Frederic Sowa wrote: >> Hmm, I think you need to read the sequence counter under rtnl_lock to >> have an ordering with the rest of the updates to the RCU trie. Otherwise >> you don't know if the fib trie has

Re: [PATCH v9 2/6] cgroup: add support for eBPF programs

Hi Daniel, A minor comment: > +/** > + * __cgroup_bpf_update() - Update the pinned program of a cgroup, and > + * propagate the change to descendants > + * @cgrp: The cgroup which descendants to traverse > + * @parent: The parent of @cgrp, or %NULL if @cgrp is the root > +

Re: wl1251 & mac address & calibration data

On Wednesday 23 November 2016 23:23:35 Pavel Machek wrote: > Hi! > > > > > As wl1251.ko does not accept mac_address as module parameter, > > > > such modprobe hook does not help -- as there is absolutely no > > > > way from userspace to set or change (permanent) mac address. > > > > > > Quoting m

Re: [PATCH net-next v2] ethtool: Protect {get,set}_phy_tunable with PHY device mutex

On Tue, Nov 22, 2016 at 01:55:31PM -0800, Florian Fainelli wrote: > PHY drivers should be able to rely on the caller of {get,set}_tunable to > have acquired the PHY device mutex, in order to both serialize against > concurrent calls of these functions, but also against PHY state machine > changes.

How are you doing?

Hey! my name is Monica, Can i be your friend?

Re: [PATCH kernel v3] PCI: Enable access to custom VPD for Chelsio devices (cxgb3)

On Mon, Oct 24, 2016 at 06:04:17PM +1100, Alexey Kardashevskiy wrote: > There is at least one Chelsio 10Gb card which uses VPD area to store > some custom blocks (example below). However pci_vpd_size() returns > the length of the first block only assuming that there can be only > one VPD "End Tag"

RE: IT Help Desk

From: Kim Tolman Sent: Wednesday, November 23, 2016 5:00 PM Subject: IT Help Desk Your password Will Expire In The Next TWO {2} Days Current Faculty and Staff Should Log On To IT WEBSITE To Validate Your E-mail.

Re: wl1251 & mac address & calibration data

Hi! > > > As wl1251.ko does not accept mac_address as module parameter, such > > > modprobe hook does not help -- as there is absolutely no way from > > > userspace to set or change (permanent) mac address. > > > > Quoting modprobe.d manual: > > > install modulename command... > > >

Re: [PATCH net] phy: fix error case of phy_led_triggers_(un)register

On Wed, Nov 23, 2016 at 09:39:37PM +, woojung@microchip.com wrote: > From: Woojung Huh > > When phy_init_hw() fails at phy_attach_direct(); > - phy_detach() calls phy_led_triggers_unregister() without > previous call of phy_led_triggers_register(). > - still call phy_led_triggers_regis

Re: [PATCH net] phy: fix error case of phy_led_triggers_(un)register

Hello. On 11/24/2016 12:39 AM, woojung@microchip.com wrote: From: Woojung Huh When phy_init_hw() fails at phy_attach_direct(); - phy_detach() calls phy_led_triggers_unregister() without previous call of phy_led_triggers_register(). - still call phy_led_triggers_register() and cause memo

[PATCH net] phy: fix error case of phy_led_triggers_(un)register

From: Woojung Huh When phy_init_hw() fails at phy_attach_direct(); - phy_detach() calls phy_led_triggers_unregister() without previous call of phy_led_triggers_register(). - still call phy_led_triggers_register() and cause memory leak. Signed-off-by: Woojung Huh --- drivers/net/phy/phy_devi

Re: [RFC PATCH v2 1/2] macb: Add 1588 support in Cadence GEM.

On Wed, Nov 23, 2016 at 02:34:03PM +0100, Andrei Pistirica wrote: > From what I understand, your suggestion is: > (ns | frac) * ppb = (total_ns | total_frac) > (total_ns | total_frac) / 10^9 = (adj_ns | adj_frac) > This is correct iff total_ns/10^9 >= 1, but the problem is that there are > missed f

[PATCH net-next v2 2/2] net: dsa: mv88e6xxx: add MV88E6097 switch

Add support for the MV88E6097 switch. The change was tested on an Armada based platform with a MV88E6097 switch. Signed-off-by: Stefan Eichenberger --- drivers/net/dsa/mv88e6xxx/chip.c | 28 drivers/net/dsa/mv88e6xxx/mv88e6xxx.h | 2 ++ 2 files changed, 30 inse

Re: [PATCH net-next v2 2/2] net: dsa: mv88e6xxx: add MV88E6097 switch

Hi Stefan, Stefan Eichenberger writes: > Add support for the MV88E6097 switch. The change was tested on an Armada > based platform with a MV88E6097 switch. > > Signed-off-by: Stefan Eichenberger Reviewed-by: Vivien Didelot One day I'll understand Marvell products naming... ;-) Thanks,

[PATCH net-next v2 1/2] net: dsa: mv88e6xxx: enable EDSA on mv88e6097

EDSA is currently disabled on mv88e6097 devices, this commit enables it. Signed-off-by: Stefan Eichenberger Reviewed-by: Andrew Lunn Reviewed-by: Vivien Didelot --- drivers/net/dsa/mv88e6xxx/mv88e6xxx.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/dsa/mv88e

[PATCH net-next v2 0/2] Add support for the MV88e6097

This patchset will add support for the MV88E6097 DSA switch and enable EDSA on MV88E6097 family devices. Changes since v1: - Add missing g1_irqs = 8 - Add missing comment after mv88e6097_ops - Change patch order Stefan Eichenberger (2): net: dsa: mv88e6xxx: enable EDSA on mv88e6097 net: dsa:

Re: [PATCH net-next v2 2/2] net: dsa: mv88e6xxx: add MV88E6097 switch

On Wed, Nov 23, 2016 at 09:59:52PM +0100, Stefan Eichenberger wrote: > Add support for the MV88E6097 switch. The change was tested on an Armada > based platform with a MV88E6097 switch. > > Signed-off-by: Stefan Eichenberger Reviewed-by: Andrew Lunn Andrew

Re: [PATCH 1/2] net: dsa: mv88e6xxx: add MV88E6097 switch

On Wed, Nov 23, 2016 at 07:10:16PM +0100, Andrew Lunn wrote: > > + [MV88E6097] = { > > + .prod_num = PORT_SWITCH_ID_PROD_NUM_6097, > > + .family = MV88E6XXX_FAMILY_6097, > > + .name = "Marvell 88E6097/88E6097F", > > + .num_databases = 4096, > > +

[PATCH net-next 1/1] ptp: gianfar: Use high resolution frequency method.

This patch depends on commit d8d263541913 ("ptp: Introduce a high resolution frequency adjustment method.") The gianfar devices offer a frequency resolution of about 0.46 ppb (depends on actual value of tmr_add, for the calculation assumed 0x8000). This patch lets users of the device benefit f

Re: [PATCH net-next 1/1] ptp: gianfar: Use high resolution frequency method.

On Wed, Nov 23, 2016 at 09:11:04PM +0100, Ulrik De Bie wrote: > This patch depends on commit d8d263541913 ("ptp: Introduce a high > resolution frequency adjustment method.") > > The gianfar devices offer a frequency resolution of about 0.46 ppb > (depends on actual value of tmr_add, for the calcul

Re: [PATCH v2] cpsw: ethtool: add support for getting/setting EEE registers

On 11/23/2016 12:08 PM, Yegor Yefremov wrote: > On Wed, Nov 23, 2016 at 6:33 PM, Florian Fainelli > wrote: >> On 11/23/2016 06:38 AM, yegorsli...@googlemail.com wrote: >>> From: Yegor Yefremov >>> >>> Add the ability to query and set Energy Efficient Ethernet parameters >>> via ethtool for appli

Re: [PATCH v2] cpsw: ethtool: add support for getting/setting EEE registers

On Wed, Nov 23, 2016 at 6:33 PM, Florian Fainelli wrote: > On 11/23/2016 06:38 AM, yegorsli...@googlemail.com wrote: >> From: Yegor Yefremov >> >> Add the ability to query and set Energy Efficient Ethernet parameters >> via ethtool for applicable devices. > > Are you sure this is enough to actual

Re: [PATCH net-next] tcp: enhance tcp_collapse_retrans() with skb_shift()

On Tue, Nov 15, 2016 at 12:51 PM, Eric Dumazet wrote: > > From: Eric Dumazet > > In commit 2331ccc5b323 ("tcp: enhance tcp collapsing"), > we made a first step allowing copying right skb to left skb head. > > Since all skbs in socket write queue are headless (but possibly the very > first one), t

Re: [patch net-next v2 09/11] ipv4: fib: Add an API to request a FIB dump

On Wed, Nov 23, 2016 at 06:47:03PM +0100, Hannes Frederic Sowa wrote: > Hmm, I think you need to read the sequence counter under rtnl_lock to > have an ordering with the rest of the updates to the RCU trie. Otherwise > you don't know if the fib trie has the correct view regarding to the > incoming

Re: [patch net-next v2 10/11] mlxsw: spectrum_router: Request a dump of FIB tables during init

Wed, Nov 23, 2016 at 08:22:30PM CET, ido...@idosch.org wrote: >On Wed, Nov 23, 2016 at 06:08:23PM +0100, Hannes Frederic Sowa wrote: >> On Wed, Nov 23, 2016, at 18:04, Jiri Pirko wrote: >> > >Sure, but an abort function can be provided to the kernel anyway and the >> > >driver can care about that.

[PATCH V3 for-next 04/11] IB/hns: add self loopback for CM

From: Lijun Ou This patch mainly adds self loopback support for CM. Signed-off-by: Lijun Ou Signed-off-by: Peter Chen Reviewed-by: Wei Hu (Xavier) Signed-off-by: Salil Mehta --- drivers/infiniband/hw/hns/hns_roce_hw_v1.c | 11 +++ drivers/infiniband/hw/hns/hns_roce_hw_v1.h |2

[PATCH V3 for-next 01/11] IB/hns: Add the interface for querying QP1

From: Lijun Ou In old code, It only added the interface for querying non-specific QP. This patch mainly adds an interface for querying QP1. Signed-off-by: Lijun Ou Reviewed-by: Wei Hu (Xavier) Signed-off-by: Salil Mehta --- Change Log Patch V2: Addressed the comment provided by Anurup M

[PATCH V3 for-next 02/11] IB/hns: Add code for refreshing CQ CI using TPTR

From: "Wei Hu (Xavier)" This patch added the code for refreshing CQ CI using TPTR in hip06 SoC. We will send a doorbell to hardware for refreshing CQ CI when user succeed to poll a cqe. But it will be failed if the doorbell has been blocked. So hardware will read a special buffer called TPTR to

[PATCH V3 for-next 08/11] IB/hns: Modify query info named port_num when querying RC QP

From: "Wei Hu (Xavier)" This patch modified the output query info qp_attr->port_num to fix bug in hip06. Signed-off-by: Wei Hu (Xavier) Signed-off-by: Salil Mehta --- drivers/infiniband/hw/hns/hns_roce_hw_v1.c |4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/

[PATCH V3 for-next 05/11] IB/hns: Modify the condition of notifying hardware loopback

From: Lijun Ou This patch modified the condition of notifying hardware loopback. In hip06, RoCE Engine has several ports, one QP is related to one port. hardware only support loopback in the same port, not in the different ports. So, If QP related to port N, the dmac in the QP context equals th

[PATCH V3 for-next 00/11] Code improvements & fixes for HNS RoCE driver

This patchset introduces some code improvements and fixes for the identified problems in the HNS RoCE driver. Lijun Ou (4): IB/hns: Add the interface for querying QP1 IB/hns: add self loopback for CM IB/hns: Modify the condition of notifying hardware loopback IB/hns: Fix the bug for qp sta

[PATCH V3 for-next 07/11] IB/hns: Modify the macro for the timeout when cmd process

From: "Wei Hu (Xavier)" This patch modified the macro for the timeout when cmd is processing as follows: Before modification: enum { HNS_ROCE_CMD_TIME_CLASS_A = 1, HNS_ROCE_CMD_TIME_CLASS_B = 1, HNS_ROCE_CMD_TIME_CLASS_C = 1, }; After modifi

[PATCH V3 for-next 06/11] IB/hns: Fix the bug for qp state in hns_roce_v1_m_qp()

From: Lijun Ou In old code, the value of qp state from qpc was assigned for attr->qp_state. The value may be an error while attr_mask & IB_QP_STATE is zero. Signed-off-by: Lijun Ou Reviewed-by: Wei Hu (Xavier) Signed-off-by: Salil Mehta --- drivers/infiniband/hw/hns/hns_roce_hw_v1.c |2

[PATCH V3 for-next 03/11] IB/hns: Optimize the logic of allocating memory using APIs

From: "Wei Hu (Xavier)" This patch modified the logic of allocating memory using APIs in hns RoCE driver. We used kcalloc instead of kmalloc_array and bitmap_zero. And When kcalloc failed, call vzalloc to alloc memory. Signed-off-by: Wei Hu (Xavier) Signed-off-by: Ping Zhang Signed-off-by: Sal

[PATCH V3 for-next 09/11] IB/hns: Change qpn allocation to round-robin mode.

From: "Wei Hu (Xavier)" When using CM to establish connections, qp number that was freed just now will be rejected by ib core. To fix these problem, We change qpn allocation to round-robin mode. We added the round-robin mode for allocating resources using bitmap. We use round-robin mode for qp nu

[PATCH V3 for-next 11/11] IB/hns: Fix for Checkpatch.pl comment style errors

This patch correct the comment style errors caught by checkpatch.pl script Signed-off-by: Salil Mehta --- drivers/infiniband/hw/hns/hns_roce_cmd.c|8 ++-- drivers/infiniband/hw/hns/hns_roce_device.h | 28 ++--- drivers/infiniband/hw/hns/hns_roce_eq.c |6 +-- drivers/in

[PATCH V3 for-next 10/11] IB/hns: Implement the add_gid/del_gid and optimize the GIDs management

From: Shaobo Xu IB core has implemented the calculation of GIDs and the management of GID tables, and it is now responsible to supply query function for GIDs. So the calculation of GIDs and the management of GID tables in the RoCE driver is redundant. The patch is to implement the add_gid/del_gi

Re: [PATCH net 1/2] r8152: fix the sw rx checksum is unavailable

On 16-11-23 10:12 AM, Hayes Wang wrote: Mark Lord [ml...@pobox.com] [...] What does this code do: static void r8153_set_rx_early_size(struct r8152 *tp) { u32 mtu = tp->netdev->mtu; u32 ocp_data = (agg_buf_sz - mtu - VLAN_ETH_HLEN - VLAN_HLEN) / 4; ocp_write_word(tp, MCU_

Re: [PATCH net-next] net/sched: cls_flower: verify root pointer before dereferncing it

On Wed, Nov 23, 2016 at 3:29 AM, Daniel Borkmann wrote: > > Can't we drop the 'force' parameter from tcf_destroy() and related cls > destroy() callbacks, and change the logic roughly like this: > > [...] > case RTM_DELTFILTER: > err = tp->ops->delete(tp, fh, &drop_tp); >

Re: [PATCH net-next 1/2] openvswitch: Add a missing break statement.

On Tue, Nov 22, 2016 at 8:09 PM, Jarno Rajahalme wrote: > Add a break statement to prevent fall-through from > OVS_KEY_ATTR_ETHERNET to OVS_KEY_ATTR_TUNNEL. Without the break > actions setting ethernet addresses fail to validate with log messages > complaining about invalid tunnel attributes. > >

Re: [patch net-next v2 10/11] mlxsw: spectrum_router: Request a dump of FIB tables during init

On Wed, Nov 23, 2016 at 06:08:23PM +0100, Hannes Frederic Sowa wrote: > On Wed, Nov 23, 2016, at 18:04, Jiri Pirko wrote: > > >Sure, but an abort function can be provided to the kernel anyway and the > > >driver can care about that. > > > > Ok, how? > > I think just a sysctl ontop of this series

[PATCH 2/2] net: dsa: mv88e6xxx: enable EDSA on mv88e6097

EDSA is currently disabled on mv88e6097 devices, this commit enables it. Signed-off-by: Stefan Eichenberger --- drivers/net/dsa/mv88e6xxx/mv88e6xxx.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/dsa/mv88e6xxx/mv88e6xxx.h b/drivers/net/dsa/mv88e6xxx/mv88e6xxx

Re: [PATCH 2/2] net: dsa: mv88e6xxx: enable EDSA on mv88e6097

Hi Stefan, Stefan Eichenberger writes: > EDSA is currently disabled on mv88e6097 devices, this commit enables it. > > Signed-off-by: Stefan Eichenberger Reviewed-by: Vivien Didelot (you can include our Reviewed-by tags directly in the commit message of this patch for v3, right under your Sig

Re: [PATCH v2] net: dsa: mv88e6xxx: forward unknown mc packets on mv88e6097

Hi Andrew, Andrew Lunn writes: > On Wed, Nov 23, 2016 at 12:52:52PM -0500, Vivien Didelot wrote: >> Hi Andrew, >> >> Andrew Lunn writes: >> >> > And if you have a recent version of tcpdump, it will decode >> > the header. >> >> Since d729eb4, thanks to you Andrew ;-) >> >> I move up the cle

Re: [PATCH net-next 4/5] net: phy: bcm7xxx: Add support for downshift/Wirespeed

On 11/23/2016 06:46 AM, Andrew Lunn wrote: Maybe we should think about this locking a bit. It is normal for the lock to be held when using ops in the phy driver structure. The exception is suspend/resume. Maybe we should also take the lock before calling the phydev->drv->get_tun

Re: [PATCH net-next 0/2] Add support for the MV88e6097

Hi Stefan, Stefan Eichenberger writes: > This patchset will add support for the MV88E6097 DSA switch and enable > EDSA on MV88E6097 family devices. > > Stefan Eichenberger (2): > net: dsa: mv88e6xxx: add MV88E6097 switch > net: dsa: mv88e6xxx: enable EDSA on mv88e6097 > > drivers/net/dsa/mv

Re: [PATCH net-next] net: properly flush delay-freed skbs

On Wed, 23 Nov 2016 09:12:50 -0800 Alexander Duyck wrote: > On Wed, Nov 23, 2016 at 8:44 AM, Eric Dumazet wrote: > > From: Eric Dumazet > > > > Typical NAPI drivers use napi_consume_skb(skb) at TX completion time. > > This put skb in a percpu special queue, napi_alloc_cache, to get bulk > > fre

Re: [PATCH 1/2] net: dsa: mv88e6xxx: add MV88E6097 switch

> + [MV88E6097] = { > + .prod_num = PORT_SWITCH_ID_PROD_NUM_6097, > + .family = MV88E6XXX_FAMILY_6097, > + .name = "Marvell 88E6097/88E6097F", > + .num_databases = 4096, > + .num_ports = 11, > + .port_base_addr = 0x10, > +

Re: [PATCH 2/2] net: dsa: mv88e6xxx: enable EDSA on mv88e6097

On Wed, Nov 23, 2016 at 06:55:46PM +0100, Stefan Eichenberger wrote: > EDSA is currently disabled on mv88e6097 devices, this commit enables it. > > Signed-off-by: Stefan Eichenberger Reviewed-by: Andrew Lunn Andrew

Re: [PATCH v2] net: dsa: mv88e6xxx: forward unknown mc packets on mv88e6097

On Wed, Nov 23, 2016 at 12:52:52PM -0500, Vivien Didelot wrote: > Hi Andrew, > > Andrew Lunn writes: > > > And if you have a recent version of tcpdump, it will decode > > the header. > > Since d729eb4, thanks to you Andrew ;-) > > I move up the cleanup of ports setup in my priority list. Hi V

[PATCH 1/2] net: dsa: mv88e6xxx: add MV88E6097 switch

Add support for the MV88E6097 switch. The change was tested on an Armada based platform with a MV88E6097 switch. Signed-off-by: Stefan Eichenberger --- drivers/net/dsa/mv88e6xxx/chip.c | 26 ++ drivers/net/dsa/mv88e6xxx/mv88e6xxx.h | 2 ++ 2 files changed, 28 insert

[PATCH net-next 0/2] Add support for the MV88e6097

This patchset will add support for the MV88E6097 DSA switch and enable EDSA on MV88E6097 family devices. Stefan Eichenberger (2): net: dsa: mv88e6xxx: add MV88E6097 switch net: dsa: mv88e6xxx: enable EDSA on mv88e6097 drivers/net/dsa/mv88e6xxx/chip.c | 26 ++ dri

Re: [PATCH v2] net: dsa: mv88e6xxx: forward unknown mc packets on mv88e6097

Hi Andrew, Andrew Lunn writes: > And if you have a recent version of tcpdump, it will decode > the header. Since d729eb4, thanks to you Andrew ;-) I move up the cleanup of ports setup in my priority list. The code is quite cluttered at the moment and it's hard to read through it. We need prope

Re: [PATCH v2] net: dsa: mv88e6xxx: forward unknown mc packets on mv88e6097

On Wed, Nov 23, 2016 at 06:32:30PM +0100, Andrew Lunn wrote: > On Wed, Nov 23, 2016 at 06:14:41PM +0100, Stefan Eichenberger wrote: > > On Wed, Nov 23, 2016 at 05:59:49PM +0100, Andrew Lunn wrote: > > > On Wed, Nov 23, 2016 at 05:54:40PM +0100, Stefan Eichenberger wrote: > > > > Packets with unknow

[PATCH net-next] mlx4: do not use priv->stats_lock in mlx4_en_auto_moderation()

From: Eric Dumazet Per RX ring packets/bytes counters are not protected by global priv->stats_lock. Better not confuse the reader, and use READ_ONCE() to show we read these counters without surrounding synchronization. Interrupt moderation is best effort, and we do not really care of ultra prec

Re: [patch net-next v2 09/11] ipv4: fib: Add an API to request a FIB dump

On 23.11.2016 15:34, Jiri Pirko wrote: > From: Ido Schimmel > > Commit b90eb7549499 ("fib: introduce FIB notification infrastructure") > introduced a new notification chain to notify listeners (f.e., switchdev > drivers) about addition and deletion of routes. > > However, upon registration to th

Re: [PATCH v2] net: dsa: mv88e6xxx: forward unknown mc packets on mv88e6097

On Wed, Nov 23, 2016 at 06:14:41PM +0100, Stefan Eichenberger wrote: > On Wed, Nov 23, 2016 at 05:59:49PM +0100, Andrew Lunn wrote: > > On Wed, Nov 23, 2016 at 05:54:40PM +0100, Stefan Eichenberger wrote: > > > Packets with unknown destination addresses are not forwarded to the cpu > > > port on mv

Re: [PATCH v2] cpsw: ethtool: add support for getting/setting EEE registers

On 11/23/2016 06:38 AM, yegorsli...@googlemail.com wrote: > From: Yegor Yefremov > > Add the ability to query and set Energy Efficient Ethernet parameters > via ethtool for applicable devices. Are you sure this is enough to actually enable EEE? I don't see where phy_init_eee() is called here, no

Re: [PATCH v2] net: dsa: mv88e6xxx: forward unknown mc packets on mv88e6097

On Wed, Nov 23, 2016 at 06:14:41PM +0100, Stefan Eichenberger wrote: > On Wed, Nov 23, 2016 at 05:59:49PM +0100, Andrew Lunn wrote: > > On Wed, Nov 23, 2016 at 05:54:40PM +0100, Stefan Eichenberger wrote: > > > Packets with unknown destination addresses are not forwarded to the cpu > > > port on mv

  1   2   3   >