[PATCH 1/5] ath10k: Remove unused 'buf_len' variable

2016-11-24 Thread Kirtika Ruchandani
Commit 32653cf19554 removed the call to 'skb_trim(skb, buf_len)' in ath10k_wmi_event_mgmt_rx(), leaving the buf_len variable set but unused. Compiling with W=1 gives the following warning, fix it. drivers/net/wireless/ath/ath10k/wmi.c: In function ‘ath10k_wmi_event_mgmt_rx’: drivers/net/wireless/at

[PATCH 0/5] Fix -Wunused-but-set-variable in ath10k/

2016-11-24 Thread Kirtika Ruchandani
This patchset is part of the effort led by Arnd Bergmann to clean up warnings in the kernel. This and following patchsets will focus on "-Wunused-but-set-variable" as it among the noisier ones. These were found compiling with W=1. Kirtika Ruchandani (5): ath10k: Remove unused 'buf_len' variable

[PATCH 4/5] ath10k: Removed unused 'dev' in ath10k_ahb_clock_enable()

2016-11-24 Thread Kirtika Ruchandani
Commit 8beff219c528 introduced ath10k_ahb_clock_enable() which defines and sets 'struct device* dev' but does not use it. Compiling with W=1 gives the following warning, fix it. drivers/net/wireless/ath/ath10k/ahb.c: In function ‘ath10k_ahb_clock_enable’: drivers/net/wireless/ath/ath10k/ahb.c:133:1

[PATCH 2/5] ath10k: Remove unused 'num_vdev_stats' variable

2016-11-24 Thread Kirtika Ruchandani
Several functions for wmi stats parsing define and set num_vdev_stats but do not use it. Compiling with W=1 gives the following warnings, fix them. drivers/net/wireless/ath/ath10k/wmi.c: In function ‘ath10k_wmi_main_op_pull_fw_stats’: drivers/net/wireless/ath/ath10k/wmi.c:2680:22: warning: variab

[PATCH 3/5] ath10k: Remove unused wmi_p2p_noa_descriptor 'noa' in wmi-tlv

2016-11-24 Thread Kirtika Ruchandani
Commit ca996ec56608 (ath10k: implement wmi-tlv backend) introduced ath10k_wmi_tlv_op_gen_vdev_start() where 'struct wmi_p2p_noa_descriptor *noa' is defined and set but not used. Compiling with W=1 gives the following warning, fix it. drivers/net/wireless/ath/ath10k/wmi-tlv.c: In function ‘ath10k_w

[PATCH 5/5] ath10k: Removed unused 'dev' in ath10k_ahb_resource_init

2016-11-24 Thread Kirtika Ruchandani
Commit 704dc4e36769 introduced ath10k_ahb_resource_init() which defines and sets 'struct device* dev' but does not use it. Compiling with W=1 gives the following warning, fix it. drivers/net/wireless/ath/ath10k/ahb.c: In function ‘ath10k_ahb_resource_init’: drivers/net/wireless/ath/ath10k/ahb.c:44

Re: [PATCH v9 2/6] cgroup: add support for eBPF programs

2016-11-24 Thread Daniel Mack
Hi Rami, On 11/23/2016 11:46 PM, Rami Rosen wrote: > A minor comment: > >> +/** >> + * __cgroup_bpf_update() - Update the pinned program of a cgroup, and >> + * propagate the change to descendants >> + * @cgrp: The cgroup which descendants to traverse >> + * @parent: The p

Re: [net-next PATCH v4] net: dummy: Introduce dummy virtual functions

2016-11-24 Thread kbuild test robot
Hi Phil, [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Phil-Sutter/net-dummy-Introduce-dummy-virtual-functions/20161124-040435 config: x86_64-randconfig-a0-11241529 (attached as .config) compiler: gcc-4.4 (Debian 4.4.7-8) 4.4.7 reproduce

Re: [Patch net-next] net_sched: move the empty tp check from ->destroy() to ->delete()

2016-11-24 Thread Roi Dayan
Hi, I'm testing this patch with KASAN enabled and got into a new kernel crash I didn't hit before. [ 1860.725065] == [ 1860.733893] BUG: KASAN: use-after-free in __netif_receive_skb_core+0x1ebe/0x29a0 at addr 880a68b04028

Re: wl1251 & mac address & calibration data

2016-11-24 Thread Pali Rohár
On Thursday 24 November 2016 08:51:04 Pavel Machek wrote: > Hi! > > > > "ifconfig hw ether XX" normally sets the address. I guess that's > > > ioctl? > > > > This sets temporary address and it is ioctl. IIRC same as what ethtool > > uses. (ifconfig is already deprecated). > > > > > And I guess

Re: [PATCH net-next 1/4] net: mvneta: Convert to be 64 bits compatible

2016-11-24 Thread Jisheng Zhang
Hi Marcin, Gregory, Arnd, On Wed, 23 Nov 2016 17:02:11 +0100 Marcin Wojtas wrote: > Hi Gregory, > > 2016-11-23 14:07 GMT+01:00 Gregory CLEMENT: > > Hi Jisheng, Arnd, > > > > > > Thanks for your feedback. > > > > > > On mer., nov. 23 2016, Arnd Bergmann wrote: > > > >> On Wednesday, November

Re: [patch net-next v2 09/11] ipv4: fib: Add an API to request a FIB dump

2016-11-24 Thread Ido Schimmel
On Thu, Nov 24, 2016 at 12:04:57AM +0100, Hannes Frederic Sowa wrote: > On 23.11.2016 20:53, Ido Schimmel wrote: > > On Wed, Nov 23, 2016 at 06:47:03PM +0100, Hannes Frederic Sowa wrote: > >> Hmm, I think you need to read the sequence counter under rtnl_lock to > >> have an ordering with the rest o

stmmac ethernet in kernel 4.9-rc6: coalescing related pauses.

2016-11-24 Thread Pavel Machek
Hi! > I'm debugging strange delays during transmit in stmmac driver. They > seem to be present in 4.4 kernel (and older kernels, too). Workload is > burst of udp packets being sent, pause, burst of udp packets, ... > > Test code is attached, I use these parameters for testing: > > ./udp-test raw

[PATCH ethtool v5 0/2] Adding downshift support to ethtool

2016-11-24 Thread Allan W. Nielsen
(downshift feature is applied in the net-next tree - d3c19c0a72) This series adds support for downshift (using phy-tunables). Downshifting can either be turned on/off, or it can be configured to a specifc count. "count" is optional. Change set: v1: - Initial version of set/get phy tunable with d

[PATCH ethtool v5 1/2] ethtool-copy.h:sync with net-next

2016-11-24 Thread Allan W. Nielsen
This covers kernel changes upto: commit 607c7029146790201e90b58c4235ddff0304d6e0 Author: Raju Lakkaraju Date: Thu Nov 17 13:07:22 2016 +0100 ethtool: (uapi) Add ETHTOOL_PHY_DOWNSHIFT to PHY tunables For operation in cabling environments that are incompatible with 1000BASE-T, PHY d

[PATCH ethtool v5 2/2] Ethtool: Implements ETHTOOL_PHY_GTUNABLE/ETHTOOL_PHY_STUNABLE and PHY downshift

2016-11-24 Thread Allan W. Nielsen
From: Raju Lakkaraju Add ethtool get and set tunable to access PHY drivers. Ethtool Help: ethtool -h for PHY tunables ethtool --set-phy-tunable DEVNAME Set PHY tunable [ downshift on|off [count N] ] ethtool --get-phy-tunable DEVNAME Get PHY tunable

Re: [PATCH net-next 1/4] net: mvneta: Convert to be 64 bits compatible

2016-11-24 Thread Arnd Bergmann
On Thursday, November 24, 2016 4:37:36 PM CET Jisheng Zhang wrote: > solB (a SW shadow cookie) perhaps gives a better performance: in hot path, > such as mvneta_rx(), the driver accesses buf_cookie and buf_phys_addr of > rx_desc which is allocated by dma_alloc_coherent, it's noncacheable if the > d

[no subject]

2016-11-24 Thread Llorente Santos Jesus
unsubscribe

Re: net/arp: ARP cache aging failed.

2016-11-24 Thread YueHaibing
On 2016/11/24 15:51, Julian Anastasov wrote: > > Hello, > > On Wed, 23 Nov 2016, Eric Dumazet wrote: > >> On Wed, 2016-11-23 at 15:37 +0100, Hannes Frederic Sowa wrote: >> >>> Irregardless about the question if bonding should keep the MAC address >>> alive, a MAC address can certainly chan

Re: [PATCH 12/20] net/iucv: Convert to hotplug state machine

2016-11-24 Thread Sebastian Andrzej Siewior
On 2016-11-23 19:04:16 [+0100], Ursula Braun wrote: > Sebastian, Hallo Ursula, > your patch looks good to me. I run successfully some small tests with it. > I want to suggest a small change in iucv_init() to keep the uniform technique > of undo labels below. Do you agree? So what you ask for is:

Re: [PATCH net-next 1/4] net: mvneta: Convert to be 64 bits compatible

2016-11-24 Thread Jisheng Zhang
On Thu, 24 Nov 2016 10:00:36 +0100 Arnd Bergmann wrote: > On Thursday, November 24, 2016 4:37:36 PM CET Jisheng Zhang wrote: > > solB (a SW shadow cookie) perhaps gives a better performance: in hot path, > > such as mvneta_rx(), the driver accesses buf_cookie and buf_phys_addr of > > rx_desc whic

[PATCH v3] cpsw: ethtool: add support for getting/setting EEE registers

2016-11-24 Thread yegorslists
From: Yegor Yefremov Add the ability to query and set Energy Efficient Ethernet parameters via ethtool for applicable devices. This patch doesn't activate full EEE support in cpsw driver, but it enables reading and writing EEE advertising settings. This way one can disable advertising EEE for ce

[PATCH 1/4] net: thunderx: 80xx BGX0 configuration changes

2016-11-24 Thread sunil . kovvuri
From: Sunil Goutham On 80xx only one lane of DLM0 and DLM1 (of BGX0) can be used , so even though lmac count may be 2 but LMAC1 should use serdes lane of DLM1. Since it's not possible to distinguish 80xx from 81xx as PCI devid are same, this patch adds this config support by replying on what firm

[PATCH 0/4] net: thunderx: Support for 80xx, RED, PFC e.t.c

2016-11-24 Thread sunil . kovvuri
From: Sunil Goutham This patch series adds support for SLM modules present on 80xx silicon, enables ramdom early discard, backpressure generation, PFC and some ethtool changes to display supported link modes e.t.c. Sunil Goutham (3): net: thunderx: 80xx BGX0 configuration changes net: thunde

[patch added to 3.12-stable] net: sctp, forbid negative length

2016-11-24 Thread Jiri Slaby
This patch has been added to the 3.12 stable tree. If you have any objections, please let us know. === [ Upstream commit a4b8e71b05c27bae6bad3bdecddbc6b68a3ad8cf ] Most of getsockopt handlers in net/sctp/socket.c check len against sizeof some structure like: if (len < sizeof(

Re: [PATCH v2] cpsw: ethtool: add support for getting/setting EEE registers

2016-11-24 Thread Yegor Yefremov
On Wed, Nov 23, 2016 at 9:15 PM, Florian Fainelli wrote: > On 11/23/2016 12:08 PM, Yegor Yefremov wrote: >> On Wed, Nov 23, 2016 at 6:33 PM, Florian Fainelli >> wrote: >>> On 11/23/2016 06:38 AM, yegorsli...@googlemail.com wrote: From: Yegor Yefremov Add the ability to query and

[PATCH 2/4] net: thunderx: Add ethtool support for supported ports and link modes.

2016-11-24 Thread sunil . kovvuri
From: Thanneeru Srinivasulu Signed-off-by: Thanneeru Srinivasulu Signed-off-by: Sunil Goutham --- drivers/net/ethernet/cavium/thunder/nic.h | 2 ++ drivers/net/ethernet/cavium/thunder/nic_main.c | 1 + .../net/ethernet/cavium/thunder/nicvf_ethtool.c| 36 -

[PATCH 4/4] net: thunderx: Pause frame support

2016-11-24 Thread sunil . kovvuri
From: Sunil Goutham Enable pause frames on both Rx and Tx side, configure pause interval e.t.c. Also support for enable/disable pause frames on Rx/Tx via ethtool has been added. Signed-off-by: Sunil Goutham --- drivers/net/ethernet/cavium/thunder/nic.h | 17 +++ drivers/net/ethern

RE: [RFC PATCH v2 1/2] macb: Add 1588 support in Cadence GEM.

2016-11-24 Thread Andrei.Pistirica
> -Original Message- > From: Richard Cochran [mailto:richardcoch...@gmail.com] > Sent: Wednesday, November 23, 2016 11:03 PM > To: Andrei Pistirica - M16132 > Cc: netdev@vger.kernel.org; linux-ker...@vger.kernel.org; linux-arm- > ker...@lists.infradead.org; da...@davemloft.net; > nicolas.

[PATCH] net: ethtool: don't require CAP_NET_ADMIN for ETHTOOL_GLINKSETTINGS

2016-11-24 Thread Miroslav Lichvar
The ETHTOOL_GLINKSETTINGS command is deprecating the ETHTOOL_GSET command and likewise it shouldn't require the CAP_NET_ADMIN capability. Signed-off-by: Miroslav Lichvar --- net/core/ethtool.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/core/ethtool.c b/net/core/ethtool.c index 97748

Re: [PATCH 3/5] ath10k: Remove unused wmi_p2p_noa_descriptor 'noa' in wmi-tlv

2016-11-24 Thread Michal Kazior
On 24 November 2016 at 09:01, Kirtika Ruchandani wrote: > Commit ca996ec56608 (ath10k: implement wmi-tlv backend) > introduced ath10k_wmi_tlv_op_gen_vdev_start() where > 'struct wmi_p2p_noa_descriptor *noa' is defined and set but not used. > Compiling with W=1 gives the following warning, fix it.

Re: [Patch net-next] net_sched: move the empty tp check from ->destroy() to ->delete()

2016-11-24 Thread Daniel Borkmann
On 11/24/2016 09:29 AM, Roi Dayan wrote: Hi, I'm testing this patch with KASAN enabled and got into a new kernel crash I didn't hit before. [ 1860.725065] == [ 1860.733893] BUG: KASAN: use-after-free in __netif_receive_skb_core+

[PATCH 3/3] tools/virtio: use {READ,WRITE}_ONCE() in uaccess.h

2016-11-24 Thread Mark Rutland
As a step towards killing off ACCESS_ONCE, use {READ,WRITE}_ONCE() for the virtio tools uaccess primitives, pulling these in from . With this done, we can kill off the now-unused ACCESS_ONCE() definition. Signed-off-by: Mark Rutland Cc: Jason Wang Cc: Michael S. Tsirkin Cc: linux-ker...@vger.k

[PATCH 1/3] tools/virtio: fix READ_ONCE()

2016-11-24 Thread Mark Rutland
The virtio tools implementation of READ_ONCE() has a single parameter called 'var', but erroneously refers to 'val' for its cast, and thus won't work unless there's a variable of the correct type that happens to be called 'var'. Fix this with s/var/val/, making READ_ONCE() work as expected regardl

[PATCH 2/3] vringh: kill off ACCESS_ONCE()

2016-11-24 Thread Mark Rutland
Despite living under drivers/ vringh.c is also used as part of the userspace virtio tools. Before we can kill off the ACCESS_ONCE()definition in the tools, we must convert vringh.c to use {READ,WRITE}_ONCE(). This patch does so, along with the required include of for the relevant definitions. The

[PATCH 0/3] virtio/vringh: kill off ACCESS_ONCE()

2016-11-24 Thread Mark Rutland
For several reasons, it would be beneficial to kill off ACCESS_ONCE() tree-wide, in favour of {READ,WRITE}_ONCE(). These work with aggregate types, more obviously document their intended behaviour, and are necessary for tools like KTSAN to work correctly (as otherwise reads and writes cannot be ins

Re: stmmac ethernet in kernel 4.9-rc6: coalescing related pauses.

2016-11-24 Thread Pavel Machek
Hi! What is going on with stmmac_tso_xmit() vs. stmmac_xmit()? One seems to be copy of another, with subtle differences -- like calling netif_queue_stopped() under spin_lock(&priv->tx_lock), or not. What is going on with all these likely()s? Likely new hardware owners will not be happy... or anyo

[PATCH] igb: Explicitly select page 0 at initialization

2016-11-24 Thread Matwey V. Kornilov
The functions igb_read_phy_reg_gs40g/igb_write_phy_reg_gs40g (which were removed in 2a3cdea) explicitly selected the required page at every phy_reg access. Currently, igb_get_phy_id_82575 relays on the fact that page 0 is already selected. The assumption is not fulfilled for my Lex 3I380CW motherbo

Re: stmmac ethernet in kernel 4.9-rc6: coalescing related pauses.

2016-11-24 Thread Pavel Machek
Hi! > What is going on with all these likely()s? Likely new hardware owners > will not be happy... or anyone running a lot of jumbo frames. (Perhaps > CPU's branch prediction can do better job here, without explicit hints?) > > if (unlikely(is_jumbo) && likely(priv->synopsys_id < >

Re: [PATCH] igb: Explicitly select page 0 at initialization

2016-11-24 Thread Sergei Shtylyov
Hello. On 11/24/2016 1:32 PM, Matwey V. Kornilov wrote: The functions igb_read_phy_reg_gs40g/igb_write_phy_reg_gs40g (which were removed in 2a3cdea) explicitly selected the required page at every phy_reg This is not the way to cite a commit -- you need to specify at least 12 digits and fo

[PATCH] stmmac ethernet: unify locking

2016-11-24 Thread Pavel Machek
Make locking match in both _xmit functions. Signed-off-by: Pavel Machek diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c index 0363db3..1cff258 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c +++ b/drivers/net/

[PATCH v2] ipv6:ipv6_pinfo dereferenced after NULL check

2016-11-24 Thread Manjeet Pawar
From: Rohit Thapliyal np checked for NULL and then dereferenced. It should be modified for NULL case. Signed-off-by: Rohit Thapliyal Signed-off-by: Manjeet Pawar Signed-off-by: Hannes Frederic Sowa Reviewed-by: Akhilesh Kumar --- v1->v2: Modified as per the suggestion of Hannes np ?

[patch] net/mlx5: remove a duplicate condition

2016-11-24 Thread Dan Carpenter
We verified that MLX5_FLOW_CONTEXT_ACTION_COUNT was set on the first line of the function so we don't need to check again here. Signed-off-by: Dan Carpenter --- Not a bugfix so it would go into -next diff --git a/drivers/net/ethernet/mellanox/mlx5/core/fs_core.c b/drivers/net/ethernet/mellanox/

[PATCH] stmmac ethernet: remove cut & paste code

2016-11-24 Thread Pavel Machek
Remove duplicate code from _tx routines. Signed-off-by: Pavel Machek diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c index 1cff258..5cf9cef 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c +++ b/drivers/net/et

Re: [PATCH 2/3] vringh: kill off ACCESS_ONCE()

2016-11-24 Thread Christian Borntraeger
On 11/24/2016 11:25 AM, Mark Rutland wrote: > Despite living under drivers/ vringh.c is also used as part of the userspace > virtio tools. Before we can kill off the ACCESS_ONCE()definition in the tools, > we must convert vringh.c to use {READ,WRITE}_ONCE(). > > This patch does so, along with the

[patch net-next] sfc: remove unneeded variable

2016-11-24 Thread Dan Carpenter
We don't use ->heap_buf after commit 46d1efd852cc ("sfc: remove Software TSO") so let's remove the last traces. Signed-off-by: Dan Carpenter diff --git a/drivers/net/ethernet/sfc/net_driver.h b/drivers/net/ethernet/sfc/net_driver.h index f97f828..fd17bda 100644 --- a/drivers/net/ethernet/sfc/ne

[patch] fsl/fman: fix a leak in tgec_free()

2016-11-24 Thread Dan Carpenter
We set "tgec->cfg" to NULL before passing it to kfree(). There is no need to set it to NULL at all. Let's just delete it. Fixes: 57ba4c9b56d8 ("fsl/fman: Add FMan MAC support") Signed-off-by: Dan Carpenter --- I haven't tested this. It occurs to me that this code might be something to paper ov

[patch -next] cxgb4: leak on error path in setup_sge_txq_uld()

2016-11-24 Thread Dan Carpenter
Freeing "txq_info->uldtxq" is a no-op. We intended to free "txq_info". Fixes: ab677ff4ad15 ("cxgb4: Allocate Tx queues dynamically") Signed-off-by: Dan Carpenter diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_uld.c b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_uld.c index 565a6c6..8098902

Re: [PATCH 1/3] tools/virtio: fix READ_ONCE()

2016-11-24 Thread Cornelia Huck
On Thu, 24 Nov 2016 10:25:12 + Mark Rutland wrote: > The virtio tools implementation of READ_ONCE() has a single parameter called > 'var', but erroneously refers to 'val' for its cast, and thus won't work > unless > there's a variable of the correct type that happens to be called 'var'. > >

Re: [PATCH 2/3] vringh: kill off ACCESS_ONCE()

2016-11-24 Thread Cornelia Huck
On Thu, 24 Nov 2016 10:25:13 + Mark Rutland wrote: > Despite living under drivers/ vringh.c is also used as part of the userspace > virtio tools. Before we can kill off the ACCESS_ONCE()definition in the tools, > we must convert vringh.c to use {READ,WRITE}_ONCE(). > > This patch does so, al

Re: [PATCH 3/3] tools/virtio: use {READ,WRITE}_ONCE() in uaccess.h

2016-11-24 Thread Cornelia Huck
On Thu, 24 Nov 2016 10:25:14 + Mark Rutland wrote: > As a step towards killing off ACCESS_ONCE, use {READ,WRITE}_ONCE() for the > virtio tools uaccess primitives, pulling these in from . > > With this done, we can kill off the now-unused ACCESS_ONCE() definition. > > Signed-off-by: Mark Rut

Re: [PATCH net-next v2] ethtool: Protect {get,set}_phy_tunable with PHY device mutex

2016-11-24 Thread Allan W. Nielsen
On 22/11/16 13:55, Florian Fainelli wrote: > EXTERNAL EMAIL > > > PHY drivers should be able to rely on the caller of {get,set}_tunable to > have acquired the PHY device mutex, in order to both serialize against > concurrent calls of these functions, but also against PHY state machine > changes.

[PATCH 3/4] net: thunderx: Configure RED and backpressure levels

2016-11-24 Thread sunil . kovvuri
From: Sunil Goutham This patch enables moving average calculation of Rx pkt's resources and configures RED and backpressure levels for both CQ and RBDR. Also initialize SQ's CQ_LIMIT properly. Signed-off-by: Sunil Goutham --- drivers/net/ethernet/cavium/thunder/nic_main.c | 9 dr

Re: [patch net-next] sfc: remove unneeded variable

2016-11-24 Thread Bert Kenward
On 24/11/16 11:16, Dan Carpenter wrote: > We don't use ->heap_buf after commit 46d1efd852cc ("sfc: remove Software > TSO") so let's remove the last traces. > > Signed-off-by: Dan Carpenter Acked-by: Bert Kenward

RE: [patch] fsl/fman: fix a leak in tgec_free()

2016-11-24 Thread Madalin-Cristian Bucur
> -Original Message- > From: Dan Carpenter [mailto:dan.carpen...@oracle.com] > Sent: Thursday, November 24, 2016 1:21 PM > To: Madalin-Cristian Bucur ; Igal Liberman > > Cc: netdev@vger.kernel.org; kernel-janit...@vger.kernel.org > Subject: [patch] fsl/fman: fix a leak in tgec_free() > >

Re: net/arp: ARP cache aging failed.

2016-11-24 Thread Hannes Frederic Sowa
On 24.11.2016 10:06, YueHaibing wrote: > On 2016/11/24 15:51, Julian Anastasov wrote: >> >> Hello, >> >> On Wed, 23 Nov 2016, Eric Dumazet wrote: >> >>> On Wed, 2016-11-23 at 15:37 +0100, Hannes Frederic Sowa wrote: >>> Irregardless about the question if bonding should keep the MAC addres

Re: [PATCH net 1/2] r8152: fix the sw rx checksum is unavailable

2016-11-24 Thread Mark Lord
On 16-11-23 02:29 PM, Mark Lord wrote: On 16-11-23 10:12 AM, Hayes Wang wrote: Mark Lord [ml...@pobox.com] [...] What does this code do: static void r8153_set_rx_early_size(struct r8152 *tp) { u32 mtu = tp->netdev->mtu; u32 ocp_data = (agg_buf_sz - mtu - VLAN_ETH_HLEN - VLAN_HL

Aw: Re: [net-next 1/2] net: ethernet: slicoss: add slicoss gigabit ethernet driver

2016-11-24 Thread Lino Sanfilippo
Hi Andrew, Hi Florian > Gesendet: Dienstag, 15. November 2016 um 23:34 Uhr > Von: "Lino Sanfilippo" > An: "Andrew Lunn" > Cc: "Florian Fainelli" , da...@davemloft.net, > char...@alacritech.com, lio...@gmail.com, gre...@linuxfoundation.org, > de...@driverdev.osuosl.org, linux-ker...@vger.kernel

Re: [patch net-next v2 09/11] ipv4: fib: Add an API to request a FIB dump

2016-11-24 Thread Hannes Frederic Sowa
On 24.11.2016 09:47, Ido Schimmel wrote: > On Thu, Nov 24, 2016 at 12:04:57AM +0100, Hannes Frederic Sowa wrote: >> On 23.11.2016 20:53, Ido Schimmel wrote: >>> On Wed, Nov 23, 2016 at 06:47:03PM +0100, Hannes Frederic Sowa wrote: Hmm, I think you need to read the sequence counter under rtnl_l

Re: [Patch net-next] net_sched: move the empty tp check from ->destroy() to ->delete()

2016-11-24 Thread Roi Dayan
On 24/11/2016 12:14, Daniel Borkmann wrote: On 11/24/2016 09:29 AM, Roi Dayan wrote: Hi, I'm testing this patch with KASAN enabled and got into a new kernel crash I didn't hit before. [ 1860.725065] == [ 1860.733893] BUG: KASA

Re: [PATCH net-next] mlx4: reorganize struct mlx4_en_tx_ring

2016-11-24 Thread Tariq Toukan
Hi Eric, Thanks for your patch. On 23/11/2016 1:56 AM, Eric Dumazet wrote: From: Eric Dumazet Goal is to reorganize this critical structure to increase performance. ndo_start_xmit() should only dirty one cache line, and access as few cache lines as possible. Add sp_ (Slow Path) prefix to fie

RE: [PATCH net 1/2] r8152: fix the sw rx checksum is unavailable

2016-11-24 Thread Hayes Wang
Mark Lord [mailto:ml...@pobox.com] > Sent: Wednesday, November 23, 2016 9:41 PM [...] > >static void r8153_set_rx_early_size(struct r8152 *tp) > >{ > >u32 mtu = tp->netdev->mtu; > >u32 ocp_data = (agg_buf_sz - mtu - VLAN_ETH_HLEN - VLAN_HLEN) / 4; > > > >ocp_write_word(tp,

RE: [patch added to 3.12-stable] net: sctp, forbid negative length

2016-11-24 Thread David Laight
From: Jiri Slaby > Sent: 24 November 2016 09:18 > This patch has been added to the 3.12 stable tree. If you have any > objections, please let us know. > > === > > [ Upstream commit a4b8e71b05c27bae6bad3bdecddbc6b68a3ad8cf ] > > Most of getsockopt handlers in net/sctp/socket.c check l

Re: [patch net-next] sfc: remove unneeded variable

2016-11-24 Thread Edward Cree
On 24/11/16 11:16, Dan Carpenter wrote: > We don't use ->heap_buf after commit 46d1efd852cc ("sfc: remove Software > TSO") so let's remove the last traces. > > Signed-off-by: Dan Carpenter > > diff --git a/drivers/net/ethernet/sfc/net_driver.h > b/drivers/net/ethernet/sfc/net_driver.h > index f97

RE: [PATCH net 1/2] r8152: fix the sw rx checksum is unavailable

2016-11-24 Thread Hayes Wang
Mark Lord [mailto:ml...@pobox.com] > Sent: Thursday, November 24, 2016 8:31 PM [...] > Nope. Guard zones did not fix it, so it's probably not a prefetch issue. > Oddly, adding a couple of memory barriers to specific places in the driver > does help, A LOT. Still not 100%, but it did pass 1800 reb

Re: [PATCH iproute2 0/2] tc/cls_flower: Support for ip tunnel metadata set/release/classify

2016-11-24 Thread Jiri Benc
On Mon, 21 Nov 2016 12:20:54 +0200, Amir Vadai wrote: > $ tc filter add dev vxlan0 protocol ip parent : \ > flower \ > enc_src_ip 11.11.0.2 \ > enc_dst_ip 11.11.0.1 \ > enc_key_id 11 \ > dst_ip 11.11.11.1 \ > action tunnel_key release \ > action mirred egress

Re: [patch net-next] sfc: remove unneeded variable

2016-11-24 Thread Dan Carpenter
On Thu, Nov 24, 2016 at 01:22:24PM +, Edward Cree wrote: > On 24/11/16 11:16, Dan Carpenter wrote: > > We don't use ->heap_buf after commit 46d1efd852cc ("sfc: remove Software > > TSO") so let's remove the last traces. > > > > Signed-off-by: Dan Carpenter > > > > diff --git a/drivers/net/ether

[PATCH] net: ieee802154: drop duplicate header delay.h

2016-11-24 Thread Geliang Tang
Drop duplicate header delay.h from adf7242.c. Signed-off-by: Geliang Tang --- drivers/net/ieee802154/adf7242.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ieee802154/adf7242.c b/drivers/net/ieee802154/adf7242.c index 4ff4c7d..3e4c8b2 100644 --- a/drivers/net/ieee802154/adf7242

[PATCH] ibmvnic: drop duplicate header seq_file.h

2016-11-24 Thread Geliang Tang
Drop duplicate header seq_file.h from ibmvnic.c. Signed-off-by: Geliang Tang --- drivers/net/ethernet/ibm/ibmvnic.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/ibm/ibmvnic.c b/drivers/net/ethernet/ibm/ibmvnic.c index 1e486d1..c125966 100644 --- a/drivers/net/ethernet

[PATCH] net/mlx5: drop duplicate header delay.h

2016-11-24 Thread Geliang Tang
Drop duplicate header delay.h from mlx5/core/main.c. Signed-off-by: Geliang Tang --- drivers/net/ethernet/mellanox/mlx5/core/main.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/main.c b/drivers/net/ethernet/mellanox/mlx5/core/main.c index f28df33..d

[PATCH] ath5k: drop duplicate header vmalloc.h

2016-11-24 Thread Geliang Tang
Drop duplicate header vmalloc.h from ath5k/debug.c. Signed-off-by: Geliang Tang --- drivers/net/wireless/ath/ath5k/debug.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath5k/debug.c b/drivers/net/wireless/ath/ath5k/debug.c index 4f8d9ed..d068df5 100644 --- a/drive

[PATCH iproute2 0/3] update ifstat for new stats

2016-11-24 Thread Nogah Frankel
Previously stats were gotten by RTM_GETLINK which return 32 bits based statistics. It support only one type of stats. Lately, a new method to get stats was added - RTM_GETSTATS. It supports ability to choose stats type. The basic stats were changed from 32 bits based to 64 bits based. This patchse

[PATCH iproute2 3/3] ifstat: Add "sw only" extended statistics to ifstat

2016-11-24 Thread Nogah Frankel
Add support for extended statistics of SW only type, for counting only the packets that went via the cpu. (useful for systems with forward offloading). It reads it from filter type IFLA_STATS_LINK_OFFLOAD_XSTATS and sub type IFLA_OFFLOAD_XSTATS_CPU_HIT. It is under the name 'software' (or any shor

[PATCH iproute2 1/3] ifstat: Change interface to get stats

2016-11-24 Thread Nogah Frankel
ifstat used to get it data from the kernel with RTM_GETLINK. Change the interface to get this data to RTM_GETSTATS that supports more stats type beside the default one. It also change the default stats to be 64 bits based. Signed-off-by: Nogah Frankel Reviewed-by: Jiri Pirko --- misc/ifstat.c |

[PATCH iproute2 2/3] ifstat: Add extended statistics to ifstat

2016-11-24 Thread Nogah Frankel
Add extended stats option for ifstat. It supports stats that are in the nesting level as the "normal" stats or one lower, as long as they are in the same struct type as the "normal" stats. Every extension is unaware of data from other extension and is being presented by itself. The extension can be

[PATCH 12/20 v2] net/iucv: Convert to hotplug state machine

2016-11-24 Thread Sebastian Andrzej Siewior
Install the callbacks via the state machine and let the core invoke the callbacks on the already online CPUs. The smp function calls in the online/downprep callbacks are not required as the callback is guaranteed to be invoked on the upcoming/outgoing cpu. Cc: Ursula Braun Cc: "David S. Miller"

Re: [PATCH] net: ieee802154: drop duplicate header delay.h

2016-11-24 Thread Stefan Schmidt
Hello. On 24/11/16 14:58, Geliang Tang wrote: Drop duplicate header delay.h from adf7242.c. Signed-off-by: Geliang Tang --- drivers/net/ieee802154/adf7242.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ieee802154/adf7242.c b/drivers/net/ieee802154/adf7242.c index 4ff4c7d..3e

[net-next PATCH v1 2/2] net: stmmac: dwmac-meson8b: make the RGMII TX delay configurable

2016-11-24 Thread Martin Blumenstingl
Prior to this patch we were using a hardcoded RGMII TX clock delay of 1/4 cycle (= 2ns). This value works for many boards, but unfortunately not for all (due to the way the actual circuit is designed, sometimes because the TX delay is enabled in the PHY, etc.). Making the TX delay on the MAC side c

[net-next PATCH v1 0/2] stmmac: dwmac-meson8b: configurable RGMII TX delay

2016-11-24 Thread Martin Blumenstingl
Currently the dwmac-meson8b stmmac glue driver uses a hardcoded 1/4 cycle TX clock delay. This seems to work fine for many boards (for example Odroid-C2 or Amlogic's reference boards) but there are some others where TX traffic is simply broken. There are probably multiple reasons why it's working o

[net-next PATCH v1 1/2] net: dt-bindings: add RGMII TX delay configuration to meson8b-dwmac

2016-11-24 Thread Martin Blumenstingl
This allows configuring the RGMII TX clock delay. This clock is generated by the Meson 8b / GXBB DWMAC glue. The configuration depends on the actual hardware (no delay may be needed due to the design of the actual circuit, the PHY might add this delay, etc.). The configuration values are provided a

[PATCH] net: stmmac: enable tx queue 0 for gmac4 IPs synthesized with multiple TX queues

2016-11-24 Thread Niklas Cassel
From: Niklas Cassel The dwmac4 IP can synthesized with 1-8 number of tx queues. On an IP synthesized with DWC_EQOS_NUM_TXQ > 1, all txqueues are disabled by default. For these IPs, the bitfield TXQEN is R/W. Always enable tx queue 0. The write will have no effect on IPs synthesized with DWC_EQOS

Re: [RFC PATCH net v2 0/3] Fix OdroidC2 Gigabit Tx link issue

2016-11-24 Thread Martin Blumenstingl
Hi Jerome, On Mon, Nov 21, 2016 at 4:35 PM, Jerome Brunet wrote: > This patchset fixes an issue with the OdroidC2 board (DWMAC + RTL8211F). > Initially reported as a low Tx throughput issue at gigabit speed, the > platform enters LPI too often. This eventually break the link (both Tx > and Rx), a

Re: [PATCH net-next 1/4] net: mvneta: Convert to be 64 bits compatible

2016-11-24 Thread Gregory CLEMENT
Hi Arnd, On jeu., nov. 24 2016, Arnd Bergmann wrote: > On Thursday, November 24, 2016 4:37:36 PM CET Jisheng Zhang wrote: >> solB (a SW shadow cookie) perhaps gives a better performance: in hot path, >> such as mvneta_rx(), the driver accesses buf_cookie and buf_phys_addr of >> rx_desc which i

Re: [PATCH iproute2 0/2] tc/cls_flower: Support for ip tunnel metadata set/release/classify

2016-11-24 Thread Amir Vadai
On Thu, Nov 24, 2016 at 02:38:56PM +0100, Jiri Benc wrote: > On Mon, 21 Nov 2016 12:20:54 +0200, Amir Vadai wrote: > > $ tc filter add dev vxlan0 protocol ip parent : \ > > flower \ > > enc_src_ip 11.11.0.2 \ > > enc_dst_ip 11.11.0.1 \ > > enc_key_id 11 \ > > dst_ip

[PATCH V3 net-next 05/15] smc: CLC handshake (incl. preparation steps)

2016-11-24 Thread Ursula Braun
* CLC (Connection Layer Control) handshake Signed-off-by: Ursula Braun --- net/smc/Makefile | 2 +- net/smc/af_smc.c | 467 ++ net/smc/smc.h | 25 ++- net/smc/smc_clc.c | 251 + net/smc/smc_clc.h | 114 +

[PATCH V3 net-next 01/15] net: introduce keepalive function in struct proto

2016-11-24 Thread Ursula Braun
Direct call of tcp_set_keepalive() function from protocol-agnostic sock_setsockopt() function in net/core/sock.c violates network layering. And newly introduced protocol (SMC-R) will need its own keepalive function. Therefore, add "keepalive" function pointer to "struct proto", and call it from soc

[PATCH V3 net-next 02/15] smc: establish new socket family

2016-11-24 Thread Ursula Braun
* enable smc module loading and unloading * register new socket family * basic smc socket creation and deletion * use backing TCP socket to run CLC (Connection Layer Control) handshake of SMC protocol * Setup for infiniband traffic is implemented in follow-on patches. For now fallback to

[PATCH V3 net-next 03/15] smc: establish pnet table management

2016-11-24 Thread Ursula Braun
From: Thomas Richter Connection creation with SMC-R starts through an internal TCP-connection. The Ethernet interface for this TCP-connection is not restricted to the Ethernet interface of a RoCE device. Any existing Ethernet interface belonging to the same physical net can be used, as long as th

[PATCH V3 net-next 07/15] smc: remote memory buffers (RMBs)

2016-11-24 Thread Ursula Braun
* allocate data RMB memory for sending and receiving * size depends on the maximum socket send and receive buffers * allocated RMBs are kept during life time of the owning link group * map the allocated RMBs to DMA Signed-off-by: Ursula Braun --- net/smc/af_smc.c | 29 ++- net/smc/smc.h

[PATCH V3 net-next 11/15] smc: connection data control (CDC)

2016-11-24 Thread Ursula Braun
send and receive CDC messages (via IB message send and CQE) Signed-off-by: Ursula Braun --- net/smc/Makefile | 1 + net/smc/af_smc.c | 9 ++ net/smc/smc.h | 97 ++ net/smc/smc_cdc.c | 288 + net/smc/smc_cdc.h | 2

[PATCH V3 net-next 06/15] smc: connection and link group creation

2016-11-24 Thread Ursula Braun
* create smc_connection for SMC-sockets * determine suitable link group for a connection * create a new link group if necessary Signed-off-by: Ursula Braun --- net/smc/Makefile | 2 +- net/smc/af_smc.c | 103 ++-- net/smc/smc.h | 36 ++ net/smc/smc_clc.c | 38 +-

[PATCH V3 net-next 00/15] net/smc: Shared Memory Communications - RDMA

2016-11-24 Thread Ursula Braun
Dave, here is now V3 of the SMC-R patches having processed your feedback from end of September. The most important change is the replacement of procfs by a netlink solution in patch 15 similar to sock_diag and inet_diag. New checkpatch warnings are resolved. V3 changes: Patch 05: Remove unneeded

[PATCH V3 net-next 04/15] smc: introduce SMC as an IB-client

2016-11-24 Thread Ursula Braun
* create a list of SMC IB-devices (IB-devices mentioned in PNET table) * determine RoCE device and port belonging to used internal TCP interface according to the PNET table definitions Signed-off-by: Ursula Braun --- net/smc/Makefile | 2 +- net/smc/af_smc.c | 10 net/smc/smc.h

[PATCH V3 net-next 10/15] smc: link layer control (LLC)

2016-11-24 Thread Ursula Braun
send and receive LLC messages CONFIRM_LINK (via IB message send and CQE) Signed-off-by: Ursula Braun --- net/smc/Makefile | 2 +- net/smc/af_smc.c | 94 ++- net/smc/smc_clc.h | 2 + net/smc/smc_core.c | 8 +++ net/smc/smc_core.h | 4 ++ net/smc/smc_llc.c

[PATCH V3 net-next 09/15] smc: initialize IB transport incl. PD, MR, QP, CQ, event, WR

2016-11-24 Thread Ursula Braun
Prepare the link for RDMA transport: Create a queue pair (QP) and move it into the state Ready-To-Receive (RTR). Signed-off-by: Ursula Braun --- net/smc/af_smc.c | 34 ++-- net/smc/smc.h | 1 + net/smc/smc_clc.c | 10 ++- net/smc/smc_core.c | 74 + net/smc/smc_co

[PATCH V3 net-next 13/15] smc: receive data from RMBE

2016-11-24 Thread Ursula Braun
move RMBE data into user space buffer and update managing cursors Signed-off-by: Ursula Braun --- net/smc/Makefile | 2 +- net/smc/af_smc.c | 7 +- net/smc/smc.h | 4 + net/smc/smc_cdc.c | 6 +- net/smc/smc_core.c | 10 +++ net/smc/smc_rx.c | 217

[PATCH V3 net-next 08/15] smc: work request (WR) base for use by LLC and CDC

2016-11-24 Thread Ursula Braun
The base containers for RDMA transport are work requests and completion queue entries processed through Infiniband verbs: * allocate and initialize these areas * map these areas to DMA * implement the basic communication consisting of work request posting and receival of completion queue events

[PATCH V3 net-next 12/15] smc: send data (through RDMA)

2016-11-24 Thread Ursula Braun
copy data to kernel send buffer, and trigger RDMA write Signed-off-by: Ursula Braun --- net/smc/Makefile | 2 +- net/smc/af_smc.c | 13 +- net/smc/smc.h | 1 + net/smc/smc_cdc.c | 7 +- net/smc/smc_tx.c | 438 ++ net/smc/smc_tx.h

Re: [PATCH net-next 1/4] net: mvneta: Convert to be 64 bits compatible

2016-11-24 Thread Marcin Wojtas
Hi Gregory, 2016-11-24 16:01 GMT+01:00 Gregory CLEMENT : > Hi Arnd, > > On jeu., nov. 24 2016, Arnd Bergmann wrote: > >> On Thursday, November 24, 2016 4:37:36 PM CET Jisheng Zhang wrote: >>> solB (a SW shadow cookie) perhaps gives a better performance: in hot path, >>> such as mvneta_rx(), the

[PATCH V3 net-next 15/15] smc: netlink interface for SMC sockets

2016-11-24 Thread Ursula Braun
Support for SMC socket monitoring via netlink sockets of protocol NETLINK_SOCK_DIAG. Signed-off-by: Ursula Braun --- include/net/smc.h | 20 include/net/sock.h| 3 + include/uapi/linux/netlink.h | 1 + include/uapi/linux/smc_diag.h | 85 + net/

  1   2   3   >