Re: [PATCH net-next] net: sock_rps_record_flow() is for connected sockets

2016-12-06 Thread Paolo Abeni
On Tue, 2016-12-06 at 19:32 -0800, Eric Dumazet wrote: > From: Eric Dumazet > > Paolo noticed a cache line miss in UDP recvmsg() to access > sk_rxhash, sharing a cache line with sk_drops. > > sk_drops might be heavily incremented by cpus handling a flood targeting > this

Re: [PATCH net-next] net: sock_rps_record_flow() is for connected sockets

2016-12-06 Thread Paolo Abeni
On Tue, 2016-12-06 at 22:47 -0800, Eric Dumazet wrote: > On Tue, 2016-12-06 at 19:32 -0800, Eric Dumazet wrote: > > A follow up patch will provide a static_key (Jump Label) since most > > hosts do not even use RFS. > > Speaking of static_key, it appears we now have GRO on UDP, and this > consumes

[PATCH 1/1] ixgbe: fcoe: return value of skb_linearize should be handled

2016-12-06 Thread Zhouyi Zhou
Signed-off-by: Zhouyi Zhou Reviewed-by: Cong Wang Reviewed-by: Yuval Shaia Reviewed-by: Eric Dumazet --- drivers/net/ethernet/intel/ixgbe/ixgbe_fcoe.c | 6 +-

[net-next 00/20][pull request] 40GbE Intel Wired LAN Driver Updates 2016-12-06

2016-12-06 Thread Jeff Kirsher
This series contains updates to i40e and i40evf only. Filip modifies the i40e to log link speed change and when the link is brought up and down. Mitch replaces i40e_txd_use_count() with a new function which is slightly faster and better documented so the dim witted can better follow the code.

[net-next 17/20] i40e: factor out addition/deletion of VLAN per each MAC address

2016-12-06 Thread Jeff Kirsher
From: Jacob Keller A future refactor of how the PF assigns a PVID to a VF will want to be able to add and remove a block of filters by VLAN without worrying about accidentally triggering the accounting for I40E_VLAN_ANY. Additionally the PVID assignment would like to be

[net-next 08/20] i40e: use unsigned printf format specifier for active_filters count

2016-12-06 Thread Jeff Kirsher
From: Jacob Keller Replace the %d specifier used for printing vsi->active_filters and vsi->promisc_threshold with an unsigned %u format specifier. While it is unlikely in practice that these values will ever reach such a large number they are unsigned values and thus

[net-next 07/20] Changed version from 1.6.21 to 1.6.25

2016-12-06 Thread Jeff Kirsher
From: Bimmy Pujari Signed-off-by: Bimmy Pujari Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/i40e/i40e_main.c | 2 +-

[net-next 03/20] i40e: restore workaround for removing default MAC filter

2016-12-06 Thread Jeff Kirsher
From: Jacob Keller A previous commit 53cb6e9e8949 ("i40e: Removal of workaround for simple MAC address filter deletion") removed a workaround for some firmware versions which was reported to not be necessary in production NICs. Unfortunately this workaround is necessary

[net-next 11/20] i40e: Add functions which apply correct PHY access method for read and write operation

2016-12-06 Thread Jeff Kirsher
From: Michal Kosiarz Depending on external PHY type, register access method should be different. Clause22 or Clause45 can be chosen for different PHYs. Implemented functions apply correct access method for used device. Change-ID:

[net-next 09/20] i40e: Add support for 25G devices

2016-12-06 Thread Jeff Kirsher
From: Carolyn Wyborny Add support for 25G devices - defines and data structures. One tricky part here is that the firmware support for these Devices introduces a mismatch between the PHY type enum and the bitfields for the phy types. This change creates a macro and

[net-next 04/20] i40e/i40evf: napi_poll must return the work done

2016-12-06 Thread Jeff Kirsher
From: Alexander Duyck Currently the function i40e_napi-poll() returns 0 when it clean completely the Rx rings, but this foul budget accounting in core code. Fix this by returning the actual work done, capped to budget - 1, since the core doesn't allow to return the

[net-next 01/20] i40e: Driver prints log message on link speed change

2016-12-06 Thread Jeff Kirsher
From: Filip Sadowski This patch makes the driver log link speed change. Before applying the patch link messages were printed only on state change. Now message is printed when link is brought up or down and when speed changes. Change-ID:

[net-next 12/20] i40e: lock service task correctly

2016-12-06 Thread Jeff Kirsher
From: Mitch Williams The service task lock was being set in the scheduling function, not the actual service task. This would potentially leave the bit set for a long time before the task actually ran. Furthermore, if the service task takes too long, it calls the

[net-next 05/20] i40e: remove code to handle dev_addr specially

2016-12-06 Thread Jeff Kirsher
From: Jacob Keller The netdev->dev_addr MAC filter already exists in the MAC/VLAN hash table, as it is added when we configure the netdev in i40e_configure_netdev. Because we already know that this address will be updated in the hash_for_each loops, we do not need to

[net-next 16/20] i40e: delete filter after adding its replacement when converting

2016-12-06 Thread Jeff Kirsher
From: Jacob Keller Fix a subtle issue with the code for converting VID=-1 filters into VID=0 filters when adding a new VLAN. Previously the code deleted the VID=-1 filter, and then added a new VID=0 filter. In the rare case that the addition fails due to -ENOMEM, we end

[net-next 06/20] i40e: Blink LED on 1G BaseT boards

2016-12-06 Thread Jeff Kirsher
From: Henry Tieman Before this patch "ethtool -p" was not blinking the LEDs on boards with 1G BaseT PHYs. This commit identifies 1G BaseT boards as having the LEDs connected to the MAC. Also, renamed the flag to be more descriptive of usage. The flag is now

[net-next 18/20] i40e: use (add|rm)_vlan_all_mac helper functions when changing PVID

2016-12-06 Thread Jeff Kirsher
From: Jacob Keller The current flow for adding or updating the PVID for a VF uses i40e_vsi_add_vlan and i40e_vsi_kill_vlan which each take, then release the hash lock. In addition the two functions also must take special care that they do not perform VLAN mode changes

[net-next 15/20] i40e: refactor i40e_update_filter_state to avoid passing aq_err

2016-12-06 Thread Jeff Kirsher
From: Jacob Keller The current caller of i40e_update_filter_state incorrectly passes aq_ret, an i40e_status variable, instead of the expected aq_err. This happens to work because i40e_status is actually just a typedef integer, and 0 is still the successful return.

[net-next 02/20] i40e: simplify txd use count calculation

2016-12-06 Thread Jeff Kirsher
From: Mitch Williams The i40e_txd_use_count function was fast but confusing. In the comments, it even admits that it's ugly. So replace it with a new function that is (very) slightly faster and has extensive commenting to help the thicker among us (including the

[net-next 13/20] i40e: defeature support for PTP L4 frame detection on XL710

2016-12-06 Thread Jeff Kirsher
From: Jacob Keller A product decision has been made to defeature detection of PTP frames over L4 (UDP) on the XL710 MAC. Do not advertise support for L4 timestamping. Change-ID: I41fbb0f84ebb27c43e23098c08156f2625c6ee06 Signed-off-by: Jacob Keller

[net-next 20/20] i40e: don't allow i40e_vsi_(add|kill)_vlan to operate when VID<1

2016-12-06 Thread Jeff Kirsher
From: Jacob Keller Now that we have the separate i40e_(add|rm)_vlan_all_mac functions, we should not be using the i40e_vsi_kill_vlan or i40e_vsi_add_vlan functions when PVID is set or when VID is less than 1. This allows us to remove some checks in i40e_vsi_add_vlan and

[net-next 19/20] i40e: move all updates for VLAN mode into i40e_sync_vsi_filters

2016-12-06 Thread Jeff Kirsher
From: Jacob Keller In a similar fashion to how we handled exiting VLAN mode, move the logic in i40e_vsi_add_vlan into i40e_sync_vsi_filters. Extract this logic into its own function for ease of understanding as it will become quite complex. The new function,

[net-next 14/20] i40e: recalculate vsi->active_filters from hash contents

2016-12-06 Thread Jeff Kirsher
From: Jacob Keller Previous code refactors have accidentally caused issues with the counting of active_filters. Avoid similar issues in the future by simply re-counting the active filters every time after we handle add and delete of all the filters. Additionally this

[net-next 10/20] i40e: Add FEC for 25g

2016-12-06 Thread Jeff Kirsher
From: Carolyn Wyborny This patch adds adminq support for Forward Error Correction ("FEC")for 25g products. Change-ID: Iaff4910737c239d2c730e5c22a313ce9c37d3964 Signed-off-by: Carolyn Wyborny Signed-off-by: Mitch Williams

Re: [PATCH 10/10] virtio: enable endian checks for sparse builds

2016-12-06 Thread Christoph Hellwig
On Tue, Dec 06, 2016 at 05:41:05PM +0200, Michael S. Tsirkin wrote: > __CHECK_ENDIAN__ isn't on by default presumably because > it triggers too many sparse warnings for correct code. > But virtio is now clean of these warnings, and > we want to keep it this way - enable this for > sparse builds. >

Re: [PATCH net-next v2 0/7] bnxt_en: Add interface to support RDMA driver.

2016-12-06 Thread Christoph Hellwig
On Wed, Dec 07, 2016 at 12:26:14AM -0500, Michael Chan wrote: > This series adds an interface to support a brand new RDMA driver bnxt_re. > The first step is to re-arrange some code so that pci_enable_msix() can > be called during pci probe. The purpose is to allow the RDMA driver to > initialize

Re: linux-next: manual merge of the staging tree with the net-next tree

2016-12-06 Thread Greg KH
On Wed, Dec 07, 2016 at 03:04:47PM +1100, Stephen Rothwell wrote: > Hi Greg, > > Today's linux-next merge of the staging tree got a conflict in: > > drivers/staging/slicoss/slicoss.c > > between commit: > > a52ad514fdf3 ("net: deprecate eth_change_mtu, remove usage") > > from the net-next

[net-next] icmp: correct return value of icmp_rcv()

2016-12-06 Thread Zhang Shengju
Currently, icmp_rcv() always return zero on a packet delivery upcall. To make its behavior more compliant with the way this API should be used, this patch changes this to let it return NET_RX_SUCCESS when the packet is proper handled, and NET_RX_DROP otherwise. Signed-off-by: Zhang Shengju

Re: [PATCH] net: return value of skb_linearize should be handled in Linux kernel

2016-12-06 Thread Eric Dumazet
On Tue, 2016-12-06 at 15:10 +0800, Zhouyi Zhou wrote: > kmalloc_reserve may fail to allocate memory inside skb_linearize, > which means skb_linearize's return value should not be ignored. > Following patch correct the uses of skb_linearize. > > Compiled in x86_64 > > Signed-off-by: Zhouyi Zhou

Re: [PATCH net-next] net: sock_rps_record_flow() is for connected sockets

2016-12-06 Thread Eric Dumazet
On Tue, 2016-12-06 at 19:32 -0800, Eric Dumazet wrote: > A follow up patch will provide a static_key (Jump Label) since most > hosts do not even use RFS. Speaking of static_key, it appears we now have GRO on UDP, and this consumes a considerable amount of cpu cycles. Turning off GRO allows me to

Re: [PATCH] net: return value of skb_linearize should be handled in Linux kernel

2016-12-06 Thread Zhouyi Zhou
On Wed, Dec 7, 2016 at 1:02 PM, Cong Wang wrote: > On Mon, Dec 5, 2016 at 11:10 PM, Zhouyi Zhou wrote: >> diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_fcoe.c >> b/drivers/net/ethernet/intel/ixgbe/ixgbe_fcoe.c >> index 2a653ec..ab787cb

Re: [PATCH 10/10] virtio: enable endian checks for sparse builds

2016-12-06 Thread Johannes Berg
On Tue, 2016-12-06 at 17:41 +0200, Michael S. Tsirkin wrote: > It seems that there should be a better way to do it, > but this works too. In some cases there might be: > --- a/drivers/s390/virtio/Makefile > +++ b/drivers/s390/virtio/Makefile > @@ -6,6 +6,8 @@ >  # it under the terms of the GNU

Re: Oops with CONFIG_VMAP_STCK and bond device + virtio-net

2016-12-06 Thread Cong Wang
On Mon, Dec 5, 2016 at 3:53 PM, Laura Abbott wrote: > This looks like an issue with CONFIG_VMAP_STACK since bond_enslave uses > struct sockaddr from the stack and virtnet_set_mac_address calls > sg_init_one which triggers BUG_ON(!virt_addr_valid(buf)); > > I know there have

[PATCH v3 net-next 1/4] bpf: xdp: Allow head adjustment in XDP prog

2016-12-06 Thread Martin KaFai Lau
This patch allows XDP prog to extend/remove the packet data at the head (like adding or removing header). It is done by adding a new XDP helper bpf_xdp_adjust_head(). It also renames bpf_helper_changes_skb_data() to bpf_helper_changes_pkt_data() to better reflect that XDP prog does not work on

[PATCH v3 net-next 4/4] bpf: xdp: Add XDP example for head adjustment

2016-12-06 Thread Martin KaFai Lau
The XDP prog checks if the incoming packet matches any VIP:PORT combination in the BPF hashmap. If it is, it will encapsulate the packet with a IPv4/v6 header as instructed by the value of the BPF hashmap and then XDP_TX it out. The VIP:PORT -> IP-Encap-Info can be specified by the cmd args of

[PATCH v3 net-next 3/4] mlx4: xdp: Reserve headroom for receiving packet when XDP prog is active

2016-12-06 Thread Martin KaFai Lau
Reserve XDP_PACKET_HEADROOM for packet and enable bpf_xdp_adjust_head() support. This patch only affects the code path when XDP is active. After testing, the tx_dropped counter is incremented if the xdp_prog sends more than wire MTU. Signed-off-by: Martin KaFai Lau ---

[PATCH v3 net-next 0/4]: Allow head adjustment in XDP prog

2016-12-06 Thread Martin KaFai Lau
This series adds a helper to allow head adjusting in XDP prog. mlx4 driver has been modified to support this feature. An example is written to encapsulate a packet with an IPv4/v6 header and then XDP_TX it out. v3: 1. Check if the driver supports head adjustment before setting the xdp_prog

[PATCH v3 net-next 2/4] mlx4: xdp: Allow raising MTU up to one page minus eth and vlan hdrs

2016-12-06 Thread Martin KaFai Lau
When XDP is active in mlx4, mlx4 is using one page/pkt. At the same time (i.e. when XDP is active), it is currently limiting MTU to be FRAG_SZ0 - ETH_HLEN - (2 * VLAN_HLEN) which is 1514 in x86. AFAICT, we can at least raise the MTU limit up to PAGE_SIZE - ETH_HLEN - (2 * VLAN_HLEN) which this

Re: [PATCH 10/10] virtio: enable endian checks for sparse builds

2016-12-06 Thread Jason Wang
On 2016年12月06日 23:41, Michael S. Tsirkin wrote: __CHECK_ENDIAN__ isn't on by default presumably because it triggers too many sparse warnings for correct code. But virtio is now clean of these warnings, and we want to keep it this way - enable this for sparse builds. Signed-off-by: Michael S.

[PATCH net-next v2 4/7] bnxt_en: Improve completion ring allocation for VFs.

2016-12-06 Thread Michael Chan
All available remaining completion rings not used by the PF should be made available for the VFs so that there are enough rings in the VF to support RDMA. The earlier workaround code of capping the rings by the statistics context is removed. When SRIOV is disabled, call a new function

[PATCH net-next v2 6/7] bnxt_en: Refactor the driver registration function with firmware.

2016-12-06 Thread Michael Chan
The driver register function with firmware consists of passing version information and registering for async events. To support the RDMA driver, the async events that we need to register may change. Separate the driver register function into 2 parts so that we can just update the async events

[PATCH net-next v2 5/7] bnxt_en: Reserve RDMA resources by default.

2016-12-06 Thread Michael Chan
If the device supports RDMA, we'll setup network default rings so that there are enough minimum resources for RDMA, if possible. However, the user can still increase network rings to the max if he wants. The actual RDMA resources won't be reserved until the RDMA driver registers. v2: Fix

[PATCH net-next v2 7/7] bnxt_en: Add interface to support RDMA driver.

2016-12-06 Thread Michael Chan
Since the network driver and RDMA driver operate on the same PCI function, we need to create an interface to allow the RDMA driver to share resources with the network driver. 1. Create a new bnxt_en_dev struct which will be returned by bnxt_ulp_probe() upon success. After that, all calls from

[PATCH net-next v2 2/7] bnxt_en: Enable MSIX early in bnxt_init_one().

2016-12-06 Thread Michael Chan
To better support the new RDMA driver, we need to move pci_enable_msix() from bnxt_open() to bnxt_init_one(). This way, MSIX vectors are available to the RDMA driver whether the network device is up or down. Part of the existing bnxt_setup_int_mode() function is now refactored into a new

[PATCH net-next v2 3/7] bnxt_en: Move function reset to bnxt_init_one().

2016-12-06 Thread Michael Chan
Now that MSIX is enabled in bnxt_init_one(), resources may be allocated by the RDMA driver before the network device is opened. So we cannot do function reset in bnxt_open() which will clear all the resources. The proper place to do function reset now is in bnxt_init_one(). If we get AER, we'll

[PATCH net-next v2 1/7] bnxt_en: Add bnxt_set_max_func_irqs().

2016-12-06 Thread Michael Chan
By refactoring existing code into this new function. The new function will be used in subsequent patches. v2: Fixed compile warning when CONFIG_BNXT_SRIOV is not set. Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 17 +++--

[PATCH net-next v2 0/7] bnxt_en: Add interface to support RDMA driver.

2016-12-06 Thread Michael Chan
This series adds an interface to support a brand new RDMA driver bnxt_re. The first step is to re-arrange some code so that pci_enable_msix() can be called during pci probe. The purpose is to allow the RDMA driver to initialize and stay initialized whether the netdev is up or down. Then we make

Re: [PATCH] net: wireless: realtek: constify rate_control_ops structures

2016-12-06 Thread Jes Sorensen
Larry Finger writes: > On 12/02/2016 03:50 AM, Bhumika Goyal wrote: >> The structures rate_control_ops are only passed as an argument to the >> functions ieee80211_rate_control_{register/unregister}. This argument is >> of type const, so rate_control_ops having this

Re: [PATCH] net: return value of skb_linearize should be handled in Linux kernel

2016-12-06 Thread Cong Wang
On Mon, Dec 5, 2016 at 11:10 PM, Zhouyi Zhou wrote: > diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_fcoe.c > b/drivers/net/ethernet/intel/ixgbe/ixgbe_fcoe.c > index 2a653ec..ab787cb 100644 > --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_fcoe.c > +++

[PATCH net] phy: Don't increment MDIO bus refcount unless it's a different owner

2016-12-06 Thread Florian Fainelli
Commit 3e3aaf649416 ("phy: fix mdiobus module safety") fixed the way we dealt with MDIO bus module reference count, but sort of introduced a regression in that, if an Ethernet driver registers its own MDIO bus driver, as is common, we will end up with the Ethernet driver's module->refnct set to 1,

Re: [PATCH 09/10] vsock/virtio: fix src/dst cid format

2016-12-06 Thread Jason Wang
On 2016年12月06日 23:41, Michael S. Tsirkin wrote: These fields are 64 bit, using le32_to_cpu and friends on these will not do the right thing. Fix this up. Cc: sta...@vger.kernel.org Signed-off-by: Michael S. Tsirkin --- net/vmw_vsock/virtio_transport_common.c | 14

[PATCH net-next 1/1] driver: macvlan: Remove the rcu member of macvlan_port

2016-12-06 Thread fgao
From: Gao Feng When free macvlan_port in macvlan_port_destroy, it is safe to free directly because netdev_rx_handler_unregister could enforce one grace period. So it is unnecessary to use kfree_rcu for macvlan_port. Signed-off-by: Gao Feng ---

Re: [PATCH 08/10] vsock/virtio: mark an internal function static

2016-12-06 Thread Jason Wang
On 2016年12月06日 23:41, Michael S. Tsirkin wrote: virtio_transport_alloc_pkt is only used locally, make it static. Signed-off-by: Michael S. Tsirkin --- net/vmw_vsock/virtio_transport_common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH 07/10] vsock/virtio: add a missing __le annotation

2016-12-06 Thread Jason Wang
On 2016年12月06日 23:40, Michael S. Tsirkin wrote: guest cid is read from config space, therefore it's in little endian format and is treated as such, annotate it accordingly. Signed-off-by: Michael S. Tsirkin --- net/vmw_vsock/virtio_transport.c | 2 +- 1 file changed, 1

Re: [PATCH 06/10] vhost: add missing __user annotations

2016-12-06 Thread Jason Wang
On 2016年12月06日 23:40, Michael S. Tsirkin wrote: Several vhost functions were missing __user annotations on pointers, causing sparse warnings. Fix this up. Signed-off-by: Michael S. Tsirkin --- drivers/vhost/vhost.c | 10 +- 1 file changed, 5 insertions(+), 5

Re: [PATCH 05/10] vhost: make interval tree static inline

2016-12-06 Thread Jason Wang
On 2016年12月06日 23:40, Michael S. Tsirkin wrote: vhost_umem_interval_tree is only used locally within vhost.c, mark it static. As some functions generated go unused, this triggers warnings unless we also mark it inline. Signed-off-by: Michael S. Tsirkin ---

[net-next][PATCH v2 13/18] RDS: RDMA: Fix the composite message user notification

2016-12-06 Thread Santosh Shilimkar
When application sends an RDS RDMA composite message consist of RDMA transfer to be followed up by non RDMA payload, it expect to be notified *only* when the full message gets delivered. RDS RDMA notification doesn't behave this way though. Thanks to Venkat for debug and root casuing the issue

[net-next][PATCH v2 04/18] RDS: IB: make the transport retry count smallest

2016-12-06 Thread Santosh Shilimkar
Transport retry is not much useful since it indicate packet loss in fabric so its better to failover fast rather than longer retry. Signed-off-by: Santosh Shilimkar --- net/rds/ib.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/rds/ib.h

[net-next][PATCH v2 10/18] RDS: IB: track and log active side endpoint in connection

2016-12-06 Thread Santosh Shilimkar
Useful to know the active and passive end points in a RDS IB connection. Signed-off-by: Santosh Shilimkar --- net/rds/ib.h| 3 +++ net/rds/ib_cm.c | 11 +++ 2 files changed, 10 insertions(+), 4 deletions(-) diff --git a/net/rds/ib.h b/net/rds/ib.h

[net-next][PATCH v2 08/18] RDS: IB: split the mr registration and invalidation path

2016-12-06 Thread Santosh Shilimkar
MR invalidation in RDS is done in background thread and not in data path like registration. So break the dependency between them which helps to remove the performance bottleneck. Signed-off-by: Santosh Shilimkar --- net/rds/ib.h | 4 +++- net/rds/ib_cm.c |

[net-next][PATCH v2 12/18] RDS: IB: Add vector spreading for cqs

2016-12-06 Thread Santosh Shilimkar
Based on available device vectors, allocate cqs accordingly to get better spread of completion vectors which helps performace great deal.. Signed-off-by: Santosh Shilimkar --- net/rds/ib.c| 11 +++ net/rds/ib.h| 5 + net/rds/ib_cm.c | 40

[net-next][PATCH v2 16/18] RDS: make message size limit compliant with spec

2016-12-06 Thread Santosh Shilimkar
From: Avinash Repaka RDS support max message size as 1M but the code doesn't check this in all cases. Patch fixes it for RDMA & non-RDMA and RDS MR size and its enforced irrespective of underlying transport. Signed-off-by: Avinash Repaka

[net-next][PATCH v2 14/18] RDS: IB: fix panic due to handlers running post teardown

2016-12-06 Thread Santosh Shilimkar
Shutdown code reaping loop takes care of emptying the CQ's before they being destroyed. And once tasklets are killed, the hanlders are not expected to run. But because of core tasklet code issues, tasklet handler could still run even after tasklet_kill, RDS IB shutdown code already reaps the CQs

[net-next][PATCH v2 11/18] RDS: IB: add few useful cache stasts

2016-12-06 Thread Santosh Shilimkar
Tracks the ib receive cache total, incoming and frag allocations. Signed-off-by: Santosh Shilimkar --- net/rds/ib.h | 7 +++ net/rds/ib_recv.c | 6 ++ net/rds/ib_stats.c | 2 ++ 3 files changed, 15 insertions(+) diff --git a/net/rds/ib.h

[net-next][PATCH v2 09/18] RDS: RDMA: silence the use_once mr log flood

2016-12-06 Thread Santosh Shilimkar
In absence of extension headers, message log will keep flooding the console. As such even without use_once we can clean up the MRs so its not really an error case message so make it debug message Signed-off-by: Santosh Shilimkar --- net/rds/rdma.c | 3 ++- 1 file

[net-next][PATCH v2 01/18] RDS: log the address on bind failure

2016-12-06 Thread Santosh Shilimkar
It's useful to know the IP address when RDS fails to bind a connection. Thus, adding it to the error message. Orabug: 21894138 Reviewed-by: Wei Lin Guay Signed-off-by: Santosh Shilimkar --- net/rds/bind.c | 4 ++-- 1 file changed, 2

[net-next][PATCH v2 18/18] RDS: IB: add missing connection cache usage info

2016-12-06 Thread Santosh Shilimkar
rds-tools already support it. Signed-off-by: Santosh Shilimkar --- include/uapi/linux/rds.h | 1 + net/rds/ib.c | 1 + 2 files changed, 2 insertions(+) diff --git a/include/uapi/linux/rds.h b/include/uapi/linux/rds.h index 3833113..410ae3c 100644 ---

[net-next][PATCH v2 15/18] RDS: add stat for socket recv memory usage

2016-12-06 Thread Santosh Shilimkar
From: Venkat Venkatsubra Tracks the receive side memory added to scokets and removed from sockets. Signed-off-by: Venkat Venkatsubra Signed-off-by: Santosh Shilimkar --- net/rds/rds.h | 3 +++

linux-next: manual merge of the staging tree with the net-next tree

2016-12-06 Thread Stephen Rothwell
Hi Greg, Today's linux-next merge of the staging tree got a conflict in: drivers/staging/slicoss/slicoss.c between commit: a52ad514fdf3 ("net: deprecate eth_change_mtu, remove usage") from the net-next tree and commit: 0af72df267f2 ("staging: slicoss: remove the staging driver") from

[net-next][PATCH v2 17/18] RDS: add receive message trace used by application

2016-12-06 Thread Santosh Shilimkar
Socket option to tap receive path latency in various stages in nano seconds. It can be enabled on selective sockets using using SO_RDS_MSG_RXPATH_LATENCY socket option. RDS will return the data to application with RDS_CMSG_RXPATH_LATENCY in defined format. Scope is left to add more trace points

[net-next][PATCH v2 06/18] RDS: RDMA: start rdma listening after init

2016-12-06 Thread Santosh Shilimkar
From: Qing Huang This prevents RDS from handling incoming rdma packets before RDS completes initializing its recv/send components. Signed-off-by: Qing Huang Signed-off-by: Santosh Shilimkar ---

[net-next][PATCH v2 03/18] RDS: IB: include faddr in connection log

2016-12-06 Thread Santosh Shilimkar
Also use pr_* for it. Signed-off-by: Santosh Shilimkar --- net/rds/ib_cm.c | 19 +-- net/rds/ib_recv.c | 4 ++-- net/rds/ib_send.c | 4 ++-- 3 files changed, 13 insertions(+), 14 deletions(-) diff --git a/net/rds/ib_cm.c b/net/rds/ib_cm.c index

[net-next][PATCH v2 07/18] RDS: RDMA: return appropriate error on rdma map failures

2016-12-06 Thread Santosh Shilimkar
The first message to a remote node should prompt a new connection even if it is RDMA operation. For RDMA operation the MR mapping can fail because connections is not yet up. Since the connection establishment is asynchronous, we make sure the map failure because of unavailable connection reach to

[net-next][PATCH v2 00/18] net: RDS updates

2016-12-06 Thread Santosh Shilimkar
v1->v2: Re-aligned indentation in patch 'RDS: mark few internal functions Series consist of: - RDMA transport fixes for map failure, listen sequence, handler panic and composite message notification. - Couple of sparse fixes. - Message logging improvements for bind failure, use once mr

[net-next][PATCH v2 02/18] RDS: mark few internal functions static to make sparse build happy

2016-12-06 Thread Santosh Shilimkar
Fixes below warnings: warning: symbol 'rds_send_probe' was not declared. Should it be static? warning: symbol 'rds_send_ping' was not declared. Should it be static? warning: symbol 'rds_tcp_accept_one_path' was not declared. Should it be static? warning: symbol 'rds_walk_conn_path_info' was not

[net-next][PATCH v2 05/18] RDS: RDMA: fix the ib_map_mr_sg_zbva() argument

2016-12-06 Thread Santosh Shilimkar
Fixes warning: Using plain integer as NULL pointer Signed-off-by: Santosh Shilimkar --- net/rds/ib_frmr.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/net/rds/ib_frmr.c b/net/rds/ib_frmr.c index d921adc..66b3d62 100644 ---

[PATCH net-next 0/2] Initial driver for Synopsys DWC XLGMAC

2016-12-06 Thread Jie Deng
This series provides the support for 25/40/50/100 GbE devices using Synopsys DWC Enterprise Ethernet (XLGMAC). The first patch adds support for Synopsys XLGMII. The second patch provides the initial driver for Synopsys XLGMAC The driver has three layers by refactoring AMD XGBE. dwc-eth-xxx.x

[PATCH net-next 1/2] net: phy: add extension of phy-mode for XLGMII

2016-12-06 Thread Jie Deng
This patch adds phy-mode support for Synopsys XLGMAC Signed-off-by: Jie Deng --- Documentation/devicetree/bindings/net/ethernet.txt | 1 + include/linux/phy.h| 3 +++ 2 files changed, 4 insertions(+) diff --git

Re: [PATCH v2] tun: Use netif_receive_skb instead of netif_rx

2016-12-06 Thread Jason Wang
On 2016年12月07日 11:25, David Miller wrote: From: Jason Wang Date: Wed, 7 Dec 2016 11:21:11 +0800 David, looks like this commit is not in net-next.git. Please help to check. Take a look, it should be there now. Yes, thanks.

[PATCH net-next] net: sock_rps_record_flow() is for connected sockets

2016-12-06 Thread Eric Dumazet
From: Eric Dumazet Paolo noticed a cache line miss in UDP recvmsg() to access sk_rxhash, sharing a cache line with sk_drops. sk_drops might be heavily incremented by cpus handling a flood targeting this socket. We might place sk_drops on a separate cache line, but lets try

Re: [PATCH v2] tun: Use netif_receive_skb instead of netif_rx

2016-12-06 Thread Jason Wang
On 2016年12月02日 03:43, David Miller wrote: From: Andrey Konovalov Date: Thu, 1 Dec 2016 10:34:40 +0100 This patch changes tun.c to call netif_receive_skb instead of netif_rx when a packet is received (if CONFIG_4KSTACKS is not enabled to avoid stack exhaustion). The

Re: [PATCH v2] tun: Use netif_receive_skb instead of netif_rx

2016-12-06 Thread David Miller
From: Jason Wang Date: Wed, 7 Dec 2016 11:21:11 +0800 > David, looks like this commit is not in net-next.git. > > Please help to check. Take a look, it should be there now.

Re: [PATCH 1/1] ixgbe: write flush vfta registers

2016-12-06 Thread zhuyj
After several week tests, your advice still make this bug appear. But my patch make this bug disappear. Zhu Yanjun On Thu, Nov 17, 2016 at 5:33 PM, zhuyj wrote: > Sure. From the following. > " > VLAN Filter. Each bit ‘i’ in register ‘n’ affects packets with VLAN > tags

Re: [PATCH net-next V2 6/7] liquidio CN23XX: VF TX buffers

2016-12-06 Thread David Miller
From: Raghu Vatsavayi Date: Tue, 6 Dec 2016 13:06:06 -0800 > diff --git a/drivers/net/ethernet/cavium/liquidio/lio_vf_main.c > b/drivers/net/ethernet/cavium/liquidio/lio_vf_main.c > index cf80722..ce5cdcd 100644 > ---

Re: [PATCH net-next 0/2] Add ethtool set regs support

2016-12-06 Thread David Miller
From: Andrew Lunn Date: Wed, 7 Dec 2016 03:41:43 +0100 > On Wed, Dec 07, 2016 at 12:33:08AM +0200, Saeed Mahameed wrote: >> Hi Dave, >> >> This series adds the support for setting device registers from user >> space ethtool. > > Is this not the start of allowing binary only

Re: [PATCH] [v3] net: phy: phy drivers should not set SUPPORTED_[Asym_]Pause

2016-12-06 Thread Timur Tabi
Florian Fainelli wrote: which is why this made me think the & (SUPPORTED_Pause | SUPPPORTED_Asym_Pause) here is most likely redundant? Well, like I said, better safe than sorry. I'd rather keep the &= unless you have a strong objection. -- Sent by an employee of the Qualcomm Innovation

Re: [PATCH v3 0/7] irda: w83977af_ir: Neatening

2016-12-06 Thread David Miller
From: Joe Perches Date: Tue, 6 Dec 2016 10:15:59 -0800 > Originally on top of Arnd's overly long udelay patches because I > noticed a misindented block. That's now already fixed along with some > other whitespace problems. These patches are the remainder style > issues from

Re: [PATCH net-next 0/2] Add ethtool set regs support

2016-12-06 Thread Andrew Lunn
On Wed, Dec 07, 2016 at 12:33:08AM +0200, Saeed Mahameed wrote: > Hi Dave, > > This series adds the support for setting device registers from user > space ethtool. Is this not the start of allowing binary only drivers in user space? Do we want this? > mlx5 driver have registers allowed access

Re: [PATCH] [v3] net: phy: phy drivers should not set SUPPORTED_[Asym_]Pause

2016-12-06 Thread Timur Tabi
Florian Fainelli wrote: + if (phydrv->features & (SUPPORTED_Pause | SUPPORTED_Asym_Pause)) { >+ phydev->supported &= ~(SUPPORTED_Pause | SUPPORTED_Asym_Pause); >+ phydev->supported |= phydrv->features & >+(SUPPORTED_Pause |

Re: [PATCH] [v3] net: phy: phy drivers should not set SUPPORTED_[Asym_]Pause

2016-12-06 Thread Florian Fainelli
On 12/06/2016 05:50 PM, Timur Tabi wrote: > Florian Fainelli wrote: >>> +if (phydrv->features & (SUPPORTED_Pause | SUPPORTED_Asym_Pause)) { >>> >+phydev->supported &= ~(SUPPORTED_Pause | >>> SUPPORTED_Asym_Pause); >>> >+phydev->supported |= phydrv->features & >>> >+

[PATCH net-next v3 1/1] driver: ipvlan: Free ipvl_port directly with kfree instead of kfree_rcu

2016-12-06 Thread fgao
From: Gao Feng There are two functions which would free the ipvl_port now. The first is ipvlan_port_create. It frees the ipvl_port in the error handler, so it could kfree it directly. The second is ipvlan_port_destroy. It invokes netdev_rx_handler_unregister which enforces one

Re: [PATCH] [v3] net: phy: phy drivers should not set SUPPORTED_[Asym_]Pause

2016-12-06 Thread Florian Fainelli
On 12/06/2016 04:27 PM, Timur Tabi wrote: > Instead of having individual PHY drivers set the SUPPORTED_Pause and > SUPPORTED_Asym_Pause flags, phylib itself should set those flags, > unless there is a hardware erratum or other special case. During > autonegotiation, the PHYs will determine

Re: [PATCH net-next v2 1/1] driver: ipvlan: Free ipvl_port directly with kfree instead of kfree_rcu

2016-12-06 Thread Gao Feng
Hi Eric, On Tue, Dec 6, 2016 at 11:18 PM, Eric Dumazet wrote: > On Tue, 2016-12-06 at 21:54 +0800, f...@ikuai8.com wrote: >> From: Gao Feng >> >> There is no one which may reference the ipvlan port when free it in >> ipvlan_port_create and

[PATCH] [v3] net: phy: phy drivers should not set SUPPORTED_[Asym_]Pause

2016-12-06 Thread Timur Tabi
Instead of having individual PHY drivers set the SUPPORTED_Pause and SUPPORTED_Asym_Pause flags, phylib itself should set those flags, unless there is a hardware erratum or other special case. During autonegotiation, the PHYs will determine whether to enable pause frame support. Pause frames are

[PATCH net-next] bpf: fix loading of BPF_MAXINSNS sized programs

2016-12-06 Thread Daniel Borkmann
General assumption is that single program can hold up to BPF_MAXINSNS, that is, 4096 number of instructions. It is the case with cBPF and that limit was carried over to eBPF. When recently testing digest, I noticed that it's actually not possible to feed 4096 instructions via bpf(2). The check

Re: [PATCH]net:sched:release lock before tcf_dump_walker() normal return to avoid deadlock

2016-12-06 Thread Cong Wang
On Tue, Dec 6, 2016 at 5:50 AM, Jamal Hadi Salim wrote: > On 16-12-06 12:36 AM, Feng Deng wrote: >> >> From: Feng Deng >> >> release lock before tcf_dump_walker() normal return to avoid deadlock >> > > /Scratching my head. > > I am probably missing something

[PATCH v5 06/13] net: ethernet: ti: cpts: disable cpts when unregistered

2016-12-06 Thread Grygorii Strashko
The cpts now is left enabled after unregistration. Hence, disable it in cpts_unregister(). Signed-off-by: Grygorii Strashko Acked-by: Richard Cochran --- drivers/net/ethernet/ti/cpts.c | 4 1 file changed, 4 insertions(+) diff --git

[PATCH v5 03/13] net: ethernet: ti: cpsw: minimize direct access to struct cpts

2016-12-06 Thread Grygorii Strashko
This will provide more flexibility in changing CPTS internals and also required for further changes. Signed-off-by: Grygorii Strashko --- drivers/net/ethernet/ti/cpsw.c | 28 +++- drivers/net/ethernet/ti/cpts.h | 39

[PATCH v5 00/13] net: ethernet: ti: cpts: update and fixes

2016-12-06 Thread Grygorii Strashko
It is preparation series intended to clean up and optimize TI CPTS driver to facilitate further integration with other TI's SoCs like Keystone 2. Changes in v5: - fixed copy paste error in cpts_release - reworked cc.mult/shift and cc_mult initialization Changes in v4: - fixed build error in

[PATCH v5 02/13] net: ethernet: ti: allow cpts to be built separately

2016-12-06 Thread Grygorii Strashko
TI CPTS IP is used as part of TI OMAP CPSW driver, but it's also present as part of NETCP on TI Keystone 2 SoCs. So, It's required to enable build of CPTS for both this drivers and this can be achieved by allowing CPTS to be built separately. Hence, allow cpts to be built separately and convert

  1   2   3   >