Re: [PATCH] net: marvell: skge: use new api ethtool_{get|set}_link_ksettings

From: Stephen Hemminger Date: Mon, 16 Jan 2017 09:29:51 -0800 > On Sat, 14 Jan 2017 13:08:28 +0100 > Philippe Reynes wrote: > >> The ethtool api {get|set}_settings is deprecated. >> We move this driver to new api {get|set}_link_ksettings. >> >>

[PATCH net-next 9/9] net/mlx4_en: Check the enabling pptx/pprx flags in SET_PORT wrapper flow

From: Shaker Daibes Make sure pptx/pprx mask flag is set using new fields upon set port request. In addition, move this code into a helper function for better code readability. Signed-off-by: Shaker Daibes Signed-off-by: Tariq Toukan

[PATCH net-next 4/9] net/mlx4_core: Add resource alloc/dealloc debugging

From: Matan Barak In order to aid debugging of functions that take a resource but don't put it, add the last function name that successfully grabbed this resource. Signed-off-by: Matan Barak Signed-off-by: Tariq Toukan ---

[PATCH net-next 5/9] net/mlx4_core: Get num_tc using netdev_get_num_tc

From: Alaa Hleihel Avoid reading num_tc directly from struct net_device, but use the helper function netdev_get_num_tc. Fixes: bc6a4744b827 ("net/mlx4_en: num cores tx rings for every UP") Fixes: f5b6345ba8da ("net/mlx4_en: User prio mapping gets corrupted when changing

[PATCH net-next 7/9] net/mlx4_en: Pass user MTU value to Firmware at set port command

From: Shaker Daibes When starting the port, driver will inform Firmware about the actual MTU which does not include implicit headers, such as FCS or VLAN tags. Signed-off-by: Shaker Daibes Signed-off-by: Tariq Toukan ---

[PATCH net-next 8/9] net/mlx4_en: Check the enabling mtu flag in SET_PORT wrapper flow

From: Shaker Daibes Make sure MTU mask flag is set using new field upon set port request. In addition, move this code into a helper function for better code readability. Signed-off-by: Shaker Daibes Signed-off-by: Tariq Toukan

[PATCH net-next 2/9] net/mlx4_core: Device revision support

From: Yishai Hadas The device revision field returned by the NodeInfo MAD is incorrect on ConnectX3 devices. This patch is driver side handling to complete a FW fix added at 2.11.1172. INIT_HCA - bit at offset 0x0C.12 is set to 1 so that FW will report correct device

[PATCH net-next 0/9] mlx4 misc improvements

Hi Dave, This patchset contains several improvements and cleanups from the team to the mlx4 Eth and core drivers. Series generated against net-next commit: dbeaa8c2a4ba stmmac: indent an if statement Thanks, Tariq. Alaa Hleihel (1): net/mlx4_core: Get num_tc using netdev_get_num_tc Ariel

Re: [PATCH] net: marvell: skge: use new api ethtool_{get|set}_link_ksettings

On Sat, 14 Jan 2017 13:08:28 +0100 Philippe Reynes wrote: > The ethtool api {get|set}_settings is deprecated. > We move this driver to new api {get|set}_link_ksettings. > > The callback set_link_ksettings no longer update the value > of advertising, as the struct

Re: [PATCH 1/2] qed: Replace memset with eth_zero_addr

From: "Mintz, Yuval" Date: Mon, 16 Jan 2017 17:05:05 + > Other than the fact these 2 patches change 2 different qed files, That's what I was trying to hint at, the locations within the drivers were the unique element. > is there any significant difference between

[PATCH v2 net-next 2/2] net: mvneta: add BQL support

Tests showed that when whole bandwidth is consumed, the latency for various kind of traffic can reach high values. With saturated link (e.g. with iperf from target to host) simple ping could take significant amount of time. BQL proved to improve this situation when implemented in mvneta driver.

[PATCH v2 net-next 1/2] net: mvneta: add xmit_more support

From: Simon Guinot Basing on xmit_more flag of the skb, TX descriptors can be concatenated before flushing. This commit delay Tx descriptor flush if the queue is running and if there is more skb's to send. A maximum allowed number of descriptors for flushing at once

[PATCH v2 net-next 0/2] mvneta xmit_more and bql support

Hi, This is a delayed v2 of short patchset, which introduces xmit_more and BQL to mvneta driver. The only one change was added in xmit_more support - condition check preventing excessive descriptors concatenation before flushing in HW. Any comments or feedback would be welcome. Best regards,

RE: [PATCH 1/2] qed: Replace memset with eth_zero_addr

> > On Sun, Jan 15, 2017 at 11:38:30PM -0500, David Miller wrote: > >> > >> Please do not ever submit two patches which have the same exact > >> commit header line, as these two patches do. > >> > >> When someone looks into the shortlog of GIT history all they will see > >> is "qed: Replace memset

Re: [PATCH] cpmac: remove hopeless #warning

From: Arnd Bergmann Date: Mon, 16 Jan 2017 14:20:54 +0100 > The #warning was present 10 years ago when the driver first got merged. > As the platform is rather obsolete by now, it seems very unlikely that > the warning will cause anyone to fix the code properly. > > kernelci.org

Re: [PATCH net v3] ravb: do not use zero-length alignment DMA descriptor

From: Sergei Shtylyov Date: Mon, 16 Jan 2017 16:01:49 +0300 > On 01/16/2017 01:45 PM, Simon Horman wrote: > >> From: Masaru Nagai >> >> Due to alignment requirements of the hardware transmissions are split >> into >> two DMA

Re: [PATCH] sfc: Replace memset with eth_zero_addr

From: Edward Cree Date: Mon, 16 Jan 2017 09:35:38 + > On 16/01/17 03:56, Shyam Saini wrote: >> Use eth_zero_addr to assign zero address to the given address array >> instead of memset when the second argument in memset is address >> of zero which makes the code clearer

Re: [PATCH net] mlx4: do not call napi_schedule() without care

From: Tariq Toukan Date: Mon, 16 Jan 2017 11:02:44 +0200 > Thanks Eric. > > On 13/01/2017 6:39 PM, Eric Dumazet wrote: >> From: Eric Dumazet >> >> Disable BH around the call to napi_schedule() to avoid following >> warning >> >> [ 52.095499]

Re: [PATCH 1/2] qed: Replace memset with eth_zero_addr

From: Shyam Saini Date: Mon, 16 Jan 2017 14:54:35 +0530 > On Sun, Jan 15, 2017 at 11:38:30PM -0500, David Miller wrote: >> >> Please do not ever submit two patches which have the same exact commit >> header line, as these two patches do. >> >> When someone looks into

Re: pull request: bluetooth 2017-01-16

From: Johan Hedberg Date: Mon, 16 Jan 2017 09:58:31 +0200 > Here are a couple of important 802.15.4 driver fixes for the 4.10 > kernel. > > Please let me know if there are any issues pulling. Thanks. Pulled, thank you.

[PATCH net 0/3] mlx4 core fixes

Hi Dave, This patchset contains bug fixes from Jack to the mlx4 Core driver. Patch 1 solves a race in the flow of CQ free. Patch 2 moves some qp context flags update to the correct qp transition. Patch 3 eliminates warnings from the path of SRQ_LIMIT that flood the message log, and keeps them

[PATCH net 3/3] net/mlx4_core: Eliminate warning messages for SRQ_LIMIT under SRIOV

From: Jack Morgenstein When running SRIOV, warnings for SRQ LIMIT events flood the Hypervisor's message log when (correct, normally operating) apps use SRQ LIMIT events as a trigger to post WQEs to SRQs. Add more information to the existing debug printout for

[PATCH net 2/3] net/mlx4_core: Fix when to save some qp context flags for dynamic VST to VGT transitions

From: Jack Morgenstein Save the qp context flags byte containing the flag disabling vlan stripping in the RESET to INIT qp transition, rather than in the INIT to RTR transition. Per the firmware spec, the flags in this byte are active in the RESET to INIT transition.

[PATCH net 1/3] net/mlx4_core: Fix racy CQ (Completion Queue) free

From: Jack Morgenstein In function mlx4_cq_completion() and mlx4_cq_event(), the radix_tree_lookup requires a rcu_read_lock. This is mandatory: if another core frees the CQ, it could run the radix_tree_node_rcu_free() call_rcu() callback while its being used by the

Re: [PATCH net-next v2 1/3] net: ipv6: Allow shorthand delete of all nexthops in multipath route

On 1/16/17 8:48 AM, Roopa Prabhu wrote: > Do we really need the flag ?. It seems like delete with just prefix should > delete all the routes in a multipath > route by default... (understand that you have it there to preserve existing > behavior...for people who maybe relying on it. But this

Re: [PATCH net-next v2 1/3] net: ipv6: Allow shorthand delete of all nexthops in multipath route

On 1/15/17, 12:07 PM, David Ahern wrote: > IPv4 allows multipath routes to be deleted using just the prefix and > length. For example: > $ ip ro ls vrf red > unreachable default metric 8192 > 1.1.1.0/24 > nexthop via 10.100.1.254 dev eth1 weight 1 > nexthop via

Re: [PATCH net-next] sctp: remove useless code from sctp_apply_peer_addr_params

On Sat, Jan 14, 2017 at 4:31 AM, Marcelo Ricardo Leitner wrote: > sctp_frag_point() doesn't store anything, and thus just calling it > cannot do anything useful. > > sctp_apply_peer_addr_params is only called by > sctp_setsockopt_peer_addr_params. When operating on an

ANNOUNCE: Netdev 2.1 Call For Proposals Opened!

Folks, We are pleased to announce that the CFP for netdev 2.1 is now open. Netdev 2.1 is a community-driven conference geared towards Linux netheads. Linux kernel networking and user space utilization of the interfaces to the Linux kernel networking subsystem are the focus. If you are using

Re: 4.9.0-rc8: tg3 dead after resume

On Mon, Jan 16, 2017 at 2:15 AM, Siva Reddy Kallam wrote: > Hi, > > Sorry for the late reply. > We don't have exact model. > We tried to reproduce with HP elitebook folio laptop & HP elite thunderbolt > 3 dock. > We observed issue with Thunder bolt bridge. All the

Re: sctp: kernel memory overwrite attempt detected in sctp_getsockopt_assoc_stats

On Mon, Jan 16, 2017 at 3:50 PM, David Laight wrote: > From: Dmitry Vyukov >> Sent: 16 January 2017 14:04 >> >> >> I've enabled CONFIG_HARDENED_USERCOPY_PAGESPAN on syzkaller fuzzer and > ... >> >> The code also takes into account compound pages. As far as I >> >>

Re: [PATCH] net/irda: fix lockdep annotation

On Mon, Jan 16, 2017 at 3:11 PM, kbuild test robot <l...@intel.com> wrote: > Hi Dmitry, > > [auto build test WARNING on net-next/master] > [also build test WARNING on v4.10-rc4 next-20170116] > [if your patch is applied to the wrong git tree, please drop us a note to >

RE: sctp: kernel memory overwrite attempt detected in sctp_getsockopt_assoc_stats

From: Dmitry Vyukov > Sent: 16 January 2017 14:04 > >> >> I've enabled CONFIG_HARDENED_USERCOPY_PAGESPAN on syzkaller fuzzer and ... > >> The code also takes into account compound pages. As far as I > >> understand the intention of the check is to effectively find > >> out-of-bounds copies (e.g.

[PATCH v2] net/irda: fix lockdep annotation

The current annotation uses a global variable as recursion counter. The variable is not atomic nor protected with a mutex, but mutated by multiple threads. This causes lockdep bug reports episodically: BUG: looking up invalid subclass: 4294967295 ... _raw_spin_lock_irqsave_nested+0x120/0x180

Re: [PATCH net-next] sctp: remove unused var from sctp_process_asconf

On Sat, Jan 14, 2017 at 4:27 AM, Marcelo Ricardo Leitner wrote: > Assigned but not used. > > Signed-off-by: Marcelo Ricardo Leitner Reviewed-by: Xin Long > --- > net/sctp/sm_make_chunk.c | 2 -- > 1 file changed, 2

[PATCH net-next v2 1/2] net: AF-specific RTM_GETSTATS attributes

Add the functionality for including address-family-specific per-link stats in RTM_GETSTATS messages. This is done through adding a new IFLA_STATS_AF_SPEC attribute under which address family attributes are nested and then the AF-specific attributes can be further nested. This follows the model of

[PATCH net-next v2 0/2] mpls: Packet stats

This patchset records per-interface packet stats in the MPLS forwarding path and exports them using a nest of attributes root at a new IFLA_STATS_AF_SPEC attribute as part of RTM_GETSTATS messages: [IFLA_STATS_AF_SPEC] -> [AF_MPLS] -> [MPLS_STATS_LINK] -> struct mpls_link_stats The first

[PATCH net-next v2 2/2] mpls: Packet stats

Having MPLS packet stats is useful for observing network operation and for diagnosing network problems. In the absence of anything better, RFC2863 and RFC3813 are used for guidance for which stats to expose and the semantics of them. In particular rx_noroutes maps to in unknown protos in RFC2863.

[PATCH v2 2/3] xen: modify xenstore watch event interface

Today a Xenstore watch event is delivered via a callback function declared as: void (*callback)(struct xenbus_watch *, const char **vec, unsigned int len); As all watch events only ever come with two parameters (path and token) changing the prototype to: void (*callback)(struct

[PATCH v2 0/3] xen: optimize xenbus performance

The xenbus driver used for communication with Xenstore (all kernel accesses to Xenstore and in case of Xenstore living in another domain all accesses of the local domain to Xenstore) is rather simple especially regarding multiple concurrent accesses: they are just being serialized in spite of

Re: [PATCH] net/irda: fix lockdep annotation

Hi Dmitry, [auto build test WARNING on net-next/master] [also build test WARNING on v4.10-rc4 next-20170116] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Dmitry-Vyukov/net-irda-fix-lockdep

[PATCH] ip/xfrm: Fix deleteall when having many policies installed

Fix "Policy buffer overflow" error when trying to use deleteall with many policies installed. Signed-off-by: Alexander Heinlein --- ip/xfrm_policy.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/ip/xfrm_policy.c b/ip/xfrm_policy.c

Re: sctp: kernel memory overwrite attempt detected in sctp_getsockopt_assoc_stats

On Mon, Jan 16, 2017 at 2:57 PM, Neil Horman wrote: > On Mon, Jan 16, 2017 at 08:11:40AM +0100, Dmitry Vyukov wrote: >> On Sun, Jan 15, 2017 at 9:35 PM, Neil Horman wrote: >> > On Sun, Jan 15, 2017 at 06:29:59PM +0100, Dmitry Vyukov wrote: >> >>

Re: sctp: kernel memory overwrite attempt detected in sctp_getsockopt_assoc_stats

On Mon, Jan 16, 2017 at 08:11:40AM +0100, Dmitry Vyukov wrote: > On Sun, Jan 15, 2017 at 9:35 PM, Neil Horman wrote: > > On Sun, Jan 15, 2017 at 06:29:59PM +0100, Dmitry Vyukov wrote: > >> Hello, > >> > >> I've enabled CONFIG_HARDENED_USERCOPY_PAGESPAN on syzkaller fuzzer

Re: [PATCH ipsec-next v3 0/2] IPsec: do not ignore crypto err in ah input

On Mon, Jan 16, 2017 at 01:17:54PM +0200, Gilad Ben-Yossef wrote: > ah input processing uses the asynchronous hash crypto API which > supplies an error code as part of the operation completion but > the error code was being ignored. > > Treat a crypto API error indication as a verification

Re: [PATCH] netfilter: Fix typo in NF_CONNTRACK Kconfig option description

On Mon, Jan 09, 2017 at 05:24:18PM -0500, William Breathitt Gray wrote: > The NF_CONNTRACK Kconfig option description makes an incorrect reference > to the "meta" expression where the "ct" expression would be correct.This > patch fixes the respective typographical error. Applied, thanks.

Re: [PATCH] xfrm: state: fix potential null pointer dereference on afinfo

On Fri, Jan 13, 2017 at 02:07:03PM +, Colin King wrote: > From: Colin Ian King > > afinfo is being null checked before a call afinfo->init_tempsel > so afinfo may be potentially null. ifinfo may still be null in > the case were it is not updated when family ==

[PATCH] stmicro: rename it to dwc to improve future development

The goal of this patch is to create an oficial Designware Ethernet place to deploy new drivers based on this family of IPs. stmmac was left untouched since it is a designware based driver. New ethernet designware IP based drivers should be placed in this place, improving code organization and it

Re: [PATCH net-next] sctp: remove useless code from sctp_apply_peer_addr_params

On Fri, Jan 13, 2017 at 06:31:15PM -0200, Marcelo Ricardo Leitner wrote: > sctp_frag_point() doesn't store anything, and thus just calling it > cannot do anything useful. > > sctp_apply_peer_addr_params is only called by > sctp_setsockopt_peer_addr_params. When operating on an asoc, >

Re: [PATCH ipsec-next] xfrm: fix possible null deref in xfrm_init_tempstate

On Fri, Jan 13, 2017 at 02:55:14PM +0100, Florian Westphal wrote: > Dan reports following smatch warning: > net/xfrm/xfrm_state.c:659 > error: we previously assumed 'afinfo' could be null (see line 651) > > 649 struct xfrm_state_afinfo *afinfo = xfrm_state_afinfo_get_rcu(family); > 651 if

[PATCH] cpmac: remove hopeless #warning

The #warning was present 10 years ago when the driver first got merged. As the platform is rather obsolete by now, it seems very unlikely that the warning will cause anyone to fix the code properly. kernelci.org reports the warning for every build in the meantime, so I think it's better to just

Re: [PATCH net-next] sctp: remove unused var from sctp_process_asconf

On Fri, Jan 13, 2017 at 06:27:33PM -0200, Marcelo Ricardo Leitner wrote: > Assigned but not used. > > Signed-off-by: Marcelo Ricardo Leitner > --- > net/sctp/sm_make_chunk.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/net/sctp/sm_make_chunk.c

Re: [PATCH net v3] ravb: do not use zero-length alignment DMA descriptor

On 01/16/2017 01:45 PM, Simon Horman wrote: From: Masaru Nagai Due to alignment requirements of the hardware transmissions are split into two DMA descriptors, a small padding descriptor of 0 - 3 bytes in length followed by a descriptor for rest of the packet. In

Re: [PATCH] net: add regs attribute to phy device for user diagnose

On 日, 2017-01-15 at 18:21 +0100, Andrew Lunn wrote: > On Sun, Jan 15, 2017 at 09:51:03AM +0800, yuan linyu wrote: > >  > > I hope user/developer can read this attribute file "regs" to do > > a full check of all registers value, and they can write any register > > inside PHY through this file. >

[PATCH ipsec-next v3 0/2] IPsec: do not ignore crypto err in ah input

ah input processing uses the asynchronous hash crypto API which supplies an error code as part of the operation completion but the error code was being ignored. Treat a crypto API error indication as a verification failure. While a crypto API reported error would almost certainly result in a

[PATCH ipsec-next v3 1/2] IPsec: do not ignore crypto err in ah4 input

ah4 input processing uses the asynchronous hash crypto API which supplies an error code as part of the operation completion but the error code was being ignored. Treat a crypto API error indication as a verification failure. While a crypto API reported error would almost certainly result in a

[PATCH ipsec-next v3 2/2] IPsec: do not ignore crypto err in ah6 input

ah6 input processing uses the asynchronous hash crypto API which supplies an error code as part of the operation completion but the error code was being ignored. Treat a crypto API error indication as a verification failure. While a crypto API reported error would almost certainly result in a

[PATCH net v3] ravb: do not use zero-length alignment DMA descriptor

From: Masaru Nagai Due to alignment requirements of the hardware transmissions are split into two DMA descriptors, a small padding descriptor of 0 - 3 bytes in length followed by a descriptor for rest of the packet. In the case of IP packets the first descriptor

Re: [PATCH net-next 2/2] mpls: Packet stats

On 14/01/17 06:41, kbuild test robot wrote: Hi Robert, [auto build test ERROR on net-next/master] url:

[PATCH] net/irda: fix lockdep annotation

The current annotation uses a global variable as recursion counter. The variable is not atomic nor protected with a mutex, but mutated by multiple threads. This causes lockdep bug reports episodically: BUG: looking up invalid subclass: 4294967295 ... _raw_spin_lock_irqsave_nested+0x120/0x180

Re: [PATCH net-next] net/sched: cls_flower: Add user specified data

Mon, Jan 16, 2017 at 08:54:18AM CET, pa...@mellanox.com wrote: > > >On 15/01/2017 21:08, John Fastabend wrote: >> On 17-01-15 09:36 AM, Paul Blakey wrote: >> > >> > >> > On 08/01/2017 19:12, Jiri Pirko wrote: >> > > Mon, Jan 02, 2017 at 03:59:49PM CET, j...@mojatatu.com wrote: >> > > > >> > > >

Re: [patch net-next] stmmac: indent an if statement

On Mon, Jan 16, 2017 at 12:19:24PM +0300, Dan Carpenter wrote: > On Sun, Jan 15, 2017 at 10:14:38PM -0500, David Miller wrote: > > From: Dan Carpenter > > Date: Thu, 12 Jan 2017 21:46:32 +0300 > > > > > The break statement should be indented one more tab. > > > > > >

Re: [PATCH] sfc: Replace memset with eth_zero_addr

On 16/01/17 03:56, Shyam Saini wrote: > Use eth_zero_addr to assign zero address to the given address array > instead of memset when the second argument in memset is address > of zero which makes the code clearer and also add header > file linux/etherdevice.h > > Signed-off-by: Shyam Saini

Re: fs, net: deadlock between bind/splice on af_unix

On Fri, Dec 9, 2016 at 7:41 AM, Al Viro wrote: > On Thu, Dec 08, 2016 at 10:32:00PM -0800, Cong Wang wrote: > >> > Why do we do autobind there, anyway, and why is it conditional on >> > SOCK_PASSCRED? Note that e.g. for SOCK_STREAM we can bloody well get >> > to sending

Re: [PATCH 1/2] qed: Replace memset with eth_zero_addr

On Sun, Jan 15, 2017 at 11:38:30PM -0500, David Miller wrote: > > Please do not ever submit two patches which have the same exact commit > header line, as these two patches do. > > When someone looks into the shortlog of GIT history all they will see > is "qed: Replace memset with eth_zero_addr"

Re: [patch net-next] stmmac: indent an if statement

On Sun, Jan 15, 2017 at 10:14:38PM -0500, David Miller wrote: > From: Dan Carpenter > Date: Thu, 12 Jan 2017 21:46:32 +0300 > > > The break statement should be indented one more tab. > > > > Signed-off-by: Dan Carpenter > > Applied, but like

Re: [PATCH 0/6] USB support for Broadcom NSP SoC

On Tuesday 13 December 2016 07:50 AM, Florian Fainelli wrote: > On 11/09/2016 01:33 AM, Yendapally Reddy Dhananjaya Reddy wrote: >> This patch set contains the usb support for Broadcom NSP SoC. >> The usb phy is connected through mdio interface. The mdio interface >> can be used to access either

Re: [PATCH net] mlx4: do not call napi_schedule() without care

Thanks Eric. On 13/01/2017 6:39 PM, Eric Dumazet wrote: From: Eric Dumazet Disable BH around the call to napi_schedule() to avoid following warning [ 52.095499] NOHZ: local_softirq_pending 08 [ 52.421291] NOHZ: local_softirq_pending 08 [ 52.608313] NOHZ:

[PATCH net-next] net/sched: cls_flower: Disallow duplicate internal elements

Flower currently allows having the same filter twice with the same priority. Actions (and statistics update) will always execute on the first inserted rule leaving the second rule unused. This patch disallows that. Signed-off-by: Paul Blakey Acked-by: Jiri Pirko

Re: [PATCH for bnxt_re V3 03/21] bnxt_re: register with the NIC driver

On Mon, Jan 16, 2017 at 01:38:40PM +0530, Selvin Xavier wrote: > On Mon, Jan 16, 2017 at 1:11 AM, Leon Romanovsky wrote: > > Recently, in one of our submission to netdev and rdma, we got > > a reminder that inline functions shouldn't be in *.c. Let for > > the compiler to decide.

Re: [PATCH 5/6] treewide: use kv[mz]alloc* rather than opencoded variants

On Mon, Jan 16, 2017 at 08:33:11AM +0100, Michal Hocko wrote: > On Sat 14-01-17 12:56:32, Leon Romanovsky wrote: > [...] > > Hi Michal, > > > > I don't see mlx5_vzalloc in the changed list. Any reason why did you skip > > it? > > > > 881 static inline void *mlx5_vzalloc(unsigned long size) > >

Re: [PATCH 5/6] treewide: use kv[mz]alloc* rather than opencoded variants

On 12/01/2017 5:37 PM, Michal Hocko wrote: From: Michal Hocko There are many code paths opencoding kvmalloc. Let's use the helper instead. The main difference to kvmalloc is that those users are usually not considering all the aspects of the memory allocator. E.g. allocation

Re: [PATCH for bnxt_re V3 03/21] bnxt_re: register with the NIC driver

On Mon, Jan 16, 2017 at 1:11 AM, Leon Romanovsky wrote: > Recently, in one of our submission to netdev and rdma, we got > a reminder that inline functions shouldn't be in *.c. Let for > the compiler to decide. > > IMHO, it should be open-coded without wrappers and honestly I

<    1   2