Re: [PATCH] rt2500usb: don't mark register accesses as inline

On Wed, Feb 15, 2017 at 6:49 AM, Kalle Valo wrote: > Arnd Bergmann writes: > >> When CONFIG_KASAN is set, we get a rather large stack here: >> >> drivers/net/wireless/ralink/rt2x00/rt2500usb.c: In function >> 'rt2500usb_set_device_state': >>

Re: [PATCH 0/8] net: stmmac: misc patchs

On Wed, Feb 15, 2017 at 07:34:41AM +0100, Giuseppe CAVALLARO wrote: > Hello Corentin > > On 2/14/2017 8:54 PM, Corentin Labbe wrote: > > Hello > > > > This is a follow up of my previous stmmac serie which address some comment > > done in v2. > > I wonder if you can resend all the patches as V3 >

[PATCH] net: ethernet: aquantia: switch to pci_alloc_irq_vectors

pci_enable_msix has been long deprecated, but this driver adds a new instance. Convert it to pci_alloc_irq_vectors so that no new instance of the deprecated function reaches mainline. Signed-off-by: Christoph Hellwig --- .../net/ethernet/aquantia/atlantic/aq_pci_func.c | 101

Re: [PATCH net-next v3 2/8] gtp: switch from struct socket to struct sock for the GTP sockets

- On Feb 14, 2017, at 6:48 PM, David S. Miller da...@davemloft.net wrote: > From: Andreas Schultz > Date: Mon, 13 Feb 2017 16:36:18 +0100 > >> +if (gtp->sk0) { >> +udp_sk(gtp->sk0)->encap_type = 0; >> +rcu_assign_sk_user_data(gtp->sk0, NULL);

Re: [PATCH net] net: neigh: Fix netevent NETEVENT_DELAY_PROBE_TIME_UPDATE notification

On Wed, Feb 15, 2017 at 01:00:36AM +0100, Marcus Huewe wrote: > When setting a neigh related sysctl parameter, we always send a > NETEVENT_DELAY_PROBE_TIME_UPDATE netevent. For instance, when > executing > > sysctl net.ipv6.neigh.wlp3s0.retrans_time_ms=2000 > > a

Re: [PATCH 0/8] net: stmmac: misc patchs

Hello Corentin On 2/14/2017 8:54 PM, Corentin Labbe wrote: Hello This is a follow up of my previous stmmac serie which address some comment done in v2. I wonder if you can resend all the patches as V3 please add the Acked-by and Reviewed-by. This will help on final review and integration.

Re: net/xfrm: stack out-of-bounds in xfrm_flowi_sport

On Tue, Feb 14, 2017 at 10:16:44AM +0100, Dmitry Vyukov wrote: > > I've run the repro with you patch and don't see the bug any more: > > Tested-by: Dmitry Vyukov I've applied this to the ipsec tree now. Thanks for testing!

Re: [PATCH net] tcp: tcp_probe: use spin_lock_bh()

On Tue, 14 Feb 2017 17:11:14 -0800 Eric Dumazet wrote: > From: Eric Dumazet > > tcp_rcv_established() can now run in process context. > > We need to disable BH while acquiring tcp probe spinlock, > or risk a deadlock. > > Fixes: 5413d1babe8f

Re: net: hix5hd2_gmac uninitialized net_device

Hi Marty, On 2017/2/15 7:59, Marty Plummer wrote: > On Mon, Feb 13, 2017 at 09:25:38AM +0800, Dongpo Li wrote: >> >> >> On 2017/2/11 8:51, Marty Plummer wrote: >>> On Fri, Feb 10, 2017 at 06:21:35PM +0800, Dongpo Li wrote: I think the error "No irq resource" happened for some other reason,

[PATCH net-next] cxgb4: Update proper netdev stats for rx drops

Count buffer group drops or truncates as rx drops rather than rx errors in netdev stats. Signed-off-by: Ganesh Goudar Signed-off-by: Arjun V --- drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

Re: [PATCH] rt2500usb: don't mark register accesses as inline

Arnd Bergmann writes: > When CONFIG_KASAN is set, we get a rather large stack here: > > drivers/net/wireless/ralink/rt2x00/rt2500usb.c: In function > 'rt2500usb_set_device_state': > drivers/net/wireless/ralink/rt2x00/rt2500usb.c:1074:1: error: the frame size > of 3032 bytes is

Re: [PATCH V2] vhost: introduce O(1) vq metadata cache

On 2016年12月14日 17:53, Jason Wang wrote: When device IOTLB is enabled, all address translations were stored in interval tree. O(lgN) searching time could be slow for virtqueue metadata (avail, used and descriptors) since they were accessed much often than other addresses. So this patch

[PATCH net-next] openvswitch: Set internal device max mtu to ETH_MAX_MTU.

Commit 91572088e3fd ("net: use core MTU range checking in core net infra") changed the openvswitch internal device to use the core net infra for controlling the MTU range, but failed to actually set the max_mtu as described in the commit message, which now defaults to ETH_DATA_LEN. This patch

Re: linux-next: build failure after merge of the rdma tree

On Wed, Feb 15, 2017 at 6:35 AM, Doug Ledford wrote: >> From: Stephen Rothwell >> Date: Wed, 15 Feb 2017 11:23:25 +1100 >> Subject: [PATCH] RDMA/bnxt_re: fix for "bnxt_en: Update to firmware >> interface spec 1.7.0." >> >> Signed-off-by: Stephen

Re: [PATCH] net: ethernet: ti: cpsw: use var instead of func for usage count

From: Ivan Khoronzhuk Date: Tue, 14 Feb 2017 16:02:36 +0200 > The usage count function is based on ndev_running flag that is > updated before calling ndo_open/close, but if ndo is called in > another place, as with suspend/resume, the counter is not changed, > that

Re: [PATCH net] tcp: tcp_probe: use spin_lock_bh()

From: Eric Dumazet Date: Tue, 14 Feb 2017 17:11:14 -0800 > From: Eric Dumazet > > tcp_rcv_established() can now run in process context. > > We need to disable BH while acquiring tcp probe spinlock, > or risk a deadlock. > > Fixes: 5413d1babe8f

Re: [PATCH v2] uapi: fix linux/if_pppol2tp.h userspace compilation errors

From: "Dmitry V. Levin" Date: Wed, 15 Feb 2017 05:23:26 +0300 > Because of interface limitations, > provided by libc cannot be included after , therefore any > header that includes cannot be included after . > > Change uapi/linux/l2tp.h, the last uapi header that includes

[PATCH v2] uapi: fix linux/if_pppol2tp.h userspace compilation errors

Because of interface limitations, provided by libc cannot be included after , therefore any header that includes cannot be included after . Change uapi/linux/l2tp.h, the last uapi header that includes , to include and instead of and use __SOCK_SIZE__ instead of sizeof(struct sockaddr) the

Re: [lkp-robot] [net] 0148239373: ltp.test_1_to_1_sockopt.fail

Hi Xiaolong, On Wed, Feb 15, 2017 at 9:46 AM, kernel test robot wrote: > > FYI, we noticed the following commit: > > commit: 0148239373801a9c0c63eefc481b710ae7ce2941 ("net: sock: Use double > send/recv buff value to compare with max value") > url: >

[PATCH net] tcp: tcp_probe: use spin_lock_bh()

From: Eric Dumazet tcp_rcv_established() can now run in process context. We need to disable BH while acquiring tcp probe spinlock, or risk a deadlock. Fixes: 5413d1babe8f ("net: do not block BH while processing socket backlog") Signed-off-by: Eric Dumazet

Re: linux-next: build failure after merge of the rdma tree

On 2/14/2017 7:30 PM, Stephen Rothwell wrote: > Hi Doug, > > After merging the rdma tree, today's linux-next build (x86_64 > allmodconfig) failed like this: > > drivers/infiniband/hw/bnxt_re/main.c: In function 'bnxt_re_net_ring_free': > drivers/infiniband/hw/bnxt_re/main.c:231:18: error: >

Re: [PATCH net-next v1] bpf: Remove redundant ifdef

On 2017/2/15 1:07, David Miller wrote: From: "Wangnan (F)" Date: Mon, 13 Feb 2017 09:53:49 +0800 On 2017/2/12 3:37, Mickaël Salaün wrote: Remove a useless ifdef __NR_bpf as requested by Wang Nan. Inline one-line static functions as it was in the bpf_sys.h file.

linux-next: build failure after merge of the rdma tree

Hi Doug, After merging the rdma tree, today's linux-next build (x86_64 allmodconfig) failed like this: drivers/infiniband/hw/bnxt_re/main.c: In function 'bnxt_re_net_ring_free': drivers/infiniband/hw/bnxt_re/main.c:231:18: error: 'RING_ALLOC_REQ_RING_TYPE_CMPL' undeclared (first use in this

Re: [RFC 2/2] net: emac: add support for device-tree based PHY discovery and setup

On 02/14/2017 04:16 PM, Christian Lamparter wrote: > On Tuesday, February 14, 2017 12:38:42 AM CET Christian Lamparter wrote: >> diff --git a/drivers/net/ethernet/ibm/emac/core.c >> b/drivers/net/ethernet/ibm/emac/core.c >> --- a/drivers/net/ethernet/ibm/emac/core.c >> +++

Re: [RFC 2/2] net: emac: add support for device-tree based PHY discovery and setup

On Tuesday, February 14, 2017 12:38:42 AM CET Christian Lamparter wrote: > > >>> diff --git a/drivers/net/ethernet/ibm/emac/core.c > > >>> b/drivers/net/ethernet/ibm/emac/core.c > > >>> --- a/drivers/net/ethernet/ibm/emac/core.c > > >>> +++ b/drivers/net/ethernet/ibm/emac/core.c > > >>> @@

[PATCH net] net: neigh: Fix netevent NETEVENT_DELAY_PROBE_TIME_UPDATE notification

When setting a neigh related sysctl parameter, we always send a NETEVENT_DELAY_PROBE_TIME_UPDATE netevent. For instance, when executing sysctl net.ipv6.neigh.wlp3s0.retrans_time_ms=2000 a NETEVENT_DELAY_PROBE_TIME_UPDATE netevent is generated. This is caused by commit 2a4501ae18b5

Re: net: hix5hd2_gmac uninitialized net_device

On Mon, Feb 13, 2017 at 09:25:38AM +0800, Dongpo Li wrote: > > > On 2017/2/11 8:51, Marty Plummer wrote: > > On Fri, Feb 10, 2017 at 06:21:35PM +0800, Dongpo Li wrote: > >> I think the error "No irq resource" happened for some other reason, has no > >> relation with > >> the info "(unnamed

[PATCH 1/1] tcp: accommodate sequence number to a peer's shrunk receive window caused by precision loss in window scaling

This updates tcp_acceptable_seq(), one of the oldest functions since 2.4.0, by preventing sending out a left-shifted sequence number from a Linux sender in response to a peer's shrunk receive-window caused by losing least significant bits in window-scaling. RFC7323 page 10 (Chapter 2.4.

HELLO DEAR

Hello, nice to meet you , How are you doing today? My name is Fidelia. Please, I am sorry for intruding into your privacy because this letter may come to you as a surprising. I have an important matter which i want to discuss with you. I can also send my pictures to you as soon as i have receive

Re: [PATCH 2/3] net: stmicro: prepare dwmac4 dma for mtl

Hi Joao, [auto build test WARNING on net-next/master] [also build test WARNING on next-20170214] [cannot apply to v4.10-rc8] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Joao-Pinto/add

[PATCH] net: nvidia: forcedeth: use new api ethtool_{get|set}_link_ksettings

The ethtool api {get|set}_settings is deprecated. We move this driver to new api {get|set}_link_ksettings. As I don't have the hardware, I'd be very pleased if someone may test this patch. Signed-off-by: Philippe Reynes --- drivers/net/ethernet/nvidia/forcedeth.c | 91

Re: [PATCH RFC v2 1/8] xdp: Infrastructure to generalize XDP

On Tue, 14 Feb 2017 22:08:10 + Edward Cree wrote: > To me, the sensible interface (which makes the batching explicit to > the driver, which I think is necessary) is to have an int (or maybe > unsigned int, which is the return type of xdp_hookfn, I'm not sure > which

Re: [PATCH RFC v2 1/8] xdp: Infrastructure to generalize XDP

On Tue, Feb 14, 2017 at 2:08 PM, Edward Cree wrote: > On 14/02/17 21:07, Tom Herbert wrote: >> Off the top of my head... I'd say may we might be able to have a >> minimally invasive interface with something like: >> >> XDP_RUN(hook, xdp, drv_xdp_handle_action) >> >> This

Re: [PATCH 1/3] net: stmicro: prepare dwmac4 core for mtl

Hi Joao, [auto build test WARNING on net-next/master] [also build test WARNING on next-20170214] [cannot apply to v4.10-rc8] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Joao-Pinto/add

Re: [PATCH RFC v2 1/8] xdp: Infrastructure to generalize XDP

On 14/02/17 21:07, Tom Herbert wrote: > Off the top of my head... I'd say may we might be able to have a > minimally invasive interface with something like: > > XDP_RUN(hook, xdp, drv_xdp_handle_action) > > This replaces xdp_run and return codes are processed in the called > functions. Its a

Re: [PATCH v3 net-next 08/14] mlx4: use order-0 pages for RX

> > This obviously does not work for the case I'm talking about > (transmitting out another device with XDP). > XDP_TX does not handle this yet. When XDP_TX was added, it was very clear that the transmit _had_ to be done on the same port. Since all this discussion happened in this thread (

[PATCH] rt2500usb: don't mark register accesses as inline

When CONFIG_KASAN is set, we get a rather large stack here: drivers/net/wireless/ralink/rt2x00/rt2500usb.c: In function 'rt2500usb_set_device_state': drivers/net/wireless/ralink/rt2x00/rt2500usb.c:1074:1: error: the frame size of 3032 bytes is larger than 100 bytes [-Werror=frame-larger-than=]

Re: [PATCH RFC v2 1/8] xdp: Infrastructure to generalize XDP

On Tue, Feb 14, 2017 at 12:47 PM, Tom Herbert wrote: > On Tue, Feb 14, 2017 at 12:31 PM, Jesper Dangaard Brouer > wrote: >> On Wed, 8 Feb 2017 15:41:20 -0800 >> Tom Herbert wrote: >> >>> +static inline int __xdp_run_one_hook(struct

Re: [PATCH 2/2] pcnet32: fix BNC/AUI port on AM79C970A

On Tuesday 14 February 2017 20:28:56 David Miller wrote: > From: Ondrej Zary > Date: Mon, 13 Feb 2017 23:45:47 +0100 > > > Even though the port autoselection is enabled by default on AM79C970A, > > BNC/AUI port does not work because the link is always reported to be >

Re: [PATCH RFC v2 1/8] xdp: Infrastructure to generalize XDP

On Tue, Feb 14, 2017 at 12:31 PM, Jesper Dangaard Brouer wrote: > On Wed, 8 Feb 2017 15:41:20 -0800 > Tom Herbert wrote: > >> +static inline int __xdp_run_one_hook(struct xdp_hook *hook, >> + struct xdp_buff *xdp) >> +{ >>

Re: [PATCH RFC v2 1/8] xdp: Infrastructure to generalize XDP

On Wed, 8 Feb 2017 15:41:20 -0800 Tom Herbert wrote: > +static inline int __xdp_run_one_hook(struct xdp_hook *hook, > + struct xdp_buff *xdp) > +{ > + void *priv = rcu_dereference(hook->priv); > + > + if (hook->is_bpf) { > +

Re: [PATCH] uapi: fix linux/if_pppol2tp.h userspace compilation errors

On Tue, Feb 14, 2017 at 02:37:23PM -0500, David Miller wrote: > From: "Dmitry V. Levin" > Date: Tue, 14 Feb 2017 13:33:53 +0300 > > > In file included from /usr/include/linux/l2tp.h:12:0, > > from /usr/include/linux/if_pppol2tp.h:21, > >

Re: [PATCH net-next v6 0/2] qed*: Add support for PTP

From: "Mintz, Yuval" Date: Tue, 14 Feb 2017 20:12:52 + >> > This patch series adds required changes for qed/qede drivers for >> > supporting the IEEE Precision Time Protocol (PTP). >> > >> > Dave, >> > Please consider applying this series to "net-next". > >> Please

Re: [PATCH net-next v6 0/2] qed*: Add support for PTP

> > This patch series adds required changes for qed/qede drivers for > > supporting the IEEE Precision Time Protocol (PTP). > > > > Dave, > > Please consider applying this series to "net-next". > Please fix the problems reported by the kbuild robot. > Thanks. Fixing those are trivial [simply

Re: [PATCH 1/2] net: xilinx_emaclite: fix receive buffer overflow

From: Anssi Hannula Date: Tue, 14 Feb 2017 19:11:44 +0200 > xilinx_emaclite looks at the received data to try to determine the > Ethernet packet length but does not properly clamp it if > proto_type == ETH_P_IP or 1500 < proto_type <= 1518, causing a buffer > overflow

Re: [PATCH net] packet: fix races in fanout_add()

From: Eric Dumazet Date: Tue, 14 Feb 2017 09:03:51 -0800 > From: Eric Dumazet > > Multiple threads can call fanout_add() at the same time. > > We need to grab fanout_mutex earlier to avoid races that could > lead to one thread freeing po->rollover

Re: [PATCH] pch_gbe: Omit private ndo_get_stats function

From: Tobias Klauser Date: Tue, 14 Feb 2017 17:47:12 +0100 > pch_gbe_get_stats() just returns dev->stats so we can leave it out > altogether and let dev_get_stats() do the job. > > Signed-off-by: Tobias Klauser Also applied to net-next, thanks.

Re: [PATCH] net: hip04: Omit private ndo_get_stats function

From: Tobias Klauser Date: Tue, 14 Feb 2017 15:10:06 +0100 > hip04_get_stats() just returns dev->stats so we can leave it > out altogether and let dev_get_stats() do the job. > > Signed-off-by: Tobias Klauser Applied to net-next, thank you.

Re: [PATCH v3 net-next 08/14] mlx4: use order-0 pages for RX

On Tue, 14 Feb 2017 11:02:01 -0800 Eric Dumazet wrote: > On Tue, Feb 14, 2017 at 10:46 AM, Jesper Dangaard Brouer > wrote: > > > > > > > With this Intel driver page count based recycle approach, the recycle > > size is tied to the size of the RX ring.

Re: [PATCH net-next] net_sched: nla_memdup_cookie() can be static

From: Wei Yongjun Date: Tue, 14 Feb 2017 14:19:32 + > From: Wei Yongjun > > Fixes the following sparse warning: > > net/sched/act_api.c:532:5: warning: > symbol 'nla_memdup_cookie' was not declared. Should it be static? > > Signed-off-by: Wei

[PATCH 7/8] net: stmmac: reduce indentation by adding a continue

As suggested by Joe Perches, replacing the "if phydev" logic permit to reduce indentation in the for loop. Signed-off-by: Corentin Labbe --- drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c | 82 +++ 1 file changed, 40 insertions(+), 42

[PATCH 8/8] net: stmmac: invert the logic for dumping regs

It is easier to follow the logic by removing the not operator Signed-off-by: Corentin Labbe --- drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git

[PATCH 4/8] net: stmmac: set speed at SPEED_UNKNOWN in case of broken speed

In case of invalid speed given, stmmac_adjust_link() still record it as current speed. This patch modify the default case to set speed as SPEED_UNKNOWN if not 10/100/1000. Signed-off-by: Corentin Labbe --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 1 + 1

[PATCH 6/8] net: stmmac: split the stmmac_adjust_link 10/100 case

The 10/100 case have too many ifcase. This patch split it for removing an if. Signed-off-by: Corentin Labbe --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git

[PATCH 2/8] net: stmmac: likely is useless in occasional function

The stmmac_adjust_link() function is called too rarely for having likely() macros being useful. Just remove likely annotation in it. Signed-off-by: Corentin Labbe --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 8 1 file changed, 4 insertions(+), 4

Re: [PATCH v3 net-next 08/14] mlx4: use order-0 pages for RX

From: Jesper Dangaard Brouer Date: Tue, 14 Feb 2017 20:38:22 +0100 > On Tue, 14 Feb 2017 12:04:26 -0500 (EST) > David Miller wrote: > >> One path I see around all of this is full integration. Meaning that >> we can free pages into the page allocator

Re: [PATCH net v2] ibmvnic: Fix initial MTU settings

From: Thomas Falcon Date: Tue, 14 Feb 2017 10:22:59 -0600 > In the current driver, the MTU is set to the maximum value > capable for the backing device. This decision turned out to > be a mistake as it led to confusion among users. The expected > initial MTU value

[PATCH 5/8] net: stmmac: run stmmac_hw_fix_mac_speed when speed is valid

This patch mutualise a bit by running stmmac_hw_fix_mac_speed() after the switch in case of valid speed. Signed-off-by: Corentin Labbe --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git

[PATCH 1/8] net: stmmac: remove useless parenthesis

This patch remove some useless parenthesis. Signed-off-by: Corentin Labbe --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 8 drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git

[PATCH 0/8] net: stmmac: misc patchs

Hello This is a follow up of my previous stmmac serie which address some comment done in v2. Corentin Labbe (8): net: stmmac: remove useless parenthesis net: stmmac: likely is useless in occasional function net: stmmac: use SPEED_UNKNOWN/DUPLEX_UNKNOWN net: stmmac: set speed at

[PATCH 3/8] net: stmmac: use SPEED_UNKNOWN/DUPLEX_UNKNOWN

It is better to use DUPLEX_UNKNOWN instead of just "-1". Using 0 for an invalid speed is bad since 0 is a valid value for speed. So this patch replace 0 by SPEED_UNKNOWN. Signed-off-by: Corentin Labbe --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 12

Re: [PATCH v2] net: ethernet: ti: cpsw: fix cpsw assignment in resume

From: Ivan Khoronzhuk Date: Tue, 14 Feb 2017 14:42:15 +0200 > There is a copy-paste error, which hides breaking of resume > for CPSW driver: there was replaced netdev_priv() to ndev_to_cpsw(ndev) > in suspend, but left it unchanged in resume. > > Fixes:

Re: possible unannotated irqs-off

On Tue, Feb 14, 2017 at 5:46 PM, David Miller wrote: > From: Ricardo Nabinger Sanchez > Date: Tue, 14 Feb 2017 17:28:58 -0200 > > > [ 93.509167] ? jtcp_rcv_established+0x8e/0x2d0 > > [ 93.509173] jtcp_rcv_established+0x8e/0x2d0 > > What are you

Re: [PATCH] net: au1000_eth: get rid of unnecessary header.

From: Manuel Lauss Date: Tue, 14 Feb 2017 13:11:07 +0100 > au1000_eth.h isn't used anywhere else, merge its contents into > main driver file. > > Signed-off-by: Manuel Lauss It is completely natural and normal to split the datastructure and

Re: [PATCH 2/2] net: irda: au1k_ir: drop useless include

From: Manuel Lauss Date: Tue, 14 Feb 2017 13:08:04 +0100 > remove useless ioport.h include. > > Signed-off-by: Manuel Lauss Also applied to net-next, thanks.

Re: [PATCH 1/2] net: irda: au1k_ir: remove unused timer

From: Manuel Lauss Date: Tue, 14 Feb 2017 13:08:03 +0100 > remove the unused timer. I suppose it was intended as a timeout > detector, but never properly implemented. > > Signed-off-by: Manuel Lauss Applied to net-next.

Re: [PATCH v3 net-next 08/14] mlx4: use order-0 pages for RX

On Tue, 14 Feb 2017 11:06:25 -0800 Alexander Duyck wrote: > On Tue, Feb 14, 2017 at 10:46 AM, Jesper Dangaard Brouer > wrote: > > On Tue, 14 Feb 2017 09:29:54 -0800 > > Alexander Duyck wrote: > > > >> On Tue, Feb 14,

Re: possible unannotated irqs-off

From: Ricardo Nabinger Sanchez Date: Tue, 14 Feb 2017 17:28:58 -0200 > [ 93.509167] ? jtcp_rcv_established+0x8e/0x2d0 > [ 93.509173] jtcp_rcv_established+0x8e/0x2d0 What are you using this TCP probe for? That's where the locking problem is happening.

Re: [PATCH net-next v6 0/2] qed*: Add support for PTP

From: Yuval Mintz Date: Tue, 14 Feb 2017 18:03:23 +0200 > This patch series adds required changes for qed/qede drivers for > supporting the IEEE Precision Time Protocol (PTP). > > Dave, > Please consider applying this series to "net-next". Please fix the problems

Re: net: use-after-free in tw_timer_handler

On Wed, Feb 8, 2017 at 8:32 PM, Dmitry Vyukov wrote: >>> >> >>> This code was changed a long time ago : >>> >> >>> >>> >> >>> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=ed2e923945892a8372ab70d2f61d364b0b6d9054 >>> >> >>> >>> >> >>> So I suspect

Re: [PATCH v3 net-next 08/14] mlx4: use order-0 pages for RX

On Tue, 14 Feb 2017 12:04:26 -0500 (EST) David Miller wrote: > From: Tariq Toukan > Date: Tue, 14 Feb 2017 16:56:49 +0200 > > > Internally, I already implemented "dynamic page-cache" and > > "page-reuse" mechanisms in the driver, and together they

Re: [PATCH] uapi: fix linux/if_pppol2tp.h userspace compilation errors

From: "Dmitry V. Levin" Date: Tue, 14 Feb 2017 13:33:53 +0300 > In file included from /usr/include/linux/l2tp.h:12:0, > from /usr/include/linux/if_pppol2tp.h:21, > /usr/include/netinet/in.h:31:8: error: redefinition of 'struct in_addr' This is protected

Re: [PATCH] bpf: reduce compiler warnings by adding fallthrough comments

From: Alexander Alemayhu Date: Tue, 14 Feb 2017 00:02:35 +0100 > Fixes the following warnings: ... > Reported-by: David Binderman > Signed-off-by: Alexander Alemayhu Applied, thank you.

possible unannotated irqs-off

Greetings, This has been popping out in my machine since 4.9 (now using 4.10-rc5), even before having VMware's modules loaded. Please advise whether this is actually from RTL8169 or whether I should post somewhere else (feel free to redirect, though). Let me know if you need more info and/or

Re: [PATCH 2/2] pcnet32: fix BNC/AUI port on AM79C970A

From: Ondrej Zary Date: Mon, 13 Feb 2017 23:45:47 +0100 > Even though the port autoselection is enabled by default on AM79C970A, > BNC/AUI port does not work because the link is always reported to be > down. The link state reported by the chip belongs only to the TP

Re: [PATCH net-next V2 1/6] net/sched: cls_matchall: Dump skip flags

On Tue, 14 Feb 2017 16:30:35 +0200, Or Gerlitz wrote: > The skip flags are not dumped to user-space, do that. > > Signed-off-by: Or Gerlitz > Acked-by: Jiri Pirko > Acked-by: Yotam Gigi > --- > net/sched/cls_matchall.c | 2 ++ > 1

Re: [PATCH 1/2] pcnet32: factor out pcnet32_clr_suspend()

From: Ondrej Zary Date: Mon, 13 Feb 2017 23:45:46 +0100 > Move the code to clear SUSPEND flag to a separate function to simplify > code. > > Signed-off-by: Ondrej Zary Applied to net-next.

Re: [PATCH net-next V2 6/6] net/sched: cls_bpf: Reflect HW offload status

On Tue, 14 Feb 2017 16:30:40 +0200, Or Gerlitz wrote: > BPF classifier support for the "in hw" offloading flags. > > Signed-off-by: Or Gerlitz > Reviewed-by: Amir Vadai Acked-by: Jakub Kicinski

Re: [PATCH net-next v6 1/2] qed: Add infrastructure for PTP support

Hi Sudarsana, [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Yuval-Mintz/qed-Add-infrastructure-for-PTP-support/20170215-003051 config: i386-allmodconfig (attached as .config) compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901 reproduce: #

Re: [PATCH v2 net-next] virtio: Fix affinity for #VCPUs != #queue pairs

On Wed, Feb 8, 2017 at 11:37 AM, Michael S. Tsirkin wrote: > IIRC irqbalance will bail out and avoid touching affinity > if you set affinity from driver. Breaking that's not nice. > Pls correct me if I'm wrong. I believe you're right that irqbalance will leave the affinity

Re: [PATCH v3 net-next 08/14] mlx4: use order-0 pages for RX

On Tue, Feb 14, 2017 at 10:46 AM, Jesper Dangaard Brouer wrote: > On Tue, 14 Feb 2017 09:29:54 -0800 > Alexander Duyck wrote: > >> On Tue, Feb 14, 2017 at 6:56 AM, Tariq Toukan >> wrote: >> > >> > >> > On 14/02/2017 3:45

Re: Bug#855153: linux-image-4.9.0-1-amd64: kernel 4.9 does not check route protocol when deleting ipv6 routes

Please queue up: commit c2ed1880fd61a998e3ce40254a99a2ad000f1a7d Author: Mantas M Date:   Fri Dec 16 10:30:59 2016 +0200 net: ipv6: check route protocol when deleting routes for stable. Ben. On Tue, 2017-02-14 at 19:52 +0100, Pascal Mathis wrote: > Package: src:linux >

Re: [PATCH v3 net-next 08/14] mlx4: use order-0 pages for RX

On Tue, Feb 14, 2017 at 10:46 AM, Jesper Dangaard Brouer wrote: > > > With this Intel driver page count based recycle approach, the recycle > size is tied to the size of the RX ring. As Eric and Tariq discovered. > And for other performance reasons (memory footprint of

Re: [PATCH v3 net-next 08/14] mlx4: use order-0 pages for RX

On Tue, 14 Feb 2017 09:29:54 -0800 Alexander Duyck wrote: > On Tue, Feb 14, 2017 at 6:56 AM, Tariq Toukan wrote: > > > > > > On 14/02/2017 3:45 PM, Eric Dumazet wrote: > >> > >> On Tue, Feb 14, 2017 at 4:12 AM, Jesper Dangaard Brouer > >>

Re: [PATCH net-next v6 0/2] qed*: Add support for PTP

On Tue, Feb 14, 2017 at 06:03:23PM +0200, Yuval Mintz wrote: > This patch series adds required changes for qed/qede drivers for > supporting the IEEE Precision Time Protocol (PTP). > > Dave, > Please consider applying this series to "net-next". > > Thanks, > Yuval > > Changes from previous

[PATCH v2 4/4] ptp: create "pins" together with the rest of attributes

Let's switch to using device_create_with_groups(), which will allow us to create "pins" attribute group together with the rest of ptp device attributes, and before userspace gets notified about ptp device creation. Signed-off-by: Dmitry Torokhov ---

[PATCH v2 3/4] ptp: use is_visible method to hide unused attributes

Instead of creating selected attributes after the device is created (and after userspace potentially seen uevent), lets use attribute group is_visible() method to control which attributes are shown. This will allow us to create all attributes (except "pins" group, which will be taken care of

[PATCH v2 2/4] ptp: use kcalloc when allocating arrays

kcalloc is more semantically correct when allocating arrays of objects, and overflow-safe. Signed-off-by: Dmitry Torokhov --- drivers/ptp/ptp_sysfs.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/ptp/ptp_sysfs.c

[PATCH v2 0/4] PTP attribute handling cleanup

PTP core was creating some attributes, such as "period" and "fifo", and the entire "pins" attribute group, after creating class deevice, which creates a race for userspace: uevent may arrive before all attributes are created. This series of patches switches PTP to use is_visible() to control

[PATCH v2 1/4] ptp: do not explicitly set drvdata in ptp_clock_register()

We do not need explicitly call dev_set_drvdata(), as it is done for us by device_create(). Acked-by: Richard Cochran Signed-off-by: Dmitry Torokhov --- drivers/ptp/ptp_clock.c | 2 -- 1 file changed, 2 deletions(-) diff --git

Re: [patch net-next] mlxsw: spectrum: Change ipv6 unregistered mc table

From: Jiri Pirko Date: Mon, 13 Feb 2017 21:03:02 +0100 > From: Nogah Frankel > > Point back the unregister IPv6 mc table to the bc table. > It is done since IPv6 mcast snooping is not supported for Spectrum yet. > > Reported-by: Jiri Pirko

Re: [PATCH V4 net-next 1/2] qed: Add support for hardware offloaded FCoE.

From: "Dupuis, Chad" Date: Mon, 13 Feb 2017 11:17:00 -0800 > @@ -255,6 +259,10 @@ struct qed_hw_info { > u32 part_num[4]; > > unsigned char hw_mac_addr[ETH_ALEN]; > + u64 node_wwn;

Re: [PATCH 3/4] ptp: use is_visible method to hide unused attributes

On Tue, Feb 14, 2017 at 10:07:47AM -0800, Dmitry Torokhov wrote: > > At first glance, this patch and the next look like nice improvements. > > I don't futz around with sysfs code very often, and so may I ask how > > or whether you tested it? > > I used the hack below. OK, thats fine. I'll be

Re: [PATCH 3/4] ptp: use is_visible method to hide unused attributes

Hi Richard, On Tue, Feb 14, 2017 at 09:42:26AM +0100, Richard Cochran wrote: > On Mon, Feb 13, 2017 at 07:51:07PM -0800, Dmitry Torokhov wrote: > > Instead of creating selected attributes after the device is created (and > > after userspace potentially seen uevent), lets use attribute group > >

Re: [Patch net] kcm: fix a null pointer dereference in kcm_sendmsg()

From: Cong Wang Date: Mon, 13 Feb 2017 11:13:16 -0800 > In commit 98e3862ca2b1 ("kcm: fix 0-length case for kcm_sendmsg()") > I tried to avoid skb allocation for 0-length case, but missed > a check for NULL pointer in the non EOR case. > > Fixes: 98e3862ca2b1 ("kcm:

Re: [PATCH v4 net-next 0/8] sunvnet driver updates

From: Shannon Nelson Date: Mon, 13 Feb 2017 10:56:56 -0800 > The sunvnet ldom virtual network driver was due for some updates and > a bugfix or two. These patches address a few items left over from > last year's make-over. > > v2: > - changed memory barrier fix to

[PATCH 0/3] add support for multiple queues/channels in stmmac

This patch-set was built in order to be easy for a developer to have a clear view of what was done to add multiple queues/channels to stmmac. It shows a progressive work starting in an initial mac functions upgrade, followed by dma related functions upgrade and finally introcuding the multiple

[PATCH 1/3] net: stmicro: prepare dwmac4 core for mtl

This patch adds the following features: a) RX and TX scheduling algorithm configuration (can be configured in the Device Tree) b) TX VLAN tag priority configuration (can be configured in the Device Tree) c) RX VLAN tag priority routing configuration (can be configured in the Device Tree) d) TX

[PATCH 2/3] net: stmicro: prepare dwmac4 dma for mtl

This patch adds the following features: a) RX and TX DMA Operation Mode now setting FIFO size b) FIFO size is obtained from the FEATURES register or can be set in the Device Tree (fifo depth) c) Common DMA operations initialization by channel d) RX DMA initialization by channel e) TX DMA

[PATCH 3/3] net: stmicro: multiple buffer support

This patch adds the following features: a) Creation of tx_queue and rx_queue structures (stmmac.h), each containing relevant queue related parameters (skbuff_dma, skbuff, etc.). b) tx_queue and rx_queue allocation is dynamic and done accordingly with the number of RX queues and TX queues existent

  1   2   >