Re: [4.9.10] ip_route_me_harder() reading off-slab

2017-02-16 Thread Florian Westphal
Daniel J Blueman wrote: [ CC nf-devel, pablo ] > When booting a VM in libvirt/KVM attached to a local bridge and KASAN > enabled on 4.9.10, we see a stream of KASAN warnings about off-slab > access [1]. > > Let me know if you'd like more debug. Does this patch help? Subject: [PATCH nf] netfil

RE: [net-next 06/14] ixgbe: Update driver to make use of DMA attributes in Rx path

2017-02-16 Thread maowenan
> -Original Message- > From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org] > On Behalf Of Jeff Kirsher > Sent: Thursday, February 16, 2017 8:51 PM > To: da...@davemloft.net > Cc: Alexander Duyck; netdev@vger.kernel.org; nhor...@redhat.com; > sassm...@redhat.com; jogre

[PATCH 00/35] treewide trivial patches converting pr_warning to pr_warn

2017-02-16 Thread Joe Perches
There are ~4300 uses of pr_warn and ~250 uses of the older pr_warning in the kernel source tree. Make the use of pr_warn consistent across all kernel files. This excludes all files in tools/ as there is a separate define pr_warning for that directory tree and pr_warn is not used in tools/. Done

[PATCH 20/35] drivers/isdn: Convert remaining uses of pr_warning to pr_warn

2017-02-16 Thread Joe Perches
To enable eventual removal of pr_warning This makes pr_warn use consistent for drivers/isdn Prior to this patch, there were 20 uses of pr_warning and 3 uses of pr_warn in drivers/isdn Signed-off-by: Joe Perches --- drivers/isdn/gigaset/interface.c| 2 +- drivers/isdn/hardware/mISDN/av

Re: [RFC] TCP_NOTSENT_LOWAT behavior

2017-02-16 Thread Eric Dumazet
On Fri, 2017-02-17 at 01:20 -0500, Josh Hunt wrote: > Eric > > A team here was using the TCP_NOTSENT_LOWAT socket option and noticed that > more unsent data than they were expecting was sitting in the write queue. I > took a look and noticed that while we don't allow allocation of new skbs once >

[PATCH net-next 1/1] pkt_sched: Remove useless qdisc_stab_lock

2017-02-16 Thread fgao
From: Gao Feng The qdisc_stab_lock is used in qdisc_get_stab and qdisc_put_stab. These two functions are invoked in qdisc_create, qdisc_change, and qdisc_destroy which run fully under RTNL. So it already makes sure only one could access the qdisc_stab_list at the same time. Then it is unnecessar

[PATCH net 3/4] ipvs: Document sysctl sync_ports

2017-02-16 Thread Hangbin Liu
Document sysctl sync_ports based on commit f73181c8288f ("ipvs: add support for sync threads"). Signed-off-by: Hangbin Liu --- Documentation/networking/ipvs-sysctl.txt | 8 1 file changed, 8 insertions(+) diff --git a/Documentation/networking/ipvs-sysctl.txt b/Documentation/networking

[PATCH net 2/4] ipvs: Document sysctl sync_qlen_max and sync_sock_size

2017-02-16 Thread Hangbin Liu
Document sysctl sync_qlen_max and sync_sock_size based on commit 1c003b1580e2 ("ipvs: wakeup master thread"). Signed-off-by: Hangbin Liu --- Documentation/networking/ipvs-sysctl.txt | 13 + 1 file changed, 13 insertions(+) diff --git a/Documentation/networking/ipvs-sysctl.txt b/Doc

[PATCH net 0/4] update ipvs sysctl document

2017-02-16 Thread Hangbin Liu
Fix and add some new ipvs sysctl options. Also use tab instead of whitespaces to indent the descriptions. Hangbin Liu (4): ipvs: fix sync_threshold description and add sync_refresh_period, sync_retries ipvs: Document sysctl sync_qlen_max and sync_sock_size ipvs: Document sysctl sync_port

[PATCH net 4/4] ipvs: Document sysctl pmtu_disc

2017-02-16 Thread Hangbin Liu
Document sysctl pmtu_disc based on commit 3654e61137db ("ipvs: add pmtu_disc option to disable IP DF for TUN packets"). Signed-off-by: Hangbin Liu --- Documentation/networking/ipvs-sysctl.txt | 9 + 1 file changed, 9 insertions(+) diff --git a/Documentation/networking/ipvs-sysctl.txt b

[PATCH net 1/4] ipvs: fix sync_threshold description and add sync_refresh_period, sync_retries

2017-02-16 Thread Hangbin Liu
Fix sync_threshold description which should have two values. Also add sync_refresh_period and sync_retries based on commit 749c42b620a9 ("ipvs: reduce sync rate with time thresholds"). Signed-off-by: Hangbin Liu --- Documentation/networking/ipvs-sysctl.txt | 40 +---

[RFC] TCP_NOTSENT_LOWAT behavior

2017-02-16 Thread Josh Hunt
Eric A team here was using the TCP_NOTSENT_LOWAT socket option and noticed that more unsent data than they were expecting was sitting in the write queue. I took a look and noticed that while we don't allow allocation of new skbs once we exceed this value, we still allow adding data to the skb at t

Re: [4.9.10] ip_route_me_harder() reading off-slab

2017-02-16 Thread Willy Tarreau
On Fri, Feb 17, 2017 at 01:34:11PM +0800, Daniel J Blueman wrote: > When booting a VM in libvirt/KVM attached to a local bridge and KASAN > enabled on 4.9.10, we see a stream of KASAN warnings about off-slab > access [1]. Did it start to appear with 4.9.10 or is 4.9.10 the first 4.9 kernel you tri

[4.9.10] ip_route_me_harder() reading off-slab

2017-02-16 Thread Daniel J Blueman
When booting a VM in libvirt/KVM attached to a local bridge and KASAN enabled on 4.9.10, we see a stream of KASAN warnings about off-slab access [1]. Let me know if you'd like more debug. Thanks, Daniel -- [1] [ 473.579567] BUG: KASAN: slab-out-of-bounds in ip_route_me_harder+0xbd5/0xf20 at

Re: [PATCH net-next] virito-net: set queues after reset during xdp_set

2017-02-16 Thread Jason Wang
On 2017年02月17日 12:53, John Fastabend wrote: On 17-02-15 01:08 AM, Jason Wang wrote: We set queues before reset which will cause a crash[1]. This is because is_xdp_raw_buffer_queue() depends on the old xdp queue pairs number to do the correct detection. So fix this by: - set queues after reset

Re: [PATCH net-next] virito-net: set queues after reset during xdp_set

2017-02-16 Thread John Fastabend
On 17-02-15 01:08 AM, Jason Wang wrote: > We set queues before reset which will cause a crash[1]. This is > because is_xdp_raw_buffer_queue() depends on the old xdp queue pairs > number to do the correct detection. So fix this by: > > - set queues after reset, to keep the old vi->curr_queue_pairs.

[PATCHv2 net-next 7/7] sctp: add reconf chunk event

2017-02-16 Thread Xin Long
This patch is to add reconf chunk event based on the sctp event frame in rx path, it will call sctp_sf_do_reconf to process the reconf chunk. Signed-off-by: Xin Long --- include/net/sctp/constants.h | 3 +++ net/sctp/sm_statetable.c | 30 ++ 2 files changed, 33 i

[PATCHv2 net-next 3/7] sctp: implement receiver-side procedures for the Outgoing SSN Reset Request Parameter

2017-02-16 Thread Xin Long
This patch is to implement Receiver-Side Procedures for the Outgoing SSN Reset Request Parameter described in rfc6525 section 5.2.2. Note that some checks must be after request_seq check, as even those checks fail, strreset_inseq still has to be increase by 1. Signed-off-by: Xin Long --- includ

[PATCHv2 net-next 5/7] sctp: add a function to verify the sctp reconf chunk

2017-02-16 Thread Xin Long
This patch is to add a function sctp_verify_reconf to do some length check and multi-params check for sctp stream reconf according to rfc6525 section 3.1. Signed-off-by: Xin Long --- include/net/sctp/sm.h| 3 +++ net/sctp/sm_make_chunk.c | 59

[PATCHv2 net-next 6/7] sctp: add reconf chunk process

2017-02-16 Thread Xin Long
This patch is to add a function to process the incoming reconf chunk, in which it verifies the chunk, and traverses the param and process it with the right function one by one. sctp_sf_do_reconf would be the process function of reconf chunk event. Signed-off-by: Xin Long --- include/net/sctp/sm

[PATCHv2 net-next 4/7] sctp: implement receiver-side procedures for the Incoming SSN Reset Request Parameter

2017-02-16 Thread Xin Long
This patch is to implement Receiver-Side Procedures for the Incoming SSN Reset Request Parameter described in rfc6525 section 5.2.3. It's also to move str_list endian conversion out of sctp_make_strreset_req, so that sctp_make_strreset_req can be used more conveniently to process inreq. Signed-of

[PATCHv2 net-next 1/7] sctp: add support for generating stream reconf resp chunk

2017-02-16 Thread Xin Long
This patch is to define Re-configuration Response Parameter described in rfc6525 section 4.4. As optional fields are only for SSN/TSN Reset Request Parameter, it uses another function to make that. Signed-off-by: Xin Long --- include/linux/sctp.h | 24 include/net/sctp/sm.h

[PATCHv2 net-next 2/7] sctp: add support for generating stream ssn reset event notification

2017-02-16 Thread Xin Long
This patch is to add Stream Reset Event described in rfc6525 section 6.1.1. Signed-off-by: Xin Long --- include/net/sctp/ulpevent.h | 4 include/uapi/linux/sctp.h | 16 net/sctp/ulpevent.c | 29 + 3 files changed, 49 insertions(+) dif

[PATCHv2 net-next 0/7] sctp: add receiver-side procedures for stream reconf ssn reset request chunk

2017-02-16 Thread Xin Long
Patch 3/7 and 4/7 are to implement receiver-side procedures for the Outgoing and Incoming SSN Reset Request Parameter described in rfc6525 section 5.2.2 and 5.2.3 Patch 1/7 and 2/7 are ahead of them to define some apis. Patch 5/7-7/7 are to add the process of reconf chunk event in rx path. Note

Re: [PATCH net-next V3 3/7] net/sched: Reflect HW offload status

2017-02-16 Thread Jakub Kicinski
On Thu, 16 Feb 2017 10:17:44 +0200, Ido Schimmel wrote: > On Wed, Feb 15, 2017 at 10:28:21AM -0800, Jakub Kicinski wrote: > > What worries me is that the moment we started offloading packet > > modification we run at the risk of modifying packets twice. This used > > to be a problem only for eBPF

Re: [BUG] 4.10-rc8 - ping spinning?

2017-02-16 Thread Soheil Hassas Yeganeh
On Thu, Feb 16, 2017 at 11:08 AM, wrote: > On Thu, Feb 16, 2017 at 10:52:19AM -0500, Soheil Hassas Yeganeh wrote: >> On Thu, Feb 16, 2017 at 10:50 AM, Soheil Hassas Yeganeh >> wrote: >> > Thank you Vito for the report. >> > >> > The patch you cited actually resolves a similar backward compatibil

Re: [PATCH net v5] bpf: add helper to compare network namespaces

2017-02-16 Thread David Ahern
On 2/16/17 3:08 AM, Daniel Borkmann wrote: > Is there anything that speaks against doing the comparison itself > outside of the helper? Meaning, the helper would get a buffer > passed from stack f.e. struct foo { u64 ns_dev; u64 ns_ino; } > and fills both out with the netns info belonging to the sk

[PATCH net-next] virtio-net: batch stats updating

2017-02-16 Thread Jason Wang
We already have counters for sent/recv packets and sent/recv bytes. Doing a batched update to reduce the number of u64_stats_update_begin/end(). Take care not to bother with stats update when called speculatively. Cc: Willem de Bruijn Signed-off-by: Jason Wang Signed-off-by: Michael S. Tsirkin

[PATCH net-next 6/6] net: dsa: mv88e6xxx: add support for 6390 VTU

2017-02-16 Thread Vivien Didelot
The 6390 family of chips use only 2 of the 3 VTU Data registers to pack the MemberTag and PortState VLAN data. This means that they must be written or read before or after each VTU/STU operations. Implement this variant to add support for VTU with such chips. Signed-off-by: Vivien Didelot --- d

[PATCH net-next 1/6] net: dsa: mv88e6xxx: add port mask helper

2017-02-16 Thread Vivien Didelot
Add a mv88e6xxx_port_mask() helper to get the bitmask of ports in a switch chip, that will be used in several features. Signed-off-by: Vivien Didelot --- drivers/net/dsa/mv88e6xxx/mv88e6xxx.h | 5 + drivers/net/dsa/mv88e6xxx/port.c | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-)

[PATCH net-next 4/6] net: dsa: mv88e6xxx: move VTU code to its own file

2017-02-16 Thread Vivien Didelot
Move the Global (1) VTU related code to its own file. Use this opportunity to provide a cleaner API for the VTU, by renaming a few underscore prefixed functions, split the data member of the mv88e6xxx_vtu_entry structure into membership (for 802.1q) and port state (for 802.1s) members, and add a m

[PATCH net-next 2/6] net: dsa: mv88e6xxx: move ATU code in its own file

2017-02-16 Thread Vivien Didelot
Move the Global (1) ATU related code in its own file, and export the necessary primitives. Use that opportunity to provide a cleaner API for the ATU, by renaming a few underscore prefixed functions, and members of the mv88e6xxx_atu_entry structures. Signed-off-by: Vivien Didelot --- drivers/net

[PATCH net-next 3/6] net: dsa: mv88e6xxx: add support for 6390 ATU Move

2017-02-16 Thread Vivien Didelot
The 6390 family of Marvell chips uses 5 bits to describe the ToPort and FromPort values of PortVec in the ATU Move operation, while older switches use 0xf. Add an atu_move_port_mask member in the info structure to describe that. Signed-off-by: Vivien Didelot --- drivers/net/dsa/mv88e6xxx/chip.c

[PATCH net-next 5/6] net: dsa: mv88e6xxx: add VTU ops

2017-02-16 Thread Vivien Didelot
Because there are several variant of the VTU operations and because checking for the presence of an STU is not enough, add new ops to the info structure to describe the VTU operations that a chip supports. Signed-off-by: Vivien Didelot --- drivers/net/dsa/mv88e6xxx/chip.c | 54 +

[PATCH net-next 0/6] net: dsa: mv88e6xxx: 88E6390 ATU/VTU

2017-02-16 Thread Vivien Didelot
This series adds support to 88E6390 for the ATU (MAC address databases) and VTU (VLAN databases), as well as providing a cleaner API for both. The 6390 family of Marvell switch chip handles the ATU Move operation differently and has a different usage of the VTU Data registers. Vivien Didelot (6):

Re: pull request (net-next): ipsec-next 2017-02-16

2017-02-16 Thread David Miller
From: Steffen Klassert Date: Thu, 16 Feb 2017 13:18:34 +0100 > 1) Make struct xfrm_input_afinfo const, nothing writes to it. >From Florian Westphal. > > 2) Remove all places that write to the afinfo policy backend >and make the struct const then. >From Florian Westphal. > > 3) Prepa

Re: [net-next 00/14][pull request] 10GbE Intel Wired LAN Driver Updates 2017-02-16

2017-02-16 Thread David Miller
From: Jeff Kirsher Date: Thu, 16 Feb 2017 04:50:27 -0800 > This series contains updates to ixgbe only. > > Tony updates the driver to advertise 2.5Gb and 5.0Gb if the adapter > supports it. > > Stephen Hemminger renames our dcbnl_ops since it is global to > ixgbe_dcbnl_ops to avoid namespace is

Re: net: hix5hd2_gmac uninitialized net_device

2017-02-16 Thread Dongpo Li
Hi Marty, On 2017/2/17 2:45, Marty Plummer wrote: > On Wed, Feb 15, 2017 at 02:18:14PM +0800, Dongpo Li wrote: >> Hi Marty, >> >> On 2017/2/15 7:59, Marty Plummer wrote: >>> On Mon, Feb 13, 2017 at 09:25:38AM +0800, Dongpo Li wrote: >> Currently this driver can't support Hi3521a soc because of som

[PATCH net-next] rtnl: don't account unused struct ifla_port_vsi in rtnl_port_size

2017-02-16 Thread Daniel Borkmann
When allocating rtnl dump messages, struct ifla_port_vsi is never dumped, so we can save header plus payload in rtnl_port_size(). Infact, attribute IFLA_PORT_VSI_TYPE and struct ifla_port_vsi are not used anywhere in the kernel. We only need to keep the nla policy should applications in user space

Awaiting your urgent reply.

2017-02-16 Thread Dr Fili Dohani
Auditing / Accounting Director Bank of Africa (PLC) Barking-West Africa My name is Dr Fili Dohani, I am the manager of (Eco-Bank) in Ouagadougou Burkina Faso West Africa. I have a business proposal in the tune of ($17.3 Million United States Dollar only) after the successful transfer;We shall

[PATCH net] mlx4: fix potential divide by 0 in mlx4_en_auto_moderation()

2017-02-16 Thread Eric Dumazet
From: Eric Dumazet 1) In the case where rate == priv->pkt_rate_low == priv->pkt_rate_high, mlx4_en_auto_moderation() does a divide by zero. 2) We want to properly change the moderation parameters if rx_frames was changed (like in ethtool -C eth0 rx-frames 16) Signed-off-by: Eric Dumazet ---

Re: [PATCH net-next] mlx4: do not fire tasklet unless necessary

2017-02-16 Thread Eric Dumazet
On Thu, 2017-02-16 at 23:17 +0200, Saeed Mahameed wrote: > so i guess you are not busy polling .. and adaptive moderation decided > to lower down > rx-usecs for you, and you are looking to improve latency. > > > Interrupt moderation is a latency killer, we want our usec back. > > > > well, for R

Re: Questions on XDP

2017-02-16 Thread John Fastabend
On 17-02-16 12:41 PM, Alexander Duyck wrote: > So I'm in the process of working on enabling XDP for the Intel NICs > and I had a few questions so I just thought I would put them out here > to try and get everything sorted before I paint myself into a corner. > Added Daniel. > So my first questio

[PATCH] net: qlogic: netxen: use new api ethtool_{get|set}_link_ksettings

2017-02-16 Thread Philippe Reynes
The ethtool api {get|set}_settings is deprecated. We move this driver to new api {get|set}_link_ksettings. As I don't have the hardware, I'd be very pleased if someone may test this patch. Signed-off-by: Philippe Reynes --- .../ethernet/qlogic/netxen/netxen_nic_ethtool.c| 123 ++---

RFC: unit tests for kernel GTP module

2017-02-16 Thread Harald Welte
Dear GTP-interested folks, I would love to somehow get towards some degree of unit testing (or even "continuous integration") for teh kernel GTP code. We currently have the original code in the kernel, we had some recent small fixes and now are getting more patches into place. With relatively fe

Re: [PATCH net-next] net/gtp: Add udp source port generation according to flow hash

2017-02-16 Thread Andreas Schultz
Hi Or, - On Feb 16, 2017, at 3:59 PM, Or Gerlitz ogerl...@mellanox.com wrote: > Generate the source udp header according to the flow represented by > the packet we are encapsulating, as done for other udp tunnels. This > helps on the receiver side to apply RSS spreading. This might work for

[PATCH] net: hamachi: use new api ethtool_{get|set}_link_ksettings

2017-02-16 Thread Philippe Reynes
The ethtool api {get|set}_settings is deprecated. We move this driver to new api {get|set}_link_ksettings. As I don't have the hardware, I'd be very pleased if someone may test this patch. Signed-off-by: Philippe Reynes --- drivers/net/ethernet/packetengines/hamachi.c | 14 -- 1 f

Re: [PATCH net-next v3 0/8] gtp: misc improvements

2017-02-16 Thread Andreas Schultz
Hi Pablo, Harald, Do you have some time to look at the patches? Andreas - On Feb 13, 2017, at 4:36 PM, Andreas Schultz aschu...@tpip.net wrote: > Hi Pablo, > > This is v3 of the GTP improvements. > > This series lays the groundwork for removing the socket references from > the GTP netdevi

[PATCH net-next] bridge: don't indicate expiry on NTF_EXT_LEARNED fdb entries

2017-02-16 Thread Roopa Prabhu
From: Roopa Prabhu added_by_external_learn fdb entries are added and expired by external entities like switchdev driver or external controllers. ageing is already disabled for such entries. Hence, don't indicate expiry for such fdb entries. CC: Nikolay Aleksandrov CC: Jiri Pirko CC: Ido Schimm

[PATCH] net/utils: fix semicolon.cocci warnings

2017-02-16 Thread kbuild test robot
net/core/utils.c:388:2-3: Unneeded semicolon Remove unneeded semicolon. Generated by: scripts/coccinelle/misc/semicolon.cocci CC: Sagi Grimberg Signed-off-by: Fengguang Wu --- utils.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/net/core/utils.c +++ b/net/core/utils.c @@

Re: [PATCH rfc 1/4] net/utils: generic inet_pton_with_scope helper

2017-02-16 Thread kbuild test robot
Hi Sagi, [auto build test WARNING on linus/master] [also build test WARNING on v4.10-rc8 next-20170216] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Sagi-Grimberg/Introduce-a-new-helper-for

[PATCH net-next 1/3] bpf: mark all registered map/prog types as __ro_after_init

2017-02-16 Thread Daniel Borkmann
All map types and prog types are registered to the BPF core through bpf_register_map_type() and bpf_register_prog_type() during init and remain unchanged thereafter. As by design we don't (and never will) have any pluggable code that can register to that at any later point in time, lets mark all th

[PATCH net-next 3/3] bpf: make jited programs visible in traces

2017-02-16 Thread Daniel Borkmann
Long standing issue with JITed programs is that stack traces from function tracing check whether a given address is kernel code through {__,}kernel_text_address(), which checks for code in core kernel, modules and dynamically allocated ftrace trampolines. But what is still missing is BPF JITed prog

[PATCH net-next 0/3] Misc BPF improvements

2017-02-16 Thread Daniel Borkmann
This last series for this window adds various misc improvements to BPF, one is to mark registered map and prog types as __ro_after_init, another one for removing cBPF stubs in eBPF JITs and moving the stub to the core and last also improving JITs is to make generated images visible to the kernel an

[PATCH net-next 2/3] bpf: remove stubs for cBPF from arch code

2017-02-16 Thread Daniel Borkmann
Remove the dummy bpf_jit_compile() stubs for eBPF JITs and make that a single __weak function in the core that can be overridden similarly to the eBPF one. Also remove stale pr_err() mentions of bpf_jit_compile. Signed-off-by: Daniel Borkmann Acked-by: Alexei Starovoitov --- arch/arm64/net/bpf_

Re: [patch net-next RFC 0/8] Add support for pipeline debug (dpipe)

2017-02-16 Thread arkadis
On 02/16/2017 06:48 PM, Jiri Pirko wrote: > Thu, Feb 16, 2017 at 05:40:29PM CET, and...@lunn.ch wrote: >> On Thu, Feb 16, 2017 at 05:20:00PM +0100, Jiri Pirko wrote: >>> Thu, Feb 16, 2017 at 05:11:50PM CET, and...@lunn.ch wrote: On Thu, Feb 16, 2017 at 04:22:36PM +0100, Jiri Pirko wrote: >>>

Re: [PATCH net-next] mlx4: do not fire tasklet unless necessary

2017-02-16 Thread Saeed Mahameed
On Thu, Feb 16, 2017 at 5:49 PM, Eric Dumazet wrote: > On Thu, 2017-02-16 at 14:44 +0200, Saeed Mahameed wrote: >> On Wed, Feb 15, 2017 at 4:04 PM, Eric Dumazet wrote: >> > On Wed, 2017-02-15 at 05:29 -0800, Eric Dumazet wrote: >> > >> >> >> >> mlx4_eq_int() is a hard irq handler. >> >> >> >> How

Re: [PATCH v3 net-next 08/14] mlx4: use order-0 pages for RX

2017-02-16 Thread Saeed Mahameed
On Thu, Feb 16, 2017 at 9:03 PM, David Miller wrote: > From: Tom Herbert > Date: Thu, 16 Feb 2017 09:05:26 -0800 > >> On Thu, Feb 16, 2017 at 5:08 AM, Tariq Toukan wrote: >>> >>> On 15/02/2017 6:57 PM, Eric Dumazet wrote: On Wed, Feb 15, 2017 at 8:42 AM, Tariq Toukan wrote: >

Re: [PATCH 04/21] ARM: sun8i: dt: Add DT bindings documentation for Allwinner dwmac-sun8i

2017-02-16 Thread Florian Fainelli
On 02/16/2017 04:48 AM, Corentin Labbe wrote: > This patch adds documentation for Device-Tree bindings for the > Allwinner dwmac-sun8i driver. > > Signed-off-by: Corentin Labbe > --- > .../devicetree/bindings/net/dwmac-sun8i.txt| 86 > ++ > 1 file changed, 86 inserti

Re: [PATCH v3 net-next 08/14] mlx4: use order-0 pages for RX

2017-02-16 Thread Saeed Mahameed
On Thu, Feb 16, 2017 at 7:11 PM, Eric Dumazet wrote: >> You're admitting that Eric's patches improve driver quality, >> stability, and performance but you're not allowing this in the kernel >> because "we know what benchmarks our customers are going to run". > > Note that I do not particularly car

Questions on XDP

2017-02-16 Thread Alexander Duyck
So I'm in the process of working on enabling XDP for the Intel NICs and I had a few questions so I just thought I would put them out here to try and get everything sorted before I paint myself into a corner. So my first question is why does the documentation mention 1 frame per page for XDP? Is t

Re: [linux-sunxi] [PATCH 03/21] net-next: stmmac: add optional setup function

2017-02-16 Thread Peter Korsgaard
> "Corentin" == Corentin Labbe writes: > Instead of ading more ifthen login for adding a new mac_device_info s/login/logic/ -- Bye, Peter Korsgaard

Re: [PATCH v2 0/4] PTP attribute handling cleanup

2017-02-16 Thread Richard Cochran
On Tue, Feb 14, 2017 at 10:23:30AM -0800, Dmitry Torokhov wrote: > drivers/ptp/ptp_clock.c | 22 +++--- > drivers/ptp/ptp_private.h | 7 +- > drivers/ptp/ptp_sysfs.c | 167 > ++ > 3 files changed, 80 insertions(+), 116 deletions(-) Nice reductio

Re: [PATCH] netfilter: ipset: Null pointer exception in ipset list:set

2017-02-16 Thread Jozsef Kadlecsik
Hi, On Wed, 15 Feb 2017, Vishwanath Pai wrote: > If we use before/after to add an element to an empty list it will cause > a kernel panic. > > $> cat crash.restore > create a hash:ip > create b hash:ip > create test list:set timeout 5 size 4 > add test b before a > > $> ipset -R < crash.restore

Re: [PATCH net-next] cxgb4: Increase max number of tc u32 links

2017-02-16 Thread David Miller
From: Ganesh Goudar Date: Thu, 16 Feb 2017 12:22:45 +0530 > From: Arjun V > > Make max number of supported tc u32 links equal to max number of filters > supported by hardware. > > Signed-off-by: Arjun V > Signed-off-by: Rahul Lakkireddy > Signed-off-by: Casey Leedom > Signed-off-by: Ganesh

Re: [PATCH net-next] cxgb4: Remove redundant code in t4_uld_clean_up()

2017-02-16 Thread David Miller
From: Ganesh Goudar Date: Thu, 16 Feb 2017 12:27:15 +0530 > Remove variable rxq_info and also remove redundant assignment > to it. > > Signed-off-by: Ganesh Goudar Applied.

Re: [PATCH net-next] cxgb4: Add new T5 and T6 pci device id's

2017-02-16 Thread David Miller
From: Ganesh Goudar Date: Thu, 16 Feb 2017 12:25:52 +0530 > Signed-off-by: Ganesh Goudar Applied.

[PATCH net-next] bridge: vlan_tunnel: explicitly reset metadata attrs to NULL on failure

2017-02-16 Thread Roopa Prabhu
From: Roopa Prabhu Fixes: efa5356b0d97 ("bridge: per vlan dst_metadata netlink support") Signed-off-by: Roopa Prabhu --- net/bridge/br_vlan_tunnel.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/net/bridge/br_vlan_tunnel.c b/net/bridge/br_vlan_tunnel.c index b2b79a0..6d2c4ee 100644 -

Re: [PATCH v3 net-next 08/14] mlx4: use order-0 pages for RX

2017-02-16 Thread David Miller
From: Tom Herbert Date: Thu, 16 Feb 2017 09:05:26 -0800 > On Thu, Feb 16, 2017 at 5:08 AM, Tariq Toukan wrote: >> >> On 15/02/2017 6:57 PM, Eric Dumazet wrote: >>> >>> On Wed, Feb 15, 2017 at 8:42 AM, Tariq Toukan wrote: Isn't it the same principle in page_frag_alloc() ? It is ca

Re: [PATCH net-next] liquidio: improve UDP TX performance

2017-02-16 Thread David Miller
From: Rick Jones Date: Thu, 16 Feb 2017 10:43:41 -0800 > On 02/16/2017 10:38 AM, Felix Manlunas wrote: >> From: VSR Burru >> >> Improve UDP TX performance by: >> * reducing the ring size from 2K to 512 >> * replacing the numerous streaming DMA allocations for info buffers and >> gather lists w

Re: Autoneg off in TI cpsw driver

2017-02-16 Thread Sriram V
Hi Andrew, 1. run ethtool -s eth1 speed 10 duplex full autoneg off 2. ethtool eth1 <-- shows link up 3. remove cable<--- ethtool shows link down 4. plug it in. <-- ethtool Still shows link down I don't have the ip utility. I will cross compile it and get back to you

Re: Autoneg off in TI cpsw driver

2017-02-16 Thread Andrew Lunn
On Fri, Feb 17, 2017 at 12:01:32AM +0530, Sriram V wrote: > Hi, > > I am using a Linux Kernel 4.1 Kernel. on AM437X with dual emac configuration. > > What i find is if i do the following the Link does not come up. > > 1. run ethtool -s eth1 speed 10 duplex full autoneg off > 2. remove cable > 3.

Re: [PATCH net-next] liquidio: improve UDP TX performance

2017-02-16 Thread Rick Jones
On 02/16/2017 10:38 AM, Felix Manlunas wrote: From: VSR Burru Improve UDP TX performance by: * reducing the ring size from 2K to 512 * replacing the numerous streaming DMA allocations for info buffers and gather lists with one large consistent DMA allocation per ring By how much was UDP TX

Re: net: hix5hd2_gmac uninitialized net_device

2017-02-16 Thread Marty Plummer
On Wed, Feb 15, 2017 at 02:18:14PM +0800, Dongpo Li wrote: > Hi Marty, > > On 2017/2/15 7:59, Marty Plummer wrote: > > On Mon, Feb 13, 2017 at 09:25:38AM +0800, Dongpo Li wrote: > Currently this driver can't support Hi3521a soc because of some new changes. > I don't know what's your purpose to run

[PATCH] e1000e: fix timing for 82579 Gigabit Ethernet controller

2017-02-16 Thread Bernd Faust
After an upgrade to Linux kernel v4.x the hardware timestamps of the 82579 Gigabit Ethernet Controller are different than expected. The values that are being read are almost four times as big as before the kernel upgrade. The difference is that after the upgrade the driver sets the clock frequency

[PATCH net-next] liquidio: improve UDP TX performance

2017-02-16 Thread Felix Manlunas
From: VSR Burru Improve UDP TX performance by: * reducing the ring size from 2K to 512 * replacing the numerous streaming DMA allocations for info buffers and gather lists with one large consistent DMA allocation per ring Signed-off-by: VSR Burru Signed-off-by: Felix Manlunas Signed-off-by:

Re: [patch net-next RFC 0/8] Add support for pipeline debug (dpipe)

2017-02-16 Thread Jiri Pirko
Thu, Feb 16, 2017 at 06:04:46PM CET, and...@lunn.ch wrote: >On Thu, Feb 16, 2017 at 04:22:36PM +0100, Jiri Pirko wrote: >> From: Jiri Pirko > >Hi Jiri, Arkadi > >Just to make sure we are all on the same page here: > >This purely RFC. It is not intended for the merge window starting next >week? No

Autoneg off in TI cpsw driver

2017-02-16 Thread Sriram V
Hi, I am using a Linux Kernel 4.1 Kernel. on AM437X with dual emac configuration. What i find is if i do the following the Link does not come up. 1. run ethtool -s eth1 speed 10 duplex full autoneg off 2. remove cable 3. plug it in. With the above sequence. The link does not come up. the plug i

Re: [PATCH] dccp: fix freeing skb too early for IPV6_RECVPKTINFO

2017-02-16 Thread Eric Dumazet
On Thu, 2017-02-16 at 17:22 +0100, Andrey Konovalov wrote: > In the current DCCP implementation an skb for a DCCP_PKT_REQUEST packet > is forcibly freed via __kfree_skb in dccp_rcv_state_process if > dccp_v6_conn_request successfully returns. > > goto discard; Thanks a lot A

Re: [PATCH rfc 0/4] Introduce a new helper for parsing ipv[4|6]:port to socket address

2017-02-16 Thread Sagi Grimberg
Yea, I wanted to get all the rpc_pton/rpc_ntop (which handle both ipv4 and ipv6 with scopes) converted to use a common helper. RPC is dealing with universal addresses, which are not quite the same as IP presentation addresses. The port number is expressed as: hi8.lo8 I noticed that, that'

Re: [PATCH rfc 0/4] Introduce a new helper for parsing ipv[4|6]:port to socket address

2017-02-16 Thread Chuck Lever
> On Feb 16, 2017, at 12:53 PM, Sagi Grimberg wrote: > > Hey Chuck, > >>> As a side-effect, this set adds ipv6 support for nvme over fabrics. >>> I also converted iscsi target and plan to convert nfs/cifs next but >>> wanted to get some feedback before doing that. >> >> At least NFS/RDMA alrea

Re: [PATCH rfc 0/4] Introduce a new helper for parsing ipv[4|6]:port to socket address

2017-02-16 Thread Sagi Grimberg
Hey Chuck, As a side-effect, this set adds ipv6 support for nvme over fabrics. I also converted iscsi target and plan to convert nfs/cifs next but wanted to get some feedback before doing that. At least NFS/RDMA already supports IPv6. You might not need many changes there, but I'll hold off on

Re: [PATCH rfc 0/4] Introduce a new helper for parsing ipv[4|6]:port to socket address

2017-02-16 Thread Chuck Lever
> On Feb 16, 2017, at 12:43 PM, Sagi Grimberg wrote: > > We have some places in the stack that support ipv4 and ipv6. In > some cases the user configuration does not reveal which > address family is given and needs to be parsed from the input string. > > Given that the user-input varies between

[PATCH rfc 4/4] iscsi-target: use generic inet_pton_with_scope

2017-02-16 Thread Sagi Grimberg
Signed-off-by: Sagi Grimberg --- drivers/target/iscsi/iscsi_target_configfs.c | 46 1 file changed, 12 insertions(+), 34 deletions(-) diff --git a/drivers/target/iscsi/iscsi_target_configfs.c b/drivers/target/iscsi/iscsi_target_configfs.c index bf40f03755dd..f30c27b

[PATCH rfc 3/4] nvme-rdma: use inet_pton_with_scope helper

2017-02-16 Thread Sagi Grimberg
Signed-off-by: Sagi Grimberg --- drivers/nvme/host/rdma.c | 48 +--- 1 file changed, 13 insertions(+), 35 deletions(-) diff --git a/drivers/nvme/host/rdma.c b/drivers/nvme/host/rdma.c index 890e7e4b1c15..bf02acbb4af8 100644 --- a/drivers/nvme/host/rdma

[PATCH rfc 0/4] Introduce a new helper for parsing ipv[4|6]:port to socket address

2017-02-16 Thread Sagi Grimberg
We have some places in the stack that support ipv4 and ipv6. In some cases the user configuration does not reveal which address family is given and needs to be parsed from the input string. Given that the user-input varies between subsystems, some processing is required from the call-site to separ

[PATCH rfc 1/4] net/utils: generic inet_pton_with_scope helper

2017-02-16 Thread Sagi Grimberg
Several locations in the stack need to handle ipv4/ipv6 (with scope) and port strings conversion to sockaddr. Add a helper that takes either AF_INET, AF_INET6 or AF_UNSPEC (for wildcard) to centralize this handling. Suggested-by: Christoph Hellwig Signed-off-by: Sagi Grimberg --- include/linux/

[PATCH rfc 2/4] nvmet-rdma: use generic inet_pton_with_scope

2017-02-16 Thread Sagi Grimberg
Signed-off-by: Sagi Grimberg --- drivers/nvme/target/rdma.c | 42 +- 1 file changed, 29 insertions(+), 13 deletions(-) diff --git a/drivers/nvme/target/rdma.c b/drivers/nvme/target/rdma.c index 8c3760a78ac0..298db68f2db9 100644 --- a/drivers/nvme/target/rd

RE: [PATCH 1/2] gianfar: Deal with link state changes during GFAR_RESETTING dev state

2017-02-16 Thread Claudiu Manoil
>-Original Message- >From: Thomas Graziadei [mailto:thomas.grazia...@omicronenergy.com] >Sent: Monday, February 13, 2017 2:22 PM >To: claudiu.man...@freescale.com; netdev@vger.kernel.org; linux- >ker...@vger.kernel.org >Cc: Thomas Graziadei >Subject: [PATCH 1/2] gianfar: Deal with link sta

Re: [PATCH net-next] virito-net: set queues after reset during xdp_set

2017-02-16 Thread Michael S. Tsirkin
On Wed, Feb 15, 2017 at 05:08:09PM +0800, Jason Wang wrote: > We set queues before reset which will cause a crash[1]. This is > because is_xdp_raw_buffer_queue() depends on the old xdp queue pairs > number to do the correct detection. So fix this by: > > - set queues after reset, to keep the old v

Re: [PATCH v3 net-next 08/14] mlx4: use order-0 pages for RX

2017-02-16 Thread Eric Dumazet
> You're admitting that Eric's patches improve driver quality, > stability, and performance but you're not allowing this in the kernel > because "we know what benchmarks our customers are going to run". Note that I do not particularly care if these patches go in 4.11 or 4.12 really. I already bac

Re: [PATCH v3 net-next 08/14] mlx4: use order-0 pages for RX

2017-02-16 Thread Tom Herbert
On Thu, Feb 16, 2017 at 5:08 AM, Tariq Toukan wrote: > > On 15/02/2017 6:57 PM, Eric Dumazet wrote: >> >> On Wed, Feb 15, 2017 at 8:42 AM, Tariq Toukan wrote: >>> >>> Isn't it the same principle in page_frag_alloc() ? >>> It is called form __netdev_alloc_skb()/__napi_alloc_skb(). >>> >>> Why is i

Re: [patch net-next RFC 0/8] Add support for pipeline debug (dpipe)

2017-02-16 Thread Andrew Lunn
On Thu, Feb 16, 2017 at 04:22:36PM +0100, Jiri Pirko wrote: > From: Jiri Pirko Hi Jiri, Arkadi Just to make sure we are all on the same page here: This purely RFC. It is not intended for the merge window starting next week? This is a new binary API, something we have to live with forever. So i

[PATCH iproute2 4/4] ip vrf: Detect invalid vrf name in pids command

2017-02-16 Thread David Ahern
Verify VRF name is valid before attempting to read cgroups files. Signed-off-by: David Ahern --- ip/ipvrf.c | 4 1 file changed, 4 insertions(+) diff --git a/ip/ipvrf.c b/ip/ipvrf.c index cb7f9fa6d1db..5e204a9ebbb1 100644 --- a/ip/ipvrf.c +++ b/ip/ipvrf.c @@ -212,6 +212,10 @@ static int ip

[PATCH iproute2 2/4] ip netns: refactor netns_identify

2017-02-16 Thread David Ahern
Move guts of netns_identify into a standalone function that returns the netns name in a given buffer. Signed-off-by: David Ahern --- ip/ip_common.h | 1 + ip/ipnetns.c | 47 +++ 2 files changed, 32 insertions(+), 16 deletions(-) diff --git a/ip/ip_

[PATCH iproute2 3/4] ip vrf: Handle VRF nesting in namespace

2017-02-16 Thread David Ahern
Since cgroups are not namespace aware, the directory heirarchy used by ip vrf should account for network namespaces. In this case, change the path from CGRP/BASE/vrf/NAME to CGRP/BASE/NETNS/vrf/NAME where CGRP is the cgroup2 mount path, BASE in any base heirarchy inherited before VRF is applied and

[PATCH iproute2 1/4] ip vrf: Handle vrf in a cgroup hierarchy

2017-02-16 Thread David Ahern
Add support for VRF in a pre-existing hierarchy. For example, if the current process is running in CGRP/foo/bar, the 'ip vrf exec NAME CMD' should run CMD in the cgroup CGRP/foo/bar/vrf/NAME. When listing process ids in a VRF, search for the directory vrf/NAME regardless of base path (foo/bar/vrf/

[PATCH iproute2 0/4] ip vrf: updates to handle cgroup hiearchy and namespace nesting

2017-02-16 Thread David Ahern
More updates to ip vrf for 4.10. Major changes: handle vrf in an existing cgroup hierarchy and handle vrf nesting in network namespaces. Comparison of the netns in bpf code will be added once the kernel patch is accepted. David Ahern (4): ip vrf: Handle vrf in a cgroup hierarchy ip netns: ref

Re: [patch net-next RFC 0/8] Add support for pipeline debug (dpipe)

2017-02-16 Thread Jiri Pirko
Thu, Feb 16, 2017 at 05:40:29PM CET, and...@lunn.ch wrote: >On Thu, Feb 16, 2017 at 05:20:00PM +0100, Jiri Pirko wrote: >> Thu, Feb 16, 2017 at 05:11:50PM CET, and...@lunn.ch wrote: >> >On Thu, Feb 16, 2017 at 04:22:36PM +0100, Jiri Pirko wrote: >> >> From: Jiri Pirko >> >> >> >> Arkadi says: >>

Re: [patch net-next RFC 0/8] Add support for pipeline debug (dpipe)

2017-02-16 Thread Andrew Lunn
On Thu, Feb 16, 2017 at 05:20:00PM +0100, Jiri Pirko wrote: > Thu, Feb 16, 2017 at 05:11:50PM CET, and...@lunn.ch wrote: > >On Thu, Feb 16, 2017 at 04:22:36PM +0100, Jiri Pirko wrote: > >> From: Jiri Pirko > >> > >> Arkadi says: > > > >Hi Jiri, Arkadi > > > >It is not mentioned here, but i assume

  1   2   3   >