Re: [patch net-next RFC 1/8] devlink: Support for pipeline debug (dpipe)

2017-02-17 Thread Jiri Pirko
Fri, Feb 17, 2017 at 09:49:07AM CET, simon.hor...@netronome.com wrote: >Hi Jiri, > >On Thu, Feb 16, 2017 at 04:22:37PM +0100, Jiri Pirko wrote: >> From: Arkadi Sharshevsky >> >> The pipeline debug is used to export the pipeline abstractions >> for the main objects - tables, headers and entries. T

Re: [4.9.10] ip_route_me_harder() reading off-slab

2017-02-17 Thread Daniel J Blueman
On 17 February 2017 at 13:36, Eric Dumazet wrote: > On Fri, 2017-02-17 at 12:36 +0800, Daniel J Blueman wrote: >> When booting a VM in libvirt/KVM attached to a local bridge and KASAN >> enabled on 4.9.10, we see a stream of KASAN warnings about off-slab >> access [1]. >> >> Let me know if you'd l

[GIT] Networking

2017-02-17 Thread David Miller
1) Fix leak in dpaa_eth error paths, from Dan Carpenter. 2) Use after free when using IPV6_RECVPKTINFO, from Andrey Konovalov. 3) fanout_release() cannot be invoked from atomic contexts, from Anoob Soman. 4) Fix bogus attempt at lockdep annotation in IRDA. 5) dev_fill_metadata_dst() can OOP

[patch] socket.7: Document SO_INCOMING_CPU

2017-02-17 Thread Francois Saint-Jacques
This socket option is undocumented. Applies on the latest version (man-pages-4.09-511). diff --git a/man7/socket.7 b/man7/socket.7 index 3efd7a5d8..1a3ffa253 100644 --- a/man7/socket.7 +++ b/man7/socket.7 @@ -490,6 +490,26 @@ flag on a socket operation. Expects an integer boolean flag. .TP +.BR

[net-next][PATCH v1] RDS: keep data type consistent in the user visible header

2017-02-17 Thread Santosh Shilimkar
rds.h is exported to /usr/include/rds.h, so u8, u64 leads to errors like below. /usr/include/linux/rds.h:197: error: expected specifier-qualifier-list before 'u8' /usr/include/linux/rds.h:202: error: expected specifier-qualifier-list before 'u8' Fix it by following same types as rest of the us

[net-next][PATCH] RDS: keep data type consistent in the user visible header

2017-02-17 Thread Santosh Shilimkar
From: Santosh Shilimkar rds.h is exported to /usr/include/rds.h, so u8, u64 leads to errors like below. /usr/include/linux/rds.h:197: error: expected specifier-qualifier-list before 'u8' /usr/include/linux/rds.h:202: error: expected specifier-qualifier-list before 'u8' Fix it by following sa

Re: [PATCH net-next] mlx4: do not fire tasklet unless necessary

2017-02-17 Thread Eric Dumazet
On Thu, 2017-02-16 at 07:30 -0800, Eric Dumazet wrote: > On Thu, 2017-02-16 at 14:38 +0200, Saeed Mahameed wrote: > > > Acked-by: Saeed Mahameed > > Thanks for reviewing this Saeed ! Note that mlx4_add_cq_to_tasklet() is called from hard irq context, so we could replace the spin_lock_irqsave()

Re: [PATCH][CFT] Saner error handling in skb_copy_datagram_iter() et.al.

2017-02-17 Thread Al Viro
On Sat, Feb 18, 2017 at 12:02:14AM +, Al Viro wrote: > On Fri, Feb 17, 2017 at 05:03:15PM +, Al Viro wrote: > > On Fri, Feb 17, 2017 at 10:54:20AM -0500, David Miller wrote: > > > From: Al Viro > > > Date: Tue, 14 Feb 2017 01:33:06 + > > > > > > > OK... Remaining interesting question

[PATCH net-next] openvswitch: Set event bit after initializing labels.

2017-02-17 Thread Jarno Rajahalme
Connlabels are included in conntrack netlink event messages only if the IPCT_LABEL bit is set in the event cache (see ctnetlink_conntrack_event()). Set it after initializing labels for a new connection. Found upon further system testing, where it was noticed that labels were missing from the conn

[PATCH net-next] net: mpls: Add support for netconf

2017-02-17 Thread David Ahern
Add netconf support to MPLS. Allows userpsace to learn and be notified of changes to 'input' enable setting per interface. Signed-off-by: David Ahern --- include/uapi/linux/netconf.h | 1 + include/uapi/linux/rtnetlink.h | 2 + net/mpls/af_mpls.c | 212 +

[PATCH 1/2] tcp: setup random timestamp offset when write_seq already set

2017-02-17 Thread Alexey Kodanev
Found that when random offset enabled (default) TCP client can still start new connections with and without random offsets. Later, if server does active close and re-use sockets in TIME-WAIT state, new SYN from client can be rejected on PAWS check inside tcp_timewait_state_process(). Here is how t

[PATCH 2/2] tcp: account for ts offset only if tsecr not zero

2017-02-17 Thread Alexey Kodanev
We can get SYN with zero tsecr, don't apply offset in this case. Fixes: ee684b6f2830 ("tcp: send packets with a socket timestamp") Signed-off-by: Alexey Kodanev --- net/ipv4/tcp_minisocks.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/net/ipv4/tcp_minisocks.c b/net/

Re: [PATCH] net/utils: fix semicolon.cocci warnings

2017-02-17 Thread Fengguang Wu
Hi Dave, On Fri, Feb 17, 2017 at 01:52:54PM -0500, David Miller wrote: From: kbuild test robot Date: Fri, 17 Feb 2017 05:34:03 +0800 net/core/utils.c:388:2-3: Unneeded semicolon Remove unneeded semicolon. Generated by: scripts/coccinelle/misc/semicolon.cocci CC: Sagi Grimberg Signed-off

[PATCH net 2/2] net: phy: Check phydev->drv

2017-02-17 Thread Florian Fainelli
There are number of function calls, originating from user-space, typically through the Ethernet driver that can make us crash by dereferencing phydev->drv which will be NULL once we unbind the driver from the PHY. There are still functional issues that prevent an unbind then rebind to work, but th

[PATCH net 0/2] net: phy: Fix PHY unbind crash

2017-02-17 Thread Florian Fainelli
Hi David, This fixes crashes when the PHY driver is no longer bound to the device. There is still a fair amount of work to be done to get the unbind -> bind sequent to result in a functional state, but that will be net-next material. These two problems existed for as long as PHYLIB as been aroun

[PATCH net 1/2] net: phy: Fix PHY unbind crash

2017-02-17 Thread Florian Fainelli
The PHY library does not deal very well with bind and unbind events. The first thing we would see is that we were not properly canceling the PHY state machine workqueue, so we would be crashing while dereferencing phydev->drv since there is no driver attached anymore. Suggested-by: Russell King S

Re: [PATCH][CFT] Saner error handling in skb_copy_datagram_iter() et.al.

2017-02-17 Thread Al Viro
On Fri, Feb 17, 2017 at 05:03:15PM +, Al Viro wrote: > On Fri, Feb 17, 2017 at 10:54:20AM -0500, David Miller wrote: > > From: Al Viro > > Date: Tue, 14 Feb 2017 01:33:06 + > > > > > OK... Remaining interesting question is whether it adds a noticable > > > overhead. Could somebody try i

Re: [PATCH net-next v2 2/6] net: dsa: mv88e6xxx: move ATU code in its own file

2017-02-17 Thread David Miller
From: Andrew Lunn Date: Fri, 17 Feb 2017 23:36:51 +0100 > Please take your time to do this right. Lots of small patches, which > are obviously correct. Agreed.

Re: [PATCH net-next] virito-net: set queues after reset during xdp_set

2017-02-17 Thread John Fastabend
On 17-02-16 09:10 PM, Jason Wang wrote: > > > On 2017年02月17日 12:53, John Fastabend wrote: >> On 17-02-15 01:08 AM, Jason Wang wrote: >>> We set queues before reset which will cause a crash[1]. This is >>> because is_xdp_raw_buffer_queue() depends on the old xdp queue pairs >>> number to do the co

Re: [PATCH net-next v2 11/12] net: ethernet: aquantia: Fixed memory allocation if AQ_CFG_RX_FRAME_MAX > 1 page.

2017-02-17 Thread Andrew Lunn
> diff --git a/drivers/net/ethernet/aquantia/atlantic/aq_ring.c > b/drivers/net/ethernet/aquantia/atlantic/aq_ring.c > index 4c40644..0877625 100644 > --- a/drivers/net/ethernet/aquantia/atlantic/aq_ring.c > +++ b/drivers/net/ethernet/aquantia/atlantic/aq_ring.c > @@ -278,6 +278,8 @@ int aq_ring_r

Re: [PATCH net-next v2 03/12] net: ethernet: aquantia: Removed unnecessary comparsion "old_mtu == new_mtu".

2017-02-17 Thread Andrew Lunn
On Sat, Feb 18, 2017 at 12:07:25AM +0300, Pavel Belous wrote: > From: Pavel Belous > > This check is not needed. Function aq_ndev_change_mtu wont be called > if mtu has not changed. > > Signed-off-by: Pavel Belous > --- > drivers/net/ethernet/aquantia/atlantic/aq_main.c | 6 ++ > 1 file ch

Re: [PATCH net-next v2 2/6] net: dsa: mv88e6xxx: move ATU code in its own file

2017-02-17 Thread Andrew Lunn
> Note that we are very close from 4.10, so unless there is a major issue > in the patchset, I'd prefer not to respin new versions. I'd gladly send > cosmetics fixup later though. I'm waiting for this patchset to land in > net-next to send the second one ready for cross-chip bridging in DSA. I kno

Re: net: use-after-free in tw_timer_handler

2017-02-17 Thread Cong Wang
On Fri, Feb 17, 2017 at 12:36 PM, Dmitry Vyukov wrote: > On Fri, Feb 17, 2017 at 7:51 PM, Cong Wang wrote: >> >> This code was changed a long time ago : >> >> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=ed2e923945892a8372ab70d2f61d364b0b6d9054 >>

[PATCH net-next 3/7] nfp: store NSP ABI version in state structure

2017-02-17 Thread Jakub Kicinski
We read the status register on each NSP open, we can store the NSP ABI version in the state structure so that we don't have to read it again. Signed-off-by: Jakub Kicinski --- .../net/ethernet/netronome/nfp/nfpcore/nfp_nsp.c | 27 +++--- 1 file changed, 13 insertions(+), 14 del

[PATCH net-next 7/7] nfp: allow application firmware to limit number of SR-IOV VFs

2017-02-17 Thread Jakub Kicinski
Some application firmware projects may choose to limit the number of VFs available below what is specified in PCI capability to be able to reuse the PCIe interface resources. There may also be projects which use cases don't require SR-IOV support at all and therefore don't want to spend time imple

[PATCH net-next 1/7] nfp: refactor NSP initialization and add error message

2017-02-17 Thread Jakub Kicinski
When acquiring NSP communication resource fails user is left with "probe failed with error -2" PCI code message but no info on what caused the problem. Some development boards may not have NSP FW in the flash image. Help users with a more verbouse message. While at it move the whole NSP init to

[PATCH net-next 5/7] nfp: add very basic access to NSP logs

2017-02-17 Thread Jakub Kicinski
Allow dumping "arm.diag" resource with ethtool -w. This resource should contain a text log of the NSP (control processor) application. Signed-off-by: Jakub Kicinski --- drivers/net/ethernet/netronome/nfp/nfp_net.h | 2 + .../net/ethernet/netronome/nfp/nfp_net_ethtool.c | 76 +++

[PATCH net-next 2/7] nfp: report manufacturing info on load

2017-02-17 Thread Jakub Kicinski
Report card manufacturing information when driver loads. These identify the version of the board and its subcomponents. Signed-off-by: Jakub Kicinski --- drivers/net/ethernet/netronome/nfp/nfp_main.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/net/ethernet/netronome/nfp/n

[PATCH net-next 0/7] nfp: expose more firmware and hw debug info

2017-02-17 Thread Jakub Kicinski
Hi! This series is mostly a result of flash firmware team requesting access to some of the information and data necessary for debugging firmware problems. Patch 1 adds a missing error message. Patch 2 prints manufacturing info to logs in case PCI VPD capability is not programmed correctly.

[PATCH net-next 4/7] nfp: report NSP ABI version in ethtool FW version

2017-02-17 Thread Jakub Kicinski
ethtool_drvinfo->fw_version can cantain multiple FW strings. We already report NFD ABI version there, add NSP ABI version if available (i.e. on PF) with 'sp:' prefix. Signed-off-by: Jakub Kicinski --- drivers/net/ethernet/netronome/nfp/nfp_net.h | 4 .../net/ethernet/netronome/nfp/nf

[PATCH net-next 6/7] nfp: return nfp_rtsym_read_le() errors correctly

2017-02-17 Thread Jakub Kicinski
nfp_rtsym_read_le() has an out parameter for error codes. We have to use that instead of returning errors directly. Signed-off-by: Jakub Kicinski --- drivers/net/ethernet/netronome/nfp/nfpcore/nfp_rtsym.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/net/eth

Re: [PATCH net-next v2 2/6] net: dsa: mv88e6xxx: move ATU code in its own file

2017-02-17 Thread Vivien Didelot
Hi Andrew, Andrew Lunn writes: > This seems to be more than renaming a few functions. There looks to be > real changes here. I think these changes should be split out into a > separate patch with an explanation what is being changed. Keep this > patch for plain renames. > > It would also be easi

Re: [PATCH net-next v2 6/6] net: dsa: mv88e6xxx: add support for 6390 VTU

2017-02-17 Thread Andrew Lunn
On Fri, Feb 17, 2017 at 10:05:31AM -0500, Vivien Didelot wrote: > The 6390 family of chips use only 2 of the 3 VTU Data registers to pack > the MemberTag and PortState VLAN data. This means that they must be > written or read before or after each VTU/STU operations. > > Implement this variant to a

Re: [PATCH net-next v2 5/6] net: dsa: mv88e6xxx: add VTU ops

2017-02-17 Thread Andrew Lunn
On Fri, Feb 17, 2017 at 10:05:30AM -0500, Vivien Didelot wrote: > Because there are several variant of the VTU operations and because > checking for the presence of an STU is not enough, add new ops to the > info structure to describe the VTU operations that a chip supports. > > Signed-off-by: Viv

Re: [PATCH net-next v2 4/6] net: dsa: mv88e6xxx: move VTU code to its own file

2017-02-17 Thread Andrew Lunn
On Fri, Feb 17, 2017 at 10:05:29AM -0500, Vivien Didelot wrote: > Move the Global (1) VTU related code to its own file. > > Use this opportunity to provide a cleaner API for the VTU, by renaming a > few underscore prefixed functions, split the data member of the > mv88e6xxx_vtu_entry structure int

Re: [PATCH] of_mdio: Add "broadcom,bcm5241" to the whitelist.

2017-02-17 Thread David Daney
On 02/17/2017 12:09 PM, Florian Fainelli wrote: On 02/17/2017 12:04 PM, David Daney wrote: Some Cavium dev boards have firmware which doesn't supply a proper ethernet-phy-ieee802.3-c22" compatible property. Restore these boards to working order by whitelisting this compatible value. Signed-off

Re: [PATCH net-next v2 3/6] net: dsa: mv88e6xxx: add support for 6390 ATU Move

2017-02-17 Thread Andrew Lunn
On Fri, Feb 17, 2017 at 10:05:28AM -0500, Vivien Didelot wrote: > The 6390 family of Marvell chips uses 5 bits to describe the ToPort and > FromPort values of PortVec in the ATU Move operation, while older > switches use 0xf. Hi Vivien Since you say 5 bits for 6390, it would be better to say 4 bi

Re: [PATCH net-next v2 2/6] net: dsa: mv88e6xxx: move ATU code in its own file

2017-02-17 Thread Andrew Lunn
On Fri, Feb 17, 2017 at 10:05:27AM -0500, Vivien Didelot wrote: > Move the Global (1) ATU related code in its own file, and export the > necessary primitives. > > Use that opportunity to provide a cleaner API for the ATU, by renaming a > few underscore prefixed functions, and members of the > mv88

Re: CHECKSUM_UNNECESSARY semantics with driver modified.created packets

2017-02-17 Thread Tom Herbert
On Fri, Feb 17, 2017 at 1:04 PM, Tom Herbert wrote: > Alexei and I were looking at the mlx5 LRO code this morning. One > discrepancy I noticed with GRO is that CHECKSUM_UNNECESSARY is set for > the assembled packet whereas in GRO we use CHECKSUM_PARTIAL. The > effect of using checksum-unnecessary

Re: [PATCH v3] net/irda: fix lockdep annotation

2017-02-17 Thread David Miller
From: Dmitry Vyukov Date: Fri, 17 Feb 2017 22:13:58 +0100 > On Fri, Jan 20, 2017 at 11:53 PM, Dmitry Vyukov wrote: >> On Thu, Jan 19, 2017 at 5:27 PM, David Miller wrote: >>> From: Dmitry Vyukov >>> Date: Thu, 19 Jan 2017 11:05:36 +0100 >>> Thanks for looking into it! This particular issu

Re: [PATCH net-next v2 1/6] net: dsa: mv88e6xxx: add port mask helper

2017-02-17 Thread Andrew Lunn
On Fri, Feb 17, 2017 at 10:05:26AM -0500, Vivien Didelot wrote: > Add a mv88e6xxx_port_mask() helper to get the bitmask of ports in a > switch chip, that will be used in several features. > > Signed-off-by: Vivien Didelot Reviewed-by: Andrew Lunn Andrew

Re: [PATCH v3] net/irda: fix lockdep annotation

2017-02-17 Thread Dmitry Vyukov
On Fri, Jan 20, 2017 at 11:53 PM, Dmitry Vyukov wrote: > On Thu, Jan 19, 2017 at 5:27 PM, David Miller wrote: >> From: Dmitry Vyukov >> Date: Thu, 19 Jan 2017 11:05:36 +0100 >> >>> Thanks for looking into it! This particular issue bothers my fuzzers >>> considerably. I agree that removing recurs

CHECKSUM_UNNECESSARY semantics with driver modified.created packets

2017-02-17 Thread Tom Herbert
Alexei and I were looking at the mlx5 LRO code this morning. One discrepancy I noticed with GRO is that CHECKSUM_UNNECESSARY is set for the assembled packet whereas in GRO we use CHECKSUM_PARTIAL. The effect of using checksum-unnecessary is that the actual TCP checksum in the packet is not correct

[PATCH net-next v2 04/12] net: ethernet: aquantia: Using module_pci_driver.

2017-02-17 Thread Pavel Belous
From: Pavel Belous Remove boilerplate code by using macro module_pci_driver. Signed-off-by: Pavel Belous --- drivers/net/ethernet/aquantia/atlantic/aq_main.c | 20 +--- 1 file changed, 1 insertion(+), 19 deletions(-) diff --git a/drivers/net/ethernet/aquantia/atlantic/aq_main.

[PATCH net-next v2 12/12] net: ethernet: aquantia: Copying tx buffers is not needed.

2017-02-17 Thread Pavel Belous
From: Pavel Belous This fix removes copying of tx biffers. Now we use ring->buff_fing directly. Signed-off-by: Pavel Belous --- drivers/net/ethernet/aquantia/atlantic/aq_nic.c | 170 +-- drivers/net/ethernet/aquantia/atlantic/aq_ring.c | 19 --- drivers/net/ethernet/aquan

[PATCH net-next v2 10/12] net: ethernet: aquantia: Fixed incorrect buff->len calculation.

2017-02-17 Thread Pavel Belous
From: Pavel Belous rxd_wb->pkt_len is the total length of the packet. If we received a large packet (with length > AQ_CFG_RX_FRAME_MAX) then we will get multiple buffers. We need to fix the length of the last buffer. Signed-off-by: Pavel Belous --- drivers/net/ethernet/aquantia/atlantic/hw_atl

[PATCH net-next v2 11/12] net: ethernet: aquantia: Fixed memory allocation if AQ_CFG_RX_FRAME_MAX > 1 page.

2017-02-17 Thread Pavel Belous
From: Pavel Belous We should allocate the number of pages based on the config parameter AQ_CFG_RX_FRAME_MAX. Signed-off-by: Pavel Belous --- drivers/net/ethernet/aquantia/atlantic/aq_nic.c | 4 ++-- drivers/net/ethernet/aquantia/atlantic/aq_ring.c | 4 +++- 2 files changed, 5 insertions(+), 3

[PATCH net-next v2 09/12] net: ethernet: aquantia: Call netdev_register after all initialized.

2017-02-17 Thread Pavel Belous
From: Pavel Belous netdev_register should be called when everything is initialized. Signed-off-by: Pavel Belous --- drivers/net/ethernet/aquantia/atlantic/aq_nic.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/aquantia/atlantic/aq_nic.c b/

[PATCH net-next v2 07/12] net: ethernet: aquantia: Using NETDEV_TX_OK instead 0.

2017-02-17 Thread Pavel Belous
From: Pavel Belous Use NETDEV_TX_OK as the return value for successful transmission. Signed-off-by: Pavel Belous --- drivers/net/ethernet/aquantia/atlantic/aq_nic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/aquantia/atlantic/aq_nic.c b/drivers/ne

[PATCH net-next v2 08/12] net: ethernet: aquantia: Null pointer check for aq_nic_ndev_alloc.

2017-02-17 Thread Pavel Belous
From: Pavel Belous We should check for a null pointer for aq_nic_ndev_alloc instead netdev_priv. Signed-off-by: Pavel Belous --- drivers/net/ethernet/aquantia/atlantic/aq_nic.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/aquantia/atlantic/aq_

[PATCH net-next v2 00/12] net: ethernet: aquantia: improvements and fixes

2017-02-17 Thread Pavel Belous
From: Pavel Belous The following patchset contains improvements and fixes for aQuantia AQtion ethernet driver from net-next tree. Most fixes are based on the comments from Lino Sanfilippo. Sanity testing was performed on real HW. No regression found. v1->v2 :Removed buffers copying. Fi

[PATCH net-next v2 05/12] net: ethernet: aquantia: Superfluous initialization of "err".

2017-02-17 Thread Pavel Belous
From: Pavel Belous Fixed superfluous initialization of err. Signed-off-by: Pavel Belous --- drivers/net/ethernet/aquantia/atlantic/aq_main.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/net/ethernet/aquantia/atlantic/aq_main.c b/drivers/net/ethernet/aquan

[PATCH net-next v2 02/12] net: ethernet: aquantia: Removed busy_count field.

2017-02-17 Thread Pavel Belous
From: Pavel Belous busy_count field and is_busy flag is not needed at all. Signed-off-by: Pavel Belous --- drivers/net/ethernet/aquantia/atlantic/aq_nic.c | 11 --- drivers/net/ethernet/aquantia/atlantic/aq_utils.h | 1 - 2 files changed, 12 deletions(-) diff --git a/drivers/net/e

[PATCH net-next v2 01/12] net: ethernet: aquantia: Removed extra assignment for skb->dev.

2017-02-17 Thread Pavel Belous
From: Pavel Belous This assignment is not needed. Signed-off-by: Pavel Belous --- drivers/net/ethernet/aquantia/atlantic/aq_ring.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/aquantia/atlantic/aq_ring.c b/drivers/net/ethernet/aquantia/atlantic/aq_ring.c index dea9e

[PATCH net-next v2 06/12] net: ethernet: aquantia: Fixed missing rtnl_unlock.

2017-02-17 Thread Pavel Belous
From: Pavel Belous rtnl_unlock should be called if error occurred. Signed-off-by: Pavel Belous --- drivers/net/ethernet/aquantia/atlantic/aq_nic.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/aquantia/atlantic/aq_nic.c b/drivers/net/ethernet/aq

[PATCH net-next v2 03/12] net: ethernet: aquantia: Removed unnecessary comparsion "old_mtu == new_mtu".

2017-02-17 Thread Pavel Belous
From: Pavel Belous This check is not needed. Function aq_ndev_change_mtu wont be called if mtu has not changed. Signed-off-by: Pavel Belous --- drivers/net/ethernet/aquantia/atlantic/aq_main.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/aquant

Re: [PATCHv2, 1/1] tcp: accommodate sequence number to a peer's shrunk receive window caused by precision loss in window scaling

2017-02-17 Thread David Miller
From: "Cui, Cheng" Date: Fri, 17 Feb 2017 17:04:55 + > Prevent sending out a left-shifted sequence number from a Linux sender in > response to a peer's shrunk receive-window caused by losing least significant > bits in window-scaling. > > Cc: "David S. Miller" > Cc: Alexey Kuznetsov > Cc:

Re: [PATCH net-next] rtnl: don't account unused struct ifla_port_vsi in rtnl_port_size

2017-02-17 Thread Daniel Borkmann
On 02/17/2017 08:57 PM, David Miller wrote: From: Daniel Borkmann Date: Fri, 17 Feb 2017 01:56:11 +0100 When allocating rtnl dump messages, struct ifla_port_vsi is never dumped, so we can save header plus payload in rtnl_port_size(). Infact, attribute IFLA_PORT_VSI_TYPE and struct ifla_port_vs

Re: net: use-after-free in tw_timer_handler

2017-02-17 Thread Dmitry Vyukov
On Fri, Feb 17, 2017 at 7:51 PM, Cong Wang wrote: > > This code was changed a long time ago : > > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=ed2e923945892a8372ab70d2f61d364b0b6d9054 > > So I suspect a recent patch broke the logic. > >

Re: [PATCH net-next] tcp: use page_ref_inc() in tcp_sendmsg()

2017-02-17 Thread David Miller
From: Eric Dumazet Date: Fri, 17 Feb 2017 09:11:42 -0800 > From: Eric Dumazet > > sk_page_frag_refill() allocates either a compound page or an order-0 > page. We can use page_ref_inc() which is slightly faster than get_page() > > Signed-off-by: Eric Dumazet Applied, thanks Eric.

Re: [PATCH net] vxlan: fix oops in dev_fill_metadata_dst

2017-02-17 Thread David Miller
From: Paolo Abeni Date: Fri, 17 Feb 2017 19:14:27 +0100 > Since the commit 0c1d70af924b ("net: use dst_cache for vxlan device") > vxlan_fill_metadata_dst() calls vxlan_get_route() passing a NULL > dst_cache pointer, so the latter should explicitly check for > valid dst_cache ptr. Unfortunately th

Re: [PATCH net-next 0/3] sfc: misc. fixes

2017-02-17 Thread David Miller
From: Edward Cree Date: Fri, 17 Feb 2017 15:47:32 + > Three largely unrelated fixes to increase robustness in rare edge cases. Series applied, thanks.

Re: [PATCH] vmxnet3: prevent building with 64K pages

2017-02-17 Thread David Miller
From: Arnd Bergmann Date: Fri, 17 Feb 2017 16:08:30 +0100 > I got a warning about broken code on ARM64 with 64K pages: > > drivers/net/vmxnet3/vmxnet3_drv.c: In function 'vmxnet3_rq_init': > drivers/net/vmxnet3/vmxnet3_drv.c:1679:29: error: large integer implicitly > truncated to unsigned type

Re: [PATCH net-next (repost)] nfp: Use PCI_DEVICE_ID_NETRONOME_NFP* defines

2017-02-17 Thread David Miller
From: Simon Horman Date: Fri, 17 Feb 2017 08:57:54 +0100 > Use PCI_DEVICE_ID_NETRONOME_NFP*, defined in linux/pci_ids.h, > rather than replicating the same values in the NFP driver. > > Signed-off-by: Simon Horman > > --- > * Reposted with subject and changelog adjusted to be less likely to be

Re: [PATCH] net/wan: add MODULE_LICENSE for fsl_ucc_hdlc

2017-02-17 Thread David Miller
From: Valentin Longchamp Date: Fri, 17 Feb 2017 11:31:22 +0100 > It is required to build it as a module. > > Signed-off-by: Valentin Longchamp Applied to net-next.

Re: [PATCHv2 1/1] rds:Remove unnecessary ib_ring unalloc

2017-02-17 Thread David Miller
From: Zhu Yanjun Date: Fri, 17 Feb 2017 04:16:22 -0500 > In the function rds_ib_xmit_atomic, ib_ring is not allocated > successfully. As such, it is not necessary to unalloc it. > > Cc: Joe Jin > Cc: Junxiao Bi > Signed-off-by: Zhu Yanjun > --- > Change from v1 to v2: > fix the word errors

Re: [PATCH net] sctp: check duplicate node before inserting a new transport

2017-02-17 Thread David Miller
From: Xin Long Date: Fri, 17 Feb 2017 16:35:24 +0800 > + list = rhltable_lookup(&sctp_transport_hashtable, &arg, > +sctp_hash_params); > + > + rhl_for_each_entry_rcu(transport, tmp, list, node) > + if (transport->asoc->ep == t->asoc->ep) { > +

Re: [PATCH net-next 1/1] pkt_sched: Remove useless qdisc_stab_lock

2017-02-17 Thread David Miller
From: f...@ikuai8.com Date: Fri, 17 Feb 2017 14:34:19 +0800 > From: Gao Feng > > The qdisc_stab_lock is used in qdisc_get_stab and qdisc_put_stab. > These two functions are invoked in qdisc_create, qdisc_change, and > qdisc_destroy which run fully under RTNL. > > So it already makes sure only o

Re: [PATCH] of_mdio: Add "broadcom,bcm5241" to the whitelist.

2017-02-17 Thread Florian Fainelli
On 02/17/2017 12:04 PM, David Daney wrote: > Some Cavium dev boards have firmware which doesn't supply a proper > ethernet-phy-ieee802.3-c22" compatible property. Restore these boards > to working order by whitelisting this compatible value. > > Signed-off-by: David Daney Acked-by: Florian Fain

Re: [PATCH net-next] rxrpc: Change module filename to rxrpc.ko

2017-02-17 Thread David Miller
From: David Howells Date: Fri, 17 Feb 2017 18:16:21 + > Change module filename from af-rxrpc.ko to rxrpc.ko so as to be consistent > with the other protocol drivers. > > Also adjust the documentation to reflect this. > > Further, there is no longer a standalone rxkad module, as it has been

Re: [PATCH net-next] netvsc: fix typo on statistics

2017-02-17 Thread David Miller
From: Stephen Hemminger Date: Fri, 17 Feb 2017 11:36:20 -0800 > From: Simon Xiao > > Return the correct tx_errors stats in netvsc. > > Reviewed-by: Haiyang Zhang > Signed-off-by: Simon Xiao > Signed-off-by: Stephen Hemminger Applied, thanks Stephen.

[PATCH] of_mdio: Add "broadcom,bcm5241" to the whitelist.

2017-02-17 Thread David Daney
Some Cavium dev boards have firmware which doesn't supply a proper ethernet-phy-ieee802.3-c22" compatible property. Restore these boards to working order by whitelisting this compatible value. Signed-off-by: David Daney --- drivers/of/of_mdio.c | 1 + 1 file changed, 1 insertion(+) diff --git

Re: [PATCH net-next] rtnl: don't account unused struct ifla_port_vsi in rtnl_port_size

2017-02-17 Thread David Miller
From: Daniel Borkmann Date: Fri, 17 Feb 2017 01:56:11 +0100 > When allocating rtnl dump messages, struct ifla_port_vsi is never dumped, > so we can save header plus payload in rtnl_port_size(). Infact, attribute > IFLA_PORT_VSI_TYPE and struct ifla_port_vsi are not used anywhere in > the kernel.

[PATCH net-next] netvsc: fix typo on statistics

2017-02-17 Thread Stephen Hemminger
From: Simon Xiao Return the correct tx_errors stats in netvsc. Reviewed-by: Haiyang Zhang Signed-off-by: Simon Xiao Signed-off-by: Stephen Hemminger --- drivers/net/hyperv/netvsc_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/hyperv/netvsc_drv.c b/drive

Re: net/packet: use-after-free in packet_rcv_fanout

2017-02-17 Thread Cong Wang
On Mon, Feb 13, 2017 at 7:17 AM, Dmitry Vyukov wrote: > > Another similar one: > The other possibility is: __fanout_link() is called twice on the same packet sock for some reason, but __fanout_unlink() only unlinks the first one, which led to this use-after-free. However, the po->running and po-

Re: [PATCH] net/utils: fix semicolon.cocci warnings

2017-02-17 Thread Keith Busch
On Fri, Feb 17, 2017 at 01:52:54PM -0500, David Miller wrote: > From: kbuild test robot > Date: Fri, 17 Feb 2017 05:34:03 +0800 > > > net/core/utils.c:388:2-3: Unneeded semicolon > > > > > > Remove unneeded semicolon. > > > > Generated by: scripts/coccinelle/misc/semicolon.cocci > > > > CC:

Re: [PATCH] net: hamachi: use new api ethtool_{get|set}_link_ksettings

2017-02-17 Thread David Miller
From: Philippe Reynes Date: Thu, 16 Feb 2017 22:46:14 +0100 > The ethtool api {get|set}_settings is deprecated. > We move this driver to new api {get|set}_link_ksettings. > > As I don't have the hardware, I'd be very pleased if > someone may test this patch. > > Signed-off-by: Philippe Reynes

Re: [PATCH] net: qlogic: netxen: use new api ethtool_{get|set}_link_ksettings

2017-02-17 Thread David Miller
From: Philippe Reynes Date: Thu, 16 Feb 2017 23:28:01 +0100 > The ethtool api {get|set}_settings is deprecated. > We move this driver to new api {get|set}_link_ksettings. > > As I don't have the hardware, I'd be very pleased if > someone may test this patch. > > Signed-off-by: Philippe Reynes

Re: [PATCH net-next] bridge: don't indicate expiry on NTF_EXT_LEARNED fdb entries

2017-02-17 Thread David Miller
From: Roopa Prabhu Date: Thu, 16 Feb 2017 13:38:04 -0800 > From: Roopa Prabhu > > added_by_external_learn fdb entries are added and expired by > external entities like switchdev driver or external controllers. > ageing is already disabled for such entries. Hence, don't > indicate expiry for suc

Re: [PATCH] net/utils: fix semicolon.cocci warnings

2017-02-17 Thread David Miller
From: kbuild test robot Date: Fri, 17 Feb 2017 05:34:03 +0800 > net/core/utils.c:388:2-3: Unneeded semicolon > > > Remove unneeded semicolon. > > Generated by: scripts/coccinelle/misc/semicolon.cocci > > CC: Sagi Grimberg > Signed-off-by: Fengguang Wu > --- > > utils.c |2 +- > 1 fil

Re: net: use-after-free in tw_timer_handler

2017-02-17 Thread Cong Wang
On Wed, Feb 8, 2017 at 9:36 AM, Dmitry Vyukov wrote: > On Tue, Jan 24, 2017 at 4:52 PM, Eric Dumazet wrote: >> On Tue, Jan 24, 2017 at 7:06 AM, Dmitry Vyukov wrote: This code was changed a long time ago : https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/

Re: [PATCH net-next v2 1/3] net: stmicro: prepare dwmac4 core for mtl

2017-02-17 Thread David Miller
From: Joao Pinto Date: Fri, 17 Feb 2017 18:09:06 + > > Hi David, > > Às 6:02 PM de 2/17/2017, David Miller escreveu: >> From: Joao Pinto >> Date: Thu, 16 Feb 2017 11:19:39 + >> >>> This patch adds the following features: >>> >>> a) RX and TX scheduling algorithm configuration (can be

Re: [PATCH net] vxlan: fix oops in dev_fill_metadata_dst

2017-02-17 Thread Jiri Benc
On Fri, 17 Feb 2017 19:14:27 +0100, Paolo Abeni wrote: > Since the commit 0c1d70af924b ("net: use dst_cache for vxlan device") > vxlan_fill_metadata_dst() calls vxlan_get_route() passing a NULL > dst_cache pointer, so the latter should explicitly check for > valid dst_cache ptr. Unfortunately the c

Re: [PATCH net-next 0/3] Misc BPF improvements

2017-02-17 Thread David Miller
From: Daniel Borkmann Date: Thu, 16 Feb 2017 22:24:47 +0100 > This last series for this window adds various misc > improvements to BPF, one is to mark registered map and > prog types as __ro_after_init, another one for removing > cBPF stubs in eBPF JITs and moving the stub to the core > and last

Re: [PATCH] dccp: fix freeing skb too early for IPV6_RECVPKTINFO

2017-02-17 Thread David Miller
From: Andrey Konovalov Date: Thu, 16 Feb 2017 17:22:46 +0100 > In the current DCCP implementation an skb for a DCCP_PKT_REQUEST packet > is forcibly freed via __kfree_skb in dccp_rcv_state_process if > dccp_v6_conn_request successfully returns. > > However, if IPV6_RECVPKTINFO is set on a socket

Re: [PATCH net-next] bridge: vlan_tunnel: explicitly reset metadata attrs to NULL on failure

2017-02-17 Thread David Miller
From: Roopa Prabhu Date: Thu, 16 Feb 2017 11:29:21 -0800 > From: Roopa Prabhu > > Fixes: efa5356b0d97 ("bridge: per vlan dst_metadata netlink support") > Signed-off-by: Roopa Prabhu Applied, thank you.

Re: [PATCH net-next (repost)] nfp: Use PCI_DEVICE_ID_NETRONOME_NFP* defines

2017-02-17 Thread Jakub Kicinski
On Fri, 17 Feb 2017 08:57:54 +0100, Simon Horman wrote: > Use PCI_DEVICE_ID_NETRONOME_NFP*, defined in linux/pci_ids.h, > rather than replicating the same values in the NFP driver. > > Signed-off-by: Simon Horman Perhaps unnecessary and obvious but this was: Acked-by: Jakub Kicinski Thanks Si

[PATCH net] vxlan: fix oops in dev_fill_metadata_dst

2017-02-17 Thread Paolo Abeni
Since the commit 0c1d70af924b ("net: use dst_cache for vxlan device") vxlan_fill_metadata_dst() calls vxlan_get_route() passing a NULL dst_cache pointer, so the latter should explicitly check for valid dst_cache ptr. Unfortunately the commit d71785ffc7e7 ("net: add dst_cache to ovs vxlan lwtunnel")

Re: [PATCH net-next 1/1] pkt_sched: Remove useless qdisc_stab_lock

2017-02-17 Thread Eric Dumazet
On Fri, 2017-02-17 at 10:02 -0800, Cong Wang wrote: > On Thu, Feb 16, 2017 at 10:34 PM, wrote: > > From: Gao Feng > > > > The qdisc_stab_lock is used in qdisc_get_stab and qdisc_put_stab. > > These two functions are invoked in qdisc_create, qdisc_change, and > > qdisc_destroy which run fully und

Re: [PATCH net-next 1/1] pkt_sched: Remove useless qdisc_stab_lock

2017-02-17 Thread Eric Dumazet
On Fri, 2017-02-17 at 14:34 +0800, f...@ikuai8.com wrote: > From: Gao Feng > > The qdisc_stab_lock is used in qdisc_get_stab and qdisc_put_stab. > These two functions are invoked in qdisc_create, qdisc_change, and > qdisc_destroy which run fully under RTNL. > > So it already makes sure only one

Re: RFC: unit tests for kernel GTP module

2017-02-17 Thread Harald Welte
Hi Andreas, On Fri, Feb 17, 2017 at 04:02:59PM +0100, Andreas Schultz wrote: > The test suite is proprietary, so we can only share the results but > not the test setup itself. it would be great to have some CI setup where both current stable as well as a development branch of the code is tested,

[PATCH net-next] rxrpc: Change module filename to rxrpc.ko

2017-02-17 Thread David Howells
Change module filename from af-rxrpc.ko to rxrpc.ko so as to be consistent with the other protocol drivers. Also adjust the documentation to reflect this. Further, there is no longer a standalone rxkad module, as it has been merged into the rxrpc core, so get rid of references to that. Reported-

Re: [PATCH net-next v2 1/3] net: stmicro: prepare dwmac4 core for mtl

2017-02-17 Thread Joao Pinto
Hi David, Às 6:02 PM de 2/17/2017, David Miller escreveu: > From: Joao Pinto > Date: Thu, 16 Feb 2017 11:19:39 + > >> This patch adds the following features: >> >> a) RX and TX scheduling algorithm configuration (can be configured in the >> Device Tree) >> b) TX VLAN tag priority configurat

Re: [PATCH] rtlwifi: rtl8723bs: Add firmware for new driver

2017-02-17 Thread Kyle McMartin
On Thu, Jan 19, 2017 at 03:04:27PM -0600, Larry Finger wrote: > This driver is being added for Fedora users, and will then be added > to the mainline kernel. > > Signed-off-by: Larry Finger > c: Hans de Goede Applied.

Re: pull-request: wireless-drivers-next 2017-02-17

2017-02-17 Thread David Miller
From: Kalle Valo Date: Thu, 16 Feb 2017 15:41:13 +0200 > few -next patches I'm still hoping to get to 4.11 to keep my backlog > short, nothing major here. Please let me know if there are any problems. Pulled, thanks Kalle.

Re: [PATCH] net: bgmac: store MAC address directly in netdev->dev_addr

2017-02-17 Thread David Miller
From: Tobias Klauser Date: Thu, 16 Feb 2017 15:11:19 +0100 > After commit 34a5102c3235 ("net: bgmac: allocate struct bgmac just once > & don't copy it") the mac_addr member of struct bgmac is no longer > necessary to pass the MAC address to bgmac_enet_probe(). Instead it can > directly be stored

Re: [PATCH net-next 1/1] pkt_sched: Remove useless qdisc_stab_lock

2017-02-17 Thread Cong Wang
On Thu, Feb 16, 2017 at 10:34 PM, wrote: > From: Gao Feng > > The qdisc_stab_lock is used in qdisc_get_stab and qdisc_put_stab. > These two functions are invoked in qdisc_create, qdisc_change, and > qdisc_destroy which run fully under RTNL. > > So it already makes sure only one could access the

Re: [PATCH net-next v2 1/3] net: stmicro: prepare dwmac4 core for mtl

2017-02-17 Thread David Miller
From: Joao Pinto Date: Thu, 16 Feb 2017 11:19:39 + > This patch adds the following features: > > a) RX and TX scheduling algorithm configuration (can be configured in the > Device Tree) > b) TX VLAN tag priority configuration (can be configured in the Device Tree) > c) RX VLAN tag priority r

Re: [PATCH] net: ethoc: Use eth_hw_addr_random()

2017-02-17 Thread David Miller
From: Tobias Klauser Date: Thu, 16 Feb 2017 13:54:32 +0100 > Use eth_hw_addr_random() to set a random dev_addr and update > addr_assign_type instead of open-coding it. > > Signed-off-by: Tobias Klauser Applied to net-next, thanks.

Re: [PATCHv2, 1/1] tcp: accommodate sequence number to a peer's shrunk receive window caused by precision loss in window scaling

2017-02-17 Thread Eric Dumazet
On Fri, 2017-02-17 at 17:04 +, Cui, Cheng wrote: > Prevent sending out a left-shifted sequence number from a Linux sender in > response to a peer's shrunk receive-window caused by losing least significant > bits in window-scaling. > > Cc: "David S. Miller" > Cc: Alexey Kuznetsov > Cc: James

  1   2   >