Re: [PATCH next 0/4] bonding: winter cleanup

2017-02-21 Thread Jiri Pirko
Wed, Feb 22, 2017 at 02:08:16AM CET, mah...@bandewar.net wrote: >From: Mahesh Bandewar > >Few cleanup patches that I have accumulated over some time now. > >(a) First two patches are basically to move the work-queue initialization >from every ndo_open / bond_open operation to once at the begin

[PATCH] net: realtek: 8139cp: use new api ethtool_{get|set}_link_ksettings

2017-02-21 Thread Philippe Reynes
The ethtool api {get|set}_settings is deprecated. We move this driver to new api {get|set}_link_ksettings. As I don't have the hardware, I'd be very pleased if someone may test this patch. Signed-off-by: Philippe Reynes --- drivers/net/ethernet/realtek/8139cp.c | 14 -- 1 files ch

Re: [PATCH v5 10/10] landlock: Add user and kernel documentation for Landlock

2017-02-21 Thread Mickaël Salaün
On 22/02/2017 06:21, Andy Lutomirski wrote: > On Tue, Feb 21, 2017 at 5:26 PM, Mickaël Salaün wrote: >> This documentation can be built with the Sphinx framework. >> >> Signed-off-by: Mickaël Salaün >> Cc: Alexei Starovoitov >> Cc: Andy Lutomirski >> Cc: Daniel Borkmann >> Cc: David S. Miller

Re: [PATCH rfc 1/4] net/utils: generic inet_pton_with_scope helper

2017-02-21 Thread Christoph Hellwig
On Tue, Feb 21, 2017 at 11:18:04PM +0200, Sagi Grimberg wrote: > I can maybe do something like: > > if (af == AF_INET || af == AF_UNSPEC) { > ret = inet4_pton(); > if (!ret) > return 0; > else if (af != AF_UNSPEC) > return ret; > } > > if (af == AF_IN

Re: [PATCH net-next] bpf: return errno -ENOMEM when exceeding RLIMIT_MEMLOCK

2017-02-21 Thread Alexei Starovoitov
On Tue, Feb 21, 2017 at 02:00:13PM +0100, Jesper Dangaard Brouer wrote: > On Tue, 21 Feb 2017 00:06:11 -0800 > Alexei Starovoitov wrote: > > > On Mon, Feb 20, 2017 at 05:25:58PM +0100, Jesper Dangaard Brouer wrote: > > > On Mon, 20 Feb 2017 16:57:34 +0100 > > > Daniel Borkmann wrote: > > > >

Re: [PATCH v2 net-next] liquidio: improve UDP TX performance

2017-02-21 Thread Felix Manlunas
Tom Herbert wrote on Tue [2017-Feb-21 15:27:54 -0800]: > On Tue, Feb 21, 2017 at 1:09 PM, Felix Manlunas > wrote: > > From: VSR Burru > > > > Improve UDP TX performance by: > > * reducing the ring size from 2K to 512 > > It looks like liquidio supports BQL. Is that not effective here? Response

Re: [PATCH] net/dccp: fix use after free in tw_timer_handler()

2017-02-21 Thread Dmitry Vyukov
On Tue, Feb 21, 2017 at 2:56 PM, Dmitry Vyukov wrote: > On Tue, Feb 21, 2017 at 2:27 PM, Andrey Ryabinin > wrote: >> DCCP doesn't purge timewait sockets on network namespace shutdown. >> So, after net namespace destroyed we could still have an active timer >> which will trigger use after free in

Re: linux-next: manual merge of the kspp tree with the net-next tree

2017-02-21 Thread Daniel Borkmann
On 02/22/2017 12:51 AM, Stephen Rothwell wrote: Hi Kees, Today's linux-next merge of the kspp tree got a conflict in: arch/arm/Kconfig between commit: d2852a224050 ("arch: add ARCH_HAS_SET_MEMORY config") from the net-next tree and commit: ad21fc4faa2a ("arch: Move CONFIG_DEBUG_ROD

Re: linux-next: manual merge of the kspp tree with the net-next tree

2017-02-21 Thread Daniel Borkmann
On 02/22/2017 01:06 AM, Stephen Rothwell wrote: Hi all, Today's linux-next merge of the kspp tree got a conflict in: include/linux/filter.h between commit: 9d876e79df6a ("bpf: fix unlocking of jited image when module ronx not set") from the net-next tree and commit: 0f5bf6d0afe4 ("

Re: linux-next: manual merge of the net-next tree with the s390 tree

2017-02-21 Thread Daniel Borkmann
On 02/22/2017 12:15 AM, Stephen Rothwell wrote: Hi all, Today's linux-next merge of the net-next tree got a conflict in: arch/s390/net/bpf_jit_comp.c between commit: 9437964885f8 ("s390/bpf: remove redundant check for non-null image") from the s390 tree and commit: 9d876e79df6a ("b

RE: create drivers/net/mdio and move mdio drivers into it

2017-02-21 Thread YUAN Linyu
Hi Florian, 1. Let's go back to original topic, Can we move all mdio dirvers into drivers/net/mdio ? Last time you said half convinced. If you insist not do it, l will follow your decision. 2. Per may understanding, I don't know why create a struct mii_bus instance to represent a mdio device in

Re: [PATCH v5 10/10] landlock: Add user and kernel documentation for Landlock

2017-02-21 Thread Andy Lutomirski
On Tue, Feb 21, 2017 at 5:26 PM, Mickaël Salaün wrote: > This documentation can be built with the Sphinx framework. > > Signed-off-by: Mickaël Salaün > Cc: Alexei Starovoitov > Cc: Andy Lutomirski > Cc: Daniel Borkmann > Cc: David S. Miller > Cc: James Morris > Cc: Jonathan Corbet > Cc: Kee

Re: Questions on XDP

2017-02-21 Thread John Fastabend
On 17-02-20 12:06 PM, Jakub Kicinski wrote: > On Sat, 18 Feb 2017 19:48:25 -0800, John Fastabend wrote: >> On 17-02-18 06:16 PM, Alexander Duyck wrote: >>> On Sat, Feb 18, 2017 at 3:48 PM, John Fastabend >>> wrote: On 17-02-18 03:31 PM, Alexei Starovoitov wrote: > On Sat, Feb 18, 2017

Re: [PATCH next 0/4] bonding: winter cleanup

2017-02-21 Thread Or Gerlitz
On Wed, Feb 22, 2017 at 5:29 AM, David Miller wrote: > From: Mahesh Bandewar > Date: Tue, 21 Feb 2017 17:08:16 -0800 > >> Few cleanup patches that I have accumulated over some time now. > > The net-next tree is closed, therefore it is not appropriate to > submit cleanups at this time. > > Please

Re: [PATCH RFC v3 0/8] xdp: Infrastructure to generalize XDP

2017-02-21 Thread David Miller
From: Tom Herbert Date: Tue, 21 Feb 2017 20:02:07 -0800 > I took out the parts about allowing non-BPF hooks in the patchset as > you requested.I believe code that is cleaner than what is currently > there, and the fact that the API is extensible to allow other uses > is a hallmark of good design.

Re: [PATCH RFC v3 0/8] xdp: Infrastructure to generalize XDP

2017-02-21 Thread Tom Herbert
On Tue, Feb 21, 2017 at 7:34 PM, David Miller wrote: > From: Tom Herbert > Date: Tue, 21 Feb 2017 18:54:53 -0800 > >> It is part of the direction to take XDP beyond the first use case of >> BPF and leverage the high performance processing model in a much >> broader context. > > And I've stated re

Re: [PATCH net-next] virtio-net: switch to use build_skb() for small buffer

2017-02-21 Thread Michael S. Tsirkin
On Wed, Feb 22, 2017 at 11:17:50AM +0800, Jason Wang wrote: > > > On 2017年02月22日 11:06, Michael S. Tsirkin wrote: > > On Wed, Feb 22, 2017 at 10:58:08AM +0800, Jason Wang wrote: > > > > > > On 2017年02月21日 22:37, Michael S. Tsirkin wrote: > > > > On Tue, Feb 21, 2017 at 04:46:28PM +0800, Jason Wa

Re: [PATCH net-next] virtio-net: switch to use build_skb() for small buffer

2017-02-21 Thread Jason Wang
On 2017年02月22日 11:17, Jason Wang wrote: On 2017年02月22日 11:06, Michael S. Tsirkin wrote: On Wed, Feb 22, 2017 at 10:58:08AM +0800, Jason Wang wrote: On 2017年02月21日 22:37, Michael S. Tsirkin wrote: On Tue, Feb 21, 2017 at 04:46:28PM +0800, Jason Wang wrote: This patch switch to use build_s

Re: [PATCH RFC v3 0/8] xdp: Infrastructure to generalize XDP

2017-02-21 Thread David Miller
From: Tom Herbert Date: Tue, 21 Feb 2017 18:54:53 -0800 > It is part of the direction to take XDP beyond the first use case of > BPF and leverage the high performance processing model in a much > broader context. And I've stated repeatedly that it's too early to be looking that far into the futu

Re: [PATCH next 0/4] bonding: winter cleanup

2017-02-21 Thread David Miller
From: Mahesh Bandewar Date: Tue, 21 Feb 2017 17:08:16 -0800 > Few cleanup patches that I have accumulated over some time now. The net-next tree is closed, therefore it is not appropriate to submit cleanups at this time. Please wait until after the merge window and the net-next tree opens back u

RE: [PATCH] net: intel: e1000e: use new api ethtool_{get|set}_link_ksettings

2017-02-21 Thread Brown, Aaron F
> From: netdev-ow...@vger.kernel.org [mailto:netdev- > ow...@vger.kernel.org] On Behalf Of Philippe Reynes > Sent: Thursday, January 26, 2017 1:20 PM > To: Kirsher, Jeffrey T ; da...@davemloft.net > Cc: intel-wired-...@lists.osuosl.org; netdev@vger.kernel.org; linux- > ker...@vger.kernel.org; Phili

Re: [PATCH net-next] virtio-net: switch to use build_skb() for small buffer

2017-02-21 Thread Jason Wang
On 2017年02月22日 11:06, Michael S. Tsirkin wrote: On Wed, Feb 22, 2017 at 10:58:08AM +0800, Jason Wang wrote: On 2017年02月21日 22:37, Michael S. Tsirkin wrote: On Tue, Feb 21, 2017 at 04:46:28PM +0800, Jason Wang wrote: This patch switch to use build_skb() for small buffer which can have better

Re: [PATCH net-next] virtio-net: switch to use build_skb() for small buffer

2017-02-21 Thread Michael S. Tsirkin
On Wed, Feb 22, 2017 at 10:58:08AM +0800, Jason Wang wrote: > > > On 2017年02月21日 22:37, Michael S. Tsirkin wrote: > > On Tue, Feb 21, 2017 at 04:46:28PM +0800, Jason Wang wrote: > > > This patch switch to use build_skb() for small buffer which can have > > > better performance for both TCP and XD

Re: [PATCH net-next] virtio-net: switch to use build_skb() for small buffer

2017-02-21 Thread Jason Wang
On 2017年02月21日 22:37, Michael S. Tsirkin wrote: On Tue, Feb 21, 2017 at 04:46:28PM +0800, Jason Wang wrote: This patch switch to use build_skb() for small buffer which can have better performance for both TCP and XDP (since we can work at page before skb creation). It also remove lots of XDP c

Re: [PATCH RFC v3 0/8] xdp: Infrastructure to generalize XDP

2017-02-21 Thread Tom Herbert
On Tue, Feb 21, 2017 at 6:23 PM, Jakub Kicinski wrote: > On Tue, 21 Feb 2017 18:04:49 -0800, Tom Herbert wrote: >> On Tue, Feb 21, 2017 at 5:29 PM, Jakub Kicinski wrote: >> > On Tue, 21 Feb 2017 16:25:15 -0800, Tom Herbert wrote: >> >> >> - Provides a more structured environment that is extensi

[PATCH 2/2] uapi: add a compatibility layer between linux/uio.h and glibc

2017-02-21 Thread Dmitry V. Levin
Do not define struct iovec in linux/uio.h when or is already included and provides these definitions. This fixes the following compilation error when or is included before : /usr/include/linux/uio.h:16:8: error: redefinition of 'struct iovec' Signed-off-by: Dmitry V. Levin --- include/uapi

[PATCH 1/2] uapi: add a compatibility layer between linux/time.h and glibc

2017-02-21 Thread Dmitry V. Levin
Do not define struct itimerspec, struct timespec, struct timeval, and TIMER_ABSTIME in linux/time.h when is already included and provides these definitions. This fixes the following compilation errors and warnings when is included before : /usr/include/linux/time.h:9:8: error: redefinition of '

Re: [PATCH RFC v3 0/8] xdp: Infrastructure to generalize XDP

2017-02-21 Thread Jakub Kicinski
On Tue, 21 Feb 2017 18:04:49 -0800, Tom Herbert wrote: > On Tue, Feb 21, 2017 at 5:29 PM, Jakub Kicinski wrote: > > On Tue, 21 Feb 2017 16:25:15 -0800, Tom Herbert wrote: > >> >> - Provides a more structured environment that is extensible to new > >> >> features while being mostly transpar

Re: [PATCH] uapi: fix linux/if.h userspace compilation errors

2017-02-21 Thread Dmitry V. Levin
On Tue, Feb 21, 2017 at 11:19:14PM +0300, Dmitry V. Levin wrote: > On Tue, Feb 21, 2017 at 12:10:22PM -0500, David Miller wrote: > > From: "Dmitry V. Levin" > > Date: Mon, 20 Feb 2017 14:58:41 +0300 > > > > > Include (guarded by ifndef __KERNEL__) to fix > > > the following linux/if.h userspace

Re: [PATCH RFC v3 0/8] xdp: Infrastructure to generalize XDP

2017-02-21 Thread Tom Herbert
On Tue, Feb 21, 2017 at 5:29 PM, Jakub Kicinski wrote: > On Tue, 21 Feb 2017 16:25:15 -0800, Tom Herbert wrote: >> >> - Provides a more structured environment that is extensible to new >> >> features while being mostly transparent to the drivers >> > >> > So far all features we added require

[PATCH net-next] l2tp: Avoid schedule while atomic in exit_net

2017-02-21 Thread Ridge Kennedy
While destroying a network namespace that contains a L2TP tunnel a "BUG: scheduling while atomic" can be observed. Enabling lockdep shows that this is happening because l2tp_exit_net() is calling l2tp_tunnel_closeall() (via l2tp_tunnel_delete()) from within an RCU critical section. l2tp_exit_net(

[PATCH v5 00/10] Landlock LSM: Toward unprivileged sandboxing

2017-02-21 Thread Mickaël Salaün
Hi, This series follows 4 previous RFCs [1]. This is the first step of the roadmap discussed at LPC [2] (with the inheritance feature included). The big change is an abstraction over LSM hooks. Instead of exposing a similar interface to userland, Landlock wraps LSM hooks into Landlock events.

[PATCH v5 02/10] bpf,landlock: Define an eBPF program type for Landlock

2017-02-21 Thread Mickaël Salaün
Add a new type of eBPF program used by Landlock rules. This new BPF program type will be registered with the Landlock LSM initialization. Add an initial Landlock Kconfig. Changes since v4: * merge a minimal (not enabled) LSM code and Kconfig in this commit Changes since v3: * split commit * rev

[PATCH v5 08/10] seccomp: Enhance test_harness with an assert step mechanism

2017-02-21 Thread Mickaël Salaün
This is useful to return an information about the error without being able to write to TH_LOG_STREAM. Helpers from test_harness.h may be useful outside of the seccomp directory. Signed-off-by: Mickaël Salaün Cc: Andy Lutomirski Cc: Arnaldo Carvalho de Melo Cc: Kees Cook Cc: Shuah Khan Cc: Wi

[PATCH v5 01/10] bpf: Add eBPF program subtype and is_valid_subtype() verifier

2017-02-21 Thread Mickaël Salaün
The goal of the program subtype is to be able to have different static fine-grained verifications for a unique program type. The struct bpf_verifier_ops gets a new optional function: is_valid_subtype(). This new verifier is called at the beginning of the eBPF program verification to check if the (

[PATCH v5 07/10] bpf: Add a Landlock sandbox example

2017-02-21 Thread Mickaël Salaün
Add a basic sandbox tool to create a process isolated from some part of the system. This sandbox create a read-only environment. It is only allowed to write to a character device such as a TTY: # :> X # echo $? 0 # ./samples/bpf/landlock1 /bin/sh -i Launching a new sandboxed process. #

Re: [PATCH RFC v3 0/8] xdp: Infrastructure to generalize XDP

2017-02-21 Thread Jakub Kicinski
On Tue, 21 Feb 2017 16:25:15 -0800, Tom Herbert wrote: > >> - Provides a more structured environment that is extensible to new > >> features while being mostly transparent to the drivers > > > > So far all features we added required explicit driver support. > > Checksumming support as an ex

[PATCH v5 09/10] bpf,landlock: Add tests for Landlock

2017-02-21 Thread Mickaël Salaün
Test basic context access and filesystem event with multiple cases. Signed-off-by: Mickaël Salaün Cc: Alexei Starovoitov Cc: Andy Lutomirski Cc: Daniel Borkmann Cc: David S. Miller Cc: James Morris Cc: Kees Cook Cc: Serge E. Hallyn Cc: Shuah Khan Cc: Will Drewry --- tools/testing/selfte

[PATCH v5 04/10] landlock: Add LSM hooks related to filesystem

2017-02-21 Thread Mickaël Salaün
Handle 33 filesystem-related LSM hooks for the Landlock filesystem event: LANDLOCK_SUBTYPE_EVENT_FS. A Landlock event wrap LSM hooks for similar kernel object types (e.g. struct file, struct path...). Multiple LSM hooks can trigger the same Landlock event. Landlock handle nine coarse-grained acti

[PATCH v5 03/10] bpf: Define handle_fs and add a new helper bpf_handle_fs_get_mode()

2017-02-21 Thread Mickaël Salaün
Add an eBPF function bpf_handle_fs_get_mode(handle_fs) to get the mode of a an abstract object wrapping either a file, a dentry, a path, or an inode. Changes since v4: * use a file abstraction (handle) to wrap inode, dentry, path and file structs * remove bpf_landlock_cmp_fs_beneath() * rename t

[PATCH v5 05/10] seccomp: Split put_seccomp_filter() with put_seccomp()

2017-02-21 Thread Mickaël Salaün
The semantic is unchanged. This will be useful for the Landlock integration with seccomp (next commit). Signed-off-by: Mickaël Salaün Cc: Kees Cook Cc: Andy Lutomirski Cc: Will Drewry --- include/linux/seccomp.h | 4 ++-- kernel/fork.c | 2 +- kernel/seccomp.c| 18

[PATCH v5 10/10] landlock: Add user and kernel documentation for Landlock

2017-02-21 Thread Mickaël Salaün
This documentation can be built with the Sphinx framework. Signed-off-by: Mickaël Salaün Cc: Alexei Starovoitov Cc: Andy Lutomirski Cc: Daniel Borkmann Cc: David S. Miller Cc: James Morris Cc: Jonathan Corbet Cc: Kees Cook Cc: Serge E. Hallyn --- Documentation/security/index.rst

[PATCH v5 06/10] seccomp,landlock: Handle Landlock events per process hierarchy

2017-02-21 Thread Mickaël Salaün
The seccomp(2) syscall can be use to apply a Landlock rule to the current process. As with a seccomp filter, the Landlock rule is enforced for all its future children. An inherited rule tree can be updated (append-only) by the owner of inherited Landlock nodes (e.g. a parent process that create a n

[PATCH next 3/4] bonding: remove hardcoded value

2017-02-21 Thread Mahesh Bandewar
From: Mahesh Bandewar Eliminate hard-coded value and use the default that is set. Signed-off-by: Mahesh Bandewar --- drivers/net/bonding/bond_main.c | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_mai

[PATCH next 1/4] bonding: restructure arp-monitor

2017-02-21 Thread Mahesh Bandewar
From: Mahesh Bandewar In preparation to move the work-queue initialization to port creation from current port_open phase. Work-queue initialization does not make sense every time we do 'ifup/ifdown'. So moving to port creation phase. Arp monitoring work depends on the bonding mode and that is no

[PATCH next 4/4] bonding: remove "port-moved" state that was never implemented

2017-02-21 Thread Mahesh Bandewar
From: Mahesh Bandewar LACP state-machine defines "port-moved" state when the same ActorSystemID and Port are seen in a LACPDU received on different port. The state is never set since it's not implemented. However the state-machine attempts to clear that state occasionally. LACP state machine is a

[PATCH next 2/4] bonding: initialize work-queues during creation of bond

2017-02-21 Thread Mahesh Bandewar
From: Mahesh Bandewar Initializing work-queues every time ifup operation performed is unnecessary and can be performed only once when the port is created. Signed-off-by: Mahesh Bandewar --- drivers/net/bonding/bond_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/

[PATCH next 0/4] bonding: winter cleanup

2017-02-21 Thread Mahesh Bandewar
From: Mahesh Bandewar Few cleanup patches that I have accumulated over some time now. (a) First two patches are basically to move the work-queue initialization from every ndo_open / bond_open operation to once at the beginning while port creation. Work-queue initialization is an unnecess

Re: [PATCH RFC v3 0/8] xdp: Infrastructure to generalize XDP

2017-02-21 Thread Tom Herbert
On Tue, Feb 21, 2017 at 3:09 PM, Jakub Kicinski wrote: > Hi, > > I still have a few worries about this patch set... > > On Tue, 21 Feb 2017 11:34:09 -0800, Tom Herbert wrote: >> This patch set generalizes XDP by making the hooks in drivers to be >> generic. This has a number of advantages: >> >>

linux-next: manual merge of the kspp tree with the net-next tree

2017-02-21 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the kspp tree got a conflict in: include/linux/filter.h between commit: 9d876e79df6a ("bpf: fix unlocking of jited image when module ronx not set") from the net-next tree and commit: 0f5bf6d0afe4 ("arch: Rename CONFIG_DEBUG_RODATA and CONFIG_DEBUG_MOD

linux-next: manual merge of the kspp tree with the net-next tree

2017-02-21 Thread Stephen Rothwell
Hi Kees, Today's linux-next merge of the kspp tree got a conflict in: arch/arm/Kconfig between commit: d2852a224050 ("arch: add ARCH_HAS_SET_MEMORY config") from the net-next tree and commit: ad21fc4faa2a ("arch: Move CONFIG_DEBUG_RODATA and CONFIG_SET_MODULE_RONX to be common") from

Re: [PATCH net-next 2/2] netfilter: nf_ct_expect: Change __nf_ct_expect_check() return value.

2017-02-21 Thread Joe Stringer
On 21 February 2017 at 15:25, Jarno Rajahalme wrote: > Commit 4dee62b1 ("netfilter: nf_ct_expect: nf_ct_expect_insert() > returns void") inadvertently changed the successful return value of > nf_ct_expect_related_report() from 0 to 1 due to > __nf_ct_expect_check() returning 1 on success. Prevent

Re: [PATCH net-next 1/2] netfilter: nf_ct_expect: nf_ct_expect_related_report(): Return zero on success,

2017-02-21 Thread Joe Stringer
On 21 February 2017 at 15:25, Jarno Rajahalme wrote: > Commit 4dee62b1 ("netfilter: nf_ct_expect: nf_ct_expect_insert() > returns void") inadvertently changed the successful return value of > nf_ct_expect_related_report() from 0 to 1, which caused openvswitch > conntrack integration fail in FTP te

Re: [PATCH v2 net-next] liquidio: improve UDP TX performance

2017-02-21 Thread Tom Herbert
On Tue, Feb 21, 2017 at 1:09 PM, Felix Manlunas wrote: > From: VSR Burru > > Improve UDP TX performance by: > * reducing the ring size from 2K to 512 It looks like liquidio supports BQL. Is that not effective here? Thanks, Tom > * replacing the numerous streaming DMA allocations for info buffe

[PATCH net-next 2/2] netfilter: nf_ct_expect: Change __nf_ct_expect_check() return value.

2017-02-21 Thread Jarno Rajahalme
Commit 4dee62b1 ("netfilter: nf_ct_expect: nf_ct_expect_insert() returns void") inadvertently changed the successful return value of nf_ct_expect_related_report() from 0 to 1 due to __nf_ct_expect_check() returning 1 on success. Prevent this regression in the future by changing the return value of

[PATCH net-next 1/2] netfilter: nf_ct_expect: nf_ct_expect_related_report(): Return zero on success,

2017-02-21 Thread Jarno Rajahalme
Commit 4dee62b1 ("netfilter: nf_ct_expect: nf_ct_expect_insert() returns void") inadvertently changed the successful return value of nf_ct_expect_related_report() from 0 to 1, which caused openvswitch conntrack integration fail in FTP test cases. Fix this by always returning zero on the success co

linux-next: manual merge of the net-next tree with the s390 tree

2017-02-21 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the net-next tree got a conflict in: arch/s390/net/bpf_jit_comp.c between commit: 9437964885f8 ("s390/bpf: remove redundant check for non-null image") from the s390 tree and commit: 9d876e79df6a ("bpf: fix unlocking of jited image when module ronx not

Re: [PATCH RFC v3 3/8] nfp: Changes to use generic XDP infrastructure

2017-02-21 Thread Jakub Kicinski
On Tue, 21 Feb 2017 11:34:12 -0800, Tom Herbert wrote: > Change XDP program management functional interface to correspond to new > XDP API. > > Signed-off-by: Tom Herbert > --- > drivers/net/ethernet/netronome/nfp/nfp_net.h | 5 +- > .../net/ethernet/netronome/nfp/nfp_net_common.c| 1

Re: [PATCH RFC v3 0/8] xdp: Infrastructure to generalize XDP

2017-02-21 Thread Jakub Kicinski
Hi, I still have a few worries about this patch set... On Tue, 21 Feb 2017 11:34:09 -0800, Tom Herbert wrote: > This patch set generalizes XDP by making the hooks in drivers to be > generic. This has a number of advantages: > > - Allows a means to pipeline XDP programs together Does it add a

Re: Focusing the XDP project

2017-02-21 Thread Saeed Mahameed
On Tue, Feb 21, 2017 at 1:40 AM, Alexander Duyck wrote: > On Mon, Feb 20, 2017 at 2:57 PM, Saeed Mahameed wrote: >> >> >> On 02/20/2017 10:09 PM, Alexander Duyck wrote: >>> On Mon, Feb 20, 2017 at 2:13 AM, Jesper Dangaard Brouer >>> wrote: First thing to bring in order for the XDP proj

Re: Focusing the XDP project

2017-02-21 Thread Tom Herbert
On Tue, Feb 21, 2017 at 2:40 PM, Saeed Mahameed wrote: > On Tue, Feb 21, 2017 at 7:40 PM, Tom Herbert wrote: >> On Tue, Feb 21, 2017 at 8:46 AM, David Miller wrote: >>> From: Tom Herbert >>> Date: Tue, 21 Feb 2017 08:35:41 -0800 >>> We already have good APIs for similar datapath functional

Re: Focusing the XDP project

2017-02-21 Thread Tom Herbert
On Tue, Feb 21, 2017 at 2:29 PM, Saeed Mahameed wrote: > On Tue, Feb 21, 2017 at 6:35 PM, Tom Herbert wrote: >> On Mon, Feb 20, 2017 at 2:57 PM, Saeed Mahameed wrote: >>> >>> Well, although I think Jesper is a little bit exaggerating ;) I guess he >>> has a point >>> and i am on his side on thi

Re: Focusing the XDP project

2017-02-21 Thread Saeed Mahameed
On Tue, Feb 21, 2017 at 7:40 PM, Tom Herbert wrote: > On Tue, Feb 21, 2017 at 8:46 AM, David Miller wrote: >> From: Tom Herbert >> Date: Tue, 21 Feb 2017 08:35:41 -0800 >> >>> We already have good APIs for similar datapath functionality (GRO, >>> GSO, xmit_more, etc.), and I don't see why XDP is

Re: Focusing the XDP project

2017-02-21 Thread Saeed Mahameed
On Tue, Feb 21, 2017 at 6:35 PM, Tom Herbert wrote: > On Mon, Feb 20, 2017 at 2:57 PM, Saeed Mahameed wrote: >> >> Well, although I think Jesper is a little bit exaggerating ;) I guess he has >> a point >> and i am on his side on this discussion. you see, if we define the APIs and >> ABIs now >

Re: [PATCH 05/21] net-next: stmmac: Add dwmac-sun8i

2017-02-21 Thread Maxime Ripard
On Fri, Feb 17, 2017 at 02:18:02PM +0100, Corentin Labbe wrote: > On Thu, Feb 16, 2017 at 08:05:24PM +0100, Maxime Ripard wrote: > > Hi, > > > > [...] > > > + > > > +struct emac_variant { > > > + u32 default_syscon_value; > > > > Why do you need a default value? Can't you read it from the syscon

Re: [PATCH RFC v3 8/8] xdp: Cleanup after API changes

2017-02-21 Thread David Miller
From: Tom Herbert Date: Tue, 21 Feb 2017 13:24:43 -0800 > On Tue, Feb 21, 2017 at 1:06 PM, David Miller wrote: >> From: Tom Herbert >> Date: Tue, 21 Feb 2017 11:34:17 -0800 >> >>> - Change trace_xdp_hook_exception to trace_xdp_exception >> >> Just give it this final name in patch #1 where you

Re: [PATCH v2 net-next] liquidio: improve UDP TX performance

2017-02-21 Thread Rick Jones
On 02/21/2017 01:09 PM, Felix Manlunas wrote: From: VSR Burru Improve UDP TX performance by: * reducing the ring size from 2K to 512 * replacing the numerous streaming DMA allocations for info buffers and gather lists with one large consistent DMA allocation per ring Netperf benchmark number

Re: [PATCH RFC v3 8/8] xdp: Cleanup after API changes

2017-02-21 Thread Tom Herbert
On Tue, Feb 21, 2017 at 1:06 PM, David Miller wrote: > From: Tom Herbert > Date: Tue, 21 Feb 2017 11:34:17 -0800 > >> - Change trace_xdp_hook_exception to trace_xdp_exception > > Just give it this final name in patch #1 where you introduce it. That will break compilation of the intervening pat

Re: [patch net-next RFC 1/2] flow_dissecror: Move ARP dissection into a separate function

2017-02-21 Thread Jiri Pirko
Tue, Feb 21, 2017 at 07:50:53PM CET, t...@herbertland.com wrote: >On Tue, Feb 21, 2017 at 6:33 AM, Jiri Pirko wrote: >> From: Jiri Pirko >> >> Make the main flow_dissect function a bit smaller and move the ARP >> dissection into a separate function. Along with that, do the ARP header >> processin

Re: [PATCH rfc 1/4] net/utils: generic inet_pton_with_scope helper

2017-02-21 Thread Sagi Grimberg
On 19/02/17 19:15, Christoph Hellwig wrote: On Thu, Feb 16, 2017 at 07:43:34PM +0200, Sagi Grimberg wrote: Several locations in the stack need to handle ipv4/ipv6 (with scope) and port strings conversion to sockaddr. Add a helper that takes either AF_INET, AF_INET6 or AF_UNSPEC (for wildcard)

[PATCH v2 net-next] liquidio: improve UDP TX performance

2017-02-21 Thread Felix Manlunas
From: VSR Burru Improve UDP TX performance by: * reducing the ring size from 2K to 512 * replacing the numerous streaming DMA allocations for info buffers and gather lists with one large consistent DMA allocation per ring Netperf benchmark numbers before and after patch: PF UDP TX ++-

Re: [PATCH RFC v3 8/8] xdp: Cleanup after API changes

2017-02-21 Thread David Miller
From: Tom Herbert Date: Tue, 21 Feb 2017 11:34:17 -0800 > - Change trace_xdp_hook_exception to trace_xdp_exception Just give it this final name in patch #1 where you introduce it.

Re: [PATCH] Revert "ath10k: Search SMBIOS for OEM board file extension"

2017-02-21 Thread David Miller
From: Kalle Valo Date: Tue, 21 Feb 2017 21:47:06 +0200 > This reverts commit f2593cb1b29185d38db706cbcbe22ed538720ae1. > > Paul reported that this patch with older board-2.bin ath10k initialisation > fails on Dell XPS 13: > > ath10k_pci :3a:00.0: failed to fetch board data for bus=pci,vendo

Re: Fw: [Bug 193911] New: net_prio.ifpriomap is not aware of the network namespace, and discloses all network interface

2017-02-21 Thread Tejun Heo
Hello, On Mon, Feb 13, 2017 at 08:04:57AM +1300, Eric W. Biederman wrote: > > Yeah, the whole thing never considered netns or delegation. Maybe the > > read function itself should probably filter on the namespace of the > > reader? I'm not completely sure whether trying to fix it won't cause > >

Re: [PATCH] uapi: fix linux/if.h userspace compilation errors

2017-02-21 Thread Dmitry V. Levin
On Tue, Feb 21, 2017 at 12:10:22PM -0500, David Miller wrote: > From: "Dmitry V. Levin" > Date: Mon, 20 Feb 2017 14:58:41 +0300 > > > Include (guarded by ifndef __KERNEL__) to fix > > the following linux/if.h userspace compilation errors: > > Wouldn't it be so much better to do this in include/

Re: [PATCHv4 net-next 00/13] net: mvpp2: misc improvements and preparation patches

2017-02-21 Thread Thomas Petazzoni
Hello, On Tue, 21 Feb 2017 13:17:57 -0500 (EST), David Miller wrote: > From: Thomas Petazzoni > Date: Tue, 21 Feb 2017 11:28:00 +0100 > > > This series contains a number of fixes, misc improvements and > > preparation patches for an upcoming series that adds support for the > > new PPv2.2 networ

Re: [PATCHv2 net-next 0/4] update ipvs sysctl document

2017-02-21 Thread Julian Anastasov
Hello, On Mon, 20 Feb 2017, Hangbin Liu wrote: > Fix and add some new ipvs sysctl options. Also use tab instead of > whitespaces to indent the descriptions. > > V2: Fix some descriptions based on Julian's advice. > > Hangbin Liu (4): > ipvs: fix sync_threshold description and add syn

[PATCH] Revert "ath10k: Search SMBIOS for OEM board file extension"

2017-02-21 Thread Kalle Valo
This reverts commit f2593cb1b29185d38db706cbcbe22ed538720ae1. Paul reported that this patch with older board-2.bin ath10k initialisation fails on Dell XPS 13: ath10k_pci :3a:00.0: failed to fetch board data for bus=pci,vendor=168c, device=003e,subsystem-vendor=1a56,subsystem-device=1535,varia

[PATCH RFC v3 7/8] bnxt: Changes to use generic XDP infrastructure

2017-02-21 Thread Tom Herbert
Change XDP program management functional interface to correspond to new XDP API. Signed-off-by: Tom Herbert --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 14 drivers/net/ethernet/broadcom/bnxt/bnxt.h | 2 +- drivers/net/ethernet/broadcom/bnxt/bnxt_xdp.c | 46 +++--

[PATCH RFC v3 6/8] mlx5: Changes to use generic XDP infrastructure

2017-02-21 Thread Tom Herbert
Change XDP program management functional interface to correspond to new XDP API. Signed-off-by: Tom Herbert --- drivers/net/ethernet/mellanox/mlx5/core/en.h | 3 +- drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 108 ++ drivers/net/ethernet/mellanox/mlx5/core/en_r

[PATCH RFC v3 3/8] nfp: Changes to use generic XDP infrastructure

2017-02-21 Thread Tom Herbert
Change XDP program management functional interface to correspond to new XDP API. Signed-off-by: Tom Herbert --- drivers/net/ethernet/netronome/nfp/nfp_net.h | 5 +- .../net/ethernet/netronome/nfp/nfp_net_common.c| 172 ++--- .../net/ethernet/netronome/nfp/nfp_net_etht

[PATCH RFC v3 5/8] virt_net: Changes to use generic XDP infrastructure

2017-02-21 Thread Tom Herbert
Change XDP program management functional interface to correspond to new XDP API. Signed-off-by: Tom Herbert --- drivers/net/virtio_net.c | 99 +++- 1 file changed, 39 insertions(+), 60 deletions(-) diff --git a/drivers/net/virtio_net.c b/drivers/net/v

[PATCH RFC v3 8/8] xdp: Cleanup after API changes

2017-02-21 Thread Tom Herbert
This patch: - Change trace_xdp_hook_exception to trace_xdp_exception - Remove XDP_SETUP_PROG and XDP_QUERY_PROG constants - Remove bpf_warn_invalid_xdp_action Signed-off-by: Tom Herbert --- drivers/net/ethernet/broadcom/bnxt/bnxt_xdp.c | 4 +-- drivers/net/ethernet/mellanox/mlx4/en_r

[PATCH RFC v3 2/8] mlx4: Changes to use generic XDP infrastructure

2017-02-21 Thread Tom Herbert
Change XDP program management functional interface to correspond to new XDP API. Signed-off-by: Tom Herbert --- drivers/net/ethernet/mellanox/mlx4/en_netdev.c | 92 +- drivers/net/ethernet/mellanox/mlx4/en_rx.c | 27 drivers/net/ethernet/mellanox/mlx4/en_tx.c

[PATCH RFC v3 1/8] xdp: Infrastructure to generalize XDP

2017-02-21 Thread Tom Herbert
This patch creates an infrastructure for registering and running code at XDP hooks in drivers. This extends and generalizes the original XDP/BPF interface. It abstract out management and running of BPF programs out of drivers. An XDP hook is defined by the xdp_hook structure. A pointer to this str

[PATCH RFC v3 4/8] qede: Changes to use generic XDP infrastructure

2017-02-21 Thread Tom Herbert
Change XDP program management functional interface to correspond to new XDP API. Signed-off-by: Tom Herbert --- drivers/net/ethernet/qlogic/qede/qede.h | 3 +- drivers/net/ethernet/qlogic/qede/qede_ethtool.c | 2 +- drivers/net/ethernet/qlogic/qede/qede_filter.c | 39 ++---

[PATCH RFC v3 0/8] xdp: Infrastructure to generalize XDP

2017-02-21 Thread Tom Herbert
This patch set generalizes XDP by making the hooks in drivers to be generic. This has a number of advantages: - Allows a means to pipeline XDP programs together - Reduces the amount of code and complexity needed in drivers to manage XDP - Provides a more structured environment that is ex

Re: [patch net-next RFC 1/2] flow_dissecror: Move ARP dissection into a separate function

2017-02-21 Thread Tom Herbert
On Tue, Feb 21, 2017 at 6:33 AM, Jiri Pirko wrote: > From: Jiri Pirko > > Make the main flow_dissect function a bit smaller and move the ARP > dissection into a separate function. Along with that, do the ARP header > processing only in case the flow dissection user requires it. > Acked-by: Tom H

[PATCH] qlogic: netxen: constify bin_attribute structures

2017-02-21 Thread Bhumika Goyal
Declare bin_attribute structures as const as they are only passed as an arguments to the functions device_remove_bin_file and device_create_bin_file. These function arguments are of type const, so bin_attribute structures having this property can be made const too. Done using Coccinelle: @r1 disab

Re: [PATCH net-next] tcp: Revert "tcp: tcp_probe: use spin_lock_bh()"

2017-02-21 Thread Eric Dumazet
On Tue, Feb 21, 2017 at 10:26 AM, David Miller wrote: > From: Eric Dumazet > Date: Tue, 21 Feb 2017 06:21:47 -0800 > >> This reverts commit e70ac171658679ecf6bea4bbd9e9325cd6079d2b. >> >> jtcp_rcv_established() is in fact called with hard irq being disabled. >> >> Initial bug report from Ricardo

[PATCH] qlogic: qlcnic_sysfs: constify bin_attribute structures

2017-02-21 Thread Bhumika Goyal
Declare bin_attribute structures as const as they are only passed as an arguments to the functions device_remove_bin_file and device_create_bin_file. These function arguments are of type const, so bin_attribute structures having this property can be made const too. Done using Coccinelle: @r1 disab

Re: [PATCH] net: socket: fix recvmmsg not returning error from sock_error

2017-02-21 Thread David Miller
From: Maxime Jayat Date: Tue, 21 Feb 2017 18:35:51 +0100 > Commit 34b88a68f26a ("net: Fix use after free in the recvmmsg exit path"), > changed the exit path of recvmmsg to always return the datagrams > variable and modified the error paths to set the variable to the error > code returned by recv

Re: [PATCH] bnxt_en: use eth_hw_addr_random()

2017-02-21 Thread David Miller
From: Tobias Klauser Date: Tue, 21 Feb 2017 15:27:28 +0100 > Use eth_hw_addr_random() to set a random MAC address in order to make > sure bp->dev->addr_assign_type will be properly set to NET_ADDR_RANDOM. > > Signed-off-by: Tobias Klauser Applied.

Re: [PATCH net-next 0/2] BPF fix with regards to unlocking

2017-02-21 Thread David Miller
From: Daniel Borkmann Date: Tue, 21 Feb 2017 16:09:32 +0100 > This set fixes the issue Eric was reporting recently [1]. > First patch is a prerequisite discussed with Laura that is > needed for the later fix in the second one. I've tested this > extensively and it does not reproduce anymore on my

Re: [patch net-next RFC 1/2] flow_dissecror: Move ARP dissection into a separate function

2017-02-21 Thread David Miller
From: Jiri Pirko Date: Tue, 21 Feb 2017 15:33:18 +0100 > From: Jiri Pirko > > Make the main flow_dissect function a bit smaller and move the ARP > dissection into a separate function. Along with that, do the ARP header > processing only in case the flow dissection user requires it. > > Signed-

Re: [PATCH net-next] net: napi_watchdog() can use napi_schedule_irqoff()

2017-02-21 Thread David Miller
From: Eric Dumazet Date: Tue, 21 Feb 2017 08:20:56 -0800 > From: Eric Dumazet > > hrtimer handlers run with masked hard IRQ, we can therefore > use napi_schedule_irqoff() > > Signed-off-by: Eric Dumazet Applied, thanks Eric.

Re: [PATCH] net/dccp: fix use after free in tw_timer_handler()

2017-02-21 Thread David Miller
From: Eric Dumazet Date: Tue, 21 Feb 2017 05:53:13 -0800 > On Tue, Feb 21, 2017 at 5:43 AM, Arnaldo Carvalho de Melo > wrote: >> >> Em Tue, Feb 21, 2017 at 02:27:40PM +0300, Andrey Ryabinin escreveu: >> > DCCP doesn't purge timewait sockets on network namespace shutdown. >> > So, after net names

Re: [PATCH net-next] tcp: Revert "tcp: tcp_probe: use spin_lock_bh()"

2017-02-21 Thread David Miller
From: Eric Dumazet Date: Tue, 21 Feb 2017 06:21:47 -0800 > This reverts commit e70ac171658679ecf6bea4bbd9e9325cd6079d2b. > > jtcp_rcv_established() is in fact called with hard irq being disabled. > > Initial bug report from Ricardo Nabinger Sanchez [1] still needs > to be investigated, but does

Re: [PATCH] net/dccp: fix use after free in tw_timer_handler()

2017-02-21 Thread David Miller
From: David Miller Date: Tue, 21 Feb 2017 13:23:51 -0500 (EST) > From: Andrey Ryabinin > Date: Tue, 21 Feb 2017 14:27:40 +0300 > >> DCCP doesn't purge timewait sockets on network namespace shutdown. >> So, after net namespace destroyed we could still have an active timer >> which will trigger u

Re: [PATCH] net/hsr: use eth_hw_addr_random()

2017-02-21 Thread David Miller
From: Tobias Klauser Date: Tue, 21 Feb 2017 14:04:59 +0100 > Use eth_hw_addr_random() to set a random MAC address in order to make sure > dev->addr_assign_type will be properly set to NET_ADDR_RANDOM. > > Signed-off-by: Tobias Klauser Applied.

  1   2   3   >