Re: [PATCH 0/7] net: stmmac: Fixes and Tegra186 support

2017-02-26 Thread Thierry Reding
On Thu, Feb 23, 2017 at 12:57:05PM -0500, David Miller wrote: > > The net-next tree is closed, therefore it is not appropriate to submit > feature patches or cleanups at this time. > > Please wait for the merge window to be finished and the net-next tree > to open back up before resubmitting

Re: [PATCH v5 5/6] 6lowpan: Use netdev addr_len to determine lladdr len

2017-02-26 Thread Alexander Aring
Hi, On 02/24/2017 01:14 PM, Luiz Augusto von Dentz wrote: > From: Luiz Augusto von Dentz > > This allow technologies such as Bluetooth to use its native lladdr which > is eui48 instead of eui64 which was expected by functions like > lowpan_header_decompress and

Re: [PATCH net-next 2/2] sctp: add support for MSG_MORE

2017-02-26 Thread Xin Long
On Sat, Feb 25, 2017 at 4:41 PM, Xin Long wrote: > On Fri, Feb 24, 2017 at 6:14 PM, David Laight wrote: >> >> From: Xin Long >> > Sent: 24 February 2017 06:44 >> ... >> > > IIRC sctp_packet_can_append_data() is called for the first queued >> > >

[PATCH v2 net-next 0/6] drivers: net: xgene-v2: Add RGMII based 1G driver

2017-02-26 Thread Iyappan Subramanian
This patch set adds support for RGMII based 1GbE hardware which uses a linked list of DMA descriptor architecture (v2) for APM X-Gene SoCs. Signed-off-by: Iyappan Subramanian --- v2: Address review comments from v1 - moved create_desc_ring and delete_desc_ring to

[PATCH v2 net-next 5/6] drivers: net: xgene-v2: Add transmit and receive

2017-02-26 Thread Iyappan Subramanian
This patch adds, - Transmit - Transmit completion poll - Receive poll - NAPI handler and enables the driver. Signed-off-by: Iyappan Subramanian Signed-off-by: Keyur Chudgar --- drivers/net/ethernet/apm/Kconfig | 1 +

[PATCH v2 net-next 1/6] drivers: net: xgene-v2: Add DMA descriptor

2017-02-26 Thread Iyappan Subramanian
This patch adds DMA descriptor setup and interrupt enable/disable functions. Signed-off-by: Iyappan Subramanian Signed-off-by: Keyur Chudgar --- drivers/net/ethernet/apm/xgene-v2/main.h | 74 +++ drivers/net/ethernet/apm/xgene-v2/ring.c

[PATCH v2 net-next 2/6] drivers: net: xgene-v2: Add mac configuration

2017-02-26 Thread Iyappan Subramanian
This patch adds functions to configure and control mac. This patch also adds helper functions to get/set registers. Signed-off-by: Iyappan Subramanian Signed-off-by: Keyur Chudgar --- drivers/net/ethernet/apm/xgene-v2/mac.c | 116

[PATCH v2 net-next 6/6] MAINTAINERS: Add entry for APM X-Gene SoC Ethernet (v2) driver

2017-02-26 Thread Iyappan Subramanian
This patch adds a MAINTAINERS entry for the ethernet driver for the on-chip ethernet interface which uses a linked list of DMA descriptor architecture (v2) for APM X-Gene SoCs. Signed-off-by: Iyappan Subramanian Signed-off-by: Keyur Chudgar ---

Re: [PATCH net-next 4/6] drivers: net: xgene-v2: Add base driver

2017-02-26 Thread Iyappan Subramanian
Hi Andrew, On Tue, Jan 31, 2017 at 12:01 PM, Andrew Lunn wrote: >> + phy_mode = device_get_phy_mode(dev); >> + if (phy_mode < 0) { >> + dev_err(dev, "Unable to get phy-connection-type\n"); >> + return phy_mode; >> + } >> +

Re: [PATCH net-next 4/6] drivers: net: xgene-v2: Add base driver

2017-02-26 Thread Iyappan Subramanian
Hi Florian, On Tue, Jan 31, 2017 at 12:31 PM, Florian Fainelli wrote: > On 01/31/2017 11:03 AM, Iyappan Subramanian wrote: >> This patch adds, >> >> - probe, remove, shutdown >> - open, close and stats >> - create and delete ring >> - request and delete

Re: [PATCH net-next 5/6] drivers: net: xgene-v2: Add transmit and receive

2017-02-26 Thread Iyappan Subramanian
Hi Florian, On Tue, Jan 31, 2017 at 12:33 PM, Florian Fainelli wrote: > On 01/31/2017 11:03 AM, Iyappan Subramanian wrote: >> This patch adds, >> - Transmit >> - Transmit completion poll >> - Receive poll >> - NAPI handler >> >> and enables the driver. >> >>

[PATCH v2 net-next 3/6] drivers: net: xgene-v2: Add ethernet hardware configuration

2017-02-26 Thread Iyappan Subramanian
This patch adds functions to configure ethernet hardware. Signed-off-by: Iyappan Subramanian Signed-off-by: Keyur Chudgar --- drivers/net/ethernet/apm/xgene-v2/enet.c | 71 drivers/net/ethernet/apm/xgene-v2/enet.h | 43

Re: [PATCH net-next 5/6] drivers: net: xgene-v2: Add transmit and receive

2017-02-26 Thread Iyappan Subramanian
On Wed, Feb 1, 2017 at 3:09 AM, David Laight wrote: > From Florian Fainelli >> Sent: 31 January 2017 20:33 >> On 01/31/2017 11:03 AM, Iyappan Subramanian wrote: >> > This patch adds, >> > - Transmit >> > - Transmit completion poll >> > - Receive poll >> >

Re: [PATCH net] l2tp: avoid use-after-free caused by l2tp_ip_backlog_recv

2017-02-26 Thread David Miller
From: Paul Hüber Date: Sun, 26 Feb 2017 17:58:19 +0100 > l2tp_ip_backlog_recv may not return -1 if the packet gets dropped. > The return value is passed up to ip_local_deliver_finish, which treats > negative values as an IP protocol number for resubmission. > > Signed-off-by:

[PATCH net] net: solve a NAPI race

2017-02-26 Thread Eric Dumazet
From: Eric Dumazet While playing with mlx4 hardware timestamping of RX packets, I found that some packets were received by TCP stack with a ~200 ms delay... Since the timestamp was provided by the NIC, and my probe was added in tcp_v4_rcv() while in BH handler, I was

Re: [PATCH net] xfrm: provide correct dst in xfrm_neigh_lookup

2017-02-26 Thread David Miller
From: Julian Anastasov Date: Sat, 25 Feb 2017 17:57:43 +0200 > Fix xfrm_neigh_lookup to provide dst->path to the > neigh_lookup dst_ops method. > > When skb is provided, the IP address in packet should already > match the dst->path address family. But for the non-skb case, > we

Re: [PATCH net 1/1] net sched actions: decrement module reference count after table flush.

2017-02-26 Thread David Miller
From: Roman Mashak Date: Fri, 24 Feb 2017 11:00:32 -0500 > When tc actions are loaded as a module and no actions have been installed, > flushing them would result in actions removed from the memory, but modules > reference count not being decremented, so that the modules would

Re: [PATCH net] rxrpc: Kernel calls get stuck in recvmsg

2017-02-26 Thread David Miller
From: David Howells Date: Fri, 24 Feb 2017 21:57:13 + > Calls made through the in-kernel interface can end up getting stuck because > of a missed variable update in a loop in rxrpc_recvmsg_data(). The problem > is like this: > > (1) A new packet comes in and doesn't

Re: [bug report] rhashtable: Add nested tables

2017-02-26 Thread David Miller
From: Herbert Xu Date: Sat, 25 Feb 2017 22:38:11 +0800 > Subject: rhashtable: Fix use before NULL check in bucket_table_free > > Dan Carpenter reported a use before NULL check bug in the function > bucket_table_free. In fact we don't need the NULL check at all as >

Re: [rhashtable] 5d60de5ff1 [ INFO: suspicious RCU usage. ]

2017-02-26 Thread David Miller
From: Herbert Xu Date: Sat, 25 Feb 2017 22:39:50 +0800 > Subject: rhashtable: Fix RCU dereference annotation in rht_bucket_nested > > The current annotation is wrong as it says that we're only called > under spinlock. In fact it should be marked as under either >

Re: [PATCH net] ipv6: check sk sk_type and protocol early in ip_mroute_set/getsockopt

2017-02-26 Thread David Miller
From: Xin Long Date: Fri, 24 Feb 2017 16:29:06 +0800 > Commit 5e1859fbcc3c ("ipv4: ipmr: various fixes and cleanups") fixed > the issue for ipv4 ipmr: > > ip_mroute_setsockopt() & ip_mroute_getsockopt() should not > access/set raw_sk(sk)->ipmr_table before making sure

Re: [PATCH net] sctp: set sin_port for addr param when checking duplicate address

2017-02-26 Thread David Miller
From: Xin Long Date: Fri, 24 Feb 2017 15:18:46 +0800 > Commit b8607805dd15 ("sctp: not copying duplicate addrs to the assoc's > bind address list") tried to check for duplicate address before copying > to asoc's bind_addr list from global addr list. > > But all the addrs'

Re: [PATCH net 1/1] net sched actions: do not overwrite status of action creation.

2017-02-26 Thread David Miller
From: Roman Mashak Date: Fri, 24 Feb 2017 17:36:58 -0500 > nla_memdup_cookie was overwriting err value, declared at function > scope and earlier initialized with result of ->init(). At success > nla_memdup_cookie() returns 0, and thus module refcnt decremented, > although the

Re: [PATCH] lib: Allow compile-testing of parman

2017-02-26 Thread David Miller
From: Geert Uytterhoeven Date: Fri, 24 Feb 2017 11:25:55 +0100 > This allows to enable and run the accompanying test (test_parman) > without dependencies on other users of parman. > > Signed-off-by: Geert Uytterhoeven Applied, thanks.

[bpf] 9d876e79df: BUG: unable to handle kernel paging request at 653a8346

2017-02-26 Thread kernel test robot
24.576150] Kernel panic - not syncing: Fatal exception git bisect start 36fd98883ef26e06ac5e1f99569930f19d59da0a 7089db84e356562f8ba737c29e472cc42d530dbc -- git bisect bad 91908381ef0f5509e823d518c3e7c97141620db3 # 11:58 17- 18 Merge 'linux-review/Codrut-Grosu/ASoC-ux500-Added-to-the-n

[PATCH net/ipv6] net/ipv6: avoid possible dead locking on addr_gen_mode sysctl

2017-02-26 Thread Felix Jia
The addr_gen_mode variable can be accessed by both sysctl and netlink. Repleacd rtnl_lock() with rtnl_trylock() protect the sysctl operation to avoid the possbile dead lock.` Signed-off-by: Felix Jia --- net/ipv6/addrconf.c | 22 +++--- 1 file

[PATCH] net: sgi: ioc3-eth: use new api ethtool_{get|set}_link_ksettings

2017-02-26 Thread Philippe Reynes
The ethtool api {get|set}_settings is deprecated. We move this driver to new api {get|set}_link_ksettings. As I don't have the hardware, I'd be very pleased if someone may test this patch. Signed-off-by: Philippe Reynes --- drivers/net/ethernet/sgi/ioc3-eth.c | 14

Re: [PATCH net] net/mlx4_en: fix overflow in mlx4_en_init_timestamp()

2017-02-26 Thread David Miller
From: Eric Dumazet Date: Thu, 23 Feb 2017 15:22:43 -0800 > From: Eric Dumazet > > The cited commit makes a great job of finding optimal shift/multiplier > values assuming a 10 seconds wrap around, but forgot to change the > overflow_period

[PATCH][V2] rtlwifi: rtl8192de: ix spelling mistake: "althougth" -> "though"

2017-02-26 Thread Colin King
From: Colin Ian King trivial fix to spelling mistake in RT_TRACE message Signed-off-by: Colin Ian King --- drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH][V2] rtlwifi: rtl8192de: ix spelling mistake: "althougth" -> "though"

2017-02-26 Thread Larry Finger
On 02/26/2017 12:52 PM, Colin King wrote: From: Colin Ian King trivial fix to spelling mistake in RT_TRACE message Signed-off-by: Colin Ian King --- drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c | 2 +- 1 file changed, 1

Re: [PATCH][V2] rtlwifi: rtl8192de: ix spelling mistake: "althougth" -> "though"

2017-02-26 Thread Colin Ian King
On 26/02/17 18:52, Colin King wrote: > From: Colin Ian King > > trivial fix to spelling mistake in RT_TRACE message > > Signed-off-by: Colin Ian King > --- > drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c | 2 +- > 1 file changed, 1

Re: [PATCH net] net/mlx4_en: fix overflow in mlx4_en_init_timestamp()

2017-02-26 Thread Tariq Toukan
On 24/02/2017 1:22 AM, Eric Dumazet wrote: From: Eric Dumazet The cited commit makes a great job of finding optimal shift/multiplier values assuming a 10 seconds wrap around, but forgot to change the overflow_period computation. It overflows in cyclecounter_cyc2ns(),

[PATCH] net: rocker: use new api ethtool_{get|set}_link_ksettings

2017-02-26 Thread Philippe Reynes
The ethtool api {get|set}_settings is deprecated. We move this driver to new api {get|set}_link_ksettings. As I don't have the hardware, I'd be very pleased if someone may test this patch. Signed-off-by: Philippe Reynes --- drivers/net/ethernet/rocker/rocker_main.c | 55

Re: [PATCH net] net/mlx4_en: reception NAPI/IRQ race breaker

2017-02-26 Thread Eric Dumazet
On Sun, 2017-02-26 at 09:40 -0800, Eric Dumazet wrote: > NAPI_STATE_SCHED > > Actually we could use an additional bit for that, that the driver would > set even if NAPI_STATE_SCHED could not be grabbed. Just to be clear : Drivers would require no change, this would be done in existing helpers.

Re: [PATCH net] net/mlx4_en: reception NAPI/IRQ race breaker

2017-02-26 Thread Eric Dumazet
On Sun, 2017-02-26 at 09:34 -0800, Eric Dumazet wrote: > I do not believe this bug is mlx4 specific. > > Anything doing the following while hard irq were not masked : > > local_bh_disable(); > napi_reschedule(>rx_cq[ring]->napi); > local_bh_enable(); > > Like in mlx4_en_recover_from_oom() > >

Re: [PATCH net] net/mlx4_en: reception NAPI/IRQ race breaker

2017-02-26 Thread Eric Dumazet
On Sun, 2017-02-26 at 18:32 +0200, Saeed Mahameed wrote: > On Sat, Feb 25, 2017 at 4:22 PM, Eric Dumazet wrote: > > From: Eric Dumazet > > > > While playing with hardware timestamping of RX packets, I found > > that some packets were received by TCP

Re: [PATCH] rtlwifi: rtl8192de: ix spelling mistake: "althougth" -> "although"

2017-02-26 Thread Larry Finger
On 02/26/2017 09:19 AM, Colin King wrote: From: Colin Ian King trivial fix to spelling mistake in RT_TRACE message Signed-off-by: Colin Ian King Bad fix. It should be althougth => through. Please read the context. NACK. Larry ---

[PATCH net] l2tp: avoid use-after-free caused by l2tp_ip_backlog_recv

2017-02-26 Thread Paul Hüber
l2tp_ip_backlog_recv may not return -1 if the packet gets dropped. The return value is passed up to ip_local_deliver_finish, which treats negative values as an IP protocol number for resubmission. Signed-off-by: Paul Hüber --- net/l2tp/l2tp_ip.c | 2 +- 1 file changed, 1

Re: [PATCH] net: s2io: fix typo argumnet argument

2017-02-26 Thread David Miller
From: Corentin Labbe Date: Sat, 25 Feb 2017 21:12:41 +0100 > This commit fix the typo argumnet/argument > > Signed-off-by: Corentin Labbe Applied.

Re: [PATCH] net: vxge: fix typo argumnet argument

2017-02-26 Thread David Miller
From: Corentin Labbe Date: Sat, 25 Feb 2017 21:08:57 +0100 > This commit fix the typo argumnet/argument > > Signed-off-by: Corentin Labbe Applied.

Re: [PATCH net] net/mlx4_en: reception NAPI/IRQ race breaker

2017-02-26 Thread Saeed Mahameed
On Sat, Feb 25, 2017 at 4:22 PM, Eric Dumazet wrote: > From: Eric Dumazet > > While playing with hardware timestamping of RX packets, I found > that some packets were received by TCP stack with a ~200 ms delay... > > Since the timestamp was provided

Re: [PATCH] lib: fix spelling mistake: "actualy" -> "actually"

2017-02-26 Thread David Miller
From: Colin King Date: Sun, 26 Feb 2017 12:10:12 + > From: Colin Ian King > > trivial fix to spelling mistake in pr_err message > > Signed-off-by: Colin Ian King Applied.

Re: [PATCH net] ipv4: add missing initialization for flowi4_uid

2017-02-26 Thread David Miller
From: Julian Anastasov Date: Sun, 26 Feb 2017 15:50:52 +0200 > Avoid matching of random stack value for uid when rules > are looked up on input route or when RP filter is used. > Problem should affect only setups that use ip rules with > uid range. > > Fixes: 622ec2c9d524 ("net:

Re: [PATCH net] ipv4: mask tos for input route

2017-02-26 Thread David Miller
From: Julian Anastasov Date: Sun, 26 Feb 2017 17:14:35 +0200 > Restore the lost masking of TOS in input route code to > allow ip rules to match it properly. > > Problem [1] noticed by Shmulik Ladkani > > [1] http://marc.info/?t=137331755300040=1=2 > >

[PATCH] rtlwifi: rtl8192de: ix spelling mistake: "althougth" -> "although"

2017-02-26 Thread Colin King
From: Colin Ian King trivial fix to spelling mistake in RT_TRACE message Signed-off-by: Colin Ian King --- drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH net] ipv4: mask tos for input route

2017-02-26 Thread Julian Anastasov
Restore the lost masking of TOS in input route code to allow ip rules to match it properly. Problem [1] noticed by Shmulik Ladkani [1] http://marc.info/?t=137331755300040=1=2 Fixes: 89aef8921bfb ("ipv4: Delete routing cache.") Signed-off-by: Julian Anastasov

Re: [PATCH] iproute2: show network device dependency tree

2017-02-26 Thread Jiri Pirko
Sun, Feb 26, 2017 at 03:00:14PM CET, zaboj.camp...@post.cz wrote: >On Sun, 2017-02-26 at 08:56 +0100, Jiri Pirko wrote: >> Sat, Feb 25, 2017 at 09:22:22PM CET, zaboj.camp...@post.cz wrote: >> > On Sat, 2017-02-25 at 18:39 +0100, Jiri Pirko wrote: >> > > > Sat, Feb 25, 2017 at 05:59:00PM CET,

Re: [PATCH] lib: fix spelling mistake: "actualy" -> "actually"

2017-02-26 Thread Jiri Pirko
Sun, Feb 26, 2017 at 01:10:12PM CET, colin.k...@canonical.com wrote: >From: Colin Ian King > >trivial fix to spelling mistake in pr_err message > >Signed-off-by: Colin Ian King Acked-by: Jiri Pirko >--- >

RE: FOR YOUR INFORMATION

2017-02-26 Thread Eddie Concepcion
From: Eddie Concepcion Sent: Sunday, February 26, 2017 9:11 AM To: Eddie Concepcion Subject: FOR YOUR INFORMATION Hi, You have received a donation of 1,000,000USD; reply to merlebutler...@gmail.com, for details.

[PATCH net] ipv4: add missing initialization for flowi4_uid

2017-02-26 Thread Julian Anastasov
Avoid matching of random stack value for uid when rules are looked up on input route or when RP filter is used. Problem should affect only setups that use ip rules with uid range. Fixes: 622ec2c9d524 ("net: core: add UID to flows, rules, and routes") Signed-off-by: Julian Anastasov

Re: [PATCH] iproute2: show network device dependency tree

2017-02-26 Thread Zaboj Campula
On Sun, 2017-02-26 at 08:56 +0100, Jiri Pirko wrote: > Sat, Feb 25, 2017 at 09:22:22PM CET, zaboj.camp...@post.cz wrote: > > On Sat, 2017-02-25 at 18:39 +0100, Jiri Pirko wrote: > > > > Sat, Feb 25, 2017 at 05:59:00PM CET, zaboj.camp...@post.cz > > > > wrote: > > > > Add the argument '-tree' to

[PATCH] lib: fix spelling mistake: "actualy" -> "actually"

2017-02-26 Thread Colin King
From: Colin Ian King trivial fix to spelling mistake in pr_err message Signed-off-by: Colin Ian King --- lib/test_parman.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/test_parman.c b/lib/test_parman.c index

Re: [Intel-wired-lan] [PATCH] e1000e: fix timing for 82579 Gigabit Ethernet controller

2017-02-26 Thread Neftin, Sasha
On 2/19/2017 14:55, Neftin, Sasha wrote: On 2/16/2017 20:42, Bernd Faust wrote: After an upgrade to Linux kernel v4.x the hardware timestamps of the 82579 Gigabit Ethernet Controller are different than expected. The values that are being read are almost four times as big as before the kernel