[patch net] mlxsw: spectrum_router: Avoid potential packets loss

2017-02-27 Thread Jiri Pirko
From: Ido Schimmel When the structure of the LPM tree changes (f.e., due to the addition of a new prefix), we unbind the old tree and then bind the new one. This may result in temporary packet loss. Instead, overwrite the old binding with the new one. Fixes: 6b75c4807db3 ("mlxsw: spectrum_route

[bug report] dp83640: Delay scheduled work.

2017-02-27 Thread Dan Carpenter
Hello Stefan Sørensen, The patch 4b063258ab93: "dp83640: Delay scheduled work." from Nov 3, 2015, leads to the following static checker warning: drivers/net/phy/dp83640.c:1442 dp83640_rxtstamp() warn: 'skb' was already freed. drivers/net/phy/dp83640.c 1402 struct dp836

Re: [Patch net v2] ipv6: check for ip6_null_entry in __ip6_del_rt_siblings()

2017-02-27 Thread kbuild test robot
Hi Cong, [auto build test WARNING on net/master] url: https://github.com/0day-ci/linux/commits/Cong-Wang/ipv6-check-for-ip6_null_entry-in-__ip6_del_rt_siblings/20170228-135206 config: x86_64-randconfig-x017-201709 (attached as .config) compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901 reproduce

[PATCH net] sctp: call rcu_read_lock before checking for duplicate transport nodes

2017-02-27 Thread Xin Long
Commit cd2b70875058 ("sctp: check duplicate node before inserting a new transport") called rhltable_lookup() to check for the duplicate transport node in transport rhashtable. But rhltable_lookup() doesn't call rcu_read_lock inside, it could cause a use-after-free issue if it tries to dereference

Re: [PATCH V2] vhost: introduce O(1) vq metadata cache

2017-02-27 Thread Jason Wang
On 2017年02月28日 02:35, Michael S. Tsirkin wrote: On Wed, Feb 15, 2017 at 01:37:17PM +0800, Jason Wang wrote: On 2016年12月14日 17:53, Jason Wang wrote: When device IOTLB is enabled, all address translations were stored in interval tree. O(lgN) searching time could be slow for virtqueue metadata

Re: [PATCH v2 net] net: solve a NAPI race

2017-02-27 Thread David Miller
From: Eric Dumazet Date: Mon, 27 Feb 2017 08:44:14 -0800 > Any point doing a napi_schedule() not from device hard irq handler > is subject to the race for NIC using some kind of edge trigger > interrupts. > > Since we do not provide a ndo to disable device interrupts, the > following can happen.

[GIT] Networking

2017-02-27 Thread David Miller
1) Don't save TIPC header values before the header has been validated, from Jon Paul Maloy. 2) Fix memory leak in RDS, from Zhu Yanjun. 3) We miss to initialize the UID in the flow key in some paths, from Julian Anastasov. 4) Fix latent TOS masking bug in the routing cache removal from ye

Re: [Patch net v3] ipv6: check for ip6_null_entry in __ip6_del_rt_siblings()

2017-02-27 Thread David Ahern
On 2/27/17 4:07 PM, Cong Wang wrote: > Andrey reported a NULL pointer deref bug in ipv6_route_ioctl() > -> ip6_route_del() -> __ip6_del_rt_siblings() code path. This is > because ip6_null_entry is returned in this path since ip6_null_entry > is kinda default for a ipv6 route table root node. Quote

[RFC PATCH] uapi: fix linux/packet_diag.h userspace compilation error

2017-02-27 Thread Dmitry V. Levin
Replace MAX_ADDR_LEN with its numeric value to fix the following linux/packet_diag.h userspace compilation error: /usr/include/linux/packet_diag.h:67:17: error: 'MAX_ADDR_LEN' undeclared here (not in a function) __u8 pdmc_addr[MAX_ADDR_LEN]; This is not the first case in the UAPI where the num

Re: [Patch net] ipv6: check for ip6_null_entry in __ip6_del_rt_siblings()

2017-02-27 Thread Cong Wang
On Mon, Feb 27, 2017 at 1:06 PM, David Ahern wrote: > On 2/27/17 1:04 PM, Cong Wang wrote: >>> >>> for (rt = fn->leaf; rt; rt = rt->dst.rt6_next) { >>> + /* do not allow deletion of the null route */ >>> + if (rt == net->ipv6.ip6_null_ent

Re: [PATCH v3 net] net: solve a NAPI race

2017-02-27 Thread Stephen Hemminger
On Mon, 27 Feb 2017 17:48:54 -0500 (EST) David Miller wrote: > From: Stephen Hemminger > Date: Mon, 27 Feb 2017 14:44:55 -0800 > > > On Mon, 27 Feb 2017 14:35:17 -0800 > > Eric Dumazet wrote: > > > >> On Mon, 2017-02-27 at 14:14 -0800, Stephen Hemminger wrote: > >> > >> > The original de

[PATCH v1.2] dt: emac: document device-tree based phy discovery and setup

2017-02-27 Thread Christian Lamparter
This patch adds documentation for a new "phy-handle" property, "fixed-link" and "mdio" sub-node. These allows the enumeration of PHYs which are supported by the phy library under drivers/net/phy. The EMAC ethernet controller in IBM and AMCC 4xx chips is currently stuck with a few privately defined

Re: [PATCH v2 net] net: phy: Fix LED mode in DT single property.

2017-02-27 Thread Rob Herring
On Fri, Feb 24, 2017 at 4:47 AM, Raju Lakkaraju wrote: > From: Raju Lakkaraju > > Fix the LED mode DT parameters combine to a single property > and change the vendor prefix i.e. mscc. > > Signed-off-by: Raju Lakkaraju > --- > Change set: > v0: Fix the LED mode DT parameters combine to a single p

Re: [PATCH v1.1] dt: emac: document device-tree based phy discovery and setup

2017-02-27 Thread Florian Fainelli
On 02/27/2017 12:11 PM, Christian Lamparter wrote: > This patch adds documentation for a new "phy-handle" property, > "fixed-link" and "mdio" sub-node. These allows the enumeration > of PHYs which are supported by the phy library under drivers/net/phy. > > The EMAC ethernet controller in IBM and A

Re: [Patch net v3] ipv6: check for ip6_null_entry in __ip6_del_rt_siblings()

2017-02-27 Thread Cong Wang
On Mon, Feb 27, 2017 at 4:14 PM, David Ahern wrote: > On 2/27/17 4:07 PM, Cong Wang wrote: >> Andrey reported a NULL pointer deref bug in ipv6_route_ioctl() >> -> ip6_route_del() -> __ip6_del_rt_siblings() code path. This is >> because ip6_null_entry is returned in this path since ip6_null_entry >

Re: Extending socket timestamping API for NTP

2017-02-27 Thread Willem de Bruijn
On Mon, Feb 27, 2017 at 10:23 AM, Miroslav Lichvar wrote: > On Tue, Feb 07, 2017 at 02:32:04PM -0800, Willem de Bruijn wrote: >> >> 4) allow sockets to use both SW and HW TX timestamping at the same time >> >> >> >>When using a socket which is not bound to a specific interface, it >> >>wou

[PATCH] wireless: ipw2200: remove redundant check of rc < 0

2017-02-27 Thread Colin King
From: Colin Ian King The check for rc < 0 is always false so the check is redundant and can be removed. Detected with CoverityScan, CID#101143 ("Logically dead code") Signed-off-by: Colin Ian King --- drivers/net/wireless/intel/ipw2x00/ipw2200.c | 3 --- 1 file changed, 3 deletions(-) diff -

[Patch net v3] ipv6: check for ip6_null_entry in __ip6_del_rt_siblings()

2017-02-27 Thread Cong Wang
Andrey reported a NULL pointer deref bug in ipv6_route_ioctl() -> ip6_route_del() -> __ip6_del_rt_siblings() code path. This is because ip6_null_entry is returned in this path since ip6_null_entry is kinda default for a ipv6 route table root node. Quote from David Ahern: ip6_null_entry is the roo

Re: [PATCH v3 net] net: solve a NAPI race

2017-02-27 Thread David Miller
From: Stephen Hemminger Date: Mon, 27 Feb 2017 14:44:55 -0800 > On Mon, 27 Feb 2017 14:35:17 -0800 > Eric Dumazet wrote: > >> On Mon, 2017-02-27 at 14:14 -0800, Stephen Hemminger wrote: >> >> > The original design (as Davem mentioned) was that IRQ's must be disabled >> > during device polling.

[PATCH v1.1] dt: emac: document device-tree based phy discovery and setup

2017-02-27 Thread Christian Lamparter
This patch adds documentation for a new "phy-handle" property, "fixed-link" and "mdio" sub-node. These allows the enumeration of PHYs which are supported by the phy library under drivers/net/phy. The EMAC ethernet controller in IBM and AMCC 4xx chips is currently stuck with a few privately defined

Re: [PATCH v3 net] net: solve a NAPI race

2017-02-27 Thread Stephen Hemminger
On Mon, 27 Feb 2017 14:35:17 -0800 Eric Dumazet wrote: > On Mon, 2017-02-27 at 14:14 -0800, Stephen Hemminger wrote: > > > The original design (as Davem mentioned) was that IRQ's must be disabled > > during device polling. If that was true, then the race above > > would be impossible. > > I w

[PATCH] net: smsc: epic100: use new api ethtool_{get|set}_link_ksettings

2017-02-27 Thread Philippe Reynes
The ethtool api {get|set}_settings is deprecated. We move this driver to new api {get|set}_link_ksettings. As I don't have the hardware, I'd be very pleased if someone may test this patch. Signed-off-by: Philippe Reynes --- drivers/net/ethernet/smsc/epic100.c | 16 +--- 1 files ch

Re: [PATCH v3 net] net: solve a NAPI race

2017-02-27 Thread Eric Dumazet
On Mon, 2017-02-27 at 14:14 -0800, Stephen Hemminger wrote: > The original design (as Davem mentioned) was that IRQ's must be disabled > during device polling. If that was true, then the race above > would be impossible. I would love to see an alternative patch.

[PATCH] net: sis: sis900: use new api ethtool_{get|set}_link_ksettings

2017-02-27 Thread Philippe Reynes
The ethtool api {get|set}_settings is deprecated. We move this driver to new api {get|set}_link_ksettings. As I don't have the hardware, I'd be very pleased if someone may test this patch. Signed-off-by: Philippe Reynes --- drivers/net/ethernet/sis/sis900.c | 18 +- 1 files ch

Re: net/ipv6: null-ptr-deref in ip6_route_del/lock_acquire

2017-02-27 Thread Andrey Konovalov
On Mon, Feb 27, 2017 at 9:34 PM, Cong Wang wrote: > On Mon, Feb 27, 2017 at 12:05 PM, Andrey Konovalov > wrote: >> On Mon, Feb 27, 2017 at 8:59 PM, David Ahern >> wrote: >>> On 2/27/17 10:11 AM, Cong Wang wrote: The attached patch fixes this crash, but I am not sure if it is the best

[PATCH] net: silan: sc92031: use new api ethtool_{get|set}_link_ksettings

2017-02-27 Thread Philippe Reynes
The ethtool api {get|set}_settings is deprecated. We move this driver to new api {get|set}_link_ksettings. As I don't have the hardware, I'd be very pleased if someone may test this patch. Signed-off-by: Philippe Reynes --- drivers/net/ethernet/silan/sc92031.c | 83 +++

Re: [PATCH v3 net] net: solve a NAPI race

2017-02-27 Thread Stephen Hemminger
On Mon, 27 Feb 2017 12:18:31 -0800 Eric Dumazet wrote: > thread 1 thread 2 (could be on same cpu) > > // busy polling or napi_watchdog() > napi_schedule(); > ... > napi->poll() > > device polling: > read 2 packets from ring buffer >

[PATCH] net: sis: sis190: use new api ethtool_{get|set}_link_ksettings

2017-02-27 Thread Philippe Reynes
The ethtool api {get|set}_settings is deprecated. We move this driver to new api {get|set}_link_ksettings. As I don't have the hardware, I'd be very pleased if someone may test this patch. Signed-off-by: Philippe Reynes --- drivers/net/ethernet/sis/sis190.c | 14 -- 1 files change

Re: [Patch net] ipv6: check for ip6_null_entry in __ip6_del_rt_siblings()

2017-02-27 Thread David Ahern
On 2/27/17 1:04 PM, Cong Wang wrote: >> >> for (rt = fn->leaf; rt; rt = rt->dst.rt6_next) { >> + /* do not allow deletion of the null route */ >> + if (rt == net->ipv6.ip6_null_entry) >> + continue; >> >> Fixe

Re: [Patch net v2] ipv6: check for ip6_null_entry in __ip6_del_rt_siblings()

2017-02-27 Thread Eric Dumazet
On Mon, 2017-02-27 at 13:34 -0800, Cong Wang wrote: > Andrey reported a NULL pointer deref bug in ipv6_route_ioctl() > -> ip6_route_del() -> __ip6_del_rt_siblings() code path. This is > because ip6_null_entry is returned in this path since ip6_null_entry > is kinda default for a ipv6 route table ro

[Patch net v2] ipv6: check for ip6_null_entry in __ip6_del_rt_siblings()

2017-02-27 Thread Cong Wang
Andrey reported a NULL pointer deref bug in ipv6_route_ioctl() -> ip6_route_del() -> __ip6_del_rt_siblings() code path. This is because ip6_null_entry is returned in this path since ip6_null_entry is kinda default for a ipv6 route table root node. Quote from David Ahern: ip6_null_entry is the roo

Re: [Patch net] ipv6: check for ip6_null_entry in __ip6_del_rt_siblings()

2017-02-27 Thread Cong Wang
On Mon, Feb 27, 2017 at 1:00 PM, David Ahern wrote: > On 2/27/17 12:34 PM, Eric Dumazet wrote: >> On Mon, 2017-02-27 at 11:07 -0800, Cong Wang wrote: >>> Andrey reported a NULL pointer deref bug in ipv6_route_ioctl() >>> -> ip6_route_del() -> __ip6_del_rt_siblings() code path. This is >>> because

Re: net/ipv6: null-ptr-deref in ip6_route_del/lock_acquire

2017-02-27 Thread David Ahern
On 2/27/17 12:37 PM, Andrey Konovalov wrote: > That's what I thought when I read your message, thanks! > > I was just confused by David saying that the fuzzer is doing something > interesting, when the reproducer is just an ioctl call on a socket. It means I have a cold, recently off a plane and

[PATCH v3 net] net: solve a NAPI race

2017-02-27 Thread Eric Dumazet
From: Eric Dumazet While playing with mlx4 hardware timestamping of RX packets, I found that some packets were received by TCP stack with a ~200 ms delay... Since the timestamp was provided by the NIC, and my probe was added in tcp_v4_rcv() while in BH handler, I was confident it was not a sende

Re: [Patch net] ipv6: check for ip6_null_entry in __ip6_del_rt_siblings()

2017-02-27 Thread David Ahern
On 2/27/17 12:34 PM, Eric Dumazet wrote: > On Mon, 2017-02-27 at 11:07 -0800, Cong Wang wrote: >> Andrey reported a NULL pointer deref bug in ipv6_route_ioctl() >> -> ip6_route_del() -> __ip6_del_rt_siblings() code path. This is >> because ip6_null_entry is returned in this path since ip6_null_entr

Re: [PATCH v2 net] net: solve a NAPI race

2017-02-27 Thread Alexander Duyck
On Mon, Feb 27, 2017 at 8:19 AM, David Miller wrote: > From: Eric Dumazet > Date: Mon, 27 Feb 2017 06:21:38 -0800 > >> A NAPI driver normally arms the IRQ after the napi_complete_done(), >> after NAPI_STATE_SCHED is cleared, so that the hard irq handler can grab >> it. >> >> Problem is that if an

Re: [Patch net] ipv6: check for ip6_null_entry in __ip6_del_rt_siblings()

2017-02-27 Thread Cong Wang
On Mon, Feb 27, 2017 at 12:34 PM, Eric Dumazet wrote: > On Mon, 2017-02-27 at 11:07 -0800, Cong Wang wrote: >> Andrey reported a NULL pointer deref bug in ipv6_route_ioctl() >> -> ip6_route_del() -> __ip6_del_rt_siblings() code path. This is >> because ip6_null_entry is returned in this path since

[PATCH v2] dt: emac: document device-tree based phy discovery and setup

2017-02-27 Thread Christian Lamparter
This patch adds documentation for a new "phy-handle" property, "fixed-link" and "mdio" sub-node. These allows the enumeration of PHYs which are supported by the phy library under drivers/net/phy. The EMAC ethernet controller in IBM and AMCC 4xx chips is currently stuck with a few privately defined

Re: net/ipv6: null-ptr-deref in ip6_route_del/lock_acquire

2017-02-27 Thread Cong Wang
On Mon, Feb 27, 2017 at 12:05 PM, Andrey Konovalov wrote: > On Mon, Feb 27, 2017 at 8:59 PM, David Ahern wrote: >> On 2/27/17 10:11 AM, Cong Wang wrote: >>> The attached patch fixes this crash, but I am not sure if it is the >>> best way to fix this bug yet... >> >> I'll take a look. I can not re

Re: [PATCH v1.2] dt: emac: document device-tree based phy discovery and setup

2017-02-27 Thread Florian Fainelli
On 02/27/2017 12:41 PM, Christian Lamparter wrote: > This patch adds documentation for a new "phy-handle" property, > "fixed-link" and "mdio" sub-node. These allows the enumeration > of PHYs which are supported by the phy library under drivers/net/phy. > > The EMAC ethernet controller in IBM and A

Re: [Patch net] ipv6: check for ip6_null_entry in __ip6_del_rt_siblings()

2017-02-27 Thread Eric Dumazet
On Mon, 2017-02-27 at 11:07 -0800, Cong Wang wrote: > Andrey reported a NULL pointer deref bug in ipv6_route_ioctl() > -> ip6_route_del() -> __ip6_del_rt_siblings() code path. This is > because ip6_null_entry is returned in this path since ip6_null_entry > is kinda default for a ipv6 route table ro

Re: [PATCH v1.1] net: emac: add support for device-tree based PHY discovery and setup

2017-02-27 Thread David Miller
From: Christian Lamparter Date: Mon, 27 Feb 2017 20:42:15 +0100 > On Wednesday, February 22, 2017 3:37:35 PM CET David Miller wrote: >> From: Christian Lamparter >> Date: Mon, 20 Feb 2017 20:10:58 +0100 >> >> > This patch adds glue-code that allows the EMAC driver to interface >> > with the exi

Re: net/ipv6: null-ptr-deref in ip6_route_del/lock_acquire

2017-02-27 Thread David Ahern
On 2/27/17 10:11 AM, Cong Wang wrote: > The attached patch fixes this crash, but I am not sure if it is the > best way to fix this bug yet... I'll take a look. I can not reproduce this using route or ip, so the fuzzer is doing something interesting.

Re: net/ipv6: null-ptr-deref in ip6_route_del/lock_acquire

2017-02-27 Thread Andrey Konovalov
On Mon, Feb 27, 2017 at 8:59 PM, David Ahern wrote: > On 2/27/17 10:11 AM, Cong Wang wrote: >> The attached patch fixes this crash, but I am not sure if it is the >> best way to fix this bug yet... > > I'll take a look. I can not reproduce this using route or ip, so the > fuzzer is doing something

Re: [PATCH v1.1] net: emac: add support for device-tree based PHY discovery and setup

2017-02-27 Thread Christian Lamparter
On Wednesday, February 22, 2017 3:37:35 PM CET David Miller wrote: > From: Christian Lamparter > Date: Mon, 20 Feb 2017 20:10:58 +0100 > > > This patch adds glue-code that allows the EMAC driver to interface > > with the existing dt-supported PHYs in drivers/net/phy. > > > > Because currently, t

Re: [PATCH V2] vhost: introduce O(1) vq metadata cache

2017-02-27 Thread Michael S. Tsirkin
On Wed, Feb 15, 2017 at 01:37:17PM +0800, Jason Wang wrote: > > > On 2016年12月14日 17:53, Jason Wang wrote: > > When device IOTLB is enabled, all address translations were stored in > > interval tree. O(lgN) searching time could be slow for virtqueue > > metadata (avail, used and descriptors) since

Re: [PATCH] iproute2: show network device dependency tree

2017-02-27 Thread Stephen Hemminger
On Sat, 25 Feb 2017 16:59:00 + Zaboj Campula wrote: > dd the argument '-tree' to ip-link to show network devices dependency tree. > > Example: > > $ ip -tree link > eth0 > bond0 > eth1 > bond0 > eth2 > bond1 > eth3 > bond1 Maybe use format similar to other utilities (lspci,

[Patch net] ipv6: check for ip6_null_entry in __ip6_del_rt_siblings()

2017-02-27 Thread Cong Wang
Andrey reported a NULL pointer deref bug in ipv6_route_ioctl() -> ip6_route_del() -> __ip6_del_rt_siblings() code path. This is because ip6_null_entry is returned in this path since ip6_null_entry is kinda default for a ipv6 route table root node. Quote from David Ahern: ip6_null_entry is the roo

Re: [PATCH RFC v2 00/12] socket sendmsg MSG_ZEROCOPY

2017-02-27 Thread Michael Kerrisk
[CC += linux-...@vger.kernel.org] Hi Willem This is a change to the kernel-user-space API. Please CC linux-...@vger.kernel.org on any future iterations of this patch. Thanks, Michael On Wed, Feb 22, 2017 at 5:38 PM, Willem de Bruijn wrote: > From: Willem de Bruijn > > RFCv2: > > I have rec

[PATCH 1/5] netvsc: don't overload variable in same function

2017-02-27 Thread Stephen Hemminger
There are two variables named packet in the same function. One is the metadata descriptor from host (vmpacket_descriptor) and the other is the control block in the skb used to hold metadata from send. Change name to avoid possible confusion and bugs. Signed-off-by: Stephen Hemminger --- drivers/

[PATCH 4/5] netvsc: enable GRO

2017-02-27 Thread Stephen Hemminger
Use GRO when receiving packets. Signed-off-by: Stephen Hemminger --- drivers/net/hyperv/netvsc_drv.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/hyperv/netvsc_drv.c b/drivers/net/hyperv/netvsc_drv.c index 54b6cab5af23..6dcd1f08b834 100644 --- a/drivers

[PATCH v1 4/4] iscsi-target: use generic inet_pton_with_scope

2017-02-27 Thread Sagi Grimberg
Acked-by: Nicholas Bellinger Signed-off-by: Sagi Grimberg --- drivers/target/iscsi/iscsi_target_configfs.c | 46 1 file changed, 12 insertions(+), 34 deletions(-) diff --git a/drivers/target/iscsi/iscsi_target_configfs.c b/drivers/target/iscsi/iscsi_target_configfs

Re: [PATCH] iproute2: show network device dependency tree

2017-02-27 Thread Stephen Hemminger
On Sat, 25 Feb 2017 16:59:00 + Zaboj Campula wrote: > Add the argument '-tree' to ip-link to show network devices dependency tree. > > Example: > > $ ip -tree link > eth0 > bond0 > eth1 > bond0 > eth2 > bond1 > eth3 > bond1 Another alternative format would be to make -tree

[PATCH v2 net] net: solve a NAPI race

2017-02-27 Thread Eric Dumazet
From: Eric Dumazet While playing with mlx4 hardware timestamping of RX packets, I found that some packets were received by TCP stack with a ~200 ms delay... Since the timestamp was provided by the NIC, and my probe was added in tcp_v4_rcv() while in BH handler, I was confident it was not a sende

Fw: [Bug 194723] New: connect() to localhost stalls after 4.9 -> 4.10 upgrade

2017-02-27 Thread Stephen Hemminger
Begin forwarded message: Date: Mon, 27 Feb 2017 11:28:51 + From: bugzilla-dae...@bugzilla.kernel.org To: step...@networkplumber.org Subject: [Bug 194723] New: connect() to localhost stalls after 4.9 -> 4.10 upgrade https://bugzilla.kernel.org/show_bug.cgi?id=194723 Bug ID: 19

[PATCH 3/5] netvsc: implement NAPI

2017-02-27 Thread Stephen Hemminger
Use NAPI (softirq), to handle receive packets and send completions. Previously this was handled by tasklet. Signed-off-by: Stephen Hemminger --- drivers/net/hyperv/hyperv_net.h | 2 + drivers/net/hyperv/netvsc.c | 140 ++ drivers/net/hyperv/netvsc_dr

[PATCH 5/5] netvsc: replace netdev_alloc_skb_ip_align with napi_alloc_skb

2017-02-27 Thread Stephen Hemminger
Gives potential performance gain. Signed-off-by: Stephen Hemminger --- drivers/net/hyperv/netvsc_drv.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/hyperv/netvsc_drv.c b/drivers/net/hyperv/netvsc_drv.c index 6dcd1f08b834..f95d686b7957 100644 --- a/drivers

[PATCH net 0/5] NAPI support for Hyper-V

2017-02-27 Thread Stephen Hemminger
These patches enable NAPI, GRO and napi_alloc_skb for Hyper-V netvsc driver. Stephen Hemminger (5): netvsc: don't overload variable in same function vmbus: introduce in-place packet iterator netvsc: implement NAPI netvsc: enable GRO netvsc: replace netdev_alloc_skb_ip_align with napi_all

[PATCH 2/5] vmbus: introduce in-place packet iterator

2017-02-27 Thread Stephen Hemminger
This is mostly just a refactoring of previous functions (get_pkt_next_raw, put_pkt_raw and commit_rd_index) to make it easier to use for other drivers and NAPI. Signed-off-by: Stephen Hemminger --- drivers/hv/ring_buffer.c| 94 +++- drivers/net/hyperv/

Re: net/ipv6: null-ptr-deref in ip6_route_del/lock_acquire

2017-02-27 Thread Cong Wang
On Mon, Feb 27, 2017 at 7:28 AM, Andrey Konovalov wrote: > Hi, > > I've got the following error report while fuzzing the kernel with syzkaller. > > On commit e5d56efc97f8240d0b5d66c03949382b6d7e5570 (Feb 26). > > A reproducer and .config are attached. > > kasan: CONFIG_KASAN_INLINE enabled > kasan

[PATCH] net: bridge: allow IPv6 when multicast flood is disabled

2017-02-27 Thread Mike Manning
Even with multicast flooding turned off, IPv6 ND should still work so that IPv6 connectivity is provided. Allow this by continuing to flood multicast traffic originated by us. And similar to the unicast case, set auto-mask if the multicast flood flag is set. Fixes: b6cb5ac8331b ("net: bridge: add

[PATCH v1 1/4] net/utils: generic inet_pton_with_scope helper

2017-02-27 Thread Sagi Grimberg
Several locations in the stack need to handle ipv4/ipv6 (with scope) and port strings conversion to sockaddr. Add a helper that takes either AF_INET, AF_INET6 or AF_UNSPEC (for wildcard) to centralize this handling. Suggested-by: Christoph Hellwig Signed-off-by: Sagi Grimberg --- include/linux/

[PATCH v1 2/4] nvmet-rdma: use generic inet_pton_with_scope

2017-02-27 Thread Sagi Grimberg
Signed-off-by: Sagi Grimberg --- drivers/nvme/target/rdma.c | 42 +- 1 file changed, 29 insertions(+), 13 deletions(-) diff --git a/drivers/nvme/target/rdma.c b/drivers/nvme/target/rdma.c index 9aa1da3778b3..973b674ab55b 100644 --- a/drivers/nvme/target/rd

[PATCH v1 3/4] nvme-rdma: use inet_pton_with_scope helper

2017-02-27 Thread Sagi Grimberg
Signed-off-by: Sagi Grimberg --- drivers/nvme/host/rdma.c | 63 +++- 1 file changed, 19 insertions(+), 44 deletions(-) diff --git a/drivers/nvme/host/rdma.c b/drivers/nvme/host/rdma.c index 49b2121af689..3f4c49969f55 100644 --- a/drivers/nvme/host/rdma

[PATCH v1 0/4] Introduce a new helper for parsing ipv[4|6]:port to socket address

2017-02-27 Thread Sagi Grimberg
Changes from v0: - rebased on 4.10 - splitted inet_pton_with_scope to be a bit saner (from Chrsitoph) - converted nvme-rdma host_traddr to use a generic helper We have some places in the stack that support ipv4 and ipv6. In some cases the user configuration does not reveal which address family is

Re: [PATCH v2 net] net: solve a NAPI race

2017-02-27 Thread Eric Dumazet
On Mon, 2017-02-27 at 08:44 -0800, Eric Dumazet wrote: > // busy polling or napi_watchdog() BTW, we also can add to the beginning of busy_poll_stop() : clear_bit(NAPI_STATE_MISSED, &napi->state);

Re: [PATCH] iproute2: show network device dependency tree

2017-02-27 Thread Stephen Hemminger
On Sun, 26 Feb 2017 08:56:33 +0100 Jiri Pirko wrote: > Did you see https://github.com/jbenc/plotnetcfg ? Cool, thanks.

Re: phy deadlock -stable backport request

2017-02-27 Thread David Miller
From: Niklas Cassel Date: Mon, 27 Feb 2017 14:56:31 +0100 > I would like to request that > > commit eab127717a6af54401ba534790c793ec143cd1fc > Author: Florian Fainelli > Date: Fri Jan 20 15:31:52 2017 -0800 > > net: phy: Avoid deadlock during phy_error() ... > would be backported to sta

Re: [PATCH] iproute2: show network device dependency tree

2017-02-27 Thread Jiri Benc
On Sun, 26 Feb 2017 15:46:10 +0100, Jiri Pirko wrote: > You can also run it remotelly. Also I believe that you can catch the > state into some dump file and process it later on. Not 100% sure though. > Ccing Jiri Benc who is the original author of plotnetcfg. It produces dot (graphviz) output or j

Re: [PATCH v2 net] net: solve a NAPI race

2017-02-27 Thread Eric Dumazet
On Mon, 2017-02-27 at 11:19 -0500, David Miller wrote: > Various rules were meant to protect these sequences, and make sure > nothing like this race could happen. > > Can you show the specific sequence that fails? > > One of the basic protections is that the device IRQ is not re-enabled > until

Re: net/sctp: use-after-free in sctp_hash_transport

2017-02-27 Thread Xin Long
On Mon, Feb 27, 2017 at 11:45 PM, Andrey Konovalov wrote: > Hi, > > I've got the following error report while fuzzing the kernel with syzkaller. > > On commit e5d56efc97f8240d0b5d66c03949382b6d7e5570 (Feb 26). > > A reproducer and .config are attached. > > === > [ ERR:

Re: [PATCH v2 net] net: solve a NAPI race

2017-02-27 Thread David Miller
From: Eric Dumazet Date: Mon, 27 Feb 2017 06:21:38 -0800 > A NAPI driver normally arms the IRQ after the napi_complete_done(), > after NAPI_STATE_SCHED is cleared, so that the hard irq handler can grab > it. > > Problem is that if another point in the stack grabs NAPI_STATE_SCHED bit > while IRQ

[PATCH net] rxrpc: Fix deadlock between call creation and sendmsg/recvmsg

2017-02-27 Thread David Howells
All the routines by which rxrpc is accessed from the outside are serialised by means of the socket lock (sendmsg, recvmsg, bind, rxrpc_kernel_begin_call(), ...) and this presents a problem: (1) If a number of calls on the same socket are in the process of connection to the same peer, a maxim

BENEFIT

2017-02-27 Thread Mrs Julie Leach
You are a recipient to Mrs Julie Leach Donation of $3 million USD. Contact(julieleac...@gmail.com) for claims.

Re: [PATCH v3 20/20] checkpatch: warn for use of old PCI pool API

2017-02-27 Thread Joe Perches
On Mon, 2017-02-27 at 13:52 +0100, Romain Perier wrote: > > I also wonder if you've in fact converted all of the > > pci_pool struct and function uses why a new checkpatch > > test is needed at all. > > That's just to avoid futures mistakes/uses. When all instances and macro definitions are remo

Re: [bpf] 9d876e79df: BUG: unable to handle kernel paging request at 653a8346

2017-02-27 Thread Daniel Borkmann
On 02/27/2017 03:14 AM, kernel test robot wrote: Greetings, 0day kernel testing robot got the below dmesg and the first bad commit is https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master I'll take a look, thanks for the report!

Re: [RFC PATCH net-next 2/5] net: split skb_checksum_help

2017-02-27 Thread Davide Caratti
On Mon, 2017-01-23 at 12:59 -0800, Tom Herbert wrote: > > > > It might make sense to create some CRC helper functions, but last time > > > > I checked there are so few users of CRC in skbufs I'm not even sure > > > > that would make sense. hello Tom and David, after some (thinking + testing) time

Re: net/bridge: warning in br_fdb_find

2017-02-27 Thread Andrey Konovalov
On Mon, Feb 27, 2017 at 4:33 PM, Andrey Konovalov wrote: > Hi, > > I'm getting a huge number of warning reports while fuzzing the kernel > with syzkaller. > Unfortunately they are not reproducible. > > On commit e5d56efc97f8240d0b5d66c03949382b6d7e5570 (Feb 26). > > My .config is attached. > > WAR

Re: Extending socket timestamping API for NTP

2017-02-27 Thread Miroslav Lichvar
On Tue, Feb 07, 2017 at 02:32:04PM -0800, Willem de Bruijn wrote: > >> 4) allow sockets to use both SW and HW TX timestamping at the same time > >> > >>When using a socket which is not bound to a specific interface, it > >>would be nice to get transmit SW timestamps when HW timestamps are >

Re: [RFC PATCH net-next 2/5] net: split skb_checksum_help

2017-02-27 Thread Tom Herbert
On Mon, Feb 27, 2017 at 5:39 AM, Davide Caratti wrote: > On Mon, 2017-01-23 at 12:59 -0800, Tom Herbert wrote: >> > > > It might make sense to create some CRC helper functions, but last time >> > > > I checked there are so few users of CRC in skbufs I'm not even sure >> > > > that would make sense

Re: [PATCH v3 2/6] ARM: dts: armada-xp-98dx3236: combine dfx server nodes

2017-02-27 Thread Rob Herring
On Thu, Feb 16, 2017 at 09:50:36PM +1300, Chris Packham wrote: > Rather than having a separate node for the dfx server add a reg property > to the parent node. This give some compatibility with the Marvell > supplied SDK. > > As no upstream driver currently exists for this block and support for >

ANNOUNCE: Netdev 2.1 update Feb 27

2017-02-27 Thread Jamal Hadi Salim
A few announcements: 1) The CFP is now officially closed. Thanks to everyone who submitted. 2) We are extending the early registration to March 5. Register early so we can plan better (and so you can save some $$). https://onlineregistrations.ca/netdev21/ - hotel (If you can get the hotel chea

Re: [4.9.10] ip_route_me_harder() reading off-slab

2017-02-27 Thread Daniel J Blueman
On 17 February 2017 at 15:39, Florian Westphal wrote: > Daniel J Blueman wrote: > > [ CC nf-devel, pablo ] > >> When booting a VM in libvirt/KVM attached to a local bridge and KASAN >> enabled on 4.9.10, we see a stream of KASAN warnings about off-slab >> access [1]. >> >> Let me know if you'd li

Re: [PATCH 0/2] qed: Bug fixes

2017-02-27 Thread David Miller
From: Yuval Mintz Date: Mon, 27 Feb 2017 11:06:31 +0200 > Hi Dave, > > Patch #1 addresses a day-one race which is dependent on the number of Vfs > [I.e., more child VFs from a single PF make it more probable]. > Patch #2 corrects a race that got introduced in the last set of fixes for > qed, one

phy deadlock -stable backport request

2017-02-27 Thread Niklas Cassel
Hello I would like to request that commit eab127717a6af54401ba534790c793ec143cd1fc Author: Florian Fainelli Date: Fri Jan 20 15:31:52 2017 -0800 net: phy: Avoid deadlock during phy_error() phy_error() is called in the PHY state machine workqueue context, and calls phy_trigger_

Re: [PATCH 0/6] Netfilter fixes for net

2017-02-27 Thread David Miller
From: Pablo Neira Ayuso Date: Mon, 27 Feb 2017 12:35:36 +0100 > The following patchset contains netfilter fixes for you net tree, > they are: > > 1) Missing ct zone size in the nft_ct initialization path, patch >from Florian Westphal. > > 2) Two patches for netfilter uapi headers, one to re

Re: [PATCH net] net: solve a NAPI race

2017-02-27 Thread Eric Dumazet
On Sun, 2017-02-26 at 19:31 -0800, Eric Dumazet wrote: > From: Eric Dumazet > > While playing with mlx4 hardware timestamping of RX packets, I found > that some packets were received by TCP stack with a ~200 ms delay... > > Since the timestamp was provided by the NIC, and my probe was added > in

[PATCH net] net: route: add missing nla_policy entry for RTA_MARK attribute

2017-02-27 Thread Liping Zhang
From: Liping Zhang This will add stricter validating for RTA_MARK attribute. Signed-off-by: Liping Zhang --- net/ipv4/fib_frontend.c | 1 + net/ipv6/route.c| 1 + 2 files changed, 2 insertions(+) diff --git a/net/ipv4/fib_frontend.c b/net/ipv4/fib_frontend.c index b39a791..42bfd08 100

Re: [PATCH v3 20/20] checkpatch: warn for use of old PCI pool API

2017-02-27 Thread Romain Perier
Hello, Le 27/02/2017 à 13:38, Joe Perches a écrit : > On Mon, 2017-02-27 at 13:26 +0100, Romain Perier wrote: >> Hello, >> >> >> Le 27/02/2017 à 12:22, Peter Senna Tschudin a écrit : >>> On Sun, Feb 26, 2017 at 08:24:25PM +0100, Romain Perier wrote: pci_pool_*() functions should be replaced

Re: [PATCH v3 20/20] checkpatch: warn for use of old PCI pool API

2017-02-27 Thread Joe Perches
On Mon, 2017-02-27 at 13:26 +0100, Romain Perier wrote: > Hello, > > > Le 27/02/2017 à 12:22, Peter Senna Tschudin a écrit : > > On Sun, Feb 26, 2017 at 08:24:25PM +0100, Romain Perier wrote: > > > pci_pool_*() functions should be replaced by the corresponding functions > > > in the DMA pool API.

Re: [PATCH 7/7] net: stmmac: dwc-qos: Add Tegra186 support

2017-02-27 Thread Mikko Perttunen
On 23.02.2017 19:24, Thierry Reding wrote: From: Thierry Reding The NVIDIA Tegra186 SoC contains an instance of the Synopsys DWC ethernet QOS IP core. The binding that it uses is slightly different from existing ones because of the integration (clocks, resets, ...). Signed-off-by: Thierry Redi

Re: [PATCH v3 20/20] checkpatch: warn for use of old PCI pool API

2017-02-27 Thread Romain Perier
Hello, Le 27/02/2017 à 12:22, Peter Senna Tschudin a écrit : > On Sun, Feb 26, 2017 at 08:24:25PM +0100, Romain Perier wrote: >> pci_pool_*() functions should be replaced by the corresponding functions >> in the DMA pool API. This adds support to check for use of these pci >> functions and displa

Re: [PATCH v2 net-next 5/6] drivers: net: xgene-v2: Add transmit and receive

2017-02-27 Thread kbuild test robot
Hi Iyappan, [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Iyappan-Subramanian/drivers-net-xgene-v2-Add-RGMII-based-1G-driver/20170227-182414 config: x86_64-allmodconfig (attached as .config) compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901

Re: [PATCH net] xfrm: provide correct dst in xfrm_neigh_lookup

2017-02-27 Thread Steffen Klassert
On Sun, Feb 26, 2017 at 09:35:48PM -0500, David Miller wrote: > From: Julian Anastasov > Date: Sat, 25 Feb 2017 17:57:43 +0200 > > > Fix xfrm_neigh_lookup to provide dst->path to the > > neigh_lookup dst_ops method. > > > > When skb is provided, the IP address in packet should already > > match

Re: [PATCH 2/2] iproute2: add support for invisible qdisc dumping

2017-02-27 Thread Phil Sutter
On Sat, Feb 25, 2017 at 10:29:17PM +0100, Jiri Kosina wrote: > From: Jiri Kosina > > Support the new TCA_DUMP_INVISIBLE netlink attribute that allows asking > kernel to perform 'full qdisc dump', as for historical reasons some of the > default qdiscs are being hidden by the kernel. > > The com

Re: [PATCH v3 20/20] checkpatch: warn for use of old PCI pool API

2017-02-27 Thread Joe Perches
On Mon, 2017-02-27 at 12:22 +0100, Peter Senna Tschudin wrote: > On Sun, Feb 26, 2017 at 08:24:25PM +0100, Romain Perier wrote: > > pci_pool_*() functions should be replaced by the corresponding functions > > in the DMA pool API. This adds support to check for use of these pci > > functions and dis

Re: [PATCH 6/7] net: stmmac: dwc-qos: Split out ->probe() and ->remove()

2017-02-27 Thread Mikko Perttunen
On 23.02.2017 19:24, Thierry Reding wrote: From: Thierry Reding Split out the binding specific parts of ->probe() and ->remove() to enable the driver to support variants of the binding. This is useful in order to keep backwards-compatibility while making it easy for a sub- driver to deal only w

[PATCH 2/6] uapi: stop including linux/sysctl.h in uapi/linux/netfilter.h

2017-02-27 Thread Pablo Neira Ayuso
From: "Dmitry V. Levin" linux/netfilter.h is the last uapi header file that includes linux/sysctl.h but it does not depend on definitions provided by this essentially dead header file. Suggested-by: Eric W. Biederman Signed-off-by: Dmitry V. Levin Signed-off-by: Pablo Neira Ayuso --- include

[PATCH 3/6] uapi: fix linux/netfilter/xt_hashlimit.h userspace compilation error

2017-02-27 Thread Pablo Neira Ayuso
From: "Dmitry V. Levin" Include like some of uapi/linux/netfilter/xt_*.h headers do to fix the following linux/netfilter/xt_hashlimit.h userspace compilation error: /usr/include/linux/netfilter/xt_hashlimit.h:90:12: error: 'NAME_MAX' undeclared here (not in a function) char name[NAME_MAX];

[PATCH 4/6] netfilter: nf_ct_expect: nf_ct_expect_related_report(): Return zero on success.

2017-02-27 Thread Pablo Neira Ayuso
From: Jarno Rajahalme Commit 4dee62b1b9b4 ("netfilter: nf_ct_expect: nf_ct_expect_insert() returns void") inadvertently changed the successful return value of nf_ct_expect_related_report() from 0 to 1, which caused openvswitch conntrack integration fail in FTP test cases. Fix this by always retu

  1   2   >