On Wed, Apr 5, 2017 at 11:57 AM, Christoph Hellwig wrote:
> On Tue, Apr 04, 2017 at 02:59:06PM +0530, dev.srinivas...@gmail.com wrote:
>> From: Thanneeru Srinivasulu
>>
>> Remove deprecated pci_enable_msix API in favour of it's
>> successor pci_alloc_irq_vectors.
>>
>> Signed-off-by: Thanneeru Sr
On Tue, 2017-04-04 at 23:02 -0700, Florian Fainelli wrote:
> We don't necessarily have a phydev attached when using NC-SI, so it was
> > easier to have the core code path not have to go fishing for those
> > settings in different places based on whether we're using NC-SI or not.
>
> Oh right, I m
On Tue, Apr 04, 2017 at 02:59:06PM +0530, dev.srinivas...@gmail.com wrote:
> From: Thanneeru Srinivasulu
>
> Remove deprecated pci_enable_msix API in favour of it's
> successor pci_alloc_irq_vectors.
>
> Signed-off-by: Thanneeru Srinivasulu
> Signed-off-by: Sunil Goutham
Looks good.
Are you
On Tue, 2017-04-04 at 22:25 -0700, Cong Wang wrote:
> On Tue, Apr 4, 2017 at 8:20 PM, Mike Galbraith wrote:
> > - while (some_qdisc_is_busy(dev))
> > - yield();
> > + swait_event_timeout(swait,
> > !some_qdisc_is_busy(dev), 1);
> > }
>
> I don't
On 04/04/2017 10:53 PM, Benjamin Herrenschmidt wrote:
> On Tue, 2017-04-04 at 21:21 -0700, Florian Fainelli wrote:
>>
>> This looks pretty good to me, two minor things:
>>
>> - most drivers keep track of the old status/duplex/pause/link variables
>> instead of the current one which is already ava
On Tue, 2017-04-04 at 22:19 -0700, Cong Wang wrote:
> On Tue, Apr 4, 2017 at 8:55 PM, Mike Galbraith wrote:
> > That won't help, cond_resched() has the same impact upon a lone
> > SCHED_FIFO task as yield() does.. none.
>
> Hmm? In the comment you quote:
>
> * If you want to use yield() to wai
On Tue, 2017-04-04 at 21:21 -0700, Florian Fainelli wrote:
>
> This looks pretty good to me, two minor things:
>
> - most drivers keep track of the old status/duplex/pause/link variables
> instead of the current one which is already available within struct
> phy_device, any particular reason for
On Wed, Apr 5, 2017 at 3:17 PM, Florian Fainelli wrote:
>
>
> On 04/04/2017 10:33 PM, Joel Stanley wrote:
>> This device is a single-port RGMII 10/100/1000BASE-T PHY with EEE & WOL.
>
> This looks good, although Rafal did beat you to it:
>
> 0fc9ae107669760c2a8658cb5b5876dbe525e08d ("net: phy: bro
On 04/04/2017 10:33 PM, Joel Stanley wrote:
> This device is a single-port RGMII 10/100/1000BASE-T PHY with EEE & WOL.
This looks good, although Rafal did beat you to it:
0fc9ae107669760c2a8658cb5b5876dbe525e08d ("net: phy: broadcom: add
support for BCM54210E")
--
Florian
This device is a single-port RGMII 10/100/1000BASE-T PHY with EEE & WOL.
Signed-off-by: Joel Stanley
---
drivers/net/phy/broadcom.c | 13 +
include/linux/brcmphy.h| 2 ++
2 files changed, 15 insertions(+)
diff --git a/drivers/net/phy/broadcom.c b/drivers/net/phy/broadcom.c
inde
On Tue, Apr 4, 2017 at 8:20 PM, Mike Galbraith wrote:
> - while (some_qdisc_is_busy(dev))
> - yield();
> + swait_event_timeout(swait, !some_qdisc_is_busy(dev), 1);
> }
I don't see why this is an improvement even if I don't care about the
hardcode
On Tue, Apr 4, 2017 at 8:55 PM, Mike Galbraith wrote:
> On Tue, 2017-04-04 at 18:52 -0700, Cong Wang wrote:
>
>> diff --git a/net/sched/sch_generic.c b/net/sched/sch_generic.c
>> index 1a2f9e9..4725d2f 100644
>> --- a/net/sched/sch_generic.c
>> +++ b/net/sched/sch_generic.c
>> @@ -925,7 +925,7 @@
Prepare to mark sensitive kernel structures for randomization by making
sure they're using designated initializers. These were identified during
allyesconfig builds of x86, arm, and arm64, and the initializer fixes
were extracted from grsecurity. In this case, NULL initialize with { }
instead of un
Salut Benjamin,
Le 04/04/17 à 19:28, Benjamin Herrenschmidt a écrit :
> This is version 2 of the first batch of updates to the
> ftgmac100 driver.
>
> Essentially:
>
> - A few misc cleanups
> - Fixing link speed & duplex handling (including dealing with
>an Aspeed requirement to double res
David Miller writes:
> From: Kalle Valo
> Date: Tue, 04 Apr 2017 20:48:35 +0300
>
>> David Miller writes:
>>
>>> From: Kalle Valo
>>> Date: Mon, 03 Apr 2017 14:26:10 +0300
>>>
here few really small fixes. I'm hoping this to be the last pull request
for 4.11.
Please let me
On Tue, 2017-04-04 at 18:52 -0700, Cong Wang wrote:
> diff --git a/net/sched/sch_generic.c b/net/sched/sch_generic.c
> index 1a2f9e9..4725d2f 100644
> --- a/net/sched/sch_generic.c
> +++ b/net/sched/sch_generic.c
> @@ -925,7 +925,7 @@ void dev_deactivate_many(struct list_head *head)
> /* Wai
Hi Kees,
On Tue, Apr 04, 2017 at 03:17:57PM -0700, Kees Cook wrote:
> On Tue, Apr 4, 2017 at 3:08 PM, Tycho Andersen wrote:
> > The goal of this patch is to protect the JIT against an attacker with a
> > write-in-memory primitive. The JIT allocates a buffer which will eventually
> > be marked +x,
The divisions they represent are not particularily meaningful
and things are going to be moving around with upcoming changes
making these comments more a burden than anything else.
Signed-off-by: Benjamin Herrenschmidt
---
drivers/net/ethernet/faraday/ftgmac100.c | 42 ---
On Tue, 2017-04-04 at 15:39 -0700, Cong Wang wrote:
> Thanks for the report! Looks like a quick solution here is to replace
> this yield() with cond_resched(), it is harder to really wait for
> all qdisc's to transmit all packets.
No, cond_resched() won't help. What I did is below, but I suspect
On Tue, 2017-04-04 at 18:11 -0700, Cong Wang wrote:
> On Tue, Apr 4, 2017 at 11:51 AM, Eric Dumazet wrote:
> > On Tue, Apr 4, 2017 at 7:50 AM, Andrey Konovalov
> > wrote:
> >>
> >> Hi,
> >>
> >> I've got the following error report while fuzzing the kernel with
> >> syzkaller.
> >>
> >> On commi
The link monitoring and error handling code will have to
redo the ring inits and HW setup so move the code out of
ftgmac100_open() into a dedicated function.
This forces a bit of re-ordering of ftgmac100_open() but
nothing dramatic.
Signed-off-by: Benjamin Herrenschmidt
---
drivers/net/ethernet
The interrupt isn't shared, so this will keep it masked
until we have the HW in a known sane state.
Signed-off-by: Benjamin Herrenschmidt
---
drivers/net/ethernet/faraday/ftgmac100.c | 19 ++-
1 file changed, 10 insertions(+), 9 deletions(-)
diff --git a/drivers/net/ethernet/far
Reorder the fields in struct ftgmac in slightly more logical
groups. Will make more sense as I add/remove some.
No code change.
Signed-off-by: Benjamin Herrenschmidt
---
drivers/net/ethernet/faraday/ftgmac100.c | 19 ---
1 file changed, 12 insertions(+), 7 deletions(-)
diff --g
The interrupt is neither enabled nor registered when the interface
isn't running (regardless of whether we use nc-si or not) so the
test isn't useful.
Signed-off-by: Benjamin Herrenschmidt
---
drivers/net/ethernet/faraday/ftgmac100.c | 11 +++
1 file changed, 3 insertions(+), 8 deletions
Link speed changes require a full HW reset. This isn't done
properly at the moment. It will involve delays and thus isn't
suitable to do from the link poll callback.
So let's create a reset_task that we can queue up when the
link changes. It will be useful for various cases of error
handling as we
Rather than probe/remove
Signed-off-by: Benjamin Herrenschmidt
---
drivers/net/ethernet/faraday/ftgmac100.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/faraday/ftgmac100.c
b/drivers/net/ethernet/faraday/ftgmac100.c
index 0d0576f..bb444d2 1006
The HW requires a full MAC reset when changing the speed.
Additionally the Aspeed documentation spells out that the
MAC needs to be reset twice with a 10us interval.
We thus move the speed setting and top level reset code
into a new ftgmac100_reset_and_config_mac() function which
handles both. Mo
First, don't look at the interrupt status in the poll loop
to decide what to poll. It's wrong. If we have run out of
budget, we may still have RX packets to unqueue but no more
RX interrupt pending.
So instead move the code looking at the interrupt status
into the interrupt handler where it belong
Currently, a single function is used to allocate the rings
themselves, initialize them, populate the rx ring, and
allocate the rx buffers. The same happens on free.
This splits them into separate functions. This will be
useful when properly implementing re-initialization on
link changes and error
Keep track of both the current speed and duplex settings
instead of only speed and properly apply the duplex setting
to the HW.
This reworks the adjust_link() function to also avoid trying
to reconfigure the HW when there is no link and to display
the link state to the user.
Signed-off-by: Benjam
There's a placeholder already for the irq, use it
Signed-off-by: Benjamin Herrenschmidt
---
drivers/net/ethernet/faraday/ftgmac100.c | 13 ++---
1 file changed, 6 insertions(+), 7 deletions(-)
diff --git a/drivers/net/ethernet/faraday/ftgmac100.c
b/drivers/net/ethernet/faraday/ftgmac10
It's not used in any meaningful way
Signed-off-by: Benjamin Herrenschmidt
---
drivers/net/ethernet/faraday/ftgmac100.c | 7 ---
1 file changed, 7 deletions(-)
diff --git a/drivers/net/ethernet/faraday/ftgmac100.c
b/drivers/net/ethernet/faraday/ftgmac100.c
index 02e0534..cc2271b 100644
---
This is version 2 of the first batch of updates to the
ftgmac100 driver.
Essentially:
- A few misc cleanups
- Fixing link speed & duplex handling (including dealing with
an Aspeed requirement to double reset the controller when
the speed changes)
- And addition of a reset task workqueue
Detection of watchdog timeout of Octeon cores is flawed and susceptible to
false alarms. Refactor by removing the detection code, and in its place,
leverage existing code that monitors for an indication from the NIC
firmware that an Octeon core crashed; expand the meaning of the indication
to "an
yield() should be rendered dead, according to Mike.
It is hard to wait properly for all qdisc's to transmit
all packets. So just keep the original logic.
Reported-by: Mike Galbraith
Signed-off-by: Cong Wang
---
net/sched/sch_generic.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
Dmitry reported a crash when injecting faults in
attach_one_default_qdisc() and dev->qdisc is still
a noop_disc, the check before qdisc_hash_add() fails
to catch it because it tests NULL. We should test
against noop_qdisc since it is the default qdisc
at this point.
Fixes: 59cc1f61f09c ("net: sche
With GCC 6.3, we can get the following warning:
drivers/net/usb/usbnet.c:85:19: warning: 'driver_name' defined but not
used [-Wunused-const-variable=]
static const char driver_name [] = "usbnet";
^~~
Signed-off-by: Florian Fainelli
---
drivers/net/usb/usbnet.c | 2 --
On Tue, Apr 4, 2017 at 11:51 AM, Eric Dumazet wrote:
> On Tue, Apr 4, 2017 at 7:50 AM, Andrey Konovalov
> wrote:
>>
>> Hi,
>>
>> I've got the following error report while fuzzing the kernel with syzkaller.
>>
>> On commit a71c9a1c779f2499fb2afc0553e543f18aff6edf (4.11-rc5).
>>
>> Unfortunately i
Support setting link speed and autonegotiation through
set_link_ksettings() ethtool op. If the port is reconfigured
in incompatible way and reboot is required the netdev will get
unregistered and not come back until user reboots the system.
Signed-off-by: Jakub Kicinski
Reviewed-by: Simon Horman
On the PF prefer the link speed value provided by the NSP.
Refresh port table if needed.
Signed-off-by: Jakub Kicinski
Reviewed-by: Simon Horman
---
drivers/net/ethernet/netronome/nfp/nfp_net_ethtool.c | 11 +++
1 file changed, 11 insertions(+)
diff --git a/drivers/net/ethernet/netrono
We will want to unregister netdevs after their port got reconfigured.
For that we need to make sure manipulations of port list from the
port reconfiguration flow will not race with driver's .remove()
callback.
Signed-off-by: Jakub Kicinski
Reviewed-by: Simon Horman
---
drivers/net/ethernet/netr
Read link speed from the BAR. This provides very basic information
and works for both PFs and VFs.
Signed-off-by: Jakub Kicinski
Reviewed-by: Simon Horman
---
drivers/net/ethernet/netronome/nfp/nfp_net_ctrl.h | 13 ++
.../net/ethernet/netronome/nfp/nfp_net_ethtool.c | 49 +++
NSP commands may be slow to respond, we should try to avoid doing
a command-per-item when user requested to change multiple parameters
for instance with an ethtool .set_settings() command.
Introduce a way of internal NSP code to carry state in NSP structure
and add start/finish calls to perform th
For caching link settings - remember if we have seen link events
since the last time the eth_port information was refreshed.
Signed-off-by: Jakub Kicinski
Reviewed-by: Simon Horman
---
drivers/net/ethernet/netronome/nfp/nfp_net.h| 6 +-
drivers/net/ethernet/netronome/nfp/nfp_net_co
Make NSP port structure a union to simplify accessing the fields
from generic macros.
Signed-off-by: Jakub Kicinski
Reviewed-by: Simon Horman
---
.../ethernet/netronome/nfp/nfpcore/nfp_nsp_eth.c | 38 ++
1 file changed, 25 insertions(+), 13 deletions(-)
diff --git a/drive
Allow NSP to set option code even when error is reported. This provides
a way for NSP to give user more precise information about why command
failed.
Signed-off-by: Jakub Kicinski
Reviewed-by: Simon Horman
---
.../net/ethernet/netronome/nfp/nfpcore/nfp_nsp.c | 37 +-
1 fi
Add NSP backend for upcoming link configuration operations.
Signed-off-by: Jakub Kicinski
Reviewed-by: Simon Horman
---
.../net/ethernet/netronome/nfp/nfpcore/nfp_nsp.c | 6 +-
.../net/ethernet/netronome/nfp/nfpcore/nfp_nsp.h | 7 +
.../ethernet/netronome/nfp/nfpcore/nfp_nsp_eth.c | 1
Service process firmware provides us with information about media
and interface (SFP module) plugged in, translate that to Linux's
PORT_* defines and report via ethtool.
Signed-off-by: Jakub Kicinski
Reviewed-by: Simon Horman
---
.../net/ethernet/netronome/nfp/nfp_net_ethtool.c | 1 +
.../et
Hi!
This series adds support for getting and setting link settings
via the (moderately) new ethtool ksettings ops.
First patch introduces minimal speed and duplex reporting using
the information directly provided in PCI BAR0 memory.
Next few changes deal with the need to refresh port state read
We will need a way of refreshing port state for link settings
get/set. For get we need to refresh port speed and type.
When settings are changed the reconfiguration may require
reboot before it's effective. Unregister netdevs affected
by reconfiguration from a workqueue.
Signed-off-by: Jakub Ki
After port reconfiguration (port split, media type change)
firmware will continue to report old configuration until
reboot. NSP will inform us that reconfiguration is pending.
To avoid user confusion refuse to spawn netdevs until the
new configuration is applied (reboot).
We need to split the net
We will soon add more NSP commands and structure definitions.
Move all high-level NSP header contents to a common nfp_nsp.h file.
Right now it mostly boils down to renaming nfp_nsp_eth.h and
moving some functions from nfp.h there.
Signed-off-by: Jakub Kicinski
Reviewed-by: Simon Horman
---
driv
NSP ABI version 0.17 is exposing the autonegotiation settings.
Report whether autoneg is on via ethtool.
Signed-off-by: Jakub Kicinski
Reviewed-by: Simon Horman
---
drivers/net/ethernet/netronome/nfp/nfp_net_ethtool.c | 4
drivers/net/ethernet/netronome/nfp/nfpcore/nfp_nsp_eth.c | 2
We should unregister the net_device first, before we give back
our reference on xdp_prog. Otherwise xdp_prog may be freed
before .ndo_stop() disabled the datapath. Found by code inspection.
Fixes: ecd63a0217d5 ("nfp: add XDP support in the driver")
Signed-off-by: Jakub Kicinski
Reviewed-by: Sim
> -Original Message-
> From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org] On
> Behalf Of Stefan Assmann
> Sent: Tuesday, April 04, 2017 12:52 PM
> To: Or Gerlitz
> Cc: intel-wired-...@lists.osuosl.org; Linux Netdev List
> ; David Miller ; Kirsher,
> Jeffrey T
> Sub
On Sat, Apr 1, 2017 at 9:28 PM, Mike Galbraith wrote:
> Greetings network wizards,
>
> Quoting kernel/sched/core.c:
> /**
> * yield - yield the current processor to other threads.
> *
> * Do not ever use this function, there's a 99% chance you're doing it wrong.
> *
> * The scheduler is at al
On Tue, Apr 4, 2017 at 3:08 PM, Tycho Andersen wrote:
> The goal of this patch is to protect the JIT against an attacker with a
> write-in-memory primitive. The JIT allocates a buffer which will eventually
> be marked +x, so we need to make sure that what was written to this buffer
> is what was i
Signed-off-by: Michael Chan
---
drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 16
drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.h | 1 +
2 files changed, 17 insertions(+)
diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c
b/drivers/net/ethernet/broadcom/bnx
And add functions to set and free magic packet filter.
Signed-off-by: Michael Chan
---
drivers/net/ethernet/broadcom/bnxt/bnxt.c | 32 +++
drivers/net/ethernet/broadcom/bnxt/bnxt.h | 2 ++
drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 26 +++
Features added include WoL and selftest.
Signed-off-by: Deepak Khungar
Signed-off-by: Michael Chan
---
drivers/net/ethernet/broadcom/bnxt/bnxt_hsi.h | 325 +---
drivers/net/ethernet/broadcom/bnxt/bnxt_sriov.c | 8 +-
drivers/net/ethernet/broadcom/bnxt/bnxt_sriov.h | 1
Signed-off-by: Michael Chan
---
drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 32 ++-
1 file changed, 31 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c
b/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c
index dde3e21..848ec
It is necessary to disable autoneg before enabling PHY loopback,
otherwise link won't come up.
Signed-off-by: Michael Chan
---
drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 62 ++-
1 file changed, 60 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/broad
No offload is performed on the XDP_TX ring so we can use the short TX
BDs. This has the effect of doubling the size of the XDP TX ring so
that it now matches the size of the rx ring by default.
Signed-off-by: Michael Chan
---
drivers/net/ethernet/broadcom/bnxt/bnxt_xdp.c | 16 ++--
The current code enables up to the maximum MSIX vectors in the PCIE
config space without considering the max completion rings available.
An MSIX vector is only useful when it has an associated completion
ring, so it is better to cap it.
Signed-off-by: Michael Chan
---
drivers/net/ethernet/broadc
The mac loopback self test operates in polling mode. To support that,
we need to add functions to open and close the NIC half way. The half
open mode allows the rings to operate without IRQ and NAPI. We
use the XDP transmit function to send the loopback packet.
Signed-off-by: Michael Chan
---
Add code to driver probe function to check if the device is WoL capable
and if Magic packet WoL filter is currently set.
Signed-off-by: Michael Chan
---
drivers/net/ethernet/broadcom/bnxt/bnxt.c | 43 +++
drivers/net/ethernet/broadcom/bnxt/bnxt.h | 4 +++
2 files cha
Main changes are to add WoL and selftest features, optimize XDP_TX by
using short BDs, and to cap the usage of MSIX.
Michael Chan (12):
bnxt_en: Update firmware interface spec to 1.7.6.2.
bnxt_en: Add basic WoL infrastructure.
bnxt_en: Add pci shutdown method.
bnxt_en: Add ethtool get_wol
Add the basic infrastructure and only firmware tests initially.
Signed-off-by: Michael Chan
---
drivers/net/ethernet/broadcom/bnxt/bnxt.c | 2 +
drivers/net/ethernet/broadcom/bnxt/bnxt.h | 13 ++-
drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 136 +-
Add suspend/resume callbacks using the newer dev_pm_ops method.
Signed-off-by: Michael Chan
---
drivers/net/ethernet/broadcom/bnxt/bnxt.c | 57 +++
1 file changed, 57 insertions(+)
diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c
b/drivers/net/ethernet/broadco
Add pci shutdown method to put device in the proper WoL and power state.
Signed-off-by: Michael Chan
---
drivers/net/ethernet/broadcom/bnxt/bnxt.c | 31 +++
1 file changed, 31 insertions(+)
diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c
b/drivers/net/etherne
The goal of this patch is to protect the JIT against an attacker with a
write-in-memory primitive. The JIT allocates a buffer which will eventually
be marked +x, so we need to make sure that what was written to this buffer
is what was intended.
We acheive this by building a hash of the instruction
On Tue, 28 Mar 2017 23:19:35 +0200
Phil Sutter wrote:
> This series addresses some minor nits with link type specific help
> texts:
>
> * Unify coding style of print_help() callbacks (or the functions they
> call.
>
> * Unify output as much as possible for a common look and feel.
>
> * Make
On Tue, Apr 04, 2017 at 01:39:55PM +0800, Xin Long wrote:
> This patch is almost to revert commit 02f3d4ce9e81 ("sctp: Adjust PMTU
> updates to accomodate route invalidation."). As t->asoc can't be NULL
> in sctp_transport_update_pmtu, it could get sk from asoc, and no need
> to pass sk into that f
On Tue, 28 Mar 2017 17:56:48 +0200
Sabrina Dubroca wrote:
> Signed-off-by: Phil Sutter
> Signed-off-by: Sabrina Dubroca
Applied
On Wed, 22 Mar 2017 14:00:31 -0400
Roman Mashak wrote:
> Signed-off-by: Roman Mashak
Makes sense. Applied
On Sun, 26 Mar 2017 21:11:14 +0200
Alexander Alemayhu wrote:
> While generating PDFs from the man pages, I saw the warning below from
> several files. Compared the tc-matchall.8 with bridge.8 and used .RI
> instead of .R. It should have no effect on the man page rendering.
>
> `R' is a strin
On Sat, 1 Apr 2017 04:31:57 +0300
Andrei Vagin wrote:
> From: Andrei Vagin
>
> A name of an abstract socket can contain zero characters.
> Now we replace only the first character. If a name contains more
> than one zero character, the ss tool shows only a part of the name:
> u_str UNCONN0
On Tue, 4 Apr 2017 17:07:31 -0400
David Ahern wrote:
> On 3/23/17 10:51 PM, David Ahern wrote:
> > Currently, ip netconf only shows data for ipv4 and ipv6 for dumps
> > and just ipv4 for device requests. Improve the user experience by
> > using the new kernel patch to dump all address families th
People are using bonding over Infiniband IPoIB connections, and who knows
what else. Infiniband has a hardware address length of 20 octets
(INFINIBAND_ALEN), and the network core defines a MAX_ADDR_LEN of 32.
Various places in the bonding code are currently hard-wired to 6 octets
(ETH_ALEN), such a
Currently the reordering SNMP counters only increase if a connection
sees a higher degree then it has previously seen. It ignores if the
reordering degree is not greater than the default system threshold.
This significantly under-counts the number of reordering events
and falsely convey that reorde
The lost retransmit SNMP stat is under-counting retransmission
that uses segment offloading. This patch fixes that so all
retransmission related SNMP counters are consistent.
Fixes: 10d3be569243 ("tcp-tso: do not split TSO packets at retransmit time")
Signed-off-by: Yuchung Cheng
Signed-off-by: E
On Wed, Apr 05, 2017 at 01:29:19AM +0800, Xin Long wrote:
> On Tue, Apr 4, 2017 at 9:28 PM, Andrey Konovalov
> wrote:
> > Hi,
> >
> > I've got the following error report while fuzzing the kernel with syzkaller.
> >
> > On commit a71c9a1c779f2499fb2afc0553e543f18aff6edf (4.11-rc5).
> >
> > A repro
On 04/04/2017 08:33 PM, Aaron Conole wrote:
The eBPF framework is used for more than just socket level filtering. It
can also provide tracing, and even change the way packets coming into the
system look. Most of the eBPF callable symbols are available to non-gpl
programs, and this includes help
On 3/23/17 10:51 PM, David Ahern wrote:
> Currently, ip netconf only shows data for ipv4 and ipv6 for dumps
> and just ipv4 for device requests. Improve the user experience by
> using the new kernel patch to dump all address families that have
> registered. For example, if mpls_router module is loa
Begin forwarded message:
Date: Fri, 31 Mar 2017 02:54:55 +
From: bugzilla-dae...@bugzilla.kernel.org
To: step...@networkplumber.org
Subject: [Bug 195169] New: ip_route_input_noref panic
https://bugzilla.kernel.org/show_bug.cgi?id=195169
Bug ID: 195169
Summary: ip_ro
On 04.04.2017 18:56, Or Gerlitz wrote:
> On Tue, Apr 4, 2017 at 5:34 PM, Stefan Assmann wrote:
>> The client interface is meant for X722 iWARP support. Modprobing i40iw
>> on systems with X710/XL710 NICs currently may crash the system.
>
> just curious may or crash? and why?
The backtrace I got
The client interface is only intended for use on devices that support
iWarp). Only register with the client if this is the case.
This fixes a panic when loading i40iw on X710 devices.
Signed-off-by: Mitch Williams
Reported-by: Stefan Assmann
---
drivers/net/ethernet/intel/i40e/i40e_main.c | 19
On Tue, Apr 04, 2017 at 06:54:27PM +0100, Joao Pinto wrote:
[...]
> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
[...]
> @@ -1259,7 +1317,6 @@ static int init_dma_tx_desc_rings(struct net_device
> *dev)
> /* TX
On Tue, Apr 04, 2017 at 06:54:25PM +0100, Joao Pinto wrote:
[...]
> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
[...]
> @@ -3402,6 +3474,9 @@ static irqreturn_t stmmac_interrupt(int irq, void
> *dev_id)
>
> i
On Tue, Apr 04, 2017 at 06:54:26PM +0100, Joao Pinto wrote:
> This patch adds the structure stmmac_tx_queue which contains
> tx queues specific data (previously in stmmac_priv).
>
> Signed-off-by: Joao Pinto
> ---
> drivers/net/ethernet/stmicro/stmmac/chain_mode.c | 38 +-
> drivers/net/ethern
One more nit: subject should say "... for RX" for consistency with patch
3/4.
Thierry
signature.asc
Description: PGP signature
On Tue, Apr 04, 2017 at 06:54:25PM +0100, Joao Pinto wrote:
[...]
> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
[...]
> static void stmmac_display_rx_rings(struct stmmac_priv *priv)
> {
> + u32 rx_cnt = priv->plat->rx_q
On Tue, Apr 04, 2017 at 06:54:24PM +0100, Joao Pinto wrote:
> This patch breaks several functions into RX and TX scopes, which
> will be useful when adding multiple buffers mechanism.
>
> Signed-off-by: Joao Pinto
> ---
> drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 350
> +++
On Tue, Apr 4, 2017 at 7:50 AM, Andrey Konovalov wrote:
>
> Hi,
>
> I've got the following error report while fuzzing the kernel with syzkaller.
>
> On commit a71c9a1c779f2499fb2afc0553e543f18aff6edf (4.11-rc5).
>
> Unfortunately it's not reproducible.
>
> =
From: Kalle Valo
Date: Tue, 04 Apr 2017 20:48:35 +0300
> David Miller writes:
>
>> From: Kalle Valo
>> Date: Mon, 03 Apr 2017 14:26:10 +0300
>>
>>> here few really small fixes. I'm hoping this to be the last pull request
>>> for 4.11.
>>>
>>> Please let me if there are any problems.
>>
>> Pul
The eBPF framework is used for more than just socket level filtering. It
can also provide tracing, and even change the way packets coming into the
system look. Most of the eBPF callable symbols are available to non-gpl
programs, and this includes helper functions which modify packets. This
allow
On 04/04/2017 11:34 AM, Marc Kleine-Budde wrote:
> On 03/24/2017 06:20 PM, Akshay Bhat wrote:
>> Hi Marc,
>>
>> On 03/17/2017 05:10 PM, Akshay Bhat wrote:
>>> This patch adds support for the Holt HI-311x CAN controller. The HI311x
>>> CAN controller is capable of transmitting and receiving standa
On Wed, Mar 29, 2017 at 03:25:17AM +0530, simran singhal wrote:
> For string without format specifiers, use seq_puts(). For
> seq_printf("\n"), use seq_putc('\n').
>
> Signed-off-by: simran singhal
> ---
> net/netfilter/ipvs/ip_vs_ctl.c | 8
Simran, I would be happy to pick up
On Tue, Apr 04, 2017 at 01:41:11PM -0400, Simon Horman wrote:
> On Wed, Mar 29, 2017 at 03:45:01PM +0530, Arushi Singhal wrote:
> > Replace explicit NULL comparison with ! operator to simplify code.
> >
> > Signed-off-by: Arushi Singhal
> > ---
> > net/netfilter/ipvs/ip_vs_ctl.c | 8 ++-
This patch adds multiple buffers to stmmac in a more fragmented
way, in order to make problem debug easier.
I would kindly request to people to test this patch in their HWs in
order to check if everything's functional. Thank you.
Joao Pinto (4):
net: stmmac: break some functions into RX and TX
1 - 100 of 166 matches
Mail list logo