Re: [PATCH] net: ipv6: Truncate single route when it doesn't fit into dump buffer.

2017-05-12 Thread David Ahern
On 5/12/17 3:41 PM, Jan Moskyto Matejka wrote: > On Fri, May 12, 2017 at 10:26:08AM -0700, David Ahern wrote: >> On 5/12/17 8:24 AM, David Miller wrote: >>> From: Jan Moskyto Matejka >>> Date: Fri, 12 May 2017 13:15:10 +0200 >>> -int rt6_dump_route(struct rt6_info *rt, void *p_arg); +int

[PATCH 1/3] bpf: Use 1<<16 as ceiling for immediate alignment in verifier.

2017-05-12 Thread David Miller
If we use 1<<31, then sequences like: R1 = 0 R1 <<= 2 do silly things. Examples of this actually exist in the MAP tests of test_verifier.c Update test_align.c expectation strings. Signed-off-by: David S. Miller --- kernel/bpf/verifier.c| 2 +- tools/test

[PATCH 3/3] bpf: Update MAP test_verifier.c tests wrt. alignment.

2017-05-12 Thread David Miller
Now that we perform proper alignment tracking of MAP accesses in the verifier, most of the MAP tests in test_verifier.c no longer need the special F_NEEDS_EFFICIENT_UNALIGNED_ACCESS flag or can trivially be made to not need it. struct test_val is an integer count followed by an array of integers.

[PATCH 2/3] bpf: Track alignment of MAP pointers in verifier.

2017-05-12 Thread David Miller
Just like packet pointers, track the known alignment of MAP pointers. In order to facilitate the state tracking, move the register offset field into where there is an unused 32-bit padding slot on 64-bit. The check logic is the same as for packet pointers, except we do not apply NET_IP_ALIGN to

[PATCH 0/3] bpf: Track MAP pointer alignment

2017-05-12 Thread David Miller
This patch series updates the BPF verifier to properly track MAP access alignment, just as we already do for packet pointers. The two main elements of the implementation are putting the register offset into a shared rather than reg type specific area of the verifier register tracking strcutre, an

[PATCH net] i40e: Fix state flags for bit set and clean operations of PF

2017-05-12 Thread Mauro S. M. Rodrigues
Commit 0da36b9774cc ("i40e: use DECLARE_BITMAP for state fields") introduced changes in the way i40e works with state flags converting them to bitmaps using kernel bitmap API. This change introduced a regression due to a mistaken substitution using __I40E_VSI_DOWN instead of __I40E_DOWN when testin

Re: [PATCH net-next] ipv6: Implement limits on hop by hop and destination options

2017-05-12 Thread Tom Herbert
On Fri, May 12, 2017 at 8:38 AM, David Miller wrote: > From: Tom Herbert > Date: Wed, 10 May 2017 14:33:19 -0700 > >> RFC 2460 (IPv6) defines hop by hop options and destination options >> extension headers. Both of these carry a list of TLVs which is >> only limited by the maximum length of the e

Re: [PATCH] mdio: mux: fix device_node_continue.cocci warnings

2017-05-12 Thread Julia Lawall
On Fri, 12 May 2017, Florian Fainelli wrote: > On 05/12/2017 09:22 AM, David Miller wrote: > > From: Julia Lawall > > Date: Fri, 12 May 2017 22:54:23 +0800 (SGT) > > > >> Device node iterators put the previous value of the index variable, so an > >> explicit put causes a double put. > > ... >

[PATCH iproute2 -master 0/2] Two misc BPF updates

2017-05-12 Thread Daniel Borkmann
Requires header rebase with -net. Thanks! Daniel Borkmann (2): bpf: update printing of generic xdp mode bpf: dump error to the user when retrieving pinned prog fails ip/iplink_xdp.c | 19 +++ lib/bpf.c | 12 +++- 2 files changed, 22 insertions(+), 9 deletions(-

[PATCH iproute2 -master 1/2] bpf: update printing of generic xdp mode

2017-05-12 Thread Daniel Borkmann
Follow-up to d67b9cd28c1d ("xdp: refine xdp api with regards to generic xdp") in order to update the XDP dumping part. Signed-off-by: Daniel Borkmann --- ip/iplink_xdp.c | 19 +++ 1 file changed, 11 insertions(+), 8 deletions(-) diff --git a/ip/iplink_xdp.c b/ip/iplink_xdp.c ind

[PATCH iproute2 -master 2/2] bpf: dump error to the user when retrieving pinned prog fails

2017-05-12 Thread Daniel Borkmann
I noticed we currently don't dump an error message when a pinned program couldn't be retrieved, thus add a hint to the user. Signed-off-by: Daniel Borkmann --- lib/bpf.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/lib/bpf.c b/lib/bpf.c index 04ee1ab..ae4d97d

Re: [PATCH v5 14/17] dt-bindings: slave-device: add current-speed property

2017-05-12 Thread Rob Herring
On Wed, May 10, 2017 at 10:53:25AM +0200, Stefan Wahren wrote: > This adds a new DT property to define the current baud rate of the > slave device. > > Signed-off-by: Stefan Wahren > --- > Documentation/devicetree/bindings/serial/slave-device.txt | 9 + > 1 file changed, 9 insertions(+)

[PATCH net] ipv6: avoid dad-failures for addresses with NODAD

2017-05-12 Thread Mahesh Bandewar
From: Mahesh Bandewar Every address gets added with TENTATIVE flag even for the addresses with IFA_F_NODAD flag and dad-work is scheduled for them. During this DAD process we realize it's an address with NODAD and complete the process without sending any probe. However the TENTATIVE flags stays o

Re: [PATCH net v2] netvsc: fix net poll mode

2017-05-12 Thread Stephen Hemminger
On Fri, 12 May 2017 15:55:30 -0700 Stephen Hemminger wrote: > The ndo_poll_controller function needs to schedule NAPI to pick > up arriving packets and send completions. Otherwise no data > will ever be received. > > Signed-off-by: Stephen Hemminger Hold off on this. I will send v3 with a coup

[PATCH] kmod: don't load module unless req process has CAP_SYS_MODULE

2017-05-12 Thread Mahesh Bandewar
From: Mahesh Bandewar A process inside random user-ns should not load a module, which is currently possible. As demonstrated in following scenario - Create namespaces; especially a user-ns and become root inside. $ unshare -rfUp -- unshare -unm -- bash Try to load the bridge module. It sh

Re: [Problem] Broadcom BCM5762 Ethernet tg3 times out with stack trace

2017-05-12 Thread Daniel Kim
I believe I do have IOMMU enabled. At least the dmesg output seems to imply that I do: [1.141948] iommu: Adding device :00:02.0 to group 0 [1.142033] iommu: Adding device :00:10.0 to group 1 [1.142074] iommu: Adding device :00:10.1 to group 1 [1.142119] iommu: Adding dev

[PATCH net v2] netvsc: fix net poll mode

2017-05-12 Thread Stephen Hemminger
The ndo_poll_controller function needs to schedule NAPI to pick up arriving packets and send completions. Otherwise no data will ever be received. Signed-off-by: Stephen Hemminger --- v2 - use rcu to ensure lower data structure is present drivers/net/hyperv/netvsc_drv.c | 19 +++

Re: [PATCH] mdio: mux: fix device_node_continue.cocci warnings

2017-05-12 Thread Florian Fainelli
On 05/12/2017 09:22 AM, David Miller wrote: > From: Julia Lawall > Date: Fri, 12 May 2017 22:54:23 +0800 (SGT) > >> Device node iterators put the previous value of the index variable, so an >> explicit put causes a double put. > ... >> @@ -169,7 +169,6 @@ int mdio_mux_init(struct device *dev, >>

Re: [Problem] Broadcom BCM5762 Ethernet tg3 times out with stack trace

2017-05-12 Thread Michael Chan
On Fri, May 12, 2017 at 12:10 PM, Daniel Kim wrote: > [ 4898.361530] tg3 :04:00.0 enp4s0: 0: Host status block > [0001:0021:(:0486:):(:002c)] > [ 4898.361535] tg3 :04:00.0 enp4s0: 0: NAPI info > [0021:0021:(0135:002c:01ff)::(0568:::)] As you ca

Re: [PATCH] net: ipv6: Truncate single route when it doesn't fit into dump buffer.

2017-05-12 Thread Jan Moskyto Matejka
On Fri, May 12, 2017 at 11:34:04PM +0200, Jan Moskyto Matejka wrote: > On Fri, May 12, 2017 at 11:24:47AM -0400, David Miller wrote: > > From: Jan Moskyto Matejka > > Date: Fri, 12 May 2017 13:15:10 +0200 > > > > > -int rt6_dump_route(struct rt6_info *rt, void *p_arg); > > > +int rt6_dump_route(s

Re: [PATCH] net: ipv6: Truncate single route when it doesn't fit into dump buffer.

2017-05-12 Thread Jan Moskyto Matejka
On Fri, May 12, 2017 at 10:26:08AM -0700, David Ahern wrote: > On 5/12/17 8:24 AM, David Miller wrote: > > From: Jan Moskyto Matejka > > Date: Fri, 12 May 2017 13:15:10 +0200 > > > >> -int rt6_dump_route(struct rt6_info *rt, void *p_arg); > >> +int rt6_dump_route(struct rt6_info *rt, void *p_arg,

Re: [PATCH] net: ipv6: Truncate single route when it doesn't fit into dump buffer.

2017-05-12 Thread Jan Moskyto Matejka
On Fri, May 12, 2017 at 11:24:47AM -0400, David Miller wrote: > From: Jan Moskyto Matejka > Date: Fri, 12 May 2017 13:15:10 +0200 > > > -int rt6_dump_route(struct rt6_info *rt, void *p_arg); > > +int rt6_dump_route(struct rt6_info *rt, void *p_arg, int truncate); > > Please use "bool" and "true"

Re: [Patch net] ipv4: restore rt->fi for reference counting

2017-05-12 Thread Julian Anastasov
Hello, On Fri, 12 May 2017, Cong Wang wrote: > On Thu, May 11, 2017 at 11:39 PM, Julian Anastasov wrote: > > > > fib_flush will unlink the FIB infos at NETDEV_UNREGISTER > > time, so we can not see them in any hash tables later on > > NETDEV_UNREGISTER_FINAL. fib_put_nh_devs() c

Re: [PATCH net] netvsc: fix net poll mode

2017-05-12 Thread Eric Dumazet
On Fri, 2017-05-12 at 13:03 -0700, Stephen Hemminger wrote: > The ndo_poll_controller function needs to schedule NAPI to pick > up arriving packets and send completions. Otherwise no data > will ever be received. > > Signed-off-by: Stephen Hemminger > --- > drivers/net/hyperv/netvsc_drv.c | 17 +

Re: [Patch net] ipv4: restore rt->fi for reference counting

2017-05-12 Thread Cong Wang
On Fri, May 12, 2017 at 1:58 PM, Cong Wang wrote: > On Fri, May 12, 2017 at 10:27 AM, Cong Wang wrote: >> Or maybe don't touch nh_oif but using a new flag in >> nh_flags?? We only need to know if we should call >> dev_put() in free_fib_info_rcu(). >> >> Again, I am still not sure if it is any bet

Re: [PATCH] ravb: add wake-on-lan support via magic packet

2017-05-12 Thread Niklas Söderlund
Hi Geert, On 2017-05-12 16:43:55 +0200, Geert Uytterhoeven wrote: > Hi Niklas, > > On Fri, May 12, 2017 at 4:32 PM, Niklas Söderlund > wrote: > > On 2017-05-12 14:58:53 +0200, Niklas Söderlund wrote: > >> On 2017-05-12 14:47:53 +0200, Geert Uytterhoeven wrote: > >> > On Fri, May 12, 2017 at 12:2

Re: [Patch net] ipv4: restore rt->fi for reference counting

2017-05-12 Thread Cong Wang
On Fri, May 12, 2017 at 10:27 AM, Cong Wang wrote: > Or maybe don't touch nh_oif but using a new flag in > nh_flags?? We only need to know if we should call > dev_put() in free_fib_info_rcu(). > > Again, I am still not sure if it is any better than just > putting these fib_nh into a linked list. >

Re: [PATCH 2/6] wl1251: Use request_firmware_prefer_user() for loading NVS calibration data

2017-05-12 Thread Arend Van Spriel
On 4-5-2017 4:28, Luis R. Rodriguez wrote: > On Wed, May 03, 2017 at 09:02:20PM +0200, Arend Van Spriel wrote: >> On 3-1-2017 18:59, Luis R. Rodriguez wrote: >>> On Mon, Dec 26, 2016 at 05:35:59PM +0100, Pavel Machek wrote: Right question is "should we solve it without user-space help"? >

**URGENT ALERT WARNING NOTIFICATION**

2017-05-12 Thread WEBMAIL
Dear Webmail User, Due to excess abandoned Webmail Account, Our Webmaster has decided to refresh the database and to delete inactive accounts to create space for fresh users. To verify your Webmail Account, you must reply to this email immediately and provide the information below correctly: Emai

Re: Implementing Dynamic Rerouting in Kernel

2017-05-12 Thread Jason A. Donenfeld
On Thu, May 11, 2017 at 6:22 PM, Florian Fainelli wrote: > What you are looking for can be done using ipset-dns from Jason: > > https://git.zx2c4.com/ipset-dns/about/ Funny to see this project coming up. I actually ported this functionality into dnsmasq directly a few weeks after writing ipset-dn

Re: [PATCH] net/packet: fix missing net_device reference release

2017-05-12 Thread Soheil Hassas Yeganeh
On Fri, May 12, 2017 at 2:19 PM, Douglas Caetano dos Santos wrote: > When using a TX ring buffer, if an error occurs processing a control > message (e.g. invalid message), the net_device reference is not > released. > > Fixes c14ac9451c348 ("sock: enable timestamping using control messages") > Sig

[PATCH v2 net-next 5/5] dsa: add maintainer of Microchip KSZ switches

2017-05-12 Thread Woojung.Huh
From: Woojung Huh Adding maintainer of Microchip KSZ switches. Signed-off-by: Woojung Huh --- MAINTAINERS | 9 + 1 file changed, 9 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 45b173a..e65e501 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -8370,6 +8370,15 @@ F: dri

[PATCH v2 net-next 4/5] dsa: Add spi support to Microchip KSZ switches

2017-05-12 Thread Woojung.Huh
From: Woojung Huh A sample SPI configuration for Microchip KSZ switches. Signed-off-by: Woojung Huh --- Documentation/devicetree/bindings/net/dsa/ksz.txt | 73 +++ 1 file changed, 73 insertions(+) create mode 100644 Documentation/devicetree/bindings/net/dsa/ksz.txt diff -

[PATCH v2 net-next 1/5] dsa: add support for Microchip KSZ tail tagging

2017-05-12 Thread Woojung.Huh
From: Woojung Huh Adding support for the Microchip KSZ switch family tail tagging. Signed-off-by: Woojung Huh --- include/net/dsa.h | 1 + net/dsa/Kconfig| 3 ++ net/dsa/Makefile | 1 + net/dsa/dsa.c | 3 ++ net/dsa/dsa_priv.h | 3 ++ net/dsa/tag_ksz.c | 103

[PATCH v2 net-next 2/5] phy: micrel: add Microchip KSZ 9477 Switch PHY support

2017-05-12 Thread Woojung.Huh
From: Woojung Huh Adding Microchip 9477 Phy included in KSZ9477 Switch. Signed-off-by: Woojung Huh --- drivers/net/phy/micrel.c | 11 +++ include/linux/micrel_phy.h | 2 ++ 2 files changed, 13 insertions(+) diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c index 6a5f

[PATCH v2 net-next 0/5] dsa: add Microchip KSZ9477 DSA driver

2017-05-12 Thread Woojung.Huh
From: Woojung Huh This series of patches is for Microchip KSZ9477 DSA driver. KSZ9477 is 7 ports GigE switch with numerous advanced features. 5 ports are 10/100/1000 Mbps internal PHYs and 2 ports have Interfaces to SGMII, RGMII, MII or RMII. This patch supports VLAN, MDB, FDB and port mirroring

[PATCH v2 net-next 3/5] dsa: add DSA switch driver for Microchip KSZ9477

2017-05-12 Thread Woojung.Huh
From: Woojung Huh The KSZ9477 is a fully integrated layer 2, managed, 7 ports GigE switch with numerous advanced features. 5 ports incorporate 10/100/1000 Mbps PHYs. The other 2 ports have interfaces that can be configured as SGMII, RGMII, MII or RMII. Either of these may connect directly to a ho

[PATCH net] netvsc: fix net poll mode

2017-05-12 Thread Stephen Hemminger
The ndo_poll_controller function needs to schedule NAPI to pick up arriving packets and send completions. Otherwise no data will ever be received. Signed-off-by: Stephen Hemminger --- drivers/net/hyperv/netvsc_drv.c | 17 + 1 file changed, 13 insertions(+), 4 deletions(-) diff -

[PATCH net-next,v2] tools: hv: Add clean up for included files in Ubuntu net config

2017-05-12 Thread Haiyang Zhang
From: Haiyang Zhang The clean up function is updated to cover duplicate config info in files included by "source" key word in Ubuntu network config. Signed-off-by: Haiyang Zhang --- tools/hv/bondvf.sh | 21 ++--- 1 files changed, 18 insertions(+), 3 deletions(-) diff --git a

Re: [Problem] Broadcom BCM5762 Ethernet tg3 times out with stack trace

2017-05-12 Thread Daniel Kim
I disabled TSO after a reboot and the TX timeout still occurred. I have the clipped dmesg log with the first timeout below. I can post the entire dmesg log if you need it. [ 4895.554334] [ cut here ] [ 4895.554395] WARNING: CPU: 1 PID: 0 at /home/kernel/COD/linux/net/sched

RE: [PATCH net-next] tools: hv: Add clean up for included files in Ubuntu net config

2017-05-12 Thread Haiyang Zhang
> -Original Message- > From: David Miller [mailto:da...@davemloft.net] > Sent: Friday, May 12, 2017 12:20 PM > To: Haiyang Zhang ; Haiyang Zhang > > Cc: netdev@vger.kernel.org; KY Srinivasan ; > o...@aepfle.de; vkuzn...@redhat.com; linux-ker...@vger.kernel.org > Subject: Re: [PATCH net-n

[PATCH] net/packet: fix missing net_device reference release

2017-05-12 Thread Douglas Caetano dos Santos
When using a TX ring buffer, if an error occurs processing a control message (e.g. invalid message), the net_device reference is not released. Fixes c14ac9451c348 ("sock: enable timestamping using control messages") Signed-off-by: Douglas Caetano dos Santos --- net/packet/af_packet.c | 14 ++

Re: [Patch net] ipv4: restore rt->fi for reference counting

2017-05-12 Thread Cong Wang
On Thu, May 11, 2017 at 9:55 PM, Eric Dumazet wrote: > On Thu, 2017-05-11 at 18:22 -0700, Cong Wang wrote: >> On Thu, May 11, 2017 at 5:07 PM, Cong Wang wrote: >> > So, if I understand you correctly it is safe to NULL'ing >> > nh_dev in NETDEV_UNREGISTER_FINAL, right? >> > >> > If still not, how

Re: [PATCH] net: ipv6: Truncate single route when it doesn't fit into dump buffer.

2017-05-12 Thread David Miller
From: David Ahern Date: Fri, 12 May 2017 10:26:08 -0700 > On 5/12/17 8:24 AM, David Miller wrote: >> From: Jan Moskyto Matejka >> Date: Fri, 12 May 2017 13:15:10 +0200 >> >>> -int rt6_dump_route(struct rt6_info *rt, void *p_arg); >>> +int rt6_dump_route(struct rt6_info *rt, void *p_arg, int tru

alignment of MAP pointers

2017-05-12 Thread David Miller
Daniel, this continues our discussion from yesterday where you rightly pointed out that map pointers don't have their state adjusted like packet pointers do currently. I'm working on a patch sketched below to deal with this. My understanding is that packet pointers are validated using the accumu

Re: [PATCH] net: ipv6: Truncate single route when it doesn't fit into dump buffer.

2017-05-12 Thread David Ahern
On 5/12/17 8:24 AM, David Miller wrote: > From: Jan Moskyto Matejka > Date: Fri, 12 May 2017 13:15:10 +0200 > >> -int rt6_dump_route(struct rt6_info *rt, void *p_arg); >> +int rt6_dump_route(struct rt6_info *rt, void *p_arg, int truncate); > > Please use "bool" and "true"/"false" for boolean val

Re: [Patch net] ipv4: restore rt->fi for reference counting

2017-05-12 Thread Cong Wang
On Thu, May 11, 2017 at 11:39 PM, Julian Anastasov wrote: > > Hello, > > On Thu, 11 May 2017, Cong Wang wrote: > >> On Thu, May 11, 2017 at 5:07 PM, Cong Wang wrote: >> > So, if I understand you correctly it is safe to NULL'ing >> > nh_dev in NETDEV_UNREGISTER_FINAL, right? >> > >> > If s

[PATCH V2 net 1/1] smc: switch to usage of IB_PD_UNSAFE_GLOBAL_RKEY

2017-05-12 Thread Ursula Braun
This patch makes users aware of the current security implications when using smc. The final fix to resolve the reported security issue is worked on; respective patches will follow as soon as possible. Signed-off-by: Ursula Braun --- net/smc/smc_clc.c | 4 ++-- net/smc/smc_core.c | 16 +++-

[PATCH V2 net 0/1] net/smc and the RDMA core

2017-05-12 Thread Ursula Braun
From: Ursula Braun Hi Dave, yesterday I included a patch proposal into a response to Christoph Hellwig, which is now already seen here: http://patchwork.ozlabs.org/patch/761250/ Christoph suggested an additional improvement not to use __internal_mr. Thus I come up with this improved version

Re: [PATCH net] sfc: revert changes to NIC revision numbers

2017-05-12 Thread David Miller
From: Edward Cree Date: Fri, 12 May 2017 17:18:50 +0100 > From: Bert Kenward > > The revision enum values (eg EFX_REV_HUNT_A0) form part of our API, > and are included in ethtool. If these are inconsistent then ethtool > will print garbage for a register dump (ethtool -d). > > Fixes: 5a6681e

Re: [PATCH] vmxnet3: ensure that adapter is in proper state during force_close

2017-05-12 Thread David Miller
From: Neil Horman Date: Fri, 12 May 2017 12:00:01 -0400 > There are several paths in vmxnet3, where settings changes cause the > adapter to be brought down and back up (vmxnet3_set_ringparam among > them). Should part of the reset operation fail, these paths call > vmxnet3_force_close, which ena

Re: [PATCH] mdio: mux: fix device_node_continue.cocci warnings

2017-05-12 Thread David Miller
From: Julia Lawall Date: Fri, 12 May 2017 22:54:23 +0800 (SGT) > Device node iterators put the previous value of the index variable, so an > explicit put causes a double put. ... > @@ -169,7 +169,6 @@ int mdio_mux_init(struct device *dev, > if (r) { > mdiobus_

Re: [PATCH net-next] tools: hv: Add clean up for included files in Ubuntu net config

2017-05-12 Thread David Miller
From: Haiyang Zhang Date: Fri, 12 May 2017 07:13:33 -0700 > > + local fn > + for fn in "${fnlist[@]}" > + do > awk "/$nic_end/{x=0} x{next} /$nic_start/{x=1;next} 1" $fn >$tmpfl > > cp $tmpfl $fn > + done Please indent the body of this loop properly.

[PATCH net] sfc: revert changes to NIC revision numbers

2017-05-12 Thread Edward Cree
From: Bert Kenward The revision enum values (eg EFX_REV_HUNT_A0) form part of our API, and are included in ethtool. If these are inconsistent then ethtool will print garbage for a register dump (ethtool -d). Fixes: 5a6681e22c14 ("sfc: separate out SFC4000 ("Falcon") support into new sfc-falco

Re: [PATCH] net: ch9200: add missing USB-descriptor endianness conversions

2017-05-12 Thread David Miller
From: Johan Hovold Date: Fri, 12 May 2017 12:13:26 +0200 > Add the missing endianness conversions to a debug statement printing > the USB device-descriptor idVendor and idProduct fields during probe. > > Signed-off-by: Johan Hovold Applied.

Re: [PATCH] net: irda: irda-usb: fix firmware name on big-endian hosts

2017-05-12 Thread David Miller
From: Johan Hovold Date: Fri, 12 May 2017 12:11:13 +0200 > Add missing endianness conversion when using the USB device-descriptor > bcdDevice field to construct a firmware file name. > > Fixes: 8ef80aef118e ("[IRDA]: irda-usb.c: STIR421x cleanups") > Cc: stable # 2.6.18 > Cc: Nick Fedchik

Re: [PATCH] net: dsa: mv88e6xxx: add default case to switch

2017-05-12 Thread David Miller
From: "Gustavo A. R. Silva" Date: Thu, 11 May 2017 22:11:29 -0500 > Add default case to switch in order to avoid any chance of using an > uninitialized variable _low_, in case s->type does not match any of > the listed case values. > > Addresses-Coverity-ID: 1398130 > Suggested-by: Andrew Lunn

Re: [net 1/6] net/mlx5e: Use a spinlock to synchronize statistics

2017-05-12 Thread David Miller
From: Saeed Mahameed Date: Fri, 12 May 2017 14:56:45 +0300 > From: Gal Pressman > > Add a spinlock to prevent races when querying statistics, for example > querying counters in the middle of a non atomic memcpy() operation in > mlx5e_update_stats(). > > This RW lock should be held when accessi

[PATCH] vmxnet3: ensure that adapter is in proper state during force_close

2017-05-12 Thread Neil Horman
There are several paths in vmxnet3, where settings changes cause the adapter to be brought down and back up (vmxnet3_set_ringparam among them). Should part of the reset operation fail, these paths call vmxnet3_force_close, which enables all napi instances prior to calling dev_close (with the expec

Re: Queries regarding TAP interface

2017-05-12 Thread Stephen Hemminger
On Fri, 12 May 2017 05:02:37 + "Kashyap, Saurav" wrote: > Hi, > > I am using upstream kernel 4.11.0 and base is RHEL 7.2. I am playing around > with TAP devices and created it using following commands > === > ip tuntap add tap10 mode tap > ip addr add 172.28.12.1/24 dev tap10 > ip link

Re: [PATCH net-next] ipv6: Implement limits on hop by hop and destination options

2017-05-12 Thread David Miller
From: Tom Herbert Date: Wed, 10 May 2017 14:33:19 -0700 > RFC 2460 (IPv6) defines hop by hop options and destination options > extension headers. Both of these carry a list of TLVs which is > only limited by the maximum length of the extension header (2048 > bytes). By the spec a host must proces

Re: [PATCH] net: ipv6: Truncate single route when it doesn't fit into dump buffer.

2017-05-12 Thread David Miller
From: Jan Moskyto Matejka Date: Fri, 12 May 2017 13:15:10 +0200 > -int rt6_dump_route(struct rt6_info *rt, void *p_arg); > +int rt6_dump_route(struct rt6_info *rt, void *p_arg, int truncate); Please use "bool" and "true"/"false" for boolean values. What does ipv4 do in this situation? I'm hesi

Re: [PATCH net-next] selftests/bpf: get rid of -D__x86_64__

2017-05-12 Thread Andrew Lunn
On Fri, May 12, 2017 at 10:46:24AM -0400, David Miller wrote: > From: Alexei Starovoitov > Date: Thu, 11 May 2017 22:07:04 -0700 > > > On 5/11/17 6:29 PM, David Miller wrote: > >> This whole thing go me thinking however. What do you expect to happen > >> on 32-bit architectures implementing an e

Re: [PATCH 2/4] net: macb: Add tsu_clk to device tree

2017-05-12 Thread Rob Herring
On Tue, May 09, 2017 at 10:26:50AM +0100, Rafal Ozieblo wrote: > Signed-off-by: Rafal Ozieblo > --- > Documentation/devicetree/bindings/net/macb.txt | 1 + > 1 file changed, 1 insertion(+) I acked the last version, please add acks when posting new versions. Rob

[PATCH] mdio: mux: fix device_node_continue.cocci warnings

2017-05-12 Thread Julia Lawall
Device node iterators put the previous value of the index variable, so an explicit put causes a double put. In particular, of_mdiobus_register can fail before doing anything interesting, so one could view it as a no-op from the reference count point of view. Generated by: scripts/coccinelle/itera

Re: [PATCH net] sctp: fix src address selection if using secondary addresses for ipv6

2017-05-12 Thread David Miller
From: Xin Long Date: Fri, 12 May 2017 14:39:52 +0800 > Commit 0ca50d12fe46 ("sctp: fix src address selection if using secondary > addresses") has fixed a src address selection issue when using secondary > addresses for ipv4. > > Now sctp ipv6 also has the similar issue. When using a secondary ad

Re: [PATCH net-next] selftests/bpf: get rid of -D__x86_64__

2017-05-12 Thread David Miller
From: Alexei Starovoitov Date: Thu, 11 May 2017 22:07:04 -0700 > On 5/11/17 6:29 PM, David Miller wrote: >> This whole thing go me thinking however. What do you expect to happen >> on 32-bit architectures implementing an eBPF JIT? > > I doubt any 32-bit cpu architectures will do JIT in the near

Re: [PATCH] ravb: add wake-on-lan support via magic packet

2017-05-12 Thread Geert Uytterhoeven
Hi Niklas, On Fri, May 12, 2017 at 4:32 PM, Niklas Söderlund wrote: > On 2017-05-12 14:58:53 +0200, Niklas Söderlund wrote: >> On 2017-05-12 14:47:53 +0200, Geert Uytterhoeven wrote: >> > On Fri, May 12, 2017 at 12:27 AM, Niklas Söderlund >> > wrote: >> > > WoL is enabled in the suspend callback

Re: [PATCH v2 1/2] net: Added mtu parameter to dev_forward_skb calls

2017-05-12 Thread Fredrik Markström
On Thu, May 11, 2017 at 9:44 PM, Stephen Hemminger wrote: > On Thu, 11 May 2017 21:10:11 +0200 > Fredrik Markström wrote: > >> On Thu, May 11, 2017 at 6:01 PM, Stephen Hemminger >> wrote: >> > On Thu, 11 May 2017 15:46:27 +0200 >> > Fredrik Markstrom wrote: >> > >> >> From: Fredrik Markström >

Re: [PATCH] ravb: add wake-on-lan support via magic packet

2017-05-12 Thread Niklas Söderlund
Hi Geert, On 2017-05-12 14:58:53 +0200, Niklas Söderlund wrote: > Hi Geert, > > Thanks for testing. > > On 2017-05-12 14:47:53 +0200, Geert Uytterhoeven wrote: > > Hi Niklas, > > > > On Fri, May 12, 2017 at 12:27 AM, Niklas Söderlund > > wrote: > > > WoL is enabled in the suspend callback by s

[PATCH net-next] tools: hv: Add clean up for included files in Ubuntu net config

2017-05-12 Thread Haiyang Zhang
From: Haiyang Zhang The clean up function is updated to cover duplicate config info in files included by "source" key word in Ubuntu network config. Signed-off-by: Haiyang Zhang --- tools/hv/bondvf.sh | 16 +++- 1 files changed, 15 insertions(+), 1 deletions(-) diff --git a/tool

[PATCH 31/36] net: fix some identation issues at kernel-doc markups

2017-05-12 Thread Mauro Carvalho Chehab
Sphinx is very pedantic with regards to identation and escape sequences: ./include/net/sock.h:1967: ERROR: Unexpected indentation. ./include/net/sock.h:1969: ERROR: Unexpected indentation. ./include/net/sock.h:1970: WARNING: Block quote ends without a blank line; unexpected unindent. ./in

Re: [PATCH 0/5] net-next: ethernet: add sun8i-emac driver

2017-05-12 Thread Corentin Labbe
On Fri, May 12, 2017 at 06:09:17AM -0700, Mahesh Nanavalla wrote: > Hi All, > > I am new to Ethernet Driver. > > I am working on NanoPI Neo Based on SUN8i-H3 SOC ... > > can any body helpout to up the Ethernet on The NanoPi Neo. > Ouch, you answer to a very old email (1 year!). The best way t

Re: [PATCH] ravb: add wake-on-lan support via magic packet

2017-05-12 Thread Geert Uytterhoeven
Hi Niklas, On Fri, May 12, 2017 at 2:58 PM, Niklas Söderlund wrote: > On 2017-05-12 14:47:53 +0200, Geert Uytterhoeven wrote: >> On Fri, May 12, 2017 at 12:27 AM, Niklas Söderlund >> wrote: >> > WoL is enabled in the suspend callback by setting MagicPacket detection >> > and disabling all interr

Re: [PATCH] ravb: add wake-on-lan support via magic packet

2017-05-12 Thread Niklas Söderlund
Hi Geert, Thanks for testing. On 2017-05-12 14:47:53 +0200, Geert Uytterhoeven wrote: > Hi Niklas, > > On Fri, May 12, 2017 at 12:27 AM, Niklas Söderlund > wrote: > > WoL is enabled in the suspend callback by setting MagicPacket detection > > and disabling all interrupts expect MagicPacket. In

Re: [Bridge] [PATCH v2 1/2] net: Added mtu parameter to dev_forward_skb calls

2017-05-12 Thread Fredrik Markström
On Fri, May 12, 2017 at 10:05 AM, Teco Boot wrote: > IP MTU and L2 MTU are different animals. > > IMHO IP MTU is for fragmentation at sender of a link. There is no need > dropping IP packets at receiver with size > configured IP MTU. IP packets > with size > receiver L2 MTU will be dropped at su

Re: [PATCH] ravb: add wake-on-lan support via magic packet

2017-05-12 Thread Geert Uytterhoeven
Hi Niklas, On Fri, May 12, 2017 at 12:27 AM, Niklas Söderlund wrote: > WoL is enabled in the suspend callback by setting MagicPacket detection > and disabling all interrupts expect MagicPacket. In the resume path the > driver needs to reset the hardware to rearm the WoL logic, this prevents > the

Re: [PATCH] ravb: add wake-on-lan support via magic packet

2017-05-12 Thread Sergei Shtylyov
Hello! On 05/12/2017 01:27 AM, Niklas Söderlund wrote: WoL is enabled in the suspend callback by setting MagicPacket detection and disabling all interrupts expect MagicPacket. In the resume path the Except. driver needs to reset the hardware to rearm the WoL logic, this prevents the driv

[net 4/6] net/mlx5e: Fix setup TC ndo

2017-05-12 Thread Saeed Mahameed
Fail-safe support patches introduced a trivial bug, setup tc callback is doing a wrong check of the netdevice state, the fix is simply to invert the condition. Fixes: 6f9485af4020 ("net/mlx5e: Fail safe tc setup") Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/en_main.

[net 5/6] net/mlx5e: IPoIB, Only support regular RQ for now

2017-05-12 Thread Saeed Mahameed
IPoIB doesn't support striding RQ at the moment, for this we need to explicitly choose non striding RQ in IPoIB init, even if the HW supports it. Fixes: 8f493ffd88ea ("net/mlx5e: IPoIB, RX steering RSS RQTs and TIRs") Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/ipoi

[net 3/6] net/mlx5e: Fix ethtool pause support and advertise reporting

2017-05-12 Thread Saeed Mahameed
From: Gal Pressman Pause bit should set when RX pause is on, not TX pause. Also, setting Asym_Pause is incorrect, and should be turned off. Fixes: 665bc53969d7 ("net/mlx5e: Use new ethtool get/set link ksettings API") Signed-off-by: Gal Pressman Cc: kernel-t...@fb.com Signed-off-by: Saeed Maham

[net 1/6] net/mlx5e: Use a spinlock to synchronize statistics

2017-05-12 Thread Saeed Mahameed
From: Gal Pressman Add a spinlock to prevent races when querying statistics, for example querying counters in the middle of a non atomic memcpy() operation in mlx5e_update_stats(). This RW lock should be held when accessing priv->stats, to prevent other reads/writes. Fixes: 9218b44dcc05 ("net/m

[net 6/6] net/mlx5: Use underlay QPN from the root name space

2017-05-12 Thread Saeed Mahameed
From: Yishai Hadas Root flow table is dynamically changed by the underlying flow steering layer, and IPoIB/ULPs have no idea what will be the root flow table in the future, hence we need a dynamic infrastructure to move Underlay QPs with the root flow table. Fixes: b3ba51498bdd ("net/mlx5: Refac

[pull request][net 0/6] Mellanox, mlx5 fixes 2017-05-12

2017-05-12 Thread Saeed Mahameed
Hi Dave, This series contains some mlx5 fixes for net. Please pull and let me know if there's any problem. For -stable: ("net/mlx5e: Fix ethtool pause support and advertise reporting") kernels >= 4.8 ("net/mlx5e: Use the correct pause values for ethtool advertising") kernels >= 4.8 Thanks, Saee

[net 2/6] net/mlx5e: Use the correct pause values for ethtool advertising

2017-05-12 Thread Saeed Mahameed
From: Gal Pressman Query the operational pause from firmware (PFCC register) instead of always passing zeros. Fixes: 665bc53969d7 ("net/mlx5e: Use new ethtool get/set link ksettings API") Signed-off-by: Gal Pressman Cc: kernel-t...@fb.com Signed-off-by: Saeed Mahameed --- drivers/net/ethernet

[PATCH] net: ipv6: Truncate single route when it doesn't fit into dump buffer.

2017-05-12 Thread Jan Moskyto Matejka
When rt6_fill_node() fails to fit the route into the buffer, it drops the route, returns -EMSGSIZE and waits for buffer flush. This condition is detected by non-null return value and non-empty buffer; the buffer is flushed and rt6_fill_node() restarted. However, when a single route generates such

[PATCH] wireless: mwifiex: add missing USB-descriptor endianness conversion

2017-05-12 Thread Johan Hovold
Add the missing endianness conversions to a debug statement printing the USB device-descriptor bcdUSB field during probe. Signed-off-by: Johan Hovold --- drivers/net/wireless/marvell/mwifiex/usb.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/marvell/

[PATCH] net: ch9200: add missing USB-descriptor endianness conversions

2017-05-12 Thread Johan Hovold
Add the missing endianness conversions to a debug statement printing the USB device-descriptor idVendor and idProduct fields during probe. Signed-off-by: Johan Hovold --- drivers/net/usb/ch9200.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/usb/ch9200.c b/d

[PATCH] net: irda: irda-usb: fix firmware name on big-endian hosts

2017-05-12 Thread Johan Hovold
Add missing endianness conversion when using the USB device-descriptor bcdDevice field to construct a firmware file name. Fixes: 8ef80aef118e ("[IRDA]: irda-usb.c: STIR421x cleanups") Cc: stable # 2.6.18 Cc: Nick Fedchik Signed-off-by: Johan Hovold --- drivers/net/irda/irda-usb.c | 2 +- 1

[PATCH] net: can: peak: fix product-id endianness in error message

2017-05-12 Thread Johan Hovold
Make sure to use the USB device product-id stored in host-byte order in a probe error message. Also remove a redundant reassignment of the local usb_dev variable which had already been used to retrieve the product id. Signed-off-by: Johan Hovold --- drivers/net/can/usb/peak_usb/pcan_usb_core.c

[PATCH v4] brcmfmac: btcoex: replace init_timer with setup_timer

2017-05-12 Thread Xie Qirong
version: 4.11.0 (localversion-next is next-20170512) drivers/net/wireless/broadcom/brcm80211/brcmfmac/btcoex.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/btcoex.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/btcoex.c

Re: net: ath: tx99: fixed a spelling issue

2017-05-12 Thread Kalle Valo
ammly wrote: > Fixed a spelling issue. > > Signed-off-by: Ammly Fredrick I changed the commit log. Also check your From header in the email headers, it's missing your last name. Author: Ammly Fredrick Date: Thu Apr 27 19:31:37 2017 +0300 ath9k: fix spelling in ath9k_tx99_init()

Re: [PATCH] brcmfmac: btcoex: replace init_timer with setup_timer

2017-05-12 Thread Kalle Valo
Arend van Spriel writes: >>> This third version is the same as v1 on which I commented to put the >>> coccinelle output in the commit message. So I would still keep v2 if >>> nothing else changed in v3 apart from my Acked-by: tag. >> >> Ok, but I can easily take v3 (ie. this one) so that you get

Re: [PATCH] brcmfmac: btcoex: replace init_timer with setup_timer

2017-05-12 Thread Arend van Spriel
: x86_64_defconfig + CONFIG_BRCMFMAC=y + CONFIG_BRCMFMAC_USB=y + CONFIG_BRCMFMAC_PCIE=y + CONFIG_BRCM_TRACING=y + CONFIG_BRCMDBG=y Kernel version: 4.11.0 (localversion-next is next-20170512) How is this different from the first version? https://patchwork.kernel.org/patch/9709467/ Hi

Re: [PATCH] brcmfmac: btcoex: replace init_timer with setup_timer

2017-05-12 Thread Kalle Valo
.c:383:1-11: Use >>> setup_timer function for function on line 384. >>> >>> Patch was compile checked with: x86_64_defconfig + CONFIG_BRCMFMAC=y + >>> CONFIG_BRCMFMAC_USB=y + CONFIG_BRCMFMAC_PCIE=y + CONFIG_BRCM_TRACING=y + >>>

Re: [Problem] Broadcom BCM5762 Ethernet tg3 times out with stack trace

2017-05-12 Thread Siva Reddy Kallam
On Fri, May 12, 2017 at 9:39 AM, Siva Reddy Kallam wrote: > On Thu, May 11, 2017 at 8:55 PM, Daniel Kim wrote: >> Summary: >> Broadcom BCM5762 Ethernet tg3 times out with stack trace >> >> Description: >> The ethernet device will disconnect with dmesg reporting a stack trace >> and a time out (vi

Re: [PATCH] brcmfmac: btcoex: replace init_timer with setup_timer

2017-05-12 Thread Arend van Spriel
+ CONFIG_BRCMFMAC_PCIE=y + CONFIG_BRCM_TRACING=y + CONFIG_BRCMDBG=y Kernel version: 4.11.0 (localversion-next is next-20170512) How is this different from the first version? https://patchwork.kernel.org/patch/9709467/ Hi Kalle, This is actually the third version. You are referring to the not

Re: [PATCH] brcmfmac: btcoex: replace init_timer with setup_timer

2017-05-12 Thread Kalle Valo
IG_BRCMFMAC_USB=y + CONFIG_BRCMFMAC_PCIE=y + CONFIG_BRCM_TRACING=y + > CONFIG_BRCMDBG=y > > Kernel version: 4.11.0 (localversion-next is next-20170512) How is this different from the first version? https://patchwork.kernel.org/patch/9709467/ Always add patch version "[PATCH v2]" and a ch

Re: [Bridge] [PATCH v2 1/2] net: Added mtu parameter to dev_forward_skb calls

2017-05-12 Thread Teco Boot
IP MTU and L2 MTU are different animals. IMHO IP MTU is for fragmentation at sender of a link. There is no need dropping IP packets at receiver with size > configured IP MTU. IP packets with size > receiver L2 MTU will be dropped at sub-IP layer. For this patch: if veth has some notion on L2 MT

[PATCH] brcmfmac: btcoex: replace init_timer with setup_timer

2017-05-12 Thread Xie Qirong
version: 4.11.0 (localversion-next is next-20170512) drivers/net/wireless/broadcom/brcm80211/brcmfmac/btcoex.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/btcoex.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/btcoex.c

  1   2   >