RE: [PATCH net 5/5] qede: Split PF/VF ndos.

2017-05-16 Thread Mintz, Yuval
> PFs and VFs share the same structure of NDOs today, and the VFs explicitly > fails the ndo_xdp() callback stating it doesn't support XDP. > > This results in lots of: > > [qede_xdp:1032(enp131s2)]VFs don't support XDP > [ cut here ] > WARNING: CPU: 4 PID: 1426 at n

Re: [patch net-next v3 06/10] net: sched: introduce helpers to work with filter chains

2017-05-16 Thread Jiri Pirko
Wed, May 17, 2017 at 12:17:11AM CEST, xiyou.wangc...@gmail.com wrote: >On Tue, May 16, 2017 at 10:27 AM, Jiri Pirko wrote: >> +static struct tcf_proto *tcf_chain_tp_prev(struct tcf_chain_info >> *chain_info) >> +{ >> + return rtnl_dereference(*chain_info->pprev); >> +} >> + >> +static void

Re: [patch net-next v3 05/10] net: sched: move TC_H_MAJ macro call into tcf_auto_prio

2017-05-16 Thread Jiri Pirko
Wed, May 17, 2017 at 12:38:08AM CEST, xiyou.wangc...@gmail.com wrote: >On Tue, May 16, 2017 at 2:03 PM, Jiri Pirko wrote: >> Tue, May 16, 2017 at 11:01:52PM CEST, xiyou.wangc...@gmail.com wrote: >>>On Tue, May 16, 2017 at 10:27 AM, Jiri Pirko wrote: From: Jiri Pirko Call the helpe

Re: [patch net-next v3 02/10] net: sched: introduce tcf block infractructure

2017-05-16 Thread Jiri Pirko
Wed, May 17, 2017 at 12:34:04AM CEST, xiyou.wangc...@gmail.com wrote: >On Tue, May 16, 2017 at 2:34 PM, David Miller wrote: >> From: Cong Wang >> Date: Tue, 16 May 2017 13:51:30 -0700 >> >>> On Tue, May 16, 2017 at 10:27 AM, Jiri Pirko wrote: +int tcf_block_get(struct tcf_block **p_block, >

[PATCH net-next] net: fix __skb_try_recv_from_queue to return the old behavior

2017-05-16 Thread Andrei Vagin
This function has to return NULL on a error case, because there is a separate error variable. The offset has to be changed only if skb is returned Cc: Paolo Abeni Cc: Eric Dumazet Cc: David S. Miller Fixes: 65101aeca522 ("net/sock: factor out dequeue/peek with offset cod") Signed-off-by: Andre

[PATCH net-next V5 0/9] vhost_net rx batch dequeuing

2017-05-16 Thread Jason Wang
This series tries to implement rx batching for vhost-net. This is done by batching the dequeuing from skb_array which was exported by underlayer socket and pass the sbk back through msg_control to finish userspace copying. This is also the requirement for more batching implemention on rx path. Tes

[PATCH net-next V5 4/9] skb_array: introduce batch dequeuing

2017-05-16 Thread Jason Wang
Signed-off-by: Jason Wang --- include/linux/skb_array.h | 25 + 1 file changed, 25 insertions(+) diff --git a/include/linux/skb_array.h b/include/linux/skb_array.h index 79850b6..35226cd 100644 --- a/include/linux/skb_array.h +++ b/include/linux/skb_array.h @@ -97,21 +97,

[PATCH net-next V5 5/9] tun: export skb_array

2017-05-16 Thread Jason Wang
This patch exports skb_array through tun_get_skb_array(). Caller can then manipulate skb array directly. Signed-off-by: Jason Wang --- drivers/net/tun.c | 13 + include/linux/if_tun.h | 5 + 2 files changed, 18 insertions(+) diff --git a/drivers/net/tun.c b/drivers/net/tun

[PATCH net-next V5 2/9] skb_array: introduce skb_array_unconsume

2017-05-16 Thread Jason Wang
Signed-off-by: Jason Wang --- include/linux/skb_array.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/include/linux/skb_array.h b/include/linux/skb_array.h index f4dfade..79850b6 100644 --- a/include/linux/skb_array.h +++ b/include/linux/skb_array.h @@ -156,6 +156,12 @@ static void __

[PATCH net-next V5 9/9] vhost_net: try batch dequing from skb array

2017-05-16 Thread Jason Wang
We used to dequeue one skb during recvmsg() from skb_array, this could be inefficient because of the bad cache utilization and spinlock touching for each packet. This patch tries to batch them by calling batch dequeuing helpers explicitly on the exported skb array and pass the skb back through msg_

[PATCH net-next V5 7/9] tun: support receiving skb through msg_control

2017-05-16 Thread Jason Wang
This patch makes tun_recvmsg() can receive from skb from its caller through msg_control. Vhost_net will be the first user. Signed-off-by: Jason Wang --- drivers/net/tun.c | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/drivers/net/tun.c b/drivers/net/tun.c

[PATCH net-next V5 3/9] ptr_ring: introduce batch dequeuing

2017-05-16 Thread Jason Wang
This patch introduce a batched version of consuming, consumer can dequeue more than one pointers from the ring at a time. We don't care about the reorder of reading here so no need for compiler barrier. Signed-off-by: Jason Wang --- include/linux/ptr_ring.h | 65 +

[PATCH net-next V5 8/9] tap: support receiving skb from msg_control

2017-05-16 Thread Jason Wang
This patch makes tap_recvmsg() can receive from skb from its caller through msg_control. Vhost_net will be the first user. Signed-off-by: Jason Wang --- drivers/net/tap.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/net/tap.c b/drivers/net/tap.c index

[PATCH net-next V5 6/9] tap: export skb_array

2017-05-16 Thread Jason Wang
This patch exports skb_array through tap_get_skb_array(). Caller can then manipulate skb array directly. Signed-off-by: Jason Wang --- drivers/net/tap.c | 13 + include/linux/if_tap.h | 5 + 2 files changed, 18 insertions(+) diff --git a/drivers/net/tap.c b/drivers/net/tap

[PATCH net-next V5 1/9] ptr_ring: add ptr_ring_unconsume

2017-05-16 Thread Jason Wang
From: "Michael S. Tsirkin" Applications that consume a batch of entries in one go can benefit from ability to return some of them back into the ring. Add an API for that - assuming there's space. If there's no space naturally can't do this and have to drop entries, but this implies ring is full

[PATCH net v3] net: x25: fix one potential use-after-free issue

2017-05-16 Thread linzhang
The function x25_init is not properly unregister related resources on error handler.It is will result in kernel oops if x25_init init failed, so add properly unregister call on error handler. Also, i adjust the coding style and make x25_register_sysctl properly return failure. Signed-off-by: linz

RE: Donation

2017-05-16 Thread Mayrhofer Family
Good Day, My wife and I have awarded you with a donation of $ 1,000,000.00 Dollars from part of our Jackpot Lottery of 50 Million Dollars, respond with your details for claims. We await your earliest response and God Bless you. Friedrich And Annand Mayrhofer. --- This email has been checked f

Re: [net-next,v2,1/3] net/sock: factor out dequeue/peek with offset code

2017-05-16 Thread Andrei Vagin
On Tue, May 16, 2017 at 11:20:13AM +0200, Paolo Abeni wrote: > And update __sk_queue_drop_skb() to work on the specified queue. > This will help the udp protocol to use an additional private > rx queue in a later patch. CRIU tests fails with this patch: recvmsg(14, {msg_name=NULL, msg_namelen=0,

[PATCH net-next 6/6] net: phy: marvell: checkpatch - Fix remaining long lines

2017-05-16 Thread Andrew Lunn
Fold lines longer than 80 characters Signed-off-by: Andrew Lunn --- drivers/net/phy/marvell.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/net/phy/marvell.c b/drivers/net/phy/marvell.c index d510eda92af5..88cd97b44ba6 100644 --- a/drivers/net/phy/marve

[PATCH net-next 0/6] net: phy: marvell: Checkpatch cleanup

2017-05-16 Thread Andrew Lunn
I will be contributing a few new features to the Marvell PHY driver soon. Start by making the code mostly checkpatch clean. There should not be any functional changes. Just comments set into the correct format, missing blank lines, turn some comparisons around, and refactoring to reduce indentation

[PATCH net-next 3/6] net: phy: marvell: Checkpatch - assignments and comparisons

2017-05-16 Thread Andrew Lunn
Avoid multiple assignments Comparisons should place the constant on the right side of the test Signed-off-by: Andrew Lunn --- drivers/net/phy/marvell.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/net/phy/marvell.c b/drivers/net/phy/marvell.c index f52656ec

[PATCH net-next 1/6] net: phy: Marvell: checkpatch - Comments

2017-05-16 Thread Andrew Lunn
Use net style comment blocks, and wrap one block with long lines. Signed-off-by: Andrew Lunn --- drivers/net/phy/marvell.c | 28 +++- 1 file changed, 15 insertions(+), 13 deletions(-) diff --git a/drivers/net/phy/marvell.c b/drivers/net/phy/marvell.c index 272b051a0199..

[PATCH net-next 4/6] net: phy: marvell: Refactor some bigger functions

2017-05-16 Thread Andrew Lunn
Break big functions up by using a number of smaller helper function. Solves some of the over 80 lines warnings, by reducing the indentation level. Signed-off-by: Andrew Lunn --- drivers/net/phy/marvell.c | 484 ++ 1 file changed, 271 insertions(+), 213

[PATCH net-next 2/6] net: phy: marvell: Checkpatch - Missing or extra blank lines

2017-05-16 Thread Andrew Lunn
Remove the extra blank lines, add one in where recommended. Signed-off-by: Andrew Lunn --- drivers/net/phy/marvell.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/net/phy/marvell.c b/drivers/net/phy/marvell.c index 2aacbf8e0eb3..f52656ec618f 100644 --- a/driver

[PATCH net-next 5/6] net: phy: marvell: Add helpers to get/set page

2017-05-16 Thread Andrew Lunn
Makes the code a bit more readable, and solves quite a few checkpatch warnings of lines longer than 80 characters. Signed-off-by: Andrew Lunn --- drivers/net/phy/marvell.c | 115 -- 1 file changed, 59 insertions(+), 56 deletions(-) diff --git a/driver

Re: [PATCH 2/6] wl1251: Use request_firmware_prefer_user() for loading NVS calibration data

2017-05-16 Thread Luis R. Rodriguez
On Tue, May 16, 2017 at 10:41:08AM +0200, Arend Van Spriel wrote: > On 16-5-2017 1:13, Luis R. Rodriguez wrote: > > On Fri, May 12, 2017 at 11:02:26PM +0200, Arend Van Spriel wrote: > >> try again.. replacing email address from Michał > >> On 12-5-2017 22:55, Arend Van Spriel wrote: > >>> Let me ex

Re: [PATCH v1] samples/bpf: Add a .gitignore for binaries

2017-05-16 Thread David Ahern
On 5/13/17 3:30 AM, Mickaël Salaün wrote: > > On 13/02/2017 02:43, David Ahern wrote: >> On 2/12/17 2:23 PM, Mickaël Salaün wrote: >>> diff --git a/samples/bpf/.gitignore b/samples/bpf/.gitignore >>> new file mode 100644 >>> index ..a7562a5ef4c2 >>> --- /dev/null >>> +++ b/samples/bpf/

Re: [PATCH net] selftests/bpf: fix broken build due to types.h

2017-05-16 Thread Yonghong Song
On 5/16/17 12:18 PM, David Miller wrote: Please correct the address of the netdev list (it is just plain 'netdev' not 'linux-netdev'). Thanks. Shortly after my first email, I sent a corrected submit as well. Sorry for the spam. Secondly, __always_inline should not be defined by types.h T

Re: [PATCH v2 1/3] bpf: Use 1<<16 as ceiling for immediate alignment in verifier.

2017-05-16 Thread Alexei Starovoitov
On 5/16/17 5:37 AM, Edward Cree wrote: On 15/05/17 17:04, David Miller wrote: If we use 1<<31, then sequences like: R1 = 0 R1 <<= 2 do silly things. Hmm. It might be a bit late for this, but I wonder if, instead of handling alignments as (1 << align), you could store them as

Re: [patch net-next v3 05/10] net: sched: move TC_H_MAJ macro call into tcf_auto_prio

2017-05-16 Thread Cong Wang
On Tue, May 16, 2017 at 2:03 PM, Jiri Pirko wrote: > Tue, May 16, 2017 at 11:01:52PM CEST, xiyou.wangc...@gmail.com wrote: >>On Tue, May 16, 2017 at 10:27 AM, Jiri Pirko wrote: >>> From: Jiri Pirko >>> >>> Call the helper from the function rather than to always adjust the >>> return value of the

Re: [PATCH v3 net-next 5/7] net: don't make false software transmit timestamps

2017-05-16 Thread Willem de Bruijn
On Tue, May 16, 2017 at 8:44 AM, Miroslav Lichvar wrote: > If software timestamping is enabled by the SO_TIMESTAMP(NS) option > when a message without timestamp is already waiting in the queue, the > __sock_recv_timestamp() function will read the current time to make a > timestamp in order to alwa

Re: [patch net-next v3 02/10] net: sched: introduce tcf block infractructure

2017-05-16 Thread Cong Wang
On Tue, May 16, 2017 at 2:34 PM, David Miller wrote: > From: Cong Wang > Date: Tue, 16 May 2017 13:51:30 -0700 > >> On Tue, May 16, 2017 at 10:27 AM, Jiri Pirko wrote: >>> +int tcf_block_get(struct tcf_block **p_block, >>> + struct tcf_proto __rcu **p_filter_chain) >>> +{ >>> +

Re: [PATCH v3 net-next 6/7] net: allow simultaneous SW and HW transmit timestamping

2017-05-16 Thread Willem de Bruijn
On Tue, May 16, 2017 at 8:44 AM, Miroslav Lichvar wrote: > Add SOF_TIMESTAMPING_OPT_TX_SWHW option to allow an outgoing packet to > be looped to the socket's error queue with a software timestamp even > when a hardware transmit timestamp is expected to be provided by the > driver. > > Applications

Re: [PATCH v3 net-next 3/7] net: add function to retrieve original skb device using NAPI ID

2017-05-16 Thread Willem de Bruijn
On Tue, May 16, 2017 at 8:44 AM, Miroslav Lichvar wrote: > Since commit b68581778cd0 ("net: Make skb->skb_iif always track > skb->dev") skbs don't have the original index of the interface which > received the packet. This information is now needed for a new control > message related to hardware ti

Re: [PATCH v3 net-next 4/7] net: add new control message for incoming HW-timestamped packets

2017-05-16 Thread Willem de Bruijn
On Tue, May 16, 2017 at 8:44 AM, Miroslav Lichvar wrote: > Add SOF_TIMESTAMPING_OPT_PKTINFO option to request a new control message > for incoming packets with hardware timestamps. It contains the index of > the real interface which received the packet and the length of the > packet at layer 2. >

Re: [patch net-next v3 06/10] net: sched: introduce helpers to work with filter chains

2017-05-16 Thread Cong Wang
On Tue, May 16, 2017 at 10:27 AM, Jiri Pirko wrote: > +static struct tcf_proto *tcf_chain_tp_prev(struct tcf_chain_info *chain_info) > +{ > + return rtnl_dereference(*chain_info->pprev); > +} > + > +static void tcf_chain_tp_insert(struct tcf_chain *chain, > + st

Re: [PATCH v8 3/5] rxrpc: check return value of skb_to_sgvec always

2017-05-16 Thread Jason A. Donenfeld
On Mon, May 15, 2017 at 3:11 PM, David Howells wrote: > skb_to_sgvec() can return -EMSGSIZE in some circumstances. You shouldn't > return -ENOMEM here in such a case. Noted. I'll fix this up for the next round.

Re: [PATCH v8 1/5] skbuff: return -EMSGSIZE in skb_to_sgvec to prevent overflow

2017-05-16 Thread Jason A. Donenfeld
On Mon, May 15, 2017 at 3:12 PM, David Howells wrote: > Is there a reason you moved skb_to_sgvec() in the file rather than just moving > the comment to it (since you moved the comment anyway)? 1) Because it's easier to understand skb_to_sgvec_nomark as a variant of skb_to_sgvec, so I'd rather skb

RE: Donation

2017-05-16 Thread Mayrhofer Family
Good Day, My wife and I have awarded you with a donation of $ 1,000,000.00 Dollars from part of our Jackpot Lottery of 50 Million Dollars, respond with your details for claims. We await your earliest response and God Bless you. Friedrich And Annand Mayrhofer. --- This email has been checked f

[PATCH net-next] tcp: warn on negative reordering values

2017-05-16 Thread Soheil Hassas Yeganeh
From: Soheil Hassas Yeganeh Commit bafbb9c73241 ("tcp: eliminate negative reordering in tcp_clean_rtx_queue") fixes an issue for negative reordering metrics. To be resilient to such errors, warn and return when a negative metric is passed to tcp_update_reordering(). Signed-off-by: Soheil Hassas

Re: [patch net-next v3 02/10] net: sched: introduce tcf block infractructure

2017-05-16 Thread David Miller
From: Cong Wang Date: Tue, 16 May 2017 13:51:30 -0700 > On Tue, May 16, 2017 at 10:27 AM, Jiri Pirko wrote: >> +int tcf_block_get(struct tcf_block **p_block, >> + struct tcf_proto __rcu **p_filter_chain) >> +{ >> + struct tcf_block *block = kzalloc(sizeof(*block), GFP_KERNE

[PATCH net-next 06/15] tcp_bbr: use tcp_jiffies32 instead of tcp_time_stamp

2017-05-16 Thread Eric Dumazet
Use tcp_jiffies32 instead of tcp_time_stamp, since tcp_time_stamp will soon be only used for TCP TS option. Signed-off-by: Eric Dumazet --- net/ipv4/tcp_bbr.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/net/ipv4/tcp_bbr.c b/net/ipv4/tcp_bbr.c index 92b045c72

[PATCH net-next 12/15] tcp_westwood: use tcp_jiffies32 instead of tcp_time_stamp

2017-05-16 Thread Eric Dumazet
This CC does not need 1 ms tcp_time_stamp and can use the jiffy based 'timestamp'. Signed-off-by: Eric Dumazet --- net/ipv4/tcp_westwood.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/net/ipv4/tcp_westwood.c b/net/ipv4/tcp_westwood.c index 9775453b8d174c848dc09df83d

[PATCH net-next 01/15] tcp: use tp->tcp_mstamp in output path

2017-05-16 Thread Eric Dumazet
Idea is to later convert tp->tcp_mstamp to a full u64 counter using usec resolution, so that we can later have fine grained TCP TS clock (RFC 7323), regardless of HZ value. We try to refresh tp->tcp_mstamp only when necessary. Signed-off-by: Eric Dumazet --- net/ipv4/tcp_ipv4.c | 1 + net/

[PATCH net-next 13/15] tcp_lp: cache tcp_time_stamp

2017-05-16 Thread Eric Dumazet
tcp_time_stamp will become slightly more expensive soon, cache its value. Signed-off-by: Eric Dumazet --- net/ipv4/tcp_lp.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/net/ipv4/tcp_lp.c b/net/ipv4/tcp_lp.c index d6fb6c067af4641f232b94e7c590c212648e8173..ef3122abb3

[PATCH net-next 10/15] tcp: uses jiffies_32 to feed tp->chrono_start

2017-05-16 Thread Eric Dumazet
tcp_time_stamp will no longer be tied to jiffies. Signed-off-by: Eric Dumazet --- net/ipv4/tcp.c| 2 +- net/ipv4/tcp_output.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/net/ipv4/tcp.c b/net/ipv4/tcp.c index d0bb61ee28bbceff8f2e27416ce87fec94935973..b85bfe7cb1

[PATCH net-next 07/15] tcp: bic,cubic: use tcp_jiffies32 instead of tcp_time_stamp

2017-05-16 Thread Eric Dumazet
Use tcp_jiffies32 instead of tcp_time_stamp, since tcp_time_stamp will soon be only used for TCP TS option. Signed-off-by: Eric Dumazet --- net/ipv4/tcp_bic.c | 6 +++--- net/ipv4/tcp_cubic.c | 12 ++-- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/net/ipv4/tcp_bic.c

[PATCH net-next 15/15] tcp: switch TCP TS option (RFC 7323) to 1ms clock

2017-05-16 Thread Eric Dumazet
TCP Timestamps option is defined in RFC 7323 Traditionally on linux, it has been tied to the internal 'jiffies' variable, because it had been a cheap and good enough generator. For TCP flows on the Internet, 1 ms resolution would be much better than 4ms or 10ms (HZ=250 or HZ=100 respectively) Fo

[PATCH net-next 03/15] dccp: do not use tcp_time_stamp

2017-05-16 Thread Eric Dumazet
Use our own macro instead of abusing tcp_time_stamp Signed-off-by: Eric Dumazet --- net/dccp/ccids/ccid2.c | 8 net/dccp/ccids/ccid2.h | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/net/dccp/ccids/ccid2.c b/net/dccp/ccids/ccid2.c index 5e3a7302f7747e4c4f3134eaca

[PATCH net-next 05/15] tcp: use tcp_jiffies32 to feed tp->snd_cwnd_stamp

2017-05-16 Thread Eric Dumazet
Use tcp_jiffies32 instead of tcp_time_stamp to feed tp->snd_cwnd_stamp. tcp_time_stamp will soon be a litle bit more expensive than simply reading 'jiffies'. Signed-off-by: Eric Dumazet --- net/ipv4/tcp_input.c | 14 +++--- net/ipv4/tcp_metrics.c | 2 +- net/ipv4/tcp_output.c | 8 +

[PATCH net-next 08/15] tcp: use tcp_jiffies32 for rcv_tstamp and lrcvtime

2017-05-16 Thread Eric Dumazet
Use tcp_jiffies32 instead of tcp_time_stamp, since tcp_time_stamp will soon be only used for TCP TS option. Signed-off-by: Eric Dumazet --- include/net/tcp.h| 4 ++-- net/ipv4/tcp_input.c | 6 +++--- net/ipv4/tcp_minisocks.c | 2 +- net/ipv4/tcp_output.c| 2 +- net/ipv4/tcp_timer

[PATCH net-next 04/15] tcp: use tcp_jiffies32 to feed tp->lsndtime

2017-05-16 Thread Eric Dumazet
Use tcp_jiffies32 instead of tcp_time_stamp to feed tp->lsndtime. tcp_time_stamp will soon be a litle bit more expensive than simply reading 'jiffies'. Signed-off-by: Eric Dumazet --- include/net/tcp.h | 2 +- net/ipv4/tcp.c| 2 +- net/ipv4/tcp_cubic.c | 2 +- net/ipv4/tcp_input.c

[PATCH net-next 09/15] tcp: use tcp_jiffies32 to feed probe_timestamp

2017-05-16 Thread Eric Dumazet
Use tcp_jiffies32 instead of tcp_time_stamp, since tcp_time_stamp will soon be only used for TCP TS option. Signed-off-by: Eric Dumazet --- net/ipv4/tcp_output.c | 6 +++--- net/ipv4/tcp_timer.c | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/net/ipv4/tcp_output.c b/net/i

[PATCH net-next 11/15] tcp: use tcp_jiffies32 in __tcp_oow_rate_limited()

2017-05-16 Thread Eric Dumazet
This place wants to use tcp_jiffies32, this is good enough. Signed-off-by: Eric Dumazet --- net/ipv4/tcp_input.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/ipv4/tcp_input.c b/net/ipv4/tcp_input.c index eeb4967df25a8dc35128d0a0848b5ae7ee6d63e3..85575888365a10643e

[PATCH net-next 14/15] tcp: replace misc tcp_time_stamp to tcp_jiffies32

2017-05-16 Thread Eric Dumazet
After this patch, all uses of tcp_time_stamp will require a change when we introduce 1 ms and/or 1 us TCP TS option. Signed-off-by: Eric Dumazet --- net/ipv4/tcp.c | 2 +- net/ipv4/tcp_htcp.c | 2 +- net/ipv4/tcp_input.c | 2 +- net/ipv4/tcp_minisocks.c | 2 +- net/ipv4/tcp_ou

[PATCH net-next 02/15] tcp: introduce tcp_jiffies32

2017-05-16 Thread Eric Dumazet
We abuse tcp_time_stamp for two different cases : 1) base to generate TCP Timestamp options (RFC 7323) 2) A 32bit version of jiffies since some TCP fields are 32bit wide to save memory. Since we want in the future to have 1ms TCP TS clock, regardless of HZ value, we want to cleanup things. t

[PATCH net-next 00/15] tcp: TCP TS option use 1 ms clock

2017-05-16 Thread Eric Dumazet
TCP Timestamps option is defined in RFC 7323 Traditionally on linux, it has been tied to the internal 'jiffy' variable, because it had been a cheap and good enough generator. Unfortunately some distros use HZ=250 or even HZ=100 leading to not very useful TCP timestamps. For TCP flows in the DC,

[PATCH] netlink: Change rtnl_dump_done to always show error

2017-05-16 Thread David Ahern
The original code which became rtnl_dump_done only shows netlink errors if the protocol is NETLINK_SOCK_DIAG, but netlink dumps always appends the length which contains any error encountered during the dump. Update rtnl_dump_done to always show the error if there is one. As an *example* without th

Re: [PATCH net-next] net: dsa: store CPU port pointer in the tree

2017-05-16 Thread Florian Fainelli
On 05/16/2017 11:10 AM, Vivien Didelot wrote: > A dsa_switch_tree instance holds a dsa_switch pointer and a port index > to identify the switch port to which the CPU is attached. > > Now that the DSA layer has a dsa_port structure to hold this data, use > it to point the switch CPU port. > > This

Re: [PATCH net-next 0/2] net: dsa: Sort various lists

2017-05-16 Thread Vivien Didelot
Hi Andrew, Andrew Lunn writes: > As we gain more DSA drivers and tagging protocols, the lists are > getting a bit unruly. Do some sorting. I'm glad to see that I'm not the only one picky with alphabetically ordering (when possible) files, function names and so on. Thanks! Vivien

Re: [PATCH net-next 2/2] drivers: net: DSA: Sort drivers

2017-05-16 Thread Florian Fainelli
On 05/16/2017 01:40 PM, Andrew Lunn wrote: > With more drivers being added, it is time to sort the drivers to > impose some order. > > Signed-off-by: Andrew Lunn Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH net-next 2/2] drivers: net: DSA: Sort drivers

2017-05-16 Thread Vivien Didelot
Andrew Lunn writes: > With more drivers being added, it is time to sort the drivers to > impose some order. > > Signed-off-by: Andrew Lunn Reviewed-by: Vivien Didelot

Re: [PATCH net-next 1/2] net: dsa: Sort DSA tagging protocol drivers

2017-05-16 Thread Vivien Didelot
Andrew Lunn writes: > With more tag protocols being added, regain some order by sorting the > entries in various places. > > Signed-off-by: Andrew Lunn Reviewed-by: Vivien Didelot

Re: [patch net-next v3 01/10] net: sched: move tc_classify function to cls_api.c

2017-05-16 Thread Jiri Pirko
Tue, May 16, 2017 at 11:03:14PM CEST, xiyou.wangc...@gmail.com wrote: >On Tue, May 16, 2017 at 2:00 PM, Jiri Pirko wrote: >> Tue, May 16, 2017 at 10:25:35PM CEST, xiyou.wangc...@gmail.com wrote: >>>On Tue, May 16, 2017 at 10:27 AM, Jiri Pirko wrote: From: Jiri Pirko Move tc_classi

Re: [patch net-next v3 01/10] net: sched: move tc_classify function to cls_api.c

2017-05-16 Thread Cong Wang
On Tue, May 16, 2017 at 2:00 PM, Jiri Pirko wrote: > Tue, May 16, 2017 at 10:25:35PM CEST, xiyou.wangc...@gmail.com wrote: >>On Tue, May 16, 2017 at 10:27 AM, Jiri Pirko wrote: >>> From: Jiri Pirko >>> >>> Move tc_classify function to cls_api.c where it belongs, rename it to >>> fit the namespac

Re: [patch net-next v3 05/10] net: sched: move TC_H_MAJ macro call into tcf_auto_prio

2017-05-16 Thread Jiri Pirko
Tue, May 16, 2017 at 11:01:52PM CEST, xiyou.wangc...@gmail.com wrote: >On Tue, May 16, 2017 at 10:27 AM, Jiri Pirko wrote: >> From: Jiri Pirko >> >> Call the helper from the function rather than to always adjust the >> return value of the function. > >And rename the function name to reflect this

Re: [patch net-next v3 05/10] net: sched: move TC_H_MAJ macro call into tcf_auto_prio

2017-05-16 Thread Cong Wang
On Tue, May 16, 2017 at 10:27 AM, Jiri Pirko wrote: > From: Jiri Pirko > > Call the helper from the function rather than to always adjust the > return value of the function. And rename the function name to reflect this change?

Re: [patch net-next v3 01/10] net: sched: move tc_classify function to cls_api.c

2017-05-16 Thread Jiri Pirko
Tue, May 16, 2017 at 10:25:35PM CEST, xiyou.wangc...@gmail.com wrote: >On Tue, May 16, 2017 at 10:27 AM, Jiri Pirko wrote: >> From: Jiri Pirko >> >> Move tc_classify function to cls_api.c where it belongs, rename it to >> fit the namespace. >> > >It is not a pure move, you silently remove the CON

Re: [patch net-next v3 02/10] net: sched: introduce tcf block infractructure

2017-05-16 Thread Jiri Pirko
Tue, May 16, 2017 at 10:51:30PM CEST, xiyou.wangc...@gmail.com wrote: >On Tue, May 16, 2017 at 10:27 AM, Jiri Pirko wrote: >> +int tcf_block_get(struct tcf_block **p_block, >> + struct tcf_proto __rcu **p_filter_chain) >> +{ >> + struct tcf_block *block = kzalloc(sizeof(*bloc

Re: [patch net-next v3 02/10] net: sched: introduce tcf block infractructure

2017-05-16 Thread Cong Wang
On Tue, May 16, 2017 at 10:27 AM, Jiri Pirko wrote: > +int tcf_block_get(struct tcf_block **p_block, > + struct tcf_proto __rcu **p_filter_chain) > +{ > + struct tcf_block *block = kzalloc(sizeof(*block), GFP_KERNEL); > + > + if (!block) > + return -ENOMEM

Re: [PATCH v2 net-next 06/12] ep93xx_eth: add GRO support

2017-05-16 Thread Eric Dumazet
On Tue, May 16, 2017 at 1:41 PM, Alexander Sverdlin wrote: > it turns out I've used this patch two weeks long already in 4.11; but I've > spent > a couple of hours now torturing the new driver and was not able to provoke > any inadequate behavior. It either receives all packets in time or not at

Re: [PATCH net-next] net: dsa: store CPU port pointer in the tree

2017-05-16 Thread Andrew Lunn
On Tue, May 16, 2017 at 02:10:33PM -0400, Vivien Didelot wrote: > A dsa_switch_tree instance holds a dsa_switch pointer and a port index > to identify the switch port to which the CPU is attached. > > Now that the DSA layer has a dsa_port structure to hold this data, use > it to point the switch C

[PATCH net-next 1/2] net: dsa: Sort DSA tagging protocol drivers

2017-05-16 Thread Andrew Lunn
With more tag protocols being added, regain some order by sorting the entries in various places. Signed-off-by: Andrew Lunn --- include/net/dsa.h | 8 net/dsa/Kconfig| 8 net/dsa/Makefile | 6 +++--- net/dsa/dsa.c | 18 +- net/dsa/dsa_priv.h | 18

Re: [PATCH v2 net-next 06/12] ep93xx_eth: add GRO support

2017-05-16 Thread Alexander Sverdlin
Hello all, On 15/05/17 23:02, Alexander Sverdlin wrote: >>> I don't know if we really care about this hardware anymore (I don't), >>> but the ep93xx platform is still listed as being maintained in the >>> MAINTAINERS file -- adding Ryan and Hartley. >> I no longer have any ep93xx hardware to test

[PATCH net-next 0/2] net: dsa: Sort various lists

2017-05-16 Thread Andrew Lunn
As we gain more DSA drivers and tagging protocols, the lists are getting a bit unruly. Do some sorting. Andrew Lunn (2): net: dsa: Sort DSA tagging protocol drivers drivers: net: DSA: Sort drivers drivers/net/dsa/Kconfig | 40 drivers/net/dsa/Makefil

[PATCH net-next 2/2] drivers: net: DSA: Sort drivers

2017-05-16 Thread Andrew Lunn
With more drivers being added, it is time to sort the drivers to impose some order. Signed-off-by: Andrew Lunn --- drivers/net/dsa/Kconfig | 40 drivers/net/dsa/Makefile | 6 +++--- 2 files changed, 23 insertions(+), 23 deletions(-) diff --git a/driver

[PATCH net 0/2] bnxt_en: DCBX fixes.

2017-05-16 Thread Michael Chan
2 bug fixes for the case where the NIC's firmware DCBX agent is enabled. With these fixes, we will return the proper information to lldpad. Michael Chan (2): bnxt_en: Call bnxt_dcb_init() after getting firmware DCBX configuration. bnxt_en: Check status of firmware DCBX agent before setting

[PATCH net 1/2] bnxt_en: Call bnxt_dcb_init() after getting firmware DCBX configuration.

2017-05-16 Thread Michael Chan
In the current code, bnxt_dcb_init() is called too early before we determine if the firmware DCBX agent is running or not. As a result, we are not setting the DCB_CAP_DCBX_HOST and DCB_CAP_DCBX_LLD_MANAGED flags properly to report to DCBNL. Signed-off-by: Michael Chan --- drivers/net/ethernet/b

[PATCH net 2/2] bnxt_en: Check status of firmware DCBX agent before setting DCB_CAP_DCBX_HOST.

2017-05-16 Thread Michael Chan
Otherwise, all the host based DCBX settings from lldpad will fail if the firmware DCBX agent is running. Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt_dcb.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt

[PATCH net] net: fix compile error in skb_orphan_partial()

2017-05-16 Thread Eric Dumazet
From: Eric Dumazet If CONFIG_INET is not set, net/core/sock.c can not compile : net/core/sock.c: In function ‘skb_orphan_partial’: net/core/sock.c:1810:2: error: implicit declaration of function ‘skb_is_tcp_pure_ack’ [-Werror=implicit-function-declaration] if (skb_is_tcp_pure_ack(skb)) ^ Fi

Re: [patch net-next v3 01/10] net: sched: move tc_classify function to cls_api.c

2017-05-16 Thread Cong Wang
On Tue, May 16, 2017 at 10:27 AM, Jiri Pirko wrote: > From: Jiri Pirko > > Move tc_classify function to cls_api.c where it belongs, rename it to > fit the namespace. > It is not a pure move, you silently remove the CONFIG_NET_CLS_ACT macros in tc_classify(). Probably not buggy, just redundancy w

Re: switchdev offload & ecmp

2017-05-16 Thread Nicolas Dichtel
Le 16/05/2017 à 16:11, Ido Schimmel a écrit : > On Tue, May 16, 2017 at 02:57:47PM +0200, Nicolas Dichtel wrote: I suspect that there can be scenarii where some packets of a flow are forwarded by the driver and some other are forwarded by the kernel. >>> >>> Can you elaborate? The k

Re: linux-next: Tree for May 16 (net/core)

2017-05-16 Thread Eric Dumazet
On Tue, May 16, 2017 at 12:44 PM, Paul Gortmaker wrote: > On Tue, May 16, 2017 at 12:28 PM, Randy Dunlap wrote: >> On 05/15/17 18:21, Stephen Rothwell wrote: >>> Hi all, >>> >>> Changes since 20170515: >>> >> >> on i386 or x86_64: >> >> when CONFIG_INET is not enabled: >> >> ../net/core/sock.c: I

Re: [PATCH net-next] geneve: add rtnl changelink support

2017-05-16 Thread Girish Moodalbail
On 5/16/17 12:31 PM, David Miller wrote: From: Girish Moodalbail Date: Mon, 15 May 2017 10:47:04 -0700 if (data[IFLA_GENEVE_REMOTE]) { - info.key.u.ipv4.dst = + info->key.u.ipv4.dst = nla_get_in_addr(data[IFLA_GENEVE_REMOTE]); -

Re: [PATCH net-next] geneve: add rtnl changelink support

2017-05-16 Thread Pravin Shelar
On Mon, May 15, 2017 at 10:47 AM, Girish Moodalbail wrote: > This patch adds changelink rtnl operation support for geneve devices. > Code changes involve: > - refactor geneve_newlink into geneve_nl2info to be used by both > geneve_newlink and geneve_changelink > - geneve_nl2info takes a ch

Re: [PATCH] liquidio: use pcie_flr instead of duplicating it

2017-05-16 Thread David Miller
From: Christoph Hellwig Date: Tue, 16 May 2017 16:21:46 +0200 > Signed-off-by: Christoph Hellwig > Tested-by: Felix Manlunas Applied to net-next, thanks.

Re: [PATCH] net: phy: Remove residual magic from PHY drivers

2017-05-16 Thread David Miller
From: Andrew Lunn Date: Tue, 16 May 2017 18:29:11 +0200 > commit fa8cddaf903c ("net phylib: Remove unnecessary condition check in phy") > removed the only place where the PHY flag PHY_HAS_MAGICANEG was > checked. But it left the flag being set in the drivers. Remove the flag. > > Signed-off-by:

Re: [PATCH 1/1] dt-binding: net: wireless: fix node name in the BCM43xx example

2017-05-16 Thread Martin Blumenstingl
Hi Arend, On Tue, May 16, 2017 at 12:05 AM, Arend Van Spriel wrote: > On 15-5-2017 22:13, Martin Blumenstingl wrote: >> The example in the BCM43xx documentation uses "brcmf" as node name. >> However, wireless devices should be named "wifi" instead. Fix this to > > Hi Martin, > > Since when is tha

Re: [PATCH 4.4-only] openvswitch: clear sender cpu before forwarding packets

2017-05-16 Thread Joe Stringer
On 16 May 2017 at 07:25, Anoob Soman wrote: > Similar to commit c29390c6dfee ("xps: must clear sender_cpu before > forwarding") the skb->sender_cpu needs to be cleared before forwarding > packets. > > Fixes: 2bd82484bb4c ("xps: fix xps for stacked devices") > Signed-off-by: Anoob Soman Is this n

Re: [PATCH net-next] cxgb4: update latest firmware version supported

2017-05-16 Thread David Miller
From: Ganesh Goudar Date: Tue, 16 May 2017 20:56:52 +0530 > Change t4fw_version.h to update latest firmware version > number to 1.16.43.0. > > Signed-off-by: Ganesh Goudar People are hitting regressions in 'net' due to using firmware allowed by the current defines in combination with the FEC d

Re: [PATCH v2 1/3] bpf: Use 1<<16 as ceiling for immediate alignment in verifier.

2017-05-16 Thread David Miller
From: Edward Cree Date: Tue, 16 May 2017 13:37:42 +0100 > On 15/05/17 17:04, David Miller wrote: >> If we use 1<<31, then sequences like: >> >> R1 = 0 >> R1 <<= 2 >> >> do silly things. > Hmm. It might be a bit late for this, but I wonder if, instead of handling > alignments as (1 <<

Re: [PATCH net-next] bnx2x: Remove open coded carrier check

2017-05-16 Thread David Miller
From: Leon Romanovsky Date: Tue, 16 May 2017 15:20:56 +0300 > From: Leon Romanovsky > > There is inline function to test if carrier present, > so it makes open-coded solution redundant. > > Signed-off-by: Leon Romanovsky Applied.

Re: [PATCH] [net, 4.12] mlx5e: add CONFIG_INET dependency

2017-05-16 Thread David Miller
From: Arnd Bergmann Date: Tue, 16 May 2017 13:27:49 +0200 > We now reference the arp_tbl, which requires IPv4 support to be > enabled in the kernel, otherwise we get a link error: > > drivers/net/built-in.o: In function `mlx5e_tc_update_neigh_used_value': > (.text+0x16afec): undefined reference

Re: [patch iproute2 v2 repost 1/3] tc_filter: add support for chain index

2017-05-16 Thread Jiri Pirko
Tue, May 16, 2017 at 08:16:58PM CEST, step...@networkplumber.org wrote: >On Tue, 16 May 2017 19:29:35 +0200 >Jiri Pirko wrote: > >> From: Jiri Pirko >> >> Allow user to put filter to a specific chain identified by index. >> >> Signed-off-by: Jiri Pirko > >This will have to wait for the chain b

Re: [PATCH v2 net-next] tcp: internal implementation for pacing

2017-05-16 Thread David Miller
From: Eric Dumazet Date: Tue, 16 May 2017 04:24:36 -0700 > BBR congestion control depends on pacing, and pacing is > currently handled by sch_fq packet scheduler for performance reasons, > and also because implemening pacing with FQ was convenient to truly > avoid bursts. > > However there are m

Re: linux-next: Tree for May 16 (net/core)

2017-05-16 Thread Paul Gortmaker
On Tue, May 16, 2017 at 12:28 PM, Randy Dunlap wrote: > On 05/15/17 18:21, Stephen Rothwell wrote: >> Hi all, >> >> Changes since 20170515: >> > > on i386 or x86_64: > > when CONFIG_INET is not enabled: > > ../net/core/sock.c: In function 'skb_orphan_partial': > ../net/core/sock.c:1810:2: error: i

Re: [PATCH net-next v2 0/3] udp: scalability improvements

2017-05-16 Thread David Miller
From: Paolo Abeni Date: Tue, 16 May 2017 11:20:12 +0200 > This patch series implement an idea suggested by Eric Dumazet to > reduce the contention of the udp sk_receive_queue lock when the socket is > under flood. Series applied, thanks a lot.

Re: [PATCH net-next] geneve: add rtnl changelink support

2017-05-16 Thread David Miller
From: Girish Moodalbail Date: Mon, 15 May 2017 10:47:04 -0700 > if (data[IFLA_GENEVE_REMOTE]) { > - info.key.u.ipv4.dst = > + info->key.u.ipv4.dst = > nla_get_in_addr(data[IFLA_GENEVE_REMOTE]); > > - if (IN_MULTICAST(ntohl(info.key

Re: [PATCH] net/smc: mark as BROKEN due to remote memory exposure

2017-05-16 Thread Doug Ledford
On Tue, 2017-05-16 at 14:52 -0400, David Miller wrote: > From: Doug Ledford > Date: Tue, 16 May 2017 14:03:22 -0400 > > > On Tue, 2017-05-16 at 13:36 -0400, David Miller wrote: > >> From: Doug Ledford > >> Date: Tue, 16 May 2017 13:20:44 -0400 > >>  > >> > Anyway, we're just talking out what hap

Re: [PATCH net] selftests/bpf: fix broken build due to types.h

2017-05-16 Thread David Miller
Please correct the address of the netdev list (it is just plain 'netdev' not 'linux-netdev'). Secondly, __always_inline should not be defined by types.h That has to come from linux/compiler.h which we have no reason to define a private version of for eBPF clang compilation. The problem is that

  1   2   3   >