From: Markus Elfring
Date: Mon, 22 May 2017 08:42:28 +0200
Omit two extra messages for memory allocation failures in these functions.
This issue was detected by using the Coccinelle software.
Link:
http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf
S
On Sun, 21 May 2017 15:10:29 -0700
Tom Herbert wrote:
> On Sun, May 21, 2017 at 9:04 AM, Jesper Dangaard Brouer
> wrote:
> > On Sat, 20 May 2017 09:16:09 -0700
> > Tom Herbert wrote:
> >
> >> > +/* XDP rxhash have an associated type, which is related to the RSS
> >> > + * (Receive Side Scalin
Fixed a coding style issue
Signed-off-by: Rohit Chavan
---
net/ipv4/tcp.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/net/ipv4/tcp.c b/net/ipv4/tcp.c
index 1e4c76d..87b0296 100644
--- a/net/ipv4/tcp.c
+++ b/net/ipv4/tcp.c
@@ -2183,7 +2183,7 @@ void tcp_close(struct s
From: Markus Elfring
Date: Mon, 22 May 2017 08:03:17 +0200
Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Link:
http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf
Sign
From: Markus Elfring
Date: Mon, 22 May 2017 07:32:46 +0200
Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Link:
http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf
Sign
From: Markus Elfring
Date: Mon, 22 May 2017 08:08:04 +0200
Two update suggestions were taken into account
from static source code analysis.
Markus Elfring (2):
Delete an error message for a failed memory allocation in ca8210_probe()
Delete an error message for a failed memory allocation in c
From: Markus Elfring
Date: Mon, 22 May 2017 06:42:33 +0200
Replace the specification of a data structure by a pointer dereference
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style convention.
Signed-off-by: Mar
From: Markus Elfring
Date: Mon, 22 May 2017 06:33:48 +0200
Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Link:
http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf
Sign
From: Markus Elfring
Date: Mon, 22 May 2017 07:04:03 +0200
Two update suggestions were taken into account
from static source code analysis.
Markus Elfring (2):
Delete an error message for a failed memory allocation
Improve a size determination
drivers/net/usb/usbnet.c | 7 ++-
1 file c
Begin forwarded message:
Date: Sun, 21 May 2017 08:53:17 +
From: bugzilla-dae...@bugzilla.kernel.org
To: step...@networkplumber.org
Subject: [Bug 195835] New: regression: tcp_fastretrans_alert
https://bugzilla.kernel.org/show_bug.cgi?id=195835
Bug ID: 195835
Summary
On 05/21/2017 08:21 PM, Alexei Starovoitov wrote:
> On Sun, May 21, 2017 at 05:55:50PM +0200, Jesper Dangaard Brouer wrote:
>>> And it looks useful to me, but
>>
>>> 1. i'm worried that we'd be relying on something that mellanox didn't
>>> implement in their drivers before. Was it tested and guarn
On Sun, May 21, 2017 at 11:35 PM, David Miller wrote:
> From: Willem de Bruijn
> Date: Sun, 21 May 2017 23:31:47 -0400
>
>> From: Willem de Bruijn
>>
>> The newly introduced timestamping option SCM_TIMESTAMPING_PKTINFO
>> is defined in asm-generic/socket.h. Also define it in the architecture
>>
On Sun, May 21, 2017 at 9:16 PM, Stephen Rothwell wrote:
> Hi all,
>
> After merging the net-next tree, today's linux-next build (powerpc
> ppc64_defconfig) failed like this:
>
> net/socket.c: In function 'put_ts_pktinfo':
> net/socket.c:695:28: error: 'SCM_TIMESTAMPING_PKTINFO' undeclared (first
Hi Dave,
On Sun, 21 May 2017 23:14:10 -0400 (EDT) David Miller
wrote:
>
> From: Stephen Rothwell
> Date: Mon, 22 May 2017 11:16:05 +1000
>
> > After merging the net-next tree, today's linux-next build (powerpc
> > ppc64_defconfig) failed like this:
> >
> > net/socket.c: In function 'put_ts_pk
From: Willem de Bruijn
Date: Sun, 21 May 2017 23:31:47 -0400
> From: Willem de Bruijn
>
> The newly introduced timestamping option SCM_TIMESTAMPING_PKTINFO
> is defined in asm-generic/socket.h. Also define it in the architecture
> specific versions.
>
> Fixes: aad9c8c470f2 ("net: add new contr
From: Willem de Bruijn
The newly introduced timestamping option SCM_TIMESTAMPING_PKTINFO
is defined in asm-generic/socket.h. Also define it in the architecture
specific versions.
Fixes: aad9c8c470f2 ("net: add new control message for incoming HW-timestamped
packets")
Reported-by: Stephen Rothwe
On Mon, May 22, 2017 at 1:35 AM, Alexander Duyck
wrote:
> On Sat, May 20, 2017 at 2:15 PM, Or Gerlitz wrote:
>> On Sat, May 20, 2017 at 3:58 AM, Amritha Nambiar
>> wrote:
>>> The following series introduces a new harware offload mode in tc/mqprio
>>
>> Wait, we have already a HW QoS model introd
On Sun, May 21, 2017 at 05:55:50PM +0200, Jesper Dangaard Brouer wrote:
> > And it looks useful to me, but
>
> > 1. i'm worried that we'd be relying on something that mellanox didn't
> > implement in their drivers before. Was it tested and guarnteed to
> > exist in the future revisions of firmwa
From: Stephen Rothwell
Date: Mon, 22 May 2017 11:16:05 +1000
> After merging the net-next tree, today's linux-next build (powerpc
> ppc64_defconfig) failed like this:
>
> net/socket.c: In function 'put_ts_pktinfo':
> net/socket.c:695:28: error: 'SCM_TIMESTAMPING_PKTINFO' undeclared (first use
>
We have a setup where two VoIP phones are communicating through a
router on a trusted LAN where the H.245 ALG is dropping some of the
traffic, so far as I can tell without good cause. These two devices
are configured differently, one with Fast Connect and one without -
this might be the reason, but
When two VoIP end points are configured differently (fast connect /
not fast connect) the ALG was failing to find a matching expectation
and dropping packets in one direction.
Dropping packets not the job of an ALG, and as such the behaviour
has been changed to allow the packet to be send to the f
Hi all,
After merging the net-next tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:
net/socket.c: In function 'put_ts_pktinfo':
net/socket.c:695:28: error: 'SCM_TIMESTAMPING_PKTINFO' undeclared (first use in
this function)
put_cmsg(msg, SOL_SOCKET, SCM_TIMESTAMPING_PK
On Sat, May 20, 2017 at 2:15 PM, Or Gerlitz wrote:
> On Sat, May 20, 2017 at 3:58 AM, Amritha Nambiar
> wrote:
>> The following series introduces a new harware offload mode in tc/mqprio
>
> Wait, we have already a HW QoS model introduced by John F and Co
> couple of years ago, right?
I assume y
On Sun, May 21, 2017 at 01:00:33PM -0400, David Miller wrote:
> From: Pablo Neira Ayuso
> Date: Fri, 19 May 2017 10:33:41 +0200
>
> > The following patchset contains Netfilter/IPVS fixes for your net tree,
> > they are:
> ...
> > You can pull these changes from:
> >
> > git://git.kernel.org/p
On Sun, May 21, 2017 at 9:04 AM, Jesper Dangaard Brouer
wrote:
> On Sat, 20 May 2017 09:16:09 -0700
> Tom Herbert wrote:
>
>> > +/* XDP rxhash have an associated type, which is related to the RSS
>> > + * (Receive Side Scaling) standard, but NIC HW have different mapping
>> > + * and support. Thu
Compliment of the day,
I have access to very vital information that can be used to move a huge amount
of money.
I have done my homework very well and i have the machineries in place to get it
done.
Ultimately I need an honest person to play an important role in the completion
of this busines
On Sun, 2017-05-21 at 12:54 -0400, David Miller wrote:
> From: David Ahern Date: Sun, 21 May 2017 10:17:47 -0600
> > On 5/21/17 10:05 AM, Joe Perches wrote:
> >> But really, why bother?
> >>
> >> Just because checkpatch bleats some message doesn't
> >> mean it _has_ to be fixed.
> >>
> >> Please
From: Markus Elfring
Date: Sun, 21 May 2017 21:50:44 +0200
A single space character should be put into a sequence.
Thus use the corresponding function "seq_putc".
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
net/atm/lec.c | 2 +-
1 file changed,
From: Markus Elfring
Date: Sun, 21 May 2017 21:49:10 +0200
A string which did not contain a data format specification should be put
into a sequence. Thus use the corresponding function "seq_puts".
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
net/
From: Markus Elfring
Date: Sun, 21 May 2017 21:34:23 +0200
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
The script “checkpatch.pl” pointed information out like the following.
Comparison to NULL could be written …
Thus fix the affected source code pla
From: Markus Elfring
Date: Sun, 21 May 2017 21:24:45 +0200
Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Link:
http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf
Sign
From: Markus Elfring
Date: Sun, 21 May 2017 21:20:44 +0200
Replace the specification of four data structures by pointer dereferences
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style convention.
Signed-off-by:
From: Markus Elfring
Date: Sun, 21 May 2017 22:09:11 +0200
A few update suggestions were taken into account
from static source code analysis.
Markus Elfring (5):
Improve a size determination in four functions
Delete an error message for a failed memory allocation in make_entry()
Adjust 19
Sun, May 21, 2017 at 08:27:21PM CEST, xiyou.wangc...@gmail.com wrote:
>On Sat, May 20, 2017 at 10:54 PM, Jiri Pirko wrote:
>> Sun, May 21, 2017 at 02:16:45AM CEST, xiyou.wangc...@gmail.com wrote:
>>>On Sat, May 20, 2017 at 6:01 AM, Jiri Pirko wrote:
+static void tcf_chain_destroy(struct tcf_
This patch fixes a typo in sockfd_lookup() in net/socket.c.
Signed-off-by: Rami Rosen
---
net/socket.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/socket.c b/net/socket.c
index cb355a7..8f9dab3 100644
--- a/net/socket.c
+++ b/net/socket.c
@@ -461,7 +461,7 @@ EXPORT_SY
On Sat, May 20, 2017 at 10:54 PM, Jiri Pirko wrote:
> Sun, May 21, 2017 at 02:16:45AM CEST, xiyou.wangc...@gmail.com wrote:
>>On Sat, May 20, 2017 at 6:01 AM, Jiri Pirko wrote:
>>> +static void tcf_chain_destroy(struct tcf_chain *chain)
>>> +{
>>> + list_del(&chain->list);
>>> + tcf_c
On Sun, 2017-05-21 at 13:46 -0400, Soheil Hassas Yeganeh wrote:
> On Sun, May 21, 2017 at 1:39 PM, Eric Dumazet wrote:
> > From: Eric Dumazet
> >
> > TCP_USER_TIMEOUT is still converted to jiffies value in
> > icsk_user_timeout
> >
> > So we need to make a conversion for the cases HZ != 1000
> >
On Sun, 2017-05-21 at 13:51 -0400, David Miller wrote:
> From: Eric Dumazet
> Date: Sun, 21 May 2017 10:39:00 -0700
>
> > From: Eric Dumazet
> >
> > TCP_USER_TIMEOUT is still converted to jiffies value in
> > icsk_user_timeout
> >
> > So we need to make a conversion for the cases HZ != 1000
>
From: Eric Dumazet
Date: Sun, 21 May 2017 10:39:00 -0700
> From: Eric Dumazet
>
> TCP_USER_TIMEOUT is still converted to jiffies value in
> icsk_user_timeout
>
> So we need to make a conversion for the cases HZ != 1000
>
> Fixes: 9a568de4818d ("tcp: switch TCP TS option (RFC 7323) to 1ms clo
On Sun, May 21, 2017 at 1:39 PM, Eric Dumazet wrote:
> From: Eric Dumazet
>
> TCP_USER_TIMEOUT is still converted to jiffies value in
> icsk_user_timeout
>
> So we need to make a conversion for the cases HZ != 1000
>
> Fixes: 9a568de4818d ("tcp: switch TCP TS option (RFC 7323) to 1ms clock")
> Si
From: Stephen Hemminger
Date: Fri, 19 May 2017 09:55:56 -0700
> Resolves warnings:
> net/ipv6/esp6.c: In function ‘esp_ssg_unref’:
> net/ipv6/esp6.c:121:10: warning: variable ‘seqhi’ set but not used
> [-Wunused-but-set-variable]
> net/ipv6/esp6.c: In function ‘esp6_output_head’:
> net/ipv6/esp6
From: Stephen Hemminger
Date: Fri, 19 May 2017 09:55:51 -0700
> The prototype for inet_rcv_saddr_equal was not being included.
>
> Signed-off-by: Stephen Hemminger
Applied.
From: Stephen Hemminger
Date: Fri, 19 May 2017 09:55:53 -0700
> This function is only used in this file and should not be global.
>
> Signed-off-by: Stephen Hemminger
Steffen said he already took this.
From: Stephen Hemminger
Date: Fri, 19 May 2017 09:55:54 -0700
> The build header functions are not used by any other code.
>
> net/ipv6/fou6.c:36:5: warning: no previous prototype for ‘fou6_build_header’
> [-Wmissing-prototypes]
> net/ipv6/fou6.c:54:5: warning: no previous prototype for ‘gue6_b
From: Stephen Hemminger
Date: Fri, 19 May 2017 09:55:55 -0700
> THe seg6_pernet_data variable was set but never used.
>
> Signed-off-by: Stephen Hemminger
Applied.
From: Stephen Hemminger
Date: Fri, 19 May 2017 09:55:52 -0700
> The TCP New Vegas congestion control was exporting an internal
> function tcpnv_get_info which is not used by any other in tree
> kernel code. Make it static.
>
> Signed-off-by: Stephen Hemminger
Applied.
From: Stephen Hemminger
Date: Fri, 19 May 2017 09:55:49 -0700
> This warning:
> net/ipv6/ila/ila_lwt.c: In function ‘ila_output’:
> net/ipv6/ila/ila_lwt.c:42:6: warning: variable ‘err’ set but not used
> [-Wunused-but-set-variable]
>
> It looks like the code attempts to set propagate different
From: Stephen Hemminger
Date: Fri, 19 May 2017 09:55:48 -0700
> Found by reviewing the warning about unused policy table.
> The code implies that it meant to check for size, but since
> it unrolled the loop for attribute validation that is never used.
> Instead do explicit check for attribute.
>
From: Stephen Hemminger
Date: Fri, 19 May 2017 09:55:50 -0700
> udp_queue_rcv_skb was global but only used in one file.
> Identified by this warning:
> net/ipv4/udp.c:1775:5: warning: no previous prototype for ‘udp_queue_rcv_skb’
> [-Wmissing-prototypes]
> int udp_queue_rcv_skb(struct sock *sk,
From: Eric Dumazet
TCP_USER_TIMEOUT is still converted to jiffies value in
icsk_user_timeout
So we need to make a conversion for the cases HZ != 1000
Fixes: 9a568de4818d ("tcp: switch TCP TS option (RFC 7323) to 1ms clock")
Signed-off-by: Eric Dumazet
---
net/ipv4/tcp_timer.c |3 ++-
1 f
From: Miroslav Lichvar
Date: Fri, 19 May 2017 17:52:34 +0200
> This patchset adds new options to the timestamping API that will be
> useful for NTP implementations and possibly other applications.
>
> The first patch specifies a timestamp filter for NTP packets. The second
> patch updates driver
From: Xin Long
Date: Fri, 19 May 2017 22:20:29 +0800
> Since commit 76b91c32dd86 ("bridge: stp: when using userspace stp stop
> kernel hello and hold timers"), bridge would not start hello_timer if
> stp_enabled is not KERNEL_STP when br_dev_open.
>
> The problem is even if users set stp_enabled
From:
Date: Fri, 19 May 2017 14:00:25 +
> From: Nisar Sayed
>
> When TX checksum offload is used, if the computed checksum is 0 the
> LAN95xx device do not alter the checksum to 0x. In the case of ipv4
> UDP checksum, it indicates to receiver that no checksum is calculated.
> Under ipv
From: Ganesh Goudar
Date: Fri, 19 May 2017 17:50:15 +0530
> issue get port information command to firmware to retrieve port
> information and update if it is different from what was last
> recorded and also add indication for supported link modes for
> firmware port types FW_PORT_TYPE_SFP28, FW_P
From: Sivakumar Krishnasamy
Date: Fri, 19 May 2017 05:30:38 -0400
...
> Signed-off-by: Sivakumar Krishnasamy
Applied, thanks for the more detailed commit message.
From: Corentin Labbe
Date: Fri, 19 May 2017 09:03:32 +0200
> This patch convert new_state from int to bool since it store only 1 or 0
>
> Signed-off-by: Corentin Labbe
You must also change it to use the values "true" and "false" as well.
Thanks.
From: Ihar Hrachyshka
Date: Thu, 18 May 2017 12:41:17 -0700
> This patchset is spurred by discussion started at
> https://patchwork.ozlabs.org/patch/760372/ where we figured that there is no
> real reason for enforcing override by gratuitous ARP packets only when
> arp_accept is 1. Same should ha
From: Wei Wang
Date: Thu, 18 May 2017 11:22:33 -0700
> From: Wei Wang
>
> When tcp_disconnect() is called, inet_csk_delack_init() sets
> icsk->icsk_ack.rcv_mss to 0.
> This could potentially cause tcp_recvmsg() => tcp_cleanup_rbuf() =>
> __tcp_select_window() call path to have division by 0 iss
From: Jakub Kicinski
Date: Fri, 19 May 2017 15:01:47 -0700
> Introduce a concept of an application. For now it's just grouping
> pointers and serving as a layer of indirection. It will help us
> weaken the dependency on nfp_net in ethtool code. Later series
> will flesh out support for differe
From: Yuval Mintz
Date: Sun, 21 May 2017 12:10:51 +0300
> This series contains some general minor fixes and enhancements:
>
> - #1, #2 and #9 correct small missing ethtool functionality.
> - #3, #6 and #8 correct minor issues in driver, but those are either
>print-related or unexposed in
From: Pablo Neira Ayuso
Date: Fri, 19 May 2017 10:33:41 +0200
> The following patchset contains Netfilter/IPVS fixes for your net tree,
> they are:
...
> You can pull these changes from:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf.git
Pulled, thanks Pablo.
From: David Ahern
Date: Sun, 21 May 2017 10:17:47 -0600
> On 5/21/17 10:05 AM, Joe Perches wrote:
>> But really, why bother?
>>
>> Just because checkpatch bleats some message doesn't
>> mean it _has_ to be fixed.
>>
>> Please strive to make the code more readable and
>> intelligible for _humans
Hello,
The NanoPi K2 has an Ampak AP6212 SDIO module. brcmfmac driver loads
brcmfmac43430-sdio.bin.
When using the firmware file from linux-firmware.git that openSUSE ships
I get the following errors on 4.11.0 and next-20170519:
[ 2103.618716] brcmfmac: brcmf_sdio_htclk: HT Avail timeout (10
On 5/21/17 10:05 AM, Joe Perches wrote:
> But really, why bother?
>
> Just because checkpatch bleats some message doesn't
> mean it _has_ to be fixed.
>
> Please strive to make the code more readable and
> intelligible for _humans_. Compilers don't care.
+1
broad cleanups like this make 'git b
On 5/19/17 10:16 PM, yuan linyu wrote:
> @@ -240,13 +240,15 @@ struct ndisc_options *ndisc_parse_options(const struct
> net_device *dev,
> "%s: duplicated ND6 option found:
> type=%d\n",
> __func__, nd_opt->nd_opt_typ
Plumb extack argument down to route add functions.
Signed-off-by: David Ahern
---
include/net/ip6_fib.h | 3 ++-
include/net/ip6_route.h | 2 +-
net/ipv6/addrconf.c | 4 ++--
net/ipv6/ip6_fib.c | 14 +++-
net/ipv6/route.c| 57 +++-
Use the extack feature to improve error messages to user on route
add and delete failures.
David Ahern (4):
net: ipv4: Plumb extack through route add functions
net: ipv4: Add extack messages for route add failures
net: ipv6: Plumb extack through route add functions
net: ipv6: Add extack me
Add messages for non-obvious errors (e.g, no need to add text for malloc
failures or ENODEV failures). This mostly covers the annoying EINVAL errors
Some message strings violate the 80-columns but searchable strings need to
trump that rule.
Signed-off-by: David Ahern
---
include/linux/netlink.h
Plumb extack argument down to route add functions.
Signed-off-by: David Ahern
---
include/net/ip_fib.h | 3 ++-
net/ipv4/fib_frontend.c | 16 +---
net/ipv4/fib_lookup.h| 3 ++-
net/ipv4/fib_semantics.c | 22 +-
net/ipv4/fib_trie.c | 4 ++--
5 file
Add messages for non-obvious errors (e.g, no need to add text for malloc
failures or ENODEV failures). This mostly covers the annoying EINVAL errors
Some message strings violate the 80-columns but searchable strings need to
trump that rule.
Signed-off-by: David Ahern
---
net/ipv6/ip6_fib.c | 4
On Sun, 2017-05-21 at 08:55 +0800, yuan linyu wrote:
> From: yuan linyu
>
> diff --git a/net/ipv6/ndisc.c b/net/ipv6/ndisc.c
[]
> @@ -512,7 +519,8 @@ void ndisc_send_na(struct net_device *dev, const struct
> in6_addr *daddr,
> in6_ifa_put(ifp);
> } else {
> if (
On Sat, 20 May 2017 09:16:09 -0700
Tom Herbert wrote:
> > +/* XDP rxhash have an associated type, which is related to the RSS
> > + * (Receive Side Scaling) standard, but NIC HW have different mapping
> > + * and support. Thus, create mapping that is interesting for XDP. XDP
> > + * would primar
On Fri, 19 May 2017 20:07:52 -0700
Alexei Starovoitov wrote:
> On Thu, May 18, 2017 at 05:41:48PM +0200, Jesper Dangaard Brouer wrote:
> >
> > +/* XDP rxhash have an associated type, which is related to the RSS
> > + * (Receive Side Scaling) standard, but NIC HW have different mapping
> > + * a
Am 15.05.2017 um 22:13 schrieb Martin Blumenstingl:
> The example in the BCM43xx documentation uses "brcmf" as node name.
No, it doesn't, it uses "bcrmf".
This typo has spread to all ARM device trees:
$ git grep bcrmf -- arch/arm/boot/dts/
arch/arm/boot/dts/imx6sx-nitrogen6sx.dts: brcmf: b
Hi,
Am 16.05.2017 um 21:56 schrieb Martin Blumenstingl:
> On Tue, May 16, 2017 at 12:05 AM, Arend Van Spriel
> wrote:
>> On 15-5-2017 22:13, Martin Blumenstingl wrote:
>>> The example in the BCM43xx documentation uses "brcmf" as node name.
>>> However, wireless devices should be named "wifi" inst
If too many CQs are requested, qed would print the available
number as if it's a resource and not a feature leading to the
wrong print.
Fixes: 08737a3fa30a ("qed: Inform qedi the number of possible CQs")
Signed-off-by: Yuval Mintz
---
drivers/net/ethernet/qlogic/qed/qed_iscsi.c | 2 +-
1 file ch
From: Tomer Tayar
The management firmware HSI contains masks which are already
shifted to their right place, so QED_MFW_SET_FIELD() is clearing
incorrect fields by shifting the mask by the offset.
Luckily, today we set the fields in an incrementing order [so we're
not erasing any previously set
This is benign, but it makes more sense to start the close sequence
only after changing the internal state [in case it would once care].
Signed-off-by: Yuval Mintz
---
drivers/net/ethernet/qlogic/qede/qede_main.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/e
From: Tomer Tayar
Re-organize the logic that allocates and frees memory of various
sub-components of the hw-function -
a. No need to pass pointers to said structure as parameters;
The internal logic knows exactly where to find/set the data.
b. Nullify pointers after cleanup to prevent pos
From: Sudarsana Reddy Kalluru
Some variants of adapters support the 1G speed capability. Need to
allow the configuration of 1G speed if adapter supports it.
Signed-off-by: Sudarsana Reddy Kalluru
Signed-off-by: Yuval Mintz
---
drivers/net/ethernet/qlogic/qede/qede_ethtool.c | 8
1 fi
From: Sudarsana Reddy Kalluru
When destroying the datapath channels, qede doesn't notify qed of the
released status blocks which were acquired during the initialization.
Signed-off-by: Sudarsana Reddy Kalluru
Signed-off-by: Yuval Mintz
---
drivers/net/ethernet/qlogic/qede/qede_main.c | 11 +++
Driver maintains its primary MAC in a private field which
gets updated when ndo_dev_set_mac() gets called.
However, there are flows where the primary MAC of the device can change
without said NDO being called [bond device in TLB mode configuring
slaves' addresses], resulting in a configuration whe
From: Sudarsana Reddy Kalluru
Driver always allocates the maximal number of tx-buffers irrespective of
actual Tx ring config.
Signed-off-by: Sudarsana Reddy Kalluru
Signed-off-by: Yuval Mintz
---
drivers/net/ethernet/qlogic/qede/qede_ethtool.c | 6 +++---
drivers/net/ethernet/qlogic/qede/qed
When management firmware declares that the device is WoL-capable,
the default driver behavior would be to allow the management firmware
to take the decision of whether it's actually needed or not.
Problem is ethtool interface doesn't have a 'default' kind
of option, and user would see the interfac
This series contains some general minor fixes and enhancements:
- #1, #2 and #9 correct small missing ethtool functionality.
- #3, #6 and #8 correct minor issues in driver, but those are either
print-related or unexposed in existing code.
- #4 adds proper support to TLB mode bonding.
- #10
Hi Anoob,
[auto build test ERROR on v4.9-rc8]
[also build test ERROR on next-20170519]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Anoob-Soman/openvswitch-clear-sender-cpu-before-forwarding-p
86 matches
Mail list logo
