Re: [PATCH net-next] enic: use kasprintf instead of snprintf

2017-06-18 Thread Joe Perches
On Sun, 2017-06-18 at 22:55 -0700, Govindarajulu Varadarajan wrote: > On Sun, 18 Jun 2017, Joe Perches wrote: > > > Perhaps it'd be better to use a style > > with a variable length format precision > > > > ie: > > > > "%.*s-tx-%u", IFNAMSIZ - 4 - , netdev-name, i) > > > > This would

Re: [PATCH v2 1/2] ip_tunnel: fix ip tunnel lookup in collect_md mode

2017-06-18 Thread Pravin Shelar
On Fri, Jun 16, 2017 at 8:27 PM, Haishuang Yan wrote: > In collect_md mode, if the tun dev is down, it still can call > ip_tunnel_rcv to receive on packets, and the rx statistics increase > improperly. > > Fixes: 2e15ea390e6f ("ip_gre: Add support to collect

[PATCH net-next] enic: use kasprintf instead of snprintf

2017-06-18 Thread Govindarajulu Varadarajan
With -Wformat-truncation=, gcc throws the following warning. Instead of using snprintf, use kasprintf and allocate string size as needed. drivers/net/ethernet/cisco/enic/enic_main.c: In function ‘enic_open’: drivers/net/ethernet/cisco/enic/enic_main.c:1740:15: warning: ‘%u’ directive output may

Re: [PATCH net-next 09/13] net: ena: adding missing cast in ena_com_mem_addr_set()

2017-06-18 Thread Leon Romanovsky
On Sun, Jun 18, 2017 at 02:28:14PM +0300, neta...@amazon.com wrote: > From: Netanel Belgazal > > Signed-off-by: Netanel Belgazal > --- > drivers/net/ethernet/amazon/ena/ena_com.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [PATCH net-next 12/13] net: ena: change validate_tx_req_id() to be inline function

2017-06-18 Thread Leon Romanovsky
On Sun, Jun 18, 2017 at 02:28:17PM +0300, neta...@amazon.com wrote: > From: Netanel Belgazal > > for optimization purpose, change validate_tx_req_id() to be > inline function. > > Signed-off-by: Netanel Belgazal > --- >

Re: [PATCH net-next repost] nfp: add VLAN filtering support

2017-06-18 Thread David Miller
From: Jakub Kicinski Date: Thu, 15 Jun 2017 16:22:15 -0700 > From: Pablo Cascón > > Add general use per-vNIC mailbox area and use it for VLAN filtering > support. Initially proto is hardcoded to 802.1q. > > Signed-off-by: Pablo Cascón

Re: pull-request: mac80211 2017-06-16

2017-06-18 Thread David Miller
From: Johannes Berg Date: Fri, 16 Jun 2017 09:19:35 +0200 > Here I just have the cleanups with the fix for that ancient bug > I sent the RFC patches for. > > Please pull and let me know if there's any problem. Pulled, thanks Johannes.

Re: [PATCH net-next] cxgb4: fix a NULL dereference

2017-06-18 Thread David Miller
From: Ganesh Goudar Date: Fri, 16 Jun 2017 15:36:09 +0530 > Avoid NULL dereference in setup_sge_queues() when the adapter is > in non offload mode. > > Fixes: 0fbc81b3ad51 ('chcr/cxgb4i/cxgbit/RDMA/cxgb4: Allocate resources > dynamically for all cxgb4 ULD's') >

Re: [PATCH v3] ip6_tunnel: Correct tos value in collect_md mode

2017-06-18 Thread David Miller
From: Haishuang Yan Date: Sat, 17 Jun 2017 11:38:05 +0800 > Same as ip_gre, geneve and vxlan, use key->tos as traffic class value. > > CC: Peter Dawson > Fixes: 0e9a709560db ("ip6_tunnel, ip6_gre: fix setting of DSCP on > encapsulated

Re: [PATCH net-next] liquidio: replace info-pointer mode with buffer-pointer-only mode

2017-06-18 Thread David Miller
From: Felix Manlunas Date: Sun, 18 Jun 2017 05:04:11 -0700 > From: Prasad Kanneganti > > Each Octeon output ring can DMA packets to host memory in two modes: info- > pointer mode and buffer-pointer-only mode. In info-pointer mode,

Re: Investment Consideration

2017-06-18 Thread John Hanan
Thank you for your time, We are looking for clients in your country with good business or project that requires financing to execute. Please get back to me if you are interested in this or you know anybody who has good business ideas but lack the necessary capital to fund his projects so we

Re: [PATCH] pptp: Remove unused variable in pptp_release()

2017-06-18 Thread David Miller
From: Christos Gkekas Date: Sun, 18 Jun 2017 16:41:40 +0100 > Variable opt in pptp_release() is set but never used, thus needs to be > removed. > > Signed-off-by: Christos Gkekas Applied to net-next.

Re: [PATCH net-next] liquidio: implement vlan filter enable and disable

2017-06-18 Thread David Miller
From: Felix Manlunas Date: Sun, 18 Jun 2017 12:41:34 -0700 > From: Prasad Kanneganti > > Add implementation to support ethtool -K ethX rx-vlan-filter on/off. > Rename OCTNET_CMD_ENABLE_VLAN_FILTER command to OCTNET_CMD_VLAN_FILTER_CTL >

Re: [PATCH V3 net-next 6/8] net: hns3: Add MDIO support to HNS3 Ethernet driver for hip08 SoC

2017-06-18 Thread Andrew Lunn
On Sat, Jun 17, 2017 at 06:24:29PM +0100, Salil Mehta wrote: > This patch adds the support of MDIO bus interface for HNS3 driver. > Code provides various interfaces to start and stop the PHY layer > and to read and write the MDIO bus or PHY. > > Signed-off-by: Daode Huang

[PATCH] netxen: Fix a sleep-in-atomic bug in netxen_nic_pci_mem_access_direct

2017-06-18 Thread Jia-Ju Bai
The driver may sleep under a spin lock, and the function call path is: netxen_nic_pci_mem_access_direct (acquire the lock by spin_lock) ioremap --> may sleep To fix it, the lock is released before "ioremap", and the lock is acquired again after this function. Signed-off-by: Jia-Ju Bai

[PATCH] netxen: Fix a sleep-in-atomic bug in netxen_nic_hw_read_wx_2M and netxen_nic_hw_write_wx_2M

2017-06-18 Thread Jia-Ju Bai
The driver may sleep under a write spin lock, and function call path is: netxen_nic_hw_read_wx_2M (acquire the lock by write_lock_irqsave) crb_win_lock netxen_pcie_sem_lock msleep --> may sleep netxen_nic_hw_write_wx_2M (acquire the lock by write_lock_irqsave) crb_win_lock

Re: [PATCH v2 net-next 0/7] qed*: RDMA and infrastructure for iWARP

2017-06-18 Thread Andrew Lunn
> I can't really say I understand who would benefit from adding > "while at it remove redundant inclusion of header file" > to the commit log message [And even less from splitting this into its own > patch]. Part of it is trust. If you say you are just renaming, not making any change,

Re: Fw: [Bug 196093] New: dot1q S-VLAN frame on dot1ad configured interface is accepted

2017-06-18 Thread Toshiaki Makita
Hi, On 2017/06/17 0:40, Stephen Hemminger wrote: > I suspect that VLAN offload on this Intel NIC is allowing any of the VLAN > types. > > Begin forwarded message: > > Date: Fri, 16 Jun 2017 15:33:35 + > From: bugzilla-dae...@bugzilla.kernel.org > To: step...@networkplumber.org > Subject:

Re: [PATCH net-next 02/13] sock: skb_copy_ubufs support for compound pages

2017-06-18 Thread Willem de Bruijn
> [auto build test ERROR on net-next/master] >>net//core/skbuff.c: In function 'skb_copy_ubufs': >>> net//core/skbuff.c:1016:2: error: 'uarg' undeclared (first use in this >>> function) > uarg->callback(uarg, false); > ^ >net//core/skbuff.c:1016:2: note: each undeclared

Re: [PATCH net-next 04/13] sock: add SOCK_ZEROCOPY sockopt and net.core.msg_zerocopy sysctl

2017-06-18 Thread kbuild test robot
Hi Willem, [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Willem-de-Bruijn/sock-allocate-skbs-from-optmem/20170619-072924 reproduce: make htmldocs All warnings (new ones prefixed by >>): /kbuild/src/i386//include/net/sock.h:479: warning: No

Investment portfolio

2017-06-18 Thread HDD Investment Co.
Hello, How are you today? we have the financial capability to finance any investment portfolio as far as is genuine, all we need is a capable business partner that possesses investment strategies or profitable business information for good turn over within 10-20years. We can provide proof of

Investment portfolio

2017-06-18 Thread HDD Investment Co.
Hello, How are you today? we have the financial capability to finance any investment portfolio as far as is genuine, all we need is a capable business partner that possesses investment strategies or profitable business information for good turn over within 10-20years. We can provide proof of

Re: [PATCH v2 net-next 0/7] qed*: RDMA and infrastructure for iWARP

2017-06-18 Thread David Miller
From: "Mintz, Yuval" Date: Sun, 18 Jun 2017 17:54:49 + > I can't really say I understand who would benefit from adding "while > at it remove redundant inclusion of header file" to the commit log > message [And even less from splitting this into its own patch].

Re: [PATCH net-next 02/13] sock: skb_copy_ubufs support for compound pages

2017-06-18 Thread kbuild test robot
Hi Willem, [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Willem-de-Bruijn/sock-allocate-skbs-from-optmem/20170619-072924 config: i386-randconfig-a0-06162344 (attached as .config) compiler: gcc-5 (Debian 5.4.1-2) 5.4.1 20160904 reproduce: #

[PATCH net-next 01/13] sock: allocate skbs from optmem

2017-06-18 Thread Willem de Bruijn
From: Willem de Bruijn Add sock_omalloc and sock_ofree to be able to allocate control skbs, for instance for looping errors onto sk_error_queue. The transmit budget (sk_wmem_alloc) is involved in transmit skb shaping, most notably in TCP Small Queues. Using this budget for

[PATCH net-next 05/13] sock: enable MSG_ZEROCOPY

2017-06-18 Thread Willem de Bruijn
From: Willem de Bruijn Prepare the datapath for refcounted ubuf_info. Clone ubuf_info with skb_zerocopy_clone() wherever needed due to skb split, merge, resize or clone. Split skb_orphan_frags into two variants. The split, merge, .. paths support reference counted zerocopy

[PATCH net-next 04/13] sock: add SOCK_ZEROCOPY sockopt and net.core.msg_zerocopy sysctl

2017-06-18 Thread Willem de Bruijn
From: Willem de Bruijn The send call ignores unknown flags. Legacy applications may already unwittingly pass MSG_ZEROCOPY. Continue to ignore this flag unless a socket opts in to zerocopy. Introduce socket option SO_ZEROCOPY to enable MSG_ZEROCOPY processing. Processes can

[PATCH net-next 00/13] socket sendmsg MSG_ZEROCOPY

2017-06-18 Thread Willem de Bruijn
From: Willem de Bruijn Introduce zerocopy socket send flag MSG_ZEROCOPY. This extends the shared page support (SKBTX_SHARED_FRAG) from sendpage to sendmsg. Implement the feature for TCP, UDP, RAW and packet sockets. On a send call with MSG_ZEROCOPY, the kernel pins user

[PATCH net-next 08/13] sock: ulimit on MSG_ZEROCOPY pages

2017-06-18 Thread Willem de Bruijn
From: Willem de Bruijn Bound the number of pages that a user may pin. Follow the lead of perf tools to maintain a per-user bound on memory locked pages commit 789f90fcf6b0 ("perf_counter: per user mlock gift") Signed-off-by: Willem de Bruijn ---

[PATCH net-next 06/13] sock: MSG_ZEROCOPY notification coalescing

2017-06-18 Thread Willem de Bruijn
From: Willem de Bruijn In the simple case, each sendmsg() call generates data and eventually a zerocopy ready notification N, where N indicates the Nth successful invocation of sendmsg() with the MSG_ZEROCOPY flag on this socket. TCP and corked sockets can cause send() calls

[PATCH net-next 07/13] sock: add ee_code SO_EE_CODE_ZEROCOPY_COPIED

2017-06-18 Thread Willem de Bruijn
From: Willem de Bruijn A send request with MSG_ZEROCOPY falls back to copying when a request cannot be completed in zerocopy mode. Notify processes when the call reverted to copying through a new bit in the completion notification, so that they can optionally decline passing

[PATCH net-next 12/13] packet: enable MSG_ZEROCOPY

2017-06-18 Thread Willem de Bruijn
From: Willem de Bruijn Support MSG_ZEROCOPY on PF_PACKET transmission. Tested: msg_zerocopy.sh 4 packet: without zerocopy tx=121543 (7588 MB) txc=0 zc=n rx=121543 (7584 MB) with zerocopy tx=338252 (21119 MB) txc=338252 zc=y rx=338252 (21108 MB)

[PATCH net-next 03/13] sock: add MSG_ZEROCOPY

2017-06-18 Thread Willem de Bruijn
From: Willem de Bruijn The kernel supports zerocopy sendmsg in virtio and tap. Expand the infrastructure to support other socket types. Introduce a completion notification channel over the socket error queue. Notifications are returned with ee_origin SO_EE_ORIGIN_ZEROCOPY.

[PATCH net-next 09/13] tcp: enable MSG_ZEROCOPY

2017-06-18 Thread Willem de Bruijn
From: Willem de Bruijn Enable support for MSG_ZEROCOPY to the TCP stack. TSO and GSO are both supported. Only data sent to remote destinations is sent without copying. Packets looped onto a local destination have their payload copied to avoid unbounded latency. Tested: A

[PATCH net-next 10/13] udp: enable MSG_ZEROCOPY

2017-06-18 Thread Willem de Bruijn
From: Willem de Bruijn Add MSG_ZEROCOPY support to INET(6). This includes UDP, but also RAW sockets that do not take the raw_send_hdrinc() path. Zerocopy is only effective when payload is not touched at all. Limit it to paths that support both checksum offload and

[PATCH net-next 13/13] test: add msg_zerocopy test

2017-06-18 Thread Willem de Bruijn
From: Willem de Bruijn Introduce regression test for msg_zerocopy feature. Send traffic from one process to another with and without zerocopy. Evaluate tcp, udp, raw and packet sockets, including variants - udp: corking and corking with mixed copy/zerocopy calls - raw: with

[PATCH net-next 11/13] raw: enable MSG_ZEROCOPY with IP_HDRINCL

2017-06-18 Thread Willem de Bruijn
From: Willem de Bruijn Zerocopy support for udp also enables it for some raw sockets. Only raw sockets that have hdrinc set take a different path. Add zerocopy support for this variant. Tested: msg_zerocopy.sh 4 raw_hdrincl: without zerocopy tx=150438 (9390 MB)

[PATCH net-next 02/13] sock: skb_copy_ubufs support for compound pages

2017-06-18 Thread Willem de Bruijn
From: Willem de Bruijn Refine skb_copy_ubufs to support compound pages. With upcoming TCP and UDP zerocopy sendmsg, such fragments may appear. The existing code replaces each page one for one. Splitting each compound page into an independent number of regular pages can

Re: [PATCH net-next 01/10] net: dsa: mv88e6xxx: add irl_init_all op

2017-06-18 Thread kbuild test robot
Hi Vivien, [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Vivien-Didelot/net-dsa-Global-2-cosmetics/20170619-033614 config: i386-randconfig-x079-06180431 (attached as .config) compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901 reproduce: # save

[PATCH net-next] liquidio: implement vlan filter enable and disable

2017-06-18 Thread Felix Manlunas
From: Prasad Kanneganti Add implementation to support ethtool -K ethX rx-vlan-filter on/off. Rename OCTNET_CMD_ENABLE_VLAN_FILTER command to OCTNET_CMD_VLAN_FILTER_CTL and add OCTNET_CMD_VLAN_FILTER_ENABLE and OCTNET_CMD_VLAN_FILTER_DISABLE parameters so that it can

Re: [PATCH v2 net-next 0/7] qed*: RDMA and infrastructure for iWARP

2017-06-18 Thread Mintz, Yuval
> I'm still not happy at all. > You failed the address the specific thing I asked to be fixed. > In patch #4, the rename, you just say in your commit message > that you are "renaming". > But in the qedr/main.c part of the change, you are _REMOVING_ > the include. > And I said that can't be

Re: [PATCH V3 net-next 1/8] net: hns3: Add support of HNS3 Ethernet Driver for hip08 SoC

2017-06-18 Thread Bo Yu
Hi, On Sat, Jun 17, 2017 at 06:24:24PM +0100, Salil Mehta wrote: + struct notifier_block notifier_block; + /* Vxlan/Geneve information */ + struct hns3_udp_tunnel udp_tnl[HNS3_UDP_TNL_MAX]; +}; + +/* the distance between [begin, end) in a ring buffer + * note: there is a unuse

Re: [PATCH V3 net-next 5/8] net: hns3: Add support of TX Scheduler & Shaper to HNS3 driver

2017-06-18 Thread Richard Cochran
On Sat, Jun 17, 2017 at 06:24:28PM +0100, Salil Mehta wrote: > + > +int hclge_tm_schd_init(struct hclge_dev *hdev); > +int hclge_tm_setup_tc(struct hclge_dev *hdev); The definition of this function DNE. > +int hclge_pause_setup_hw(struct hclge_dev *hdev); > + > +#endif > -- > 2.7.4 Thanks,

Re: [PATCH V3 net-next 2/8] net: hns3: Add support of the HNAE3 framework

2017-06-18 Thread Bo Yu
Hi, On Sat, Jun 17, 2017 at 06:24:25PM +0100, Salil Mehta wrote: + * Unregister client from ae_dev + * start() + * Enable the hardware + * stop() + * Disable the hardware + * get_status() + * Get the carrier state of the back channel of the handle, 1 for ok, 0 for + * non-ok + *

Re: [PATCH v2 net-next 0/7] qed*: RDMA and infrastructure for iWARP

2017-06-18 Thread David Miller
From: Yuval Mintz Date: Sun, 18 Jun 2017 14:50:28 +0300 > Changes from previous versions > -- > - V2: Add several inclusion into qede_rdma.h to have proper declarations >of all variable types used in it I'm still not happy at all. You

Re: [PATCH net-next 10/13] net: ena: add mtu limitation in ena_change_mtu()

2017-06-18 Thread David Miller
From: Date: Sun, 18 Jun 2017 14:28:15 +0300 > From: Netanel Belgazal > > Signed-off-by: Netanel Belgazal I don't understand this at all. This whole reason we have those: > @@ -3008,8 +3015,6 @@ static void

Re: [PATCH V3 net-next 1/8] net: hns3: Add support of HNS3 Ethernet Driver for hip08 SoC

2017-06-18 Thread Bo Yu
Hi, On Sat, Jun 17, 2017 at 06:24:24PM +0100, Salil Mehta wrote: +static int hns3_fill_desc(struct hns3_enet_ring *ring, void *priv, + int size, dma_addr_t dma, int frag_end, + enum hns_desc_type type) +{ + struct hns3_desc_cb *desc_cb =

[PATCH] pptp: Remove unused variable in pptp_release()

2017-06-18 Thread Christos Gkekas
Variable opt in pptp_release() is set but never used, thus needs to be removed. Signed-off-by: Christos Gkekas --- drivers/net/ppp/pptp.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/ppp/pptp.c b/drivers/net/ppp/pptp.c index 1951b10..5b0fd89 100644 ---

Re: [PATCH V3 net-next 2/8] net: hns3: Add support of the HNAE3 framework

2017-06-18 Thread Andrew Lunn
> +static int __init hnae3_init(void) > +{ > + return 0; > +} > + > +static void __exit hnae3_exit(void) > +{ > +} > + > +module_init(hnae3_init); > +module_exit(hnae3_exit); I think init and exit functions are optional. Since your's don't do anything useful, please try without them.

Re: [PATCH V2 net-next 2/8] net: hns3: Add support of the HNAE3 framework

2017-06-18 Thread Andrew Lunn
On Wed, Jun 14, 2017 at 12:10:29AM +0100, Salil Mehta wrote: > This patch adds the support of the HNAE3 (Hisilicon Network > Acceleration Engine 3) framework support to the HNS3 driver. > > Framework facilitates clients like ENET(HNS3 Ethernet Driver), RoCE > and user-space Ethernet drivers (like

[PATCH net-next 3/3] net: manual clean code which call skb_put_[data:zero]

2017-06-18 Thread yuan linyu
From: yuan linyu Signed-off-by: yuan linyu --- drivers/isdn/hysdn/hycapi.c | 8 drivers/isdn/i4l/isdn_bsdcomp.c | 2 +- drivers/isdn/i4l/isdn_ppp.c

[PATCH net-next 2/3] net: replace more place to skb_put_[data:zero]

2017-06-18 Thread yuan linyu
From: yuan linyu spatch file, @@ expression skb, len, data; type t; @@ -memcpy((t *)skb_put(skb, len), data, len); +skb_put_data(skb, data, len); @@ identifier p; expression skb, len, data; type t; @@ -p = (t *)memset(skb_put(skb, len), data, len); +p =

[PATCH net-next 1/3] net: introduce __skb_put_[zero, data, u8]

2017-06-18 Thread yuan linyu
From: yuan linyu follow Johannes Berg, semantic patch file as below, @@ identifier p, p2; expression len; expression skb; type t, t2; @@ ( -p = __skb_put(skb, len); +p = __skb_put_zero(skb, len); | -p = (t)__skb_put(skb, len); +p = __skb_put_zero(skb, len); ) ...

[PATCH net-next 0/3] more skb_put_[data:zero] related work

2017-06-18 Thread yuan linyu
From: yuan linyu yuan linyu (3): net: introduce __skb_put_[zero, data, u8] net: replace more place to skb_put_[data:zero] net: manual clean code which call skb_put_[data:zero] drivers/crypto/chelsio/chcr_algo.c | 15 +--

Re: [PATCH v1 1/2] dt-binding: ptp: add bindings document for dte based ptp clock

2017-06-18 Thread Rob Herring
On Mon, Jun 12, 2017 at 01:26:00PM -0700, Arun Parameswaran wrote: > Add device tree binding documentation for the Broadcom DTE > PTP clock driver. > > Signed-off-by: Arun Parameswaran > --- > Documentation/devicetree/bindings/ptp/brcm,ptp-dte.txt | 13

Re: [PATCH] of: update ePAPR references to point to Devicetree Specification

2017-06-18 Thread Rob Herring
On Tue, Jun 13, 2017 at 07:49:04PM -0700, frowand.l...@gmail.com wrote: > From: Frank Rowand > > The Devicetree Specification has superseded the ePAPR as the > base specification for bindings. Update files in Documentation > to reference the new document. > > Some files

Re: [PATCH v2 net-next 0/7] qed*: RDMA and infrastructure for iWARP

2017-06-18 Thread Christoph Hellwig
On Sun, Jun 18, 2017 at 02:50:28PM +0300, Yuval Mintz wrote: > This series focuses on RDMA in general with emphasis on required changes > toward adding iWARP support. The vast majority of the changes introduced > are in qed/qede, with a couple of small changes to qedr > [mentioned below]. Btw,

Re: [PATCH net-next 1/1] net: reflect mark on tcp syn ack packets

2017-06-18 Thread Jamal Hadi Salim
Sorry for the latency. On 17-06-13 09:58 AM, Lorenzo Colitti wrote: On Sat, Jun 10, 2017 at 10:31 PM, Jamal Hadi Salim wrote: skb->priority = sk->sk_priority; - skb->mark = sk->sk_mark; + if (!skb->mark) + skb->mark = sk->sk_mark; It

[PATCH net-next] liquidio: replace info-pointer mode with buffer-pointer-only mode

2017-06-18 Thread Felix Manlunas
From: Prasad Kanneganti Each Octeon output ring can DMA packets to host memory in two modes: info- pointer mode and buffer-pointer-only mode. In info-pointer mode, Octeon takes two buffer pointers for each packet and places the length of the packet along with

RE: [PATCH v2 net-next 4/7] qed*: Rename qede_roce.[ch]

2017-06-18 Thread Kalderon, Michal
> From: Michal Kalderon > > Once we have iWARP support, the qede portion of the qedr<->qede would > serve all the RDMA protocols - so rename the file to be appropriate to its > function. > > CC: Michal Kalderon > Signed-off-by: Yuval

[PATCH v2 net-next 7/7] qed: SPQ async callback registration

2017-06-18 Thread Yuval Mintz
From: Michal Kalderon Whenever firmware indicates that there's an async indication it needs to handle, there's a switch-case where the right functionality is called based on function's personality and information. Before iWARP is added [as yet another client], switch

[PATCH v2 net-next 5/7] qed*: Set rdma generic functions prefix

2017-06-18 Thread Yuval Mintz
From: Michal Kalderon Rename the functions common to both iWARP and RoCE to have a prefix of _rdma_ instead of _roce_. Signed-off-by: Michal Kalderon Signed-off-by: Yuval Mintz ---

[PATCH v2 net-next 3/7] qed: Disable RoCE dpm when DCBx change occurs

2017-06-18 Thread Yuval Mintz
If DCBx update occurs while QPs are open, stop sending edpms until all QPs are closed. Signed-off-by: Yuval Mintz --- drivers/net/ethernet/qlogic/qed/qed_dcbx.c | 8 +++ drivers/net/ethernet/qlogic/qed/qed_roce.c | 36 ++

[PATCH v2 net-next 6/7] qed: Wait for resources before FUNC_CLOSE

2017-06-18 Thread Yuval Mintz
From: Michal Kalderon Driver needs to wait for all resources to return from FW before it can send the FUNC_CLOSE ramrod. Signed-off-by: Michal Kalderon Signed-off-by: Yuval Mintz ---

[PATCH v2 net-next 4/7] qed*: Rename qede_roce.[ch]

2017-06-18 Thread Yuval Mintz
From: Michal Kalderon Once we have iWARP support, the qede portion of the qedr<->qede would serve all the RDMA protocols - so rename the file to be appropriate to its function. CC: Michal Kalderon Signed-off-by: Yuval Mintz

[PATCH v2 net-next 2/7] qed: RoCE EDPM to honor PFC

2017-06-18 Thread Yuval Mintz
Configure device according to DCBx results so that EDPMs made by RoCE would honor flow-control. Signed-off-by: Yuval Mintz --- drivers/net/ethernet/qlogic/qed/qed_dcbx.c | 16 drivers/net/ethernet/qlogic/qed/qed_reg_addr.h | 6 ++ 2 files

[PATCH v2 net-next 0/7] qed*: RDMA and infrastructure for iWARP

2017-06-18 Thread Yuval Mintz
This series focuses on RDMA in general with emphasis on required changes toward adding iWARP support. The vast majority of the changes introduced are in qed/qede, with a couple of small changes to qedr [mentioned below]. The infrastructure changes: - Patch #1 adds the ability to pass PBL memory

[PATCH v2 net-next 1/7] qed: Chain support for external PBL

2017-06-18 Thread Yuval Mintz
iWARP would require the chains to allocate/free their PBL memory independently, so add the infrastructure to provide it externally. Signed-off-by: Yuval Mintz --- drivers/infiniband/hw/qedr/main.c | 2 +- drivers/infiniband/hw/qedr/verbs.c| 6

[PATCH net-next 09/13] net: ena: adding missing cast in ena_com_mem_addr_set()

2017-06-18 Thread netanel
From: Netanel Belgazal Signed-off-by: Netanel Belgazal --- drivers/net/ethernet/amazon/ena/ena_com.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/amazon/ena/ena_com.c

[PATCH net-next 03/13] net: ena: change sizeof() argument to be the type pointer

2017-06-18 Thread netanel
From: Netanel Belgazal Instead of using: memset(ptr, 0x0, sizeof(struct ...)) use: memset(ptr, 0x0, sizeor(*ptr)) Signed-off-by: Netanel Belgazal --- drivers/net/ethernet/amazon/ena/ena_com.c | 16 1 file changed, 8 insertions(+), 8

[PATCH net-next 12/13] net: ena: change validate_tx_req_id() to be inline function

2017-06-18 Thread netanel
From: Netanel Belgazal for optimization purpose, change validate_tx_req_id() to be inline function. Signed-off-by: Netanel Belgazal --- drivers/net/ethernet/amazon/ena/ena_netdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH net-next 10/13] net: ena: add mtu limitation in ena_change_mtu()

2017-06-18 Thread netanel
From: Netanel Belgazal Signed-off-by: Netanel Belgazal --- drivers/net/ethernet/amazon/ena/ena_netdev.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/amazon/ena/ena_netdev.c

[PATCH net-next 13/13] net: ena: update ena driver to version 1.2.0

2017-06-18 Thread netanel
From: Netanel Belgazal Signed-off-by: Netanel Belgazal --- drivers/net/ethernet/amazon/ena/ena_netdev.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/amazon/ena/ena_netdev.h

[PATCH net-next 05/13] net: ena: add support for out of order rx buffers refill

2017-06-18 Thread netanel
From: Netanel Belgazal ENA driver post Rx buffers through the Rx submission queue for the ENA device to fill them with receive packets. Each Rx buffer is marked with req_id in the Rx descriptor. Newer ENA devices could consume the posted Rx buffer in out of order, and as

[PATCH net-next 02/13] net: ena: add hardware hints capability to the driver

2017-06-18 Thread netanel
From: Netanel Belgazal With this patch, ENA device can update the ena driver about the desired timeout values: These values are part of the "hardware hints" which are transmitted to the driver as Asynchronous event through ENA async event notification queue. In case the ENA

[PATCH net-next 11/13] net: ena: update driver's rx drop statistics

2017-06-18 Thread netanel
From: Netanel Belgazal rx drop counter is reported by the device in the keep-alive event. update the driver's counter with the device counter. Signed-off-by: Netanel Belgazal --- drivers/net/ethernet/amazon/ena/ena_netdev.c | 9 + 1 file

[PATCH net-next 08/13] net: ena: separate skb allocation to dedicated function

2017-06-18 Thread netanel
From: Netanel Belgazal Signed-off-by: Netanel Belgazal --- drivers/net/ethernet/amazon/ena/ena_netdev.c | 44 +--- 1 file changed, 27 insertions(+), 17 deletions(-) diff --git a/drivers/net/ethernet/amazon/ena/ena_netdev.c

[PATCH net-next 06/13] net: ena: allow the driver to work with small number of msix vectors

2017-06-18 Thread netanel
From: Netanel Belgazal Current driver tries to allocate msix vectors as the number of the negotiated io queues. (with another msix vector for management). If pci_alloc_irq_vectors() fails, the driver aborts the probe and the ENA network device is never brought up. With this

[PATCH net-next 07/13] net: ena: use napi_schedule_irqoff when possible

2017-06-18 Thread netanel
From: Netanel Belgazal Signed-off-by: Netanel Belgazal --- drivers/net/ethernet/amazon/ena/ena_netdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/amazon/ena/ena_netdev.c

[PATCH net-next 04/13] net: ena: add reset reason for each device FLR

2017-06-18 Thread netanel
From: Netanel Belgazal For each device reset, log to the device what is the cause the reset occur. Signed-off-by: Netanel Belgazal --- drivers/net/ethernet/amazon/ena/ena_com.c | 5 +++- drivers/net/ethernet/amazon/ena/ena_com.h | 4 +++-

[PATCH net-next 01/13] net: ena: change return value for unsupported features unsupported return value

2017-06-18 Thread netanel
From: Netanel Belgazal return -EOPNOTSUPP instead of -EPERM. Signed-off-by: Netanel Belgazal --- drivers/net/ethernet/amazon/ena/ena_com.c | 22 +++--- drivers/net/ethernet/amazon/ena/ena_ethtool.c | 10 +++---

[PATCH net-next 00/13] update ena ethernet driver to version 1.2.0

2017-06-18 Thread netanel
From: Netanel Belgazal This patchset contains some new features/improvements that were added to the ENA driver to increase its robustness and are based on experience of wide ENA deployment. Netanel Belgazal (13): net: ena: change return value for unsupported features

Re: [PATCH net-next] net/mlx4_en: don't set CHECKSUM_COMPLETE on SCTP packets

2017-06-18 Thread Tariq Toukan
On 16/06/2017 5:01 PM, Davide Caratti wrote: if the NIC fails to validate the checksum on TCP/UDP, and validation of IP checksum is successful, the driver subtracts the pseudo-header checksum from the value obtained by the hardware and sets CHECKSUM_COMPLETE. Don't do that if protocol is

Re: [PATCH v3] ip6_tunnel: Correct tos value in collect_md mode

2017-06-18 Thread Peter Dawson
On Sat, 17 Jun 2017 11:38:05 +0800 Haishuang Yan wrote: > Same as ip_gre, geneve and vxlan, use key->tos as traffic class value. > > CC: Peter Dawson > Fixes: 0e9a709560db ("ip6_tunnel, ip6_gre: fix setting of DSCP on > encapsulated

Re: [PATCH 42/44] powerpc/cell: use the dma_supported method for ops switching

2017-06-18 Thread Benjamin Herrenschmidt
On Sun, 2017-06-18 at 00:13 -0700, Christoph Hellwig wrote: > On Sun, Jun 18, 2017 at 06:50:27AM +1000, Benjamin Herrenschmidt wrote: > > What is your rationale here ? (I have missed patch 0 it seems). > > Less code duplication, more modular dma_map_ops insteance. > > > dma_supported() was

RXFH manual configuration

2017-06-18 Thread Tariq Toukan
Hi Jacob, I am looking at your patch: d4ab4286276f ethtool: correctly ensure {GS}CHANNELS doesn't conflict ... I wonder - if I want to configure the number of channels (ethtool -L), without being aware to the history of indirection table (manually set or not), how can I know what is the

Re: [PATCH 42/44] powerpc/cell: use the dma_supported method for ops switching

2017-06-18 Thread Christoph Hellwig
On Sun, Jun 18, 2017 at 06:50:27AM +1000, Benjamin Herrenschmidt wrote: > What is your rationale here ? (I have missed patch 0 it seems). Less code duplication, more modular dma_map_ops insteance. > dma_supported() was supposed to be pretty much a "const" function > simply informing whether a

Re: [PATCH 03/44] dmaengine: ioat: don't use DMA_ERROR_CODE

2017-06-18 Thread Christoph Hellwig
On Fri, Jun 16, 2017 at 01:40:24PM -0700, Alexander Duyck wrote: > dma_unmap_page on dest_dma if "op == IOAT_OP_XOR"? Odds are it is what > the compiler is already generating and will save a few lines of code > so what you end up with is something like: Honestly wanted to touch the code as little

Re: [PATCH V3 net-next 0/8] Hisilicon Network Subsystem 3 Ethernet Driver

2017-06-18 Thread Leon Romanovsky
On Sat, Jun 17, 2017 at 06:24:23PM +0100, Salil Mehta wrote: > This patch-set contains the support of the HNS3 (Hisilicon Network Subsystem > 3) > Ethernet driver for hip08 family of SoCs and future upcoming SoCs. > > Hisilicon's new hip08 SoCs have integrated ethernet based on PCI Express and >