Re: [PATCH] netxen: Fix a sleep-in-atomic bug in netxen_nic_pci_mem_access_direct

2017-06-20 Thread Jia-Ju Bai
On 06/21/2017 02:11 PM, Kalle Valo wrote: David Miller writes: From: Jia-Ju Bai Date: Mon, 19 Jun 2017 10:48:53 +0800 The driver may sleep under a spin lock, and the function call path is: netxen_nic_pci_mem_access_direct (acquire the lock by spin_lock) ioremap --> may sleep To fix it,

Re: [PATCH] netxen: Fix a sleep-in-atomic bug in netxen_nic_pci_mem_access_direct

2017-06-20 Thread Kalle Valo
David Miller writes: > From: Jia-Ju Bai > Date: Mon, 19 Jun 2017 10:48:53 +0800 > >> The driver may sleep under a spin lock, and the function call path is: >> netxen_nic_pci_mem_access_direct (acquire the lock by spin_lock) >> ioremap --> may sleep >> >> To fix it, the lock is released before

[PATCH rdma-next 03/19] RDMA/netlink: Rename and remove redundant parameter from ibnl_unicast

2017-06-20 Thread Leon Romanovsky
From: Leon Romanovsky Netlink message header is not needed for unicast reply, hence remove it. Signed-off-by: Leon Romanovsky --- drivers/infiniband/core/iwpm_msg.c | 6 +++--- drivers/infiniband/core/iwpm_util.c | 4 ++-- drivers/infiniband/core/netlink.c | 5 ++--- include/rdma/rdma_netli

[PATCH rdma-next 15/19] RDMA/netlink: Implement nldev device dumpit calback

2017-06-20 Thread Leon Romanovsky
From: Leon Romanovsky This patch adds the ability to return all available devices together with their properties. Signed-off-by: Leon Romanovsky --- drivers/infiniband/core/nldev.c | 61 - 1 file changed, 60 insertions(+), 1 deletion(-) diff --git a/dri

[PATCH rdma-next 09/19] RDMA/netlink: Add and implement doit netlink callback

2017-06-20 Thread Leon Romanovsky
From: Leon Romanovsky The .doit callback is used by netlink core to differentiate between get and set operations. Common convention is to use that call for command operations like (SET, ADD, e.t.c.) and/or access without NLF_M_DUMP flag. This commit adds proper declaration and implementation to

[PATCH rdma-next 17/19] RDMA/netlink: Add nldev port dumpit implementation

2017-06-20 Thread Leon Romanovsky
From: Leon Romanovsky This patch implements the query interface to get all ports data for the specific device. Signed-off-by: Leon Romanovsky --- drivers/infiniband/core/nldev.c | 60 + 1 file changed, 60 insertions(+) diff --git a/drivers/infiniband/co

[PATCH rdma-next 18/19] RDMA/netlink: Implement nldev port doit callback

2017-06-20 Thread Leon Romanovsky
From: Leon Romanovsky Provide ability to get specific to device and port information. Signed-off-by: Leon Romanovsky --- drivers/infiniband/core/nldev.c | 45 + 1 file changed, 45 insertions(+) diff --git a/drivers/infiniband/core/nldev.c b/drivers/infi

[PATCH rdma-next 14/19] RDMA/netlink: Add nldev initialization flows

2017-06-20 Thread Leon Romanovsky
From: Leon Romanovsky Add nldev init and exit flows to the RDMA/core. Signed-off-by: Leon Romanovsky --- drivers/infiniband/core/Makefile| 4 +++- drivers/infiniband/core/core_priv.h | 4 drivers/infiniband/core/device.c| 2 ++ drivers/infiniband/core/nldev.c | 45 +

[PATCH rdma-next 19/19] RDMA/netlink: Expose device and port capability masks

2017-06-20 Thread Leon Romanovsky
From: Leon Romanovsky The port capability mask is exposed to user space via sysfs interface, while device capabilities are available for verbs only. This patch provides those capabilities through netlink interface. Signed-off-by: Leon Romanovsky --- drivers/infiniband/core/nldev.c | 19 +

[PATCH rdma-next 06/19] RDMA/netlink: Rename netlink callback struct

2017-06-20 Thread Leon Romanovsky
From: Leon Romanovsky The RDMA netlink client infrastructure was removed and made obsolete the old name (ibnl_client_cbs). This patch renames to the more appropriate name (rdma_nl_cbs). Signed-off-by: Leon Romanovsky --- drivers/infiniband/core/cma.c | 2 +- drivers/infiniband/core/device.

[PATCH rdma-next 13/19] RDMA/netlink: Add netlink device definitions to UAPI

2017-06-20 Thread Leon Romanovsky
From: Leon Romanovsky Introduce new defines to rdma_netlink.h, so the RDMA configuration tool will be able to communicate with RDMA subsystem by using the shared defines. The addition of new client (NLDEV) revealed the fact that we exposed by mistake the RDMA_NL_I40IW define which is not backed

[PATCH rdma-next 07/19] RDMA/core: Add iterator over ib_devices

2017-06-20 Thread Leon Romanovsky
From: Leon Romanovsky The coming nldev needs iterate over all IB devices in the system and in order do not expose the ib_devices list outside the devices.c, it is necessary to provide function iterator. Current version is written explicitly for nldev callback to avoid over-engineering at this st

[PATCH rdma-next 08/19] RDMA/core: Expose translation from device name to ib_device

2017-06-20 Thread Leon Romanovsky
From: Leon Romanovsky Provide ability to convert from device name to ib_device for the IB/core users. Signed-off-by: Leon Romanovsky --- drivers/infiniband/core/core_priv.h | 1 + drivers/infiniband/core/device.c| 3 +-- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/driver

[PATCH rdma-next 10/19] RDMA/netlink: Reduce indirection access to cb_table

2017-06-20 Thread Leon Romanovsky
From: Leon Romanovsky Introduce intermediate variable to store access to fields of cb_table. Signed-off-by: Leon Romanovsky --- drivers/infiniband/core/netlink.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/drivers/infiniband/core/netlink.c b/drivers/infin

[PATCH rdma-next 11/19] RDMA/netlink: Convert LS to doit callback

2017-06-20 Thread Leon Romanovsky
From: Leon Romanovsky RDMA_NL_LS protocol is actually is not dump anything, but sets data and it should be handled by doit callback. This patch actually converts RDMA_NL_LS to doit callback, while preserving IWCM and RDMA_CM flows through netlink_dump_start(). Signed-off-by: Leon Romanovsky --

[PATCH rdma-next 12/19] RDMA/netlink: Update copyright

2017-06-20 Thread Leon Romanovsky
From: Leon Romanovsky Add Mellanox to the copyright header. Signed-off-by: Leon Romanovsky --- drivers/infiniband/core/netlink.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/infiniband/core/netlink.c b/drivers/infiniband/core/netlink.c index 52fce73be9c1..9731c313e9b9 100644 --

[PATCH rdma-next 04/19] RDMA/netlink: Rename and remove redundant parameter from ibnl_multicast

2017-06-20 Thread Leon Romanovsky
From: Leon Romanovsky The pointer to netlink header was not used in the ibnl_multicast function, so let's remove it and simplify the function signature. Signed-off-by: Leon Romanovsky --- drivers/infiniband/core/addr.c | 2 +- drivers/infiniband/core/iwpm_msg.c | 2 +- drivers/infiniband/c

[PATCH rdma-next 05/19] RDMA/netlink: Simplify and rename ibnl_chk_listeners

2017-06-20 Thread Leon Romanovsky
From: Leon Romanovsky Make ibnl_chk_listeners function to be one line by removing unneeded comparison. Rename that function to be complaint to other functions in RDMA netlink. Signed-off-by: Leon Romanovsky --- drivers/infiniband/core/addr.c | 2 +- drivers/infiniband/core/netlink.c | 8

[PATCH rdma-next 16/19] RDMa/netlink: Add nldev device doit implementation

2017-06-20 Thread Leon Romanovsky
From: Leon Romanovsky Provide ability to query specific device. Signed-off-by: Leon Romanovsky --- drivers/infiniband/core/nldev.c | 40 1 file changed, 40 insertions(+) diff --git a/drivers/infiniband/core/nldev.c b/drivers/infiniband/core/nldev.c ind

[PATCH rdma-next 01/19] RDMA/netlink: Add flag to consolidate common handing

2017-06-20 Thread Leon Romanovsky
From: Leon Romanovsky Add ability to provide flags to control RDMA netlink callbacks and convert addr.c and sa_query.c to be first users of such infrastructure. It allows to move their CAP_NET_ADMIN checks into netlink core. Signed-off-by: Leon Romanovsky --- drivers/infiniband/core/addr.c

[PATCH rdma-next 00/19] RDMA Netlink Device Client

2017-06-20 Thread Leon Romanovsky
The following patch set is an implementation of NLDEV - RDMA netlink device client. It is based on the already sent patch [1] and patch set [2]. This client is needed to properly integrate coming RDMAtool [3] into iproute2 package which is based on netlink. The following patch set can be logicall

[PATCH rdma-next 02/19] RDMA/netlink: Simplify the put_msg and put_attr

2017-06-20 Thread Leon Romanovsky
From: Leon Romanovsky Reuse standard macros to cancel the netlink message in case of error. Signed-off-by: Leon Romanovsky --- drivers/infiniband/core/netlink.c | 31 +-- 1 file changed, 9 insertions(+), 22 deletions(-) diff --git a/drivers/infiniband/core/netlink.

[PATCH v2] brcmfmac: Fix a memory leak in error handling path in 'brcmf_cfg80211_attach'

2017-06-20 Thread Christophe JAILLET
If 'wiphy_new()' fails, we leak 'ops'. Add a new label in the error handling path to free it in such a case. Cc: sta...@vger.kernel.org Fixes: 5c22fb85102a7 ("brcmfmac: add wowl gtk rekeying offload support") Signed-off-by: Christophe JAILLET --- v2: Add CC tag Change prefix --- drivers/net/

Re: [PATCH net 1/2] xfrm6: Fix IPv6 payload_len in xfrm6_transport_finish

2017-06-20 Thread Steffen Klassert
On Mon, Jun 19, 2017 at 11:33:20AM +0300, yoss...@mellanox.com wrote: > From: Yossi Kuperman > > IPv6 payload length indicates the size of the payload, including any > extension headers. In xfrm6_transport_finish, ipv6_hdr(skb)->payload_len > is set to the payload size only, regardless of the pre

[PATCH net-next] qede: Fix compilation without QED_RDMA

2017-06-20 Thread Yuval Mintz
From: Chad Dupuis When CONFIG_QED_RDMA isn't defined, we'd hit the following: /include/linux/qed/qede_rdma.h:84:19: warning: ‘qede_rdma_dev_add’ used but never defined [enabled by default] static inline int qede_rdma_dev_add(struct qede_dev *dev); Fixes: bbfcd1e8e167 ("qed*: Set rdma generic

Re: [RFC 1/2] net-next: fix DSA flow_disection

2017-06-20 Thread John Crispin
On 20/06/17 23:52, Andrew Lunn wrote: On Tue, Jun 20, 2017 at 07:37:35PM +0200, John Crispin wrote: On 20/06/17 16:01, Andrew Lunn wrote: On Tue, Jun 20, 2017 at 10:06:54AM +0200, John Crispin wrote: RPS and probably other kernel features are currently broken on some if not all DSA devices.

Re: [PATCH NET] net/hns:bugfix of ethtool -t phy self_test

2017-06-20 Thread l00371289
Hi, Andrew On 2017/6/21 11:13, Andrew Lunn wrote: > On Wed, Jun 21, 2017 at 10:03:29AM +0800, l00371289 wrote: >> Hi, Andrew >> >> On 2017/6/20 21:27, Andrew Lunn wrote: >>> On Tue, Jun 20, 2017 at 11:05:54AM +0800, l00371289 wrote: hi, Florian On 2017/6/20 5:00, Florian Fainelli wr

[PATCH net-next] r8152: correct the definition

2017-06-20 Thread Hayes Wang
Replace VLAN_HLEN and CRC_SIZE with ETH_FCS_LEN. Signed-off-by: Hayes Wang --- drivers/net/usb/r8152.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c index 8bc4573..6cfffef 100644 --- a/drivers/net/us

Re: [Patch net] ipv6: only call ip6_route_dev_notify() once for NETDEV_UNREGISTER

2017-06-20 Thread David Ahern
On 6/20/17 2:42 PM, Cong Wang wrote: > In commit 242d3a49a2a1 ("ipv6: reorder ip6_route_dev_notifier after > ipv6_dev_notf") > I assumed NETDEV_REGISTER and NETDEV_UNREGISTER are paired, > unfortunately, as reported by jeffy, netdev_wait_allrefs() > could rebroadcast NETDEV_UNREGISTER event until

Re: [PATCH NET] net/hns:bugfix of ethtool -t phy self_test

2017-06-20 Thread Andrew Lunn
On Wed, Jun 21, 2017 at 10:03:29AM +0800, l00371289 wrote: > Hi, Andrew > > On 2017/6/20 21:27, Andrew Lunn wrote: > > On Tue, Jun 20, 2017 at 11:05:54AM +0800, l00371289 wrote: > >> hi, Florian > >> > >> On 2017/6/20 5:00, Florian Fainelli wrote: > >>> On 06/16/2017 02:24 AM, Lin Yun Sheng wrote:

Re: [Patch net] ipv6: only call ip6_route_dev_notify() once for NETDEV_UNREGISTER

2017-06-20 Thread jeffy
Hi Cong Wang, oh, oops, i did misread. also, Tested-by: Jeffy Chen On 06/21/2017 11:01 AM, jeffy wrote: Hi Cong Wang, i don't know much about net core, maybe i'm misreading the code...but On 06/21/2017 02:42 AM, Cong Wang wrote: In commit 242d3a49a2a1 ("ipv6: reorder ip6_route_dev_notifier

Re: Repeatable inet6_dump_fib crash in stock 4.12.0-rc4+

2017-06-20 Thread David Ahern
On 6/20/17 5:41 PM, Ben Greear wrote: > On 06/20/2017 11:05 AM, Michal Kubecek wrote: >> On Tue, Jun 20, 2017 at 07:12:27AM -0700, Ben Greear wrote: >>> On 06/14/2017 03:25 PM, David Ahern wrote: On 6/14/17 4:23 PM, Ben Greear wrote: > On 06/13/2017 07:27 PM, David Ahern wrote: > >

Re: [Patch net] ipv6: only call ip6_route_dev_notify() once for NETDEV_UNREGISTER

2017-06-20 Thread jeffy
Hi Cong Wang, i don't know much about net core, maybe i'm misreading the code...but On 06/21/2017 02:42 AM, Cong Wang wrote: In commit 242d3a49a2a1 ("ipv6: reorder ip6_route_dev_notifier after ipv6_dev_notf") I assumed NETDEV_REGISTER and NETDEV_UNREGISTER are paired, unfortunately, as reporte

Re: [PATCH] liquidio: stop using huge static buffer, save 4096k in .data

2017-06-20 Thread Felix Manlunas
From: David Miller Date: Tue, 20 Jun 2017 21:17:13 -0400 > From: Felix Manlunas > Date: Tue, 20 Jun 2017 13:51:25 -0700 > > > From: Derek Chickles > > Date: Tue, 20 Jun 2017 13:15:34 -0700 > > > >> > From: David Miller [mailto:da...@davemloft.net] > >> > Sent: Tuesday, June 20, 2017 12:22 PM

Re: [PATCH] net: intel: e1000e: add check on e1e_wphy() return value

2017-06-20 Thread Ethan Zhao
Gustavo, The return value of ret_val seems used to check if the access to PHY/NVM got its semaphore, generally speaking, it is needed for every PHY access of this driver. Reviewed-by: Ethan Zhao On Wed, Jun 21, 2017 at 5:22 AM, Gustavo A. R. Silva wrote: > Check return value from call to e

[PATCH] PATCH v3 Convert multiple netdev_info messages to netdev_dbg

2017-06-20 Thread Michael J Dilmore
The bond_options.c file contains multiple netdev_info messages that clutter kernel output. This patches replaces these with netdev_dbg messages and adds a netdev_dbg for packets for slave. Signed-off-by: Michael J Dilmore Suggested-by: Joe Perches --- drivers/net/bonding/bond_options.c | 54 +++

Re: [PATCH NET] net/hns:bugfix of ethtool -t phy self_test

2017-06-20 Thread l00371289
Hi, Andrew On 2017/6/20 21:28, Andrew Lunn wrote: The question really is, why is not this properly integrated into the PHY driver and PHYLIB such that the only thing the Ethernet MAC driver has to call is a function of the PHY driver putting it in self-test? >>> >>> This whole drive

[PATCH net-next] Add a tcp_filter hook before handle ack packet

2017-06-20 Thread Chenbo Feng
From: Chenbo Feng Currently in both ipv4 and ipv6 code path, the ack packet received when sk at TCP_NEW_SYN_RECV state is not filtered by socket filter or cgroup filter since it is handled from tcp_child_process and never reaches the tcp_filter inside tcp_v4_rcv or tcp_v6_rcv. Adding a tcp_filter

Re: [PATCH NET] net/hns:bugfix of ethtool -t phy self_test

2017-06-20 Thread l00371289
Hi, Andrew On 2017/6/20 21:27, Andrew Lunn wrote: > On Tue, Jun 20, 2017 at 11:05:54AM +0800, l00371289 wrote: >> hi, Florian >> >> On 2017/6/20 5:00, Florian Fainelli wrote: >>> On 06/16/2017 02:24 AM, Lin Yun Sheng wrote: This patch fixes the phy loopback self_test failed issue. when M

linux-next: manual merge of the net-next tree with the pci tree

2017-06-20 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the net-next tree got a conflict in: drivers/net/wireless/marvell/mwifiex/pcie.c between commit: c336cc0ee4eb ("PCI: Split ->reset_notify() method into ->reset_prepare() and ->reset_done()") from the pci tree and commit: 68efd0386988 ("mwifiex: pcie:

linux-next: manual merge of the net-next tree with the net tree

2017-06-20 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the net-next tree got a conflict in: net/core/rtnetlink.c between commit: db833d40ad32 ("rtnetlink: add IFLA_GROUP to ifla_policy") from the net tree and commit: 3d3ea5af5c0b ("rtnl: Add support for netdev event to link messages") from the net-next t

[net-next 05/15] i40e: use dev_dbg instead of dev_info when warning about missing routine

2017-06-20 Thread Jeff Kirsher
From: Jacob Keller When searching for the vf_capability client routine, dev_info() was used, instead of the normal dev_dbg(). This causes the message to be displayed at standard log levels which can cause administrators to worry. Avoid this by using dev_dbg instead. Copyright updated to 2017. S

[net-next 08/15] i40e: Support firmware CEE DCB UP to TC map re-definition

2017-06-20 Thread Jeff Kirsher
From: Greg Bowers Changes parsing of FW 4.33 AQ command Get CEE DCBX OPER CFG (0x0A07). Change is required because FW now creates the oper_prio_tc nibbles reversed from those in the CEE Priority Group sub-TLV. This change will only apply to FW 4.33 as future FW versions will use a different funct

[net-next 13/15] i40e: clear only cause_ena bit

2017-06-20 Thread Jeff Kirsher
From: Shannon Nelson When disabling interrupts, we should only be clearing the CAUSE_ENA bit, not clearing the whole register. Clearing the whole register sets the NEXTQ_IDX field to 0 instead of 0x7ff which can confuse the Firmware in some reset sequences. Signed-off-by: Shannon Nelson Signed

[net-next 07/15] i40e: Fix potential out of bound array access

2017-06-20 Thread Jeff Kirsher
From: Sudheer Mogilappagari This is a fix for the static code analysis issue where dcbcfg->numapps could be greater than size of array (i.e dcbcfg->app[I40E_DCBX_MAX_APPS]). The fix makes sure that the array is not accessed past the size of of the array (i.e. I40E_DCBX_MAX_APPS). Copyright updat

[net-next 15/15] i40e: don't hold RTNL lock for the entire reset

2017-06-20 Thread Jeff Kirsher
From: Jacob Keller We recently refactored i40e_do_reset() and its friends to be able to hold the RTNL lock only for the portions that actually need to be protected. However, a separate refactoring added several new callers of these functions during the PCIe error recovery and suspend/resume cycle

[net-next 12/15] i40e: fix disabling overflow promiscuous mode

2017-06-20 Thread Jeff Kirsher
From: Alan Brady There exists a bug in which the driver does not correctly exit overflow promiscuous mode. This can occur if "too many" mac filters are added, putting the driver into overflow promiscuous mode, and the filters are then removed. When the failed filters are removed, the driver rep

[net-next 10/15] i40e: genericize the partition bandwidth control

2017-06-20 Thread Jeff Kirsher
From: Shannon Nelson Partition bandwidth control is not in just one form of MFP (multi-function partitioning), so make the code more generic and be sure to nudge the Tx scheduler for all MFP. Copyright updated to 2017. Signed-off-by: Shannon Nelson Signed-off-by: Mitch Williams Tested-by: And

[net-next 04/15] i40e/i40evf: update WOL and I40E_AQC_ADDR_VALID_MASK flags

2017-06-20 Thread Jeff Kirsher
From: Alice Michael Update a few flags related to FW interactions. Copyright updated to 2017. Signed-off-by: Alice Michael Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/i40e/i40e_adminq_cmd.h | 4 ++-- drivers/net/ethernet/intel/i40evf/i40e_adminq_cmd

[net-next 03/15] i40evf: assign num_active_queues inside i40evf_alloc_queues

2017-06-20 Thread Jeff Kirsher
From: Jacob Keller The variable num_active_queues represents the number of active queues we have for the device. We assign this pretty early in i40evf_init_subtask. Several code locations are written with loops over the tx_rings and rx_rings structures, which don't get allocated until i40evf_all

[net-next 01/15] i40e: add XDP support for pass and drop actions

2017-06-20 Thread Jeff Kirsher
From: Björn Töpel This commit adds basic XDP support for i40e derived NICs. All XDP actions will end up in XDP_DROP. Signed-off-by: Björn Töpel Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/i40e/i40e.h | 7 ++ drivers/net/ethernet/intel/i40e/i40e_

[net-next 09/15] i40e: Add message for unsupported MFP mode

2017-06-20 Thread Jeff Kirsher
From: Carolyn Wyborny This patch adds a check and message if the device is in MFP mode as changing RSS input set is not supported in MFP mode. Signed-off-by: Carolyn Wyborny Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/i40e/i40e_ethtool.c | 6 ++ 1

[net-next 14/15] i40e: Handle PE_CRITERR properly with IWARP enabled

2017-06-20 Thread Jeff Kirsher
From: Catherine Sullivan When IWARP is enabled, we weren't clearing the PE_CRITERR, just logging it and removing it from the mask. We need to do a corer to reset the PE_CRITERR register, so set the bit for that as we handle the interrupt. We should also be checking for the error against the PFIN

[net-next 02/15] i40e: add support for XDP_TX action

2017-06-20 Thread Jeff Kirsher
From: Björn Töpel This patch adds proper XDP_TX action support. For each Tx ring, an additional XDP Tx ring is allocated and setup. This version does the DMA mapping in the fast-path, which will penalize performance for IOMMU enabled systems. Further, debugfs support is not wired up for the XDP T

[net-next 11/15] i40e: Add support for OEM firmware version

2017-06-20 Thread Jeff Kirsher
From: Filip Sadowski This patch adds support for OEM firmware version. If OEM specific adapter is detected ethtool reports OEM product version in firmware version string instead of etrack id. Signed-off-by: Filip Sadowski Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/e

[net-next 06/15] i40e: comment that udp_port must be in host byte order

2017-06-20 Thread Jeff Kirsher
From: Jacob Keller The firmware expects the port number passed when setting up the UDP tunnel configuration to be in Little Endian format. The i40e_aq_add_udp_tunnel command byte swaps the value from host order to Little Endian. Since commit fe0b0cd97b4f ("i40e: send correct port number to Admin

[net-next 00/15][pull request] 40GbE Intel Wired LAN Driver Updates 2017-06-20

2017-06-20 Thread Jeff Kirsher
This series contains updates to i40e and i40evf only. Björn adds additional XDP support for i40e, by adding pass and drop actions and XDP_TX action support. Jake fixes a possible NULL pointer dereference in i40evf_get_ethtool_stats() which could occur if the VF fails to recover from a reset, and

Re: [PATCH] liquidio: stop using huge static buffer, save 4096k in .data

2017-06-20 Thread David Miller
From: Felix Manlunas Date: Tue, 20 Jun 2017 13:51:25 -0700 > From: Derek Chickles > Date: Tue, 20 Jun 2017 13:15:34 -0700 > >> > From: David Miller [mailto:da...@davemloft.net] >> > Sent: Tuesday, June 20, 2017 12:22 PM >> > >> > From: Denys Vlasenko >> > Date: Mon, 19 Jun 2017 21:50:52 +0200

Investment portfolio

2017-06-20 Thread HDD Investment Co.
Hello, How are you today? we have the financial capability to finance any investment portfolio as far as is genuine, all we need is a capable business partner that possesses investment strategies or profitable business information for good turn over within 10-20years. We can provide proof of

Re: [PATCH] [PATCH v2 net-next] bonding: Convert multiple netdev_info messages to netdev_dbg

2017-06-20 Thread Joe Perches
On Tue, 2017-06-20 at 23:05 +0100, Michael J Dilmore wrote: > The bond_options.c file contains several netdev_info messages that clutter > kernel output. This patch changes all netdev_info messages > to netdev_dbg and adds a netdev debug for the packets per slave parameter. Hey Michael. You shou

Re: [PATCH 00/51] rtc: stop using rtc deprecated functions

2017-06-20 Thread Russell King - ARM Linux
On Wed, Jun 21, 2017 at 12:00:30AM +0200, Thomas Gleixner wrote: > Yes, but there are still quite some issues to solve there: > > 1) How do you tell the system that it should apply the offset in the > first place, i.e at boot time before NTP or any other mechanism can > correct it

[PATCH] [PATCH v2 net-next] bonding: Convert multiple netdev_info messages to netdev_dbg

2017-06-20 Thread Michael J Dilmore
The bond_options.c file contains several netdev_info messages that clutter kernel output. This patch changes all netdev_info messages to netdev_dbg and adds a netdev debug for the packets per slave parameter. Suggested-by: Joe Perches Signed-off-by: Michael J Dilmore --- drivers/net/bonding/bo

Re: [PATCH 00/51] rtc: stop using rtc deprecated functions

2017-06-20 Thread Pavel Machek
Hi! > >> > This is it. > >> > https://patchwork.kernel.org/patch/6219401/ > >> > >> Thanks. > >> > >> Yes, that's argument against changing rtc _drivers_ for hardware that > >> can not do better than 32bit. For generic code (such as 44/51 sysfs, > >> 51/51 suspend test), the change still makes sen

Re: [PATCH 00/51] rtc: stop using rtc deprecated functions

2017-06-20 Thread Thomas Gleixner
On Tue, 20 Jun 2017, Alexandre Belloni wrote: > On 20/06/2017 at 22:15:36 +0100, Russell King - ARM Linux wrote: > > On Tue, Jun 20, 2017 at 05:07:46PM +0200, Benjamin Gaignard wrote: > > > 2017-06-20 15:48 GMT+02:00 Alexandre Belloni > > > : > > > >> Yes, that's argument against changing rtc _driv

Re: [RFC 1/2] net-next: fix DSA flow_disection

2017-06-20 Thread Andrew Lunn
> On Tue, Jun 20, 2017 at 07:37:35PM +0200, John Crispin wrote: > > > On 20/06/17 16:01, Andrew Lunn wrote: > >On Tue, Jun 20, 2017 at 10:06:54AM +0200, John Crispin wrote: > >>RPS and probably other kernel features are currently broken on some if not > >>all DSA devices. The root cause of this t

Re: [PATCH] net: phy: smsc: fix buffer overflow in memcpy

2017-06-20 Thread Andrew Lunn
On Tue, Jun 20, 2017 at 10:40:46PM +0200, Arnd Bergmann wrote: > The memcpy annotation triggers for a fixed-length buffer copy: > > In file included from /git/arm-soc/arch/arm64/include/asm/processor.h:30:0, > from /git/arm-soc/arch/arm64/include/asm/spinlock.h:21, >

Re: [PATCH v2] net/phy: micrel: configure intterupts after autoneg workaround

2017-06-20 Thread Florian Fainelli
On 06/20/2017 10:48 AM, Zach Brown wrote: > The commit ("net/phy: micrel: Add workaround for bad autoneg") fixes an > autoneg failure case by resetting the hardware. This turns off > intterupts. Things will work themselves out if the phy polls, as it will > figure out it's state during a poll. Howe

Re: [PATCH v2] net/phy: micrel: configure intterupts after autoneg workaround

2017-06-20 Thread Andrew Lunn
On Tue, Jun 20, 2017 at 12:48:11PM -0500, Zach Brown wrote: > The commit ("net/phy: micrel: Add workaround for bad autoneg") fixes an > autoneg failure case by resetting the hardware. This turns off > intterupts. Things will work themselves out if the phy polls, as it will > figure out it's state d

Re: Repeatable inet6_dump_fib crash in stock 4.12.0-rc4+

2017-06-20 Thread Ben Greear
On 06/20/2017 11:05 AM, Michal Kubecek wrote: On Tue, Jun 20, 2017 at 07:12:27AM -0700, Ben Greear wrote: On 06/14/2017 03:25 PM, David Ahern wrote: On 6/14/17 4:23 PM, Ben Greear wrote: On 06/13/2017 07:27 PM, David Ahern wrote: Let's try a targeted debug patch. See attached I had to chan

[PATCH net-next v2 06/12] nfp: add stats and xmit helpers for representors

2017-06-20 Thread Simon Horman
Provide helpers for stats and xmit on representor netdevs. Parts based on work by Bert van Leeuwen, Benjamin LaHaise and Jakub Kicinski. Signed-off-by: Simon Horman Reviewed-by: Jakub Kicinski --- drivers/net/ethernet/netronome/nfp/nfp_net_repr.c | 199 +- drivers/net/ether

[PATCH net-next v2 12/12] nfp: add VF and PF representors to flower app

2017-06-20 Thread Simon Horman
Initialise VF and PF representors in flower app. Based in part on work by Benjamin LaHaise, Bert van Leeuwen and Jakub Kicinski. Signed-off-by: Simon Horman Reviewed-by: Jakub Kicinski --- drivers/net/ethernet/netronome/nfp/flower/main.c | 86 +++- 1 file changed, 84 insert

[PATCH net-next v2 11/12] nfp: add flower app

2017-06-20 Thread Simon Horman
Add app for flower offload. At this point the PF netdev and phys port representor netdevs are initialised. Follow-up work will add support for VF and PF representors and beyond that offloading the flower classifier. Based in part on work by Benjamin LaHaise and Bert van Leeuwen. Signed-off-by: Si

[PATCH net-next v2 08/12] nfp: provide nfp_port to of nfp_net_get_mac_addr()

2017-06-20 Thread Simon Horman
Provide port rather than vNIC as parameter of nfp_net_get_mac_addr. This is to allow this function to be used by representor netdevs where a vNIC may have more than one physical port none of which are associated with the vNIC. Signed-off-by: Simon Horman Reviewed-by: Jakub Kicinski --- drivers/

[PATCH net-next v2 10/12] nfp: add support for control messages for flower app

2017-06-20 Thread Simon Horman
In preparation for adding a new flower app - targeted at offloading the flower classifier - provide support for control message that it will use to communicate with the NFP. Based in part on work by Bert van Leeuwen. Signed-off-by: Simon Horman Reviewed-by: Jakub Kicinski --- drivers/net/ether

[PATCH net-next v2 09/12] nfp: add support for tx/rx with metadata portid

2017-06-20 Thread Simon Horman
Allow tx/rx with metadata port id. This will be used for tx/rx of representor netdevs acting as upper-devices while a pf netdev acts as a lower-device. Signed-off-by: Simon Horman Reviewed-by: Jakub Kicinski --- drivers/net/ethernet/netronome/nfp/nfp_net.h | 1 + .../net/ethernet/netrono

[PATCH net-next v2 07/12] nfp: app callbacks for SRIOV

2017-06-20 Thread Simon Horman
Add app-callbacks for app-specific initialisation of SRIOV. Disabling SRIOV is brought forward in nfp_pci_remove() so that nfp_app_sriov_disable is called while the app still exists. This is intended to be used to implement representor netdevs for virtual ports. Signed-off-by: Simon Horman Revi

[PATCH net-next v2 00/12] nfp: add flower app with representors

2017-06-20 Thread Simon Horman
Hi, this series adds a flower app to the NFP driver. It initialises four types of netdevs: * PF netdev - lower-device for communication of packets to device * PF representor netdev * VF representor netdevs * Phys port representor netdevs The PF netdev acts as a lower-device which sends and recei

[PATCH net-next v2 01/12] net: store port/representator id in metadata_dst

2017-06-20 Thread Simon Horman
From: Jakub Kicinski Switches and modern SR-IOV enabled NICs may multiplex traffic from Port representators and control messages over single set of hardware queues. Control messages and muxed traffic may need ordered delivery. Those requirements make it hard to comfortably use TC infrastructure

[PATCH net-next v2 05/12] nfp: general representor implementation

2017-06-20 Thread Simon Horman
Provide infrastructure to create and destroy representors of a given type. Parts based on work by Bert van Leeuwen, Benjamin LaHaise, and Jakub Kicinski. Signed-off-by: Simon Horman Reviewed-by: Jakub Kicinski --- drivers/net/ethernet/netronome/nfp/Makefile | 1 + drivers/net/ethernet/

[PATCH net-next v2 04/12] nfp: map mac_stats and vf_cfg BARs

2017-06-20 Thread Simon Horman
If present map mac_stats and vf_cfg BARs. These will be used by representor netdevs to read statistics for phys port and vf representors. Also provide defines describing the layout of the mac_stats area. Similar defines are already present for the cf_cfg area. Based in part on work by Jakub Kicin

[PATCH net-next v2 03/12] nfp: move physical port init into a helper

2017-06-20 Thread Simon Horman
From: Jakub Kicinski Move MAC/PHY port init into a helper to make it easier to reuse it in the representor code. Signed-off-by: Jakub Kicinski Signed-off-by: Simon Horman --- drivers/net/ethernet/netronome/nfp/nfp_app_nic.c | 23 ++ drivers/net/ethernet/netronome/nfp/nfp_p

[PATCH net-next v2 02/12] nfp: devlink add support for getting eswitch mode

2017-06-20 Thread Simon Horman
From: Jakub Kicinski Add app callback for reporting eswitch mode. Non-SRIOV apps should not implement this callback, nfp_app code will then respond with -EOPNOTSUPP. Signed-off-by: Jakub Kicinski Signed-off-by: Simon Horman --- drivers/net/ethernet/netronome/nfp/nfp_app.h | 15 ++

Re: [PATCH 00/51] rtc: stop using rtc deprecated functions

2017-06-20 Thread Alexandre Belloni
On 20/06/2017 at 22:15:36 +0100, Russell King - ARM Linux wrote: > On Tue, Jun 20, 2017 at 05:07:46PM +0200, Benjamin Gaignard wrote: > > 2017-06-20 15:48 GMT+02:00 Alexandre Belloni > > : > > >> Yes, that's argument against changing rtc _drivers_ for hardware that > > >> can not do better than 32b

Re: [PATCH net-next v3 4/4] ip6mr: add netlink notifications on mrt6msg cache reports

2017-06-20 Thread Nikolay Aleksandrov
On 20/06/17 23:54, Julien Gomes wrote: > Add Netlink notifications on cache reports in ip6mr, in addition to the > existing mrt6msg sent to mroute6_sk. > Send RTM_NEWCACHEREPORT notifications to RTNLGRP_IPV6_MROUTE_R. > > MSGTYPE, MIF_ID, SRC_ADDR and DST_ADDR Netlink attributes contain the > same

Re: [PATCH net-next v3 3/4] ipmr: add netlink notifications on igmpmsg cache reports

2017-06-20 Thread Nikolay Aleksandrov
On 20/06/17 23:54, Julien Gomes wrote: > Add Netlink notifications on cache reports in ipmr, in addition to the > existing igmpmsg sent to mroute_sk. > Send RTM_NEWCACHEREPORT notifications to RTNLGRP_IPV4_MROUTE_R. > > MSGTYPE, VIF_ID, SRC_ADDR and DST_ADDR Netlink attributes contain the > same d

Re: [PATCH net-next v3 07/15] bpf: Add setsockopt helper function to bpf

2017-06-20 Thread Craig Gallek
On Mon, Jun 19, 2017 at 11:00 PM, Lawrence Brakmo wrote: > Added support for calling a subset of socket setsockopts from > BPF_PROG_TYPE_SOCK_OPS programs. The code was duplicated rather > than making the changes to call the socket setsockopt function because > the changes required would have been

[PATCH] net: intel: e1000e: add check on e1e_wphy() return value

2017-06-20 Thread Gustavo A. R. Silva
Check return value from call to e1e_wphy(). This value is being checked during previous calls to function e1e_wphy() and it seems a check was missing here. Addresses-Coverity-ID: 1226905 Signed-off-by: Gustavo A. R. Silva --- drivers/net/ethernet/intel/e1000e/ich8lan.c | 2 ++ 1 file changed, 2

Re: [PATCH 00/51] rtc: stop using rtc deprecated functions

2017-06-20 Thread Russell King - ARM Linux
On Tue, Jun 20, 2017 at 05:07:46PM +0200, Benjamin Gaignard wrote: > 2017-06-20 15:48 GMT+02:00 Alexandre Belloni > : > >> Yes, that's argument against changing rtc _drivers_ for hardware that > >> can not do better than 32bit. For generic code (such as 44/51 sysfs, > >> 51/51 suspend test), the ch

[PATCH net-next v3 1/4] rtnetlink: add NEWCACHEREPORT message type

2017-06-20 Thread Julien Gomes
New NEWCACHEREPORT message type to be used for cache reports sent via Netlink, effectively allowing splitting cache report reception from mroute programming. Suggested-by: Ryan Halbrook Signed-off-by: Julien Gomes Reviewed-by: Nikolay Aleksandrov --- include/uapi/linux/rtnetlink.h | 3 +++ sec

[PATCH net-next v3 0/4] ipmr/ip6mr: add Netlink notifications on cache reports

2017-06-20 Thread Julien Gomes
Currently, all ipmr/ip6mr cache reports are sent through the mroute/mroute6 socket only. This forces the use of a single socket for mroute programming, cache reports and, regarding ipmr, IGMP messages without Router Alert option reception. The present patches are aiming to send Netlink notificatio

[PATCH net-next v3 2/4] rtnetlink: add restricted rtnl groups for ipv4 and ipv6 mroute

2017-06-20 Thread Julien Gomes
Add RTNLGRP_{IPV4,IPV6}_MROUTE_R as two new restricted groups for the NETLINK_ROUTE family. Binding to these groups specifically requires CAP_NET_ADMIN to allow multicast of sensitive messages (e.g. mroute cache reports). Suggested-by: Nikolay Aleksandrov Signed-off-by: Julien Gomes Signed-off-b

[PATCH net-next v3 4/4] ip6mr: add netlink notifications on mrt6msg cache reports

2017-06-20 Thread Julien Gomes
Add Netlink notifications on cache reports in ip6mr, in addition to the existing mrt6msg sent to mroute6_sk. Send RTM_NEWCACHEREPORT notifications to RTNLGRP_IPV6_MROUTE_R. MSGTYPE, MIF_ID, SRC_ADDR and DST_ADDR Netlink attributes contain the same data as their equivalent fields in the mrt6msg hea

[PATCH net-next v3 3/4] ipmr: add netlink notifications on igmpmsg cache reports

2017-06-20 Thread Julien Gomes
Add Netlink notifications on cache reports in ipmr, in addition to the existing igmpmsg sent to mroute_sk. Send RTM_NEWCACHEREPORT notifications to RTNLGRP_IPV4_MROUTE_R. MSGTYPE, VIF_ID, SRC_ADDR and DST_ADDR Netlink attributes contain the same data as their equivalent fields in the igmpmsg heade

Re: [PATCH] liquidio: stop using huge static buffer, save 4096k in .data

2017-06-20 Thread Felix Manlunas
From: Derek Chickles Date: Tue, 20 Jun 2017 13:15:34 -0700 > > From: David Miller [mailto:da...@davemloft.net] > > Sent: Tuesday, June 20, 2017 12:22 PM > > > > From: Denys Vlasenko > > Date: Mon, 19 Jun 2017 21:50:52 +0200 > > > > > Only compile-tested - I don't have the hardware. > > > > > >

Re: [PATCH v1 1/2] dt-binding: ptp: add bindings document for dte based ptp clock

2017-06-20 Thread Scott Branden
Hi Rob, On 17-06-18 07:04 AM, Rob Herring wrote: On Mon, Jun 12, 2017 at 01:26:00PM -0700, Arun Parameswaran wrote: Add device tree binding documentation for the Broadcom DTE PTP clock driver. Signed-off-by: Arun Parameswaran --- Documentation/devicetree/bindings/ptp/brcm,ptp-dte.txt | 13

Re: [PATCH net-next 06/12] nfp: add stats and xmit helpers for representors

2017-06-20 Thread Simon Horman
On Wed, Jun 21, 2017 at 01:15:05AM +0800, kbuild test robot wrote: > Hi Simon, > > [auto build test ERROR on net-next/master] > > url: > https://github.com/0day-ci/linux/commits/Simon-Horman/nfp-add-flower-app-with-representors/20170620-233831 > config: arm-allmodconfig

[PATCH] net: phy: smsc: fix buffer overflow in memcpy

2017-06-20 Thread Arnd Bergmann
The memcpy annotation triggers for a fixed-length buffer copy: In file included from /git/arm-soc/arch/arm64/include/asm/processor.h:30:0, from /git/arm-soc/arch/arm64/include/asm/spinlock.h:21, from /git/arm-soc/include/linux/spinlock.h:87, from

RE: [PATCH] liquidio: stop using huge static buffer, save 4096k in .data

2017-06-20 Thread Chickles, Derek
> From: David Miller [mailto:da...@davemloft.net] > Sent: Tuesday, June 20, 2017 12:22 PM > > From: Denys Vlasenko > Date: Mon, 19 Jun 2017 21:50:52 +0200 > > > Only compile-tested - I don't have the hardware. > > > > From code inspection, octeon_pci_write_core_mem() appears to be safe wrt > > u

[net-next PATCH] tcp: md5: hide unused variable

2017-06-20 Thread Arnd Bergmann
Changing from a memcpy to per-member comparison left the size variable unused: net/ipv4/tcp_ipv4.c: In function 'tcp_md5_do_lookup': net/ipv4/tcp_ipv4.c:910:15: error: unused variable 'size' [-Werror=unused-variable] This does not show up when CONFIG_IPV6 is enabled, but the variable can be remo

[GIT] Networking

2017-06-20 Thread David Miller
1) Fix refcounting wrt. timers which hold onto inet6 address objects, from Xin Long. 2) Fix an ancient bug in wireless wext ioctls, from Johannes Berg. 3) Firmware handling fixes in brcm80211 driver, from Arend Van Spriel. 4) Several mlx5 driver fixes (firmware readiness, timestamp cap repor

  1   2   3   >