[PATCH] datapath: Avoid using stack larger than 1024.

2017-06-27 Thread Tonghao Zhang
When compiling OvS-master on 4.4.0-81 kernel, there is a warning: CC [M] /root/ovs/datapath/linux/datapath.o /root/ovs/datapath/linux/datapath.c: In function ‘ovs_flow_cmd_set’: /root/ovs/datapath/linux/datapath.c:1221:1: warning: the frame size of 1040 bytes is larger than 10

bug report: hairpin NAT doesn't work across bridges

2017-06-27 Thread Russell Stuart
Configuration =   A box running Debian stretch is acting as a NAT'ing router.   It has a single Ethernet NIC and a wireless NIC servicing the local   LAN.  These devices are bridged.  Since it has only one wired NIC   it is used to connect to both the LAN and internet via a switch.   T

[PATCH net-next 01/14] nfp: explicitly check if application FW is loaded

2017-06-27 Thread Jakub Kicinski
We support application FW being either loaded automatically at boot from flash or (more commonly) by the driver from disk. If FW is not found on disk and nothing is preloaded users are faced with this unintuitive error: nfp :04:00.0: nfp: Failed to find PF symbol _pf0_net_bar0 We can do bette

[PATCH net-next 00/14] nfp: get_phys_port_name for representors and SR-IOV reorder

2017-06-27 Thread Jakub Kicinski
Hi! This series starts by making the error message if FW cannot be located easier to understand. Then I move some functions from PCI probe files into library code (nfpcore) where they belong, and remove one function which is never used. Next few patches equip representors with nfp_port structure

[PATCH net-next 03/14] nfp: add helper for mapping runtime symbols

2017-06-27 Thread Jakub Kicinski
Move most of the helper for mapping RTsyms from nfp_net_main.c to nfpcore. Use the new helper directly for mapping MAC statistics, since they don't need to include the PCIe interface ID in the symbol name. Signed-off-by: Jakub Kicinski Reviewed-by: Simon Horman --- drivers/net/ethernet/netrono

[PATCH net-next 04/14] nfp: remove unused nfp_cpp_area_check_range()

2017-06-27 Thread Jakub Kicinski
Remove unused nfp_cpp_area_check_range() function. Signed-off-by: Jakub Kicinski Reviewed-by: Simon Horman --- .../net/ethernet/netronome/nfp/nfpcore/nfp_cpp.h| 2 -- .../ethernet/netronome/nfp/nfpcore/nfp_cppcore.c| 21 - 2 files changed, 23 deletions(-) diff --gi

[PATCH net-next 07/14] nfp: make the representor get stats app-independent

2017-06-27 Thread Jakub Kicinski
Thanks to the fact that all representors will now have an nfp_port, we can depend on information there to provide a app-independent .ndo_get_stats64(). Signed-off-by: Jakub Kicinski Reviewed-by: Simon Horman --- drivers/net/ethernet/netronome/nfp/flower/main.c | 16 + drivers/net/e

[PATCH net-next 05/14] nfp: add nfp_app cleanup callback and make flower use it

2017-06-27 Thread Jakub Kicinski
Add a cleanup callback for undoing what app init callback did. Make flower allocate its private structure on init and free it from the new callback. While at it remember to set the app pointer to NULL on the error path to avoid any races while probe path unwinds. Signed-off-by: Jakub Kicinski Re

[PATCH net-next 09/14] nfp: allow converting representor's netdev into nfp_port

2017-06-27 Thread Jakub Kicinski
Based on struct net_device_ops figure out if netdev is a nfp_repr. Use this knowledge to convert netdev directly to nfp_port. Signed-off-by: Jakub Kicinski Reviewed-by: Simon Horman --- drivers/net/ethernet/netronome/nfp/nfp_net_repr.c | 2 +- drivers/net/ethernet/netronome/nfp/nfp_net_repr.h

[PATCH net-next 08/14] nfp: move representors' struct net_device_ops to shared code

2017-06-27 Thread Jakub Kicinski
Apps shouldn't declare their own struct net_device_ops for representors, this makes sharing code harder. Add necessary nfp_app callbacks and move the definition of representors' struct net_device_ops to common code. Signed-off-by: Jakub Kicinski Reviewed-by: Simon Horman --- drivers/net/ethern

[PATCH net-next 02/14] nfp: move area mapping helper into nfpcore

2017-06-27 Thread Jakub Kicinski
nfp_net_map_area() is a helper for mapping areas of NFP memory defined in nfp_net_main.c. Move it to nfpcore to allow reuse and rename accordingly. Create an additional helper - nfp_cpp_area_alloc_acquire() the opposite of already existing nfp_cpp_area_release_free(). Signed-off-by: Jakub Kicins

[PATCH net-next 12/14] nfp: reorder SR-IOV config and nfp_app SR-IOV callbacks

2017-06-27 Thread Jakub Kicinski
We previously assumed that app callback can be guaranteed to be executed before SR-IOV is actually enabled. Given that we can't guarantee that SR-IOV will be disabled during probe or that we will be able to disable it on remove, we should reorder the callbacks. We should also call the app's sriov_

[PATCH net-next 14/14] nfp: flower: add Kconfig for flower app

2017-06-27 Thread Jakub Kicinski
Give users an option not to build the flower-offload related code. Signed-off-by: Jakub Kicinski Reviewed-by: Simon Horman --- drivers/net/ethernet/netronome/Kconfig | 10 ++ drivers/net/ethernet/netronome/nfp/Makefile | 8 ++-- drivers/net/ethernet/netronome/nfp/nfp_app.c |

[PATCH net-next 06/14] nfp: spawn nfp_ports for PF and VF ports

2017-06-27 Thread Jakub Kicinski
nfp_port is an abstraction which is supposed to allow us sharing code between different netdev types (vNIC vs repr). Spawn ports for PFs and VFs to enable this sharing. Signed-off-by: Jakub Kicinski Reviewed-by: Simon Horman --- drivers/net/ethernet/netronome/nfp/flower/main.c | 19 +++

[PATCH net-next 11/14] nfp: handle SR-IOV already enabled when driver is probing

2017-06-27 Thread Jakub Kicinski
We assumed that when we probe number of enabled VFs will be at 0. This doesn't have to be the case for example if previous driver left SR-IOV enabled due to some VFs being assigned. Read the number of VFs enabled. Fail probe if it's above current FWs limit. Signed-off-by: Jakub Kicinski Reviewe

[PATCH net-next 10/14] nfp: wire get_phys_port_name on representors

2017-06-27 Thread Jakub Kicinski
Make nfp_port_get_phys_port_name() support new port types and wire it up to representors' struct net_device_ops. Signed-off-by: Jakub Kicinski Reviewed-by: Simon Horman --- drivers/net/ethernet/netronome/nfp/nfp_net_repr.c | 1 + drivers/net/ethernet/netronome/nfp/nfp_port.c | 30 +

[PATCH net-next 13/14] nfp: allocate a private workqueue for driver work

2017-06-27 Thread Jakub Kicinski
Since we grab pf->lock around pci_enable_sriov() we can no longer safely queue work which may also grab that lock onto system workqueue. pci_enable_sriov() will flush system workqueue as part to wait for VF probing. Signed-off-by: Jakub Kicinski Reviewed-by: Simon Horman --- drivers/net/etherne

Re: [PATCH v6 05/21] net-next: stmmac: Add dwmac-sun8i

2017-06-27 Thread Chen-Yu Tsai
On Tue, Jun 27, 2017 at 4:05 PM, Corentin Labbe wrote: > On Mon, Jun 26, 2017 at 01:18:23AM +0100, André Przywara wrote: >> On 31/05/17 08:18, Corentin Labbe wrote: >> > The dwmac-sun8i is a heavy hacked version of stmmac hardware by >> > allwinner. >> > In fact the only common part is the descrip

RE: [RFC 01/19] qed: Introduce iWARP personality

2017-06-27 Thread Kalderon, Michal
From: Leon Romanovsky [mailto:l...@kernel.org] Sent: Tuesday, June 27, 2017 8:37 AM > > On Mon, Jun 26, 2017 at 09:06:51PM +0300, Michal Kalderon wrote: > > iWARP personality introduced the need for differentiating in several > > places in the code whether we are RoCE, iWARP or either. This leads

RE: [RFC 15/19] RDMA/qedr: Add iWARP support in existing verbs.

2017-06-27 Thread Kalderon, Michal
From: Leon Romanovsky [mailto:l...@kernel.org] Sent: Tuesday, June 27, 2017 8:27 AM > On Mon, Jun 26, 2017 at 09:07:05PM +0300, Michal Kalderon wrote: > > Make slight modifications to common RoCE/iWARP code. > > Add additional doorbell for iWARP post_send. > > iWARP QP pbl is allocated in qed and

RE: [RFC 02/19] qed: Implement iWARP initialization, teardown and qp operations

2017-06-27 Thread Kalderon, Michal
From: Leon Romanovsky [mailto:l...@kernel.org] Sent: Tuesday, June 27, 2017 8:46 AM > > On Mon, Jun 26, 2017 at 09:06:52PM +0300, Michal Kalderon wrote: > > This patch adds iWARP support for flows that have common code between > > RoCE and iWARP, such as initialization, teardown and qp setup verbs

Re: [PATCH v6 05/21] net-next: stmmac: Add dwmac-sun8i

2017-06-27 Thread Corentin Labbe
On Tue, Jun 27, 2017 at 04:11:21PM +0800, Chen-Yu Tsai wrote: > On Tue, Jun 27, 2017 at 4:05 PM, Corentin Labbe > wrote: > > On Mon, Jun 26, 2017 at 01:18:23AM +0100, André Przywara wrote: > >> On 31/05/17 08:18, Corentin Labbe wrote: > >> > The dwmac-sun8i is a heavy hacked version of stmmac hard

[net-next v2 1/6] ixgbe: Ensure MAC filter was added before setting MACVLAN

2017-06-27 Thread Jeff Kirsher
From: Tony Nguyen This patch adds a check to ensure that adding the MAC filter was successful before setting the MACVLAN. If it was unsuccessful, propagate the error. Signed-off-by: Tony Nguyen Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/ixgbe/ixgbe_s

[net-next v2 2/6] ixgbe: Enable LASI interrupts for X552 devices

2017-06-27 Thread Jeff Kirsher
From: Tony Nguyen Enable LASI interrupts on X552 devices in order to receive notifications of link configurations of the external PHY and support the configuration of the internal iXFI link since iXFI does not support auto-negotiation. This is not required for X553 devices; add a check to avoid

[net-next v2 3/6] ixgbe: Update NW_MNG_IF_SEL support for X553

2017-06-27 Thread Jeff Kirsher
From: Tony Nguyen The MAC register NW_MNG_IF_SEL fields have been redefined for X553. These changes impact the iXFI driver code flow. Since iXFI is only supported in X552, add MAC checks for iXFI flows. Signed-off-by: Tony Nguyen Signed-off-by: Paul Greenwalt Tested-by: Andrew Bowers Signed-o

[net-next v2 4/6] ixgbe: Do not support flow control autonegotiation for X553

2017-06-27 Thread Jeff Kirsher
From: Tony Nguyen Flow control autonegotiation is not supported for fiber on X553. Add device ID checks in ixgbe_device_supports_autoneg_fc() to return the appropriate value. Signed-off-by: Tony Nguyen Signed-off-by: Emil Tantilov Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- dr

[net-next v2 6/6] ixgbe: Add malicious driver detection support

2017-06-27 Thread Jeff Kirsher
From: Paul Greenwalt Add malicious driver detection (MDD) support for X550, X550em_a, and X550em_x devices. MDD is a hardware SR-IOV security feature which the driver enables by default, but can be controlled on|off by ethtool set-priv-flags parameter. When enabled MDD disables a VF drivers tran

[net-next v2 5/6] ixgbe: Disable flow control for XFI

2017-06-27 Thread Jeff Kirsher
From: Tony Nguyen Flow control autonegotiation is not supported for XFI. Make sure that ixgbe_device_supports_autoneg_fc() returns false and hw->fc.disable_fc_autoneg is set to true to avoid running the fc_autoneg function for that device. Signed-off-by: Tony Nguyen Signed-off-by: Emil Tantilo

[net-next v2 0/6][pull request] 10GbE Intel Wired LAN Driver Updates 2017-06-27

2017-06-27 Thread Jeff Kirsher
This series contains updates to ixgbe only. Tony provides majority of the changes, starting with adding a check to ensure that adding a MAC filter was successful, before setting the MACVLAN. In order to receive notifications of link configurations of the external PHY and support the configuration

RE: [PATCH] net: usb: asix88179_178a: Add support for the Belkin B2B128

2017-06-27 Thread David Laight
From: Andrew F. Davis > Sent: 26 June 2017 18:41 > The Belkin B2B128 is a USB 3.0 Hub + Gigabit Ethernet Adapter, the > Ethernet adapter uses the ASIX AX88179 USB 3.0 to Gigabit Ethernet > chip supported by this driver, add the USB ID for the same. ... I've just had a look at the current version o

Re: [PATCH v6 05/21] net-next: stmmac: Add dwmac-sun8i

2017-06-27 Thread Corentin Labbe
On Mon, Jun 26, 2017 at 01:18:23AM +0100, André Przywara wrote: > On 31/05/17 08:18, Corentin Labbe wrote: > > The dwmac-sun8i is a heavy hacked version of stmmac hardware by > > allwinner. > > In fact the only common part is the descriptor management and the first > > register function. > > Hi, >

Re: [PATCH v6 05/21] net-next: stmmac: Add dwmac-sun8i

2017-06-27 Thread Andre Przywara
Hi, (CC:ing some people from that Rockchip dmwac series) On 27/06/17 09:21, Corentin Labbe wrote: > On Tue, Jun 27, 2017 at 04:11:21PM +0800, Chen-Yu Tsai wrote: >> On Tue, Jun 27, 2017 at 4:05 PM, Corentin Labbe >> wrote: >>> On Mon, Jun 26, 2017 at 01:18:23AM +0100, André Przywara wrote:

Re: [net-next v2 6/6] ixgbe: Add malicious driver detection support

2017-06-27 Thread Or Gerlitz
On Tue, Jun 27, 2017 at 11:51 AM, Jeff Kirsher wrote: > From: Paul Greenwalt > > Add malicious driver detection (MDD) support for X550, X550em_a, > and X550em_x devices. > > MDD is a hardware SR-IOV security feature which the driver enables by > default, but can be controlled on|off by ethtool se

[PATCH] datapath: Avoid using stack larger than 1024.

2017-06-27 Thread Tonghao Zhang
When compiling OvS-master on 4.4.0-81 kernel, there is a warning: CC [M] /root/ovs/datapath/linux/datapath.o /root/ovs/datapath/linux/datapath.c: In function ‘ovs_flow_cmd_set’: /root/ovs/datapath/linux/datapath.c:1221:1: warning: the frame size of 1040 bytes is larger than 10

Re: [PATCH iproute2 3/5] rdma: Add device capability parsing

2017-06-27 Thread Leon Romanovsky
On Tue, Jun 27, 2017 at 07:06:04AM +0300, Leon Romanovsky wrote: > On Mon, Jun 26, 2017 at 02:36:10PM -0600, Jason Gunthorpe wrote: > > On Mon, Jun 26, 2017 at 10:21:03PM +0300, Leon Romanovsky wrote: > > > On Mon, Jun 26, 2017 at 12:29:24PM -0600, Jason Gunthorpe wrote: > > > > On Mon, Jun 26, 201

[PATCH 5/6] arm: sun8i: nanopi-neo: use internal phy-mode

2017-06-27 Thread Corentin Labbe
Since the PHY used is internal, simply set phy-mode as internal. Signed-off-by: Corentin Labbe --- arch/arm/boot/dts/sun8i-h3-nanopi-neo.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/sun8i-h3-nanopi-neo.dts b/arch/arm/boot/dts/sun8i-h3-nanopi-neo.dts

[PATCH 3/6] arm: sun8i: orangepi-zero: use internal phy-mode

2017-06-27 Thread Corentin Labbe
Since the PHY used is internal, simply set phy-mode as internal. Signed-off-by: Corentin Labbe --- arch/arm/boot/dts/sun8i-h2-plus-orangepi-zero.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/sun8i-h2-plus-orangepi-zero.dts b/arch/arm/boot/dts/sun8i-h2

[PATCH 6/6] arm: sun8i: orangepi-2: use internal phy-mode

2017-06-27 Thread Corentin Labbe
Since the PHY used is internal, simply set phy-mode as internal. Signed-off-by: Corentin Labbe --- arch/arm/boot/dts/sun8i-h3-orangepi-2.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/sun8i-h3-orangepi-2.dts b/arch/arm/boot/dts/sun8i-h3-orangepi-2.dts

[PATCH 4/6] arm: sun8i: orangepi-one: use internal phy-mode

2017-06-27 Thread Corentin Labbe
Since the PHY used is internal, simply set phy-mode as internal. Signed-off-by: Corentin Labbe --- arch/arm/boot/dts/sun8i-h3-orangepi-one.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/sun8i-h3-orangepi-one.dts b/arch/arm/boot/dts/sun8i-h3-orangepi-on

[PATCH 1/6] net: stmmac: support future possible different internal phy mode

2017-06-27 Thread Corentin Labbe
The current way to find if the phy is internal is to compare DT phy-mode and emac_variant/internal_phy. But it will negate a possible future SoC where an external PHY use the same phy mode than the internal one. By using phy-mode = "internal" we permit to have an external PHY with the same mode th

[PATCH 2/6] arm: sun8i: orangepipc: use internal phy-mode

2017-06-27 Thread Corentin Labbe
Since the PHY used is internal, simply set phy-mode as internal. Signed-off-by: Corentin Labbe --- arch/arm/boot/dts/sun8i-h3-orangepi-pc.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/sun8i-h3-orangepi-pc.dts b/arch/arm/boot/dts/sun8i-h3-orangepi-pc.d

[RESEND PATCH v4 1/3] Bluetooth: bnep: fix possible might sleep error in bnep_session

2017-06-27 Thread Jeffy Chen
It looks like bnep_session has same pattern as the issue reported in old rfcomm: while (1) { set_current_state(TASK_INTERRUPTIBLE); if (condition) break; // may call might_sleep here schedule();

[RESEND PATCH v4 3/3] Bluetooth: hidp: fix possible might sleep error in hidp_session_thread

2017-06-27 Thread Jeffy Chen
It looks like hidp_session_thread has same pattern as the issue reported in old rfcomm: while (1) { set_current_state(TASK_INTERRUPTIBLE); if (condition) break; // may call might_sleep here schedule();

[RESEND PATCH v4 2/3] Bluetooth: cmtp: fix possible might sleep error in cmtp_session

2017-06-27 Thread Jeffy Chen
It looks like cmtp_session has same pattern as the issue reported in old rfcomm: while (1) { set_current_state(TASK_INTERRUPTIBLE); if (condition) break; // may call might_sleep here schedule();

Re: [PATCH v6 05/21] net-next: stmmac: Add dwmac-sun8i

2017-06-27 Thread Maxime Ripard
On Tue, Jun 27, 2017 at 10:02:45AM +0100, Andre Przywara wrote: > Hi, > > (CC:ing some people from that Rockchip dmwac series) > > On 27/06/17 09:21, Corentin Labbe wrote: > > On Tue, Jun 27, 2017 at 04:11:21PM +0800, Chen-Yu Tsai wrote: > >> On Tue, Jun 27, 2017 at 4:05 PM, Corentin Labbe > >>

Re: Bluetooth: might sleep error in hidp_session_thread

2017-06-27 Thread jeffy
Hi Rohit, On 06/24/2017 02:00 AM, Rohit Vaswani wrote: I don't have a way to reply back to the older message; but you can use by tested-by for the below patch and re-send: ok, i've resent it, thanks for your test by~ and for replying to an old message, i've figured it out when i tried to do

[PATCH] net: atl1c: fix spelling mistake: "droppted" -> "dropped"

2017-06-27 Thread Colin King
From: Colin Ian King Trivial fix to spelling mistake in netif_info message Signed-off-by: Colin Ian King --- drivers/net/ethernet/atheros/atl1c/atl1c_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/atheros/atl1c/atl1c_main.c b/drivers/net/ethern

[PATCH] net/mlx4: fix spelling mistake: "enforcment" -> "enforcement"

2017-06-27 Thread Colin King
From: Colin Ian King Trivial fix to spelling mistake in mlx4_dbg debug message Signed-off-by: Colin Ian King --- drivers/net/ethernet/mellanox/mlx4/cmd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/mellanox/mlx4/cmd.c b/drivers/net/ethernet/mellano

Re: [PATCH net-next] netfilter: conntrack: add a new NF_CT_EXT_EXPAND extension

2017-06-27 Thread kbuild test robot
Hi Lin, [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Lin-Zhang/netfilter-conntrack-add-a-new-NF_CT_EXT_EXPAND-extension/20170627-000844 config: i386-allyesconfig (attached as .config) compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901 reproduce

RE: bug report: hairpin NAT doesn't work across bridges

2017-06-27 Thread Russell Stuart
I don't know how the unicode non-breaking spaces leaked into the previous version. Sorry about that. Configuration = A box running Debian stretch is acting as a NAT'ing router. It has a single Ethernet NIC and a wireless NIC servicing the local LAN. These devices are bridged.

Re: [PATCH v6 05/21] net-next: stmmac: Add dwmac-sun8i

2017-06-27 Thread Chen-Yu Tsai
On Tue, Jun 27, 2017 at 5:41 PM, Maxime Ripard wrote: > On Tue, Jun 27, 2017 at 10:02:45AM +0100, Andre Przywara wrote: >> Hi, >> >> (CC:ing some people from that Rockchip dmwac series) >> >> On 27/06/17 09:21, Corentin Labbe wrote: >> > On Tue, Jun 27, 2017 at 04:11:21PM +0800, Chen-Yu Tsai wrote

Re: [PATCH v6 05/21] net-next: stmmac: Add dwmac-sun8i

2017-06-27 Thread Andre Przywara
Hi, On 27/06/17 10:41, Maxime Ripard wrote: > On Tue, Jun 27, 2017 at 10:02:45AM +0100, Andre Przywara wrote: >> Hi, >> >> (CC:ing some people from that Rockchip dmwac series) >> >> On 27/06/17 09:21, Corentin Labbe wrote: >>> On Tue, Jun 27, 2017 at 04:11:21PM +0800, Chen-Yu Tsai wrote: On T

Re: [linux-sunxi] Re: [PATCH v6 05/21] net-next: stmmac: Add dwmac-sun8i

2017-06-27 Thread Icenowy Zheng
于 2017年6月27日 GMT+08:00 下午6:11:47, Chen-Yu Tsai 写到: >On Tue, Jun 27, 2017 at 5:41 PM, Maxime Ripard > wrote: >> On Tue, Jun 27, 2017 at 10:02:45AM +0100, Andre Przywara wrote: >>> Hi, >>> >>> (CC:ing some people from that Rockchip dmwac series) >>> >>> On 27/06/17 09:21, Corentin Labbe wrote: >>>

Re: [linux-sunxi] Re: [PATCH v6 05/21] net-next: stmmac: Add dwmac-sun8i

2017-06-27 Thread Chen-Yu Tsai
On Tue, Jun 27, 2017 at 6:17 PM, Icenowy Zheng wrote: > > > 于 2017年6月27日 GMT+08:00 下午6:11:47, Chen-Yu Tsai 写到: >>On Tue, Jun 27, 2017 at 5:41 PM, Maxime Ripard >> wrote: >>> On Tue, Jun 27, 2017 at 10:02:45AM +0100, Andre Przywara wrote: Hi, (CC:ing some people from that Rockchip d

Re: [PATCH v6 05/21] net-next: stmmac: Add dwmac-sun8i

2017-06-27 Thread Chen-Yu Tsai
On Tue, Jun 27, 2017 at 6:15 PM, Andre Przywara wrote: > Hi, > > On 27/06/17 10:41, Maxime Ripard wrote: >> On Tue, Jun 27, 2017 at 10:02:45AM +0100, Andre Przywara wrote: >>> Hi, >>> >>> (CC:ing some people from that Rockchip dmwac series) >>> >>> On 27/06/17 09:21, Corentin Labbe wrote: On

Re: [PATCH net-next 1/3] net: ethtool: add support for forward error correction modes

2017-06-27 Thread Jakub Kicinski
On Sat, 24 Jun 2017 12:19:43 -0700, Roopa Prabhu wrote: > Encoding: Types of encoding > Off: Turning off any encoding > RS : enforcing RS-FEC encoding on supported speeds > BaseR : enforcing Base R encoding on supported speeds > Auto : IEEE defaults for the speed/medium combination

Re: [PATCH v6 05/21] net-next: stmmac: Add dwmac-sun8i

2017-06-27 Thread Icenowy Zheng
于 2017年6月27日 GMT+08:00 下午6:15:58, Andre Przywara 写到: >Hi, > >On 27/06/17 10:41, Maxime Ripard wrote: >> On Tue, Jun 27, 2017 at 10:02:45AM +0100, Andre Przywara wrote: >>> Hi, >>> >>> (CC:ing some people from that Rockchip dmwac series) >>> >>> On 27/06/17 09:21, Corentin Labbe wrote: On Tu

[PATCH NET V6 0/2] Add loopback support in phy_driver and hns ethtool fix

2017-06-27 Thread Lin Yun Sheng
This Patch Set add set_loopback in phy_driver and use it to setup loopback when doing ethtool phy self_test. Patch V6: Fix Or'ing error code in __lb_setup. Patch V5: Removing non loopback related code change. Patch V4: 1. Remove c45 checking 2. Add -ENOTSUPP when

[PATCH NET V6 2/2] net: hns: Use phy_driver to setup Phy loopback

2017-06-27 Thread Lin Yun Sheng
Use function set_loopback in phy_driver to setup phy loopback when doing ethtool self test. Signed-off-by: Lin Yun Sheng --- drivers/net/ethernet/hisilicon/hns/hnae.h| 1 + drivers/net/ethernet/hisilicon/hns/hns_ethtool.c | 102 +++ 2 files changed, 32 insertions(+)

[PATCH NET V6 1/2] net: phy: Add phy loopback support in net phy framework

2017-06-27 Thread Lin Yun Sheng
This patch add set_loopback in phy_driver, which is used by Mac driver to enable or disable a phy. it also add a generic genphy_loopback function, which use BMCR loopback bit to enable or disable a phy. Signed-off-by: Lin Yun Sheng --- drivers/net/phy/marvell.c| 1 + drivers/net/phy/phy_dev

Re: [PATCH] net/mlx4: fix spelling mistake: "enforcment" -> "enforcement"

2017-06-27 Thread Tariq Toukan
On 27/06/2017 1:02 PM, Colin King wrote: From: Colin Ian King Trivial fix to spelling mistake in mlx4_dbg debug message Signed-off-by: Colin Ian King --- drivers/net/ethernet/mellanox/mlx4/cmd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/mell

Re: [PATCH v6 05/21] net-next: stmmac: Add dwmac-sun8i

2017-06-27 Thread Andre Przywara
Hi, On 27/06/17 11:23, Icenowy Zheng wrote: > > > 于 2017年6月27日 GMT+08:00 下午6:15:58, Andre Przywara 写到: >> Hi, >> >> On 27/06/17 10:41, Maxime Ripard wrote: >>> On Tue, Jun 27, 2017 at 10:02:45AM +0100, Andre Przywara wrote: Hi, (CC:ing some people from that Rockchip dmwac series)

Re: [PATCH] net/mlx4: fix spelling mistake: "enforcment" -> "enforcement"

2017-06-27 Thread Colin Ian King
On 27/06/17 11:33, Tariq Toukan wrote: > > > On 27/06/2017 1:02 PM, Colin King wrote: >> From: Colin Ian King >> >> Trivial fix to spelling mistake in mlx4_dbg debug message >> >> Signed-off-by: Colin Ian King >> --- >> drivers/net/ethernet/mellanox/mlx4/cmd.c | 2 +- >> 1 file changed, 1 in

[PATCH][V2] net/mlx4: fix spelling mistake: "enforcment" -> "enforcement"

2017-06-27 Thread Colin King
From: Colin Ian King Trivial fix to spelling mistake in mlx4_dbg debug message Signed-off-by: Colin Ian King --- drivers/net/ethernet/mellanox/mlx4/cmd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/mellanox/mlx4/cmd.c b/drivers/net/ethernet/mellano

[PATCH] cavium: thunder: Remove duplicate "netdev->name" logging output

2017-06-27 Thread Joe Perches
Using netdev_(netdev, "%s: ...", netdev->name) duplicates the name in the output. Remove those uses. Miscellanea: o Use the netif_ convenience macros at the same time Signed-off-by: Joe Perches --- drivers/net/ethernet/cavium/thunder/nicvf_main.c | 33 -- drivers/net/eth

Re: [PATCH][V2] net/mlx4: fix spelling mistake: "enforcment" -> "enforcement"

2017-06-27 Thread Tariq Toukan
On 27/06/2017 1:36 PM, Colin King wrote: From: Colin Ian King Trivial fix to spelling mistake in mlx4_dbg debug message Signed-off-by: Colin Ian King --- drivers/net/ethernet/mellanox/mlx4/cmd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/mell

RE: [PATCH NET V6 1/2] net: phy: Add phy loopback support in net phy framework

2017-06-27 Thread Madalin-cristian Bucur
> -Original Message- > From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org] > On Behalf Of Lin Yun Sheng > Sent: Tuesday, June 27, 2017 2:01 PM > To: da...@davemloft.net; and...@lunn.ch; f.faine...@gmail.com > Cc: huangda...@hisilicon.com; xuw...@hisilicon.com; > liguo..

Re: [Qemu-devel] BUG: KASAN: use-after-free in free_old_xmit_skbs

2017-06-27 Thread Jean-Philippe Menil
On 06/27/2017 04:13 AM, Jason Wang wrote: On 2017年06月26日 15:35, Jean-Philippe Menil wrote: On 06/26/2017 04:50 AM, Jason Wang wrote: On 2017年06月24日 06:32, Cong Wang wrote: On Fri, Jun 23, 2017 at 1:43 AM, Jason Wang wrote: On 2017年06月23日 02:53, Michael S. Tsirkin wrote: On Thu, Jun 22,

Re: [PATCH v6 05/21] net-next: stmmac: Add dwmac-sun8i

2017-06-27 Thread Corentin Labbe
On Tue, Jun 27, 2017 at 11:33:56AM +0100, Andre Przywara wrote: > Hi, > > On 27/06/17 11:23, Icenowy Zheng wrote: > > > > > > 于 2017年6月27日 GMT+08:00 下午6:15:58, Andre Przywara > > 写到: > >> Hi, > >> > >> On 27/06/17 10:41, Maxime Ripard wrote: > >>> On Tue, Jun 27, 2017 at 10:02:45AM +0100, Andr

[PATCH net-next] vxlan: fix incorrect nlattr access in MTU check

2017-06-27 Thread Matthias Schiffer
The access to the wrong variable could lead to a NULL dereference and possibly other invalid memory reads in vxlan newlink/changelink requests with a IFLA_MTU attribute. Fixes: a985343ba906 "vxlan: refactor verification and application of configuration" Signed-off-by: Matthias Schiffer --- driv

[PATCH v3 net-next 00/12] bpf: rewrite value tracking in verifier

2017-06-27 Thread Edward Cree
This series simplifies alignment tracking, generalises bounds tracking and fixes some bounds-tracking bugs in the BPF verifier. Pointer arithmetic on packet pointers, stack pointers, map value pointers and context pointers has been unified, and bounds on these pointers are only checked when the

[PATCH v3 net-next 01/12] selftests/bpf: add test for mixed signed and unsigned bounds checks

2017-06-27 Thread Edward Cree
Currently fails due to bug in verifier bounds handling. Signed-off-by: Edward Cree --- tools/testing/selftests/bpf/test_verifier.c | 26 ++ 1 file changed, 26 insertions(+) diff --git a/tools/testing/selftests/bpf/test_verifier.c b/tools/testing/selftests/bpf/test_verif

[PATCH v3 net-next 02/12] bpf/verifier: rework value tracking

2017-06-27 Thread Edward Cree
Tracks value alignment by means of tracking known & unknown bits. Tightens some min/max value checks and fixes a couple of bugs therein. If pointer leaks are allowed, and adjust_ptr_min_max_vals returns -EACCES, treat the pointer as an unknown scalar and try again, because we might be able to con

[PATCH v3 net-next 03/12] nfp: change bpf verifier hooks to match new verifier data structures

2017-06-27 Thread Edward Cree
Signed-off-by: Edward Cree --- drivers/net/ethernet/netronome/nfp/bpf/verifier.c | 24 +-- kernel/bpf/tnum.c | 1 + 2 files changed, 15 insertions(+), 10 deletions(-) diff --git a/drivers/net/ethernet/netronome/nfp/bpf/verifier.c b/drivers/ne

[PATCH v3 net-next 04/12] bpf/verifier: track signed and unsigned min/max values

2017-06-27 Thread Edward Cree
Allows us to, sometimes, combine information from a signed check of one bound and an unsigned check of the other. We now track the full range of possible values, rather than restricting ourselves to [0, 1<<30) and considering anything beyond that as unknown. While this is probably not necessary

[PATCH v3 net-next 05/12] bpf/verifier: more concise register state logs for constant var_off

2017-06-27 Thread Edward Cree
Signed-off-by: Edward Cree --- kernel/bpf/verifier.c | 46 +++--- 1 file changed, 27 insertions(+), 19 deletions(-) diff --git a/kernel/bpf/verifier.c b/kernel/bpf/verifier.c index d45c1d1..3e1df75 100644 --- a/kernel/bpf/verifier.c +++ b/kernel/bpf/verifi

[PATCH v3 net-next 06/12] selftests/bpf: change test_verifier expectations

2017-06-27 Thread Edward Cree
Some of the verifier's error messages have changed, and some constructs that previously couldn't be verified are now accepted. Signed-off-by: Edward Cree --- tools/testing/selftests/bpf/test_verifier.c | 226 ++-- 1 file changed, 116 insertions(+), 110 deletions(-) diff

[PATCH v3 net-next 07/12] selftests/bpf: rewrite test_align

2017-06-27 Thread Edward Cree
Expectations have changed, as has the format of the logged state. To make the tests easier to read, add a line-matching framework so that each match need only quote the register it cares about. (Multiple matches may refer to the same line, but matches must be listed in order of increasing line.

[PATCH v3 net-next 10/12] selftests/bpf: don't try to access past MAX_PACKET_OFF in test_verifier

2017-06-27 Thread Edward Cree
"direct packet access: test2" was potentially reading four bytes from pkt + 0x, which could take it past the verifier's limit, causing the program to be rejected. Increase the shifts by one so that R2 is now mask 0x7fff instead of mask 0x. Signed-off-by: Edward Cree --- tools/testing/

[PATCH v3 net-next 09/12] selftests/bpf: add test for bogus operations on pointers

2017-06-27 Thread Edward Cree
Tests non-add/sub operations (AND, LSH) on pointers decaying them to unknown scalars. Also tests that a pkt_ptr add which could potentially overflow is rejected (find_good_pkt_pointers ignores it and doesn't give us any reg->range). Signed-off-by: Edward Cree --- tools/testing/selftests/bpf/te

[PATCH v3 net-next 12/12] selftests/bpf: variable offset negative tests

2017-06-27 Thread Edward Cree
Variable ctx accesses and stack accesses aren't allowed, because we can't determine what type of value will be read. Signed-off-by: Edward Cree --- tools/testing/selftests/bpf/test_verifier.c | 41 + 1 file changed, 41 insertions(+) diff --git a/tools/testing/selfte

[PATCH v3 net-next 11/12] selftests/bpf: add tests for subtraction & negative numbers

2017-06-27 Thread Edward Cree
Signed-off-by: Edward Cree --- tools/testing/selftests/bpf/test_align.c | 104 +++ 1 file changed, 104 insertions(+) diff --git a/tools/testing/selftests/bpf/test_align.c b/tools/testing/selftests/bpf/test_align.c index dfd96c6..6bc2ceb 100644 --- a/tools/testing/sel

[PATCH v3 net-next 08/12] selftests/bpf: add a test to test_align

2017-06-27 Thread Edward Cree
New test adds 14 to the unknown value before adding to the packet pointer, meaning there's no 'fixed offset' field and instead we add into the var_off, yielding a '4n+2' value. Signed-off-by: Edward Cree --- tools/testing/selftests/bpf/test_align.c | 67 1 file

Re: [PATCH NET V5 2/2] net: hns: Use phy_driver to setup Phy loopback

2017-06-27 Thread Andrew Lunn
> >> - phy_write(phy_dev, COPPER_CONTROL_REG, val); > >> + err = phy_resume(phy_dev); > > > > Maybe this was discussed with an earlier version of these patches. Why > > are using phy_resume() and phy_suspend()? > When self_test is invoked with ETH_TEST_FL_OFFLINE option, hns mac

[net-next] net: remove policy-routing.txt documentation

2017-06-27 Thread Vincent Bernat
It dates back from 2.1.16 and is obsolete since 2.1.68 when the current rule system has been introduced. Signed-off-by: Vincent Bernat --- Documentation/networking/policy-routing.txt | 150 1 file changed, 150 deletions(-) delete mode 100644 Documentation/networking

[PATCH net-next 0/3] fix sw timestamping for non PTP packets

2017-06-27 Thread Ivan Khoronzhuk
This series contains several corrections connected with timestamping for cpsw and netcp drivers based on same cpts module. Based on net/next Ivan Khoronzhuk (3): net: ethernet: ti: cpsw: move skb timestamp to packet_submit net: ethernet: ti: cpsw: fix sw timestamping for non PTP packets net

[PATCH net-next 3/3] net: ethernet: ti: netcp_ethss: use cpts to check if packet needs timestamping

2017-06-27 Thread Ivan Khoronzhuk
There is cpts function to check if packet can be timstamped with cpts. Seems that ptp_classify_raw cover all cases listed with "case". Signed-off-by: Ivan Khoronzhuk --- drivers/net/ethernet/ti/netcp_ethss.c | 18 +- 1 file changed, 1 insertion(+), 17 deletions(-) diff --git a/d

[PATCH net-next 2/3] net: ethernet: ti: cpsw: fix sw timestamping for non PTP packets

2017-06-27 Thread Ivan Khoronzhuk
The cpts can timestmap only ptp packets at this moment, so driver cannot mark every packet as though it's going to be timestamped, only because h/w timestamping for given skb is enabled with SKBTX_HW_TSTAMP. It doesn't allow to use sw timestamping, as result outgoing packet is not timestamped at al

[PATCH net-next 1/3] net: ethernet: ti: cpsw: move skb timestamp to packet_submit

2017-06-27 Thread Ivan Khoronzhuk
Move sw timestamp function close to channel submit function. Signed-off-by: Ivan Khoronzhuk --- drivers/net/ethernet/ti/cpsw.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/ethernet/ti/cpsw.c b/drivers/net/ethernet/ti/cpsw.c index b7a0f5e..422994e 100644 --- a

[PATCH net] net: prevent sign extension in dev_get_stats()

2017-06-27 Thread Eric Dumazet
From: Eric Dumazet Similar to the fix provided by Dominik Heidler in commit 9b3dc0a17d73 ("l2tp: cast l2tp traffic counter to unsigned") we need to take care of 32bit kernels in dev_get_stats(). When using atomic_long_read(), we add a 'long' to u64 and might misinterpret high order bit, unless w

Re: [v2] brcmfmac: Fix a memory leak in error handling path in 'brcmf_cfg80211_attach'

2017-06-27 Thread Kalle Valo
Christophe Jaillet wrote: > If 'wiphy_new()' fails, we leak 'ops'. Add a new label in the error > handling path to free it in such a case. > > Cc: sta...@vger.kernel.org > Fixes: 5c22fb85102a7 ("brcmfmac: add wowl gtk rekeying offload support") > Signed-off-by: Christophe JAILLET Patch applied

Re: [PATCH 05/11] net: stmmac: dwmac-rk: Add internal phy support

2017-06-27 Thread David.Wu
Hi Florian, Sorry for reply late. 在 2017/6/24 0:22, Florian Fainelli 写道: On 06/22/2017 09:59 PM, David Wu wrote: To make internal phy worked, need to configure the phy_clock, phy cru_reset and related registers. Change-Id: I6971c0a769754b824b1b908b56080cbaf7867d13 Signed-off-by: David Wu ---

[net-next 03/16] net/mlx5: Add support for multiple RoCE enable

2017-06-27 Thread Saeed Mahameed
From: Ilan Tayari Previously, only mlx5_ib enabled RoCE on the port, but FPGA needs it as well. Add support for counting number of enables, so that FPGA and IB can work in parallel and independently. Program the HW to enable RoCE on the first enable call, and program to disable RoCE on the last d

[pull request][net-next 00/16] Mellanox, mlx5 Innova IPsec offload

2017-06-27 Thread Saeed Mahameed
Hi Dave, This series from Ilan provides the support for IPsec XFRM offload in mlx5 drivers for Innova devices. For more detalis please see tag log from Ilan below. Please pull and let me know if there's any problem. Thanks, Saeed. --- The following changes since commit 593814d1beae8ad91be6c90

[net-next 09/16] net/mlx5: FPGA, Add high-speed connection routines

2017-06-27 Thread Saeed Mahameed
From: Ilan Tayari An FPGA high-speed connection has two endpoints, an FPGA QP and a ConnectX QP. Add library routines to create and connect the endpoints of an FPGA high-speed connection. These routines allow creating and interacting with both types of connections: Shell and Sandbox Unit (SBU).

[net-next 15/16] net/mlx5e: IPSec, Add Innova IPSec offload TX data path

2017-06-27 Thread Saeed Mahameed
From: Ilan Tayari In the TX data path, prepend a special metadata ethertype which instructs the hardware to perform cryptography. In addition, fill Software-Parser segment in TX descriptor so that the hardware may parse the ESP protocol, and perform TX checksum offload on the inner payload. Sup

[net-next 06/16] net/mlx5: Add QP WQ support

2017-06-27 Thread Saeed Mahameed
From: Ilan Tayari A QP in ConnectX is a concatenation of RQ and SQ which share a QP-number and work together. Add support for allocating and managing the work-queue buffer for a QP, in a similar way to how SQs and RQs are already supported. Signed-off-by: Ilan Tayari Signed-off-by: Saeed Mahame

[net-next 07/16] net/mlx5: FPGA, Move FPGA init/cleanup to init_once

2017-06-27 Thread Saeed Mahameed
From: Ilan Tayari The FPGA init and cleanup routines should be called just once per device. Move them to the init_once and cleanup_once routines. Signed-off-by: Ilan Tayari Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/fpga/core.c | 4 ++-- drivers/net/ethernet/me

[net-next 04/16] IB/mlx5: Respect mlx5_core reserved GIDs

2017-06-27 Thread Saeed Mahameed
From: Ilan Tayari Reserved gids are taken by the mlx5_core, report smaller GID table size to IB core. Set mlx5_query_roce_port's return value back to int. In case of error, return an indication. This rolls back some of the change in commit 50f22fd8ecf9 ("IB/mlx5: Set mlx5_query_roce_port's retur

[net-next 16/16] net/mlx5e: IPSec, Add IPSec ethtool stats

2017-06-27 Thread Saeed Mahameed
From: Ilan Tayari Add Innova IPSec SBU counters to the ethtool -S stats. Add IPSec offload error counters to the ethtool -S stats. Signed-off-by: Ilan Tayari Reviewed-by: Boris Pismenny Reviewed-by: Gal Pressman Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/Makef

  1   2   3   >