On 7/8/2017 9:46 AM, Christophe JAILLET wrote:
'alloc_dma_[rt]x_desc_resources()' functions look very close.
Remove a useless initialization and use the same label name for error
handling path in order to get them even closer.
Signed-off-by: Christophe JAILLET
Acked-by: Giuseppe Cavallaro
On 7/8/2017 9:46 AM, Christophe JAILLET wrote:
If the first 'kmalloc_array' within the loop fails, we should free what
as already been allocated, as done in all other error handling path.
Fixes: ce736788e8a9 ("net: stmmac: adding multiple buffers for TX")
Signed-off-by: Christophe JAILLET
Acke
On 7/8/2017 9:46 AM, Christophe JAILLET wrote:
If the first 'kmalloc_array' within the loop fails, we should free what
as already been allocated, as done in all other error handling path.
Fixes: 54139cf3bb33 ("net: stmmac: adding multiple buffers for rx")
Signed-off-by: Christophe JAILLET
Ack
netlink_sendskb() is problematic, it releases sock refcnt
silently which could cause troubles we can call it multiple
times. info->notify_sock is a good example where we
setup once and use it to send netlink skb's for many times.
It should not hold or release any refcnt, but needs to rely
on netlin
внимания;
Ваши сообщения превысил лимит памяти, который составляет 5 Гб, определенных
администратором, который в настоящее время работает на 10.9GB, Вы не сможете
отправить или получить новую почту, пока вы повторно не проверить ваш почтовый
ящик почты. Чтобы восстановить работоспособность Ваше
внимания;
Ваши сообщения превысил лимит памяти, который составляет 5 Гб, определенных
администратором, который в настоящее время работает на 10.9GB, Вы не сможете
отправить или получить новую почту, пока вы повторно не проверить ваш почтовый
ящик почты. Чтобы восстановить работоспособность Ваше
It's safer to use the generic library function for this, rather than
reinventing it here with hard-coded alignment values.
Signed-off-by: Jason A. Donenfeld
---
drivers/net/ethernet/sgi/ioc3-eth.c | 11 +++
1 file changed, 3 insertions(+), 8 deletions(-)
diff --git a/drivers/net/etherne
Being able to utilize this makes code a lot simpler and cleaner. It's
easier in many cases for drivers to pass around their private data
structure, while occationally needing to dip into net_device, rather
than the other way around, which results in tons of calls to netdev_priv
in the top of every
On Sat, Jul 8, 2017 at 12:39 AM, Cong Wang wrote:
> On Thu, Jul 6, 2017 at 7:24 AM, Jason A. Donenfeld wrote:
>> list_add(&priv->list, &list_of_things);
>>
>> ret = register_netdevice(); // if ret is < 0, then destruct above is
>> automatically called
>>
>> // RACE WITH L
On Wed, Jul 05, 2017 at 02:01:50PM +0100, Biju Das wrote:
> Add support for Gigabit Ethernet E-MAC on r8a7743 (RZ/G1M) SoC.
> Renesas RZ/G1M (R8A7743) SoC Ethernet AVB IP is identical to the R-Car Gen2
> family.
For the subject: "dt-bindings: net: ..."
>
> Signed-off-by: Biju Das
> Reviewed-by:
The new refcount debugging code spews this twice during boot on my router..
refcount_t: increment on 0; use-after-free.
[ cut here ]
WARNING: CPU: 1 PID: 17 at lib/refcount.c:152 refcount_inc+0x2b/0x30
CPU: 1 PID: 17 Comm: ksoftirqd/1 Not tainted 4.12.0-firewall+ #8
task:
On Sun, Jul 9, 2017 at 1:19 PM, Cong Wang wrote:
>
> Setting 'sock' to NULL here should be sufficient to fix it.
Thanks. Applied and marked for stable.
Linus
On Thu, 2017-07-06 at 10:12 +0200, Romain Perier wrote:
> The current PCI pool API are simple macro functions direct expanded
> to
> the appropriate dma pool functions. The prototypes are almost the
> same
> and semantically, they are very similar. I propose to use the DMA
> pool
> API directly and
From: Sowmini Varadhan
Date: Sun, 9 Jul 2017 15:11:31 -0400
> On (07/09/17 11:49), Linus Torvalds wrote:
>>
>> On Sat, Jul 8, 2017 at 3:36 AM, David Miller wrote:
>> >
>> > 8) Fix socket leak on accept() in RDS, from Sowmini Varadhan. Also
>> >add a WARN_ON() to sock_graft() so other proto
The retry logic for netlink_attachskb() inside sys_mq_notify()
is nasty and vulnerable:
1) The sock refcnt is already released when retry is needed
2) The fd is controllable by user-space because we already
release the file refcnt
so we when retry but the fd has been just closed by user-space
On Sat, Jul 8, 2017 at 11:55 AM, Linus Torvalds
wrote:
> On Sat, Jul 8, 2017 at 11:04 AM, Cong Wang wrote:
>>>
>>> Can you confirm that? I don't know where the original report is.
>>
>> Yes of course, setting 'sock' to NULL before 'goto retry' is sufficient
>> to fix it, that is in fact my initia
Hi Florian, Andrew,
On Sun, Jul 9, 2017 at 7:28 PM, Andrew Lunn wrote:
>> It sure does fix a real issue, but I am really concerned about the
>> inability to test this patch in a configuration where we have multiple
>> PHY(s) or MDIO device(s) hanging off the same MDIO bus and one of those
>> requ
Adding a dummy for set_dma_ops() allows to compile (sub)drivers that
don't actually use the DMA API, but propagate DMA ops configuration to a
second driver that may or may not use the DMA API. Of course the second
driver does have to depend on HAS_DMA if it uses the DMA API.
An example is commit
On (07/09/17 11:49), Linus Torvalds wrote:
>
> On Sat, Jul 8, 2017 at 3:36 AM, David Miller wrote:
> >
> > 8) Fix socket leak on accept() in RDS, from Sowmini Varadhan. Also
> >add a WARN_ON() to sock_graft() so other protocol stacks don't trip
> >over this as well.
>
> Hmm. This one tr
On Sat, Jul 8, 2017 at 3:36 AM, David Miller wrote:
>
> 8) Fix socket leak on accept() in RDS, from Sowmini Varadhan. Also
>add a WARN_ON() to sock_graft() so other protocol stacks don't trip
>over this as well.
Hmm. This one triggers for me on both my desktop and laptop at bootup.
Bog-s
> It sure does fix a real issue, but I am really concerned about the
> inability to test this patch in a configuration where we have multiple
> PHY(s) or MDIO device(s) hanging off the same MDIO bus and one of those
> requesting an EPROBE_DEFER.
>
> I currently don't have a setup where I could exe
On 07/02/2017 01:37 PM, Geert Uytterhoeven wrote:
> On Tue, Jun 6, 2017 at 11:43 AM, Geert Uytterhoeven
> wrote:
>> On Tue, May 23, 2017 at 11:36 AM, Geert Uytterhoeven
>> wrote:
>>> On Fri, May 19, 2017 at 12:21 AM, Florian Fainelli
>>> wrote:
On 05/18/2017 01:36 PM, Geert Uytterhoeven
From: Saeed Mahameed
Date: Sun, 9 Jul 2017 15:49:10 +0300
> This series includes fixes to mlx5 driver:
> - Compilation warnings and issues introduced on v4.12
> - Add Makefile to each mlx5 subdir to allow individual file compilation
> - Initialize CEE's getpermhwaddr address buffer to 0xff
On 07/07/2017 12:36 AM, Florian Fainelli wrote:
> On 07/06/2017 04:00 AM, Arkadi Sharshevsky wrote:
>>
>>
>> On 07/05/2017 10:45 PM, Florian Fainelli wrote:
>>> On 07/05/2017 08:36 AM, Arkadi Sharshevsky wrote:
The bridge port attributes/vlan for DSA devices should be set only
from brid
On 7/7/2017 8:35 PM, John Fastabend wrote:
This adds support for a bpf_redirect helper function to the XDP
infrastructure. For now this only supports redirecting to the egress
path of a port.
In order to support drivers handling a xdp_buff natively this patches
uses a new ndo operation ndo_xdp
On 07/06/2017 09:45 PM, Vivien Didelot wrote:
> Hi Arkadi,
>
> Florian Fainelli writes:
>
>> On 07/05/2017 08:36 AM, Arkadi Sharshevsky wrote:
>>> This workqueue will be used for FDB add/del processing. It should
>>> be destroyed after all devices unregistered successfully.
>>>
>>> Signed-off-
From: Ilan Tayari
Fix warning when building with -Wall:
drivers/net/ethernet/mellanox/mlx5/core/fpga/core.c:105:5: warning: symbol
'mlx5_fpga_device_brb' was not declared. Should it be static?
Fixes: c43051d72a8d ("net/mlx5: FPGA, Add SBU bypass and reset flows")
Reported-by: Or Gerlitz
Signed
From: Ilan Tayari
Both the ethernet and FPGA portions of MLX5 now require the wq functions,
and we get a link error when CONFIG_MLX5_CORE_EN is disabled:
drivers/net/ethernet/mellanox/mlx5/core/fpga/conn.o: In function
`mlx5_fpga_conn_create_cq':
conn.c:(.text+0x10b3): undefined reference to `m
From: Ilan Tayari
Fix warnings when building with -Wall:
drivers/net/ethernet/mellanox/mlx5/core/lib/gid.c:38:6: warning: symbol
'mlx5_init_reserved_gids' was not declared. Should it be static?
drivers/net/ethernet/mellanox/mlx5/core/lib/gid.c:47:6: warning: symbol
'mlx5_cleanup_reserved_gids'
From: Huy Nguyen
Latest change in open-lldp code uses bytes 6-11 of perm_addr buffer
as the Ethernet source address for the host TLV packet.
Since our driver does not fill these bytes, they stay at zero and
the open-lldp code ends up sending the TLV packet with zero source
address and the switch
From: Ilan Tayari
Fix warnings when building with -Wall:
drivers/net/ethernet/mellanox/mlx5/core/fpga/ipsec.c:313:36: warning: cast to
restricted __be32
drivers/net/ethernet/mellanox/mlx5/core/fpga/ipsec.c:314:37: warning: cast to
restricted __be32
Fixes: bebb23e6cb02 ("net/mlx5: Accel, Add IP
From: Ilan Tayari
Fix warnings when building 386 kernel:
>> ERROR: "__udivdi3" [drivers/net/ethernet/mellanox/mlx5/core/mlx5_core.ko]
>> undefined!
Fixes: 2ac9cfe78223 ("net/mlx5e: IPSec, Add Innova IPSec offload TX data path")
Reported-by: kbuild test robot
Signed-off-by: Ilan Tayari
Signed-
Hi Dave,
This series includes fixes to mlx5 driver:
- Compilation warnings and issues introduced on v4.12
- Add Makefile to each mlx5 subdir to allow individual file compilation
- Initialize CEE's getpermhwaddr address buffer to 0xff
Please pull and let me know if there's any problem.
For
From: Ilan Tayari
Currently it is not possible to build just one .o file inside
a subdirectory, because the subdirectories lack a Makefile.
Add a Makefile to the mlx5 subdirectories.
Fixes: e29341fb3a5b ("net/mlx5: FPGA, Add basic support for Innova")
Signed-off-by: Ilan Tayari
Reported-by: Da
A recent change fixing NFC device allocation itself introduced an
error-handling bug by returning an error pointer in case device-id
allocation failed. This is clearly broken as the callers still expected
NULL to be returned on errors as detected by Dan's static checker.
Fix this up by returning N
The option "h" (host order ) exists for ipv4 only.
Remove the h when printing ipv6 addresses.
Lead to the following smatch warning:
drivers/net/ethernet/qlogic/qed/qed_iwarp.c:585 qed_iwarp_print_tcp_ramrod()
warn: '%pI6' can only be followed by c
drivers/net/ethernet/qlogic/qed/qed_iwarp.c:1521
36 matches
Mail list logo
