[RFC] switchdev: clarify ndo_get_phys_port_name() formats

We are still in position where we can suggest uniform naming convention for ndo_get_phys_port_name(). switchdev.txt file already contained a suggestion of how to name external ports. Since the use of switchdev for SR-IOV NIC's eswitches is growing, establish a format for ports of those devices as

Re: [PATCH net-next 10/10] bnxt_en: add support for port_attr_get and and get_phys_port_name

On Mon, 24 Jul 2017 12:34:29 -0400, Michael Chan wrote: > From: Sathya Perla > > This patch adds support for the switchdev_port_attr_get() and > ndo_get_phys_port_name() methods for the PF and the VF-reps. > Using this support a user application can deduce that the PF

Re: [PATCH 1/2] net: ethernet: ti: cpts: convert to use kthread_worker

On Mon, Jul 24, 2017 at 07:34:38PM -0500, Grygorii Strashko wrote: > Below if pure TBD/RFC version of patch which add kthread worker to PTP core. > I'm sending it to get you opinion about implementation in general, before > continue with more changes. Pls, take a look if you have time? > - are

Re: [PATCH net-next 10/10] bnxt_en: add support for port_attr_get and and get_phys_port_name

From: Jakub Kicinski Date: Mon, 24 Jul 2017 21:06:17 -0700 > On Tue, 25 Jul 2017 10:44:49 +0800, kbuild test robot wrote: >>drivers/net/ethernet/broadcom/bnxt/bnxt.c: In function 'bnxt_init_one': >> >> drivers/net/ethernet/broadcom/bnxt/bnxt.c:7897:5: error: 'struct >> >>

Re: A buggy behavior for Linux TCP Reno and HTCP

On Mon, 24 Jul 2017 16:41:12 -0700 Yuchung Cheng wrote: > On Mon, Jul 24, 2017 at 11:29 AM, Neal Cardwell wrote: > > On Mon, Jul 24, 2017 at 2:17 PM, Yuchung Cheng wrote: > >> On Sun, Jul 23, 2017 at 7:37 PM, Neal Cardwell

[PATCH net 1/1] Revert "netvsc: optimize calculation of number of slots"

The logic for computing page buffer scatter does not take into account the impact of compound pages. Therefore the optimization to compute number of slots was incorrect and could cause stack corruption a skb was sent with lots of fragments from huge pages. This reverts commit

[PATCH net 0/1] fix bug in netvsc driver

Internal testing found a problem under some load tests and the problem was bisected down to one commit. This needs to go to current (4.13) and stable (4.12). Stephen Hemminger (1): Revert "netvsc: optimize calculation of number of slots" drivers/net/hyperv/netvsc_drv.c | 43

Re: [PATCH net-next 10/10] bnxt_en: add support for port_attr_get and and get_phys_port_name

On Tue, 25 Jul 2017 10:44:49 +0800, kbuild test robot wrote: >drivers/net/ethernet/broadcom/bnxt/bnxt.c: In function 'bnxt_init_one': > >> drivers/net/ethernet/broadcom/bnxt/bnxt.c:7897:5: error: 'struct > >> net_device' has no member named 'switchdev_ops'; did you mean > >> 'netdev_ops'?

Re: [PATCH] tun/tap: Add the missed return value check of register_netdevice_notifier

From: Tonghao Zhang Date: Tue, 25 Jul 2017 10:43:26 +0800 > One question, this type bugfix will be applied to net-next ? 'net' is periodically merged into 'net-next', so yes.

Re: [PATCH net] ipv6: no need to return rt->dst.error if it is not null entry.

On 7/24/17 6:08 PM, Hangbin Liu wrote: > That's why I think we should remove both rt->dst.error and ip6_null_entry > check in inet6_rtm_getroute(). And even further, remove the ip6_null_entry > check in rt6_dump_route(). git blame net/ipv6/route.c find the commits and review.

Re: [PATCH net-next 10/10] bnxt_en: add support for port_attr_get and and get_phys_port_name

Hi Sathya, [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Michael-Chan/bnxt_en-Update-firmware-interface-spec-to-1-8-0/20170725-094835 config: x86_64-randconfig-x016-201730 (attached as .config) compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901

Re: [PATCH] tun/tap: Add the missed return value check of register_netdevice_notifier

One question, this type bugfix will be applied to net-next ? > On Jul 25, 2017, at 4:45 AM, David Miller wrote: > >> >> There is some codes of tun/tap module which did not check the return >> value of register_netdevice_notifier. Add the check now. >> >> Signed-off-by:

Re: [PATCH net-next 08/10] bnxt_en: add support to enable VF-representors

Hi Sathya, [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Michael-Chan/bnxt_en-Update-firmware-interface-spec-to-1-8-0/20170725-094835 config: x86_64-randconfig-x016-201730 (attached as .config) compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901

Re: Bonding driver fails to enable second interface if updelay is non-zero

On Mon, Jul 24, 2017 at 2:34 PM, Mahesh Bandewar (महेश बंडेवार) wrote: > Having said that, the proposed solution (Cong's patch) should fix it, please > give it a try so that this fix can be formalized. The patch fixes the problem for me. Thanks! --Benjamin Gilbert

Re: SELinux/IP_PASSSEC regression in 4.13-rcX

On Mon, Jul 24, 2017 at 3:00 PM, Paul Moore wrote: > On Mon, Jul 24, 2017 at 12:09 PM, Paolo Abeni wrote: >> Hi, >> >> On Mon, 2017-07-24 at 10:42 -0400, Paul Moore wrote: >>> The change in behavior for userspace makes me a little nervous as >>> there is

Re: [PATCH 00/22] gcc-7 -Wformat-* warnings

Arnd, > This series addresses all warnings that gcc-7 introduces for > -Wformat-overflow= and turns off the -Wformat-truncation by default > (they remain enabled with "make W=1"). Applied the SCSI patches. Thanks! -- Martin K. Petersen Oracle Linux Engineering

Dear Talented

Dear Talented, I am Talent Scout For Sony Pictures Animation, Present Sony Pictures Animation Movies a Film Corporation Located in the United State, is Soliciting for the Right to use Your Photo/Face and Personality as One of the Semi -Major Role/ Character in our Upcoming ANIMATED Stereoscope

[PATCH net-next] i40e: limit lan queue count in large cpu count machine

When a machine has more cpus than queuepairs, e.g. 512 cores, the counting gets a little funky and turns off Flow Director with the message: not enough queues for Flow Director. Flow Director feature is disabled This patch limits the number of lan queues initially allocated to be sure we have

[PATCH] ftgmac100: return error in ftgmac100_alloc_rx_buf

The error paths set err, but it's not returned. I wondered if we should fix all of the callers to check the returned value, but Ben explains why the code is this way: > Most call sites ignore it on purpose. There's nothing we can do if > we fail to get a buffer at interrupt time, so we point the

Re: [PATCH net-next] ibmvnic: Check for transport event on driver resume

From: John Allen Date: Mon, 24 Jul 2017 13:26:06 -0500 > On resume, the ibmvnic driver will fail to resume normal operation. > The main crq gets closed on suspend by the vnic server and doesn't get > reopened again as the interrupt for the transport event that would

Re: [PATCH net-next 0/6] netvsc: minor fixes

From: Stephen Hemminger Date: Mon, 24 Jul 2017 10:57:24 -0700 > This fixes fallout from previous patch related to RTNL and RCU > annotaiton. Also one patch sent to wrong list. Series applied, thanks.

Re: [PATCH net] net: dsa: Initialize ds->cpu_port_mask earlier

From: Florian Fainelli Date: Mon, 24 Jul 2017 10:49:23 -0700 > The mt7530 driver has its dsa_switch_ops::get_tag_protocol function > check ds->cpu_port_mask to issue a warning in case the configured CPU > port is not capable of supporting tags. > > After commit

Re: [patch net-next] mlxsw: spectrum_router: Fix build when IPv6 isn't enabled

On 7/24/17 1:56 AM, Jiri Pirko wrote: > @@ -949,9 +950,13 @@ mlxsw_sp_router_neighs_update_interval_init(struct > mlxsw_sp *mlxsw_sp) > { > unsigned long interval; > > +#if IS_ENABLED(CONFIG_IPV6) > interval = min_t(unsigned long, >NEIGH_VAR(_tbl.parms,

Re: [PATCH 1/2] net: ethernet: ti: cpts: convert to use kthread_worker

Hi Richard, On 07/22/2017 12:29 AM, Richard Cochran wrote: > On Fri, Jul 21, 2017 at 06:49:42PM -0500, Grygorii Strashko wrote: >> There could be significant delay in CPTS work schedule under high system >> load and on -RT which could cause CPTS misbehavior due to internal counter >> overflow.

Re: [Patch net] packet: fix use-after-free in prb_retire_rx_blk_timer_expired()

From: Cong Wang Date: Mon, 24 Jul 2017 10:07:32 -0700 > There are multiple reports showing we have a use-after-free in > the timer prb_retire_rx_blk_timer_expired(), where we use struct > tpacket_kbdq_core::pkbdq, a pg_vec, after it gets freed by > free_pg_vec(). > >

Re: [PATCH net-next 00/10] bnxt_en: Updates for net-next.

From: Michael Chan Date: Mon, 24 Jul 2017 12:34:19 -0400 > This series includes updating the firmware interface, adding > methods to get and set VEPA/VEB bridge modes, some minor DCBX and ETS > refinements, and 3 patches from Sathya Perla to implement initial > VF

Re: Problem with PHY state machine when using interrupts

On 07/24/2017 03:59 PM, Florian Fainelli wrote: > On 07/24/2017 03:53 PM, Mason wrote: >> On 25/07/2017 00:36, Florian Fainelli wrote: >>> On 07/24/2017 02:20 PM, Mason wrote: On 24/07/2017 21:53, Florian Fainelli wrote: > Well now that I see the possible interrupts generated, I

Re: [PATCH] tcp: remove redundant argument from tcp_rcv_established()

From: Ilya Matveychikov Date: Mon, 24 Jul 2017 16:02:12 +0400 > The last (4th) argument of tcp_rcv_established() is redundant as it > always equals to skb->len and the skb itself is always passed as 2th > agrument. There is no reason to have it. > > Signed-off-by: Ilya

Re: [PATCH 1/1] mlx4_en: remove unnecessary error check

From: Zhu Yanjun Date: Mon, 24 Jul 2017 04:22:44 -0400 > The function mlx4_en_get_profile always return zero. So it is not > necessary to check its return value. > > CC: Joe Jin > CC: Junxiao Bi > Signed-off-by: Zhu Yanjun

Re: [PATCH 2/2] ftgmac100: Make the MDIO bus a child of the ethernet device

From: Benjamin Herrenschmidt Date: Mon, 24 Jul 2017 16:59:07 +1000 > Populate mii_bus->parent with our own platform device before > registering, which makes it easier to locate the MDIO bus > in sysfs when trying to diagnose problems. > > Signed-off-by: Benjamin

Re: [PATCH 1/2] ftgmac100: Increase reset timeout

From: Benjamin Herrenschmidt Date: Mon, 24 Jul 2017 16:59:01 +1000 > We had reports of 50us not being sufficient to reset the MAC, > thus hitting the "Hardware reset failed" error bringing the > interface up on some AST2400 based machines. > > This bumps the timeout to

[PATCH v2 net-next 2/2] liquidio: cleanup: removed cryptic and misleading macro

From: Rick Farrington Signed-off-by: Rick Farrington Signed-off-by: Felix Manlunas --- drivers/net/ethernet/cavium/liquidio/octeon_console.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff

[PATCH v2 net-next 1/2] liquidio: standardization: use min_t instead of custom macro

From: Rick Farrington Signed-off-by: Rick Farrington Signed-off-by: Derek Chickles Signed-off-by: Felix Manlunas --- drivers/net/ethernet/cavium/liquidio/octeon_console.c | 3

[PATCH v2 net-next 0/2] liquidio: standardization and cleanup

From: Rick Farrington This patchset corrects some non-standard macro usage. 1. Replaced custom MIN macro with use of standard 'min_t'. 2. Removed cryptic and misleading macro 'CAST_ULL'. change log: V1 -> V2: 1. Added driver cleanup of macro 'CAST_ULL'. Rick

Re: [patch net-next] mlxsw: spectrum_router: Fix build when IPv6 isn't enabled

From: Jiri Pirko Date: Mon, 24 Jul 2017 09:56:00 +0200 > From: Ido Schimmel > > When IPv6 isn't enabled the following error is generated: > > ERROR: "nd_tbl" [drivers/net/ethernet/mellanox/mlxsw/mlxsw_spectrum.ko] > undefined! > > Fix it by replacing

Re: [PATCH net] ipv6: no need to return rt->dst.error if it is not null entry.

On Mon, Jul 24, 2017 at 12:57:43PM -0700, Cong Wang wrote: > On Sun, Jul 23, 2017 at 8:09 PM, Hangbin Liu wrote: > > Do we still need this net->ipv6.ip6_null_entry check? How about remove all > > the checks? > > I believe you only need to check for rt->dst.error, no need to

Re: [PATCH net-next 00/18] net: mvpp2: MAC/GoP configuration and optional PHYs

Hi Antoine, I stressed 10G interfaces with bidirectional traffic on A8040-DB, did some up/down sequences and overall it seems stable (of course I needed fix mentioned in patch 10/18). In a spare moment I'll give other changes a scroll. Best regards, Marcin 2017-07-24 15:48 GMT+02:00 Antoine

Re: A buggy behavior for Linux TCP Reno and HTCP

On Mon, Jul 24, 2017 at 11:29 AM, Neal Cardwell wrote: > On Mon, Jul 24, 2017 at 2:17 PM, Yuchung Cheng wrote: >> On Sun, Jul 23, 2017 at 7:37 PM, Neal Cardwell wrote: >>> On Sun, Jul 23, 2017 at 10:36 PM, Neal Cardwell

Re: [PATCH] netvsc: fix ptr_ret.cocci warnings

From: Stephen Hemminger Date: Mon, 24 Jul 2017 16:21:57 -0700 > On Mon, 24 Jul 2017 16:20:28 -0700 (PDT) > David Miller wrote: > >> From: kbuild test robot >> Date: Sat, 22 Jul 2017 02:54:43 +0800 >> >> >

Re: [PATCH 1/1] mlx4_en: remove unnecessary returned value

From: Zhu Yanjun Date: Sun, 23 Jul 2017 23:02:53 -0400 > The function mlx4_en_arm_cq always returns zero. So change the > return type of the function mlx4_en_arm_cq to void. > > CC: Joe Jin > CC: Junxiao Bi > Signed-off-by: Zhu

Re: [PATCH] of_mdio: kill useless variable in of_phy_register_fixed_link()

From: Sergei Shtylyov Date: Sun, 23 Jul 2017 21:45:47 +0300 > of_phy_register_fixed_link() declares the 'err' variable to hold the result > of of_property_read_string() but only uses it once after that, while that > function can be called directly from the

Re: [PATCH net-next] skbuff: re-add check for NULL skb->head in kfree_skb path

From: Florian Westphal Date: Sun, 23 Jul 2017 19:54:47 +0200 > A null check is needed after all. netlink skbs can have skb->head be > backed by vmalloc. The netlink destructor vfree()s head, then sets it to > NULL. We then panic in skb_release_data with a NULL dereference. >

Re: [PATCH-next] liquidio: fix implicit irq include causing build failures

From: Paul Gortmaker Date: Sun, 23 Jul 2017 10:44:52 -0400 > To fix > > In file included from > drivers/net/ethernet/cavium/liquidio/octeon_mem_ops.c:24:0: > drivers/net/ethernet/cavium/liquidio/octeon_device.h:216:2: error: expected > specifier-qualifier-list

Re: [PATCH net] openvswitch: fix potential out of bound access in parse_ct

From: Liping Zhang Date: Sun, 23 Jul 2017 17:52:23 +0800 > From: Liping Zhang > > Before the 'type' is validated, we shouldn't use it to fetch the > ovs_ct_attr_lens's minlen and maxlen, else, out of bound access > may happen. > > Fixes: 7f8a436eaa2c

Re: [PATCH] netvsc: fix ptr_ret.cocci warnings

On Mon, 24 Jul 2017 16:20:28 -0700 (PDT) David Miller wrote: > From: kbuild test robot > Date: Sat, 22 Jul 2017 02:54:43 +0800 > > > drivers/net/hyperv/netvsc_drv.c:737:8-14: WARNING: PTR_ERR_OR_ZERO can be > > used > > > > > > Use

Re: [PATCH] net: stmmac: Adjust dump offset of DMA registers for ethtool

From: thor.tha...@linux.intel.com Date: Fri, 21 Jul 2017 16:35:09 -0500 > From: Thor Thayer > > The commit fbf68229ffe7 ("net: stmmac: unify registers dumps methods") > > in the Linux kernel modified the register dump to store the DMA registers > at the DMA

Re: [PATCH] netvsc: fix ptr_ret.cocci warnings

From: kbuild test robot Date: Sat, 22 Jul 2017 02:54:43 +0800 > drivers/net/hyperv/netvsc_drv.c:737:8-14: WARNING: PTR_ERR_OR_ZERO can be used > > > Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR > > Generated by: scripts/coccinelle/api/ptr_ret.cocci > >

Re: [PATCH net-next 0/2] rxrpc: Rearrange headers

From: David Howells Date: Fri, 21 Jul 2017 19:29:42 +0100 > > Here's a pair of patches that rearrange some of the AF_RXRPC header files > that are outside of the net/rxrpc/ directory: > > (1) The bits userspace need are moved to uapi/linux/rxrpc.h. [Should this > be

Re: [patch net-next] mlxsw: spectrum_router: Don't batch neighbour deletion

From: Jiri Pirko Date: Fri, 21 Jul 2017 20:31:38 +0200 > From: Ido Schimmel > > Current firmware supported by the driver doesn't support batch deletion > of IPv6 neighbours on a given router interface (RIF). > > Until a new version that supports this

Re: [PATCH V2 net] net: fix tcp reset packet flowlabel for ipv6

On Mon, Jul 24, 2017 at 1:34 PM, David Miller wrote: > From: Shaohua Li > Date: Tue, 18 Jul 2017 12:03:37 -0700 > >> + /* Since this is being sent on the wire obfuscate hash a bit >> + * to minimize possbility that any useful information to an >> +

[PATCH v2 4/4] can: m_can: Add call to of_can_transceiver_fixed

Add call to new generic functions that provides support via a binding to limit the arbitration rate and/or data rate imposed by the physical transceiver connected to the MCAN peripheral. Signed-off-by: Franklin S Cooper Jr --- drivers/net/can/m_can/m_can.c | 2 ++ 1 file

[PATCH v2 3/4] can: m_can: Update documentation to mention new fixed transceiver binding

Add information regarding fixed transceiver binding. This is especially important for MCAN since the IP allows CAN FD mode to run significantly faster than what most transceivers are capable of. Signed-off-by: Franklin S Cooper Jr --- Version 2 changes: Drop unit address

[PATCH v2 0/4] can: Add new binding to limit bit rate used

Add a new generic binding that CAN drivers can use to specify the max arbitration and data bit rate supported by a transceiver. This is useful since in some instances the maximum speeds may be limited by the transceiver used. However, transceivers may not provide a means to determine this

[PATCH v2 1/4] can: dev: Add support for limiting configured bitrate

Various CAN or CAN-FD IP may be able to run at a faster rate than what the transceiver the CAN node is connected to. This can lead to unexpected errors. However, CAN transceivers typically have fixed limitations and provide no means to discover these limitations at runtime. Therefore, add support

[PATCH v2 2/4] can: fixed-transceiver: Add documentation for CAN fixed transceiver bindings

Add documentation to describe usage of the new fixed transceiver binding. This new binding is applicable for any CAN device therefore it exists as its own document. Signed-off-by: Franklin S Cooper Jr --- Version 2: Tweak commit message working Tweak wording for properties Drop

Re: [PATCH V2 net-next 01/21] net-next/hinic: Initialize hw interface

Aviad Krawczyk : [...] > hinic_remove - If insmod failed and someone calls rmmod, we will get a > crash because the resource are already free. Therefore we test if the > device exists, please tell me if you meant to something different The module won't even proceed

Re: [PATCH net-next 00/11] sctp: remove typedefs from structures part 3

From: Xin Long Date: Sun, 23 Jul 2017 09:34:25 +0800 > As we know, typedef is suggested not to use in kernel, even checkpatch.pl > also gives warnings about it. Now sctp is using it for many structures. > > All this kind of typedef's using should be removed. This patchset

Re: Problem with PHY state machine when using interrupts

On 07/24/2017 03:53 PM, Mason wrote: > On 25/07/2017 00:36, Florian Fainelli wrote: >> On 07/24/2017 02:20 PM, Mason wrote: >>> On 24/07/2017 21:53, Florian Fainelli wrote: >>> Well now that I see the possible interrupts generated, I indeed don't see how you can get a link down

Re: Problem with PHY state machine when using interrupts

On 25/07/2017 00:36, Florian Fainelli wrote: > On 07/24/2017 02:20 PM, Mason wrote: >> On 24/07/2017 21:53, Florian Fainelli wrote: >> >>> Well now that I see the possible interrupts generated, I indeed don't >>> see how you can get a link down notification unless you somehow force >>> the link

[PATCH v2 1/3] can: m_can: Make hclk optional

Hclk is the MCAN's interface clock. However, for OMAP based devices such as DRA7 SoC family the interface clock is handled by hwmod. Therefore, this interface clock is managed by hwmod driver via pm_runtime_get and pm_runtime_put calls. Therefore, this interface clock isn't defined in DT and thus

[PATCH v2 0/3] can: m_can: Add PM Runtime Support

Add PM runtime support to the MCAN driver. To support devices that don't use PM runtime leave the original clk calls in the driver. Perhaps in the future when it makes sense we can remove these non pm runtime clk calls. Version 2 changes: Used NULL instead of 0 for unused hclk handle Franklin S

[PATCH v2 3/3] can: m_can: Add PM Runtime

Add support for PM Runtime which is the new way to handle managing clocks. However, to avoid breaking SoCs not using PM_RUNTIME leave the old clk management approach in place. PM_RUNTIME is required by OMAP based devices to handle clock management. Therefore, this allows future Texas Instruments

[PATCH v2 2/3] can: m_can: Update documentation to indicate that hclk may be optional

Update the documentation to reflect that hclk is now an optional clock. Signed-off-by: Franklin S Cooper Jr Acked-by: Rob Herring --- Documentation/devicetree/bindings/net/can/m_can.txt | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

Re: Problem with PHY state machine when using interrupts

On 07/24/2017 03:36 PM, Florian Fainelli wrote: > On 07/24/2017 02:20 PM, Mason wrote: >> On 24/07/2017 21:53, Florian Fainelli wrote: >> >>> Well now that I see the possible interrupts generated, I indeed don't >>> see how you can get a link down notification unless you somehow force >>> the link

Re: Problem with PHY state machine when using interrupts

On 07/24/2017 02:20 PM, Mason wrote: > On 24/07/2017 21:53, Florian Fainelli wrote: > >> Well now that I see the possible interrupts generated, I indeed don't >> see how you can get a link down notification unless you somehow force >> the link down yourself, which would certainly happen in

Re: [PATCH 2/2] net: ethernet: nb8800: Fix RGMII TX clock delay setup

On 24/07/2017 23:49, Florian Fainelli wrote: > On 07/24/2017 02:21 PM, Mason wrote: >> On 20/07/2017 14:33, Mason wrote: >> >>> As [Florian] pointed out, the spec states that the >>> "Data to Clock input Skew (at Receiver)" >>> must be within [ 1.0, 2.6 ] ns. >>> >>> I understand that 2 ns is 1/4

Re: [PATCH iproute2 net-next] bridge: this patch adds json support for bridge mdb show

Hello Stephen, Thanks you. I will send an incremental patch with updated usage message and man page. -Nikhil > On Jul 18, 2017, at 5:33 PM, Stephen Hemminger > wrote: > > On Fri, 7 Jul 2017 15:24:16 -0700 > Roopa Prabhu wrote: > >>

[PATCH] mwifiex: usb: fix spelling mistake: "aggreataon"-> "aggregation"

From: Colin Ian King Trivial fix to spelling mistake in aggr_ctrl module parameter message text. Signed-off-by: Colin Ian King --- drivers/net/wireless/marvell/mwifiex/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: commit 16ecba59 breaks 82574L under heavy load.

> On Jul 20, 2017, at 5:44 PM, Benjamin Poirier wrote: > > [snip] > Could you please test the following patch and let me know if it: > 1) reduces the interrupt rate of the Other msi-x vector > 2) avoids the link flaps > or > 3) logs some dmesg warnings of the form "Other

Re: [PATCH 2/2] net: ethernet: nb8800: Fix RGMII TX clock delay setup

On 07/24/2017 02:21 PM, Mason wrote: > On 20/07/2017 14:33, Mason wrote: > >> As [Florian] pointed out, the spec states that the >> "Data to Clock input Skew (at Receiver)" >> must be within [ 1.0, 2.6 ] ns. >> >> I understand that 2 ns is 1/4 of a 125 MHz period, >> but it's not clear to me why

Re: [PATCH net-next V2 0/5] Refine virtio-net XDP

On Mon, Jul 24, 2017 at 01:38:59PM -0700, David Miller wrote: > From: Jason Wang > Date: Wed, 19 Jul 2017 16:54:44 +0800 > > > Hi: > > > > This series brings two optimizations for virtio-net XDP: > > > > - avoid reset during XDP set > > - turn off offloads on demand > > >

Re: [PATCH net-next V2 5/5] virtio-net: switch off offloads on demand if possible on XDP set

On Wed, Jul 19, 2017 at 04:54:49PM +0800, Jason Wang wrote: > Current XDP implementation wants guest offloads feature to be disabled > on device. This is inconvenient and means guest can't benefit from > offloads if XDP is not used. This patch tries to address this > limitation by disabling the

Re: [PATCH net-next 5/5] virtio-net: switch off offloads on demand if possible on XDP set

On Wed, Jul 19, 2017 at 10:39:53AM +0800, Jason Wang wrote: > > > On 2017年07月19日 04:07, Michael S. Tsirkin wrote: > > On Mon, Jul 17, 2017 at 08:44:01PM +0800, Jason Wang wrote: > > > Current XDP implementation want guest offloads feature to be disabled > > s/want/wants/ > > > > > on qemu cli.

Re: [PATCH net-next V2 5/5] virtio-net: switch off offloads on demand if possible on XDP set

On Wed, Jul 19, 2017 at 04:54:49PM +0800, Jason Wang wrote: > Current XDP implementation wants guest offloads feature to be disabled > on device. This is inconvenient and means guest can't benefit from > offloads if XDP is not used. This patch tries to address this > limitation by disabling the

[PATCH net-next] bpf: add helper capable of reading out instructions

To read translated and jited instructions from the kernel, one has to set certain pointers of struct bpf_prog_info to pre-allocated user buffers. Unfortunately, the existing bpf_obj_get_info_by_fd() helper zeros struct bpf_prog_info before passing it to the kernel. Keeping the zeroing seems like

[PATCH net-next] bpf: install libbpf headers on 'make install'

Install the bpf.h header to $(prefix)/include/bpf/ directory. This is necessary to build standalone applications using libbpf, without the need to clone the kernel sources and point to them. Signed-off-by: Jakub Kicinski --- I'm not 100% sure if it's OK to export

Re: [PATCH 2/2] net: ethernet: nb8800: Fix RGMII TX clock delay setup

On 20/07/2017 14:33, Mason wrote: > As [Florian] pointed out, the spec states that the > "Data to Clock input Skew (at Receiver)" > must be within [ 1.0, 2.6 ] ns. > > I understand that 2 ns is 1/4 of a 125 MHz period, > but it's not clear to me why the above interval is > centered at 1.8

Re: Problem with PHY state machine when using interrupts

On 24/07/2017 21:53, Florian Fainelli wrote: > Well now that I see the possible interrupts generated, I indeed don't > see how you can get a link down notification unless you somehow force > the link down yourself, which would certainly happen in phy_suspend() > when we set BMCR.pwrdwn, but that

Re: [PATCH net] net/socket: fix type in assignment and trim long line

From: Paolo Abeni Date: Fri, 21 Jul 2017 18:49:45 +0200 > The commit ffb07550c76f ("copy_msghdr_from_user(): get rid of > field-by-field copyin") introduce a new sparse warning: > > net/socket.c:1919:27: warning: incorrect type in assignment (different > address spaces) >

Re: pull-request: wireless-drivers 2017-07-21

From: Kalle Valo Date: Fri, 21 Jul 2017 19:12:54 +0300 > important fixes for net which had accumulated while I was away. I only > applied the brcmfmac and rtlwifi patches only eight hours ago and I > haven't seen the kbuild report yet so they might have some build >

Re: [patch net] mlxsw: spectrum_router: Don't offload routes next in list

From: Jiri Pirko Date: Fri, 21 Jul 2017 18:04:28 +0200 > From: Ido Schimmel > > Each FIB node holds a linked list of routes sharing the same prefix and > length. In the case of IPv4 it's ordered according to table ID, metric > and TOS and only the first

[PATCH net] ipv6: Don't increase IPSTATS_MIB_FRAGFAILS twice in ip6_fragment()

RFC 2465 defines ipv6IfStatsOutFragFails as: "The number of IPv6 datagrams that have been discarded because they needed to be fragmented at this output interface but could not be." The existing implementation, instead, would increase the counter twice in case we fail to

Re: [PATCH] lib: test_rhashtable: fix for large entry counts

From: Phil Sutter Date: Fri, 21 Jul 2017 16:51:31 +0200 > During concurrent access testing, threadfunc() concatenated thread ID > and object index to create a unique key like so: > > | tdata->objs[i].value = (tdata->id << 16) | i; > > This breaks if a user passes an entries

Re: [RFC PATCH] IP: do not modify ingress packet IP option in ip_options_echo()

From: Paolo Abeni Date: Fri, 21 Jul 2017 15:55:18 +0200 > diff --git a/net/ipv4/ip_options.c b/net/ipv4/ip_options.c > index 93157f2..fdda973 100644 > --- a/net/ipv4/ip_options.c > +++ b/net/ipv4/ip_options.c > @@ -174,9 +174,6 @@ int __ip_options_echo(struct ip_options *dopt,

Re: Kernel TLS in 4.13-rc1

On 07/23/17 09:39 PM, David Oberhollenzer wrote: > After fixing the benchmark/test tool that the patch description > linked to (https://github.com/Mellanox/tls-af_ktls_tool) to make > sure that the server and client actually *agree* on AES-128-GCM, > I simply ran the client program with the

Re: [BUG] /net/hsr: prune_timer

On Tue, Jul 18, 2017 at 1:07 AM, Dmitry wrote: > Hello! > > > void hsr_prune_nodes(unsigned long data) called once by timer. > > hsr_prune_nodes must be called periodically every PRUNE_PERIOD (60s). > > > > > This code want be added to tail of hsr_prune_nodes function > >

Re: [PATCH net 0/2] bpf: fix verifier min/max handling in BPF_SUB

From: Edward Cree Date: Fri, 21 Jul 2017 14:35:17 +0100 > I managed to come up with a test for the swapped bounds in BPF_SUB, so here > it is along with a patch that fixes it, separated out from my 'rewrite > everything' series so it can go to -stable. Series applied and

Re: [PATCH] PCI: Update ACS quirk for more Intel 10G NICs

On Mon, 24 Jul 2017 12:31:39 -0700 Roland Dreier wrote: > > Is there a misunderstanding of the code flow here? We're never setting > > EC. In the first code block we're just masking out requested > > capabilities where unimplemented capabilities is the same as > >

Re: Bonding driver fails to enable second interface if updelay is non-zero

On Thu, Jul 20, 2017 at 7:07 PM, Benjamin Gilbert wrote: > [resend] > > Hello, > > Starting with commit de77ecd4ef02ca783f7762e04e92b3d0964be66b, and > through 4.12.2, the bonding driver in 802.3ad mode fails to enable the > second interface on a bond device if

Re: [PATCH net-next v2 0/6] Allow to switch off UDP-based tunnel offloads per netdevice

From: Sabrina Dubroca Date: Fri, 21 Jul 2017 12:49:27 +0200 > This patchset adds a new netdevice feature to toggle RX offloads of > UDP-based tunnel via ethtool. This is useful if the offload is causing > issues, for example if the hardware is buggy. > > The feature is

Re: [PATCH net-next v3 1/1] geneve: add rtnl changelink support

From: Girish Moodalbail Date: Thu, 20 Jul 2017 22:44:20 -0700 > This patch adds changelink rtnl operation support for geneve devices > and the code changes involve: > > - added geneve_quiesce() which quiesces the geneve device data path > for both TX and RX.

Re: [PATCH] net: ethernet: mediatek: Explicitly include linux/interrupt.h

From: Mark Brown Date: Thu, 20 Jul 2017 11:06:31 +0100 > The mediatek ethernet driver uses interrupts but does not explicitly > include linux/interrupt.h, relying on implicit includes. Fix this so we > don't get build breaks as happened for ARM in next-20170720. > >

Re: [PATCH] tun/tap: Add the missed return value check of register_netdevice_notifier

From: Tonghao Zhang Date: Thu, 20 Jul 2017 02:41:34 -0700 > There is some codes of tun/tap module which did not check the return > value of register_netdevice_notifier. Add the check now. > > Signed-off-by: Tonghao Zhang Applied.

Re: [PATCH v2 net] net: ethernet: mediatek: avoid potential invalid memory access

From: Date: Sat, 22 Jul 2017 20:45:55 +0800 > From: Sean Wang > > Potential dangerous invalid memory might be accessed if invalid mac value > reflected from the forward port field in rxd4 caused by possible potential > hardware defects. So added

Re: [PATCH] net: Convert to using %pOF instead of full_name

From: Rob Herring Date: Wed, 19 Jul 2017 10:09:13 -0500 > On Tue, Jul 18, 2017 at 4:51 PM, David Miller wrote: >> From: Rob Herring >> Date: Tue, 18 Jul 2017 16:43:19 -0500 >> >>> Now that we have a custom printf format specifier, convert

Re: [PATCH net-next V2 0/5] Refine virtio-net XDP

From: Jason Wang Date: Wed, 19 Jul 2017 16:54:44 +0800 > Hi: > > This series brings two optimizations for virtio-net XDP: > > - avoid reset during XDP set > - turn off offloads on demand > > Changes from V1: > - Various tweaks on commit logs and comments > - Use

Re: [PATCH V2 net] net: fix tcp reset packet flowlabel for ipv6

From: Shaohua Li Date: Tue, 18 Jul 2017 12:03:37 -0700 > + /* Since this is being sent on the wire obfuscate hash a bit > + * to minimize possbility that any useful information to an > + * attacker is leaked. Only lower 20 bits are relevant. > + */ > +

Re: [PATCH V4 net-next 7/8] net: hns3: Add Ethtool support to HNS3 driver

> On Jul 23, 2017, at 10:05 AM, Florian Fainelli wrote: >> + >> +strncpy(drvinfo->version, HNAE_DRIVER_VERSION, >> +sizeof(drvinfo->version)); >> +drvinfo->version[sizeof(drvinfo->version) - 1] = '\0'; > > strlcpy() would probably do that for you. You

Re: [PATCH 00/13] net: dsa: lan9303: unicast offload, fdb,mdb,STP

From: Egil Hjelmeland Date: Mon, 24 Jul 2017 16:47:51 +0200 > This is my first patches submitted to the kernel, so I am looking > forward to comments. Please clean up how the dates are handled in your submission. They are all over the place, over a period of 3

Re: [PATCH net] ipv6: no need to return rt->dst.error if it is not null entry.

On Sun, Jul 23, 2017 at 8:09 PM, Hangbin Liu wrote: > Do we still need this net->ipv6.ip6_null_entry check? How about remove all > the checks? I believe you only need to check for rt->dst.error, no need to check against NULL or ip6_null_entry. Take a look at other

  1   2   3   >