Re: [PATCH 0/3] net-next: stmmac: support future possible different internal phy mode

2017-07-28 Thread Corentin Labbe
On Fri, Jul 28, 2017 at 10:54:30AM -0700, Florian Fainelli wrote: > On 07/28/2017 07:44 AM, Corentin Labbe wrote: > > On Fri, Jul 28, 2017 at 04:36:00PM +0200, Andrew Lunn wrote: > I've probably asked this before: Does the internal PHY use a different > PHY ID in registers 2 and 3? >

Re: STABLE: net: reduce skb_warn_bad_offload() noise

2017-07-28 Thread Willy Tarreau
On Fri, Jul 28, 2017 at 10:22:52PM -0700, Eric Dumazet wrote: > On Fri, 2017-07-28 at 12:30 -0700, David Miller wrote: > > From: Mark Salyzyn > > Date: Fri, 28 Jul 2017 10:29:57 -0700 > > > > > Please backport the upstream patch to the stable trees (including > > > 3.10.y, 3.18.y, 4.4.y and 4.9.y

[PATCH 1/2] ipv4: constify net_protocol structures

2017-07-28 Thread Julia Lawall
The net_protocol structures are only passed as the first argument to inet_add_protocol, which is declared as const. Thus the net_protocol structures themselves can be const. Done with the help of Coccinelle. // @r disable optional_qualifier@ identifier i; position p; @@ static struct net_protoc

[PATCH 0/2] constify net_protocol structures

2017-07-28 Thread Julia Lawall
The net_protocol structure is only passed as the first argument to inet_add_protocol or inet_del_protocol, both of which are declared as const. Thus the net_protocol structure itself can be const. Done with the help of Coccinelle. --- net/ipv4/af_inet.c |4 ++-- net/l2tp/l2tp_ip.c |2 +

[PATCH 2/2] l2tp: constify net_protocol structures

2017-07-28 Thread Julia Lawall
The net_protocol structure is only passed as the first argument to inet_add_protocol or inet_del_protocol, both of which are declared as const. Thus the net_protocol structure itself can be const. Done with the help of Coccinelle. // @r disable optional_qualifier@ identifier i; position p; @@ s

Re: [PATCH net-next v2 0/3] ethtool: support for forward error correction mode setting on a link

2017-07-28 Thread Roopa Prabhu
On Fri, Jul 28, 2017 at 10:29 AM, Andrew Lunn wrote: > On Fri, Jul 28, 2017 at 09:46:20AM -0700, Jakub Kicinski wrote: >> On Fri, 28 Jul 2017 07:53:01 -0700, Roopa Prabhu wrote: >> > On Thu, Jul 27, 2017 at 7:33 PM, Jakub Kicinski wrote: >> > > On Thu, 27 Jul 2017 16:47:25 -0700, Roopa Prabhu wro

Re: [PATCH net-next v2 0/3] ethtool: support for forward error correction mode setting on a link

2017-07-28 Thread Roopa Prabhu
On Fri, Jul 28, 2017 at 9:46 AM, Jakub Kicinski wrote: > On Fri, 28 Jul 2017 07:53:01 -0700, Roopa Prabhu wrote: >> On Thu, Jul 27, 2017 at 7:33 PM, Jakub Kicinski wrote: >> > On Thu, 27 Jul 2017 16:47:25 -0700, Roopa Prabhu wrote: >> >> From: Roopa Prabhu >> >> >> >> Forward Error Correction (F

[PATCH V2 net-next 1/2] liquidio: Add support to pass meta information to firmware

2017-07-28 Thread Felix Manlunas
From: Veerasenareddy Burru The LiquidIO adapter has processor cores that can run Linux. This patch adds the support for passing meta information to LiquidIO linux cores. Signed-off-by: Veerasenareddy Burru Signed-off-by: Srinivasa Jampala Signed-off-by: Satanand Burla Signed-off-by: Raghu Vat

[PATCH V2 net-next 2/2] liquidio: Add support to create management interface

2017-07-28 Thread Felix Manlunas
From: Veerasenareddy Burru This patch adds support to create a virtual ethernet interface to communicate with Linux on LiquidIO adapter for management. Signed-off-by: Veerasenareddy Burru Signed-off-by: Srinivasa Jampala Signed-off-by: Satanand Burla Signed-off-by: Raghu Vatsavayi Signed-off

[PATCH V2 net-next 0/2] liquidio: Add support for managing liquidio adapter

2017-07-28 Thread Felix Manlunas
From: Veerasenareddy Burru The LiquidIO adapter has processor cores that can run Linux. This patch set adds support to create a virtual Ethernet interface on host to communicate with applications running on Linux in the LiquidIO adapter. The virtual Ethernet interface also provides login access t

Re: [RFC PATCH v1 0/5] TCP Wave

2017-07-28 Thread Eric Dumazet
On Fri, 2017-07-28 at 21:59 +0200, Natale Patriciello wrote: > Hi, > We are working on a new TCP congestion control algorithm, aiming at satisfying > new requirements coming from current networks. For instance, adaptation to > bandwidth/delay changes (due to mobility, dynamic switching, handover),

Re: STABLE: net: reduce skb_warn_bad_offload() noise

2017-07-28 Thread Eric Dumazet
On Fri, 2017-07-28 at 12:30 -0700, David Miller wrote: > From: Mark Salyzyn > Date: Fri, 28 Jul 2017 10:29:57 -0700 > > > Please backport the upstream patch to the stable trees (including > > 3.10.y, 3.18.y, 4.4.y and 4.9.y): > > > > b2504a5dbef3305ef41988ad270b0e8ec289331c net: reduce > > skb_w

Re: [PATCH 3/5] net: stmmac: Add Adaptrum Anarion GMAC glue layer

2017-07-28 Thread David Miller
From: Alexandru Gagniuc Date: Fri, 28 Jul 2017 15:07:03 -0700 > Before the GMAC on the Anarion chip can be used, the PHY interface > selection must be configured with the DWMAC block in reset. > > This layer covers a block containing only two registers. Although it > is possible to model this as

Re: [PATCH 0/2] constify inet6_protocol structures

2017-07-28 Thread David Miller
From: Julia Lawall Date: Fri, 28 Jul 2017 22:18:56 +0200 > The inet6_protocol structure is only passed as the first argument to > inet6_add_protocol or inet6_del_protocol, both of which are declared as > const. Thus the inet6_protocol structure itself can be const. > > Done with the help of Coc

Re: [RFC PATCH v1 5/5] wave: Added basic version of TCP Wave

2017-07-28 Thread David Miller
From: Natale Patriciello Date: Fri, 28 Jul 2017 21:59:19 +0200 > +static __always_inline bool test_flag(u8 value, const u8 *flags) Never, ever, declare functions as inline in foo.c files. Always let the compiler decide. No matter how brilliant you think you are, it always knows better. And wh

Re: [RFC PATCH v1 5/5] wave: Added basic version of TCP Wave

2017-07-28 Thread David Miller
From: Natale Patriciello Date: Fri, 28 Jul 2017 21:59:19 +0200 > +/* TCP Wave private struct */ > +struct wavetcp { > + /* The module flags */ > + u8 flags; > + /* The current transmission timer (us) */ > + u32 tx_timer; > + /* The current burst size (segments) */ > + u16

Re: [RFC PATCH v1 2/5] tcp: Implemented the timing-based operations

2017-07-28 Thread David Miller
From: Natale Patriciello Date: Fri, 28 Jul 2017 21:59:16 +0200 > @@ -369,6 +369,9 @@ struct tcp_sock { >*/ > struct request_sock *fastopen_rsk; > u32 *saved_syn; > + > +/* TCP send timer */ > + struct timer_list send_timer; > }; > > enum tsq_enum { If this is cong

RE: [PATCH V3 net-next] TLP: Don't reschedule PTO when there's one outstanding TLP retransmission

2017-07-28 Thread maowenan
> -Original Message- > From: Neal Cardwell [mailto:ncardw...@google.com] > Sent: Saturday, July 29, 2017 6:48 AM > To: maowenan > Cc: Netdev; David Miller; Yuchung Cheng; Nandita Dukkipati; weiyongjun (A); > Chenweilong; Wangkefeng (Kevin) > Subject: Re: [PATCH V3 net-next] TLP: Don't res

Re: [PATCH net v2] MAINTAINERS: Add more files to the PHY LIBRARY section

2017-07-28 Thread Andrew Lunn
On Fri, Jul 28, 2017 at 05:43:17PM -0700, Florian Fainelli wrote: > Include missing files that are provided by, used, or directly maintained > within the PHY LIBRARY, this include uapi header, header files used by > Device Tree code etc. > > Signed-off-by: Florian Fainelli Reviewed-by: Andrew Lu

[PATCH net v2] MAINTAINERS: Add more files to the PHY LIBRARY section

2017-07-28 Thread Florian Fainelli
Include missing files that are provided by, used, or directly maintained within the PHY LIBRARY, this include uapi header, header files used by Device Tree code etc. Signed-off-by: Florian Fainelli --- Changes in v2: - added the files Andrew identified and a few more - sort by alphabetical order

Re: [PATCH net] MAINTAINERS: Include platform_data/mdio-gpio.h into PHY LIBRARY

2017-07-28 Thread Andrew Lunn
On Fri, Jul 28, 2017 at 04:08:12PM -0700, Florian Fainelli wrote: > Include the file include/linux/platform_data/mdio-gpio.h into the PHY > LIBRARY maintainers section. > > Signed-off-by: Florian Fainelli > --- > MAINTAINERS | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/MAINTAINERS b

RE: [PATCH V5 net-next 7/8] net: hns3: Add Ethtool support to HNS3 driver

2017-07-28 Thread Salil Mehta
Hi Andrew, > -Original Message- > From: Andrew Lunn [mailto:and...@lunn.ch] > Sent: Saturday, July 29, 2017 12:49 AM > To: Salil Mehta > Cc: da...@davemloft.net; Zhuangyuzeng (Yisen); huangdaode; lipeng (Y); > mehta.salil@gmail.com; netdev@vger.kernel.org; linux- > ker...@vger.kernel.o

RE: [PATCH V5 net-next 6/8] net: hns3: Add MDIO support to HNS3 Ethernet driver for hip08 SoC

2017-07-28 Thread Salil Mehta
Hi Andrew, > -Original Message- > From: linux-rdma-ow...@vger.kernel.org [mailto:linux-rdma- > ow...@vger.kernel.org] On Behalf Of Andrew Lunn > Sent: Saturday, July 29, 2017 12:29 AM > To: Salil Mehta > Cc: da...@davemloft.net; Zhuangyuzeng (Yisen); huangdaode; lipeng (Y); > mehta.salil..

RE: [PATCH V5 net-next 6/8] net: hns3: Add MDIO support to HNS3 Ethernet driver for hip08 SoC

2017-07-28 Thread Salil Mehta
Hi Andrew, > -Original Message- > From: Andrew Lunn [mailto:and...@lunn.ch] > Sent: Saturday, July 29, 2017 12:24 AM > To: Salil Mehta > Cc: da...@davemloft.net; Zhuangyuzeng (Yisen); huangdaode; lipeng (Y); > mehta.salil@gmail.com; netdev@vger.kernel.org; linux- > ker...@vger.kernel.o

Re: [PATCH V5 net-next 7/8] net: hns3: Add Ethtool support to HNS3 driver

2017-07-28 Thread Andrew Lunn
On Fri, Jul 28, 2017 at 11:26:51PM +0100, Salil Mehta wrote: > +static const struct hns3_link_mode_mapping hns3_lm_map[] = { > + {HNS3_LM_FIBRE_BIT, ETHTOOL_LINK_MODE_FIBRE_BIT, FLG}, > + {HNS3_LM_AUTONEG_BIT, ETHTOOL_LINK_MODE_Autoneg_BIT, FLG}, > + {HNS3_LM_TP_BIT, ETHTOOL_LINK_MODE_T

Re: [PATCH V5 net-next 6/8] net: hns3: Add MDIO support to HNS3 Ethernet driver for hip08 SoC

2017-07-28 Thread Andrew Lunn
> +int hclge_mac_mdio_config(struct hclge_dev *hdev) > +{ .. > +} > + > +int hclge_mac_start_phy(struct hclge_dev *hdev) > +{ > +} > + > +void hclge_mac_stop_phy(struct hclge_dev *hdev) > +{ > +} > -- These are not static functions. So i would expect them to be in a header file somewhere

Re: [PATCH V5 net-next 6/8] net: hns3: Add MDIO support to HNS3 Ethernet driver for hip08 SoC

2017-07-28 Thread Andrew Lunn
> +static void hclge_mac_adjust_link(struct net_device *netdev) > +{ > + struct hnae3_handle *h = *((void **)netdev_priv(netdev)); > + struct hclge_vport *vport = hclge_get_vport(h); > + struct hclge_dev *hdev = vport->back; > + int duplex, speed; > + int ret; > + > + speed

[PATCH net-next 3/3] strparser: Generalize strparser

2017-07-28 Thread Tom Herbert
Generalize strparser from more than just being used in conjunction with read_sock. strparser will also be used in the send path with zero proxy. The primary change is to create strp_process function that performs the critical processing on skbs. The documentation is also updated to reflect the new

[PATCH net-next 1/3] proto_ops: Add locked held versions of sendmsg and sendpage

2017-07-28 Thread Tom Herbert
Add new proto_ops sendmsg_locked and sendpage_locked that can be called when the socket lock is already held. Correspondingly, add kernel_sendmsg_locked and kernel_sendpage_locked as front end functions. These functions will be used in zero proxy so that we can take the socket lock in a ULP sendms

[PATCH net-next 2/3] skbuff: Function to send an skbuf on a socket

2017-07-28 Thread Tom Herbert
Add skb_send_sock to send an skbuff on a socket within the kernel. Arguments include an offset so that an skbuf might be sent in mulitple calls (e.g. send buffer limit is hit). Signed-off-by: Tom Herbert --- include/linux/skbuff.h | 3 ++ net/core/skbuff.c | 101 ++

[PATCH net-next 0/3] net: Infrastructure changes for [kz]proxy

2017-07-28 Thread Tom Herbert
This patch set contains some general infrastructure enhancements that will be used by kernel proxy and zero proxy. The changes are: - proto_ops: Add locked versions of sendmsg and sendpage - skb_send_sock: Allow sending and skb on a socket within the kernel - Generalize strparser. Allow

Re: [RFC PATCH v1 5/5] wave: Added basic version of TCP Wave

2017-07-28 Thread Neal Cardwell
On Fri, Jul 28, 2017 at 3:59 PM, Natale Patriciello wrote: > TCP Wave (TCPW) replaces the window-based transmission paradigm of the > standard TCP with a burst-based transmission, the ACK-clock scheduling > with a self-managed timer and the RTT-based congestion control loop > with an Ack-based Cap

[PATCH net] MAINTAINERS: Include platform_data/mdio-gpio.h into PHY LIBRARY

2017-07-28 Thread Florian Fainelli
Include the file include/linux/platform_data/mdio-gpio.h into the PHY LIBRARY maintainers section. Signed-off-by: Florian Fainelli --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 297e610c9163..7b5834ee1260 100644 --- a/MAINTAINERS +++ b/MAINTAI

Re: [PATCH net-next] TLP: Don't reschedule PTO when there's one outstanding TLP retransmission.

2017-07-28 Thread Neal Cardwell
On Wed, Jul 26, 2017 at 9:28 PM, maowenan wrote: > Ok, please check as below. Server: 192.169.0.18, client: 192.169.0.17 > .. Thanks for this trace! Here is a condensed version that I believe should be equivalent, for those who are working on parsing what's going on: 2.239562 srv > cli: P 54

Re: TCP fast retransmit issues

2017-07-28 Thread Neal Cardwell
On Wed, Jul 26, 2017 at 3:02 PM, Neal Cardwell wrote: > On Wed, Jul 26, 2017 at 2:38 PM, Neal Cardwell wrote: >> Yeah, it looks like I can reproduce this issue with (1) bad sacks >> causing repeated TLPs, and (2) TLPs timers being pushed out to later >> times due to incoming data. Scripts are att

Re: [PATCH V3 net-next] TLP: Don't reschedule PTO when there's one outstanding TLP retransmission

2017-07-28 Thread Neal Cardwell
On Thu, Jul 27, 2017 at 8:08 AM, Mao Wenan wrote: > If there is one TLP probe went out(TLP use the write_queue_tail > packet as TLP probe, we assume this first TLP probe named A), and > this TLP probe was not acked by receive side. > > Then the transmit side sent the next two packetes out(named B,

Re: STABLE: net: reduce skb_warn_bad_offload() noise

2017-07-28 Thread Greg KH
On Fri, Jul 28, 2017 at 12:30:10PM -0700, David Miller wrote: > From: Mark Salyzyn > Date: Fri, 28 Jul 2017 10:29:57 -0700 > > > Please backport the upstream patch to the stable trees (including > > 3.10.y, 3.18.y, 4.4.y and 4.9.y): > > > > b2504a5dbef3305ef41988ad270b0e8ec289331c net: reduce >

[PATCH V5 net-next 3/8] net: hns3: Add HNS3 IMP(Integrated Mgmt Proc) Cmd Interface Support

2017-07-28 Thread Salil Mehta
This patch adds the support of IMP (Integrated Management Processor) command interface to the HNS3 driver. Each PF/VF has support of CQP(Command Queue Pair) ring interface. Each CQP consis of send queue CSQ and receive queue CRQ. There are various commands a PF/VF may support, like for Flow Table

[PATCH V5 net-next 0/8] Hisilicon Network Subsystem 3 Ethernet Driver

2017-07-28 Thread Salil Mehta
This patch-set contains the support of the HNS3 (Hisilicon Network Subsystem 3) Ethernet driver for hip08 family of SoCs and future upcoming SoCs. Hisilicon's new hip08 SoCs have integrated ethernet based on PCI Express and hence there was a need of new driver over the previous HNS driver which is

[PATCH v4 0/4] net: ethernet: ti: cpts: fix tx timestamping timeout

2017-07-28 Thread Grygorii Strashko
Hi With the low Ethernet connection speed cpdma notification about packet processing can be received before CPTS TX timestamp event, which is set when packet actually left CPSW while cpdma notification is sent when packet pushed in CPSW fifo. As result, when connection is slow and CPU is fast enou

[PATCH v4 2/4] net: ethernet: ti: cpts: convert to use ptp auxiliary worker

2017-07-28 Thread Grygorii Strashko
There could be significant delay in CPTS work schedule under high system load and on -RT which could cause CPTS misbehavior due to internal counter overflow. Usage of own kthread_worker allows to avoid such kind of issues and makes it possible to tune priority of CPTS kthread_worker thread on -RT (

[PATCH v4 1/4] ptp: introduce ptp auxiliary worker

2017-07-28 Thread Grygorii Strashko
Many PTP drivers required to perform some asynchronous or periodic work, like periodically handling PHC counter overflow or handle delayed timestamp for RX/TX network packets. In most of the cases, such work is implemented using workqueues. Unfortunately, Kernel workqueues might introduce significa

Re: [PATCH net-next 4/4] net: dsa: lan9303: MDIO access phy registers directly

2017-07-28 Thread Egil Hjelmeland
Den 28. juli 2017 23:28, skrev Andrew Lunn: Since the kernel module license is GPL, EXPORT_SYMBOL_GPL() would seem to be appropriate, which can be done as a subsequent patch. Reviewed-by: Florian Fainelli I have no idea how these legalities work. But for the record, I give consent to change t

[PATCH v4 4/4] net: ethernet: ti: cpts: fix fifo read in cpts_find_ts

2017-07-28 Thread Grygorii Strashko
Now the call chain cpts_find_ts() |- cpts_fifo_read(cpts, CPTS_EV_PUSH) will stop reading CPTS FIFO if PUSH event is found. But this is not expected and CPTS FIFI should be completely drained here. This is most probably copy-paste error and it has no negative impact as CPTS_EV_PUSH should not b

[PATCH v4 3/4] net: ethernet: ti: cpts: fix tx timestamping timeout

2017-07-28 Thread Grygorii Strashko
With the low speed Ethernet connection CPDMA notification about packet processing can be received before CPTS TX timestamp event, which is set when packet actually left CPSW while cpdma notification is sent when packet pushed in CPSW fifo. As result, when connection is slow and CPU is fast enough

[PATCH V5 net-next 1/8] net: hns3: Add support of HNS3 Ethernet Driver for hip08 SoC

2017-07-28 Thread Salil Mehta
This patch adds the support of Hisilicon Network Subsystem 3 Ethernet driver to hip08 family of SoCs. This driver includes basic Rx/Tx functionality. It also includes the client registration code with the HNAE3(Hisilicon Network Acceleration Engine 3) framework. This work provides the initial sup

[PATCH V5 net-next 4/8] net: hns3: Add HNS3 Acceleration Engine & Compatibility Layer Support

2017-07-28 Thread Salil Mehta
This patch adds the support of Hisilicon Network Subsystem Accceleration Engine and common operations to access it. This layer provides access to the hardware configuration, hardware statistics. This layer is also responsible for triggering the initialization of the PHY layer through the below MDIO

[PATCH V5 net-next 2/8] net: hns3: Add support of the HNAE3 framework

2017-07-28 Thread Salil Mehta
This patch adds the support of the HNAE3 (Hisilicon Network Acceleration Engine 3) framework support to the HNS3 driver. Framework facilitates clients like ENET(HNS3 Ethernet Driver), RoCE and user-space Ethernet drivers (like ODP etc.) to register with HNAE3 devices and their associated operation

[PATCH V5 net-next 5/8] net: hns3: Add support of TX Scheduler & Shaper to HNS3 driver

2017-07-28 Thread Salil Mehta
THis patch adds the support of the Scheduling and Shaping functionalities during the transmit leg. This also adds the support of Pause at MAC level. (Pause at per-priority level shall be added later along with the DCB feature). Hardware as such consists of two types of cofiguration of 6 level sche

[PATCH V5 net-next 7/8] net: hns3: Add Ethtool support to HNS3 driver

2017-07-28 Thread Salil Mehta
This patch adds the support of the Ethtool interface to the HNS3 Ethernet driver. Various commands to read the statistics, configure the offloading, loopback selftest etc. are supported. Signed-off-by: Daode Huang Signed-off-by: lipeng Signed-off-by: Salil Mehta Signed-off-by: Yisen Zhuang ---

[PATCH V5 net-next 6/8] net: hns3: Add MDIO support to HNS3 Ethernet driver for hip08 SoC

2017-07-28 Thread Salil Mehta
This patch adds the support of MDIO bus interface for HNS3 driver. Code provides various interfaces to start and stop the PHY layer and to read and write the MDIO bus or PHY. Signed-off-by: Daode Huang Signed-off-by: lipeng Signed-off-by: Salil Mehta Signed-off-by: Yisen Zhuang --- Patch V5: A

[PATCH V5 net-next 8/8] net: hns3: Add HNS3 driver to kernel build framework & MAINTAINERS

2017-07-28 Thread Salil Mehta
This patch updates the MAINTAINERS file with HNS3 Ethernet driver maintainers names and other details. This also introduces the new Makefiles required to build the HNS3 Ethernet driver and updates the existing Kconfig file in the hisilicon folder. Signed-off-by: Salil Mehta --- Patch V5: Addresse

Re: [PATCH net-next v11 3/4] net sched actions: dump more than TCA_ACT_MAX_PRIO actions per batch

2017-07-28 Thread Jamal Hadi Salim
On 17-07-28 11:45 AM, Jiri Pirko wrote: Fri, Jul 28, 2017 at 05:08:10PM CEST, j...@mojatatu.com wrote: On 17-07-28 10:52 AM, Jamal Hadi Salim wrote: On 17-07-28 10:12 AM, Jiri Pirko wrote: /*disallow invalid selector */ if ((bf->selector & *valid_flags_allowed) > *valid_flag

[PATCH 3/5] net: stmmac: Add Adaptrum Anarion GMAC glue layer

2017-07-28 Thread Alexandru Gagniuc
Before the GMAC on the Anarion chip can be used, the PHY interface selection must be configured with the DWMAC block in reset. This layer covers a block containing only two registers. Although it is possible to model this as a reset controller and use the "resets" property of stmmac, it's much mor

Re: [PATCH net-next v11 1/4] net netlink: Add new type NLA_BITFIELD_32

2017-07-28 Thread Jamal Hadi Salim
On 17-07-28 11:13 AM, David Ahern wrote: On 7/28/17 9:04 AM, Jamal Hadi Salim wrote: Kernel side checking for device ifindex must know what a device ifindex means. That doesnt disqualify that the generic code checks that it is of the same size as a signed 32b, etc. That is generic stuff that ca

Re: [RFC PATCH v1] net: ethernet: nb8800: Reset HW block in ndo_open

2017-07-28 Thread Mason
On 28/07/2017 20:56, Måns Rullgård wrote: > Marc Gonzalez writes: > >> On 28/07/2017 18:17, Måns Rullgård wrote: >> >>> Marc Gonzalez wrote: >>> ndo_stop breaks RX in a way that ndo_open is unable to undo. >>> >>> Please elaborate. Why can't it be fixed in a less heavy-handed way? >> >> I'm

Re: [PATCH net-next 4/4] net: dsa: lan9303: MDIO access phy registers directly

2017-07-28 Thread Andrew Lunn
> >Since the kernel module license is GPL, EXPORT_SYMBOL_GPL() would seem > >to be appropriate, which can be done as a subsequent patch. > > > >Reviewed-by: Florian Fainelli > > > I have no idea how these legalities work. But for the record, > I give consent to change to EXPORT_SYMBOL_GPL at any t

Re: [PATCH V2 3/4] net-next: dsa: fix flow dissection

2017-07-28 Thread Andrew Lunn
> thanks for the feedback. should I add 2 callbacks for each of the 2 > parameters ? Hi John A single callback is better. We don't want to have to peek into the packet twice to determine two values. Andrew

Re: refcount_t + (resend to wider audience)

2017-07-28 Thread Andrew Lunn
> Please, guidance on where I can go from here. Hi Mark Real fixes will be accepted. So check if there are any refcount fixes which are not in stable. If so, ask for the fix to be added to stable. A fix should be independent of the infrastructure used to find there is an issue. Andrew

Re: [RFC] net: make net.core.{r,w}mem_{default,max} namespaced

2017-07-28 Thread Hannes Frederic Sowa
Matteo Croce writes: > The following sysctl are global and can't be read or set from a netns: > > net.core.rmem_default > net.core.rmem_max > net.core.wmem_default > net.core.wmem_max [...] I think a sensible addition to those sysctls would be tcp_moderate_rcvbuf to disable autotuning. Thanks!

Re: [RFC PATCH] IP: do not modify ingress packet IP option in ip_options_echo()

2017-07-28 Thread Hannes Frederic Sowa
Hello, David Miller writes: > From: Paolo Abeni > Date: Fri, 21 Jul 2017 15:55:18 +0200 > >> diff --git a/net/ipv4/ip_options.c b/net/ipv4/ip_options.c >> index 93157f2..fdda973 100644 >> --- a/net/ipv4/ip_options.c >> +++ b/net/ipv4/ip_options.c >> @@ -174,9 +174,6 @@ int __ip_options_echo(str

[PATCH 0/2] constify inet6_protocol structures

2017-07-28 Thread Julia Lawall
The inet6_protocol structure is only passed as the first argument to inet6_add_protocol or inet6_del_protocol, both of which are declared as const. Thus the inet6_protocol structure itself can be const. Done with the help of Coccinelle. // @r disable optional_qualifier@ identifier i; position p

[PATCH 1/2] ipv6: constify inet6_protocol structures

2017-07-28 Thread Julia Lawall
The inet6_protocol structure is only passed as the first argument to inet6_add_protocol or inet6_del_protocol, both of which are declared as const. Thus the inet6_protocol structure itself can be const. Also drop __read_mostly where present on the newly const structures. Done with the help of Co

[PATCH 2/2] l2tp: constify inet6_protocol structures

2017-07-28 Thread Julia Lawall
The inet6_protocol structure is only passed as the first argument to inet6_add_protocol or inet6_del_protocol, both of which are declared as const. Thus the inet6_protocol structure itself can be const. Also drop __read_mostly on the newly const structure. Done with the help of Coccinelle. Sign

[PATCH net] ipv4: fib: Fix NULL pointer deref during fib_sync_down_dev()

2017-07-28 Thread Ido Schimmel
Michał reported a NULL pointer deref during fib_sync_down_dev() when unregistering a netdevice. The problem is that we don't check for 'in_dev' being NULL, which can happen in very specific cases. Usually routes are flushed upon NETDEV_DOWN sent in either the netdev or the inetaddr notification ch

[RFC PATCH v1 0/5] TCP Wave

2017-07-28 Thread Natale Patriciello
Hi, We are working on a new TCP congestion control algorithm, aiming at satisfying new requirements coming from current networks. For instance, adaptation to bandwidth/delay changes (due to mobility, dynamic switching, handover), and optimal exploitation of very high link capacity and efficient tra

[RFC PATCH v1 1/5] tcp: Added callback for timed sender operations

2017-07-28 Thread Natale Patriciello
Standard TCP is ACK-clocked, or in other words it must wait for ACKs after sending a full window size bytes. However, in some particular cases, a congestion control would like to be able to tell the TCP implementation when it is possible to send segments through a timer. This patch adds the interfa

[RFC PATCH v1 2/5] tcp: Implemented the timing-based operations

2017-07-28 Thread Natale Patriciello
Timing the TCP operation based on the timer returned by the congestion control. If the congestion control does not implement the timing interface, the TCP behaves as usual, by sending down segments as soon as it is possible. Otherwise, it will wait until the timer expires (and so respecting the tim

[RFC PATCH v1 3/5] tcp: PSH frames sent without timer involved

2017-07-28 Thread Natale Patriciello
Segments flagged with 'PSH' should be sent as soon as possible, ignoring the timing set by the congestion control (if any). This patch avoids the waiting of 'PSH' segments in the TCP queue. Signed-off-by: Natale Patriciello Tested-by: Ahmed Said --- net/ipv4/tcp.c | 8 1 file changed,

[RFC PATCH v1 4/5] tcp: Add initial delay to allow data queueing

2017-07-28 Thread Natale Patriciello
To be able to correctly send out data respecting the congestion control timing requests, it is necessary to add a small delay at the beginning of the transfer. It is necessary because, if there is no data in the TCP queue, the sending timer is useless (and therefore not set). But, it can happen (es

[RFC PATCH v1 5/5] wave: Added basic version of TCP Wave

2017-07-28 Thread Natale Patriciello
TCP Wave (TCPW) replaces the window-based transmission paradigm of the standard TCP with a burst-based transmission, the ACK-clock scheduling with a self-managed timer and the RTT-based congestion control loop with an Ack-based Capacity and Congestion Estimation (ACCE) module. In non-technical word

Re: refcount_t + (resend to wider audience)

2017-07-28 Thread Mark Salyzyn
On 07/28/2017 12:31 PM, David Miller wrote: Sorry, even with this explanation this -stable require is completely and totally inappropriate. Puts me between a rock and a hard place trying to address kernel security issues. Should I instead file KASAN Use-After-Free reports on stable kernels here

Re: [PATCH net v2] net: phy: Correctly process PHY_HALTED in phy_stop_machine()

2017-07-28 Thread Marc Gonzalez
On 28/07/2017 20:58, Florian Fainelli wrote: > Marc reported that he was not getting the PHY library adjust_link() > callback function to run when calling phy_stop() + phy_disconnect() > which does not indeed happen because we set the state machine to > PHY_HALTED but we don't get to run it to pro

Re: [PATCH net] ipv6: no need to return rt->dst.error if it is not null entry.

2017-07-28 Thread Roopa Prabhu
On Fri, Jul 28, 2017 at 10:39 AM, David Ahern wrote: > On 7/28/17 11:13 AM, Roopa Prabhu wrote: >> for fibmatch, my original intent was to return with an error code. >> This is similar >> to the ipv4 behavior. One option is to keep the check in there and put >> the 'fibmatch' >> condition around i

Re: [PATCH net-next 4/4] net: dsa: lan9303: MDIO access phy registers directly

2017-07-28 Thread Egil Hjelmeland
Den 28. juli 2017 19:05, skrev Florian Fainelli: On 07/28/2017 09:55 AM, Vivien Didelot wrote: Hi Egil, Egil Hjelmeland writes: +const struct lan9303_phy_ops lan9303_indirect_phy_ops = { + .phy_read = lan9303_indirect_phy_read, + .phy_write = lan9303_indirect_phy_write, +}; +EXPO

Re: [PATCH v2 2/4] can: fixed-transceiver: Add documentation for CAN fixed transceiver bindings

2017-07-28 Thread Kurt Van Dijck
> > On 07/28/2017 01:33 PM, Oliver Hartkopp wrote: > > Hi Kurt, > > > > On 07/28/2017 03:02 PM, Kurt Van Dijck wrote: > > > The word 'max-arbitration-bitrate' makes the difference very clear. > >>> > >>> I think you are mixing up ISO layer 1 and ISO layer 2. > >> > >> In order to provide h

Re: [PATCH V2 3/4] net-next: dsa: fix flow dissection

2017-07-28 Thread John Crispin
On 26/07/17 17:10, Andrew Lunn wrote: On Fri, Jul 21, 2017 at 10:58:12AM +0200, John Crispin wrote: RPS and probably other kernel features are currently broken on some if not all DSA devices. The root cause of this is that skb_hash will call the flow_dissector. At this point the skb still cont

Re: refcount_t + (resend to wider audience)

2017-07-28 Thread David Miller
From: Mark Salyzyn Date: Fri, 28 Jul 2017 11:07:53 -0700 > On 07/28/2017 10:41 AM, Andrew Lunn wrote: >> On Fri, Jul 28, 2017 at 10:15:23AM -0700, Mark Salyzyn wrote: >>> (Resend to wider audience to comply with >>> Documentation/networking/netdev-FAQ.txt) >>> >>> Please apply/backport the follow

Re: STABLE: net: reduce skb_warn_bad_offload() noise

2017-07-28 Thread David Miller
From: Mark Salyzyn Date: Fri, 28 Jul 2017 10:29:57 -0700 > Please backport the upstream patch to the stable trees (including > 3.10.y, 3.18.y, 4.4.y and 4.9.y): > > b2504a5dbef3305ef41988ad270b0e8ec289331c net: reduce > skb_warn_bad_offload() noise > > Impacting performance or creating unnecess

Re: refcount_t + (resend to wider audience)

2017-07-28 Thread David Miller
From: Mark Salyzyn Date: Fri, 28 Jul 2017 10:15:23 -0700 > (Resend to wider audience to comply with > Documentation/networking/netdev-FAQ.txt) > > Please apply/backport the following upstream feature and followup > grouped fixes patches to the stable trees (expect included in at least > 3.10.y,

Re: [RFC net-next 0/6] tcp: remove prequeue and header prediction

2017-07-28 Thread Yuchung Cheng
On Thu, Jul 27, 2017 at 4:31 PM, Florian Westphal wrote: > > This RFC removes tcp prequeueing and header prediction support. > > After a hallway discussion with Eric Dumazet some > maybe-not-so-useful-anymore TCP stack features came up, HP and > Prequeue among these. > > So this RFC proposes to ax

Re: Long stalls creating a new netns after a netns with a SMB client exits

2017-07-28 Thread David Ahern
On 7/28/17 12:58 PM, Rolf Neugebauer wrote: >>> I can readily reproduce this on 4.9.39, 4.11.12 and another user >>> repro-ed it on 4.12.3. It seems to happen every time. At least one >>> user reported issues with NFS mounts as well, but we were not able to >>> reproduce it. It's not clear to me if

Re: [v4.12 regression] netns: NULL deref in fib_sync_down_dev()

2017-07-28 Thread Ido Schimmel
On Fri, Jul 28, 2017 at 08:04:37PM +0200, Michał Mirosław wrote: > On Fri, Jul 28, 2017 at 08:36:02PM +0300, Ido Schimmel wrote: > > On Fri, Jul 28, 2017 at 10:28:16AM -0700, Cong Wang wrote: > > > On Fri, Jul 28, 2017 at 9:43 AM, Ido Schimmel wrote: > > > > On Fri, Jul 28, 2017 at 06:00:47PM +020

[PATCH net v2] net: phy: Correctly process PHY_HALTED in phy_stop_machine()

2017-07-28 Thread Florian Fainelli
Marc reported that he was not getting the PHY library adjust_link() callback function to run when calling phy_stop() + phy_disconnect() which does not indeed happen because we set the state machine to PHY_HALTED but we don't get to run it to process this state past that point. Fix this with a sync

Re: Long stalls creating a new netns after a netns with a SMB client exits

2017-07-28 Thread Rolf Neugebauer
On Fri, Jul 28, 2017 at 6:49 PM, Cong Wang wrote: > Hello, > > On Fri, Jul 28, 2017 at 9:47 AM, Rolf Neugebauer > wrote: >> Creating the new namespace is stalling for around 200 seconds and >> there 20 odd messages on the console, like: >> >> [ 67.372603] unregister_netdevice: waiting for lo to

Re: [RFC PATCH v1] net: ethernet: nb8800: Reset HW block in ndo_open

2017-07-28 Thread Måns Rullgård
Marc Gonzalez writes: > On 28/07/2017 18:17, Måns Rullgård wrote: > >> Marc Gonzalez wrote: >> >>> ndo_stop breaks RX in a way that ndo_open is unable to undo. >> >> Please elaborate. Why can't it be fixed in a less heavy-handed way? > > I'm not sure what "elaborate" means. After we've been th

Re: [PATCH v2 2/4] can: fixed-transceiver: Add documentation for CAN fixed transceiver bindings

2017-07-28 Thread Franklin S Cooper Jr
On 07/28/2017 01:33 PM, Oliver Hartkopp wrote: > Hi Kurt, > > On 07/28/2017 03:02 PM, Kurt Van Dijck wrote: > The word 'max-arbitration-bitrate' makes the difference very clear. >>> >>> I think you are mixing up ISO layer 1 and ISO layer 2. >> >> In order to provide higher data throughput

Re: [PATCH net] net: phy: Run state machine to completion

2017-07-28 Thread Florian Fainelli
On 07/28/2017 03:57 AM, Marc Gonzalez wrote: > On 26/07/2017 21:24, Florian Fainelli wrote: > >> Marc reported that he was not getting the PHY library adjust_link() >> callback function to run when calling phy_stop() + phy_disconnect() >> which does not indeed happen because we don't make sure we

Re: [PATCH net] xgene: Don't fail probe, if there is no clk resource for SGMII interfaces

2017-07-28 Thread Iyappan Subramanian
On Fri, Jul 28, 2017 at 7:23 AM, Tom Bogendoerfer wrote: > On Thu, Jul 27, 2017 at 03:39:58PM -0700, Laura Abbott wrote: >> I don't know the intricacies of the Mustang hardware but external >> aborts have been a symptom of missing clocks on other hardware. > > you are right, it's a missing clock.

Re: [PATCH v2 2/4] can: fixed-transceiver: Add documentation for CAN fixed transceiver bindings

2017-07-28 Thread Oliver Hartkopp
Hi Kurt, On 07/28/2017 03:02 PM, Kurt Van Dijck wrote: The word 'max-arbitration-bitrate' makes the difference very clear. I think you are mixing up ISO layer 1 and ISO layer 2. In order to provide higher data throughput without putting extra limits on transceiver & wire, the requirement fo

Re: refcount_t + (resend to wider audience)

2017-07-28 Thread Mark Salyzyn
On 07/28/2017 10:41 AM, Andrew Lunn wrote: On Fri, Jul 28, 2017 at 10:15:23AM -0700, Mark Salyzyn wrote: (Resend to wider audience to comply with Documentation/networking/netdev-FAQ.txt) Please apply/backport the following upstream feature and followup grouped fixes patches to the stable trees

Re: [v4.12 regression] netns: NULL deref in fib_sync_down_dev()

2017-07-28 Thread Michał Mirosław
On Fri, Jul 28, 2017 at 08:36:02PM +0300, Ido Schimmel wrote: > On Fri, Jul 28, 2017 at 10:28:16AM -0700, Cong Wang wrote: > > On Fri, Jul 28, 2017 at 9:43 AM, Ido Schimmel wrote: > > > On Fri, Jul 28, 2017 at 06:00:47PM +0200, Michał Mirosław wrote: > > >> Dear NetDevs, > > >> > > >> Before I go

Re: [PATCH 0/3] net-next: stmmac: support future possible different internal phy mode

2017-07-28 Thread Florian Fainelli
On 07/28/2017 07:44 AM, Corentin Labbe wrote: > On Fri, Jul 28, 2017 at 04:36:00PM +0200, Andrew Lunn wrote: I've probably asked this before: Does the internal PHY use a different PHY ID in registers 2 and 3? >>> >>> yes >>> >>> reg2: 0x0044 >>> reg3: 0X1500 > > Copy/paste error, it

Re: Long stalls creating a new netns after a netns with a SMB client exits

2017-07-28 Thread Cong Wang
Hello, On Fri, Jul 28, 2017 at 9:47 AM, Rolf Neugebauer wrote: > Creating the new namespace is stalling for around 200 seconds and > there 20 odd messages on the console, like: > > [ 67.372603] unregister_netdevice: waiting for lo to become free. > Usage count = 1 > Sounds like another netdev

Re: refcount_t + (resend to wider audience)

2017-07-28 Thread Andrew Lunn
On Fri, Jul 28, 2017 at 10:15:23AM -0700, Mark Salyzyn wrote: > (Resend to wider audience to comply with > Documentation/networking/netdev-FAQ.txt) > > Please apply/backport the following upstream feature and followup > grouped fixes patches to the stable trees (expect included in at least > 3.10.

Re: [PATCH net] ipv6: no need to return rt->dst.error if it is not null entry.

2017-07-28 Thread David Ahern
On 7/28/17 11:13 AM, Roopa Prabhu wrote: > for fibmatch, my original intent was to return with an error code. > This is similar > to the ipv4 behavior. One option is to keep the check in there and put > the 'fibmatch' > condition around it. But, i do want to make sure that for the fibmatch case, >

Re: [v4.12 regression] netns: NULL deref in fib_sync_down_dev()

2017-07-28 Thread Ido Schimmel
On Fri, Jul 28, 2017 at 10:28:16AM -0700, Cong Wang wrote: > On Fri, Jul 28, 2017 at 9:43 AM, Ido Schimmel wrote: > > On Fri, Jul 28, 2017 at 06:00:47PM +0200, Michał Mirosław wrote: > >> Dear NetDevs, > >> > >> Before I go to bisecting, have you seen a following NULL dereference, > >> yet? Where

Re: [PATCH v3 3/3] net: ethernet: ti: cpts: fix tx timestamping timeout

2017-07-28 Thread Grygorii Strashko
On 07/28/2017 12:02 PM, Ivan Khoronzhuk wrote: On Wed, Jul 26, 2017 at 05:11:38PM -0500, Grygorii Strashko wrote: With the low speed Ethernet connection CPDMA notification about packet processing can be received before CPTS TX timestamp event, which is set when packet actually left CPSW while

Re: [PATCH net-next v2 0/3] ethtool: support for forward error correction mode setting on a link

2017-07-28 Thread Andrew Lunn
On Fri, Jul 28, 2017 at 09:46:20AM -0700, Jakub Kicinski wrote: > On Fri, 28 Jul 2017 07:53:01 -0700, Roopa Prabhu wrote: > > On Thu, Jul 27, 2017 at 7:33 PM, Jakub Kicinski wrote: > > > On Thu, 27 Jul 2017 16:47:25 -0700, Roopa Prabhu wrote: > > >> From: Roopa Prabhu > > >> > > >> Forward Erro

STABLE: net: reduce skb_warn_bad_offload() noise

2017-07-28 Thread Mark Salyzyn
Please backport the upstream patch to the stable trees (including 3.10.y, 3.18.y, 4.4.y and 4.9.y): b2504a5dbef3305ef41988ad270b0e8ec289331c net: reduce skb_warn_bad_offload() noise Impacting performance or creating unnecessary alarm, and will result in kernel panic for panic_on_warn configu

  1   2   3   >