Re: [PATCH v2 2/4] can: fixed-transceiver: Add documentation for CAN fixed transceiver bindings

2017-08-01 Thread Kurt Van Dijck
> Hi Kurt, > > On 07/28/2017 09:41 PM, Kurt Van Dijck wrote: > > >>The transceiver is an analog device that needs to support faster > >>switching frequency (FETs) including minimizing delay to support CAN-FD > >>ie higher bitrate. From the transceiver perspective the bits for > >>"arbitration" an

Re: [RFC net-next] net ipv6: convert fib6_table rwlock to a percpu lock

2017-08-01 Thread Eric Dumazet
On Mon, 2017-07-31 at 19:57 -0700, Shaohua Li wrote: > On Mon, Jul 31, 2017 at 04:10:07PM -0700, Stephen Hemminger wrote: > > On Mon, 31 Jul 2017 10:18:57 -0700 > > Shaohua Li wrote: > > > > > From: Shaohua Li > > > > > > In a syn flooding test, the fib6_table rwlock is a significant > > > bott

Re: [PATCH net 1/3] tcp: introduce tcp_rto_delta_us() helper for xmit timer fix

2017-08-01 Thread Eric Dumazet
On Mon, 2017-07-31 at 22:58 -0400, Neal Cardwell wrote: > Pure refactor. This helper will be required in the xmit timer fix > later in the patch series. (Because the TLP logic will want to make > this calculation.) > > Fixes: 6ba8a3b19e76 ("tcp: Tail loss probe (TLP)") > Signed-off-by: Neal Cardwe

Re: [RFC] net: make net.core.{r,w}mem_{default,max} namespaced

2017-08-01 Thread Eric Dumazet
On Tue, 2017-08-01 at 02:17 -0400, Hannes Frederic Sowa wrote: > We do account rmem as well as wmem allocated memory to the apropriate > mem_cgs. In theory this should be okay. Last time I checked, rmem was not memcg ready yet. Can you describe the details ? Thanks.

Re: [PATCH net 2/3] tcp: enable xmit timer fix by having TLP use time when RTO should fire

2017-08-01 Thread Eric Dumazet
On Mon, 2017-07-31 at 22:58 -0400, Neal Cardwell wrote: > Have tcp_schedule_loss_probe() base the TLP scheduling decision based > on when the RTO *should* fire. This is to enable the upcoming xmit > timer fix in this series, where tcp_schedule_loss_probe() cannot > assume that the last timer instal

Re: [PATCH net 3/3] tcp: fix xmit timer to only be reset if data ACKed/SACKed

2017-08-01 Thread Eric Dumazet
On Mon, 2017-07-31 at 22:58 -0400, Neal Cardwell wrote: > Fix a TCP loss recovery performance bug raised recently on the netdev > list, in two threads: > > (i) July 26, 2017: netdev thread "TCP fast retransmit issues" > (ii) July 26, 2017: netdev thread: > "[PATCH V2 net-next] TLP: Don't res

RE: [PATCH] netfilter: fix stringop-overflow warning with UBSAN

2017-08-01 Thread David Laight
From: Arnd Bergmann > Sent: 31 July 2017 11:09 > Using gcc-7 with UBSAN enabled, we get this false-positive warning: > > net/netfilter/ipset/ip_set_core.c: In function 'ip_set_sockfn_get': > net/netfilter/ipset/ip_set_core.c:1998:3: error: 'strncpy' writing 32 bytes > into a region of size 2 > ov

Re: [RFC] net: make net.core.{r,w}mem_{default,max} namespaced

2017-08-01 Thread Hannes Frederic Sowa
On Tue, Aug 1, 2017, at 09:18, Eric Dumazet wrote: > On Tue, 2017-08-01 at 02:17 -0400, Hannes Frederic Sowa wrote: > > > We do account rmem as well as wmem allocated memory to the apropriate > > mem_cgs. In theory this should be okay. > > Last time I checked, rmem was not memcg ready yet. > > C

pull request: bluetooth-next 2017-08-01

2017-08-01 Thread Johan Hedberg
Hi Dave, Here's our first batch of Bluetooth patches for the 4.14 kernel: - Several new USB IDs for the btusb driver - Memory leak fix in btusb driver - Cleanups & fixes to hci_nokia, hci_serdev and hci_bcm drivers - Fixed cleanup path in mrf24j40 (802.15.4) driver probe function - A few oth

[PATCH net-next 1/7] esp4: Support RX checksum with crypto offload

2017-08-01 Thread ilant
From: Ilan Tayari Keep the device's reported ip_summed indication in case crypto was offloaded by the device. Subtract the csum values of the stripped parts (esp header+iv, esp trailer+auth_data) to keep value correct. Note: CHECKSUM_COMPLETE should be indicated only if skb->csum has the post-de

[PATCH net-next 2/7] esp6: Support RX checksum with crypto offload

2017-08-01 Thread ilant
From: Ilan Tayari Keep the device's reported ip_summed indication in case crypto was offloaded by the device. Subtract the csum values of the stripped parts (esp header+iv, esp trailer+auth_data) to keep value correct. Note: CHECKSUM_COMPLETE should be indicated only if skb->csum has the post-de

[PATCH] Adding Agile-SD TCP module and modifying Kconfig and Makefile to configure the kernel for this new module to configure the kernel for this new module.

2017-08-01 Thread mohamedalrshah
From: Mohamed Alrshah --- net/ipv4/Kconfig | 15 net/ipv4/Makefile | 1 + net/ipv4/tcp_agilesd.c | 221 + 3 files changed, 237 insertions(+) create mode 100755 net/ipv4/tcp_agilesd.c diff --git a/net/ipv4/Kconfig b/net/ipv4/Kco

[PATCH net-next 3/7] xfrm6: Fix CHECKSUM_COMPLETE after IPv6 header push

2017-08-01 Thread ilant
From: Yossi Kuperman xfrm6_transport_finish rebuilds the IPv6 header based on the original one and pushes it back without fixing skb->csum. Therefore, CHECKSUM_COMPLETE is no longer valid and the packet gets dropped. Fix skb->csum by calling skb_postpush_rcsum. Note: A valid IPv4 header has che

[PATCH net-next 4/7] esp6: Fix RX checksum after header pull

2017-08-01 Thread ilant
From: Yossi Kuperman Both ip6_input_finish (non-GRO) and esp6_gro_receive (GRO) strip the IPv6 header without adjusting skb->csum accordingly. As a result CHECKSUM_COMPLETE breaks and "hw csum failure" is written to the kernel log by netdev_rx_csum_fault (dev.c). Fix skb->csum by substracting th

[PATCH net-next 0/7] IPSec offload improvements

2017-08-01 Thread ilant
From: Ilan Tayari Hi Steffen, This patchset introduces several improvements to IPSec offload. We would like to see these merged in 4.14. Patches 1-4 add RX checksum offload support. This gives a big performance boost. These patches have been submitted before but were not merged. Note that patch

[PATCH net-next 5/7] xfrm: Auto-load xfrm offload modules

2017-08-01 Thread ilant
From: Ilan Tayari IPSec crypto offload depends on the protocol-specific offload module (such as esp_offload.ko). When the user installs an SA with crypto-offload, load the offload module automatically, in the same way that the protocol module is loaded (such as esp.ko) Signed-off-by: Ilan Tayar

[PATCH net-next 7/7] net: Allow IPsec GSO for local sockets

2017-08-01 Thread ilant
From: Steffen Klassert This patch allows local sockets to make use of XFRM GSO code path. Signed-off-by: Steffen Klassert Signed-off-by: Ilan Tayari --- include/net/xfrm.h | 19 +++ net/core/sock.c| 2 +- 2 files changed, 20 insertions(+), 1 deletion(-) diff --git a/incl

[PATCH net-next 6/7] xfrm: Clear RX SKB secpath xfrm_offload

2017-08-01 Thread ilant
From: Ilan Tayari If an incoming packet undergoes XFRM crypto-offload, its secpath is filled with xfrm_offload struct denoting offload information. If the SKB is then forwarded to a device which supports crypto- offload, the stack wrongfully attempts to offload it (even though the output SA may

[PATCH v3] ss: Enclose IPv6 address in brackets

2017-08-01 Thread Florian Lehner
This updated patch adds support for RFC2732 IPv6 address format with brackets for the tool ss. It implements the suggestion by Phil Sutter to use a further value, whether an address was resolved to a hostname. Signed-off-by: Lehner Florian --- include/utils.h | 10 +++--- lib/utils.c | 1

Re: [PATCH v2] ravb: add wake-on-lan support via magic packet

2017-08-01 Thread Niklas Söderlund
Hi Sergei, Thanks for your feedback! On 2017-07-31 22:47:12 +0300, Sergei Shtylyov wrote: > Hello! > > On 07/30/2017 05:06 PM, Niklas Söderlund wrote: > > > WoL is enabled in the suspend callback by setting MagicPacket detection > > and disabling all interrupts expect MagicPacket. In the resume

Re: [PATCH net-next RFC 0/6] Configure cloud filters in i40e via tc/flower classifier

2017-08-01 Thread Jamal Hadi Salim
On 17-07-31 08:36 PM, Amritha Nambiar wrote: This patch series enables configuring cloud filters in i40e using the tc/flower classifier. The only tc-filter action supported is to redirect packets to a traffic class on the same device. The tc/mirred:redirect action is extended to accept a traffic

[PATCH v3 2/2] ravb: add workaround for clock when resuming with WoL enabled

2017-08-01 Thread Niklas Söderlund
The renesas-cpg-mssr clock driver are not yet aware of PSCI sleep where power is cut to the SoC. When resuming from this state with WoL enabled the enable count of the ravb clock is 1 and the clock driver thinks the clock is already on when PM core enables the clock and increments the enable count

[PATCH v3 1/2] ravb: add wake-on-lan support via magic packet

2017-08-01 Thread Niklas Söderlund
WoL is enabled in the suspend callback by setting MagicPacket detection and disabling all interrupts expect MagicPacket. In the resume path the driver needs to reset the hardware to rearm the WoL logic, this prevents the driver from simply restoring the registers and to take advantage of that ravb

[PATCH v3 0/2] ravb: add wake-on-lan support via magic packet

2017-08-01 Thread Niklas Söderlund
WoL is enabled in the suspend callback by setting MagicPacket detection and disabling all interrupts expect MagicPacket. In the resume path the driver needs to reset the hardware to rearm the WoL logic, this prevents the driver from simply restoring the registers and to take advantage of that ravb

Re: [PATCH 1/6] [net-next]net: sched: act_mirred: Extend redirect action to accept a traffic class

2017-08-01 Thread Jamal Hadi Salim
On 17-07-31 08:37 PM, Amritha Nambiar wrote: The Mirred/redirect action is extended to forward to a traffic class on the device. The traffic class index needs to be provided in addition to the device's ifindex. Example: # tc filter add dev eth0 protocol ip parent : prio 1 flower\ dst_ip 1

[PATCH net 0/2] lan78xx: Fixes to lan78xx driver

2017-08-01 Thread Nisar.Sayed
From: Nisar Sayed This series of patches are for lan78xx driver. These patches fixes potential issues associated with lan78xx driver Nisar Sayed (2): USB fast connect/disconnect crash fix Fix to handle hard_header_len update drivers/net/usb/lan78xx.c | 18 +- 1 file change

[PATCH net 1/2] lan78xx: USB fast connect/disconnect crash fix

2017-08-01 Thread Nisar.Sayed
From: Nisar Sayed USB fast connect/disconnect crash fix When USB plugged/unplugged at fast rate, lan78xx_mdio_init() in lan78xx_bind() failing case is not handled. Whenever lan78xx_mdio_init() failed, dev->mdiobus will be freed, however since lan78xx_bind() not consider as error and try to proc

[PATCH net 2/2] lan78xx: Fix to handle hard_header_len update

2017-08-01 Thread Nisar.Sayed
From: Nisar Sayed Fix to handle hard_header_len update When ifconfig up/down sequence is initiated hard_header_len get updated incrementally for each ifconfig up /down sequence, this leads invalid hard_header_len, moving to lan78xx_bind to have one time update of hard_header_len addresses the is

Re: [PATCH 1/6] [net-next]net: sched: act_mirred: Extend redirect action to accept a traffic class

2017-08-01 Thread Jamal Hadi Salim
On 17-07-31 08:37 PM, Amritha Nambiar wrote: The Mirred/redirect action is extended to forward to a traffic class on the device. The traffic class index needs to be provided in addition to the device's ifindex. Example: # tc filter add dev eth0 protocol ip parent : prio 1 flower\ dst_ip 1

Re: [PATCH net] mcs7780: Silence uninitialized variable warning

2017-08-01 Thread Dan Carpenter
On Mon, Jul 31, 2017 at 10:37:16AM -0700, David Miller wrote: > From: Dan Carpenter > Date: Mon, 31 Jul 2017 10:41:40 +0300 > > > On Sat, Jul 29, 2017 at 11:28:55PM -0700, David Miller wrote: > >> From: Dan Carpenter > >> Date: Fri, 28 Jul 2017 17:45:11 +0300 > >> > >> > -__u16 rval; >

Re: [PATCH 3/6] [net-next]net: i40e: Extend set switch config command to accept cloud filter mode

2017-08-01 Thread Jamal Hadi Salim
On 17-07-31 08:37 PM, Amritha Nambiar wrote: Add definitions for L4 filters and switch modes based on cloud filters modes and extend the set switch config command to include the additional cloud filter mode. "Cloud filters"? Seriously? Is "enteprise" the next one? ;-> cheers, jamal

[PATCH 0/1 v3 nf-next] constify nf_conntrack_l3/4proto parameters

2017-08-01 Thread Julia Lawall
When a nf_conntrack_l3/4proto parameter is not on the left hand side of an assignment, its address is not taken, and it is not passed to a function that may modify its fields, then it can be declared as const. This change is useful from a documentation point of view, and can possibly facilitate ma

[PATCH 1/1 v3 nf-next] netfilter: constify nf_conntrack_l3/4proto parameters

2017-08-01 Thread Julia Lawall
When a nf_conntrack_l3/4proto parameter is not on the left hand side of an assignment, its address is not taken, and it is not passed to a function that may modify its fields, then it can be declared as const. This change is useful from a documentation point of view, and can possibly facilitate ma

Re: [PATCH 6/6] [net-next]net: i40e: Enable cloud filters in i40e via tc/flower classifier

2017-08-01 Thread Jamal Hadi Salim
On 17-07-31 08:38 PM, Amritha Nambiar wrote: This patch enables tc-flower based hardware offloads. tc/flower filter provided by the kernel is configured as driver specific cloud filter. The patch implements functions and admin queue commands needed to support cloud filters in the driver and adds

Re: [PATCH net-next v12 0/4] net sched actions: improve dump performance

2017-08-01 Thread Jamal Hadi Salim
On 17-07-31 11:54 PM, Stephen Hemminger wrote: On Mon, 31 Jul 2017 08:06:42 -0400 Jamal Hadi Salim wrote: [..] Please cleanup and resubmit for net-next. Will do. The header files have been updated in iproute2 net-next branch. When does net-next show up? I noticed some changes - examp

RE: [PATCH] ss: Enclose IPv6 address in brackets

2017-08-01 Thread David Laight
From: Florian Lehner > Sent: 29 July 2017 13:29 > This patch adds support for RFC2732 IPv6 address format with brackets > for the tool ss. So output for ss changes from > 2a00:1450:400a:804::200e:443 to [2a00:1450:400a:804::200e]:443 for IPv6 > addresses with attached port number. > > Signed-off-b

Re: [PATCH 1/6] [net-next]net: sched: act_mirred: Extend redirect action to accept a traffic class

2017-08-01 Thread Jiri Pirko
Tue, Aug 01, 2017 at 02:37:37AM CEST, amritha.namb...@intel.com wrote: >The Mirred/redirect action is extended to forward to a traffic >class on the device. The traffic class index needs to be >provided in addition to the device's ifindex. > >Example: ># tc filter add dev eth0 protocol ip parent ff

[PATCH nf-next] netfilter: constify nf_loginfo structures

2017-08-01 Thread Julia Lawall
The nf_loginfo structures are only passed as the seventh argument to nf_log_trace, which is declared as const or stored in a local const variable. Thus the nf_loginfo structures themselves can be const. Done with the help of Coccinelle. // @r disable optional_qualifier@ identifier i; position p

[PATCH v2 net-next 1/3] net: dsa: lan9303: Refactor lan9303_xxx_packet_processing()

2017-08-01 Thread Egil Hjelmeland
lan9303_enable_packet_processing, lan9303_disable_packet_processing() Pass port number (0,1,2) as parameter instead of port offset. Because other functions in the module pass port numbers. And to enable simplifications in following patch. Plus replaced a constant 0x400 with LAN9303_SWITCH_PORT_REG

[PATCH v2 net-next 3/3] net: dsa: lan9303: Simplify lan9303_xxx_packet_processing() usage

2017-08-01 Thread Egil Hjelmeland
Simplify usage of lan9303_enable_packet_processing, lan9303_disable_packet_processing() Signed-off-by: Egil Hjelmeland --- drivers/net/dsa/lan9303-core.c | 24 ++-- 1 file changed, 10 insertions(+), 14 deletions(-) diff --git a/drivers/net/dsa/lan9303-core.c b/drivers/net/ds

[PATCH v2 net-next 0/3] Refactor lan9303_xxx_packet_processing

2017-08-01 Thread Egil Hjelmeland
This series is purely non functional. It changes the lan9303_enable_packet_processing, lan9303_disable_packet_processing() to pass port number (0,1,2) as parameter instead of port offset. This aligns them with other functions in the module, and makes it possible to simplify the code. First patch:

[PATCH v2 net-next 2/3] net: dsa: lan9303: define LAN9303_NUM_PORTS 3

2017-08-01 Thread Egil Hjelmeland
Will be used instead of '3' in upcomming patches. Signed-off-by: Egil Hjelmeland --- drivers/net/dsa/lan9303-core.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/dsa/lan9303-core.c b/drivers/net/dsa/lan9303-core.c index 4c514d3b9f68..2a3c6bf473dd 100644 --- a/drivers/net/dsa/

Re: [PATCH v2 net-next 2/3] net: dsa: lan9303: define LAN9303_NUM_PORTS 3

2017-08-01 Thread Juergen Borleis
Hi Egil, On Tuesday 01 August 2017 13:14:38 Egil Hjelmeland wrote: > Will be used instead of '3' in upcomming patches. > > Signed-off-by: Egil Hjelmeland > --- > drivers/net/dsa/lan9303-core.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/net/dsa/lan9303-core.c > b/drivers/n

[PATCH net-next] net: bcmgenet: drop COMPILE_TEST dependency

2017-08-01 Thread Arnd Bergmann
The last patch added the dependency on 'OF && HAS_IOMEM' but left COMPILE_TEST as an alternative, which kind of defeats the purpose of adding the dependency, we still get randconfig build warnings: warning: (NET_DSA_BCM_SF2 && BCMGENET) selects MDIO_BCM_UNIMAC which has unmet direct dependencies

RE: [PATCH net 3/3] tcp: fix xmit timer to only be reset if data ACKed/SACKed

2017-08-01 Thread maowenan
> -Original Message- > From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org] > On Behalf Of Neal Cardwell > Sent: Tuesday, August 01, 2017 10:58 AM > To: David Miller > Cc: netdev@vger.kernel.org; Neal Cardwell; Yuchung Cheng; Nandita Dukkipati > Subject: [PATCH net 3/3

Re: [PATCH v2 net-next 2/3] net: dsa: lan9303: define LAN9303_NUM_PORTS 3

2017-08-01 Thread Egil Hjelmeland
On 01. aug. 2017 13:49, Juergen Borleis wrote: Hi Egil, On Tuesday 01 August 2017 13:14:38 Egil Hjelmeland wrote: Will be used instead of '3' in upcomming patches. +#define LAN9303_NUM_PORTS 3 + Maybe we should put this macro into a shared location because in "net/dsa/tag_lan9303.c" there i

Re: [PATCH v3 1/2] ravb: add wake-on-lan support via magic packet

2017-08-01 Thread Sergei Shtylyov
Hello! On 08/01/2017 01:14 PM, Niklas Söderlund wrote: WoL is enabled in the suspend callback by setting MagicPacket detection and disabling all interrupts expect MagicPacket. In the resume path the driver needs to reset the hardware to rearm the WoL logic, this prevents the driver from simply

Re: [PATCH v3 2/2] ravb: add workaround for clock when resuming with WoL enabled

2017-08-01 Thread Sergei Shtylyov
On 08/01/2017 01:14 PM, Niklas Söderlund wrote: The renesas-cpg-mssr clock driver are not yet aware of PSCI sleep where power is cut to the SoC. When resuming from this state with WoL enabled the enable count of the ravb clock is 1 and the clock driver thinks the clock is already on when PM core

Re: [PATCH v2 net-next 2/3] net: dsa: lan9303: define LAN9303_NUM_PORTS 3

2017-08-01 Thread Andrew Lunn
On Tue, Aug 01, 2017 at 02:31:44PM +0200, Egil Hjelmeland wrote: > On 01. aug. 2017 13:49, Juergen Borleis wrote: > >Hi Egil, > > > >On Tuesday 01 August 2017 13:14:38 Egil Hjelmeland wrote: > >>Will be used instead of '3' in upcomming patches. > >> > >> > >>+#define LAN9303_NUM_PORTS 3 > >>+ > > >

Re: [PATCH v2 net-next 1/3] net: dsa: lan9303: Refactor lan9303_xxx_packet_processing()

2017-08-01 Thread Andrew Lunn
> @@ -704,7 +710,7 @@ static void lan9303_get_ethtool_stats(struct dsa_switch > *ds, int port, > unsigned int u, poff; > int ret; > > - poff = port * 0x400; > + poff = LAN9303_SWITCH_PORT_REG(port, 0); > > for (u = 0; u < ARRAY_SIZE(lan9303_mib); u++) { >

[PATCH net 4/4] net/mlx4_core: Fixes missing capability bit in flags2 capability dump

2017-08-01 Thread Tariq Toukan
From: Jack Morgenstein The cited commit introduced the following new enum value in file include/linux/mlx4/device.h: QUERY_DEV_CAP_DIAG_RPRT_PER_PORT However, it failed to introduce a corresponding entry in function dump_dev_cap_flags2() for outputting a line in the message log when this ca

[PATCH net 1/4] net/mlx4_en: Fix wrong indication of Wake-on-LAN (WoL) support

2017-08-01 Thread Tariq Toukan
From: Inbar Karmy Currently when WoL is supported but disabled, ethtool reports: "Supports Wake-on: d". Fix the indication of Wol support, so that the indication remains "g" all the time if the NIC supports WoL. Tested: As accepted, when NIC supports WoL- ethtool reports: Supports Wake-o

[PATCH net 2/4] net/mlx4_core: Fix sl_to_vl_change bit offset in flags2 dump

2017-08-01 Thread Tariq Toukan
From: Jack Morgenstein The index value in function dump_dev_cap_flags2() for outputting "sl to vl mapping table change event support" needs to be consistent with the value of the enumerated constant MLX4_DEV_CAP_FLAG2_SL_TO_VL_CHANGE_EVENT defined in file include/linux/mlx4_device.h The change h

[PATCH net 3/4] net/mlx4_core: Fix namespace misalignment in QinQ VST support commit

2017-08-01 Thread Tariq Toukan
From: Jack Morgenstein The cited commit introduced the following new enum value in file include/linux/mlx4/device.h: MLX4_DEV_CAP_FLAG2_SVLAN_BY_QP However the value of MLX4_DEV_CAP_FLAG2_SVLAN_BY_QP needs to stay consistent with the value used in another namespace in function dump_dev_cap_

Re: [PATCH v2 net-next 2/3] net: dsa: lan9303: define LAN9303_NUM_PORTS 3

2017-08-01 Thread Egil Hjelmeland
On 01. aug. 2017 15:27, Andrew Lunn wrote: On Tue, Aug 01, 2017 at 02:31:44PM +0200, Egil Hjelmeland wrote: On 01. aug. 2017 13:49, Juergen Borleis wrote: Hi Egil, On Tuesday 01 August 2017 13:14:38 Egil Hjelmeland wrote: Will be used instead of '3' in upcomming patches. +#define LAN9303_NU

[PATCH net 0/4] mlx4 misc fixes

2017-08-01 Thread Tariq Toukan
Hi Dave, This patchset contains misc bug fixes from the team to the mlx4 Core and Eth drivers. Patch 1 by Inbar fixes a wrong ethtool indication for Wake-on-LAN. The other 3 patches by Jack add a missing capability description, and fixes the off-by-1 misalignment for the following capabilities de

Re: [PATCH v2 net-next 1/3] net: dsa: lan9303: Refactor lan9303_xxx_packet_processing()

2017-08-01 Thread Egil Hjelmeland
On 01. aug. 2017 15:39, Andrew Lunn wrote: @@ -704,7 +710,7 @@ static void lan9303_get_ethtool_stats(struct dsa_switch *ds, int port, unsigned int u, poff; int ret; - poff = port * 0x400; + poff = LAN9303_SWITCH_PORT_REG(port, 0); for (u = 0; u < ARRAY_SIZE(lan930

Re: [PATCH v2 net-next 1/3] net: dsa: lan9303: Refactor lan9303_xxx_packet_processing()

2017-08-01 Thread Andrew Lunn
On Tue, Aug 01, 2017 at 03:50:14PM +0200, Egil Hjelmeland wrote: > On 01. aug. 2017 15:39, Andrew Lunn wrote: > >>@@ -704,7 +710,7 @@ static void lan9303_get_ethtool_stats(struct dsa_switch > >>*ds, int port, > >>unsigned int u, poff; > >>int ret; > >>- poff = port * 0x400; > >>+ poff

[PATCH net-next] tcp: tcp_data_queue() cleanup

2017-08-01 Thread Eric Dumazet
From: Eric Dumazet Commit c13ee2a4f03f ("tcp: reindent two spots after prequeue removal") removed code in tcp_data_queue(). We can go a little farther, removing an always true test, and removing initializers for fragstolen and eaten variables. Signed-off-by: Eric Dumazet Cc: Florian Westphal

Re: [PATCH RFC, iproute2] tc/mirred: Extend the mirred/redirect action to accept additional traffic class parameter

2017-08-01 Thread Roman Mashak
Amritha Nambiar writes: [...] > @@ -72,6 +73,8 @@ parse_direction(struct action_util *a, int *argc_p, char > ***argv_p, > struct tc_mirred p = {}; > struct rtattr *tail; > char d[16] = {}; > + __u32 flags = 0; > + __u8 tc; > > while (argc > 0) { > > @@ -142,6

Re: [PATCH net-next 01/11] net: dsa: make EEE ops optional

2017-08-01 Thread Andrew Lunn
Hi Vivien > @@ -646,38 +646,42 @@ static int dsa_slave_set_eee(struct net_device *dev, > struct ethtool_eee *e) > { > struct dsa_slave_priv *p = netdev_priv(dev); > struct dsa_switch *ds = p->dp->ds; > - int ret; > + int err = -ENODEV; > > - if (!ds->ops->set_eee) > -

Re: [PATCH v3] ss: Enclose IPv6 address in brackets

2017-08-01 Thread Phil Sutter
On Tue, Aug 01, 2017 at 12:05:13PM +0200, Florian Lehner wrote: [...] > @@ -114,9 +114,13 @@ int addr64_n2a(__u64 addr, char *buff, size_t len); > int af_bit_len(int af); > int af_byte_len(int af); > > -const char *format_host_r(int af, int len, const void *addr, > -c

RE: [PATCH net-next 00/10] net: l3mdev: Support for sockets bound to enslaved device

2017-08-01 Thread David Laight
From: David Ahern > Sent: 01 August 2017 04:13 ... > Existing code for socket lookups already pass in 6+ arguments. Rather > than add another for the enslaved device index, the existing lookups > are converted to use a new sk_lookup struct. From there, the enslaved > device index becomes another el

[PATCH net] xfrm: fix null pointer dereference on state and tmpl sort

2017-08-01 Thread Koichiro Den
Creating sub policy that matches the same outer flow as main policy does leads to a null pointer dereference if the outer mode's family is ipv4. For userspace compatibility, this patch just eliminates the crash i.e., does not introduce any new sorting rule, which would fruitlessly affect all but th

Re: [PATCH net 3/3] tcp: fix xmit timer to only be reset if data ACKed/SACKed

2017-08-01 Thread Neal Cardwell
On Tue, Aug 1, 2017 at 8:20 AM, maowenan wrote: > > + /* If needed, reset TLP/RTO timer; RACK may later override this. */ > [Mao Wenan] I have question about RACK, if there is no RACK feature > in lower version, who can clear this flag:FLAG_SET_XMIT_TIMER? In the comment, "this" is referring

Re: [PATCH net-next 10/11] net: dsa: mv88e6xxx: remove EEE support

2017-08-01 Thread Andrew Lunn
On Mon, Jul 31, 2017 at 06:17:18PM -0400, Vivien Didelot wrote: > The PHY's EEE settings are already accessed by the DSA layer through the > Marvell PHY driver and there is nothing to be done for switch's MACs. I'm confused, or missing something. Does not patch #1 mean that if the DSA driver does

Re: [PATCH net-next 00/11] net: dsa: rework EEE support

2017-08-01 Thread Andrew Lunn
On Mon, Jul 31, 2017 at 06:17:08PM -0400, Vivien Didelot wrote: > EEE implies configuring the port's PHY and MAC of both ends of the wire. > > The current EEE support in DSA mixes PHY and MAC configuration, which is > bad because PHYs must be configured through a proper PHY driver. The DSA > switc

Re: [PATCH RFC 08/13] phylink: add phylink infrastructure

2017-08-01 Thread Andrew Lunn
On Tue, Jul 25, 2017 at 03:03:13PM +0100, Russell King wrote: > The link between the ethernet MAC and its PHY has become more complex > as the interface evolves. This is especially true with serdes links, > where the part of the PHY is effectively integrated into the MAC. > > Serdes links can be

Re: [PATCH RFC 09/13] sfp: add sfp-bus to bridge between network devices and sfp cages

2017-08-01 Thread Andrew Lunn
On Tue, Jul 25, 2017 at 03:03:18PM +0100, Russell King wrote: > Signed-off-by: Russell King Reviewed-by: Andrew Lunn Andrew

Re: [PATCH net 2/3] tcp: enable xmit timer fix by having TLP use time when RTO should fire

2017-08-01 Thread Neal Cardwell
On Tue, Aug 1, 2017 at 3:22 AM, Eric Dumazet wrote: > On Mon, 2017-07-31 at 22:58 -0400, Neal Cardwell wrote: >> @@ -2418,13 +2418,9 @@ bool tcp_schedule_loss_probe(struct sock *sk) >> timeout = max_t(u32, timeout, msecs_to_jiffies(10)); >> >> /* If RTO is shorter, just schedule TLP in

Re: [PATCH RFC 00/13] phylink and sfp support

2017-08-01 Thread Andrew Lunn
On Tue, Jul 25, 2017 at 03:01:39PM +0100, Russell King - ARM Linux wrote: > Hi, > > This patch series introduces generic support for SFP sockets found on > various Marvell based platforms. The idea here is to provide common > SFP socket support which can be re-used by network drivers as > appropr

Re: [PATCH] ss: Enclose IPv6 address in brackets

2017-08-01 Thread Stephen Hemminger
On Tue, 1 Aug 2017 11:11:03 + David Laight wrote: > From: Florian Lehner > > Sent: 29 July 2017 13:29 > > This patch adds support for RFC2732 IPv6 address format with brackets > > for the tool ss. So output for ss changes from > > 2a00:1450:400a:804::200e:443 to [2a00:1450:400a:804::200e]:443

Re: [PATCH v2 net-next 1/3] net: dsa: lan9303: Refactor lan9303_xxx_packet_processing()

2017-08-01 Thread Egil Hjelmeland
On 01. aug. 2017 16:02, Andrew Lunn wrote: On Tue, Aug 01, 2017 at 03:50:14PM +0200, Egil Hjelmeland wrote: On 01. aug. 2017 15:39, Andrew Lunn wrote: @@ -704,7 +710,7 @@ static void lan9303_get_ethtool_stats(struct dsa_switch *ds, int port, unsigned int u, poff; int ret; -

Re: [RFC net-next] net ipv6: convert fib6_table rwlock to a percpu lock

2017-08-01 Thread Stephen Hemminger
On Mon, 31 Jul 2017 19:57:04 -0700 Shaohua Li wrote: > On Mon, Jul 31, 2017 at 04:10:07PM -0700, Stephen Hemminger wrote: > > On Mon, 31 Jul 2017 10:18:57 -0700 > > Shaohua Li wrote: > > > > > From: Shaohua Li > > > > > > In a syn flooding test, the fib6_table rwlock is a significant > > >

Re: [PATCH net-next 00/10] net: l3mdev: Support for sockets bound to enslaved device

2017-08-01 Thread David Ahern
On 8/1/17 8:15 AM, David Laight wrote: > From: David Ahern >> Sent: 01 August 2017 04:13 > ... >> Existing code for socket lookups already pass in 6+ arguments. Rather >> than add another for the enslaved device index, the existing lookups >> are converted to use a new sk_lookup struct. From there,

Re: [PATCH] Adding Agile-SD TCP module and modifying Kconfig and Makefile to configure the kernel for this new module to configure the kernel for this new module.

2017-08-01 Thread Stephen Hemminger
On Tue, 1 Aug 2017 17:50:05 +0800 mohamedalrshah wrote: > From: Mohamed Alrshah > Please add more background on Agile-SD in the email commit message. > +static struct tcp_congestion_ops agilesdtcp __read_mostly = { > + .init = agilesdtcp_init, > + .ssthresh = agilesd

RE: [PATCH RFC, iproute2] tc/mirred: Extend the mirred/redirect action to accept additional traffic class parameter

2017-08-01 Thread David Laight
From: Stephen Hemminger > Sent: 01 August 2017 04:52 > On Mon, 31 Jul 2017 17:40:50 -0700 > Amritha Nambiar wrote: > The concept is fine, bu t the code looks different than the rest which > is never a good sign. > > > > + if ((argc > 0) && (matches(*argv, "tc") == 0)) {

[PATCH iproute2 v2] ip: change flag names to an array

2017-08-01 Thread Stephen Hemminger
For the most of the address flags, use a table of values rather than open coding every value. This allows for easier inevitable expansion of flags. This also fixes the missing stable-privacy flag. Signed-off-by: Stephen Hemminger --- v2 - use name/value table rather than assuming order han

Re: [PATCH net-next 10/11] net: dsa: mv88e6xxx: remove EEE support

2017-08-01 Thread Vivien Didelot
Hi Andrew, Andrew Lunn writes: > On Mon, Jul 31, 2017 at 06:17:18PM -0400, Vivien Didelot wrote: >> The PHY's EEE settings are already accessed by the DSA layer through the >> Marvell PHY driver and there is nothing to be done for switch's MACs. > > I'm confused, or missing something. Does not p

[PATCH iproute2] netns: make /var/run/netns bind-mount recursive

2017-08-01 Thread Casey Callendrello
When ip netns {add|delete} is first run, it bind-mounts /var/run/netns on top of itself, then marks it as shared. However, if there are already bind-mounts in the directory from other tools, these would not be propagated. Fix this by recursively bind-mounting. Signed-off-by: Casey Callendrello --

[PATCH 2/2] usb: qmi_wwan: add D-Link DWM-222 device ID

2017-08-01 Thread Hector Martin
Cc: sta...@vger.kernel.org Signed-off-by: Hector Martin --- drivers/net/usb/qmi_wwan.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c index 5894e3c9468f..ff6f39fe6c00 100644 --- a/drivers/net/usb/qmi_wwan.c +++ b/drivers/net/usb/qmi_wwa

Re: [PATCH 1/2] ipv6: constify inet6_protocol structures

2017-08-01 Thread David Ahern
On 7/31/17 11:59 PM, Julia Lawall wrote: >> This change breaks the kernel if one of these sysctls are changed: >> tcp_early_demux, udp_early_demux > > The other patch in the series has the same problem and should be dropped > too. > > julia Julia: are you going to send a revert patch? Right now

Re: [PATCH net-next 10/11] net: dsa: mv88e6xxx: remove EEE support

2017-08-01 Thread Andrew Lunn
On Tue, Aug 01, 2017 at 11:36:13AM -0400, Vivien Didelot wrote: > Hi Andrew, > > Andrew Lunn writes: > > > On Mon, Jul 31, 2017 at 06:17:18PM -0400, Vivien Didelot wrote: > >> The PHY's EEE settings are already accessed by the DSA layer through the > >> Marvell PHY driver and there is nothing to

Re: [PATCH 1/2] ipv6: constify inet6_protocol structures

2017-08-01 Thread Julia Lawall
On Tue, 1 Aug 2017, David Ahern wrote: > On 7/31/17 11:59 PM, Julia Lawall wrote: > >> This change breaks the kernel if one of these sysctls are changed: > >> tcp_early_demux, udp_early_demux > > > > The other patch in the series has the same problem and should be dropped > > too. > > > > julia

Re: [PATCH v3] ss: Enclose IPv6 address in brackets

2017-08-01 Thread Florian Lehner
On 08/01/2017 04:11 PM, Phil Sutter wrote: > On Tue, Aug 01, 2017 at 12:05:13PM +0200, Florian Lehner wrote: > [...] >> @@ -114,9 +114,13 @@ int addr64_n2a(__u64 addr, char *buff, size_t len); >> int af_bit_len(int af); >> int af_byte_len(int af); >> >> -const char *format_host_r(int af, int le

Re: [PATCH net-next] net: bcmgenet: drop COMPILE_TEST dependency

2017-08-01 Thread Florian Fainelli
On 08/01/2017 04:50 AM, Arnd Bergmann wrote: > The last patch added the dependency on 'OF && HAS_IOMEM' but left > COMPILE_TEST as an alternative, which kind of defeats the purpose > of adding the dependency, we still get randconfig build warnings: > > warning: (NET_DSA_BCM_SF2 && BCMGENET) select

Re: [PATCH net-next 10/11] net: dsa: mv88e6xxx: remove EEE support

2017-08-01 Thread Florian Fainelli
On 08/01/2017 09:06 AM, Andrew Lunn wrote: > On Tue, Aug 01, 2017 at 11:36:13AM -0400, Vivien Didelot wrote: >> Hi Andrew, >> >> Andrew Lunn writes: >> >>> On Mon, Jul 31, 2017 at 06:17:18PM -0400, Vivien Didelot wrote: The PHY's EEE settings are already accessed by the DSA layer through the

[iproute PATCH] Really fix get_addr() and get_prefix() error messages

2017-08-01 Thread Phil Sutter
Both functions take the desired address family as a parameter. So using that to notify the user what address family was expected is correct, unlike using dst->family which will tell the user only what address family was specified. The situation which commit 334af76143368 tried to fix was when 'ip'

Re: [PATCH net-next 10/11] net: dsa: mv88e6xxx: remove EEE support

2017-08-01 Thread Vivien Didelot
Hi Andrew, Andrew Lunn writes: >> >> The PHY's EEE settings are already accessed by the DSA layer through the >> >> Marvell PHY driver and there is nothing to be done for switch's MACs. >> > >> > I'm confused, or missing something. Does not patch #1 mean that if the >> > DSA driver does not have

[RFC PATCH v2 0/2] nb8800 suspend/resume support

2017-08-01 Thread Mason
Hello, I need suspend/resume support in the nb8800 driver. On tango platforms, suspend loses all context (MMIO registers). To make the task easy, we just close the device on suspend, and open it again on resume. This requires properly resetting the HW on resume. Patch 1 moves all the HW init to n

[RFC PATCH v2 1/2] net: ethernet: nb8800: Reset HW block in ndo_open

2017-08-01 Thread Mason
Move all HW initializations to nb8800_init. This provides the basis for suspend/resume support. --- drivers/net/ethernet/aurora/nb8800.c | 50 +--- drivers/net/ethernet/aurora/nb8800.h | 1 + 2 files changed, 25 insertions(+), 26 deletions(-) diff --git a/drivers/

[RFC PATCH v2 2/2] net: ethernet: nb8800: Add suspend/resume support

2017-08-01 Thread Mason
Wrappers around nb8800_stop and nb8800_open. --- drivers/net/ethernet/aurora/nb8800.c | 23 ++- 1 file changed, 22 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/aurora/nb8800.c b/drivers/net/ethernet/aurora/nb8800.c index aa18ea25d91f..607064a6d7a1 100644 ---

[PATCH 0/2] Revert "ipv6: constify inet6_protocol structures"

2017-08-01 Thread Julia Lawall
inet6_add_protocol and inet6_del_protocol include casts that remove the effect of the const annotation on their parameter, leading to possible runtime crashes.

Re: [PATCH v6 net-next] net: systemport: Support 64bit statistics

2017-08-01 Thread Florian Fainelli
On 07/31/2017 06:18 PM, Jianming.qiao wrote: > When using Broadcom Systemport device in 32bit Platform, ifconfig can > only report up to 4G tx,rx status, which will be wrapped to 0 when the > number of incoming or outgoing packets exceeds 4G, only taking > around 2 hours in busy network environment

[PATCH 2/2] Revert "l2tp: constify inet6_protocol structures"

2017-08-01 Thread Julia Lawall
This reverts commit d04916a48ad4a3db892b664fa9c3a2a693c378ad. inet6_add_protocol and inet6_del_protocol include casts that remove the effect of the const annotation on their parameter, leading to possible runtime crashes. Reported-by: Eric Dumazet Signed-off-by: Julia Lawall --- net/l2tp/l2t

[PATCH 1/2] Revert "ipv6: constify inet6_protocol structures"

2017-08-01 Thread Julia Lawall
This reverts commit 3a3a4e3054137c5ff5d4d306ec834f6d25d7f95b. inet6_add_protocol and inet6_del_protocol include casts that remove the effect of the const annotation on their parameter, leading to possible runtime crashes. Reported-by: Eric Dumazet Signed-off-by: Julia Lawall --- net/ipv6/ip6

[PATCH v4] ss: Enclose IPv6 address in brackets

2017-08-01 Thread Florian Lehner
This updated patch adds support for RFC2732 IPv6 address format with brackets for the tool ss. Following the advice by David Laight I used strchr(). Also, IN6ADDR_ANY and INADDR_ANY will return "*". Signed-off-by: Lehner Florian --- misc/ss.c | 28 +--- 1 file changed,

Re: [PATCH 0/2] Revert "ipv6: constify inet6_protocol structures"

2017-08-01 Thread David Miller
From: Julia Lawall Date: Tue, 1 Aug 2017 18:27:27 +0200 > inet6_add_protocol and inet6_del_protocol include casts that remove the > effect of the const annotation on their parameter, leading to possible > runtime crashes. Series applied, thanks for following up on this.

Re: [PATCH net-next 4/6] tcp: remove header prediction

2017-08-01 Thread Neal Cardwell
On Sat, Jul 29, 2017 at 9:57 PM, Florian Westphal wrote: > @@ -5519,11 +5347,10 @@ void tcp_finish_connect(struct sock *sk, struct > sk_buff *skb) > if (sock_flag(sk, SOCK_KEEPOPEN)) > inet_csk_reset_keepalive_timer(sk, keepalive_time_when(tp)); > > - if (!tp->rx_opt

[iproute PATCH] iplink: Notify user if EEXIST error might be spurious

2017-08-01 Thread Phil Sutter
Back in the days when RTM_NEWLINK wasn't yet implemented, people had to rely upon kernel modules to create (virtual) interfaces for them. The number of those was usually defined via module parameter, and a sane default value was chosen. Now that iproute2 allows users to instantiate new interfaces a

  1   2   3   >