RE: [PATCH net-next] skbuff: Add BUG_ON in skb_init.

2017-08-09 Thread Yuan, Linyu (NSB - CN/Shanghai)
Original this function have return value but not used, and check allocate result internal, When I change this function to void return, I add this BUG_ON. > -Original Message- > From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org] > On Behalf Of Tonghao Zhang > Sent: T

[net-next:master 905/906] net/core/flow_dissector.c:448:18: error: 'struct net_device' has no member named 'dsa_ptr'; did you mean 'dn_ptr'?

2017-08-09 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master head: 7e1ecbcf79b2fdc7349da1bb90d6dadad1f9ac89 commit: 43e665287f931a167cd2eea3387efda901bff0ce [905/906] net-next: dsa: fix flow dissection config: x86_64-acpi-redef (attached as .config) compiler: gcc-6 (Debian

Re: [PATCH 0/4] net-next: dsa: fix flow dissection

2017-08-09 Thread Eric Dumazet
On Wed, 2017-08-09 at 22:52 -0700, David Miller wrote: > From: John Crispin > Date: Wed, 9 Aug 2017 14:41:15 +0200 > > > RPS and probably other kernel features are currently broken on some if not > > all DSA devices. The root cause of this is that skb_hash will call the > > flow_dissector. At th

[net-next:master 905/906] net/core/flow_dissector.c:448:18: error: 'struct net_device' has no member named 'dsa_ptr'

2017-08-09 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master head: 7e1ecbcf79b2fdc7349da1bb90d6dadad1f9ac89 commit: 43e665287f931a167cd2eea3387efda901bff0ce [905/906] net-next: dsa: fix flow dissection config: i386-randconfig-a1-201732 (attached as .config) compiler: gcc-5

Re: [PATCH net-next] skbuff: Add BUG_ON in skb_init.

2017-08-09 Thread Tonghao Zhang
Thanks a lot. I found it when reviewing this codes. and BUG_ON is added in the init_inodecache(). We may remove it or not ? diff --git a/net/socket.c b/net/socket.c index b332d1e..ebee3ee 100644 --- a/net/socket.c +++ b/net/socket.c @@ -296,7 +296,6 @@ static void init_inodecache(void)

Re: [PATCH 0/4] net-next: dsa: fix flow dissection

2017-08-09 Thread David Miller
From: John Crispin Date: Wed, 9 Aug 2017 14:41:15 +0200 > RPS and probably other kernel features are currently broken on some if not > all DSA devices. The root cause of this is that skb_hash will call the > flow_dissector. At this point the skb still contains the magic switch > header and the s

Re: [PATCH net-next] skbuff: Add BUG_ON in skb_init.

2017-08-09 Thread David Miller
From: Tonghao Zhang Date: Wed, 9 Aug 2017 05:04:38 -0700 > When initializing the skbuff SLAB cache, we should make > sure it is successful. Adding BUG_ON to check it and > init_inodecache() is in the same case. > > Signed-off-by: Tonghao Zhang > --- > net/core/skbuff.c | 2 ++ > 1 file change

Re: [PATCHv2] igmp: Fix regression caused by igmp sysctl namespace code.

2017-08-09 Thread David Miller
From: Nikolay Borisov Date: Wed, 9 Aug 2017 14:38:04 +0300 > Commit dcd87999d415 ("igmp: net: Move igmp namespace init to correct file") > moved the igmp sysctls initialization from tcp_sk_init to igmp_net_init. This > function is only called as part of per-namespace initialization, only if > CO

Re: [PATCH 0/2] net-next: mediatek: bring up QDMA RX ring 0

2017-08-09 Thread David Miller
From: John Crispin Date: Wed, 9 Aug 2017 12:09:30 +0200 > The MT7623 has several DMA rings. Inside the SW path, the core will use > the PDMA when receiving traffic. While bringing up the HW path we noticed > that the PPE requires the QDMA RX to also be brought up as it uses this > ring internall

Re: [PATCHv2 net] net: sched: set xt_tgchk_param par.nft_compat as 0 in ipt_init_target

2017-08-09 Thread David Miller
From: Xin Long Date: Wed, 9 Aug 2017 18:15:19 +0800 > Commit 55917a21d0cc ("netfilter: x_tables: add context to know if > extension runs from nft_compat") introduced a member nft_compat to > xt_tgchk_param structure. > > But it didn't set it's value for ipt_init_target. With unexpected > value

Re: [PATCH] net: atm: make atmdev_ops const

2017-08-09 Thread David Miller
From: Bhumika Goyal Date: Wed, 9 Aug 2017 15:02:08 +0530 > Make these const as they are only stored in the ops field of a atm_dev > structure, which is const. > Done using Coccinelle. > > Signed-off-by: Bhumika Goyal Applied.

Re: [PATCH] atm: make atmdev_ops const

2017-08-09 Thread David Miller
From: Bhumika Goyal Date: Wed, 9 Aug 2017 14:49:15 +0530 > Make these structures const as they are either passed to the function > atm_dev_register having the corresponding argument as const or stored in > the ops field of a atm_dev structure, which is also const. > Done using Coccinelle. > > S

Re: [PATCH] net: dsa: make dsa_switch_ops const

2017-08-09 Thread David Miller
From: Bhumika Goyal Date: Wed, 9 Aug 2017 10:34:15 +0530 > Make these structures const as they are only stored in the ops field of > a dsa_switch structure, which is const. > Done using Coccinelle. > > Signed-off-by: Bhumika Goyal Applied, thank you.

Re: [PATCH net-next] liquidio: napi cleanup

2017-08-09 Thread David Miller
From: Felix Manlunas Date: Tue, 8 Aug 2017 19:34:28 -0700 > From: Intiyaz Basha > > Disable napi when interface is going down. > Delete napi when destroying the interface. > > Signed-off-by: Intiyaz Basha > Signed-off-by: Felix Manlunas Applied, thanks.

Re: [PATCH net] geneve: maximum value of VNI cannot be used

2017-08-09 Thread David Miller
From: Girish Moodalbail Date: Tue, 8 Aug 2017 17:26:24 -0700 > Geneve's Virtual Network Identifier (VNI) is 24 bit long, so the range > of values for it would be from 0 to 16777215 (2^24 -1). However, one > cannot create a geneve device with VNI set to 16777215. This patch fixes > this issue. >

Re: unregister_netdevice: waiting for eth0 to become free. Usage count = 1

2017-08-09 Thread Wei Wang
Hi John, Is it possible to try the attached patch? I am not sure if it actually fixes the issue. But I think it is worth a try. Also, could you get me all the ipv6 routes when you plug in the usb using "ip -6 route show"? (If you have multiple routing tables configured, could you dump them all?)

Re: [PATCH net-next] net: ipv6: lower ndisc notifier priority below addrconf

2017-08-09 Thread David Miller
From: David Ahern Date: Tue, 8 Aug 2017 15:51:02 -0600 > ndisc_notify is used to send unsolicited neighbor advertisements > (e.g., on a link up). Currently, the ndisc notifier is run before the > addrconf notifer which means NA's are not sent for link-local addresses > which are added by the add

Re: [PATCH net v2] net: systemport: Fix software statistics for SYSTEMPORT Lite

2017-08-09 Thread David Miller
From: Florian Fainelli Date: Tue, 8 Aug 2017 14:45:09 -0700 > With SYSTEMPORT Lite we have holes in our statistics layout that make us > skip over the hardware MIB counters, bcm_sysport_get_stats() was not > taking that into account resulting in reporting 0 for all SW-maintained > statistics, fi

Regression: Bug 196547 - Since 4.12 - bonding module not working with wireless drivers

2017-08-09 Thread Kalle Valo
Hi Mahesh and Andy, James Feeney reported that there's a serious regression in bonding module since v4.12, it doesn't work with wireless drivers anymore as wireless drivers don't report the link speed via ethtool: https://bugzilla.kernel.org/show_bug.cgi?id=196547 In the bug report it's said tha

Re: [net 1/1] tipc: remove premature ESTABLISH FSM event at link synchronization

2017-08-09 Thread David Miller
From: Jon Maloy Date: Tue, 8 Aug 2017 22:23:56 +0200 > When a link between two nodes come up, both endpoints will initially > send out a STATE message to the peer, to increase the probability that > the peer endpoint also is up when the first traffic message arrives. > Thereafter, if the establis

Re: [PATCH net-next] ibmvnic: Correct 'unused variable' warning in build.

2017-08-09 Thread David Miller
From: Nathan Fontenot Date: Tue, 08 Aug 2017 15:26:18 -0500 > Commit a248878d7a1d ("ibmvnic: Check for transport event on driver resume") > removed the loop to kick irqs on driver resume but didn't remove the now > unused loop variable 'i'. > > Signed-off-by: Nathan Fontenot Applied.

Re: [PATCH net-next] ibmvnic: Clean up resources on probe failure

2017-08-09 Thread David Miller
From: Nathan Fontenot Date: Tue, 08 Aug 2017 14:28:45 -0500 > Ensure that any resources allocated during probe are released if the > probe of the driver fails. > > Signed-off-by: Nathan Fontenot Applied, but: > + > +ibmvnic_register_fail: > + device_remove_file(&dev->dev, &dev_attr_failov

Re: [PATCH v1 net] TCP_USER_TIMEOUT and tcp_keepalive should conform to RFC5482

2017-08-09 Thread Jerry Chu
On Wed, Aug 9, 2017 at 8:32 PM, Jerry Chu wrote: > On Wed, Aug 9, 2017 at 5:47 PM, Rao Shoaib wrote: >> >> >> On 08/09/2017 05:30 PM, David Miller wrote: >>> >>> From: Joe Smith >>> Date: Wed, 9 Aug 2017 17:20:32 -0700 >>> Making Linux conform to standards and behavior that is logical seems

[PATCH] bonding: require speed/duplex only for 802.3ad, alb and tlb

2017-08-09 Thread Andreas Born
The patch c4adfc822bf5 ("bonding: make speed, duplex setting consistent with link state") puts the link state to down if bond_update_speed_duplex() cannot retrieve speed and duplex settings. Assumably the patch was written with 802.3ad mode in mind which relies on link speed/duplex settings. For ot

Re: [PATCH v4 05/12] Documentation: net: phy: Add phy-is-internal binding

2017-08-09 Thread Chen-Yu Tsai
On Thu, Aug 10, 2017 at 8:20 AM, Andrew Lunn wrote: > On Wed, Aug 09, 2017 at 03:47:34PM -0700, Florian Fainelli wrote: >> On August 9, 2017 5:10:30 AM PDT, David Wu wrote: >> >Add the documentation for internal phy. A boolean property >> >indicates that a internal phy will be used. >> > >> >Sign

Re:Re: [PATCH net-next 1/1] driver: pptp: Remove unnecessary statements in pptp_sock_destruct

2017-08-09 Thread Gao Feng
At 2017-08-10 02:08:30, "Cong Wang" wrote: >On Wed, Aug 9, 2017 at 8:57 AM, wrote: >> From: Gao Feng >> >> In the commit ddab82821fa6 ("ppp: Fix a scheduling-while-atomic bug in >> del_chan"), I moved the synchronize_rcu() from del_chan() to pptp_release >> after del_chan() to avoid one schedu

Re: [PATCH v1 net] TCP_USER_TIMEOUT and tcp_keepalive should conform to RFC5482

2017-08-09 Thread Jerry Chu
On Wed, Aug 9, 2017 at 5:47 PM, Rao Shoaib wrote: > > > On 08/09/2017 05:30 PM, David Miller wrote: >> >> From: Joe Smith >> Date: Wed, 9 Aug 2017 17:20:32 -0700 >> >>> Making Linux conform to standards and behavior that is logical seems >>> like a good enough reason. >> >> That's an awesome atti

Re:Re: Re:Re: Re:Re: Re: [PATCH net] ppp: Fix a scheduling-while-atomic bug in del_chan

2017-08-09 Thread Gao Feng
At 2017-08-10 05:00:19, "Cong Wang" wrote: >On Wed, Aug 9, 2017 at 12:17 AM, Gao Feng wrote: >> Hi Cong, >> >> Actually I have one question about the SOCK_RCU_FREE. >> I don't think it could resolve the issue you raised even though it exists >> really. >> >> I checked the SOCK_RCU_FREE, it just

Re: [PATCH v3 05/11] net: stmmac: dwmac-rk: Add internal phy support

2017-08-09 Thread Chen-Yu Tsai
Hi David, On Wed, Aug 9, 2017 at 5:38 PM, David.Wu wrote: > Hello Corentin, Chen-Yu > > > 在 2017/8/9 16:45, Corentin Labbe 写道: >> >> On Thu, Aug 03, 2017 at 07:06:33PM +0800, Chen-Yu Tsai wrote: >>> >>> On Thu, Aug 3, 2017 at 1:38 AM, Florian Fainelli >>> wrote: On 08/01/2017 11:21 PM,

Re: [PATCH net-next 0/2] zerocopy fixes

2017-08-09 Thread David Ahern
On 8/9/17 5:09 PM, Willem de Bruijn wrote: > From: Willem de Bruijn > > Fix two issues introduced in the msg_zerocopy patchset. > > Willem de Bruijn (2): > sock: fix zerocopy panic in mem accounting > sock: fix zerocopy_success regression with msg_zerocopy > > include/linux/skbuff.h | 9 ++

Re: [PATCH 0/3] Fix y2038 issues for security/keys subsystem

2017-08-09 Thread Baolin Wang
Hi Arnd, On 9 August 2017 at 16:44, Arnd Bergmann wrote: > On Wed, Aug 9, 2017 at 4:51 AM, Baolin Wang wrote: >> Since 'time_t', 'timeval' and 'timespec' types are not year 2038 safe on >> 32 bits system, this patchset tries to fix this issues for security/keys >> subsystem and net/rxrpc subsyst

Re: [PATCH 0/3] Fix y2038 issues for security/keys subsystem

2017-08-09 Thread Baolin Wang
On 9 August 2017 at 16:28, David Howells wrote: > The rxrpc patch isn't part of the security/keys subsystem. I'll push it > to the network tree. The other two I'll push to James. Thanks David. -- Baolin.wang Best Regards

Re: unregister_netdevice: waiting for eth0 to become free. Usage count = 1

2017-08-09 Thread Wei Wang
On Wed, Aug 9, 2017 at 6:26 PM, John Stultz wrote: > On Wed, Aug 9, 2017 at 5:36 PM, Wei Wang wrote: >> On Wed, Aug 9, 2017 at 4:44 PM, John Stultz wrote: >>> On Wed, Aug 9, 2017 at 4:34 PM, Cong Wang wrote: (Cc'ing Wei whose commit was blamed) On Mon, Aug 7, 2017 at 2:15 PM, Joh

Re: [PATCH v2 net-next 0/7] rtnetlink: allow selected handlers to run without rtnl

2017-08-09 Thread David Ahern
On 8/9/17 6:21 PM, David Miller wrote: > > Ok series applied, let's see where this goes :-) > 1 hour in, 1 problem reported

Re: unregister_netdevice: waiting for eth0 to become free. Usage count = 1

2017-08-09 Thread John Stultz
On Wed, Aug 9, 2017 at 5:36 PM, Wei Wang wrote: > On Wed, Aug 9, 2017 at 4:44 PM, John Stultz wrote: >> On Wed, Aug 9, 2017 at 4:34 PM, Cong Wang wrote: >>> (Cc'ing Wei whose commit was blamed) >>> >>> On Mon, Aug 7, 2017 at 2:15 PM, John Stultz wrote: On Mon, Aug 7, 2017 at 2:05 PM, John

Re:Re: Re: Re:Re: Re: [PATCH net] ppp: Fix a scheduling-while-atomic bug in del_chan

2017-08-09 Thread Gao Feng
At 2017-08-10 02:18:44, "Cong Wang" wrote: >On Tue, Aug 8, 2017 at 10:13 PM, Gao Feng wrote: >> Maybe I didn't show my explanation clearly. >> I think it won't happen as I mentioned in the last email. >> Because the pptp_release invokes the synchronize_rcu to make sure it, and >> actually there

RTNL: assertion failed at ...

2017-08-09 Thread David Ahern
Florian: Booting top of tree on my host with a VRF configured is spewing traces: [ 24.779911] RTNL: assertion failed at /home/dsa/kernel.git/net/core/dev.c (5717) [ 24.779984] CPU: 3 PID: 989 Comm: ip Not tainted 4.13.0-rc4-01020-gcd9cb3890b20 #8 [ 24.779986] Hardware name: Supermicro X9DAi

Re: [PATCH v2 3/4] can: m_can: Update documentation to mention new fixed transceiver binding

2017-08-09 Thread Franklin S Cooper Jr
Hi Rob, On 08/03/2017 12:07 PM, Rob Herring wrote: > On Mon, Jul 24, 2017 at 06:05:20PM -0500, Franklin S Cooper Jr wrote: >> Add information regarding fixed transceiver binding. This is especially >> important for MCAN since the IP allows CAN FD mode to run significantly >> faster than what most

Re: [PATCH net-next] net: skb_needs_check() removes CHECKSUM_NONE check for tx.

2017-08-09 Thread Tonghao Zhang
Thanks for your work. On Thu, Aug 10, 2017 at 2:30 AM, Willem de Bruijn wrote: > On Wed, Aug 9, 2017 at 5:04 AM, Tonghao Zhang > wrote: >> This patch reverts the commit 6e7bc478c9a0 >> ("net: skb_needs_check() accepts CHECKSUM_NONE for tx"), >> because we removed the UFO support. >> >> Cc: Eric

[PATCH v4 4/4] can: m_can: Add call to of_can_transceiver

2017-08-09 Thread Franklin S Cooper Jr
Add call to new generic functions that provides support via a binding to limit the arbitration rate and/or data rate imposed by the physical transceiver connected to the MCAN peripheral. Signed-off-by: Franklin S Cooper Jr --- drivers/net/can/m_can/m_can.c | 2 ++ 1 file changed, 2 insertions(+)

Re: [PATCH v3 2/4] dt-bindings: can: fixed-transceiver: Add new CAN fixed transceiver bindings

2017-08-09 Thread Franklin S Cooper Jr
Hi Sergei, On 08/03/2017 10:38 AM, Franklin S Cooper Jr wrote: > > > On 08/03/2017 07:22 AM, Sergei Shtylyov wrote: >> On 08/03/2017 12:48 PM, Franklin S Cooper Jr wrote: >> > Add documentation to describe usage of the new fixed transceiver > binding. > This new binding is applicable

[PATCH v4 2/4] dt-bindings: can: can-transceiver: Document new binding

2017-08-09 Thread Franklin S Cooper Jr
Add documentation to describe usage of the new can-transceiver binding. This new binding is applicable for any CAN device therefore it exists as its own document. Signed-off-by: Franklin S Cooper Jr --- Version 4 changes: Drop unit address. Switch from using fixed-transceiver to can-transceiver

[PATCH v4 0/4] can: Support transceiver based bit rate limit

2017-08-09 Thread Franklin S Cooper Jr
Add a new generic binding that CAN drivers can be used to specify the max bit rate supported by a transceiver. This is useful since in some instances since the maximum speeds may be limited by the transceiver used. However, transceivers may not provide a means to determine this limitation at runtim

[PATCH v4 1/4] can: dev: Add support for limiting configured bitrate

2017-08-09 Thread Franklin S Cooper Jr
Various CAN or CAN-FD IP may be able to run at a faster rate than what the transceiver the CAN node is connected to. This can lead to unexpected errors. However, CAN transceivers typically have fixed limitations and provide no means to discover these limitations at runtime. Therefore, add support f

[PATCH v4 3/4] dt-bindings: can: m_can: Document new can transceiver binding

2017-08-09 Thread Franklin S Cooper Jr
Add information regarding can-transceiver binding. This is especially important for MCAN since the IP allows CAN FD mode to run significantly faster than what most transceivers are capable of. Signed-off-by: Franklin S Cooper Jr --- Drop unit address. Switch from using fixed-transceiver to can-tr

Re: [PATCH v1 net] TCP_USER_TIMEOUT and tcp_keepalive should conform to RFC5482

2017-08-09 Thread David Miller
From: Rao Shoaib Date: Wed, 9 Aug 2017 17:47:57 -0700 > > > On 08/09/2017 05:30 PM, David Miller wrote: >> From: Joe Smith >> Date: Wed, 9 Aug 2017 17:20:32 -0700 >> >>> Making Linux conform to standards and behavior that is logical seems >>> like a good enough reason. >> That's an awesome att

Re: [PATCH v1 net] TCP_USER_TIMEOUT and tcp_keepalive should conform to RFC5482

2017-08-09 Thread Rao Shoaib
On 08/09/2017 05:30 PM, David Miller wrote: From: Joe Smith Date: Wed, 9 Aug 2017 17:20:32 -0700 Making Linux conform to standards and behavior that is logical seems like a good enough reason. That's an awesome attitude to have when we're implementing something new and don't have the facili

[PATCH net-next 04/10] netvsc: check error return when restoring channels and mtu

2017-08-09 Thread Stephen Hemminger
If setting new values fails, and the attempt to restore original settings fails. Then log an error and leave device down. This should never happen, but if it does don't go down in flames. Signed-off-by: Stephen Hemminger --- drivers/net/hyperv/netvsc_drv.c | 16 ++-- 1 file changed,

[PATCH net-next 08/10] netvsc: remove unnecessary check for NULL hdr

2017-08-09 Thread Stephen Hemminger
The function init_page_array is always called with a valid pointer to RNDIS header. No check for NULL is needed. Signed-off-by: Stephen Hemminger --- drivers/net/hyperv/netvsc_drv.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/net/hyperv/netvsc_drv.c b/drive

[PATCH net-next 09/10] netvsc: allow controlling send/recv buffer size

2017-08-09 Thread Stephen Hemminger
Control the size of the buffer areas via ethtool ring settings. They aren't really traditional hardware rings, but host API breaks receive and send buffer into chunks. The final size of the chunks are controlled by the host. The default value of send and receive buffer area for host DMA is much la

[PATCH net-next 07/10] netvsc: remove unnecessary cast of void pointer

2017-08-09 Thread Stephen Hemminger
Assignment to a typed pointer is sufficient in C. No cast is needed. Signed-off-by: Stephen Hemminger --- drivers/net/hyperv/netvsc_drv.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/net/hyperv/netvsc_drv.c b/drivers/net/hyperv/netvsc_drv.c index 3219d2e89

[PATCH net-next 03/10] netvsc: propagate MAC address change to VF slave

2017-08-09 Thread Stephen Hemminger
If VF is slaved to synthetic device, then any change to netvsc MAC address should be propagated to the slave device. If slave device doesn't support MAC address change then it should also be an error to attempt to change synthetic NIC MAC address. It also fixes the error unwind in the original co

[PATCH net-next 05/10] netvsc: no need to allocate send/receive on numa node

2017-08-09 Thread Stephen Hemminger
The send and receive buffers are both per-device (not per-channel). The associated NUMA node is a property of the CPU which is per-channel therefore it makes no sense to force the receive/send buffer to be allocated on a particular node (since it is a shared resource). Signed-off-by: Stephen Hemmi

[PATCH net-next 01/10] netvsc: delay setup of VF device

2017-08-09 Thread Stephen Hemminger
When VF device is discovered, delay bring it automatically up in order to allow userspace to some simple changes (like renaming). Reported-by: Vitaly Kuznetsov Signed-off-by: Stephen Hemminger --- drivers/net/hyperv/hyperv_net.h | 2 +- drivers/net/hyperv/netvsc_drv.c | 15 --- 2 f

[PATCH net-next 02/10] netvsc: don't signal host twice if empty

2017-08-09 Thread Stephen Hemminger
When hv_pkt_iter_next() returns NULL, it has already called hv_pkt_iter_close(). Calling it twice can lead to extra host signal. Signed-off-by: Stephen Hemminger --- drivers/net/hyperv/netvsc.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/net/hyperv/netvsc.c b/drivers/net/hyper

[PATCH net-next 06/10] netvsc: whitespace cleanup

2017-08-09 Thread Stephen Hemminger
Fix some minor indentation issues. Signed-off-by: Stephen Hemminger --- drivers/net/hyperv/netvsc_drv.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/net/hyperv/netvsc_drv.c b/drivers/net/hyperv/netvsc_drv.c index c7391889938b..3219d2e8918f 100644 --- a/

[PATCH net-next 10/10] netvsc: keep track of some non-fatal overload conditions

2017-08-09 Thread Stephen Hemminger
Add ethtool statistics for case where send chimmeny buffer is exhausted and driver has to fall back to doing scatter/gather send. Also, add statistic for case where ring buffer is full and receive completions are delayed. Signed-off-by: Stephen Hemminger --- drivers/net/hyperv/hyperv_net.h | 2

[PATCH net-next 00/10] netvsc: minor fixes and improvements

2017-08-09 Thread Stephen Hemminger
These are non-critical bug fixes, related to functionality now in net-next. 1. delaying the automatic bring up of VF device to allow udev to change name. 2. performance improvement 3. handle MAC address change with VF; mostly propogate the error that VF gives. 4. minor cleanups 5. allow settin

Re: unregister_netdevice: waiting for eth0 to become free. Usage count = 1

2017-08-09 Thread John Stultz
On Wed, Aug 9, 2017 at 5:36 PM, Wei Wang wrote: > > Does your USB adapter get an IPv6 address? Yes, it does. > If you see the problem starts to happen on commit > 9514528d92d4cbe086499322370155ed69f5d06c, could you try reverting all > the following commits: > (from new to old) > 1eb04e7c9e63 net

Re: unregister_netdevice: waiting for eth0 to become free. Usage count = 1

2017-08-09 Thread Wei Wang
On Wed, Aug 9, 2017 at 4:44 PM, John Stultz wrote: > On Wed, Aug 9, 2017 at 4:34 PM, Cong Wang wrote: >> (Cc'ing Wei whose commit was blamed) >> >> On Mon, Aug 7, 2017 at 2:15 PM, John Stultz wrote: >>> On Mon, Aug 7, 2017 at 2:05 PM, John Stultz wrote: So, with recent testing with my HiKe

Re: [PATCH iproute2 master] bpf: unbreak libelf linkage for bpf obj loader

2017-08-09 Thread Stephen Hemminger
On Thu, 10 Aug 2017 00:15:41 +0200 Daniel Borkmann wrote: > Commit 69fed534a533 ("change how Config is used in Makefile's") moved > HAVE_MNL specific CFLAGS/LDLIBS for building with libmnl out of the > top level Makefile into sub-Makefiles. However, it also removed the > HAVE_ELF specific CFLAGS/

Re: [PATCH v1 net] TCP_USER_TIMEOUT and tcp_keepalive should conform to RFC5482

2017-08-09 Thread Rao Shoaib
On 08/09/2017 05:20 PM, Joe Smith wrote: On Wed, Aug 9, 2017 at 4:52 PM, Jerry Chu wrote: [try to recover from long lost memory] On Tue, Aug 8, 2017 at 10:25 AM, Yuchung Cheng wrote: On Mon, Aug 7, 2017 at 11:16 AM, Rao Shoaib wrote: Change from version 0: Rationale behind the change: T

Re: [PATCH v1 net] TCP_USER_TIMEOUT and tcp_keepalive should conform to RFC5482

2017-08-09 Thread David Miller
From: Joe Smith Date: Wed, 9 Aug 2017 17:20:32 -0700 > Making Linux conform to standards and behavior that is logical seems > like a good enough reason. That's an awesome attitude to have when we're implementing something new and don't have the facility already. But when we have something alrea

Re: [PATCH v4 05/12] Documentation: net: phy: Add phy-is-internal binding

2017-08-09 Thread Andrew Lunn
On Wed, Aug 09, 2017 at 03:47:34PM -0700, Florian Fainelli wrote: > On August 9, 2017 5:10:30 AM PDT, David Wu wrote: > >Add the documentation for internal phy. A boolean property > >indicates that a internal phy will be used. > > > >Signed-off-by: David Wu > >--- > > Documentation/devicetree/bin

Re: [PATCH v2 net-next 0/7] rtnetlink: allow selected handlers to run without rtnl

2017-08-09 Thread David Miller
From: Florian Westphal Date: Wed, 9 Aug 2017 20:41:46 +0200 > Changes since v1: > In patch 6, don't make ipv6 route handlers lockless, they all have > assumptions on rtnl being held. Other patches are unchanged. > > The RTNL mutex is used to serialize both rtnetlink calls and > dump requests

Re: [PATCH v1 net] TCP_USER_TIMEOUT and tcp_keepalive should conform to RFC5482

2017-08-09 Thread Joe Smith
On Wed, Aug 9, 2017 at 4:52 PM, Jerry Chu wrote: > [try to recover from long lost memory] > > On Tue, Aug 8, 2017 at 10:25 AM, Yuchung Cheng wrote: >> On Mon, Aug 7, 2017 at 11:16 AM, Rao Shoaib wrote: >>> Change from version 0: Rationale behind the change: >>> >>> The man page for tcp(7) states

Re: [PATCH net-next 0/2] zerocopy fixes

2017-08-09 Thread David Miller
From: Willem de Bruijn Date: Wed, 9 Aug 2017 19:09:42 -0400 > Fix two issues introduced in the msg_zerocopy patchset. Series applied, thanks for following up on this so quickly.

Re: [PATCH net-next v2 0/9] Add BPF_J{LT,LE,SLT,SLE} instructions

2017-08-09 Thread David Miller
From: Daniel Borkmann Date: Thu, 10 Aug 2017 01:39:54 +0200 > This set adds BPF_J{LT,LE,SLT,SLE} instructions to the BPF > insn set, interpreter, JIT hardening code and all JITs are > also updated to support the new instructions. Basic idea is > to reduce register pressure by avoiding BPF_J{GT,GE

Re: [net-next 00/12][pull request] 1GbE Intel Wired LAN Driver Updates 2017-08-08

2017-08-09 Thread David Miller
From: Jeff Kirsher Date: Wed, 9 Aug 2017 14:47:34 -0700 > This series contains updates to e1000e and igb/igbvf. ... > The following are changes since commit > 53b948356554376ec6f89016376825d48bf396c3: > net: vrf: Add extack messages for newlink failures > and are available in the git reposit

Re: [PATCH v1 net] TCP_USER_TIMEOUT and tcp_keepalive should conform to RFC5482

2017-08-09 Thread Jerry Chu
[try to recover from long lost memory] On Tue, Aug 8, 2017 at 10:25 AM, Yuchung Cheng wrote: > On Mon, Aug 7, 2017 at 11:16 AM, Rao Shoaib wrote: >> Change from version 0: Rationale behind the change: >> >> The man page for tcp(7) states >> >> when used with the TCP keepalive (SO_KEEPALIVE) opti

Re: unregister_netdevice: waiting for eth0 to become free. Usage count = 1

2017-08-09 Thread John Stultz
On Wed, Aug 9, 2017 at 4:34 PM, Cong Wang wrote: > (Cc'ing Wei whose commit was blamed) > > On Mon, Aug 7, 2017 at 2:15 PM, John Stultz wrote: >> On Mon, Aug 7, 2017 at 2:05 PM, John Stultz wrote: >>> So, with recent testing with my HiKey board, I've been noticing some >>> quirky behavior with m

[PATCH net-next v2 4/9] bpf, sparc64: implement jiting of BPF_J{LT, LE, SLT, SLE}

2017-08-09 Thread Daniel Borkmann
This work implements jiting of BPF_J{LT,LE,SLT,SLE} instructions with BPF_X/BPF_K variants for the sparc64 eBPF JIT. Signed-off-by: Daniel Borkmann --- arch/sparc/net/bpf_jit_comp_64.c | 34 ++ 1 file changed, 34 insertions(+) diff --git a/arch/sparc/net/bpf_jit_

[PATCH net-next v2 0/9] Add BPF_J{LT,LE,SLT,SLE} instructions

2017-08-09 Thread Daniel Borkmann
This set adds BPF_J{LT,LE,SLT,SLE} instructions to the BPF insn set, interpreter, JIT hardening code and all JITs are also updated to support the new instructions. Basic idea is to reduce register pressure by avoiding BPF_J{GT,GE,SGT,SGE} rewrites. Removing the workaround for the rewrites in LLVM,

[PATCH net-next v2 5/9] bpf, s390x: implement jiting of BPF_J{LT,LE,SLT,SLE}

2017-08-09 Thread Daniel Borkmann
This work implements jiting of BPF_J{LT,LE,SLT,SLE} instructions with BPF_X/BPF_K variants for the s390x eBPF JIT. Signed-off-by: Daniel Borkmann Acked-by: Michael Holzheu --- arch/s390/net/bpf_jit_comp.c | 24 1 file changed, 24 insertions(+) diff --git a/arch/s390/ne

[PATCH net-next v2 1/9] bpf: add BPF_J{LT,LE,SLT,SLE} instructions

2017-08-09 Thread Daniel Borkmann
Currently, eBPF only understands BPF_JGT (>), BPF_JGE (>=), BPF_JSGT (s>), BPF_JSGE (s>=) instructions, this means that particularly *JLT/*JLE counterparts involving immediates need to be rewritten from e.g. X < [IMM] by swapping arguments into [IMM] > X, meaning the immediate first is required to

[PATCH net-next v2 3/9] bpf, arm64: implement jiting of BPF_J{LT,LE,SLT,SLE}

2017-08-09 Thread Daniel Borkmann
This work implements jiting of BPF_J{LT,LE,SLT,SLE} instructions with BPF_X/BPF_K variants for the arm64 eBPF JIT. Signed-off-by: Daniel Borkmann --- arch/arm64/net/bpf_jit.h | 4 arch/arm64/net/bpf_jit_comp.c | 20 2 files changed, 24 insertions(+) diff --git a/

[PATCH net-next v2 6/9] bpf, ppc64: implement jiting of BPF_J{LT,LE,SLT,SLE}

2017-08-09 Thread Daniel Borkmann
This work implements jiting of BPF_J{LT,LE,SLT,SLE} instructions with BPF_X/BPF_K variants for the ppc64 eBPF JIT. Signed-off-by: Daniel Borkmann Acked-by: Naveen N. Rao Tested-by: Naveen N. Rao --- arch/powerpc/net/bpf_jit.h| 1 + arch/powerpc/net/bpf_jit_comp64.c | 20 ++

[PATCH net-next v2 7/9] bpf, nfp: implement jiting of BPF_J{LT,LE}

2017-08-09 Thread Daniel Borkmann
This work implements jiting of BPF_J{LT,LE} instructions with BPF_X/BPF_K variants for the nfp eBPF JIT. The two BPF_J{SLT,SLE} instructions have not been added yet given BPF_J{SGT,SGE} are not supported yet either. Signed-off-by: Daniel Borkmann Acked-by: Jakub Kicinski --- drivers/net/etherne

[PATCH net-next v2 8/9] bpf: enable BPF_J{LT,LE,SLT,SLE} opcodes in verifier

2017-08-09 Thread Daniel Borkmann
Enable the newly added jump opcodes, main parts are in two different areas, namely direct packet access and dynamic map value access. For the direct packet access, we now allow for the following two new patterns to match in order to trigger markings with find_good_pkt_pointers(): Variant 1 (access

[PATCH net-next v2 2/9] bpf, x86: implement jiting of BPF_J{LT,LE,SLT,SLE}

2017-08-09 Thread Daniel Borkmann
This work implements jiting of BPF_J{LT,LE,SLT,SLE} instructions with BPF_X/BPF_K variants for the x86_64 eBPF JIT. Signed-off-by: Daniel Borkmann Acked-by: Alexei Starovoitov --- arch/x86/net/bpf_jit_comp.c | 26 ++ 1 file changed, 26 insertions(+) diff --git a/arch/x8

[PATCH net-next v2 9/9] bpf: add test cases for new BPF_J{LT, LE, SLT, SLE} instructions

2017-08-09 Thread Daniel Borkmann
Add test cases to the verifier selftest suite in order to verify that i) direct packet access, and ii) dynamic map value access is working with the changes related to the new instructions. Signed-off-by: Daniel Borkmann Acked-by: Alexei Starovoitov --- tools/testing/selftests/bpf/test_verifier.

Re: unregister_netdevice: waiting for eth0 to become free. Usage count = 1

2017-08-09 Thread Cong Wang
(Cc'ing Wei whose commit was blamed) On Mon, Aug 7, 2017 at 2:15 PM, John Stultz wrote: > On Mon, Aug 7, 2017 at 2:05 PM, John Stultz wrote: >> So, with recent testing with my HiKey board, I've been noticing some >> quirky behavior with my USB eth adapter. >> >> Basically, pluging the usb eth ad

Re: skb allocation from interrupt handler?

2017-08-09 Thread Stephen Hemminger
On Thu, 10 Aug 2017 00:29:19 +0200 Francois Romieu wrote: > Murali Karicheri : > [...] > > The internal memory or FIFO can store only up to 3 MTU sized packets. So > > that has to > > be processed before PRU gets another packets to send to CPU. So per above, > > it is not ideal to run NAPI for

Re: Some traffic stress testing with 4.13.0-rc4-next-20170808 and BUG: [61183.212237] BUG: Bad page state in process ksoftirqd/52 pfn:855f2f

2017-08-09 Thread Cong Wang
On Wed, Aug 9, 2017 at 8:50 AM, Paweł Staszewski wrote: > > > > [60961.112120] BUG: Bad page state in process ksoftirqd/44 pfn:855f2f > [60961.112123] page:ea002157cbc0 count:51910 mapcount:0 mapping: > (null) index:0x0 > [60961.112259] flags: 0x600() > [60961.112375] raw: 0600

[PATCH net-next 0/2] zerocopy fixes

2017-08-09 Thread Willem de Bruijn
From: Willem de Bruijn Fix two issues introduced in the msg_zerocopy patchset. Willem de Bruijn (2): sock: fix zerocopy panic in mem accounting sock: fix zerocopy_success regression with msg_zerocopy include/linux/skbuff.h | 9 +++-- net/core/skbuff.c | 4 ++-- 2 files changed, 9

[PATCH net-next 1/2] sock: fix zerocopy panic in mem accounting

2017-08-09 Thread Willem de Bruijn
From: Willem de Bruijn Only call mm_unaccount_pinned_pages when releasing a struct ubuf_info that has initialized its field uarg->mmp. Before this patch, a vhost-net with experimental_zcopytx can crash in mm_unaccount_pinned_pages sock_zerocopy_put skb_zcopy_clear skb_release_data Only

[PATCH net-next 2/2] sock: fix zerocopy_success regression with msg_zerocopy

2017-08-09 Thread Willem de Bruijn
From: Willem de Bruijn Do not use uarg->zerocopy outside msg_zerocopy. In other paths the field is not explicitly initialized and aliases another field. Those paths have only one reference so do not need this intermediate variable. Call uarg->callback directly. Fixes: 1f8b977ab32d ("sock: enabl

RE: [ovs-dev] [PATCH net-next] openvswitch: add NSH support

2017-08-09 Thread Yang, Yi Y
struct ovs_action_encap_nsh is the only one way we transfer all the data for encap_nsh, netlink allows variable attribute, so I don't think we break netlink convention or abuse this variable feature. Even if we bring nested attributes to handle this, OVS_ACTION_ATTR_ENCAP_NSH is still length-va

Re: [PATCH v4 10/12] ARM: dts: rk3228-evb: Enable the internal phy for gmac

2017-08-09 Thread Florian Fainelli
On August 9, 2017 5:13:19 AM PDT, David Wu wrote: >This patch enables the internal phy for rk3228 evb board >by default. >To use the external 1000M phy on evb board, need to make >some switch of evb board to be on. > >Signed-off-by: David Wu LGTM Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH v4 05/12] Documentation: net: phy: Add phy-is-internal binding

2017-08-09 Thread Florian Fainelli
On August 9, 2017 5:10:30 AM PDT, David Wu wrote: >Add the documentation for internal phy. A boolean property >indicates that a internal phy will be used. > >Signed-off-by: David Wu >--- > Documentation/devicetree/bindings/net/phy.txt | 3 +++ > 1 file changed, 3 insertions(+) > >diff --git a/Docu

Re: [PATCH v3 05/11] net: stmmac: dwmac-rk: Add internal phy support

2017-08-09 Thread Florian Fainelli
On August 9, 2017 1:45:41 AM PDT, Corentin Labbe wrote: >On Thu, Aug 03, 2017 at 07:06:33PM +0800, Chen-Yu Tsai wrote: >> On Thu, Aug 3, 2017 at 1:38 AM, Florian Fainelli > wrote: >> > On 08/01/2017 11:21 PM, David Wu wrote: >> >> To make internal phy work, need to configure the phy_clock, >> >>

Help with debugging CPU stall

2017-08-09 Thread Joe Smith
Hi, I am debugging a system where rcu_sched detects cpu stall. The system is running a test which runs fine if IPSec is not used. With IPSec it stalls. I have tried reducing the value of netdev_budget to 100 but that seems to have no impact. I have included two stack traces below. How do I figur

Re: skb allocation from interrupt handler?

2017-08-09 Thread Francois Romieu
Murali Karicheri : [...] > The internal memory or FIFO can store only up to 3 MTU sized packets. So that > has to > be processed before PRU gets another packets to send to CPU. So per above, > it is not ideal to run NAPI for this scenario, right? Also for NetCP we use > about 128 descriptors wit

[PATCH iproute2 master] bpf: unbreak libelf linkage for bpf obj loader

2017-08-09 Thread Daniel Borkmann
Commit 69fed534a533 ("change how Config is used in Makefile's") moved HAVE_MNL specific CFLAGS/LDLIBS for building with libmnl out of the top level Makefile into sub-Makefiles. However, it also removed the HAVE_ELF specific CFLAGS/LDLIBS entirely, which breaks the BPF object loader for tc and ip wi

[net-next 03/12] e1000e: add check on e1e_wphy() return value

2017-08-09 Thread Jeff Kirsher
From: Gustavo A R Silva Check return value from call to e1e_wphy(). This value is being checked during previous calls to function e1e_wphy() and it seems a check was missing here. Addresses-Coverity-ID: 1226905 Signed-off-by: Gustavo A R Silva Reviewed-by: Ethan Zhao Tested-by: Aaron Brown Si

[net-next 02/12] igb: protect TX timestamping from API misuse

2017-08-09 Thread Jeff Kirsher
From: Cliff Spradlin HW timestamping can only be requested for a packet if the NIC is first setup via ioctl(SIOCSHWTSTAMP). If this step was skipped, then the igb driver still allowed TX packets to request HW timestamping. In this situation, the _IGB_PTP_TX_IN_PROGRESS flag was set and would neve

[net-next 01/12] igb: Fix error of RX network flow classification

2017-08-09 Thread Jeff Kirsher
From: Gangfeng Huang After add an ethertype filter, if user change the adapter speed several times, the error "ethtool -N: etype filters are all used" is reported by igb driver. In older patch, function igb_nfc_filter_exit() and igb_nfc_filter_restore() is not paried. igb_nfc_filter_restore() ex

[net-next 04/12] igb: Remove incorrect "unexpected SYS WRAP" log message

2017-08-09 Thread Jeff Kirsher
From: Corinna Vinschen TSAUXC.DisableSystime is never set, so SYSTIM runs into a SYS WRAP every 1100 secs on 80580/i350/i354 (40 bit SYSTIM) and every 35000 secs on 80576 (45 bit SYSTIM). This wrap event sets the TSICR.SysWrap bit unconditionally. However, checking TSIM at interrupt time shows

[net-next 06/12] igb: expose mailbox unlock method

2017-08-09 Thread Jeff Kirsher
From: Greg Edwards Add a mailbox unlock method to e1000_mbx_operations, which will be used to unlock the PF/VF mailbox by the PF. Signed-off-by: Greg Edwards Tested-by: Aaron Brown Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/igb/e1000_hw.h | 1 + drivers/net/ethernet/intel/i

[net-next 05/12] igb: add argument names to mailbox op function declarations

2017-08-09 Thread Jeff Kirsher
From: Greg Edwards Signed-off-by: Greg Edwards Tested-by: Aaron Brown Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/igb/e1000_hw.h | 15 --- drivers/net/ethernet/intel/igb/e1000_mbx.h | 12 ++-- 2 files changed, 14 insertions(+), 13 deletions(-) diff --git a

  1   2   3   4   >