[PATCH v3 06/20] brcm80211: constify usb_device_id

usb_device_id are not supposed to change at runtime. All functions working with usb_device_id provided by work with const usb_device_id. So mark the non-const structs as const. Signed-off-by: Arvind Yadav --- changes in v2: Re-submitting wireless

Re: [net-next 03/12] e1000e: add check on e1e_wphy() return value

On Thu, 2017-08-10 at 19:53 -0700, Joe Perches wrote: > On Thu, 2017-08-10 at 21:47 -0500, Gustavo A. R. Silva wrote: > > Hello everybody, > > > > I'm a little confused. Is this patch causing any trouble? > > Not to me. I no longer have an e1000e. > > Given the commit message, this just seemed

[PATCH net-next] net: skb_needs_check() removes CHECKSUM_UNNECESSARY check for tx.

Because we remove the UFO support, we will also remove the CHECKSUM_UNNECESSARY check in skb_needs_check(). Cc: Willem de Bruijn Signed-off-by: Tonghao Zhang --- net/core/dev.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git

Re: [net-next 03/12] e1000e: add check on e1e_wphy() return value

Hello everybody, I'm a little confused. Is this patch causing any trouble? On 08/10/2017 12:56 PM, Joe Perches wrote: On Wed, 2017-08-09 at 14:47 -0700, Jeff Kirsher wrote: From: Gustavo A R Silva Check return value from call to e1e_wphy(). This value is being

Re: [net-next 03/12] e1000e: add check on e1e_wphy() return value

On Thu, 2017-08-10 at 21:47 -0500, Gustavo A. R. Silva wrote: > Hello everybody, > > I'm a little confused. Is this patch causing any trouble? Not to me. I no longer have an e1000e. Given the commit message, this just seemed to be a patch that _might_ cause an issue if this code patch is

Re: [PATCH 2/3] ARM: sun8i: sunxi-h3-h5: add phy-is-integrated property to internal PHY

Hi, On Thu, Aug 10, 2017 at 4:51 PM, Corentin Labbe wrote: > This patch add the new phy-is-integrated property to the internal PHY > node. > > Signed-off-by: Corentin Labbe > --- > arch/arm/boot/dts/sunxi-h3-h5.dtsi | 1 + > 1 file changed,

Re: [PATCH v1 net] TCP_USER_TIMEOUT and tcp_keepalive should conform to RFC5482

On Thu, Aug 10, 2017 at 2:05 PM, Rao Shoaib wrote: > > > On 08/09/2017 09:59 PM, Jerry Chu wrote: >> >> On Wed, Aug 9, 2017 at 8:32 PM, Jerry Chu wrote: >>> >>> On Wed, Aug 9, 2017 at 5:47 PM, Rao Shoaib wrote: On

Re: [PATCH net-next] net: skb_needs_check() removes CHECKSUM_NONE check for tx.

Hi Willem, because we change the CHECKSUM_NONE to CHECKSUM_UNNECESSARY in skb_needs_check(), I can't revert 6e7bc478c9a0 ("net: skb_needs_check() accepts CHECKSUM_NONE for tx"). I change it directly and resubmit it. On Fri, Aug 11, 2017 at 1:03 AM, Willem de Bruijn

[PATCH net-next 14/14] sctp: fix some indents in sm_make_chunk.c

There are some bad indents of functions' defination in sm_make_chunk.c. They have been there since beginning, it was probably caused by that the typedef sctp_chunk_t was replaced with struct sctp_chunk. So it's the best time to fix them in this patchset, it's also to fix some bad indents in other

[PATCH net-next 11/14] sctp: remove the unused typedef sctp_sm_command_t

Remove this typedef including the struct, there is even no places using it. Signed-off-by: Xin Long --- include/net/sctp/sm.h | 5 - 1 file changed, 5 deletions(-) diff --git a/include/net/sctp/sm.h b/include/net/sctp/sm.h index 9af64b9..3ca75a6 100644 ---

[PATCH net-next 12/14] sctp: remove the typedef sctp_sm_table_entry_t

This patch is to remove the typedef sctp_sm_table_entry_t, and replace with struct sctp_sm_table_entry in the places where it's using this typedef. It is also to fix some indents. Signed-off-by: Xin Long --- include/net/sctp/sm.h| 6 +++--- net/sctp/sm_sideeffect.c |

[PATCH net-next 13/14] sctp: remove the typedef sctp_disposition_t

This patch is to remove the typedef sctp_disposition_t, and replace with enum sctp_disposition in the places where it's using this typedef. It's also to fix the indent for many functions' defination. Signed-off-by: Xin Long --- include/net/sctp/sm.h| 19 +-

[PATCH net-next 09/14] sctp: remove the typedef sctp_arg_t

This patch is to remove the typedef sctp_arg_t, and replace with union sctp_arg in the places where it's using this typedef. Signed-off-by: Xin Long --- include/net/sctp/command.h | 26 +- net/sctp/sm_statefuns.c| 2 +- 2 files changed, 14

[PATCH net-next 10/14] sctp: remove the typedef sctp_verb_t

This patch is to remove the typedef sctp_verb_t, and replace with enum sctp_verb in the places where it's using this typedef. Signed-off-by: Xin Long --- include/net/sctp/command.h | 10 +- net/sctp/sm_statefuns.c| 2 +- 2 files changed, 6 insertions(+), 6

[PATCH net-next 05/14] sctp: remove the typedef sctp_dbg_objcnt_entry_t

This patch is to remove the typedef sctp_dbg_objcnt_entry_t, and replace with struct sctp_dbg_objcnt_entry in the places where it's using this typedef. Signed-off-by: Xin Long --- include/net/sctp/structs.h | 4 ++-- net/sctp/objcnt.c | 2 +- 2 files changed, 3

[PATCH net-next 08/14] sctp: remove the typedef sctp_cmd_seq_t

This patch is to remove the typedef sctp_cmd_seq_t, and replace with struct sctp_cmd_seq in the places where it's using this typedef. Note that it doesn't fix many indents although it should, as sctp_disposition_t's removal would mess them up again. So better to fix them when removing

[PATCH net-next 06/14] sctp: remove the typedef sctp_socket_type_t

This patch is to remove the typedef sctp_socket_type_t, and replace with enum sctp_socket_type in the places where it's using this typedef. Signed-off-by: Xin Long --- include/net/sctp/sctp.h| 3 ++- include/net/sctp/structs.h | 6 +++--- net/sctp/socket.c | 7

[PATCH net-next 04/14] sctp: remove the typedef sctp_cmsgs_t

This patch is to remove the typedef sctp_cmsgs_t, and replace with struct sctp_cmsgs in the places where it's using this typedef. Signed-off-by: Xin Long --- include/net/sctp/structs.h | 4 ++-- net/sctp/socket.c | 9 + 2 files changed, 7 insertions(+), 6

[PATCH net-next 07/14] sctp: remove the typedef sctp_cmd_t

This patch is to remove the typedef sctp_cmd_t, and replace with enum sctp_cmd in the places where it's using this typedef. Signed-off-by: Xin Long --- include/net/sctp/command.h | 14 +++--- net/sctp/sm_sideeffect.c | 2 +- 2 files changed, 8 insertions(+), 8

[PATCH net-next 03/14] sctp: remove the typedef sctp_endpoint_type_t

This patch is to remove the typedef sctp_endpoint_type_t, and replace with enum sctp_endpoint_type in the places where it's using this typedef. Signed-off-by: Xin Long --- include/net/sctp/structs.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

[PATCH net-next 01/14] sctp: remove the unused typedef sctp_packet_phandler_t

Remove this function typedef, there is even no places using it. Signed-off-by: Xin Long --- include/net/sctp/structs.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/include/net/sctp/structs.h b/include/net/sctp/structs.h index fbe6e81..73e9509 100644 ---

[PATCH net-next 02/14] sctp: remove the typedef sctp_sender_hb_info_t

This patch is to remove the typedef sctp_sender_hb_info_t, and replace with struct sctp_sender_hb_info in the places where it's using this typedef. It is also to use sizeof(variable) instead of sizeof(type). Signed-off-by: Xin Long --- include/net/sctp/structs.h | 4 ++--

[PATCH net-next 00/14] sctp: remove typedefs from structures part 6

As we know, typedef is suggested not to use in kernel, even checkpatch.pl also gives warnings about it. Now sctp is using it for many structures. All this kind of typedef's using should be removed. This patchset is the part 6 to remove all typedefs in include/net/sctp/structs.h, command.h and

[PATCH iproute2 net-next] config: put CFLAGS/LDLIBS in config.mk

This renames Config to config.mk and includes more Make input. Now configure generates all the required CFLAGS and LDLIBS for the optional libraries. Also, use pkg-config to test for libelf, rather than using a test program. This makes it consistent with other libraries. Signed-off-by: Stephen

[PATCH] selftests: bpf: add check for ip XDP redirect

Kernel test robot reports error when running test_xdp_redirect.sh. Check if ip tool supports xdpgeneric, if not, skip the test. Signed-off-by: William Tu Cc: Daniel Borkmann Cc: John Fastabend ---

Re: [PATCH iproute2 master] bpf: unbreak libelf linkage for bpf obj loader

On Thu, 10 Aug 2017 10:44:13 +0200 Daniel Borkmann wrote: > On 08/10/2017 02:35 AM, Stephen Hemminger wrote: > > On Thu, 10 Aug 2017 00:15:41 +0200 > > Daniel Borkmann wrote: > > > >> Commit 69fed534a533 ("change how Config is used in Makefile's")

Re: [PATCH] MAINTAINERS: update the NetLabel and Labeled Networking information

On Thu, 10 Aug 2017, Paul Moore wrote: > On Thu, Aug 10, 2017 at 3:13 PM, Paul Moore wrote: > > From: Paul Moore > > > > Signed-off-by: Paul Moore > > --- > > MAINTAINERS | 24 ++-- > > 1 file changed, 14

Re: [PATCH] MAINTAINERS: update the NetLabel and Labeled Networking information

On Thu, 10 Aug 2017, Paul Moore wrote: > From: Paul Moore > > Signed-off-by: Paul Moore Applied to git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/linux-security.git next -- James Morris

[PATCH v3 net-next 2/2] wan: dscc4: convert to plain DMA API

Make use the dma_*() interfaces rather than the pci_*() interfaces. Signed-off-by: Alexey Khoroshilov --- drivers/net/wan/dscc4.c | 96 ++--- 1 file changed, 51 insertions(+), 45 deletions(-) diff --git

[PATCH v3 net-next 1/2] wan: dscc4: add checks for dma mapping errors

The driver does not check if mapping dma memory succeed. The patch adds the checks and failure handling. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov --- v2: Fix issues noted by David Miller and Francois Romieu. v3:

Re: [PATCHv2 net-next iproute2] gre: add support for ERSPAN tunnel

On Thu, 10 Aug 2017 13:14:27 -0700 William Tu wrote: > + > + if (greinfo[IFLA_GRE_ERSPAN_INDEX]) > + erspan_idx = > rta_getattr_u32(greinfo[IFLA_GRE_ERSPAN_INDEX]); > } Are you missing a ntohl() here? It is encoded as htonl() when

[PATCH net-next v2] vxlan: change vxlan_[config_]validate() to use netlink_ext_ack for error reporting

The kernel log is not where users expect error messages for netlink requests; as we have extended acks now, we can replace pr_debug() with NL_SET_ERR_MSG_ATTR(). Signed-off-by: Matthias Schiffer Signed-off-by: Girish Moodalbail ---

Re: [PATCH v1 net] TCP_USER_TIMEOUT and tcp_keepalive should conform to RFC5482

On 08/09/2017 09:59 PM, Jerry Chu wrote: On Wed, Aug 9, 2017 at 8:32 PM, Jerry Chu wrote: On Wed, Aug 9, 2017 at 5:47 PM, Rao Shoaib wrote: On 08/09/2017 05:30 PM, David Miller wrote: From: Joe Smith Date: Wed, 9 Aug 2017

[PATCH net-next] net: ipv4: set orig_oif based on fib result for local traffic

Attempts to connect to a local address with a socket bound to a device with the local address hangs if there is no listener: $ ip addr sh dev eth1 3: eth1: mtu 1500 qdisc mq state UP group default qlen 1000 link/ether 02:e0:f9:1c:00:37 brd

[PATCH 1/2] mpls: add handlers

Mpls handler allows creation/deletion of mpls routes without using rtnetlink. When an incoming mpls packet matches this route, the saved function handler is called. Signed-off-by: Amine Kherbouche Signed-off-by: David Lamparter ---

[PATCH 2/2] drivers: add vpls support

This commit introduces the support of VPLS virtual device, that allows performing L2VPN multipoint to multipoint communication over MPLS PSN. VPLS device encap received ethernet frame over mpls packet and send it the output device, in the other direction, when receiving the right configured mpls

[RFC PATCH 0/2] Support of VPLS MPLS

This small series implements the support of VPLS dataplane using MPLS encapsulation to perform a l2VPN using a virtual network device. The ingress ethernet frames are encapsulated and carried over an MPLS packet switched network, then decapsulated in the egress router (LER) by a vpls device.

[PATCHv2 net-next iproute2] gre: add support for ERSPAN tunnel

The patch adds ERSPAN type II tunnel support. The implementation is based on the draft at https://tools.ietf.org/html/draft-foschiano-erspan-01 One of the purposes is for Linux box to be able to receive ERSPAN monitoring traffic sent from the Cisco switch, by creating a ERSPAN tunnel device. In

Re: unregister_netdevice: waiting for eth0 to become free. Usage count = 1

On Thu, Aug 10, 2017 at 11:12 AM, John Stultz wrote: > On Wed, Aug 9, 2017 at 10:41 PM, Wei Wang wrote: >> Hi John, >> >> Is it possible to try the attached patch? > > Thanks so much for the quick turn around! > > So I dropped all the reverts you

Re: [PATCH 2/6] wl1251: Use request_firmware_prefer_user() for loading NVS calibration data

On Fri, Jun 30, 2017 at 11:35:41PM +0200, Arend van Spriel wrote: > On 23-06-17 23:53, Luis R. Rodriguez wrote: > > On Tue, May 16, 2017 at 10:41:08AM +0200, Arend Van Spriel wrote: > >> On 16-5-2017 1:13, Luis R. Rodriguez wrote: > >>> Since no upstream delta is needed for firmwared I'd like to

Re: [PATCH RFC 0/2] stap: Socket tap

On 8/7/17 4:12 PM, Tom Herbert wrote: > A socket tap is enabled on socket using SO_ULP socket option with > ulp type "stap". The socket option takes ULP specific configuration How about sktap instead of stap since stap has a history of referring to system tap?

Re: [PATCH] MAINTAINERS: update the NetLabel and Labeled Networking information

From: Paul Moore Date: Thu, 10 Aug 2017 15:15:23 -0400 > On Thu, Aug 10, 2017 at 3:13 PM, Paul Moore wrote: >> From: Paul Moore >> >> Signed-off-by: Paul Moore >> --- >> MAINTAINERS | 24

Re: [PATCH] MAINTAINERS: update the NetLabel and Labeled Networking information

On Thu, Aug 10, 2017 at 3:13 PM, Paul Moore wrote: > From: Paul Moore > > Signed-off-by: Paul Moore > --- > MAINTAINERS | 24 ++-- > 1 file changed, 14 insertions(+), 10 deletions(-) I'm planning on sending

Re: [PATCH V4 net 0/2] ipv6: fix flowlabel issue for reset packet

On Thu, Aug 10, 2017 at 11:30:51AM -0700, Tom Herbert wrote: > On Thu, Aug 10, 2017 at 9:30 AM, Shaohua Li wrote: > > On Wed, Aug 09, 2017 at 09:40:08AM -0700, Tom Herbert wrote: > >> On Mon, Jul 31, 2017 at 3:19 PM, Shaohua Li wrote: > >> > From: Shaohua Li

[PATCH] MAINTAINERS: update the NetLabel and Labeled Networking information

From: Paul Moore Signed-off-by: Paul Moore --- MAINTAINERS | 24 ++-- 1 file changed, 14 insertions(+), 10 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 65990909fe73..be25ebaaeec3 100644 --- a/MAINTAINERS +++

Re: [PATCH] bonding: require speed/duplex only for 802.3ad, alb and tlb

On Wed, Aug 9, 2017 at 9:41 PM, Andreas Born wrote: > The patch c4adfc822bf5 ("bonding: make speed, duplex setting consistent > with link state") puts the link state to down if > bond_update_speed_duplex() cannot retrieve speed and duplex settings. > Assumably the patch

Re: [PATCH V4 net 0/2] ipv6: fix flowlabel issue for reset packet

On Thu, Aug 10, 2017 at 9:30 AM, Shaohua Li wrote: > On Wed, Aug 09, 2017 at 09:40:08AM -0700, Tom Herbert wrote: >> On Mon, Jul 31, 2017 at 3:19 PM, Shaohua Li wrote: >> > From: Shaohua Li >> > >> > Please see below tcpdump output: >> >

Re: unregister_netdevice: waiting for eth0 to become free. Usage count = 1

On Wed, Aug 9, 2017 at 10:41 PM, Wei Wang wrote: > Hi John, > > Is it possible to try the attached patch? Thanks so much for the quick turn around! So I dropped all the reverts you suggested, and applied this one against 4.13-rc4, but I'm still seeing the problematic

Re: [net-next 03/12] e1000e: add check on e1e_wphy() return value

On Wed, 2017-08-09 at 14:47 -0700, Jeff Kirsher wrote: > From: Gustavo A R Silva > > Check return value from call to e1e_wphy(). This value is being > checked during previous calls to function e1e_wphy() and it seems > a check was missing here. The use of "it seems"

Re: Regression: Bug 196547 - Since 4.12 - bonding module not working with wireless drivers

Hi everyone, 2017-08-10 14:43 GMT+02:00 Arend van Spriel : > > > On 10-08-17 07:39, Kalle Valo wrote: >> >> Hi Mahesh and Andy, >> >> James Feeney reported that there's a serious regression in bonding >> module since v4.12, it doesn't work with wireless drivers

[GIT] Networking

1) Fix handling of initial STATE message in TIPC, from Jon Paul Maloy. 2) Fix stats handling in bcm_sysport_get_stats(), from Florian Fainelli. 3) Reject 16777215 VNI value in geneve_validate(), from Girish Moodalbail. 4) Fix initial IGMP sysctl setting regression, from Nikolay

Re: [PATCH RFC net-next] net: Allow name change of IFF_UP interfaces

On Thu, 10 Aug 2017 10:55:01 -0600 David Ahern wrote: > On 8/10/17 10:48 AM, David Miller wrote: > > From: Andrew Lunn > > Date: Thu, 10 Aug 2017 18:27:22 +0200 > > > >> On Thu, Aug 10, 2017 at 05:24:55PM +0200, Vitaly Kuznetsov wrote: > >>> Andrew Lunn

[PATCH ipsec-next] net: xfrm: support setting an output mark.

On systems that use mark-based routing it may be necessary for routing lookups to use marks in order for packets to be routed correctly. An example of such a system is Android, which uses socket marks to route packets via different networks. Currently, routing lookups in tunnel mode always use a

Re: [PATCH V5 1/2] firmware: add more flexible request_firmware_async function

On Thu, Aug 03, 2017 at 05:55:18AM +, Coelho, Luciano wrote: > On Thu, 2017-08-03 at 08:23 +0300, Kalle Valo wrote: > > "Luis R. Rodriguez" writes: > > > > > > +int request_firmware_nowait(struct module *module, bool uevent, > > > > + const char

Re: [PATCH V5 1/2] firmware: add more flexible request_firmware_async function

On Thu, Aug 03, 2017 at 08:23:00AM +0300, Kalle Valo wrote: > "Luis R. Rodriguez" writes: > > >> +int request_firmware_nowait(struct module *module, bool uevent, > >> + const char *name, struct device *device, gfp_t gfp, > >> + void

Re: [PATCH net-next] net: skb_needs_check() removes CHECKSUM_NONE check for tx.

On Wed, Aug 9, 2017 at 6:02 PM, Tonghao Zhang wrote: > Thanks for your work. You, too. > On Thu, Aug 10, 2017 at 2:30 AM, Willem de Bruijn > wrote: >> On Wed, Aug 9, 2017 at 5:04 AM, Tonghao Zhang >> wrote:

Re: [PATCH RFC net-next] net: Allow name change of IFF_UP interfaces

On 8/10/17 10:48 AM, David Miller wrote: > From: Andrew Lunn > Date: Thu, 10 Aug 2017 18:27:22 +0200 > >> On Thu, Aug 10, 2017 at 05:24:55PM +0200, Vitaly Kuznetsov wrote: >>> Andrew Lunn writes: >>> > We are - rtnetlink_event() does the job. We, however,

Re: [PATCH net] packet: fix tp_reserve race in packet_set_ring

From: Willem de Bruijn Date: Thu, 10 Aug 2017 12:41:58 -0400 > From: Willem de Bruijn > > Updates to tp_reserve can race with reads of the field in > packet_set_ring. Avoid this by holding the socket lock during > updates in setsockopt

Re: [PATCH net] udp: consistently apply ufo or fragmentation

From: Willem de Bruijn Date: Thu, 10 Aug 2017 12:29:19 -0400 > From: Willem de Bruijn > > When iteratively building a UDP datagram with MSG_MORE and that > datagram exceeds MTU, consistently choose UFO or fragmentation. > > Once skb_is_gso,

Re: [PATCH 0/3] ARM: dts: keystone-k2g: Add DCAN instances to 66AK2G

On 8/7/17 2:31 PM, Franklin S Cooper Jr wrote: Hi Santosh, On 08/04/2017 12:07 PM, Santosh Shilimkar wrote: Hi Franklin, On 8/2/2017 1:18 PM, Franklin S Cooper Jr wrote: Add D CAN nodes to 66AK2G based SoC dtsi. Franklin S Cooper Jr (2): dt-bindings: net: c_can: Update binding for clock

Re: [PATCH net-next 0/6] rtnetlink: fix initial rtnl pushdown fallout

From: Florian Westphal Date: Thu, 10 Aug 2017 16:52:56 +0200 > This series fixes various bugs and splats reported since the > allow-handler-to-run-with-no-rtnl series went in. > > Last patch adds a script that can be used to add further > tests in case more bugs are reported. >

Re: [PATCH RFC net-next] net: Allow name change of IFF_UP interfaces

From: Andrew Lunn Date: Thu, 10 Aug 2017 18:27:22 +0200 > On Thu, Aug 10, 2017 at 05:24:55PM +0200, Vitaly Kuznetsov wrote: >> Andrew Lunn writes: >> >> >> We are - rtnetlink_event() does the job. We, however, don't have a >> >> special IFLA_EVENT_* for name

[PATCH net] packet: fix tp_reserve race in packet_set_ring

From: Willem de Bruijn Updates to tp_reserve can race with reads of the field in packet_set_ring. Avoid this by holding the socket lock during updates in setsockopt PACKET_RESERVE. This bug was discovered by syzkaller. Fixes: 8913336a7e8d ("packet: add PACKET_RESERVE

Re: [PATCH 1/3] dt-bindings: net: c_can: Update binding for clock and power-domains property

On Wed, Aug 02, 2017 at 03:18:20PM -0500, Franklin S Cooper Jr wrote: > CAN driver uses the clk_get_rate call to determine the frequency of the > functional clock. OMAP based SoCs do not require the clock property since > hwmod already handles creating a "fck" clock thats accessible to drivers.

Re: [PATCH RFC net-next] net: Allow name change of IFF_UP interfaces

Andrew Lunn writes: > On Thu, Aug 10, 2017 at 05:24:55PM +0200, Vitaly Kuznetsov wrote: >> Andrew Lunn writes: >> >> >> We are - rtnetlink_event() does the job. We, however, don't have a >> >> special IFLA_EVENT_* for name change and end up with IFLA_EVENT_NONE.

Re: [PATCH V4 net 0/2] ipv6: fix flowlabel issue for reset packet

On Wed, Aug 09, 2017 at 09:40:08AM -0700, Tom Herbert wrote: > On Mon, Jul 31, 2017 at 3:19 PM, Shaohua Li wrote: > > From: Shaohua Li > > > > Please see below tcpdump output: > > 21:00:48.109122 IP6 (flowlabel 0x43304, hlim 64, next-header TCP (6) > > payload

[PATCH net] udp: consistently apply ufo or fragmentation

From: Willem de Bruijn When iteratively building a UDP datagram with MSG_MORE and that datagram exceeds MTU, consistently choose UFO or fragmentation. Once skb_is_gso, always apply ufo. Conversely, once a datagram is split across multiple skbs, do not consider ufo. Sendpage

Re: [PATCH RFC net-next] net: Allow name change of IFF_UP interfaces

On Thu, Aug 10, 2017 at 05:24:55PM +0200, Vitaly Kuznetsov wrote: > Andrew Lunn writes: > > >> We are - rtnetlink_event() does the job. We, however, don't have a > >> special IFLA_EVENT_* for name change and end up with IFLA_EVENT_NONE. > > > > What is in this event? Old and new

Re: [PATCHv2 1/2] drivers: net: davinci_mdio: remove busy loop on wait user access

On 08/10/2017 02:47 AM, Max Uvarov wrote: Polling 14 mdio devices on single mdio bus eats 30% of 1Ghz cpu time due to busy loop in wait(). Add small delay to relax cpu. Signed-off-by: Max Uvarov yep. cover letter is good to have. Reviewed-by: Grygorii Strashko

Re: [PATCH 4/8] tty/bcm63xx_uart: allow naming clock in device tree

On Wed, Aug 02, 2017 at 11:34:25AM +0200, Jonas Gorski wrote: > Codify using a named clock for the refclk of the uart. This makes it > easier if we might need to add a gating clock (like present on the > BCM6345). > > Signed-off-by: Jonas Gorski > --- >

Re: [PATCH v2 net-next 0/7] rtnetlink: allow selected handlers to run without rtnl

On 8/10/17 5:29 AM, Florian Westphal wrote: > David Ahern wrote: > >> On 8/9/17 6:21 PM, David Miller wrote: >>> >>> Ok series applied, let's see where this goes :-) >>> >> >> 1 hour in, 1 problem reported > > Its even worse. Would you rather see a revert? no. > > I'm

Re: [PATCHv2 2/2] drivers: net: davinci_mdio: print bus frequency

On 08/10/2017 02:47 AM, Max Uvarov wrote: Frequency can be adjusted in DT it make sense to print current used value on driver init. Signed-off-by: Max Uvarov Reviewed-by: Grygorii Strashko --- drivers/net/ethernet/ti/davinci_mdio.c | 6

Re: [PATCH net-next 3/6] rtnetlink: switch rtnl_link_get_slave_info_data_size to rcu

On 8/10/17 8:52 AM, Florian Westphal wrote: > David Ahern reports following splat: > RTNL: assertion failed at net/core/dev.c (5717) > netdev_master_upper_dev_get+0x5f/0x70 > if_nlmsg_size+0x158/0x240 > rtnl_calcit.isra.26+0xa3/0xf0 > > rtnl_link_get_slave_info_data_size currently assumes

Re: [PATCH net-next] net: core: fix compile error inside flow_dissector due to new dsa callback

From: John Crispin Date: Thu, 10 Aug 2017 10:09:03 +0200 > The following error was introduced by > commit 43e665287f93 ("net-next: dsa: fix flow dissection") > due to a missing #if guard > > net/core/flow_dissector.c: In function '__skb_flow_dissect': >

Re: [PATCH] hv_set_ifconfig.sh double check before setting ip

From: Eduardo Otubo Date: Thu, 10 Aug 2017 09:40:27 +0200 > On 08/09/2017 11:02 AM, Eduardo Otubo wrote: >> On 08/09/2017 06:11 AM, David Miller wrote: >>> From: Eduardo Otubo >>> Date: Tue, 8 Aug 2017 15:53:45 +0200 >>> This patch fixes the behavior of

Re: [PATCH net] geneve: maximum value of VNI cannot be used

On 8/9/17 10:41 PM, David Miller wrote: From: Girish Moodalbail Date: Tue, 8 Aug 2017 17:26:24 -0700 Geneve's Virtual Network Identifier (VNI) is 24 bit long, so the range of values for it would be from 0 to 16777215 (2^24 -1). However, one cannot create a

Re: [PATCH net-next 1/6] rtnetlink: use rcu_dereference_raw to silence rcu splat

On Thu, Aug 10, 2017 at 04:52:57PM +0200, Florian Westphal wrote: > Ido reports a rcu splat in __rtnl_register. > The splat is correct; as rtnl_register doesn't grab any logs > and doesn't use rcu locks either. It has always been like this. > handler families are not registered in parallel so

Re: [PATCH v4 1/4] can: dev: Add support for limiting configured bitrate

Hello, sorry for stepping in late On 08/10/2017 02:59 AM, Franklin S Cooper Jr wrote: > Various CAN or CAN-FD IP may be able to run at a faster rate than > what the transceiver the CAN node is connected to. This can lead to > unexpected errors. However, CAN transceivers typically have fixed

Re: [PATCH RFC net-next] net: Allow name change of IFF_UP interfaces

Andrew Lunn writes: >> We are - rtnetlink_event() does the job. We, however, don't have a >> special IFLA_EVENT_* for name change and end up with IFLA_EVENT_NONE. > > What is in this event? Old and new name? Just the new name? Basically, it's everything we know about the

Re: [PATCH net-next] phylink: Fix an uninitialized variable bug

On Thu, Aug 10, 2017 at 12:35:50AM +0300, Dan Carpenter wrote: > "ret" isn't necessarily initialized here. > > Fixes: 9525ae83959b ("phylink: add phylink infrastructure") > Signed-off-by: Dan Carpenter Reviewed-by: Andrew Lunn Andrew

[patch v1 2/2] Change Kconfig description

Mellanox devices can be cards or switch therefore naming it device. Signed-off-by: Ohad Oz --- drivers/net/ethernet/mellanox/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/mellanox/Kconfig

[patch v1 1/2] Allow Mellanox network vendor to be configured if only I2C bus is configured

Patch allows Mellanox devices on system with no PCI, but with I2C only. Signed-off-by: Ohad Oz --- drivers/net/ethernet/mellanox/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/mellanox/Kconfig

[PATCH v3] net: stmmac: Use the right logging function in stmmac_mdio_register

Currently, the function stmmac_mdio_register() is only used by stmmac_dvr_probe() from stmmac_main.c, in order to register the MDIO bus and probe information about the PHY. As this function is called before calling register_netdev(), all messages logged from stmmac_mdio_register are prefixed by

[PATCH net-next 5/6] rtnetlink: fallback to UNSPEC if current family has no doit callback

We need to use PF_UNSPEC in case the requested family has no doit callback, otherwise this now fails with EOPNOTSUPP instead of running the unspec doit callback, as before. Fixes: 6853dd488119 ("rtnetlink: protect handler table with rcu") Signed-off-by: Florian Westphal ---

[PATCH net-next 6/6] selftests: add rtnetlink test script

add a simple script to exercise some rtnetlink call paths, so KASAN, lockdep etc. can yell at developer before patches are sent upstream. This can be extended to also cover bond, team, vrf and the like. Signed-off-by: Florian Westphal --- This test crashes the kernel, fix is

[PATCH net-next 4/6] rtnetlink: init handler refcounts to 1

If using CONFIG_REFCOUNT_FULL=y we get following splat: refcount_t: increment on 0; use-after-free. WARNING: CPU: 0 PID: 304 at lib/refcount.c:152 refcount_inc+0x47/0x50 Call Trace: rtnetlink_rcv_msg+0x191/0x260 ... This warning is harmless (0 is "no callback running", not "memory was freed").

[PATCH net-next 0/6] rtnetlink: fix initial rtnl pushdown fallout

This series fixes various bugs and splats reported since the allow-handler-to-run-with-no-rtnl series went in. Last patch adds a script that can be used to add further tests in case more bugs are reported. In case you prefer reverting the original series instead of fixing fallout I can resend

[PATCH net-next 2/6] rtnetlink: do not use RTM_GETLINK directly

Userspace sends RTM_GETLINK type, but the kernel substracts RTM_BASE from this, i.e. 'type' doesn't contain RTM_GETLINK anymore but instead RTM_GETLINK - RTM_BASE. This caused the calcit callback to not be invoked when it should have been (and vice versa). While at it, also fix a off-by one when

[PATCH net-next 3/6] rtnetlink: switch rtnl_link_get_slave_info_data_size to rcu

David Ahern reports following splat: RTNL: assertion failed at net/core/dev.c (5717) netdev_master_upper_dev_get+0x5f/0x70 if_nlmsg_size+0x158/0x240 rtnl_calcit.isra.26+0xa3/0xf0 rtnl_link_get_slave_info_data_size currently assumes RTNL protection, but there appears to be no hard requirement

[PATCH net-next 1/6] rtnetlink: use rcu_dereference_raw to silence rcu splat

Ido reports a rcu splat in __rtnl_register. The splat is correct; as rtnl_register doesn't grab any logs and doesn't use rcu locks either. It has always been like this. handler families are not registered in parallel so there are no races wrt. the kmalloc ordering. The only reason to use

Re: [PATCH v2] net: stmmac: Use the right logging function in stmmac_mdio_register

Hi Andrew, Le 10/08/2017 à 15:56, Andrew Lunn a écrit : > On Thu, Aug 10, 2017 at 09:38:26AM +0200, Romain Perier wrote: >> Currently, the function stmmac_mdio_register() is only used by >> stmmac_dvr_probe() from stmmac_main.c, in order to register the MDIO bus >> and probe information about

Re: [PATCHv2 1/2] drivers: net: davinci_mdio: remove busy loop on wait user access

On Thu, Aug 10, 2017 at 10:47:46AM +0300, Max Uvarov wrote: > Polling 14 mdio devices on single mdio bus eats 30% of 1Ghz cpu time > due to busy loop in wait(). Add small delay to relax cpu. Hi Max Please include a cover note when you have multiple patches in a series. With 14 devices, it makes

Re: [PATCH RFC net-next] net: Allow name change of IFF_UP interfaces

> We are - rtnetlink_event() does the job. We, however, don't have a > special IFLA_EVENT_* for name change and end up with IFLA_EVENT_NONE. What is in this event? Old and new name? Just the new name? Andrew

Re: [PATCH RFC net-next] net: Allow name change of IFF_UP interfaces

> >> Can you think of any particular real world scenarios which are broken by > >> the change? > > > > How about: > > > > man 8 dhclient-script > > > > The interface name is passed in $interface to the scripts. Do we get > > the old name or the new name? I suspect scripts are going to break if > >

Re: [PATCH v2] net: stmmac: Use the right logging function in stmmac_mdio_register

On Thu, Aug 10, 2017 at 09:38:26AM +0200, Romain Perier wrote: > Currently, the function stmmac_mdio_register() is only used by > stmmac_dvr_probe() from stmmac_main.c, in order to register the MDIO bus > and probe information about the PHY. As this function is called before > calling

[PATCH v5 11/11] ARM64: dts: rockchip: Enable gmac2phy for rk3328-evb

Enable the gmac2phy, make the gmac2phy work on the rk3328-evb board. Signed-off-by: David Wu --- arch/arm64/boot/dts/rockchip/rk3328-evb.dts | 17 + 1 file changed, 17 insertions(+) diff --git a/arch/arm64/boot/dts/rockchip/rk3328-evb.dts

[PATCH v5 10/11] ARM64: dts: rockchip: Add gmac2phy node support for rk3328

The gmac2phy controller of rk3328 is connected to integrated PHY directly inside, add the node for the integrated PHY support. Signed-off-by: David Wu --- changes in v5: - Use phy-is-integrated property via PHY node. - Move the PHY clock, reset control, pinctrl to PHY

[PATCH v5 09/11] ARM: dts: rk3228-evb: Enable the integrated PHY for gmac

This patch enables the integrated PHY for rk3228 evb board by default. To use the external 1000M PHY on evb board, need to make some switch of evb board to be on. Signed-off-by: David Wu Reviewed-by: Florian Fainelli --- changes in v5: - Use

[PATCH v5 07/11] net: stmmac: dwmac-rk: Add integrated PHY support for rk3228

There is only one mac controller in rk3228, which could connect to external PHY or integrated PHY, use the grf_com_mux bit15 to route external/integrated PHY. Signed-off-by: David Wu --- drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c | 12 1 file changed,

[PATCH v5 08/11] net: stmmac: dwmac-rk: Add integrated PHY supprot for rk3328

There are two mac controllers in the rk3328, the one connects to external PHY, and the other one connects to integrated PHY. Like the mac of external PHY, the integrated PHY's mac also needs to configure the related mac registers at GRF. Signed-off-by: David Wu ---

  1   2   >