Re: Grant-

2017-08-11 Thread Mayrhofer Family
Good Day, My wife and I have awarded you with a donation of $ 1,000,000.00 Dollars from part of our Jackpot Lottery of 50 Million Dollars, respond with your details for claims. We await your earliest response and God Bless you. Friedrich And Annand Mayrhofer. --- This email has been checked

Re: unregister_netdevice: waiting for eth0 to become free. Usage count = 1

2017-08-11 Thread David Ahern
On 8/11/17 6:25 PM, Wei Wang wrote: > By "a patch to fix that" do you mean after your patch, for every rt6, > rt6->rt6i_idev will be the same as rt6->dst.dev? FIB entries should have them the same device with my patch. The copies done (ip6_rt_cache_alloc and ip6_rt_pcpu_alloc) will have to set

Re: unregister_netdevice: waiting for eth0 to become free. Usage count = 1

2017-08-11 Thread John Stultz
On Fri, Aug 11, 2017 at 5:31 PM, John Stultz wrote: > On Fri, Aug 11, 2017 at 5:10 PM, Wei Wang wrote: >>> If after Cong's fix, the issue still happens, could you help try the >>> patch attached and collect all logs when you try the reproduce the >>>

Re: [PATCH net-next V2 3/3] tap: XDP support

2017-08-11 Thread Jason Wang
On 2017年08月12日 07:12, Jakub Kicinski wrote: On Fri, 11 Aug 2017 19:41:18 +0800, Jason Wang wrote: This patch tries to implement XDP for tun. The implementation was split into two parts: - fast path: small and no gso packet. We try to do XDP at page level before build_skb(). For XDP_TX,

Re: [PATCH 5/5] e1000e: Avoid receiver overrun interrupt bursts

2017-08-11 Thread Philip Prindeville
> On Aug 11, 2017, at 8:13 PM, Philip Prindeville > wrote: > >> >> On Jul 21, 2017, at 12:48 PM, Lennart Sorensen >> wrote: >> >> On Fri, Jul 21, 2017 at 11:36:27AM -0700, Benjamin Poirier wrote: >>> When e1000e_poll() is

Re: [PATCH net-next v2] vxlan: change vxlan_[config_]validate() to use netlink_ext_ack for error reporting

2017-08-11 Thread Roopa Prabhu
On Fri, Aug 11, 2017 at 9:39 AM, Jiri Benc wrote: > On Fri, 11 Aug 2017 09:19:34 -0700, Roopa Prabhu wrote: >> > if (tb[IFLA_ADDRESS]) { >> > if (nla_len(tb[IFLA_ADDRESS]) != ETH_ALEN) { >> > - pr_debug("invalid link address (not

Re: [PATCH 5/5] e1000e: Avoid receiver overrun interrupt bursts

2017-08-11 Thread Philip Prindeville
> On Jul 21, 2017, at 12:48 PM, Lennart Sorensen > wrote: > > On Fri, Jul 21, 2017 at 11:36:27AM -0700, Benjamin Poirier wrote: >> When e1000e_poll() is not fast enough to keep up with incoming traffic, the >> adapter (when operating in msix mode) raises the Other

[PATCH net-next] liquidio: update debug console logging mechanism

2017-08-11 Thread Felix Manlunas
From: Rick Farrington - remove logging dependency upon global func octeon_console_debug_enabled() - abstract debug console logging using console structure (via function ptr) to allow for more flexible logging Signed-off-by: Rick Farrington

★nathalyg17--“JEC world 2018 世界复合材料展览及会议”将于“3月06-08日”在“法国巴黎”举行 (地右P1-L-Me)

2017-08-11 Thread netdev-owner
尊敬的 nathaly...@yahoo.com 企业领导/公司负责人/业界专家,您好:       新材料为21世纪三大共性关键技术之一,已成为全球经济迅速增长的源动力和提升核心竞争力的战略焦点。材料作为制造业的基础,特别是新材料研究和产业发展的水平与规模,已经成为衡量一个国家科技进步和综合实力的重要标志。在新材料发展与应用中,复合材料占有相当重要的地位,特别广泛的应用在汽车、交通、风能、航空、航天、兵器、船舶、国防、机械、电子、化工、建筑、农业、渔业、纺织、运动器材等领域,一直是世界各国优先发展和竞争激烈的重要行业。      “JEC世界复合材料展览及会议”(JEC world

[PATCH net-next 6/8] liquidio: moved liquidio_napi_poll to lio_core.c

2017-08-11 Thread Felix Manlunas
From: Intiyaz Basha Moving common liquidio_napi_poll to lio_core.c Signed-off-by: Intiyaz Basha Signed-off-by: Felix Manlunas --- drivers/net/ethernet/cavium/liquidio/lio_core.c| 61 +-

[PATCH net-next 5/8] liquidio: moved liquidio_napi_drv_callback to lio_core.c

2017-08-11 Thread Felix Manlunas
From: Intiyaz Basha Moving common liquidio_napi_drv_callback to lio_core.c Signed-off-by: Intiyaz Basha Signed-off-by: Felix Manlunas --- drivers/net/ethernet/cavium/liquidio/lio_core.c| 39

[PATCH net-next 8/8] liquidio: added support for ethtool --set-ring feature

2017-08-11 Thread Felix Manlunas
From: Intiyaz Basha added support for ethtool --set-ring feature Signed-off-by: Intiyaz Basha Signed-off-by: Felix Manlunas --- drivers/net/ethernet/cavium/liquidio/lio_ethtool.c | 131 +

[PATCH net-next 3/8] liquidio: moved octeon_setup_droq to lio_core.c

2017-08-11 Thread Felix Manlunas
From: Intiyaz Basha Moving common octeon_setup_droq to lio_core.c Signed-off-by: Intiyaz Basha Signed-off-by: Felix Manlunas --- drivers/net/ethernet/cavium/liquidio/lio_core.c| 35

[PATCH net-next 7/8] liquidio: moved liquidio_setup_io_queues to lio_core.c

2017-08-11 Thread Felix Manlunas
From: Intiyaz Basha Moving common liquidio_setup_io_queues to lio_core.c Signed-off-by: Intiyaz Basha Signed-off-by: Felix Manlunas --- drivers/net/ethernet/cavium/liquidio/lio_core.c| 119

[PATCH net-next 4/8] liquidio: moved liquidio_push_packet to lio_core.c

2017-08-11 Thread Felix Manlunas
From: Intiyaz Basha Moving common liquidio_push_packet to lio_core.c Signed-off-by: Intiyaz Basha Signed-off-by: Felix Manlunas --- drivers/net/ethernet/cavium/liquidio/lio_core.c| 149 +

[PATCH net-next 2/8] liquidio: moved update_txq_status to lio_core.c

2017-08-11 Thread Felix Manlunas
From: Intiyaz Basha Moving common update_txq_status to lio_core.c Signed-off-by: Intiyaz Basha Signed-off-by: Felix Manlunas --- drivers/net/ethernet/cavium/liquidio/lio_core.c| 33

[PATCH net-next 1/8] liquidio: moved wait_for_pending_requests to octeon_network.h

2017-08-11 Thread Felix Manlunas
From: Intiyaz Basha Moving common function wait_for_pending_requests to octeon_network.h Signed-off-by: Intiyaz Basha Signed-off-by: Felix Manlunas --- .../ethernet/cavium/liquidio/cn23xx_vf_device.h| 2 --

[PATCH net-next 0/8] liquidio: adding support for ethtool --set-ring feature

2017-08-11 Thread Felix Manlunas
From: Intiyaz Basha Code reorganization is required for adding ethtool --set-ring feature. First seven patches are for code reorganization. The last patch is for adding this feature. Intiyaz Basha (8): liquidio: moved wait_for_pending_requests to octeon_network.h

Re: [PATCH V4 net 0/2] ipv6: fix flowlabel issue for reset packet

2017-08-11 Thread Tom Herbert
On Thu, Aug 10, 2017 at 12:13 PM, Shaohua Li wrote: > On Thu, Aug 10, 2017 at 11:30:51AM -0700, Tom Herbert wrote: >> On Thu, Aug 10, 2017 at 9:30 AM, Shaohua Li wrote: >> > On Wed, Aug 09, 2017 at 09:40:08AM -0700, Tom Herbert wrote: >> >> On Mon, Jul 31, 2017

Re: unregister_netdevice: waiting for eth0 to become free. Usage count = 1

2017-08-11 Thread Wei Wang
> So yes, sorry I haven't been able to get back quicker on the other > patches sent, was mucking about in other work. > > So yea, this patch (potential fix for unregister_netdevice()) seems > to avoid the issue. > > I'm going to do some further testing, but its looking good so far. > Great.

Re: unregister_netdevice: waiting for eth0 to become free. Usage count = 1

2017-08-11 Thread John Stultz
On Fri, Aug 11, 2017 at 5:10 PM, Wei Wang wrote: >> If after Cong's fix, the issue still happens, could you help try the >> patch attached and collect all logs when you try the reproduce the >> issue? It would be great to have logs for both success case and the >> failure case.

Re: unregister_netdevice: waiting for eth0 to become free. Usage count = 1

2017-08-11 Thread Wei Wang
On Fri, Aug 11, 2017 at 5:19 PM, David Ahern wrote: > On 8/11/17 6:10 PM, Wei Wang wrote: >> I think we have a potential fix for this issue. >> Martin and I found that when addrconf_dst_alloc() creates a rt6, it is >> possible that rt6->dst.dev points to loopback device while

Re: unregister_netdevice: waiting for eth0 to become free. Usage count = 1

2017-08-11 Thread David Ahern
On 8/11/17 6:10 PM, Wei Wang wrote: > I think we have a potential fix for this issue. > Martin and I found that when addrconf_dst_alloc() creates a rt6, it is > possible that rt6->dst.dev points to loopback device while > rt6->rt6i_idev->dev points to a real device. > When the real device goes

[PATCH net-next 0/2] net: vrf: Support for local traffic with sockets bound to enslaved devices

2017-08-11 Thread David Ahern
This set gets local traffic working for sockets bound to enslaved devices. The local rtable and rt6_info added in June 2016 to get local traffic in VRFs working is no longer needed and actually keeps local traffic for sockets bound to an enslaved device from working. Patch 1 removes them. Patch 2

[PATCH net-next 1/2] net: vrf: Drop local rtable and rt6_info

2017-08-11 Thread David Ahern
The VRF cached rtable and rt6_info for local traffic are no longer needed and actually prevent local traffic through enslaved devices. Remove them. Signed-off-by: David Ahern --- drivers/net/vrf.c | 122 -- 1 file changed, 8

[PATCH net-next 2/2] net: ipv4: add check for l3slave for index returned in IP_PKTINFO

2017-08-11 Thread David Ahern
Similar to the loopback device, for packets sent through a VRF device the index returned in ipi_ifindex needs to be the saved index in rt_iif. Signed-off-by: David Ahern --- net/ipv4/ip_sockglue.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

Re: unregister_netdevice: waiting for eth0 to become free. Usage count = 1

2017-08-11 Thread Wei Wang
> If after Cong's fix, the issue still happens, could you help try the > patch attached and collect all logs when you try the reproduce the > issue? It would be great to have logs for both success case and the > failure case. > > Thanks so much for your help. > I think we have a potential fix for

[PATCH net-next] net: ipv4: remove unnecessary check on orig_oif

2017-08-11 Thread David Ahern
rt_iif is going to be set to either 0 or orig_oif. If orig_oif is 0 it amounts to the same end result so remove the check. Signed-off-by: David Ahern --- net/ipv4/route.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/ipv4/route.c b/net/ipv4/route.c

Re: [PATCH v3 net-next 2/2] wan: dscc4: convert to plain DMA API

2017-08-11 Thread Francois Romieu
David Miller : [...] > Oops, this will need to be sent as a relative fixup as I've applied these > two patches to net-next, sorry Francois. No problem. It works perfectly this way. -- Ueimor

Re: Performance comparision / qdisc / no qdisc / queueing linux kernel 4.12

2017-08-11 Thread Stephen Hemminger
Any of the current qdisc that do rate control are single threaded. Since bandwidth is a shared resource, the qdisc has to acquire a lock and update cache shared data structures. Don't expect HTB or HFSC to be free. > > 4.13-rc3 have kernel panic when deleting qdisc - will try to get panic trace

Re: [PATCH net-next V2 3/3] tap: XDP support

2017-08-11 Thread Jakub Kicinski
On Fri, 11 Aug 2017 19:41:18 +0800, Jason Wang wrote: > This patch tries to implement XDP for tun. The implementation was > split into two parts: > > - fast path: small and no gso packet. We try to do XDP at page level > before build_skb(). For XDP_TX, since creating/destroying queues > were

Re: [PATCH net-next 1/3] Add LAN743X driver

2017-08-11 Thread Stephen Hemminger
On Fri, 11 Aug 2017 19:47:57 + wrote: > +static void lan743x_pcidev_remove(struct pci_dev *pdev) > +{ > + struct net_device *netdev = NULL; > + struct lan743x_adapter *adapter = NULL; > + > + netdev = pci_get_drvdata(pdev); > + adapter =

Re: [PATCH net-next 1/3] Add LAN743X driver

2017-08-11 Thread Stephen Hemminger
On Fri, 11 Aug 2017 19:47:57 + wrote: > + > +static struct net_device_stats *mac_get_stats(struct lan743x_adapter > *adapter) > +{ > + struct lan743x_mac *mac = >mac; > + > + memset(>statistics, 0, sizeof(mac->statistics)); > +

Re: [PATCH net-next 1/3] Add LAN743X driver

2017-08-11 Thread Stephen Hemminger
On Fri, 11 Aug 2017 19:47:57 + wrote: > + > +static int lan743x_rx_napi_poll(struct napi_struct *napi, int weight) > +{ > + int count; > + bool finished = false; > + struct lan743x_rx *rx = container_of(napi, > + struct lan743x_rx,

Re: [PATCH net-next 1/3] Add LAN743X driver

2017-08-11 Thread Stephen Hemminger
On Fri, 11 Aug 2017 19:47:57 + wrote: > + > +static int lan743x_ethtool_get_eeprom_len(struct net_device *netdev) > +{ > + return 0; > +} > + This stub should go. If you have no eeprom, take the ethtool default.

Re: [PATCH net-next 1/3] Add LAN743X driver

2017-08-11 Thread Stephen Hemminger
On Fri, 11 Aug 2017 19:47:57 + wrote: > + > + netdev = alloc_etherdev(sizeof(struct lan743x_adapter)); > + if (!netdev) { > + NETIF_ERROR(adapter, probe, adapter->netdev, > + "alloc_etherdev returned NULL"); > +

Re: [PATCH net-next 1/3] Add LAN743X driver

2017-08-11 Thread Stephen Hemminger
; > + > +static void lan743x_rx_isr(void *context, u32 int_sts); > + > +static int lan743x_rx_ring_init(struct lan743x_rx *rx); > +static void lan743x_rx_ring_cleanup(struct lan743x_rx *rx); > +static int lan743x_rx_init(struct lan743x_rx *rx, > +struct lan743x_adapter

[PATCH v2] bonding: ratelimit failed speed/duplex update warning

2017-08-11 Thread Andreas Born
bond_miimon_commit() handles the UP transition for each slave of a bond in the case of MII. It is triggered 10 times per second for the default MII Polling interval of 100ms. For device drivers that do not implement __ethtool_get_link_ksettings() the call to bond_update_speed_duplex() fails

Re: [PATCH net-next 1/3] Add LAN743X driver

2017-08-11 Thread Andrew Lunn
> This thing is huge, I'm not reviewing any more of this enormous submission. Yes. Could you split it up a bit. Take the PTP support out for the moment, and submit it later once the core driver is accepted. The same for any other optional bits. Andrew

[PATCH net-next v3] vxlan: change vxlan_[config_]validate() to use netlink_ext_ack for error reporting

2017-08-11 Thread Girish Moodalbail
The kernel log is not where users expect error messages for netlink requests; as we have extended acks now, we can replace pr_debug() with NL_SET_ERR_MSG_ATTR(). Signed-off-by: Matthias Schiffer Signed-off-by: Girish Moodalbail ---

Re: [PATCH net-next 1/3] Add LAN743X driver

2017-08-11 Thread Andrew Lunn
On Fri, Aug 11, 2017 at 07:47:57PM +, bryan.whiteh...@microchip.com wrote: > From: Bryan Whitehead > > Add Microchip LAN743X Driver files > LAN743X is a PCIe Gigabit ethernet adapter > > Signed-off-by: Bryan Whitehead > --- >

Re: [PATCH 1/4] MIPS/seccomp: Fix indirect syscall args

2017-08-11 Thread Kees Cook
On Fri, Aug 11, 2017 at 1:56 PM, James Hogan wrote: > Since commit 669c4092225f ("MIPS: Give __secure_computing() access to > syscall arguments."), upon syscall entry when seccomp is enabled, > syscall_trace_enter() passes a carefully prepared struct seccomp_data >

Re: [PATCH net-next 1/3] Add LAN743X driver

2017-08-11 Thread David Miller
From: Date: Fri, 11 Aug 2017 19:47:57 + > +static int lan743x_pci_init(struct lan743x_adapter *adapter, > + struct pci_dev *pdev) > +{ > + int ret = -ENODEV; > + int bars = 0; > + struct lan743x_pci *pci = >pci; Please

Re: [PATCH net-next] liquidio: moved ptp_enable to octeon_device structure

2017-08-11 Thread David Miller
From: Felix Manlunas Date: Fri, 11 Aug 2017 11:22:09 -0700 > From: Intiyaz Basha > > ptp_enable was a global static variable. Moved this global variable to > octeon_device structure and removed extra device id check. > > Signed-off-by:

Re: [PATCH net] udp: harden copy_linear_skb()

2017-08-11 Thread David Miller
From: Eric Dumazet Date: Fri, 11 Aug 2017 10:48:53 -0700 > From: Eric Dumazet > > syzkaller got crashes with CONFIG_HARDENED_USERCOPY=y configs. > > Issue here is that recvfrom() can be used with user buffer of Z bytes, > and SO_PEEK_OFF of X

Re: [PATCH net 0/2] Minor fix in bpf_convert_ctx_access

2017-08-11 Thread David Miller
From: Daniel Borkmann Date: Fri, 11 Aug 2017 18:31:23 +0200 > First one was found while trying to compile the kernel > with !CONFIG_NET_RX_BUSY_POLL. Series applied, thanks Daniel.

Re: Driver profiles RFC

2017-08-11 Thread Jakub Kicinski
On Tue, 8 Aug 2017 16:15:41 +0300, Arkadi Sharshevsky wrote: > Driver <--> Devlink API > === > Each driver will register his resources with default values at init in > a similar way to DPIPE table registration. In case those resources already > exist the default values are

Re: [PATCHv2 net-next] selftests: bpf: add check for ip XDP redirect

2017-08-11 Thread David Miller
From: William Tu Date: Fri, 11 Aug 2017 06:46:39 -0700 > Kernel test robot reports error when running test_xdp_redirect.sh. > Check if ip tool supports xdpgeneric, if not, skip the test. > > Signed-off-by: William Tu > Acked-by: Daniel Borkmann

Re: [PATCH] mlxsw: make mlxsw_config_profile const

2017-08-11 Thread David Miller
From: Bhumika Goyal Date: Fri, 11 Aug 2017 19:10:42 +0530 > Make these structures const as they only stored in the profile field of > a mlxsw_driver structure, which is of type const. > Done using Coccinelle. > > Signed-off-by: Bhumika Goyal Applied to

Re: [PATCH] mISDN: Fix null pointer dereference at mISDN_FsmNew

2017-08-11 Thread David Miller
From: Anton Vasilyev Date: Fri, 11 Aug 2017 15:57:22 +0300 > If mISDN_FsmNew() fails to allocate memory for jumpmatrix > then null pointer dereference will occur on any write to > jumpmatrix. > > The patch adds check on successful allocation and > corresponding error

Re: [PATCH] openvswitch: Remove unnecessary newlines from OVS_NLERR uses

2017-08-11 Thread David Miller
From: Joe Perches Date: Fri, 11 Aug 2017 04:26:26 -0700 > OVS_NLERR already adds a newline so these just add blank > lines to the logging. > > Signed-off-by: Joe Perches Applied to net-next.

Re: [PATCH net-next] nfp: send control message when MAC representors are created

2017-08-11 Thread David Miller
From: Simon Horman Date: Fri, 11 Aug 2017 10:25:44 +0200 > The firmware expects a MAC_REPR control message when a MAC representor > is created. The driver should expect a PORTMOD message to follow which > will provide the link states of the physical port associated

Re: [PATCH net repost] nfp: do not update MTU from BH in flower app

2017-08-11 Thread David Miller
From: Simon Horman Date: Fri, 11 Aug 2017 10:18:20 +0200 > The Flower app may receive a request to update the MTU of a representor > netdev upon receipt of a control message from the firmware. This requires > the RTNL lock which needs to be taken outside of the packet

Re: [PATCH v3 net-next 2/2] wan: dscc4: convert to plain DMA API

2017-08-11 Thread David Miller
From: Francois Romieu Date: Fri, 11 Aug 2017 23:45:49 +0200 > Alexey Khoroshilov : > [...] >> diff --git a/drivers/net/wan/dscc4.c b/drivers/net/wan/dscc4.c >> index 8480dbf..a043fb1 100644 >> --- a/drivers/net/wan/dscc4.c >> +++

Re: [PATCH 0/3] NCSI VLAN Filtering Support

2017-08-11 Thread David Miller
From: Samuel Mendoza-Jonas Date: Fri, 11 Aug 2017 16:16:45 +1000 > This series (mainly patch 3) adds VLAN filtering to the NCSI implementation. > A fair amount of code already exists in the NCSI stack for VLAN filtering but > none of it is actually hooked up. This goes the

Re: [PATCH v3 net-next 2/2] wan: dscc4: convert to plain DMA API

2017-08-11 Thread Francois Romieu
Alexey Khoroshilov : [...] > diff --git a/drivers/net/wan/dscc4.c b/drivers/net/wan/dscc4.c > index 8480dbf..a043fb1 100644 > --- a/drivers/net/wan/dscc4.c > +++ b/drivers/net/wan/dscc4.c [...] > @@ -506,8 +506,9 @@ static void dscc4_release_ring(struct dscc4_dev_priv >

Re: [PATCH net-next] net: skb_needs_check() removes CHECKSUM_UNNECESSARY check for tx.

2017-08-11 Thread David Miller
From: Tonghao Zhang Date: Thu, 10 Aug 2017 20:16:29 -0700 > Because we remove the UFO support, we will also remove the > CHECKSUM_UNNECESSARY check in skb_needs_check(). > > Cc: Willem de Bruijn > Signed-off-by: Tonghao Zhang

Re: [PATCH v3 net-next 2/2] wan: dscc4: convert to plain DMA API

2017-08-11 Thread David Miller
From: Alexey Khoroshilov Date: Fri, 11 Aug 2017 01:55:21 +0300 > Make use the dma_*() interfaces rather than the pci_*() interfaces. > > Signed-off-by: Alexey Khoroshilov Applied.

Re: [PATCH v3 net-next 1/2] wan: dscc4: add checks for dma mapping errors

2017-08-11 Thread David Miller
From: Alexey Khoroshilov Date: Fri, 11 Aug 2017 01:55:20 +0300 > The driver does not check if mapping dma memory succeed. > The patch adds the checks and failure handling. > > Found by Linux Driver Verification project (linuxtesting.org). > > Signed-off-by: Alexey

Re: [PATCH net-next] net: ipv4: set orig_oif based on fib result for local traffic

2017-08-11 Thread David Miller
From: David Ahern Date: Thu, 10 Aug 2017 13:49:10 -0700 > Attempts to connect to a local address with a socket bound > to a device with the local address hangs if there is no listener: > > $ ip addr sh dev eth1 > 3: eth1: mtu 1500 qdisc

Re: [PATCH v3] net: stmmac: Use the right logging function in stmmac_mdio_register

2017-08-11 Thread David Miller
From: Romain Perier Date: Thu, 10 Aug 2017 16:56:05 +0200 > Currently, the function stmmac_mdio_register() is only used by > stmmac_dvr_probe() from stmmac_main.c, in order to register the MDIO bus > and probe information about the PHY. As this function is called

Re: [PATCH] net/sched: reset block pointer in tcf_block_put()

2017-08-11 Thread Cong Wang
On Fri, Aug 11, 2017 at 1:36 PM, Konstantin Khlebnikov wrote: > > > On 11.08.2017 23:18, Cong Wang wrote: >> >> On Thu, Aug 10, 2017 at 2:31 AM, Konstantin Khlebnikov >> wrote: >>> >>> In previous API tcf_destroy_chain() could be called

Re: [PATCH net-next] fsl/fman: implement several errata workarounds

2017-08-11 Thread David Miller
From: Florinel Iordache Date: Thu, 10 Aug 2017 16:47:04 +0300 > Implemented workarounds for the following dTSEC Erratum: > A002, A004, A0012, A0014, A004839 on several operations > that involve MAC CFG register changes: adjust link, > rx pause frames, modify MAC

Re: [PATCH 3/3] tls: Use correct sk->sk_prot for IPV6

2017-08-11 Thread David Miller
From: Ilya Lesokhin Date: Thu, 10 Aug 2017 13:33:16 +0300 > +#if IS_ENABLED(CONFIG_IPV6) > + build_protos(tls_prots[TLSV6], _prot); > +#endif > Have you tested this with CONFIG_TLS=m and CONFIG_IPV6=m? I bet it doesn't link. How about CONFIG_IPV6=m and CONFIG_TLS=y?

Re: [PATCH 2/3] net: Export tcpv6_prot

2017-08-11 Thread David Miller
From: Ilya Lesokhin Date: Thu, 10 Aug 2017 13:33:15 +0300 > From: Boris Pismenny > > Want to be able to use these in TLS. > > Signed-off-by: Boris Pismenny > --- > net/ipv6/tcp_ipv6.c | 1 + > 1 file changed, 1 insertion(+) > >

Re: [PATCH 1/2 net-next] hns3pf: fix hns3_del_tunnel_port()

2017-08-11 Thread David Miller
From: Dan Carpenter Date: Thu, 10 Aug 2017 12:54:59 +0300 > This function has a copy and paste bug so it accidentally calls the add > function instead of the delete function. > > Fixes: 76ad4f0ee747 ("net: hns3: Add support of HNS3 Ethernet Driver for > hip08 SoC") >

Re: [PATCH 2/2 net-next] hns3pf: Fix some harmless copy and paste bugs

2017-08-11 Thread David Miller
From: Dan Carpenter Date: Thu, 10 Aug 2017 12:56:14 +0300 > These were copy and paste bugs, but I believe they are harmless. > > Signed-off-by: Dan Carpenter Applied.

Re: [PATCH] net/sched/hfsc: allocate tcf block for hfsc root class

2017-08-11 Thread David Miller
From: Konstantin Khlebnikov Date: Thu, 10 Aug 2017 12:31:40 +0300 > Without this filters cannot be attached. > > Signed-off-by: Konstantin Khlebnikov > Fixes: 6529eaba33f0 ("net: sched: introduce tcf block infractructure") Applied, thanks.

Re: [PATCH v5 00/11] Add the integrated PHY support

2017-08-11 Thread David Miller
From: David Wu Date: Thu, 10 Aug 2017 21:56:39 +0800 > The rk3228 and rk3328 support integrated PHY inside, let's enable > it to work. And the integrated PHY need to do some special setting, > so register the rockchip integrated PHY driver. Series applied to net-next,

Re: [PATCH 1/1] forcedeth: replace init_timer_deferrable with setup_deferrable_timer

2017-08-11 Thread David Miller
From: Zhu Yanjun Date: Thu, 10 Aug 2017 04:13:12 -0400 > Replace init_timer_deferrable with setup_deferrable_timer to simplify > the source code. > > Signed-off-by: Zhu Yanjun Applied to net-next, thanks.

Re: [PATCHv2 2/2] drivers: net: davinci_mdio: print bus frequency

2017-08-11 Thread David Miller
From: Max Uvarov Date: Thu, 10 Aug 2017 10:47:47 +0300 > Frequency can be adjusted in DT it make sense to > print current used value on driver init. > > Signed-off-by: Max Uvarov Applied to net-next.

Re: [PATCHv2 1/2] drivers: net: davinci_mdio: remove busy loop on wait user access

2017-08-11 Thread David Miller
From: Max Uvarov Date: Thu, 10 Aug 2017 10:47:46 +0300 > Polling 14 mdio devices on single mdio bus eats 30% of 1Ghz cpu time > due to busy loop in wait(). Add small delay to relax cpu. > > Signed-off-by: Max Uvarov Applied to net-next.

Re: [PATCH] bonding: require speed/duplex only for 802.3ad, alb and tlb

2017-08-11 Thread David Miller
From: Andreas Born Date: Thu, 10 Aug 2017 06:41:44 +0200 > The patch c4adfc822bf5 ("bonding: make speed, duplex setting consistent > with link state") puts the link state to down if > bond_update_speed_duplex() cannot retrieve speed and duplex settings. > Assumably the

Re: [PATCH] net/sched: reset block pointer in tcf_block_put()

2017-08-11 Thread David Miller
From: Cong Wang Date: Fri, 11 Aug 2017 14:06:31 -0700 > On Fri, Aug 11, 2017 at 1:32 PM, Florian Westphal wrote: >> Cong Wang wrote: >>> On Thu, Aug 10, 2017 at 2:31 AM, Konstantin Khlebnikov >>>

Re: [PATCH] net/sched: reset block pointer in tcf_block_put()

2017-08-11 Thread Cong Wang
On Fri, Aug 11, 2017 at 1:32 PM, Florian Westphal wrote: > Cong Wang wrote: >> On Thu, Aug 10, 2017 at 2:31 AM, Konstantin Khlebnikov >> wrote: >> > In previous API tcf_destroy_chain() could be called several times and >> >

Re: [PATCH net-next 00/10] netvsc: minor fixes and improvements

2017-08-11 Thread David Miller
From: Stephen Hemminger Date: Wed, 9 Aug 2017 17:46:02 -0700 > These are non-critical bug fixes, related to functionality now in net-next. > 1. delaying the automatic bring up of VF device to allow udev to change name. > 2. performance improvement > 3. handle MAC

Re: [PATCH net] net: dsa: ksz: fix skb freeing

2017-08-11 Thread David Miller
From: Vivien Didelot Date: Wed, 9 Aug 2017 16:46:09 -0400 > The DSA layer frees the original skb when an xmit function returns NULL, > meaning an error occurred. But if the tagging code copied the original > skb, it is responsible of freeing the copy if an

[PATCH 0/4] MIPS: syscall tracing fixes

2017-08-11 Thread James Hogan
These patches fix some system call tracing issues around seccomp and ptrace on MIPS. Patch 1 fixes an issue introduced in v4.13-rc1, where o32 indirect syscall arguments aren't shifted when filling out seccomp_data struct. Arguably the samples/bpf/tracex5 case that was being fixed in -rc1 is

Re: [PATCH net-next] phylink: Fix an uninitialized variable bug

2017-08-11 Thread David Miller
From: Dan Carpenter Date: Thu, 10 Aug 2017 00:35:50 +0300 > "ret" isn't necessarily initialized here. > > Fixes: 9525ae83959b ("phylink: add phylink infrastructure") > Signed-off-by: Dan Carpenter Applied, thanks Dan.

[PATCH 1/4] MIPS/seccomp: Fix indirect syscall args

2017-08-11 Thread James Hogan
Since commit 669c4092225f ("MIPS: Give __secure_computing() access to syscall arguments."), upon syscall entry when seccomp is enabled, syscall_trace_enter() passes a carefully prepared struct seccomp_data containing syscall arguments to __secure_computing(). Unfortunately it directly uses

Re: [PATCH net-next] liquidio: rx/tx queue cleanup

2017-08-11 Thread David Miller
From: Felix Manlunas Date: Wed, 9 Aug 2017 12:07:08 -0700 > From: Intiyaz Basha > > When deleting a queue, clear its corresponding bit in the qmask, vfree its > memory, clear out the pointer that's pointing to it, and decrement the > queue

Re: [PATCH net-next] liquidio: removed check for queue size alignment

2017-08-11 Thread David Miller
From: Felix Manlunas Date: Wed, 9 Aug 2017 13:28:04 -0700 > From: Intiyaz Basha > > There is no restriction on queue size alignment. Hence removing check for > valid queue size. > > Signed-off-by: Intiyaz Basha >

Re: [patch net-next 0/5] net: sched: let the offloader decide what to offload

2017-08-11 Thread David Miller
From: Jiri Pirko Date: Wed, 9 Aug 2017 14:30:30 +0200 > From: Jiri Pirko > > Currently there is a Qdisc_class_ops->tcf_cl_offload callback > that is called to find out if cls would offload rule or not. > This is only supported by sch_ingress and

Re: [PATCH net-next] geneve: use netlink_ext_ack for error reporting in rtnl operations

2017-08-11 Thread David Miller
From: Girish Moodalbail Date: Wed, 9 Aug 2017 01:09:28 -0700 > Add extack error messages for failure paths while creating/modifying > geneve devices. Once extack support is added to iproute2, more > meaningful and helpful error messages will be displayed making it

Re: [PATCH] net/sched: reset block pointer in tcf_block_put()

2017-08-11 Thread Konstantin Khlebnikov
On 11.08.2017 23:18, Cong Wang wrote: On Thu, Aug 10, 2017 at 2:31 AM, Konstantin Khlebnikov wrote: In previous API tcf_destroy_chain() could be called several times and some schedulers like hfsc and atm use that. In new API tcf_block_put() frees block but leaves

Re: [PATCH] net/sched: reset block pointer in tcf_block_put()

2017-08-11 Thread Florian Westphal
Cong Wang wrote: > On Thu, Aug 10, 2017 at 2:31 AM, Konstantin Khlebnikov > wrote: > > In previous API tcf_destroy_chain() could be called several times and > > some schedulers like hfsc and atm use that. In new API tcf_block_put() > > frees

Re: [PATCH] net/sched/hfsc: allocate tcf block for hfsc root class

2017-08-11 Thread Cong Wang
On Thu, Aug 10, 2017 at 2:31 AM, Konstantin Khlebnikov wrote: > Without this filters cannot be attached. > > Signed-off-by: Konstantin Khlebnikov > Fixes: 6529eaba33f0 ("net: sched: introduce tcf block infractructure") Looks good. Acked-by:

Re: [PATCH] net/sched: reset block pointer in tcf_block_put()

2017-08-11 Thread Cong Wang
On Thu, Aug 10, 2017 at 2:31 AM, Konstantin Khlebnikov wrote: > In previous API tcf_destroy_chain() could be called several times and > some schedulers like hfsc and atm use that. In new API tcf_block_put() > frees block but leaves stale pointer, second call will free

Re: After a while of system running no incoming UDP any more?

2017-08-11 Thread Marc Haber
On Fri, Aug 11, 2017 at 04:34:53PM +0200, Marc Haber wrote: > On Fri, Jul 28, 2017 at 02:14:34PM +0200, Marc Haber wrote: > > I can confirm that these two changes make a system in bad state work > > again immediately. Will try the patch on 4.12.4 later today. > > After upgrading my test systems

[PATCH net-next 3/3] Add LAN743X to MAINTAINER list

2017-08-11 Thread Bryan.Whitehead
From: Bryan Whitehead Add LAN743X to MAINTAINER list Signed-off-by: Bryan Whitehead --- MAINTAINERS | 7 +++ 1 file changed, 7 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 2db0f8c..3216348 100644 ---

[PATCH net-next 2/3] Add LAN743X to Kconfig and Makefile

2017-08-11 Thread Bryan.Whitehead
From: Bryan Whitehead Add LAN743X Driver to Kconfig and Makefile Removed "depends on SPI" from NET_VENDOR_MICROCHIP group Because all existing drivers already specify SPI dependency, and New driver does not have SPI dependency. Signed-off-by: Bryan Whitehead

[PATCH net-next 0/3] Add LAN743X driver

2017-08-11 Thread Bryan.Whitehead
From: Bryan Whitehead Add Microchip LAN743X PCIe 3.1 Gigabit Ethernet Controller Driver Bryan Whitehead (3): Add LAN743X driver Add LAN743X to Kconfig and Makefile Add LAN743X to MAINTAINER list MAINTAINERS |7 +

Re: [PATCH][next] Bluetooth: kfree tmp rather than an alias to it

2017-08-11 Thread Marcel Holtmann
Hi Colin, > While the kfree of dhkey_a is of the same address of tmp, it > probably is clearer and more human readable if tmp is kfree'd > rather than dhkey_a. > > Detected by CoverityScan, CID#1448650 ("Free of address-of expression") > Signed-off-by: Colin Ian King >

Re: BUG_ON(sg->sg_magic != SG_MAGIC) on tls socket.

2017-08-11 Thread Dave Watson
Hi Dave, On 08/11/17 02:52 PM, Dave Jones wrote: > kernel BUG at ./include/linux/scatterlist.h:189! > invalid opcode: [#1] SMP KASAN ... > Call Trace: > ? copy_page_to_iter+0x6c0/0x6c0 > tls_sw_sendmsg+0x6d8/0x9c0 > ? alloc_sg+0x510/0x510 > ? cyc2ns_read_end+0x10/0x10 > ?

BUG_ON(sg->sg_magic != SG_MAGIC) on tls socket.

2017-08-11 Thread Dave Jones
kernel BUG at ./include/linux/scatterlist.h:189! invalid opcode: [#1] SMP KASAN CPU: 3 PID: 20890 Comm: trinity-c51 Not tainted 4.13.0-rc4-think+ #5 task: 88036e3d1cc0 task.stack: 88033e9d8000 RIP: 0010:tls_push_record+0x675/0x680 RSP: 0018:88033e9df630 EFLAGS: 00010287 RAX:

[PATCH][next] Bluetooth: kfree tmp rather than an alias to it

2017-08-11 Thread Colin King
From: Colin Ian King While the kfree of dhkey_a is of the same address of tmp, it probably is clearer and more human readable if tmp is kfree'd rather than dhkey_a. Detected by CoverityScan, CID#1448650 ("Free of address-of expression") Signed-off-by: Colin Ian King

[PATCH net-next] liquidio: moved ptp_enable to octeon_device structure

2017-08-11 Thread Felix Manlunas
From: Intiyaz Basha ptp_enable was a global static variable. Moved this global variable to octeon_device structure and removed extra device id check. Signed-off-by: Intiyaz Basha Signed-off-by: Felix Manlunas ---

[PATCH v2] netfilter: nf_nat_h323: fix logical-not-parentheses warning

2017-08-11 Thread Nick Desaulniers
Clang produces the following warning: net/ipv4/netfilter/nf_nat_h323.c:553:6: error: logical not is only applied to the left hand side of this comparison [-Werror,-Wlogical-not-parentheses] if (!set_h225_addr(skb, protoff, data, dataoff, taddr, ^ add parentheses after the '!' to evaluate

Re: Some traffic stress testing with 4.13.0-rc4-next-20170808 and BUG: [61183.212237] BUG: Bad page state in process ksoftirqd/52 pfn:855f2f

2017-08-11 Thread Cong Wang
(Cc'ing Intel) On Thu, Aug 10, 2017 at 3:05 AM, Paweł Staszewski wrote: > Hi > > > yes there are some stack traces more > > enp24s0f3 - this NIC is used only for ssh to the host (not much traffic on > it) > > enp216s0f1 - this NIC was have 6Mpps TX traffic (when stack

Kernel 4.13.0-rc4-next-20170811 - IP Routing / Forwarding performance vs Core/RSS number / HT on

2017-08-11 Thread Paweł Staszewski
Hi I made some tests for performance comparison. Tested HW (FORWARDING HOST): Intel(R) Xeon(R) Gold 6132 CPU @ 2.60GHz Intel Corporation 82599ES 10-Gigabit SFI/SFP+ Network Connection (rev 01) Test diagram: TRAFFIC GENERATOR (ethX) -> (enp216s0f0 - RX Traffic) FORWARDING HOST

  1   2   >