Re: XDP redirect measurements, gotchas and tracepoints

2017-08-21 Thread Jesper Dangaard Brouer
On Mon, 21 Aug 2017 15:35:42 -0700 Alexei Starovoitov wrote: > On Mon, Aug 21, 2017 at 09:25:06PM +0200, Jesper Dangaard Brouer wrote: > > > > Third gotcha(3): You got this far, loaded xdp on both interfaces, and > > notice now that (with default setup) you can RX with 14Mpps but only > > TX wit

[PATCH] net: ftgmac100: Fix oops in probe on failure to find associated PHY

2017-08-21 Thread Andrew Jeffery
netif_napi_del() should be paired with netif_napi_add(), however no such call takes place in ftgmac100_probe(). This triggers a NULL pointer dereference if e.g. no PHY is found by the MDIO probe: [ 2.77] libphy: Fixed MDIO Bus: probed [ 2.77] ftgmac100 1e66.ethernet:

[PATCH v4 net-next] arm: eBPF JIT compiler

2017-08-21 Thread Shubham Bansal
The JIT compiler emits ARM 32 bit instructions. Currently, It supports eBPF only. Classic BPF is supported because of the conversion by BPF core. This patch is essentially changing the current implementation of JIT compiler of Berkeley Packet Filter from classic to internal with almost all instruc

Re: [PATCH] ptp: make ptp_clock_info const

2017-08-21 Thread Bhumika Goyal
On Tue, Aug 22, 2017 at 11:57 AM, Richard Cochran wrote: > On Mon, Aug 21, 2017 at 11:01:12PM +0530, Bhumika Goyal wrote: >> File ptp_ixp46x.c is not tested as I could not find any architecture >> to cross compile it. > > No problem. Thanks for test compiling the other drivers. > By testing I me

[PATCH v4 net-next] arm: eBPF JIT compiler

2017-08-21 Thread Shubham Bansal
The JIT compiler emits ARM 32 bit instructions. Currently, It supports eBPF only. Classic BPF is supported because of the conversion by BPF core. This patch is essentially changing the current implementation of JIT compiler of Berkeley Packet Filter from classic to internal with almost all instruc

[PATCH net-next v3 2/2] tcp: Remove the unused parameter for tcp_try_fastopen.

2017-08-21 Thread Tonghao Zhang
Signed-off-by: Tonghao Zhang --- include/net/tcp.h | 3 +-- net/ipv4/tcp_fastopen.c | 6 ++ net/ipv4/tcp_input.c| 2 +- 3 files changed, 4 insertions(+), 7 deletions(-) diff --git a/include/net/tcp.h b/include/net/tcp.h index afdab3781425..a995004ae946 100644 --- a/include/net/tcp.

[PATCH net-next v3 1/2] tcp: Get a proper dst before checking it.

2017-08-21 Thread Tonghao Zhang
tcp_peer_is_proven needs a proper route to make the determination, but dst always is NULL. This bug may be there at the beginning of git tree. This does not look serious enough to deserve backports to stable versions. Signed-off-by: Tonghao Zhang --- net/ipv4/tcp_input.c | 9 - 1 file ch

[PATCH net-next v3 0/2] Simplify the tcp_conn_request.

2017-08-21 Thread Tonghao Zhang
Just simplify the tcp_conn_request function. Tonghao Zhang (2): tcp: Get a proper dst before checking it. tcp: Remove the unused parameter for tcp_try_fastopen. include/net/tcp.h | 3 +-- net/ipv4/tcp_fastopen.c | 6 ++ net/ipv4/tcp_input.c| 11 +-- 3 files changed, 8

[PATCH net-next v4] arm: eBPF JIT compiler

2017-08-21 Thread Shubham Bansal
The JIT compiler emits ARM 32 bit instructions. Currently, It supports eBPF only. Classic BPF is supported because of the conversion by BPF core. This patch is essentially changing the current implementation of JIT compiler of Berkeley Packet Filter from classic to internal with almost all instruc

[PATCH net-next v4] arm: eBPF JIT compiler

2017-08-21 Thread Shubham Bansal
The JIT compiler emits ARM 32 bit instructions. Currently, It supports eBPF only. Classic BPF is supported because of the conversion by BPF core. This patch is essentially changing the current implementation of JIT compiler of Berkeley Packet Filter from classic to internal with almost all instruc

Re: [PATCH] ptp: make ptp_clock_info const

2017-08-21 Thread Richard Cochran
On Mon, Aug 21, 2017 at 11:01:12PM +0530, Bhumika Goyal wrote: > File ptp_ixp46x.c is not tested as I could not find any architecture > to cross compile it. No problem. Thanks for test compiling the other drivers. Acked-by: Richard Cochran

Re: [PATCH] net: ethernet: make ptp_clock_info const

2017-08-21 Thread Richard Cochran
On Mon, Aug 21, 2017 at 10:36:50PM +0530, Bhumika Goyal wrote: > Make these const as they are only used in a copy operation. > Done using Coccinelle. Acked-by: Richard Cochran

Re: [PATCH RESEND 0/2] enable hires timer to timeout datagram socket

2017-08-21 Thread Richard Cochran
On Mon, Aug 21, 2017 at 06:22:10PM +, Vallish Vaidyeshwara wrote: > AWS Lambda is affected by this change in behavior in > system call. Following links has more information: > https://en.wikipedia.org/wiki/AWS_Lambda Quote: Unlike Amazon EC2, which is priced by the hour, AWS Lambda is

Re: Something hitting my total number of connections to the server

2017-08-21 Thread Akshat Kakkar
On Tue, Aug 22, 2017 at 11:12 AM, Akshat Kakkar wrote: > There are multiple hosts/clients. All are mainly windows based. > > Timestamp is not used as my clients mainly are windows based and in > that it tcp timestamp is by defauly disabled. > > sysctl is as follows: > > kernel.shmmax = 68719476736

Re: Something hitting my total number of connections to the server

2017-08-21 Thread Akshat Kakkar
There are multiple hosts/clients. All are mainly windows based. Timestamp is not used as my clients mainly are windows based and in that it tcp timestamp is by defauly disabled. sysctl is as follows: kernel.shmmax = 68719476736 kernel.shmall = 4294967296 kernel.pid_max=4194303 vm.max_map_count=1

Re: [PATCH net-next 3/3 v5] drivers: net: ethernet: qualcomm: rmnet: Initial implementation

2017-08-21 Thread Subash Abhinov Kasiviswanathan
+ priv = netdev_priv(rmnet_dev); + memset(priv, 0, sizeof(struct rmnet_priv)); Netdev private area is always zero on creation. See alloc_netdev(). + if (!rmnet_dev) + return 0; Do not confuse 0 with NULL. Did you run sparse? + + priv = netdev_priv(rmne

Re: skb_over_panic when sending esp traffic from a vmware guest

2017-08-21 Thread Steffen Klassert
On Thu, Aug 17, 2017 at 07:19:03PM +, Nick Huber wrote: > I've been experience the following traceback since upgrading from the 4.9 > kernel to the 4.11 branch. I've only seen this in a few VMWare guests and I > haven't been able to narrow down what exactly is causing it. I'm not familiar >

Re: [PATCH net-next 1/3 v7] net: ether: Add support for multiplexing and aggregation type

2017-08-21 Thread Subash Abhinov Kasiviswanathan
+#define ETH_P_MAP 0xDA1A /* Multiplexing and Aggregation Protocol +* NOT AN OFFICIALLY REGISTERED ID ] +*/ Hi Subash This list is sorted. So this entry should go earlier. + netdev_info(real

Re: [RFC PATCH] dt-binding: net: sfp binding documentation

2017-08-21 Thread Baruch Siach
Hi Rob, On Mon, Aug 21, 2017 at 02:10:33PM -0500, Rob Herring wrote: > On Sun, Aug 20, 2017 at 5:28 AM, Baruch Siach wrote: > > Add device-tree binding documentation SFP transceivers. Support for SFP > > transceivers has been recently introduced (drivers/net/phy/sfp.c). > > > > Signed-off-by: Bar

Re: [RFC net-next v2] bridge lwtunnel, VPLS & NVGRE

2017-08-21 Thread Roopa Prabhu
On Mon, Aug 21, 2017 at 10:15 AM, David Lamparter wrote: > Hi all, > > > this is an update on the earlier "[RFC net-next] VPLS support". Note > I've changed the subject lines on some of the patches to better reflect > what they really do (tbh the earlier subject lines were crap.) > > As previousl

[PATCH v2 1/4] net: stmmac: dwmac-sun8i: support RGMII modes with PHY internal delay

2017-08-21 Thread Icenowy Zheng
Some boards uses a PHY with internal delay with an Allwinner SoC. Support these PHY modes in the driver. As the driver has no configuration registers for these modes, just treat them as ordinary RGMII. Signed-off-by: Icenowy Zheng --- drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c | 3 +++

[PATCH v2 0/4] Workaround broken RTL8211E on some Pine64+ boards

2017-08-21 Thread Icenowy Zheng
Some Pine64+ boards come with bad RTL8211E PHYs, which cannot work reliably unless do some hack. According to Pine64 people, Realtek describes the hack as totally disabling RX delay, and it's not documented at all. This patchset introduces the workaround on Pine64+. The first patch adds RGMII var

[PATCH v2 2/4] net: phy: realtek: change macro name for page select register

2017-08-21 Thread Icenowy Zheng
From: Icenowy Zheng The page select register also exists on RTL8211E PHY (although it behaves slightly differently). Change the register macro name to remove the F. Signed-off-by: Icenowy Zheng --- drivers/net/phy/realtek.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) d

Re: [PATCHv3 iproute2 net-next] gre: add support for ERSPAN tunnel

2017-08-21 Thread Stephen Hemminger
On Fri, 18 Aug 2017 05:54:08 -0700 William Tu wrote: > The patch adds ERSPAN type II tunnel support. The implementation > is based on the draft at https://tools.ietf.org/html/draft-foschiano-erspan-01 > One of the purposes is for Linux box to be able to receive ERSPAN > monitoring traffic sent f

Re: [PATCH net-next 3/3 v5] drivers: net: ethernet: qualcomm: rmnet: Initial implementation

2017-08-21 Thread Stephen Hemminger
> +void rmnet_vnd_setup(struct net_device *rmnet_dev) > +{ > + struct rmnet_priv *priv; > + > + /* Clear out private data */ > + priv = netdev_priv(rmnet_dev); > + memset(priv, 0, sizeof(struct rmnet_priv)); Netdev private area is always zero on creation. See alloc_netdev(). > +s

[PATCH v2 3/4] net: phy: realtek: add disable RX internal delay mode

2017-08-21 Thread Icenowy Zheng
From: Icenowy Zheng Some RTL8211E chips have broken GbE function, which needs a hack to fix. It's said that this fix will affect the performance on not-buggy PHYs, so it should only be enabled on boards with the broken PHY. Currently only some Pine64+ boards are known to have this issue. This ha

[PATCH v2 4/4] arm64: allwinner: a64: disable the RTL8211E internal RX delay on Pine64+

2017-08-21 Thread Icenowy Zheng
Some Pine64+ boards have a broken RTL8211E PHY, which cannot work reliably in 1000Base-T mode with default configuration. A solution is passed to Pine64, which is said to be disabling the internal RX delay of the PHY. Enable the hack by set the PHY mode to RGMII-TXID. Signed-off-by: Icenowy Zhen

Re: [PATCH net-next] virtio-net: invoke zerocopy callback on xmit path if no tx napi

2017-08-21 Thread Willem de Bruijn
>>> Interesting, deadlock could be treated as a a radical case of the >>> discussion >>> here https://patchwork.kernel.org/patch/3787671/. >>> >>> git grep tells more similar skb_orphan() cases. Do we need to change them >>> all (or part)? >> >> Most skb_orphan calls are not relevant to the issue o

Re: [PATCH net-next] virtio-net: invoke zerocopy callback on xmit path if no tx napi

2017-08-21 Thread Jason Wang
On 2017年08月21日 23:41, Willem de Bruijn wrote: On Mon, Aug 21, 2017 at 8:33 AM, Jason Wang wrote: On 2017年08月19日 14:38, Koichiro Den wrote: Facing the possible unbounded delay relying on freeing on xmit path, we also better to invoke and clear the upper layer zerocopy callback beforehand to

[PATCH net-next,2/4] hv_netvsc: Clean up unused parameter from netvsc_get_rss_hash_opts()

2017-08-21 Thread Haiyang Zhang
From: Haiyang Zhang The parameter "nvdev" is not in use. Signed-off-by: Haiyang Zhang --- drivers/net/hyperv/netvsc_drv.c |5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/net/hyperv/netvsc_drv.c b/drivers/net/hyperv/netvsc_drv.c index 4677d21..d8612b1 100644

[PATCH net-next,0/4] hv_netvsc: Ethtool handler to change UDP hash levels

2017-08-21 Thread Haiyang Zhang
From: Haiyang Zhang The patch set adds the functions to switch UDP hash level between L3 and L4 by ethtool command. UDP over IPv4 and v6 can be set differently. The default hash level is L4. We currently only allow switching TX hash level from within the guests. The ethtool callback function is

[PATCH net-next,4/4] hv_netvsc: Update netvsc Document for UDP hash level setting

2017-08-21 Thread Haiyang Zhang
From: Haiyang Zhang Update Documentation/networking/netvsc.txt for UDP hash level setting and related info. Signed-off-by: Haiyang Zhang --- Documentation/networking/netvsc.txt | 22 +- 1 files changed, 17 insertions(+), 5 deletions(-) diff --git a/Documentation/networki

[PATCH net-next,3/4] hv_netvsc: Add ethtool handler to set and get UDP hash levels

2017-08-21 Thread Haiyang Zhang
From: Haiyang Zhang The patch add the functions to switch UDP hash level between L3 and L4 by ethtool command. UDP over IPv4 and v6 can be set differently. The default hash level is L4. We currently only allow switching TX hash level from within the guests. On Azure, fragmented UDP packets have

[PATCH net-next,1/4] hv_netvsc: Clean up unused parameter from netvsc_get_hash()

2017-08-21 Thread Haiyang Zhang
From: Haiyang Zhang The parameter "sk" is not in use. Signed-off-by: Haiyang Zhang --- drivers/net/hyperv/netvsc_drv.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/hyperv/netvsc_drv.c b/drivers/net/hyperv/netvsc_drv.c index b33f050..4677d21 100644 ---

Re: [PATCH net-next] liquidio: show NIC's U-Boot version in a dev_info() message

2017-08-21 Thread Andrew Lunn
On Mon, Aug 21, 2017 at 06:19:44PM -0700, Felix Manlunas wrote: > From: Weilin Chang > > Signed-off-by: Weilin Chang > Signed-off-by: Felix Manlunas > --- > .../net/ethernet/cavium/liquidio/octeon_console.c | 85 > ++ > .../net/ethernet/cavium/liquidio/octeon_device.h |

linux-next: manual merge of the net-next tree with the rockchip tree

2017-08-21 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the net-next tree got a conflict in: arch/arm64/boot/dts/rockchip/rk3328-evb.dts between commits: ab78718bda79 ("arm64: dts: rockchip: Enable tsadc module on RK3328 eavluation board") 1e28037ec88e ("arm64: dts: rockchip: add rk805 node for rk3328-evb")

[PATCH net-next] liquidio: show NIC's U-Boot version in a dev_info() message

2017-08-21 Thread Felix Manlunas
From: Weilin Chang Signed-off-by: Weilin Chang Signed-off-by: Felix Manlunas --- .../net/ethernet/cavium/liquidio/octeon_console.c | 85 ++ .../net/ethernet/cavium/liquidio/octeon_device.h | 5 ++ 2 files changed, 90 insertions(+) diff --git a/drivers/net/ethernet/cavi

Re: [PATCH net-next 3/3 v7] drivers: net: ethernet: qualcomm: rmnet: Initial implementation

2017-08-21 Thread Andrew Lunn
> +static int rmnet_unregister_real_device(struct net_device *real_dev) > +{ > + struct rmnet_real_dev_info *rdinfo; > + struct list_head *iter; > + > + ASSERT_RTNL(); > + > + if (!rmnet_is_real_dev_registered(real_dev) || > + netdev_lower_get_next(real_dev, &iter)) > +

Re: [PATCH net] udp: on peeking bad csum, drop packets even if not at head

2017-08-21 Thread Willem de Bruijn
On Mon, Aug 21, 2017 at 8:12 PM, Willem de Bruijn wrote: > On Mon, Aug 21, 2017 at 6:40 PM, Eric Dumazet wrote: >> On Mon, 2017-08-21 at 17:39 -0400, Willem de Bruijn wrote: >>> From: Willem de Bruijn >>> >>> When peeking, if a bad csum is discovered, the skb is unlinked from >>> the queue with

Re: [PATCH net-next 1/3 v7] net: ether: Add support for multiplexing and aggregation type

2017-08-21 Thread Andrew Lunn
On Mon, Aug 21, 2017 at 04:36:57PM -0600, Subash Abhinov Kasiviswanathan wrote: > Define the multiplexing and aggregation (MAP) ether type 0xDA1A. This > is needed for receiving data in the MAP protocol like RMNET. This is > not an officially registered ID. > > Signed-off-by: Subash Abhinov Kasivi

Re: [PATCH net-next v2 1/2] tcp: Remove unnecessary dst check in tcp_conn_request.

2017-08-21 Thread Tonghao Zhang
On Mon, Aug 21, 2017 at 10:56 PM, Eric Dumazet wrote: > Please do not top post. Got it, thanks. > On Mon, 2017-08-21 at 21:24 +0800, Tonghao Zhang wrote: >> Thanks, yes this is a bug. I found this bug exists from 3.17~ 4.13. >> The commit is d94e0417 >> > > This bug was there at the beginning o

Re: Re: [PATCH net-next] net: sched: Add the invalid handle check in qdisc_class_find

2017-08-21 Thread Cong Wang
On Mon, Aug 21, 2017 at 5:46 PM, Gao Feng wrote: > Hi Cong, > > Thanks your reminder firstly. > But I had used the get_maintainer.pl actually before sent the patch. > > The following is the output. > [fgao@ikuai8 net-next]#./scripts/get_maintainer.pl > patch_ScheCheck/0001-net-sched-Add-the-inval

Re:Re: [PATCH net-next] net: sched: Add the invalid handle check in qdisc_class_find

2017-08-21 Thread Gao Feng
At 2017-08-22 03:58:03, "Cong Wang" wrote: >On Mon, Aug 21, 2017 at 10:47 AM, David Miller wrote: >> From: gfree.w...@vip.163.com >> Date: Fri, 18 Aug 2017 15:23:24 +0800 >> >>> From: Gao Feng >>> >>> Add the invalid handle "0" check to avoid unnecessary search, because >>> the qdisc uses the sk

Re: [PATCH v2 2/2] net: phy: Don't use drv when it is NULL in phy_attached_print

2017-08-21 Thread Florian Fainelli
On 08/21/2017 07:24 AM, Andrew Lunn wrote: > On Mon, Aug 21, 2017 at 01:45:30PM +0200, Romain Perier wrote: >> Currently, if this logging function is used prior the phy driver is >> bound to the phy device (that is usually done from .ndo_open), >> 'phydev->drv' might be NULL, resulting in a kernel

Re: [PATCH v2 1/2] net: stmmac: Delete dead code for MDIO registration

2017-08-21 Thread Florian Fainelli
On 08/21/2017 04:45 AM, Romain Perier wrote: > This code is no longer used, the logging function was changed by commit > fbca164776e4 ("net: stmmac: Use the right logging functi"). > > Fixes: fbca164776e4 ("net: stmmac: Use the right logging functi") > Signed-off-by: Romain Perier > --- > driver

Re: [iproute PATCH v2] lib/bpf: Don't leak fp in bpf_find_mntpt()

2017-08-21 Thread Stephen Hemminger
On Mon, 21 Aug 2017 16:46:51 +0200 Phil Sutter wrote: > If fopen() succeeded but len != PATH_MAX, the function leaks the open > FILE pointer. Fix this by checking len value before calling fopen(). > > Signed-off-by: Phil Sutter > Acked-by: Daniel Borkmann Thanks, Applied

Re: [iproute PATCH v2 2/7] ss: Make sure index variable is >= 0

2017-08-21 Thread Stephen Hemminger
On Mon, 21 Aug 2017 19:08:08 +0200 Phil Sutter wrote: > This shouldn't happen but relying upon external data without checking > may lead to unexpected results. > > Signed-off-by: Phil Sutter > --- > misc/ss.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/misc/ss.c b

Re: [RFC net-next v2] bridge lwtunnel, VPLS & NVGRE

2017-08-21 Thread David Lamparter
On Mon, Aug 21, 2017 at 05:01:51PM -0700, Stephen Hemminger wrote: > On Mon, 21 Aug 2017 19:15:17 +0200 David Lamparter wrote: > > > P.S.: For a little context on the bridge FDB changes - I'm hoping to > > > find some time to extend this to the MDB to allow aggregating dst > > > metadata and handi

Re: [iproute PATCH v2 0/3] Covscan: Fix for missing error checking

2017-08-21 Thread Stephen Hemminger
On Mon, 21 Aug 2017 18:36:49 +0200 Phil Sutter wrote: > This series collects patches from v1 dealing with spots where error > checking is necessary or recommended. > > Minor changes to patches 1 and 2, patch 3 remains unchanged. > > Phil Sutter (3): > iproute: Check mark value input > iplin

Re: [iproute PATCH v3 2/7] xfrm_state: Make sure alg_name is NULL-terminated

2017-08-21 Thread Stephen Hemminger
On Mon, 21 Aug 2017 15:23:36 +0200 Phil Sutter wrote: > Signed-off-by: Phil Sutter > --- > ip/xfrm_state.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/ip/xfrm_state.c b/ip/xfrm_state.c > index e11c93bf1c3b5..7c0389038986e 100644 > --- a/ip/xfrm_state.c > +++ b/ip

Re: [iproute PATCH v2 1/7] nstat: Avoid passing negative fd to fdopen()

2017-08-21 Thread Stephen Hemminger
On Mon, 21 Aug 2017 19:08:07 +0200 Phil Sutter wrote: > Introduce a wrapper which does the sanity checking and returns NULL > in case fd is invalid. > > Signed-off-by: Phil Sutter > --- > misc/nstat.c | 15 +++ > 1 file changed, 11 insertions(+), 4 deletions(-) > > diff --git a/mi

Re: [iproute PATCH v3 2/5] nstat: Fix for potential NULL pointer dereference

2017-08-21 Thread Stephen Hemminger
On Mon, 21 Aug 2017 12:03:05 +0200 Phil Sutter wrote: > If the string at 'p' contains neither space not newline, 'p' will become > NULL. Make sure this isn't the case before dereferencing it. > > Signed-off-by: Phil Sutter > --- > Changes since v2: > - Call abort() if 'p' becomes NULL. > --- >

Re: [iproute PATCH v3 0/6] Covscan: Don't access garbage

2017-08-21 Thread Stephen Hemminger
On Mon, 21 Aug 2017 11:26:58 +0200 Phil Sutter wrote: > This series collects patches from v1 which resolve situations where > garbage might be read, either due to missing initialization of > variables or accessing data which went out of scope. > > Changes since v2: > - Rebased onto current maste

Re: [iproute PATCH v2 0/7] Covscan: Dead code elimination

2017-08-21 Thread Stephen Hemminger
On Thu, 17 Aug 2017 19:09:24 +0200 Phil Sutter wrote: > This series collects patches from v1 which deal with dead code, either > by removing it or changing context so it is accessed again if that makes > sense. > > No changes to the actual patches, just splitting into smaller series. > > Phil S

Re: [PATCH v6 iproute2 0/8] RDMAtool

2017-08-21 Thread Stephen Hemminger
On Sun, 20 Aug 2017 12:58:20 +0300 Leon Romanovsky wrote: > From: Leon Romanovsky > > This is fifth revision of series implementing the RDAMtool - the tool > to configure RDMA devices. > > It looks like everyone who was interested to read cover letter already did it, > so I'll start from the

Re: [PATCH net] udp: on peeking bad csum, drop packets even if not at head

2017-08-21 Thread Willem de Bruijn
On Mon, Aug 21, 2017 at 6:40 PM, Eric Dumazet wrote: > On Mon, 2017-08-21 at 17:39 -0400, Willem de Bruijn wrote: >> From: Willem de Bruijn >> >> When peeking, if a bad csum is discovered, the skb is unlinked from >> the queue with __sk_queue_drop_skb and the peek operation restarted. >> >> __sk_

Re: [PATCH net-next] net: dsa: User per-cpu 64-bit statistics

2017-08-21 Thread Florian Fainelli
On 08/21/2017 04:23 PM, Florian Fainelli wrote: > On 08/04/2017 10:11 AM, Eric Dumazet wrote: >> On Fri, 2017-08-04 at 08:51 -0700, Florian Fainelli wrote: >>> On 08/03/2017 10:36 PM, Eric Dumazet wrote: On Thu, 2017-08-03 at 21:33 -0700, Florian Fainelli wrote: > During testing with a bac

Re: [RFC net-next v2] bridge lwtunnel, VPLS & NVGRE

2017-08-21 Thread Stephen Hemminger
On Mon, 21 Aug 2017 19:15:17 +0200 David Lamparter wrote: > Hi all, > > > this is an update on the earlier "[RFC net-next] VPLS support". Note > I've changed the subject lines on some of the patches to better reflect > what they really do (tbh the earlier subject lines were crap.) > > As prev

[PATCH] once: switch to new jump label API

2017-08-21 Thread Eric Biggers
From: Eric Biggers Switch the DO_ONCE() macro from the deprecated jump label API to the new one. The new one is more readable, and for DO_ONCE() it also makes the generated code more icache-friendly: now the one-time initialization code is placed out-of-line at the jump target, rather than at th

Re: [PATCH net-next] net: dsa: User per-cpu 64-bit statistics

2017-08-21 Thread Florian Fainelli
On 08/04/2017 10:11 AM, Eric Dumazet wrote: > On Fri, 2017-08-04 at 08:51 -0700, Florian Fainelli wrote: >> On 08/03/2017 10:36 PM, Eric Dumazet wrote: >>> On Thu, 2017-08-03 at 21:33 -0700, Florian Fainelli wrote: During testing with a background iperf pushing 1Gbit/sec worth of traffic

Re: [PATCH net-next,1/4] hv_netvsc: Clean up unused parameter from netvsc_get_hash()

2017-08-21 Thread David Miller
All proper patch series must have a header "[PATCH xxx 0/N]" posting which explains at a high level what the patch series does, how it does it, and why it is doing it that way. Therefore, please resubmit this patch series with a proper header posting. Thank you.

Re: [PATCH net] udp: on peeking bad csum, drop packets even if not at head

2017-08-21 Thread Eric Dumazet
On Mon, 2017-08-21 at 17:39 -0400, Willem de Bruijn wrote: > From: Willem de Bruijn > > When peeking, if a bad csum is discovered, the skb is unlinked from > the queue with __sk_queue_drop_skb and the peek operation restarted. > > __sk_queue_drop_skb only drops packets that match the queue head.

Re: [PATCH net] udp: on peeking bad csum, drop packets even if not at head

2017-08-21 Thread Willem de Bruijn
On Mon, Aug 21, 2017 at 5:39 PM, Willem de Bruijn wrote: > From: Willem de Bruijn > > When peeking, if a bad csum is discovered, the skb is unlinked from > the queue with __sk_queue_drop_skb and the peek operation restarted. > > __sk_queue_drop_skb only drops packets that match the queue head. Wi

[PATCH net-next 1/3 v7] net: ether: Add support for multiplexing and aggregation type

2017-08-21 Thread Subash Abhinov Kasiviswanathan
Define the multiplexing and aggregation (MAP) ether type 0xDA1A. This is needed for receiving data in the MAP protocol like RMNET. This is not an officially registered ID. Signed-off-by: Subash Abhinov Kasiviswanathan --- include/uapi/linux/if_ether.h | 4 +++- 1 file changed, 3 insertions(+), 1

[PATCH net-next 2/3 v7] net: arp: Add support for raw IP device

2017-08-21 Thread Subash Abhinov Kasiviswanathan
Define the raw IP type. This is needed for raw IP net devices like rmnet. Signed-off-by: Subash Abhinov Kasiviswanathan --- include/uapi/linux/if_arp.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/uapi/linux/if_arp.h b/include/uapi/linux/if_arp.h index cf73510..a2a6356 100644 ---

[PATCH net-next 3/3 v7] drivers: net: ethernet: qualcomm: rmnet: Initial implementation

2017-08-21 Thread Subash Abhinov Kasiviswanathan
RmNet driver provides a transport agnostic MAP (multiplexing and aggregation protocol) support in embedded module. Module provides virtual network devices which can be attached to any IP-mode physical device. This will be used to provide all MAP functionality on future hardware in a single consiste

[PATCH net-next 0/3 v7] Add support for rmnet driver

2017-08-21 Thread Subash Abhinov Kasiviswanathan
This patch adds support for the rmnet driver which is required to support recent chipsets using Qualcomm Technologies, Inc. modems. The data from hardware follows the multiplexing and aggregation protocol (MAP). This driver can be used to register onto any physical network device in IP mode. Physi

Re: XDP redirect measurements, gotchas and tracepoints

2017-08-21 Thread Alexei Starovoitov
On Mon, Aug 21, 2017 at 09:25:06PM +0200, Jesper Dangaard Brouer wrote: > > Third gotcha(3): You got this far, loaded xdp on both interfaces, and > notice now that (with default setup) you can RX with 14Mpps but only > TX with 6.9Mpps (and might have 5% idle cycles). I debugged this via > perf tr

Re: [PATCH v2] mt7601u: check memory allocation failure

2017-08-21 Thread Jakub Kicinski
On Tue, 22 Aug 2017 00:06:17 +0200, Christophe JAILLET wrote: > Check memory allocation failure and return -ENOMEM in such a case, as > already done a few lines below. > > As 'dev->tx_q' can be NULL, we also need to check for that in > 'mt7601u_free_tx()', and return early. > > Signed-off-by: Chr

Re: [PATCH net] net: dsa: skb_put_padto() already frees nskb

2017-08-21 Thread Florian Fainelli
On 08/21/2017 03:15 PM, woojung@microchip.com wrote: > Florian, > >> -Original Message- >> From: Florian Fainelli [mailto:f.faine...@gmail.com] >> Sent: Monday, August 21, 2017 3:42 PM >> To: netdev@vger.kernel.org >> Cc: da...@davemloft.net; and...@lunn.ch; >> vivien.dide...@savoirfai

RE: [PATCH net] net: dsa: skb_put_padto() already frees nskb

2017-08-21 Thread Woojung.Huh
Florian, > -Original Message- > From: Florian Fainelli [mailto:f.faine...@gmail.com] > Sent: Monday, August 21, 2017 3:42 PM > To: netdev@vger.kernel.org > Cc: da...@davemloft.net; and...@lunn.ch; > vivien.dide...@savoirfairelinux.com; Woojung Huh - C21699; Florian Fainelli > Subject: [PAT

Re: [PATCH] mt7601u: check memory allocation failure

2017-08-21 Thread Christophe JAILLET
Le 21/08/2017 à 23:41, Jakub Kicinski a écrit : On Mon, 21 Aug 2017 14:34:30 -0700, Jakub Kicinski wrote: On Mon, 21 Aug 2017 22:59:56 +0200, Christophe JAILLET wrote: Check memory allocation failure and return -ENOMEM in such a case, as already done a few lines below Signed-off-by: Christophe

Re: [PATCH net-next 03/11] net: dsa: debugfs: add tree

2017-08-21 Thread Florian Fainelli
On 08/14/2017 03:22 PM, Vivien Didelot wrote: > This commit adds the boiler plate to create a DSA related debug > filesystem entry as well as a "tree" file, containing the tree index. > > # cat switch1/tree > 0 > > Signed-off-by: Vivien Didelot Reviewed-by: Florian Fainelli -- Florian

[PATCH v2] mt7601u: check memory allocation failure

2017-08-21 Thread Christophe JAILLET
Check memory allocation failure and return -ENOMEM in such a case, as already done a few lines below. As 'dev->tx_q' can be NULL, we also need to check for that in 'mt7601u_free_tx()', and return early. Signed-off-by: Christophe JAILLET --- v2: avoid another NULL pointer dereference in 'mt7601u_

[PATCH net-next,1/4] hv_netvsc: Clean up unused parameter from netvsc_get_hash()

2017-08-21 Thread Haiyang Zhang
From: Haiyang Zhang The parameter "sk" is not in use. Signed-off-by: Haiyang Zhang --- drivers/net/hyperv/netvsc_drv.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/hyperv/netvsc_drv.c b/drivers/net/hyperv/netvsc_drv.c index b33f050..4677d21 100644 ---

[PATCH net-next,2/4] hv_netvsc: Clean up unused parameter from netvsc_get_rss_hash_opts()

2017-08-21 Thread Haiyang Zhang
From: Haiyang Zhang The parameter "nvdev" is not in use. Signed-off-by: Haiyang Zhang --- drivers/net/hyperv/netvsc_drv.c |5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/net/hyperv/netvsc_drv.c b/drivers/net/hyperv/netvsc_drv.c index 4677d21..d8612b1 100644

[PATCH net-next,3/4] hv_netvsc: Add ethtool handler to set and get UDP hash levels

2017-08-21 Thread Haiyang Zhang
From: Haiyang Zhang The patch add the functions to switch UDP hash level between L3 and L4 by ethtool command. UDP over IPv4 and v6 can be set differently. The default hash level is L4. We currently only allow switching TX hash level from within the guests. On Azure, fragmented UDP packets have

[PATCH net-next,4/4] hv_netvsc: Update netvsc Document for UDP hash level setting

2017-08-21 Thread Haiyang Zhang
From: Haiyang Zhang Update Documentation/networking/netvsc.txt for UDP hash level setting and related info. Signed-off-by: Haiyang Zhang --- Documentation/networking/netvsc.txt | 22 +- 1 files changed, 17 insertions(+), 5 deletions(-) diff --git a/Documentation/networki

Re: [PATCH] mt7601u: check memory allocation failure

2017-08-21 Thread Jakub Kicinski
On Mon, 21 Aug 2017 14:34:30 -0700, Jakub Kicinski wrote: > On Mon, 21 Aug 2017 22:59:56 +0200, Christophe JAILLET wrote: > > Check memory allocation failure and return -ENOMEM in such a case, as > > already done a few lines below > > > > Signed-off-by: Christophe JAILLET > > Acked-by: Jakub K

[PATCH net] udp: on peeking bad csum, drop packets even if not at head

2017-08-21 Thread Willem de Bruijn
From: Willem de Bruijn When peeking, if a bad csum is discovered, the skb is unlinked from the queue with __sk_queue_drop_skb and the peek operation restarted. __sk_queue_drop_skb only drops packets that match the queue head. With sk_peek_off, the skb need not be at head, causing the call to fai

Re: [PATCH] mt7601u: check memory allocation failure

2017-08-21 Thread Jakub Kicinski
On Mon, 21 Aug 2017 22:59:56 +0200, Christophe JAILLET wrote: > Check memory allocation failure and return -ENOMEM in such a case, as > already done a few lines below > > Signed-off-by: Christophe JAILLET Acked-by: Jakub Kicinski Thanks!

Re: [PATCH v3 net-next] bpf/verifier: track liveness for pruning

2017-08-21 Thread Alexei Starovoitov
On 8/21/17 2:00 PM, Daniel Borkmann wrote: On 08/21/2017 10:44 PM, Edward Cree wrote: On 21/08/17 21:27, Daniel Borkmann wrote: On 08/21/2017 08:36 PM, Edward Cree wrote: On 19/08/17 00:37, Alexei Starovoitov wrote: [...] I'm tempted to just rip out env->varlen_map_value_access and always ch

Re: [PATCH v3 net-next] bpf/verifier: track liveness for pruning

2017-08-21 Thread Alexei Starovoitov
On 8/21/17 1:24 PM, Edward Cree wrote: On 18/08/17 15:16, Edward Cree wrote: On 18/08/17 04:21, Alexei Starovoitov wrote: It seems you're trying to sort-of do per-fake-basic block liveness analysis, but our state_list_marks are not correct if we go with canonical basic block definition, since w

Re: [RFC] about net: Fix inconsistent teardown and release of private netdev state.

2017-08-21 Thread David Miller
From: Eric Dumazet Date: Fri, 18 Aug 2017 20:40:01 -0700 > Let look at tun->pcpu_stats, for example. > > It is allocated at line 1831, before the register_netdevice() > > drivers/net/tun.c does not provide ndo_init() I see the problem now. And it's done this way because several steps need to

Re: [PATCH net-next 3/3 v6] drivers: net: ethernet: qualcomm: rmnet: Initial implementation

2017-08-21 Thread David Miller
From: Subash Abhinov Kasiviswanathan Date: Fri, 18 Aug 2017 23:35:31 -0600 > diff --git a/drivers/net/ethernet/qualcomm/Makefile > b/drivers/net/ethernet/qualcomm/Makefile > index 92fa7c4..c4f38bd 100644 > --- a/drivers/net/ethernet/qualcomm/Makefile > +++ b/drivers/net/ethernet/qualcomm/Makefil

Re: [PATCH v3 net-next] bpf/verifier: track liveness for pruning

2017-08-21 Thread Daniel Borkmann
On 08/21/2017 10:44 PM, Edward Cree wrote: On 21/08/17 21:27, Daniel Borkmann wrote: On 08/21/2017 08:36 PM, Edward Cree wrote: On 19/08/17 00:37, Alexei Starovoitov wrote: [...] I'm tempted to just rip out env->varlen_map_value_access and always check the whole thing, because honestly I d

[PATCH] mt7601u: check memory allocation failure

2017-08-21 Thread Christophe JAILLET
Check memory allocation failure and return -ENOMEM in such a case, as already done a few lines below Signed-off-by: Christophe JAILLET --- drivers/net/wireless/mediatek/mt7601u/dma.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/wireless/mediatek/mt7601u/dma.c b/drivers/net/

Re: [PATCH v3 net-next] bpf/verifier: track liveness for pruning

2017-08-21 Thread Edward Cree
On 21/08/17 21:27, Daniel Borkmann wrote: > On 08/21/2017 08:36 PM, Edward Cree wrote: >> On 19/08/17 00:37, Alexei Starovoitov wrote: > [...] >> I'm tempted to just rip out env->varlen_map_value_access and always check >> the whole thing, because honestly I don't know what it was meant to do >>

Re: [PATCH net-next] net: sched: Add the invalid handle check in qdisc_class_find

2017-08-21 Thread David Miller
From: gfree.w...@vip.163.com Date: Fri, 18 Aug 2017 15:23:24 +0800 > From: Gao Feng > > Add the invalid handle "0" check to avoid unnecessary search, because > the qdisc uses the skb->priority as the handle value to look up, and > it is "0" usually. > > Signed-off-by: Gao Feng Applied, thanks

Re: [net-next 1/1] tipc: don't reset stale broadcast send link

2017-08-21 Thread David Miller
From: Jon Maloy Date: Mon, 21 Aug 2017 17:59:30 +0200 > When the broadcast send link after 100 attempts has failed to > transfer a packet to all peers, we consider it stale, and reset > it. Thereafter it needs to re-synchronize with the peers, something > currently done by just resetting and re-e

Re: [PATCH v3 net-next] bpf/verifier: track liveness for pruning

2017-08-21 Thread Daniel Borkmann
On 08/21/2017 08:36 PM, Edward Cree wrote: On 19/08/17 00:37, Alexei Starovoitov wrote: [...] I'm tempted to just rip out env->varlen_map_value_access and always check the whole thing, because honestly I don't know what it was meant to do originally or how it can ever do any useful pruning.

Re: [PATCH v3 net-next] bpf/verifier: track liveness for pruning

2017-08-21 Thread Edward Cree
On 18/08/17 15:16, Edward Cree wrote: > On 18/08/17 04:21, Alexei Starovoitov wrote: >> It seems you're trying to sort-of do per-fake-basic block liveness >> analysis, but our state_list_marks are not correct if we go with >> canonical basic block definition, since we mark the jump insn and >> not

Re: [PATCH net-next] net: sched: Add the invalid handle check in qdisc_class_find

2017-08-21 Thread Jamal Hadi Salim
On 17-08-21 03:58 PM, Cong Wang wrote: On Mon, Aug 21, 2017 at 10:47 AM, David Miller wrote: From: gfree.w...@vip.163.com Date: Fri, 18 Aug 2017 15:23:24 +0800 From: Gao Feng Add the invalid handle "0" check to avoid unnecessary search, because the qdisc uses the skb->priority as the handle

Re: [PATCH RESEND 1/2] net: enable high resolution timer mode to timeout datagram sockets

2017-08-21 Thread Cong Wang
On Fri, Aug 18, 2017 at 11:44 AM, Vallish Vaidyeshwara wrote: > - *timeo_p = schedule_timeout(*timeo_p); > + /* Wait using highres timer */ > + expires = ktime_add_ns(ktime_get(), jiffies_to_nsecs(*timeo_p)); > + pre_sched_time = jiffies; > + if (schedule_hrtimeout(&e

[PATCH net] net/hsr: Check skb_put_padto() return value

2017-08-21 Thread Florian Fainelli
skb_put_padto() will free the sk_buff passed as reference in case of errors, but we still need to check its return value and decide what to do. Detected by CoverityScan, CID#1416688 ("CHECKED_RETURN") Fixes: ee1c27977284 ("net/hsr: Added support for HSR v1") Signed-off-by: Florian Fainelli ---

Re: [PATCH net-next] net: sched: Add the invalid handle check in qdisc_class_find

2017-08-21 Thread Cong Wang
On Mon, Aug 21, 2017 at 10:47 AM, David Miller wrote: > From: gfree.w...@vip.163.com > Date: Fri, 18 Aug 2017 15:23:24 +0800 > >> From: Gao Feng >> >> Add the invalid handle "0" check to avoid unnecessary search, because >> the qdisc uses the skb->priority as the handle value to look up, and >> i

Re: [linux-sunxi] Re: [PATCH 2/4] dt-bindings: add binding for RTL8211E Ethernet PHY

2017-08-21 Thread Florian Fainelli
On 08/21/2017 07:53 AM, icen...@aosc.io wrote: > 在 2017-05-05 02:29,Florian Fainelli 写道: >> On 05/04/2017 11:26 AM, Icenowy Zheng wrote: >>> >>> >>> 于 2017年5月5日 GMT+08:00 上午2:21:29, Florian Fainelli >>> 写到: On 05/04/2017 11:10 AM, icen...@aosc.io wrote: > 在 2017-04-22 08:22,Florian Fainel

Re: [PATCH net] net: dsa: skb_put_padto() already frees nskb

2017-08-21 Thread Andrew Lunn
On Mon, Aug 21, 2017 at 12:41:43PM -0700, Florian Fainelli wrote: > skb_put_padto() already frees the passed sk_buff reference upon error, > so calling kfree_skb() on it again is not necessary. > > Detected by CoverityScan, CID#1416687 ("USE_AFTER_FREE") > > Fixes: e71cb9e00922 ("net: dsa: ksz: f

Re: [PATCH 1/2] vhost: remove the possible fruitless search on iotlb prefetch

2017-08-21 Thread Michael S. Tsirkin
On Sat, Aug 19, 2017 at 03:41:14PM +0900, Koichiro Den wrote: > Signed-off-by: Koichiro Den > --- > drivers/vhost/vhost.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c > index e4613a3c362d..93e909afc1c3 100644 > --- a/drive

[PATCH] vhost: fix end of range for access_ok

2017-08-21 Thread Michael S. Tsirkin
During access_ok checks, addr increases as we iterate over the data structure, thus addr + len - 1 will point beyond the end of region we are translating. Harmless since we then verify that the region covers addr, but let's not waste cpu cycles. Reported-by: Koichiro Den Signed-off-by: Michael S

  1   2   3   4   >