[patch net] mlxsw: spectrum: Prevent mirred-related crash on removal

2017-09-11 Thread Jiri Pirko
From: Yuval Mintz When removing the offloading of mirred actions under matchall classifiers, mlxsw would find the destination port associated with the offloaded action and utilize it for undoing the configuration. Depending on the order by which ports are removed, it's possible that the destinat

Re: [RFC PATCH] net: Introduce a socket option to enable picking tx queue based on rx queue.

2017-09-11 Thread Samudrala, Sridhar
On 9/11/2017 8:53 PM, Eric Dumazet wrote: On Mon, 2017-09-11 at 20:12 -0700, Tom Herbert wrote: Two ints in sock_common for this purpose is quite expensive and the use case for this is limited-- even if a RX->TX queue mapping were introduced to eliminate the queue pair assumption this still w

Re: [PATCH] tcp: TCP_USER_TIMEOUT can not work in tcp_probe_timer()

2017-09-11 Thread liujian
Hi, In the scenario, tcp server side IP changed, and at that memont, userspace application still send data continuously; tcp_send_head(sk)'s timestamp always be refreshed. Here is the packetdrill script: 0 socket(..., SOCK_STREAM, IPPROTO_TCP) = 3 +0 setsockopt(3, SOL_SOCKET, SO_REUSEADDR,

Re: [PATCH v2] openvswitch: Fix an error handling path in 'ovs_nla_init_match_and_action()'

2017-09-11 Thread Pravin Shelar
On Mon, Sep 11, 2017 at 12:56 PM, Christophe JAILLET wrote: > All other error handling paths in this function go through the 'error' > label. This one should do the same. > > Fixes: 9cc9a5cb176c ("datapath: Avoid using stack larger than 1024.") > Signed-off-by: Christophe JAILLET > --- > I think

Re: [RFC net-next 0/5] TSN: Add qdisc-based config interfaces for traffic shapers

2017-09-11 Thread Richard Cochran
On Thu, Sep 07, 2017 at 06:29:00PM -0700, Vinicius Costa Gomes wrote: > >> * Time-aware shaper (802.1Qbv): > >> > >>The idea we are currently exploring is to add a "time-aware", priority > >> based > >>qdisc, that also exposes the Tx queues available and provides a > >> mechanism for > >

Re: [RFC PATCH] net: Introduce a socket option to enable picking tx queue based on rx queue.

2017-09-11 Thread Eric Dumazet
On Mon, 2017-09-11 at 20:12 -0700, Tom Herbert wrote: > Two ints in sock_common for this purpose is quite expensive and the > use case for this is limited-- even if a RX->TX queue mapping were > introduced to eliminate the queue pair assumption this still won't > help if the receive and transmit i

Subject: [PATCH] vxlan: only reduce known arp boardcast request to support, virtual IP

2017-09-11 Thread oc
The purpose of vxlan arp reduce feature is to reply the boardcast arp request in vtep instead of sending it out to save traffic. The current implemention drops arp packet, if the ip cannot be found in neigh table. In the case of virtual IP address, user defines IP address without management from S

Re: [RFC PATCH] net: Introduce a socket option to enable picking tx queue based on rx queue.

2017-09-11 Thread Tom Herbert
On Thu, Aug 31, 2017 at 4:27 PM, Sridhar Samudrala wrote: > This patch introduces a new socket option SO_SYMMETRIC_QUEUES that can be used > to enable symmetric tx and rx queues on a socket. > > This option is specifically useful for epoll based multi threaded workloads > where each thread handles

RE: Extended IDR API

2017-09-11 Thread Chris Mi
This improvement is good. But I have a concern that the parameters of idr_alloc and idr_alloc_ul are different. I mean in idr_alloc, we have start and end. In our new API, we keep them. So our design goal is to make them consistent. Your new API has its advantage surely. If you want to change it,

RE: [PATCH] mwifiex: remove unnecessary call to memset

2017-09-11 Thread Xinming Hu
Hi Himanshu, > -Original Message- > From: Himanshu Jha [mailto:himanshujha199...@gmail.com] > Sent: 2017年9月11日 20:46 > To: amitkar...@gmail.com > Cc: Nishant Sarmukadam ; Ganapathi Bhat > ; Xinming Hu ; > kv...@codeaurora.org; linux-wirel...@vger.kernel.org; > netdev@vger.kernel.org; Hima

RE: [PATCH] e1000e: changed some expensive calls of udelay to usleep_range

2017-09-11 Thread Brown, Aaron F
> From: netdev-ow...@vger.kernel.org [mailto:netdev- > ow...@vger.kernel.org] On Behalf Of Kardonik Michael > Sent: Tuesday, September 5, 2017 1:27 PM > To: leoyang...@nxp.com; michael.kardo...@nxp.com; Kirsher, Jeffrey T > ; Brandeburg, Jesse > ; Shannon Nelson > ; Wyborny, Carolyn > ; Skidmore, D

[net-next] dummy: declare dummy devices as enumerated devices

2017-09-11 Thread Zhang Shengju
Dummy device name is enumerated by the kernel, let user space be aware of the naming scheme used by dummy devices: (visible in /sys/class/net//name_assign_type). Signed-off-by: Zhang Shengju --- drivers/net/dummy.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/d

Re: [patch net] net: sched: fix memleak for chain zero

2017-09-11 Thread Cong Wang
On Sun, Sep 10, 2017 at 7:03 AM, Jiri Pirko wrote: > Sat, Sep 09, 2017 at 08:46:42PM CEST, xiyou.wangc...@gmail.com wrote: >>On Thu, Sep 7, 2017 at 7:18 PM, David Miller wrote: >>> >>> This doesn't apply cleanly any more, please respin. >>> >> >>Sigh, you applied this patch despite of strong obje

[Patch net v3 0/3] net_sched: fix filter chain reference counting

2017-09-11 Thread Cong Wang
This patchset fixes tc filter chain reference counting and nasty race conditions with RCU callbacks. Please see each patch for details. --- v3: Rebase on the latest -net Add code comment in patch 1 Improve comment and changelog for patch 2 Add patch 3 v2: Add patch 1 Get rid of m

[Patch net v3 1/3] net_sched: get rid of tcfa_rcu

2017-09-11 Thread Cong Wang
gen estimator has been rewritten in commit 1c0d32fde5bd ("net_sched: gen_estimator: complete rewrite of rate estimators"), the caller is no longer needed to wait for a grace period. So this patch gets rid of it. This also completely closes a race condition between action free path and filter chain

[Patch net v3 3/3] net_sched: carefully handle tcf_block_put()

2017-09-11 Thread Cong Wang
As pointed out by Jiri, there is still a race condition between tcf_block_put() and tcf_chain_destroy() in a RCU callback. There is no way to make it correct without proper locking or synchronization, because both operate on a shared list. Locking is hard, because the only lock we can pick here is

[Patch net v3 2/3] net_sched: fix reference counting of tc filter chain

2017-09-11 Thread Cong Wang
This patch fixes the following ugliness of tc filter chain refcnt: a) tp proto should hold a refcnt to the chain too. This significantly simplifies the logic. b) Chain 0 is no longer special, it is created with refcnt=1 like any other chains. All the ugliness in tcf_chain_put() can be gone!

[PATCH net] tcp/dccp: remove reqsk_put() from inet_child_forget()

2017-09-11 Thread Eric Dumazet
From: Eric Dumazet Back in linux-4.4, I inadvertently put a call to reqsk_put() in inet_child_forget(), forgetting it could be called from two different points. In the case it is called from inet_csk_reqsk_queue_add(), we want to keep the reference on the request socket, since it is released lat

Re: [RFC PATCH] net: Introduce a socket option to enable picking tx queue based on rx queue.

2017-09-11 Thread Alexander Duyck
On Mon, Sep 11, 2017 at 3:07 PM, Tom Herbert wrote: > On Mon, Sep 11, 2017 at 9:49 AM, Samudrala, Sridhar > wrote: >> On 9/10/2017 8:19 AM, Tom Herbert wrote: >>> >>> On Thu, Aug 31, 2017 at 4:27 PM, Sridhar Samudrala >>> wrote: This patch introduces a new socket option SO_SYMMETRIC_QU

Re: broken vlan support on Realtek RTL8111/8168/8411 rev 9

2017-09-11 Thread Francois Romieu
Benoit Panizzon : [...] > It's not marked as fixed but: > > when I try to turn offloading off I get: > > # /sbin/ethtool -K eth0 rx-vlan-offload off > ethtool: bad command line argument(s) > For more information run ethtool -h > > Could anyone give me a hint how to further debug the problem or

Re: Kernel 4.13.0-rc4-next-20170811 - IP Routing / Forwarding performance vs Core/RSS number / HT on

2017-09-11 Thread Paweł Staszewski
Another test for this patch with linux-next tree with patch:  bwm-ng v0.6.1 (probing every 1.000s), press 'h' for help   input: /proc/net/dev type: rate   - iface   Rx Tx    Total ==  

Re: [RFC PATCH] net: Introduce a socket option to enable picking tx queue based on rx queue.

2017-09-11 Thread Tom Herbert
On Mon, Sep 11, 2017 at 9:49 AM, Samudrala, Sridhar wrote: > On 9/10/2017 8:19 AM, Tom Herbert wrote: >> >> On Thu, Aug 31, 2017 at 4:27 PM, Sridhar Samudrala >> wrote: >>> >>> This patch introduces a new socket option SO_SYMMETRIC_QUEUES that can be >>> used >>> to enable symmetric tx and rx que

Re: WARNING: CPU: 2 PID: 4277 at lib/refcount.c:186

2017-09-11 Thread Eric Dumazet
On Mon, 2017-09-11 at 17:43 -0400, Shankara Pailoor wrote: > Hi Eric, > > I applied your patch and I no longer observed the warning. Thanks! I > will let you know if any further problems show up during fuzzing. Great, I also verified this fixed the problem, I will send the official patch shortly

Re: [Patch net v2 2/2] net_sched: fix all the madness of tc filter chain

2017-09-11 Thread Cong Wang
On Mon, Sep 11, 2017 at 2:14 PM, Cong Wang wrote: > > Looks like all due to the lack of locking on block->chain_list. > I thought the rcu_barrier() could properly handle this, > but seems still not, probably I need to move it in the loop, > I am still not 100% sure if it is totally safe with > lis

Re: WARNING: CPU: 2 PID: 4277 at lib/refcount.c:186

2017-09-11 Thread Shankara Pailoor
Hi Eric, I applied your patch and I no longer observed the warning. Thanks! I will let you know if any further problems show up during fuzzing. Regards, Shankara On Sun, Sep 10, 2017 at 11:34 PM, Eric Dumazet wrote: > On Fri, 2017-09-08 at 11:46 -0700, Eric Dumazet wrote: >> On Fri, 2017-09-08

Re: [PATCH] net/sched: fix pointer check in gen_handle

2017-09-11 Thread David Miller
From: Josh Hunt Date: Sun, 10 Sep 2017 15:48:50 -0400 > Fixes sparse warning about pointer in gen_handle: > net/sched/cls_rsvp.h:392:40: warning: Using plain integer as NULL pointer > > Fixes: 8113c095672f6 ("net_sched: use void pointer for filter handle") > Signed-off-by: Josh Hunt Applied.

Re: [PATCH net] ipv6: sr: remove duplicate routing header type check

2017-09-11 Thread David Miller
From: David Lebrun Date: Sun, 10 Sep 2017 14:22:01 +0100 > From: David Lebrun > > As seg6_validate_srh() already checks that the Routing Header type is > correct, it is not necessary to do it again in get_srh(). > > Fixes: 5829d70b ("ipv6: sr: fix get_srh() to comply with IPv6 standard "RFC >

Re: [V3 PATCH net] xdp: implement xdp_redirect_map for generic XDP

2017-09-11 Thread David Miller
From: Jesper Dangaard Brouer Date: Sun, 10 Sep 2017 09:47:02 +0200 > Using bpf_redirect_map is allowed for generic XDP programs, but the > appropriate map lookup was never performed in xdp_do_generic_redirect(). > > Instead the map-index is directly used as the ifindex. For the > xdp_redirect_m

Re: Extended IDR API

2017-09-11 Thread David Miller
From: Matthew Wilcox Date: Mon, 11 Sep 2017 14:14:08 -0700 > I really don't like your new API. I wish you'd discussed it before > merging it. If I recall correctly, linux-kernel was CC:'d and nobody engaged. I could be wrong, and if I am then my bad, I should have enforced that. Thanks.

Re: [PATCH] tipc: Use bsearch library function

2017-09-11 Thread David Miller
From: Thomas Meyer Date: Sat, 9 Sep 2017 05:18:19 +0200 > @@ -168,6 +169,18 @@ static struct name_seq *tipc_nameseq_create(u32 type, > struct hlist_head *seq_hea > return nseq; > } > > +static int nameseq_find_subseq_cmp(const void *key, const void *elt) > +{ > + u32 instance = *(u

Re: [PATCH net] perf/bpf: fix a clang compilation issue

2017-09-11 Thread David Miller
From: Yonghong Song Date: Thu, 7 Sep 2017 18:36:15 -0700 > clang does not support variable length array for structure member. > It has the following error during compilation: > > kernel/trace/trace_syscalls.c:568:17: error: fields must have a constant size: > 'variable length array in structure'

Re: [PATCH] net: bonding: Fix transmit load balancing in balance-alb mode if specified by sysfs

2017-09-11 Thread David Miller
From: Kosuke Tatsukawa Date: Wed, 6 Sep 2017 22:47:59 + > Commit cbf5ecb30560 ("net: bonding: Fix transmit load balancing in > balance-alb mode") tried to fix transmit dynamic load balancing in > balance-alb mode, which wasn't working after commit 8b426dc54cf4 > ("bonding: remove hardcoded va

Re: [PATCH v2 net-next 1/2] hv_netvsc: fix deadlock on hotplug

2017-09-11 Thread David Miller
From: Stephen Hemminger Date: Wed, 6 Sep 2017 13:53:05 -0700 > When a virtual device is added dynamically (via host console), then > the vmbus sends an offer message for the primary channel. The processing > of this message for networking causes the network device to then > initialize the sub ch

Re: [PATCH v2 net-next 2/2] hv_netvsc: avoid unnecessary wakeups on subchannel creation

2017-09-11 Thread David Miller
From: Stephen Hemminger Date: Wed, 6 Sep 2017 13:53:06 -0700 > Only need to wakeup the initiator after all sub-channels > are opened. > > Signed-off-by: Stephen Hemminger Applied.

Re: [Patch net v2 2/2] net_sched: fix all the madness of tc filter chain

2017-09-11 Thread Cong Wang
On Sun, Sep 10, 2017 at 7:33 AM, Jiri Pirko wrote: > Fri, Sep 08, 2017 at 06:37:55PM CEST, xiyou.wangc...@gmail.com wrote: >>On Thu, Sep 7, 2017 at 1:52 PM, Jiri Pirko wrote: >>> Thu, Sep 07, 2017 at 07:45:49PM CEST, xiyou.wangc...@gmail.com wrote: Yes it is for chain 0, because block holds a

Extended IDR API

2017-09-11 Thread Matthew Wilcox
I really don't like your new API. I wish you'd discussed it before merging it. Here's my redesign. Does anybody have a suggestion for improvement? We have a lovely new test-suite for the IDR (in tools/testing/radix-tree) ... when adding a new API, it's polite to update the test-suite too. Do y

Re: [net-next PATCHv6 1/2] dt-bindings: net: Add DT bindings for Socionext Netsec

2017-09-11 Thread Rob Herring
On Wed, Aug 30, 2017 at 03:55:52PM +0530, Jassi Brar wrote: > This patch adds documentation for Device-Tree bindings for the > Socionext NetSec Controller driver. > > Signed-off-by: Jassi Brar > --- > .../devicetree/bindings/net/socionext-netsec.txt | 46 > ++ > 1 file cha

Re: [PATCH v2 net 1/3] lan78xx: Fix for eeprom read/write when device auto suspend

2017-09-11 Thread Andrew Lunn
On Mon, Sep 11, 2017 at 06:51:49PM +, nisar.sa...@microchip.com wrote: > From: Nisar Sayed > > Fix for eeprom read/write when device auto suspend > > Fixes: 55d7de9de6c3 ("Microchip's LAN7800 family USB 2/3 to 10/100/1000 > Ethernet device driver") > Signed-off-by: Nisar Sayed > --- > dri

Re: [PATCH v5 10/10] net: stmmac: dwmac-sun8i: Handle integrated/external MDIOs

2017-09-11 Thread Andrew Lunn
> Even with CLK_BUS_EPHY/RST_BUS_EPHY enabled, the MAC reset timeout. > So no the CLK/RST are really for the PHY. Thanks for trying that. You said it was probably during scanning of the bus it times out. What address is causing the timeout? 0 or 1? If the internal bus can only have one PHY on it,

RE: [PATCH v2 net 2/3] lan78xx: Allow EEPROM write for less than MAX_EEPROM_SIZE

2017-09-11 Thread Woojung.Huh
Nisar, >@@ -1290,8 +1290,8 @@ static int lan78xx_ethtool_set_eeprom(struct net_device >*netdev, > >/* Allow entire eeprom update only */ >if ((ee->magic == LAN78XX_EEPROM_MAGIC) && >- (ee->offset == 0) && >- (ee->len == 512) && >+ (ee->offset >= 0 &&

[PATCH v2] openvswitch: Fix an error handling path in 'ovs_nla_init_match_and_action()'

2017-09-11 Thread Christophe JAILLET
All other error handling paths in this function go through the 'error' label. This one should do the same. Fixes: 9cc9a5cb176c ("datapath: Avoid using stack larger than 1024.") Signed-off-by: Christophe JAILLET --- I think that the comment above the function could be improved. It looks like the c

Re: [PATCH] netfilter: ipset: ipset list may return wrong member count for set with timeout

2017-09-11 Thread Vishwanath Pai
Hi Jozsef, Thank you. Yes, that is true, the count can still be incorrect in the case of a huge set. Thanks, Vishwanath On 09/11/2017 03:36 PM, Jozsef Kadlecsik wrote: > Hi, > > Your patch is applied in the ipset git tree and I'm going to push it for > kernel inclusion. > > I modified the com

Re: [PATCH] netfilter: ipset: ipset list may return wrong member count for set with timeout

2017-09-11 Thread Jozsef Kadlecsik
Hi, Your patch is applied in the ipset git tree and I'm going to push it for kernel inclusion. I modified the comment part: the elements counter can still be incorrect in the case of a huge set, because elements might time out during the listing. Thanks for your patience! Best regards, Jozse

Re: [PATCH] datapath: Fix an error handling path in 'ovs_nla_init_match_and_action()'

2017-09-11 Thread David Miller
Please use a proper Subject subsystem prefix for openvswitch patches. "datapath" isn't very specific in the global kernel namespace at all. The entire networking stack packet processing path is a "datapath" "openvswitch: " would have been much better.

[PATCH] datapath: Fix an error handling path in 'ovs_nla_init_match_and_action()'

2017-09-11 Thread Christophe JAILLET
All other error handling paths in this function go through the 'error' label. This one should do the same. Fixes: 9cc9a5cb176c ("datapath: Avoid using stack larger than 1024.") Signed-off-by: Christophe JAILLET --- I think that the comment above the function could be improved. It looks like the c

Re: [PATCH v5 10/10] net: stmmac: dwmac-sun8i: Handle integrated/external MDIOs

2017-09-11 Thread Corentin Labbe
On Mon, Sep 11, 2017 at 06:11:24PM +0200, Andrew Lunn wrote: > On Fri, Sep 08, 2017 at 04:28:25PM +0200, Corentin Labbe wrote: > > On Fri, Sep 08, 2017 at 04:17:36PM +0200, Andrew Lunn wrote: > > > > > Do you know why the reset times out/fails? > > > > > > > > > > > > > Because there are nothing

[PATCH v2 net 2/3] lan78xx: Allow EEPROM write for less than MAX_EEPROM_SIZE

2017-09-11 Thread Nisar.Sayed
From: Nisar Sayed Allow EEPROM write for less than MAX_EEPROM_SIZE Fixes: 55d7de9de6c3 ("Microchip's LAN7800 family USB 2/3 to 10/100/1000 Ethernet device driver") Signed-off-by: Nisar Sayed --- drivers/net/usb/lan78xx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/

[PATCH v2 net 3/3] lan78xx: Use default value loaded from EEPROM/OTP when resetting

2017-09-11 Thread Nisar.Sayed
From: Nisar Sayed Use default value loaded from EEPROM/OTP when resetting The LAN78xx allows platform configurations to be loaded from EEPROM/OTP. Ex: When external phy is connected, the MAC can be configured to have speed, duplex, polarity configurations loadded from the EEPROM/OTP. Fixes: 55d

[PATCH v2 net 1/3] lan78xx: Fix for eeprom read/write when device auto suspend

2017-09-11 Thread Nisar.Sayed
From: Nisar Sayed Fix for eeprom read/write when device auto suspend Fixes: 55d7de9de6c3 ("Microchip's LAN7800 family USB 2/3 to 10/100/1000 Ethernet device driver") Signed-off-by: Nisar Sayed --- drivers/net/usb/lan78xx.c | 22 ++ 1 file changed, 18 insertions(+), 4 delet

[PATCH v2 net 0/3] lan78xx: Fixes to lan78xx driver

2017-09-11 Thread Nisar.Sayed
From: Nisar Sayed This series of patches are for lan78xx driver. These patches fixes potential issues associated with lan78xx driver v2 - Added patch version information - Added fixes tag - Updated patch description - Updated changes as per comments v1 - Spitted patches as per comments - Dropp

Re: [PATCH] net/sched: fix pointer check in gen_handle

2017-09-11 Thread Cong Wang
On Sun, Sep 10, 2017 at 12:48 PM, Josh Hunt wrote: > Fixes sparse warning about pointer in gen_handle: > net/sched/cls_rsvp.h:392:40: warning: Using plain integer as NULL pointer > > Fixes: 8113c095672f6 ("net_sched: use void pointer for filter handle") > Signed-off-by: Josh Hunt Acked-by: Cong

Re: [RFC PATCH] net: Introduce a socket option to enable picking tx queue based on rx queue.

2017-09-11 Thread Alexander Duyck
On Mon, Sep 11, 2017 at 9:48 AM, Samudrala, Sridhar wrote: > > > On 9/9/2017 6:28 PM, Alexander Duyck wrote: >> >> On Thu, Aug 31, 2017 at 4:27 PM, Sridhar Samudrala >> wrote: >>> >>> This patch introduces a new socket option SO_SYMMETRIC_QUEUES that can be >>> used >>> to enable symmetric tx and

[PATCH v2 net] smsc95xx: Configure pause time to 0xffff when tx flow control enabled

2017-09-11 Thread Nisar.Sayed
From: Nisar Sayed Configure pause time to 0x when tx flow control enabled Set pause time to 0x in the pause frame to indicate the partner to stop sending the packets. When RX buffer frees up, the device sends pause frame with pause time zero for partner to resume transmission. Fixes: 2f

Re: [patch net] mlxsw: spectrum: Fix EEPROM access in case of SFP/SFP+

2017-09-11 Thread David Miller
From: Jiri Pirko Date: Mon, 11 Sep 2017 09:42:26 +0200 > From: Arkadi Sharshevsky > > The current code does not handle correctly the access to the upper page > in case of SFP/SFP+ EEPROM. In that case the offset should be local > and the I2C address should be changed. > > Fixes: 2ea109039cd3 (

Re: [PATCH net] MAINTAINERS: Remove Yuval Mintz from maintainers list

2017-09-11 Thread David Miller
From: Date: Mon, 11 Sep 2017 17:05:13 +0300 > From: Ariel Elior > > Remove Yuval from maintaining the bnx2x & qed* modules as he is no longer > working for the company. Thanks Yuval for your huge contributions and > tireless efforts over the many years and various companies. > > Ariel All pat

RE: [PATCH v1 net] smsc95xx: Configure pause time to 0xffff when tx flow control enabled

2017-09-11 Thread Nisar.Sayed
> On Mon, Sep 11, 2017 at 12:32:10PM +, nisar.sa...@microchip.com > wrote: > > From: Nisar Sayed > > > > Configure pause time to 0x when tx flow control enabled > > > > Set pause time to 0x in the pause frame to indicate the partner to > > stop sending the packets. When RX buffer frees

Re: [PATCH net] netlink: access nlk groups safely in netlink bind and getname

2017-09-11 Thread Cong Wang
On Sun, Sep 10, 2017 at 4:45 AM, Xin Long wrote: > On Sat, Sep 9, 2017 at 7:35 AM, Cong Wang wrote: >> On Tue, Sep 5, 2017 at 8:53 PM, Xin Long wrote: >>> Now there is no lock protecting nlk ngroups/groups' accessing in >>> netlink bind and getname. It's safe from nlk groups' setting in >>> netl

Re: [PATCH net] phy: mvebu-cp110: checking for NULL instead of IS_ERR()

2017-09-11 Thread David Miller
From: Kishon Vijay Abraham I Date: Mon, 11 Sep 2017 12:54:47 +0530 > On Saturday 09 September 2017 09:39 AM, David Miller wrote: >> Yeah let's sort this out before I apply this fix to my tree. > > I'll take this fix in linux-phy tree after -rc1 is tagged if that's okay with > you. No problem,

Re: [patch net] mlxsw: spectrum: Fix EEPROM access in case of SFP/SFP+

2017-09-11 Thread Jiri Pirko
Mon, Sep 11, 2017 at 03:58:26PM CEST, and...@lunn.ch wrote: >On Mon, Sep 11, 2017 at 09:42:26AM +0200, Jiri Pirko wrote: >> From: Arkadi Sharshevsky >> >> The current code does not handle correctly the access to the upper page >> in case of SFP/SFP+ EEPROM. In that case the offset should be local

Re: Kernel 4.13.0-rc4-next-20170811 - IP Routing / Forwarding performance vs Core/RSS number / HT on

2017-09-11 Thread Paweł Staszewski
Tested with connectx-5 Without patch 10Mpps - > 16 cores used    PerfTop:   66258 irqs/sec  kernel:99.3%  exact:  0.0% [4000Hz cycles],  (all, 32 CPUs) --

Re: [RFC PATCH] net: Introduce a socket option to enable picking tx queue based on rx queue.

2017-09-11 Thread Samudrala, Sridhar
On 9/10/2017 8:19 AM, Tom Herbert wrote: On Thu, Aug 31, 2017 at 4:27 PM, Sridhar Samudrala wrote: This patch introduces a new socket option SO_SYMMETRIC_QUEUES that can be used to enable symmetric tx and rx queues on a socket. This option is specifically useful for epoll based multi threaded

Re: [RFC PATCH] net: Introduce a socket option to enable picking tx queue based on rx queue.

2017-09-11 Thread Samudrala, Sridhar
On 9/9/2017 6:28 PM, Alexander Duyck wrote: On Thu, Aug 31, 2017 at 4:27 PM, Sridhar Samudrala wrote: This patch introduces a new socket option SO_SYMMETRIC_QUEUES that can be used to enable symmetric tx and rx queues on a socket. This option is specifically useful for epoll based multi thre

Re: [PATCH] net: bonding: Fix transmit load balancing in balance-alb mode if specified by sysfs

2017-09-11 Thread Nikolay Aleksandrov
On 11 September 2017 19:07:33 EEST, "Mahesh Bandewar (महेश बंडेवार)" wrote: >On Sat, Sep 9, 2017 at 4:28 AM, Nikolay Aleksandrov > wrote: >> On 07/09/17 01:47, Kosuke Tatsukawa wrote: >>> Commit cbf5ecb30560 ("net: bonding: Fix transmit load balancing in >>> balance-alb mode") tried to fix transm

Re: [PATCH v5 10/10] net: stmmac: dwmac-sun8i: Handle integrated/external MDIOs

2017-09-11 Thread Andrew Lunn
On Fri, Sep 08, 2017 at 04:28:25PM +0200, Corentin Labbe wrote: > On Fri, Sep 08, 2017 at 04:17:36PM +0200, Andrew Lunn wrote: > > > > Do you know why the reset times out/fails? > > > > > > > > > > Because there are nothing connected to it. > > > > That should not be an issue. A read should just

Re: [PATCH] net: bonding: Fix transmit load balancing in balance-alb mode if specified by sysfs

2017-09-11 Thread महेश बंडेवार
On Sat, Sep 9, 2017 at 4:28 AM, Nikolay Aleksandrov wrote: > On 07/09/17 01:47, Kosuke Tatsukawa wrote: >> Commit cbf5ecb30560 ("net: bonding: Fix transmit load balancing in >> balance-alb mode") tried to fix transmit dynamic load balancing in >> balance-alb mode, which wasn't working after commit

Re: [PATCH] tcp: TCP_USER_TIMEOUT can not work in tcp_probe_timer()

2017-09-11 Thread Eric Dumazet
On Mon, 2017-09-11 at 08:13 -0700, Eric Dumazet wrote: > You can see we got only 3 probes, not 4. Here is complete packetdrill test showing that code behaves as expected. 0 socket(..., SOCK_STREAM, IPPROTO_TCP) = 3 +0 setsockopt(3, SOL_SOCKET, SO_REUSEADDR, [1], 4) = 0 +0 bind(3, ...,

Re: [PATCH] tcp: TCP_USER_TIMEOUT can not work in tcp_probe_timer()

2017-09-11 Thread Eric Dumazet
On Mon, 2017-09-11 at 07:49 -0700, Eric Dumazet wrote: > On Mon, 2017-09-11 at 14:27 +0800, liujia...@huawei.com wrote: > > From: liujian > > > > After the tcp socket go to ESTABLISHED stat, change IP address (server > > side), > > then the tcp socket will go tcp_probe_timer process. > > > > [ro

Re: [PATCH] tcp: TCP_USER_TIMEOUT can not work in tcp_probe_timer()

2017-09-11 Thread Eric Dumazet
On Mon, 2017-09-11 at 14:27 +0800, liujia...@huawei.com wrote: > From: liujian > > After the tcp socket go to ESTABLISHED stat, change IP address (server > side), > then the tcp socket will go tcp_probe_timer process. > > [root@localhost net]# netstat -toe > Active Internet connections (w/o serv

[PATCH net] MAINTAINERS: Remove Yuval Mintz from maintainers list

2017-09-11 Thread aelior
From: Ariel Elior Remove Yuval from maintaining the bnx2x & qed* modules as he is no longer working for the company. Thanks Yuval for your huge contributions and tireless efforts over the many years and various companies. Ariel --- MAINTAINERS | 2 -- 1 file changed, 2 deletions(-) diff --git

Re: [PATCH v1 net] smsc95xx: Configure pause time to 0xffff when tx flow control enabled

2017-09-11 Thread Andrew Lunn
On Mon, Sep 11, 2017 at 12:32:10PM +, nisar.sa...@microchip.com wrote: > From: Nisar Sayed > > Configure pause time to 0x when tx flow control enabled > > Set pause time to 0x in the pause frame to indicate the > partner to stop sending the packets. When RX buffer frees up, > the dev

Re: [patch net] mlxsw: spectrum: Fix EEPROM access in case of SFP/SFP+

2017-09-11 Thread Andrew Lunn
On Mon, Sep 11, 2017 at 09:42:26AM +0200, Jiri Pirko wrote: > From: Arkadi Sharshevsky > > The current code does not handle correctly the access to the upper page > in case of SFP/SFP+ EEPROM. In that case the offset should be local > and the I2C address should be changed. Shame you cannot/didn'

Re: [PATCH net-next 09/11] bnxt_en: bnxt: add TC flower filter offload support

2017-09-11 Thread Jiri Pirko
Mon, Aug 28, 2017 at 07:40:33PM CEST, michael.c...@broadcom.com wrote: >From: Sathya Perla > >This patch adds support for offloading TC based flow >rules and actions for the 'flower' classifier in the bnxt_en driver. >It includes logic to parse flow rules and actions received from the >TC subsyste

[PATCH] tipc: Use bsearch library function

2017-09-11 Thread Thomas Meyer
Use common library function rather than explicitly coding some variant of it yourself. Signed-off-by: Thomas Meyer --- net/tipc/name_table.c | 30 +++--- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/net/tipc/name_table.c b/net/tipc/name_table.c index bd

[PATCH] mwifiex: remove unnecessary call to memset

2017-09-11 Thread Himanshu Jha
call to memset to assign 0 value immediately after allocating memory with kzalloc is unnecesaary as kzalloc allocates the memory filled with 0 value. Semantic patch used to resolve this issue: @@ expression e,e2; constant c; statement S; @@ e = kzalloc(e2, c); if(e == NULL) S - memset(e, 0,

Re: [PATCH net-next 2/3] net: ethernet: socionext: add AVE ethernet driver

2017-09-11 Thread Andrew Lunn
> > > +static irqreturn_t ave_interrupt(int irq, void *netdev) > > > +{ > > > + struct net_device *ndev = (struct net_device *)netdev; > > > + struct ave_private *priv = netdev_priv(ndev); > > > + u32 gimr_val, gisr_val; > > > + > > > + gimr_val = ave_irq_disable_all(ndev); > > > + > > > + /* get i

[PATCH v1 net] smsc95xx: Configure pause time to 0xffff when tx flow control enabled

2017-09-11 Thread Nisar.Sayed
From: Nisar Sayed Configure pause time to 0x when tx flow control enabled Set pause time to 0x in the pause frame to indicate the partner to stop sending the packets. When RX buffer frees up, the device sends pause frame with pause time zero for partner to resume transmission. Signed-of

Hello Friend

2017-09-11 Thread Mr. LEUNG Cheung
I NEED YOUR ASSISTANCE INTO THIS TRANSACTION

Re: [RFC net-next v2] bridge lwtunnel, VPLS & NVGRE

2017-09-11 Thread Amine Kherbouche
Hi David, Do you plan to send a v3? On 21/08/2017 18:15, David Lamparter wrote: Hi all, this is an update on the earlier "[RFC net-next] VPLS support". Note I've changed the subject lines on some of the patches to better reflect what they really do (tbh the earlier subject lines were crap.)

Re: [PATCH RFC] Update documentation for KSZ DSA drivers so that new drivers can be added

2017-09-11 Thread Maxim Uvarov
2017-09-08 22:48 GMT+03:00 : >> -Original Message- >> From: Maxim Uvarov [mailto:muva...@gmail.com] >> Sent: Friday, September 08, 2017 12:00 PM >> To: Florian Fainelli >> Cc: Tristram Ha - C24268; Andrew Lunn; Pavel Machek; Nathan Conrad; Vivien >> Didelot; netdev; linux-ker...@vger.kerne

Re: [PATCH net-next 3/3] net: phy: realtek: add RTL8201F phy-id and functions

2017-09-11 Thread Kunihiko Hayashi
Hi Andrew, Thank your for reviewing. On Sat, 9 Sep 2017 17:55:17 +0200 wrote: > On Sat, Sep 09, 2017 at 09:03:05AM +0530, Jassi Brar wrote: > > On 9 September 2017 at 00:21, Florian Fainelli wrote: > > > On 09/08/2017 06:02 AM, Kunihiko Hayashi wrote: > > >> From: Jassi Brar > > >> > > >> Add

[patch net] mlxsw: spectrum: Fix EEPROM access in case of SFP/SFP+

2017-09-11 Thread Jiri Pirko
From: Arkadi Sharshevsky The current code does not handle correctly the access to the upper page in case of SFP/SFP+ EEPROM. In that case the offset should be local and the I2C address should be changed. Fixes: 2ea109039cd3 ("mlxsw: spectrum: Add support for access cable info via ethtool") Repo

Re: [PATCH net] phy: mvebu-cp110: checking for NULL instead of IS_ERR()

2017-09-11 Thread Kishon Vijay Abraham I
Hi, On Saturday 09 September 2017 09:39 AM, David Miller wrote: > From: Dan Carpenter > Date: Fri, 8 Sep 2017 13:31:37 +0300 > >> devm_ioremap_resource() never returns NULL, it only returns error >> pointers so this test needs to be changed. >> >> Fixes: d0438bd6aa09 ("phy: add the mvebu cp110 c

Re: [PATCH iproute2 1/2] lib/libnetlink: re malloc buff if size is not enough

2017-09-11 Thread Hangbin Liu
Hi Phil and Michal, On Fri, Sep 08, 2017 at 04:51:13PM +0200, Phil Sutter wrote: > Hi, > > On Fri, Sep 08, 2017 at 10:01:31PM +0800, Hangbin Liu wrote: > [...] > > Since we have to use two static bufffers. So how about check like > > > > if (len > strlen(buffer)) > > I don't think that will

Re: [PATCH net-next 1/3] dt-bindings: net: add DT bindings for Socionext UniPhier AVE

2017-09-11 Thread Kunihiko Hayashi
Hi Florian, On Fri, 8 Sep 2017 11:54:31 -0700 wrote: > On 09/08/2017 06:02 AM, Kunihiko Hayashi wrote: > > DT bindings for the AVE ethernet controller found on Socionext's > > UniPhier platforms. > > > > Signed-off-by: Kunihiko Hayashi > > Signed-off-by: Jassi Brar > > --- > > .../bindings/n

Re: [PATCH net-next 1/3] dt-bindings: net: add DT bindings for Socionext UniPhier AVE

2017-09-11 Thread Kunihiko Hayashi
Hi Andrew, On Fri, 8 Sep 2017 16:03:22 +0200 wrote: > > + eth: ethernet@6500 { > > + compatible = "socionext,uniphier-ave4"; > > + reg = <0x6500 0x8500>; > > + interrupts = <0 66 4>; > > + pinctrl-names = "default"; > > + pinctrl-0 = <&