netfilter: xt_bpf: ABI issue in xt_bpf_info_v1?

2017-09-13 Thread Shmulik Ladkani
Hi, Commit 2c16d60 'netfilter: xt_bpf: support ebpf' introduced 'xt_bpf_info_v1', to support attaching an eBPF object by fd. Alas, seems this ABI is problematic, as the 'fd', which is local to the process attaching the ebpf object (namely iptables) is stored in the matchinfo structure. This lead

Re: [RFC PATCH v3 2/7] sched: act_mirred: Traffic class option for mirror/redirect action

2017-09-13 Thread Jiri Pirko
Wed, Sep 13, 2017 at 11:59:24AM CEST, amritha.namb...@intel.com wrote: >Adds optional traffic class parameter to the mirror/redirect action. >The mirror/redirect action is extended to forward to a traffic >class on the device if the traffic class index is provided in >addition to the device's ifind

Re: [PATCH 05/10] drivers:net: return -ENOMEM on allocation failure.

2017-09-13 Thread Allen
> propagates the -1. That is only called by bond_open() with: > > if (bond_alb_initialize(bond, (BOND_MODE(bond) == BOND_MODE_ALB))) > return -ENOMEM; > > So you might want to also modify this code, to return the return > value, rather than use the hard coded ENOMEM. > I'l

Re: [PATCH 06/10] drivers:ethernet: return -ENOMEM on allocation failure.

2017-09-13 Thread Allen
> > static int cas_alloc_rxds(struct cas *cp) > { > int i; > > for (i = 0; i < N_RX_DESC_RINGS; i++) { > if (cas_alloc_rx_desc(cp, i) < 0) { > cas_free_rxds(cp); > return -1; > } > } > re

Re: [PATCH v2] ipv4: Namespaceify tcp_fastopen knob

2017-09-13 Thread Eric Dumazet
On Wed, 2017-09-13 at 05:44 -0700, Eric Dumazet wrote: > On Wed, 2017-09-13 at 19:19 +0800, Haishuang Yan wrote: > > Different namespace application might require enable TCP Fast Open > > feature independently of the host. > > > > Poor changelog, no actual description / list of sysctls that are m

Re: [LPC] 2nd RDMA Mini-Summit Schedule

2017-09-13 Thread Leon Romanovsky
On Thu, Sep 07, 2017 at 08:18:05AM +0300, Leon Romanovsky wrote: > Hi, > > We're happy to announce schedule of the 2nd RDMA mini-summit, which will be > held as part of coming Linux Plumbers Conference 2017. > > During the conference, we will have two sessions: main track session and > round table

Re: [PATCH v2] ipv4: Namespaceify tcp_fastopen knob

2017-09-13 Thread Eric Dumazet
On Wed, 2017-09-13 at 19:19 +0800, Haishuang Yan wrote: > Different namespace application might require enable TCP Fast Open > feature independently of the host. > Poor changelog, no actual description / list of sysctls that are moved to per netns. And looking at the patch, it seems your convers

Re: [oss-drivers] Re: [PATCH/RFC net-next 2/2] net/sched: allow flower to match tunnel options

2017-09-13 Thread Or Gerlitz
On Wed, Sep 13, 2017 at 2:59 PM, Simon Horman wrote: > On Wed, Sep 13, 2017 at 01:03:43PM +0300, Or Gerlitz wrote: >> On Wed, Sep 13, 2017 at 12:25 PM, Simon Horman >> wrote: >> > On Tue, Sep 12, 2017 at 11:23:55PM +0300, Or Gerlitz wrote: >> >> On Tue, Sep 12, 2017 at 5:20 PM, Simon Horman >> >>

[PATCH] dt-bindings: net: renesas-ravb: Add support for R8A77995 RAVB

2017-09-13 Thread Yoshihiro Shimoda
Add a new compatible string for the R8A77995 (R-Car D3) RAVB. Signed-off-by: Yoshihiro Shimoda --- Documentation/devicetree/bindings/net/renesas,ravb.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/net/renesas,ravb.txt b/Documentation/devicetree/binding

Re: [PATCH 06/10] drivers:ethernet: return -ENOMEM on allocation failure.

2017-09-13 Thread Andrew Lunn
On Wed, Sep 13, 2017 at 01:02:15PM +0530, Allen Pais wrote: > Signed-off-by: Allen Pais > --- > drivers/net/ethernet/sun/cassini.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/sun/cassini.c > b/drivers/net/ethernet/sun/cassini.c > index 382993c..

Re: [PATCH 05/10] drivers:net: return -ENOMEM on allocation failure.

2017-09-13 Thread Andrew Lunn
On Wed, Sep 13, 2017 at 01:02:14PM +0530, Allen Pais wrote: > Signed-off-by: Allen Pais Hi Allen Although correct, if you look higher up the call chain, this appears to be not so useful. rlb_initialize() is only called by bond_alb_initialize(), and it propagates the -1. That is only called by b

Re: [oss-drivers] Re: [PATCH/RFC net-next 2/2] net/sched: allow flower to match tunnel options

2017-09-13 Thread Simon Horman
On Wed, Sep 13, 2017 at 01:03:43PM +0300, Or Gerlitz wrote: > On Wed, Sep 13, 2017 at 12:25 PM, Simon Horman > wrote: > > On Tue, Sep 12, 2017 at 11:23:55PM +0300, Or Gerlitz wrote: > >> On Tue, Sep 12, 2017 at 5:20 PM, Simon Horman > >> wrote: > >> > Allow matching on options in tunnel headers.

[PATCH v2] ipv4: Namespaceify tcp_fastopen knob

2017-09-13 Thread Haishuang Yan
Different namespace application might require enable TCP Fast Open feature independently of the host. Reported-by: Luca BRUNO Signed-off-by: Haishuang Yan --- Change since v2: * Remove unrelated change by mistake --- include/net/netns/ipv4.h | 2 ++ include/net/tcp.h | 1 - net/

Re: [PATCH v2] geneve: Fix setting ttl value in collect metadata mode

2017-09-13 Thread 严海双
> On 2017年9月13日, at 上午7:43, Pravin Shelar wrote: > > On Tue, Sep 12, 2017 at 12:05 AM, Haishuang Yan > wrote: >> Similar to vxlan/ipip tunnel, if key->tos is zero in collect metadata >> mode, tos should also fallback to ip{4,6}_dst_hoplimit. >> >> Signed-off-by: Haishuang Yan >> >> --- >> C

Re: [PATCH] vti: fix NULL dereference in xfrm_input()

2017-09-13 Thread Steffen Klassert
On Tue, Sep 12, 2017 at 02:53:46PM +0300, Alexey Kodanev wrote: > Can be reproduced with LTP tests: > # icmp-uni-vti.sh -p ah -a sha256 -m tunnel -S fffe -k 1 -s 10 > > IPv4: > RIP: 0010:xfrm_input+0x7f9/0x870 > ... > Call Trace: > > vti_input+0xaa/0x110 [ip_vti] > ? skb_free_he

FW:

2017-09-13 Thread Moreira Nobrega de Andrade, Carlos Guilherme
-Original Message- From: Moreira Nobrega de Andrade, Carlos Guilherme Sent: 13 September 2017 14:00 Subject: FW: Have a proposal for U

Re: [RFC PATCH v3 0/7] tc-flower based cloud filters in i40e

2017-09-13 Thread Jiri Pirko
Wed, Sep 13, 2017 at 11:59:13AM CEST, amritha.namb...@intel.com wrote: >This patch series enables configuring cloud filters in i40e >using the tc-flower classifier. The only tc-filter action >supported is to redirect packets to a traffic class on the >same device. The mirror/redirect action is exte

[iproute2 PATCH] tc/mirred: Clean up white-space noise

2017-09-13 Thread Amritha Nambiar
Signed-off-by: Amritha Nambiar --- include/linux/tc_act/tc_mirred.h |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/include/linux/tc_act/tc_mirred.h b/include/linux/tc_act/tc_mirred.h index 3d7a2b3..69038c2 100644 --- a/include/linux/tc_act/tc_mirred.h +++ b/include/l

Re: [oss-drivers] Re: [PATCH/RFC net-next 2/2] net/sched: allow flower to match tunnel options

2017-09-13 Thread Or Gerlitz
On Wed, Sep 13, 2017 at 12:25 PM, Simon Horman wrote: > On Tue, Sep 12, 2017 at 11:23:55PM +0300, Or Gerlitz wrote: >> On Tue, Sep 12, 2017 at 5:20 PM, Simon Horman >> wrote: >> > Allow matching on options in tunnel headers. >> > This makes use of existing tunnel metadata support. >> >> Simon, >>

[RFC PATCH v3 3/7] i40e: Map TCs with the VSI seids

2017-09-13 Thread Amritha Nambiar
Add mapping of TCs with the seids of the channel VSIs. TC0 will be mapped to the main VSI seid and all other TCs are mapped to the seid of the corresponding channel VSI. Signed-off-by: Amritha Nambiar --- drivers/net/ethernet/intel/i40e/i40e.h |1 + drivers/net/ethernet/intel/i40e/i40e_

[RFC PATCH v3 0/7] tc-flower based cloud filters in i40e

2017-09-13 Thread Amritha Nambiar
This patch series enables configuring cloud filters in i40e using the tc-flower classifier. The only tc-filter action supported is to redirect packets to a traffic class on the same device. The mirror/redirect action is extended to accept a traffic class to achieve this. The cloud filters are adde

[RFC PATCH v3 7/7] i40e: Enable cloud filters via tc-flower

2017-09-13 Thread Amritha Nambiar
This patch enables tc-flower based hardware offloads. tc flower filter provided by the kernel is configured as driver specific cloud filter. The patch implements functions and admin queue commands needed to support cloud filters in the driver and adds cloud filters to configure these tc-flower filt

[RFC PATCH v3 1/7] tc_mirred: Clean up white-space noise

2017-09-13 Thread Amritha Nambiar
Signed-off-by: Amritha Nambiar --- include/uapi/linux/tc_act/tc_mirred.h |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/include/uapi/linux/tc_act/tc_mirred.h b/include/uapi/linux/tc_act/tc_mirred.h index 3d7a2b3..69038c2 100644 --- a/include/uapi/linux/tc_act/tc_mir

[PATCHv2 iproute2 2/2] lib/libnetlink: update rtnl_talk to support malloc buff at run time

2017-09-13 Thread Hangbin Liu
This is an update for 460c03f3f3cc ("iplink: double the buffer size also in iplink_get()"). After update, we will not need to double the buffer size every time when VFs number increased. With call like rtnl_talk(&rth, &req.n, NULL, 0), we can simply remove the length parameter. With call like rtn

[RFC PATCH v3 6/7] i40e: Clean up of cloud filters

2017-09-13 Thread Amritha Nambiar
Introduce the cloud filter datastructure and cleanup of cloud filters associated with the device. v2: Moved field comments in struct i40e_cloud_filter to the right. Removed hlist_empty check from i40e_cloud_filter_exit() Signed-off-by: Amritha Nambiar --- drivers/net/ethernet/intel/i40e/i40e.h

[RFC PATCH v3 4/7] i40e: Cloud filter mode for set_switch_config command

2017-09-13 Thread Amritha Nambiar
Add definitions for L4 filters and switch modes based on cloud filters modes and extend the set switch config command to include the additional cloud filter mode. Signed-off-by: Amritha Nambiar Signed-off-by: Kiran Patil --- drivers/net/ethernet/intel/i40e/i40e_adminq_cmd.h | 30 +

[RFC PATCH v3 5/7] i40e: Admin queue definitions for cloud filters

2017-09-13 Thread Amritha Nambiar
Add new admin queue definitions and extended fields for cloud filter support. Define big buffer for extended general fields in Add/Remove Cloud filters command. v3: Shortened some lengthy struct names. v2: Added I40E_CHECK_STRUCT_LEN check to AQ command structs and added AQ definitions to i40evf f

[PATCHv2 iproute2 1/2] lib/libnetlink: re malloc buff if size is not enough

2017-09-13 Thread Hangbin Liu
With commit 72b365e8e0fd ("libnetlink: Double the dump buffer size") we doubled the buffer size to support more VFs. But the VFs number is increasing all the time. Some customers even use more than 200 VFs now. We could not double it everytime when the buffer is not enough. Let's just not hard cod

[RFC PATCH v3 2/7] sched: act_mirred: Traffic class option for mirror/redirect action

2017-09-13 Thread Amritha Nambiar
Adds optional traffic class parameter to the mirror/redirect action. The mirror/redirect action is extended to forward to a traffic class on the device if the traffic class index is provided in addition to the device's ifindex. Example: # tc filter add dev eth0 protocol ip parent : prio 1 flow

[PATCHv2 iproute2 0/2] libnetlink: malloc correct buff at run time

2017-09-13 Thread Hangbin Liu
With commit 72b365e8e0fd ("libnetlink: Double the dump buffer size") and 460c03f3f3cc ("iplink: double the buffer size also in iplink_get()"), we extend the buffer size to avoid truncated message with large numbers of VFs. But just as Michal said, this is not future-proof since the NIC number is in

Re: [PATCH iproute2 1/2] lib/libnetlink: re malloc buff if size is not enough

2017-09-13 Thread Hangbin Liu
Hi Michal, Thanks a lot for all your explains. Phil has helped update the patch to support return a newly allocated buffer. I will post it soon. Thanks Hangbin On Tue, Sep 12, 2017 at 11:09:26AM +0200, Michal Kubecek wrote: > > > > I checked again and arpd indeed isn't a problem. It doesn't seem

Re: [oss-drivers] Re: [PATCH/RFC net-next 2/2] net/sched: allow flower to match tunnel options

2017-09-13 Thread Simon Horman
On Tue, Sep 12, 2017 at 11:23:55PM +0300, Or Gerlitz wrote: > On Tue, Sep 12, 2017 at 5:20 PM, Simon Horman > wrote: > > Allow matching on options in tunnel headers. > > This makes use of existing tunnel metadata support. > > Simon, > > This patch is about matching on tunnel options, right? but

[PATCH net] sctp: potential read out of bounds in sctp_ulpevent_type_enabled()

2017-09-13 Thread Dan Carpenter
This code causes a static checker warning because Smatch doesn't trust anything that comes from skb->data. I've reviewed this code and I do think skb->data can be controlled by the user here. The sctp_event_subscribe struct has 13 __u8 fields and we want to see if ours is non-zero. sn_type can b

[iproute PATCH v2] ipaddress: Fix segfault in 'addr showdump'

2017-09-13 Thread Phil Sutter
Obviously, 'addr showdump' feature wasn't adjusted to json output support. As a consequence, calls to print_string() in print_addrinfo() tried to dereference a NULL FILE pointer. Cc: Julien Fortin Fixes: d0e720111aad2 ("ip: ipaddress.c: add support for json output") Signed-off-by: Phil Sutter --

RE: [PATCH] qed: remove unnecessary call to memset

2017-09-13 Thread Kalluru, Sudarsana
-Original Message- From: Himanshu Jha [mailto:himanshujha199...@gmail.com] Sent: 12 September 2017 16:49 To: Mintz, Yuval Cc: Elior, Ariel ; Dept-Eng Everest Linux L2 ; netdev@vger.kernel.org; linux-ker...@vger.kernel.org; Himanshu Jha Subject: [PATCH] qed: remove unnecessary call to

Re: [iproute PATCH] ipaddress: Fix segfault in 'addr showdump'

2017-09-13 Thread Phil Sutter
On Tue, Sep 12, 2017 at 04:58:12PM +0200, Phil Sutter wrote: > Obviously, 'addr showdump' feature wasn't adjusted to json output > support. As a consequence, calls to print_string() in print_addrinfo() > tried to dereference a NULL FILE pointer. Please ignore this patch - it generates incorrect js

[no subject]

2017-09-13 Thread kindergartenchaos2
<>

Re: [PATCH] ipv4: Namespaceify tcp_fastopen knob

2017-09-13 Thread 严海双
> On 2017年9月13日, at 上午11:57, David Miller wrote: > > From: Haishuang Yan > Date: Tue, 12 Sep 2017 18:30:57 +0800 > >> Different namespace application might require enable TCP Fast Open >> feature independently of the host. >> >> Reported-by: Luca BRUNO >> Signed-off-by: Haishuang Yan > ...

Re: Regression in throughput between kvm guests over virtual bridge

2017-09-13 Thread Jason Wang
On 2017年09月13日 09:16, Jason Wang wrote: On 2017年09月13日 01:56, Matthew Rosato wrote: We are seeing a regression for a subset of workloads across KVM guests over a virtual bridge between host kernel 4.12 and 4.13. Bisecting points to c67df11f "vhost_net: try batch dequing from skb array" In t

Re: Memory leaks in conntrack

2017-09-13 Thread Florian Westphal
Cong Wang wrote: > While testing my TC filter patches (so not related to conntrack), the > following memory leaks are shown up: > > unreferenced object 0x9b19ba551228 (size 128): > comm "chronyd", pid 338, jiffies 4294910829 (age 53.188s) > hex dump (first 32 bytes): > 6b 6b 6b 6b 6b

Re: [PATCH] ravb: document R8A77970 bindings

2017-09-13 Thread Geert Uytterhoeven
On Tue, Sep 12, 2017 at 10:02 PM, Sergei Shtylyov wrote: > R-Car V3M (R8A77970) SoC also has the R-Car gen3 compatible EtherAVB > device, so document the SoC specific bindings. > > Signed-off-by: Sergei Shtylyov Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert

Re: [PATCH] VSOCK: fix uapi/linux/vm_sockets.h incomplete types

2017-09-13 Thread Jorgen S. Hansen
> On Sep 12, 2017, at 6:34 PM, Stefan Hajnoczi wrote: > > This patch fixes the following compiler errors when userspace > applications use the vm_sockets.h header: > > include/uapi/linux/vm_sockets.h:148:32: error: invalid application of > ‘sizeof’ to incomplete type ‘struct sockaddr’ >un

Re: [PATCH] ravb: document R8A77970 bindings

2017-09-13 Thread Simon Horman
On Tue, Sep 12, 2017 at 11:02:08PM +0300, Sergei Shtylyov wrote: > R-Car V3M (R8A77970) SoC also has the R-Car gen3 compatible EtherAVB > device, so document the SoC specific bindings. > > Signed-off-by: Sergei Shtylyov Acked-by: Simon Horman > --- > The patch is against DaveM's 'net-next.git

[PATCH 03/10] driver:gpu: return -ENOMEM on allocation failure.

2017-09-13 Thread Allen Pais
Signed-off-by: Allen Pais --- drivers/gpu/drm/gma500/mid_bios.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/gma500/mid_bios.c b/drivers/gpu/drm/gma500/mid_bios.c index d75ecb3..1fa1633 100644 --- a/drivers/gpu/drm/gma500/mid_bios.c +++ b/drivers/gpu/drm/gm

[PATCH 05/10] drivers:net: return -ENOMEM on allocation failure.

2017-09-13 Thread Allen Pais
Signed-off-by: Allen Pais --- drivers/net/bonding/bond_alb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/bonding/bond_alb.c b/drivers/net/bonding/bond_alb.c index c02cc81..89df377 100644 --- a/drivers/net/bonding/bond_alb.c +++ b/drivers/net/bonding/bond_alb.c

[PATCH 06/10] drivers:ethernet: return -ENOMEM on allocation failure.

2017-09-13 Thread Allen Pais
Signed-off-by: Allen Pais --- drivers/net/ethernet/sun/cassini.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/sun/cassini.c b/drivers/net/ethernet/sun/cassini.c index 382993c..fc0ea3a 100644 --- a/drivers/net/ethernet/sun/cassini.c +++ b/drivers/net/et

[PATCH 07/10] driver:megaraid: return -ENOMEM on allocation failure.

2017-09-13 Thread Allen Pais
Signed-off-by: Allen Pais --- drivers/scsi/megaraid/megaraid_mbox.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/megaraid/megaraid_mbox.c b/drivers/scsi/megaraid/megaraid_mbox.c index ec3c438..b09a0a6 100644 --- a/drivers/scsi/megaraid/megaraid_mbox.c +++

[PATCH 10/10] fs:btrfs: return -ENOMEM on allocation failure.

2017-09-13 Thread Allen Pais
Signed-off-by: Allen Pais --- fs/btrfs/check-integrity.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/btrfs/check-integrity.c b/fs/btrfs/check-integrity.c index 7d5a9b5..efa4c23 100644 --- a/fs/btrfs/check-integrity.c +++ b/fs/btrfs/check-integrity.c @@ -2913,7 +2913,7 @

[PATCH 08/10] driver:cxgbit: return -NOMEM on allocation failure.

2017-09-13 Thread Allen Pais
Signed-off-by: Allen Pais --- drivers/target/iscsi/cxgbit/cxgbit_target.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/target/iscsi/cxgbit/cxgbit_target.c b/drivers/target/iscsi/cxgbit/cxgbit_target.c index 514986b..47127d6 100644 --- a/drivers/target/iscsi/cxgbit/

[PATCH 04/10] drivers:mpt: return -ENOMEM on allocation failure.

2017-09-13 Thread Allen Pais
Signed-off-by: Allen Pais --- drivers/message/fusion/mptbase.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/message/fusion/mptbase.c b/drivers/message/fusion/mptbase.c index 84eab28..7920b2b 100644 --- a/drivers/message/fusion/mptbase.c +++ b/drivers/me

[PATCH 09/10] driver:video: return -ENOMEM on allocation failure.

2017-09-13 Thread Allen Pais
Signed-off-by: Allen Pais --- drivers/video/fbdev/matrox/matroxfb_base.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/fbdev/matrox/matroxfb_base.c b/drivers/video/fbdev/matrox/matroxfb_base.c index f6a0b9a..5cd238d 100644 --- a/drivers/video/fbdev/matrox/matr

[PATCH 02/10] drivers:crypto: return -ENOMEM on allocation failure.

2017-09-13 Thread Allen Pais
Signed-off-by: Allen Pais --- drivers/crypto/omap-aes-gcm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/omap-aes-gcm.c b/drivers/crypto/omap-aes-gcm.c index 7d4f8a4..2542224 100644 --- a/drivers/crypto/omap-aes-gcm.c +++ b/drivers/crypto/omap-aes-gcm.c @@ -1

[PATCH 01/10] arch:powerpc: return -ENOMEM on failed allocation

2017-09-13 Thread Allen Pais
Signed-off-by: Allen Pais --- arch/powerpc/platforms/cell/spider-pci.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/powerpc/platforms/cell/spider-pci.c b/arch/powerpc/platforms/cell/spider-pci.c index d1e61e2..82aa3f7 100644 --- a/arch/powerpc/platforms/cell/spide

Re: [PATCH] tcp: TCP_USER_TIMEOUT can not work in tcp_probe_timer()

2017-09-13 Thread liujian
在 2017/9/13 14:56, liujian 写道: > > > 在 2017/9/12 23:38, Eric Dumazet 写道: >> On Tue, 2017-09-12 at 08:05 -0700, Eric Dumazet wrote: >>> On Tue, 2017-09-12 at 14:08 +0800, liujian wrote: Hi, In the scenario, tcp server side IP changed, and at that memont, userspace application

<    1   2