[PATCH v2] net/ethernet/freescale: fix warning for ucc_geth

2017-09-14 Thread Valentin Longchamp
uf_info.regs is resource_size_t i.e. phys_addr_t that can be either u32 or u64 according to CONFIG_PHYS_ADDR_T_64BIT. The printk format is thus adaptet to u64 and the regs value cast to u64 to take both u32 and u64 into account. Signed-off-by: Valentin Longchamp

Re: [PATCH net-next v2 01/10] net: dsa: add debugfs interface

2017-09-14 Thread Jiri Pirko
Thu, Sep 14, 2017 at 11:01:32PM CEST, and...@lunn.ch wrote: >> Can you clarify what type of registers it is you are wanting to read? >> We already have ethtool which is meant to allow reading the device >> registers for a given netdev. As long as the port has a netdev >> associated it then there

[PATCH 1/1] ipv6_skip_exthdr: use ipv6_authlen for AH header length computation

2017-09-14 Thread Xiang Gao
>From 09cf2e3cf09cf591283785aaa8159baf39ac2e08 Mon Sep 17 00:00:00 2001 From: Xiang Gao Date: Fri, 15 Sep 2017 00:44:12 -0400 Subject: [PATCH] ipv6_skip_exthdr: use ipv6_authlen for AH hdrlen In ipv6_skip_exthdr, the lengh of AH header is computed manually as

Re: [REGRESSION] Warning in tcp_fastretrans_alert() of net/ipv4/tcp_input.c

2017-09-14 Thread Oleksandr Natalenko
Hi. I've applied your test patch but it doesn't fix the issue for me since the warning is still there. Were you able to reproduce it? On pondělí 11. září 2017 1:59:02 CEST Neal Cardwell wrote: > Thanks for the detailed report! > > I suspect this is due to the following commit, which happened

[PATCH net] ip6_gre: skb_push ipv6hdr before packing the header in ip6gre_header

2017-09-14 Thread Xin Long
Now in ip6gre_header before packing the ipv6 header, it skb_push t->hlen which only includes encap_hlen + tun_hlen. It means greh and inner header would be over written by ipv6 stuff and ipv6h might have no chance to set up. Jianlin found this issue when using remote any on ip6_gre, the packets

Re: Regression in throughput between kvm guests over virtual bridge

2017-09-14 Thread Matthew Rosato
> Is the issue gone if you reduce VHOST_RX_BATCH to 1? And it would be > also helpful to collect perf diff to see if anything interesting. > (Consider 4.4 shows more obvious regression, please use 4.4). > Issue still exists when I force VHOST_RX_BATCH = 1 Collected perf data, with 4.12 as the

Re: [iproute PATCH v2] ipaddress: Fix segfault in 'addr showdump'

2017-09-14 Thread Julien Fortin
v2 looks good to me, thanks for catching this segfault. On Wed, Sep 13, 2017 at 2:20 AM, Phil Sutter wrote: > Obviously, 'addr showdump' feature wasn't adjusted to json output > support. As a consequence, calls to print_string() in print_addrinfo() > tried to dereference a NULL FILE

[PATCH net] sctp: do not mark sk dumped when inet_sctp_diag_fill returns err

2017-09-14 Thread Xin Long
sctp_diag would not actually dump out sk/asoc if inet_sctp_diag_fill returns err, in which case it shouldn't mark sk dumped by setting cb->args[3] as 1 in sctp_sock_dump(). Otherwise, it could cause some asocs to have no parent's sk dumped in 'ss --sctp'. So this patch is to not set cb->args[3]

[PATCH net] sctp: fix an use-after-free issue in sctp_sock_dump

2017-09-14 Thread Xin Long
Commit 86fdb3448cc1 ("sctp: ensure ep is not destroyed before doing the dump") tried to fix an use-after-free issue by checking !sctp_sk(sk)->ep with holding sock and sock lock. But Paolo noticed that endpoint could be destroyed in sctp_rcv without sock lock protection. It means the

[PATCH 1/1] forcedeth: replace pci_map_single with dma_map_single functions

2017-09-14 Thread Zhu Yanjun
pci_map_single functions are obsolete. So replace them with dma_map_single functions. Signed-off-by: Zhu Yanjun --- drivers/net/ethernet/nvidia/forcedeth.c | 70 + 1 file changed, 36 insertions(+), 34 deletions(-) diff --git

RE: [Intel-wired-lan] [PATCH 5/5] e1000e: Avoid receiver overrun interrupt bursts

2017-09-14 Thread Brown, Aaron F
> From: Intel-wired-lan [mailto:intel-wired-lan-boun...@osuosl.org] On Behalf > Of Benjamin Poirier > Sent: Friday, July 21, 2017 11:36 AM > To: Kirsher, Jeffrey T > Cc: netdev@vger.kernel.org; intel-wired-...@lists.osuosl.org; linux- > ker...@vger.kernel.org; Lennart

RE: [Intel-wired-lan] [PATCH 4/5] e1000e: Separate signaling for link check/link up

2017-09-14 Thread Brown, Aaron F
On 7/21/2017 21:36, Benjamin Poirier wrote: > Lennart reported the following race condition: > > \ e1000_watchdog_task > \ e1000e_has_link > \ hw->mac.ops.check_for_link() === e1000e_check_for_copper_link > /* link is up */ > mac->get_link_status = false; >

RE: [Intel-wired-lan] [PATCH 3/5] e1000e: Fix return value test

2017-09-14 Thread Brown, Aaron F
> From: Intel-wired-lan [mailto:intel-wired-lan-boun...@osuosl.org] On Behalf > Of Benjamin Poirier > Sent: Friday, July 21, 2017 11:36 AM > To: Kirsher, Jeffrey T > Cc: netdev@vger.kernel.org; intel-wired-...@lists.osuosl.org; linux- > ker...@vger.kernel.org; Lennart

RE: [Intel-wired-lan] [PATCH 1/5] e1000e: Fix error path in link detection

2017-09-14 Thread Brown, Aaron F
> From: Intel-wired-lan [mailto:intel-wired-lan-boun...@osuosl.org] On Behalf > Of Benjamin Poirier > Sent: Friday, July 21, 2017 11:36 AM > To: Kirsher, Jeffrey T > Cc: netdev@vger.kernel.org; intel-wired-...@lists.osuosl.org; linux- > ker...@vger.kernel.org; Lennart

RE: [Intel-wired-lan] [PATCH net-next v3] e1000e: Be drop monitor friendly

2017-09-14 Thread Brown, Aaron F
> From: Intel-wired-lan [mailto:intel-wired-lan-boun...@osuosl.org] On Behalf > Of Florian Fainelli > Sent: Friday, August 25, 2017 6:14 PM > To: netdev@vger.kernel.org > Cc: eduma...@gmail.com; Florian Fainelli ; open list > ; moderated

RE: [PATCH] e1000e: apply burst mode settings only on default

2017-09-14 Thread Brown, Aaron F
> From: netdev-ow...@vger.kernel.org [mailto:netdev- > ow...@vger.kernel.org] On Behalf Of Willem de Bruijn > Sent: Friday, August 25, 2017 8:06 AM > To: Kirsher, Jeffrey T > Cc: intel-wired-...@lists.osuosl.org; netdev@vger.kernel.org; Brandeburg, > Jesse

Re: Bug with BPF_ALU64 | BPF_END?

2017-09-14 Thread Daniel Borkmann
On 09/14/2017 07:53 PM, Edward Cree wrote: Is BPF_END supposed to only be used with BPF_ALU, never with BPF_ALU64? In kernel/bpf/core.c:___bpf_prog_run(), there are only jump table targets for the BPF_ALU case, not for the BPF_ALU64 case (opcodes 0xd7 and 0xdf). But the verifier doesn't

Re: [PATCH net] packet: hold bind lock when rebinding to fanout hook

2017-09-14 Thread Eric Dumazet
On Thu, 2017-09-14 at 17:14 -0400, Willem de Bruijn wrote: > Packet socket bind operations must hold the po->bind_lock. This keeps > po->running consistent with whether the socket is actually on a ptype > list to receive packets. > > fanout_add unbinds a socket and its packet_rcv/tpacket_rcv

Re: feature request for kernel module 8021q

2017-09-14 Thread Florian Fainelli
On September 14, 2017 12:14:04 PM PDT, Pierre Colombier wrote: >Hello > > >One big problem with vlans on linux is that the native interface always > >get all vlans. > >This can cause problem with bridges. What specific problem are you thinking about? > > >One interesting

Re: Bug with BPF_ALU64 | BPF_END?

2017-09-14 Thread Y Song
On Thu, Sep 14, 2017 at 11:14 AM, David Miller wrote: > From: Edward Cree > Date: Thu, 14 Sep 2017 18:53:17 +0100 > >> Is BPF_END supposed to only be used with BPF_ALU, never with BPF_ALU64? Yes, only BPF_ALU. The below is LLVM bpf swap insn encoding:

[PATCH net] packet: hold bind lock when rebinding to fanout hook

2017-09-14 Thread Willem de Bruijn
Packet socket bind operations must hold the po->bind_lock. This keeps po->running consistent with whether the socket is actually on a ptype list to receive packets. fanout_add unbinds a socket and its packet_rcv/tpacket_rcv call, then binds the fanout object to receive through packet_rcv_fanout.

Re: [PATCH net-next v2 01/10] net: dsa: add debugfs interface

2017-09-14 Thread Andrew Lunn
> Can you clarify what type of registers it is you are wanting to read? > We already have ethtool which is meant to allow reading the device > registers for a given netdev. As long as the port has a netdev > associated it then there is no need to be getting into debugfs since > we should probably

Re: Page allocator bottleneck

2017-09-14 Thread Andi Kleen
Tariq Toukan writes: > > Congestion in this case is very clear. > When monitored in perf top: > 85.58% [kernel] [k] queued_spin_lock_slowpath Please look at the callers. Spinlock profiles without callers are usually useless because it's just blaming the messenger. Most

Re: [PATCH net-next v2 01/10] net: dsa: add debugfs interface

2017-09-14 Thread Alexander Duyck
On Thu, Sep 14, 2017 at 12:59 PM, Maxim Uvarov wrote: > debugfs here is very very useful to read registers directly and > compare what use space tools see. Cool feature to get regs by port and > use standard tools to diff and print them. Even might be better to > allow drivers

Re: [PATCH net-next v2 01/10] net: dsa: add debugfs interface

2017-09-14 Thread Maxim Uvarov
debugfs here is very very useful to read registers directly and compare what use space tools see. Cool feature to get regs by port and use standard tools to diff and print them. Even might be better to allow drivers to decode register names and bits values. Once that is done driver mainaince will

feature request for kernel module 8021q

2017-09-14 Thread Pierre Colombier
Hello One big problem with vlans on linux is that the native interface always get all vlans. This can cause problem with bridges. One interesting feature would be to have a special vlan number (let's say 0 or -1 or 4097 ) designed so that it gets all the untagged trafic and only the

Re: [PATCH v5 05/10] dt-bindings: net: dwmac-sun8i: update documentation about integrated PHY

2017-09-14 Thread Andrew Lunn
> > Is the MDIO controller "allwinner,sun8i-h3-emac" or "snps,dwmac-mdio"? > > If the latter, then I think the node is fine, but then the mux should be > > a child node of it. IOW, the child of an MDIO controller should either > > be a mux node or slave devices. Hi Rob Up until now, children

Re: [PATCH v5 05/10] dt-bindings: net: dwmac-sun8i: update documentation about integrated PHY

2017-09-14 Thread Corentin Labbe
On Wed, Sep 13, 2017 at 01:20:04PM -0500, Rob Herring wrote: > On Fri, Sep 08, 2017 at 09:43:25AM +0200, Corentin Labbe wrote: > > On Fri, Sep 08, 2017 at 09:25:38AM +0200, Maxime Ripard wrote: > > > On Fri, Sep 08, 2017 at 09:11:51AM +0200, Corentin Labbe wrote: > > > > This patch add

Re: [PATCH] net/mlx5: fpga: avoid uninitialized return codes

2017-09-14 Thread Saeed Mahameed
On Thu, Sep 14, 2017 at 5:54 AM, Leon Romanovsky wrote: > On Thu, Sep 14, 2017 at 01:06:18PM +0200, Arnd Bergmann wrote: >> calling mlx5_fpga_mem_{read,write}_i2c() with a zero length on >> older compiler version such as gcc-4.6 results in a warning that >> the return code is

Re: [PATCH v5 02/10] dt-bindings: net: Restore sun8i dwmac binding

2017-09-14 Thread Corentin Labbe
On Wed, Sep 13, 2017 at 01:07:34PM -0500, Rob Herring wrote: > On Fri, Sep 08, 2017 at 09:11:48AM +0200, Corentin Labbe wrote: > > This patch restore dt-bindings documentation about dwmac-sun8i > > This reverts commit 8aa33ec2f481 ("dt-bindings: net: Revert sun8i dwmac > > binding") > > Why? >

Re: Bug with BPF_ALU64 | BPF_END?

2017-09-14 Thread David Miller
From: Edward Cree Date: Thu, 14 Sep 2017 18:53:17 +0100 > Is BPF_END supposed to only be used with BPF_ALU, never with BPF_ALU64? > In kernel/bpf/core.c:___bpf_prog_run(), there are only jump table targets > for the BPF_ALU case, not for the BPF_ALU64 case (opcodes 0xd7

Re: RFC: Audit Kernel Container IDs

2017-09-14 Thread Richard Guy Briggs
On 2017-09-14 12:33, Eric W. Biederman wrote: > Richard Guy Briggs writes: > > > The trigger is a pseudo filesystem (proc, since PID tree already exists) > > write of a u64 representing the container ID to a file representing a > > process that will become the first process in a

Re: RTL8192EE PCIe Wireless Network Adapter crashed with linux-4.13

2017-09-14 Thread Larry Finger
On 09/14/2017 08:30 AM, Zwindl wrote: Dear developers: I'm using Arch Linux with testing enabled, the current kernel version and details are `Linux zwindl 4.13.2-1-ARCH #1 SMP PREEMPT Thu Sep 14 02:57:34 UTC 2017 x86_64 GNU/Linux`. The wireless card can't work properly from the kernel 4.13.

Bug with BPF_ALU64 | BPF_END?

2017-09-14 Thread Edward Cree
Is BPF_END supposed to only be used with BPF_ALU, never with BPF_ALU64? In kernel/bpf/core.c:___bpf_prog_run(), there are only jump table targets for the BPF_ALU case, not for the BPF_ALU64 case (opcodes 0xd7 and 0xdf). But the verifier doesn't enforce this; by crafting a program that uses these

Re: [PATCH net] netvsc: increase default receive buffer size

2017-09-14 Thread Stephen Hemminger
On Thu, 14 Sep 2017 10:02:03 -0700 (PDT) David Miller wrote: > From: Stephen Hemminger > Date: Thu, 14 Sep 2017 09:31:07 -0700 > > > The default receive buffer size was reduced by recent change > > to a value which was appropriate for 10G and

Re: RFC: Audit Kernel Container IDs

2017-09-14 Thread Eric W. Biederman
Richard Guy Briggs writes: > The trigger is a pseudo filesystem (proc, since PID tree already exists) > write of a u64 representing the container ID to a file representing a > process that will become the first process in a new container. > This might place restrictions on mount

Re: [PATCH net] netvsc: increase default receive buffer size

2017-09-14 Thread David Miller
From: Stephen Hemminger Date: Thu, 14 Sep 2017 09:31:07 -0700 > The default receive buffer size was reduced by recent change > to a value which was appropriate for 10G and Windows Server 2016. > But the value is too small for full performance with 40G on Azure. >

Re: [PATCH] tg3: clean up redundant initialization of tnapi

2017-09-14 Thread David Miller
From: Colin King Date: Thu, 14 Sep 2017 17:01:25 +0100 > From: Colin Ian King > > tnapi is being initialized and then immediately updated and > hence the initialiation is redundant. Clean up the warning > by moving the declaration and

Re: [PATCH] tls: make tls_sw_free_resources static

2017-09-14 Thread David Miller
From: Tobias Klauser Date: Thu, 14 Sep 2017 13:22:25 +0200 > Make the needlessly global function tls_sw_free_resources static to fix > a gcc/sparse warning. > > Signed-off-by: Tobias Klauser Applied.

Page allocator bottleneck

2017-09-14 Thread Tariq Toukan
Hi all, As part of the efforts to support increasing next-generation NIC speeds, I am investigating SW bottlenecks in network stack receive flow. Here I share some numbers I got for a simple experiment, in which I simulate the page allocation rate needed in 200Gpbs NICs. I ran the test below

Re: [LPC] 2nd RDMA Mini-Summit Schedule

2017-09-14 Thread Leon Romanovsky
On Wed, Sep 13, 2017 at 04:02:16PM +0300, Leon Romanovsky wrote: > On Thu, Sep 07, 2017 at 08:18:05AM +0300, Leon Romanovsky wrote: > > Hi, > > > > We're happy to announce schedule of the 2nd RDMA mini-summit, which will be > > held as part of coming Linux Plumbers Conference 2017. > > > > During

Re: [PATCH net] tcp: update skb->skb_mstamp more carefully

2017-09-14 Thread Soheil Hassas Yeganeh
On Thu, Sep 14, 2017 at 12:32 PM, Yuchung Cheng wrote: > On Thu, Sep 14, 2017 at 6:57 AM, Neal Cardwell wrote: >> On Wed, Sep 13, 2017 at 11:30 PM, Eric Dumazet >> wrote: >>> >>> From: Eric Dumazet >>> >>>

Re: [PATCH net] tcp: update skb->skb_mstamp more carefully

2017-09-14 Thread Yuchung Cheng
On Thu, Sep 14, 2017 at 6:57 AM, Neal Cardwell wrote: > On Wed, Sep 13, 2017 at 11:30 PM, Eric Dumazet wrote: >> >> From: Eric Dumazet >> >> liujian reported a problem in TCP_USER_TIMEOUT processing with a patch >> in

[PATCH net] netvsc: increase default receive buffer size

2017-09-14 Thread Stephen Hemminger
The default receive buffer size was reduced by recent change to a value which was appropriate for 10G and Windows Server 2016. But the value is too small for full performance with 40G on Azure. Increase the default back to maximum supported by host. Fixes: 8b5327975ae1 ("netvsc: allow controlling

Re: [PATCH v2] vxlan: only reduce known arp broadcast request to support virtual IP

2017-09-14 Thread Jiri Benc
On Thu, 14 Sep 2017 23:14:40 +0800, Chen Haiquan wrote: > +static bool arp_reduce_ignore_unknown_ip; > +module_param(arp_reduce_ignore_unknown_ip, bool, 0644); > +MODULE_PARM_DESC(arp_reduce_ignore_unknown_ip, > + "Only reduce known arp broaddcast request to support virtual > IP");

[PATCH] tg3: clean up redundant initialization of tnapi

2017-09-14 Thread Colin King
From: Colin Ian King tnapi is being initialized and then immediately updated and hence the initialiation is redundant. Clean up the warning by moving the declaration and initialization to the inside of the for-loop. Cleans up clang scan-build warning: warning: Value

selftests/bpf doesn't compile

2017-09-14 Thread Shuah Khan
Hi Alexei and Daniel, bpf test depends on clang and fails to compile when -- make -C tools/testing/selftests/bpf run_tests make: clang: Command not found Makefile:39: recipe for target

[PATCH v2] vxlan: only reduce known arp broadcast request to support virtual IP

2017-09-14 Thread Chen Haiquan
The purpose of vxlan arp reduce feature is to reply the broadcast arp request in vtep instead of sending it out to save traffic. The current implementation drops arp packet, if the ip cannot be found in neigh table. In the case of virtual IP address, user defines IP address without management from

Re: [PATCH] net: phy: Fix mask value write on gmii2rgmii converter speed register.

2017-09-14 Thread Andrew Lunn
On Thu, Sep 14, 2017 at 12:46:31PM +0530, Fahad Kunnathadi wrote: > To clear Speed Selection in MDIO control register(0x10), > ie, clear bits 6 and 13 to zero while keeping other bits same. > Before AND operation,The Mask value has to be perform with bitwise NOT > operation (ie, ~ operator) > >

[PATCH iproute2] tc: fix typo in tc-tcindex man page

2017-09-14 Thread Davide Caratti
fix mis-typed 'pass_on' keyword. Signed-off-by: Davide Caratti --- man/man8/tc-tcindex.8 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/man/man8/tc-tcindex.8 b/man/man8/tc-tcindex.8 index 7fcf8254..9a4e5ffc 100644 --- a/man/man8/tc-tcindex.8 +++

Re: [Intel-wired-lan] [PATCH] igb: check memory allocation failure

2017-09-14 Thread Waskiewicz Jr, Peter
On 9/13/17 7:24 PM, Brown, Aaron F wrote: >> From: Intel-wired-lan [mailto:intel-wired-lan-boun...@osuosl.org] On Behalf >> Of Christophe JAILLET >> Sent: Monday, August 28, 2017 10:13 AM >> To: Waskiewicz Jr, Peter ; Kirsher, Jeffrey T >>

Re: [PATCH] net/packet: fix race condition between fanout_add and __unregister_prot_hook

2017-09-14 Thread Willem de Bruijn
On Thu, Sep 14, 2017 at 10:07 AM, nixiaoming wrote: > From: l00219569 > > If fanout_add is preempted after running po-> fanout = match > and before running __fanout_link, > it will cause BUG_ON when __unregister_prot_hook call __fanout_unlink > > so, we

[PATCH] net/packet: fix race condition between fanout_add and __unregister_prot_hook

2017-09-14 Thread nixiaoming
From: l00219569 If fanout_add is preempted after running po-> fanout = match and before running __fanout_link, it will cause BUG_ON when __unregister_prot_hook call __fanout_unlink so, we need add mutex_lock(_mutex) to __unregister_prot_hook or add spin_lock(>bind_lock)

Re: [PATCH] net/ethernet/freescale: fix warning for ucc_geth

2017-09-14 Thread Longchamp, Valentin
Hi Christophe, On Thu, 2017-09-14 at 15:24 +0200, Christophe LEROY wrote: > Hi, > > Le 14/09/2017 à 14:05, Valentin Longchamp a écrit : > > Simple printk format warning for the the ucc registers address. > > Did you test your patch with mpc83xx_defconfig ? No I only tested on a 85xx where I

Re: [PATCH net] tcp: update skb->skb_mstamp more carefully

2017-09-14 Thread Neal Cardwell
On Wed, Sep 13, 2017 at 11:30 PM, Eric Dumazet wrote: > > From: Eric Dumazet > > liujian reported a problem in TCP_USER_TIMEOUT processing with a patch > in tcp_probe_timer() : > https://www.spinics.net/lists/netdev/msg454496.html > > After

Re: [PATCH] net/ethernet/freescale: fix warning for ucc_geth

2017-09-14 Thread Christophe LEROY
Hi, Le 14/09/2017 à 14:05, Valentin Longchamp a écrit : Simple printk format warning for the the ucc registers address. Did you test your patch with mpc83xx_defconfig ? I get a new warning with your patch: CC drivers/net/ethernet/freescale/ucc_geth.o In file included from

Re: [PATCH] net/mlx5: fpga: avoid uninitialized return codes

2017-09-14 Thread Leon Romanovsky
On Thu, Sep 14, 2017 at 01:06:18PM +0200, Arnd Bergmann wrote: > calling mlx5_fpga_mem_{read,write}_i2c() with a zero length on > older compiler version such as gcc-4.6 results in a warning that > the return code is not initialized: > > drivers/net/ethernet/mellanox/mlx5/core/fpga/sdk.c:147:6:

[PATCH] net/ethernet/freescale: fix warning for ucc_geth

2017-09-14 Thread Valentin Longchamp
Simple printk format warning for the the ucc registers address. Signed-off-by: Valentin Longchamp --- drivers/net/ethernet/freescale/ucc_geth.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/freescale/ucc_geth.c

[PATCH] tls: make tls_sw_free_resources static

2017-09-14 Thread Tobias Klauser
Make the needlessly global function tls_sw_free_resources static to fix a gcc/sparse warning. Signed-off-by: Tobias Klauser --- net/tls/tls_sw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/tls/tls_sw.c b/net/tls/tls_sw.c index

Re: [PATCH] net/packet: fix race condition between fanout_add and __unregister_prot_hook

2017-09-14 Thread Willem de Bruijn
On Wed, Sep 13, 2017 at 10:40 PM, nixiaoming wrote: > If fanout_add is preempted after running po-> fanout = match > and before running __fanout_link, > it will cause BUG_ON when __unregister_prot_hook call __fanout_unlink > > so, we need add mutex_lock(_mutex) to

[PATCH] net/mlx5: fpga: avoid uninitialized return codes

2017-09-14 Thread Arnd Bergmann
calling mlx5_fpga_mem_{read,write}_i2c() with a zero length on older compiler version such as gcc-4.6 results in a warning that the return code is not initialized: drivers/net/ethernet/mellanox/mlx5/core/fpga/sdk.c:147:6: error: ‘err’ may be used uninitialized in this function

System NIC does not get activated at boot time

2017-09-14 Thread Itaru Kitayama
Hi, Our Cavium ThunderX system's system NIC can not get activated upon boot for some reason. To make it active, we need to re-plug the network cable. The system is GIGABYTE R150-T62-00 (T45 BIOS), and is powered by CentOS 7 (kernel is 4.5.0-25.el7). Has anyone seen this kind of issue on a

[PATCH net-next 4/5] net: Add TLS TX offload features

2017-09-14 Thread Ilya Lesokhin
This patch adds a netdev feature to configure TLS TX offloads. Signed-off-by: Boris Pismenny Signed-off-by: Ilya Lesokhin Signed-off-by: Aviad Yehezkel --- include/linux/netdev_features.h | 2 ++ net/core/ethtool.c |

[PATCH net-next 0/5] tls: Add generic NIC offload infrastructure

2017-09-14 Thread Ilya Lesokhin
This series add a generic infrastructure to offload TLS crypto to a network devices. It enables the kernel TLS socket to skip encryption and authentication operations on the transmit side of the data path. Leaving those computationally expensive operations to the NIC. The NIC offload

[PATCH net-next 5/5] tls: Add generic NIC offload infrastructure.

2017-09-14 Thread Ilya Lesokhin
This patch adds a generic infrastructure to offload TLS crypto to a network devices. It enables the kernel TLS socket to skip encryption and authentication operations on the transmit side of the data path. Leaving those computationally expensive operations to the NIC. The NIC offload

[PATCH net-next 3/5] net: Add TLS offload netdev ops

2017-09-14 Thread Ilya Lesokhin
Add new netdev ops to add and delete tls context Signed-off-by: Boris Pismenny Signed-off-by: Ilya Lesokhin Signed-off-by: Aviad Yehezkel --- include/linux/netdevice.h | 21 + 1 file changed, 21 insertions(+)

[PATCH net-next 2/5] tcp: Add clean acked data hook

2017-09-14 Thread Ilya Lesokhin
Called when a TCP segment is acknowledged. Could be used by application protocols who hold additional metadata associated with the stream data This is required by TLS device offload to release metadata associated with acknowledged TLS records. Signed-off-by: Boris Pismenny

[PATCH net-next 1/5] tls: Move release of tls_ctx into tls_sw_free_resources

2017-09-14 Thread Ilya Lesokhin
Move release of tls_ctx into sw specific code. This is required because the device offload implementation requires this context to remain alive until there are no more in-flight SKBs. Signed-off-by: Boris Pismenny Signed-off-by: Ilya Lesokhin

Re: [PATCH] dt-bindings: net: renesas-ravb: Add support for R8A77995 RAVB

2017-09-14 Thread Sergei Shtylyov
Hello! On 9/14/2017 3:06 AM, Yoshihiro Shimoda wrote: Add a new compatible string for the R8A77995 (R-Car D3) RAVB. Acked-by: Geert Uytterhoeven Usually those are added after sign-off. Signed-off-by: Yoshihiro Shimoda

Re: [PATCH v2] net: smsc911x: Quieten netif during suspend

2017-09-14 Thread Geert Uytterhoeven
Hi Florian, On Thu, Sep 14, 2017 at 1:28 AM, Florian Fainelli wrote: > On 09/13/2017 10:42 AM, Geert Uytterhoeven wrote: >> If the network interface is kept running during suspend, the net core >> may call net_device_ops.ndo_start_xmit() while the Ethernet device is >>

Re: [PATCH net-next v9] openvswitch: enable NSH support

2017-09-14 Thread Jiri Benc
On Thu, 14 Sep 2017 16:37:59 +0800, Yi Yang wrote: > OVS master and 2.8 branch has merged NSH userspace > patch series, this patch is to enable NSH support > in kernel data path in order that OVS can support > NSH in compat mode by porting this. http://vger.kernel.org/~davem/net-next.html

Re: scheduling while atomic from vmci_transport_recv_stream_cb in 3.16 kernels

2017-09-14 Thread Michal Hocko
On Wed 13-09-17 18:58:13, Jorgen S. Hansen wrote: [...] > The patch series look good to me. Thanks for double checking. Ben, could you merge this to 3.16 stable branch, please? -- Michal Hocko SUSE Labs

[PATCH net-next v9] openvswitch: enable NSH support

2017-09-14 Thread Yi Yang
v8->v9 - Fix build error reported by daily intel build because nsh module isn't selected by openvswitch v7->v8 - Rework nested value and mask for OVS_KEY_ATTR_NSH - Change pop_nsh to adapt to nsh kernel module - Fix many issues per comments from Jiri Benc v6->v7 - Remove NSH GSO patches

Re: [PATCH net] tcp: update skb->skb_mstamp more carefully

2017-09-14 Thread liujian
On 2017/9/14 11:30, Eric Dumazet worte: > From: Eric Dumazet > > liujian reported a problem in TCP_USER_TIMEOUT processing with a patch > in tcp_probe_timer() : > https://www.spinics.net/lists/netdev/msg454496.html > > After investigations, the root cause of the

Re: [RFC PATCH v3 7/7] i40e: Enable cloud filters via tc-flower

2017-09-14 Thread Nambiar, Amritha
On 9/13/2017 6:26 AM, Jiri Pirko wrote: > Wed, Sep 13, 2017 at 11:59:50AM CEST, amritha.namb...@intel.com wrote: >> This patch enables tc-flower based hardware offloads. tc flower >> filter provided by the kernel is configured as driver specific >> cloud filter. The patch implements functions and

Re: [RFC PATCH v3 2/7] sched: act_mirred: Traffic class option for mirror/redirect action

2017-09-14 Thread Nambiar, Amritha
On 9/13/2017 6:18 AM, Jiri Pirko wrote: > Wed, Sep 13, 2017 at 11:59:24AM CEST, amritha.namb...@intel.com wrote: >> Adds optional traffic class parameter to the mirror/redirect action. >> The mirror/redirect action is extended to forward to a traffic >> class on the device if the traffic class

Re: [PATCH 1/1] forcedeth: remove tx_stop variable

2017-09-14 Thread Yanjun Zhu
Hi, all After this patch is applied, the TCP && UDP tests are made. The TCP bandwidth is 939 Mbits/sec. The UDP bandwidth is 806 Mbits/sec. So I think this patch can work well. host1 <-> host2 host1: forcedeth NIC IP: 1.1.1.107 iperf -s host2: forcedeth NIC IP:1.1.1.105 iperf -c

[PATCH] net: phy: Fix mask value write on gmii2rgmii converter speed register.

2017-09-14 Thread Fahad Kunnathadi
To clear Speed Selection in MDIO control register(0x10), ie, clear bits 6 and 13 to zero while keeping other bits same. Before AND operation,The Mask value has to be perform with bitwise NOT operation (ie, ~ operator) This patch clears current speed selection before writing the new speed settings

Re: [PATCH v2] ipv4: Namespaceify tcp_fastopen knob

2017-09-14 Thread 严海双
> On 2017年9月13日, at 下午9:02, Eric Dumazet wrote: > > On Wed, 2017-09-13 at 05:44 -0700, Eric Dumazet wrote: >> On Wed, 2017-09-13 at 19:19 +0800, Haishuang Yan wrote: >>> Different namespace application might require enable TCP Fast Open >>> feature independently of the

Re: [Outreachy kernel] [PATCH] staging: irda: Remove typedef struct

2017-09-14 Thread Julia Lawall
On Wed, 13 Sep 2017, Haneen Mohammed wrote: > This patch remove typedef from a structure with all its ocurrences > since using typedefs for structures is discouraged. > Issue found using Coccinelle: > > @r1@ > type T; > @@ > > typedef struct { ... } T; > > @script:python c1@ > T2; > T << r1.T;