Re: WARNING: kernel stack frame pointer at ffff880156a5fea0 in bash:2103 has bad value 00007ffec7d87e50

2017-09-26 Thread Richard Weinberger
Am Mittwoch, 27. September 2017, 00:42:46 CEST schrieb Josh Poimboeuf: > > Here is another variant of the warning, it matches the attached .config: > I can take a look at it. Unfortunately, for these types of issues I > often need the vmlinux file to be able to make sense of the unwinder > dump.

[patch net-next v3 00/12] mlxsw: Add support for offloading IPv4 multicast routes

2017-09-26 Thread Jiri Pirko
From: Jiri Pirko Yotam says: This patch-set introduces offloading of the kernel IPv4 multicast router logic in the Spectrum driver. The first patch makes the Spectrum driver ignore FIB notifications that are not of address family IPv4 or IPv6. This is needed in order to prevent crashes while th

[patch net-next v3 10/12] mlxsw: spectrum_router: Add multicast routes notification handling functionality

2017-09-26 Thread Jiri Pirko
From: Yotam Gigi Add functionality for calling the multicast routing offloading logic upon MFC and VIF add and delete notifications. In addition, call the multicast routing upon RIF addition and deletion events. As the multicast routing offload logic may sleep, the actual calls are done in a def

[patch net-next v3 01/12] fib: notifier: Add VIF add and delete event types

2017-09-26 Thread Jiri Pirko
From: Yotam Gigi In order for an interface to forward packets according to the kernel multicast routing table, it must be configured with a VIF index according to the mroute user API. The VIF index is then used to refer to that interface in the mroute user API, for example, to set the iif and oif

[patch net-next v3 12/12] mlxsw: spectrum: router: Don't ignore IPMR notifications

2017-09-26 Thread Jiri Pirko
From: Yotam Gigi Make the Spectrum router logic not ignore the RTNL_FAMILY_IPMR FIB notifications. Past commits added the IPMR VIF and MFC add/del notifications via the fib_notifier chain. In addition, a code for handling these notifications in the Spectrum router logic was added. Make the Spect

[patch net-next v3 08/12] mlxsw: spectrum: Add the multicast routing hardware logic

2017-09-26 Thread Jiri Pirko
From: Yotam Gigi Implement the multicast routing hardware API introduced in previous patch for the specific spectrum hardware. The spectrum hardware multicast routes are written using the RMFT2 register and point to an ACL flexible action set. The actions used for multicast routes are: - Counte

[patch net-next v3 11/12] mlxsw: spectrum: Notify multicast router on RIF MTU changes

2017-09-26 Thread Jiri Pirko
From: Yotam Gigi Due to the fact that multicast routes hold the minimum MTU of all the egress RIFs and trap packets that don't meet it, notify the mulitcast router code on RIF MTU changes. Signed-off-by: Yotam Gigi Reviewed-by: Ido Schimmel Signed-off-by: Jiri Pirko --- drivers/net/ethernet/

[patch net-next v3 07/12] mlxsw: spectrum: Add the multicast routing offloading logic

2017-09-26 Thread Jiri Pirko
From: Yotam Gigi Add the multicast router offloading logic, which is in charge of handling the VIF and MFC notifications and translating it to the hardware logic API. The offloading logic has to overcome several obstacles in order to safely comply with the kernel multicast router user API: - It

[patch net-next v3 09/12] mlxsw: spectrum: router: Squash the default route table to main

2017-09-26 Thread Jiri Pirko
From: Yotam Gigi Currently, the mlxsw Spectrum driver offloads only either the RT_TABLE_MAIN FIB table or the VRF tables, so the RT_TABLE_LOCAL table is squashed to the RT_TABLE_MAIN table to allow local routes to be offloaded too. By default, multicast MFC routes which are not assigned to any u

[patch net-next v3 05/12] net: ipmr: Add MFC offload indication

2017-09-26 Thread Jiri Pirko
From: Yotam Gigi Allow drivers, registered to the fib notification chain indicate whether a multicast MFC route is offloaded or not, similarly to unicast routes. The indication of whether a route is offloaded is done using the mfc_flags field on an mfc_cache struct, and the information is sent to

[patch net-next v3 02/12] ipmr: Add reference count to MFC entries

2017-09-26 Thread Jiri Pirko
From: Yotam Gigi Next commits will introduce MFC notifications through the atomic fib_notification chain, thus allowing modules to be aware of MFC entries. Due to the fact that modules may need to hold a reference to an MFC entry, add reference count to MFC entries to prevent them from being fre

[patch net-next v3 03/12] ipmr: Add FIB notification access functions

2017-09-26 Thread Jiri Pirko
From: Yotam Gigi Make the ipmr module register as a FIB notifier. To do that, implement both the ipmr_seq_read and ipmr_dump ops. The ipmr_seq_read op returns a sequence counter that is incremented on every notification related operation done by the ipmr. To implement that, add a sequence counte

[patch net-next v3 04/12] ipmr: Send FIB notifications on MFC and VIF entries

2017-09-26 Thread Jiri Pirko
From: Yotam Gigi Use the newly introduced notification chain to send events upon VIF and MFC addition and deletion. The MFC notifications are sent only on resolved MFC entries, as unresolved cannot be offloaded. Signed-off-by: Yotam Gigi Reviewed-by: Ido Schimmel Signed-off-by: Jiri Pirko Rev

[patch net-next v3 06/12] net: mroute: Check if rule is a default rule

2017-09-26 Thread Jiri Pirko
From: Yotam Gigi When the ipmr starts, it adds one default FIB rule that matches all packets and sends them to the DEFAULT (multicast) FIB table. A more complex rule can be added by user to specify that for a specific interface, a packet should be look up at either an arbitrary table or according

Re: [PATCH net] net: Set sk_prot_creator when cloning sockets to the right proto

2017-09-26 Thread Eric Dumazet
On Tue, 2017-09-26 at 17:38 -0700, Christoph Paasch wrote: > sk->sk_prot and sk->sk_prot_creator can differ when the app uses > IPV6_ADDRFORM (transforming an IPv6-socket to an IPv4-one). > Which is why sk_prot_creator is there to make sure that sk_prot_free() > does the kmem_cache_free() on the ri

Re: [PATCH] net: stmmac: Meet alignment requirements for DMA

2017-09-26 Thread Paul Burton
Hi David, On Tuesday, 26 September 2017 21:53:21 PDT David Miller wrote: > From: Paul Burton > Date: Tue, 26 Sep 2017 21:30:56 -0700 > > > Nobody said that you are required to do anything, I suggested that > > it would be beneficial if you were to suggest a change to the > > documented DMA API s

[PATCH v4 net-next 05/12] gtp: Change to use gro_cells

2017-09-26 Thread Tom Herbert
Call gro_cells_receive instead of netif_rx. Signed-off-by: Tom Herbert --- drivers/net/Kconfig | 1 + drivers/net/gtp.c | 11 ++- 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig index aba0d652095b..d4292d56bb02 100644 --- a/driv

[PATCH v4 net-next 09/12] gtp: Eliminate pktinfo and add port configuration

2017-09-26 Thread Tom Herbert
The gtp pktinfo structure is unnecessary and needs a lot of code to manage it. Remove it. Also, add per pdp port configuration for transmit. Signed-off-by: Tom Herbert --- drivers/net/gtp.c| 177 +-- include/uapi/linux/gtp.h | 1 + 2 files ch

[PATCH v4 net-next 07/12] gtp: udp recv clean up

2017-09-26 Thread Tom Herbert
Create separate UDP receive functions for GTP version 0 and version 1. Set encap_rcv appropriately when configuring a socket. Signed-off-by: Tom Herbert --- drivers/net/gtp.c | 100 ++ 1 file changed, 49 insertions(+), 51 deletions(-) diff --g

[PATCH v4 net-next 10/12] gtp: Experimental encapsulation of IPv6 packets

2017-09-26 Thread Tom Herbert
Allow IPv6 mobile subscriber packets. This entails adding an IPv6 mobile subscriber address to pdp context and IPv6 specific variants to find pdp contexts by address. Note that this is experimental support of IPv6, more work is necessary to make this compliant with 3GPP standard. Signed-off-by: T

[PATCH v4 net-next 06/12] gtp: Use goto for exceptions in gtp_udp_encap_recv funcs

2017-09-26 Thread Tom Herbert
Consolidate return logic to make it easier to extend. Signed-off-by: Tom Herbert --- drivers/net/gtp.c | 26 +- 1 file changed, 17 insertions(+), 9 deletions(-) diff --git a/drivers/net/gtp.c b/drivers/net/gtp.c index f2aac5d01143..00e5ea5cb935 100644 --- a/drivers/net/g

[PATCH v4 net-next 11/12] gtp: Experimental support encpasulating over IPv6

2017-09-26 Thread Tom Herbert
Allows using GTP datapath over IPv6. Remote peers are indicated by IPv6. Note this is experimental, more work is needed to make this compliant with 3GPP standard. Signed-off-by: Tom Herbert --- drivers/net/gtp.c| 248 ++- include/uapi/linux/gt

[PATCH v4 net-next 08/12] gtp: Call function to update path mtu

2017-09-26 Thread Tom Herbert
Replace mtu handling with call to __iptunnel_update_pmtu. Signed-off-by: Tom Herbert --- drivers/net/gtp.c | 36 ++-- 1 file changed, 6 insertions(+), 30 deletions(-) diff --git a/drivers/net/gtp.c b/drivers/net/gtp.c index a6e2e0a1f424..bbb08f8849d3 100644 --- a

[PATCH v4 net-next 03/12] gtp: Call common functions to get tunnel routes and add dst_cache

2017-09-26 Thread Tom Herbert
Call ip_tunnel_get_route and dst_cache to pdp context which should improve performance by obviating the need to perform a route lookup on every packet. Signed-off-by: Tom Herbert --- drivers/net/gtp.c | 62 +++ 1 file changed, 35 insertions(+),

[PATCH v4 net-next 02/12] vxlan: Call common functions to get tunnel routes

2017-09-26 Thread Tom Herbert
Call ip_tunnel_get_route and ip6_tnl_get_route to handle getting a route and dealing with the dst_cache. Signed-off-by: Tom Herbert --- drivers/net/vxlan.c | 84 - 1 file changed, 5 insertions(+), 79 deletions(-) diff --git a/drivers/net/vxlan

[PATCH v4 net-next 01/12] iptunnel: Add common functions to get a tunnel route

2017-09-26 Thread Tom Herbert
ip_tunnel_get_route and ip6_tnl_get_route are created to return routes for a tunnel. These functions are derived from the VXLAN functions. Signed-off-by: Tom Herbert --- include/net/ip6_tunnel.h | 33 + include/net/ip_tunnels.h | 32 +++

[PATCH v4 net-next 12/12] gtp: Allow configuring GTP interface as standalone

2017-09-26 Thread Tom Herbert
Add new configuration of GTP interfaces that allow specifying a port to listen on (as opposed to having to get sockets from a userspace control plane). This allows GTP interfaces to be configured and the data path tested without requiring a GTP-C daemon. Signed-off-by: Tom Herbert --- drivers/ne

[PATCH v4 net-next 04/12] iptunnel: Generalize tunnel update pmtu

2017-09-26 Thread Tom Herbert
Add __iptunnel_update_pmtu exported function which does not take an iptunnel argument but instead includes the fields from the iptunnel structure as arguments which are needed in the function. iptunnel_update_pmtu was modified to call __iptunnel_update_pmtu. Signed-off-by: Tom Herbert --- inclu

[PATCH v4 net-next 00/12] gtp: Additional feature support - Part I

2017-09-26 Thread Tom Herbert
This patch set builds upon the initial GTP implementation to make support closer to that enjoyed by other encapsulation protocols. The major items are: - Experimental IPv6 support - Configurable networking interfaces so that GTP kernel can be used and tested without needing GSN network em

Re: [PATCH] net: stmmac: Meet alignment requirements for DMA

2017-09-26 Thread David Miller
From: Paul Burton Date: Tue, 26 Sep 2017 21:30:56 -0700 > Nobody said that you are required to do anything, I suggested that > it would be beneficial if you were to suggest a change to the > documented DMA API such that it allows your usage where it currently > does not. Documentation is often w

Re: [PATCH v2 16/16] net: Add support for networking over Thunderbolt cable

2017-09-26 Thread David Miller
From: Mika Westerberg Date: Mon, 25 Sep 2017 14:07:38 +0300 > +struct thunderbolt_ip_header { > + u32 route_hi; > + u32 route_lo; > + u32 length_sn; > + uuid_t uuid; > + uuid_t initiator_uuid; > + uuid_t target_uuid; > + u32 type; > + u32 command_id; > +} __packed;

Re: [PATCH v2 06/16] thunderbolt: Add support for XDomain discovery protocol

2017-09-26 Thread David Miller
From: Mika Westerberg Date: Mon, 25 Sep 2017 14:07:28 +0300 > +struct icm_fr_event_xdomain_connected { > + struct icm_pkg_header hdr; > + u16 reserved; > + u16 link_info; > + uuid_t remote_uuid; > + uuid_t local_uuid; > + u32 local_route_hi; > + u32 local_route_lo; > +

Re: [PATCH v2 02/16] thunderbolt: Add support for XDomain properties

2017-09-26 Thread David Miller
From: Mika Westerberg Date: Mon, 25 Sep 2017 14:07:24 +0300 > +struct tb_property_entry { > + u32 key_hi; > + u32 key_lo; > + u16 length; > + u8 reserved; > + u8 type; > + u32 value; > +} __packed; > + > +struct tb_property_rootdir_entry { > + u32 magic; > + u32 le

[PATCH] net-ipv6: add support for sockopt(SOL_IPV6, IPV6_FREEBIND)

2017-09-26 Thread Maciej Żenczykowski
From: Maciej Żenczykowski So far we've been relying on sockopt(SOL_IP, IP_FREEBIND) being usable even on IPv6 sockets. However, it turns out it is perfectly reasonable to want to set freebind on an AF_INET6 SOCK_RAW socket - but there is no way to set any SOL_IP socket option on such a socket (t

Re: [PATCH] net: stmmac: Meet alignment requirements for DMA

2017-09-26 Thread Paul Burton
Hi David, On Tuesday, 26 September 2017 19:52:44 PDT David Miller wrote: > From: Paul Burton > Date: Tue, 26 Sep 2017 14:30:33 -0700 > > > I'd suggest that at a minimum if you're unwilling to obey the API as > > described in Documentation/DMA-API.txt then it would be beneficial > > if you could

Re: [PATCH net-next 0/7] nfp: flower vxlan tunnel offload

2017-09-26 Thread David Miller
From: Simon Horman Date: Mon, 25 Sep 2017 12:23:34 +0200 > From: Simon Horman > > John says: > > This patch set allows offloading of TC flower match and set tunnel fields > to the NFP. The initial focus is on VXLAN traffic. Due to the current > state of the NFP firmware, only VXLAN traffic on

Re: [PATCH net] net/ncsi: Don't assume last available channel exists

2017-09-26 Thread Samuel Mendoza-Jonas
On Thu, 2017-09-21 at 18:11 -0700, David Miller wrote: > From: Samuel Mendoza-Jonas > Date: Fri, 22 Sep 2017 11:00:00 +1000 > > > If we haven't configured a channel yet (or are in the process of doing > > so) we won't have a hot_channel - does it make more sense to > > - check against the hot_cha

Re: [PATCH net v2] sctp: Fix a big endian bug in sctp_diag_dump()

2017-09-26 Thread David Miller
From: Dan Carpenter Date: Mon, 25 Sep 2017 13:19:26 +0300 > The sctp_for_each_transport() function takes an pointer to int. The > cb->args[] array holds longs so it's only using the high 32 bits. It > works on little endian system but will break on big endian 64 bit > machines. > > Fixes: d25a

[PATCH v5 2/4] ipv4: Remove the 'publish' logic in tcp_fastopen_init_key_once

2017-09-26 Thread Haishuang Yan
The 'publish' logic is not necessary after commit dfea2aa65424 ("tcp: Do not call tcp_fastopen_reset_cipher from interrupt context"), because in tcp_fastopen_cookie_gen,it wouldn't call tcp_fastopen_init_key_once. Signed-off-by: Haishuang Yan --- include/net/tcp.h | 2 +- net/ipv4/af_in

[PATCH] net-ipv6: remove unused IP6_ECN_clear() function

2017-09-26 Thread Maciej Żenczykowski
From: Maciej Żenczykowski This function is unused, and furthermore it is buggy since it suffers from the same issue that requires IP6_ECN_set_ce() to take a pointer to the skb so that it may (in case of CHECKSUM_COMPLETE) update skb->csum Instead of fixing it, let's just outright remove it. Tes

[PATCH v5 3/4] ipv4: Namespaceify tcp_fastopen_key knob

2017-09-26 Thread Haishuang Yan
Different namespace application might require different tcp_fastopen_key independently of the host. David Miller pointed out there is a leak without releasing the context of tcp_fastopen_key during netns teardown. So add the release action in exit_batch path. Tested: 1. Container namespace: # cat

[PATCH v5 1/4] ipv4: Namespaceify tcp_fastopen knob

2017-09-26 Thread Haishuang Yan
Different namespace application might require enable TCP Fast Open feature independently of the host. This patch series continues making more of the TCP Fast Open related sysctl knobs be per net-namespace. Reported-by: Luca BRUNO Signed-off-by: Haishuang Yan --- Changes since v5: * Splite pa

Re: [patch net-next 0/3] mlxsw: Introduce support for "pass" gact action offloading

2017-09-26 Thread David Miller
From: Jiri Pirko Date: Mon, 25 Sep 2017 10:58:19 +0200 > From: Jiri Pirko > > Very simple patchset adds ability for user to insert filters with "pass" > gact action and offload it. That allows scenarios like this: > > $ tc filter add dev enp3s0np19 ingress protocol ip pref 10 flower skip_sw >

[PATCH v5 4/4] ipv4: Namespaceify tcp_fastopen_blackhole_timeout knob

2017-09-26 Thread Haishuang Yan
Different namespace application might require different time period in second to disable Fastopen on active TCP sockets. Tested: Simulate following similar situation that the server's data gets dropped after 3WHS. C syn-data ---> S C <--- syn/ack - S C ack > S S (accept & wri

Re: pull-request: wireless-drivers 2017-09-25

2017-09-26 Thread David Miller
From: Kalle Valo Date: Mon, 25 Sep 2017 11:55:22 +0300 > here a pull request to net for 4.14, more info in the signed tag below. > Please let me know if there are any problems. Pulled, thanks Kalle.

Re: [PATCH 6/6] net: dsa: mv88e6xxx: Forward broadcast frames to cpu and dsa ports

2017-09-26 Thread David Miller
From: Andrew Lunn Date: Wed, 27 Sep 2017 00:26:04 +0200 > + > + for (port = 0; port < mv88e6xxx_num_ports(chip); ++port) { Just a nit pick since you are going to respin this anyways: for (x; cond(x); x++) seems to be the canonical way to express this in the kernel, so please make "

Re: [PATCH net-next 0/5] net: dsa: use generic slave phydev

2017-09-26 Thread David Miller
From: Vivien Didelot Date: Tue, 26 Sep 2017 17:15:30 -0400 > DSA currently stores a phy_device pointer in each slave private > structure. This requires to implement our own ethtool ksettings > accessors and such. > > This patchset removes the private phy_device in favor of the one > provided in

Re: [patch net-next 00/10] mlxsw: Add router adjacency dpipe table

2017-09-26 Thread David Miller
From: Jiri Pirko Date: Mon, 25 Sep 2017 10:32:20 +0200 > From: Jiri Pirko > > Arkadi says: > > This patchset adds router adjacency dpipe table support. This will provide > the ability to observe the hardware offloaded IPv4/6 nexthops. Series applied, thanks everyone.

Re: [PATCH] net/ipv4: Update sk_for_each_entry_offset_rcu macro to utilize rcu methods hlist_next_rcu. This fixes the warnings thrown by sparse regarding net/ipv4/udp.c on line 1974.

2017-09-26 Thread David Miller
From: Tim Hansen Date: Tue, 26 Sep 2017 20:54:05 -0400 > Signed-off-by: Tim Hansen This is a poor patch submission on many levels. But the main problem, is that there is no use of sk_for_each_entry_offset_rcu() in any of my networking kernel trees. Referencing code by line number never works,

Re: [PATCH] net: stmmac: Meet alignment requirements for DMA

2017-09-26 Thread David Miller
From: Paul Burton Date: Tue, 26 Sep 2017 14:30:33 -0700 > I'd suggest that at a minimum if you're unwilling to obey the API as > described in Documentation/DMA-API.txt then it would be beneficial > if you could propose a change to it such that it works for you, and > perhaps we can extend the API

Re: [PATCH net-next RFC 0/5] batched tx processing in vhost_net

2017-09-26 Thread Jason Wang
On 2017年09月27日 03:26, Michael S. Tsirkin wrote: On Fri, Sep 22, 2017 at 04:02:30PM +0800, Jason Wang wrote: Hi: This series tries to implement basic tx batched processing. This is done by prefetching descriptor indices and update used ring in a batch. This intends to speed up used ring updati

Re: [PATCH net-next RFC 5/5] vhost_net: basic tx virtqueue batched processing

2017-09-26 Thread Jason Wang
On 2017年09月27日 03:25, Michael S. Tsirkin wrote: On Fri, Sep 22, 2017 at 04:02:35PM +0800, Jason Wang wrote: This patch implements basic batched processing of tx virtqueue by prefetching desc indices and updating used ring in a batch. For non-zerocopy case, vq->heads were used for storing the p

[PATCH v3 net-next 00/10] Add support for DCB feature in hns3 driver

2017-09-26 Thread Yunsheng Lin
The patchset contains some enhancement related to DCB before adding support for DCB feature. This patchset depends on the following patchset: https://patchwork.ozlabs.org/cover/815646/ https://patchwork.ozlabs.org/cover/816145/ High Level Architecture: [ lldpad ]

[PATCH v3 net-next 01/10] net: hns3: Support for dynamically assigning tx buffer to TC

2017-09-26 Thread Yunsheng Lin
This patch add support of dynamically assigning tx buffer to TC when the TC is enabled. It will save buffer for rx direction to avoid packet loss. Signed-off-by: Yunsheng Lin --- V2: Fix for not defining variables in local loop. V1: Initial submit. --- .../net/ethernet/hisilicon

[PATCH v3 net-next 10/10] net: hns3: Add DCB support when interacting with network stack

2017-09-26 Thread Yunsheng Lin
When using lldptool to configure DCB parameter, hclge_dcb module call the client_ops->setup_tc to tell network stack which queue and priority is using for specific tc. Signed-off-by: Yunsheng Lin --- V2: Drop mqprio support. V1: Initial submit. --- .../net/ethernet/hisilicon/hns

[PATCH v3 net-next 03/10] net: hns3: Add support for PFC setting in TM module

2017-09-26 Thread Yunsheng Lin
This patch add a pfc_pause_en cmd, and use it to configure PFC option according to fc_mode in hdev->tm_info. Signed-off-by: Yunsheng Lin --- .../net/ethernet/hisilicon/hns3/hns3pf/hclge_tm.c | 68 -- .../net/ethernet/hisilicon/hns3/hns3pf/hclge_tm.h | 5 ++ 2 files changed

[PATCH v3 net-next 06/10] net: hns3: Add some interface for the support of DCB feature

2017-09-26 Thread Yunsheng Lin
This patch add some interface and export some interface from hclge_tm and hclgc_main to support the upcoming DCB feature. Signed-off-by: Yunsheng Lin --- .../ethernet/hisilicon/hns3/hns3pf/hclge_main.c| 3 +- .../ethernet/hisilicon/hns3/hns3pf/hclge_main.h| 3 ++ .../net/ethernet/hisil

[PATCH v3 net-next 08/10] net: hns3: Add dcb netlink interface for the support of DCB feature

2017-09-26 Thread Yunsheng Lin
This patch add dcb netlink interface by calling the interface from hclge_dcb module. This patch also update Makefile in order to build hns3_dcbnl module. Signed-off-by: Yunsheng Lin --- .../net/ethernet/hisilicon/hns3/hns3pf/Makefile| 2 + .../ethernet/hisilicon/hns3/hns3pf/hns3_dcbnl.c

[PATCH v3 net-next 09/10] net: hns3: Setting for fc_mode and dcb enable flag in TM module

2017-09-26 Thread Yunsheng Lin
After the DCB feature is supported, fc_mode and dcb enable flag must be set according to the DCB parameter. Signed-off-by: Yunsheng Lin --- .../net/ethernet/hisilicon/hns3/hns3pf/hclge_tm.c | 34 +++--- 1 file changed, 30 insertions(+), 4 deletions(-) diff --git a/drivers/net/e

[PATCH v3 net-next 07/10] net: hns3: Add hclge_dcb module for the support of DCB feature

2017-09-26 Thread Yunsheng Lin
The hclge_dcb module calls the interface from hclge_main/tm and provide interface for the dcb netlink interface. This patch also update Makefiles required to build the DCB supported code in HNS3 Ethernet driver and update the existing Kconfig file in the hisilicon folder. Signed-off-by: Yunsheng

[PATCH v3 net-next 05/10] net: hns3: Add tc-based TM support for sriov enabled port

2017-09-26 Thread Yunsheng Lin
When sriov is enabled and TM is in tc-based mode, vf's TM parameters is not set in TM initialization process. This patch add the tc_based TM support for sriov enabled using the information in vport struct. Signed-off-by: Yunsheng Lin --- .../net/ethernet/hisilicon/hns3/hns3pf/hclge_tm.c | 49 ++

[PATCH v3 net-next 02/10] net: hns3: Add support for dynamically buffer reallocation

2017-09-26 Thread Yunsheng Lin
Current buffer allocation can only happen at init, when doing buffer reallocation after init, care must be taken care of memory which priv_buf points to. This patch fixes it by using a dynamic allocated temporary memory. Because we only do buffer reallocation at init or when setting up the DCB para

[PATCH v3 net-next 04/10] net: hns3: Add support for port shaper setting in TM module

2017-09-26 Thread Yunsheng Lin
This patch add a tm_port_shaper cmd and set port shaper to HCLGE_ETHER_MAX_RATE on TM initialization process. Signed-off-by: Yunsheng Lin --- .../net/ethernet/hisilicon/hns3/hns3pf/hclge_tm.c | 32 ++ .../net/ethernet/hisilicon/hns3/hns3pf/hclge_tm.h | 4 +++ 2 files chang

Re: [PATCH net-next v9] openvswitch: enable NSH support

2017-09-26 Thread Yang, Yi
On Tue, Sep 26, 2017 at 06:49:14PM +0800, Jiri Benc wrote: > On Tue, 26 Sep 2017 12:55:39 +0800, Yang, Yi wrote: > > After push_nsh, the packet won't be recirculated to flow pipeline, so > > key->eth.type must be set explicitly here, but for pop_nsh, the packet > > will be recirculated to flow pipe

Re: [ovs-dev] [PATCH net-next v9] openvswitch: enable NSH support

2017-09-26 Thread Yang, Yi
On Wed, Sep 27, 2017 at 04:59:36AM +0800, Eric Garver wrote: > On Tue, Sep 26, 2017 at 01:02:15PM +0800, Yang, Yi wrote: > > On Tue, Sep 26, 2017 at 03:28:42AM +0800, Eric Garver wrote: > > > On Mon, Sep 25, 2017 at 10:16:09PM +0800, Yi Yang wrote: > > > > + > > > > + length = nsh_hdr_len(nsh

Re: [PATCH v4 2/3] ipv4: Namespaceify tcp_fastopen_key knob

2017-09-26 Thread 严海双
> On 2017年9月27日, at 上午2:18, David Miller wrote: > > From: 严海双 > Date: Tue, 26 Sep 2017 09:25:51 +0800 > >>> On 2017年9月26日, at 上午7:24, David Miller wrote: >>> >>> From: Haishuang Yan >>> Date: Fri, 22 Sep 2017 21:48:43 +0800 >>> @@ -9,13 +9,18 @@ #include #include >>

Re: [PATCH net-next v10] openvswitch: enable NSH support

2017-09-26 Thread Yang, Yi
On Tue, Sep 26, 2017 at 10:42:40PM +0800, Jiri Benc wrote: > On Tue, 26 Sep 2017 21:52:41 +0800, Yang, Yi wrote: > > > + return ((ret != 0) ? false : true); > > > > But I don't think this is a problematic line from my understanding, > > Why not: > > return ((ret != 0 == true) ? false : tru

[PATCH] net/ipv4: Update sk_for_each_entry_offset_rcu macro to utilize rcu methods hlist_next_rcu. This fixes the warnings thrown by sparse regarding net/ipv4/udp.c on line 1974.

2017-09-26 Thread Tim Hansen
Signed-off-by: Tim Hansen --- include/net/sock.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/net/sock.h b/include/net/sock.h index aeeec62992ca..516289f6404b 100644 --- a/include/net/sock.h +++ b/include/net/sock.h @@ -732,10 +732,10 @@ static inline void sk_ad

[PATCH net] net: Set sk_prot_creator when cloning sockets to the right proto

2017-09-26 Thread Christoph Paasch
sk->sk_prot and sk->sk_prot_creator can differ when the app uses IPV6_ADDRFORM (transforming an IPv6-socket to an IPv4-one). Which is why sk_prot_creator is there to make sure that sk_prot_free() does the kmem_cache_free() on the right kmem_cache slab. Now, if such a socket gets transformed back t

Re: [PATCH v2 net-next 10/10] net: hns3: Add mqprio support when interacting with network stack

2017-09-26 Thread Yunsheng Lin
Hi, Yuval On 2017/9/26 20:29, Yuval Mintz wrote: >> Hi, Yuval >> >> On 2017/9/26 14:43, Yuval Mintz wrote: When using tc qdisc to configure DCB parameter, dcb_ops->setup_tc is used to tell hclge_dcb module to do the setup. >>> >>> While this might be a step in the right direction, this c

Re: [PATCH net-next 0/2] tools: add bpftool

2017-09-26 Thread Jakub Kicinski
On Tue, 26 Sep 2017 17:32:31 -0600, David Ahern wrote: > On 9/26/17 9:35 AM, Jakub Kicinski wrote: > > I'm looking for a home for bpftool, Daniel suggested that > > tools/net could be a good place, since there are only BPF > > utilities there already. > > > > The tool should be complete for simpl

Re: [PATCH net-next RFC 3/5] vhost: introduce vhost_add_used_idx()

2017-09-26 Thread Jason Wang
On 2017年09月27日 03:13, Michael S. Tsirkin wrote: On Fri, Sep 22, 2017 at 04:02:33PM +0800, Jason Wang wrote: This patch introduces a helper which just increase the used idx. This will be used in pair with vhost_prefetch_desc_indices() by batching code. Signed-off-by: Jason Wang --- drivers/

Re: [PATCH net-next RFC 2/5] vhost: introduce helper to prefetch desc index

2017-09-26 Thread Jason Wang
On 2017年09月27日 03:19, Michael S. Tsirkin wrote: On Fri, Sep 22, 2017 at 04:02:32PM +0800, Jason Wang wrote: This patch introduces vhost_prefetch_desc_indices() which could batch descriptor indices fetching and used ring updating. This intends to reduce the cache misses of indices fetching and

Re: [PATCH net-next RFC 0/5] batched tx processing in vhost_net

2017-09-26 Thread Jason Wang
On 2017年09月26日 21:45, Michael S. Tsirkin wrote: On Fri, Sep 22, 2017 at 04:02:30PM +0800, Jason Wang wrote: Hi: This series tries to implement basic tx batched processing. This is done by prefetching descriptor indices and update used ring in a batch. This intends to speed up used ring updati

Re: [REGRESSION] Warning in tcp_fastretrans_alert() of net/ipv4/tcp_input.c

2017-09-26 Thread Yuchung Cheng
On Tue, Sep 26, 2017 at 5:12 PM, Yuchung Cheng wrote: > On Tue, Sep 26, 2017 at 6:10 AM, Roman Gushchin wrote: >>> On Wed, Sep 20, 2017 at 6:46 PM, Roman Gushchin wrote: >>> > >>> > > Hello. >>> > > >>> > > Since, IIRC, v4.11, there is some regression in TCP stack resulting in >>> > > the >>> >

Re: [REGRESSION] Warning in tcp_fastretrans_alert() of net/ipv4/tcp_input.c

2017-09-26 Thread Yuchung Cheng
On Tue, Sep 26, 2017 at 6:10 AM, Roman Gushchin wrote: >> On Wed, Sep 20, 2017 at 6:46 PM, Roman Gushchin wrote: >> > >> > > Hello. >> > > >> > > Since, IIRC, v4.11, there is some regression in TCP stack resulting in >> > > the >> > > warning shown below. Most of the time it is harmless, but rar

Re: [PATCH net-next 0/5] net: dsa: use generic slave phydev

2017-09-26 Thread Florian Fainelli
On 09/26/2017 02:15 PM, Vivien Didelot wrote: > DSA currently stores a phy_device pointer in each slave private > structure. This requires to implement our own ethtool ksettings > accessors and such. > > This patchset removes the private phy_device in favor of the one > provided in the net_device

Re: [PATCH net-next 2/5] net: dsa: use slave device phydev

2017-09-26 Thread Florian Fainelli
On 09/26/2017 02:15 PM, Vivien Didelot wrote: > There is no need to store a phy_device in dsa_slave_priv since > net_device already provides one. Simply s/p->phy/dev->phydev/. > > Signed-off-by: Vivien Didelot Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH iproute2] Add information about COLORFGBG to ip.8 man page

2017-09-26 Thread Roland Hopferwieser
Your patch was damaged by the mailer you used. Please fix and resubmit. Sorry, now as attachment. diff --git a/man/man8/ip.8 b/man/man8/ip.8 index ae018fdf..2a27a56e 100644 --- a/man/man8/ip.8 +++ b/man/man8/ip.8 @@ -187,7 +187,8 @@ executes specified command over all objects, it depends if comm

[PATCH iproute2 v3] lib: json_print: rework 'new_json_obj' drop FILE* argument

2017-09-26 Thread Julien Fortin
From: Julien Fortin As Stephen Hemminger mentioned on the last submission the new_json_obj function is always called with fp == stdout, so right now, there's no need of this extra argument. The background for the rework is the following: The ip monitor didn't call `new_json_obj` (even for in non

[iproute2 net-next 2/3] tc: Add support for the CBS qdisc

2017-09-26 Thread Vinicius Costa Gomes
The Credit Based Shaper (CBS) queueing discipline allows bandwidth reservation with sub-milisecond precision. It is defined by the 802.1Q-2014 specification (section 8.6.8.2 and Annex L). The syntax is: tc qdisc add dev DEV parent NODE cbs locredit hicredit sendslope

[next-queue PATCH 1/3] net/sched: Introduce the user API for the CBS shaper

2017-09-26 Thread Vinicius Costa Gomes
Export the API necessary for configuring the CBS shaper (implemented in the next patch) via the tc tool. Signed-off-by: Vinicius Costa Gomes --- include/uapi/linux/pkt_sched.h | 17 + 1 file changed, 17 insertions(+) diff --git a/include/uapi/linux/pkt_sched.h b/include/uapi/lin

[next-queue PATCH 0/3] TSN: Add qdisc based config interface for CBS

2017-09-26 Thread Vinicius Costa Gomes
Hi, Changes from the RFC: - Fixed comments from Henrik Austad; - Simplified the Qdisc, using the generic implementation of callbacks where possible; - Small refactor on the driver (igb) code; This patchset is a proposal of how the Traffic Control subsystem can be used to offload the configu

[iproute2 net-next 1/3] update headers with CBS API

2017-09-26 Thread Vinicius Costa Gomes
Signed-off-by: Vinicius Costa Gomes --- include/linux/pkt_sched.h | 17 + 1 file changed, 17 insertions(+) diff --git a/include/linux/pkt_sched.h b/include/linux/pkt_sched.h index 099bf552..27c849c0 100644 --- a/include/linux/pkt_sched.h +++ b/include/linux/pkt_sched.h @@ -871,4

[iproute2 net-next 3/3] man: Add initial manpage for tc-cbs(8)

2017-09-26 Thread Vinicius Costa Gomes
Signed-off-by: Vinicius Costa Gomes --- man/man8/tc-cbs.8 | 100 ++ 1 file changed, 100 insertions(+) create mode 100644 man/man8/tc-cbs.8 diff --git a/man/man8/tc-cbs.8 b/man/man8/tc-cbs.8 new file mode 100644 index ..e84c5495 --- /de

[next-queue PATCH 3/3] igb: Add support for CBS offload

2017-09-26 Thread Vinicius Costa Gomes
From: Andre Guedes This patch adds support for Credit-Based Shaper (CBS) qdisc offload from Traffic Control system. This support enable us to leverage the Forwarding and Queuing for Time-Sensitive Streams (FQTSS) features from Intel i210 Ethernet Controller. FQTSS is the former 802.1Qav standard

[next-queue PATCH 2/3] net/sched: Introduce Credit Based Shaper (CBS) qdisc

2017-09-26 Thread Vinicius Costa Gomes
This queueing discipline implements the shaper algorithm defined by the 802.1Q-2014 Section 8.6.8.2 and detailed in Annex L. It's primary usage is to apply some bandwidth reservation to user defined traffic classes, which are mapped to different queues via the mqprio qdisc. Initially, it only sup

Re: [PATCH net-next 0/2] tools: add bpftool

2017-09-26 Thread David Ahern
On 9/26/17 9:35 AM, Jakub Kicinski wrote: > I'm looking for a home for bpftool, Daniel suggested that > tools/net could be a good place, since there are only BPF > utilities there already. > > The tool should be complete for simple use cases and we > will continue extending it as we go along. E.

Re: [PATCH net-next 2/2] tools: bpf: add bpftool

2017-09-26 Thread Jakub Kicinski
On Tue, 26 Sep 2017 15:24:06 -0700, Alexei Starovoitov wrote: > On Tue, Sep 26, 2017 at 08:35:22AM -0700, Jakub Kicinski wrote: > > Add a simple tool for querying and updating BPF objects on the system. > > > > Signed-off-by: Jakub Kicinski > > Reviewed-by: Simon Horman > > --- > > tools/bpf/Ma

Re: [PATCH v2 net-next 1/2] bpf/verifier: improve disassembly of BPF_END instructions

2017-09-26 Thread Daniel Borkmann
On 09/26/2017 05:35 PM, Edward Cree wrote: print_bpf_insn() was treating all BPF_ALU[64] the same, but BPF_END has a different structure: it has a size in insn->imm (even if it's BPF_X) and uses the BPF_SRC (X or K) to indicate which endianness to use. So it needs different code to print i

Re: [PATCH v2 net-next 2/2] bpf/verifier: improve disassembly of BPF_NEG instructions

2017-09-26 Thread Daniel Borkmann
On 09/26/2017 05:35 PM, Edward Cree wrote: BPF_NEG takes only one operand, unlike the bulk of BPF_ALU[64] which are compound-assignments. So give it its own format in print_bpf_insn(). Signed-off-by: Edward Cree Acked-by: Daniel Borkmann

Re: [PATCH 6/6] net: dsa: mv88e6xxx: Forward broadcast frames to cpu and dsa ports

2017-09-26 Thread Andrew Lunn
Ah, twice patch 6. Not good. I will wait for a few days for comments, and then repost without the duplication. Andrew

Re: WARNING: kernel stack frame pointer at ffff880156a5fea0 in bash:2103 has bad value 00007ffec7d87e50

2017-09-26 Thread Josh Poimboeuf
On Tue, Sep 26, 2017 at 11:51:31PM +0200, Richard Weinberger wrote: > Alexei, > > CC'ing Josh and Ingo. > > Am Dienstag, 26. September 2017, 06:09:02 CEST schrieb Alexei Starovoitov: > > On Mon, Sep 25, 2017 at 11:23:31PM +0200, Richard Weinberger wrote: > > > Hi! > > > > > > While playing with

Re: [PATCH v2 net-next 2/2] bpf/verifier: improve disassembly of BPF_NEG instructions

2017-09-26 Thread Alexei Starovoitov
On Tue, Sep 26, 2017 at 04:35:29PM +0100, Edward Cree wrote: > BPF_NEG takes only one operand, unlike the bulk of BPF_ALU[64] which are > compound-assignments. So give it its own format in print_bpf_insn(). > > Signed-off-by: Edward Cree Acked-by: Alexei Starovoitov thank you for the cleanup

Re: [PATCH v2 net-next 1/2] bpf/verifier: improve disassembly of BPF_END instructions

2017-09-26 Thread Alexei Starovoitov
On Tue, Sep 26, 2017 at 04:35:13PM +0100, Edward Cree wrote: > print_bpf_insn() was treating all BPF_ALU[64] the same, but BPF_END has a > different structure: it has a size in insn->imm (even if it's BPF_X) and > uses the BPF_SRC (X or K) to indicate which endianness to use. So it > needs diff

[PATCH net-next 2/6] net: dsa: {e}dsa: set offload_fwd_mark on received packets

2017-09-26 Thread Andrew Lunn
The software bridge needs to know if a packet has already been bridged by hardware offload to ports in the same hardware offload, in order that it does not re-flood them, causing duplicates. This is particularly true for broadcast and multicast traffic which the host has requested. By setting offl

[PATCH 6/6] net: dsa: mv88e6xxx: Forward broadcast frames to cpu and dsa ports

2017-09-26 Thread Andrew Lunn
By default, the switch does not flood broadcast frames. Instead the broadcast address is unknown in the ATU, so the frame gets forwarded out the cpu port. The software bridge then floods it back to the individual switch ports which are members of the bridge. Add an ATU entry in the switch so that

[PATCH net-next 1/6] net: dsa: Fix SWITCHDEV_ATTR_ID_PORT_PARENT_ID

2017-09-26 Thread Andrew Lunn
SWITCHDEV_ATTR_ID_PORT_PARENT_ID is used by the software bridge when determining which ports to flood a packet out. If the packet originated from a switch, it assumes the switch has already flooded the packet out the switches ports, so the bridge should not flood the packet itself out switch ports.

[PATCH net-next 5/6] net: dsa: mv88e6xxx: Move mv88e6xxx_port_db_load_purge()

2017-09-26 Thread Andrew Lunn
This function is going to be needed by a soon to be added new function. Move it earlier so we can avoid a forward declaration. No code changes. Signed-off-by: Andrew Lunn --- drivers/net/dsa/mv88e6xxx/chip.c | 88 1 file changed, 44 insertions(+), 44 dele

[PATCH net-next 6/6] net: dsa: mv88e6xxx: Flood broadcast frames in hardware

2017-09-26 Thread Andrew Lunn
By default, the switch does not flood broadcast frames. Instead the broadcast address is unknown in the ATU, so the frame gets forwarded out the cpu port. The software bridge then floods it back to the individual switch ports which are members of the bridge. Add an ATU entry in the switch so that

  1   2   3   >