Re: [PATCH] mac80211: aead api to reduce redundancy

Hi Johannes, Thanks for your time on reviewing this. I will make changes following your review. See details below. By the way, I'm still struggling on how to run unit tests. It might take time for me to make it run on my machine. 2017-10-02 8:04 GMT-04:00 Johannes Berg

Re: [patch net-next 1/6] net: bridge: Use the MDB_RTR_TYPE_TEMP on bridge device too

On 10/05/2017 03:09 PM, Nikolay Aleksandrov wrote: > On 05/10/17 13:36, Jiri Pirko wrote: >> From: Yotam Gigi >> >> Every bridge port is in one of four mcast router port states: >> - MDB_RTR_TYPE_PERM - the port is set by the user to be an mrouter port >>regardless of

[PATCH net-next 1/6] ipv6: prepare RCU lookups for idev->addr_list

inet6_ifa_finish_destroy() already uses kfree_rcu() to free inet6_ifaddr structs. We need to use proper list additions/deletions in order to allow readers to use RCU instead of idev->lock rwlock. Signed-off-by: Eric Dumazet --- net/ipv6/addrconf.c | 21

[PATCH net-next 4/6] ipv6: ipv6_chk_prefix() rcu conversion

Signed-off-by: Eric Dumazet --- net/ipv6/addrconf.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c index 33ee84c2512b50e316a0a6ed38a604a382ce5319..ea63442209bf268f1a19b5e014cb8c7e34fd40b4 100644 ---

[PATCH net-next 6/6] ipv6: avoid cache line dirtying in ipv6_dev_get_saddr()

By extending the rcu section a bit, we can avoid these very expensive in6_ifa_put()/in6_ifa_hold() calls done in __ipv6_dev_get_saddr() and ipv6_dev_get_saddr() Signed-off-by: Eric Dumazet --- net/ipv6/addrconf.c | 17 ++--- 1 file changed, 6 insertions(+), 11

[PATCH net-next 3/6] ipv6: ipv6_chk_custom_prefix() rcu conversion

Signed-off-by: Eric Dumazet --- net/ipv6/addrconf.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c index 2e029c8be1f2e2746e804a47bb5a3eb632adaa5d..33ee84c2512b50e316a0a6ed38a604a382ce5319 100644 ---

[PATCH net-next 5/6] ipv6: __ipv6_dev_get_saddr() rcu conversion

Callers hold rcu_read_lock(), so we do not need the rcu_read_lock()/rcu_read_unlock() pair. Signed-off-by: Eric Dumazet --- net/ipv6/addrconf.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c index

[PATCH net-next 2/6] ipv6: ipv6_count_addresses() rcu conversion

Signed-off-by: Eric Dumazet --- net/ipv6/addrconf.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c index d1ff0955b709eaa6b5d94bd8d740334eb1eed6d7..2e029c8be1f2e2746e804a47bb5a3eb632adaa5d 100644

[PATCH net-next 0/6] ipv6: ipv6_dev_get_saddr() rcu works

Sending IPv6 udp packets on non connected sockets is quite slow, because ipv6_dev_get_saddr() is still using an rwlock and silly references games on ifa. Tested: $ ./super_netperf 16 -H ::555:0786 -l 2000 -t UDP_STREAM -- -m 100 & [1] 12527 Performance is boosted from 2.02 Mpps to 4.28 Mpps

Re: [PATCH net-next 0/3] bpf: Misc improvements and a new usage on bpf obj name

From: Martin KaFai Lau Date: Thu, 5 Oct 2017 21:52:10 -0700 > The first two patches make improvements on the bpf obj name. > > The last patch adds the prog name to kallsyms. Series applied, thanks Martin.

Re: [PATCH net] bpf: fix liveness marking

From: Alexei Starovoitov Date: Thu, 5 Oct 2017 16:20:56 -0700 > while processing Rx = Ry instruction the verifier does > regs[insn->dst_reg] = regs[insn->src_reg] > which often clears write mark (when Ry doesn't have it) > that was just set by check_reg_arg(Rx) prior to the

Re: [patch net-next 0/2] mlxsw: Add more extack error reporting

From: Jiri Pirko Date: Thu, 5 Oct 2017 23:39:58 +0200 > From: Jiri Pirko > > Ido says: > > Add error messages to VLAN and bridge enslavements to help users > understand why the enslavement failed. For some reason patch #2 didn't make it to the list and

Re: [PATCH net-next 1/1] [net] bonding: Add NUMA notice

From: Patrick Talbert Date: Thu, 5 Oct 2017 16:23:45 -0400 > Network performance can suffer when a load balancing bond uses slave > interfaces which are in different NUMA domains. > > This compares the NUMA domain of a newly enslaved interface against any > existing

Re: [PATCH] doc: Fix typo "8023.ad" in bonding documentation

From: Axel Beckert Date: Thu, 5 Oct 2017 22:00:33 +0200 > Should be "802.3ad" like everywhere else in the document. > > Signed-off-by: Axel Beckert Applied.

[PATCH] net: make ->ndo_get_phys_port_name accept 32-bit len

Buffer length passed into this hook is always IFNAMSIZ which is 16. Code savings on x86_64: add/remove: 0/0 grow/shrink: 1/9 up/down: 2/-45 (-43) function old new delta rocker_cmd_get_port_settings_phys_name_proc 179 181

Re: [net-next,v2] ip_gre: check packet length and mtu correctly in erspan tx

From: William Tu Date: Thu, 5 Oct 2017 12:07:12 -0700 > Similarly to early patch for erspan_xmit(), the ARPHDR_ETHER device > is the length of the whole ether packet. So skb->len should subtract > the dev->hard_header_len. > > Fixes: 1a66a836da63 ("gre: add collect_md mode

Re: [PATCH v3 2/2] net: phonet: mark phonet_protocol as const

From: Lin Zhang Date: Fri, 6 Oct 2017 01:40:35 +0800 > The phonet_protocol structs don't need to be written by anyone and > so can be marked as const. > > Signed-off-by: Lin Zhang Applied.

Re: [PATCH v3 1/2] net: phonet: mark header_ops as const

From: Lin Zhang Date: Fri, 6 Oct 2017 01:37:29 +0800 > Signed-off-by: Lin Zhang Applied.

Re: [PATCH] ipv6: fix net.ipv6.conf.all.accept_dad behaviour for real

From: Matteo Croce Date: Thu, 5 Oct 2017 19:03:05 +0200 > Commit 35e015e1f577 ("ipv6: fix net.ipv6.conf.all interface DAD handlers") > was intended to affect accept_dad flag handling in such a way that > DAD operation and mode on a given interface would be selected >

Re: [PATCH net-next v7 0/5] bpf: add two helpers to read perf event enabled/running time

From: Yonghong Song Date: Thu, 5 Oct 2017 09:19:18 -0700 > Hardware pmu counters are limited resources. When there are more > pmu based perf events opened than available counters, kernel will > multiplex these events so each event gets certain percentage > (but not 100%) of the pmu

Re: [patch net-next 0/6] mlxsw: Offload bridge device mrouter

From: Jiri Pirko Date: Thu, 5 Oct 2017 12:36:36 +0200 > From: Jiri Pirko > > Yotam says: > > Similarly to a bridged port, the bridge device itself can be configured by > the user to be an mrouter port. In this case, all multicast traffic should > be

Re: [PATCH v6 1/1] ip_tunnel: add mpls over gre support

From: Amine Kherbouche Date: Wed, 4 Oct 2017 19:35:57 +0200 > This commit introduces the MPLSoGRE support (RFC 4023), using ip tunnel > API by simply adding ipgre_tunnel_encap_(add|del)_mpls_ops() and the new > tunnel type TUNNEL_ENCAP_MPLS. > > Signed-off-by: Amine

Re: [PATCH net-next 00/16] ipv6: replace rwlock with rcu and spinlock in fib6 table

From: 吉藤英明 Date: Sat, 7 Oct 2017 18:25:13 +0900 > Hi, > > 2017-10-07 8:49 GMT+09:00 Eric Dumazet : >> On Fri, 2017-10-06 at 12:05 -0700, Wei Wang wrote: >>> From: Wei Wang >>> >>> Currently, fib6 table is protected

Re: [PATCH 3/3] batman-adv: Add missing kerneldoc for extack

From: Sven Eckelmann Date: Sat, 7 Oct 2017 14:21:22 +0200 > The parameter extack was added to batadv_softif_slave_add without adding > the kernel-doc for it. This caused kernel-doc warnings. > > Signed-off-by: Sven Eckelmann > Cc: David Ahern

Re: Fw: [Bug 197099] New: Kernel panic in interrupt [l2tp_ppp]

On 2017-10-07 15:09, SviMik wrote: Unfortunately, netconsole has managed to send a kernel panic trace only once, and it's not related to this bug. Looks like something crashes really hard to make netconsole unusable. In some cases i had luck with pstore, when netconsole failed me (especially

Re: [PATCH 3/3] batman-adv: Add missing kerneldoc for extack

On 10/7/17 6:21 AM, Sven Eckelmann wrote: > The parameter extack was added to batadv_softif_slave_add without adding > the kernel-doc for it. This caused kernel-doc warnings. > > Signed-off-by: Sven Eckelmann > Cc: David Ahern > --- >

[net 1/1] tipc: Unclone message at secondary destination lookup

When a bundling message is received, the function tipc_link_input() calls function tipc_msg_extract() to unbundle all inner messages of the bundling message before adding them to input queue. The function tipc_msg_extract() just clones all inner skb for all inner messagges from the bundling skb.

Re: [PATCH v3 1/2] dt-bindings: add device tree binding for Allwinner XR819 SDIO Wi-Fi

在 2017-10-05 14:58，Kalle Valo 写道： Icenowy Zheng writes: 于 2017年10月4日 GMT+08:00 下午6:11:45, Maxime Ripard 写到: On Wed, Oct 04, 2017 at 10:02:48AM +, Arend van Spriel wrote: On 10/4/2017 11:03 AM, Icenowy Zheng wrote: > > > 于 2017年10月4日

[net 1/1] tipc: correct initialization of skb list

We change the initialization of the skb transmit buffer queues in the functions tipc_bcast_xmit() and tipc_rcast_xmit() to also initialize their spinlocks. This is needed because we may, during error conditions, need to call skb_queue_purge() on those queues further down the stack. Signed-off-by:

Re: [PATCH v3 1/2] dt-bindings: add device tree binding for Allwinner XR819 SDIO Wi-Fi

于 2017年10月5日 GMT+08:00 下午2:58:01, Kalle Valo 写到: >Icenowy Zheng writes: > >> 于 2017年10月4日 GMT+08:00 下午6:11:45, Maxime Ripard >> 写到: >>>On Wed, Oct 04, 2017 at 10:02:48AM +, Arend van Spriel wrote: On 10/4/2017

[PATCH 3/3] batman-adv: Add missing kerneldoc for extack

The parameter extack was added to batadv_softif_slave_add without adding the kernel-doc for it. This caused kernel-doc warnings. Signed-off-by: Sven Eckelmann Cc: David Ahern --- net/batman-adv/soft-interface.c | 1 + 1 file changed, 1 insertion(+) diff

Re: Fw: [Bug 197099] New: Kernel panic in interrupt [l2tp_ppp]

2017-10-06 12:52 GMT+03:00 James Chapman : > On 6 October 2017 at 05:45, SviMik wrote: >> 2017-10-04 10:49 GMT+03:00 James Chapman : >>> On 3 October 2017 at 08:27, James Chapman wrote: For capturing

Re: [PATCH net-next 00/16] ipv6: replace rwlock with rcu and spinlock in fib6 table

Hi, 2017-10-07 8:49 GMT+09:00 Eric Dumazet : > On Fri, 2017-10-06 at 12:05 -0700, Wei Wang wrote: >> From: Wei Wang >> >> Currently, fib6 table is protected by rwlock. During route lookup, >> reader lock is taken and during route insertion, deletion or

Re: [PATCH v8 01/20] crypto: change transient busy return code to -EAGAIN

On Sat, Oct 7, 2017 at 6:05 AM, Herbert Xu wrote: > On Tue, Sep 05, 2017 at 03:38:40PM +0300, Gilad Ben-Yossef wrote: >> >> diff --git a/crypto/algif_hash.c b/crypto/algif_hash.c >> index 5e92bd2..3b3c154 100644 >> --- a/crypto/algif_hash.c >> +++

Re: [PATCH net] net: fib_rules: Fix fib_rules_ops->compare implementations to support exact match

Hi David, On Tue, 03 Oct 2017 14:54:18 -0700 (PDT) David Miller wrote: > From: Shmulik Ladkani > Date: Sat, 30 Sep 2017 11:59:09 +0300 > > > This leads to inconsistencies, depending on order of operations, e.g.: > > I don't see any inconsistency.