On 10/16/2017 02:20 PM, Nicolas Dichtel wrote:
> Le 16/10/2017 à 03:17, David Ahern a écrit :
>> [ cc'ed Nicolas ]
>>
>> On 10/15/17 4:13 AM, Xin Long wrote:
>>> The check 'status & DO_SETLINK_NOTIFY' in do_setlink doesn't really
>>> work after status & DO_SETLINK_MODIFIED, as:
>>>
>>> DO_SETLINK
On Thu, Oct 26, 2017 at 08:26:16AM +0200, Jiri Pirko wrote:
> Thu, Oct 26, 2017 at 07:08:05AM CEST, dsah...@gmail.com wrote:
> >Adding a FIB rule on a spectrum platform silently aborts FIB offload:
> >$ ip ru add pref 99 from all to 192.168.1.1 table 10
> >$ dmesg -c
> >[ 623.144736] m
Hi David,
On Wed, Oct 25, 2017 at 10:08:05PM -0700, David Ahern wrote:
> Adding a FIB rule on a spectrum platform silently aborts FIB offload:
> $ ip ru add pref 99 from all to 192.168.1.1 table 10
> $ dmesg -c
> [ 623.144736] mlxsw_spectrum :03:00.0: FIB abort triggered. Note
>
On Wed, Oct 25, 2017 at 07:38:35PM -0500, Gustavo A. R. Silva wrote:
>
> I don't think we want something like:
>
> bool err;
>
> err = build_spdinfo(r_skb, net, sportid, seq, *flags) < 0 ? true : false;
> BUG_ON(err);
How about
int err;
err = build_spdinfo(r_skb, net, sportid,
Thu, Oct 26, 2017 at 07:08:05AM CEST, dsah...@gmail.com wrote:
>Adding a FIB rule on a spectrum platform silently aborts FIB offload:
>$ ip ru add pref 99 from all to 192.168.1.1 table 10
>$ dmesg -c
>[ 623.144736] mlxsw_spectrum :03:00.0: FIB abort triggered. Note that
> FIB entr
Thu, Oct 26, 2017 at 07:36:41AM CEST, felix.manlu...@cavium.com wrote:
>From: Vijaya Mohan Guvva
>
>patch1 of this patch set adds switchdev support for SRIOV capable
>LiquidIO NIC, so that for every SRIOV VF on LiquidIO, a representor
>netdev is created on hyperviser. It also has changes to send r
On Wed, Oct 25, 2017 at 01:09:44PM +, Aviv Heller wrote:
> -Original message-
> > From: Steffen Klassert
> > Sent: Wednesday, October 25 2017, 10:22 am
> > To: av...@mellanox.com
> > Cc: Herbert Xu; Boris Pismenny; Yossi Kuperman; Yevgeny Kliteynik;
> > netdev@vger.kernel.org
> > Subje
Thu, Oct 26, 2017 at 03:01:31AM CEST, da...@davemloft.net wrote:
>From: Jiri Pirko
>Date: Wed, 25 Oct 2017 16:34:58 +0200
>
>> From: Jiri Pirko
>>
>> This restores the original behaviour before the block callbacks were
>> introduced. Allow the drivers to do binding of block always, no matter
>>
On 2017年10月25日 15:23, Girish Moodalbail wrote:
Double free of skb_array in tap module is causing kernel panic. When
tap_set_queue() fails we free skb_array right away by calling
skb_array_cleanup(). However, later on skb_array_cleanup() is called
again by tap_sock_destruct through sock_put(). T
On 2017年10月26日 03:01, Eric Dumazet wrote:
On Wed, Oct 25, 2017 at 11:49 AM, Willem de Bruijn
wrote:
From skb->dev and netdev_priv, the tun device has flags 0x1002 ==
IFF_TAP | IFF_NO_PI. This kernel precedes the recent support for
IFF_NAPI and IFF_NAPI_FRAGS. The allocation most likely happ
From: Vijaya Mohan Guvva
Enable switchdev for SRIOV capable LiquidIO NIC. It registers
a representor netdev (with switchdev_ops) for each SRIOV VF created.
It also has changes to send representor interface configurations like
admin state and MTU to LiquidIO firmware and to retrieve HW counted
VF
From: Vijaya Mohan Guvva
Enable and disable switchdev on SRIOV capable LiquidIO NIC with devlink.
Create representor netdev for each SRIOV VF function on SRIOV enable and
and do the cleanup on SRIOV disable.
Signed-off-by: Vijaya Mohan Guvva
Signed-off-by: Satanand Burla
Signed-off-by: Raghu V
From: Vijaya Mohan Guvva
Added ethtool support for vf representor ports to return port stats and
driver info.
Signed-off-by: Vijaya Mohan Guvva
Signed-off-by: Satanand Burla
Signed-off-by: Raghu Vatsavayi
Signed-off-by: Felix Manlunas
---
drivers/net/ethernet/cavium/liquidio/lio_vf_rep.c |
On Wed, Oct 25, 2017 at 7:07 PM, Alexei Starovoitov
wrote:
>
> On Thu, Sep 28, 2017 at 04:36:58PM -0700, Yuchung Cheng wrote:
> > On Thu, Sep 28, 2017 at 1:14 AM, Oleksandr Natalenko
> > wrote:
> > > Hi.
> > >
> > > Won't tell about panic in tcp_sacktag_walk() since I cannot trigger it
> > > inte
From: Vijaya Mohan Guvva
patch1 of this patch set adds switchdev support for SRIOV capable
LiquidIO NIC, so that for every SRIOV VF on LiquidIO, a representor
netdev is created on hyperviser. It also has changes to send representor
interface configurations like admin state and MTU to LiquidIO fir
There are many cases where networking subsystems throw non-fatal warning
messages that end up in dmesg / kernel log to which a user making the
change is completely oblivious. This set makes the extack facility
usable for returning such messages. The case in point here is spectrum
and adding FIB rul
Add extack to fib_notifier_info and plumb through stack to
call_fib_rule_notifiers, call_fib_entry_notifiers and
call_fib6_entry_notifiers. This allows notifer handlers to
return messages to user.
Signed-off-by: David Ahern
---
include/net/fib_notifier.h | 1 +
net/core/fib_rules.c | 9 +
The NLMSGERR API already carries data (eg, a cookie) on the success path.
Allow a message string to be returned as well.
Signed-off-by: David Ahern
---
net/netlink/af_netlink.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/net/netlink/af_netlink.c b/net/n
Adding a FIB rule on a spectrum platform silently aborts FIB offload:
$ ip ru add pref 99 from all to 192.168.1.1 table 10
$ dmesg -c
[ 623.144736] mlxsw_spectrum :03:00.0: FIB abort triggered. Note that
FIB entries are no longer being offloaded to this device.
This patch reworks
On Wed, Oct 25, 2017 at 5:19 PM, Paul E. McKenney
wrote:
> On Wed, Oct 25, 2017 at 03:37:40PM -0700, Cong Wang wrote:
>> My solution is introducing a workqueue for tc filters
>> and let each RCU callback defer the work to this
>> workqueue. I solve the flush_workqueue() deadlock
>> by queuing anot
On 10/25, Ye Xiaolong wrote:
>On 10/25, Michael S. Tsirkin wrote:
>>On Thu, Oct 26, 2017 at 12:53:23AM +0800, kernel test robot wrote:
>>> FYI, we noticed the following commit (built with gcc-6):
>>>
>>> commit: 3ea693a925e14c1fc54c7d8bebe6f9fd9441b47d ("bpf: introduce new bpf
>>> cpu map type BP
Thanks, David.
VM1:
sudo ip addr add 192.168.200.1/24 dev enp0s8 broadcast 192.168.200.255
sudo ip link set enp0s8 up
sudo ip route add 192.168.210.0/24 nexthop via 192.168.200.3 dev enp0s8
sudo ip tunnel add jtun mode sit remote 192.168.210.2 local 192.168.200.1
sudo ip -6 addr add 2001::1/64 dev
Hi Song,
[auto build test WARNING on net-next/master]
url:
https://github.com/0day-ci/linux/commits/Song-Liu/tcp-add-tracepoint-trace_tcp_retransmit_synack/20171026-010651
reproduce:
# apt-get install sparse
make ARCH=x86_64 allmodconfig
make C=1 CF=-D__CHECK_ENDIAN__
On 10/25/17 7:41 PM, Hangbin Liu wrote:
> +static int rtnl_recvmsg(int fd, struct msghdr *msg, char **answer)
> +{
> + struct iovec *iov = msg->msg_iov;
> + char *buf;
> + int len;
> +
> + iov->iov_base = NULL;
> + iov->iov_len = 0;
> +
> + len = __rtnl_recvmsg(fd, msg, MSG_
On Thu, Sep 28, 2017 at 04:36:58PM -0700, Yuchung Cheng wrote:
> On Thu, Sep 28, 2017 at 1:14 AM, Oleksandr Natalenko
> wrote:
> > Hi.
> >
> > Won't tell about panic in tcp_sacktag_walk() since I cannot trigger it
> > intentionally, but setting net.ipv4.tcp_retrans_collapse to 0 *does not* fix
> >
On 10/25, Michael S. Tsirkin wrote:
>On Thu, Oct 26, 2017 at 12:53:23AM +0800, kernel test robot wrote:
>> FYI, we noticed the following commit (built with gcc-6):
>>
>> commit: 3ea693a925e14c1fc54c7d8bebe6f9fd9441b47d ("bpf: introduce new bpf
>> cpu map type BPF_MAP_TYPE_CPUMAP")
>> url:
>> htt
commit afdb09c720b6 ("security: bpf: Add LSM hooks for bpf object related
syscall") included linux/bpf.h in linux/security.h. As a result, bpf
programs including bpf_helpers.h and some other header that ends up
pulling in also security.h, such as several examples under samples/bpf,
fail to compile
On Tue, Oct 24, 2017 at 08:11:28PM -0700, Jakub Kicinski wrote:
> From: Quentin Monnet
>
> One possible cause of failure for `bpftool {prog|map} pin * file FILE`
> is the FILE not being in an eBPF virtual file system (bpffs). In this
> case, make bpftool attempt to mount bpffs on the parent direc
With commit 72b365e8e0fd ("libnetlink: Double the dump buffer size") and
460c03f3f3cc ("iplink: double the buffer size also in iplink_get()"), we
extend the buffer size to avoid truncated message with large numbers of
VFs. But just as Michal said, this is not future-proof since the NIC
number is in
With commit 72b365e8e0fd ("libnetlink: Double the dump buffer size")
we doubled the buffer size to support more VFs. But the VFs number is
increasing all the time. Some customers even use more than 200 VFs now.
We could not double it everytime when the buffer is not enough. Let's just
not hard cod
This is an update for 460c03f3f3cc ("iplink: double the buffer size also in
iplink_get()"). After update, we will not need to double the buffer size
every time when VFs number increased.
With call like rtnl_talk(&rth, &req.n, NULL, 0), we can simply remove the
length parameter.
With call like rtn
Florian Fainelli writes:
> Remove the code that tried to identify if a PHY designated by Device
> Tree required diversion through the DSA-created MDIO bus. This was
> created mainly for the bcm_sf2.c driver back when it did not have its
> own MDIO bus driver, which it now has since 461cd1b03e32 (
From: Doug Berger
Date: Wed, 25 Oct 2017 15:04:10 -0700
> This commit set is the result of an investigation into an issue that
> occurred when bringing the interface up and down repeatedly with an
> external 100BASE-T PHY. In some cases the MAC would experience mass
> receive packet duplication t
From: Nikolay Aleksandrov
Date: Thu, 26 Oct 2017 01:14:19 +0300
> On 26/10/17 00:59, Nikolay Aleksandrov wrote:
> ...
>>
>> v3: rebased to latest net-next and fixed non-vlan config functions reported
>> by kbuild test bot
>
> And obviously fixed them wrong, grr... sorry about the noise agai
From: Julien Gomes
Date: Wed, 25 Oct 2017 11:50:50 -0700
> If the name argument of dev_get_valid_name() contains "%d", it will try
> to assign it a unit number in __dev__alloc_name() and return either the
> unit number (>= 0) or an error code (< 0).
> Considering positive values as error values p
From: Girish Moodalbail
Date: Wed, 25 Oct 2017 12:26:43 -0700
> commit 635b8c8ecdd2 ("tap: Renaming tap related APIs, data structures,
> macros") captured all the tap related fields into a new struct tap_dev.
> However, it failed to remove those fields from struct macvlan_dev.
> Those fields are
From: Julien Gomes
Date: Wed, 25 Oct 2017 11:50:50 -0700
> If the name argument of dev_get_valid_name() contains "%d", it will try
> to assign it a unit number in __dev__alloc_name() and return either the
> unit number (>= 0) or an error code (< 0).
> Considering positive values as error values p
From: Jakub Kicinski
Date: Wed, 25 Oct 2017 11:47:05 -0700
> From: Pieter Jansen van Vuuren
>
> Previously we did not ensure that a netdev is a representative netdev
> before dereferencing its private data. This can occur when an upper netdev
> is created on a representative netdev. This patch
From: Andrei Vagin
Date: Wed, 25 Oct 2017 10:16:42 -0700
> socket_diag shows information only about sockets from a namespace where
> a diag socket lives.
>
> But if we request information about one unix socket, the kernel don't
> check that its netns is matched with a diag socket namespace, so a
Deprecate the 1-bit flag (bit 2 in the SLI_SCRATCH_1 Octeon register) that
indicates that the liquidio watchdog kernel thread is running for this NIC.
Reason is: it is incompatible with the firmware's use for SLI_SCRATCH_1.
In lieu of checking that now-deprecated flag, check the value of
oct_dev-
From: "Steven J. Hill"
Date: Wed, 25 Oct 2017 11:44:32 -0500
> Signed-off-by: Steven J. Hill
> Signed-off-by: David Daney
Applied to net-next, thanks.
Quoting "Gustavo A. R. Silva" :
Hi all,
Quoting Steffen Klassert :
On Wed, Oct 25, 2017 at 01:22:22PM +0900, David Miller wrote:
From: Herbert Xu
Date: Wed, 25 Oct 2017 12:05:41 +0800
On Tue, Oct 24, 2017 at 05:48:42PM +0900, David Miller wrote:
This discussion has happened before.
Bu
From: Jiri Pirko
Date: Wed, 25 Oct 2017 16:34:58 +0200
> From: Jiri Pirko
>
> This restores the original behaviour before the block callbacks were
> introduced. Allow the drivers to do binding of block always, no matter
> if the NETIF_F_HW_TC feature is on or off. Move the check to the block
>
Check that the master network device that is signaled through the DSA
notifier is actually going to be ourself, otherwise, we could just be
de-referencing garbage from other drivers.
Fixes: 84ff33eeb23d ("net: systemport: Establish DSA network device queue
mapping")
Signed-off-by: Florian Fainell
From: Jon Maloy
Date: Wed, 25 Oct 2017 16:19:52 +0200
> The following warning was reported by syzbot on Oct 24. 2017:
> KASAN: slab-out-of-bounds Read in tipc_nametbl_lookup_dst_nodes
>
> This is a harmless bug, but we still want to get rid of the warning,
> so we swap the two conditions in ques
On Wed, Oct 25, 2017 at 9:49 PM, Nanjappa, Gangadhar
wrote:
> Using linux kernel – 4.4.45 (Blurry Fish Butt), VPN test fails. If I revert
> the attached five patches, VPN test passes.
> [...]
>
> 1. 1-net-core-add-UID-to-flows-rules-and-routes.patch
Those patches don't exist in 4.4, they we
Remove the code that tried to identify if a PHY designated by Device
Tree required diversion through the DSA-created MDIO bus. This was
created mainly for the bcm_sf2.c driver back when it did not have its
own MDIO bus driver, which it now has since 461cd1b03e32 ("net: dsa:
bcm_sf2: Register our sl
may I also suggest being able to specify the offload parameters in the format in
which "ethtool -k " prints them? The user can only guess which -K
parameters correspond to the -k parameters.
On 09/08/2015 04:52 AM, roopa wrote:
> On 9/5/15, 2:53 AM, Ben Hutchings wrote:
>> On Thu, 2015-06-25 at 0
Hi Aviv,
[auto build test WARNING on ipsec-next/master]
[also build test WARNING on v4.14-rc6 next-20171018]
[cannot apply to net-next/master]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/aviv
From: Eric Dumazet
Date: Wed, 25 Oct 2017 07:55:17 -0700
> You might squash this patch with the following one ;)
Indeed.
The whole bit of changing dst->child is a bit tricky because of
the generic layer need to access it just for the dst destroy
case.
I'll think a bit more about how to transfo
On Wed, Oct 25, 2017 at 03:37:40PM -0700, Cong Wang wrote:
> On Tue, Oct 24, 2017 at 6:43 PM, David Miller wrote:
> > From: Cong Wang
> > Date: Mon, 23 Oct 2017 15:02:49 -0700
> >
> >> Recently, the RCU callbacks used in TC filters and TC actions keep
> >> drawing my attention, they introduce at
From: Shannon Nelson
Date: Wed, 25 Oct 2017 08:56:06 -0700
> On Wed, Oct 25, 2017 at 7:03 AM, David Miller wrote:
>>
>>
>> diff --git a/include/net/xfrm.h b/include/net/xfrm.h
>> index f002a2c5e33c..4fa951112873 100644
>> --- a/include/net/xfrm.h
>> +++ b/include/net/xfrm.h
>> @@ -994,6 +994,15
While debugging a crash reported by David Daney, we discovered that the
offending driver was calling phy_disconnect() without a prior call to
phy_stop() although it should have.
Add a WARN_ON() to catch such drivers, in order to invite their
maintainers to fix them, and also force the PHY state ma
Commit 2aa70f864955 ("net: smsc911x: Quieten netif during suspend")
addressed the network device parts of the suspend/resume process, but
this is not enough, we can also need to manage the PHY state machine
during suspend.
Because Geert indicated that we are going to cut the power to the block,
we
phy_stop_machine() is publicly exported in include/linux/phy.y, and is
not made static because it's also used by phy_device.c. Since
phy_start_machine() is already exported, do this here too. This is a
function that provides hard guarantees that the state machine is
properly stopped past that synch
Marc reported that he was not getting the PHY library adjust_link()
callback function to run when calling phy_stop() + phy_disconnect()
which does not indeed happen because we set the state machine to
PHY_HALTED but we don't get to run it to process this state past that
point.
Fix this with a sync
Hi all,
This patch series tries to address the shortcomings of the previously and then
quickly reverted commit 7ad813f208533cebfcc32d3d7474dc1677d1b09a ("net: phy:
Correctly process PHY_HALTED in phy_stop_machine()")
This time, the empire returns and strikes back with a few additional changes:
-
Before this patch we had cases that either sent notifications when there
were in fact no changes (e.g. non-existent vlan delete) or didn't send
notifications when there were changes (e.g. vlan add range with an error in
the middle, port flags change + vlan update error). This patch sends down
a boo
Before this patch there was no way to tell if the vlan add operation
actually changed anything, thus we would always generate a notification
on adds. Let's make the notifications more precise and generate them
only if anything changed, so use the new bool parameter to signal that the
vlan was updat
Hi,
Before this set the bridge would generate a notification on vlan add or del
even if they didn't actually do any changes, which confuses listeners and
is generally not preferred. We could also lose notifications on actual
changes if one adds a range of vlans and there's an error in the middle.
T
On Tue, Oct 24, 2017 at 6:43 PM, David Miller wrote:
> From: Cong Wang
> Date: Mon, 23 Oct 2017 15:02:49 -0700
>
>> Recently, the RCU callbacks used in TC filters and TC actions keep
>> drawing my attention, they introduce at least 4 race condition bugs:
>
> Like Eric, I think doing a full RCU sy
On 26/10/17 00:59, Nikolay Aleksandrov wrote:
...
>
> v3: rebased to latest net-next and fixed non-vlan config functions reported
> by kbuild test bot
And obviously fixed them wrong, grr... sorry about the noise again, I'll resend
v4
with the proper fix.
> v2: pass changed down to vlan add
On Wed, 25 Oct 2017 16:34:58 +0200, Jiri Pirko wrote:
> From: Jiri Pirko
>
> This restores the original behaviour before the block callbacks were
> introduced. Allow the drivers to do binding of block always, no matter
> if the NETIF_F_HW_TC feature is on or off. Move the check to the block
> cal
As noted in the net-next submission for GENETv5 support [1], there
were merge conflicts with an earlier net submission [2] that had not
yet found its way to the net-next repository.
Unfortunately, when the branches were merged the conflicts were not
correctly resolved. This commit attempts to cor
When bcmgenet_dma_teardown is called from bcmgenet_fini_dma it ends
up getting called twice from the bcmgenet_close and bcmgenet_suspend
functions (once directly and once inside the bcmgenet_fini_dma call).
This commit removes the call from bcmgenet_fini_dma and ensures that
bcmgenet_dma_teardown
Since the NAPI interrupts are basically ignored when NAPI is
disabled we don't need to mask them within the functions
bcmgenet_disable_tx_napi() and bcmgenet_disable_rx_napi().
So wait until all NAPI instances are disabled and mask all of the
bcmgenet driver interrupts together in bcmgenet_netif_st
It is necessary for the UniMAC to be clocked at least 5 cycles
while the sw_reset is asserted to ensure a clean reset.
It was discovered that this condition was not being met when
connected to an external RGMII PHY that disabled the Rx clock in
the Power Save state.
This commit modifies the reset
This commit consolidates more common functionality from
bcmgenet_close and bcmgenet_suspend into bcmgenet_netif_stop and
modifies the start and stop sequences to better suit the design
of the GENET hardware.
Signed-off-by: Doug Berger
---
drivers/net/ethernet/broadcom/genet/bcmgenet.c | 49 +
Since each ring has its own NAPI instance it might as well be
initialized along with the other ring context.
Signed-off-by: Doug Berger
---
drivers/net/ethernet/broadcom/genet/bcmgenet.c | 42 +-
1 file changed, 8 insertions(+), 34 deletions(-)
diff --git a/drivers/net/e
Now that the software reset of the PHY has been removed it is no
longer necessary to retain a private pointer to the phydev for
use when the PHY is detached (which isn't generally safe anyway).
The driver now uses the phydev member attached to the net_device.
For ethtool commands that have a PHY
Since the ring locks are not used in a hard IRQ context it is often
not necessary to disable global IRQs while waiting on a lock.
Using less restrictive lock and unlock calls improves the real-time
responsiveness of the system.
Signed-off-by: Doug Berger
---
drivers/net/ethernet/broadcom/genet/
With commit f7d72996e222 ("net: bcmgenet: enable loopback during
UniMAC sw_reset") it is no longer necessary to force the software
reset of the internal EPHY before resetting the UniMAC to ensure a
clean reset.
Therefore this commit reverts commit 5dbebbb44a6a ("net: bcmgenet:
Software reset EPHY
This commit set is the result of an investigation into an issue that
occurred when bringing the interface up and down repeatedly with an
external 100BASE-T PHY. In some cases the MAC would experience mass
receive packet duplication that could in rare cases lead to a stall
from overflow. The fix fo
Before this patch there was no way to tell if the vlan add operation
actually changed anything, thus we would always generate a notification
on adds. Let's make the notifications more precise and generate them
only if anything changed, so use the new bool parameter to signal that the
vlan was updat
Hi,
Before this set the bridge would generate a notification on vlan add or del
even if they didn't actually do any changes, which confuses listeners and
is generally not preferred. We could also lose notifications on actual
changes if one adds a range of vlans and there's an error in the middle.
T
Before this patch we had cases that either sent notifications when there
were in fact no changes (e.g. non-existent vlan delete) or didn't send
notifications when there were changes (e.g. vlan add range with an error in
the middle, port flags change + vlan update error). This patch sends down
a boo
Hi Yupeng,
On Wed, Oct 25, 2017 at 02:20:25PM -0700, peng yu wrote:
> Thanks for your suggestion, below is a new patch. What I did:
> 1. change all 'package' to 'packet'
> 2. put my additional text as second paragraphs of the original options.
> 3. checked the man page by aspell
> If anything else
On 21/10/2017 02:07 πμ, Fujinaka, Todd wrote:
> You picked a bunch of places to post this, and you really should've used a
> different place: e1000-de...@lists.sourceforge.net
>
Just subscribed to that ML and mailed about it.
> Also, since you flagged the "communities" post as "answered", you're
On 24/10/17 15:32, Nikolay Aleksandrov wrote:
> Hi,
> Before this set the bridge would generate a notification on vlan add or del
> even if they didn't actually do any changes, which confuses listeners and
> is generally not preferred. We could also lose notifications on actual
> changes if one add
On 10/25/17 2:45 PM, Jeff Barnhill wrote:
> Are v6/sit tunnels working with VRFs?
>
> For instance, I have a very simple configuration with three VMs
> running 4.13.0-16 (Ubuntu Server 17.10) kernels. VM3 is setup as a
> router for separation. VM1 and VM2 have static routes to each other
> via V
Thanks for your suggestion, below is a new patch. What I did:
1. change all 'package' to 'packet'
2. put my additional text as second paragraphs of the original options.
3. checked the man page by aspell
If anything else need to fix, please let me know.
commit 9803d27de31028733de789495d78ff7a3938
> On Oct 25, 2017, at 10:39, Dan Williams wrote:
>
> On Wed, 2017-10-25 at 17:12 +, Perez-Gonzalez, Inaky wrote:
>>> On Tue, 2017-10-24 at 21:00 +, Perez-Gonzalez, Inaky wrote:
> ping any comments on this?
None from me; I don't have access to this HW anymore, so I can't
>
On Tue, Oct 24, 2017 at 9:46 PM, Matthias Kaehlcke wrote:
> El Mon, Oct 09, 2017 at 12:41:53PM -0700 Matthias Kaehlcke ha dit:
>> + u8 cmd_payload[];
>> } __packed *buf;
>> struct i2400m_bootrom_header ack;
>
> ping
>
> any comments on this?
What for? The patch is clearly
Hi Nikolay,
[auto build test ERROR on net-next/master]
url:
https://github.com/0day-ci/linux/commits/Nikolay-Aleksandrov/bridge-make-setlink-dellink-notifications-more-accurate/20171026-042029
config: x86_64-randconfig-x019-201743 (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 2
On Mon, Oct 23, 2017 at 4:31 PM, Eric Dumazet wrote:
>
> I did not pretend to give a bug fix, I simply said your patch series was
> probably not the right way.
Generally I agree with you on avoid synchronize_rcu(), but this case
is very special, you need to consider case by case, not just talking
Are v6/sit tunnels working with VRFs?
For instance, I have a very simple configuration with three VMs
running 4.13.0-16 (Ubuntu Server 17.10) kernels. VM3 is setup as a
router for separation. VM1 and VM2 have static routes to each other
via VM3. All VMs have v4 interfaces configured. If I setu
On Wed, Oct 25, 2017 at 11:50 AM, Julien Gomes wrote:
> If the name argument of dev_get_valid_name() contains "%d", it will try
> to assign it a unit number in __dev__alloc_name() and return either the
> unit number (>= 0) or an error code (< 0).
> Considering positive values as error values preve
On 10/23/2017 09:57 AM, Wei Xu wrote:
> On Wed, Oct 18, 2017 at 04:17:51PM -0400, Matthew Rosato wrote:
>> On 10/12/2017 02:31 PM, Wei Xu wrote:
>>> On Thu, Oct 05, 2017 at 04:07:45PM -0400, Matthew Rosato wrote:
Ping... Jason, any other ideas or suggestions?
>>>
>>> Hi Matthew,
>>> Rece
On 10/22/2017 10:06 PM, Jason Wang wrote:
>
>
> On 2017年10月19日 04:17, Matthew Rosato wrote:
>>> 2. It might be useful to short the traffic path as a reference, What
>>> I am running
>>> is briefly like:
>>> pktgen(host kernel) -> tap(x) -> guest(DPDK testpmd)
>>>
>>> The bridge driver(br_for
commit 635b8c8ecdd2 ("tap: Renaming tap related APIs, data structures,
macros") captured all the tap related fields into a new struct tap_dev.
However, it failed to remove those fields from struct macvlan_dev.
Those fields are currently unused and must be removed. While there
I moved the comment fo
On 10/25/2017 07:04 AM, Jose Abreu wrote:
> This adds the documentation for TSN feature EST and FP.
>
> Signed-off-by: Jose Abreu
> Cc: David S. Miller
> Cc: Joao Pinto
> Cc: Giuseppe Cavallaro
> Cc: Alexandre Torgue
> Cc: Rob Herring
> ---
> Documentation/devicetree/bindings/net/stmmac.txt
On Wed, Oct 25, 2017 at 11:49 AM, Willem de Bruijn
wrote:
> From skb->dev and netdev_priv, the tun device has flags 0x1002 ==
> IFF_TAP | IFF_NO_PI. This kernel precedes the recent support for
> IFF_NAPI and IFF_NAPI_FRAGS. The allocation most likely happened
> in tun_build_skb from current->task
On Wed, Oct 25, 2017 at 06:37:16AM -0700, Eric Dumazet wrote:
> On Wed, 2017-10-25 at 00:17 -0700, Andrei Vagin wrote:
> > socket_diag shows information only about sockets from a namespace where
> > a diag socket lives.
> >
> > But if we request information about one unix socket, the kernel don't
If the name argument of dev_get_valid_name() contains "%d", it will try
to assign it a unit number in __dev__alloc_name() and return either the
unit number (>= 0) or an error code (< 0).
Considering positive values as error values prevent tun device creations
relying this mechanism, therefor we sho
On Wed, Oct 25, 2017 at 2:24 PM, Willem de Bruijn
wrote:
> On Sat, Oct 21, 2017 at 9:56 PM, Wei Wei wrote:
>> I have uploaded the VM core dump [1]. And I don’t know if these logs are
>> helpful in the case of
>> failing to get the C reproducer currently.
>>
>> [1]
>> https://github.com/dotweiba
From: Pieter Jansen van Vuuren
Previously we did not ensure that a netdev is a representative netdev
before dereferencing its private data. This can occur when an upper netdev
is created on a representative netdev. This patch corrects this by first
ensuring that the netdev is a representative net
On Sat, Oct 21, 2017 at 9:56 PM, Wei Wei wrote:
> I have uploaded the VM core dump [1]. And I don’t know if these logs are
> helpful in the case of
> failing to get the C reproducer currently.
>
> [1] https://github.com/dotweiba/skb_clone_atomic_inc_bug/blob/master/vmcore.gz
Thanks. So this woul
You need to check return code and abort if memory could not be
allocated.
There is a reason this helper has _init() prefix, it does not belong to
_setup() since a _setup() is not expected to fail.
Please take a look at other gro_cells_init() callers, and you will
notice that it is called from nd
On Wed, 2017-10-25 at 17:12 +, Perez-Gonzalez, Inaky wrote:
> > On Tue, 2017-10-24 at 21:00 +, Perez-Gonzalez, Inaky wrote:
> > > > ping any comments on this?
> > >
> > > None from me; I don't have access to this HW anymore, so I can't
> > > validate if the change would work or not.
> > I
socket_diag shows information only about sockets from a namespace where
a diag socket lives.
But if we request information about one unix socket, the kernel don't
check that its netns is matched with a diag socket namespace, so any
user can get information about any unix socket in a system. This l
1 - 100 of 194 matches
Mail list logo
