Re: [PATCH net-next 0/2] net: dsa: lan9303: IGMP handling

Den 10. nov. 2017 15:07, skrev Andrew Lunn: skb->offload_fwd_mark calculation is a candidate for consolidation into the DSA core. The calculation can probably be more polished when done at a point where DSA has updated skb. Hi Egil Yes, at some point we should do this. But at the moment it

Re: [PATCH net-next v2 0/3] net: dsa: b53: Turn on Broadcom tags

On 11/09/2017 02:34 PM, Florian Fainelli wrote: > Hi all, > > This was long overdue, with this patch series, the b53 driver now > turns on Broadcom tags except for 5325 and 5365 which use an older > format that we do not support yet (TBD). > > First patch is necessary in order for bgmac, used on

Re: [PATCH net-next v2 1/3] net: bgmac: Pad packets to a minimum size

On 11/10/2017 03:10 AM, David Laight wrote: > From: Florian Fainelli >> Sent: 09 November 2017 22:35 >> >> In preparation for enabling Broadcom tags with b53, pad packets to a >> minimum size of 64 bytes (sans FCS) in order for the Broadcom switch to >> accept ingressing frames. Without this, we

Re: [PATCH net-next] bpf: add support for SO_PRIORITY in bpf_getsockopt

On Thu, Nov 9, 2017 at 4:43 PM, Alexei Starovoitov wrote: > On 11/10/17 8:04 AM, Vlad Dumitrescu wrote: >> >> From: Vlad Dumitrescu >> >> Allows BPF_PROG_TYPE_SOCK_OPS programs to read sk_priority. >> >> Signed-off-by: Vlad Dumitrescu >> --- >>

Re: [PATCH] tcp: Export to userspace the TCP state names for the trace events

> On Nov 10, 2017, at 7:07 AM, Steven Rostedt wrote: > > On Fri, 10 Nov 2017 12:56:06 +0800 > Yafang Shao wrote: > >> Could the macro tcp_state_name() be renamed ？ >> If is included in include/net/tcp.h, it will > > Ideally, you don't want to

[PATCH][v2] uprobes/x86: emulate push insns for uprobe on x86

Uprobe is a tracing mechanism for userspace programs. Typical uprobe will incur overhead of two traps. First trap is caused by replaced trap insn, and the second trap is to execute the original displaced insn in user space. To reduce the overhead, kernel provides hooks for architectures to

Re: [PATCH 1/2] bpf: add a bpf_override_function helper

On Fri, Nov 10, 2017 at 10:34:59AM +0100, Ingo Molnar wrote: > > * Josef Bacik wrote: > > > @@ -551,6 +578,10 @@ static const struct bpf_func_proto > > *kprobe_prog_func_proto(enum bpf_func_id func > > return _get_stackid_proto; > > case

Re: [PATCH 12/31] nds32: Device specific operations

On Fri, Nov 10, 2017 at 5:07 PM, Greentime Hu wrote: > 2017-11-09 15:04 GMT+08:00 Greentime Hu : >> 2017-11-08 17:04 GMT+08:00 Arnd Bergmann : >>> On Wed, Nov 8, 2017 at 6:55 AM, Greentime Hu wrote: >>> +

Re: [PATCH 12/31] nds32: Device specific operations

2017-11-09 15:04 GMT+08:00 Greentime Hu : > 2017-11-08 17:04 GMT+08:00 Arnd Bergmann : >> On Wed, Nov 8, 2017 at 6:55 AM, Greentime Hu wrote: >> >>> + >>> +#define ioremap(cookie,size) __ioremap(cookie,size,0,1) >>> +#define

Re: [PATCH 0/4] make function arg and structures as const

On Fri, Nov 10, 2017 at 10:09:46AM -0500, Anna Schumaker wrote: > > > On 11/09/2017 09:21 PM, J. Bruce Fields wrote: > > On Tue, Oct 17, 2017 at 12:40:27PM -0400, Jeff Layton wrote: > >> On Tue, 2017-10-17 at 18:14 +0200, Bhumika Goyal wrote: > >>> Make the function argument as const. After

Re: [PATCH 0/4] make function arg and structures as const

On 11/09/2017 09:21 PM, J. Bruce Fields wrote: > On Tue, Oct 17, 2017 at 12:40:27PM -0400, Jeff Layton wrote: >> On Tue, 2017-10-17 at 18:14 +0200, Bhumika Goyal wrote: >>> Make the function argument as const. After thing change, make >>> the cache_detail structures as const. >>> >>> Bhumika

Re: [PATCH] tcp: Export to userspace the TCP state names for the trace events

On Fri, 10 Nov 2017 12:56:06 +0800 Yafang Shao wrote: > Could the macro tcp_state_name() be renamed ？ > If is included in include/net/tcp.h, it will Ideally, you don't want to include trace/events/*.h headers in other headers, as they can have side effects if those

Re: [PATCH] [net-next,v3] ibmvnic: Feature implementation of Vital Product Data (VPD) for the ibmvnic driver

On 11/10/2017 08:41 AM, Desnes Augusto Nunes do Rosário wrote: > > > On 11/09/2017 06:31 PM, Nathan Fontenot wrote: >> On 11/09/2017 01:00 PM, Desnes Augusto Nunes do Rosario wrote: >>> This patch implements and enables VDP support for the ibmvnic driver. >>> Moreover, it includes the

Re: [PATCH] [net-next,v3] ibmvnic: Feature implementation of Vital Product Data (VPD) for the ibmvnic driver

On 11/09/2017 06:31 PM, Nathan Fontenot wrote: On 11/09/2017 01:00 PM, Desnes Augusto Nunes do Rosario wrote: This patch implements and enables VDP support for the ibmvnic driver. Moreover, it includes the implementation of suitable structs, signal transmission/handling and functions which

Re: [PATCH net-next 1/2] net: dsa: lan9303: Set up trapping of IGMP to CPU port

On Fri, Nov 10, 2017 at 12:54:34PM +0100, Egil Hjelmeland wrote: > IGMP packets should be trapped to the CPU port. The SW bridge knows > whether to forward to other ports. > > With "IGMP snooping for local traffic" merged, IGMP trapping is also > required for stable IGMPv2 operation. > > LAN9303

Re: [PATCH] net: qcom/emac: fix the error of tpd buff address valid bit

On 11/10/2017 07:24 AM, Wang, Dongsheng wrote: On QDF2400, EMAC TPD buff address size is [45:0]. buff address_l [31:0], buff address_h [31:18]. The address_h should change from [30:18] to [31:18]. So TPD buff address should has 46bits. Bit 31 of the Word 3 in the TPD is the Timestamp_save.

Re: [PATCH net-next 0/2] net: dsa: lan9303: IGMP handling

> skb->offload_fwd_mark calculation is a candidate for consolidation into the > DSA core. The calculation can probably be more polished when done at a point > where DSA has updated skb. Hi Egil Yes, at some point we should do this. But at the moment it is too early. We don't have enough

Re: [PATCH 4/4] RFC: net: dsa: realtek-smi: Add Realtek SMI driver

> Out of curiosity: Are there fundamental reasons why ToR switches don't use > the DSA model, or is it more historical? Yes, there is a fundamental reason. https://www.netdevconf.org/2.1/session.html?lunn_didelot_fainelli DSA always has a host Ethernet interface connected to a port of the

Re: [kernel-hardening] [PATCH v4] scripts: add leaking_addresses.pl

On Tue, 2017-11-07 at 21:32 +1100, Tobin C. Harding wrote: > Currently we are leaking addresses from the kernel to user space. > This > script is an attempt to find some of those leakages. Script parses > `dmesg` output and /proc and /sys files for hex strings that look > like > kernel addresses.

Re: [PATCH net-next v7 0/3] nfp act_vlan: Rewrite of the TC vlan action to use the RCU, and incorporated review comments

Hi Dave, On Fri, Nov 10, 2017 at 8:39 AM, David Miller wrote: > From: Manish Kurup > Date: Fri, 10 Nov 2017 07:30:09 -0500 > >> The last version I sent out (with changes for comments), was v10, But >> I noticed that you applied v7 (without the

Re: [PATCH 4/4] RFC: net: dsa: realtek-smi: Add Realtek SMI driver

> OK, so looks like DSA is actually what I need. I just didn't see a clear > implementation path for e.g. ACL functions. > Correct me if I'm wrong, to add support for ar8327 ACL or port rate control > I should expand struct dsa_switch_ops, add appropriate infrastructure in > netfilter/tc

Re: [PATCH] socket: add THIS_MODULE to sock_fs_type.

From: Tonghao Zhang Date: Fri, 10 Nov 2017 04:47:58 -0800 > As important member of file_system_type, we set > ->owner for sock_fs_type. > > Signed-off-by: Tonghao Zhang The value of THIS_MODULE is always NULL in this file. Sorry, I'm

Re: [REGRESSION] Warning in tcp_fastretrans_alert() of net/ipv4/tcp_input.c

Uhh, sorry, just found the original submission [1]. [1] https://marc.info/?l=linux-netdev=151009763926816=2 10.11.2017 14:15, Oleksandr Natalenko wrote: Hi. I'm running the machine with this patch applied for 7 hours now, and the warning hasn't appeared yet. Typically, it should be there

Re: [PATCH net-next v7 0/3] nfp act_vlan: Rewrite of the TC vlan action to use the RCU, and incorporated review comments

From: Manish Kurup Date: Fri, 10 Nov 2017 07:30:09 -0500 > The last version I sent out (with changes for comments), was v10, But > I noticed that you applied v7 (without the reverse xmas tree patch on > patch #3). Check my tree, I actually applied a later version than

Re: [PATCH] net: qcom/emac: fix the error of tpd buff address valid bit

Hey, Timur, On 2017/11/10 20:57, Timur Tabi wrote: On 11/10/17 3:49 AM, Wang Dongsheng wrote: TPD has 46-bits as buff address valid bit. So fix the buff address from 45-bits to 46-bits. NAK. The TPD has 45 bits.  Why do you say it was 46? On QDF2400, EMAC TPD buff address size is [45:0].

Re: [REGRESSION] Warning in tcp_fastretrans_alert() of net/ipv4/tcp_input.c

Hi. I'm running the machine with this patch applied for 7 hours now, and the warning hasn't appeared yet. Typically, it should be there within the first hour. I'll keep an eye on it for a longer time, but as of now it looks good. Some explanation on this please? Thanks! 06.11.2017 23:27,

[PATCH 1/4] can: c_can: don't indicate triple sampling support for D_CAN

From: Richard Schütz The D_CAN controller doesn't provide a triple sampling mode, so don't set the CAN_CTRLMODE_3_SAMPLES flag in ctrlmode_supported. Currently enabling triple sampling is a no-op. Signed-off-by: Richard Schütz Cc: linux-stable

pull-request: can 2017-11-10

(2017-11-10 14:54:47 +0900) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/mkl/linux-can.git tags/linux-can-fixes-for-4.14-20171110 for you to fetch changes up to 4f7116757b4bd99e4ef2636c7d957a6d63035d11: can: ifi: Fix transmitter delay calculation

[PATCH 4/4] can: ifi: Fix transmitter delay calculation

From: Marek Vasut The CANFD transmitter delay calculation formula was updated in the latest software drop from IFI and improves the behavior of the IFI CANFD core during bitrate switching. Use the new formula to improve stability of the CANFD operation. Signed-off-by: Marek Vasut

[PATCH 2/4] can: sun4i: handle overrun in RX FIFO

From: Gerhard Bertelsmann SUN4Is CAN IP has a 64 byte deep FIFO buffer. If the buffer is not drained fast enough (overrun) it's getting mangled. Already received frames are dropped - the data can't be restored. Signed-off-by: Gerhard Bertelsmann

[PATCH 3/4] can: peak: Add support for new PCIe/M2 CAN FD interfaces

From: Stephane Grosjean This adds support for the following PEAK-System CAN FD interfaces: PCAN-cPCIe FD CAN FD Interface for cPCI Serial (2 or 4 channels) PCAN-PCIe/104-Express CAN FD Interface for PCIe/104-Express (1, 2 or 4 ch.) PCAN-miniPCIe FD CAN

Re: [PATCH] uprobes/x86: emulate push insns for uprobe on x86

Yonghong, The patch looks good to me, but I'll try to read it carefully later. Just a couple of cosmetic nits for now. On 11/09, Yonghong Song wrote: > > --- a/arch/x86/include/asm/uprobes.h > +++ b/arch/x86/include/asm/uprobes.h > @@ -53,6 +53,10 @@ struct arch_uprobe { >

Re: [RFD] Managed interrupt affinities [ Was: mlx5 broken affinity ]

On Fri, 10 Nov 2017, Saeed Mahameed wrote: > Well, I can speak for mlx5 case or most of the network drivers, where > all of the queues associated with an interrupt, move with it, so i > don't think our current driver have this issue. I don't believe there > are network driver with fixed Per cpu

Re: [PATCH] net: qcom/emac: fix the error of tpd buff address valid bit

On 11/10/17 3:49 AM, Wang Dongsheng wrote: TPD has 46-bits as buff address valid bit. So fix the buff address from 45-bits to 46-bits. NAK. The TPD has 45 bits. Why do you say it was 46? -- Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm

[PATCH] socket: add THIS_MODULE to sock_fs_type.

As important member of file_system_type, we set ->owner for sock_fs_type. Signed-off-by: Tonghao Zhang --- net/socket.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/socket.c b/net/socket.c index c729625..b085f14 100644 --- a/net/socket.c +++

Re: [PATCH net-next v7 0/3] nfp act_vlan: Rewrite of the TC vlan action to use the RCU, and incorporated review comments

Hi Dave, On Fri, Nov 10, 2017 at 12:53 AM, David Miller wrote: > From: Manish Kurup > Date: Tue, 7 Nov 2017 08:50:00 -0500 > >> This commit consists of 3 patches: >> >> patch1 (1/3): >> The VLAN action maintains one set of stats across all cores,

Re: [PATCH 4/4] RFC: net: dsa: realtek-smi: Add Realtek SMI driver

On 09. nov. 2017 14:24, Andrew Lunn wrote: What should also be considered is who is pushing swithdev and DSA forward, and for what market. Pure switchdev drivers is mostly being pushed forward for Top or Rack switches. Big switches, 10G, 40G, 100G ports and lots of them. L3 routing, etc.

Re: [PATCH 4/4] RFC: net: dsa: realtek-smi: Add Realtek SMI driver

On 2017-11-09 20:08, Florian Fainelli wrote: On 11/09/2017 09:24 AM, Andrew Lunn wrote: The registers writing code is where? switchdev driver? All I care about is that all the switch specific code should be in one place. The switch specific code is in the switch specific driver. Take a

Re: [PATCH 4/4] RFC: net: dsa: realtek-smi: Add Realtek SMI driver

On 2017-11-09 19:24, Andrew Lunn wrote: The registers writing code is where? switchdev driver? All I care about is that all the switch specific code should be in one place. The switch specific code is in the switch specific driver. Take a look under drivers/net/dsa for the switches which are

[PATCH net-next 1/2] net: dsa: lan9303: Set up trapping of IGMP to CPU port

IGMP packets should be trapped to the CPU port. The SW bridge knows whether to forward to other ports. With "IGMP snooping for local traffic" merged, IGMP trapping is also required for stable IGMPv2 operation. LAN9303 does not trap IGMP packets by default. Enable IGMP trapping in lan9303_setup.

[PATCH net-next 2/2] net: dsa: lan9303: Clear offload_fwd_mark for IGMP

Now that IGMP packets no longer is flooded in HW, we want the SW bridge to forward packets based on bridge configuration. To make that happen, IGMP packets must have skb->offload_fwd_mark = 0. Signed-off-by: Egil Hjelmeland --- net/dsa/tag_lan9303.c | 13 +

[PATCH net-next 0/2] net: dsa: lan9303: IGMP handling

Set up the HW switch to trap IGMP packets to CPU port. And make sure skb->offload_fwd_mark is cleared for incoming IGMP packets. skb->offload_fwd_mark calculation is a candidate for consolidation into the DSA core. The calculation can probably be more polished when done at a point where DSA has

Re: [Patch net] vlan: fix a use-after-free in vlan_device_event()

It works, thank you for fixing this ancient bug! Tested-by: Fengguang Wu

RE: [PATCH net-next v2 1/3] net: bgmac: Pad packets to a minimum size

From: Florian Fainelli > Sent: 09 November 2017 22:35 > > In preparation for enabling Broadcom tags with b53, pad packets to a > minimum size of 64 bytes (sans FCS) in order for the Broadcom switch to > accept ingressing frames. Without this, we would typically be able to > DHCP, but not resolve

Re: [PATCH net-next] bindings: net: stmmac: correctify note about LPI interrupt

On 11/09/2017 06:09 PM, Niklas Cassel wrote: There are two different combined signal for various interrupt events: In EQOS-CORE and EQOS-MTL configurations, mci_intr_o is the interrupt signal. In EQOS-DMA, EQOS-AHB and EQOS-AXI configurations, these interrupt events are combined with the

Re: [RFC] hv_netvsc: safer orderly shutdown

Stephen Hemminger writes: > Several types of control operations require that the underlying RNDIS > infrastructure be restarted. This patch changes the ordering of the > shutdown to avoid race conditions. > Stop all transmits before doing RNDIS halt. This involves

Re: [PATCH] net: mvneta: fix handling of the Tx descriptor counter

Hi Simon, Until now it seems to work. No issues so far. Regards and Thanks Sven Am Thu, 9 Nov 2017 20:19:42 +0100 schrieb Andreas Tobler : > Hi Simon, > > > On 08.11.17 18:17, Simon Guinot wrote: > > Hi Sven and Andreas, > > > > Please, can you try with

[PATCH] net: qcom/emac: fix the error of tpd buff address valid bit

From: Wang Dongsheng TPD has 46-bits as buff address valid bit. So fix the buff address from 45-bits to 46-bits. Signed-off-by: Wang Dongsheng diff --git a/drivers/net/ethernet/qualcomm/emac/emac-mac.h b/drivers/net/ethernet/qualcomm/emac/emac-mac.h

Re: [PATCH 1/2] bpf: add a bpf_override_function helper

* Josef Bacik wrote: > @@ -551,6 +578,10 @@ static const struct bpf_func_proto > *kprobe_prog_func_proto(enum bpf_func_id func > return _get_stackid_proto; > case BPF_FUNC_perf_event_read_value: > return _perf_event_read_value_proto; > +

Re: [PATCH 0/2][v5] Add the ability to do BPF directed error injection

On Wed, Nov 08, 2017 at 06:43:25AM +0900, Alexei Starovoitov wrote: > On 11/8/17 5:28 AM, Josef Bacik wrote: > > I'm sending this through Dave since it'll conflict with other BPF changes > > in his > > tree, but since it touches tracing as well Dave would like a review from > > somebody on the

[PATCH net-next] net/mlx4: Use Kconfig flag to remove support of old gen2 Mellanox devices

From: Slava Shwartsman Since Mellanox focus is on newer adapters, we would like to have the ability to disable the support for old gen2 adapters. This can be done by turning off the MLX4_CORE_GEN2 Kconfig flag. We keep it turned on by default. Signed-off-by: Slava

[net V2 2/5] net/mlx5: Cancel health poll before sending panic teardown command

From: Huy Nguyen After the panic teardown firmware command, health_care detects the error in PCI bus and calls the mlx5_pci_err_detected. This health_care flow is no longer needed because the panic teardown firmware command will bring down the PCI bus communication with the

[net V2 4/5] net/mlx5e: Set page to null in case dma mapping fails

From: Inbar Karmy Currently, when dma mapping fails, put_page is called, but the page is not set to null. Later, in the page_reuse treatment in mlx5e_free_rx_descs(), mlx5e_page_release() is called for the second time, improperly doing dma_unmap (for a non-mapped address)

[net V2 5/5] net/mlx5e: Increase Striding RQ minimum size limit to 4 multi-packet WQEs

From: Eugenia Emantayev This is to prevent the case of working with a single MPWQE (1 WQE is always reserved as RQ is linked-list). When the WQE is fully consumed, HW should still have available buffer in order not to drop packets. Fixes: 461017cb006a ("net/mlx5e: Support

[net V2 3/5] net/mlx5e: Fix napi poll with zero budget

napi->poll can be called with budget 0, e.g. in netpoll scenarios where the caller only wants to poll TX rings (poll_one_napi@net/core/netpoll.c). The below commit changed RX polling from "while" loop to "do {} while", which caused to ignore the initial budget and handle at least one RX packet.

[net V2 1/5] net/mlx5: Loop over temp list to release delay events

From: Huy Nguyen list_splice_init initializing waiting_events_list after splicing it to temp list, therefore we should loop over temp list to fire the events. Fixes: 4ca637a20a52 ("net/mlx5: Delay events till mlx5 interface's add complete for pci resume") Signed-off-by: Huy

[pull request][net V2 0/5] Mellanox, mlx5 fixes 2017-11-08

Hi Dave, The follwoing series includes some fixes for mlx5 core and etherent driver. Sorry for the late submission but as you can see i have some very critical fixes below that i would like them merged into this RC. Please pull and let me know if there is any problem. For -stable:

Re: [PATCH net] tcp: fix tcp_fastretrans_alert warning

From: Yuchung Cheng Date: Tue, 7 Nov 2017 15:33:43 -0800 > This patch fixes the cause of an WARNING indicatng TCP has pending > retransmission in Open state in tcp_fastretrans_alert(). > > The root cause is a bad interaction between path mtu probing, > if enabled, and the

Re: [PATCH net] tcp: gso: avoid refcount_t warning from tcp_gso_segment()

From: Eric Dumazet Date: Tue, 07 Nov 2017 15:15:04 -0800 > From: Eric Dumazet > > When a GSO skb of truesize O is segmented into 2 new skbs of truesize N1 > and N2, we want to transfer socket ownership to the new fresh skbs. > > In order to avoid

Re: [PATCH 0/2][v5] Add the ability to do BPF directed error injection

From: Alexei Starovoitov Date: Wed, 8 Nov 2017 06:43:25 +0900 > looks great to me. > Peter, > could you please review x86 bits? I'm still waiting for this.

Re: [PATCH net] net: fix incorrect comment with regard to VLAN packet handling

From: Girish Moodalbail Date: Tue, 7 Nov 2017 11:32:11 -0800 > The commit bcc6d4790361 ("net: vlan: make non-hw-accel rx path similar > to hw-accel") unified accel and non-accel path for VLAN RX. With that > fix we do not register any packet_type handler for VLANs

Re: [PATCH 30/31] dt-bindings: nds32 CPU Bindings

>>> Then having both is not valid. The strings should be in order of best >>> match to worst match where worst match is typically either older >>> implementations of IP blocks or generic'ish strings such as "ns16550" >>> for a UART. >> >> Thanks. >> I would like to explain it more clearly. >> They

Re: [PATCH 26/31] nds32: Build infrastructure

2017-11-09 18:33 GMT+08:00 Arnd Bergmann : > On Thu, Nov 9, 2017 at 10:02 AM, Greentime Hu wrote: >> 2017-11-08 18:16 GMT+08:00 Arnd Bergmann : >>> On Wed, Nov 8, 2017 at 6:55 AM, Greentime Hu wrote: > +config

Re: [PATCH 30/31] dt-bindings: nds32 CPU Bindings

On Fri, Nov 10, 2017 at 7:22 AM, Greentime Hu wrote: > 2017-11-09 21:57 GMT+08:00 Rob Herring : >> On Thu, Nov 9, 2017 at 3:39 AM, Greentime Hu wrote: >>> 2017-11-08 21:18 GMT+08:00 Rob Herring : Please Cc the DT

Re: [PATCH 25/31] nds32: defconfig

2017-11-09 18:20 GMT+08:00 Arnd Bergmann : > On Thu, Nov 9, 2017 at 9:00 AM, Greentime Hu wrote: >> 2017-11-08 18:03 GMT+08:00 Arnd Bergmann : >>> On Wed, Nov 8, 2017 at 6:55 AM, Greentime Hu wrote: From: Greentime Hu

Re: [PATCH 4/4] RFC: net: dsa: realtek-smi: Add Realtek SMI driver

On Thu, Nov 9, 2017 at 7:08 PM, Florian Fainelli wrote: > if you are thinking about converting existing swconfig > drivers from OpenWrt/LEDE into DSA, please do it! The conversion is > reasonably simple even if the APIs do not exactly match. I can confirm this :) It's

Re: [PATCH 13/31] nds32: DMA mapping API

2017-11-09 18:14 GMT+08:00 Arnd Bergmann : > On Thu, Nov 9, 2017 at 8:12 AM, Greentime Hu wrote: >> 2017-11-08 17:09 GMT+08:00 Arnd Bergmann : >>> On Wed, Nov 8, 2017 at 6:55 AM, Greentime Hu wrote: >>> > >>> You do the same

<    1   2