On 15/11/17 21:27, Sarah Newman wrote:
> Current memory and CPU usage for managing bridge fdb entries is unbounded.
> Add a parameter max_fdb_count, controlled from sysfs, which places an upper
> limit on the number of entries. Defaults to 1024.
>
> When max_fdb_count is met or exceeded, whether t
Weixiao Zhang writes:
> Signed-off-by: Weixiao Zhang
No empty commit logs, please.
And use v2, v3 to clearly mark what's the version of the patch:
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#patch_version_missing
> drivers/net/wireless/marvell/mwl8k.c | 7
2017-11-16 4:35 GMT+01:00 Willem de Bruijn :
> On Wed, Nov 15, 2017 at 9:55 PM, Alexei Starovoitov wrote:
>> On 11/14/17 4:20 AM, Willem de Bruijn wrote:
>>>
>>>
>>> * Limit the scope of the first patchset to Rx only, and introduce Tx
>>> in a separate patchset.
>>
>>
>>>
On Thu, Nov 16, 2017 at 01:19:52PM +0800, kbuild test robot wrote:
> Hi Atul,
>
> Thank you for the patch! Yet something to improve:
>
> [auto build test ERROR on cryptodev/master]
> [also build test ERROR on next-20171115]
> [cannot apply to v4.14]
> [if your patch is
On Mon 13 Nov 23:23 PST 2017, Ramon Fried wrote:
> From: Eyal Ilsar
>
> If the value for the firmware configuration parameters
> BTC_STATIC_LEN_LE_BT and BTC_STATIC_LEN_LE_WLAN are not set the duty
> cycle between BT and WLAN is such that if BT (including BLE) is active
> WLAN gets 0 bandwidth.
On Wed, Nov 15, 2017 at 10:13 PM, Toshiaki Makita
wrote:
> On 2017/11/16 13:54, Sarah Newman wrote:
>> On 11/15/2017 08:05 PM, Toshiaki Makita wrote:
>>> On 2017/11/16 11:25, Andrew Lunn wrote:
> Also what do the vendors using bridge for L2 offload to switch think?
The Marvell L2 swi
On 2017/11/16 13:54, Sarah Newman wrote:
> On 11/15/2017 08:05 PM, Toshiaki Makita wrote:
>> On 2017/11/16 11:25, Andrew Lunn wrote:
Also what do the vendors using bridge for L2 offload to switch think?
>>>
>>> The Marvell L2 switches which DSA supports have 8K FDB/MDB entries. So
>>> maybe 10
Hi Atul,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on cryptodev/master]
[also build test ERROR on next-20171115]
[cannot apply to v4.14]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https
On Mon, 6 Nov 2017 16:16:20 +0100
Jiri Benc wrote:
> On Mon, 6 Nov 2017 15:04:54 +, Colin King wrote:
> > The size for IFLA_IF_NETNSID is missing from the size calculation
> > because the proceeding semicolon was not removed. Fix this by removing
> > the semicolon.
>
> Acked-by: Jiri Benc
On 11/15/2017 08:05 PM, Toshiaki Makita wrote:
> On 2017/11/16 11:25, Andrew Lunn wrote:
>>> Also what do the vendors using bridge for L2 offload to switch think?
>>
>> The Marvell L2 switches which DSA supports have 8K FDB/MDB entries. So
>> maybe 1024 is a bit low?
>
> How about U32_MAX by defau
The pnp_irq() function returns -1 if an error occurs.
pnp_irq() error checking for zero is not correct.
Signed-off-by: Arvind Yadav
---
drivers/isdn/hisax/isurf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/isdn/hisax/isurf.c b/drivers/isdn/hisax/isurf.c
index 139
> On 15 Nov 2017, at 6:53 PM, David Miller wrote:
>
> From: Kai-Heng Feng
> Date: Wed, 15 Nov 2017 04:00:18 -0500
>
>> Commit ("r8169: enable ALDPS for power saving") caused a regression on
>> RTL8168evl/8111evl [1], so it got reverted.
>>
>> Instead of reverting the whole commit, let's rein
pnp_irq() and pnp_port_start() can fail here and we must check
its return value.
Signed-off-by: Arvind Yadav
---
drivers/isdn/hisax/hisax_fcpcipnp.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/isdn/hisax/hisax_fcpcipnp.c
b/drivers/isdn/hisax/hisax_fcpcipnp.c
index e4f7573..7a7
The pnp_irq() function returns -1 if an error occurs.
pnp_irq() error checking for zero is not correct.
Signed-off-by: Arvind Yadav
---
drivers/isdn/hisax/teles3.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/isdn/hisax/teles3.c b/drivers/isdn/hisax/teles3.c
index
The pnp_irq() function returns -1 if an error occurs.
pnp_irq() error checking for zero is not correct.
Signed-off-by: Arvind Yadav
---
drivers/isdn/hisax/hfc_sx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/isdn/hisax/hfc_sx.c b/drivers/isdn/hisax/hfc_sx.c
index
The pnp_irq() function returns -1 if an error occurs.
pnp_irq() error checking for zero is not correct.
Signed-off-by: Arvind Yadav
---
drivers/isdn/hisax/ix1_micro.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/isdn/hisax/ix1_micro.c b/drivers/isdn/hisax/ix1_micro
The pnp_irq() function returns -1 if an error occurs.
pnp_irq() error checking for zero is not correct.
Signed-off-by: Arvind Yadav
---
drivers/isdn/hisax/elsa.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/isdn/hisax/elsa.c b/drivers/isdn/hisax/elsa.c
index 03bc5d
The pnp_irq() function returns -1 if an error occurs.
pnp_irq() error checking for zero is not correct.
Signed-off-by: Arvind Yadav
---
drivers/isdn/hisax/sedlbauer.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/isdn/hisax/sedlbauer.c b/drivers/isdn/hisax/sedlbauer
The pnp_irq() function returns -1 if an error occurs.
pnp_irq() error checking for zero is not correct.
Signed-off-by: Arvind Yadav
---
drivers/isdn/hisax/niccy.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/isdn/hisax/niccy.c b/drivers/isdn/hisax/niccy.c
index e4c
The pnp_irq() function returns -1 if an error occurs.
pnp_irq() error checking for zero is not correct.
Signed-off-by: Arvind Yadav
---
drivers/isdn/hisax/hfcscard.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/isdn/hisax/hfcscard.c b/drivers/isdn/hisax/hfcscard.c
The pnp_irq() function returns -1 if an error occurs.
pnp_irq() error checking for zero is not correct.
Signed-off-by: Arvind Yadav
---
drivers/isdn/hisax/asuscom.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/isdn/hisax/asuscom.c b/drivers/isdn/hisax/asuscom.c
ind
The pnp_irq() function returns -1 if an error occurs.
pnp_irq() error checking for zero is not correct.
Signed-off-by: Arvind Yadav
---
drivers/isdn/hisax/diva.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/isdn/hisax/diva.c b/drivers/isdn/hisax/diva.c
index 3fc94e
The pnp_irq() function returns -1 if an error occurs.
pnp_irq() error checking for zero is not correct.
Arvind Yadav (12):
[PATCH 01/12] isdn: hisax: Fix pnp_irq's error checking for setup_asuscom
[PATCH 02/12] isdn: hisax: Fix pnp_irq's error checking for avm_pnp_setup
[PATCH 03/12] isdn: h
The pnp_irq() function returns -1 if an error occurs.
pnp_irq() error checking for zero is not correct.
Signed-off-by: Arvind Yadav
---
drivers/isdn/hisax/avm_pci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/isdn/hisax/avm_pci.c b/drivers/isdn/hisax/avm_pci.c
ind
Alexandar Potapenko while testing the kernel with KMSAN and syzkaller
discovered that in some configurations sctp would leak 4 bytes of
kernel stack.
Working with his reproducer I discovered that those 4 bytes that
are leaked is the scope id of an ipv6 address returned by recvmsg.
With a little
Hi,
I am trying to enable multi-queue in Tegra186 EQOS (which has support for 4
channels). Observed below netdev watchdog warning. Its easily reproable with
iperf test.
In normal ping scenario this is not observed. I did not observe any issue if we
disable TSO. Looks like issue in stmmac_tso_x
On 2017/11/16 11:25, Andrew Lunn wrote:
>> Also what do the vendors using bridge for L2 offload to switch think?
>
> The Marvell L2 switches which DSA supports have 8K FDB/MDB entries. So
> maybe 1024 is a bit low?
How about U32_MAX by default since it is currently not restricted.
(assuming the f
On Wed, Nov 15, 2017 at 9:55 PM, Alexei Starovoitov wrote:
> On 11/14/17 4:20 AM, Willem de Bruijn wrote:
>>
>>
>> * Limit the scope of the first patchset to Rx only, and introduce Tx
>> in a separate patchset.
>
>
>
> all sounds good to me except above bit.
>
Signed-off-by: Weixiao Zhang
---
drivers/net/wireless/marvell/mwl8k.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/net/wireless/marvell/mwl8k.c
b/drivers/net/wireless/marvell/mwl8k.c
index e813b2ca740c..8e4e9b6919e0 100644
--- a/drivers/net/wireless/marvell/m
This patch try to fix the building error on MIPS. The reason is MIPS
has already defined the LONG macro, which conflicts with the LONG enum
in drivers/net/ethernet/fealnx.c.
Cc: sta...@vger.kernel.org
Signed-off-by: Huacai Chen
---
drivers/net/ethernet/fealnx.c | 6 +++---
1 file changed, 3 inse
> @@ -556,6 +559,10 @@ void br_fdb_update(struct net_bridge *br, struct
> net_bridge_port *source,
> if (hold_time(br) == 0)
> return;
>
> + /* Place maximum on number of learned entries. */
> + if (br->max_fdb_count <= br->fdb_count)
> + return;
> +
Hi S
On 11/14/17 4:20 AM, Willem de Bruijn wrote:
* Limit the scope of the first patchset to Rx only, and introduce Tx
in a separate patchset.
all sounds good to me except above bit.
I don't remember people suggesting to split it this way.
What's the value of it without tx?
We definitely need
> What do other vendors support? Time? Number of pause frames sent?
So i checked a few Marvell Switches. You can also specify a time. It
is a little bit more complex than that, since the units of time depend
on the link speed. But converting a time in ms to what the register
wants is possible.
So
> Also what do the vendors using bridge for L2 offload to switch think?
The Marvell L2 switches which DSA supports have 8K FDB/MDB entries. So
maybe 1024 is a bit low?
How big is an FDB entry? Even an OpenWRT/LEDE class devices with 512MB
RAM can probably support 1MB of RAM for FDB entries.
> Ma
From: Grygorii Strashko
Date: Wed, 15 Nov 2017 09:46:35 -0600
> Now CPSW driver configures min eth packet size to 60 octets (ETH_ZLEN)
> which works in most of cases, but when port VLAN is configured on some
> switch port, it also can be configured to force all egress packets to be
> VLAN untagge
From: Jon Maloy
Date: Wed, 15 Nov 2017 21:23:56 +0100
> The socket level flow control is based on the assumption that incoming
> buffers meet the condition (skb->truesize / roundup(skb->len) <= 4),
> where the latter value is rounded off upwards to the nearest 1k number.
> This does empirically h
From: Vitaly Kuznetsov
Date: Wed, 15 Nov 2017 15:12:55 +0100
> rndis_filter_device_add() is called both from netvsc_probe() when we
> initially create the device and from set channels/mtu/ringparam
> routines where we basically remove the device and add it back.
>
> hw_features is reset in rndis
From: Pablo Neira Ayuso
Date: Wed, 15 Nov 2017 18:28:21 +0100
> From: Arnd Bergmann
>
> This function is no longer marked 'inline', so we now get a warning
> when it is unused:
>
> net/netfilter/nf_conntrack_netlink.c:536:15: error: 'ctnetlink_proto_size'
> defined but not used [-Werror=unuse
From: Colin King
Date: Wed, 15 Nov 2017 14:03:20 +
> From: Colin Ian King
>
> Replace kmalloc followed by a memset with kzalloc
>
> Signed-off-by: Colin Ian King
Applied.
From: Ahmed Abdelsalam
Date: Wed, 15 Nov 2017 15:34:23 +0100
> The IPv6 Segment Routing Header (SRH) format has been updated (revision 6
> of the SRH ietf draft). The update includes the following SRH fields:
>
> (1) The "First Segment" field changed to be "Last Entry" which contains
> the index
From: Michal Kubecek
Date: Wed, 15 Nov 2017 13:09:32 +0100 (CET)
> According to the description, first argument of genlmsg_nlhdr() points to
> what genlmsg_put() returns, i.e. beginning of user header. Therefore we
> should only subtract size of genetlink header and netlink message header,
> not
From: Xin Long
Date: Wed, 15 Nov 2017 17:00:11 +0800
> Now when resetting stream, if both in and out flags are set, the info
> len can reach:
> sizeof(struct sctp_strreset_outreq) + SCTP_MAX_STREAM(65535) +
> sizeof(struct sctp_strreset_inreq) + SCTP_MAX_STREAM(65535)
> even without duplicat
From: Xin Long
Date: Wed, 15 Nov 2017 16:57:26 +0800
> Commit dfcb9f4f99f1 ("sctp: deny peeloff operation on asocs with threads
> sleeping on it") fixed the race between peeloff and wait sndbuf by
> checking waitqueue_active(&asoc->wait) in sctp_do_peeloff().
>
> But it actually doesn't work, as
From: Xin Long
Date: Wed, 15 Nov 2017 16:55:54 +0800
> Now in sctp_sendmsg sctp_wait_for_sndbuf could schedule out without
> holding sock sk. It means the current asoc can be freed elsewhere,
> like when receiving an abort packet.
>
> If the asoc is just created in sctp_sendmsg and sctp_wait_for
From: chet l
Date: Wed, 15 Nov 2017 14:34:32 -0800
> I have not reviewed the entire patchset but I think if we could add a
> version_hdr and then unionize the fields, it might be easier to add
> SVM support without having to spin v5. I could be wrong though.
Please, NO VERSION FIELDS!
Design th
From: Daniel Borkmann
Date: Wed, 15 Nov 2017 23:15:20 +0100
> On 11/15/2017 09:19 PM, Linus Torvalds wrote:
>> On Wed, Nov 15, 2017 at 3:33 AM, David Miller wrote:
>>>
>>> Highlights:
>>
>> Lowlights:
>>
>> 1) it duplicated a commit from the hrtimer tree, which had been
>> cleaned up and rewr
From: Vasyl Gomonovych
Date: Wed, 15 Nov 2017 20:58:15 +0100
> @@ -1277,11 +1277,10 @@ static struct qed_dcbx_get *qed_dcbnl_get_dcbx(struct
> qed_hwfn *hwfn,
> {
> struct qed_dcbx_get *dcbx_info;
>
> - dcbx_info = kmalloc(sizeof(*dcbx_info), GFP_ATOMIC);
> + dcbx_info = kzmallo
On 11/16/2017 10:30 AM, Michael S. Tsirkin wrote:
On Thu, Nov 16, 2017 at 08:52:39AM +0900, Byungchul Park wrote:
On Thu, Nov 09, 2017 at 09:17:29AM +0900, Byungchul Park wrote:
I am sorry for having made a mistake on it.
Hello Nicholas,
Please consider this patch urgently. I'm sorry for hav
On Thu, Nov 16, 2017 at 08:52:39AM +0900, Byungchul Park wrote:
> On Thu, Nov 09, 2017 at 09:17:29AM +0900, Byungchul Park wrote:
> > I am sorry for having made a mistake on it.
>
> Hello Nicholas,
>
> Please consider this patch urgently. I'm sorry for having changed the
> original behavior with
From: Guillaume Nault
Date: Wed, 15 Nov 2017 17:20:46 +0100
> Can you please queue commit 46f1c52e66db
> ("nfp: TX time stamp packets before HW doorbell is rung") for -stable?
> We got hit but this bug in the late summer. We run this fix internally
> since a couple of months, but that'd be better
From: Gao Feng
There are multiple duplicated condition checks in the current codes, so
I add the new func ipvlan_is_valid_dev instead of the duplicated codes to
check if the netdev is real ipvlan dev.
Signed-off-by: Gao Feng
---
drivers/net/ipvlan/ipvlan_main.c | 33 +--
On Wed, Nov 15, 2017 at 09:00:09PM +0200, Eran Ben Elisha wrote:
> From: Inbar Karmy
>
> This RFC adds support for configuring PFC stall prevention through ethtool.
>
> In the event where the device unexpectedly becomes unresponsive for a long
> period of time, flow control mechanism may propaga
On Wed, 2017-11-15 at 10:45 -0600, Bryant G. Ly wrote:
> This patch just closes the window, bad things can still happen. I wanted to
> leave it
> up to the people who actively develop in ibmveth to close the window, since
> introducing
> a lock can be expensive in tx.
You don't need to instrodu
On Thu, Nov 09, 2017 at 09:17:29AM +0900, Byungchul Park wrote:
> I am sorry for having made a mistake on it.
Hello Nicholas,
Please consider this patch urgently. I'm sorry for having changed the
original behavior with the previous patch.
The safe version of llist API should be used to keep the
David Miller :
[...]
> The amount of coverage this change is going to get is very small as
> well, meaning an even greater chance of regressions.
Yes.
> Therefore the only acceptable way to handle this is to have
> a white-list, specific chips that have been explicitly tested
> and are known to
On Sun, Nov 12, 2017 at 7:55 AM, Jiri Pirko wrote:
> From: Jiri Pirko
>
> Currently the filters added to qdiscs are independent. So for example if you
> have 2 netdevices and you create ingress qdisc on both and you want to add
> identical filter rules both, you need to add them twice. This patch
Hi Pablo,
On Thu, 9 Nov 2017 00:40:14 +0100 Pablo Neira Ayuso wrote:
>
> On Wed, Nov 08, 2017 at 07:00:52PM +1100, Stephen Rothwell wrote:
> >
> > On Tue, 7 Nov 2017 11:02:48 +1100 Stephen Rothwell
> > wrote:
> > >
> > > After merging the netfilter-next tree, today's linux-next build (powerp
On Tue, Oct 31, 2017 at 5:41 AM, Björn Töpel wrote:
> From: Björn Töpel
>
> +/*
> + * struct tpacket_memreg_req is used in conjunction with PACKET_MEMREG
> + * to register user memory which should be used to store the packet
> + * data.
> + *
> + * There are some constraints for the memory being
>
> Actually, we started out with that approach, where the packet_mmap
> call mapped Tx/Rx descriptor rings and the packet buffer region. We
> later moved to this (register umem) approach, because it's more
> flexible for user space, not having to use a AF_PACKET specific
> allocator (i.e. continue
Am 15.11.2017 um 23:04 schrieb Florian Fainelli:
> On 11/12/2017 01:08 PM, Heiner Kallweit wrote:
>> After commits c974bdbc3e "net: phy: Use threaded IRQ, to allow IRQ from
>> sleeping devices" and 664fcf123a30 "net: phy: Threaded interrupts allow
>> some simplification" all relevant code pieces ru
On 11/15/2017 09:19 PM, Linus Torvalds wrote:
> On Wed, Nov 15, 2017 at 3:33 AM, David Miller wrote:
>>
>> Highlights:
>
> Lowlights:
>
> 1) it duplicated a commit from the hrtimer tree, which had been
> cleaned up and rewritten, but then merging the second copy of the
> commit re-introduced th
On 11/12/2017 01:08 PM, Heiner Kallweit wrote:
> After commits c974bdbc3e "net: phy: Use threaded IRQ, to allow IRQ from
> sleeping devices" and 664fcf123a30 "net: phy: Threaded interrupts allow
> some simplification" all relevant code pieces run in process context
> anyway and I don't think we nee
On 11/15/2017 01:45 PM, Heiner Kallweit wrote:
> Remove generic settings for callbacks config_aneg and read_status
> from drivers.
>
> Signed-off-by: Heiner Kallweit
Nice diffstat:
Reviewed-by: Florian Fainelli
--
Florian
On 11/15/2017 01:42 PM, Heiner Kallweit wrote:
> read_status and config_aneg are the only mandatory callbacks and most
> of the time the generic implementation is used by drivers.
> So make the core fall back to the generic version if a driver doesn't
> implement the respective callback.
>
> Also
Remove generic settings for callbacks config_aneg and read_status
from drivers.
Signed-off-by: Heiner Kallweit
---
drivers/net/phy/amd.c| 2 --
drivers/net/phy/at803x.c | 6 --
drivers/net/phy/bcm-cygnus.c | 2 --
drivers/net/phy/bcm63xx.c| 4
drivers/net/phy/bcm7xxx
read_status and config_aneg are the only mandatory callbacks and most
of the time the generic implementation is used by drivers.
So make the core fall back to the generic version if a driver doesn't
implement the respective callback.
Also currently the core doesn't seem to verify that drivers impl
Den 15. nov. 2017 20:27, skrev Sarah Newman:
Current memory and CPU usage for managing bridge fdb entries is unbounded.
Add a parameter max_fdb_count, controlled from sysfs, which places an upper
limit on the number of entries. Defaults to 1024.
When max_fdb_count is met or exceeded, whether t
On Wed, Nov 15, 2017 at 04:19:56PM +0100, Marc Gonzalez wrote:
> On 15/11/2017 16:03, Andrew Lunn wrote:
>
> > On Wed, Nov 15, 2017 at 03:33:47PM +0100, Marc Gonzalez wrote:
> >
> >> On 15/11/2017 15:17, Andrew Lunn wrote:
> >>
> >> In our local branch, I have completely disabled flow control sup
The socket level flow control is based on the assumption that incoming
buffers meet the condition (skb->truesize / roundup(skb->len) <= 4),
where the latter value is rounded off upwards to the nearest 1k number.
This does empirically hold true for the device drivers we know, but we
cannot trust tha
On Wed, Nov 15, 2017 at 3:33 AM, David Miller wrote:
>
> Highlights:
Lowlights:
1) it duplicated a commit from the hrtimer tree, which had been
cleaned up and rewritten, but then merging the second copy of the
commit re-introduced the bad code that had been cleaned up.
I'm talking about commit
On Wed, 15 Nov 2017 11:27:07 -0800
Sarah Newman wrote:
> Current memory and CPU usage for managing bridge fdb entries is unbounded.
> Add a parameter max_fdb_count, controlled from sysfs, which places an upper
> limit on the number of entries. Defaults to 1024.
>
> When max_fdb_count is met or e
Use kzalloc rather than kmalloc followed by memset with 0
drivers/net/ethernet/qlogic/qed/qed_dcbx.c:1280:13-20: WARNING:
kzalloc should be used for dcbx_info, instead of kmalloc/memset
Generated by: scripts/coccinelle/api/alloc/kzalloc-simple.cocci
Originally was fixed in:
'commit 561ed23331df ("
From: Inbar Karmy
In the event where the device unexpectedly becomes unresponsive
for a long period of time, flow control mechanism may propagate
pause frames which will cause congestion spreading to the entire
network.
To prevent this scenario, when the device is stalled for a period
longer than
From: Inbar Karmy
This RFC adds support for configuring PFC stall prevention through ethtool.
In the event where the device unexpectedly becomes unresponsive for a long
period of time, flow control mechanism may propagate pause frames which will
cause congestion spreading to the entire network.
From: Inbar Karmy
Implement set/get functions to configure PFC stall prevention
mode by ethtool.
On default the stall prevention timeout is configured to 8 sec.
Auto mode will set the stall prevention timeout to be 100 msec.
Signed-off-by: Inbar Karmy
Reviewed-by: Eran Ben Elisha
---
.../net/
On 11/15/2017 11:27 AM, Sarah Newman wrote:
> Current memory and CPU usage for managing bridge fdb entries is unbounded.
> Add a parameter max_fdb_count, controlled from sysfs, which places an upper
> limit on the number of entries. Defaults to 1024.
>
> When max_fdb_count is met or exceeded, whet
Current memory and CPU usage for managing bridge fdb entries is unbounded.
Add a parameter max_fdb_count, controlled from sysfs, which places an upper
limit on the number of entries. Defaults to 1024.
When max_fdb_count is met or exceeded, whether traffic is sent out a
given port should depend on
On 11/15/2017 11:18 AM, Rob Herring wrote:
On Thu, Nov 09, 2017 at 11:29:08AM -0800, David Daney wrote:
From: Carlos Munoz
Add bindings for Common Ethernet Interface (BGX) block.
Signed-off-by: Carlos Munoz
Signed-off-by: Steven J. Hill
Signed-off-by: David Daney
---
.../devicetree/bindi
On Thu, Nov 09, 2017 at 11:29:08AM -0800, David Daney wrote:
> From: Carlos Munoz
>
> Add bindings for Common Ethernet Interface (BGX) block.
>
> Signed-off-by: Carlos Munoz
> Signed-off-by: Steven J. Hill
> Signed-off-by: David Daney
> ---
> .../devicetree/bindings/net/cavium-bgx.txt
Adding CC netdev
Can someone comment on the expected behavior of this test case?
Here's the isolated test:
ip netns del tst_net_ns0
ip netns del tst_net_ns1
ip netns add tst_net_ns0
ip netns add tst_net_ns1
ip netns exec tst_net_ns0 ip link add veth0 type veth peer name veth1
Kees Cook writes:
> On Wed, Nov 1, 2017 at 5:48 AM, Eric W. Biederman
> wrote:
>> Eric Dumazet writes:
>>
>>> On Tue, 2017-10-31 at 09:14 -0700, Kees Cook wrote:
Some protocols do not correctly wipe the contents of the on-stack
struct sockaddr_storage sent down into recvmsg() (e.g. S
On Tue, Nov 14, 2017 at 01:59:03PM -0800, Shaohua Li wrote:
> On Tue, Nov 14, 2017 at 11:13:10AM -0800, Tom Herbert wrote:
> > On Tue, Nov 14, 2017 at 10:24 AM, Shaohua Li wrote:
> > > On Wed, Nov 08, 2017 at 09:44:51AM -0800, Tom Herbert wrote:
> > >> On Fri, Aug 18, 2017 at 3:27 PM, David Miller
On Tue, Nov 14, 2017 at 8:02 PM, Jakub Kicinski
wrote:
> On Tue, 14 Nov 2017 19:04:36 -0800, Alexander Duyck wrote:
>> On Tue, Nov 14, 2017 at 3:36 PM, Jakub Kicinski
>> wrote:
>> > On Tue, 14 Nov 2017 15:05:08 -0800, Alexander Duyck wrote:
>> >> >> We basically need to do some feasability resear
Uprobe is a tracing mechanism for userspace programs.
Typical uprobe will incur overhead of two traps.
First trap is caused by replaced trap insn, and
the second trap is to execute the original displaced
insn in user space.
To reduce the overhead, kernel provides hooks
for architectures to emulate
On Wed, 15 Nov 2017 07:06:21 +0530
Nishanth Devarajan wrote:
> int parse_percent_rate(char *rate, const char *str, char *dev)
You aren't modifyin dev so it should be const char *
> +{
> + long max_rate_bits;
> + int ret, saved_errno;
> + double perc, rate_bits;
> + char *str_perc,
On Wed, Nov 15, 2017 at 10:11 AM, John Fastabend
wrote:
> On 11/14/2017 04:41 PM, Willem de Bruijn wrote:
>>> /* use instead of qdisc->dequeue() for all qdiscs queried with ->peek() */
>>> static inline struct sk_buff *qdisc_dequeue_peeked(struct Qdisc *sch)
>>> {
>>> - struct sk_buff *sk
On Wed, 15 Nov 2017 09:58:33 +0900 (KST)
David Miller wrote:
> From: Stephen Hemminger
> Date: Tue, 14 Nov 2017 08:37:13 -0800
>
> > These are both old decrepit protocols that need to be sent
> > to pasture.
>
> These need to go to gregkh and his staging/ tree, not net-next.
Ok, just wanted
From: Arnd Bergmann
This function is no longer marked 'inline', so we now get a warning
when it is unused:
net/netfilter/nf_conntrack_netlink.c:536:15: error: 'ctnetlink_proto_size'
defined but not used [-Werror=unused-function]
We could mark it inline again, mark it __maybe_unused, or add an
The test compares old text based kprobe API with PERF_TYPE_PROBE.
Here is a sample output of this test:
Creating 1000 kprobes with text-based API takes 6.979683 seconds
Cleaning 1000 kprobes with text-based API takes 84.897687 seconds
Creating 1000 kprobes with PERF_TYPE_PROBE (function name) tak
A new perf type PERF_TYPE_PROBE is added to allow creating [k,u]probe
with perf_event_open. These [k,u]probe are associated with the file
decriptor created by perf_event_open, thus are easy to clean when
the file descriptor is destroyed.
Struct probe_desc and two flags, is_uprobe and is_return, ar
On 11/15/17 9:07 AM, Oleg Nesterov wrote:
On 11/15, Oleg Nesterov wrote:
So please, check if uprobe_init_insn() fails or not in this case. After that
we will know whether your patch needs the additional is_64bit_mm() check in
push_setup_xol_ops() or not.
OK, I did the check for you.
uprobe
A new pmu, perf_probe, is created for PERF_TYPE_PROBE. Based on
input from perf_event_open(), perf_probe creates a kprobe (or
kretprobe) for the perf_event. This kprobe is private to this
perf_event, and thus not added to global lists, and not
available in tracefs.
Two functions, create_local_trac
This patch adds uprobe support to perf_probe with similar pattern
as previous patch (for kprobe).
Two functions, create_local_trace_uprobe() and
destroy_local_trace_uprobe(), are created so a uprobe can be created
and attached to the file descriptor created by perf_event_open().
Signed-off-by: So
New kernel API allows creating [k,u]probe with perf_event_open.
This patch tries to use the new API. If the new API doesn't work,
we fall back to old API.
bpf_detach_probe() looks up the event being removed. If the event
is not found, we skip the clean up procedure.
Signed-off-by: Song Liu
---
Function load_and_attach() is updated to be able to create kprobes
with either old text based API, or the new PERF_TYPE_PROBE API.
A global flag use_perf_type_probe is added to select between the
two APIs.
Signed-off-by: Song Liu
Reviewed-by: Josef Bacik
---
samples/bpf/bpf_load.c | 56 +++
A new type PERF_TYPE_PROBE is being added to perf_event_attr. This
patch adds information about this type.
Note: the following two flags are also added to the man page. They
are from perf_event.h in latest kernel repo. However, they are not
related to PERF_TYPE_PROBE. Therefore, their usage are no
perf_event.h is updated in previous patch, this patch applies same
changes to the tools/ version. This is part is put in a separate
patch in case the two files are back ported separately.
Signed-off-by: Song Liu
Reviewed-by: Yonghong Song
Reviewed-by: Josef Bacik
Acked-by: Alexei Starovoitov
-
Changes RFC v2 to PATCH v1:
Check type PERF_TYPE_PROBE in perf_event_set_filter().
Rebase on to tip perf/core.
Changes RFC v1 to RFC v2:
Fix build issue reported by kbuild test bot by adding ifdef of
CONFIG_KPROBE_EVENTS, and CONFIG_UPROBE_EVENTS.
RFC v1 cover letter:
This is to follow u
On 11/15, Oleg Nesterov wrote:
>
> So please, check if uprobe_init_insn() fails or not in this case. After that
> we will know whether your patch needs the additional is_64bit_mm() check in
> push_setup_xol_ops() or not.
OK, I did the check for you.
uprobe_init_insn() doesn't fail but insn_init(x
Hi,
>> Does DSA offer any protection against concurrent calls of
>> dsa_switch_ops?
This is something I thought about for a while. Since DSA offers an
abstraction of different net stack entry points to its drivers, like
netlink (bridge, etc.) or ioctl (ethtool), it would make sense to add a
mutex
1 - 100 of 188 matches
Mail list logo