Re: [PATCH] r8152: disable rx checksum offload on Dell TB dock

2017-11-22 Thread Greg KH
On Thu, Nov 23, 2017 at 01:38:38AM -0500, Kai-Heng Feng wrote: > r8153 on Dell TB dock corrupts rx packets. > > The root cause is not found yet, but disabling rx checksumming can > workaround the issue. We can use this connection to decide if it's > a Dell TB dock: > Realtek r8153 <-> SMSC hub <->

Re: [Outreachy kernel] Re: [PATCH] net: usb: hso.c: remove unneeded DRIVER_LICENSE #define

2017-11-22 Thread Julia Lawall
On Thu, 23 Nov 2017, Greg Kroah-Hartman wrote: > On Wed, Nov 22, 2017 at 10:20:49PM +0100, Julia Lawall wrote: > > > > > > On Wed, 22 Nov 2017, Joe Perches wrote: > > > > > On Fri, 2017-11-17 at 15:19 +0100, Greg Kroah-Hartman wrote: > > > > There is no need to #define the license of the driver,

Re: [Outreachy kernel] Re: [PATCH] net: usb: hso.c: remove unneeded DRIVER_LICENSE #define

2017-11-22 Thread Greg Kroah-Hartman
On Wed, Nov 22, 2017 at 10:20:49PM +0100, Julia Lawall wrote: > > > On Wed, 22 Nov 2017, Joe Perches wrote: > > > On Fri, 2017-11-17 at 15:19 +0100, Greg Kroah-Hartman wrote: > > > There is no need to #define the license of the driver, just put it in > > > the MODULE_LICENSE() line directly as a

[PATCH] r8152: disable rx checksum offload on Dell TB dock

2017-11-22 Thread Kai-Heng Feng
r8153 on Dell TB dock corrupts rx packets. The root cause is not found yet, but disabling rx checksumming can workaround the issue. We can use this connection to decide if it's a Dell TB dock: Realtek r8153 <-> SMSC hub <-> ASMedia XHCI controller BugLink: https://bugs.launchpad.net/bugs/1729674

Re: NETDEV WATCHDOG: eth0 (dwc-eth-dwmac): transmit queue 1 timed out

2017-11-22 Thread Giuseppe CAVALLARO
Hi Bhadram you said that In normal ping scenario this is not observed, I wonder if you could try for example, ping with -s 1400. In that case, if still fail I think the issue could be the FIFO tuning and I expect overflow on RX MMC counters. Let me know Regards, Peppe On 11/20/2017 3:22 PM,

Re: [PATCH net] net: thunderx: Fix TCP/UDP checksum offload for IPv6 pkts

2017-11-22 Thread Sunil Kovvuri
On Wed, Nov 22, 2017 at 9:27 PM, Eric Dumazet wrote: > On Wed, 2017-11-22 at 15:37 +0300, Aleksey Makarov wrote: >> From: Sunil Goutham >> >> This fixes a previous patch which missed some changes >> and due to which L3 checksum offload was getting enabled >> for IPv6 pkts. And HW is dropping thes

[PATCH net 1/2] ipvlan: Fix insufficient skb linear check for arp

2017-11-22 Thread gfree . wind
From: Gao Feng In the function ipvlan_get_L3_hdr, current codes use pskb_may_pull to make sure the skb header has enough linear room for arp header. But it would access the arp payload in func ipvlan_addr_lookup. So it still may access the unepxected memory. Now use arp_hdr_len(port->dev) instea

[PATCH net 2/2] ipvlan: Fix insufficient skb linear check for ipv6 icmp

2017-11-22 Thread gfree . wind
From: Gao Feng In the function ipvlan_get_L3_hdr, current codes use pskb_may_pull to make sure the skb header has enough linear room for ipv6 header. But it would use the latter memory directly without linear check when it is icmp. So it still may access the unepxected memory in ipvlan_addr_looku

[PATCH net 0/2] ipvlan: Fix insufficient skb linear check

2017-11-22 Thread gfree . wind
From: Gao Feng The current ipvlan codes use pskb_may_pull to get the skb linear header in func ipvlan_get_L3_hdr, but the size isn't enough for arp and ipv6 icmp. So it may access the unexpected momory in ipvlan_addr_lookup. Gao Feng (2): ipvlan: Fix insufficient skb linear check for arp ipv

[PATCH net] geneve: only configure or fill UDP_ZERO_CSUM6_RX/TX info when CONFIG_IPV6

2017-11-22 Thread Hangbin Liu
Stefano pointed that configure or show UDP_ZERO_CSUM6_RX/TX info doesn't make sense if we haven't enabled CONFIG_IPV6. Fix it by adding if IS_ENABLED(CONFIG_IPV6) check. Signed-off-by: Hangbin Liu --- drivers/net/geneve.c | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) di

Re: [PATCH linux-firmware 0/2] Mellanox: Add new mlxsw_spectrum firmware 13.1530.152

2017-11-22 Thread Ben Hutchings
On Thu, 2017-11-09 at 09:15 +0200, Shalom Toledo wrote: > This set adds a new firmware version 13.1530.152 as well as information about > the previous firmware version of the mlxsw_spectrum driver > > Shalom Toledo (2): > WHENCE: Add missing entry for mlxsw_spectrum firmware > Mellanox: Add ne

[PATCH v4 2/2] sock: Move the socket inuse to namespace.

2017-11-22 Thread Tonghao Zhang
This patch add a member in struct netns_core. And this is a counter for socket_inuse in the _net_ namespace. The patch will add/sub counter in the sk_alloc or sk_free. Because socket and sock is in pair. It's a easy way to maintain the code and help developer to review. More important, it avoids ho

Re: pull-request Cavium LiquidIO firmware v1.7.0

2017-11-22 Thread Ben Hutchings
On Mon, 2017-11-13 at 13:07 -0800, Felix Manlunas wrote: > The following changes since commit bf04291309d3169c0ad3b8db52564235bbd08e30: > > WHENCE: Add new qed firmware (2017-10-09 18:03:26 +0100) > > are available in the git repository at: > > https://github.com/felix-cavium/linux-firmware.

Re: pull request: Cavium Octeon III firmware

2017-11-22 Thread Ben Hutchings
On Tue, 2017-10-31 at 17:05 -0500, Steven J. Hill wrote: > Hello. > > Would like to add firmware for our Octeon III PKI driver. Thanks. Where is this driver? I don't see any reference to the file in linux- next. [...] > cavium/pki-cluster.bin | Bin 0 -> 7488 bytes > 1 file changed, 0 insertio

[PATCH v4 1/2] sock: Change the netns_core member name.

2017-11-22 Thread Tonghao Zhang
Change the member name will make the code more readable. This patch will be used in next patch. Signed-off-by: Martin Zhang Signed-off-by: Tonghao Zhang --- include/net/netns/core.h | 2 +- net/core/sock.c | 10 +- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a

Re: [PATCH v7 0/4] Add the ability to do BPF directed error injection

2017-11-22 Thread Alexei Starovoitov
On Wed, Nov 22, 2017 at 04:23:29PM -0500, Josef Bacik wrote: > This is hopefully the final version, I've addressed the comment by Igno and > added his Acks. > > v6->v7: > - moved the opt-in macro to bpf.h out of kprobes.h. Thanks Josef! All patches look great to me. We'll probably take them all i

Re: [PATCH 1/1] qed: Add firmware 8.33.1.0

2017-11-22 Thread Ben Hutchings
On Wed, 2017-10-11 at 00:57 -0700, Rahul Verma wrote: > The new qed firmware contains fixes to firmware and added > support for new features, > -Add UFP support and drop action support. > -DCQCN support for unlimited number of QP > -Add IP type to GFT filter profile. > -Added new TCP function count

[PATCH iproute2/master] bpf: initialize the verifier log

2017-11-22 Thread Jakub Kicinski
If program loading fails before verifier prints its first message, the verifier log will not be initialized. Always set the first character of the log buffer to zero to make sure we don't dump non-printable characters to the terminal. Signed-off-by: Jakub Kicinski Reviewed-by: Quentin Monnet --

[PATCH v2 net] bpf: fix branch pruning logic

2017-11-22 Thread Alexei Starovoitov
when the verifier detects that register contains a runtime constant and it's compared with another constant it will prune exploration of the branch that is guaranteed not to be taken at runtime. This is all correct, but malicious program may be constructed in such a way that it always has a constan

[PATCH] net-sysfs: export gso_max_size attribute

2017-11-22 Thread Solio Sarabia
The netdevice gso_max_size is exposed to allow users fine-control on systems with multiple NICs with different GSO buffer sizes, and where the virtual devices like bridge and veth, need to be aware of the GSO size of the underlying devices. In a virtualized environment, setting the right GSO sizes

Re: [e1000_shutdown] e1000 0000:00:03.0: disabling already-disabled device

2017-11-22 Thread Fengguang Wu
On Wed, Nov 22, 2017 at 03:40:52AM +0530, Tushar Dave wrote: On 11/21/2017 06:11 PM, Fengguang Wu wrote: Hello, FYI this happens in mainline kernel 4.14.0-01330-g3c07399. It happens since 4.13 . It occurs in 3 out of 162 boots. [ 44.637743] advantechwdt: Unexpected close, not stopping wa

Re: kernel BUG at crypto/asymmetric_keys/public_key.c:80

2017-11-22 Thread Florian Fainelli
On 11/22/2017 10:42 AM, Johannes Berg wrote: > On Wed, 2017-11-22 at 19:29 +0100, Arend van Spriel wrote: >> + Johannes >> >> >>> BUG_ON(!sig->digest); >> BUG_ON(!sig->s); > > I *think* this is the same bug that was reported before, then this > should fix it: > > https://git.kernel.

[PATCH V2 14/29] bnx2x: deprecate pci_get_bus_and_slot()

2017-11-22 Thread Sinan Kaya
pci_get_bus_and_slot() is restrictive such that it assumes domain=0 as where a PCI device is present. This restricts the device drivers to be reused for other domain numbers. Getting ready to remove pci_get_bus_and_slot() function in favor of pci_get_domain_bus_and_slot(). Introduce bnx2x_vf_doma

[PATCH V2 15/29] pch_gbe: deprecate pci_get_bus_and_slot()

2017-11-22 Thread Sinan Kaya
pci_get_bus_and_slot() is restrictive such that it assumes domain=0 as where a PCI device is present. This restricts the device drivers to be reused for other domain numbers. Getting ready to remove pci_get_bus_and_slot() function in favor of pci_get_domain_bus_and_slot(). Use the domain informat

Re: [PATCH v1] Bluetooth: introduce DEFINE_SHOW_ATTRIBUTE() macro

2017-11-22 Thread Randy Dunlap
On 11/22/2017 02:04 PM, Randy Dunlap wrote: > On 11/22/2017 01:15 PM, Andy Shevchenko wrote: >> This macro deduplicates a lot of similar code across the hci_debugfs.c >> module. Targeting to be moved to seq_file.h eventually. >> >> Signed-off-by: Andy Shevchenko >> --- >> net/bluetooth/hci_debugf

Re: [PATCH net 0/4] bpf: fix semantics issues with helpers receiving NULL arguments

2017-11-22 Thread Daniel Borkmann
On 11/22/2017 07:32 PM, Gianluca Borello wrote: > This set includes some fixes in semantics and usability issues that emerged > recently, and would be good to have them in net before the next release. > > In particular, ARG_CONST_SIZE_OR_ZERO semantics was recently changed in > commit 9fd29c08e520

Re: [PATCH v1] Bluetooth: introduce DEFINE_SHOW_ATTRIBUTE() macro

2017-11-22 Thread Randy Dunlap
On 11/22/2017 01:15 PM, Andy Shevchenko wrote: > This macro deduplicates a lot of similar code across the hci_debugfs.c > module. Targeting to be moved to seq_file.h eventually. > > Signed-off-by: Andy Shevchenko > --- > net/bluetooth/hci_debugfs.c | 184 > +-

[PATCH v7 5/5] btrfs: allow us to inject errors at io_ctl_init

2017-11-22 Thread Josef Bacik
From: Josef Bacik This was instrumental in reproducing a space cache bug. Signed-off-by: Josef Bacik Acked-by: Ingo Molnar --- fs/btrfs/free-space-cache.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/fs/btrfs/free-space-cache.c b/fs/btrfs/free-space-cache.c index cdc9f4015ec3..daa98d

[PATCH v7 4/5] samples/bpf: add a test for bpf_override_return

2017-11-22 Thread Josef Bacik
From: Josef Bacik This adds a basic test for bpf_override_return to verify it works. We override the main function for mounting a btrfs fs so it'll return -ENOMEM and then make sure that trying to mount a btrfs fs will fail. Acked-by: Alexei Starovoitov Acked-by: Ingo Molnar Signed-off-by: Jo

[PATCH 04/11] net: ethernet: ti: cpsw: move mac_hi/lo defines in cpsw.h

2017-11-22 Thread Grygorii Strashko
Move mac_hi/lo defines in common header cpsw.h and re-use them for netcp_ethss.c. Signed-off-by: Grygorii Strashko --- drivers/net/ethernet/ti/cpsw.c| 4 drivers/net/ethernet/ti/cpsw.h| 4 drivers/net/ethernet/ti/netcp_ethss.c | 5 + 3 files changed, 5 insertions(+)

[PATCH 05/11] net: ethernet: ti: cpsw: fix ale port numbers

2017-11-22 Thread Grygorii Strashko
TI OMAP/Sitara SoCs have fixed number of ALE ports 3, which includes Host port also. Hence, use fixed value instead of value calcualted from DT, which can be set by user and might not reflect actual HW configuration. Signed-off-by: Grygorii Strashko --- drivers/net/ethernet/ti/cpsw.c | 3 ++- 1

[PATCH 03/11] net: ethernet: ti: cpsw: move platform data struct to .c file

2017-11-22 Thread Grygorii Strashko
CPSW platform data struct cpsw_platform_data and struct cpsw_slave_data are used only incide cpsw.c module, so move these definitions there. Signed-off-by: Grygorii Strashko --- drivers/net/ethernet/ti/cpsw.c | 21 + drivers/net/ethernet/ti/cpsw.h | 21 -

[PATCH 01/11] net: ethernet: ti: cpsw: drop unused var poll from cpsw_update_channels_res

2017-11-22 Thread Grygorii Strashko
Drop unused variable "poll" from cpsw_update_channels_res(). Signed-off-by: Grygorii Strashko --- drivers/net/ethernet/ti/cpsw.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/ethernet/ti/cpsw.c b/drivers/net/ethernet/ti/cpsw.c index 0c7c7a1..9235b9e 100644 --- a/drivers/net/e

[PATCH 00/11] net: ethernet: ti: cpsw/ale clean up and optimization

2017-11-22 Thread Grygorii Strashko
This is set of non critical clean ups and optimizations for TI CPSW and ALE drivers. Grygorii Strashko (11): net: ethernet: ti: cpsw: drop unused var poll from cpsw_update_channels_res net: ethernet: ti: cpsw: use proper io apis net: ethernet: ti: cpsw: move platform data struct to .c fi

[PATCH 06/11] net: ethernet: ti: ale: use proper io apis

2017-11-22 Thread Grygorii Strashko
Switch to use writel_relaxed/readl_relaxed() IO API instead of raw version as it is recommended. Signed-off-by: Grygorii Strashko --- drivers/net/ethernet/ti/cpsw_ale.c | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/drivers/net/ethernet/ti/cpsw_a

[PATCH 11/11] net: ethernet: ti: ale: fix port check in cpsw_ale_control_set/get

2017-11-22 Thread Grygorii Strashko
ALE ports number includes the Host port and ext Ports, and ALE ports numbering starts from 0, so correct corresponding port checks in cpsw_ale_control_set/get(). Signed-off-by: Grygorii Strashko --- drivers/net/ethernet/ti/cpsw_ale.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) dif

[PATCH 08/11] net: ethernet: ti: ale: optimize ale entry mask bits configuartion

2017-11-22 Thread Grygorii Strashko
The ale->params.ale_ports parameter can be used to deriver values for all ale entry mask bits: port_mask_bits, port_mask_bits, port_num_bits. Hence, calculate above values and drop all hardcoded values. For port_num_bits calcualtion use order_base_2() API. Signed-off-by: Grygorii Strashko --- dr

[PATCH 07/11] net: ethernet: ti: ale: disable ale from stop()

2017-11-22 Thread Grygorii Strashko
ALE is enabled from cpsw_ale_start() now, but disabled only from cpsw_ale_destroy() which introduces inconsitance as cpsw_ale_start() is called when netif[s] is opened, but cpsw_ale_destroy() is called when driver is removed. Hence, move ALE disabling in cpsw_ale_stop(). Signed-off-by: Grygorii St

[PATCH 10/11] net: ethernet: ti: ale: use devm_kzalloc in cpsw_ale_create()

2017-11-22 Thread Grygorii Strashko
Use cpsw_ale_create in cpsw_ale_create(). This also makes cpsw_ale_destroy() function nop, so remove it. Signed-off-by: Grygorii Strashko --- drivers/net/ethernet/ti/cpsw.c| 17 +++-- drivers/net/ethernet/ti/cpsw_ale.c| 11 +-- drivers/net/ethernet/ti/cpsw_ale.h

[PATCH 02/11] net: ethernet: ti: cpsw: use proper io apis

2017-11-22 Thread Grygorii Strashko
Switch to use writel_relaxed/readl_relaxed() IO API instead of raw version as it is recommended. Signed-off-by: Grygorii Strashko --- drivers/net/ethernet/ti/cpsw.c | 36 ++-- 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/drivers/net/ethernet/ti/

[PATCH 09/11] net: ethernet: ti: ale: move static initialization in cpsw_ale_create()

2017-11-22 Thread Grygorii Strashko
Move static initialization from cpsw_ale_start() to cpsw_ale_create() as it does not make much sence to perform static initializtion in cpsw_ale_start() which is called everytime netif[s] is opened. Signed-off-by: Grygorii Strashko --- drivers/net/ethernet/ti/cpsw_ale.c | 57 +++-

[PATCH v7 3/5] bpf: add a bpf_override_function helper

2017-11-22 Thread Josef Bacik
From: Josef Bacik Error injection is sloppy and very ad-hoc. BPF could fill this niche perfectly with it's kprobe functionality. We could make sure errors are only triggered in specific call chains that we care about with very specific situations. Accomplish this with the bpf_override_funciton

[PATCH v7 2/5] btrfs: make open_ctree error injectable

2017-11-22 Thread Josef Bacik
From: Josef Bacik This allows us to do error injection with BPF for open_ctree. Signed-off-by: Josef Bacik Acked-by: Ingo Molnar --- fs/btrfs/disk-io.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c index dfdab849037b..69d17a640b94 100644 --- a/f

[PATCH v7 1/5] add infrastructure for tagging functions as error injectable

2017-11-22 Thread Josef Bacik
From: Josef Bacik Using BPF we can override kprob'ed functions and return arbitrary values. Obviously this can be a bit unsafe, so make this feature opt-in for functions. Simply tag a function with KPROBE_ERROR_INJECT_SYMBOL in order to give BPF access to that function for error injection purpo

[PATCH v7 0/4] Add the ability to do BPF directed error injection

2017-11-22 Thread Josef Bacik
This is hopefully the final version, I've addressed the comment by Igno and added his Acks. v6->v7: - moved the opt-in macro to bpf.h out of kprobes.h. v5->v6: - add BPF_ALLOW_ERROR_INJECTION() tagging for functions that will support this feature. This way only functions that opt-in will be al

Re: [Outreachy kernel] Re: [PATCH] net: usb: hso.c: remove unneeded DRIVER_LICENSE #define

2017-11-22 Thread Julia Lawall
On Wed, 22 Nov 2017, Joe Perches wrote: > On Fri, 2017-11-17 at 15:19 +0100, Greg Kroah-Hartman wrote: > > There is no need to #define the license of the driver, just put it in > > the MODULE_LICENSE() line directly as a text string. > > > > This allows tools that check that the module license m

[PATCH v1] Bluetooth: introduce DEFINE_SHOW_ATTRIBUTE() macro

2017-11-22 Thread Andy Shevchenko
This macro deduplicates a lot of similar code across the hci_debugfs.c module. Targeting to be moved to seq_file.h eventually. Signed-off-by: Andy Shevchenko --- net/bluetooth/hci_debugfs.c | 184 +--- 1 file changed, 18 insertions(+), 166 deletions(-) di

[PATCH net] bpf: fix branch pruning logic

2017-11-22 Thread Alexei Starovoitov
when the verifier detects that register contains a runtime constant and it's compared with another constant it will prune exploration of the branch that is guaranteed not to be taken at runtime. This is all correct, but malicious program may be constructed in such a way that it always has a constan

[PATCH iproute 2/5] ila: added csum neutral support to ipila

2017-11-22 Thread Tom Herbert
Add checksum neutral to ip ila configuration. This control whether the C-bit is interpreted as checksum neutral bit. Signed-off-by: Tom Herbert --- ip/ipila.c | 57 +++-- 1 file changed, 55 insertions(+), 2 deletions(-) diff --git a/ip/ipila.c

[PATCH iproute 5/5] ila: create ila_common.h

2017-11-22 Thread Tom Herbert
Move common functions related to checksum, identifier and hook-type parsing to a common include file. Signed-off-by: Tom Herbert --- ip/ila_common.h | 105 ++ ip/ipila.c| 77 +--- ip/iproute_lwtunn

[PATCH iproute 3/5] ila: support to configure checksum neutral-map-auto

2017-11-22 Thread Tom Herbert
Configuration support in both ip ila and ip LWT for checksum neutral-map-auto. This is a mode of ILA where checksum neutral mapping is assumed for packets (there is no C-bit in the identifier to indicate checksum neutral). Signed-off-by: Tom Herbert --- ip/ipila.c| 8 +--- ip/ipr

[PATCH iproute 4/5] ila: support for configuring identifier and hook types

2017-11-22 Thread Tom Herbert
Expose identifier type and hook types in ILA configuraiton and reporting. This adds support in both ip ila ILA LWT. Signed-off-by: Tom Herbert --- ip/ipila.c| 75 ++- ip/iproute_lwtunnel.c | 107 +- 2 fi

[PATCH iproute 1/5] ila: Fix reporting of ILA locators and locator match

2017-11-22 Thread Tom Herbert
Fix retrieval of locator value for RTA to get 64 bits instead of 32. Signed-off-by: Tom Herbert --- ip/ipila.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ip/ipila.c b/ip/ipila.c index 0403fc42..fe5c4d8b 100644 --- a/ip/ipila.c +++ b/ip/ipila.c @@ -79,7 +79,7 @@ static vo

[PATCH iproute 0/5] ila: additional configuratio support

2017-11-22 Thread Tom Herbert
Add configuration support for checksum neutral-map-auto, identifier tyoes, and hook type (for LWT). Tom Herbert (5): ila: Fix reporting of ILA locators and locator match ila: added csum neutral support to ipila ila: support to configure checksum neutral-map-auto ila: support for configurin

Re: [PATCH] net: sched: crash on blocks with goto chain action

2017-11-22 Thread Cong Wang
On Tue, Nov 21, 2017 at 12:02 PM, Roman Kapl wrote: > > But maybe the "hold all chains" approach from 822e86d997 (net_sched: remove > tcf_block_put_deferred()) is simpler to understand? > Yes, it is much easier to understand for me, probably for others too.

Re: len = bpf_probe_read_str(); bpf_perf_event_output(... len) == FAIL

2017-11-22 Thread Gianluca Borello
On Tue, Nov 21, 2017 at 2:31 PM, Alexei Starovoitov wrote: > > yeah sorry about this hack. Gianluca reported this issue as well. > Yonghong fixed it for bpf_probe_read only. We will extend > the fix to bpf_probe_read_str() and bpf_perf_event_output() asap. > The above workaround gets too much into

Re: kernel BUG at crypto/asymmetric_keys/public_key.c:80

2017-11-22 Thread Johannes Berg
On Wed, 2017-11-22 at 19:29 +0100, Arend van Spriel wrote: > + Johannes > > >>> BUG_ON(!sig->digest); > BUG_ON(!sig->s); I *think* this is the same bug that was reported before, then this should fix it: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git/commit/?id=d7be10

[PATCH net 3/4] bpf: change bpf_probe_read_str arg2 type to ARG_CONST_SIZE_OR_ZERO

2017-11-22 Thread Gianluca Borello
Commit 9fd29c08e520 ("bpf: improve verifier ARG_CONST_SIZE_OR_ZERO semantics") relaxed the treatment of ARG_CONST_SIZE_OR_ZERO due to the way the compiler generates optimized BPF code when checking boundaries of an argument from C code. A typical example of this optimized code can be generated usin

[PATCH net 4/4] bpf: change bpf_perf_event_output arg5 type to ARG_CONST_SIZE_OR_ZERO

2017-11-22 Thread Gianluca Borello
Commit 9fd29c08e520 ("bpf: improve verifier ARG_CONST_SIZE_OR_ZERO semantics") relaxed the treatment of ARG_CONST_SIZE_OR_ZERO due to the way the compiler generates optimized BPF code when checking boundaries of an argument from C code. A typical example of this optimized code can be generated usin

[PATCH net 2/4] bpf: remove explicit handling of 0 for arg2 in bpf_probe_read

2017-11-22 Thread Gianluca Borello
Commit 9c019e2bc4b2 ("bpf: change helper bpf_probe_read arg2 type to ARG_CONST_SIZE_OR_ZERO") changed arg2 type to ARG_CONST_SIZE_OR_ZERO to simplify writing bpf programs by taking advantage of the new semantics introduced for ARG_CONST_SIZE_OR_ZERO which allows arguments. In order to prevent the

[PATCH net 1/4] bpf: introduce ARG_PTR_TO_MEM_OR_NULL

2017-11-22 Thread Gianluca Borello
With the current ARG_PTR_TO_MEM/ARG_PTR_TO_UNINIT_MEM semantics, an helper argument can be NULL when the next argument type is ARG_CONST_SIZE_OR_ZERO and the verifier can prove the value of this next argument is 0. However, most helpers are just interested in handling , so forcing them to deal with

[PATCH net 0/4] bpf: fix semantics issues with helpers receiving NULL arguments

2017-11-22 Thread Gianluca Borello
This set includes some fixes in semantics and usability issues that emerged recently, and would be good to have them in net before the next release. In particular, ARG_CONST_SIZE_OR_ZERO semantics was recently changed in commit 9fd29c08e520 ("bpf: improve verifier ARG_CONST_SIZE_OR_ZERO semantics"

Re: kernel BUG at crypto/asymmetric_keys/public_key.c:80

2017-11-22 Thread Arend van Spriel
+ Johannes On 22-11-17 18:43, Florian Fainelli wrote: Hi, (sorry for the cross post) I am at v4.14-12995-g0c86a6bd85ff and just met the following, attached is my .config file. Is this a known problem? Thanks! [1.798714] cfg80211: Loading compiled-in X.509 certificates for regulatory datab

kernel BUG at crypto/asymmetric_keys/public_key.c:80

2017-11-22 Thread Florian Fainelli
Hi, (sorry for the cross post) I am at v4.14-12995-g0c86a6bd85ff and just met the following, attached is my .config file. Is this a known problem? Thanks! [1.798714] cfg80211: Loading compiled-in X.509 certificates for regulatory database [1.809390] [ cut here ] [

Re: [Outreachy kernel] Re: [PATCH] net: usb: hso.c: remove unneeded DRIVER_LICENSE #define

2017-11-22 Thread Julia Lawall
On Wed, 22 Nov 2017, Joe Perches wrote: > On Fri, 2017-11-17 at 15:19 +0100, Greg Kroah-Hartman wrote: > > There is no need to #define the license of the driver, just put it in > > the MODULE_LICENSE() line directly as a text string. > > > > This allows tools that check that the module license m

Re: [PATCH] net: usb: hso.c: remove unneeded DRIVER_LICENSE #define

2017-11-22 Thread Greg Kroah-Hartman
On Wed, Nov 22, 2017 at 09:05:36AM -0800, Joe Perches wrote: > On Fri, 2017-11-17 at 15:19 +0100, Greg Kroah-Hartman wrote: > > There is no need to #define the license of the driver, just put it in > > the MODULE_LICENSE() line directly as a text string. > > > > This allows tools that check that t

Re: [PATCH] net: usb: hso.c: remove unneeded DRIVER_LICENSE #define

2017-11-22 Thread Joe Perches
On Fri, 2017-11-17 at 15:19 +0100, Greg Kroah-Hartman wrote: > There is no need to #define the license of the driver, just put it in > the MODULE_LICENSE() line directly as a text string. > > This allows tools that check that the module license matches the source > code license to work properly, a

Re: Uninitialized value in __sk_nulls_add_node_rcu()

2017-11-22 Thread Eric Dumazet
On Wed, Nov 22, 2017 at 5:38 AM, Alexander Potapenko wrote: > On Thu, Oct 26, 2017 at 4:56 PM, Alexander Potapenko > wrote: >> On Thu, Oct 26, 2017 at 4:52 PM, Eric Dumazet wrote: >>> On Thu, Oct 26, 2017 at 7:47 AM, Eric Dumazet wrote: On Thu, Oct 26, 2017 at 7:20 AM, Alexander Potapenko

Re: [PATCH net] net: thunderx: Fix TCP/UDP checksum offload for IPv6 pkts

2017-11-22 Thread Eric Dumazet
On Wed, 2017-11-22 at 15:37 +0300, Aleksey Makarov wrote: > From: Sunil Goutham > > This fixes a previous patch which missed some changes > and due to which L3 checksum offload was getting enabled > for IPv6 pkts. And HW is dropping these pkts as it assumes > the pkt is IPv4 when IP csum offload

ipsec: ipcomp alg problem on vti interface

2017-11-22 Thread Alexey Kodanev
Hi Steffen, LTP has vti test-cases which fail on ipcomp alg, e.g. "tcp_ipsec_vti.sh -p comp -m tunnel -s 100" Basically, the setupconsists of the following commands: ip li add ltp_vti0 type vti local 10.0.0.2 remote 10.0.0.1 key 10 dev ltp_ns_veth2 ip li set ltp_vti0 up ip -4 xf st add src 10.0

[PATCH] [WAN]: lmc: Use memdup_user() as a cleanup

2017-11-22 Thread Vasyl Gomonovych
Fix coccicheck warning which recommends to use memdup_user(): drivers/net/wan/lmc/lmc_main.c:497:27-34: WARNING opportunity for memdup_user Generated by: scripts/coccinelle/memdup_user/memdup_user.cocci Signed-off-by: Vasyl Gomonovych --- drivers/net/wan/lmc/lmc_main.c | 13 +++-- 1 file

pull-request: wireless-drivers 2017-11-22

2017-11-22 Thread Kalle Valo
Hi Dave, here's the first pull request to net tree for 4.15. Please let me know if there are any problems. Kalle The following changes since commit 32a72bbd5da2411eab591bf9bc2e39349106193a: net: vxge: Fix some indentation issues (2017-11-20 11:36:30 +0900) are available in the git repository

Re: Uninitialized value in __sk_nulls_add_node_rcu()

2017-11-22 Thread Alexander Potapenko
On Thu, Oct 26, 2017 at 4:56 PM, Alexander Potapenko wrote: > On Thu, Oct 26, 2017 at 4:52 PM, Eric Dumazet wrote: >> On Thu, Oct 26, 2017 at 7:47 AM, Eric Dumazet wrote: >>> On Thu, Oct 26, 2017 at 7:20 AM, Alexander Potapenko >>> wrote: On Thu, Oct 26, 2017 at 2:51 PM, Alexander Potapen

Re: [PATCH net v2] net: accept UFO datagrams from tuntap and packet

2017-11-22 Thread Jason Wang
On 2017年11月21日 23:22, Willem de Bruijn wrote: From: Willem de Bruijn Tuntap and similar devices can inject GSO packets. Accept type VIRTIO_NET_HDR_GSO_UDP, even though not generating UFO natively. Processes are expected to use feature negotiation such as TUNSETOFFLOAD to detect supported offl

[PATCH net] net: thunderx: Fix TCP/UDP checksum offload for IPv6 pkts

2017-11-22 Thread Aleksey Makarov
From: Sunil Goutham This fixes a previous patch which missed some changes and due to which L3 checksum offload was getting enabled for IPv6 pkts. And HW is dropping these pkts as it assumes the pkt is IPv4 when IP csum offload is set in the SQ descriptor. Fixes: 494fd005 ("net: thunderx: Ena

Re: [PATCH] xen-netfront: remove warning when unloading module

2017-11-22 Thread kbuild test robot
/linux/commits/Eduardo-Otubo/xen-netfront-remove-warning-when-unloading-module/20171122-163844 base: https://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git linux-next config: x86_64-allmodconfig (attached as .config) compiler: gcc-6 (Debian 6.4.0-9) 6.4.0 20171026 reproduce: # save the

Re: [PATCH 12/31] nds32: Device specific operations

2017-11-22 Thread Greentime Hu
2017-11-11 0:14 GMT+08:00 Arnd Bergmann : > Could you move ioremap_nocache/ioremap_uc/ioremap_wc/ioremap_wt > out of that #ifdef, or would that break other architectures? > It seems ok. I just tried arm64, x86 and nds32. #endif /* CONFIG_MMU */ #ifndef ioremap_nocache void __iomem *ioremap(phys_a

Wifi RTL8723bu driver test: failed to scan

2017-11-22 Thread Mylene JOSSERAND
Hello Jes Sorensen, I am currently testing a LM811 Wifi/BT USB dongle [1] on a Sinlinx SinA33 Allwinner SoC board [2]. I saw that I should use the realtek driver RTL8723BU for this USB dongle. Currently, I am only testing the Wifi and the mainline driver (kernel 4.14-rc7) does not seem to work. A

Re: broken ipv6 tcp csum offload on thunderx

2017-11-22 Thread Sunil Kovvuri
On Wed, Nov 22, 2017 at 2:24 PM, Florian Westphal wrote: > Hi. > > We are experiencing broken ipv6 connectivity with 4.14 kernel > on arm64 with thunderx. > > ping6 still works, but it looks like tcp syn packets get sent > with a wrong checksum -- socket remains in SYN-SENT state. > > after runnin

broken ipv6 tcp csum offload on thunderx

2017-11-22 Thread Florian Westphal
Hi. We are experiencing broken ipv6 connectivity with 4.14 kernel on arm64 with thunderx. ping6 still works, but it looks like tcp syn packets get sent with a wrong checksum -- socket remains in SYN-SENT state. after running ethtool -K enP2p1s0f1 tx-checksum-ipv6 off ipv6 tcp appears to works

[net 06/13] i40e: restore promiscuous after reset

2017-11-22 Thread Jeff Kirsher
From: Alan Brady After a reset we rebuild the VSIs which is going to clobber any promiscuous settings we had before reset. This makes it so that we restore the promiscuous settings we had before reset. Signed-off-by: Alan Brady Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- driver

[net 07/13] ixgbe: Fix skb list corruption on Power systems

2017-11-22 Thread Jeff Kirsher
From: Brian King This patch fixes an issue seen on Power systems with ixgbe which results in skb list corruption and an eventual kernel oops. The following is what was observed: CPU 1 CPU2 1: i

[net 04/13] i40e: Fix FLR reset timeout issue

2017-11-22 Thread Jeff Kirsher
From: Filip Sadowski This patch allows detection of upcoming core reset in case NIC gets stuck while performing FLR reset. The i40e_pf_reset() function returns I40E_ERR_NOT_READY when global reset was detected. Signed-off-by: Filip Sadowski Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher

[net 09/13] ixgbevf: Use smp_rmb rather than read_barrier_depends

2017-11-22 Thread Jeff Kirsher
From: Brian King The original issue being fixed in this patch was seen with the ixgbe driver, but the same issue exists with ixgbevf as well, as the code is very similar. read_barrier_depends is not sufficient to ensure loads following it are not speculatively loaded out of order by the CPU, whic

[net 01/13] i40e: Fix for NUP NVM image downgrade failure

2017-11-22 Thread Jeff Kirsher
From: Jacob Keller Since commit 96a39aed25e6 ("i40e: Acquire NVM lock before reads on all devices") we've used the NVM lock to synchronize NVM reads even on devices which don't strictly need the lock. Doing so can cause a regression on older firmware prior to 1.5, especially when downgrading the

[net 02/13] i40e: fix the calculation of VFs mac addresses

2017-11-22 Thread Jeff Kirsher
From: Zijie Pan num_mac should be increased only after the call to i40e_add_mac_filter(). Fixes: 5f527ba962e2 ("i40e: Limit the number of MAC and VLAN addresses that can be added for VFs") Signed-off-by: Zijie Pan Signed-off-by: Nicolas Dichtel Reviewed-by: Tushar Dave Tested-by: Andrew Bowe

[net 00/13][pull request] Intel Wired LAN Driver Fixes 2017-11-21

2017-11-22 Thread Jeff Kirsher
This series contains fixes for igb/vf, ixgbe/vf, i40e/vf and fm10k. Jake fixes a regression issue with older firmware, where we were using the NVM lock to synchronize NVM reads for all devices and firmware versions, yet this caused issues with older firmware prior to version 1.5. Fixed this by on

[net 03/13] i40e: Remove limit of 64 max queues per channel

2017-11-22 Thread Jeff Kirsher
From: Amritha Nambiar It is safe to remove the upper limit of 64 queues on a channel VSI. The upper bound is determined by the VSI's num_queue_pairs and gets validated when the queue mapping info through mqprio interface is subject to bound checking in the driver. Signed-off-by: Amritha Nambiar

[net 13/13] i40evf: Use smp_rmb rather than read_barrier_depends

2017-11-22 Thread Jeff Kirsher
From: Brian King The original issue being fixed in this patch was seen with the ixgbe driver, but the same issue exists with i40evf as well, as the code is very similar. read_barrier_depends is not sufficient to ensure loads following it are not speculatively loaded out of order by the CPU, which

[net 08/13] i40e: Use smp_rmb rather than read_barrier_depends

2017-11-22 Thread Jeff Kirsher
From: Brian King The original issue being fixed in this patch was seen with the ixgbe driver, but the same issue exists with i40e as well, as the code is very similar. read_barrier_depends is not sufficient to ensure loads following it are not speculatively loaded out of order by the CPU, which c

[net 11/13] igb: Use smp_rmb rather than read_barrier_depends

2017-11-22 Thread Jeff Kirsher
From: Brian King The original issue being fixed in this patch was seen with the ixgbe driver, but the same issue exists with igb as well, as the code is very similar. read_barrier_depends is not sufficient to ensure loads following it are not speculatively loaded out of order by the CPU, which ca

[net 10/13] igbvf: Use smp_rmb rather than read_barrier_depends

2017-11-22 Thread Jeff Kirsher
From: Brian King The original issue being fixed in this patch was seen with the ixgbe driver, but the same issue exists with igbvf as well, as the code is very similar. read_barrier_depends is not sufficient to ensure loads following it are not speculatively loaded out of order by the CPU, which

[net 05/13] i40evf: fix client notify of l2 params

2017-11-22 Thread Jeff Kirsher
From: Alan Brady The current method for notifying clients of l2 parameters is broken because we fail to copy the new parameters to the client instance struct, we need to do the notification before the client 'open' function pointer gets called, and lastly we should set the l2 parameters when firs

[net 12/13] fm10k: Use smp_rmb rather than read_barrier_depends

2017-11-22 Thread Jeff Kirsher
From: Brian King The original issue being fixed in this patch was seen with the ixgbe driver, but the same issue exists with fm10k as well, as the code is very similar. read_barrier_depends is not sufficient to ensure loads following it are not speculatively loaded out of order by the CPU, which