[PATCH net] Revert "net: core: maybe return -EEXIST in __dev_alloc_name"

2017-12-01 Thread Johannes Berg
From: Johannes Berg This reverts commit d6f295e9def0; some userspace (in the case we noticed it's wpa_supplicant), is relying on the current error code to determine that a fixed name interface already exists. Reported-by: Jouni Malinen Signed-off-by: Johannes Berg --- net/core/dev.c | 2 +- 1

[PATCH v2] net: macb: change GFP_KERNEL to GFP_ATOMIC

2017-12-01 Thread Julia Lawall
Function gem_add_flow_filter called on line 2958 inside lock on line 2949 but uses GFP_KERNEL Generated by: scripts/coccinelle/locks/call_kern.cocci Fixes: ae8223de3df5 ("net: macb: Added support for RX filtering") CC: Rafal Ozieblo Signed-off-by: Julia Lawall Signed-off-by: Fengguang Wu ---

Re: [Patch net-next] act_mirred: use tcfm_dev in tcf_mirred_get_dev()

2017-12-01 Thread Jiri Pirko
Fri, Dec 01, 2017 at 10:46:42PM CET, xiyou.wangc...@gmail.com wrote: >On Fri, Dec 1, 2017 at 9:56 AM, Jiri Pirko wrote: >> >> Isn't this here so user may specify a ifindex of netdev which is not yet >> present on the system (not sure how much sense that would make though...) > >How is this even po

[PATCH net] nfp: fix port stats for mac representors

2017-12-01 Thread Jakub Kicinski
From: Pieter Jansen van Vuuren Previously we swapped the tx_packets, tx_bytes and tx_dropped counters with rx_packets, rx_bytes and rx_dropped counters, respectively. This behaviour is correct and expected for VF representors but it should not be swapped for physical port mac representors. Signe

[PATCH 1/1] timecounter: Make cyclecounter struct part of timecounter struct

2017-12-01 Thread Sagar Arun Kamble
There is no real need for the users of timecounters to define cyclecounter and timecounter variables separately. Since timecounter will always be based on cyclecounter, have cyclecounter struct as member of timecounter struct. Suggested-by: Chris Wilson Signed-off-by: Sagar Arun Kamble Cc: Chris

[PATCH net-next v2] net: dsa: Allow compiling out legacy support

2017-12-01 Thread Florian Fainelli
Introduce a configuration option: CONFIG_NET_DSA_LEGACY allowing to compile out support for the old platform device and Device Tree binding registration. Support for these configurations is scheduled to be removed in 4.17. Signed-off-by: Florian Fainelli --- Changes in v2: - make the option enabl

Re: UNITED NATION COMPENSATIONS,

2017-12-01 Thread UNITED NATION COMPENSATIONS
Re:Hello Dear, What has actually kept you waiting to claim your fund $870.000.00 since then? Your fund has been approved since and nobody has heard from you. hurry and get back to me with your valid receiving data immediately you receive this mail to avoid error procedures because the United N

[PATCH net-next] enic: add sw timestamp support

2017-12-01 Thread Govindarajulu Varadarajan
Add ethtool ops to advertise sw timestamping. Call skb_tx_timestamp() just before ringing the wq doorbell. Signed-off-by: Govindarajulu Varadarajan --- drivers/net/ethernet/cisco/enic/enic_ethtool.c | 12 drivers/net/ethernet/cisco/enic/enic_main.c| 1 + 2 files changed, 13 ins

Re: [PATCH/RFC] Re: 'perf test BPF' failing, libbpf regression wrt "basic API for BPF obj name"

2017-12-01 Thread Alexei Starovoitov
On 12/1/17 9:51 AM, Arnaldo Carvalho de Melo wrote: But this is not just testcase expectations, the usecase is someone wanting to use a newer tool, with perhaps some new features of interest that don't depend on changes in the kernel, in an older kernel on a system where updating it is not possi

Re: [PATCH net-next V3 3/3] net: add a sysctl to make auto flowlabel consistent

2017-12-01 Thread Tom Herbert
On Fri, Dec 1, 2017 at 3:31 PM, Shaohua Li wrote: > From: Shaohua Li > > Currently if there is negative routing, we change sock's txhash, so the > sock will have a different flowlabel and route to different path. > According to Tom, we'd better to have option to enable this, because some > router

Re: [PATCH net-next 1/5] rhashtable: Don't reset walker table in rhashtable_walk_start

2017-12-01 Thread Tom Herbert
On Fri, Dec 1, 2017 at 3:29 PM, Tom Herbert wrote: > On Fri, Dec 1, 2017 at 2:18 PM, Herbert Xu > wrote: >> On Thu, Nov 30, 2017 at 04:03:01PM -0800, Tom Herbert wrote: >>> Remove the code that resets the walker table. The walker table should >>> only be initialized in the walk init function or

pull-request: bpf 2017-12-02

2017-12-01 Thread Daniel Borkmann
Hi David, The following pull-request contains BPF updates for your *net* tree. The main changes are: 1) Fix a compilation warning in xdp redirect tracepoint due to missing bpf.h include that pulls in struct bpf_map, from Xie. 2) Limit the maximum number of attachable BPF progs for a given

Re: [PATCH net-next 0/2] allow setting gso_maximum values

2017-12-01 Thread Solio Sarabia
On Fri, Dec 01, 2017 at 03:30:01PM -0800, Stephen Hemminger wrote: > On Fri, 1 Dec 2017 12:11:56 -0800 > Stephen Hemminger wrote: > > > This is another way of addressing the GSO maximum performance issues for > > containers on Azure. What happens is that the underlying infrastructure uses > > a

x86 boot broken on -rc1?

2017-12-01 Thread Jakub Kicinski
Hi! I'm hitting these after DaveM pulled rc1 into net-next on my Xeon E5-2630 v4 box. It also happens on linux-next. Did anyone else experience it? (.config attached) [5.003771] WARNING: CPU: 14 PID: 1 at ../arch/x86/events/intel/uncore.c:936 uncore_pci_probe+0x285/0x2b0 [5.007544] Mo

[Patch net-next] net_sched: get rid of rcu_barrier() in tcf_block_put_ext()

2017-12-01 Thread Cong Wang
Both Eric and Paolo noticed the rcu_barrier() we use in tcf_block_put_ext() could be a performance bottleneck when we have lots of filters. Paolo provided the following to demonstrate the issue: tc qdisc add dev lo root htb for I in `seq 1 1000`; do tc class add dev lo parent 1: classid 1

Re: [PATCH net-next] net: dsa: Allow compiling out legacy support

2017-12-01 Thread Florian Fainelli
On 12/01/2017 07:21 AM, Vivien Didelot wrote: > Hi Florian, > > Florian Fainelli writes: > >> +#if IS_ENABLED(CONFIG_NET_DSA_LEGACY) >> /* Legacy driver registration */ >> void register_switch_driver(struct dsa_switch_driver *type); >> void unregister_switch_driver(struct dsa_switch_driver

Re: [PATCH v4 3/8] MIPS: Octeon: Add a global resource manager.

2017-12-01 Thread Philippe Ombredanne
On Fri, Dec 1, 2017 at 9:56 PM, David Daney wrote: > On 12/01/2017 12:41 PM, Philippe Ombredanne wrote: >> >> David, >> >> On Fri, Dec 1, 2017 at 9:01 PM, David Daney >> wrote: >>> >>> On 12/01/2017 11:49 AM, Philippe Ombredanne wrote: David, Greg, On Fri, Dec 1, 2017 at

[PATCH net-next V3 0/3] net: fix flowlabel inconsistency in reset packet

2017-12-01 Thread Shaohua Li
From: Shaohua Li Hi, Please see below tcpdump output: 21:00:48.109122 IP6 (flowlabel 0x43304, hlim 64, next-header TCP (6) payload length: 40) fec0::5054:ff:fe12:3456.55804 > fec0::5054:ff:fe12:3456.: Flags [S], cksum 0x0529 (incorrect -> 0xf56c), seq 3282214508, win 43690, options [mss 6

[PATCH net-next V3 2/3] net-next: copy user configured flowlabel to reset packet

2017-12-01 Thread Shaohua Li
From: Shaohua Li Reset packet doesn't use user configured flowlabel, instead, it always uses 0. This will cause inconsistency for flowlabel. tw sock already records flowlabel info, so we can directly use it. Cc: Martin KaFai Lau Cc: Eric Dumazet Cc: Florent Fourcot Cc: Cong Wang Cc: Tom Herb

[PATCH net-next V3 3/3] net: add a sysctl to make auto flowlabel consistent

2017-12-01 Thread Shaohua Li
From: Shaohua Li Currently if there is negative routing, we change sock's txhash, so the sock will have a different flowlabel and route to different path. According to Tom, we'd better to have option to enable this, because some routers require flowlabel consistent. By default, we maintain consis

[PATCH net-next V3 1/3] net-next: use five-tuple hash for sk_txhash

2017-12-01 Thread Shaohua Li
From: Shaohua Li We are using sk_txhash to calculate flowlabel, but sk_txhash isn't always available, for example, in inet_timewait_sock. This causes problem for reset packet, which will have a different flowlabel. This causes our router doesn't correctly close tcp connection. We are using flowla

Re: [PATCH net-next 0/2] allow setting gso_maximum values

2017-12-01 Thread Stephen Hemminger
On Fri, 1 Dec 2017 12:11:56 -0800 Stephen Hemminger wrote: > This is another way of addressing the GSO maximum performance issues for > containers on Azure. What happens is that the underlying infrastructure uses > a overlay network such that GSO packets over 64K - vlan header end up cause > eit

Re: [PATCH v5 net-next,mips 1/7] dt-bindings: Add Cavium Octeon Common Ethernet Interface.

2017-12-01 Thread Florian Fainelli
On 12/01/2017 03:18 PM, David Daney wrote: > From: Carlos Munoz > > Add bindings for Common Ethernet Interface (BGX) block. > > Acked-by: Rob Herring > Signed-off-by: Carlos Munoz > Signed-off-by: Steven J. Hill > Signed-off-by: David Daney Reviewed-by: Florian Fainelli -- Florian

[PATCH net] Revert "tcp: must block bh in __inet_twsk_hashdance()"

2017-12-01 Thread Eric Dumazet
From: Eric Dumazet We had to disable BH _before_ calling __inet_twsk_hashdance() in commit cfac7f836a71 ("tcp/dccp: block bh before arming time_wait timer"). This means we can revert 614bdd4d6e61 ("tcp: must block bh in __inet_twsk_hashdance()"). Signed-off-by: Eric Dumazet ---  net/ipv4/inet_

Re: [PATCH net-next 1/5] rhashtable: Don't reset walker table in rhashtable_walk_start

2017-12-01 Thread Tom Herbert
On Fri, Dec 1, 2017 at 2:18 PM, Herbert Xu wrote: > On Thu, Nov 30, 2017 at 04:03:01PM -0800, Tom Herbert wrote: >> Remove the code that resets the walker table. The walker table should >> only be initialized in the walk init function or when a future table is >> encountered. If the walker table i

[PATCH net-next 2/3] bpf: allow disabling tunnel csum for ipv6

2017-12-01 Thread William Tu
Before the patch, BPF_F_ZERO_CSUM_TX can be used only for ipv4 tunnel. With introduction of ip6gretap collect_md mode, the flag should be also supported for ipv6. Signed-off-by: William Tu Cc: Daniel Borkmann --- net/core/filter.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff

[PATCH net-next 0/3] add ip6 gre and gretap collect_md mode

2017-12-01 Thread William Tu
Similar to gre, vxlan, geneve, ipip tunnels, allow ip6gretap tunnels to operate in collect metadata mode. The first patch adds the support to ip6_gre.c. The second patch enables unsetting the csum for ipv6 tunnel, when using bpf_skb_[gs]et_tunnel_key() helpers. Finally, the last patch adds the ip

[PATCH net-next 3/3] samples/bpf: extend test_tunnel_bpf.sh with ip6gre

2017-12-01 Thread William Tu
Extend existing tests for vxlan, gre, geneve, ipip, erspan, to include ip6 gre and gretap tunnel. Signed-off-by: William Tu Cc: Alexei Starovoitov --- samples/bpf/tcbpf2_kern.c | 43 samples/bpf/test_tunnel_bpf.sh | 65 ++

[PATCH net-next 1/3] ip6_gre: add ip6 gre and gretap collect_md mode

2017-12-01 Thread William Tu
Similar to gre, vxlan, geneve, ipip tunnels, allow ip6 gre and gretap tunnels to operate in collect metadata mode. bpf_skb_[gs]et_tunnel_key() helpers can make use of it right away. OVS can use it as well in the future. Signed-off-by: William Tu --- net/ipv6/ip6_gre.c| 105

Re: [PATCH net-next resubmit 2/2] net: phy: remove generic settings for callbacks config_aneg and read_status from drivers

2017-12-01 Thread Florian Fainelli
On 12/01/2017 02:37 PM, Heiner Kallweit wrote: > Am 01.12.2017 um 21:42 schrieb David Miller: >> From: Heiner Kallweit >> Date: Thu, 30 Nov 2017 23:47:52 +0100 >> >>> Remove generic settings for callbacks config_aneg and read_status >>> from drivers. >>> > When re-testing I just figured out that

[PATCH v5 net-next,mips 5/7] MIPS: Octeon: Automatically provision CVMSEG space.

2017-12-01 Thread David Daney
Remove CONFIG_CAVIUM_OCTEON_CVMSEG_SIZE and automatically calculate the amount of CVMSEG space needed. 1st 128-bytes: Use by IOBDMA 2nd 128-bytes: Reserved by kernel for scratch/TLS emulation. 3rd 128-bytes: OCTEON-III LMTLINE New config variable CONFIG_CAVIUM_OCTEON_EXTRA_CVMSEG provisions addit

[PATCH v5 net-next,mips 2/7] MIPS: Octeon: Enable LMTDMA/LMTST operations.

2017-12-01 Thread David Daney
From: Carlos Munoz LMTDMA/LMTST operations move data between cores and I/O devices: * LMTST operations can send an address and a variable length (up to 128 bytes) of data to an I/O device. * LMTDMA operations can send an address and a variable length (up to 128) of data to the I/O device and

[PATCH v5 net-next,mips 4/7] MIPS: Octeon: Add Free Pointer Unit (FPA) support.

2017-12-01 Thread David Daney
From: Carlos Munoz >From the hardware user manual: "The FPA is a unit that maintains pools of pointers to free L2/DRAM memory. To provide QoS, the pools are referenced indirectly through 1024 auras. Both core software and hardware units allocate and free pointers." Signed-off-by: Carlos Munoz S

[PATCH v5 net-next,mips 3/7] MIPS: Octeon: Add a global resource manager.

2017-12-01 Thread David Daney
From: Carlos Munoz Add a global resource manager to manage tagged pointers within bootmem allocated memory. This is used by various functional blocks in the Octeon core like the FPA, Ethernet nexus, etc. Signed-off-by: Carlos Munoz Signed-off-by: Steven J. Hill Signed-off-by: David Daney ---

[PATCH v5 net-next,mips 7/7] MAINTAINERS: Add entry for drivers/net/ethernet/cavium/octeon/octeon3-*

2017-12-01 Thread David Daney
Signed-off-by: David Daney --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 77d819b458a9..5aff6fb41b21 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -3249,6 +3249,12 @@ W: http://www.cavium.com S: Supported F: drivers/mmc/ho

[PATCH v5 net-next,mips 0/7] Cavium OCTEON-III network driver.

2017-12-01 Thread David Daney
We are adding the Cavium OCTEON-III network driver. But since interacting with the input and output queues is done via special CPU local memory, we also need to add support to the MIPS/Octeon architecture code. Aren't SoCs nice in this way? The first five patches add the SoC support needed by th

[PATCH v5 net-next,mips 1/7] dt-bindings: Add Cavium Octeon Common Ethernet Interface.

2017-12-01 Thread David Daney
From: Carlos Munoz Add bindings for Common Ethernet Interface (BGX) block. Acked-by: Rob Herring Signed-off-by: Carlos Munoz Signed-off-by: Steven J. Hill Signed-off-by: David Daney --- .../devicetree/bindings/net/cavium-bgx.txt | 61 ++ 1 file changed, 61 insert

[PATCH net-next v3 2/8] net: xdp: report flags program was installed with on query

2017-12-01 Thread Jakub Kicinski
Some drivers enforce that flags on program replacement and removal must match the flags passed on install. This leaves the possibility open to enable simultaneous loading of XDP programs both to HW and DRV. Allow such drivers to report the flags back to the stack. Signed-off-by: Jakub Kicinski

[PATCH net-next v3 8/8] net: dummy: remove fake SR-IOV functionality

2017-12-01 Thread Jakub Kicinski
netdevsim driver seems like a better place for fake SR-IOV functionality. Remove the code previously added to dummy. Signed-off-by: Jakub Kicinski Reviewed-by: Quentin Monnet Acked-by: Phil Sutter --- CC: Phil Sutter CC: Sabrina Dubroca --- drivers/net/dummy.c | 215 +--

[PATCH net-next v3 5/8] netdevsim: add bpf offload support

2017-12-01 Thread Jakub Kicinski
Add support for loading programs for netdevsim devices and expose the related information via DebugFS. Both offload of XDP and cls_bpf programs is supported. Signed-off-by: Jakub Kicinski Reviewed-by: Simon Horman Reviewed-by: Quentin Monnet --- drivers/net/netdevsim/Makefile| 1 + driv

[PATCH net-next v3 3/8] net: xdp: make the stack take care of the tear down

2017-12-01 Thread Jakub Kicinski
Since day one of XDP drivers had to remember to free the program on the remove path. This leads to code duplication and is error prone. Make the stack query the installed programs on unregister and if something is installed, remove the program. Freeing of program attached to XDP generic is moved

[PATCH net-next v3 0/8] xdp: make stack perform remove and add selftests

2017-12-01 Thread Jakub Kicinski
Hi! The purpose of this series is to add a software model of BPF offloads to make it easier for everyone to test them and make some of the more arcane rules and assumptions more clear. The series starts with 3 patches aiming to make XDP handling in the drivers less error prone. Currently driver

[PATCH net-next v3 4/8] netdevsim: add software driver for testing offloads

2017-12-01 Thread Jakub Kicinski
To be able to run selftests without any hardware required we need a software model. The model can also serve as an example implementation for those implementing actual HW offloads. The dummy driver have previously been extended to test SR-IOV, but the general consensus seems to be against adding f

[PATCH net-next v3 1/8] net: xdp: avoid output parameters when querying XDP prog

2017-12-01 Thread Jakub Kicinski
The output parameters will get unwieldy if we want to add more information about the program. Simply pass the entire struct netdev_bpf in. Signed-off-by: Jakub Kicinski Reviewed-by: Simon Horman Reviewed-by: Quentin Monnet --- include/linux/netdevice.h | 3 ++- net/core/dev.c| 24

[PATCH net-next v3 6/8] selftests/bpf: add offload test based on netdevsim

2017-12-01 Thread Jakub Kicinski
Add a test of BPF offload control path interfaces based on just-added netdevsim driver. Perform various checks of both the stack and the expected driver behaviour. Signed-off-by: Jakub Kicinski Reviewed-by: Simon Horman Reviewed-by: Quentin Monnet --- tools/testing/selftests/bpf/Makefile

[PATCH net-next v3 7/8] netdevsim: add SR-IOV functionality

2017-12-01 Thread Jakub Kicinski
dummy driver was extended with VF-related netdev APIs for testing SR-IOV-related software. netdevsim did not exist back then. Implement SR-IOV functionality in netdevsim. Notable difference is that since netdevsim has no module parameters, we will actually create a device with sriov_numvfs attrib

[PATCH net 1/2] tcp: add tcp_v4_fill_cb()/tcp_v4_restore_cb()

2017-12-01 Thread Eric Dumazet
James Morris reported kernel stack corruption bug [1] while running the SELinux testsuite, and bisected to a recent commit bffa72cf7f9d ("net: sk_buff rbnode reorg") We believe this commit is fine, but exposes an older bug. SELinux code runs from tcp_filter() and might send an ICMP, expecting IP

[PATCH net 0/2] tcp: fix SELinux/Smack corruptions

2017-12-01 Thread Eric Dumazet
James Morris reported kernel stack corruption bug that we tracked back to commit 971f10eca186 ("tcp: better TCP_SKB_CB layout to reduce cache line misses") First patch needs to be backported to kernels >= 3.18, while second patch needs to be backported to kernels >= 4.9, since this was the time wh

[PATCH net 2/2] tcp: use IPCB instead of TCP_SKB_CB in inet_exact_dif_match()

2017-12-01 Thread Eric Dumazet
From: David Ahern After this fix : ("tcp: add tcp_v4_fill_cb()/tcp_v4_restore_cb()"), socket lookups happen while skb->cb[] has not been mangled yet by TCP. Fixes: a04a480d4392 ("net: Require exact match for TCP socket lookups if dif is l3mdev") Signed-off-by: David Ahern Signed-off-by: Eric D

[PATCH iproute2 net-next] gre6: add collect metadata support

2017-12-01 Thread William Tu
The patch adds 'external' option to support collect metadata gre6 tunnel. Example of L3 and L2 gre device: bash:~# ip link add dev ip6gre123 type ip6gre external bash:~# ip link add dev ip6gretap123 type ip6gretap external Signed-off-by: William Tu --- ip/link_gre6.c| 55

Re: [PATCH net-next] openvswitch: do not propagate headroom updates to internal port

2017-12-01 Thread Pravin Shelar
On Thu, Nov 30, 2017 at 6:35 AM, Paolo Abeni wrote: > After commit 3a927bc7cf9d ("ovs: propagate per dp max headroom to > all vports") the need_headroom for the internal vport is updated > accordingly to the max needed headroom in its datapath. > > That avoids the pskb_expand_head() costs when sen

Re: [PATCH net-next 1/5] libbpf: add ability to guess program type based on section name

2017-12-01 Thread Jakub Kicinski
On Fri, 1 Dec 2017 10:22:57 +, Quentin Monnet wrote: > Thanks Roman! > One comment in-line. > > 2017-11-30 13:42 UTC+ ~ Roman Gushchin > > The bpf_prog_load() function will guess program type if it's not > > specified explicitly. This functionality will be used to implement > > loading of

Re: [PATCH net-next resubmit 2/2] net: phy: remove generic settings for callbacks config_aneg and read_status from drivers

2017-12-01 Thread Heiner Kallweit
Am 01.12.2017 um 21:42 schrieb David Miller: > From: Heiner Kallweit > Date: Thu, 30 Nov 2017 23:47:52 +0100 > >> Remove generic settings for callbacks config_aneg and read_status >> from drivers. >> When re-testing I just figured out that in drivers/net/phy/broadcom.c I mistakenly removed three

Re: [PATCH v2 net-next 3/4] inet: Add a 2nd listener hashtable (port+addr)

2017-12-01 Thread Eric Dumazet
On Fri, 2017-12-01 at 12:52 -0800, Martin KaFai Lau wrote: > The current listener hashtable is hashed by port only. > When a process is listening at many IP addresses with the same port > (e.g. > [IP1]:443, [IP2]:443... [IPN]:443), the inet[6]_lookup_listener() > performance is degraded to a link l

Re: [PATCH net-next 1/5] rhashtable: Don't reset walker table in rhashtable_walk_start

2017-12-01 Thread Herbert Xu
On Thu, Nov 30, 2017 at 04:03:01PM -0800, Tom Herbert wrote: > Remove the code that resets the walker table. The walker table should > only be initialized in the walk init function or when a future table is > encountered. If the walker table is NULL this is the indication that > the walk has comple

Re: [PATCH net-next v2 7/8] netdevsim: add SR-IOV functionality

2017-12-01 Thread Jakub Kicinski
On Fri, 1 Dec 2017 22:58:29 +0100, Phil Sutter wrote: > > > > > > + ret = count; > > > > > > +exit_unlock: > > > > > > + rtnl_unlock(); > > > > > > + > > > > > > + return ret; > > > > > > +} > > > > > > > > > > [...] > > > > > > > > > > > +static void nsim_free(struct net_device *

Re: [RFC PATCH] net_sched: bulk free tcf_block

2017-12-01 Thread Cong Wang
On Fri, Dec 1, 2017 at 3:05 AM, Paolo Abeni wrote: > > Thank you for the feedback. > > I tested your patch and in the above scenario I measure: > > real0m0.017s > user0m0.000s > sys 0m0.017s > > so it apparently works well for this case. Thanks a lot for testing it! I will test it fur

Re: [PATCH net-next v2 7/8] netdevsim: add SR-IOV functionality

2017-12-01 Thread Phil Sutter
On Fri, Dec 01, 2017 at 01:45:09PM -0800, Jakub Kicinski wrote: > On Fri, 1 Dec 2017 22:36:52 +0100, Phil Sutter wrote: > > On Fri, Dec 01, 2017 at 12:14:07PM -0800, Jakub Kicinski wrote: > > > On Fri, 1 Dec 2017 14:43:06 +0100, Phil Sutter wrote: > > > > On Thu, Nov 30, 2017 at 05:35:39PM -0800,

Re: [Patch net-next] act_mirred: use tcfm_dev in tcf_mirred_get_dev()

2017-12-01 Thread Cong Wang
On Fri, Dec 1, 2017 at 9:56 AM, Jiri Pirko wrote: > > Isn't this here so user may specify a ifindex of netdev which is not yet > present on the system (not sure how much sense that would make though...) How is this even possible? If an ifindex is not present, we return ENODEV: if (parm->

Re: [PATCH net-next v2 7/8] netdevsim: add SR-IOV functionality

2017-12-01 Thread Jakub Kicinski
On Fri, 1 Dec 2017 22:36:52 +0100, Phil Sutter wrote: > On Fri, Dec 01, 2017 at 12:14:07PM -0800, Jakub Kicinski wrote: > > On Fri, 1 Dec 2017 14:43:06 +0100, Phil Sutter wrote: > > > On Thu, Nov 30, 2017 at 05:35:39PM -0800, Jakub Kicinski wrote: > > > [...] > > > > +static int nsim_vfs_enable

Re: [PATCH net-next v2 8/8] net: dummy: remove fake SR-IOV functionality

2017-12-01 Thread Phil Sutter
On Fri, Dec 01, 2017 at 12:19:52PM -0800, Jakub Kicinski wrote: > On Fri, 1 Dec 2017 14:46:34 +0100, Phil Sutter wrote: > > On Thu, Nov 30, 2017 at 05:35:40PM -0800, Jakub Kicinski wrote: > > > netdevsim driver seems like a better place for fake SR-IOV > > > functionality. Remove the code previous

Re: [PATCH net-next v2 7/8] netdevsim: add SR-IOV functionality

2017-12-01 Thread Phil Sutter
On Fri, Dec 01, 2017 at 12:14:07PM -0800, Jakub Kicinski wrote: > On Fri, 1 Dec 2017 14:43:06 +0100, Phil Sutter wrote: > > On Thu, Nov 30, 2017 at 05:35:39PM -0800, Jakub Kicinski wrote: > > [...] > > > +static int nsim_vfs_enable(struct netdevsim *ns, unsigned int num_vfs) > > > +{ > > > + ns->vf

Re: [PATCH net-next 00/11] net: ethernet: ti: cpsw/ale clean up and optimization

2017-12-01 Thread David Miller
From: Grygorii Strashko Date: Thu, 30 Nov 2017 18:21:09 -0600 > This is set of non critical clean ups and optimizations for TI > CPSW and ALE drivers. > > Rebased on top on net-next. Series applied, thank you.

Re: netfilter: xt_bpf: Fix XT_BPF_MODE_FD_PINNED mode of 'xt_bpf_info_v1'

2017-12-01 Thread Daniel Borkmann
On 12/01/2017 04:48 AM, Al Viro wrote: > On Fri, Dec 01, 2017 at 01:33:04AM +, Al Viro wrote: > >> Use of file descriptors should be limited to "got a number from userland, >> convert to struct file *" on the way in and "install struct file * into >> descriptor table and return the descriptor

Re: [PATCH net-next V2 1/2] net-next: use five-tuple hash for sk_txhash

2017-12-01 Thread Tom Herbert
On Fri, Dec 1, 2017 at 1:00 PM, Shaohua Li wrote: > From: Shaohua Li > > We are using sk_txhash to calculate flowlabel, but sk_txhash isn't > always available, for example, in inet_timewait_sock. This causes > problem for reset packet, which will have a different flowlabel. This > causes our rout

[PATCH net-next V2 2/2] net-next: copy user configured flowlabel to reset packet

2017-12-01 Thread Shaohua Li
From: Shaohua Li Reset packet doesn't use user configured flowlabel, instead, it always uses 0. This will cause inconsistency for flowlabel. tw sock already records flowlabel info, so we can directly use it. Cc: Martin KaFai Lau Cc: Eric Dumazet Cc: Florent Fourcot Cc: Cong Wang Cc: Tom Herb

[PATCH net-next V2 1/2] net-next: use five-tuple hash for sk_txhash

2017-12-01 Thread Shaohua Li
From: Shaohua Li We are using sk_txhash to calculate flowlabel, but sk_txhash isn't always available, for example, in inet_timewait_sock. This causes problem for reset packet, which will have a different flowlabel. This causes our router doesn't correctly close tcp connection. We are using flowla

[PATCH net-next V2 0/2] net: fix flowlabel inconsistency in reset packet

2017-12-01 Thread Shaohua Li
From: Shaohua Li Hi, Please see below tcpdump output: 21:00:48.109122 IP6 (flowlabel 0x43304, hlim 64, next-header TCP (6) payload length: 40) fec0::5054:ff:fe12:3456.55804 > fec0::5054:ff:fe12:3456.: Flags [S], cksum 0x0529 (incorrect -> 0xf56c), seq 3282214508, win 43690, options [mss 6

Re: [PATCH v4 3/8] MIPS: Octeon: Add a global resource manager.

2017-12-01 Thread David Daney
On 12/01/2017 12:41 PM, Philippe Ombredanne wrote: David, On Fri, Dec 1, 2017 at 9:01 PM, David Daney wrote: On 12/01/2017 11:49 AM, Philippe Ombredanne wrote: David, Greg, On Fri, Dec 1, 2017 at 6:42 PM, David Daney wrote: On 11/30/2017 11:53 PM, Philippe Ombredanne wrote: [...] ---

[PATCH v2 net-next 0/4] tcp: Add a 2nd listener hashtable (port+addr)

2017-12-01 Thread Martin KaFai Lau
This patch set adds a 2nd listener hashtable. It is to resolve the performance issue when a process is listening at many IP addresses with the same port (e.g. [IP1]:443, [IP2]:443... [IPN]:443) v2: - Move the new lhash2 and lhash2_mask before the existing listening_hash to avoid adding another

[PATCH v2 net-next 2/4] udp: Move udp[46]_portaddr_hash() to net/ip[v6].h

2017-12-01 Thread Martin KaFai Lau
This patch moves the udp[46]_portaddr_hash() to net/ip[v6].h. The function name is renamed to ipv[46]_portaddr_hash(). It will be used by a later patch which adds a second listener hashtable hashed by the address and port. Signed-off-by: Martin KaFai Lau Reviewed-by: Eric Dumazet --- include/

[PATCH v2 net-next 3/4] inet: Add a 2nd listener hashtable (port+addr)

2017-12-01 Thread Martin KaFai Lau
The current listener hashtable is hashed by port only. When a process is listening at many IP addresses with the same port (e.g. [IP1]:443, [IP2]:443... [IPN]:443), the inet[6]_lookup_listener() performance is degraded to a link list. It is prone to syn attack. UDP had a similar issue and a secon

[PATCH v2 net-next 4/4] tcp: Enable 2nd listener hashtable in TCP

2017-12-01 Thread Martin KaFai Lau
Enable the second listener hashtable in TCP. The scale is the same as UDP which is one slot per 2MB. Signed-off-by: Martin KaFai Lau Reviewed-by: Eric Dumazet --- net/ipv4/tcp.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/net/ipv4/tcp.c b/net/ipv4/tcp.c index bf97317e6c97..1803116360

[PATCH v2 net-next 1/4] inet: Add a count to struct inet_listen_hashbucket

2017-12-01 Thread Martin KaFai Lau
This patch adds a count to the 'struct inet_listen_hashbucket'. It counts how many sk is hashed to a bucket. It will be used to decide if the (to-be-added) portaddr listener's hashtable should be used during inet[6]_lookup_listener(). Signed-off-by: Martin KaFai Lau Reviewed-by: Eric Dumazet --

Re: [PATCH net] tcp/dccp: block bh before arming time_wait timer

2017-12-01 Thread Eric Dumazet
On Fri, 2017-12-01 at 15:12 -0500, David Miller wrote: > From: Eric Dumazet > Date: Fri, 01 Dec 2017 10:06:56 -0800 > > > From: Eric Dumazet > >  > > Maciej Żenczykowski reported some panics in tcp_twsk_destructor() > > that might be caused by the following bug. > >  > > timewait timer is pinned

Re: netfilter: xt_bpf: Fix XT_BPF_MODE_FD_PINNED mode of 'xt_bpf_info_v1'

2017-12-01 Thread Daniel Borkmann
On 12/01/2017 06:39 PM, Al Viro wrote: [...] > If that does not scream "wrong or missing primitive", I don't know what would. > You want something along the lines of "create a filesystem object at given > location, calling this function with this argument for actual object > creation"? > Fair enou

Re: [PATCH net-next resubmit 2/2] net: phy: remove generic settings for callbacks config_aneg and read_status from drivers

2017-12-01 Thread David Miller
From: Heiner Kallweit Date: Thu, 30 Nov 2017 23:47:52 +0100 > Remove generic settings for callbacks config_aneg and read_status > from drivers. > > Signed-off-by: Heiner Kallweit > Reviewed-by: Florian Fainelli Applied.

Re: [PATCH net-next resubmit 1/2] net: phy: core: use genphy version of callbacks read_status and config_aneg per default

2017-12-01 Thread David Miller
From: Heiner Kallweit Date: Thu, 30 Nov 2017 23:46:19 +0100 > read_status and config_aneg are the only mandatory callbacks and most > of the time the generic implementation is used by drivers. > So make the core fall back to the generic version if a driver doesn't > implement the respective callb

Re: [PATCH v4 3/8] MIPS: Octeon: Add a global resource manager.

2017-12-01 Thread Philippe Ombredanne
David, On Fri, Dec 1, 2017 at 9:01 PM, David Daney wrote: > On 12/01/2017 11:49 AM, Philippe Ombredanne wrote: >> >> David, Greg, >> >> On Fri, Dec 1, 2017 at 6:42 PM, David Daney >> wrote: >>> >>> On 11/30/2017 11:53 PM, Philippe Ombredanne wrote: >> >> [...] >> >> --- /dev/null >>

Re: [PATCH v5 net-next 0/3] ip6_gre: add erspan native tunnel for ipv6

2017-12-01 Thread David Miller
From: William Tu Date: Thu, 30 Nov 2017 11:51:26 -0800 > The patch series add support for ERSPAN tunnel over ipv6. The first patch > refectors the existing ipv4 gre implementation and the second refactors the > ipv6 gre's xmit code. Finally the last patch introduces erspan protocol. Series app

Re: [PATCH RFC 2/2] veth: propagate bridge GSO to peer

2017-12-01 Thread Stephen Hemminger
On Mon, 27 Nov 2017 19:02:01 -0700 David Ahern wrote: > On 11/27/17 6:42 PM, Solio Sarabia wrote: > > On Mon, Nov 27, 2017 at 01:15:02PM -0800, Stephen Hemminger wrote: > >> On Mon, 27 Nov 2017 12:14:19 -0800 > >> Solio Sarabia wrote: > >> > >>> On Sun, Nov 26, 2017 at 11:07:25PM -0800, Step

Re: [PATCH 0/2] net: ethtool: add support for ETH_RESET_AP

2017-12-01 Thread David Miller
From: Scott Branden Date: Thu, 30 Nov 2017 11:35:58 -0800 > Add support to reset appplication processors inside SmartNICs by > defining new ETH_RESET_AP bit. > > And use new ETH_RESET_AP bit in bnxt ethernet driver. Looks good, series applied, thanks!

Re: [PATCH net-next 0/3] rds-tcp netns delete related fixes

2017-12-01 Thread David Miller
From: Sowmini Varadhan Date: Thu, 30 Nov 2017 11:11:26 -0800 > Patchset contains cleanup and bug fixes. Patch 1 is the removal > of some redundant code/functions. Patch 2 and 3 are fixes for > corner cases identified by syzkaller. I've not been able to > reproduce the actual use-after-free race

Re: [net-next 1/1] tipc: fall back to smaller MTU if allocation of local send skb fails

2017-12-01 Thread David Miller
From: Jon Maloy Date: Thu, 30 Nov 2017 16:47:25 +0100 > When sending node local messages the code is using an 'mtu' of 66060 > bytes to avoid unnecessary fragmentation. During situations of low > memory tipc_msg_build() may sometimes fail to allocate such large > buffers, resulting in unnecessary

Re: [PATCH net-next v2 8/8] net: dummy: remove fake SR-IOV functionality

2017-12-01 Thread Jakub Kicinski
On Fri, 1 Dec 2017 14:46:34 +0100, Phil Sutter wrote: > On Thu, Nov 30, 2017 at 05:35:40PM -0800, Jakub Kicinski wrote: > > netdevsim driver seems like a better place for fake SR-IOV > > functionality. Remove the code previously added to dummy. > > > > Signed-off-by: Jakub Kicinski > > Reviewed-

Re: [PATCH 0/4] SFP/phylink fixes

2017-12-01 Thread David Miller
From: Russell King - ARM Linux Date: Thu, 30 Nov 2017 13:58:35 + > Here are four phylink fixes: > - the "options" is a big-endian value, we must test the bits taking the > endian-ness into account. > - improve the handling of RX_LOS polarity, taking no RX_LOS polarity > bits set to mean t

Re: [PATCH] net: phy-micrel: check return code in flp center function

2017-12-01 Thread David Miller
From: Max Uvarov Date: Thu, 30 Nov 2017 13:08:29 +0300 > Fix obvious typo that first return value is set but not checked. > > Signed-off-by: Max Uvarov Applied, thank you.

Re: [PATCH net v2] tipc: call tipc_rcv() only if bearer is up in tipc_udp_recv()

2017-12-01 Thread David Miller
From: Tommi Rantala Date: Wed, 29 Nov 2017 12:48:42 +0200 > Remove the second tipc_rcv() call in tipc_udp_recv(). We have just > checked that the bearer is not up, and calling tipc_rcv() with a bearer > that is not up leads to a TIPC div-by-zero crash in > tipc_node_calculate_timer(). The crash i

Re: [RFC] virtio-net: help live migrate SR-IOV devices

2017-12-01 Thread Shannon Nelson
On 11/30/2017 6:11 AM, Michael S. Tsirkin wrote: On Thu, Nov 30, 2017 at 10:08:45AM +0200, achiad shochat wrote: Re. problem #2: Indeed the best way to address it seems to be to enslave the VF driver netdev under a persistent anchor netdev. And it's indeed desired to allow (but not enforce) PV n

Re: [PATCH net-next v2 7/8] netdevsim: add SR-IOV functionality

2017-12-01 Thread Jakub Kicinski
On Fri, 1 Dec 2017 14:43:06 +0100, Phil Sutter wrote: > On Thu, Nov 30, 2017 at 05:35:39PM -0800, Jakub Kicinski wrote: > [...] > > +static int nsim_vfs_enable(struct netdevsim *ns, unsigned int num_vfs) > > +{ > > + ns->vfconfigs = kcalloc(num_vfs, sizeof(struct nsim_vf_config), > > +

Re: netfilter: xt_bpf: Fix XT_BPF_MODE_FD_PINNED mode of 'xt_bpf_info_v1'

2017-12-01 Thread Daniel Borkmann
On 12/01/2017 07:28 PM, Linus Torvalds wrote: > [ Sorry for HTML email crud - traveling and on mobile right now ] > > On Nov 30, 2017 23:54, "Al Viro" wrote: > > Would cause problems for tracepoints in there, though. And that, BTW, > is precisely why I don't want tracepoints in core VFS, TYVM -

[PATCH iproute2 net-next] iplink: allow configuring GSO max values

2017-12-01 Thread Stephen Hemminger
This allows sending GSO maximum values when configuring a device. The values are advisory. Most devices will ignore them but for some pseudo devices such as veth pairs they can be set. Example: # ip link add dev vm1 type veth peer name vm2 gso_max_size 32768 Signed-off-by: Stephen Hemming

Re: [PATCH net] tcp/dccp: block bh before arming time_wait timer

2017-12-01 Thread David Miller
From: Eric Dumazet Date: Fri, 01 Dec 2017 10:06:56 -0800 > From: Eric Dumazet > > Maciej Żenczykowski reported some panics in tcp_twsk_destructor() > that might be caused by the following bug. > > timewait timer is pinned to the cpu, because we want to transition > timwewait refcount from 0 to

[PATCH net-next 1/2] rtnetlink: allow GSO maximums to be passed to device

2017-12-01 Thread Stephen Hemminger
Allow GSO maximum segments and size as netlink parameters on input. Signed-off-by: Stephen Hemminger --- net/core/rtnetlink.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c index dabba2a91fc8..8138194c5f81 100644 --- a/net/core/rtnetlink.c +++ b

[PATCH net-next 2/2] veth: allow configuring GSO maximums

2017-12-01 Thread Stephen Hemminger
Veth's can be used in environments (like Azure) where the underlying network device is impacted by large GSO packets. This patch allows gso maximum values to be passed in when creating the device via netlink. In theory, other pseudo devices could also use netlink attributes to set GSO maximums but

[PATCH net-next 0/2] allow setting gso_maximum values

2017-12-01 Thread Stephen Hemminger
This is another way of addressing the GSO maximum performance issues for containers on Azure. What happens is that the underlying infrastructure uses a overlay network such that GSO packets over 64K - vlan header end up cause either guest or host to have do expensive software copy and fragmentation

Re: [PATCH net-next 00/13] nfp: bpf: jump resolution and memcpy update

2017-12-01 Thread Daniel Borkmann
On 12/01/2017 06:32 AM, Jakub Kicinski wrote: > Hi! > > Jiong says: > > Currently, compiler will lower memcpy function call in XDP/eBPF C program > into a sequence of eBPF load/store pairs for some scenarios. > > Compiler is thinking this "inline" optimiation is beneficial as it could > avoid fu

Re: [PATCH v4 3/8] MIPS: Octeon: Add a global resource manager.

2017-12-01 Thread David Daney
On 12/01/2017 11:49 AM, Philippe Ombredanne wrote: David, Greg, On Fri, Dec 1, 2017 at 6:42 PM, David Daney wrote: On 11/30/2017 11:53 PM, Philippe Ombredanne wrote: [...] --- /dev/null +++ b/arch/mips/cavium-octeon/resource-mgr.c @@ -0,0 +1,371 @@ +// SPDX-License-Identifier: GPL-2.0 +/* +

Re: [PATCH iproute2] iproute2: Fix undeclared __kernel_long_t type build error in RHEL 6.8

2017-12-01 Thread Michal Kubecek
On Fri, Dec 01, 2017 at 08:48:07AM -0800, Stephen Hemminger wrote: > On Fri, 1 Dec 2017 13:04:51 +0200 > Leon Romanovsky wrote: > > > From: Leon Romanovsky > > > > Add asm/posix_types.h header file to the list of needed includes, > > because the headers files in RHEL 6.8 are too old and doesn'

[PATCH tip/core/rcu 14/21] netfilter: Remove now-redundant smp_read_barrier_depends()

2017-12-01 Thread Paul E. McKenney
READ_ONCE() now implies smp_read_barrier_depends(), which means that the instances in arpt_do_table(), ipt_do_table(), and ip6t_do_table() are now redundant. This commit removes them and adjusts the comments. Signed-off-by: Paul E. McKenney Cc: Pablo Neira Ayuso Cc: Jozsef Kadlecsik Cc: Floria

  1   2   3   >