Re: [PATCH net-next 01/12] sctp: add stream interleave enable members and sockopt

2017-12-05 Thread Neil Horman
On Tue, Dec 05, 2017 at 11:15:58PM +0800, Xin Long wrote: > This patch adds intl_enable in asoc and netns, and strm_interleave in > sctp_sock to indicate if stream interleave is enabled and supported. > > netns intl_enable would be set via procfs, but that is not added yet > until all stream inter

Re: [PATCH tip/core/rcu 21/21] drivers/vhost: Remove now-redundant read_barrier_depends()

2017-12-05 Thread Michael S. Tsirkin
On Fri, Dec 01, 2017 at 11:51:16AM -0800, Paul E. McKenney wrote: > Because READ_ONCE() now implies read_barrier_depends(), the > read_barrier_depends() in next_desc() is now redundant. This commit > therefore removes it and the related comments. > > Signed-off-by: Paul E. McKenney > Cc: "Michae

Re: [PATCH net-next 07/12] sctp: implement ulpevent_data for sctp_stream_interleave

2017-12-05 Thread Neil Horman
On Tue, Dec 05, 2017 at 11:16:04PM +0800, Xin Long wrote: > ulpevent_data is added as a member of sctp_stream_interleave, used to > do the most process in ulpq, including to convert data or idata chunk > to event, reasm them in reasm queue and put them in lobby queue in > right order, and deliver t

Re: [PATCH net 1/2] netlink: add NLA_U8_BUGGY attribute type

2017-12-05 Thread David Ahern
On 12/5/17 10:40 AM, David Miller wrote: > From: Johannes Berg > Date: Tue, 05 Dec 2017 18:30:10 +0100 > >> On Tue, 2017-12-05 at 11:41 -0500, David Miller wrote: >>> >>> There is no reasonable interpretation for what that application is >>> doing, so I think we can safely call that case as buggy

Re: [Intel-wired-lan] [next-queue 08/10] ixgbe: process the Tx ipsec offload

2017-12-05 Thread Alexander Duyck
On Mon, Dec 4, 2017 at 9:35 PM, Shannon Nelson wrote: > If the skb has a security association referenced in the skb, then > set up the Tx descriptor with the ipsec offload bits. While we're > here, we fix an oddly named field in the context descriptor struct. > > Signed-off-by: Shannon Nelson >

Re: [PATCH net-next 2/4] bnxt_en: Use NETIF_F_GRO_HW.

2017-12-05 Thread Marcelo Ricardo Leitner
On Mon, Dec 04, 2017 at 04:07:15PM -0800, Michael Chan wrote: > As already pointed out, GRO_HW is a subset of GRO. Packets that > cannot be aggregated in hardware (due to hardware resource limitations > or protocol types that it doesn't handle) can just be passed to the > stack for GRO aggregation

Re: [PATCH net-next v3 2/4] phylib: add reset after clk enable support

2017-12-05 Thread Richard Leitner
Hi Andrew, On 12/05/2017 06:34 PM, Andrew Lunn wrote: On Tue, Dec 05, 2017 at 02:25:58PM +0100, Richard Leitner wrote: From: Richard Leitner Some PHYs need the refclk to be a continuous clock. Therefore they don't allow turning it off and on again during operation. Nonetheless such a clock sw

Re: [PATCH net-next v3 1/4] phylib: Add device reset delay support

2017-12-05 Thread Richard Leitner
Hi Andrew, On 12/05/2017 06:28 PM, Andrew Lunn wrote: Hi Richard +++ b/drivers/of/of_mdio.c @@ -77,6 +77,14 @@ static int of_mdiobus_register_phy(struct mii_bus *mdio, if (of_property_read_bool(child, "broken-turn-around")) mdio->phy_ignore_ta_mask |= 1 << addr; + if

Re: [RFC PATCH] net: stmmac: enable EEE in MII, GMII or RGMII only

2017-12-05 Thread Andrew Lunn
> bool stmmac_eee_init(struct stmmac_priv *priv) > { > struct net_device *ndev = priv->dev; > + int interface = priv->plat->interface; > unsigned long flags; > bool ret = false; > > + if ((interface != PHY_INTERFACE_MODE_MII) && > + (interface != PHY_INTERFACE_

Re: [PATCH net-next] net: phy: meson-gxl: cleanup by defining the control registers

2017-12-05 Thread Andrew Lunn
On Tue, Dec 05, 2017 at 10:33:34AM +0100, Jerome Brunet wrote: > From: Neil Armstrong > > Define registers and bits in meson-gxl PHY driver to make a bit > more human friendly. No functional change > static int meson_gxl_config_init(struct phy_device *phydev) > { > - /* Enable Analog and

Re: [PATCH v2] net: sh_eth: do not advertise Gigabit capabilities when not available

2017-12-05 Thread Andrew Lunn
On Tue, Dec 05, 2017 at 10:29:52AM +0100, Thomas Petazzoni wrote: > Not all variants of the sh_eth hardware have Gigabit > support. Unfortunately, the current driver doesn't tell the PHY about > the limited MAC capabilities. Due to this, if you have a Gigabit > capable PHY, the PHY will advertise i

Re: [PATCH v4 0/4] Teach phylib hard-resetting devices

2017-12-05 Thread David Miller
From: Geert Uytterhoeven Date: Mon, 4 Dec 2017 11:34:48 +0100 > This patch series adds optional PHY reset support to phylib. Patch #1 and #2 applied to net-next, using v4.1 of patch #1. Thanks.

Re: [PATCH net 1/2] netlink: add NLA_U8_BUGGY attribute type

2017-12-05 Thread David Miller
From: Johannes Berg Date: Tue, 05 Dec 2017 18:30:10 +0100 > On Tue, 2017-12-05 at 11:41 -0500, David Miller wrote: >> >> There is no reasonable interpretation for what that application is >> doing, so I think we can safely call that case as buggy. >> >> We are only trying to handle the situatio

Re: [Intel-wired-lan] [next-queue 07/10] ixgbe: process the Rx ipsec offload

2017-12-05 Thread Alexander Duyck
On Mon, Dec 4, 2017 at 9:35 PM, Shannon Nelson wrote: > If the chip sees and decrypts an ipsec offload, set up the skb > sp pointer with the ralated SA info. Since the chip is rude > enough to keep to itself the table index it used for the > decryption, we have to do our own table lookup, using t

Re: [PATCH net-next v3 3/4] net: phy: smsc: LAN8710/20: add PHY_RST_AFTER_CLK_EN flag

2017-12-05 Thread Andrew Lunn
On Tue, Dec 05, 2017 at 02:25:59PM +0100, Richard Leitner wrote: > From: Richard Leitner > > The Microchip/SMSC LAN8710/LAN8720 PHYs need (according to their > datasheet [1]) a continuous REF_CLK when configured to "REF_CLK In Mode". > Therefore set the PHY_RST_AFTER_CLK_EN flag for those PHYs to

Re: [PATCH net-next v3 2/4] phylib: add reset after clk enable support

2017-12-05 Thread Andrew Lunn
On Tue, Dec 05, 2017 at 02:25:58PM +0100, Richard Leitner wrote: > From: Richard Leitner > > Some PHYs need the refclk to be a continuous clock. Therefore they don't > allow turning it off and on again during operation. Nonetheless such a > clock switching is performed by some ETH drivers (namely

Re: [PATCH net 1/2] netlink: add NLA_U8_BUGGY attribute type

2017-12-05 Thread Johannes Berg
On Tue, 2017-12-05 at 11:41 -0500, David Miller wrote: > > There is no reasonable interpretation for what that application is > doing, so I think we can safely call that case as buggy. > > We are only trying to handle the situation where a U8 attribute > is presented as a bonafide U32 or a correc

Re: [Intel-wired-lan] [next-queue 06/10] ixgbe: restore offloaded SAs after a reset

2017-12-05 Thread Alexander Duyck
On Mon, Dec 4, 2017 at 9:35 PM, Shannon Nelson wrote: > On a chip reset most of the table contents are lost, so must be > restored. This scans the driver's ipsec tables and restores both > the filled and empty table slots to their pre-reset values. > > Signed-off-by: Shannon Nelson > --- > driv

Re: [PATCH net-next 00/12] sctp: Implement Stream Interleave: The I-DATA Chunk Supporting User Message Interleaving

2017-12-05 Thread Marcelo Ricardo Leitner
On Tue, Dec 05, 2017 at 11:15:57PM +0800, Xin Long wrote: > Stream Interleave would be Implemented in two Parts: >1. The I-DATA Chunk Supporting User Message Interleaving >2. Interaction with Other SCTP Extensions > I have reviewed this patchset a couple of times already before the postin

Re: [PATCH net-next v3 1/4] phylib: Add device reset delay support

2017-12-05 Thread Andrew Lunn
Hi Richard > +++ b/drivers/of/of_mdio.c > @@ -77,6 +77,14 @@ static int of_mdiobus_register_phy(struct mii_bus *mdio, > if (of_property_read_bool(child, "broken-turn-around")) > mdio->phy_ignore_ta_mask |= 1 << addr; > > + if (of_property_read_u32(child, "reset-delay-us",

Re: [PATCH net-next 04/12] sctp: implement make_datafrag for sctp_stream_interleave

2017-12-05 Thread Marcelo Ricardo Leitner
On Tue, Dec 05, 2017 at 11:16:01PM +0800, Xin Long wrote: > To avoid hundreds of checks for the different process on I-DATA chunk, > struct sctp_stream_interleave is defined as a group of functions used > to replace the codes in some place where it needs to do different job > according to if the as

Re: [Intel-wired-lan] [next-queue 05/10] ixgbe: implement ipsec add and remove of offloaded SA

2017-12-05 Thread Alexander Duyck
On Mon, Dec 4, 2017 at 9:35 PM, Shannon Nelson wrote: > Add the functions for setting up and removing offloaded SAs (Security > Associations) with the x540 hardware. We set up the callback structure > but we don't yet set the hardware feature bit to be sure the XFRM service > won't actually try t

Re: [RFC v2 6/6] flow_dissector: Parse batman-adv unicast headers

2017-12-05 Thread Tom Herbert
On Tue, Dec 5, 2017 at 6:35 AM, Sven Eckelmann wrote: > The batman-adv unicast packets contain a full layer 2 frame in encapsulated > form. The flow dissector must therefore be able to parse the batman-adv > unicast header to reach the layer 2+3 information. > > ++ > | ip(v

Re: [PATCH net-next 4/4] qede: Use NETIF_F_GRO_HW.

2017-12-05 Thread Michael Chan
On Tue, Dec 5, 2017 at 4:32 AM, Chopra, Manish wrote: > > Since we are now differentiating HW gro with distinct feature bit, I think we > should consider this feature bit everywhere where driver disables > HW gro internally [not explicitly using ethtool]. This is not just specific > to XDP but

RE: [PATCH net-next 1/8] net: hns3: Add HNS3 VF IMP(Integrated Management Proc) cmd interface

2017-12-05 Thread Salil Mehta
Hi Dave, > -Original Message- > From: David Miller [mailto:da...@davemloft.net] > Sent: Tuesday, December 05, 2017 4:38 PM > To: Salil Mehta > Cc: Zhuangyuzeng (Yisen) ; lipeng (Y) > ; mehta.salil@gmail.com; > netdev@vger.kernel.org; linux-ker...@vger.kernel.org; linux- > r...@vger.ke

Re: [PATCH net-next] flow_dissector: dissect tunnel info outside __skb_flow_dissect()

2017-12-05 Thread David Miller
From: Simon Horman Date: Mon, 4 Dec 2017 11:31:48 +0100 > Move dissection of tunnel info to outside of the main flow dissection > function, __skb_flow_dissect(). The sole user of this feature, the flower > classifier, is updated to call tunnel info dissection directly, using > skb_flow_dissect_t

Re: [Intel-wired-lan] [next-queue 04/10] ixgbe: add ipsec data structures

2017-12-05 Thread Alexander Duyck
On Mon, Dec 4, 2017 at 9:35 PM, Shannon Nelson wrote: > Set up the data structures to be used by the ipsec offload. > > Signed-off-by: Shannon Nelson > --- > drivers/net/ethernet/intel/ixgbe/ixgbe.h | 5 > drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.h | 40 > +++

Re: [PATCH net-next V3] tun: add eBPF based queue selection method

2017-12-05 Thread David Miller
From: Jason Wang Date: Mon, 4 Dec 2017 17:31:23 +0800 > This patch introduces an eBPF based queue selection method. With this, > the policy could be offloaded to userspace completely through a new > ioctl TUNSETSTEERINGEBPF. > > Signed-off-by: Jason Wang > --- > Changes from V2: > - call rtnl

Re: [PATCH v3 net-next] net/tcp: trace all TCP/IP state transition with tcp_set_state tracepoint

2017-12-05 Thread Marcelo Ricardo Leitner
On Tue, Dec 05, 2017 at 02:12:42PM +, Yafang Shao wrote: > The TCP/IP transition from TCP_LISTEN to TCP_SYN_RECV and some other > transitions are not traced with tcp_set_state tracepoint. > > In order to trace the whole tcp lifespans, two helpers are introduced, > void __tcp_set_state(struct s

RE: [PATCH V2 net-next 0/3] net: hns3: Refactors "reset" handling code in HCLGE layer of HNS3 driver

2017-12-05 Thread Salil Mehta
> -Original Message- > From: David Miller [mailto:da...@davemloft.net] > Sent: Tuesday, December 05, 2017 4:49 PM > To: Salil Mehta > Cc: Zhuangyuzeng (Yisen) ; lipeng (Y) > ; mehta.salil@gmail.com; > netdev@vger.kernel.org; linux-ker...@vger.kernel.org; linux- > r...@vger.kernel.org;

Re: [Intel-wired-lan] [next-queue 02/10] ixgbe: add ipsec register access routines

2017-12-05 Thread Alexander Duyck
On Mon, Dec 4, 2017 at 9:35 PM, Shannon Nelson wrote: > Add a few routines to make access to the ipsec registers just a little > easier, and throw in the beginnings of an initialization. > > Signed-off-by: Shannon Nelson > --- > drivers/net/ethernet/intel/ixgbe/Makefile | 1 + > drivers/n

Re: [PATCH net-next 4/6] net: qualcomm: rmnet: Process packets over ethernet

2017-12-05 Thread David Miller
From: Subash Abhinov Kasiviswanathan Date: Sun, 3 Dec 2017 23:37:06 -0700 > Add support to send and receive packets over ethernet. > An example of usage is testing the data path on UML. This can be > achieved by setting up two UML instances in multicast mode and > associating rmnet over the UML

Re: [PATCH net-next 1/6] net: qualcomm: rmnet: Remove the rmnet_map_results enum

2017-12-05 Thread David Miller
From: Subash Abhinov Kasiviswanathan Date: Sun, 3 Dec 2017 23:37:03 -0700 > Only the success and consumed entries were actually in use. > Use standard error codes instead. > > Signed-off-by: Subash Abhinov Kasiviswanathan That is definitely not the only thing this change is doing: > @@ -126,

Re: [PATCH net 1/2] netlink: add NLA_U8_BUGGY attribute type

2017-12-05 Thread David Miller
From: David Ahern Date: Tue, 5 Dec 2017 09:41:21 -0700 > On 12/5/17 9:34 AM, Johannes Berg wrote: >> On Tue, 2017-12-05 at 11:31 -0500, David Miller wrote: >>> We could try to fix up the big endian problem here, but we don't know *how* userspace misbehaved - if using nla_put_u32 th

Re: [PATCH V2 net-next 0/3] net: hns3: Refactors "reset" handling code in HCLGE layer of HNS3 driver

2017-12-05 Thread David Miller
From: Salil Mehta Date: Mon, 4 Dec 2017 01:29:52 + > This patch refactors the code of the reset feature in HCLGE layer > of HNS3 PF driver. Prime motivation to do this change is: > 1. To reduce the time for which common miscellaneous Vector 0 >interrupt is disabled because of the reset.

Re: [PATCH 1/1] gianfar: fix a flooded alignment reports because of padding issue.

2017-12-05 Thread David Miller
From: Zumeng Chen Date: Mon, 4 Dec 2017 11:22:02 +0800 > According to LS1021A RM, the value of PAL can be set so that the start of the > IP header in the receive data buffer is aligned to a 32-bit boundary. > Normally, > setting PAL = 2 provides minimal padding to ensure such alignment of the IP

Re: [PATCH net 1/2] netlink: add NLA_U8_BUGGY attribute type

2017-12-05 Thread David Ahern
On 12/5/17 9:34 AM, Johannes Berg wrote: > On Tue, 2017-12-05 at 11:31 -0500, David Miller wrote: >> >>> We could try to fix up the big endian problem here, but we >>> don't know *how* userspace misbehaved - if using nla_put_u32 >>> then we could, but we also found a debug tool (which we'll >>> ign

Re: [PATCH net 1/2] netlink: add NLA_U8_BUGGY attribute type

2017-12-05 Thread David Miller
From: Johannes Berg Date: Tue, 05 Dec 2017 17:34:21 +0100 > On Tue, 2017-12-05 at 11:31 -0500, David Miller wrote: >> >> > We could try to fix up the big endian problem here, but we >> > don't know *how* userspace misbehaved - if using nla_put_u32 >> > then we could, but we also found a debug to

Re: [PATCH net-next 1/8] net: hns3: Add HNS3 VF IMP(Integrated Management Proc) cmd interface

2017-12-05 Thread David Miller
From: Salil Mehta Date: Sun, 3 Dec 2017 12:33:00 + > +static int hclgevf_ring_space(struct hclgevf_cmq_ring *ring) > +{ > + int ntu = ring->next_to_use; > + int ntc = ring->next_to_clean; > + int used = (ntu - ntc + ring->desc_num) % ring->desc_num; Order local variables from lon

Re: [PATCH net 1/2] netlink: add NLA_U8_BUGGY attribute type

2017-12-05 Thread Johannes Berg
On Tue, 2017-12-05 at 11:31 -0500, David Miller wrote: > > > We could try to fix up the big endian problem here, but we > > don't know *how* userspace misbehaved - if using nla_put_u32 > > then we could, but we also found a debug tool (which we'll > > ignore for the purposes of this regression) th

Re: [PATCH net 1/2] netlink: add NLA_U8_BUGGY attribute type

2017-12-05 Thread David Miller
From: Johannes Berg Date: Sat, 2 Dec 2017 21:23:31 +0100 > From: Johannes Berg > > This netlink type is used only for backwards compatibility > with broken userspace that used the wrong size for a given > u8 attribute, which is now rejected. It would've been wrong > before already, since on bi

Re: [PATCH net] nfp: fix port stats for mac representors

2017-12-05 Thread David Miller
From: Jakub Kicinski Date: Sat, 2 Dec 2017 02:03:31 -0800 > On Fri, Dec 1, 2017 at 9:37 PM, Jakub Kicinski > wrote: >> From: Pieter Jansen van Vuuren >> >> Previously we swapped the tx_packets, tx_bytes and tx_dropped counters >> with rx_packets, rx_bytes and rx_dropped counters, respectively.

Re: [PATCH net] Revert "net: core: maybe return -EEXIST in __dev_alloc_name"

2017-12-05 Thread David Miller
From: Johannes Berg Date: Sat, 2 Dec 2017 08:41:55 +0100 > From: Johannes Berg > > This reverts commit d6f295e9def0; some userspace (in the case > we noticed it's wpa_supplicant), is relying on the current > error code to determine that a fixed name interface already > exists. > > Reported-by

Re: [PATCH v2] net: macb: change GFP_KERNEL to GFP_ATOMIC

2017-12-05 Thread David Miller
From: Julia Lawall Date: Sat, 2 Dec 2017 08:01:21 +0100 (CET) > Function gem_add_flow_filter called on line 2958 inside lock on line 2949 > but uses GFP_KERNEL > > Generated by: scripts/coccinelle/locks/call_kern.cocci > > Fixes: ae8223de3df5 ("net: macb: Added support for RX filtering") > CC:

Re: [PATCH net] Revert "tcp: must block bh in __inet_twsk_hashdance()"

2017-12-05 Thread David Miller
From: Eric Dumazet Date: Fri, 01 Dec 2017 15:28:44 -0800 > From: Eric Dumazet > > We had to disable BH _before_ calling __inet_twsk_hashdance() in commit > cfac7f836a71 ("tcp/dccp: block bh before arming time_wait timer"). > > This means we can revert 614bdd4d6e61 ("tcp: must block bh in > __i

Re: [PATCH net] nfp: fix port stats for mac representors

2017-12-05 Thread David Miller
From: Jakub Kicinski Date: Fri, 1 Dec 2017 21:37:23 -0800 > From: Pieter Jansen van Vuuren > > Previously we swapped the tx_packets, tx_bytes and tx_dropped counters > with rx_packets, rx_bytes and rx_dropped counters, respectively. This > behaviour is correct and expected for VF representors

Re: Linux 4.14 - regression: broken tun/tap / bridge network with virtio - bisected

2017-12-05 Thread Andreas Hartmann
On 12/05/2017 at 04:50 AM Jason Wang wrote: > > > On 2017年12月05日 00:28, Andreas Hartmann wrote: >> On 12/03/2017 at 12:35 PM Andreas Hartmann wrote: >>> On 12/01/2017 at 11:11 AM Andreas Hartmann wrote: Hello! I hopefully could get rid of both of my problems (hanging network w/ >>>

Re: [Intel-wired-lan] [next-queue 02/10] ixgbe: add ipsec register access routines

2017-12-05 Thread Rustad, Mark D
> On Dec 4, 2017, at 9:35 PM, Shannon Nelson wrote: > > Add a few routines to make access to the ipsec registers just a little > easier, and throw in the beginnings of an initialization. > > Signed-off-by: Shannon Nelson > --- > drivers/net/ethernet/intel/ixgbe/Makefile | 1 + > drivers/

Re: [Intel-wired-lan] [next-queue 03/10] ixgbe: add ipsec engine start and stop routines

2017-12-05 Thread Alexander Duyck
On Mon, Dec 4, 2017 at 9:35 PM, Shannon Nelson wrote: > Add in the code for running and stopping the hardware ipsec > encryption/decryption engine. It is good to keep the engine > off when not in use in order to save on the power draw. > > Signed-off-by: Shannon Nelson > --- > drivers/net/ether

Re: [PATCH v3] net: sched: crash on blocks with goto chain action

2017-12-05 Thread David Miller
From: Roman Kapl Date: Wed, 29 Nov 2017 20:20:14 +0100 > tcf_block_put_ext has assumed that all filters (and thus their goto > actions) are destroyed in RCU callback and so can not race with our > list iteration. However, that is not true during netns cleanup (see > tcf_exts_get_net comment). The

Re: [PATCH net-next 00/11] SFP/phylink updates

2017-12-05 Thread David Miller
From: Russell King - ARM Linux Date: Fri, 1 Dec 2017 10:23:07 + > This series, which follows on from the fixes posted earlier, improves > the phylink/sfp support. Changes included here are: ... Series applied, thanks!

Re: [PATCH net-next] rtnetlink: fix rtnl_link msghandler rcu annotations

2017-12-05 Thread David Miller
From: Florian Westphal Date: Mon, 4 Dec 2017 22:42:30 +0100 > Incorrect/missing annotations caused a few sparse warnings: > > rtnetlink.c:155:15: incompatible types .. (different address spaces) > rtnetlink.c:157:23: incompatible types .. (different address spaces) > rtnetlink.c:185:15: incompa

Re: [PATCH net-next V3] tun: add eBPF based queue selection method

2017-12-05 Thread Willem de Bruijn
On Tue, Dec 5, 2017 at 2:29 AM, Jason Wang wrote: > > > On 2017年12月05日 08:16, Willem de Bruijn wrote: >> >> On Mon, Dec 4, 2017 at 4:31 AM, Jason Wang wrote: >>> >>> This patch introduces an eBPF based queue selection method. With this, >>> the policy could be offloaded to userspace completely th

Re: [crypto 4/8] chtls: CPL handler definition

2017-12-05 Thread Hannes Frederic Sowa
Hello, On Tue, Dec 5, 2017, at 12:40, Atul Gupta wrote: > CPL handlers for TLS session, record transmit and receive This does very much looks like full TCP offload with TLS on top? It would be nice if you could give a few more details in the patch descriptions. Bye, Hannes

Re: [PATCH net-next] net: phy: meson-gxl: cleanup by defining the control registers

2017-12-05 Thread Jerome Brunet
On Tue, 2017-12-05 at 23:23 +0800, Yixun Lan wrote: > > +static inline int meson_gxl_write_reg(struct phy_device *phydev, > > + unsigned int bank, unsigned int reg, > > + uint16_t value) > > +{ > > + int ret; > > + > > + /*

Re: [PATCH v2 0/6] bpf: correct broken uapi for BPF_PROG_TYPE_PERF_EVENT program type

2017-12-05 Thread Daniel Borkmann
On 12/04/2017 10:56 AM, Hendrik Brueckner wrote: > Perf tool bpf selftests revealed a broken uapi for s390 and arm64. > With the BPF_PROG_TYPE_PERF_EVENT program type the bpf_perf_event > structure exports the pt_regs structure for all architectures. > > This fails for s390 and arm64 because pt_re

Re: [PATCH 4/7 v2] net: ethernet: i825xx: Fix platform_get_irq's error checking

2017-12-05 Thread David Miller
From: Arvind Yadav Date: Tue, 5 Dec 2017 11:04:55 +0530 > Hi David, > > > On Monday 04 December 2017 11:55 PM, David Miller wrote: >> From: Arvind Yadav >> Date: Mon, 4 Dec 2017 23:18:20 +0530 >> >>> @@ -120,9 +120,10 @@ static int sni_82596_probe(struct platform_device >>> *dev) >>> netd

Re: [PATCH net-next] net: phy: meson-gxl: cleanup by defining the control registers

2017-12-05 Thread Yixun Lan
HI Jerome: On 12/05/17 17:33, Jerome Brunet wrote: > From: Neil Armstrong > > Define registers and bits in meson-gxl PHY driver to make a bit > more human friendly. No functional change > > Signed-off-by: Neil Armstrong > Signed-off-by: Jerome Brunet > --- > drivers/net/phy/meson-gxl.c | 11

Re: Linux ECN Handling

2017-12-05 Thread Neal Cardwell
On Tue, Dec 5, 2017 at 12:22 AM, Steve Ibanez wrote: > Hi Neal, > > Happy to help out :) And thanks for the tip! > > I was able to track down where the missing bytes that you pointed out > are being lost. It turns out the destination host seems to be > misbehaving. I performed a packet capture at

Re: [crypto 4/8] chtls: CPL handler definition

2017-12-05 Thread Stefano Brivio
On Tue, 5 Dec 2017 17:10:00 +0530 Atul Gupta wrote: > CPL handlers for TLS session, record transmit and receive > > Signed-off-by: Atul Gupta > --- > drivers/crypto/chelsio/chtls/chtls_cm.c | 2048 > +++ > 1 file changed, 2048 insertions(+) > create mode 100644 d

[PATCH net-next 12/12] sctp: add support for the process of unordered idata

2017-12-05 Thread Xin Long
Unordered idata process is more complicated than unordered data: - It has to add mid into sctp_stream_out to save the next mid value, which is separated from ordered idata's. - To support pd for unordered idata, another mid and pd_mode need to be added to save the message id and pd state

[PATCH net-next 11/12] sctp: implement abort_pd for sctp_stream_interleave

2017-12-05 Thread Xin Long
abort_pd is added as a member of sctp_stream_interleave, used to abort partial delivery for data or idata, called in sctp_cmd_assoc_failed. Since stream interleave allows to do partial delivery for each stream at the same time, sctp_intl_abort_pd for idata would be very different from the old func

[PATCH net-next 10/12] sctp: implement start_pd for sctp_stream_interleave

2017-12-05 Thread Xin Long
start_pd is added as a member of sctp_stream_interleave, used to do partial_delivery for data or idata when datalen >= asoc->rwnd in sctp_eat_data. The codes have been done in last patches, but they need to be extracted into start_pd, so that it could be used for SCTP_CMD_PART_DELIVER cmd as well.

[PATCH net-next 09/12] sctp: implement renege_events for sctp_stream_interleave

2017-12-05 Thread Xin Long
renege_events is added as a member of sctp_stream_interleave, used to renege some old data or idata in reasm or lobby queue properly to free some memory for the new data when there's memory stress. It defines sctp_renege_events for idata, and leaves sctp_ulpq_renege as it is for data. Signed-off-

[PATCH net-next 08/12] sctp: implement enqueue_event for sctp_stream_interleave

2017-12-05 Thread Xin Long
enqueue_event is added as a member of sctp_stream_interleave, used to enqueue either data, idata or notification events into user socket rx queue. It replaces sctp_ulpq_tail_event used in the other places with enqueue_event. Signed-off-by: Xin Long --- include/net/sctp/stream_interleave.h | 2 +

[PATCH net-next 07/12] sctp: implement ulpevent_data for sctp_stream_interleave

2017-12-05 Thread Xin Long
ulpevent_data is added as a member of sctp_stream_interleave, used to do the most process in ulpq, including to convert data or idata chunk to event, reasm them in reasm queue and put them in lobby queue in right order, and deliver them up to user sk rx queue. This procedure is described in sectio

[PATCH net-next 06/12] sctp: implement validate_data for sctp_stream_interleave

2017-12-05 Thread Xin Long
validate_data is added as a member of sctp_stream_interleave, used to validate ssn/chunk type for data or mid (message id)/chunk type for idata, called in sctp_eat_data. If this check fails, an abort packet will be sent, as says in section 2.2.3 of RFC8260. It also adds the process for idata in r

[PATCH net-next 05/12] sctp: implement assign_number for sctp_stream_interleave

2017-12-05 Thread Xin Long
assign_number is added as a member of sctp_stream_interleave, used to assign ssn for data or mid (message id) for idata, called in sctp_packet_append_data. sctp_chunk_assign_ssn is left as it is, and sctp_chunk_assign_mid is added for sctp_stream_interleave_1. This procedure is described in sectio

[PATCH net-next 00/12] sctp: Implement Stream Interleave: The I-DATA Chunk Supporting User Message Interleaving

2017-12-05 Thread Xin Long
Stream Interleave would be Implemented in two Parts: 1. The I-DATA Chunk Supporting User Message Interleaving 2. Interaction with Other SCTP Extensions Overview in section 1.1 of RFC8260 for Part 1: This document describes a new chunk carrying payload data called I-DATA. This chunk in

[PATCH net-next 04/12] sctp: implement make_datafrag for sctp_stream_interleave

2017-12-05 Thread Xin Long
To avoid hundreds of checks for the different process on I-DATA chunk, struct sctp_stream_interleave is defined as a group of functions used to replace the codes in some place where it needs to do different job according to if the asoc intl_enabled is set. With these ops, it only needs to initiali

[PATCH net-next 01/12] sctp: add stream interleave enable members and sockopt

2017-12-05 Thread Xin Long
This patch adds intl_enable in asoc and netns, and strm_interleave in sctp_sock to indicate if stream interleave is enabled and supported. netns intl_enable would be set via procfs, but that is not added yet until all stream interleave codes are completely implemented; asoc intl_enable will be set

[PATCH net-next 02/12] sctp: add asoc intl_enable negotiation during 4 shakehands

2017-12-05 Thread Xin Long
asoc intl_enable will be set when local sp strm_interleave is set and there's I-DATA chunk in init and init_ack extensions, as says in section 2.2.1 of RFC8260. asoc intl_enable indicates all data will be sent as I-DATA chunks. Signed-off-by: Xin Long --- include/linux/sctp.h | 3 +++ net/

[PATCH net-next 03/12] sctp: add basic structures and make chunk function for idata

2017-12-05 Thread Xin Long
sctp_idatahdr and sctp_idata_chunk are used to define and parse I-DATA chunk format, and sctp_make_idata is a function to build the chunk. The I-DATA Chunk Format is defined in section 2.1 of RFC8260. Signed-off-by: Xin Long --- include/linux/sctp.h | 17 + include/net/sct

Re: [PATCH net-next v3 1/4] phylib: Add device reset delay support

2017-12-05 Thread Richard Leitner
Hi Geert, On 12/05/2017 02:54 PM, Geert Uytterhoeven wrote: > Hi Richard, > > On Tue, Dec 5, 2017 at 2:25 PM, Richard Leitner wrote: >> From: Richard Leitner >> >> Some PHYs need a minimum time after the reset gpio was asserted and/or >> deasserted. To ensure we meet these timing requirements a

Re: [PATCH] bnxt_en: Uninitialized variable in bnxt_tc_parse_actions()

2017-12-05 Thread Dan Carpenter
I'm sorry, I left out that this applies to net-next. regards, dan carpenter

[RFC v2 0/6] flow_dissector: Provide basic batman-adv unicast handling

2017-12-05 Thread Sven Eckelmann
Hi, we are currently starting to use batman-adv as mesh protocol on multicore embedded devices. These usually don't have a lot of CPU power per core but are reasonable fast when using multiple cores. It was noticed that sending was working very well but receiving was basically only using on CPU c

[PATCH] bnxt_en: Uninitialized variable in bnxt_tc_parse_actions()

2017-12-05 Thread Dan Carpenter
Smatch warns that: drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c:160 bnxt_tc_parse_actions() error: uninitialized symbol 'rc'. "rc" is either uninitialized or set to zero here so we can just remove the check. Fixes: 8c95f773b4a3 ("bnxt_en: add support for Flower based vxlan encap/decap o

[RFC v2 2/6] batman-adv: Rename batman-adv.h to batadv_genl.h

2017-12-05 Thread Sven Eckelmann
This file contains the relevant information to let userspace communicate with batman-adv over generic netlink. The relevant genl enums for the attributes and commands have the prefix batadv_genl. Renaming this file to this name therefore represents the content better and avoids confusion with the f

[RFC v2 3/6] batman-adv: Let packet.h include its headers directly

2017-12-05 Thread Sven Eckelmann
The headers used by packet.h should also be included by it directly. main.h is currently dealing with it in batman-adv, but this will no longer work when this header is moved to include/uapi/linux/. Signed-off-by: Sven Eckelmann --- net/batman-adv/main.h | 2 -- net/batman-adv/packet.h | 2 ++

[RFC v2 4/6] batman-adv: Remove usage of BIT(x) in packet.h

2017-12-05 Thread Sven Eckelmann
The BIT(x) macro is no longer available for uapi headers because it is defined outside of it (linux/bitops.h). The use of it must therefore be avoided and replaced by an appropriate other representation. Signed-off-by: Sven Eckelmann --- net/batman-adv/packet.h | 23 +++ 1 fi

[RFC v2 5/6] batman-adv: Convert packet.h to uapi header

2017-12-05 Thread Sven Eckelmann
The header file is used by different userspace programs to inject packets or to decode sniffed packets. It should therefore be available to them as userspace header. Also other components in the kernel (like the flow dissector) require access to the packet definitions to be able to decode ETH_P_BA

[RFC v2 6/6] flow_dissector: Parse batman-adv unicast headers

2017-12-05 Thread Sven Eckelmann
The batman-adv unicast packets contain a full layer 2 frame in encapsulated form. The flow dissector must therefore be able to parse the batman-adv unicast header to reach the layer 2+3 information. ++ | ip(v6)hdr | ++ | inner ethhdr |

[RFC v2 1/6] batman-adv: Change nl references to genl

2017-12-05 Thread Sven Eckelmann
The batman-adv netlink functionality is actually not pure netlink but is using NETLINK_GENERIC and related API. The code should therefore also use this "genl" instead of "nl" to make this more clear. Signed-off-by: Sven Eckelmann --- include/uapi/linux/batman_adv.h | 14 +++--- net/batma

Re: b1cbacc866 ("x86/smpboot: Do not use smp_num_siblings in .."): divide error: 0000 [#1] SMP DEBUG_PAGEALLOC

2017-12-05 Thread Prarit Bhargava
>[0.029102] Hierarchical SRCU implementation. >[0.030040] smp: Bringing up secondary CPUs ... >[0.030528] smp: Brought up 1 node, 1 CPU >[0.030953] divide error: [#1] SMP DEBUG_PAGEALLOC >[0.031000] Modules linked in: >[0.031000] CPU: 0 PID: 1 Comm: swapper/0 Not tainte

Re: Uninitialized value in __sk_nulls_add_node_rcu()

2017-12-05 Thread Eric Dumazet
On Tue, 2017-12-05 at 06:15 -0800, Eric Dumazet wrote: > > + hlist_nulls_add_head_rcu(&sk->sk_nulss_node, list); Typo here, this needs sk_nulls_node of course.

Re: Uninitialized value in __sk_nulls_add_node_rcu()

2017-12-05 Thread Eric Dumazet
On Wed, 2017-11-22 at 07:58 -0800, Eric Dumazet wrote: > On Wed, Nov 22, 2017 at 5:38 AM, Alexander Potapenko om> wrote: > > On Thu, Oct 26, 2017 at 4:56 PM, Alexander Potapenko > .com> wrote: > > > On Thu, Oct 26, 2017 at 4:52 PM, Eric Dumazet > > m> wrote: > > > > On Thu, Oct 26, 2017 at 7:47

[PATCH v3 net-next] net/tcp: trace all TCP/IP state transition with tcp_set_state tracepoint

2017-12-05 Thread Yafang Shao
The TCP/IP transition from TCP_LISTEN to TCP_SYN_RECV and some other transitions are not traced with tcp_set_state tracepoint. In order to trace the whole tcp lifespans, two helpers are introduced, void __tcp_set_state(struct sock *sk, int state); void sk_state_store(struct sock *sk, int newstate)

Re: [PATCH net-next] bpf: Add access to snd_cwnd and others in sock_ops

2017-12-05 Thread Daniel Borkmann
On 12/05/2017 01:21 AM, Lawrence Brakmo wrote: [...] > Just a question for clarification: do you need to have this in > the uapi struct as well? Meaning, do you have a specific use case > where you do this check out of the BPF program given the below > two snd_cwnd/srtt_us check thi

Re: [PATCH net-next v3 1/4] phylib: Add device reset delay support

2017-12-05 Thread Geert Uytterhoeven
Hi Richard, On Tue, Dec 5, 2017 at 2:25 PM, Richard Leitner wrote: > From: Richard Leitner > > Some PHYs need a minimum time after the reset gpio was asserted and/or > deasserted. To ensure we meet these timing requirements add two new > optional devicetree parameters for the phy: reset-delay-us

Re: [PATCH v3 12/14] nubus: Adopt standard linked list implementation

2017-12-05 Thread Bartlomiej Zolnierkiewicz
On Tuesday, December 05, 2017 01:20:02 AM Finn Thain wrote: > This increases code re-use and improves readability. > > Cc: Bartlomiej Zolnierkiewicz > Signed-off-by: Finn Thain > Tested-by: Stan Johnson Acked-by: Bartlomiej Zolnierkiewicz for fbdev part > --- > drivers/net/ethernet/8390/ma

Re: [PATCH v3 11/14] nubus: Rename struct nubus_dev

2017-12-05 Thread Bartlomiej Zolnierkiewicz
On Tuesday, December 05, 2017 01:20:02 AM Finn Thain wrote: > It is misleading to call a functional resource a "device". In adopting > the Linux Driver Model, the struct device will be embedded in struct > nubus_board. That will compound the terminlogy problem because drivers > will bind with board

Re: [PATCH] VSOCK: fix outdated sk_state value in hvs_release()

2017-12-05 Thread Jorgen S. Hansen
> On Dec 5, 2017, at 12:31 PM, Stefan Hajnoczi wrote: > > Since commit 3b4477d2dcf2709d0be89e2a8dced3d0f4a017f2 ("VSOCK: use TCP > state constants for sk_state") VSOCK has used TCP_* constants for > sk_state. > > Commit b4562ca7925a3bedada87a3dd072dd5bad043288 ("hv_sock: add locking > in the op

[PATCH net-next v3 1/4] phylib: Add device reset delay support

2017-12-05 Thread Richard Leitner
From: Richard Leitner Some PHYs need a minimum time after the reset gpio was asserted and/or deasserted. To ensure we meet these timing requirements add two new optional devicetree parameters for the phy: reset-delay-us and reset-post-delay-us. This patch depends on the "phylib: Add device reset

[PATCH net-next v3 0/4] net: fec: fix refclk enable for SMSC LAN8710/20

2017-12-05 Thread Richard Leitner
From: Richard Leitner This patch series fixes the use of the SMSC LAN8710/20 with a Freescale ETH when the refclk is generated by the FSL. This patch depends on the "phylib: Add device reset GPIO support" patch submitted by Geert Uytterhoeven/Sergei Shtylyov, see: https://patchwork.kerne

[PATCH net-next v3 2/4] phylib: add reset after clk enable support

2017-12-05 Thread Richard Leitner
From: Richard Leitner Some PHYs need the refclk to be a continuous clock. Therefore they don't allow turning it off and on again during operation. Nonetheless such a clock switching is performed by some ETH drivers (namely FEC [1]) for power saving reasons. An example for an affected PHY is the S

[PATCH net-next v3 4/4] net: fec: add phy_reset_after_clk_enable() support

2017-12-05 Thread Richard Leitner
From: Richard Leitner Some PHYs (for example the SMSC LAN8710/LAN8720) doesn't allow turning the refclk on and off again during operation (according to their datasheet). Nonetheless exactly this behaviour was introduced for power saving reasons by commit e8fcfcd5684a ("net: fec: optimize the cloc

[PATCH net-next v3 3/4] net: phy: smsc: LAN8710/20: add PHY_RST_AFTER_CLK_EN flag

2017-12-05 Thread Richard Leitner
From: Richard Leitner The Microchip/SMSC LAN8710/LAN8720 PHYs need (according to their datasheet [1]) a continuous REF_CLK when configured to "REF_CLK In Mode". Therefore set the PHY_RST_AFTER_CLK_EN flag for those PHYs to let the ETH driver reset them after the REF_CLK is enabled. [1] http://ww

Re: [crypto 6/8] chtls: TCB and Key program

2017-12-05 Thread Stephan Mueller
Am Dienstag, 5. Dezember 2017, 12:40:29 CET schrieb Atul Gupta: Hi Atul, > program the tx and rx key on chip. > > Signed-off-by: Atul Gupta > --- > drivers/crypto/chelsio/chtls/chtls_hw.c | 394 > 1 file changed, 394 insertions(+) > create mode 100644 drivers/c

[PATCH net-next] bnxt: Don't print message, if DAC isn't connected on both ends

2017-12-05 Thread Thomas Bogendoerfer
bnxt driver spams logfiles with [ 541.003065] bnxt_en :5d:00.1 eth5: Link speed -1 no longer supported if a direct attached cable (DAC) is plugged into the bnxt card and is unplugged on the other side. This patch removes the code printing this message, since it doesn't provide any useful inf

RE: [PATCH net-next 4/4] qede: Use NETIF_F_GRO_HW.

2017-12-05 Thread Chopra, Manish
> -Original Message- > From: Michael Chan [mailto:michael.c...@broadcom.com] > Sent: Tuesday, December 05, 2017 4:15 AM > To: Yuval Mintz > Cc: da...@davemloft.net; netdev@vger.kernel.org; Elior, Ariel > ; Dept-Eng Everest Linux L2 engeverestlinu...@cavium.com> > Subject: Re: [PATCH net-n

<    1   2   3   4   >