Re: [netfilter-core] kernel panic: Out of memory and no killable processes... (2)

On Mon 29-01-18 23:35:22, Florian Westphal wrote: > Kirill A. Shutemov wrote: [...] > > I hate what I'm saying, but I guess we need some tunable here. > > Not sure what exactly. > > Would memcg help? That really depends. I would have to check whether vmalloc path obeys

Re: [PATCH net-next] ptr_ring: fix integer overflow

On 2018年01月30日 01:01, David Miller wrote: From: Jason Wang Date: Thu, 25 Jan 2018 15:31:42 +0800 We try to allocate one more entry for lockless peeking. The adding operation may overflow which causes zero to be passed to kmalloc(). In this case, it returns ZERO_SIZE_PTR

RE: [RFC crypto v3 8/9] chtls: Register the ULP

@Dave Watson, Did you get chance to look at my response? What I was referring is that passing "tls" ulp type in setsockopt may be insufficient to make the decision when multi HW assist Inline TLS solution exists. Some HW may go beyond defining sendmsg/sendpage of the prot and require

bpf-next is closed too. Was: net-next is CLOSED...

On Sun, Jan 28, 2018 at 09:20:25PM -0500, David Miller wrote: > > With the release of 4.15 final, the net-next tree is closed. bpf-next is closed too. There are several bpf patches queued in patch work. We will review and apply them to bpf tree when net-next gets pulled into Linus's tree and

[PATCH bpf] tools/bpf: permit selftests/bpf to be built in a different directory

Fix a couple of issues at tools/testing/selftests/bpf/Makefile so the following command make -C tools/testing/selftests/bpf OUTPUT=/home/yhs/tmp can put the built results into a different directory. Also add the built binary test_tcpbpf_user in the .gitignore file. Fixes: 6882804c916b

Re: [RFC] iproute2: add json and color support

On 1/29/18 1:29 PM, Stephen Hemminger wrote: > This patch makes ip route command have json and color output in > a similar fashion of ip link and address. > > The printing is split into functions and duplicate code > removed. > > Probably incomplete, and has formatting glitches. > > --- >

Re: [PATCH v3 1/2] net: create skb_gso_validate_mac_len()

Hi Eric, >> skb_gso_transport_seglen(skb) is quite expensive (out of line) >> >> It is unfortunate bnx2x seems to support 9600 MTU ( >> ETH_MAX_JUMBO_PACKET_SIZE ), because 100 bytes of headers can be too >> small in some cases. >> >> Presumably we could avoid calling the function for standard

RE: macvlan devices and vlan interaction

https://www.spinics.net/lists/netdev/msg476083.html I also have a macvlan device question, but get no answer. But my original thought is in __netif_receive_skb_core() we should check packet destination mac address, if it match macvlan device, change packet as receive from macvlan device, not

Re: [PATCH v3 1/2] net: create skb_gso_validate_mac_len()

On Mon, 2018-01-29 at 17:46 -0800, Eric Dumazet wrote: > On Tue, 2018-01-30 at 12:14 +1100, Daniel Axtens wrote: > > If you take a GSO skb, and split it into packets, will the MAC > > length (L2 + L3 + L4 headers + payload) of those packets be small > > enough to fit within a given length? > > >

Re: [PATCH v3 1/2] net: create skb_gso_validate_mac_len()

On Tue, 2018-01-30 at 12:14 +1100, Daniel Axtens wrote: > If you take a GSO skb, and split it into packets, will the MAC > length (L2 + L3 + L4 headers + payload) of those packets be small > enough to fit within a given length? > > Move skb_gso_mac_seglen() to skbuff.h with other related

[PATCH v3 1/2] net: create skb_gso_validate_mac_len()

If you take a GSO skb, and split it into packets, will the MAC length (L2 + L3 + L4 headers + payload) of those packets be small enough to fit within a given length? Move skb_gso_mac_seglen() to skbuff.h with other related functions like skb_gso_network_seglen() so we can use it, and then create

[PATCH v3 0/2] bnx2x: disable GSO on too-large packets

We observed a case where a packet received on an ibmveth device had a GSO size of around 10kB. This was forwarded by Open vSwitch to a bnx2x device, where it caused a firmware assert. This is described in detail at [0]. Ultimately we want a fix in the core, but that is very tricky to backport. So

[PATCH v3 2/2] bnx2x: disable GSO where gso_size is too big for hardware

If a bnx2x card is passed a GSO packet with a gso_size larger than ~9700 bytes, it will cause a firmware error that will bring the card down: bnx2x: [bnx2x_attn_int_deasserted3:4323(enP24p1s0f0)]MC assert! bnx2x: [bnx2x_mc_assert:720(enP24p1s0f0)]XSTORM_ASSERT_LIST_INDEX 0x2 bnx2x:

after adding > 200vlans to mlx nic no traffic

Weird thing with mellanox mlx5 (connectx-4) kernel 4.15-rc9 - from net-next davem tree after: ip link add link enp175s0f1 name vlan1538 type vlan id 1538 ip link set up dev vlan1538 traffic on vlan is working But after VID="1160 1450 1451 1452 1453 1454 1455 1456 1457 1458 1459 1460

Re: [Patch net-next v3 0/3] net_sched: reflect tx_queue_len change for pfifo_fast

On Mon, Jan 29, 2018 at 9:43 AM, David Miller wrote: > > Please follow up with John about making the queue allocation use > a prepare + commit phase. Will do it once net-next is re-open. > > And as for the TX queue state handling on change, I think it's > fine to purge the

Re: [PATCH net-next v2 00/12] net: sched: propagate extack to cls offloads on destroy and only with skip_sw

On Sun, 28 Jan 2018 20:39:02 -0200, Marcelo Ricardo Leitner wrote: > On Thu, Jan 25, 2018 at 02:57:17PM -0800, Jakub Kicinski wrote: > > On Thu, 25 Jan 2018 13:11:57 -0200, Marcelo Ricardo Leitner wrote: > > > On Wed, Jan 24, 2018 at 12:54:12PM -0800, Jakub Kicinski wrote: > > > > Hi! > > > >

Re: [PATCH net] ibmvnic: Wait for device response when changing MAC

From: Thomas Falcon Date: Mon, 29 Jan 2018 13:45:05 -0600 > Wait for a response from the VNIC server before exiting after setting > the MAC address. The resolves an issue with bonding a VNIC client in > ALB or TLB modes. The bonding driver was changing the MAC

macvlan devices and vlan interaction

Hi, I'm currently investigating how macvlan devices behave in regards to vlan support, and found some interesting behavior that I am not sure how best to correct, or what the right path forward is. If I create a macvlan device: ip link add link ens0 name macvlan0 type macvlan: and then add a

Re: [PATCH] qlcnic: fix deadlock bug

From: Junxiao Bi Date: Mon, 29 Jan 2018 17:53:42 +0800 > The following soft lockup was caught. This is a deadlock caused by > recusive locking. > > Process kworker/u40:1:28016 was holding spin lock "mbx->queue_lock" in > qlcnic_83xx_mailbox_worker(), while a softirq came

Re: [PATCH] tcp: release sk_frag.page in tcp_disconnect

From: Li RongQing Date: Fri, 26 Jan 2018 16:40:41 +0800 > socket can be disconnected and gets transformed back to a listening > socket, if sk_frag.page is not released, which will be cloned into > a new socket by sk_clone_lock, but the reference count of this page > is

Re: [netfilter-core] kernel panic: Out of memory and no killable processes... (2)

Kirill A. Shutemov wrote: > On Mon, Jan 29, 2018 at 05:57:22PM +0100, Florian Westphal wrote: > > Kirill A. Shutemov wrote: > > > On Mon, Jan 29, 2018 at 08:23:57AM +0100, Florian Westphal wrote: > > > > > vmalloc() once became killable by commit

Re: [PATCH v3 bpf] bpf: introduce BPF_JIT_ALWAYS_ON config

On Mon, Jan 29, 2018 at 12:40:47AM +0100, Daniel Borkmann wrote: > On 01/28/2018 03:45 PM, Greg KH wrote: > > On Wed, Jan 24, 2018 at 11:10:50AM +0100, Daniel Borkmann wrote: > >> On 01/24/2018 11:07 AM, David Woodhouse wrote: > >>> On Tue, 2018-01-09 at 22:39 +0100, Daniel Borkmann wrote: >

Re: [virtio-dev] Re: [RFC PATCH net-next v2 2/2] virtio_net: Extend virtio to use VF datapath when available

On Mon, Jan 29, 2018 at 10:24 AM, Michael S. Tsirkin wrote: > On Sun, Jan 28, 2018 at 08:26:53PM -0800, Alexander Duyck wrote: >> >> > For live migration with advanced usecases that Siwei is suggesting, i >> >> > think we need a new driver with a new device type that can track

[RFC] iproute2: add json and color support

This patch makes ip route command have json and color output in a similar fashion of ip link and address. The printing is split into functions and duplicate code removed. Probably incomplete, and has formatting glitches. --- include/utils.h | 4 + ip/iproute.c| 764

[bpf-next PATCH v3 3/3] bpf: sockmap, fix leaking maps with attached but not detached progs

When a program is attached to a map we increment the program refcnt to ensure that the program is not removed while it is potentially being referenced from sockmap side. However, if this same program also references the map (this is a reasonably common pattern in my programs) then the verifier

[bpf-next PATCH v3 2/3] bpf: sockmap, add sock close() hook to remove socks

The selftests test_maps program was leaving dangling BPF sockmap programs around because not all psock elements were removed from the map. The elements in turn hold a reference on the BPF program they are attached to causing BPF programs to stay open even after test_maps has completed. The

[bpf-next PATCH v3 1/3] net: add a UID to use for ULP socket assignment

Create a UID field and enum that can be used to assign ULPs to sockets. This saves a set of string comparisons if the ULP id is known. For sockmap, which is added in the next patches, a ULP is used to hook into TCP sockets close state. In this case the ULP being added is done at map insert time

[bpf-next PATCH v3 0/3] bpf: sockmap fixes

A set of fixes for sockmap to resolve programs referencing sockmaps and closing without deleting all entries in the map and/or not detaching BPF programs attached to the map. Both leaving entries in the map and not detaching programs may result in the map failing to be removed by BPF

Re: [PATCH v3 bpf] bpf: introduce BPF_JIT_ALWAYS_ON config

On 01/29/2018 06:36 PM, Greg KH wrote: > On Mon, Jan 29, 2018 at 04:36:35PM +0100, Daniel Borkmann wrote: >> On 01/29/2018 12:40 AM, Daniel Borkmann wrote: >>> On 01/28/2018 03:45 PM, Greg KH wrote: On Wed, Jan 24, 2018 at 11:10:50AM +0100, Daniel Borkmann wrote: > On 01/24/2018 11:07 AM,

Re: [PATCH v3 bpf] bpf: introduce BPF_JIT_ALWAYS_ON config

On Mon, Jan 29, 2018 at 04:36:35PM +0100, Daniel Borkmann wrote: > On 01/29/2018 12:40 AM, Daniel Borkmann wrote: > > On 01/28/2018 03:45 PM, Greg KH wrote: > >> On Wed, Jan 24, 2018 at 11:10:50AM +0100, Daniel Borkmann wrote: > >>> On 01/24/2018 11:07 AM, David Woodhouse wrote: > On Tue,

[PATCH net] ibmvnic: Wait for device response when changing MAC

Wait for a response from the VNIC server before exiting after setting the MAC address. The resolves an issue with bonding a VNIC client in ALB or TLB modes. The bonding driver was changing the MAC address more rapidly than the device could respond, causing the following errors. "bond0: the hw

Re: [PATCH] ipv4: Get the address of interface correctly.

From: Tonghao Zhang Date: Sun, 28 Jan 2018 03:38:58 -0800 > When using ioctl to get address of interface, we can't > get it anymore. For example, the command is show as below. > > # ifconfig eth0 > > In the patch ("03aef17bb79b3"), the devinet_ioctl does not >

Re: [PATCH] net: pxa168_eth: add netconsole support

From: Alexander Monakov Date: Sat, 27 Jan 2018 23:29:07 +0300 > @@ -1362,6 +1362,14 @@ static int pxa168_eth_do_ioctl(struct net_device *dev, > struct ifreq *ifr, > return -EOPNOTSUPP; > } > > +#ifdef CONFIG_NET_POLL_CONTROLLER > +static void

Re: [PATCH net] net_sched: gen_estimator: fix lockdep splat

From: Eric Dumazet Date: Sat, 27 Jan 2018 10:58:43 -0800 > From: Eric Dumazet > > syzbot reported a lockdep splat in gen_new_estimator() / > est_fetch_counters() when attempting to lock est->stats_lock. > > Since est_fetch_counters() is called from

Re: [PATCH v3] net: macb: Handle HRESP error

From: Date: Sat, 27 Jan 2018 12:09:01 +0530 > From: Harini Katakam > > Handle HRESP error by doing a SW reset of RX and TX and > re-initializing the descriptors, RX and TX queue pointers. > > Signed-off-by: Harini Katakam

Re: [PATCH net-next] net/mlx5e: IPoIB, Fix copy-paste bug in flow steering refactoring

From: Saeed Mahameed Date: Fri, 26 Jan 2018 16:16:45 -0800 > From: Gal Pressman > > On TTC table creation, the indirection TIRs should be used instead of > the inner indirection TIRs. > > Fixes: 1ae1df3a1193 ("net/mlx5e: Refactor RSS related objects and

Re: [PATCH net] ipv6: addrconf: break critical section in addrconf_verify_rtnl()

From: Eric Dumazet Date: Fri, 26 Jan 2018 16:10:43 -0800 > From: Eric Dumazet > > Heiner reported a lockdep splat [1] > > This is caused by attempting GFP_KERNEL allocation while RCU lock is > held and BH blocked. > > We believe that

Re: [PATCH net] ipv6: change route cache aging logic

From: Wei Wang Date: Fri, 26 Jan 2018 11:40:17 -0800 > From: Wei Wang > > In current route cache aging logic, if a route has both RTF_EXPIRE and > RTF_GATEWAY set, the route will only be removed if the neighbor cache > has no RTN_ROUTE flag. Otherwise,

Re: [net] i40e/i40evf: Update DESC_NEEDED value to reflect larger value

From: Jeff Kirsher Date: Fri, 26 Jan 2018 08:54:45 -0800 > From: Alexander Duyck > > When compared to ixgbe and other previous Intel drivers the i40e and i40evf > drivers actually reserve 2 additional descriptors in maybe_stop_tx for >

Re: [PATCH net-next] bnxt_en: cleanup DIM work on device shutdown

From: Andy Gospodarek Date: Fri, 26 Jan 2018 10:27:47 -0500 > From: Andy Gospodarek > > Make sure to cancel any pending work that might update driver coalesce > settings when taking down an interface. > > Fixes: 6a8788f25625 ("bnxt_en: add support for

Re: [PATCH net] net: ipv6: send unsolicited NA after DAD

From: David Ahern Date: Thu, 25 Jan 2018 20:16:29 -0800 > Unsolicited IPv6 neighbor advertisements should be sent after DAD > completes. Update ndisc_send_unsol_na to skip tentative, non-optimistic > addresses and have those sent by addrconf_dad_completed after DAD. > >

Re: [PATCH net] gianfar: prevent integer wrapping in the rx handler

From: Andy Spencer Date: Thu, 25 Jan 2018 19:37:50 -0800 > When the frame check sequence (FCS) is split across the last two frames > of a fragmented packet, part of the FCS gets counted twice, once when > subtracting the FCS, and again when subtracting the previously

Re: iproute2 4.14.1 tc class add come to kernel-panic

On Mon, Jan 29, 2018 at 9:03 AM, Cong Wang wrote: > On Mon, Jan 29, 2018 at 8:00 AM, Stephen Hemminger > wrote: >> On Mon, 29 Jan 2018 16:18:07 +0100 >> "Roland Franke" wrote: >> >>> Hello, >>> >>> > To: Roland Franke ;

Re: [netfilter-core] kernel panic: Out of memory and no killable processes... (2)

On Monday 2018-01-29 17:57, Florian Westphal wrote: >> > > vmalloc() once became killable by commit 5d17a73a2ebeb8d1 ("vmalloc: back >> > > off when the current task is killed") but then became unkillable by >> > > commit >> > > b8c8a338f75e052d ("Revert "vmalloc: back off when the current task

Re: [netfilter-core] kernel panic: Out of memory and no killable processes... (2)

On Mon, Jan 29, 2018 at 05:57:22PM +0100, Florian Westphal wrote: > Kirill A. Shutemov wrote: > > On Mon, Jan 29, 2018 at 08:23:57AM +0100, Florian Westphal wrote: > > > > vmalloc() once became killable by commit 5d17a73a2ebeb8d1 ("vmalloc: > > > > back > > > > off when the

Re: [netfilter-core] kernel panic: Out of memory and no killable processes... (2)

On Mon 29-01-18 17:57:22, Florian Westphal wrote: > Kirill A. Shutemov wrote: > > On Mon, Jan 29, 2018 at 08:23:57AM +0100, Florian Westphal wrote: > > > > vmalloc() once became killable by commit 5d17a73a2ebeb8d1 ("vmalloc: > > > > back > > > > off when the current task is

Re: [virtio-dev] Re: [RFC PATCH net-next v2 2/2] virtio_net: Extend virtio to use VF datapath when available

On Sun, Jan 28, 2018 at 08:26:53PM -0800, Alexander Duyck wrote: > >> > For live migration with advanced usecases that Siwei is suggesting, i > >> > think we need a new driver with a new device type that can track the > >> > VF specific feature settings even when the VF driver is unloaded. > > > >

Re: [Patch net-next v3 0/3] net_sched: reflect tx_queue_len change for pfifo_fast

From: Cong Wang Date: Thu, 25 Jan 2018 18:26:21 -0800 > This pathcset restores the pfifo_fast qdisc behavior of dropping > packets based on latest dev->tx_queue_len. Patch 1 introduces > a helper, patch 2 introduces a new Qdisc ops which is called when > we modify

Re: [PATCH net-next 0/2] Ease to follow an interface that moves to another netns

From: Nicolas Dichtel Date: Thu, 25 Jan 2018 15:01:37 +0100 > The goal of this series is to ease the user to follow an interface that > moves to another netns. > > After this series, with a patched iproute2: > > $ ip netns > bar > foo > $ ip monitor link & > $ ip

Re: [PATCH net] vhost_net: stop device during reset owner

From: Jason Wang Date: Thu, 25 Jan 2018 22:03:52 +0800 > We don't stop device before reset owner, this means we could try to > serve any virtqueue kick before reset dev->worker. This will result a > warn since the work was pending at llist during owner resetting. Fix > this

Re: [PATCH 3/3] Revert "e1000e: Do not read ICR in Other interrupt"

On Sun, Jan 28, 2018 at 11:28 PM, Benjamin Poirier wrote: > On 2018/01/26 13:01, Alexander Duyck wrote: >> On Fri, Jan 26, 2018 at 1:12 AM, Benjamin Poirier wrote: >> > This reverts commit 16ecba59bc333d6282ee057fb02339f77a880beb. >> > >> > It was reported

Re: [PATCH v4] net: ethernet: cavium: Correct Cavium Thunderx NIC driver names accordingly to module name

From: Vadim Lomovtsev Date: Thu, 25 Jan 2018 03:38:17 -0800 > From: Vadim Lomovtsev > > It was found that ethtool provides unexisting module name while > it queries the specified network device for associated driver > information.

Re: [PATCH net-next 0/3 V1] rtnetlink: enable IFLA_IF_NETNSID for RTM_{DEL,SET}LINK

On Mon, Jan 29, 2018 at 11:31:57AM -0500, David Miller wrote: > From: Christian Brauner > Date: Wed, 24 Jan 2018 15:26:31 +0100 > > > Based on the previous discussion this enables passing a IFLA_IF_NETNSID > > property along with RTM_SETLINK and RTM_DELLINK

[PATCH net-next 0/1] rtnetlink: enable IFLA_IF_NETNSID for RTM_NEWLINK

Hi, Based on the previous discussion this enables passing a IFLA_IF_NETNSID property along with RTM_NEWLINK requests. The latter patch was missing from my previous series to allow for some more time to test this. Best, Christian Christian Brauner (1): rtnetlink: enable IFLA_IF_NETNSID for

[PATCH net-next 1/1] rtnetlink: enable IFLA_IF_NETNSID for RTM_NEWLINK

- Backwards Compatibility: If userspace wants to determine whether RTM_NEWLINK supports the IFLA_IF_NETNSID property they should first send an RTM_GETLINK request with IFLA_IF_NETNSID on lo. If either EACCESS is returned or the reply does not include IFLA_IF_NETNSID userspace should assume

Re: iproute2 4.14.1 tc class add come to kernel-panic

On Mon, Jan 29, 2018 at 8:00 AM, Stephen Hemminger wrote: > On Mon, 29 Jan 2018 16:18:07 +0100 > "Roland Franke" wrote: > >> Hello, >> >> > To: Roland Franke ; netdev@vger.kernel.org >> > Subject: Re: BUG: iproute2 4.14.1 tc class add come to

Re: [PATCH net-next 00/12] ptr_ring fixes

From: Jason Wang Date: Mon, 29 Jan 2018 15:10:37 +0800 > > > On 2018年01月26日 07:36, Michael S. Tsirkin wrote: >> This fixes a bunch of issues around ptr_ring use in net core. >> One of these: "tap: fix use-after-free" is also needed on net, >> but can't be backported

Re: [PATCH net-next] ptr_ring: fix integer overflow

From: Jason Wang Date: Thu, 25 Jan 2018 15:31:42 +0800 > We try to allocate one more entry for lockless peeking. The adding > operation may overflow which causes zero to be passed to kmalloc(). > In this case, it returns ZERO_SIZE_PTR without any notice by ptr > ring. Try to

Re: [netfilter-core] kernel panic: Out of memory and no killable processes... (2)

Kirill A. Shutemov wrote: > On Mon, Jan 29, 2018 at 08:23:57AM +0100, Florian Westphal wrote: > > > vmalloc() once became killable by commit 5d17a73a2ebeb8d1 ("vmalloc: back > > > off when the current task is killed") but then became unkillable by commit > > >

Re: [net-next 0/8][pull request] 1GbE Intel Wired LAN Driver Updates 2018-01-24

From: Alexander Duyck Date: Wed, 24 Jan 2018 18:29:42 -0800 > I'll double check our VF drivers and make sure none of them are > exposing a netdevice with an all 0's MAC address, and see what we can > do about relocating the locally administered address generation into

Re: [PATCH] ceph: Check memory allocation result

On Fri, Jan 26, 2018 at 7:54 AM, Chengguang Xu wrote: > Should check result of kstrndup() in case of memory allocation failure. > > Signed-off-by: Chengguang Xu > --- > net/ceph/ceph_common.c | 4 > 1 file changed, 4 insertions(+) > > diff --git

Re: [PATCH net] ipv6: Fix SO_REUSEPORT UDP socket with implicit sk_ipv6only

From: Martin KaFai Lau Date: Wed, 24 Jan 2018 23:15:27 -0800 > If a sk_v6_rcv_saddr is !IPV6_ADDR_ANY and !IPV6_ADDR_MAPPED, it > implicitly implies it is an ipv6only socket. However, in inet6_bind(), > this addr_type checking and setting sk->sk_ipv6only to 1 are only done > after

Re: [PATCH v2 0/4] Check size of packets before sending

From: Daniel Axtens Date: Mon, 29 Jan 2018 14:20:58 +1100 > OK, so how about: > > - first, a series that introduces skb_gso_validate_mac_len and uses it >in bnx2x. This should be backportable without difficulty. > > - then, a series that wires skb_gso_validate_mac_len

Re: [PATCH net-next 0/3 V1] rtnetlink: enable IFLA_IF_NETNSID for RTM_{DEL,SET}LINK

From: Christian Brauner Date: Wed, 24 Jan 2018 15:26:31 +0100 > Based on the previous discussion this enables passing a IFLA_IF_NETNSID > property along with RTM_SETLINK and RTM_DELLINK requests. The patch for > RTM_NEWLINK will be sent out in a separate patch

[ANNOUNCE] iproute2 4.15 release

Release of iproute2 for Linux 4.15 Update to iproute2 utility to support new features in Linux 4.15. This release ands more JSON output and fixes some bugs that JSON code introduced. Also more updates to active developing subsystems such as devlink and bpf. The tarball can be dowloaded from:

xdp_router_ipv4 mellanox problem

Hi Want to do some tests with xdp_router on two 100G physical interfaces but: Jan 29 17:00:40 HOST kernel: mlx5_core :af:00.0: MLX5E: StrdRq(0) RqSz(1024) StrdSz(1) RxCqeCmprss(0) Jan 29 17:00:40 HOST kernel: mlx5_core :af:00.0 enp175s0f0: Link up Jan 29 17:00:41 HOST kernel:

Re: [PATCH iproute2] police: don't skip parameters after actions

On Mon, 29 Jan 2018 12:13:11 +0100 Wolfgang Bumiller wrote: > The 'parse_action_control()' helper advances the argument > pointers to past its parsed action already, so don't > advance it further in 'act_parse_polic()'. > > Fixes: e67aba559581 ("tc: actions: add helpers

Re: iproute2 4.14.1 tc class add come to kernel-panic

On Mon, 29 Jan 2018 16:18:07 +0100 "Roland Franke" wrote: > Hello, > > > To: Roland Franke ; netdev@vger.kernel.org > > Subject: Re: BUG: iproute2 4.14.1 tc class add come to kernel-panic > >> > >> tc qdisc add dev eth0 root handle 20: htb default 4 r2q 1 > >> tc

sctp netns "unregister_netdevice: waiting for lo to become free. Usage count = 1"

Hi, When running sctp_test from lksctp-tools in netns in 4.4 and 4.9 with suitable arguments, the local loopback device in the netns is not getting destroyed after deleting the netns. For example: ip netns add TEST ip netns exec TEST ip link set lo up ip link add dummy0 type dummy ip link

Re: [PATCH bpf-next 07/13] bpf, s390x: remove obsolete exception handling from div/mod

On 01/29/2018 03:33 PM, Michael Holzheu wrote: > Am Fri, 26 Jan 2018 23:33:42 +0100 > schrieb Daniel Borkmann : > >> Since we've changed div/mod exception handling for src_reg in >> eBPF verifier itself, > > Maybe add the commit that introduced that to the patch

Re: [PATCH 2/3] Revert "e1000e: Separate signaling for link check/link up"

On Sun, Jan 28, 2018 at 11:21 PM, Benjamin Poirier wrote: > On 2018/01/26 09:03, Alexander Duyck wrote: >> On Fri, Jan 26, 2018 at 1:12 AM, Benjamin Poirier wrote: >> > This reverts commit 19110cfbb34d4af0cdfe14cd243f3b09dc95b013. >> > This reverts commit

Re: [PATCH 1/3] Partial revert "e1000e: Avoid receiver overrun interrupt bursts"

On Sun, Jan 28, 2018 at 11:20 PM, Benjamin Poirier wrote: > On 2018/01/26 08:50, Alexander Duyck wrote: >> On Fri, Jan 26, 2018 at 1:12 AM, Benjamin Poirier wrote: >> > This reverts commit 4aea7a5c5e940c1723add439f4088844cd26196d. >> > >> > We keep the fix

Re: [PATCH v3 bpf] bpf: introduce BPF_JIT_ALWAYS_ON config

On 01/29/2018 12:40 AM, Daniel Borkmann wrote: > On 01/28/2018 03:45 PM, Greg KH wrote: >> On Wed, Jan 24, 2018 at 11:10:50AM +0100, Daniel Borkmann wrote: >>> On 01/24/2018 11:07 AM, David Woodhouse wrote: On Tue, 2018-01-09 at 22:39 +0100, Daniel Borkmann wrote: > On 01/09/2018 07:04

RE: r8169 take too long to complete driver initialization

Hi Chris, Could you test following patch? DECLARE_RTL_COND(rtl_ocp_tx_cond) { void __iomem *ioaddr = tp->mmio_addr; - return RTL_R8(IBISR0) & 0x02; + return RTL_R8(IBISR0) & 0x20; } static void rtl8168ep_stop_cmac(struct rtl8169_private *tp) { void __iomem

Re: iproute2 4.14.1 tc class add come to kernel-panic

Hello, To: Roland Franke ; netdev@vger.kernel.org Subject: Re: BUG: iproute2 4.14.1 tc class add come to kernel-panic tc qdisc add dev eth0 root handle 20: htb default 4 r2q 1 tc class add dev eth0 parent 20: classid 20:7 htb rate 1kbit tc qdisc add dev eth0 parent 20:7 sfq perturb 10 tc

Re: BUG: iproute2 4.14.1 tc class add come to kernel-panic

On Mon, 2018-01-29 at 15:51 +0100, Roland Franke wrote: > Starting with Kernel 4.14.1 (x86_64) I found the following problem: > When I made the following commands: > > tc qdisc add dev eth0 root handle 20: htb default 4 r2q 1 > tc class add dev eth0 parent 20: classid 20:7 htb rate 1kbit > tc

BUG: iproute2 4.14.1 tc class add come to kernel-panic

Starting with Kernel 4.14.1 (x86_64) I found the following problem: When I made the following commands: tc qdisc add dev eth0 root handle 20: htb default 4 r2q 1 tc class add dev eth0 parent 20: classid 20:7 htb rate 1kbit tc qdisc add dev eth0 parent 20:7 sfq perturb 10 tc class add dev

Re: [PATCH bpf-next 07/13] bpf, s390x: remove obsolete exception handling from div/mod

Am Fri, 26 Jan 2018 23:33:42 +0100 schrieb Daniel Borkmann : > Since we've changed div/mod exception handling for src_reg in > eBPF verifier itself, Maybe add the commit that introduced that to the patch description? > remove the leftovers from s390x JIT. > >

Re: [PATCH stable 4.9 1/8] x86: bpf_jit: small optimization in emit_bpf_tail_call()

Hi Eric, On Mon, Jan 29, 2018 at 06:04:30AM -0800, Eric Dumazet wrote: > > If these 4 bytes matter, why not use > > cmpq with an immediate value instead, which saves 2 extra bytes ? : > > > > - the mov above is 11 bytes total : > > > >0: 48 8b 84 d6 78 56 34mov

Re: [PATCH stable 4.9 1/8] x86: bpf_jit: small optimization in emit_bpf_tail_call()

On Sun, Jan 28, 2018 at 10:39 PM, Willy Tarreau wrote: > Hi, > > [ replaced stable@ and greg@ by netdev@ as my question below is not > relevant to stable ] > > On Mon, Jan 29, 2018 at 02:48:54AM +0100, Daniel Borkmann wrote: >> From: Eric Dumazet >> >> [

Re: [4.15-rc9] fs_reclaim lockdep trace

On Mon, Jan 29, 2018 at 08:47:20PM +0900, Tetsuo Handa wrote: > Peter Zijlstra wrote: > > On Sun, Jan 28, 2018 at 02:55:28PM +0900, Tetsuo Handa wrote: > > > This warning seems to be caused by commit d92a8cfcb37ecd13 > > > ("locking/lockdep: Rework FS_RECLAIM annotation") which moved the > > >

Re: dvb usb issues since kernel 4.9

Em Fri, 26 Jan 2018 17:37:39 -0200 Mauro Carvalho Chehab escreveu: > Em Fri, 26 Jan 2018 12:17:37 -0200 > Mauro Carvalho Chehab escreveu: > > > Hi Alan, > > > > Em Mon, 8 Jan 2018 14:15:35 -0500 (EST) > > Alan Stern

[PATCH] netfilter: fix pointer leaks to userspace

Several netfilter matches and targets put kernel pointers into info objects, but don't set usersize in descriptors. This leads to kernel pointer leaks if a match/target is set and then read back to userspace. Properly set usersize for these matches/targets. Found with manual code inspection.

Re: [4.15-rc9] fs_reclaim lockdep trace

Peter Zijlstra wrote: > On Sun, Jan 28, 2018 at 02:55:28PM +0900, Tetsuo Handa wrote: > > This warning seems to be caused by commit d92a8cfcb37ecd13 > > ("locking/lockdep: Rework FS_RECLAIM annotation") which moved the > > location of > > > > /* this guy won't enter reclaim */ > > if

[PATCH iproute2] police: don't skip parameters after actions

The 'parse_action_control()' helper advances the argument pointers to past its parsed action already, so don't advance it further in 'act_parse_polic()'. Fixes: e67aba559581 ("tc: actions: add helpers to parse and print control actions") Signed-off-by: Wolfgang Bumiller

Re: [PATCH nf-next,RFC v4] netfilter: nf_flow_table: add hardware offload support

Hi Jakub, On Thu, Jan 25, 2018 at 02:38:46PM -0800, Jakub Kicinski wrote: > On Thu, 25 Jan 2018 12:28:58 +0100, Pablo Neira Ayuso wrote: [...] > Ah, I must be misunderstanding. I meant when device is removed, not > the flow_table_hw module. Does the nf_flow_table_hw_module_exit() run > when

Re: [4.15-rc9] fs_reclaim lockdep trace

On Sun, Jan 28, 2018 at 02:55:28PM +0900, Tetsuo Handa wrote: > This warning seems to be caused by commit d92a8cfcb37ecd13 > ("locking/lockdep: Rework FS_RECLAIM annotation") which moved the > location of > > /* this guy won't enter reclaim */ > if ((current->flags & PF_MEMALLOC) &&

Re: [PATCH 2/3] Revert "e1000e: Separate signaling for link check/link up"

On 2018/01/26 09:03, Alexander Duyck wrote: > On Fri, Jan 26, 2018 at 1:12 AM, Benjamin Poirier wrote: > > This reverts commit 19110cfbb34d4af0cdfe14cd243f3b09dc95b013. > > This reverts commit 4110e02eb45ea447ec6f5459c9934de0a273fb91. > > > > ... because they cause an extra 2s

Re: r8169 take too long to complete driver initialization

On Fri, Jan 5, 2018 at 10:17 AM, Chris Chiu wrote: > On Wed, Dec 20, 2017 at 4:41 PM, Chris Chiu wrote: >> Hi, >> We've hit a suspend/resume issue on a Acer desktop caused by r8169 >> driver. The dmseg >>

[PATCH] qlcnic: fix deadlock bug

The following soft lockup was caught. This is a deadlock caused by recusive locking. Process kworker/u40:1:28016 was holding spin lock "mbx->queue_lock" in qlcnic_83xx_mailbox_worker(), while a softirq came in and ask the same spin lock in qlcnic_83xx_enqueue_mbx_cmd(). This lock should be hold

Re: BUG: 4.14.11 unable to handle kernel NULL pointer dereference in xfrm_lookup

On Wed, Jan 24, 2018 at 10:59:21AM +0100, Steffen Klassert wrote: > On Fri, Jan 19, 2018 at 03:45:46PM +0100, Tobias Hommel wrote: > > > > I tried to strip down the system configuration and was able to reproduce the > > problem with a minimal configuration: > > * ipsets are not used anymore > > *

Re: [netfilter-core] kernel panic: Out of memory and no killable processes... (2)

On Mon, Jan 29, 2018 at 08:23:57AM +0100, Florian Westphal wrote: > > vmalloc() once became killable by commit 5d17a73a2ebeb8d1 ("vmalloc: back > > off when the current task is killed") but then became unkillable by commit > > b8c8a338f75e052d ("Revert "vmalloc: back off when the current task is >