tree: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git vhost
head: 9991b95cb712cdd9a40240bde6274d5415476fb5
commit: 860c7fa9d6d433011e82a4f7f896893e914ce4a9 [11/22] fw_cfg: write
vmcoreinfo details
config: i386-randconfig-c0-02011330 (attached as .config)
compiler: gcc-7 (Debian 7
On Thu, Jan 04, 2018 at 10:14:38AM -0800, Andrei Vagin wrote:
> On Thu, Jan 04, 2018 at 01:01:17PM +0100, Dmitry Vyukov wrote:
> > On Wed, Jan 3, 2018 at 8:37 AM, Andrei Vagin wrote:
> > >> > Hello,
> > >> >
> > >> > syzkaller hit the following crash on
> > >> > 75aa5540627fdb3d8f86229776ea87f9952
On Sun, Dec 17, 2017 at 09:52:01PM -0800, syzbot wrote:
> Hello,
>
> syzkaller hit the following crash on
> f3b5ad89de16f5d42e8ad36fbdf85f705c1ae051
> git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/master
> compiler: gcc (GCC) 7.1.1 20170620
> .config is attached
> Raw console ou
From: Eric Dumazet
Some devices (like mlx4) try hard to allocate memory on selected
NUMA node, but it turns out intel_alloc_coherent() is not NUMA
aware yet.
Note that dma_generic_alloc_coherent() in arch/x86/kernel/pci-dma.c
gets this right.
Signed-off-by: Eric Dumazet
Cc: Benjamin Serebrin
> -Original Message-
> From: Dave Watson [mailto:davejwat...@fb.com]
> Sent: Wednesday, January 31, 2018 11:05 PM
> To: Vakul Garg
> Cc: linux-cry...@vger.kernel.org; il...@mellanox.com;
> avia...@mellanox.com; da...@davemloft.net; netdev@vger.kernel.org;
> Gilad Ben-Yossef
> Subject: R
On Wed, Jan 31, 2018 at 04:49:36PM -0800, Jesus Sanchez-Palencia wrote:
> While implementing this today it crossed my mind that why don't we have the
> clockid_t set per socket (e.g. as an argument to SO_TXTIME) instead of per
> packet?
Sounds good to me.
Thanks,
Richard
On Wed, Jan 31, 2018 at 6:48 PM, Ed Swierk wrote:
> IPv4 and IPv6 packets may arrive with lower-layer padding that is not
> included in the L3 length. For example, a short IPv4 packet may have
> up to 6 bytes of padding following the IP payload when received on an
> Ethernet device with a minimum
On 1/30/18 11:09 AM, Serhey Popovych wrote:
> With this series I propose to get rid of custom print_linkinfo_brief()
> in favor of print_linkinfo() to avoid code duplication.
>
Cover letter needs updating in light of the change to patch 6
On 1/30/18 11:09 AM, Serhey Popovych wrote:
> There is at least three places implementing same things: two in
> ipaddress.c print_linkinfo() & print_linkinfo_brief() and one in
> bridge/link.c.
>
> These two implementations diverge from each other very little:
> bridge/link.c does not support JSON
On 1/30/18 11:09 AM, Serhey Popovych wrote:
> Be consistent in handling of IFLA_IFNAME attribute in all places: if
> there is no attribute report bug to stderr and use ll_index_to_name() as
> last measure to get name in "if%d" format instead of "".
>
> Use check_ifname() to validate network device
On 1/30/18 11:09 AM, Serhey Popovych wrote:
> Improve print_linkinfo_brief() and it's callers:
>
> 1) Get rid of custom @struct filter pointer @pfilter: it is NULL in
> all callers anyway and global @filter is used.
>
Looks like I somehow dropped a vrf change that was going to use that.
S
On 1/30/18 11:09 AM, Serhey Popovych wrote:
> diff --git a/ip/ipaddress.c b/ip/ipaddress.c
> index 051a05f..f8fd392 100644
> --- a/ip/ipaddress.c
> +++ b/ip/ipaddress.c
> @@ -948,14 +948,14 @@ int print_linkinfo_brief(const struct sockaddr_nl *who,
> parse_rtattr(tb, IFLA_MAX, IFLA_RTA(ifi),
On 1/31/18 4:04 PM, Stephen Hemminger wrote:
>
> /proc/net/dev is legacy and unextensible.
>
> I would rather see netlink used everywhere and not /proc/net/dev or sysfs!
>
agreed. ll_init_map is already called in some places so a device cache
already exists.
IPv4 and IPv6 packets may arrive with lower-layer padding that is not
included in the L3 length. For example, a short IPv4 packet may have
up to 6 bytes of padding following the IP payload when received on an
Ethernet device with a minimum packet length of 64 bytes.
Higher-layer processing functio
On Wed, Jan 31, 2018 at 07:07:49PM -0600, Gustavo A. R. Silva wrote:
>
> Hi Alan,
>
> Quoting Alan Cox :
>
> >On Wed, 31 Jan 2018 18:24:07 -0600
> >"Gustavo A. R. Silva" wrote:
> >
> >>Cast to s64 some variables and a macro in order to give the
> >>compiler complete information about the proper
On Wed, 2018-01-31 at 14:45 -0800, Eric Dumazet wrote:
> From: Eric Dumazet
>
> Some devices (like mlx4) try hard to allocate memory on selected
> NUMA node, but it turns out intel_alloc_coherent() is not NUMA
> aware yet.
>
> Note that dma_generic_alloc_coherent() in arch/x86/kernel/pci-dma.c
>
On Wed, 2018-01-31 at 16:26 -0800, Cong Wang wrote:
> rateest_hash is supposed to be protected by xt_rateest_mutex.
>
> Reported-by:
> Fixes: 5859034d7eb8 ("[NETFILTER]: x_tables: add RATEEST target")
> Cc: Pablo Neira Ayuso
> Signed-off-by: Cong Wang
> ---
> net/netfilter/xt_RATEEST.c | 2 ++
Hi Alan,
Quoting Alan Cox :
On Wed, 31 Jan 2018 18:24:07 -0600
"Gustavo A. R. Silva" wrote:
Cast to s64 some variables and a macro in order to give the
compiler complete information about the proper arithmetic to
use. Notice that these elements are used in contexts that
expect expressions o
Hi,
On 01/18/2018 09:13 AM, Richard Cochran wrote:
> On Thu, Jan 18, 2018 at 09:42:27AM +0100, Miroslav Lichvar wrote:
>> In the discussion about the v1 patchset, there was a question if the
>> cmsg should include a clockid_t. Without that, how can an application
>> prevent the packet from being
On Tue, Jan 30, 2018 at 11:59 PM, David Ahern wrote:
> On 1/30/18 1:57 PM, David Ahern wrote:
>> On 1/30/18 1:08 PM, Daniel Borkmann wrote:
>>> On 01/30/2018 07:32 PM, Cong Wang wrote:
On Tue, Jan 30, 2018 at 4:09 AM, Dmitry Vyukov wrote:
> Hello,
>
> The following program create
Cast to s64 some variables and a macro in order to give the
compiler complete information about the proper arithmetic to
use. Notice that these elements are used in contexts that
expect expressions of type s64 (64 bits, signed).
Currently such expression are being evaluated using 32-bit
arithmetic
On Wed, 31 Jan 2018 18:24:07 -0600
"Gustavo A. R. Silva" wrote:
> Cast to s64 some variables and a macro in order to give the
> compiler complete information about the proper arithmetic to
> use. Notice that these elements are used in contexts that
> expect expressions of type s64 (64 bits, signe
rateest_hash is supposed to be protected by xt_rateest_mutex.
Reported-by:
Fixes: 5859034d7eb8 ("[NETFILTER]: x_tables: add RATEEST target")
Cc: Pablo Neira Ayuso
Signed-off-by: Cong Wang
---
net/netfilter/xt_RATEEST.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/net/netfilter/xt_RATE
Adopt the extra-option framework for SMC.
It allows us to entirely remove SMC-code out of the TCP-stack.
The static key is gone, as this is now covered by the static key of the
extra-option framework.
We allocate state (struct tcp_smc_opt) that indicates whether SMC was
successfully negotiated or
Resubmit as v2 RFC to get some feedback before net-next opens up again.
Only minor changes (see below).
This patchset introduces a generic framework for handling TCP-options.
TCP-options like TCP_MD5 and SMC are rather rare use-cases, but their
implementation is rather intrusive to the TCP-stack
Now that we have consolidated the TCP_MD5 output path, we can cleanup
TCP and its callbacks to MD5.
These callbacks are solely there to handle the different
address-familiese (v4, v6 and v4mapped).
Now that we have isolated the TCP_MD5-code it is acceptable to add a bit
more complexity inside tcp
As we allow a generic TCP-option parser that also parses experimental
TCP options, we need to add a return-value to smc_parse_options() that
indicates whether the option actually matched or not.
Cc: Ursula Braun
Signed-off-by: Christoph Paasch
Reviewed-by: Mat Martineau
---
net/ipv4/tcp_input.
An upcoming patch adds a configurable, per-socket list of TCP options to
populate in the TCP header. This requires tcp_options_write() to know the
socket (to use the options list) and the skb (to provide visibility to the
packet data for options like TCP_MD5SIG).
Signed-off-by: Christoph Paasch
R
This patch starts making use of the extra_option framework for TCP_MD5.
One tricky part is that extra_options are called at the end of the
tcp_syn_options(), while TCP_MD5 is called at the beginning.
TCP_MD5 is called at the beginning because it wants to disable
TCP-timestamps (for option-space r
We want to move all the TCP-MD5 code to a single place which enables us
to factor the TCP-MD5 code out of the TCP-stack into the extra-option
framework.
Detection of whether or not to drop the segment (as done in
tcp_v6_send_reset()) has now been moved to tcp_v6_send_response().
So we needed to ad
It really does not matter, because we never use TCP timestamps when
TCP_MD5 is enabled (see tcp_syn_options).
Moving TCP_MD5 a bit lower allows for easier adoption of the
tcp_extra_option framework.
Cc: Ivan Delalande
Signed-off-by: Christoph Paasch
Reviewed-by: Mat Martineau
---
net/ipv4/tcp
This will simplify to consolidate the TCP_MD5-code into a single place.
Cc: Ivan Delalande
Signed-off-by: Christoph Paasch
Reviewed-by: Mat Martineau
---
net/ipv4/tcp_ipv4.c | 18 ++
1 file changed, 14 insertions(+), 4 deletions(-)
diff --git a/net/ipv4/tcp_ipv4.c b/net/ipv4/t
This is all just copy-pasting the TCP_MD5-code into functions that are
placed in net/ipv4/tcp_md5.c.
Cc: Ivan Delalande
Signed-off-by: Christoph Paasch
Reviewed-by: Mat Martineau
---
Notes:
v2: * Add SPDX-identifier (Mat Martineau's feedback)
include/linux/inet_diag.h |1 +
include/l
The generic TCP-option framework will need to have access to the full
TCP-header (e.g., if we want to compute a checksum for TCP-MD5).
Thus, we move the call to tcp_options_write() to after all the fields in
the header have been filled out.
Signed-off-by: Christoph Paasch
Reviewed-by: Mat Martin
The checks are now being done through the extra-option framework. For
TCP MD5 this means that the check happens a bit later than usual.
Cc: Ivan Delalande
Signed-off-by: Christoph Paasch
Reviewed-by: Mat Martineau
---
include/linux/tcp_md5.h | 23 +--
net/ipv4/tcp_input.c
From: Mat Martineau
Allow additional TCP options to be handled by registered hook
functions.
Registered options have a priority that determines the order in which
options are prepared and written. Lower priority numbers are handled
first.
Option parsing will call the provided 'parse' function w
After parsing the TCP-options, some option-kinds might trigger a drop of
the segment (e.g., as is the case for TCP_MD5). As we are moving to
consolidate the TCP_MD5-code in follow-up patches, we need to add the
capability to drop a segment right after parsing the options in
tcp_fast_parse_options()
It is much cleaner to store the key-pointer in tcp_out_options. It
allows to remove some MD5-specific code out of the function-arguments
and paves the way to adopting the TCP-option framework with TCP-MD5.
Cc: Ivan Delalande
Signed-off-by: Christoph Paasch
Reviewed-by: Mat Martineau
---
includ
On Wed, 31 Jan 2018 21:49:45 +0200
Serhey Popovych wrote:
> Currently there is two places in ip(8) where /proc/net/dev is read line
> by line with nearly identical steps: iptunnel.c and ip6tunnel.c
>
> On the other hand we have iptuntap.c that uses /sys/class/net that could
> be problematic in c
xt_cgroup_info_v1->priv is an internal pointer only used for kernel,
we should not trust what user-space provides.
Reported-by:
Fixes: c38c4597e4bf ("netfilter: implement xt_cgroup cgroup2 path match")
Cc: Pablo Neira Ayuso
Signed-off-by: Cong Wang
---
net/netfilter/xt_cgroup.c | 1 +
1 file c
On Wed, 31 Jan 2018 12:16:49 +0100
Mohammed Gamal wrote:
> On Tue, 2018-01-30 at 11:29 -0800, Stephen Hemminger wrote:
> > On Tue, 23 Jan 2018 10:34:04 +0100
> > Mohammed Gamal wrote:
> >
> > > Split each of the functions into two for each of send/recv buffers
> > >
> > > Signed-off-by: Moha
From: Eric Dumazet
Some devices (like mlx4) try hard to allocate memory on selected
NUMA node, but it turns out intel_alloc_coherent() is not NUMA
aware yet.
Note that dma_generic_alloc_coherent() in arch/x86/kernel/pci-dma.c
gets this right.
Signed-off-by: Eric Dumazet
Cc: Benjamin Serebrin
> -Original Message-
> From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org]
> On Behalf Of Joe Perches
> Sent: Wednesday, January 31, 2018 3:35 AM
> To: Kirsher, Jeffrey T ; da...@davemloft.net
> Cc: Keller, Jacob E ; netdev@vger.kernel.org;
> nhor...@redhat.com; sassm..
On Thu, Jan 25, 2018 at 12:03:02PM -0500, David Miller wrote:
> From: Roman Gushchin
> Date: Thu, 25 Jan 2018 00:19:11 +
>
> > @@ -476,6 +477,10 @@ struct sock *inet_csk_accept(struct sock *sk, int
> > flags, int *err, bool kern)
> > spin_unlock_bh(&queue->fastopenq.lock);
> >
On Wed, 2018-01-31 at 14:15 +1100, Daniel Axtens wrote:
> If a bnx2x card is passed a GSO packet with a gso_size larger than
> ~9700 bytes, it will cause a firmware error that will bring the card
> down:
>
> bnx2x: [bnx2x_attn_int_deasserted3:4323(enP24p1s0f0)]MC assert!
> bnx2x: [bnx2x_mc_assert:
"Chopra, Manish" writes:
>> -Original Message-
>> From: Daniel Axtens [mailto:d...@axtens.net]
>> Sent: Wednesday, January 31, 2018 8:46 AM
>> To: netdev@vger.kernel.org
>> Cc: Daniel Axtens ; Eric Dumazet ;
>> Chopra, Manish ; Jason Wang
>> ; Pravin Shelar ; Marcelo Ricardo
>> Leitner
>
On Sat, Dec 09, 2017 at 02:40:00AM -0800, syzbot wrote:
> Hello,
>
> syzkaller hit the following crash on
> 328b4ed93b69a6f2083d52f31a240a09e5de386a
> git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/master
> compiler: gcc (GCC) 7.1.1 20170620
> .config is attached
> Raw console ou
This commit fixes the pacing_gain to remain at BBR_UNIT (1.0) when
using lt_bw and returning from the PROBE_RTT state to PROBE_BW.
Previously, when using lt_bw, upon exiting PROBE_RTT and entering
PROBE_BW the bbr_reset_probe_bw_mode() code could sometimes randomly
end up with a cycle_idx of 0 and
> I'm running into a NULL pointer dereference after updating from Linux
4.1.6 to
> 4.14.11 (see kernel log below).
We are running into the same problem on our production machine, running
CoreOS 1576.5.0 Stable with the 4.14.11 kernel on a KVM Cloud VM. It is
not as easy to reproduce though in
David Ahern wrote:
> On 1/31/18 10:21 AM, Serhey Popovych wrote:
>> Eric Dumazet wrote:
>>> ip tuntap enumerates devices using /sys/class/net which is unusual.
>>>
>>> Should we replace this enumeration using /proc/net/dev like "ip tunnel" ?
>>>
>>> After "unshare -n" maybe mounting /sys should not
Now we have helper to iterate over entries in /proc/net/dev we can
simplify and cleanup do_tunnels_list() in ip/iptuntap.c.
While there replace printf("\n") with fputc('\n', stdout) and
printf() with fputs() where string does not contain format specifiers.
Signed-off-by: Serhey Popovych
---
ip/
Now we have helper to iterate over entries in /proc/net/dev we can
simplify and cleanup do_tunnels_list() in ip/iptunnel.c.
While there replace printf("\n") with fputc('\n', stdout) and printf()
with fputs() where string does not contain format specifiers.
Also move tunnel parameter matching to n
Now we have helper to iterate over entries in /proc/net/dev we can
simplify and cleanup do_tunnels_list() in ip/iptunnel.c.
While there replace printf("\n") with fputc('\n', stdout) and printf()
with fputs() where string does not contain format specifiers.
Signed-off-by: Serhey Popovych
---
ip/
It is natural for ip(8) tool to access /proc/net/dev for various
information and there at least two places implementing same iteration
over lines in this file: iptunnel.c and ip6tunnel.c.
To unify interface and avoid code duplication introduce helper that
reads line from /proc/net/dev, passes it t
Currently there is two places in ip(8) where /proc/net/dev is read line
by line with nearly identical steps: iptunnel.c and ip6tunnel.c
On the other hand we have iptuntap.c that uses /sys/class/net that could
be problematic in case of unshare(1)d network namespace without sysfs
being mounted.
Int
2018-01-30 8:58 GMT+01:00 Ilias Apalodimas :
> We've noticed 3 different hardware approaches in receiving payloads
>
> 1. Host driver needs to pre-load descriptor ring with addresses of RAM
> buffers to write arriving data.
> The "standard" functionality for most NICs is (in little detail) fetch th
-Original Message-
From: Dave Watson [mailto:davejwat...@fb.com]
Sent: Wednesday, January 31, 2018 10:14 PM
To: Atul Gupta
Cc: s...@queasysnail.net; herb...@gondor.apana.org.au;
linux-cry...@vger.kernel.org; ganes...@chelsio.co; netdev@vger.kernel.org;
da...@davemloft.net; Boris Pisme
On 31.01.2018 14:31, Neil Horman wrote:
On Wed, Jan 31, 2018 at 11:42:24AM +0200, Tommi Rantala wrote:
I think there's a problem in the dst refcounting in sctp_v4_get_dst()
There's a dst_entry struct that has >0 refcnt after running the testcase,
which makes it impossible to delete the loopback
On Wed, Jan 31, 2018 at 7:34 PM, Dave Watson wrote:
> On 01/31/18 05:22 PM, Vakul Garg wrote:
>> > > On second though in stable we should probably just disable async tfm
>> > > allocations.
>> > > It's simpler. But this approach is still good for -next
>> > >
>> > >
>> > > Gilad
>> >
>> > I agree
David Ahern wrote:
> On 1/31/18 10:21 AM, Serhey Popovych wrote:
>> Eric Dumazet wrote:
>>> ip tuntap enumerates devices using /sys/class/net which is unusual.
>>>
>>> Should we replace this enumeration using /proc/net/dev like "ip tunnel" ?
>>>
>>> After "unshare -n" maybe mounting /sys should not
On 1/31/18 10:21 AM, Serhey Popovych wrote:
> Eric Dumazet wrote:
>> ip tuntap enumerates devices using /sys/class/net which is unusual.
>>
>> Should we replace this enumeration using /proc/net/dev like "ip tunnel" ?
>>
>> After "unshare -n" maybe mounting /sys should not be required for
>> proper
On 01/31/18 05:22 PM, Vakul Garg wrote:
> > > On second though in stable we should probably just disable async tfm
> > > allocations.
> > > It's simpler. But this approach is still good for -next
> > >
> > >
> > > Gilad
> >
> > I agree with Gilad, just disable async for now.
> >
>
> How to do it
On Wed, Jan 31, 2018 at 4:43 PM, David Miller wrote:
> From: Masahiro Yamada
> Date: Thu, 1 Feb 2018 00:37:27 +0900
>
>> 2018-02-01 0:32 GMT+09:00 David Miller :
>>> From: Ulf Magnusson
>>> Date: Tue, 30 Jan 2018 20:05:23 +0100
>>>
In preparation for adding a warning ("kconfig: Warn if help
> -Original Message-
> From: Dave Watson [mailto:davejwat...@fb.com]
> Sent: Wednesday, January 31, 2018 8:52 PM
> To: Vakul Garg
> Cc: linux-cry...@vger.kernel.org; il...@mellanox.com;
> avia...@mellanox.com; da...@davemloft.net; netdev@vger.kernel.org;
> Gilad Ben-Yossef
> Subject: Re
Eric Dumazet wrote:
> ip tuntap enumerates devices using /sys/class/net which is unusual.
>
> Should we replace this enumeration using /proc/net/dev like "ip tunnel" ?
>
> After "unshare -n" maybe mounting /sys should not be required for
> proper iproute2 behavior.
>
> At least ip command should
ip tuntap enumerates devices using /sys/class/net which is unusual.
Should we replace this enumeration using /proc/net/dev like "ip tunnel" ?
After "unshare -n" maybe mounting /sys should not be required for
proper iproute2 behavior.
At least ip command should adopt a common enumeration method.
On 01/30/2018 09:50 PM, Eric Leblond wrote:
> Hello Daniel,
>
> No problem with the delay in the answer. I'm doing far worse.
>
> Here is an updated version:
> - add if_link.h in uapi and remove the definition
> - fix a commit message
> - remove uapi from a include
Fyi, this still needs to wait
On 01/31/18 04:14 PM, Atul Gupta wrote:
>
>
> On Tuesday 30 January 2018 10:41 PM, Dave Watson wrote:
> > On 01/30/18 06:51 AM, Atul Gupta wrote:
> >
> > > What I was referring is that passing "tls" ulp type in setsockopt
> > > may be insufficient to make the decision when multi HW assist Inline
On Wed, Jan 31, 2018 at 10:30:44AM -0500, David Miller wrote:
> From: Christian Brauner
> Date: Mon, 29 Jan 2018 18:07:20 +0100
>
> > - Backwards Compatibility:
> > If userspace wants to determine whether RTM_NEWLINK supports the
> > IFLA_IF_NETNSID property they should first send an RTM_GETL
From: Colin Ian King
Variable head is initialized to a value that is never read and is
being updated to a new value a few lines later, hence this
initialization is redundant and can be safely removed as well
as the now unused pointer txq.
Cleans up clang warning:
drivers/net/ethernet/emulex/bene
Please queue up this commit for stable:
69c64866ce07 dccp: CVE-2017-8824: use-after-free in DCCP code
Ben.
--
Ben Hutchings
Software Developer, Codethink Ltd.
From: Masahiro Yamada
Date: Thu, 1 Feb 2018 00:37:27 +0900
> 2018-02-01 0:32 GMT+09:00 David Miller :
>> From: Ulf Magnusson
>> Date: Tue, 30 Jan 2018 20:05:23 +0100
>>
>>> In preparation for adding a warning ("kconfig: Warn if help text is
>>> blank"): https://lkml.org/lkml/2018/1/30/516
>>>
>>
2018-02-01 0:32 GMT+09:00 David Miller :
> From: Ulf Magnusson
> Date: Tue, 30 Jan 2018 20:05:23 +0100
>
>> In preparation for adding a warning ("kconfig: Warn if help text is
>> blank"): https://lkml.org/lkml/2018/1/30/516
>>
>> Signed-off-by: Ulf Magnusson
>
> Applied.
> --
> To unsubscribe fro
On Tue, Jan 30, 2018 at 07:01:40PM +0100, Paolo Abeni wrote:
> Syzbot reported several deadlocks in the netfilter area caused by
> rtnl lock and socket lock being acquired with a different order on
> different code paths, leading to backtraces like the following one:
[...]
> The problem, as Florian
From: Chunhao Lin
Date: Wed, 31 Jan 2018 01:32:36 +0800
> Driver check the wrong register bit in rtl_ocp_tx_cond() that keep driver
> waiting until timeout.
>
> Fix this by waiting for the right register bit.
>
> Signed-off-by: Chunhao Lin
Applied and queued up for -stable.
From: Nikolay Aleksandrov
Date: Wed, 31 Jan 2018 16:29:30 +0200
> When we dump the ip6mr mfc entries via proc, we initialize an iterator
> with the table to dump but we don't clear the cache pointer which might
> be initialized from a prior read on the same descriptor that ended. This
> can resul
From: "Gustavo A. R. Silva"
Date: Tue, 30 Jan 2018 22:21:48 -0600
> Add suffix ULL to constant 8 in order to avoid a potential integer
> overflow and give the compiler complete information about the proper
> arithmetic to use. Notice that this constant is used in a context that
> expects an e
From: Vakul Garg
Date: Wed, 31 Jan 2018 21:34:37 +0530
> Async crypto accelerators (e.g. drivers/crypto/caam) support offloading
> GCM operation. If they are enabled, crypto_aead_encrypt() return error
> code -EINPROGRESS. In this case tls_do_encryption() needs to wait on a
> completion till the
From: "Gustavo A. R. Silva"
Date: Tue, 30 Jan 2018 22:55:33 -0600
> Add suffix LL to constant 1000 in order to give the compiler
> complete information about the proper arithmetic to use. Notice
> that this constant is used in a context that expects an expression
> of type long long int (64 bits,
From: Ulf Magnusson
Date: Tue, 30 Jan 2018 20:05:23 +0100
> In preparation for adding a warning ("kconfig: Warn if help text is
> blank"): https://lkml.org/lkml/2018/1/30/516
>
> Signed-off-by: Ulf Magnusson
Applied.
From: Kristian Evensen
Date: Tue, 30 Jan 2018 14:12:55 +0100
> The Quectel EP06 is a Cat. 6 LTE modem. It uses the same interface as
> the EC20/EC25 for QMI, and requires the same "set DTR"-quirk to work.
>
> Signed-off-by: Kristian Evensen
Applied and queued up for -stable.
From: Christian Brauner
Date: Mon, 29 Jan 2018 18:07:20 +0100
> - Backwards Compatibility:
> If userspace wants to determine whether RTM_NEWLINK supports the
> IFLA_IF_NETNSID property they should first send an RTM_GETLINK request
> with IFLA_IF_NETNSID on lo. If either EACCESS is returned
On 01/31/18 09:34 PM, Vakul Garg wrote:
> Async crypto accelerators (e.g. drivers/crypto/caam) support offloading
> GCM operation. If they are enabled, crypto_aead_encrypt() return error
> code -EINPROGRESS. In this case tls_do_encryption() needs to wait on a
> completion till the time the response
From: Dmitry Vyukov
Date: Wed, 31 Jan 2018 15:49:15 +0100
> Don't we need to Cc stable 2.6 in this case or something like this. We
> want it to be backported.
Networking changes do not CC: stable.
Please read the netdev FAQ, thank you.
From: Alexander Monakov
Date: Wed, 31 Jan 2018 17:05:47 +0300 (MSK)
> And is this a matter of efficiency (not calling napi_schedule when there's
> nothing to do and not keeping interrupts enabled for its duration), or also
> a matter of correctness?
If you don't mask interrupts properly around s
On Wed, Jan 31, 2018 at 3:52 PM, Nikolay Aleksandrov
wrote:
> On 31/01/18 16:49, Dmitry Vyukov wrote:
>> On Wed, Jan 31, 2018 at 3:29 PM, Nikolay Aleksandrov
>> wrote:
>>> When we dump the ip6mr mfc entries via proc, we initialize an iterator
>>> with the table to dump but we don't clear the cach
Hi, Eduardo!
I am working on a frontend driver (PV DRM) and also seeing some strange
things on driver unloading:
xt# rmmod -f drm_xen_front.ko
[ 3236.462497] [drm] Unregistering XEN PV vdispl
[ 3236.485745] [drm:xen_drv_remove [drm_xen_front]] *ERROR* Backend
state is InitWait while removing d
On Wed, Jan 31, 2018 at 02:58:57PM +0200, Andy Shevchenko wrote:
> On Tue, Jan 30, 2018 at 8:25 PM, Colin King wrote:
> > From: Colin Ian King
> >
> > Pointer q is initialized and then almost immediately afterwards being
> > re-assigned the same value. Remove the second redundant assignment.
> >
On 31/01/18 16:49, Dmitry Vyukov wrote:
> On Wed, Jan 31, 2018 at 3:29 PM, Nikolay Aleksandrov
> wrote:
>> When we dump the ip6mr mfc entries via proc, we initialize an iterator
>> with the table to dump but we don't clear the cache pointer which might
>> be initialized from a prior read on the sa
On Wed, 31 Jan 2018 12:58:56 +0100
Daniel Borkmann wrote:
> syzkaller was able to generate the following XDP program ...
>
> (18) r0 = 0x0
> (61) r5 = *(u32 *)(r1 +12)
> (04) (u32) r0 += (u32) 0
> (95) exit
>
> ... and trigger a NULL pointer dereference in ___bpf_prog_run()
> via bpf_pr
On Wed, Jan 31, 2018 at 3:29 PM, Nikolay Aleksandrov
wrote:
> When we dump the ip6mr mfc entries via proc, we initialize an iterator
> with the table to dump but we don't clear the cache pointer which might
> be initialized from a prior read on the same descriptor that ended. This
> can result in
When we dump the ip6mr mfc entries via proc, we initialize an iterator
with the table to dump but we don't clear the cache pointer which might
be initialized from a prior read on the same descriptor that ended. This
can result in lock imbalance (an unnecessary unlock) leading to other
crashes and h
> > +#ifdef CONFIG_NET_POLL_CONTROLLER
> > +static void pxa168_eth_netpoll(struct net_device *dev)
> > +{
> > + struct pxa168_eth_private *pep = netdev_priv(dev);
> > + napi_schedule(&pep->napi);
> > +}
> > +#endif
>
> This definitely is not sufficient.
>
> Look at what other drivers do.
Sor
On Tue, Jan 30, 2018 at 03:21:34PM +0100, Dmitry Vyukov wrote:
> Commit 136e92bbec0a switched local_nodes from an array to a bitmask
> but did not add proper bounds checks. As the result
> clusterip_config_init_nodelist() can both over-read
> ipt_clusterip_tgt_info.local_nodes and over-write
> clus
On Mon, Jan 29, 2018 at 01:21:20PM +0100, Dmitry Vyukov wrote:
> Several netfilter matches and targets put kernel pointers into
> info objects, but don't set usersize in descriptors.
> This leads to kernel pointer leaks if a match/target is set
> and then read back to userspace.
>
> Properly set u
From: Björn Töpel
Buildable skeleton. Move on, nothing to see.
Signed-off-by: Björn Töpel
---
include/linux/socket.h | 5 +-
include/uapi/linux/if_xdp.h | 32 +
net/Kconfig | 1 +
net/Makefile| 1 +
net/core/so
From: Björn Töpel
The XDP_MEM_REG socket option allows a process to register a window of
user space memory to the kernel. This memory will later be used as
frame data buffer.
Signed-off-by: Björn Töpel
---
include/uapi/linux/if_xdp.h | 7 ++
net/xdp/xsk.c | 294
From: Björn Töpel
Added a buff_poll implementation that do page recycling.
Signed-off-by: Björn Töpel
---
drivers/net/ethernet/intel/i40e/buff_pool.c | 385
drivers/net/ethernet/intel/i40e/buff_pool.h | 6 +
2 files changed, 391 insertions(+)
diff --git a/driver
From: Björn Töpel
In this commit we start making use of the new ndo_bpf sub-commands,
and try to enable zero copy, if available.
Signed-off-by: Björn Töpel
---
net/xdp/xsk.c | 185 +-
1 file changed, 145 insertions(+), 40 deletions(-)
di
From: Björn Töpel
Add packet array like functionality that acts directly on the
user/kernel shared ring. We'll use this in the zerocopy Rx scenario.
TODO Better naming...
Signed-off-by: Björn Töpel
---
net/xdp/xsk_ring.c | 3 +-
net/xdp/xsk_ring.h | 136 +
1 - 100 of 162 matches
Mail list logo
