[ANNOUNCE] Linux IPsec workshop 2018

2018-02-08 Thread Steffen Klassert
This is an announce of the Linux IPsec workshop 2018. The workshop will take place in Dresden, Germany, from 26th to 28th March 2018. The workshop is invitation based and limited to ca. 20 - 25 IPsec developers from user and kernel space. We almost reached the limit, but still have a few spare

Re: [PATCH] ath9k: turn on btcoex_enable as default

2018-02-08 Thread Kalle Valo
Kai Heng Feng writes: > Hi Felix, > >> On Feb 8, 2018, at 7:02 PM, Felix Fietkau wrote: >> >> On 2018-02-08 06:28, Kai-Heng Feng wrote: >>> Without btcoex_enable, WiFi activies make both WiFi and Bluetooth >>> unstable if there's a bluetooth

Re: [PATCH iproute2-next v2 0/3] ip/tunnel: Unify tunnel help message print routines

2018-02-08 Thread Serhey Popovych
> To show only relevant diffs of ip and ipv6 variants help message print > routines needs to be unified and improved. > > Get rid of print_usage() and usage() wrappers: use single function to > output help message. As side effect we return -1 from parse function > instead of calling exit(2) in

[PATCH iproute2-next v3 2/3] gre/gre6: Unify gre_print_help()

2018-02-08 Thread Serhey Popovych
Reduce diff lines between gre and gre6 help printing code. Use @struct link_util ->id field to print correct link help: all callers now pass this data structure to gre_print_help(). Get rid of custom print_usage() and usage() functions and use gre_print_help() directly, return from function on

[PATCH iproute2-next v3 3/3] iptnl/ip6tnl: Unify iptunnel_print_help()

2018-02-08 Thread Serhey Popovych
Reduce diff lines between iptnl and ip6tnl help printing code. Use @struct link_util ->id field to print correct link help: all callers now pass this data structure to iptunnel_print_help(). Get rid of custom print_usage() and usage() functions and use iptunnel_print_help() directly, return from

[PATCH iproute2-next v3 1/3] vti/vti6: Unify vti_print_help()

2018-02-08 Thread Serhey Popovych
Reduce diff lines between vti and vti6 help printing code. Use @struct link_util ->id field to print correct link help: all callers now pass this data structure to vti_print_help(). Get rid of custom print_usage() and usage() functions and use vti_print_help() directly, return from function on

[PATCH iproute2-next v3 0/3] ip/tunnel: Unify tunnel help message print routines

2018-02-08 Thread Serhey Popovych
To show only relevant diffs of ip and ipv6 variants help message print routines needs to be unified and improved. Get rid of print_usage() and usage() wrappers: use single function to output help message. As side effect we return -1 from parse function instead of calling exit(2) in case of "...

Re: [PATCH iproute2-next 0/3] ip/tunnel: Unify tunnel help message print routines

2018-02-08 Thread Serhey Popovych
David Ahern wrote: > On 2/8/18 8:35 PM, David Ahern wrote: >> On 2/8/18 3:50 AM, Serhey Popovych wrote: >>> To show only relevant diffs of ip and ipv6 variants help message print >>> routines needs to be unified and improved. >>> >>> Get rid of print_usage() and usage() wrappers: use single

[PATCH iproute2-next v2 3/3] iptnl/ip6tnl: Unify iptunnel_print_help()

2018-02-08 Thread Serhey Popovych
Reduce diff lines between iptnl and ip6tnl help printing code. Use @struct link_util ->id field to print correct link help: all callers now pass this data structure to iptunnel_print_help(). Get rid of custom print_usage() and usage() functions and use ip{,6}tunnel_print_help() directly, return

[PATCH iproute2-next v2 2/3] gre/gre6: Unify gre_print_help()

2018-02-08 Thread Serhey Popovych
Reduce diff lines between gre and gre6 help printing code. Use @struct link_util ->id field to print correct link help: all callers now pass this data structure to gre_print_help(). Get rid of custom print_usage() and usage() functions and use gre_print_help() directly, return from function on

[PATCH iproute2-next v2 0/3] ip/tunnel: Unify tunnel help message print routines

2018-02-08 Thread Serhey Popovych
To show only relevant diffs of ip and ipv6 variants help message print routines needs to be unified and improved. Get rid of print_usage() and usage() wrappers: use single function to output help message. As side effect we return -1 from parse function instead of calling exit(2) in case of "...

[PATCH iproute2-next v2 1/3] vti/vti6: Unify vti_print_help()

2018-02-08 Thread Serhey Popovych
Reduce diff lines between vti and vti6 help printing code. Use @struct link_util ->id field to print correct link help: all callers now pass this data structure to vti_print_help(). Get rid of custom print_usage() and usage() functions and use vti_print_help() directly, return from function on

Re: [BUG] mveta: mvneta_txq_bufs_free NULL pointer dereference

2018-02-08 Thread Sean Nyekjær
On 8 December 2017 at 18:41, Simon Guinot wrote: > On Sat, Dec 02, 2017 at 12:06:12PM +0100, Sean Nyekjær wrote: >> Hi >> >> >> I'm not sure at all, but could you try to apply >> >>

Re: net: phy: question about phy_is_internal for generic-phy

2018-02-08 Thread Kunihiko Hayashi
Hi Andrew, On Thu, 8 Feb 2018 13:51:44 +0100 wrote: > On Thu, Feb 08, 2018 at 07:09:25PM +0900, Kunihiko Hayashi wrote: > > Hello, > > > > Is there a way to specify "phy is internal" to generic phy driver, > > that is, to make phy_is_internal() function available? > > > > I

tg3 crashes under high load, when using 100Mbits

2018-02-08 Thread Kai Heng Feng
Hi Broadcom folks, We are now enabling a new platform with tg3 nic, unfortunately we observed the bug [1] that dated back to 2015. I tried commit 4419bb1cedcd ("tg3: Add workaround to restrict 5762 MRRS to 2048”) but it does’t work. Do you have any idea how to solve the issue? [1]

Re: net: thunder: change q_len's type to handle max ring size

2018-02-08 Thread Sunil Kovvuri
On Fri, Feb 9, 2018 at 3:27 AM, Dean Nelson wrote: > On 02/08/2018 02:34 PM, David Miller wrote: >> >> From: Dean Nelson >> Date: >> >>> The Cavium thunder nicvf driver supports rx/tx rings of up to 65536 >>> entries per. >>> The number of entires are

Re: [PATCH] ath9k: turn on btcoex_enable as default

2018-02-08 Thread Kai Heng Feng
Hi Felix, On Feb 8, 2018, at 7:02 PM, Felix Fietkau wrote: On 2018-02-08 06:28, Kai-Heng Feng wrote: Without btcoex_enable, WiFi activies make both WiFi and Bluetooth unstable if there's a bluetooth connection. Enable this option when bt_ant_diversity is disabled. BugLink:

Re: [PATCH net V3 1/2] ptr_ring: try vmalloc() when kmalloc() fails

2018-02-08 Thread Jason Wang
On 2018年02月09日 11:56, Michael S. Tsirkin wrote: On Fri, Feb 09, 2018 at 11:49:12AM +0800, Jason Wang wrote: On 2018年02月09日 03:17, Michael S. Tsirkin wrote: On Thu, Feb 08, 2018 at 02:58:40PM +0800, Jason Wang wrote: On 2018年02月08日 12:45, Michael S. Tsirkin wrote: On Thu, Feb 08, 2018 at

Re: [PATCH net V3 1/2] ptr_ring: try vmalloc() when kmalloc() fails

2018-02-08 Thread Michael S. Tsirkin
On Fri, Feb 09, 2018 at 11:49:12AM +0800, Jason Wang wrote: > > > On 2018年02月09日 03:17, Michael S. Tsirkin wrote: > > On Thu, Feb 08, 2018 at 02:58:40PM +0800, Jason Wang wrote: > > > On 2018年02月08日 12:45, Michael S. Tsirkin wrote: > > > > On Thu, Feb 08, 2018 at 11:59:24AM +0800, Jason Wang

Re: [PATCH iproute2-next 0/3] ip/tunnel: Unify tunnel help message print routines

2018-02-08 Thread David Ahern
On 2/8/18 8:35 PM, David Ahern wrote: > On 2/8/18 3:50 AM, Serhey Popovych wrote: >> To show only relevant diffs of ip and ipv6 variants help message print >> routines needs to be unified and improved. >> >> Get rid of print_usage() and usage() wrappers: use single function to >> output help

Re: [PATCH net V3 2/2] ptr_ring: fail on large queue size (>64K)

2018-02-08 Thread Jason Wang
On 2018年02月09日 03:09, David Miller wrote: From: Jason Wang Date: Thu, 8 Feb 2018 11:59:25 +0800 We need limit the maximum size of queue, otherwise it may cause several side effects e.g slab will warn when the size exceeds KMALLOC_MAX_SIZE. Using KMALLOC_MAX_SIZE still

Re: [PATCH net V3 2/2] ptr_ring: fail on large queue size (>64K)

2018-02-08 Thread Jason Wang
On 2018年02月08日 23:50, Michael S. Tsirkin wrote: On Thu, Feb 08, 2018 at 03:11:22PM +0800, Jason Wang wrote: On 2018年02月08日 12:52, Michael S. Tsirkin wrote: On Thu, Feb 08, 2018 at 11:59:25AM +0800, Jason Wang wrote: We need limit the maximum size of queue, otherwise it may cause several

Re: [PATCH net V3 1/2] ptr_ring: try vmalloc() when kmalloc() fails

2018-02-08 Thread Jason Wang
On 2018年02月09日 03:17, Michael S. Tsirkin wrote: On Thu, Feb 08, 2018 at 02:58:40PM +0800, Jason Wang wrote: On 2018年02月08日 12:45, Michael S. Tsirkin wrote: On Thu, Feb 08, 2018 at 11:59:24AM +0800, Jason Wang wrote: This patch switch to use kvmalloc_array() for using a vmalloc() fallback to

Re: [PATCH iproute2-next 0/3] ip/tunnel: Unify tunnel help message print routines

2018-02-08 Thread David Ahern
On 2/8/18 3:50 AM, Serhey Popovych wrote: > To show only relevant diffs of ip and ipv6 variants help message print > routines needs to be unified and improved. > > Get rid of print_usage() and usage() wrappers: use single function to > output help message. As side effect we return -1 from parse

tcp_probe tracepoint only when cwnd changes

2018-02-08 Thread Md. Islam
Hi I'm using tcp_probe tracepoint as [1]. It takes a snapshot each time tcp_rcv_established() is called. However I need to take a snapshot only when congestion window changes. Old tcp_probe had full=0 option to achieve this. Is there a way to achieve this using tcp_probe tracepoint? Many thanks

Re: [bpf-next V3 PATCH 0/5] tools/libbpf improvements and selftests

2018-02-08 Thread Daniel Borkmann
On 02/08/2018 12:48 PM, Jesper Dangaard Brouer wrote: > While playing with using libbpf for the Suricata project, we had > issues LLVM >= 4.0.1 generating ELF files that could not be loaded > with libbpf (tools/lib/bpf/). > > During the troubleshooting phase, I wrote a test program and improved >

pull-request: bpf 2018-02-09

2018-02-08 Thread Daniel Borkmann
Hi David, The following pull-request contains BPF updates for your *net* tree. The main changes are: 1) Two fixes for BPF sockmap in order to break up circular map references from programs attached to sockmap, and detaching related sockets in case of socket close() event. For the latter

Re: [PATCH v2] rtlwifi: rtl8192cu: Remove variable self-assignment in rf.c

2018-02-08 Thread Guenter Roeck
On Thu, Feb 8, 2018 at 4:57 PM, Matthias Kaehlcke wrote: > In _rtl92c_get_txpower_writeval_by_regulatory() the variable writeVal > is assigned to itself in an if ... else statement, apparently only to > document that the branch condition is handled and that a previously read >

Re: [PATCH v2] rtlwifi: rtl8192cu: Remove variable self-assignment in rf.c

2018-02-08 Thread Larry Finger
On 02/08/2018 06:57 PM, Matthias Kaehlcke wrote: In _rtl92c_get_txpower_writeval_by_regulatory() the variable writeVal is assigned to itself in an if ... else statement, apparently only to document that the branch condition is handled and that a previously read value should be returned

[PATCH v2] rtlwifi: rtl8192cu: Remove variable self-assignment in rf.c

2018-02-08 Thread Matthias Kaehlcke
In _rtl92c_get_txpower_writeval_by_regulatory() the variable writeVal is assigned to itself in an if ... else statement, apparently only to document that the branch condition is handled and that a previously read value should be returned unmodified. The self-assignment causes clang to raise the

Re: sctp: skb_over_panic on INIT/INIT_ACK packet sending

2018-02-08 Thread Marcelo Ricardo Leitner
Hi, On Fri, Feb 09, 2018 at 02:38:59AM +0300, Alexey Kodanev wrote: > Hi, > > Got the following panic when the received INIT packet has a lot of > address parameters, so that the INIT_ACK chunksize exceeds > SCTP_MAX_CHUNK_LEN: > > [ 597.804948] skbuff: skb_over_panic: text:ffae06e4

sctp: skb_over_panic on INIT/INIT_ACK packet sending

2018-02-08 Thread Alexey Kodanev
Hi, Got the following panic when the received INIT packet has a lot of address parameters, so that the INIT_ACK chunksize exceeds SCTP_MAX_CHUNK_LEN: [ 597.804948] skbuff: skb_over_panic: text:ffae06e4 len:120168 put:120156 head:7aa47635 data:d991c2de

Re: [RFC PATCH 00/24] Introducing AF_XDP support

2018-02-08 Thread Willem de Bruijn
On Wed, Feb 7, 2018 at 4:28 PM, Björn Töpel wrote: > 2018-02-07 16:54 GMT+01:00 Willem de Bruijn : >>> We realized, a bit late maybe, that 24 patches is a bit mouthful, so >>> let me try to make it more palatable. >> >> Overall, this

Re: [PATCH net 1/1 v4] rtnetlink: require unique netns identifier

2018-02-08 Thread Christian Brauner
On Thu, Feb 8, 2018 at 8:33 PM, David Miller wrote: > From: Christian Brauner > Date: Wed, 7 Feb 2018 13:53:20 +0100 > >> Since we've added support for IFLA_IF_NETNSID for RTM_{DEL,GET,SET,NEW}LINK >> it is possible for userspace to send us

Re: [PATCH iproute2 v1] ip netns: allow negative nsid

2018-02-08 Thread Christian Brauner
On Thu, Feb 8, 2018 at 5:01 PM, Stephen Hemminger wrote: > On Tue, 6 Feb 2018 19:39:31 +0100 > Christian Brauner wrote: > >> If the kernel receives a negative nsid it will automatically assign the >> next available nsid. In this case

linux-next: Signed-off-by missing for commit in the net tree

2018-02-08 Thread Stephen Rothwell
Hi all, Commit 55b3280d1e47 ("tipc: fix skb truesize/datasize ratio control") is missing a Signed-off-by from its author. -- Cheers, Stephen Rothwell

Re: net: thunder: change q_len's type to handle max ring size

2018-02-08 Thread Dean Nelson
On 02/08/2018 02:34 PM, David Miller wrote: From: Dean Nelson Date: The Cavium thunder nicvf driver supports rx/tx rings of up to 65536 entries per. The number of entires are stored in the q_len member of struct q_desc_mem. The problem is that q_len being a u16, results in

Re: [Patch net v2] ipt_CLUSTERIP: fix a refcount bug in clusterip_config_find_get()

2018-02-08 Thread Florian Westphal
Cong Wang wrote: > In clusterip_config_find_get() we hold RCU read lock so it could > run concurrently with clusterip_config_entry_put(), as a result, > the refcnt could go back to 1 from 0, which leads to a double > list_del()... Just replace refcount_inc() with >

[Patch net v2] ipt_CLUSTERIP: fix a refcount bug in clusterip_config_find_get()

2018-02-08 Thread Cong Wang
In clusterip_config_find_get() we hold RCU read lock so it could run concurrently with clusterip_config_entry_put(), as a result, the refcnt could go back to 1 from 0, which leads to a double list_del()... Just replace refcount_inc() with refcount_inc_not_zero(), as for c->refcount. Fixes:

Re: [PATCH v2 1/2] net, can, ifi: fix "write buffer full" error

2018-02-08 Thread Marek Vasut
On 02/08/2018 10:33 PM, Marc Kleine-Budde wrote: > On 02/08/2018 08:22 PM, Marek Vasut wrote: >> On 02/08/2018 03:46 PM, Marc Kleine-Budde wrote: >>> On 02/08/2018 07:47 AM, Heiko Schocher wrote: the driver reads in the ISR first the IRQpending register, and clears after that in a write

Re: [PATCH v2 1/2] net, can, ifi: fix "write buffer full" error

2018-02-08 Thread Marc Kleine-Budde
On 02/08/2018 08:22 PM, Marek Vasut wrote: > On 02/08/2018 03:46 PM, Marc Kleine-Budde wrote: >> On 02/08/2018 07:47 AM, Heiko Schocher wrote: >>> the driver reads in the ISR first the IRQpending register, >>> and clears after that in a write *all* bits in it. >>> >>> It could happen that the isr

Re: [PATCH] net: Whitelist the skbuff_head_cache "cb" field

2018-02-08 Thread David Miller
From: Kees Cook Date: Fri, 9 Feb 2018 08:01:12 +1100 > Cool, thanks. And just to be clear, if it's not already obvious, this > patch needs kmem_cache_create_usercopy() which just landed in Linus's > tree last week, in case you've not merged yet. Understood, and 'net' has

Re: [PATCH] net: Whitelist the skbuff_head_cache "cb" field

2018-02-08 Thread Kees Cook
On Fri, Feb 9, 2018 at 7:16 AM, David Miller wrote: > From: Kees Cook > Date: Wed, 7 Feb 2018 17:44:38 -0800 > >> Most callers of put_cmsg() use a "sizeof(foo)" for the length argument. >> Within put_cmsg(), a copy_to_user() call is made with a dynamic

Re: [PATCH net v3] net: phy: fix phy_start to consider PHY_IGNORE_INTERRUPT

2018-02-08 Thread David Miller
From: Heiner Kallweit Date: Thu, 8 Feb 2018 21:01:48 +0100 > This condition wasn't adjusted when PHY_IGNORE_INTERRUPT (-2) was added > long ago. In case of PHY_IGNORE_INTERRUPT the MAC interrupt indicates > also PHY state changes and we should do what the symbol says. > >

Re: net: thunder: change q_len's type to handle max ring size

2018-02-08 Thread David Miller
From: Dean Nelson Date: > The Cavium thunder nicvf driver supports rx/tx rings of up to 65536 entries > per. > The number of entires are stored in the q_len member of struct q_desc_mem. The > problem is that q_len being a u16, results in 65536 becoming 0. > > In getting

Re: pull-request: wireless-drivers-next 2018-02-08

2018-02-08 Thread David Miller
From: Kalle Valo Date: Thu, 08 Feb 2018 19:54:15 +0200 > first set of fixes for 4.16, unusually many when the merge window hasn't > even closed yet. Especially the ssb fix is important so I hope there's > still time to get this to 4.16-rc1. As you can see from the diffstat

Re: [net 1/1] tipc: fix skb truesize/datasize ratio control

2018-02-08 Thread David Miller
From: Jon Maloy Date: Thu, 8 Feb 2018 17:16:25 +0100 > From: Hoang Le > > In commit d618d09a68e4 ("tipc: enforce valid ratio between skb truesize > and contents") we introduced a test for ensuring that the condition > truesize/datasize <= 4 is

Re: [PATCH net] net/sched: cls_u32: fix cls_u32 on filter replace

2018-02-08 Thread David Miller
From: Ivan Vecera Date: Thu, 8 Feb 2018 16:10:39 +0100 > The following sequence is currently broken: > > # tc qdisc add dev foo ingress > # tc filter replace dev foo protocol all ingress \ >u32 match u8 0 0 action mirred egress mirror dev bar1 > # tc filter replace

Re: [PATCH] mpls, nospec: Sanitize array index in mpls_label_ok()

2018-02-08 Thread David Miller
From: Dan Williams Date: Wed, 07 Feb 2018 22:34:24 -0800 > mpls_label_ok() validates that the 'platform_label' array index from a > userspace netlink message payload is valid. Under speculation the > mpls_label_ok() result may not resolve in the CPU pipeline until after

Re: [PATCH V2 net-next] rds: tcp: use rds_destroy_pending() to synchronize netns/module teardown and rds connection/workq management

2018-02-08 Thread David Miller
From: Sowmini Varadhan Date: Thu, 8 Feb 2018 15:19:05 -0500 > I was just checking the patchq for the fate of this patch and find > it marked "superseded" in http://patchwork.ozlabs.org/patch/868902/ > > I'm intrigued, superseded by what? My bad, I'll apply this. I

Re: [PATCH V2 net-next] rds: tcp: use rds_destroy_pending() to synchronize netns/module teardown and rds connection/workq management

2018-02-08 Thread Sowmini Varadhan
I was just checking the patchq for the fate of this patch and find it marked "superseded" in http://patchwork.ozlabs.org/patch/868902/ I'm intrigued, superseded by what? --Sowmini

Re: [PATCH] net: Whitelist the skbuff_head_cache "cb" field

2018-02-08 Thread David Miller
From: Kees Cook Date: Wed, 7 Feb 2018 17:44:38 -0800 > Most callers of put_cmsg() use a "sizeof(foo)" for the length argument. > Within put_cmsg(), a copy_to_user() call is made with a dynamic size, as a > result of the cmsg header calculations. This means that hardened

Re: [PATCH] net: Extra '_get' in declaration of arch_get_platform_mac_address

2018-02-08 Thread David Miller
From: Mathieu Malaterre Date: Wed, 7 Feb 2018 20:35:00 +0100 > In commit c7f5d105495a ("net: Add eth_platform_get_mac_address() helper."), > two declarations were added: > > int eth_platform_get_mac_address(struct device *dev, u8 *mac_addr); > unsigned char

Re: [PATCH net-next] ibmvnic: queue reset when CRQ gets closed during reset

2018-02-08 Thread David Miller
From: Nathan Fontenot Date: Wed, 07 Feb 2018 13:00:24 -0600 > While handling a driver reset we get a H_CLOSED return trying > to send a CRQ event. When this occurs we need to queue up another > reset attempt. Without doing this we see instances where the driver > is

Re: [PATCH v2 1/2] net, can, ifi: fix "write buffer full" error

2018-02-08 Thread Marek Vasut
On 02/08/2018 03:46 PM, Marc Kleine-Budde wrote: > On 02/08/2018 07:47 AM, Heiko Schocher wrote: >> the driver reads in the ISR first the IRQpending register, >> and clears after that in a write *all* bits in it. >> >> It could happen that the isr register raise bits between >> this 2 register

Re: [PATCH] atm: he: use 64-bit arithmetic instead of 32-bit

2018-02-08 Thread David Miller
From: "Gustavo A. R. Silva" Date: Wed, 7 Feb 2018 10:17:29 -0600 > Add suffix ULL to constants 272, 204, 136 and 68 in order to give the > compiler complete information about the proper arithmetic to use. > Notice that these constants are used in contexts that expect >

Re: [Patch net] ipt_CLUSTERIP: fix a refcount bug in clusterip_config_find_get()

2018-02-08 Thread Cong Wang
On Thu, Feb 8, 2018 at 12:01 AM, Florian Westphal wrote: > Cong Wang wrote: >> In clusterip_config_find_get() we hold RCU read lock so it could >> run concurrently with clusterip_config_entry_put(), as a result, >> the refcnt could go back to 1 from 0,

Re: [PATCH net v3] net: phy: fix phy_start to consider PHY_IGNORE_INTERRUPT

2018-02-08 Thread Florian Fainelli
On 02/08/2018 12:01 PM, Heiner Kallweit wrote: > This condition wasn't adjusted when PHY_IGNORE_INTERRUPT (-2) was added > long ago. In case of PHY_IGNORE_INTERRUPT the MAC interrupt indicates > also PHY state changes and we should do what the symbol says. > > Fixes: 84a527a41f38 ("net: phylib:

[PATCH net v3] net: phy: fix phy_start to consider PHY_IGNORE_INTERRUPT

2018-02-08 Thread Heiner Kallweit
This condition wasn't adjusted when PHY_IGNORE_INTERRUPT (-2) was added long ago. In case of PHY_IGNORE_INTERRUPT the MAC interrupt indicates also PHY state changes and we should do what the symbol says. Fixes: 84a527a41f38 ("net: phylib: fix interrupts re-enablement in phy_start") Signed-off-by:

Linux Plumbers Networking Track CFP

2018-02-08 Thread David Miller
This is a call for proposals for the networking track at the Linux Plumbers Conference in Vancouver, which will be happening on November 13th and November 14th. We are seeking talks of 40 minutes in length, accompanied by papers of 2 to 10 pages in length. Please submit your proposals to the

Re: [PATCH v3 1/1] tcp: Honor the eor bit in tcp_mtu_probe

2018-02-08 Thread David Miller
From: Ilya Lesokhin Date: Wed, 7 Feb 2018 15:13:11 +0200 > +static bool tcp_can_coalesce_send_queue_head(struct sock *sk, int len) > +{ > + struct sk_buff *skb, *next; > + > + skb = tcp_send_head(sk); > + tcp_for_write_queue_from_safe(skb, next, sk) > + {

[RFC PATCH bpf-next 2/2] bpf/verifier: update selftests

2018-02-08 Thread Edward Cree
Error messages for some bad programs have changed, partly because we now check for loops / out-of-bounds jumps before checking subprogs. Problematic selftests: 513 calls: wrong recursive calls This is now rejected with 'unreachable insn 1'. I'm not entirely sure what it was meant to do/test,

Re: [PATCH net 1/1 v4] rtnetlink: require unique netns identifier

2018-02-08 Thread David Miller
From: Christian Brauner Date: Wed, 7 Feb 2018 13:53:20 +0100 > Since we've added support for IFLA_IF_NETNSID for RTM_{DEL,GET,SET,NEW}LINK > it is possible for userspace to send us requests with three different > properties to identify a target network namespace.

[RFC PATCH bpf-next 1/2] bpf/verifier: validate func_calls by marking at do_check() time

2018-02-08 Thread Edward Cree
Removes a couple of passes from the verifier, one to check subprogs don't overlap etc., and one to compute max stack depth (which now is done by topologically sorting the call graph). Signed-off-by: Edward Cree --- include/linux/bpf_verifier.h | 24 ++-

[RFC PATCH bpf-next 0/2] bpf/verifier: simplify subprog tracking

2018-02-08 Thread Edward Cree
By storing subprog boundaries as a subprogno mark on each insn, rather than a start (and implicit end) for each subprog, we collect a number of gains: * More efficient determination of which subprog contains a given insn, and thus of find_subprog (which subprog begins at a given insn). * Number

net: thunder: change q_len's type to handle max ring size

2018-02-08 Thread Dean Nelson
The Cavium thunder nicvf driver supports rx/tx rings of up to 65536 entries per. The number of entires are stored in the q_len member of struct q_desc_mem. The problem is that q_len being a u16, results in 65536 becoming 0. In getting pointers to descriptors in the rings, the driver uses q_len

Re: [PATCH net V3 1/2] ptr_ring: try vmalloc() when kmalloc() fails

2018-02-08 Thread Michael S. Tsirkin
On Thu, Feb 08, 2018 at 02:58:40PM +0800, Jason Wang wrote: > > > On 2018年02月08日 12:45, Michael S. Tsirkin wrote: > > On Thu, Feb 08, 2018 at 11:59:24AM +0800, Jason Wang wrote: > > > This patch switch to use kvmalloc_array() for using a vmalloc() > > > fallback to help in case kmalloc() fails.

Re: [V9fs-developer] [PATCH] 9p/trans_virtio: discard zero-length reply

2018-02-08 Thread Michael S. Tsirkin
OK, I've queued it. On Thu, Feb 08, 2018 at 06:52:32PM +0100, Greg Kurz wrote: > Ping ? > > Michael, > > Since this is virtio code and you have acked the QEMU part of the fix already, > would you be kind enough to take this through your tree ? > > Cheers, > > -- > Greg > > On Mon, 22 Jan

Re: [PATCH net] tuntap: add missing xdp flush

2018-02-08 Thread David Miller
From: Jason Wang Date: Wed, 7 Feb 2018 17:14:46 +0800 > When using devmap to redirect packets between interfaces, > xdp_do_flush() is usually a must to flush any batched > packets. Unfortunately this is missed in current tuntap > implementation. > > Unlike most hardware

Re: [PATCH net V3 2/2] ptr_ring: fail on large queue size (>64K)

2018-02-08 Thread David Miller
From: Jason Wang Date: Thu, 8 Feb 2018 11:59:25 +0800 > We need limit the maximum size of queue, otherwise it may cause > several side effects e.g slab will warn when the size exceeds > KMALLOC_MAX_SIZE. Using KMALLOC_MAX_SIZE still looks too so this patch > tries to limit

Re: [PATCH net] netlink: ensure to loop over all netns in genlmsg_multicast_allns()

2018-02-08 Thread David Miller
From: Nicolas Dichtel Date: Tue, 6 Feb 2018 14:48:32 +0100 > Nowadays, nlmsg_multicast() returns only 0 or -ESRCH but this was not the > case when commit 134e63756d5f was pushed. > However, there was no reason to stop the loop if a netns does not have > listeners. >

Re: [PATCH] net: ethernet: ti: cpsw: fix net watchdog timeout

2018-02-08 Thread David Miller
From: Grygorii Strashko Date: Thu, 8 Feb 2018 10:04:31 -0600 > Could this be marked as stable material 4.9+? Sure, queued up.

Re: [PATCH net] rxrpc: Don't put crypto buffers on the stack

2018-02-08 Thread David Miller
From: David Howells Date: Thu, 08 Feb 2018 15:59:07 + > Don't put buffers of data to be handed to crypto on the stack as this may > cause an assertion failure in the kernel (see below). Fix this by using an > kmalloc'd buffer instead. ... > Reported-by: Jonathan

Re: [V9fs-developer] [PATCH] 9p/trans_virtio: discard zero-length reply

2018-02-08 Thread Greg Kurz
Ping ? Michael, Since this is virtio code and you have acked the QEMU part of the fix already, would you be kind enough to take this through your tree ? Cheers, -- Greg On Mon, 22 Jan 2018 22:02:05 +0100 Greg Kurz wrote: > When a 9p request is successfully flushed, the

Re: [RFC][PATCH bpf 1/2] bpf: allow 64-bit offsets for bpf function calls

2018-02-08 Thread Naveen N. Rao
Alexei Starovoitov wrote: On 2/8/18 4:03 AM, Sandipan Das wrote: The imm field of a bpf_insn is a signed 32-bit integer. For JIT-ed bpf-to-bpf function calls, it stores the offset from __bpf_call_base to the start of the callee function. For some architectures, such as powerpc64, it was found

pull-request: wireless-drivers-next 2018-02-08

2018-02-08 Thread Kalle Valo
Hi Dave, first set of fixes for 4.16, unusually many when the merge window hasn't even closed yet. Especially the ssb fix is important so I hope there's still time to get this to 4.16-rc1. As you can see from the diffstat there's one PCI id addition but that has been acked by Bjorn. Please let

[PATCH] net/9p: avoid -ERESTARTSYS leak to userspace

2018-02-08 Thread Greg Kurz
If it was interrupted by a signal, the 9p client may need to send some more requests to the server for cleanup before returning to userspace. To avoid such a last minute request to be interrupted right away, the client memorizes if a signal is pending, clear TIF_SIGPENDING, handle the request and

Re: [RFC][PATCH bpf 1/2] bpf: allow 64-bit offsets for bpf function calls

2018-02-08 Thread Alexei Starovoitov
On 2/8/18 4:03 AM, Sandipan Das wrote: The imm field of a bpf_insn is a signed 32-bit integer. For JIT-ed bpf-to-bpf function calls, it stores the offset from __bpf_call_base to the start of the callee function. For some architectures, such as powerpc64, it was found that this offset may be as

Re: USB rndis_host - slow download transfers, RX errors

2018-02-08 Thread Tomasz Janowski
On Thursday, February 8, 2018 5:37:25 PM EST Greg KH wrote: > On Thu, Feb 08, 2018 at 10:53:20AM -0500, Tomasz Janowski wrote: > > On Thursday, February 8, 2018 3:43:05 PM EST Greg KH wrote: > > > On Thu, Feb 08, 2018 at 02:16:08PM +, Tomasz Janowski, Ph.D. wrote: > > > > Dear USB developers,

Re: [Patch net] ipt_CLUSTERIP: fix a race condition of proc file creation

2018-02-08 Thread Pablo Neira Ayuso
On Wed, Feb 07, 2018 at 09:59:17PM -0800, Cong Wang wrote: > There is a race condition between clusterip_config_entry_put() > and clusterip_config_init(), after we release the spinlock in > clusterip_config_entry_put(), a new proc file with a same IP could > be created immediately since it is

Re: [PATCH v4 3/3] qemu: add linkspeed and duplex settings to virtio-net

2018-02-08 Thread Michael S. Tsirkin
On Fri, Jan 05, 2018 at 05:44:55PM -0500, Jason Baron wrote: > Although linkspeed and duplex can be set in a linux guest via 'ethtool -s', > this requires custom ethtool commands for virtio-net by default. > > Introduce a new feature flag, VIRTIO_NET_F_SPEED_DUPLEX, which allows > the hypervisor

Re: USB rndis_host - slow download transfers, RX errors

2018-02-08 Thread Greg KH
On Thu, Feb 08, 2018 at 10:53:20AM -0500, Tomasz Janowski wrote: > On Thursday, February 8, 2018 3:43:05 PM EST Greg KH wrote: > > On Thu, Feb 08, 2018 at 02:16:08PM +, Tomasz Janowski, Ph.D. wrote: > > > Dear USB developers, > > > > > > Based on my google research, the problem I experience

[PATCH iproute2-next 3/4] json: fix newline at end of array

2018-02-08 Thread Stephen Hemminger
From: Stephen Hemminger The json print library was toggling pretty print at the end of an array to workaround a bug in underlying json_writer. Instead, just fix json_writer to pretty print array correctly. Signed-off-by: Stephen Hemminger

[PATCH iproute2-next 0/4] JSON (and color) support for iproute

2018-02-08 Thread Stephen Hemminger
From: Stephen Hemminger This set of patches adds JSON output to route printing. Tested for the simple cases, but there are many variations and there such as lw tunnels which have not be tested. The color formatting may need some additional tweaks. It looks like for

[PATCH iproute2-next 4/4] iproute: implement JSON and color output

2018-02-08 Thread Stephen Hemminger
From: Stephen Hemminger Add JSON and color output formatting to ip route command. Similar to existing address and link output. Signed-off-by: Stephen Hemminger --- include/utils.h | 5 + ip/iproute.c | 376

[PATCH iproute2-next 2/4] man: add documentation for json and pretty flags

2018-02-08 Thread Stephen Hemminger
From: Stephen Hemminger Add description for -json and -pretty options. Signed-off-by: Stephen Hemminger --- ip/ip.c | 4 ++-- man/man8/ip.8 | 18 ++ man/man8/tc.8 | 3 ++- 3 files changed, 18 insertions(+), 7

[PATCH iproute2-next 1/4] json: make pretty printing optional

2018-02-08 Thread Stephen Hemminger
From: Stephen Hemminger Since JSON is intended for programmatic consumption, it makes sense for the default output format to be concise as possible. For programmer and other uses, it is helpful to keep the pretty whitespace format; therefore enable it with -p flag.

Re: [PATCH RFC 2/4] netlink: add generic object description infrastructure

2018-02-08 Thread Pablo Neira Ayuso
Hi Randy, On Wed, Feb 07, 2018 at 05:28:20PM -0800, Randy Dunlap wrote: [...] > > diff --git a/include/net/nldesc.h b/include/net/nldesc.h > > new file mode 100644 > > index ..19306a648f10 > > --- /dev/null > > +++ b/include/net/nldesc.h > > @@ -0,0 +1,160 @@ > > +/*

[net 1/1] tipc: fix skb truesize/datasize ratio control

2018-02-08 Thread Jon Maloy
From: Hoang Le In commit d618d09a68e4 ("tipc: enforce valid ratio between skb truesize and contents") we introduced a test for ensuring that the condition truesize/datasize <= 4 is true for a received buffer. Unfortunately this test has two problems. - Because of the

[PULL] virtio, vhost: fixes, cleanups, features

2018-02-08 Thread Michael S. Tsirkin
The following changes since commit d8a5b80568a9cb66810e75b182018e9edb68e8ff: Linux 4.15 (2018-01-28 13:20:33 -0800) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git tags/for_linus for you to fetch changes up to

[PATCH iproute2-next] ip: Use print_0xhex() where appropriate

2018-02-08 Thread Serhey Popovych
In gre/gre6 for non-JSON output 0x%x format is used: use print_0xhex() to get the same value for JSON. Get rid of custom _print_hex() in bridge slave code: print_0xhex() can be used perfectly. Break long print_uint() with long argument list to fit into 80 columns. Signed-off-by: Serhey Popovych

Re: [PATCH] net: ethernet: ti: cpsw: fix net watchdog timeout

2018-02-08 Thread Grygorii Strashko
On 02/07/2018 08:57 PM, David Miller wrote: From: Grygorii Strashko Date: Tue, 6 Feb 2018 19:17:06 -0600 It was discovered that simple program which indefinitely sends 200b UDP packets and runs on TI AM574x SoC (SMP) under RT Kernel triggers network watchdog

Re: [PATCH iproute2 v1] ip netns: allow negative nsid

2018-02-08 Thread Stephen Hemminger
On Tue, 6 Feb 2018 19:39:31 +0100 Christian Brauner wrote: > If the kernel receives a negative nsid it will automatically assign the > next available nsid. In this case alloc_netid() will set min and max to > 0 for ird_alloc(). And when max == 0 idr_alloc() will

[PATCH net] rxrpc: Don't put crypto buffers on the stack

2018-02-08 Thread David Howells
Don't put buffers of data to be handed to crypto on the stack as this may cause an assertion failure in the kernel (see below). Fix this by using an kmalloc'd buffer instead. kernel BUG at ./include/linux/scatterlist.h:147! ... RIP: 0010:rxkad_encrypt_response.isra.6+0x191/0x1b0 [rxrpc] RSP:

Re: USB rndis_host - slow download transfers, RX errors

2018-02-08 Thread Tomasz Janowski
On Thursday, February 8, 2018 3:43:05 PM EST Greg KH wrote: > On Thu, Feb 08, 2018 at 02:16:08PM +, Tomasz Janowski, Ph.D. wrote: > > Dear USB developers, > > > > Based on my google research, the problem I experience seems to happen > > with some newer smartphones. My test case is Samsung

Re: [PATCH net V3 2/2] ptr_ring: fail on large queue size (>64K)

2018-02-08 Thread Michael S. Tsirkin
On Thu, Feb 08, 2018 at 03:11:22PM +0800, Jason Wang wrote: > > > On 2018年02月08日 12:52, Michael S. Tsirkin wrote: > > On Thu, Feb 08, 2018 at 11:59:25AM +0800, Jason Wang wrote: > > > We need limit the maximum size of queue, otherwise it may cause > > > several side effects e.g slab will warn

Re: [PATCH net] ptr_ring: fail early if queue occupies more than KMALLOC_MAX_SIZE

2018-02-08 Thread Michael S. Tsirkin
On Wed, Feb 07, 2018 at 04:08:25PM +0800, Jason Wang wrote: > To avoid slab to warn about exceeded size, fail early if queue > occupies more than KMALLOC_MAX_SIZE. > > Reported-by: syzbot+e4d4f9ddd42955397...@syzkaller.appspotmail.com > Signed-off-by: Jason Wang > --- >

Re: USB rndis_host - slow download transfers, RX errors

2018-02-08 Thread Greg KH
On Thu, Feb 08, 2018 at 02:16:08PM +, Tomasz Janowski, Ph.D. wrote: > Dear USB developers, > > Based on my google research, the problem I experience seems to happen > with some newer smartphones. My test case is Samsung Galaxy S8 (SM-950U1). I > am > trying to use USB tethering and

[PATCH net] net/sched: cls_u32: fix cls_u32 on filter replace

2018-02-08 Thread Ivan Vecera
The following sequence is currently broken: # tc qdisc add dev foo ingress # tc filter replace dev foo protocol all ingress \ u32 match u8 0 0 action mirred egress mirror dev bar1 # tc filter replace dev foo protocol all ingress \ handle 800::800 pref 49152 \ u32 match u8 0 0 action

Re: [PATCH net 0/5] nfp: fix disabling TC offloads in flower, max TSO segs and module version

2018-02-08 Thread David Miller
From: Jakub Kicinski Date: Wed, 7 Feb 2018 20:55:21 -0800 > This set corrects the way nfp deals with the NETIF_F_HW_TC flag. > It has slipped the review that flower offload does not currently > refuse disabling this flag when filter offload is active. > > nfp's

  1   2   >