Re: [PATCH 5/5] mtd: Stop updating erase_info->state and calling mtd_erase_callback()

Hi Boris, Just a few comments about the form. Otherwise: Reviewed-by: Miquel Raynal > diff --git a/drivers/mtd/devices/lart.c b/drivers/mtd/devices/lart.c > index 555b94406e0b..3d6c8ffd351f 100644 > --- a/drivers/mtd/devices/lart.c > +++ b/drivers/mtd/devices/lart.c

Re: [PATCH net] sctp: rename sctp_diag.c as diag.c

On Mon, Feb 12, 2018 at 11:12 PM, David Miller wrote: > From: Marcelo Ricardo Leitner > Date: Mon, 12 Feb 2018 10:37:04 -0200 > >> On Mon, Feb 12, 2018 at 06:32:30PM +0800, Xin Long wrote: >>> Remove sctp_ prefix for diag file, to keep consistent

Re: [PATCH net] sctp: fix some copy-paste errors for file comments

On Mon, Feb 12, 2018 at 10:12 PM, Neil Horman wrote: > On Mon, Feb 12, 2018 at 06:30:34PM +0800, Xin Long wrote: >> This patch is to fix the file comments in stream.c and >> stream_interleave.c >> >> Fixes: a83863174a61 ("sctp: prepare asoc stream for stream reconf") >>

Re: [PATCH ipsec,v2] net: xfrm_policy: fix device unregistration hang

On Mon, Feb 12, 2018 at 08:58:28PM +0200, Eyal Birger wrote: > In setups like the following: > >Host A --Host B > tun0 -- ipsec -- eth0 -- eth0 -- ipsec -- tun0 > > where tun0 are tunnel devices using dst_cache (ipip, ipip6, etc...). > > Unregistration of an

Re: [PATCH net-next] trace_events_filter: conditional trace event (tcp_probe full=0)

On Mon, Feb 12, 2018 at 11:29 AM, Masami Hiramatsu wrote: > On Mon, 12 Feb 2018 00:08:46 -0500 > "Md. Islam" wrote: > >> Recently tcp_probe kernel module has been replaced by trace_event. Old >> tcp_probe had full=0 option where it only takes a snapshot

[PATCH net] net: fix race on decreasing number of TX queues

netif_set_real_num_tx_queues() can be called when netdev is up. That usually happens when user requests change of number of channels/rings with ethtool -L. The procedure for changing the number of queues involves resetting the qdiscs and setting dev->num_tx_queues to the new value. When the new

Re: net: phy: question about phy_is_internal for generic-phy

Hi Andrew, Thank you for your advice. On Fri, 9 Feb 2018 15:59:54 +0100 wrote: > > There are some SoCs that have a built-in phy, and sometimes > > these SoCs can choose to use built-in phy or external phy. > > O.K. This is the same use case we had at the end of last year. > >

Re: [RFC PATCH bpf-next 0/2] bpf/verifier: simplify subprog tracking

On 02/12/2018 02:22 AM, Edward Cree wrote: > On 10/02/18 03:18, Alexei Starovoitov wrote: >> On Thu, Feb 08, 2018 at 07:31:55PM +, Edward Cree wrote: >>> By storing subprog boundaries as a subprogno mark on each insn, rather than >>> a start (and implicit end) for each subprog, we collect a

Re: [PATCH net v4 09/13] net/mac8390: Convert to nubus_driver

On Mon, 12 Feb 2018, Geert Uytterhoeven wrote: > On Mon, Feb 12, 2018 at 4:08 AM, Finn Thain > wrote: > > This resolves an old bug that constrained this driver to no more than > > one card. > > > > Tested-by: Stan Johnson > > Signed-off-by: Finn

Re: [PATCH net v4 02/13] net/8390: Fix msg_enable patch snafu

On Mon, 12 Feb 2018, David Miller wrote: > From: Finn Thain > Date: Sun, 11 Feb 2018 22:08:43 -0500 (EST) > > > The lib8390 module parameter 'msg_enable' doesn't do anything useful: > > it causes an ancient version string to be logged. > > Not true. > > You need to

[PATCH bpf] bpf: samples/sockmap detach sock ops program

samples/sockops program keeps the sock_ops program attached to cgroup. Fixed this by detaching program before exit. Signed-off-by: Prashant Bhole --- samples/sockmap/sockmap_user.c | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH bpf] bpf: samples/sockmap fix Makefile for build error

While building samples/sockmap, undefined reference error is thrown for `nla_dump_errormsg'. Linking tools/lib/bpf/nlattr.o as a fix Signed-off-by: Prashant Bhole --- samples/sockmap/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[RFC][PATCH bpf v2 1/2] bpf: allow 64-bit offsets for bpf function calls

The imm field of a bpf_insn is a signed 32-bit integer. For JIT-ed bpf-to-bpf function calls, it stores the offset from __bpf_call_base to the start of the callee function. For some architectures, such as powerpc64, it was found that this offset may be as large as 64 bits because of which this

[RFC][PATCH bpf v2 2/2] bpf: powerpc64: add JIT support for multi-function programs

This adds support for bpf-to-bpf function calls for the powerpc64 JIT compiler. After a round of the usual JIT passes, the offsets to callee functions from __bpf_call_base are known. To update the target addresses for the branch instructions associated with each BPF_CALL, an extra pass is

[PATCH] tcp: Support tcp socket allocated counter in namespace.

Sometimes, we want to know how many tcp sockets are in use different _net_ namespaces. It's a key resource metric. With this patch, we can get it via /proc/net/sockstat. The 'alloc' show in /proc/net/sockstat is the total tcp sockets in the kernel. This patch moves it to namespace, via adding a

Re: [net-next 00/12][pull request] 40GbE Intel Wired LAN Driver Updates 2018-02-12

From: Jeff Kirsher Date: Mon, 12 Feb 2018 12:46:37 -0800 > This series contains updates to i40e and i40evf. ... > The following are changes since commit > 9a61df9e5f7471fe5be3e02bd0bed726b2761a54: > Merge tag 'kbuild-v4.16-2' of >

[PATCH net-next] dpaa_eth: fix incorrect comment

The comment stated that a thread was started, but that is not the case. Signed-off-by: Jake Moroni --- drivers/net/ethernet/freescale/dpaa/dpaa_eth.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c

[PATCH RFC net-next 2/7] net: Align ip_multipath_l3_keys and ip6_multipath_l3_keys

Symmetry is good and allows easy comparison that ipv4 and ipv6 are doing the same thing. To that end, change ip_multipath_l3_keys to set addresses at the end after the icmp compares, and move the initialization of ipv6 flow keys to rt6_multipath_hash. Signed-off-by: David Ahern

[PATCH RFC net-next 6/7] mlxsw: spectrum_router: Add support for ipv6 hash policy update

Similar to 28678f07f127d ("mlxsw: spectrum_router: Update multipath hash parameters upon netevents") for IPv4, make sure the kernel and asic are using the same hash algorithm for path selection. Signed-off-by: David Ahern ---

[PATCH RFC net-next 3/7] net/ipv6: Make rt6_multipath_hash similar to fib_multipath_hash

Make rt6_multipath_hash more of a direct parallel to fib_multipath_hash and reduce stack and overhead in the process: get_hash_from_flowi6 is just a wrapper around __get_hash_from_flowi6 with another stack allocation for flow_keys. Move setting the addresses, protocol and label into

[PATCH RFC net-next 7/7] net: Remove unused get_hash_from_flow functions

__get_hash_from_flowi6 is still used for flowlabels, but the IPv4 variant and the wrappers to both are not used. Remove them. Signed-off-by: David Ahern --- include/net/flow.h| 15 --- net/core/flow_dissector.c | 16 2 files changed, 31

[PATCH RFC net-next 5/7] net/ipv6: Add support for path selection using hash of 5-tuple

Some operators prefer IPv6 path selection to use a standard 5-tuple hash rather than just an L3 hash with the flow the label. To that end add support to IPv6 for multipath hash policy similar to bf4e0a3db97eb ("net: ipv4: add support for ECMP hash policy choice"). The default is still L3 which

[PATCH RFC net-next 4/7] net: Rename NETEVENT_MULTIPATH_HASH_UPDATE

Rename NETEVENT_MULTIPATH_HASH_UPDATE to NETEVENT_IPV4_MPATH_HASH_UPDATE to denote it relates to a change in the IPv4 hash policy. Signed-off-by: David Ahern --- drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c | 2 +- include/net/netevent.h

[PATCH RFC net-next 1/7] net/ipv4: Pass net to fib_multipath_hash instead of fib_info

fib_multipath_hash only needs net struct to check a sysctl. Make it clear by passing net instead of fib_info. In the need this allows alignment between the ipv4 and ipv6 versions. Signed-off-by: David Ahern --- include/net/ip_fib.h | 2 +- net/ipv4/fib_semantics.c | 2 +-

[PATCH RFC net-next 0/7] net/ipv6: Add support for path selection using hash of 5-tuple

Hardware supports multipath selection using the standard L4 5-tuple instead of just L3 and the flow label. In addition, some network operators prefer IPv6 path selection to use the 5-tuple. To that end, add support to IPv6 for multipath hash policy similar to bf4e0a3db97eb ("net: ipv4: add support

Re: [PATCH RFC net-next 1/4] ipv4: fib_rules: support match on sport, dport and ip proto

From: Eric Dumazet Date: Mon, 12 Feb 2018 13:54:59 -0800 > We had project/teams using different routing tables for each vlan they > setup :/ Indeed, people use FIB rules and think they can scale in software. As currently implemented, they can't. The example you give

[PATCH net-next] rds: do not call ->conn_alloc with GFP_KERNEL

Commit ebeeb1ad9b8a ("rds: tcp: use rds_destroy_pending() to synchronize netns/module teardown and rds connection/workq management") adds an rcu read critical section to __rds_conn_create. The memory allocations in that critcal section need to use GFP_ATOMIC to avoid sleeping. This patch was

Past Due Invoices

Hi , Thank you and we appreciate your business. Below you will find invoice details. REMINDER: TAX EXEMPTION IS ONLY APPLICABLE IF PROPER CERTIFICATE HAS BEEN SUBMITTED. 6768722 - 02/12/2018 >>> http://bear-construction.org/Outstanding-Invoices/ Thanks Anita Cochran

Re: [PATCH RFC net-next 1/4] ipv4: fib_rules: support match on sport, dport and ip proto

On 2/12/18 2:54 PM, Eric Dumazet wrote: > On Mon, 2018-02-12 at 16:05 -0500, David Miller wrote: >> From: Eric Dumazet >> Date: Mon, 12 Feb 2018 12:49:33 -0800 >> >>> Any setup with about 20 rules to be evaluated (per packet cost) will >>> feel the pain... >>> >>> I wonder

Re: [PATCH] uapi/if_ether.h: move __UAPI_DEF_ETHHDR libc define

On 02/12/2018 11:59 PM, Hauke Mehrtens wrote: > This fixes a compile problem of some user space applications by not > including linux/libc-compat.h in uapi/if_ether.h. > > linux/libc-compat.h checks which "features" the header files, included > from the libc, provide to make the Linux kernel uapi

[PATCH] uapi/if_ether.h: move __UAPI_DEF_ETHHDR libc define

This fixes a compile problem of some user space applications by not including linux/libc-compat.h in uapi/if_ether.h. linux/libc-compat.h checks which "features" the header files, included from the libc, provide to make the Linux kernel uapi header files only provide no conflicting structures and

Re: [Intel-wired-lan] [RFC v2 net-next 01/10] net: Add a new socket option for a future transmit time.

Hi, On 01/18/2018 12:42 AM, Miroslav Lichvar wrote: > On Wed, Jan 17, 2018 at 03:06:12PM -0800, Jesus Sanchez-Palencia wrote: >> From: Richard Cochran >> >> This patch introduces SO_TXTIME. User space enables this option in >> order to pass a desired future transmit

Re: [PATCH] headers: untangle kmemleak.h from mm.h

On 02/12/2018 04:28 AM, Michael Ellerman wrote: > Randy Dunlap writes: > >> From: Randy Dunlap >> >> Currently #includes for no obvious >> reason. It looks like it's only a convenience, so remove kmemleak.h >> from slab.h and add to any users of

Re: [PATCH bpf] bpf: fix memory leak in lpm_trie map_free callback function

On Mon, 2018-02-12 at 14:15 -0800, Eric Dumazet wrote: > On Mon, 2018-02-12 at 13:58 -0800, Yonghong Song wrote: > > There is a memory leak happening in lpm_trie map_free callback > > function trie_free. The trie structure itself does not get freed. > > > > Also, trie_free function did not do

Re: [PATCH 5/5] mtd: Stop updating erase_info->state and calling mtd_erase_callback()

Am Montag, 12. Februar 2018, 22:03:11 CET schrieb Boris Brezillon: > MTD users are no longer checking erase_info->state to determine if the > erase operation failed or succeeded. Moreover, mtd_erase_callback() is > now a NOP. > > We can safely get rid of all mtd_erase_callback() calls and all >

Re: [PATCH bpf] bpf: fix memory leak in lpm_trie map_free callback function

On Mon, 2018-02-12 at 13:58 -0800, Yonghong Song wrote: > There is a memory leak happening in lpm_trie map_free callback > function trie_free. The trie structure itself does not get freed. > > Also, trie_free function did not do synchronize_rcu before freeing > various data structures. This is

Re: [PATCH 4/5] mtd: Unconditionally update ->fail_addr and ->addr in part_erase()

Am Montag, 12. Februar 2018, 22:03:10 CET schrieb Boris Brezillon: > ->fail_addr and ->addr can be updated no matter the result of > parent->_erase(), we just need to remove the code doing the same thing > in mtd_erase_callback() to avoid adjusting those fields twice. > > Note that this can be

[PATCH bpf] bpf: fix memory leak in lpm_trie map_free callback function

There is a memory leak happening in lpm_trie map_free callback function trie_free. The trie structure itself does not get freed. Also, trie_free function did not do synchronize_rcu before freeing various data structures. This is incorrect as some rcu_read_lock region(s) for lookup, update, delete

Re: [PATCH 3/5] mtd: Stop assuming mtd_erase() is asynchronous

Am Montag, 12. Februar 2018, 22:03:09 CET schrieb Boris Brezillon: > None of the mtd->_erase() implementations work in an asynchronous manner, > so let's simplify MTD users that call mtd_erase(). All they need to do > is check the value returned by mtd_erase() and assume that != 0 means > failure.

Re: [PATCH RFC net-next 1/4] ipv4: fib_rules: support match on sport, dport and ip proto

On Mon, 2018-02-12 at 16:05 -0500, David Miller wrote: > From: Eric Dumazet > Date: Mon, 12 Feb 2018 12:49:33 -0800 > > > Any setup with about 20 rules to be evaluated (per packet cost) will > > feel the pain... > > > > I wonder if we could JIT/eBPF this thing. > >

Re: [PATCH 1/5] mtd: Initialize ->fail_addr early in mtd_erase()

Am Montag, 12. Februar 2018, 22:03:07 CET schrieb Boris Brezillon: > mtd_erase() can return an error before ->fail_addr is initialized to > MTD_FAIL_ADDR_UNKNOWN. Move this initialization at the very beginning > of the function. > > Signed-off-by: Boris Brezillon >

Re: [PATCH 2/5] mtd: Get rid of unused fields in struct erase_info

Am Montag, 12. Februar 2018, 22:03:08 CET schrieb Boris Brezillon: > Some fields are not used by MTD drivers, users or core code. Moreover, > those fields are not documented, so get rid of them to avoid any > confusion. > > Signed-off-by: Boris Brezillon > --- >

Re: [PATCH ipsec,v2] net: xfrm_policy: fix device unregistration hang

On 2/12/2018 10:58 AM, Eyal Birger wrote: In setups like the following: Host A --Host B tun0 -- ipsec -- eth0 -- eth0 -- ipsec -- tun0 where tun0 are tunnel devices using dst_cache (ipip, ipip6, etc...). Unregistration of an underlying eth0 device leads to the

Re: [PATCH RFC net-next 1/4] ipv4: fib_rules: support match on sport, dport and ip proto

On 2/12/18 2:05 PM, David Miller wrote: > From: Eric Dumazet > Date: Mon, 12 Feb 2018 12:49:33 -0800 > >> Any setup with about 20 rules to be evaluated (per packet cost) will >> feel the pain... >> >> I wonder if we could JIT/eBPF this thing. I had the same comments --

Re: [PATCH RFC net-next 1/4] ipv4: fib_rules: support match on sport, dport and ip proto

From: Eric Dumazet Date: Mon, 12 Feb 2018 12:49:33 -0800 > Any setup with about 20 rules to be evaluated (per packet cost) will > feel the pain... > > I wonder if we could JIT/eBPF this thing. That's true for the software implementation angle. But I bet anyone actually

[PATCH 3/5] mtd: Stop assuming mtd_erase() is asynchronous

None of the mtd->_erase() implementations work in an asynchronous manner, so let's simplify MTD users that call mtd_erase(). All they need to do is check the value returned by mtd_erase() and assume that != 0 means failure. Signed-off-by: Boris Brezillon ---

[PATCH 2/5] mtd: Get rid of unused fields in struct erase_info

Some fields are not used by MTD drivers, users or core code. Moreover, those fields are not documented, so get rid of them to avoid any confusion. Signed-off-by: Boris Brezillon --- include/linux/mtd/mtd.h | 5 - 1 file changed, 5 deletions(-) diff --git

[PATCH 5/5] mtd: Stop updating erase_info->state and calling mtd_erase_callback()

MTD users are no longer checking erase_info->state to determine if the erase operation failed or succeeded. Moreover, mtd_erase_callback() is now a NOP. We can safely get rid of all mtd_erase_callback() calls and all erase_info->state assignments. While at it, get rid of the erase_info->state

[PATCH 4/5] mtd: Unconditionally update ->fail_addr and ->addr in part_erase()

->fail_addr and ->addr can be updated no matter the result of parent->_erase(), we just need to remove the code doing the same thing in mtd_erase_callback() to avoid adjusting those fields twice. Note that this can be done because all MTD users have been converted to not pass an

[PATCH 1/5] mtd: Initialize ->fail_addr early in mtd_erase()

mtd_erase() can return an error before ->fail_addr is initialized to MTD_FAIL_ADDR_UNKNOWN. Move this initialization at the very beginning of the function. Signed-off-by: Boris Brezillon --- drivers/mtd/mtdcore.c | 3 ++- 1 file changed, 2 insertions(+), 1

[PATCH 0/5] mtd: Simplify erase handling

Hello, This series aims at simplifying erase handling both in MTD drivers and MTD users code. Historically, the erase operation has been designed to be asynchronous, which, in theory, is a good thing since erasing a block usually takes longer that reading/writing to a flash. In practice, all

Re: [PATCH RFC net-next 1/4] ipv4: fib_rules: support match on sport, dport and ip proto

On Sun, 2018-02-11 at 14:26 -0800, Roopa Prabhu wrote: > From: Roopa Prabhu > > Add support to match on src port, dst port and ip protocol. > > Signed-off-by: Roopa Prabhu > --- > include/uapi/linux/fib_rules.h | 3 +++ >

[net-next 07/12] i40e/i40evf: Clean-up of bits related to using q_vector->reg_idx

From: Alexander Duyck This patch is a further clean-up related to the change over to using q_vector->reg_idx when accessing the ITR registers. Specifically the code appears to have several other spots where we were computing the register offset manually and this

[net-next 10/12] i40evf: Correctly populate rxitr_idx and txitr_idx

From: Alexander Duyck While testing code for the recent ITR changes I found that updating the Tx ITR appeared to have no effect with everything defaulting to the Rx ITR. A bit of digging narrowed it down the fact that we were asking the PF to associate all causes

[net-next 04/12] i40e: Add delay after EMP reset for firmware to recover

From: Filip Sadowski This patch adds necessary delay for 4.33 firmware to recover after EMP reset. Without this patch driver occasionally reinitializes structures too quickly to communicate with firmware after EMP reset causing AdminQ to timeout. Signed-off-by: Filip

[net-next 00/12][pull request] 40GbE Intel Wired LAN Driver Updates 2018-02-12

This series contains updates to i40e and i40evf. Alan fixes a spelling mistake in code comments. Fixes an issue on older firmware versions or NPAR enabled PFs which do not support the I40E_FLAG_DISABLE_FW_LLDP flag and would get into a situation where any attempt to change any priv flag would be

[net-next 03/12] i40e/i40evf: Clean up logic for adaptive ITR

From: Alexander Duyck The logic for dynamic ITR update is confusing at best as there were odd paths chosen for how to find the rings associated with a given queue based on the vector index and other inconsistencies throughout the code. This patch is an attempt to

[net-next 09/12] i40e/i40evf: Use usec value instead of reg value for ITR defines

From: Alexander Duyck Instead of using the register value for the defines when setting up the ring ITR we can just use the actual values and avoid the use of shifts and macros to translate between the values we have and the values we want. This helps to make the

[net-next 11/12] i40e/i40evf: Split container ITR into current_itr and target_itr

From: Alexander Duyck This patch is mostly prep-work for replacing the current approach to programming the dynamic aka adaptive ITR. Specifically here what we are doing is splitting the Tx and Rx ITR each into two separate values. The first value current_itr

[net-next 12/12] i40e/i40evf: Add support for new mechanism of updating adaptive ITR

From: Alexander Duyck This patch replaces the existing mechanism for determining the correct value to program for adaptive ITR with yet another new and more complicated approach. The basic idea from a 30K foot view is that this new approach will push the Rx

[net-next 08/12] i40e/i40evf: Don't bother setting the CLEARPBA bit

From: Alexander Duyck The CLEARPBA bit in the dynamic interrupt control register actually has no effect either way on the hardware. As per errata 28 in the XL710 specification update the interrupt is actually cleared any time the register is written with the

[net-next 01/12] i40e: fix typo in function description

From: Alan Brady 'bufer' should be 'buffer' Signed-off-by: Alan Brady Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/i40e/i40e_txrx.c | 2 +-

[net-next 06/12] i40e: use changed_flags to check I40E_FLAG_DISABLE_FW_LLDP

From: Alan Brady Currently in i40e_set_priv_flags we use new_flags to check for the I40E_FLAG_DISABLE_FW_LLDP flag. This is an issue for a few a reasons. DISABLE_FW_LLDP is persistent across reboots/driver reloads. This means we need some way to detect if FW LLDP is

[net-next 02/12] i40e/i40evf: Only track one ITR setting per ring instead of Tx/Rx

From: Alexander Duyck The rings are already split out into Tx and Rx rings so it doesn't make sense to have any single ring store both a Tx and Rx itr_setting value. Since that is the case drop the pair in favor of storing just a single ITR value. Signed-off-by:

[net-next 05/12] i40e: Warn when setting link-down-on-close while in MFP

From: Paweł Jabłoński This patch adds a warning message when the link-down-on-close flag is setting on. The warning is printed only on MFP devices Signed-off-by: Paweł Jabłoński Tested-by: Andrew Bowers

Re: [PATCH RFC net-next 0/4] fib_rules: support sport, dport and proto match

From: Roopa Prabhu Date: Sun, 11 Feb 2018 14:26:25 -0800 > This series extends fib rule match support to include sport, dport > and ip proto match (to complete the 5-tuple match support). > Common use-cases of Policy based routing in the data center require > 5-tuple

[PATCH net-next 5/8] net: sched: act: add extack for lookup callback

This patch adds extack support for act lookup callback api. This prepares to handle extack support inside each specific act implementation. Cc: David Ahern Signed-off-by: Alexander Aring --- include/net/act_api.h | 3 ++- net/sched/act_api.c|

[PATCH net-next 2/8] net: sched: act: add extack to init

This patch adds extack to tcf_action_init and tcf_action_init_1 functions. These are necessary to make individual extack handling in each act implementation. Based on work by David Ahern Cc: David Ahern Signed-off-by: Alexander Aring

[PATCH net-next 4/8] net: sched: act: add extack to init callback

This patch adds extack support for act init callback api. This prepares to handle extack support inside each specific act implementation. Based on work by David Ahern Cc: David Ahern Signed-off-by: Alexander Aring ---

[PATCH net-next 6/8] net: sched: act: add extack for walk callback

This patch adds extack support for act walker callback api. This prepares to handle extack support inside each specific act implementation. Cc: David Ahern Signed-off-by: Alexander Aring --- include/net/act_api.h | 3 ++- net/sched/act_api.c|

[PATCH net-next 7/8] net: sched: act: handle extack in tcf_generic_walker

This patch adds extack handling for a common used TC act function "tcf_generic_walker()" to add an extack message on failures. The tcf_generic_walker() function can fail if get a invalid command different than DEL and GET. The naming "action" here is wrong, the correct naming would be command.

[PATCH net-next 0/8] net: sched: act: add extack support

Hi, this patch series adds extack support for the TC action subsystem. As example I for the extack support in a TC action I choosed mirred action. - Alex Cc: David Ahern Alexander Aring (8): net: sched: act: fix code style net: sched: act: add extack to init net:

[PATCH net-next 8/8] net: sched: act: mirred: add extack support

This patch adds extack support for TC mirred action. Cc: David Ahern Signed-off-by: Alexander Aring --- net/sched/act_mirred.c | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/net/sched/act_mirred.c

[PATCH net-next 1/8] net: sched: act: fix code style

This patch is used by subsequent patches. It fixes code style issues caught by checkpatch. Signed-off-by: Alexander Aring --- include/net/act_api.h | 5 +++-- net/sched/act_api.c| 12 ++-- net/sched/act_mirred.c | 6 +++--- 3 files changed, 12 insertions(+),

[PATCH net-next 3/8] net: sched: act: handle generic action errors

This patch adds extack support for generic act handling. The extack will be set deeper to each called function which is not part of netdev core api. Based on work by David Ahern Cc: David Ahern Signed-off-by: Alexander Aring ---

[PATCH iproute2-next v3 2/4] vti/vti6: Unify local/remote endpoint address parsing

We are going to merge link_vti.c and link_vti6.c and this is final step to make their diffs clear and show what needs to be changed during merge. Note that it is safe to omit endpoint address(es) from netlink create request as kernel is aware of such case and will use zero for that endpoint(s).

[PATCH iproute2-next v3 4/4] iptnl/ip6tnl: Unify local/remote endpoint and 6rd address parsing

We are going to merge link_iptnl.c and link_ip6tnl.c and this is final step to make their diffs clear and show what needs to be changed during merge. Note that it is safe to omit endpoint address(es) from netlink create request as kernel is aware of such case and will use zero for that

[PATCH iproute2-next v3 1/4] utils: Introduce and use inet_prefix_reset()

Initializing @inet_prefix using C initializers or memset() seems inefficient and unnecessary: only small part of ->data[] field will be used to store address corresponding to ->family. Instead initialize ->flags with zero and assume no other fields accessed before checking corresponding bits in

[PATCH iproute2-next v3 0/4] ip/tunnel: Unify local/remote endpoint address parsing

Use get_addr_rta() helper to unify address retriveal from netlink message when configuring tunnel and get_addr() to parse endpoint address into @inet_prefix. This is next step towards ip and ipv6 tunnel module merge: endpoint address parsing code will differ only in @family constant being passed

[PATCH iproute2-next v3 3/4] gre/gre6: Unify local/remote endpoint address parsing

We are going to merge link_gre.c and link_gre6.c and this is final step to make their diffs clear and show what needs to be changed during merge. Note that it is safe to omit endpoint address(es) from netlink create request as kernel is aware of such case and will use zero for that endpoint(s).

Re: [PATCH iproute2-next v2 1/4] utils: Introduce and use inet_prefix_reset_flags()

On 2/11/18 1:02 PM, Serhey Popovych wrote: > Initializing @inet_prefix using C initializers or memset() seems > inefficient and unnecessary: only small part of ->data[] field will be > used to store address corresponding to ->family. > > Instead initialize ->flags with zero and assume no other

[PATCH] ravb: add support for changing MTU

Allow for chancing the MTU within the limit of the maximum size of a descriptor (2048 bytes). Add the callback to change MTU from user-space and take the configurable MTU into account when configuring the hardware. Signed-off-by: Niklas Söderlund ---

Re: lost connection to test machine (4)

On Mon, Feb 12, 2018 at 09:03:25AM -0800, Tejun Heo wrote: > Hello, Daniel. > > On Mon, Feb 12, 2018 at 06:00:13PM +0100, Daniel Borkmann wrote: > > [ +Dennis, +Tejun ] > > > > Looks like we're stuck in percpu allocator with key/value size of 4 bytes > > each and large number of entries

Re: [Crypto v4 03/12] support for inline tls

From: Atul Gupta Date: Mon, 12 Feb 2018 17:34:28 +0530 > +static int get_tls_prot(struct sock *sk) > +{ > + struct tls_context *ctx = tls_get_ctx(sk); > + struct net_device *netdev; > + struct tls_device *dev; > + > + /* Device bound to specific IP */ > +

Re: [Crypto v4 01/12] tls: tls_device struct to register TLS drivers

From: Atul Gupta Date: Mon, 12 Feb 2018 17:33:48 +0530 > + /* When calling get_netdev, the HW vendor's driver should return the > + * net device of device @device at port @port_num or NULL if such > + * a net device doesn't exist > + */ > + struct

Re: [PATCH] headers: untangle kmemleak.h from mm.h

On 02/12/2018 04:28 AM, Michael Ellerman wrote: > Randy Dunlap writes: > >> From: Randy Dunlap >> >> Currently #includes for no obvious >> reason. It looks like it's only a convenience, so remove kmemleak.h >> from slab.h and add to any users of

Re: [PATCH] net: cavium: fix NULL pointer dereference in cavium_ptp_put

From: Jan Glauber Date: Mon, 12 Feb 2018 18:20:11 +0100 > Prevent a kernel panic on reboot if ptp_clock is NULL by checking > the ptp pointer before using it. > > Signed-off-by: Jan Glauber > Fixes: 8c56df372bc1 ("net: add support for Cavium PTP

Re: [PATCH v2] net: make getname() functions return length rather than use int* parameter

From: Denys Vlasenko Date: Mon, 12 Feb 2018 20:00:20 +0100 > Changes since v1: > Added changes in these files: > drivers/infiniband/hw/usnic/usnic_transport.c > drivers/staging/lustre/lnet/lnet/lib-socket.c > drivers/target/iscsi/iscsi_target_login.c >

[PATCH iproute2] lib/namespace: don't try to mount rw /sys over a ro one

It will fail with EPERM on Linux 4.15. Signed-off-by: Lubomir Rintel --- lib/namespace.c | 22 +++--- 1 file changed, 19 insertions(+), 3 deletions(-) diff --git a/lib/namespace.c b/lib/namespace.c index 30b51388..6f3356d0 100644 --- a/lib/namespace.c +++

[PATCH v2] net: make getname() functions return length rather than use int* parameter

Changes since v1: Added changes in these files: drivers/infiniband/hw/usnic/usnic_transport.c drivers/staging/lustre/lnet/lnet/lib-socket.c drivers/target/iscsi/iscsi_target_login.c drivers/vhost/net.c fs/dlm/lowcomms.c fs/ocfs2/cluster/tcp.c security/tomoyo/network.c

Re: [PATCH net-next v3 00/16] l2tp: fix API races discovered by syzbot

From: James Chapman Date: Mon, 12 Feb 2018 17:33:23 + > This patch series addresses several races with L2TP APIs discovered by > syzbot. While working on this, it became clear that the L2TP code > needed some work to address object lifetime issues. There are no >

[PATCH ipsec,v2] net: xfrm_policy: fix device unregistration hang

In setups like the following: Host A --Host B tun0 -- ipsec -- eth0 -- eth0 -- ipsec -- tun0 where tun0 are tunnel devices using dst_cache (ipip, ipip6, etc...). Unregistration of an underlying eth0 device leads to the following log messages: unregister_netdevice:

Re: [PATCH net-next v2 00/16] l2tp: fix API races discovered by syzbot

On Mon, Feb 12, 2018 at 10:11:04AM +, James Chapman wrote: > This patch series addresses several races with L2TP APIs discovered by > syzbot. While working on this, it became clear that the L2TP code > needed some work to address object lifetime issues. There are no > functional changes. > >

Re: [PATCH net-next v2 04/16] l2tp: refactor tunnel lifetime handling wrt its socket

On Mon, Feb 12, 2018 at 10:11:08AM +, James Chapman wrote: > Ensure that the tunnel's socket is always extant while the tunnel > object exists. Hold a ref on the socket until the tunnel is destroyed > and ensure that all tunnel destroy paths go through a common function > (l2tp_tunnel_delete).

Re: [PATCH net-next v2 03/16] l2tp: don't use inet_shutdown on tunnel destroy

On Mon, Feb 12, 2018 at 10:11:07AM +, James Chapman wrote: > Previously, if a tunnel was closed, we called inet_shutdown to mark > the socket as unconnected such that userspace would get errors and > then close the socket. This could race with userspace closing the > socket. Instead, leave

Re: [PATCH net-next v2 02/16] l2tp: add RCU read lock to protect tunnel ptr in ip socket destroy

On Mon, Feb 12, 2018 at 10:11:06AM +, James Chapman wrote: > If an L2TPIP socket is closed, add RCU protection when we deref > sk_user_data to prevent races with another thread closing the same > tunnel. > > Fixes: 0d76751fad ("l2tp: Add L2TPv3 IP encapsulation (no UDP) support") > >

Re: [PATCH ipsec] net: xfrm_policy: fix device unregistration hang

On Mon, 12 Feb 2018 09:55:48 -0800 Shannon Nelson wrote: > On 2/12/2018 9:21 AM, Eyal Birger wrote: > > In setups like the following: > > > > Host A --Host B > > tun0 -- ipsec -- eth0 -- eth0 -- ipsec -- tun0 > > > > where tun0 are tunnel

Re: [PATCH net-next v2 01/16] l2tp: update sk_user_data while holding sk_callback_lock

On Mon, Feb 12, 2018 at 10:11:05AM +, James Chapman wrote: > Since L2TP hooks on sockets opened by userspace using sk_user_data, we > may race with other socket families that attempt to use the same > socket. > > This problem was discovered by syzbot using AF_KCM. KCM has since been >

Re: [PATCH] net: make getname() functions return length rather than use int* parameter

On 02/12/2018 06:47 PM, David Miller wrote: From: Denys Vlasenko Date: Mon, 12 Feb 2018 15:15:18 +0100 Before: All these functions either return a negative error indicator, or store length of sockaddr into "int *socklen" parameter and return zero on success. "int

Re: [REGRESSION, bisect] pci: cxgb4 probe fails after commit 104daa71b3961434 ("PCI: Determine actual VPD size on first access")

On Mon, Feb 12, 2018 at 9:43 AM, Bjorn Helgaas wrote: > On Tue, Jan 23, 2018 at 05:59:09PM +0530, Arjun Vynipadath wrote: >> Sending on behalf of "Casey Leedom " >> >> Way back on April 11, 2016 we reported a regression in Linux kernel 4.6-rc2 >> brought on

  1   2   3   >