Hi Oliver,
On 2018-02-27 17:07, Oliver Neukum wrote:
Am Dienstag, den 27.02.2018, 07:13 -0800 schrieb Eric Dumazet:
On Tue, 2018-02-27 at 07:09 -0800, Eric Dumazet wrote:
Note that for this one, it seems we also could perform stats updates in
BH context, since skb is queued via defer_bh()
Bu
On Sun, Mar 04, 2018 at 05:37:47PM -0800, David Ahern wrote:
> For tests using veth interfaces, the test infrastructure can create
> the netdevs if they do not exist. Arguably this is a preferred approach
> since the tests require p$N and p$(N+1) to be pairs.
>
> Signed-off-by: David Ahern
Revie
On Mon, 5 Mar 2018, Arushi Singhal wrote:
> Replace printk having a log level with the appropriate
> net_*macro_ratelimited.
> It's better to use actual device name as a prefix in error messages.
>
> Signed-off-by: Arushi Singhal
> ---
> changes in v2
> *In v1 printk was changed to pr_*macro(),
On Mon, Mar 5, 2018 at 9:40 AM, Stephen Rothwell wrote:
> Hi Paul,
>
> Today's linux-next merge of the selinux tree got a conflict in:
>
> net/sctp/socket.c
>
> between several refactoring commits from the net-next tree and commit:
>
> 2277c7cd75e3 ("sctp: Add LSM hooks")
>
> from the selinux
On Mon, Mar 05, 2018 at 09:47:40AM +0530, Arushi Singhal wrote:
> Replace printk having a log level with the appropriate
> net_*macro_ratelimited.
> It's better to use actual device name as a prefix in error messages.
>
> Signed-off-by: Arushi Singhal
> ---
> changes in v2
> *In v1 printk was cha
Take an additional reference to a page whenever it is placed
into the rx ring and put the page again after running
dma_unmap_page.
When swiotlb is in use, calling dma_unmap_page means that
the original page mapped with dma_map_page must still be valid,
as swiotlb will copy data from its internal c
Replace printk having a log level with the appropriate
net_*macro_ratelimited.
It's better to use actual device name as a prefix in error messages.
Signed-off-by: Arushi Singhal
---
changes in v2
*In v1 printk was changed to pr_*macro(), which is used
in kernel instead of calling printk() directl
On 2018-03-04 16:55, Mimi Zohar wrote:
> On Thu, 2018-03-01 at 14:41 -0500, Richard Guy Briggs wrote:
> > Implement audit kernel container ID.
> >
> > This patchset is a preliminary RFC based on the proposal document (V3)
> > posted:
> > https://www.redhat.com/archives/linux-audit/2018-January
1) Use an appropriate TSQ pacing shift in mac80211, from Toke Høiland-Jørgensen.
2) Just like ipv4's ip_route_me_harder(), we have to use skb_to_full_sk
in ip6_route_me_harder, from Eric Dumazet.
3) Fix several shutdown races and similar other problems in l2tp, from
James Chapman.
4) Hand
From: Stephen Hemminger
Date: Fri, 2 Mar 2018 13:49:00 -0800
> These are improvements to netvsc driver. They aren't functionality
> changes so not targeting net-next; and they are not show stopper
> bugs that need to go to stable either.
>
> v2
>- drop the irq flags patch, defer it to net-n
From: Jason Wang
Date: Mon, 5 Mar 2018 10:43:41 +0800
>
>
> On 2018年03月05日 07:38, David Miller wrote:
>> From: Jason Wang
>> Date: Fri, 2 Mar 2018 17:29:14 +0800
>>
>>> XDP_REDIRECT support for mergeable buffer was removed since commit
>>> 7324f5399b06 ("virtio_net: disable XDP_REDIRECT in re
On 2018年03月05日 07:38, David Miller wrote:
From: Jason Wang
Date: Fri, 2 Mar 2018 17:29:14 +0800
XDP_REDIRECT support for mergeable buffer was removed since commit
7324f5399b06 ("virtio_net: disable XDP_REDIRECT in receive_mergeable()
case"). This is because we don't reserve enough tailroom
On 2018年03月03日 01:36, Michael S. Tsirkin wrote:
On Fri, Mar 02, 2018 at 05:29:14PM +0800, Jason Wang wrote:
XDP_REDIRECT support for mergeable buffer was removed since commit
7324f5399b06 ("virtio_net: disable XDP_REDIRECT in receive_mergeable()
case"). This is because we don't reserve enough
On 2018年03月03日 00:07, Jesper Dangaard Brouer wrote:
On Fri, 2 Mar 2018 17:29:14 +0800
Jason Wang wrote:
XDP_REDIRECT support for mergeable buffer was removed since commit
7324f5399b06 ("virtio_net: disable XDP_REDIRECT in receive_mergeable()
case"). This is because we don't reserve enough t
On Sat, 3 Mar 2018 21:44:56 +0530, Arushi Singhal wrote:
> diff --git a/drivers/net/ethernet/netronome/nfp/nfp_net_main.c
> b/drivers/net/ethernet/netronome/nfp/nfp_net_main.c
> index 15fa47f..5cd4f3f 100644
> --- a/drivers/net/ethernet/netronome/nfp/nfp_net_main.c
> +++ b/drivers/net/ethernet/net
Hi Paul,
Today's linux-next merge of the selinux tree got a conflict in:
net/sctp/socket.c
between several refactoring commits from the net-next tree and commit:
2277c7cd75e3 ("sctp: Add LSM hooks")
from the selinux tree.
I fixed it up (I think - see below) and can carry the fix as
necess
For tests using veth interfaces, the test infrastructure can create
the netdevs if they do not exist. Arguably this is a preferred approach
since the tests require p$N and p$(N+1) to be pairs.
Signed-off-by: David Ahern
---
v2
- local on j declaration and line wrap
.../net/forwarding/forwarding
On 3/4/18 1:14 AM, Ido Schimmel wrote:
> On Fri, Mar 02, 2018 at 08:45:53AM -0800, David Ahern wrote:
>> For tests using veth interfaces, the test infrastructure can create
>> the netdevs if they do not exist. Arguably this is a preferred approach
>> since the tests require p$N and p$(N+1) to be pa
On 3/4/18 4:12 PM, Stefano Brivio wrote:
> On Sat, 3 Mar 2018 12:22:36 +0100
> Stefano Brivio wrote:
>
>>> And please codify the above expectation as a test under
>>> tools/testing/selftests/net
>>
>> And this, along with v2.
>
> On a second thought: I start thinking it doesn't make much sense
Add a generic netlink family for NCSI. This supports three commands;
NCSI_CMD_PKG_INFO which returns information on packages and their
associated channels, NCSI_CMD_SET_INTERFACE which allows a specific
package or package/channel combination to be set as the preferred
choice, and NCSI_CMD_CLEAR_INT
From: Simon Wunderlich
Date: Fri, 2 Mar 2018 18:57:40 +0100
> here is a little cleanup pull request of batman-adv to go into net-next.
>
> Please pull or let me know of any problem!
Pulled, thanks Simon.
From: Guillaume Nault
Date: Fri, 2 Mar 2018 18:41:16 +0100
> PPP units don't hold any reference on the channels connected to it.
> It is the channel's responsibility to ensure that it disconnects from
> its unit before being destroyed.
> In practice, this is ensured by ppp_unregister_channel() di
From: Paolo Abeni
Date: Fri, 2 Mar 2018 16:03:32 +0100
> Currently we allow the creation of 8021q devices on top of
> ipvlan, but such devices are nonfunctional, as the underlying
> ipvlan rx_hanlder hook can't match the relevant traffic.
>
> Be explicit and forbid the creation of such nonfunct
From: Davide Caratti
Date: Fri, 2 Mar 2018 14:44:39 +0100
> iproute2 print_skbmod() prints the configured ethertype using format 0x%X:
> therefore, test 9aa8 systematically fails, because it configures action #4
> using ethertype 0x0031, and expects 0x0031 when it reads it back. Changing
> the e
From: Jason Wang
Date: Fri, 2 Mar 2018 17:29:14 +0800
> XDP_REDIRECT support for mergeable buffer was removed since commit
> 7324f5399b06 ("virtio_net: disable XDP_REDIRECT in receive_mergeable()
> case"). This is because we don't reserve enough tailroom for struct
> skb_shared_info which breaks
From: Prashant Bhole
Date: Fri, 2 Mar 2018 11:22:20 +0900
> This patch removes testns after test failure so that next test can
> continue with clean ns
>
> Signed-off-by: Prashant Bhole
Applied.
From: William Tu
Date: Thu, 1 Mar 2018 13:49:56 -0800
> Currently GRE sequence number can only be used in native tunnel mode.
> The first patch adds sequence number support for gre collect
> metadata mode, and the second patch tests it using BPF.
>
> RFC2890 defines GRE sequence number to be sp
From: Govindarajulu Varadarajan
Date: Thu, 1 Mar 2018 11:07:18 -0800
> This series adds support for IPv6 vxlan offload and UDP rss along with a
> bug fix in filling the rq ring.
Applied, thank you.
From: Colin King
Date: Thu, 1 Mar 2018 16:42:40 +
> From: Colin Ian King
>
> The variable tx_index is being initialized with a value that is never
> read and re-assigned a little later, hence the initialization is redundant
> and can be removed.
>
> Cleans up clang warning:
> drivers/net/
Applied.
From: Andy Shevchenko
Date: Thu, 1 Mar 2018 13:27:35 +0200
> This is a follow up to the commit
>
> 4c45d24a759d ("r8169: switch to device-managed functions in probe")
>
> to move towards managed resources even more.
>
> Cc: Heiner Kallweit
> Signed-off-by: Andy Shevchenko
Applied.
On Sat, 3 Mar 2018 12:22:36 +0100
Stefano Brivio wrote:
> > And please codify the above expectation as a test under
> > tools/testing/selftests/net
>
> And this, along with v2.
On a second thought: I start thinking it doesn't make much sense,
especially given the current context of self-tests
From: Jiri Pirko
Date: Thu, 1 Mar 2018 11:37:05 +0100
> From: Shalom Toledo
>
> Until now, we assumed that in case of error when adding FDB entries, the
> write operation will fail, but this is not the case. Instead, we need to
> check that the number of entries reported in the response is equ
From: Ganesh Goudar
Date: Thu, 1 Mar 2018 15:01:04 +0530
> From: Arjun Vynipadath
>
> The Virtual Interfaces are connected to an internal switch on the chip
> which allows VIs attached to the same port to talk to each other even
> when the port link is down. As a result, we generally want to
From: Colin King
Date: Thu, 1 Mar 2018 10:23:03 +
> From: Colin Ian King
>
> Trivial fix to spelling mistake in comments and error message text.
>
> Signed-off-by: Colin Ian King
Applied.
From: Daniel Axtens
Date: Thu, 1 Mar 2018 17:13:36 +1100
> As requested [1], I went through and had a look at users of gso_size to
> see if there were things that need to be fixed to consider
> GSO_BY_FRAGS, and I have tried to improve our helper functions to deal
> with this case.
...
Series
Hi all,
Today's linux-next merge of the net-next tree got a conflict in:
net/ipv6/netfilter/nft_fib_ipv6.c
between commit:
47b7e7f82802 ("netfilter: don't set F_IFACE on ipv6 fib lookups")
from the net tree and commit:
b75cc8f90f07 ("net/ipv6: Pass skb to route lookup")
from the net-ne
On Sun, Mar 4, 2018 at 10:50 AM, Jiri Pirko wrote:
> Sun, Mar 04, 2018 at 07:24:12PM CET, alexander.du...@gmail.com wrote:
>>On Sat, Mar 3, 2018 at 11:13 PM, Jiri Pirko wrote:
>>> Sun, Mar 04, 2018 at 01:26:53AM CET, alexander.du...@gmail.com wrote:
On Sat, Mar 3, 2018 at 1:25 PM, Jiri Pirko
On Thu, 2018-03-01 at 14:41 -0500, Richard Guy Briggs wrote:
> Implement audit kernel container ID.
>
> This patchset is a preliminary RFC based on the proposal document (V3)
> posted:
> https://www.redhat.com/archives/linux-audit/2018-January/msg00014.html
>
> The first patch implements th
On 3/4/2018 10:50 AM, Jiri Pirko wrote:
Sun, Mar 04, 2018 at 07:24:12PM CET, alexander.du...@gmail.com wrote:
On Sat, Mar 3, 2018 at 11:13 PM, Jiri Pirko wrote:
Sun, Mar 04, 2018 at 01:26:53AM CET, alexander.du...@gmail.com wrote:
On Sat, Mar 3, 2018 at 1:25 PM, Jiri Pirko wrote:
Sat, Mar
On Mon, 5 Mar 2018, Arushi Singhal wrote:
> Replace printk having a log level with the appropriate
> net_*macro_ratelimited.
Why did you choose this function?
> It's better to use actual device name as a prefix in error messages.
What does this message relate to.
> Indentation is also change
Replace printk having a log level with the appropriate
net_*macro_ratelimited.
It's better to use actual device name as a prefix in error messages.
Indentation is also changed, to fix the checkpatch issue.
Signed-off-by: Arushi Singhal
---
changes in v2
*In previous version printk was changed to
From: Atul Gupta
Date: Thu, 1 Mar 2018 11:19:35 +0530
> + __u8 reneg_to_write_rx;
> + __u8 protocol;
You should use "u8" rather than "__u8" except in UAPI headers
which this file is not.
Please audit your entire patch series for this issue.
Thank you.
This is a basic intermediate representation to decouple
the ruleset representation (iptables, nftables) from the
ebpf translation.
The IMR currently assumes that translation will always be
into ebpf, its pseudo-registers map 1:1 to ebpf ones.
Objects implemented at the moment:
- relop (eq, ne onl
This adds a nftables frontend for the IMR->BPF translator.
This doesn't work via UMH yet.
AFAIU it should be possible to get transparent ebpf translation for
nftables, similar to the bpfilter/iptables UMH.
However, at this time I think its better to get IMR "right".
nftjit.ko currently needs li
Translate basic iptables rule blob to the IMR, then ask
IMR to translate to ebpf.
IMR is shared between nft and bpfilter translators.
iptables_gen_append() is the only relevant function here,
as it demonstrates simple 'source/destination matches x' test.
Signed-off-by: Florian Westphal
---
net/
These patches, which go on top of the 'bpfilter' RFC patches,
demonstrate an nftables to ebpf translation (done in userspace).
In order to not duplicate the ebpf code generation efforts, the rules
iptables -i lo -d 127.0.0.2 -j DROP
and
nft add rule ip filter input ip daddr 127.0.0.2 drop
are fir
From: Yossi Kuperman
Artem Savkov reported that commit 5efec5c655dd leads to a packet loss under
IPSec configuration. It appears that his setup consists of a TUN device,
which does not have a MAC header.
Make sure MAC header exists.
Note: TUN device sets a MAC header pointer, although it does n
Sun, Mar 04, 2018 at 07:24:12PM CET, alexander.du...@gmail.com wrote:
>On Sat, Mar 3, 2018 at 11:13 PM, Jiri Pirko wrote:
>> Sun, Mar 04, 2018 at 01:26:53AM CET, alexander.du...@gmail.com wrote:
>>>On Sat, Mar 3, 2018 at 1:25 PM, Jiri Pirko wrote:
Sat, Mar 03, 2018 at 07:04:57PM CET, alexand
On 03/01/2018 07:10 PM, Andrew Lunn wrote:
>> +void mv88e6352_serdes_get_strings(struct mv88e6xxx_chip *chip,
>> + int port, uint8_t *data)
>> +{
>> +struct mv88e6352_serdes_hw_stat *stat;
>> +int i;
>> +
>> +if (!mv88e6352_port_has_serdes(chip, port))
>>
__dev_mc_add grabs an adress spinlock so use
atomic context in kmalloc.
/ # ifconfig eth0 inet 192.168.0.111
[ 89.331622] BUG: sleeping function called from invalid context at
mm/slab.h:420
[ 89.339002] in_atomic(): 1, irqs_disabled(): 0, pid: 1035, name: ifconfig
[ 89.345799] 2 locks held
This patch adds TCP_NLA_SENDQ_SIZE stat into SCM_TIMESTAMPING_OPT_STATS.
It reports no. of bytes present in send queue, when timestamp is
generated.
Signed-off-by: Priyaranjan Jha
Signed-off-by: Neal Cardwell
Signed-off-by: Yuchung Cheng
Signed-off-by: Soheil Hassas Yeganeh
---
include/uapi/l
This patch adds TCP_NLA_CA_STATE stat into SCM_TIMESTAMPING_OPT_STATS.
It reports ca_state of socket, when timestamp is generated.
Signed-off-by: Priyaranjan Jha
Signed-off-by: Neal Cardwell
Signed-off-by: Yuchung Cheng
Signed-off-by: Soheil Hassas Yeganeh
---
include/uapi/linux/tcp.h | 1 +
From: Andrew Lunn
Date: Thu, 1 Mar 2018 02:02:26 +0100
> The mv88e6352 family has a SERDES interface which can be used for
> example to connect to SFF/SFP modules. This interface has a couple of
> statistics counters. Add support for including these counters in the
> output of ethtool -S.
Serie
From: Alexander Kurz
Date: Wed, 28 Feb 2018 21:27:39 +
> -static int ax88179_bind(struct usbnet *dev, struct usb_interface *intf)
> +static int ax88179_link_bind_or_reset(struct usbnet *dev, int do_reset)
"do_reset" is a boolean, therefore please use type 'bool' and true/false.
Thank you.
From: "Brenda J. Butler"
Date: Wed, 28 Feb 2018 15:36:19 -0500
> Add a command line arg to suppress tap output. Handy in case
> all the tap output is being supplied by the plugins.
>
> Signed-off-by: Brenda J. Butler
> ---
>
> v2: Drop the first patch that changes the format
> of the ta
On Sat, Mar 3, 2018 at 11:13 PM, Jiri Pirko wrote:
> Sun, Mar 04, 2018 at 01:26:53AM CET, alexander.du...@gmail.com wrote:
>>On Sat, Mar 3, 2018 at 1:25 PM, Jiri Pirko wrote:
>>> Sat, Mar 03, 2018 at 07:04:57PM CET, alexander.du...@gmail.com wrote:
On Sat, Mar 3, 2018 at 3:31 AM, Jiri Pirko
From: David Ahern
Date: Fri, 2 Mar 2018 08:32:11 -0800
> Hardware supports multipath selection using the standard L4 5-tuple
> instead of just L3 and the flow label. In addition, some network
> operators prefer IPv6 path selection to use the 5-tuple. To that end,
> add support to IPv6 for multip
From: Xin Long
Date: Thu, 1 Mar 2018 23:05:09 +0800
> This cleanup mostly does three things:
>
> - extract some codes into functions to make sendmsg more readable.
>
> - tidy up some codes to avoid the unnecessary checks.
>
> - adjust some logic so that it will be easier to add the send fl
On Fri, 2 Mar 2018 19:36:16 +0100
Davide Caratti wrote:
> If the user didn't specify any control action, don't pop the command line
> arguments: otherwise, parsing of the next argument (tipically the 'index'
> keyword) results in an error, causing the following 'tc-testing' failures:
>
> Test
On Sat, 3 Mar 2018 22:56:02 +0100
David Kaufmann wrote:
> Hi!
>
> `lnstat` segfaults (tested on Debian 9, CentOS 6+7, Fedora 27) if it is
> started as `lnstat -w 1`
>
> according to gdb the crash is in `build_hdr_string` at lnstat.c:212
>
> as it seems to be an useless value for the option any
On Fri, Mar 02, 2018 at 03:08:35PM -0800, Florian Fainelli wrote:
> Hi all,
>
> After turning on KASAN on one of my systems, I started getting lots of out of
> bounds errors while fetching a given port's statistics, and indeed using
> memcpy() is unsafe for copying strings which have not been decl
On 04/03/2018 17:13, Mark Bloch wrote:
On 04/03/2018 15:26, Paul Blakey wrote:
When inserting duplicate objects (those with the same key),
current rhlist implementation messes up the chain pointers by
updating the bucket pointer instead of prev next pointer to the
newly inserted node. This c
Hi Michael
> mdio {
> compatible = "cdns,macb-mdio";
> /* reg = <0xe000b000 0x1000>; */
> /* clocks = <&clkc 30>, <&clkc 30>, <&clkc 13>; */
> /* clock-names = "pclk", "hcl
On our mlx5 driver fs_core.c, we use the rhltable interface to store
flow groups. We noticed that sometimes we get a warning that flow group isn't
found at removal. This rare case was caused when a specific scenario happened,
insertion of a flow group with a similar match criteria (a duplicate),
bu
Tries to insert duplicates in the middle of bucket's chain:
bucket 1: [[val 21 (tid=1)]] -> [[ val 1 (tid=2), val 1 (tid=0) ]]
Reuses tid to distinguish the elements insertion order.
Signed-off-by: Paul Blakey
---
lib/test_rhashtable.c | 134 ++
When inserting duplicate objects (those with the same key),
current rhlist implementation messes up the chain pointers by
updating the bucket pointer instead of prev next pointer to the
newly inserted node. This causes missing elements on removal and
travesal.
Fix that by properly updating pprev p
On 04/03/2018 15:26, Paul Blakey wrote:
> When inserting duplicate objects (those with the same key),
> current rhlist implementation messes up the chain pointers by
> updating the bucket pointer instead of prev next pointer to the
> newly inserted node. This causes missing elements on removal an
On Sat, Mar 3, 2018 at 4:19 AM, Serge E. Hallyn wrote:
> On Thu, Mar 01, 2018 at 02:41:04PM -0500, Richard Guy Briggs wrote:
> ...
>> +static inline bool audit_containerid_set(struct task_struct *tsk)
>
> Hi Richard,
>
> the calls to audit_containerid_set() confused me. Could you make it
> is_aud
Currently the tc action test is used only to test mirred redirect
action. This patch extends it for mirred mirror.
Signed-off-by: Jiri Pirko
Reviewed-by: Ido Schimmel
Signed-off-by: Arkadi Sharshevsky
---
tools/testing/selftests/net/forwarding/tc_actions.sh | 16 ++--
1 file change
On Sun, Mar 04, 2018 at 03:26:49PM +0200, Paul Blakey wrote:
> Tries to insert duplicates in the middle of bucket's chain:
> bucket 1: [[val 21 (tid=1)]] -> [[ val 1 (tid=2), val 1 (tid=0) ]]
>
> Reuses tid to distinguish the elements insertion order.
>
> Signed-off-by: Paul Blakey
Acked-by:
On Sun, Mar 04, 2018 at 03:26:48PM +0200, Paul Blakey wrote:
> When inserting duplicate objects (those with the same key),
> current rhlist implementation messes up the chain pointers by
> updating the bucket pointer instead of prev next pointer to the
> newly inserted node. This causes missing ele
On Sun, Mar 04, 2018 at 02:34:26PM +0200, Paul Blakey wrote:
> When inserting duplicate objects (those with the same key),
> current rhashtable implementation messes up the chain pointers by
> updating the bucket pointer instead of prev next pointer to the
> newly inserted node. This causes missing
On Sun, Mar 04, 2018 at 02:29:35PM +0530, Arushi Singhal wrote:
> Using pr_() is more concise than printk(KERN_).
> Replace printks having a log level with the appropriate pr_*() macros.
>
> Signed-off-by: Arushi Singhal
> ---
> drivers/staging/ipx/af_ipx.c | 2 +-
> 1 file changed, 1 insertion(
On 04/03/2018 14:57, Herbert Xu wrote:
On Sun, Mar 04, 2018 at 02:34:26PM +0200, Paul Blakey wrote:
When inserting duplicate objects (those with the same key),
current rhashtable implementation messes up the chain pointers by
updating the bucket pointer instead of prev next pointer to the
newl
On our mlx5 driver fs_core.c, we use the rhltable interface to store
flow groups. We noticed that sometimes we get a warning that flow group isn't
found at removal. This rare case was caused when a specific scenario happened,
insertion of a flow group with a similar match criteria (a duplicate),
bu
When inserting duplicate objects (those with the same key),
current rhlist implementation messes up the chain pointers by
updating the bucket pointer instead of prev next pointer to the
newly inserted node. This causes missing elements on removal and
travesal.
Fix that by properly updating pprev p
Tries to insert duplicates in the middle of bucket's chain:
bucket 1: [[val 21 (tid=1)]] -> [[ val 1 (tid=2), val 1 (tid=0) ]]
Reuses tid to distinguish the elements insertion order.
Signed-off-by: Paul Blakey
---
lib/test_rhashtable.c | 121 ++
On Sun, Mar 04, 2018 at 02:34:26PM +0200, Paul Blakey wrote:
> When inserting duplicate objects (those with the same key),
> current rhashtable implementation messes up the chain pointers by
> updating the bucket pointer instead of prev next pointer to the
> newly inserted node. This causes missing
On our mlx5 driver fs_core.c, we use the rhltable interface to store
flow groups. We noticed that sometimes we get a warning that flow group isn't
found at removal. This rare case was caused when a specific scenrio happened,
insertion of a flow group with a similar match criteria (duplicate),
but
Tries to insert duplicates in the middle of bucket's chain:
bucket 1: [[val 21 (tid=1)]] -> [[ val 1 (tid=2), val 1 (tid=0) ]]
Reuses tid to distinguish the elements insertion order.
Signed-off-by: Paul Blakey
---
lib/test_rhashtable.c | 121 ++
When inserting duplicate objects (those with the same key),
current rhashtable implementation messes up the chain pointers by
updating the bucket pointer instead of prev next pointer to the
newly inserted node. This causes missing elements on removal and
travesal.
Fix that by properly updating ppr
LRO and RX-FCS offloads cannot be enabled at the same time since it is
not clear what should happen to the FCS of each coalesced packet.
The FCS is not really part of the TCP payload, hence cannot be merged
into one big packet. On the other hand, providing one big LRO packet
with one FCS contradict
> > To perform checksum in HW, HW obviously should work in store and
> forward mode. Store all frame in TX FIFO and then check checksum.
> > If mtu 1500B, everything fine and all port can do this.
> >
> > If mtu is 9KB and 9KB frame transmitted, Port 0 still can do HW checksum.
> But ports 1 and 2
> -Original Message-
> From: Thomas Petazzoni [mailto:thomas.petazz...@bootlin.com]
> Sent: Sunday, March 04, 2018 11:25 AM
> To: Stefan Chulski
> Cc: Antoine Tenart ; da...@davemloft.net;
> Yan Markman ; netdev@vger.kernel.org; linux-
> ker...@vger.kernel.org; maxime.chevall...@bootlin.
Hello,
On Sun, 4 Mar 2018 06:56:02 +, Stefan Chulski wrote:
> > > + if (port->pool_long->id == MVPP2_BM_JUMBO && port->id != 0) {
> >
> > Again, all over the place we hardcode the fact that Jumbo frames can only be
> > used on port 0. I know port 0 is the only one that can do 10G, but are
Hello,
On Sun, 4 Mar 2018 06:29:59 +, Stefan Chulski wrote:
> > Is there a reason to hardcode 10KB for port 0, and 3KB for the other ports ?
> > Would there be use cases where the user may want different configurations
> > ?
>
> Design requirement are 10KB TX FIFO for the 10Gb/sec and 2.5KB
Using pr_() is more concise than printk(KERN_).
Replace printks having a log level with the appropriate pr_*() macros.
Signed-off-by: Arushi Singhal
---
drivers/staging/ipx/af_ipx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/ipx/af_ipx.c b/drivers/staging
On Fri, Mar 02, 2018 at 08:45:53AM -0800, David Ahern wrote:
> For tests using veth interfaces, the test infrastructure can create
> the netdevs if they do not exist. Arguably this is a preferred approach
> since the tests require p$N and p$(N+1) to be pairs.
>
> Signed-off-by: David Ahern
[...]
Hello!
On 3/4/2018 1:39 AM, Niklas Söderlund wrote:
When addressing a review comment in a early version of the offending
patch a comment where left in which should have been removed. Remove the
s/where/was/?
comment to keep it consistent with the code.
Fixes: 75efa06f457bbed3 ("ravb: ad
90 matches
Mail list logo
