Re: [PATCH][rds-next] rds: make functions rds_info_from_znotifier and rds_message_zcopy_from_user static

2018-03-12 Thread santosh.shilim...@oracle.com
On 3/11/18 11:54 PM, santosh.shilim...@oracle.com wrote: On 3/11/18 10:03 AM, Colin King wrote: From: Colin Ian King Functions rds_info_from_znotifier and rds_message_zcopy_from_user are local to the source and do not need to be in global scope, so make them static. Cleans up sparse warnins:

Re: [PATCH 1/2] net: rds: drop VLA in rds_for_each_conn_info()

2018-03-12 Thread santosh.shilim...@oracle.com
On 3/11/18 2:07 PM, Salvatore Mesoraca wrote: Avoid VLA[1] by using an already allocated buffer passed by the caller. [1] https://lkml.org/lkml/2018/3/7/621 Signed-off-by: Salvatore Mesoraca --- Thanks for both VLA fixes Salvatore. FWIW, Acked-by: Santosh Shilimkar

Re: [PATCH 2/2] net: rds: drop VLA in rds_walk_conn_path_info()

2018-03-12 Thread santosh.shilim...@oracle.com
On 3/11/18 2:07 PM, Salvatore Mesoraca wrote: Avoid VLA[1] by using an already allocated buffer passed by the caller. [1] https://lkml.org/lkml/2018/3/7/621 Signed-off-by: Salvatore Mesoraca --- Acked-by: Santosh Shilimkar

Re: [pci PATCH v4 1/4] pci-iov: Add support for unmanaged SR-IOV

2018-03-12 Thread Christoph Hellwig
On Sun, Mar 11, 2018 at 09:59:09PM -0600, Alex Williamson wrote: > I still struggle to understand why we need this "unmanaged" > complication and how a user of the sysfs API is expected to have any > idea whether a PF is managed or unmanaged and why they should care. > Can't we just have a pci_simp

Re: KASAN: use-after-free Read in sctp_association_free (2)

2018-03-12 Thread Xin Long
On Sun, Mar 11, 2018 at 3:04 AM, Neil Horman wrote: > On Sun, Mar 11, 2018 at 12:22:32AM +0800, Xin Long wrote: >> On Sat, Mar 10, 2018 at 9:13 PM, Neil Horman wrote: >> > On Sat, Mar 10, 2018 at 03:58:04PM +0800, Xin Long wrote: >> >> On Sat, Mar 10, 2018 at 6:08 AM, Neil Horman >> >> wrote: >

Re: [PATCH] net/mlx4_en: Fix a memory leak in case of error in 'mlx4_en_init_netdev()'

2018-03-12 Thread Tariq Toukan
On 12/03/2018 12:45 AM, Christophe JAILLET wrote: If 'kzalloc' fails, we must free some memory before returning. Fixes: 67f8b1dcb9ee ("net/mlx4_en: Refactor the XDP forwarding rings scheme") Signed-off-by: Christophe JAILLET --- drivers/net/ethernet/mellanox/mlx4/en_netdev.c | 2 +- 1 file

[PATCH v4 5/6] staging: fsl-dpaa2/ethsw: Add README

2018-03-12 Thread Razvan Stefanescu
Add a README file describing the driver architecture, components and interfaces. Signed-off-by: Razvan Stefanescu --- Changelog: v2: - no changes v3: - no changes v4: - no changes drivers/staging/fsl-dpaa2/ethsw/README | 106 + 1 file changed, 106

[PATCH v4 6/6] staging: fsl-dpaa2/ethsw: Add TODO

2018-03-12 Thread Razvan Stefanescu
Add a TODO file describing what needs to be added/changed before the driver can be moved out of staging. Signed-off-by: Razvan Stefanescu --- Changelog: v2: - no changes v3: - no changes v4: - remove fsl-mc bus driver dependency as it is out of staging drivers/staging/fsl-dpaa2/e

[PATCH v4 4/6] staging: fsl-dpaa2/ethsw: Add maintainer for Ethernet Switch driver

2018-03-12 Thread Razvan Stefanescu
Signed-off-by: Razvan Stefanescu --- Changelog: v2: - no changes v3: - no changes v4: - no changes MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index c3c2b75..20d7bf2 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -4410,6 +4410,12

[PATCH v4 1/6] staging: fsl-dpaa2/ethsw: Add APIs for DPSW object

2018-03-12 Thread Razvan Stefanescu
Add the command build/parse APIs for operating on DPSW objects through the DPAA2 Management Complex. Signed-off-by: Razvan Stefanescu --- Changelog: v2: - use u8 for en parameter of dpsw_if_set_flooding/broadcast() v3: - no changes v4: - adjust to moving MC-bus out of staging -

[PATCH v4 3/6] staging: fsl-dpaa2/ethsw: Add ethtool support

2018-03-12 Thread Razvan Stefanescu
Add driver information, link details and hardware statistics to be reported via ethtool -S. Signed-off-by: Razvan Stefanescu --- Changelog: v2: - no changes v3: - removed driver version v4: - no changes drivers/staging/fsl-dpaa2/ethsw/Makefile| 2 +- drivers/staging/fsl

[PATCH v4 2/6] staging: fsl-dpaa2/ethsw: Add Freescale DPAA2 Ethernet Switch driver

2018-03-12 Thread Razvan Stefanescu
Introduce the DPAA2 Ethernet Switch driver, which manages Datapath Switch (DPSW) objects discovered on the MC bus. Suggested-by: Alexandru Marginean Signed-off-by: Razvan Stefanescu --- Changelog: v2: - fix PVID cleanup in ethsw_port_add_vlan() - rename err2 to ret in ethsw_port_add/del

Re: [PATCH net v2 2/2] l2tp: fix races with ipv4-mapped ipv6 addresses

2018-03-12 Thread Paolo Abeni
On Fri, 2018-03-09 at 19:26 +0100, Guillaume Nault wrote: > On Fri, Mar 09, 2018 at 06:58:00PM +0100, Paolo Abeni wrote: > > The single threaded reproducer does not trigger anymore after 1/2, > > _but_ if ask syzbot to test 1/2 that will trigger another splat, > > because syzbot will do also multi

[PATCH] can: m_can: select pinctrl state in each suspend/resume function

2018-03-12 Thread Bich HEMON
Make sure to apply the correct pin state in suspend/resume callbacks. Putting pins in sleep state saves power. Signed-off-by: Bich Hemon --- drivers/net/can/m_can/m_can.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/net/can/m_can/m_can.c b/drivers/net/can/m_can/m_can.c index 2

[PATCH v4 0/6] staging: Introduce DPAA2 Ethernet Switch driver

2018-03-12 Thread Razvan Stefanescu
This patchset introduces the Ethernet Switch Driver for Freescale/NXP SoCs with DPAA2 (DataPath Acceleration Architecture v2). The driver manages switch objects discovered on the fsl-mc bus. A description of the driver can be found in the associated README file. The patchset consists of: * A set o

Re: [PATCH net-next] net: stmmac: remove superfluous wmb() memory barriers

2018-03-12 Thread Niklas Cassel
On Fri, Mar 09, 2018 at 10:15:20AM -0500, David Miller wrote: > From: Jose Abreu > Date: Fri, 9 Mar 2018 10:26:11 + > > > Sorry but I know at least two architectures which don't do a > > wmb() upon an writel [1] [2]. This can be critical if if we are > > accessing the device through some slow

Re: [PATCH] can: m_can: select pinctrl state in each suspend/resume function

2018-03-12 Thread Marc Kleine-Budde
On 03/12/2018 09:52 AM, Bich HEMON wrote: > Make sure to apply the correct pin state in suspend/resume callbacks. > Putting pins in sleep state saves power. > > Signed-off-by: Bich Hemon > --- Doesn't compile: > CHECK /srv/work/frogger/socketcan/linux/drivers/net/can/m_can/m_can.c > /srv/wo

Re: [RESEND] rsi: Remove stack VLA usage

2018-03-12 Thread Kalle Valo
tcharding wrote: > The kernel would like to have all stack VLA usage removed[1]. rsi uses > a VLA based on 'blksize'. Elsewhere in the SDIO code maximum block size > is defined using a magic number. We can use a pre-processor defined > constant and declare the array to maximum size. We add a

Re: Problem with bridge (mcast-to-ucast + hairpin) and Broadcom's 802.11f in their FullMAC fw

2018-03-12 Thread Rafał Miłecki
On 27 February 2018 at 18:05, Stephen Hemminger wrote: > On Tue, 27 Feb 2018 11:08:20 +0100 > Rafał Miłecki wrote: > >> I've problem when using OpenWrt/LEDE on a home router with Broadcom's >> FullMAC WiFi chipset. >> >> >> First of all OpenWrt/LEDE uses bridge interface for LAN network with: >>

Re: Problem with bridge (mcast-to-ucast + hairpin) and Broadcom's 802.11f in their FullMAC fw

2018-03-12 Thread Rafał Miłecki
On 28 February 2018 at 12:31, Arend van Spriel wrote: > On 2/27/2018 11:14 AM, Rafał Miłecki wrote: >> >> Sending with a fixed linux-wireless ML address. Please kindly send your >> replies using linux-wireless@ >> >> On 02/27/2018 11:08 AM, Rafał Miłecki wrote: >>> >>> I've problem when using Open

[PATCH net-next] net: Make RX-FCS and HW GRO mutually exclusive

2018-03-12 Thread Gal Pressman
Same as LRO, hardware GRO cannot be enabled with RX-FCS. When both are requested, hardware GRO will be dropped. Suggested-by: David Miller Signed-off-by: Gal Pressman --- net/core/dev.c | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/net/core/dev.c b/net/cor

[BUGFIX PATCH bpf-next] error-injection: Fix to prohibit jump optimization

2018-03-12 Thread Masami Hiramatsu
Since the kprobe which was optimized by jump can not change the execution path, the kprobe for error-injection must not be optimized. To prohibit it, set a dummy post-handler as officially stated in Documentation/kprobes.txt. Fixes: 4b1a29a7f542 ("error-injection: Support fault injection framework

pull-request: can 2018-03-12

2018-03-12 Thread Marc Kleine-Budde
r: fix the incorrect calculation of max delta_t (2018-03-11 22:48:59 -0400) are available in the Git repository at: ssh://g...@gitolite.kernel.org/pub/scm/linux/kernel/git/mkl/linux-can.git tags/linux-can-fixes-for-4.16-20180312 for you to fetch changes up to c9b3bce18da4a0aebc27853052de

[PATCH 1/6] can: m_can: change comparison to bitshift when dealing with a mask

2018-03-12 Thread Marc Kleine-Budde
From: Wolfram Sang Due to a typo, the mask was destroyed by a comparison instead of a bit shift. Reported-by: Geert Uytterhoeven Signed-off-by: Wolfram Sang Signed-off-by: Marc Kleine-Budde --- drivers/net/can/m_can/m_can.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/

[PATCH 3/6] can: ifi: Repair the error handling

2018-03-12 Thread Marc Kleine-Budde
From: Marek Vasut The new version of the IFI CANFD core has significantly less complex error state indication logic. In particular, the warning/error state bits are no longer all over the place, but are all present in the STATUS register. Moreover, there is a new IRQ register bit indicating trans

[PATCH 4/6] can: peak/pcie_fd: fix echo_skb is occupied! bug

2018-03-12 Thread Marc Kleine-Budde
From: Stephane Grosjean This patch makes atomic the handling of the linux-can echo_skb array and the network tx queue. This prevents from the "BUG! echo_skb is occupied!" message to be printed by the linux-can core, in SMP environments. Reported-by: Diana Burgess Signed-off-by: Stephane Grosjea

[PATCH 6/6] can: m_can: select pinctrl state in each suspend/resume function

2018-03-12 Thread Marc Kleine-Budde
From: Bich HEMON Make sure to apply the correct pin state in suspend/resume callbacks. Putting pins in sleep state saves power. Signed-off-by: Bich Hemon Signed-off-by: Marc Kleine-Budde --- drivers/net/can/m_can/m_can.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/net/can

[PATCH 2/6] can: ifi: Check core revision upon probe

2018-03-12 Thread Marc Kleine-Budde
From: Marek Vasut Older versions of the core are not compatible with the driver due to various intrusive fixes of the core. Read out the VER register, check the core revision bitfield and verify if the core in use is new enough (rev 2.1 or newer) to work correctly with this driver. Signed-off-by

[PATCH 5/6] can: peak/pcie_fd: remove useless code when interface starts

2018-03-12 Thread Marc Kleine-Budde
From: Stephane Grosjean When an interface starts, the echo_skb array is empty and the network queue should be started only. This patch replaces useless code and locks when the internal RX_BARRIER message is received from the IP core, telling the driver that tx may start. Signed-off-by: Stephane

Re: [bpf-next V3 PATCH 13/15] mlx5: use page_pool for xdp_return_frame call

2018-03-12 Thread Tariq Toukan
On 09/03/2018 10:56 PM, Jesper Dangaard Brouer wrote: This patch shows how it is possible to have both the driver local page cache, which uses elevated refcnt for "catching"/avoiding SKB put_page. And at the same time, have pages getting returned to the page_pool from ndp_xdp_xmit DMA completi

Re: [PATCH 2/2] net/usb/ax88179_178a: Delete three unnecessary variables in ax88179_chk_eee()

2018-03-12 Thread Oliver Neukum
Am Samstag, den 10.03.2018, 19:26 +0100 schrieb SF Markus Elfring: > From: Markus Elfring > Date: Sat, 10 Mar 2018 18:53:28 +0100 > > Use three values directly for a condition check without assigning them > to intermediate variables. Hi, what is the benefit of this? It looks like needless code

Re: [PATCH 1/2] net: rds: drop VLA in rds_for_each_conn_info()

2018-03-12 Thread Salvatore Mesoraca
2018-03-12 8:06 GMT+01:00 santosh.shilim...@oracle.com : > On 3/11/18 2:07 PM, Salvatore Mesoraca wrote: >> >> Avoid VLA[1] by using an already allocated buffer passed >> by the caller. >> >> [1] https://lkml.org/lkml/2018/3/7/621 >> >> Signed-off-by: Salvatore Mesoraca >> --- > > Thanks for both

Re: [bpf-next V3 PATCH 13/15] mlx5: use page_pool for xdp_return_frame call

2018-03-12 Thread Tariq Toukan
On 12/03/2018 12:08 PM, Tariq Toukan wrote: On 09/03/2018 10:56 PM, Jesper Dangaard Brouer wrote: This patch shows how it is possible to have both the driver local page cache, which uses elevated refcnt for "catching"/avoiding SKB put_page.  And at the same time, have pages getting returned

Re: [BUGFIX PATCH bpf-next] error-injection: Fix to prohibit jump optimization

2018-03-12 Thread Masami Hiramatsu
On Mon, 12 Mar 2018 19:00:49 +0900 Masami Hiramatsu wrote: > Since the kprobe which was optimized by jump can not change > the execution path, the kprobe for error-injection must not > be optimized. To prohibit it, set a dummy post-handler as > officially stated in Documentation/kprobes.txt. Not

Re: [PATCH 6/6] can: m_can: select pinctrl state in each suspend/resume function

2018-03-12 Thread Bich HEMON
Hi Mark, Thanks for the fix. On 03/12/2018 11:04 AM, Marc Kleine-Budde wrote: > From: Bich HEMON > > Make sure to apply the correct pin state in suspend/resume callbacks. > Putting pins in sleep state saves power. > > Signed-off-by: Bich Hemon > Signed-off-by: Marc Kleine-Budde > --- > dri

Re: [BUGFIX PATCH bpf-next] error-injection: Fix to prohibit jump optimization

2018-03-12 Thread Daniel Borkmann
Hi Masami, On 03/12/2018 11:27 AM, Masami Hiramatsu wrote: > On Mon, 12 Mar 2018 19:00:49 +0900 > Masami Hiramatsu wrote: > >> Since the kprobe which was optimized by jump can not change >> the execution path, the kprobe for error-injection must not >> be optimized. To prohibit it, set a dummy p

Re: Problem with bridge (mcast-to-ucast + hairpin) and Broadcom's 802.11f in their FullMAC fw

2018-03-12 Thread Linus Lüssing
On Tue, Feb 27, 2018 at 11:08:20AM +0100, Rafał Miłecki wrote: > I've problem when using OpenWrt/LEDE on a home router with Broadcom's > FullMAC WiFi chipset. Hi Rafał, Thanks for reporting this issue! > Can you see any solution for this problem? Is that an option to stop > multicast-to-unicast

Re: KASAN: use-after-free Read in sctp_association_free (2)

2018-03-12 Thread Neil Horman
On Mon, Mar 12, 2018 at 04:16:27PM +0800, Xin Long wrote: > On Sun, Mar 11, 2018 at 3:04 AM, Neil Horman wrote: > > On Sun, Mar 11, 2018 at 12:22:32AM +0800, Xin Long wrote: > >> On Sat, Mar 10, 2018 at 9:13 PM, Neil Horman wrote: > >> > On Sat, Mar 10, 2018 at 03:58:04PM +0800, Xin Long wrote: >

Re: Problem with bridge (mcast-to-ucast + hairpin) and Broadcom's 802.11f in their FullMAC fw

2018-03-12 Thread Linus Lüssing
On Mon, Mar 12, 2018 at 10:46:45AM +0100, Rafał Miłecki wrote: > On 27 February 2018 at 18:05, Stephen Hemminger [...] > > ebtables is your friend in dealing with weird and broken devices. > > It may be weird, not sure if actually broken. Anyway I'd like to have > some generic solution instead of

Re: Problem with bridge (mcast-to-ucast + hairpin) and Broadcom's 802.11f in their FullMAC fw

2018-03-12 Thread Linus Lüssing
On Mon, Mar 12, 2018 at 12:08:56PM +0100, Linus Lüssing wrote: > On Tue, Feb 27, 2018 at 11:08:20AM +0100, Rafał Miłecki wrote: > > I've problem when using OpenWrt/LEDE on a home router with Broadcom's > > FullMAC WiFi chipset. > > Hi Rafał, > > Thanks for reporting this issue! > > > Can you see

Re: [PATCH net-next] modules: allow modprobe load regular elf binaries

2018-03-12 Thread Edward Cree
On 09/03/18 18:58, Alexei Starovoitov wrote: > It's not waiting for the whole thing, because once bpfilter starts it > stays running/sleeping because it's stateful. So, this has been bugging me a bit. If bpfilter takes a signal and crashes, all that state goes away. Does that mean your iptables/net

[PATCH net-next] sctp: fix error return code in sctp_sendmsg_new_asoc()

2018-03-12 Thread Wei Yongjun
Return error code -EINVAL in the address len check error handling case since 'err' can be overwrite to 0 by 'err = sctp_verify_addr()' in the for loop. Fixes: 2c0dbaa0c43d ("sctp: add support for SCTP_DSTADDRV4/6 Information for sendmsg") Signed-off-by: Wei Yongjun --- net/sctp/socket.c | 8 +++

[PATCH net-next] mlxsw: spectrum_kvdl: Make some functions static

2018-03-12 Thread Wei Yongjun
Fixes the following sparse warnings: drivers/net/ethernet/mellanox/mlxsw/spectrum_kvdl.c:371:5: warning: symbol 'mlxsw_sp_kvdl_single_occ_get' was not declared. Should it be static? drivers/net/ethernet/mellanox/mlxsw/spectrum_kvdl.c:384:5: warning: symbol 'mlxsw_sp_kvdl_chunks_occ_get' was not

Re: [PATCH v2] net: ipv6: xfrm6_state: remove VLA usage

2018-03-12 Thread Steffen Klassert
On Sat, Mar 10, 2018 at 07:26:44PM +0100, Stefano Brivio wrote: > On Sat, 10 Mar 2018 09:18:46 -0800 > Kees Cook wrote: > > > On Sat, Mar 10, 2018 at 12:43 AM, Stefano Brivio wrote: > > > On Sat, 10 Mar 2018 09:40:44 +0200 > > > Andreas Christoforou wrote: > > > > > >> diff --git a/net/ipv6/x

Re: [PATCH net-next] mlxsw: spectrum_kvdl: Make some functions static

2018-03-12 Thread Jiri Pirko
Mon, Mar 12, 2018 at 01:25:24PM CET, weiyongj...@huawei.com wrote: >Fixes the following sparse warnings: > >drivers/net/ethernet/mellanox/mlxsw/spectrum_kvdl.c:371:5: warning: > symbol 'mlxsw_sp_kvdl_single_occ_get' was not declared. Should it be static? >drivers/net/ethernet/mellanox/mlxsw/spectru

Re: [bpf-next V3 PATCH 13/15] mlx5: use page_pool for xdp_return_frame call

2018-03-12 Thread Tariq Toukan
On 12/03/2018 12:16 PM, Tariq Toukan wrote: On 12/03/2018 12:08 PM, Tariq Toukan wrote: On 09/03/2018 10:56 PM, Jesper Dangaard Brouer wrote: This patch shows how it is possible to have both the driver local page cache, which uses elevated refcnt for "catching"/avoiding SKB put_page.  And

Re: [PATCH v10 crypto 09/11] chtls: Inline TLS request Tx/Rx

2018-03-12 Thread Stefano Brivio
On Sat, 10 Mar 2018 00:40:14 +0530 Atul Gupta wrote: > TLS handler for record transmit and receive. > Create Inline TLS work request and post to FW. > Create Inline TLS record CPLs for hardware > > Signed-off-by: Atul Gupta > --- > drivers/crypto/chelsio/chtls/chtls_io.c | 1863 >

Re: [PATCH v10 crypto 08/11] chtls: CPL handler definition

2018-03-12 Thread Stefano Brivio
On Sat, 10 Mar 2018 00:40:13 +0530 Atul Gupta wrote: > Exchange CPL messages with hardware to program the TLS session > CPL handlers defined to process messages received from chip. > > Signed-off-by: Atul Gupta > --- > drivers/crypto/chelsio/chtls/chtls_cm.c | 2041 > +

Re: [PATCH v10 crypto 07/11] chtls: Program the TLS Key

2018-03-12 Thread Stefano Brivio
On Sat, 10 Mar 2018 00:40:12 +0530 Atul Gupta wrote: > Initialize the space reserved for storing the TLS keys > get and free the location where key is stored for the TLS > connection > Program the tx and rx key as received from user in > struct tls12_crypto_info_aes_gcm_128 and understood by hard

Re: [PATCH net-next] sctp: fix error return code in sctp_sendmsg_new_asoc()

2018-03-12 Thread Xin Long
On Mon, Mar 12, 2018 at 8:16 PM, Wei Yongjun wrote: > Return error code -EINVAL in the address len check error handling > case since 'err' can be overwrite to 0 by 'err = sctp_verify_addr()' > in the for loop. > > Fixes: 2c0dbaa0c43d ("sctp: add support for SCTP_DSTADDRV4/6 Information for > send

[PATCH net v3 2/2] l2tp: fix races with ipv4-mapped ipv6 addresses

2018-03-12 Thread Paolo Abeni
The l2tp_tunnel_create() function checks for v4mapped ipv6 sockets and cache that flag, so that l2tp core code can reusing it at xmit time. If the socket is provided by the userspace, the connection status of the tunnel sockets can change between the tunnel creation and the xmit call, so that syzb

[PATCH net v3 0/2] l2tp: fix races with ipv4-mapped ipv6 addresses

2018-03-12 Thread Paolo Abeni
The syzbot reported an l2tp oops that uncovered some races in the l2tp xmit path and a partially related issue in the generic ipv6 code. We need to address them separately. v1 -> v2: - add missing fixes tag in patch 1 - fix several issues in patch 2 v2 -> v3: - dropped some unneeded chunks in

[PATCH net v3 1/2] net: ipv6: keep sk status consistent after datagram connect failure

2018-03-12 Thread Paolo Abeni
On unsuccesful ip6_datagram_connect(), if the failure is caused by ip6_datagram_dst_update(), the sk peer information are cleared, but the sk->sk_state is preserved. If the socket was already in an established status, the overall sk status is inconsistent and fouls later checks in datagram code.

Re: [PATCH 1/1] qed: Add firmware 8.33.11.0

2018-03-12 Thread Josh Boyer
On Feb 28, Rahul Verma wrote: > This patch add a new qed firmware with fixes and added > support for new features. > -Support VLAN remove action in steering flow. > -Optimized the FW flow and several bug fixes. > -Allow VXLAN steering. > -Supports T10DIF and SRQ. > -Support for port redirection for

Re: [BUGFIX PATCH bpf-next] error-injection: Fix to prohibit jump optimization

2018-03-12 Thread Masami Hiramatsu
On Mon, 12 Mar 2018 11:44:21 +0100 Daniel Borkmann wrote: > Hi Masami, > > On 03/12/2018 11:27 AM, Masami Hiramatsu wrote: > > On Mon, 12 Mar 2018 19:00:49 +0900 > > Masami Hiramatsu wrote: > > > >> Since the kprobe which was optimized by jump can not change > >> the execution path, the kprobe

Re: [PATCH linux-firmware] Mellanox: Add new mlxsw_spectrum firmware 13.1620.192

2018-03-12 Thread Josh Boyer
On Tue, Feb 27, 2018 at 3:51 AM, Tal Bar wrote: > This new firmware contains: > - Support for auto-neg disable mode > > Signed-off-by: Tal Bar > --- > WHENCE | 1 + > mellanox/mlxsw_spectrum-13.1620.192.mfa2 | Bin 0 -> 1091848 bytes > 2 files changed,

Re: [PATCH v4 2/6] staging: fsl-dpaa2/ethsw: Add Freescale DPAA2 Ethernet Switch driver

2018-03-12 Thread Andrew Lunn
On Mon, Mar 12, 2018 at 03:49:51AM -0500, Razvan Stefanescu wrote: > +static irqreturn_t ethsw_irq0_handler(int irq_num, void *arg) > +{ > + return IRQ_WAKE_THREAD; > +} > + > +static int ethsw_setup_irqs(struct fsl_mc_device *sw_dev) > +{ > + struct device *dev = &sw_dev->dev; > + st

Re: [PATCH net v3] net: phy: Tell caller result of phy_change()

2018-03-12 Thread David Miller
From: Brad Mouring Date: Thu, 8 Mar 2018 16:23:03 -0600 > In 664fcf123a30e (net: phy: Threaded interrupts allow some simplification) > the phy_interrupt system was changed to use a traditional threaded > interrupt scheme instead of a workqueue approach. > > With this change, the phy status check

Re: [PATCH v4 2/6] staging: fsl-dpaa2/ethsw: Add Freescale DPAA2 Ethernet Switch driver

2018-03-12 Thread Andrew Lunn
> +static int port_netdevice_event(struct notifier_block *unused, > + unsigned long event, void *ptr) > +{ > + struct net_device *netdev = netdev_notifier_info_to_dev(ptr); > + struct netdev_notifier_changeupper_info *info = ptr; > + struct net_device *upper_

Re: [PATCH] net: hns: use put_device() if device_register fail

2018-03-12 Thread David Miller
From: Arvind Yadav Date: Fri, 9 Mar 2018 16:11:17 +0530 > if device_register() returned an error! Always use put_device() > to give up the reference initialized. > > Signed-off-by: Arvind Yadav I do not see anything giving cls_dev an initial non-zero reference count before this device_registe

chelsio inline tls patches

2018-03-12 Thread David Miller
Atul, starting with patch #5 there are functions which need to be adjusted to order function local variables from longest to shortest line (reverse christmas tree order). Please fix this up for all of those patches and resubmit your series. Thank you.

Re: [PATCH net-next 1/1] tc-testing: updated gact tests with batch test cases

2018-03-12 Thread David Miller
From: Roman Mashak Date: Fri, 9 Mar 2018 17:16:12 -0500 > Add test cases to exercise code paths responsible for adding or deleting > batch of TC actions. > > Signed-off-by: Roman Mashak You submitted this patch twice. You didn't indicate if this is a new version of the patch or something lik

Re: [PATCH net 0/8] bnxt_en: Bug fixes.

2018-03-12 Thread David Miller
From: Michael Chan Date: Fri, 9 Mar 2018 23:46:02 -0500 > There are 3 bug fixes in this series to fix regressions recently > introduced when adding the new ring reservations scheme. 2 minor > fixes in the TC Flower code to return standard errno values and > to elide some unnecessary warning dme

Re: [PATCH V2 net-next] liquidio: fix ndo_change_mtu to always return correct status to the caller

2018-03-12 Thread David Miller
From: Felix Manlunas Date: Sat, 10 Mar 2018 00:17:35 -0800 > From: Veerasenareddy Burru > > In a scenario where the command queued to firmware get dropped or times > out, MTU change from host will not propagate to firmware. So, it is > required for host driver to wait for response from firmware

Re: [PATCHv3 net] sock_diag: request _diag module only when the family or proto has been registered

2018-03-12 Thread David Miller
From: Xin Long Date: Sat, 10 Mar 2018 18:57:50 +0800 > Now when using 'ss' in iproute, kernel would try to load all _diag > modules, which also causes corresponding family and proto modules > to be loaded as well due to module dependencies. > > Like after running 'ss', sctp, dccp, af_packet (if

Re: [PATCH net-next] cxgb4: do not display 50Gbps as unsupported speed

2018-03-12 Thread David Miller
From: Ganesh Goudar Date: Sat, 10 Mar 2018 17:34:50 +0530 > 50Gbps is a supported speed, Stop reporting it as > unsupported speed. > > Signed-off-by: Ganesh Goudar Applied.

Re: [PATCH net-next] cxgb4/cxgb4vf: check fw caps to set link mode mask

2018-03-12 Thread David Miller
From: Ganesh Goudar Date: Sat, 10 Mar 2018 19:27:52 +0530 > check firmware capabilities before setting ethtool > link mode mask, also add few missing speeds. > > Signed-off-by: Ganesh Goudar Applied.

[PATCH] net: drivers/net: Remove unnecessary skb_copy_expand OOM messages

2018-03-12 Thread Joe Perches
skb_copy_expand without __GFP_NOWARN already does a dump_stack on OOM so these messages are redundant. Signed-off-by: Joe Perches --- drivers/net/ethernet/qualcomm/qca_spi.c | 1 - drivers/net/usb/lg-vl600.c | 6 +- drivers/net/wimax/i2400m/usb-rx.c | 3 --- drivers/net/wi

Re: [PATCH net-next 0/3] mlxsw: Removing dependency of mlxsw on GRE

2018-03-12 Thread David Miller
From: Ido Schimmel Date: Sun, 11 Mar 2018 09:44:39 +0200 > Petr says: > > mlxsw_spectrum supports offloading of a tc action mirred egress mirror > to a gretap or ip6gretap netdevice, which necessitates calls to > functions defined in ip_gre, ip6_gre and ip6_tunnel modules. Previously > this was

[PATCH] ipv6: Use ip6_multipath_hash_policy() in rt6_multipath_hash().

2018-03-12 Thread David Miller
Make use of the new helper. Suggested-by: David Ahern Signed-off-by: David S. Miller --- net/ipv6/route.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/ipv6/route.c b/net/ipv6/route.c index f0ae58424c45..81711e3e2604 100644 --- a/net/ipv6/route.c +++ b/net/ipv6/route.

Re: [PATCH][next] lan743x: make functions lan743x_csr_read and lan743x_csr_read static

2018-03-12 Thread David Miller
From: Colin King Date: Sun, 11 Mar 2018 17:55:47 +0100 > From: Colin Ian King > > Functions lan743x_csr_read and lan743x_csr_read are local to the source > and do not need to be in global scope, so make them static. > > Cleans up sparse warning: > drivers/net/ethernet/microchip/lan743x_main.c:

Re: [PATCH][rds-next] rds: remove redundant variable 'sg_off'

2018-03-12 Thread David Miller
From: Colin King Date: Sun, 11 Mar 2018 17:27:56 +0100 > From: Colin Ian King > > Variable sg_off is assigned a value but it is never read, hence it is > redundant and can be removed. > > Cleans up clang warning: > net/rds/message.c:373:2: warning: Value stored to 'sg_off' is never read > > S

Re: [PATCH][next] lan743x: remove some redundant variables and assignments

2018-03-12 Thread David Miller
From: Colin King Date: Sun, 11 Mar 2018 17:42:33 +0100 > From: Colin Ian King > > Function lan743x_phy_init assigns pointer 'netdev' but this is never read > and hence it can be removed. The return error code handling can also be > cleaned up to remove the variable 'ret'. > > Function lan743x_

Re: [PATCH] net: llc: drop VLA in llc_sap_mcast()

2018-03-12 Thread David Miller
From: Salvatore Mesoraca Date: Sun, 11 Mar 2018 22:12:04 +0100 > Avoid a VLA[1] by using a real constant expression instead of a variable. > The compiler should be able to optimize the original code and avoid using > an actual VLA. Anyway this change is useful because it will avoid a false > posi

Re: [PATCH net-next] net: Make RX-FCS and HW GRO mutually exclusive

2018-03-12 Thread David Miller
From: Gal Pressman Date: Mon, 12 Mar 2018 11:48:49 +0200 > Same as LRO, hardware GRO cannot be enabled with RX-FCS. > When both are requested, hardware GRO will be dropped. > > Suggested-by: David Miller > Signed-off-by: Gal Pressman Applied, thank you.

RE: [PATCH v2 iproute2-next 0/6] cm_id, cq, mr, and pd resource tracking

2018-03-12 Thread Steve Wise
Hey all, The kernel side of this series has been merged for rdma-next [1]. Let me know if this iproute2 series can be merged, of if it needs more changes. Thanks, Steve. [1] https://www.spinics.net/lists/linux-rdma/msg61720.html > -Original Message- > From: linux-rdma-ow...@vger.ker

Re: pull-request: can 2018-03-12

2018-03-12 Thread David Miller
From: Marc Kleine-Budde Date: Mon, 12 Mar 2018 11:04:04 +0100 > this is a pull reqeust of 6 patches for net/master. > > The first patch is by Wolfram Sang and fixes a bitshift vs. comparison mistake > in the m_can driver. Two patches of Marek Vasut repair the error handling in > the ifi driver.

Re: [PATCH net-next] sctp: fix error return code in sctp_sendmsg_new_asoc()

2018-03-12 Thread David Miller
From: Wei Yongjun Date: Mon, 12 Mar 2018 12:16:04 + > Return error code -EINVAL in the address len check error handling > case since 'err' can be overwrite to 0 by 'err = sctp_verify_addr()' > in the for loop. > > Fixes: 2c0dbaa0c43d ("sctp: add support for SCTP_DSTADDRV4/6 Information for

Re: [BUGFIX PATCH bpf-next] error-injection: Fix to prohibit jump optimization

2018-03-12 Thread Daniel Borkmann
On 03/12/2018 03:06 PM, Masami Hiramatsu wrote: > On Mon, 12 Mar 2018 11:44:21 +0100 > Daniel Borkmann wrote: >> On 03/12/2018 11:27 AM, Masami Hiramatsu wrote: >>> On Mon, 12 Mar 2018 19:00:49 +0900 >>> Masami Hiramatsu wrote: >>> Since the kprobe which was optimized by jump can not change

Re: [PATCH 3/4 net-next] ibmvnic: Pad small packets to minimum MTU size

2018-03-12 Thread Thomas Falcon
On 03/11/2018 09:56 PM, David Miller wrote: > From: Thomas Falcon > Date: Fri, 9 Mar 2018 13:23:56 -0600 > >> +/* For some backing devices, mishandling of small packets >> + * can result in a loss of connection or TX stall. Device >> + * architects recommend that no packet should be s

Re: [PATCH net-next] sctp: fix error return code in sctp_sendmsg_new_asoc()

2018-03-12 Thread Neil Horman
On Mon, Mar 12, 2018 at 12:16:04PM +, Wei Yongjun wrote: > Return error code -EINVAL in the address len check error handling > case since 'err' can be overwrite to 0 by 'err = sctp_verify_addr()' > in the for loop. > > Fixes: 2c0dbaa0c43d ("sctp: add support for SCTP_DSTADDRV4/6 Information fo

Re: [PATCH net-next] sctp: fix error return code in sctp_sendmsg_new_asoc()

2018-03-12 Thread Marcelo Ricardo Leitner
On Mon, Mar 12, 2018 at 09:38:53PM +0800, Xin Long wrote: > On Mon, Mar 12, 2018 at 8:16 PM, Wei Yongjun wrote: ... > Btw, the 'err' initialization can also be removed in your patch. I second this.

Re: [pci PATCH v4 1/4] pci-iov: Add support for unmanaged SR-IOV

2018-03-12 Thread Alexander Duyck
On Mon, Mar 12, 2018 at 12:59 AM, Christoph Hellwig wrote: > On Sun, Mar 11, 2018 at 09:59:09PM -0600, Alex Williamson wrote: >> I still struggle to understand why we need this "unmanaged" >> complication and how a user of the sysfs API is expected to have any >> idea whether a PF is managed or un

Re: [PATCH net] ipv4: lock mtu in fnhe when received PMTU < net.ipv4.route.min_pmtu

2018-03-12 Thread Sabrina Dubroca
2018-03-09, 16:06:19 -0500, David Miller wrote: > From: Sabrina Dubroca > Date: Fri, 9 Mar 2018 17:43:21 +0100 > > > diff --git a/include/net/ip_fib.h b/include/net/ip_fib.h > > index f80524396c06..77d0a78cf7d2 100644 > > --- a/include/net/ip_fib.h > > +++ b/include/net/ip_fib.h > > @@ -59,6 +59

[PATCH 3/5] netfilter: x_tables: add and use xt_check_proc_name

2018-03-12 Thread Pablo Neira Ayuso
From: Florian Westphal recent and hashlimit both create /proc files, but only check that name is 0 terminated. This can trigger WARN() from procfs when name is "" or "/". Add helper for this and then use it for both. Cc: Eric Dumazet Reported-by: Eric Dumazet Reported-by: Signed-off-by: Flor

[PATCH 5/5] netfilter: nf_tables: release flowtable hooks

2018-03-12 Thread Pablo Neira Ayuso
Otherwise we leak this array. Signed-off-by: Pablo Neira Ayuso --- net/netfilter/nf_tables_api.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/netfilter/nf_tables_api.c b/net/netfilter/nf_tables_api.c index 558593e6a0a3..c4acc7340eb1 100644 --- a/net/netfilter/nf_tables_api.c +++ b/net

[PATCH 4/5] netfilter: bridge: ebt_among: add more missing match size checks

2018-03-12 Thread Pablo Neira Ayuso
From: Florian Westphal ebt_among is special, it has a dynamic match size and is exempt from the central size checks. commit c4585a2823edf ("bridge: ebt_among: add missing match size checks") added validation for pool size, but missed fact that the macros ebt_among_wh_src/dst can already return o

[PATCH 1/5] netfilter: nft_set_hash: skip fixed hash if timeout is specified

2018-03-12 Thread Pablo Neira Ayuso
Fixed hash supports to timeouts, so skip it. Otherwise, userspace hits EOPNOTSUPP. Fixes: 6c03ae210ce3 ("netfilter: nft_set_hash: add non-resizable hashtable implementation") Signed-off-by: Pablo Neira Ayuso --- net/netfilter/nft_set_hash.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH 2/5] netfilter: ebtables: fix erroneous reject of last rule

2018-03-12 Thread Pablo Neira Ayuso
From: Florian Westphal The last rule in the blob has next_entry offset that is same as total size. This made "ebtables32 -A OUTPUT -d de:ad:be:ef:01:02" fail on 64 bit kernel. Fixes: b71812168571fa ("netfilter: ebtables: CONFIG_COMPAT: don't trust userland offsets") Signed-off-by: Florian Westp

[PATCH 0/5] Netfilter fixes for net

2018-03-12 Thread Pablo Neira Ayuso
Hi David, The following patchset contains Netfilter fixes for your net tree, they are: 1) Fixed hashtable representation doesn't support timeout flag, skip it otherwise rules to add elements from the packet fail bogusly fail with EOPNOTSUPP. 2) Fix bogus error with 32-bits ebtables userspa

Re: [PATCH net] ipv4: lock mtu in fnhe when received PMTU < net.ipv4.route.min_pmtu

2018-03-12 Thread David Miller
From: Sabrina Dubroca Date: Mon, 12 Mar 2018 17:05:28 +0100 > 2018-03-09, 16:06:19 -0500, David Miller wrote: >> From: Sabrina Dubroca >> Date: Fri, 9 Mar 2018 17:43:21 +0100 >> >> I think if you just choose an unused RTCF_* bit (f.e. 0x0200) for >> the state, you can use that because valu

Re: [PATCH] net: hns: use put_device() if device_register fail

2018-03-12 Thread arvindY
On Monday 12 March 2018 08:13 PM, David Miller wrote: From: Arvind Yadav Date: Fri, 9 Mar 2018 16:11:17 +0530 if device_register() returned an error! Always use put_device() to give up the reference initialized. Signed-off-by: Arvind Yadav I do not see anything giving cls_dev an initial

Re: [pci PATCH v4 1/4] pci-iov: Add support for unmanaged SR-IOV

2018-03-12 Thread Alex Williamson
On Mon, 12 Mar 2018 09:01:54 -0700 Alexander Duyck wrote: > On Mon, Mar 12, 2018 at 12:59 AM, Christoph Hellwig wrote: > > On Sun, Mar 11, 2018 at 09:59:09PM -0600, Alex Williamson wrote: > >> I still struggle to understand why we need this "unmanaged" > >> complication and how a user of the s

Re: [PATCH net-next 1/1] tc-testing: updated gact tests with batch test cases

2018-03-12 Thread Roman Mashak
David Miller writes: > From: Roman Mashak > Date: Fri, 9 Mar 2018 17:16:12 -0500 > >> Add test cases to exercise code paths responsible for adding or deleting >> batch of TC actions. >> >> Signed-off-by: Roman Mashak > > You submitted this patch twice. > > You didn't indicate if this is a new

[RESEND PATCH net-next 1/1] tc-testing: updated gact tests with batch test cases

2018-03-12 Thread Roman Mashak
Add test cases to exercise code paths responsible for adding or deleting batch of TC actions. Signed-off-by: Roman Mashak --- .../tc-testing/tc-tests/actions/gact.json | 73 +- 1 file changed, 72 insertions(+), 1 deletion(-) diff --git a/tools/testing/selftests/tc-t

Re: [PATCH net-next 1/1] tc-testing: updated gact tests with batch test cases

2018-03-12 Thread David Miller
From: Roman Mashak Date: Mon, 12 Mar 2018 12:39:57 -0400 > David Miller writes: > >> From: Roman Mashak >> Date: Fri, 9 Mar 2018 17:16:12 -0500 >> >>> Add test cases to exercise code paths responsible for adding or deleting >>> batch of TC actions. >>> >>> Signed-off-by: Roman Mashak >> >>

Re: [PATCH] net: llc: drop VLA in llc_sap_mcast()

2018-03-12 Thread Salvatore Mesoraca
2018-03-12 16:14 GMT+01:00 David Miller : > From: Salvatore Mesoraca > Date: Sun, 11 Mar 2018 22:12:04 +0100 > >> Avoid a VLA[1] by using a real constant expression instead of a variable. >> The compiler should be able to optimize the original code and avoid using >> an actual VLA. Anyway this cha

Re: [PATCH 0/5] Netfilter fixes for net

2018-03-12 Thread David Miller
From: Pablo Neira Ayuso Date: Mon, 12 Mar 2018 17:15:59 +0100 > The following patchset contains Netfilter fixes for your net tree, they are: > > 1) Fixed hashtable representation doesn't support timeout flag, skip it >otherwise rules to add elements from the packet fail bogusly fail with >

[PATCH net-next v2 0/4] ibmvnic: Fix VLAN and other device errata

2018-03-12 Thread Thomas Falcon
This patch series contains fixes for VLAN and other backing hardware errata. The VLAN fixes are mostly to account for the additional four bytes VLAN header in TX descriptors and buffers, when applicable. The other fixes for device errata are to pad small packets to avoid a possible connection erro

[PATCH net-next v2 3/4] ibmvnic: Pad small packets to minimum MTU size

2018-03-12 Thread Thomas Falcon
Some backing devices cannot handle small packets well, so pad any small packets to avoid that. It was recommended that the VNIC driver should not send packets smaller than the minimum MTU value provided by firmware, so pad small packets to be at least that long. Signed-off-by: Thomas Falcon --- v

  1   2   3   4   >