Re: [PATCH v3 iproute2-next 1/8] rdma: include rdma-core

2018-03-26 Thread Leon Romanovsky
On Mon, Mar 26, 2018 at 01:57:32PM -0700, Steve Wise wrote: > This avoids requiring rdma-core be installed on systems. > > Signed-off-by: Steve Wise > --- > rdma/include/rdma/rdma_cma.h | 728 > +++ > 1 file changed, 728

Re: [PATCH net-next] qed*: Utilize FW 8.33.11.0

2018-03-26 Thread kbuild test robot
Hi Michal, I love your patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Michal-Kalderon/qed-Utilize-FW-8-33-11-0/20180327-070630 reproduce: # apt-get install sparse make ARCH=x86_64 allmodconfig

[RFC PATCH] qed*: qed_cm_init_pf() can be static

2018-03-26 Thread kbuild test robot
Fixes: cda33d25b808 ("qed*: Utilize FW 8.33.11.0") Signed-off-by: Fengguang Wu --- qed_cxt.c |2 +- qed_dcbx.c |2 +- qed_dev.c | 12 ++-- qed_init_fw_funcs.c |2 +- qed_iscsi.c |4 ++-- qed_iwarp.c |

[PATCH net] vhost: correctly remove wait queue during poll failure

2018-03-26 Thread Jason Wang
We tried to remove vq poll from wait queue, but do not check whether or not it was in a list before. This will lead double free. Fixing this by checking poll->wqh to make sure it was in a list. Reported-by: syzbot+c0272972b01b872e6...@syzkaller.appspotmail.com Fixes: 2b8b328b61c79 ("vhost_net:

Re: BUG: corrupted list in remove_wait_queue

2018-03-26 Thread Jason Wang
On 2018年03月24日 20:32, syzbot wrote: syzbot has found reproducer for the following crash on upstream commit 99fec39e7725d091c94d1bb0242e40c8092994f6 (Fri Mar 23 22:34:18 2018 +) Merge tag 'trace-v4.16-rc4' of git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace syzbot

Re: [RFC PATCH V2 0/8] Packed ring for vhost

2018-03-26 Thread Jason Wang
On 2018年03月27日 03:01, Konrad Rzeszutek Wilk wrote: On Mon, Mar 26, 2018 at 11:38:45AM +0800, Jason Wang wrote: Hi all: This RFC implement packed ring layout. The code were tested with pmd implement by Jens at http://dpdk.org/ml/archives/dev/2018-January/089417.html. Minor change was needed

Re: [PATCH v2 iproute2-next 3/6] rdma: Add CM_ID resource tracking information

2018-03-26 Thread Leon Romanovsky
On Mon, Mar 26, 2018 at 04:30:33PM -0600, Jason Gunthorpe wrote: > On Mon, Mar 26, 2018 at 04:34:44PM -0500, Steve Wise wrote: > > > > On 3/26/2018 4:15 PM, Jason Gunthorpe wrote: > > > On Mon, Mar 26, 2018 at 09:30:41AM -0500, Steve Wise wrote: > > >> > > >> On 3/26/2018 9:17 AM, David Ahern

Re: [PATCH bpf-next] bpf: sockmap: initialize sg table entries properly

2018-03-26 Thread John Fastabend
On 03/25/2018 11:54 PM, Prashant Bhole wrote: > When CONFIG_DEBUG_SG is set, sg->sg_magic is initialized to SG_MAGIC, > when sg table is initialized using sg_init_table(). Magic is checked > while navigating the scatterlist. We hit BUG_ON when magic check is > failed. > > Fixed following things:

Re: [PATCH 4/4] selftests/bpf: fix compiling errors

2018-03-26 Thread Du, Changbin
On Mon, Mar 26, 2018 at 08:02:30PM -0700, Alexei Starovoitov wrote: > On Tue, Mar 27, 2018 at 10:20:10AM +0800, Du, Changbin wrote: > > On Mon, Mar 26, 2018 at 07:55:13AM -0700, Alexei Starovoitov wrote: > > > On Mon, Mar 26, 2018 at 05:23:28PM +0800, changbin...@intel.com wrote: > > > >

Re: [PATCH 4/4] selftests/bpf: fix compiling errors

2018-03-26 Thread Alexei Starovoitov
On Tue, Mar 27, 2018 at 10:20:10AM +0800, Du, Changbin wrote: > On Mon, Mar 26, 2018 at 07:55:13AM -0700, Alexei Starovoitov wrote: > > On Mon, Mar 26, 2018 at 05:23:28PM +0800, changbin...@intel.com wrote: > > > Signed-off-by: Changbin Du > > > --- > > >

[PATCH v6 bpf-next 00/11] bpf, tracing: introduce bpf raw tracepoints

2018-03-26 Thread Alexei Starovoitov
From: Alexei Starovoitov v5->v6: - avoid changing semantics of for_each_kernel_tracepoint() function, instead introduce kernel_tracepoint_find_by_name() helper v4->v5: - adopted Daniel's fancy REPEAT macro in bpf_trace.c in patch 8 v3->v4: - adopted Linus's CAST_TO_U64

[PATCH v6 bpf-next 06/11] tracepoint: compute num_args at build time

2018-03-26 Thread Alexei Starovoitov
From: Alexei Starovoitov compute number of arguments passed into tracepoint at compile time and store it as part of 'struct tracepoint'. The number is necessary to check safety of bpf program access that is coming in subsequent patch. Signed-off-by: Alexei Starovoitov

[PATCH v6 bpf-next 05/11] macro: introduce COUNT_ARGS() macro

2018-03-26 Thread Alexei Starovoitov
From: Alexei Starovoitov move COUNT_ARGS() macro from apparmor to generic header and extend it to count till twelve. COUNT() was an alternative name for this logic, but it's used for different purpose in many other places. Similarly for CONCATENATE() macro. Suggested-by:

[PATCH v6 bpf-next 10/11] samples/bpf: raw tracepoint test

2018-03-26 Thread Alexei Starovoitov
From: Alexei Starovoitov add empty raw_tracepoint bpf program to test overhead similar to kprobe and traditional tracepoint tests Signed-off-by: Alexei Starovoitov --- samples/bpf/Makefile| 1 + samples/bpf/bpf_load.c |

[PATCH v6 bpf-next 09/11] libbpf: add bpf_raw_tracepoint_open helper

2018-03-26 Thread Alexei Starovoitov
From: Alexei Starovoitov add bpf_raw_tracepoint_open(const char *name, int prog_fd) api to libbpf Signed-off-by: Alexei Starovoitov --- tools/include/uapi/linux/bpf.h | 11 +++ tools/lib/bpf/bpf.c| 11 +++ tools/lib/bpf/bpf.h

[PATCH v6 bpf-next 08/11] bpf: introduce BPF_RAW_TRACEPOINT

2018-03-26 Thread Alexei Starovoitov
From: Alexei Starovoitov Introduce BPF_PROG_TYPE_RAW_TRACEPOINT bpf program type to access kernel internal arguments of the tracepoints in their raw form. >From bpf program point of view the access to the arguments look like: struct bpf_raw_tracepoint_args { __u64

[PATCH v6 bpf-next 02/11] net/mediatek: disambiguate mt76 vs mt7601u trace events

2018-03-26 Thread Alexei Starovoitov
From: Alexei Starovoitov two trace events defined with the same name and both unused. They conflict in allyesconfig build. Rename one of them. Signed-off-by: Alexei Starovoitov --- drivers/net/wireless/mediatek/mt7601u/trace.h | 6 +++--- 1 file changed, 3

[PATCH v6 bpf-next 07/11] tracepoint: introduce kernel_tracepoint_find_by_name

2018-03-26 Thread Alexei Starovoitov
From: Alexei Starovoitov introduce kernel_tracepoint_find_by_name() helper to let bpf core find tracepoint by name and later attach bpf probe to a tracepoint Signed-off-by: Alexei Starovoitov --- include/linux/tracepoint.h | 6 ++ kernel/tracepoint.c

[PATCH v6 bpf-next 03/11] net/mac802154: disambiguate mac80215 vs mac802154 trace events

2018-03-26 Thread Alexei Starovoitov
From: Alexei Starovoitov two trace events defined with the same name and both unused. They conflict in allyesconfig build. Rename one of them. Signed-off-by: Alexei Starovoitov --- net/mac802154/trace.h | 8 1 file changed, 4 insertions(+), 4

[PATCH v6 bpf-next 01/11] treewide: remove large struct-pass-by-value from tracepoint arguments

2018-03-26 Thread Alexei Starovoitov
From: Alexei Starovoitov - fix trace_hfi1_ctxt_info() to pass large struct by reference instead of by value - convert 'type array[]' tracepoint arguments into 'type *array', since compiler will warn that sizeof('type array[]') == sizeof('type *array') and later should be

[PATCH v6 bpf-next 11/11] selftests/bpf: test for bpf_get_stackid() from raw tracepoints

2018-03-26 Thread Alexei Starovoitov
From: Alexei Starovoitov similar to traditional traceopint test add bpf_get_stackid() test from raw tracepoints and reduce verbosity of existing stackmap test Signed-off-by: Alexei Starovoitov --- tools/testing/selftests/bpf/test_progs.c | 91

[PATCH v6 bpf-next 04/11] net/wireless/iwlwifi: fix iwlwifi_dev_ucode_error tracepoint

2018-03-26 Thread Alexei Starovoitov
From: Alexei Starovoitov fix iwlwifi_dev_ucode_error tracepoint to pass pointer to a table instead of all 17 arguments by value. dvm/main.c and mvm/utils.c have 'struct iwl_error_event_table' defined with very similar yet subtly different fields and offsets. tracepoint is still

Re: [PATCH 4/4] selftests/bpf: fix compiling errors

2018-03-26 Thread Du, Changbin
Hi Starovoitov, This one does have the issue you mentioned. [PATCH 2/4] selftests/gpio: fix paths in Makefile And can be fixed by: --- a/tools/testing/selftests/gpio/Makefile +++ b/tools/testing/selftests/gpio/Makefile @@ -1,5 +1,6 @@ # SPDX-License-Identifier: GPL-2.0 +OUTPUT ?= $(shell pwd)

Re: [PATCH 4/4] selftests/bpf: fix compiling errors

2018-03-26 Thread Du, Changbin
On Mon, Mar 26, 2018 at 07:55:13AM -0700, Alexei Starovoitov wrote: > On Mon, Mar 26, 2018 at 05:23:28PM +0800, changbin...@intel.com wrote: > > Signed-off-by: Changbin Du > > --- > > tools/testing/selftests/bpf/Makefile | 5 +++-- > > 1 file changed, 3 insertions(+), 2

Re: [PATCH bpf-next] bpf, tracing: unbreak lttng

2018-03-26 Thread Alexei Starovoitov
On 3/26/18 5:08 PM, Steven Rostedt wrote: On Mon, 26 Mar 2018 15:35:56 -0700 Alexei Starovoitov wrote: This patch is not reverting to the old code properly. It introduces a static inline void function that returns NULL. Please compile-test with CONFIG_TRACEPOINTS=n before

Re: [PATCH v3 net 1/5] tcp: feed correct number of pkts acked to cc modules also in recovery

2018-03-26 Thread Yuchung Cheng
On Tue, Mar 13, 2018 at 3:25 AM, Ilpo Järvinen wrote: > > A miscalculation for the number of acknowledged packets occurs during > RTO recovery whenever SACK is not enabled and a cumulative ACK covers > any non-retransmitted skbs. The reason is that pkts_acked value >

[PATCH 0/6] rhashtable: assorted fixes and enhancements

2018-03-26 Thread NeilBrown
Hi, I'm hoping to use rhashtable in lustre, to replace the resizeable hashtable implementation in libcfs. While working through the conversion I found some minor bugs in the rhashtable code and documentation, and some areas where enhancements could make rhashtable a better fit for lustre.

[PATCH 1/6] rhashtable: improve documentation for rhashtable_walk_peek()

2018-03-26 Thread NeilBrown
The documentation for rhashtable_walk_peek() wrong. It claims to return the *next* entry, whereas it in fact returns the *previous* entry. However if no entries have yet been returned - or if the iterator was reset due to a resize event, then rhashtable_walk_peek() *does* return the next entry,

[PATCH 4/6] rhashtable: allow a walk of the hash table without missing objects.

2018-03-26 Thread NeilBrown
When a walk of the hashtable can be done entirely under RCU, no objects will be missed - though seeing duplicates is possible. This is because a cursor is kept in iter->p. Without the cursor we depend on the ->skip counter. If an object before the current location in hash chain is removed, the

[PATCH 3/6] rhashtable: reset intr when rhashtable_walk_start sees new table

2018-03-26 Thread NeilBrown
The documentation claims that when rhashtable_walk_start_check() detects a resize event, it will rewind back to the beginning of the table. This is not true. We need to set ->slot and ->skip to be zero for it to be true. Signed-off-by: NeilBrown --- lib/rhashtable.c |2 ++

[PATCH 5/6] rhashtable: support guaranteed successful insertion.

2018-03-26 Thread NeilBrown
The current rhashtable will fail an insertion if the hashtable it "too full", one of: - table already has 2^31 elements (-E2BIG) - a max_size was specified and table already has that many elements (rounded up to power of 2) (-E2BIG) - a single chain has more than 16 elements (-EBUSY) -

[PATCH 2/6] rhashtable: remove outdated comments about grow_decision etc

2018-03-26 Thread NeilBrown
grow_decision and shink_decision no longer exist, so remove the remaining references to them. Signed-off-by: NeilBrown --- include/linux/rhashtable.h | 33 ++--- 1 file changed, 14 insertions(+), 19 deletions(-) diff --git

[PATCH 6/6] rhashtable: allow element counting to be disabled.

2018-03-26 Thread NeilBrown
If multiple CPUs are performing concurrent updates, they can contend on accessing the element counter even when they don't often content on hash chains or spin locks. This can hurt performance. The nelems counter is only used to trigger a resize at the 70% and 30% marks, so it does not need to

RE: [Intel-wired-lan] [next-queue PATCH v5 7/9] igb: Add MAC address support for ethtool nftuple filters

2018-03-26 Thread Brown, Aaron F
> From: Gomes, Vinicius > Sent: Monday, March 26, 2018 4:56 PM > To: Brown, Aaron F ; intel-wired- > l...@lists.osuosl.org > Cc: netdev@vger.kernel.org; Sanchez-Palencia, Jesus palen...@intel.com> > Subject: RE: [Intel-wired-lan] [next-queue PATCH v5 7/9] igb: Add MAC >

ip6_forward / NF_HOOK and counters

2018-03-26 Thread Jeff Barnhill
At the end of ip6_forward(), is there a good reason why IPSTATS_MIB_OUTFORWDATAGRAMS and IPSTATS_MIB_OUTOCTETS are incremented before the NF_HOOK? If the hook steals or drops the packet, this counts still go up, which seems incorrect. v4/ip_forward() increments these counters in

Re: [PATCH net-next] XDP router for veth

2018-03-26 Thread Md. Islam
On Mon, Mar 26, 2018 at 9:01 PM, Md. Islam wrote: > On Mon, Mar 26, 2018 at 10:21 AM, David Miller wrote: >> From: "Md. Islam" >> Date: Fri, 23 Mar 2018 02:43:16 -0400 >> >>> +#ifdef CONFIG_XDP_ROUTER >>> +//if IP forwarding is

Re: [PATCH net-next] XDP router for veth

2018-03-26 Thread Md. Islam
On Mon, Mar 26, 2018 at 10:21 AM, David Miller wrote: > From: "Md. Islam" > Date: Fri, 23 Mar 2018 02:43:16 -0400 > >> +#ifdef CONFIG_XDP_ROUTER >> +//if IP forwarding is enabled on the receiver, create xdp_buff >> +//from skb and call

Re: [PATCH net-next 4/8] dt-bindings: net: add DT bindings for Microsemi Ocelot Switch

2018-03-26 Thread Rob Herring
On Mon, Mar 26, 2018 at 5:50 PM, Andrew Lunn wrote: >> ports and port collide with the OF graph binding. It would be good if >> this moved to ethernet-port(s) or similar. > > Hi Rob > > Well, we have been using port in DSA since March 2013. ports is a bit > newer, June 2016. Yes,

Re: [PATCH bpf-next] bpf, tracing: unbreak lttng

2018-03-26 Thread Steven Rostedt
On Mon, 26 Mar 2018 15:35:56 -0700 Alexei Starovoitov wrote: > > This patch is not reverting to the old code properly. It introduces a > > static inline void function that returns NULL. Please compile-test > > with CONFIG_TRACEPOINTS=n before submitting a patch involving

Re: [PATCH v2 bpf-next] bpf, tracing: unbreak lttng

2018-03-26 Thread Steven Rostedt
On Mon, 26 Mar 2018 16:02:20 -0700 Alexei Starovoitov wrote: > for_each_kernel_tracepoint() is used by out-of-tree lttng module > and therefore cannot be changed. This is false and misleading. NACK. -- Steve > Instead introduce kernel_tracepoint_find_by_name() to find >

Re: [PATCH bpf-next] bpf, tracing: unbreak lttng

2018-03-26 Thread Steven Rostedt
On Mon, 26 Mar 2018 15:25:32 -0700 Alexei Starovoitov wrote: > On 3/26/18 3:15 PM, Steven Rostedt wrote: > > On Mon, 26 Mar 2018 15:08:45 -0700 > > Alexei Starovoitov wrote: > > > >> for_each_kernel_tracepoint() is used by out-of-tree lttng module > >> and

Re: bpf stable request

2018-03-26 Thread Daniel Borkmann
On 03/27/2018 01:52 AM, Chenbo Feng wrote: > 0fa4fe85f4724fff89b09741c437cbee9cf8b008 bpf: skip unnecessary capability > check > > This patch fixes the false alarms from security system such as selinux when > doing the capability check. The problem exists since the >

RE: [Intel-wired-lan] [next-queue PATCH v5 7/9] igb: Add MAC address support for ethtool nftuple filters

2018-03-26 Thread Vinicius Costa Gomes
Hi Aaron, "Brown, Aaron F" writes: > > Maybe not "this" patch, but this is the one that enables the ethtool > commands, so replying here. > The filters do not seem to take effect with this version (v5) of the > series. The commands are accepted for i210 and rejected

bpf stable request

2018-03-26 Thread Chenbo Feng
0fa4fe85f4724fff89b09741c437cbee9cf8b008 bpf: skip unnecessary capability check This patch fixes the false alarms from security system such as selinux when doing the capability check. The problem exists since the sysctl_unprivileged_bpf_disabled is added in linux 4.4. So I suggest to

Re: [PATCH net-next 0/2] net: broadcom: Adaptive interrupt coalescing

2018-03-26 Thread Florian Fainelli
On 03/26/2018 04:21 PM, Tal Gilboa wrote: > On 3/27/2018 1:29 AM, Florian Fainelli wrote: >> On 03/26/2018 03:04 PM, Florian Fainelli wrote: >>> On 03/26/2018 02:16 PM, Tal Gilboa wrote: On 3/23/2018 4:19 AM, Florian Fainelli wrote: > Hi all, > > This patch series adds adaptive

Re: [PATCH net-next V2] Documentation/networking: Add net DIM documentation

2018-03-26 Thread Tal Gilboa
On 3/22/2018 8:51 PM, David Miller wrote: From: Tal Gilboa Date: Wed, 21 Mar 2018 20:33:45 +0200 Net DIM is a generic algorithm, purposed for dynamically optimizing network devices interrupt moderation. This document describes how it works and how to use it.

Re: [PATCH net-next 0/2] net: broadcom: Adaptive interrupt coalescing

2018-03-26 Thread Tal Gilboa
On 3/27/2018 1:29 AM, Florian Fainelli wrote: On 03/26/2018 03:04 PM, Florian Fainelli wrote: On 03/26/2018 02:16 PM, Tal Gilboa wrote: On 3/23/2018 4:19 AM, Florian Fainelli wrote: Hi all, This patch series adds adaptive interrupt coalescing for the Gigabit Ethernet drivers SYSTEMPORT and

Re: [RFC PATCH 00/24] Introducing AF_XDP support

2018-03-26 Thread Tushar Dave
On 03/26/2018 04:03 PM, Alexander Duyck wrote: On Mon, Mar 26, 2018 at 3:54 PM, Tushar Dave wrote: On 03/26/2018 09:38 AM, Jesper Dangaard Brouer wrote: On Mon, 26 Mar 2018 09:06:54 -0700 William Tu wrote: On Wed, Jan 31, 2018 at 5:53 AM,

Re: [PATCH net-next 1/2] net: systemport: Implement adaptive interrupt coalescing

2018-03-26 Thread Tal Gilboa
On 3/27/2018 12:36 AM, Florian Fainelli wrote: On 03/26/2018 02:22 PM, Tal Gilboa wrote: On 3/23/2018 4:19 AM, Florian Fainelli wrote: Implement support for adaptive RX and TX interrupt coalescing using net_dim. We have each of our TX ring and our single RX ring implement a bcm_sysport_net_dim

Re: [RFC PATCH 00/24] Introducing AF_XDP support

2018-03-26 Thread Alexander Duyck
On Mon, Mar 26, 2018 at 3:54 PM, Tushar Dave wrote: > > > On 03/26/2018 09:38 AM, Jesper Dangaard Brouer wrote: >> >> >> On Mon, 26 Mar 2018 09:06:54 -0700 William Tu wrote: >> >>> On Wed, Jan 31, 2018 at 5:53 AM, Björn Töpel

[PATCH v2 bpf-next] bpf, tracing: unbreak lttng

2018-03-26 Thread Alexei Starovoitov
for_each_kernel_tracepoint() is used by out-of-tree lttng module and therefore cannot be changed. Instead introduce kernel_tracepoint_find_by_name() to find tracepoint by name. Fixes: 9e9afbae6514 ("tracepoint: compute num_args at build time") Signed-off-by: Alexei Starovoitov

Re: Bug#892057: Fwd: Re: TS-x09 fails to boot when obtaining MAC

2018-03-26 Thread Andrew Lunn
On Tue, Mar 27, 2018 at 12:50:04AM +0200, Martin Michlmayr wrote: > The fix is in Linus' tree since v.16-rc5: > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=13a55372b64e00e564a08d785ca87bd9d454ba30 > > I don't see it in 4.9 stable or the stable queue. Will Greg

Re: [net-next 00/15][pull request] 100GbE Intel Wired LAN Driver Updates 2018-03-26

2018-03-26 Thread David Miller
From: Jeff Kirsher Date: Mon, 26 Mar 2018 12:46:04 -0700 > This patch series adds the ice driver, which will support the Intel(R) > E800 Series of network devices. Pulled, thanks Jeff.

Re: [RFC PATCH 00/24] Introducing AF_XDP support

2018-03-26 Thread Tushar Dave
On 03/26/2018 09:38 AM, Jesper Dangaard Brouer wrote: On Mon, 26 Mar 2018 09:06:54 -0700 William Tu wrote: On Wed, Jan 31, 2018 at 5:53 AM, Björn Töpel wrote: From: Björn Töpel This RFC introduces a new address family

Re: [PATCH net-next 4/8] dt-bindings: net: add DT bindings for Microsemi Ocelot Switch

2018-03-26 Thread Andrew Lunn
> ports and port collide with the OF graph binding. It would be good if > this moved to ethernet-port(s) or similar. Hi Rob Well, we have been using port in DSA since March 2013. ports is a bit newer, June 2016. Changing DSA is not going to happen. But new switch bindings could use

Re: [RFC PATCH v2] net: phy: Added device tree binding for dev-addr and dev-addr code check-up

2018-03-26 Thread Florian Fainelli
On 03/23/2018 08:05 AM, Vicentiu Galanopulo wrote: > Reason for this patch is that the Inphi PHY has a > vendor specific address space for accessing the > C45 MDIO registers - starting from 0x1e. > > A search of the dev-addr property is done in of_mdiobus_register. > If the property is found in

Re: [PATCH net] r8169: fix setting driver_data after register_netdev

2018-03-26 Thread Andrew Lunn
On Tue, Mar 27, 2018 at 12:18:40AM +0200, Francois Romieu wrote: > Andrew Lunn : > [...] > > How about rtl8169_get_wol() and rtl8169_set_wol(). And > > rtl8169_get_ethtool_stats(). > > rtl8169_get_wol does not depend on dev->driver_data. Neither does > rtl8169_set_wol() nor

Re: [PATCH bpf-next] bpf, tracing: unbreak lttng

2018-03-26 Thread Mathieu Desnoyers
- On Mar 26, 2018, at 6:25 PM, Alexei Starovoitov a...@fb.com wrote: > On 3/26/18 3:15 PM, Steven Rostedt wrote: >> On Mon, 26 Mar 2018 15:08:45 -0700 >> Alexei Starovoitov wrote: >> >>> for_each_kernel_tracepoint() is used by out-of-tree lttng module >>> and therefore

Re: [PATCH bpf-next] bpf, tracing: unbreak lttng

2018-03-26 Thread Alexei Starovoitov
On 3/26/18 3:30 PM, Mathieu Desnoyers wrote: - On Mar 26, 2018, at 6:08 PM, Alexei Starovoitov a...@kernel.org wrote: [...] #ifdef CONFIG_TRACEPOINTS -void * -for_each_kernel_tracepoint(void *(*fct)(struct tracepoint *tp, void *priv), +void +for_each_kernel_tracepoint(void (*fct)(struct

Re: [PATCH v2 iproute2-next 3/6] rdma: Add CM_ID resource tracking information

2018-03-26 Thread Jason Gunthorpe
On Mon, Mar 26, 2018 at 04:34:44PM -0500, Steve Wise wrote: > > On 3/26/2018 4:15 PM, Jason Gunthorpe wrote: > > On Mon, Mar 26, 2018 at 09:30:41AM -0500, Steve Wise wrote: > >> > >> On 3/26/2018 9:17 AM, David Ahern wrote: > >>> On 2/27/18 9:07 AM, Steve Wise wrote: > diff --git

Re: [PATCH bpf-next] bpf, tracing: unbreak lttng

2018-03-26 Thread Mathieu Desnoyers
- On Mar 26, 2018, at 6:08 PM, Alexei Starovoitov a...@kernel.org wrote: [...] > > #ifdef CONFIG_TRACEPOINTS > -void * > -for_each_kernel_tracepoint(void *(*fct)(struct tracepoint *tp, void *priv), > +void > +for_each_kernel_tracepoint(void (*fct)(struct tracepoint *tp, void *priv), >

Re: [PATCH net-next 0/2] net: broadcom: Adaptive interrupt coalescing

2018-03-26 Thread Florian Fainelli
On 03/26/2018 03:04 PM, Florian Fainelli wrote: > On 03/26/2018 02:16 PM, Tal Gilboa wrote: >> On 3/23/2018 4:19 AM, Florian Fainelli wrote: >>> Hi all, >>> >>> This patch series adds adaptive interrupt coalescing for the Gigabit >>> Ethernet >>> drivers SYSTEMPORT and GENET. >>> >>> This really

Re: [PATCH bpf-next] bpf, tracing: unbreak lttng

2018-03-26 Thread Alexei Starovoitov
On 3/26/18 3:15 PM, Steven Rostedt wrote: On Mon, 26 Mar 2018 15:08:45 -0700 Alexei Starovoitov wrote: for_each_kernel_tracepoint() is used by out-of-tree lttng module and therefore cannot be changed. Instead introduce kernel_tracepoint_find_by_name() to find tracepoint by

Re: [RFC PATCH v2] net: phy: Added device tree binding for dev-addr and dev-addr code check-up

2018-03-26 Thread Rob Herring
On Fri, Mar 23, 2018 at 10:05:22AM -0500, Vicentiu Galanopulo wrote: > Reason for this patch is that the Inphi PHY has a > vendor specific address space for accessing the > C45 MDIO registers - starting from 0x1e. > > A search of the dev-addr property is done in of_mdiobus_register. > If the

Re: [PATCH net-next 4/8] dt-bindings: net: add DT bindings for Microsemi Ocelot Switch

2018-03-26 Thread Rob Herring
On Fri, Mar 23, 2018 at 09:11:13PM +0100, Alexandre Belloni wrote: > DT bindings for the Ethernet switch found on Microsemi Ocelot platforms. > > Cc: Rob Herring > Signed-off-by: Alexandre Belloni > --- >

Re: [PATCH net-next 4/8] dt-bindings: net: add DT bindings for Microsemi Ocelot Switch

2018-03-26 Thread Rob Herring
On Fri, Mar 23, 2018 at 02:11:35PM -0700, Florian Fainelli wrote: > On 03/23/2018 01:11 PM, Alexandre Belloni wrote: > > DT bindings for the Ethernet switch found on Microsemi Ocelot platforms. > > > > Cc: Rob Herring > > Signed-off-by: Alexandre Belloni

Re: [PATCH net] r8169: fix setting driver_data after register_netdev

2018-03-26 Thread Francois Romieu
Andrew Lunn : [...] > How about rtl8169_get_wol() and rtl8169_set_wol(). And > rtl8169_get_ethtool_stats(). rtl8169_get_wol does not depend on dev->driver_data. Neither does rtl8169_set_wol() nor rtl8169_get_ethtool_stats(). > Basically anything which makes use of run time power

Re: [PATCH net-next 04/12] dt-bindings: net: dwmac-sun8i: Sort syscon compatibles by alphabetical order

2018-03-26 Thread Rob Herring
On Sat, Mar 17, 2018 at 05:28:49PM +0800, Chen-Yu Tsai wrote: > The A83T syscon compatible was appended to the syscon compatibles list, > instead of inserted in to preserve the ordering. > > Move it to the proper place to keep the list sorted. > > Signed-off-by: Chen-Yu Tsai >

Re: [PATCH bpf-next] bpf, tracing: unbreak lttng

2018-03-26 Thread Steven Rostedt
On Mon, 26 Mar 2018 15:08:45 -0700 Alexei Starovoitov wrote: > for_each_kernel_tracepoint() is used by out-of-tree lttng module > and therefore cannot be changed. > Instead introduce kernel_tracepoint_find_by_name() to find > tracepoint by name. > > Fixes: 9e9afbae6514

[Patch net] llc: properly handle dev_queue_xmit() return value

2018-03-26 Thread Cong Wang
llc_conn_send_pdu() pushes the skb into write queue and calls llc_conn_send_pdus() to flush them out. However, the status of dev_queue_xmit() is not returned to caller, in this case, llc_conn_state_process(). llc_conn_state_process() needs hold the skb no matter success or failure, because it

[PATCH bpf-next] bpf, tracing: unbreak lttng

2018-03-26 Thread Alexei Starovoitov
for_each_kernel_tracepoint() is used by out-of-tree lttng module and therefore cannot be changed. Instead introduce kernel_tracepoint_find_by_name() to find tracepoint by name. Fixes: 9e9afbae6514 ("tracepoint: compute num_args at build time") Signed-off-by: Alexei Starovoitov

Re: [PATCH net-next 0/2] net: broadcom: Adaptive interrupt coalescing

2018-03-26 Thread Florian Fainelli
On 03/26/2018 02:16 PM, Tal Gilboa wrote: > On 3/23/2018 4:19 AM, Florian Fainelli wrote: >> Hi all, >> >> This patch series adds adaptive interrupt coalescing for the Gigabit >> Ethernet >> drivers SYSTEMPORT and GENET. >> >> This really helps lower the interrupt count and system load, as >>

Re: [RFC PATCH 00/24] Introducing AF_XDP support

2018-03-26 Thread William Tu
Hi Jesper, Thanks a lot for your prompt reply. >> Hi, >> I also did an evaluation of AF_XDP, however the performance isn't as >> good as above. >> I'd like to share the result and see if there are some tuning suggestions. >> >> System: >> 16 core, Intel(R) Xeon(R) CPU E5-2440 v2 @ 1.90GHz >>

[net-next 06/10] i40e: hold the RTNL lock while changing interrupt schemes

2018-03-26 Thread Jeff Kirsher
From: Jacob Keller When we suspend and resume, we need to clear and re-enable the interrupt scheme. This was previously not done while holding the RTNL lock, which could be problematic, because we are actually destroying and re-creating queues. Hold the RTNL lock for

[net-next 05/10] i40e: move client flags into state bits

2018-03-26 Thread Jeff Kirsher
From: Jacob Keller The iWarp client flags are all potentially changed when the RTNL lock is not held, so they should not be part of the pf->flags variable. Instead, move them into the state field so that we can use atomic bit operations. This is part of a larger effort

[net-next 08/10] i40e: re-number feature flags to remove gaps

2018-03-26 Thread Jeff Kirsher
From: Jacob Keller Remove the gaps created by the recent refactor of various feature flags that have moved to the state field. Use only a u32 now that we have fewer than 32 flags in the field. Signed-off-by: Jacob Keller Tested-by: Andrew

[net-next 09/10] i40e: tweak page counting for XDP_REDIRECT

2018-03-26 Thread Jeff Kirsher
From: Björn Töpel This commit tweaks the page counting for XDP_REDIRECT to function properly. XDP_REDIRECT support will be added in a future commit. The current page counting scheme assumes that the reference count cannot decrease until the received frame is sent to the

[net-next 10/10] i40e: add support for XDP_REDIRECT

2018-03-26 Thread Jeff Kirsher
From: Björn Töpel The driver now acts upon the XDP_REDIRECT return action. Two new ndos are implemented, ndo_xdp_xmit and ndo_xdp_flush. XDP_REDIRECT action enables XDP program to redirect frames to other netdevs. Signed-off-by: Björn Töpel

[net-next 04/10] i40e: move I40E_FLAG_TEMP_LINK_POLLING to state field

2018-03-26 Thread Jeff Kirsher
From: Jacob Keller This flag is modified outside of the RTNL lock and thus should not be part of the pf->flags variable. Use a state bit instead, so that we can use atomic bit operations. This is part of a larger effort to remove cmpxchg64 in i40e_set_priv_flags()

[net-next 07/10] i40e: stop using cmpxchg flow in i40e_set_priv_flags()

2018-03-26 Thread Jeff Kirsher
From: Jacob Keller Now that the only places which modify flags are either (a) during initialization prior to creating a netdevice, or (b) while holding the rtnl lock, we no longer need the cmpxchg64 call in i40e_set_priv_flags. Signed-off-by: Jacob Keller

[net-next 00/10][pull request] 40GbE Intel Wired LAN Driver Updates 2018-03-26

2018-03-26 Thread Jeff Kirsher
This series contains updates to i40e only. Jake provides several patches which remove the need for cmpxchg64(), starting with moving I40E_FLAG_[UDP]_FILTER_SYNC from pf->flags to pf->state since they are modified during run time possibly when the RTNL lock is not held so they should be a state

[net-next 02/10] i40e: move I40E_FLAG_UDP_FILTER_SYNC to the state field

2018-03-26 Thread Jeff Kirsher
From: Jacob Keller This flag is modified during run time, possibly even when the RTNL lock is not held. Additionally it has a few places which should be using test_and_set or test_and_clear atomic bit operations. Create a new state bit __I40E_UDP_SYNC_PENDING and use

[net-next 03/10] i40e: move AUTO_DISABLED flags into the state field

2018-03-26 Thread Jeff Kirsher
From: Jacob Keller The two Flow Directory auto disable flags are used at run time to mark when the flow director features needed to be disabled. Thus the flags could change even when the RTNL lock is not held. They also have some code constructions which really should

[net-next 01/10] i40e: move I40E_FLAG_FILTER_SYNC to a state bit

2018-03-26 Thread Jeff Kirsher
From: Jacob Keller The I40E_FLAG_FILTER_SYNC flag is modified during run time possibly when the RTNL lock is not held. Thus, it should not be part of pf->flags, and instead should be using atomic bit operations in the pf->state field. Create a

Re: [PATCH net-next 1/2] net: systemport: Implement adaptive interrupt coalescing

2018-03-26 Thread Florian Fainelli
On 03/26/2018 02:22 PM, Tal Gilboa wrote: > On 3/23/2018 4:19 AM, Florian Fainelli wrote: >> Implement support for adaptive RX and TX interrupt coalescing using >> net_dim. We have each of our TX ring and our single RX ring implement a >> bcm_sysport_net_dim structure which holds an interrupt

Re: [PATCH v2 iproute2-next 3/6] rdma: Add CM_ID resource tracking information

2018-03-26 Thread Steve Wise
On 3/26/2018 4:15 PM, Jason Gunthorpe wrote: > On Mon, Mar 26, 2018 at 09:30:41AM -0500, Steve Wise wrote: >> >> On 3/26/2018 9:17 AM, David Ahern wrote: >>> On 2/27/18 9:07 AM, Steve Wise wrote: diff --git a/rdma/rdma.h b/rdma/rdma.h index 5809f70..e55205b 100644 +++ b/rdma/rdma.h

Re: [PATCH v5 bpf-next 06/10] tracepoint: compute num_args at build time

2018-03-26 Thread Mathieu Desnoyers
- On Mar 26, 2018, at 1:55 PM, Alexei Starovoitov a...@fb.com wrote: [...] > > correct. this set deals with in-kernel tracepoints only. > No attempt to do anything with tracepoints inside modules. Please endeavor to handle in-module tracepoints properly, then we'll be able to pursue a more

Re: [PATCH net-next 2/2] net: bcmgenet: Add support for adaptive RX coalescing

2018-03-26 Thread Tal Gilboa
On 3/23/2018 4:19 AM, Florian Fainelli wrote: Unlike the moder modern SYSTEMPORT hardware, we do not have a configurable TDMA timeout, which limits us to implement adaptive RX interrupt coalescing only. We have each of our RX rings implement a bcmgenet_net_dim structure which holds an interrupt

[PATCH 5/6] net/ipv4: Update ip_tunnel_metadata_cnt static key to modern api

2018-03-26 Thread Davidlohr Bueso
No changes in refcount semantics -- key init is false; replace static_key_slow_inc|dec with static_branch_inc|dec static_key_false with static_branch_unlikely Added a '_key' suffix to i2c_trace_msg, for better self documentation. Cc: David S. Miller Cc:

[PATCH v3 iproute2-next 5/8] rdma: Add CM_ID resource tracking information

2018-03-26 Thread Steve Wise
Sample output: # rdma resource 2: cxgb4_0: pd 5 cq 2 qp 2 cm_id 3 mr 7 3: mlx4_0: pd 7 cq 3 qp 3 cm_id 3 mr 7 # rdma resource show cm_id link cxgb4_0/- lqpn 0 qp-type RC state LISTEN ps TCP pid 30485 comm rping src-addr 0.0.0.0:7174 link cxgb4_0/2 lqpn 1048 qp-type RC state CONNECT ps TCP pid

[PATCH 6/6] net/sock: Update memalloc_socks static key to modern api

2018-03-26 Thread Davidlohr Bueso
No changes in refcount semantics -- key init is false; replace static_key_slow_inc|dec with static_branch_inc|dec static_key_false with static_branch_unlikely Added a '_key' suffix to memalloc_socks, for better self documentation. Cc: David S. Miller Cc:

Re: [PATCH net-next 1/2] net: systemport: Implement adaptive interrupt coalescing

2018-03-26 Thread Tal Gilboa
On 3/23/2018 4:19 AM, Florian Fainelli wrote: Implement support for adaptive RX and TX interrupt coalescing using net_dim. We have each of our TX ring and our single RX ring implement a bcm_sysport_net_dim structure which holds an interrupt counter, number of packets, bytes, and a container for

[PATCH v3 iproute2-next 8/8] rdma: Add PD resource tracking information

2018-03-26 Thread Steve Wise
Sample output: Without CAP_NET_ADMIN capability: link mlx4_0/- users 0 pid 0 comm [ib_srpt] link mlx4_0/- users 0 pid 0 comm [ib_srp] link mlx4_0/- users 1 pid 0 comm [ib_core] link cxgb4_0/- users 0 pid 0 comm [ib_srp] With CAP_NET_ADMIN capability: link mlx4_0/- local_dma_lkey 0x8000 users 0

[PATCH v3 iproute2-next 6/8] rdma: Add CQ resource tracking information

2018-03-26 Thread Steve Wise
Sample output: # rdma resource show cq link cxgb4_0/- cqe 46 users 2 pid 30503 comm rping link cxgb4_0/- cqe 46 users 2 pid 30498 comm rping link mlx4_0/- cqe 63 users 2 pid 30494 comm rping link mlx4_0/- cqe 63 users 2 pid 30489 comm rping link mlx4_0/- cqe 1023 users 2 poll_ctx WORKQUEUE pid 0

[PATCH v3 iproute2-next 3/8] rdma: update rdma_netlink.h

2018-03-26 Thread Steve Wise
From: Steve Wise Pull in the latest rdma_netlink.h which has support for the rdma nldev resource tracking objects being added with this patch series. Signed-off-by: Steve Wise --- rdma/include/uapi/rdma/rdma_netlink.h | 38

[PATCH v3 iproute2-next 4/8] rdma: initialize the rd struct

2018-03-26 Thread Steve Wise
Initialize the rd struct so port_idx is 0 unless set otherwise. Otherwise, strict_port queries end up passing an uninitialized PORT nlattr. Signed-off-by: Steve Wise Reviewed-by: Leon Romanovsky --- rdma/rdma.c | 2 +- 1 file changed, 1

[PATCH v3 iproute2-next 7/8] rdma: Add MR resource tracking information

2018-03-26 Thread Steve Wise
Sample output: Without CAP_NET_ADMIN: $ rdma resource show mr mrlen 65536 link mlx4_0/- mrlen 65536 pid 0 comm [nvme_rdma] link cxgb4_0/- mrlen 65536 pid 0 comm [nvme_rdma] With CAP_NET_ADMIN: # rdma resource show mr mrlen 65536 link mlx4_0/- rkey 0x12702 lkey 0x12702 iova 0x85724a000 mrlen

[PATCH v3 iproute2-next 1/8] rdma: include rdma-core

2018-03-26 Thread Steve Wise
This avoids requiring rdma-core be installed on systems. Signed-off-by: Steve Wise --- rdma/include/rdma/rdma_cma.h | 728 +++ 1 file changed, 728 insertions(+) create mode 100644 rdma/include/rdma/rdma_cma.h diff --git

[PATCH v3 iproute2-next 2/8] rdma: Makefile change to find

2018-03-26 Thread Steve Wise
Signed-off-by: Steve Wise --- rdma/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/rdma/Makefile b/rdma/Makefile index 819fcbe..2cb46b6 100644 --- a/rdma/Makefile +++ b/rdma/Makefile @@ -4,7 +4,7 @@ include ../config.mk TARGETS :=

[PATCH v3 iproute2-next 0/8] cm_id, cq, mr, and pd resource tracking

2018-03-26 Thread Steve Wise
Hello, This series enhances the iproute2 rdma tool to include dumping of connection manager id (cm_id), completion queue (cq), memory region (mr), and protection domain (pd) rdma resources. It is the user-space part of the kernel resource tracking series merged into rdma-next for 4.17 [1].

  1   2   3   4   >