Re: [PATCH] wcn36xx: Disable 5GHz for wcn3610

2018-03-29 Thread Ramon Fried
On 3/29/2018 9:58 AM, Rafał Miłecki wrote: > On 03/29/2018 08:20 AM, Ramon Fried wrote: >> wcn3610 can only operate on 2.4GHz band due to RF limitation. >> If wcn36xx digital block is associated with an external IRIS >> RF module, retrieve the id and disable 5GHz band in case of >> wcn3610 id. >>

[PATCH 2/8] vti4: Don't count header length twice on tunnel setup

2018-03-29 Thread Steffen Klassert
From: Stefano Brivio This re-introduces the effect of commit a32452366b72 ("vti4: Don't count header length twice.") which was accidentally reverted by merge commit f895f0cfbb77 ("Merge branch 'master' of git://git.kernel.org/pub/scm/linux/kernel/git/klassert/ipsec"). The commit message from Ste

[PATCH 8/8] xfrm: Fix transport mode skb control buffer usage.

2018-03-29 Thread Steffen Klassert
A recent commit introduced a new struct xfrm_trans_cb that is used with the sk_buff control buffer. Unfortunately it placed the structure in front of the control buffer and overlooked that the IPv4/IPv6 control buffer is still needed for some layer 4 protocols. As a result the IPv4/IPv6 control buf

[PATCH 5/8] vti6: Properly adjust vti6 MTU from MTU of lower device

2018-03-29 Thread Steffen Klassert
From: Stefano Brivio If a lower device is found, we don't need to subtract LL_MAX_HEADER to calculate our MTU: just use its MTU, the link layer headers are already taken into account by it. If the lower device is not found, start from ETH_DATA_LEN instead, and only in this case subtract a worst-

[PATCH 1/8] xfrm: fix rcu_read_unlock usage in xfrm_local_error

2018-03-29 Thread Steffen Klassert
From: Taehee Yoo In the xfrm_local_error, rcu_read_unlock should be called when afinfo is not NULL. because xfrm_state_get_afinfo calls rcu_read_unlock if afinfo is NULL. Fixes: af5d27c4e12b ("xfrm: remove xfrm_state_put_afinfo") Signed-off-by: Taehee Yoo Signed-off-by: Steffen Klassert --- n

[PATCH 6/8] vti6: Keep set MTU on link creation or change, validate it

2018-03-29 Thread Steffen Klassert
From: Stefano Brivio In vti6_link_config(), if MTU is already given on link creation or change, validate and use it instead of recomputing it. To do that, we need to propagate the knowledge that MTU was set by userspace all the way down to vti6_link_config(). To keep this simple, vti6_dev_init()

[PATCH 4/8] vti4: Don't override MTU passed on link creation via IFLA_MTU

2018-03-29 Thread Steffen Klassert
From: Stefano Brivio Don't hardcode a MTU value on vti tunnel initialization, ip_tunnel_newlink() is able to deal with this already. See also commit ffc2b6ee4174 ("ip_gre: fix IFLA_MTU ignored on NEWLINK"). Fixes: 1181412c1a67 ("net/ipv4: VTI support new module for ip_vti.") Signed-off-by: Stefa

pull request (net): ipsec 2018-03-29

2018-03-29 Thread Steffen Klassert
1) Fix a rcu_read_lock/rcu_read_unlock imbalance in the error path of xfrm_local_error(). From Taehee Yoo. 2) Some VTI MTU fixes. From Stefano Brivio. 3) Fix a too early overwritten skb control buffer on xfrm transport mode. Please not that this pull request has a merge conflict in net/

[PATCH 7/8] vti6: Fix dev->max_mtu setting

2018-03-29 Thread Steffen Klassert
From: Stefano Brivio We shouldn't allow a tunnel to have IP_MAX_MTU as MTU, because another IPv6 header is going on top of our packets. Without this patch, we might end up building packets bigger than IP_MAX_MTU. Fixes: b96f9afee4eb ("ipv4/6: use core net MTU range checking") Signed-off-by: Stef

[PATCH 3/8] ip_tunnel: Clamp MTU to bounds on new link

2018-03-29 Thread Steffen Klassert
From: Stefano Brivio Otherwise, it's possible to specify invalid MTU values directly on creation of a link (via 'ip link add'). This is already prevented on subsequent MTU changes by commit b96f9afee4eb ("ipv4/6: use core net MTU range checking"). Fixes: c54419321455 ("GRE: Refactor GRE tunnelin

Re: [PATCH v2] wcn36xx: Disable 5GHz for wcn3610

2018-03-29 Thread Kalle Valo
(adding devicetree list) Ramon Fried writes: > wcn3610 can only operate on 2.4GHz band due to RF limitation. > If wcn36xx digital block is associated with an external IRIS > RF module, retrieve the id and disable 5GHz band in case of > wcn3610 id. > > Signed-off-by: Ramon Fried > --- > v2: fixe

INFO: task hung in stop_sync_thread (2)

2018-03-29 Thread syzbot
Hello, syzbot hit the following crash on net-next commit 5d22d47b9ed96eddb35821dc2cc4f629f45827f7 (Tue Mar 27 17:33:21 2018 +) Merge branch 'sfc-filter-locking' syzbot dashboard link: https://syzkaller.appspot.com/bug?extid=5fe074c01b2032ce9618 Unfortunately, I don't have any reproducer f

[PATCH 1/4] esp4: remove redundant initialization of pointer esph

2018-03-29 Thread Steffen Klassert
From: Colin Ian King Pointer esph is being assigned a value that is never read, esph is re-assigned and only read inside an if statement, hence the initialization is redundant and can be removed. Cleans up clang warning: net/ipv4/esp4.c:657:21: warning: Value stored to 'esph' during its initiali

[PATCH 4/4] xfrm_policy: use true and false for boolean values

2018-03-29 Thread Steffen Klassert
From: "Gustavo A. R. Silva" Assign true or false to boolean variables instead of an integer value. This issue was detected with the help of Coccinelle. Signed-off-by: Gustavo A. R. Silva Signed-off-by: Steffen Klassert --- net/xfrm/xfrm_policy.c | 2 +- 1 file changed, 1 insertion(+), 1 dele

[PATCH 3/4] esp: check the NETIF_F_HW_ESP_TX_CSUM bit before segmenting

2018-03-29 Thread Steffen Klassert
From: Shannon Nelson If I understand correctly, we should not be asking for a checksum offload on an ipsec packet if the netdev isn't advertising NETIF_F_HW_ESP_TX_CSUM. In that case, we should clear the NETIF_F_CSUM_MASK bits. Signed-off-by: Shannon Nelson Signed-off-by: Steffen Klassert ---

pull request (net-next): ipsec-next 2018-03-29

2018-03-29 Thread Steffen Klassert
1) Remove a redundant pointer initialization esp_input_set_header(). From Colin Ian King. 2) Mark the xfrm kmem_caches as __ro_after_init. From Alexey Dobriyan. 3) Do the checksum for an ipsec offlad packet in software if the device does not advertise NETIF_F_HW_ESP_TX_CSUM. From Shan

[PATCH 2/4] xfrm: mark kmem_caches as __ro_after_init

2018-03-29 Thread Steffen Klassert
From: Alexey Dobriyan Kmem caches aren't relocated once set up. Signed-off-by: Alexey Dobriyan Signed-off-by: Steffen Klassert --- net/xfrm/xfrm_input.c | 3 ++- net/xfrm/xfrm_policy.c | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/net/xfrm/xfrm_input.c b/net/xfrm/xfr

Re: [PATCH v2] wcn36xx: Disable 5GHz for wcn3610

2018-03-29 Thread Ramon Fried
(adding Bjorn Andersson) On 3/29/2018 10:15 AM, Kalle Valo wrote: > (adding devicetree list) > > Ramon Fried writes: > >> wcn3610 can only operate on 2.4GHz band due to RF limitation. >> If wcn36xx digital block is associated with an external IRIS >> RF module, retrieve the id and disable 5GHz b

Re: [PATCH v2] wcn36xx: Disable 5GHz for wcn3610

2018-03-29 Thread Loic Poulain
Hi Ramon, On 29 March 2018 at 09:32, Ramon Fried wrote: >> Should we document qcom,wcn3610 just like wcn3620 is: >> >> Documentation/devicetree/bindings/remoteproc/qcom,wcnss-pil.txt: >>"qcom,wcn3620", > IMHO the mentioned bindings is related to the PIL (peripheral image loa

Re: [PATCH net-next v2 2/3] net: systemport: Fix coalescing settings handling

2018-03-29 Thread Tal Gilboa
On 3/29/2018 1:15 AM, Florian Fainelli wrote: There were a number of issues with setting the RX coalescing parameters: - we would not be preserving values that would have been configured across close/open calls, instead we would always reset to no timeout and 1 interrupt per packet, this w

Re: [PATCH net-next v2 3/3] net: bcmgenet: Fix coalescing settings handling

2018-03-29 Thread Tal Gilboa
On 3/29/2018 1:15 AM, Florian Fainelli wrote: There were a number of issues with setting the RX coalescing parameters: - we would not be preserving values that would have been configured across close/open calls, instead we would always reset to no timeout and 1 interrupt per packet, this

Re: [EXT] [PATCH net-next v2 0/2] phylink: API changes

2018-03-29 Thread Russell King - ARM Linux
On Thu, Mar 29, 2018 at 05:58:43AM +, Yan Markman wrote: > Hi Florian > Please keep CCYelena Krivosheev > for changes with drivers/net/ethernet/marvell/mvneta.c > Thanks We have a way to ensure such things happen - it's the MAINTAINERS file. Please use the established co

Re: [PATCH v2] wcn36xx: Disable 5GHz for wcn3610

2018-03-29 Thread Kalle Valo
(really adding Bjorn) Ramon Fried writes: > (adding Bjorn Andersson) > > > On 3/29/2018 10:15 AM, Kalle Valo wrote: >> (adding devicetree list) >> >> Ramon Fried writes: >> >>> wcn3610 can only operate on 2.4GHz band due to RF limitation. >>> If wcn36xx digital block is associated with an exter

[PATCH net] vhost: validate log when IOTLB is enabled

2018-03-29 Thread Jason Wang
Vq log_base is the userspace address of bitmap which has nothing to do with IOTLB. So it needs to be validated unconditionally otherwise we may try use 0 as log_base which may lead to pin pages that will lead unexpected result (e.g trigger BUG_ON() in set_bit_to_user()). Fixes: 6b1e6cc7855b0 ("vho

Re: [PATCH net V2] vhost: correctly remove wait queue during poll failure

2018-03-29 Thread Jason Wang
On 2018年03月29日 12:20, Michael S. Tsirkin wrote: On Tue, Mar 27, 2018 at 08:50:52PM +0800, Jason Wang wrote: We tried to remove vq poll from wait queue, but do not check whether or not it was in a list before. This will lead double free. Fixing this by switching to use vhost_poll_stop() which z

Re: [PATCH net-next 1/2] ipv6: do not set routes if disable_ipv6 has been enabled

2018-03-29 Thread Lorenzo Bianconi
> On 3/27/18 11:11 AM, Lorenzo Bianconi wrote: > > Do not allow to set ipv6 routes from userspace if disable_ipv6 has been > > enabled. The issue can be triggered using the following reproducer: > > > > - sysctl net.ipv6.conf.all.disable_ipv6=1 > > - ip -6 route add a:b:c:d::/64 dev em1 > > - ip -

Re: [PATCH net-next 1/6] net: Fix fib notifer to return errno

2018-03-29 Thread Ido Schimmel
On Tue, Mar 27, 2018 at 06:21:55PM -0700, David Ahern wrote: > Notifier handlers use notifier_from_errno to convert any potential error > to an encoded format. As a consequence the other side, call_fib_notifier{s} > in this case, needs to use notifier_to_errno to return the error from > the handler

Re: [PATCH net-next 2/6] net: Move call_fib_rule_notifiers up in fib_nl_newrule

2018-03-29 Thread Ido Schimmel
On Tue, Mar 27, 2018 at 06:21:56PM -0700, David Ahern wrote: > Move call_fib_rule_notifiers up in fib_nl_newrule to the point right > before the rule is inserted into the list. At this point there are no > more failure paths within the core rule code, so if the notifier > does not fail then the rul

Re: [PATCH net-next 2/6] net: Move call_fib_rule_notifiers up in fib_nl_newrule

2018-03-29 Thread Ido Schimmel
On Tue, Mar 27, 2018 at 06:21:56PM -0700, David Ahern wrote: > Move call_fib_rule_notifiers up in fib_nl_newrule to the point right > before the rule is inserted into the list. At this point there are no > more failure paths within the core rule code, so if the notifier > does not fail then the rul

Re: [PATCH net-next 4/6] net/ipv4: Allow notifier to fail route replace

2018-03-29 Thread Ido Schimmel
On Tue, Mar 27, 2018 at 06:21:58PM -0700, David Ahern wrote: > Add checking to call to call_fib_entry_notifiers for IPv4 route replace. > Allows a notifier handler to fail the replace. > > Signed-off-by: David Ahern Reviewed-by: Ido Schimmel

Re: [PATCH net-next 3/6] net/ipv4: Move call_fib_entry_notifiers up for new routes

2018-03-29 Thread Ido Schimmel
On Tue, Mar 27, 2018 at 06:21:57PM -0700, David Ahern wrote: > Move call to call_fib_entry_notifiers for new IPv4 routes to right > before the call to fib_insert_alias. At this point the only remaining > failure path is memory allocations in fib_insert_node. Handle that > very unlikely failure with

Re: [PATCH net-next 5/6] net/ipv6: Move call_fib6_entry_notifiers up for route adds

2018-03-29 Thread Ido Schimmel
On Tue, Mar 27, 2018 at 06:21:59PM -0700, David Ahern wrote: > Move call to call_fib6_entry_notifiers for new IPv6 routes to right > before the insertion into the FIB. At this point notifier handlers can > decide the fate of the new route with a clean path to delete the > potential new entry if the

Re: [PATCH net-next 0/6] net: Allow FIB notifiers to fail add and replace

2018-03-29 Thread Ido Schimmel
On Tue, Mar 27, 2018 at 06:21:54PM -0700, David Ahern wrote: > I wanted to revisit how resource overload is handled for hardware offload > of FIB entries and rules. At the moment, the in-kernel fib notifier can > tell a driver about a route or rule add, replace, and delete, but the > notifier can n

Re: [PATCH 07/30] aio: add delayed cancel support

2018-03-29 Thread Christoph Hellwig
On Wed, Mar 28, 2018 at 05:35:26PM +0100, Al Viro wrote: > > ret = vfs_fsync(req->file, req->datasync); > > - fput(req->file); > > - aio_complete(container_of(req, struct aio_kiocb, fsync), ret, 0); > > + if (aio_complete(iocb, ret, 0, 0)) > > + fput(file); > > IDGI. > 1)

[PATCH v2 net-next 2/2] Documentation: ip-sysctl.txt: clarify disable_ipv6

2018-03-29 Thread Lorenzo Bianconi
Clarify that when disable_ipv6 is enabled even the ipv6 routes are deleted for the selected interface and from now it will not be possible to add addresses/routes to that interface Signed-off-by: Lorenzo Bianconi --- Documentation/networking/ip-sysctl.txt | 4 +++- 1 file changed, 3 insertions(+

[PATCH v2 net-next 0/2] do not allow adding routes if disable_ipv6 is enabled

2018-03-29 Thread Lorenzo Bianconi
Do not allow userspace to add static ipv6 routes if disable_ipv6 is enabled. Update disable_ipv6 documentation according to that change Changes since v1: - added an extack message telling the user that IPv6 is disabled on the nexthop device - rebased on-top of net-next Lorenzo Bianconi (2): i

[PATCH v2 net-next 1/2] ipv6: do not set routes if disable_ipv6 has been enabled

2018-03-29 Thread Lorenzo Bianconi
Do not allow setting ipv6 routes from userspace if disable_ipv6 has been enabled. The issue can be triggered using the following reproducer: - sysctl net.ipv6.conf.all.disable_ipv6=1 - ip -6 route add a:b:c:d::/64 dev em1 - ip -6 route show a:b:c:d::/64 dev em1 metric 1024 pref medium Fix it ch

Re: [RFC PATCH ghak32 V2 01/13] audit: add container id

2018-03-29 Thread Richard Guy Briggs
On 2018-03-28 12:39, Jonathan Corbet wrote: > On Fri, 16 Mar 2018 05:00:28 -0400 > Richard Guy Briggs wrote: > > Implement the proc fs write to set the audit container ID of a process, > > emitting an AUDIT_CONTAINER record to document the event. > > A little detail, but still... I am understand

Re: ath: Remove unnecessary ath_bcast_mac and use eth_broadcast_addr

2018-03-29 Thread Kalle Valo
Joe Perches wrote: > Remove the static array and use the generic routine to set the > Ethernet broadcast address. > > Signed-off-by: Joe Perches > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. a72c92629108 ath: Remove unnecessary ath_bcast_mac and use eth_bro

RE: [PATCH v7 3/7] bnx2x: Replace doorbell barrier() with wmb()

2018-03-29 Thread Elior, Ariel
> Subject: [PATCH v7 3/7] bnx2x: Replace doorbell barrier() with wmb() > > barrier() doesn't guarantee memory writes to be observed by the hardware on > all architectures. barrier() only tells compiler not to move this code > with respect to other read/writes. > > If memory write needs to be obse

Re: RFC on writel and writel_relaxed

2018-03-29 Thread Will Deacon
On Thu, Mar 29, 2018 at 08:31:32AM +1100, Benjamin Herrenschmidt wrote: > On Thu, 2018-03-29 at 02:23 +1000, Nicholas Piggin wrote: > > This is a variation on the mandatory write barrier that causes writes to > > weakly > > ordered I/O regions to be partially ordered. Its effects may go beyon

[PATCH] net: mvneta: remove duplicate *_coal assignment

2018-03-29 Thread Jisheng Zhang
The style of the rx/tx queue's *_coal member assignment is: static void foo_coal_set(...) { set the coal in hw; update queue's foo_coal member; [1] } In other place, we call foo_coal_set(pp, queue->foo_coal), so the above [1] is duplicated and could be removed. Signed-off-by: Jis

[PATCH v2 net-next 0/2] Fix TX Timeout and implement Safety Features

2018-03-29 Thread Jose Abreu
Fix the TX Timeout handler to correctly reconfigure the whole system and start implementing features for DWMAC5 cores, specifically the Safety Features. Changes since v1: - Display error stats in ethtool Cc: David S. Miller Cc: Joao Pinto Cc: Giuseppe Cavallaro Cc: Alexandre Torgue Cc

[PATCH v2 net-next 1/2] net: stmmac: Rework and fix TX Timeout code

2018-03-29 Thread Jose Abreu
Currently TX Timeout handler does not behaves as expected and leads to an unrecoverable state. Rework current implementation of TX Timeout handling to actually perform a complete reset of the driver state and IP. We use deferred work to init a task which will be responsible for resetting the syste

[PATCH v2 net-next 2/2] net: stmmac: Add support for DWMAC5 and implement Safety Features

2018-03-29 Thread Jose Abreu
This adds initial suport for DWMAC5 and implements the Automotive Safety Package which is available from core version 5.10. The Automotive Safety Pacakge (also called Safety Features) offers us with error protection in the core by implementing ECC Protection in memories, on-chip data path parity p

Re: [PATCH linux-stable-4.14] tcp: reset sk_send_head in tcp_write_queue_purge

2018-03-29 Thread Timofey Titovets
Hi, any progress here? I didn't find that patch applied for any 4.14.27-4.14.31 Patch rejected? 2018-03-20 19:13 GMT+03:00 Willy Tarreau : > Hi David, > > regarding the patch below, I'm not certain whether you planned to take > it since it's marked "not applicable" on patchwork, but I suspect it

[PATCH net-next] dt-bindings: net: renesas-ravb: Add support for r8a77470 SoC

2018-03-29 Thread Biju Das
Add a new compatible string for the RZ/G1C (R8A77470) SoC. Signed-off-by: Biju Das Reviewed-by: Fabrizio Castro --- Documentation/devicetree/bindings/net/renesas,ravb.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/net/renesas,ravb.txt b/Documentation/

[PATCH net 0/2] Fix vlan tag handling for vlan packets without ethernet headers

2018-03-29 Thread Toshiaki Makita
Eric Dumazet reported syzbot found a new bug which leads to underflow of size argument of memmove(), causing crash[1]. This can be triggered by tun devices. The underflow happened because skb_vlan_untag() did not expect vlan packets without ethernet headers, and tun can produce such packets. I als

[PATCH net 1/2] net: Fix untag for vlan packets without ethernet header

2018-03-29 Thread Toshiaki Makita
In some situation vlan packets do not have ethernet headers. One example is packets from tun devices. Users can specify vlan protocol in tun_pi field instead of IP protocol, and skb_vlan_untag() attempts to untag such packets. skb_vlan_untag() (more precisely, skb_reorder_vlan_header() called by i

[PATCH net 2/2] vlan: Fix vlan insertion for packets without ethernet header

2018-03-29 Thread Toshiaki Makita
In some situation vlan packets do not have ethernet headers. One example is packets from tun devices. Users can specify vlan protocol in tun_pi field instead of IP protocol. When we have a vlan device with reorder_hdr disabled on top of the tun device, such packets from tun devices are untagged in

Re: [PATCH linux-stable-4.14] tcp: reset sk_send_head in tcp_write_queue_purge

2018-03-29 Thread Jack Wang
2018-03-29 12:00 GMT+02:00 Timofey Titovets : > Hi, > any progress here? > > I didn't find that patch applied for any 4.14.27-4.14.31 > > Patch rejected? It's in queue for 4.14.32 https://git.kernel.org/pub/scm/linux/kernel/git/stable/stable-queue.git/tree/queue-4.14/tcp-reset-sk_send_head-in-tcp_w

[PATCH 0/2] net: mvneta: improve suspend/resume

2018-03-29 Thread Jisheng Zhang
This series tries to optimize the mvneta's suspend/resume implementation by only taking necessary actions. Jisheng Zhang (2): net: mvneta: split rxq/txq init into SW and HW parts net: mvneta: improve suspend/resume drivers/net/ethernet/marvell/mvneta.c | 146 +++--

[PATCH 1/2] net: mvneta: split rxq/txq init into SW and HW parts

2018-03-29 Thread Jisheng Zhang
This is to prepare the suspend/resume improvement in next patch. The SW parts can be optimized out during resume. Signed-off-by: Jisheng Zhang --- drivers/net/ethernet/marvell/mvneta.c | 70 ++- 1 file changed, 53 insertions(+), 17 deletions(-) diff --git a/drive

[PATCH 2/2] net: mvneta: improve suspend/resume

2018-03-29 Thread Jisheng Zhang
Current suspend/resume implementation reuses the mvneta_open() and mvneta_close(), but it could be optimized to take only necessary actions during suspend/resume. One obvious problem of current implementation is: after hundreds of system suspend/resume cycles, the resume of mvneta could fail due t

[PATCH net] net/dim: Fix int overflow

2018-03-29 Thread Tal Gilboa
When calculating difference between samples, the values are multiplied by 100. Large values may cause int overflow when multiplied (usually on first iteration). Fixed by forcing 100 to be of type unsigned long. Fixes: 4c4dbb4a7363 ("net/mlx5e: Move dynamic interrupt coalescing code to include/lin

[PATCH net-next] MAINTAINERS: Update my email address from freescale to nxp

2018-03-29 Thread Claudiu Manoil
The freescale.com address will no longer be available. Signed-off-by: Claudiu Manoil --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 73c0cda..274ba58 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -5637,7 +5637,7 @@ S:Mai

[PATCH 106/109] syscalls/x86: auto-create compat_sys_*() prototypes

2018-03-29 Thread Dominik Brodowski
compat_sys_*() functions are no longer called from within the kernel on x86 except from the system call table. Linking the system call does not require compat_sys_*() function prototypes at least on x86. Therefore, generate compat_sys_*() prototypes on-the-fly within the COMPAT_SYSCALL_DEFINEx() ma

[PATCH 028/109] net: socket: add __compat_sys_recvmmsg() helper; remove in-kernel call to compat syscall

2018-03-29 Thread Dominik Brodowski
Using the net-internal helper __compat_sys_recvmmsg() allows us to avoid the internal calls to the compat_sys_recvmmsg() syscall. This patch is part of a series which removes in-kernel calls to syscalls. On this basis, the syscall entry path can be streamlined. For details, see http://lkml.kernel.

[PATCH 024/109] net: socket: replace call to sys_recv() with __sys_recvfrom()

2018-03-29 Thread Dominik Brodowski
sys_recv() merely expands the parameters to __sys_recvfrom() by NULL and NULL. Open-code this in the two places which used sys_recv() as a wrapper to __sys_recvfrom(). This patch is part of a series which removes in-kernel calls to syscalls. On this basis, the syscall entry path can be streamlined

[PATCH 026/109] net: socket: add __compat_sys_setsockopt() helper; remove in-kernel call to compat syscall

2018-03-29 Thread Dominik Brodowski
Using the net-internal helper __compat_sys_setsockopt() allows us to avoid the internal calls to the compat_sys_setsockopt() syscall. This patch is part of a series which removes in-kernel calls to syscalls. On this basis, the syscall entry path can be streamlined. For details, see http://lkml.ker

[PATCH net-next] net: tcp: update mib LISTENOVERFLOWS if syn flood

2018-03-29 Thread yuan linyu
From: yuan linyu it's better to update mib LISTENOVERFLOWS even if packet is flood Signed-off-by: yuan linyu --- net/ipv4/tcp_input.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/net/ipv4/tcp_input.c b/net/ipv4/tcp_input.c index 451ef3012636..581f5b03ae54 100644

[PATCH 016/109] net: socket: add __sys_getpeername() helper; remove in-kernel call to syscall

2018-03-29 Thread Dominik Brodowski
Using the net-internal helper __sys_getpeername() allows us to avoid the internal calls to the sys_getpeername() syscall. This patch is part of a series which removes in-kernel calls to syscalls. On this basis, the syscall entry path can be streamlined. For details, see http://lkml.kernel.org/r/20

[PATCH 009/109] net: socket: add __sys_sendto() helper; remove in-kernel call to syscall

2018-03-29 Thread Dominik Brodowski
Using the net-internal helper __sys_sendto() allows us to avoid the internal calls to the sys_sendto() syscall. This patch is part of a series which removes in-kernel calls to syscalls. On this basis, the syscall entry path can be streamlined. For details, see http://lkml.kernel.org/r/201803251625

[PATCH 014/109] net: socket: add __sys_listen() helper; remove in-kernel call to syscall

2018-03-29 Thread Dominik Brodowski
Using the net-internal helper __sys_listen() allows us to avoid the internal calls to the sys_listen() syscall. This patch is part of a series which removes in-kernel calls to syscalls. On this basis, the syscall entry path can be streamlined. For details, see http://lkml.kernel.org/r/201803251625

[PATCH 018/109] net: socket: add __sys_shutdown() helper; remove in-kernel call to syscall

2018-03-29 Thread Dominik Brodowski
Using the net-internal helper __sys_shutdown() allows us to avoid the internal calls to the sys_shutdown() syscall. This patch is part of a series which removes in-kernel calls to syscalls. On this basis, the syscall entry path can be streamlined. For details, see http://lkml.kernel.org/r/20180325

[PATCH 011/109] net: socket: add __sys_socket() helper; remove in-kernel call to syscall

2018-03-29 Thread Dominik Brodowski
Using the net-internal helper __sys_socket() allows us to avoid the internal calls to the sys_socket() syscall. This patch is part of a series which removes in-kernel calls to syscalls. On this basis, the syscall entry path can be streamlined. For details, see http://lkml.kernel.org/r/201803251625

[PATCH 023/109] net: socket: replace calls to sys_send() with __sys_sendto()

2018-03-29 Thread Dominik Brodowski
sys_send() merely expands the parameters to __sys_sendto() by NULL and 0. Open-code this in the two places which used sys_send() as a wrapper to __sys_sendto(). This patch is part of a series which removes in-kernel calls to syscalls. On this basis, the syscall entry path can be streamlined. For d

[PATCH 104/109] net: remove compat_sys_*() prototypes from net/compat.h

2018-03-29 Thread Dominik Brodowski
As the syscall functions should only be called from the system call table but not from elsewhere in the kernel, it is sufficient that they are defined in linux/compat.h. Cc: David S. Miller Cc: netdev@vger.kernel.org Signed-off-by: Dominik Brodowski --- include/net/compat.h | 11 --- 1

[PATCH 029/109] net: socket: add __compat_sys_...msg() helpers; remove in-kernel calls to compat syscalls

2018-03-29 Thread Dominik Brodowski
Using the net-internal helpers __compat_sys_...msg() allows us to avoid the internal calls to the compat_sys_...msg() syscalls. compat_sys_recvmmsg() is handled in a different patch. This patch is part of a series which removes in-kernel calls to syscalls. On this basis, the syscall entry path can

Re: [PATCH 1/2] net: mvneta: split rxq/txq init into SW and HW parts

2018-03-29 Thread Thomas Petazzoni
Hello, On Thu, 29 Mar 2018 18:13:56 +0800, Jisheng Zhang wrote: > This is to prepare the suspend/resume improvement in next patch. The > SW parts can be optimized out during resume. > > Signed-off-by: Jisheng Zhang Thanks, I have two very minor nits below, but otherwise: Acked-by: Thomas Petaz

[PATCH 012/109] net: socket: add __sys_bind() helper; remove in-kernel call to syscall

2018-03-29 Thread Dominik Brodowski
Using the net-internal helper __sys_bind() allows us to avoid the internal calls to the sys_bind() syscall. This patch is part of a series which removes in-kernel calls to syscalls. On this basis, the syscall entry path can be streamlined. For details, see http://lkml.kernel.org/r/20180325162527.g

[PATCH 025/109] net: socket: add __compat_sys_recvfrom() helper; remove in-kernel call to compat syscall

2018-03-29 Thread Dominik Brodowski
Using the net-internal helper __compat_sys_recvfrom() allows us to avoid the internal calls to the compat_sys_recvfrom() syscall. This patch is part of a series which removes in-kernel calls to syscalls. On this basis, the syscall entry path can be streamlined. For details, see http://lkml.kernel.

[PATCH 027/109] net: socket: add __compat_sys_getsockopt() helper; remove in-kernel call to compat syscall

2018-03-29 Thread Dominik Brodowski
Using the net-internal helper __compat_sys_getsockopt() allows us to avoid the internal calls to the compat_sys_getsockopt() syscall. This patch is part of a series which removes in-kernel calls to syscalls. On this basis, the syscall entry path can be streamlined. For details, see http://lkml.ker

[PATCH 010/109] net: socket: add __sys_accept4() helper; remove in-kernel call to syscall

2018-03-29 Thread Dominik Brodowski
Using the net-internal helper __sys_accept4() allows us to avoid the internal calls to the sys_accept4() syscall. This patch is part of a series which removes in-kernel calls to syscalls. On this basis, the syscall entry path can be streamlined. For details, see http://lkml.kernel.org/r/2018032516

[PATCH 021/109] net: socket: add do_sys_recvmmsg() helper; remove in-kernel call to syscall

2018-03-29 Thread Dominik Brodowski
Using the net-internal helper do_sys_recvmmsg() allows us to avoid the internal calls to the sys_getsockopt() syscall. This patch is part of a series which removes in-kernel calls to syscalls. On this basis, the syscall entry path can be streamlined. For details, see http://lkml.kernel.org/r/20180

[PATCH 015/109] net: socket: add __sys_getsockname() helper; remove in-kernel call to syscall

2018-03-29 Thread Dominik Brodowski
Using the net-internal helper __sys_getsockname() allows us to avoid the internal calls to the sys_getsockname() syscall. This patch is part of a series which removes in-kernel calls to syscalls. On this basis, the syscall entry path can be streamlined. For details, see http://lkml.kernel.org/r/20

[PATCH 019/109] net: socket: add __sys_setsockopt() helper; remove in-kernel call to syscall

2018-03-29 Thread Dominik Brodowski
Using the net-internal helper __sys_setsockopt() allows us to avoid the internal calls to the sys_setsockopt() syscall. This patch is part of a series which removes in-kernel calls to syscalls. On this basis, the syscall entry path can be streamlined. For details, see http://lkml.kernel.org/r/2018

Re: [PATCH 2/2] net: mvneta: improve suspend/resume

2018-03-29 Thread Thomas Petazzoni
Hello Jisheng, On Thu, 29 Mar 2018 18:15:36 +0800, Jisheng Zhang wrote: > Current suspend/resume implementation reuses the mvneta_open() and > mvneta_close(), but it could be optimized to take only necessary > actions during suspend/resume. > > One obvious problem of current implementation is: af

[PATCH 008/109] net: socket: add __sys_recvfrom() helper; remove in-kernel call to syscall

2018-03-29 Thread Dominik Brodowski
Using the net-internal helper __sys_recvfrom() allows us to avoid the internal calls to the sys_recvfrom() syscall. This patch is part of a series which removes in-kernel calls to syscalls. On this basis, the syscall entry path can be streamlined. For details, see http://lkml.kernel.org/r/20180325

[PATCH 022/109] net: socket: move check for forbid_cmsg_compat to __sys_...msg()

2018-03-29 Thread Dominik Brodowski
The non-compat codepaths for sys_...msg() verify that MSG_CMSG_COMPAT is not set. By moving this check to the __sys_...msg() functions (and making it dependent on a static flag passed to this function), we can call the __sys...msg() functions instead of the syscall functions in all cases. __sys_rec

[PATCH 020/109] net: socket: add __sys_getsockopt() helper; remove in-kernel call to syscall

2018-03-29 Thread Dominik Brodowski
Using the net-internal helper __sys_getsockopt() allows us to avoid the internal calls to the sys_getsockopt() syscall. This patch is part of a series which removes in-kernel calls to syscalls. On this basis, the syscall entry path can be streamlined. For details, see http://lkml.kernel.org/r/2018

[PATCH] qed: fix spelling mistake: "checksumed" -> "checksummed"

2018-03-29 Thread Colin King
From: Colin Ian King Trivial fix to spelling mistake in DP_INFO message text Signed-off-by: Colin Ian King --- drivers/net/ethernet/qlogic/qed/qed_ll2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/qlogic/qed/qed_ll2.c b/drivers/net/ethernet/qlogic/

[PATCH 000/109] remove in-kernel calls to syscalls

2018-03-29 Thread Dominik Brodowski
[ While most parts of this patch set have been sent out already at least once, I send out *all* patches to lkml once again as this whole series touches several different subsystems in sensitive areas. ] System calls are interaction points between userspace and the kernel. Therefore, system cal

[PATCH 013/109] net: socket: add __sys_connect() helper; remove in-kernel call to syscall

2018-03-29 Thread Dominik Brodowski
Using the net-internal helper __sys_connect() allows us to avoid the internal calls to the sys_connect() syscall. This patch is part of a series which removes in-kernel calls to syscalls. On this basis, the syscall entry path can be streamlined. For details, see http://lkml.kernel.org/r/2018032516

[PATCH 017/109] net: socket: add __sys_socketpair() helper; remove in-kernel call to syscall

2018-03-29 Thread Dominik Brodowski
Using the net-internal helper __sys_socketpair() allows us to avoid the internal calls to the sys_socketpair() syscall. This patch is part of a series which removes in-kernel calls to syscalls. On this basis, the syscall entry path can be streamlined. For details, see http://lkml.kernel.org/r/2018

Re: [PATCH net] net/dim: Fix int overflow

2018-03-29 Thread Andy Gospodarek
On Thu, Mar 29, 2018 at 01:53:52PM +0300, Tal Gilboa wrote: > When calculating difference between samples, the values > are multiplied by 100. Large values may cause int overflow > when multiplied (usually on first iteration). > Fixed by forcing 100 to be of type unsigned long. > > Fixes: 4c4dbb4a

NAK: [PATCH] qed: fix spelling mistake: "checksumed" -> "checksummed"

2018-03-29 Thread Colin Ian King
On 29/03/18 12:59, Colin King wrote: > From: Colin Ian King > > Trivial fix to spelling mistake in DP_INFO message text > > Signed-off-by: Colin Ian King > --- > drivers/net/ethernet/qlogic/qed/qed_ll2.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethe

[PATCH v2 2/2] gfs2: Stop using rhashtable_walk_peek

2018-03-29 Thread Andreas Gruenbacher
Function rhashtable_walk_peek is problematic because there is no guarantee that the glock previously returned still exists; when that key is deleted, rhashtable_walk_peek can end up returning a different key, which will cause an inconsistent glock dump. Fix this by keeping track of the current glo

[PATCH v2 0/2] gfs2: Stop using rhashtable_walk_peek

2018-03-29 Thread Andreas Gruenbacher
Here's a second version of the patch (now a patch set) to eliminate rhashtable_walk_peek in gfs2. The first patch introduces lockref_put_not_zero, the inverse of lockref_get_not_zero. The second patch eliminates rhashtable_walk_peek in gfs2. In gfs2_glock_iter_next, the new lockref function from

[PATCH v2 1/2] lockref: Add lockref_put_not_zero

2018-03-29 Thread Andreas Gruenbacher
Put a lockref unless the lockref is dead or its count would become zero. This is the same as lockref_put_or_lock except that the lock is never left held. Signed-off-by: Andreas Gruenbacher --- include/linux/lockref.h | 1 + lib/lockref.c | 28 2 files chan

Re: [Patch net] llc: properly handle dev_queue_xmit() return value

2018-03-29 Thread Noam Rathaus
Hi, Will you notify me when its been accepted? if not, how can I do this checking myself to see if it was accepted? On Tue, Mar 27, 2018 at 8:13 PM, David Miller wrote: > From: Noam Rathaus > Date: Tue, 27 Mar 2018 16:27:49 + > >> Guys please fill me in on the next step? >> >> If it’s appli

Re: [Cluster-devel] [PATCH v2 0/2] gfs2: Stop using rhashtable_walk_peek

2018-03-29 Thread Steven Whitehouse
Hi, Can we solve the problem another way, by not taking refs on the glocks when we are iterating over them for the debugfs files? I assume that is the main issue here. We didn't used to take refs since the rcu locking was enough during the walk itself. We used to only keep track of the hash

Re: [PATCH v2 0/2] gfs2: Stop using rhashtable_walk_peek

2018-03-29 Thread Herbert Xu
On Thu, Mar 29, 2018 at 02:06:10PM +0200, Andreas Gruenbacher wrote: > Here's a second version of the patch (now a patch set) to eliminate > rhashtable_walk_peek in gfs2. > > The first patch introduces lockref_put_not_zero, the inverse of > lockref_get_not_zero. > > The second patch eliminates rh

Re: [PATCH net] vhost: validate log when IOTLB is enabled

2018-03-29 Thread Michael S. Tsirkin
On Thu, Mar 29, 2018 at 04:00:04PM +0800, Jason Wang wrote: > Vq log_base is the userspace address of bitmap which has nothing to do > with IOTLB. So it needs to be validated unconditionally otherwise we > may try use 0 as log_base which may lead to pin pages that will lead > unexpected result (e.g

[PATCH net-next 1/1] tc-testing: add connmark action tests

2018-03-29 Thread Roman Mashak
Signed-off-by: Roman Mashak --- .../tc-testing/tc-tests/actions/connmark.json | 291 + 1 file changed, 291 insertions(+) create mode 100644 tools/testing/selftests/tc-testing/tc-tests/actions/connmark.json diff --git a/tools/testing/selftests/tc-testing/tc-tests/action

Re: [EXT] [PATCH net-next v2 1/2] net: phy: phylink: Provide PHY interface to mac_link_{up,down}

2018-03-29 Thread Andrew Lunn
On Thu, Mar 29, 2018 at 05:59:02AM +, Yan Markman wrote: > Hi Florian > Please keep CCYelena Krivosheev > for changes with drivers/net/ethernet/marvell/mvneta.c > Thanks > Yan Markman > Tel. 05-44732819 Hi Yan Since you have obviously seen the patches, how about a Review

Re: [RFC PATCH ghak32 V2 01/13] audit: add container id

2018-03-29 Thread Jonathan Corbet
On Thu, 29 Mar 2018 05:01:32 -0400 Richard Guy Briggs wrote: > > A little detail, but still... > > I am understanding that you would prefer more context (as opposed to > operational detail) in the description, laying out the use case for this > patch(set)? No, sorry, "a little detail" was ref

pull-request: mac80211-next 2018-03-29

2018-03-29 Thread Johannes Berg
Hi Dave, Last update for -next, I guess, but I wanted to get the ETSI adaptivity requirements code and the eapol-over-nl80211 thing out - both have been around for a while. A number of other smaller things are also there, of course. Please pull and let me know if there's any problem. Thanks, joh

Re: [Cluster-devel] [PATCH v2 0/2] gfs2: Stop using rhashtable_walk_peek

2018-03-29 Thread Andreas Gruenbacher
On 29 March 2018 at 14:24, Steven Whitehouse wrote: > Hi, > > Can we solve the problem another way, by not taking refs on the glocks when > we are iterating over them for the debugfs files? I assume that is the main > issue here. > > We didn't used to take refs since the rcu locking was enough dur

Re: [PATCH v2 0/2] gfs2: Stop using rhashtable_walk_peek

2018-03-29 Thread Andreas Gruenbacher
On 29 March 2018 at 14:35, Herbert Xu wrote: > On Thu, Mar 29, 2018 at 02:06:10PM +0200, Andreas Gruenbacher wrote: >> Here's a second version of the patch (now a patch set) to eliminate >> rhashtable_walk_peek in gfs2. >> >> The first patch introduces lockref_put_not_zero, the inverse of >> lockr

  1   2   3   4   >