Re: linux-next: Signed-off-by missing for commits in the net-next tree

2018-04-01 Thread Stephen Rothwell
Hi Johan, On Mon, 2 Apr 2018 08:38:03 +0300 Johan Hedberg wrote: > > On Mon, Apr 02, 2018, Stephen Rothwell wrote: > > 45a42bc9cc65 ("Bluetooth: hci_bcm: Remove DMI quirk for the MINIX Z83-4") > > f9b95db0165a ("Bluetooth: btrsi: remove unused including > > ") > > 96e58d368fa6 ("Bluetooth:

general protection fault in tipc_nametbl_unsubscribe

2018-04-01 Thread syzbot
Hello, syzbot hit the following crash on upstream commit 10b84daddbec72c6b440216a69de9a9605127f7a (Sat Mar 31 17:59:00 2018 +) Merge branch 'perf-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip syzbot dashboard link: https://syzkaller.appspot.com/bug?extid=4859f

WARNING in add_uevent_var

2018-04-01 Thread syzbot
Hello, syzbot hit the following crash on upstream commit 10b84daddbec72c6b440216a69de9a9605127f7a (Sat Mar 31 17:59:00 2018 +) Merge branch 'perf-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip syzbot dashboard link: https://syzkaller.appspot.com/bug?extid=230d9

KASAN: stack-out-of-bounds Read in xfrm_state_find (5)

2018-04-01 Thread syzbot
Hello, syzbot hit the following crash on upstream commit 10b84daddbec72c6b440216a69de9a9605127f7a (Sat Mar 31 17:59:00 2018 +) Merge branch 'perf-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip syzbot dashboard link: https://syzkaller.appspot.com/bug?extid=d9046

Re: linux-next: Signed-off-by missing for commits in the net-next tree

2018-04-01 Thread Johan Hedberg
Hi, On Mon, Apr 02, 2018, Stephen Rothwell wrote: > 45a42bc9cc65 ("Bluetooth: hci_bcm: Remove DMI quirk for the MINIX Z83-4") > f9b95db0165a ("Bluetooth: btrsi: remove unused including ") > 96e58d368fa6 ("Bluetooth: Set HCI_QUIRK_SIMULTANEOUS_DISCOVERY for > BTUSB_QCA_ROME") > 9ea471320e1

[PATCH net-next] ipv6: frags: fix /proc/sys/net/ipv6/ip6frag_low_thresh

2018-04-01 Thread Eric Dumazet
I forgot to change ip6frag_low_thresh proc_handler from proc_dointvec_minmax to proc_doulongvec_minmax Fixes: 3e67f106f619 ("inet: frags: break the 2GB limit for frags storage") Signed-off-by: Eric Dumazet Reported-by: Maciej Żenczykowski --- net/ipv6/reassembly.c | 2 +- 1 file changed, 1 inse

Re: [PATCH] net: improve ipv4 performances

2018-04-01 Thread Eric Dumazet
On 04/01/2018 11:31 AM, Anton Gary Ceph wrote: > As the Linux networking stack is growing, more and more protocols are > added, increasing the complexity of stack itself. > Modern processors, contrary to common belief, are very bad in branch > prediction, so it's our task to give hints to the com

Re: [PATCH] net: ip tos cgroup

2018-04-01 Thread David Miller
From: Li RongQing Date: Mon, 2 Apr 2018 11:51:48 +0800 > ip tos segment can be changed by setsockopt(IP_TOS), or by iptables; > this patch creates a new method to change socket tos segment of > processes based on cgroup > > The usage: > > 1. mount tos_cgroup, and setting tos value > mo

[PATCH] net: ip tos cgroup

2018-04-01 Thread Li RongQing
ip tos segment can be changed by setsockopt(IP_TOS), or by iptables; this patch creates a new method to change socket tos segment of processes based on cgroup The usage: 1. mount tos_cgroup, and setting tos value mount -t cgroup -o ip_tos ip_tos /cgroups/tos echo tos-value >/cgroups/t

[PATCH v3 2/2] net: mvneta: improve suspend/resume

2018-04-01 Thread Jisheng Zhang
Current suspend/resume implementation reuses the mvneta_open() and mvneta_close(), but it could be optimized to take only necessary actions during suspend/resume. One obvious problem of current implementation is: after hundreds of system suspend/resume cycles, the resume of mvneta could fail due t

[PATCH v3 1/2] net: mvneta: split rxq/txq init and txq deinit into SW and HW parts

2018-04-01 Thread Jisheng Zhang
This is to prepare the suspend/resume improvement in next patch. The SW parts can be optimized out during resume. As for rxq handling during suspend, we'd like to drop packets by calling mvneta_rxq_drop_pkts() which is both SW and HW operation, so we don't split rxq deinit. Signed-off-by: Jisheng

[PATCH v3 0/2] net: mvneta: improve suspend/resume

2018-04-01 Thread Jisheng Zhang
This series tries to optimize the mvneta's suspend/resume implementation by only taking necessary actions. Since v2: - keep rtnl lock when calling mvneta_start_dev() and mvneta_stop_dev() Thank Russell for pointing this out Since v1: - unify ret check - try best to keep the suspend/resume b

linux-next: Signed-off-by missing for commits in the net-next tree

2018-04-01 Thread Stephen Rothwell
Hi all, Commits 45a42bc9cc65 ("Bluetooth: hci_bcm: Remove DMI quirk for the MINIX Z83-4") f9b95db0165a ("Bluetooth: btrsi: remove unused including ") 96e58d368fa6 ("Bluetooth: Set HCI_QUIRK_SIMULTANEOUS_DISCOVERY for BTUSB_QCA_ROME") 9ea471320e13 ("Bluetooth: Mark expected switch fall-th

Re: [PATCH net 0/2] net: bgmac: Couple of sparse warnings

2018-04-01 Thread David Miller
From: Florian Fainelli Date: Sun, 1 Apr 2018 10:26:28 -0700 > This patch series fixes a couple of warnings reported by sparse, should not > cause any functional problems since bgmac is typically used on LE platforms > anyway. Series applied, thanks Florian.

Re: INFO: rcu detected stall in vprintk_func

2018-04-01 Thread Sergey Senozhatsky
On (04/02/18 10:54), Sergey Senozhatsky wrote: > > > If you forward the report, please keep this part and the footer. > > > > > > llcp: nfc_llcp_send_ui_frame: Could not allocate PDU > > > llcp: nfc_llcp_send_ui_frame: Could not allocate PDU > > > llcp: nfc_llcp_send_ui_frame: Could not allocate PD

Re: INFO: rcu detected stall in vprintk_default

2018-04-01 Thread Sergey Senozhatsky
On (04/01/18 12:52), Dmitry Vyukov wrote: > > Seems to be the same as: > > #syz dup: INFO: rcu detected stall in vprintk_func > > +nfc maintainers Yes, seems to be the same issue. -ss

Re: INFO: rcu detected stall in vprintk_func

2018-04-01 Thread Sergey Senozhatsky
On (04/01/18 12:51), Dmitry Vyukov wrote: [..] > > IMPORTANT: if you fix the bug, please add the following tag to the commit: > > Reported-by: syzbot+3f28bd18291266ec8...@syzkaller.appspotmail.com > > It will help syzbot understand when the bug is fixed. See footer for > > details. > > If you forwa

RE: [PATCH v4 iproute2-next 0/7] cm_id, cq, mr, and pd resource tracking

2018-04-01 Thread Steve Wise
> > On Sun, Apr 01, 2018 at 09:22:14AM -0600, David Ahern wrote: > > On 3/29/18 3:38 PM, Steve Wise wrote: > > > This series enhances the iproute2 rdma tool to include dumping of > > > connection manager id (cm_id), completion queue (cq), memory region > (mr), > > > and protection domain (pd) rdma

Re: [PATCH net] route: check sysctl_fib_multipath_use_neigh earlier than hash

2018-04-01 Thread David Miller
From: Xin Long Date: Sun, 1 Apr 2018 22:40:35 +0800 > Prior to this patch, when one packet is hashed into path [1] > (hash <= nh_upper_bound) and it's neigh is dead, it will try > path [2]. However, if path [2]'s neigh is alive but it's > hash > nh_upper_bound, it will not return this alive path

Re: [PATCH] [PATCH] fix typo in command value in drivers/net/phy/mdio-bitbang.

2018-04-01 Thread David Miller
From: Frans Meulenbroeks Date: Sun, 1 Apr 2018 22:52:55 +0200 > mdio-bitbang mentioned 10 for both read and write. > However mdio read opcode is 10 and write opcode is 01 > Fixed comment. > > Signed-off-by: Frans Meulenbroeks Applied.

Re: [PATCH] sky2: Increase D3 delay to sky2 stops working after suspend

2018-04-01 Thread David Miller
From: Kai-Heng Feng Date: Sat, 31 Mar 2018 23:42:03 +0800 > The sky2 ethernet stops working after system resume from suspend: > [ 582.852065] sky2 :04:00.0: Refused to change power state, currently in > D3 > > The current 150ms delay is not enough, change it to 200ms can solve the > issue.

Re: [PATCH net] vlan: also check phy_driver ts_info for vlan's real device

2018-04-01 Thread David Miller
From: Hangbin Liu Date: Fri, 30 Mar 2018 09:44:00 +0800 > Just like function ethtool_get_ts_info(), we should also consider the > phy_driver ts_info call back. For example, driver dp83640. > > Fixes: 37dd9255b2f6 ("vlan: Pass ethtool get_ts_info queries to real device.") > Acked-by: Richard Coch

Re: [PATCH] net: sched: do not emit messages while holding spinlock

2018-04-01 Thread David Miller
From: Li RongQing Date: Fri, 30 Mar 2018 10:11:21 +0800 > move messages emitting out of sch_tree_lock to avoid holding > this lock too long. > > Signed-off-by: Li RongQing Applied.

Re: [PATCH net 1/1] net/mlx5e: Set EQE based as default TX interrupt moderation mode

2018-04-01 Thread David Miller
From: Saeed Mahameed Date: Fri, 30 Mar 2018 15:50:08 -0700 > From: Tal Gilboa > > The default TX moderation mode was mistakenly set to CQE based. The > intention was to add a control ability in order to improve some specific > use-cases. In general, we prefer to use EQE based moderation as it g

Re: [PATCH net] ibmvnic: Disable irqs before exiting reset from closed state

2018-04-01 Thread David Miller
From: John Allen Date: Fri, 30 Mar 2018 13:44:21 -0500 > When the driver is closed, all the associated irqs are disabled. In the > event that the driver exits a reset in the closed state, we should be > consistent with the state we are in directly after a close. So before we > exit the reset rout

Re: [PATCH] net: improve ipv4 performances

2018-04-01 Thread Md. Islam
Yes, I'm also seeing good performance improvement after adding likely() and prefetch(). On Sun, Apr 1, 2018 at 2:50 PM, Stephen Hemminger wrote: > On Sun, 1 Apr 2018 20:31:21 +0200 > Anton Gary Ceph wrote: > >> As the Linux networking stack is growing, more and more protocols are >> added, incr

[PATCH v15 ] net/veth/XDP: Line-rate packet forwarding in kernel

2018-04-01 Thread Md. Islam
This patch implements IPv4 forwarding on xdp_buff. I added a new config option XDP_ROUTER. Kernel would forward packets through fast path when this option is enabled. But it would require driver support. Currently it only works with veth. Here I have modified veth such that it outputs xdp_buff. I c

Re: [PATCH v5 04/14] PCI: Add pcie_bandwidth_available() to compute bandwidth available to device

2018-04-01 Thread Bjorn Helgaas
On Sun, Apr 01, 2018 at 11:41:42PM +0300, Tal Gilboa wrote: > On 3/31/2018 12:05 AM, Bjorn Helgaas wrote: > > From: Tal Gilboa > > > > Add pcie_bandwidth_available() to compute the bandwidth available to a > > device. This may be limited by the device itself or by a slower upstream > > link lead

Re: [PATCH v5 03/14] PCI: Add pcie_bandwidth_capable() to compute max supported link bandwidth

2018-04-01 Thread Bjorn Helgaas
On Sun, Apr 01, 2018 at 11:38:53PM +0300, Tal Gilboa wrote: > On 3/31/2018 12:05 AM, Bjorn Helgaas wrote: > > From: Tal Gilboa > > > > Add pcie_bandwidth_capable() to compute the max link bandwidth supported by > > a device, based on the max link speed and width, adjusted by the encoding > > over

Re: [PATCH bpf-next v8 00/11] Landlock LSM: Toward unprivileged sandboxing

2018-04-01 Thread Tycho Andersen
Hi Mickaël, On Mon, Apr 02, 2018 at 12:04:36AM +0200, Mickaël Salaün wrote: > >> vDSO is a code mapped for all processes. As you said, these processes > >> may use it or not. What I was thinking about is to use the same concept, > >> i.e. map a "shim" code into each processes pertaining to a parti

gretap tunnel redirecting 2 different networks on destination host

2018-04-01 Thread Marc Roos
How can I get the 10.11.12.x traffic received on tun1 at server B to eth2? I have a server A that sends 172.16.1.x and 10.11.12.x traffic via a gretab tunnel 192.168.1.x to server B. +-+ ++ 172.16.1.x | B |

Re: [PATCH] [PATCH] fix typo in command value in drivers/net/phy/mdio-bitbang.

2018-04-01 Thread Andrew Lunn
On Sun, Apr 01, 2018 at 10:52:55PM +0200, Frans Meulenbroeks wrote: > mdio-bitbang mentioned 10 for both read and write. > However mdio read opcode is 10 and write opcode is 01 > Fixed comment. > > Signed-off-by: Frans Meulenbroeks Reviewed-by: Andrew Lunn Andrew

Re: [PATCH bpf-next v8 08/11] landlock: Add ptrace restrictions

2018-04-01 Thread Mickaël Salaün
On 03/06/2018 11:28 PM, Mickaël Salaün wrote: > > On 28/02/2018 01:09, Andy Lutomirski wrote: >> On Wed, Feb 28, 2018 at 12:00 AM, Mickaël Salaün wrote: >>> >>> On 28/02/2018 00:23, Andy Lutomirski wrote: On Tue, Feb 27, 2018 at 11:02 PM, Andy Lutomirski wrote: > On Tue, Feb 27, 2018 a

[PATCH bpf-next v8 00/11] Landlock LSM: Toward unprivileged sandboxing

2018-04-01 Thread Mickaël Salaün
On 03/09/2018 12:53 AM, Andy Lutomirski wrote: > On Thu, Mar 8, 2018 at 11:51 PM, Mickaël Salaün wrote: >> >> On 07/03/2018 02:21, Andy Lutomirski wrote: >>> On Tue, Mar 6, 2018 at 11:06 PM, Mickaël Salaün wrote: On 06/03/2018 23:46, Tycho Andersen wrote: > On Tue, Mar 06, 2018 at

Re: [PATCH net-next V1 0/4] Introduce adaptive TX interrupt moderation to net DIM

2018-04-01 Thread David Miller
From: Tal Gilboa Date: Sun, 1 Apr 2018 23:28:13 +0300 > v1: Fix compilation issues due to missed function renaming. This doesn't even apply cleanly to net-next, always generate your patch series against the current state of the GIT tree. Applying: net/dim: Rename *_get_profile() functions to *

Re: pull request: bluetooth-next 2018-04-01

2018-04-01 Thread David Miller
From: Johan Hedberg Date: Sun, 1 Apr 2018 21:53:42 +0300 > Here's (most likely) the last bluetooth-next pull request for the 4.17 > kernel: > > - Remove unused btuart_cs driver (replaced by serial_cs + hci_uart) > - New USB ID for Edimax EW-7611ULB controller > - Cleanups & fixes to hci_bcm d

Re: [PATCH net] e1000e: Remove Other from EIAC.

2018-04-01 Thread Jan Kiszka
On 2018-01-31 08:26, Benjamin Poirier wrote: > It was reported that emulated e1000e devices in vmware esxi 6.5 Build > 7526125 do not link up after commit 4aea7a5c5e94 ("e1000e: Avoid receiver > overrun interrupt bursts", v4.15-rc1). Some tracing shows that after > e1000e_trigger_lsc() is called, I

[PATCH] [PATCH] fix typo in command value in drivers/net/phy/mdio-bitbang.

2018-04-01 Thread Frans Meulenbroeks
mdio-bitbang mentioned 10 for both read and write. However mdio read opcode is 10 and write opcode is 01 Fixed comment. Signed-off-by: Frans Meulenbroeks --- drivers/net/phy/mdio-bitbang.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/phy/mdio-bitbang.c b/driver

Re: [PATCH v5 04/14] PCI: Add pcie_bandwidth_available() to compute bandwidth available to device

2018-04-01 Thread Tal Gilboa
On 3/31/2018 12:05 AM, Bjorn Helgaas wrote: From: Tal Gilboa Add pcie_bandwidth_available() to compute the bandwidth available to a device. This may be limited by the device itself or by a slower upstream link leading to the device. The available bandwidth at each link along the path is compu

Re: [PATCH v5 03/14] PCI: Add pcie_bandwidth_capable() to compute max supported link bandwidth

2018-04-01 Thread Tal Gilboa
On 3/31/2018 12:05 AM, Bjorn Helgaas wrote: From: Tal Gilboa Add pcie_bandwidth_capable() to compute the max link bandwidth supported by a device, based on the max link speed and width, adjusted by the encoding overhead. The maximum bandwidth of the link is computed as: max_link_speed * ma

Re: [PATCH net-next] net/broadcom: Fixup broken build due to function name change

2018-04-01 Thread Tal Gilboa
On 4/1/2018 7:33 PM, Florian Fainelli wrote: Le 03/31/18 à 23:48, Tal Gilboa a écrit : Fixes: 8c6d6895bebb ("net/dim: Rename *_get_profile() functions to *_get_rx_moderation()") Signed-off-by: Tal Gilboa I think David just backed out your entire patch series adding TX DIM so you would have t

[PATCH net-next V1 2/4] net/dim: Add "enabled" field to net_dim struct

2018-04-01 Thread Tal Gilboa
Preparation for introducing adaptive TX to net DIM. Signed-off-by: Tal Gilboa --- drivers/net/ethernet/mellanox/mlx5/core/en.h | 1 - drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c | 10 +++--- drivers/net/ethernet/mellanox/mlx5/core/en_main.c| 6 +++--- drivers/net/ether

[PATCH net-next V1 4/4] net/mlx5e: Enable adaptive-TX moderation

2018-04-01 Thread Tal Gilboa
Add support for adaptive TX moderation. This greatly reduces TX interrupt rate and increases bandwidth, mostly for TCP bandwidth over ARM architecture (below). There is a slight single stream TCP with very large message sizes degradation (x86). In this case if there's any moderation on transmitted

[PATCH net-next V1 1/4] net/dim: Rename *_get_profile() functions to *_get_rx_moderation()

2018-04-01 Thread Tal Gilboa
Preparation for introducing adaptive TX to net DIM. Signed-off-by: Tal Gilboa --- drivers/net/ethernet/broadcom/bcmsysport.c| 6 +++--- drivers/net/ethernet/broadcom/bnxt/bnxt_dim.c | 8 drivers/net/ethernet/broadcom/genet/bcmgenet.c| 6 +++--- drivers/net/ethernet/me

[PATCH net-next V1 0/4] Introduce adaptive TX interrupt moderation to net DIM

2018-04-01 Thread Tal Gilboa
Net DIM is a library designed for dynamic interrupt moderation. It was implemented and optimized with receive side interrupts in mind, since these are usually the CPU expensive ones. This patch-set introduces adaptive transmit interrupt moderation to net DIM, complete with a usage in the mlx5e driv

[PATCH net-next V1 3/4] net/dim: Support adaptive TX moderation

2018-04-01 Thread Tal Gilboa
Interrupt moderation for TX traffic requires different profiles than RX interrupt moderation. The main goal here is to reduce interrupt rate and allow better payload aggregation by keeping SKBs in the TX queue a bit longer. Ping-pong behavior would get a profile with a short timer, so latency would

pull request: bluetooth-next 2018-04-01

2018-04-01 Thread Johan Hedberg
Hi Dave, Here's (most likely) the last bluetooth-next pull request for the 4.17 kernel: - Remove unused btuart_cs driver (replaced by serial_cs + hci_uart) - New USB ID for Edimax EW-7611ULB controller - Cleanups & fixes to hci_bcm driver - Clenups to btmrvl driver Please let me know if ther

Re: [PATCH] net: improve ipv4 performances

2018-04-01 Thread Stephen Hemminger
On Sun, 1 Apr 2018 20:31:21 +0200 Anton Gary Ceph wrote: > As the Linux networking stack is growing, more and more protocols are > added, increasing the complexity of stack itself. > Modern processors, contrary to common belief, are very bad in branch > prediction, so it's our task to give hints

[PATCH] net: improve ipv4 performances

2018-04-01 Thread Anton Gary Ceph
As the Linux networking stack is growing, more and more protocols are added, increasing the complexity of stack itself. Modern processors, contrary to common belief, are very bad in branch prediction, so it's our task to give hints to the compiler when possible. After a few profiling and analysis,

Re: [PATCH v4 iproute2-next 0/7] cm_id, cq, mr, and pd resource tracking

2018-04-01 Thread Leon Romanovsky
On Sun, Apr 01, 2018 at 09:22:14AM -0600, David Ahern wrote: > On 3/29/18 3:38 PM, Steve Wise wrote: > > This series enhances the iproute2 rdma tool to include dumping of > > connection manager id (cm_id), completion queue (cq), memory region (mr), > > and protection domain (pd) rdma resources. It

Re: [PATCH 0/2] sh_eth: remove SH_ETH_OFFSET_INVALID abuses

2018-04-01 Thread David Miller
From: Sergei Shtylyov Date: Sun, 1 Apr 2018 00:15:04 +0300 > Hello! > > Here's a set of 2 patches against DaveM's 'net-next.git' repo. They get rid of > the abuse of SH_ETH_OFFSET_INVALID for the register existence checks, so that > only its necessary uses would remain... > > [1/2] sh_eth: add

Re: [PATCH net-next 0/2] inet: factorize sk_wmem_alloc updates

2018-04-01 Thread David Miller
From: Eric Dumazet Date: Sat, 31 Mar 2018 13:16:24 -0700 > While testing my inet defrag changes, I found that senders > could spend ~20% of cpu cycles in skb_set_owner_w() updating > sk->sk_wmem_alloc for every fragment they cook, competing > with TX completion of prior skbs possibly happening on

Re: [PATCH V2] treewide/net: Rename eth_stp_addr to ether_stp_addr

2018-04-01 Thread David Miller
From: Joe Perches Date: Sat, 31 Mar 2018 11:34:06 -0700 > eth_stp_addr is not in the same form as the other global ether__addr > addresses like ether_broadcast_addr. > > Convert it treewide. > > Miscellanea: > > o Add comment to the ether_stp_addr define to show it's for spanning-tree > > Sig

Re: [PATCH v2 2/2] net: usb: asix88179_178a: de-duplicate code

2018-04-01 Thread David Miller
From: Marc Zyngier Date: Sat, 31 Mar 2018 12:16:05 + > I'd suggest that this patch is reverted until we understand what is > actually going on here. Yep, makes sense, reverted.

Re: [PATCH net] ip6_gre: remove redundant 'tunnel' setting in ip6erspan_tap_init()

2018-04-01 Thread David Miller
From: Alexey Kodanev Date: Fri, 30 Mar 2018 20:34:33 +0300 > 'tunnel' was already set at the start of ip6erspan_tap_init(). > > Fixes: 5a963eb61b7c ("ip6_gre: Add ERSPAN native tunnel support") > Signed-off-by: Alexey Kodanev Applied to net-next.

Re: [PATCH net-next] net: tcp: update mib LISTENOVERFLOWS if syn flood

2018-04-01 Thread David Miller
From: yuan linyu Date: Thu, 29 Mar 2018 19:20:09 +0800 > From: yuan linyu > > it's better to update mib LISTENOVERFLOWS even if packet is flood > > Signed-off-by: yuan linyu When we drop because of synflood we had no intention of trying to add to the accept queue. Therefore bumping the list

Re: [PATCH net-next] net/mlx4_en: CHECKSUM_COMPLETE support for fragments

2018-04-01 Thread David Miller
From: Eric Dumazet Date: Sun, 1 Apr 2018 09:39:38 -0700 > On 04/01/2018 01:06 AM, Tariq Toukan wrote: > >> >> Acked-by: Tariq Toukan > > Thanks Tariq and Saeed for the review ! Applied, thanks everyone.

[PATCH net 0/2] net: bgmac: Couple of sparse warnings

2018-04-01 Thread Florian Fainelli
Hi all, This patch series fixes a couple of warnings reported by sparse, should not cause any functional problems since bgmac is typically used on LE platforms anyway. Florian Fainelli (2): net: bgmac: Correctly annotate register space net: bgmac: Fix endian access in bgmac_dma_tx_ring_free()

[PATCH net 2/2] net: bgmac: Fix endian access in bgmac_dma_tx_ring_free()

2018-04-01 Thread Florian Fainelli
bgmac_dma_tx_ring_free() assigns the ctl1 word which is a litle endian 32-bit word without using proper accessors, fix this, and because a length cannot be negative, use unsigned int while at it. Fixes: 9cde94506eac ("bgmac: implement scatter/gather support") Signed-off-by: Florian Fainelli ---

[PATCH net 1/2] net: bgmac: Correctly annotate register space

2018-04-01 Thread Florian Fainelli
All the members: base, idm_base and nicpm_base should be annotated with __iomem since they are pointers to register space. This fixes a bunch of sparse reported warnings. Fixes: f6a95a24957a ("net: ethernet: bgmac: Add platform device support") Fixes: dd5c5d037f5e ("net: ethernet: bgmac: add NS2 s

Re: [PATCH net-next] net/mlx4_en: CHECKSUM_COMPLETE support for fragments

2018-04-01 Thread Eric Dumazet
On 04/01/2018 01:06 AM, Tariq Toukan wrote: > > Acked-by: Tariq Toukan Thanks Tariq and Saeed for the review !

Re: [PATCH net-next] net: ipv6/gre: Add GRO support

2018-04-01 Thread Eric Dumazet
On 04/01/2018 06:17 AM, Tariq Toukan wrote: > From: Eran Ben Elisha > > Add GRO capability for IPv6 GRE tunnel and ip6erspan tap, via gro_cells > infrastructure. > > Performance testing: 55% higher badwidth. > Measuring bandwidth of 1 thread IPv4 TCP traffic over IPv6 GRE tunnel > while GRO on

Re: [PATCH net-next] net/broadcom: Fixup broken build due to function name change

2018-04-01 Thread Florian Fainelli
Le 03/31/18 à 23:48, Tal Gilboa a écrit : > Fixes: 8c6d6895bebb ("net/dim: Rename *_get_profile() functions to > *_get_rx_moderation()") > Signed-off-by: Tal Gilboa I think David just backed out your entire patch series adding TX DIM so you would have to incorporate that change into your series

Re: [PATCH net] route: check sysctl_fib_multipath_use_neigh earlier than hash

2018-04-01 Thread David Ahern
On 4/1/18 8:40 AM, Xin Long wrote: > Prior to this patch, when one packet is hashed into path [1] > (hash <= nh_upper_bound) and it's neigh is dead, it will try > path [2]. However, if path [2]'s neigh is alive but it's > hash > nh_upper_bound, it will not return this alive path. > This packet will

Re: [RFC PATCH 2/3] netdev: kernel-only IFF_HIDDEN netdevice

2018-04-01 Thread David Ahern
On 4/1/18 3:13 AM, Si-Wei Liu wrote: > Hidden netdevice is not visible to userspace such that > typical network utilites e.g. ip, ifconfig and et al, > cannot sense its existence or configure it. Internally > hidden netdev may associate with an upper level netdev > that userspace has access to. Alt

Re: [PATCH iproute2-next 1/1] tc: jsonify sample action

2018-04-01 Thread David Ahern
On 3/30/18 10:20 PM, Roman Mashak wrote: > Signed-off-by: Roman Mashak > --- > tc/m_sample.c | 22 +- > 1 file changed, 13 insertions(+), 9 deletions(-) > applied to iproute2-next

Re: [PATCH iproute2-next 1/1] tc: support oneline mode in action generic printer functions

2018-04-01 Thread David Ahern
On 3/30/18 10:16 PM, Roman Mashak wrote: > Signed-off-by: Roman Mashak > --- > tc/m_action.c | 12 > 1 file changed, 8 insertions(+), 4 deletions(-) > applied to iproute2-next

Re: [PATCH v2 net-next 10/10] mlxsw: spectrum: Don't use resource ID of 0

2018-04-01 Thread David Ahern
On 4/1/18 8:34 AM, Ido Schimmel wrote: > From: Petr Machata > > In commit 145307460ba9 ("devlink: Remove top_hierarchy arg to > devlink_resource_register"), the "top_hierarchy" parameter to > devlink_resource_register() was removed in favor of using the parameter > "parent_resource_id" exclusivel

include/uapi/linux/ethtool.h problem

2018-04-01 Thread Madarassy László
Hi, I have the following problem: I included include/uapi/linux/mii.h from my source and when I compiled I got this error: ethtool.h:1556:35: error: comparison between signed and unsigned integer expressions [-Werro   return speed <= INT_MAX || speed == SPEED_UNKNOWN; speed declared as unsigne

Re: [PATCH v2 net-next 00/10] mlxsw: Various cleanups

2018-04-01 Thread David Miller
From: Ido Schimmel Date: Sun, 1 Apr 2018 17:34:49 +0300 > The first nine patches from Jiri perform small and unrelated cleanups. > The largest being the conversion of the KVD linear partitions from a > list to an array, which simplifies the code. > > The last patch from Petr is a bug fix for a

Re: [PATCH v4 iproute2-next 0/7] cm_id, cq, mr, and pd resource tracking

2018-04-01 Thread David Ahern
On 3/29/18 3:38 PM, Steve Wise wrote: > This series enhances the iproute2 rdma tool to include dumping of > connection manager id (cm_id), completion queue (cq), memory region (mr), > and protection domain (pd) rdma resources. It is the user-space part of > the kernel resource tracking series merg

[bpf-next PATCH 3/4] bpf: sockmap, refactor sockmap routines to work with hashmap

2018-04-01 Thread John Fastabend
This patch only refactors the existing sockmap code. This will allow much of the psock initialization code path and bpf helper codes to work for both sockmap bpf map types that are backed by an array, the currently supported type, and the new hash backed bpf map type sockhash. Most the fallout com

[bpf-next PATCH 2/4] bpf: sockmap, duplicates release calls may NULL sk_prot

2018-04-01 Thread John Fastabend
It is possible to have multiple ULP tcp_release call paths in flight if a sock is closed and simultaneously being removed from the sockmap control path. The result would be setting the sk_prot to the saved values on the first iteration and then on the second iteration setting the value to NULL. Th

[bpf-next PATCH 4/4] bpf: sockmap, add hash map support

2018-04-01 Thread John Fastabend
Sockmap is currently backed by an array and enforces keys to be four bytes. This works well for many use cases and was originally modeled after devmap which also uses four bytes keys. However, this has become limiting in larger use cases where a hash would be more appropriate. For example users may

[bpf-next PATCH 1/4] bpf: sockmap, free memory on sock close with cork data

2018-04-01 Thread John Fastabend
If a socket with pending cork data is closed we do not return the memory to the socket until the garbage collector free's the psock structure. The garbage collector though can run after the sock has completed its close operation. If this ordering happens the sock code will through a WARN_ON because

[bpf-next PATCH 0/4] Sockmap Updates

2018-04-01 Thread John Fastabend
Some additions for sockmap. First a couple fixes from the last round to ensure (a) we account for corked memory when a socket is closing and (b) do not set a null sk_prot value when tcp_close and sockmap destroy race. Then the new addition is a hash map type. As the sockmap use cases become more c

[PATCH net] route: check sysctl_fib_multipath_use_neigh earlier than hash

2018-04-01 Thread Xin Long
Prior to this patch, when one packet is hashed into path [1] (hash <= nh_upper_bound) and it's neigh is dead, it will try path [2]. However, if path [2]'s neigh is alive but it's hash > nh_upper_bound, it will not return this alive path. This packet will never be sent even if path [2] is alive. 3

[PATCH v2 net-next 04/10] mlxsw: spectrum: Change KVD linear parts from list to array

2018-04-01 Thread Ido Schimmel
From: Jiri Pirko The parts info is array. The parts copy this info array, yet they are a list. So make the indexing according to the id and change the list of parts into array of parts. This helps to eliminate lookups and constructs like mlxsw_sp_kvdl_part_update() (took me some non-trivial time

[PATCH v2 net-next 05/10] mlxsw: remove kvd_hash_granularity from config profile struct

2018-04-01 Thread Ido Schimmel
From: Jiri Pirko This should not be part of the struct, as the struct fields are tightly coupled with the FW command payload of the same name. Just use the "granularity" define directly, as in other places. Signed-off-by: Jiri Pirko Signed-off-by: Ido Schimmel --- drivers/net/ethernet/mellano

[PATCH v2 net-next 10/10] mlxsw: spectrum: Don't use resource ID of 0

2018-04-01 Thread Ido Schimmel
From: Petr Machata In commit 145307460ba9 ("devlink: Remove top_hierarchy arg to devlink_resource_register"), the "top_hierarchy" parameter to devlink_resource_register() was removed in favor of using the parameter "parent_resource_id" exclusively to determine who the parent is. The root node's r

[PATCH v2 net-next 08/10] mlxsw: Move "resources_query_enable" out of mlxsw_config_profile

2018-04-01 Thread Ido Schimmel
From: Jiri Pirko As struct mlxsw_config_profile is mapped to the payload of the FW command of the same name, resources_query_enable flag does not belong there. Move it to struct mlxsw_driver. Signed-off-by: Jiri Pirko Signed-off-by: Ido Schimmel --- drivers/net/ethernet/mellanox/mlxsw/core.c

[PATCH v2 net-next 06/10] mlxsw: core: Fix arg name of MLXSW_CORE_RES_VALID and MLXSW_CORE_RES_GET

2018-04-01 Thread Ido Schimmel
From: Jiri Pirko First arg of these helpers should be "mlxsw_core". Signed-off-by: Jiri Pirko Signed-off-by: Ido Schimmel --- drivers/net/ethernet/mellanox/mlxsw/core.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlxsw/core.h b/dr

[PATCH v2 net-next 09/10] mlxsw: spectrum: Pass mlxsw_core as arg of mlxsw_sp_kvdl_resources_register()

2018-04-01 Thread Ido Schimmel
From: Jiri Pirko Pass struct mlxsw_core instead of devlink since it is nicer within mlxsw code and we need both structs in mlxsw_sp_kvdl_resources_register() anyway. Signed-off-by: Jiri Pirko Signed-off-by: Ido Schimmel --- drivers/net/ethernet/mellanox/mlxsw/spectrum.c | 2 +- drivers/n

[PATCH v2 net-next 07/10] mlxsw: Move "used_kvd_sizes" check to mlxsw_pci_config_profile

2018-04-01 Thread Ido Schimmel
From: Jiri Pirko The check should be done directly in mlxsw_pci_config_profile, as for other profile items. Also, be consistent in naming with the rest and rename to "used_kvd_sizes". Signed-off-by: Jiri Pirko Signed-off-by: Ido Schimmel --- drivers/net/ethernet/mellanox/mlxsw/core.h | 3

[PATCH v2 net-next 01/10] mlxsw: spectrum_acl: Fix flex actions header ifndef define construct

2018-04-01 Thread Ido Schimmel
From: Jiri Pirko Fix copy&paste error in flex actions header ifndef define construct Signed-off-by: Jiri Pirko Signed-off-by: Ido Schimmel --- drivers/net/ethernet/mellanox/mlxsw/spectrum_acl_flex_actions.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/et

[PATCH v2 net-next 00/10] mlxsw: Various cleanups

2018-04-01 Thread Ido Schimmel
Hi, The first nine patches from Jiri perform small and unrelated cleanups. The largest being the conversion of the KVD linear partitions from a list to an array, which simplifies the code. The last patch from Petr is a bug fix for a recent net-next commit that prevented the "kvd" resource from be

[PATCH v2 net-next 03/10] mlxsw: Constify devlink_resource_ops

2018-04-01 Thread Ido Schimmel
From: Jiri Pirko devlink_resource_ops should be const as the arg of register function is also const. Signed-off-by: Jiri Pirko Signed-off-by: Ido Schimmel --- drivers/net/ethernet/mellanox/mlxsw/spectrum.c | 2 +- drivers/net/ethernet/mellanox/mlxsw/spectrum_kvdl.c | 6 +++--- 2 files ch

[PATCH v2 net-next 02/10] mlxsw: spectrum_kvdl: Fix handling of resource_size_param

2018-04-01 Thread Ido Schimmel
From: Jiri Pirko Current code uses global variables, adjusts them and passes pointer down to devlink. With every other mlxsw_core instance, the previously passed pointer values are rewritten. Fix this by de-globalize the variables. Fixes: 7f47b19bd744 ("mlxsw: spectrum_kvdl: Add support for per

[RFC v2] virtio: support packed ring

2018-04-01 Thread Tiwei Bie
Hello everyone, This RFC implements packed ring support for virtio driver. The code was tested with DPDK vhost (testpmd/vhost-PMD) implemented by Jens at http://dpdk.org/ml/archives/dev/2018-January/089417.html Minor changes are needed for the vhost code, e.g. to kick the guest. TODO: - Refineme

Re: [PATCH v15 net-next 01/12] tls: support for Inline tls record

2018-04-01 Thread Boris Pismenny
On 3/31/2018 7:11 PM, Atul Gupta wrote: Facility to register Inline TLS drivers to net/tls. Setup TLS_HW_RECORD prot to listen on offload device. Cases handled - Inline TLS device exists, setup prot for TLS_HW_RECORD - Atleast one Inline TLS exists, sets TLS_HW_RECORD. - If non-inline device e

[PATCH net-next] net: ipv6/gre: Add GRO support

2018-04-01 Thread Tariq Toukan
From: Eran Ben Elisha Add GRO capability for IPv6 GRE tunnel and ip6erspan tap, via gro_cells infrastructure. Performance testing: 55% higher badwidth. Measuring bandwidth of 1 thread IPv4 TCP traffic over IPv6 GRE tunnel while GRO on the physical interface is disabled. CPU: Intel Xeon E312xx (S

Re: [PATCH v15 net-next 00/12] Chelsio Inline TLS

2018-04-01 Thread Boris Pismenny
Hi, On 4/1/2018 6:37 AM, David Miller wrote: From: Atul Gupta Date: Sat, 31 Mar 2018 21:41:51 +0530 Series for Chelsio Inline TLS driver (chtls) Series applied, thank you. Sorry for being late to the party, could you please help answer a few questions to help me understand better. 1.

Re: WARNING: refcount bug in should_fail

2018-04-01 Thread Dmitry Vyukov
On Sun, Apr 1, 2018 at 1:46 PM, Dmitry Vyukov wrote: > On Sun, Apr 1, 2018 at 1:30 PM, Dmitry Vyukov wrote: >> On Sun, Apr 1, 2018 at 1:11 PM, Tetsuo Handa >> wrote: >>> Dmitry Vyukov wrote: On Sun, Apr 1, 2018 at 12:32 PM, Dmitry Vyukov wrote: > On Sun, Mar 4, 2018 at 6:57 AM, Tetsuo

Re: WARNING: refcount bug in should_fail

2018-04-01 Thread Dmitry Vyukov
On Sun, Apr 1, 2018 at 1:30 PM, Dmitry Vyukov wrote: > On Sun, Apr 1, 2018 at 1:11 PM, Tetsuo Handa > wrote: >> Dmitry Vyukov wrote: >>> On Sun, Apr 1, 2018 at 12:32 PM, Dmitry Vyukov wrote: >>> > On Sun, Mar 4, 2018 at 6:57 AM, Tetsuo Handa >>> > wrote: >>> >> Switching from mm to fsdevel, for

Re: WARNING: refcount bug in should_fail

2018-04-01 Thread Dmitry Vyukov
On Sun, Apr 1, 2018 at 1:11 PM, Tetsuo Handa wrote: > Dmitry Vyukov wrote: >> On Sun, Apr 1, 2018 at 12:32 PM, Dmitry Vyukov wrote: >> > On Sun, Mar 4, 2018 at 6:57 AM, Tetsuo Handa >> > wrote: >> >> Switching from mm to fsdevel, for this report says that put_net(net) in >> >> rpc_kill_sb() made

Re: WARNING: refcount bug in should_fail

2018-04-01 Thread Tetsuo Handa
Dmitry Vyukov wrote: > On Sun, Apr 1, 2018 at 12:32 PM, Dmitry Vyukov wrote: > > On Sun, Mar 4, 2018 at 6:57 AM, Tetsuo Handa > > wrote: > >> Switching from mm to fsdevel, for this report says that put_net(net) in > >> rpc_kill_sb() made net->count < 0 when mount_ns() failed due to > >> register_

Re: [PATCH net-next v2] ipvs: fix multiplicative hashing in sh/dh/lblc/lblcr algorithms

2018-04-01 Thread Julian Anastasov
Hello, On Sun, 1 Apr 2018, Vincent Bernat wrote: > The sh/dh/lblc/lblcr algorithms are using Knuth's multiplicative > hashing incorrectly. Replace its use by the hash_32() macro, which > correctly implements this algorithm. It doesn't use the same constant, > but it shouldn't matter. >

Re: INFO: rcu detected stall in vprintk_default

2018-04-01 Thread Dmitry Vyukov
On Sun, Apr 1, 2018 at 12:50 PM, syzbot wrote: > Hello, > > syzbot hit the following crash on upstream commit > 10b84daddbec72c6b440216a69de9a9605127f7a (Sat Mar 31 17:59:00 2018 +) > Merge branch 'perf-urgent-for-linus' of > git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip > syzbot dashb

Re: INFO: rcu detected stall in vprintk_func

2018-04-01 Thread Dmitry Vyukov
On Sun, Apr 1, 2018 at 12:49 PM, syzbot wrote: > Hello, > > syzbot hit the following crash on upstream commit > 3eb2ce825ea1ad89d20f7a3b5780df850e4be274 (Sun Mar 25 22:44:30 2018 +) > Linux 4.16-rc7 > syzbot dashboard link: > https://syzkaller.appspot.com/bug?extid=3f28bd18291266ec826b > > Unf

Re: [PATCH v4 iproute2-next 1/7] rdma: update rdma_netlink.h

2018-04-01 Thread Leon Romanovsky
On Thu, Mar 29, 2018 at 09:10:30AM -0700, Steve Wise wrote: > From: Steve Wise > > Pull in the latest rdma_netlink.h which has support for > the rdma nldev resource tracking objects being added > with this patch series. > > Signed-off-by: Steve Wise > --- > rdma/include/uapi/rdma/rdma_netlink.h

  1   2   >