Re: [PATCH 1/1] IB/rxe: avoid double kfree_skb

2018-04-19 Thread Yanjun Zhu
On 2018/4/20 10:19, Doug Ledford wrote: On Thu, 2018-04-19 at 10:01 -0400, Zhu Yanjun wrote: When skb is dropped by iptables rules, the skb is freed at the same time -EPERM is returned. So in softroce, it is not necessary to free skb again. Or else, crash will occur. The steps to reproduce:

[Patch net] llc: fix NULL pointer deref for SOCK_ZAPPED

2018-04-19 Thread Cong Wang
For SOCK_ZAPPED socket, we don't need to care about llc->sap, so we should just skip these refcount functions in this case. Fixes: f7e43672683b ("llc: hold llc_sap before release_sock()") Reported-by: kernel test robot Signed-off-by: Cong Wang ---

Re: [RFC] vhost: introduce mdev based hardware vhost backend

2018-04-19 Thread Jason Wang
On 2018年04月20日 02:40, Michael S. Tsirkin wrote: On Tue, Apr 10, 2018 at 03:25:45PM +0800, Jason Wang wrote: One problem is that, different virtio ring compatible devices may have different device interfaces. That is to say, we will need different drivers in QEMU. It could be troublesome. And

RE: [RFC] vhost: introduce mdev based hardware vhost backend

2018-04-19 Thread Liang, Cunming
> -Original Message- > From: Bie, Tiwei > Sent: Friday, April 20, 2018 11:28 AM > To: Michael S. Tsirkin > Cc: Jason Wang ; alex.william...@redhat.com; > ddut...@redhat.com; Duyck, Alexander H ; >

Re: [RFC] vhost: introduce mdev based hardware vhost backend

2018-04-19 Thread Michael S. Tsirkin
On Fri, Apr 20, 2018 at 11:28:07AM +0800, Tiwei Bie wrote: > On Thu, Apr 19, 2018 at 09:40:23PM +0300, Michael S. Tsirkin wrote: > > On Tue, Apr 10, 2018 at 03:25:45PM +0800, Jason Wang wrote: > > > > > > One problem is that, different virtio ring compatible devices > > > > > > may have different

Re: [PATCH bpf-next,v2 1/2] bpf: add helper for getting xfrm states

2018-04-19 Thread Eyal Birger
Hi, On Wed, 18 Apr 2018 15:31:03 -0700 Alexei Starovoitov wrote: > On Thu, Apr 19, 2018 at 12:58:22AM +0300, Eyal Birger wrote: > > This commit introduces a helper which allows fetching xfrm state > > parameters by eBPF programs attached to TC. > > > > Prototype:

Re: [PATCH v7 net-next 2/4] net: Introduce generic failover module

2018-04-19 Thread Michael S. Tsirkin
On Thu, Apr 19, 2018 at 06:42:02PM -0700, Sridhar Samudrala wrote: > +static struct net_device *failover_get_bymac(u8 *mac, struct failover_ops > **ops) > +{ > + struct net_device *failover_dev; > + struct failover *failover; > + > + spin_lock(_lock); > +

Re: [RFC] vhost: introduce mdev based hardware vhost backend

2018-04-19 Thread Tiwei Bie
On Thu, Apr 19, 2018 at 09:40:23PM +0300, Michael S. Tsirkin wrote: > On Tue, Apr 10, 2018 at 03:25:45PM +0800, Jason Wang wrote: > > > > > One problem is that, different virtio ring compatible devices > > > > > may have different device interfaces. That is to say, we will > > > > > need different

Re: [PATCH net-next 1/5] tcp: fix SO_RCVLOWAT and RCVBUF autotuning

2018-04-19 Thread Marcelo Ricardo Leitner
On Fri, Apr 20, 2018 at 02:36:52AM +, Eric Dumazet wrote: > On Thu, Apr 19, 2018 at 7:02 PM Marcelo Ricardo Leitner < > marcelo.leit...@gmail.com> wrote: > > > Hi Eric, > > > As val may be changed to a smaller value by the line above, shouldn't > > it assign sk->sk_rcvlowat again? Otherwise

Re: [PATCH v7 net-next 3/4] virtio_net: Extend virtio to use VF datapath when available

2018-04-19 Thread Michael S. Tsirkin
On Thu, Apr 19, 2018 at 06:42:03PM -0700, Sridhar Samudrala wrote: > @@ -3010,6 +3043,7 @@ static __init int virtio_net_driver_init(void) > ret = register_virtio_driver(_net_driver); > if (ret) > goto err_virtio; > + > return 0; > err_virtio: >

Re: [PATCH v7 net-next 2/4] net: Introduce generic failover module

2018-04-19 Thread Michael S. Tsirkin
On Thu, Apr 19, 2018 at 06:42:02PM -0700, Sridhar Samudrala wrote: > This provides a generic interface for paravirtual drivers to listen > for netdev register/unregister/link change events from pci ethernet > devices with the same MAC and takeover their datapath. The notifier and > event handling

Re: [net-next PATCH 0/3] Symmetric queue selection using XPS for Rx queues

2018-04-19 Thread Eric Dumazet
On Thu, Apr 19, 2018 at 6:07 PM Amritha Nambiar wrote: > This patch series implements support for Tx queue selection based on > Rx queue map. This is done by configuring Rx queue map per Tx-queue > using sysfs attribute. If the user configuration for Rx queues does >

Re: [PATCH net-next 1/5] tcp: fix SO_RCVLOWAT and RCVBUF autotuning

2018-04-19 Thread Eric Dumazet
On Thu, Apr 19, 2018 at 7:02 PM Marcelo Ricardo Leitner < marcelo.leit...@gmail.com> wrote: > Hi Eric, > As val may be changed to a smaller value by the line above, shouldn't > it assign sk->sk_rcvlowat again? Otherwise it may still be bigger > than sk_rcvbuf. > Say val = 512k,

Re: [PATCH 1/1] IB/rxe: avoid double kfree_skb

2018-04-19 Thread Doug Ledford
On Thu, 2018-04-19 at 10:01 -0400, Zhu Yanjun wrote: > When skb is dropped by iptables rules, the skb is freed at the same time > -EPERM is returned. So in softroce, it is not necessary to free skb again. > Or else, crash will occur. > > The steps to reproduce: > > server

Re: [PATCH net-next] net-next/hinic: add arm64 support

2018-04-19 Thread Zhao Chen
On 2018/4/20 1:34, David Miller wrote: > From: Zhao Chen > Date: Wed, 18 Apr 2018 06:07:39 -0400 > >> This patch enables arm64 platform support for the HINIC driver. >> >> Signed-off-by: Zhao Chen > > Applied, thank you. > > . > Thanks, David.

Re: [PATCH net-next 1/5] tcp: fix SO_RCVLOWAT and RCVBUF autotuning

2018-04-19 Thread Marcelo Ricardo Leitner
On Mon, Apr 16, 2018 at 10:33:35AM -0700, Eric Dumazet wrote: > Applications might use SO_RCVLOWAT on TCP socket hoping to receive > one [E]POLLIN event only when a given amount of bytes are ready in socket > receive queue. > > Problem is that receive autotuning is not aware of this constraint, >

[PATCH v7 net-next 4/4] netvsc: refactor notifier/event handling code to use the failover framework

2018-04-19 Thread Sridhar Samudrala
Use the registration/notification framework supported by the generic failover infrastructure. Signed-off-by: Sridhar Samudrala --- drivers/net/hyperv/Kconfig | 1 + drivers/net/hyperv/hyperv_net.h | 2 + drivers/net/hyperv/netvsc_drv.c | 208

[PATCH net-next v7 0/4] Enable virtio_net to act as a standby for a passthru device

2018-04-19 Thread Sridhar Samudrala
The main motivation for this patch is to enable cloud service providers to provide an accelerated datapath to virtio-net enabled VMs in a transparent manner with no/minimal guest userspace changes. This also enables hypervisor controlled live migration to be supported with VMs that have direct

[PATCH v7 net-next 2/4] net: Introduce generic failover module

2018-04-19 Thread Sridhar Samudrala
This provides a generic interface for paravirtual drivers to listen for netdev register/unregister/link change events from pci ethernet devices with the same MAC and takeover their datapath. The notifier and event handling code is based on the existing netvsc implementation. It exposes 2 sets of

[PATCH v7 net-next 1/4] virtio_net: Introduce VIRTIO_NET_F_STANDBY feature bit

2018-04-19 Thread Sridhar Samudrala
This feature bit can be used by hypervisor to indicate virtio_net device to act as a standby for another device with the same MAC address. VIRTIO_NET_F_STANDBY is defined as bit 62 as it is a device feature bit. Signed-off-by: Sridhar Samudrala ---

[PATCH v7 net-next 3/4] virtio_net: Extend virtio to use VF datapath when available

2018-04-19 Thread Sridhar Samudrala
This patch enables virtio_net to switch over to a VF datapath when a VF netdev is present with the same MAC address. It allows live migration of a VM with a direct attached VF without the need to setup a bond/team between a VF and virtio net device in the guest. The hypervisor needs to enable

Re: [RFC PATCH ghak32 V2 06/13] audit: add support for non-syscall auxiliary records

2018-04-19 Thread Richard Guy Briggs
On 2018-04-18 20:39, Paul Moore wrote: > On Fri, Mar 16, 2018 at 5:00 AM, Richard Guy Briggs wrote: > > Standalone audit records have the timestamp and serial number generated > > on the fly and as such are unique, making them standalone. This new > > function

Re: [PATCH net-next 4/5] tcp: implement mmap() for zero copy receive

2018-04-19 Thread David Miller
From: Eric Dumazet Date: Thu, 19 Apr 2018 18:01:32 -0700 > David, do you think such patch would be acceptable by lkml and mm/fs > maintainers ? You will have to ask them directly I think :)

[GIT] Networking

2018-04-19 Thread David Miller
1) Unbalanced refcounting in TIPC, from Jon Maloy. 2) Only allow TCP_MD5SIG to be set on sockets in close or listen state. Once the connection is established it makes no sense to change this. From Eric Dumazet. 3) Missing attribute validation in neigh_dump_table(), also from Eric

Re: [RFC PATCH ghak32 V2 05/13] audit: add containerid support for ptrace and signals

2018-04-19 Thread Richard Guy Briggs
On 2018-04-18 20:32, Paul Moore wrote: > On Fri, Mar 16, 2018 at 5:00 AM, Richard Guy Briggs wrote: > > Add container ID support to ptrace and signals. In particular, the "op" > > field provides a way to label the auxiliary record to which it is > > associated. > > > >

[net-next PATCH 1/3] net: Refactor XPS for CPUs and Rx queues

2018-04-19 Thread Amritha Nambiar
Refactor XPS code to support Tx queue selection based on CPU map or Rx queue map. Signed-off-by: Amritha Nambiar --- include/linux/netdevice.h | 82 +- net/core/dev.c| 206 +

[net-next PATCH 3/3] net-sysfs: Add interface for Rx queue map per Tx queue

2018-04-19 Thread Amritha Nambiar
Extend transmit queue sysfs attribute to configure Rx queue map per Tx queue. By default no receive queues are configured for the Tx queue. - /sys/class/net/eth0/queues/tx-*/xps_rxqs Signed-off-by: Amritha Nambiar --- net/core/net-sysfs.c | 81

[net-next PATCH 0/3] Symmetric queue selection using XPS for Rx queues

2018-04-19 Thread Amritha Nambiar
This patch series implements support for Tx queue selection based on Rx queue map. This is done by configuring Rx queue map per Tx-queue using sysfs attribute. If the user configuration for Rx queues does not apply, then the Tx queue selection falls back to XPS using CPUs and finally to hashing.

[net-next PATCH 2/3] net: Enable Tx queue selection based on Rx queues

2018-04-19 Thread Amritha Nambiar
This patch adds support to pick Tx queue based on the Rx queue map configuration set by the admin through the sysfs attribute for each Tx queue. If the user configuration for receive queue map does not apply, then the Tx queue selection falls back to CPU map based selection and finally to hashing.

Re: [PATCH net-next 4/5] tcp: implement mmap() for zero copy receive

2018-04-19 Thread Eric Dumazet
On 04/19/2018 04:15 PM, Eric Dumazet wrote: > I am not sure we can keep mmap() API, since we probably need to first lock > the socket, > then grab vm semaphore. > We can keep mmap() nice interface, granted we can add one hook like in following patch. David, do you think such patch would be

Re: [RFC PATCH ghak32 V2 10/13] audit: add containerid support for seccomp and anom_abend records

2018-04-19 Thread Richard Guy Briggs
On 2018-04-18 21:31, Paul Moore wrote: > On Fri, Mar 16, 2018 at 5:00 AM, Richard Guy Briggs wrote: > > Add container ID auxiliary records to secure computing and abnormal end > > standalone records. > > > > Signed-off-by: Richard Guy Briggs > > --- > >

Re: [pci PATCH v7 0/5] Add support for unmanaged SR-IOV

2018-04-19 Thread Michael S. Tsirkin
On Thu, Apr 19, 2018 at 03:54:49PM -0700, Alexander Duyck wrote: > On Thu, Mar 15, 2018 at 11:40 AM, Alexander Duyck > wrote: > > This series is meant to add support for SR-IOV on devices when the VFs are > > not managed by the kernel. Examples of recent patches

Re: [virtio-dev] [pci PATCH v7 2/5] virtio_pci: Add support for unmanaged SR-IOV on virtio_pci devices

2018-04-19 Thread Michael S. Tsirkin
On Tue, Apr 03, 2018 at 12:06:03PM -0700, Alexander Duyck wrote: > On Tue, Apr 3, 2018 at 11:27 AM, Michael S. Tsirkin wrote: > > On Tue, Apr 03, 2018 at 10:32:00AM -0700, Alexander Duyck wrote: > >> On Tue, Apr 3, 2018 at 6:12 AM, Michael S. Tsirkin wrote: > >>

Re: [bpf-next PATCH 3/3] bpf: add sample program to trace map events

2018-04-19 Thread Alexei Starovoitov
On Wed, Apr 18, 2018 at 05:30:59PM +0200, Sebastiano Miano wrote: > This patch adds a sample program, called trace_map_events, > that shows how to capture map events and filter them based on > the map id. ... > +struct bpf_map_keyval_ctx { > + u64 pad;// First 8 bytes are not

Re: [PATCH bpf-next v5 00/10] BTF: BPF Type Format

2018-04-19 Thread Daniel Borkmann
On 04/19/2018 12:55 AM, Martin KaFai Lau wrote: > This patch introduces BPF Type Format (BTF). > > BTF (BPF Type Format) is the meta data format which describes > the data types of BPF program/map. Hence, it basically focus > on the C programming language which the modern BPF is primary > using.

Re: [PATCH bpf-next v2 7/9] samples/bpf: add a test for bpf_get_stack helper

2018-04-19 Thread Yonghong Song
On 4/18/18 9:37 PM, Alexei Starovoitov wrote: On Wed, Apr 18, 2018 at 09:54:42AM -0700, Yonghong Song wrote: The test attached a kprobe program to kernel function sys_write. It tested to get stack for user space, kernel space and user space with build_id request. It also tested to get user

Re: [PATCH bpf-next v2 9/9] tools/bpf: add a test_progs test case for bpf_get_stack helper

2018-04-19 Thread Yonghong Song
On 4/18/18 9:39 PM, Alexei Starovoitov wrote: On Wed, Apr 18, 2018 at 09:54:44AM -0700, Yonghong Song wrote: The test_stacktrace_map is enhanced to call bpf_get_stack in the helper to get the stack trace as well. The stack traces from bpf_get_stack and bpf_get_stackid are compared to ensure

Re: [PATCH bpf-next v2 4/9] bpf/verifier: improve register value range tracking with ARSH

2018-04-19 Thread Yonghong Song
On 4/18/18 9:35 PM, Alexei Starovoitov wrote: On Wed, Apr 18, 2018 at 09:54:39AM -0700, Yonghong Song wrote: When helpers like bpf_get_stack returns an int value and later on used for arithmetic computation, the LSH and ARSH operations are often required to get proper sign extension into

Re: [PATCH bpf-next v2 3/9] bpf/verifier: refine retval R0 state for bpf_get_stack helper

2018-04-19 Thread Yonghong Song
On 4/18/18 9:33 PM, Alexei Starovoitov wrote: On Wed, Apr 18, 2018 at 09:54:38AM -0700, Yonghong Song wrote: The special property of return values for helpers bpf_get_stack and bpf_probe_read_str are captured in verifier. Both helpers return a negative error code or a length, which is equal

Re: [PATCH] kvmalloc: always use vmalloc if CONFIG_DEBUG_VM

2018-04-19 Thread Andrew Morton
On Thu, 19 Apr 2018 17:19:20 -0400 (EDT) Mikulas Patocka wrote: > > > In order to detect these bugs reliably I submit this patch that changes > > > kvmalloc to always use vmalloc if CONFIG_DEBUG_VM is turned on. > > > > > > ... > > > > > > --- linux-2.6.orig/mm/util.c

Re: [PATCH net-next 4/5] tcp: implement mmap() for zero copy receive

2018-04-19 Thread Eric Dumazet
On 04/16/2018 10:33 AM, Eric Dumazet wrote: > Some networks can make sure TCP payload can exactly fit 4KB pages, > with well chosen MSS/MTU and architectures. > > Implement mmap() system call so that applications can avoid > copying data without complex splice() games. > > Note that a

Re: [pci PATCH v7 0/5] Add support for unmanaged SR-IOV

2018-04-19 Thread Alexander Duyck
On Thu, Mar 15, 2018 at 11:40 AM, Alexander Duyck wrote: > This series is meant to add support for SR-IOV on devices when the VFs are > not managed by the kernel. Examples of recent patches attempting to do this > include: > virto -

Re: WARNING in refcount_inc (3)

2018-04-19 Thread Eric Biggers
On Sat, Mar 31, 2018 at 04:01:02PM -0700, syzbot wrote: > Hello, > > syzbot hit the following crash on bpf-next commit > 1379ef828a18d8f81c526b25e4d5685caa2cfd65 (Thu Mar 29 22:09:44 2018 +) > Merge branch 'bpf-sockmap-ingress' > syzbot dashboard link: >

Re: [PATCHv3 net 3/3] net: sched: ife: check on metadata length

2018-04-19 Thread Eric Dumazet
On 04/19/2018 03:14 PM, Alexander Aring wrote: > This patch checks if sk buffer is available to dererence ife header. If > not then NULL will returned to signal an malformed ife packet. This > avoids to crashing the kernel from outside. > > Signed-off-by: Alexander Aring >

Re: [PATCH net-next] ipv6: send netlink notifications for manually configured addresses

2018-04-19 Thread Lorenzo Bianconi
> From: Lorenzo Bianconi > Date: Tue, 17 Apr 2018 11:54:39 +0200 > >> Send a netlink notification when userspace adds a manually configured >> address if DAD is enabled and optimistic flag isn't set. >> Moreover send RTM_DELADDR notifications for tentative addresses.

[PATCHv3 net 2/3] net: sched: ife: handle malformed tlv length

2018-04-19 Thread Alexander Aring
There is currently no handling to check on a invalid tlv length. This patch adds such handling to avoid killing the kernel with a malformed ife packet. Signed-off-by: Alexander Aring Reviewed-by: Yotam Gigi Acked-by: Jamal Hadi Salim

[PATCHv3 net 3/3] net: sched: ife: check on metadata length

2018-04-19 Thread Alexander Aring
This patch checks if sk buffer is available to dererence ife header. If not then NULL will returned to signal an malformed ife packet. This avoids to crashing the kernel from outside. Signed-off-by: Alexander Aring Reviewed-by: Yotam Gigi Acked-by: Jamal

[PATCHv3 net 1/3] net: sched: ife: signal not finding metaid

2018-04-19 Thread Alexander Aring
We need to record stats for received metadata that we dont know how to process. Have find_decode_metaid() return -ENOENT to capture this. Signed-off-by: Alexander Aring Reviewed-by: Yotam Gigi Acked-by: Jamal Hadi Salim ---

[PATCHv3 net 0/3] net: sched: ife: malformed ife packet fixes

2018-04-19 Thread Alexander Aring
As promised at netdev 2.2 tc workshop I am working on adding scapy support for tdc testing. It is still work in progress. I will submit the patches to tdc later (they are not in good shape yet). The good news is I have been able to find bugs which normal packet testing would not be able to find.

Re: [PATCHv2 net 3/3] net: sched: ife: check on metadata length

2018-04-19 Thread Eric Dumazet
On 04/19/2018 02:44 PM, Alexander Aring wrote: > This patch checks if sk buffer is available to dererence ife header. If > not then NULL will returned to signal an malformed ife packet. This > avoids to crashing the kernel from outside. > > Signed-off-by: Alexander Aring >

[PATCHv2 net 1/3] net: sched: ife: signal not finding metaid

2018-04-19 Thread Alexander Aring
We need to record stats for received metadata that we dont know how to process. Have find_decode_metaid() return -ENOENT to capture this. Signed-off-by: Alexander Aring Reviewed-by: Yotam Gigi Acked-by: Jamal Hadi Salim ---

[PATCHv2 net 3/3] net: sched: ife: check on metadata length

2018-04-19 Thread Alexander Aring
This patch checks if sk buffer is available to dererence ife header. If not then NULL will returned to signal an malformed ife packet. This avoids to crashing the kernel from outside. Signed-off-by: Alexander Aring Reviewed-by: Yotam Gigi Acked-by: Jamal

[PATCHv2 net 0/3] net: sched: ife: malformed ife packet fixes

2018-04-19 Thread Alexander Aring
As promised at netdev 2.2 tc workshop I am working on adding scapy support for tdc testing. It is still work in progress. I will submit the patches to tdc later (they are not in good shape yet). The good news is I have been able to find bugs which normal packet testing would not be able to find.

[PATCHv2 net 2/3] net: sched: ife: handle malformed tlv length

2018-04-19 Thread Alexander Aring
There is currently no handling to check on a invalid tlv length. This patch adds such handling to avoid killing the kernel with a malformed ife packet. Signed-off-by: Alexander Aring Reviewed-by: Yotam Gigi Acked-by: Jamal Hadi Salim

Re: [PATCH v4 00/10] New network driver for Amiga X-Surf 100 (m68k)

2018-04-19 Thread Michael Schmitz
Thanks Dave! And many thanks to all the reviewers and testers! Cheers, Michael On Fri, Apr 20, 2018 at 8:11 AM, David Miller wrote: > From: Michael Schmitz > Date: Thu, 19 Apr 2018 14:05:17 +1200 > >> This patch series adds support for the

[net-next:master 23/31] drivers/net/hyperv/rndis_filter.c:1243: undefined reference to `ucs2_as_utf8'

2018-04-19 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master head: bda73d4ec943c4f7479603a59cad09a07c6c729a commit: 0fe554a46a0ff855376053c7e4204673b7879f05 [23/31] hv_netvsc: propogate Hyper-V friendly name into interface alias config: x86_64-randconfig-b0-04200208

[PATCH] kvmalloc: always use vmalloc if CONFIG_DEBUG_SG

2018-04-19 Thread Mikulas Patocka
On Thu, 19 Apr 2018, Michael S. Tsirkin wrote: > Maybe make it conditional on CONFIG_DEBUG_SG too? > Otherwise I think you just trigger a hard to debug memory corruption. OK, here I resend the patch with CONFIG_DEBUG_SG. With CONFIG_DEBUG_SG, the DMA API will print a stacktrace where the

[PATCH RFC net-next] net: ipvs: Adjust gso_size for IPPROTO_TCP

2018-04-19 Thread Martin KaFai Lau
This patch is not a proper fix and mainly serves for discussion purpose. It is based on net-next which I have been using to debug the issue. The change that works around the issue is in ensure_mtu_is_adequate(). Other changes are the rippling effect in function arg. This bug was uncovered by one

Re: [PATCH] kvmalloc: always use vmalloc if CONFIG_DEBUG_VM

2018-04-19 Thread Mikulas Patocka
On Thu, 19 Apr 2018, Andrew Morton wrote: > On Thu, 19 Apr 2018 12:12:38 -0400 (EDT) Mikulas Patocka > wrote: > > > The kvmalloc function tries to use kmalloc and falls back to vmalloc if > > kmalloc fails. > > > > Unfortunatelly, some kernel code has bugs - it uses

Re: [PATCH net 5/5] nfp: remove false positive offloads in flower vxlan

2018-04-19 Thread Or Gerlitz
On Thu, Apr 19, 2018 at 1:31 AM, John Hurley wrote: > On Wed, Apr 18, 2018 at 7:18 PM, Or Gerlitz wrote: >> On Wed, Apr 18, 2018 at 3:31 PM, John Hurley >> wrote: >>> On Wed, Apr 18, 2018 at 8:43 AM, Or Gerlitz

Re: [PATCH bpf-next v5 00/10] BTF: BPF Type Format

2018-04-19 Thread Martin KaFai Lau
On Thu, Apr 19, 2018 at 04:40:34PM -0300, Arnaldo Carvalho de Melo wrote: > Em Wed, Apr 18, 2018 at 03:55:56PM -0700, Martin KaFai Lau escreveu: > > This patch introduces BPF Type Format (BTF). > > > > BTF (BPF Type Format) is the meta data format which describes > > the data types of BPF

Re: [PATCH net-next 0/4] tracking TCP data delivery and ECN stats

2018-04-19 Thread Yuchung Cheng
On Thu, Apr 19, 2018 at 10:07 AM, David Miller wrote: > > From: Yuchung Cheng > Date: Tue, 17 Apr 2018 23:18:45 -0700 > > > This patch series improve tracking the data delivery status > > 1. minor improvement on SYN data > > 2. accounting bytes

Re: [PATCH net 0/1] net/smc: shutdown fix

2018-04-19 Thread David Miller
From: Ursula Braun Date: Thu, 19 Apr 2018 15:56:39 +0200 > This patch fixes the problem and is a candidate for -stable. Ok, queueud up.

Re: [PATCH net 1/1] net/smc: fix shutdown in state SMC_LISTEN

2018-04-19 Thread David Miller
From: Ursula Braun Date: Thu, 19 Apr 2018 15:56:40 +0200 > From: Ursula Braun > > Calling shutdown with SHUT_RD and SHUT_RDWR for a listening SMC socket > crashes, because >commit 127f49705823 ("net/smc: release clcsock from

Re: [PATCH net] bnxt_en: Fix memory fault in bnxt_ethtool_init()

2018-04-19 Thread David Miller
From: Michael Chan Date: Thu, 19 Apr 2018 03:16:16 -0400 > From: Vasundhara Volam > > In some firmware images, the length of BNX_DIR_TYPE_PKG_LOG nvram type > could be greater than the fixed buffer length of 4096 bytes allocated by >

Re: [PATCH] net: hns: Avoid action name truncation

2018-04-19 Thread David Miller
From: dann frazier Date: Wed, 18 Apr 2018 21:55:41 -0600 > When longer interface names are used, the action names exposed in > /proc/interrupts and /proc/irq/* maybe truncated. For example, when > using the predictable name algorithm in systemd on a HiSilicon D05, > I

Re: [PATCH net-next 00/11] Modernize mdio-gpio

2018-04-19 Thread Andrew Lunn
On Thu, Apr 19, 2018 at 09:52:09PM +0200, Linus Walleij wrote: > On Thu, Apr 19, 2018 at 1:02 AM, Andrew Lunn wrote: > > > This patchset is inspired by a previous version by Linus Walleij > > > > It reworks the mdio-gpio code to make use of gpio descriptors instead > > of gpio

Re: [PATCH v4 00/10] New network driver for Amiga X-Surf 100 (m68k)

2018-04-19 Thread David Miller
From: Michael Schmitz Date: Thu, 19 Apr 2018 14:05:17 +1200 > This patch series adds support for the Individual Computers X-Surf 100 > network card for m68k Amiga, a network adapter based on the AX88796 chip set. Series applied, thank you.

Re: [Xen-devel] [PATCH] xen-netfront: Fix hang on device removal

2018-04-19 Thread Simon Gaiser
Jason Andryuk: > On Thu, Apr 19, 2018 at 2:10 PM, Simon Gaiser > wrote: >> Jason Andryuk: >>> A toolstack may delete the vif frontend and backend xenstore entries >>> while xen-netfront is in the removal code path. In that case, the >>> checks for

Re: [PATCH net-next 01/11] net: phy_ mdio-gpio: Fixup , which should be ;

2018-04-19 Thread David Miller
From: Andrew Lunn Date: Thu, 19 Apr 2018 01:02:49 +0200 > @@ -161,7 +161,7 @@ static struct mii_bus *mdio_gpio_bus_init(struct device > *dev, > if (!new_bus) > goto out; > > - new_bus->name = "GPIO Bitbanged MDIO", > + new_bus->name = "GPIO

Re: [PATCH net-next 00/11] Modernize mdio-gpio

2018-04-19 Thread David Miller
From: Andrew Lunn Date: Thu, 19 Apr 2018 01:02:48 +0200 > This patchset is inspired by a previous version by Linus Walleij > > It reworks the mdio-gpio code to make use of gpio descriptors instead > of gpio numbers. However compared to the previous version, it retains > support

Re: [PATCH net-next 00/11] Modernize mdio-gpio

2018-04-19 Thread Linus Walleij
On Thu, Apr 19, 2018 at 1:02 AM, Andrew Lunn wrote: > This patchset is inspired by a previous version by Linus Walleij > > It reworks the mdio-gpio code to make use of gpio descriptors instead > of gpio numbers. However compared to the previous version, it retains > support for

[PATCH v2] net: ethernet: ti: cpsw: fix tx vlan priority mapping

2018-04-19 Thread Ivan Khoronzhuk
The CPDMA_TX_PRIORITY_MAP in real is vlan pcp field priority mapping register and basically replaces vlan pcp field for tagged packets. So, set it to be 1:1 mapping. Otherwise, it will cause unexpected change of egress vlan tagged packets, like prio 2 -> prio 5. Fixes: e05107e6b747 ("net:

Re: [PATCH] kvmalloc: always use vmalloc if CONFIG_DEBUG_VM

2018-04-19 Thread Andrew Morton
On Thu, 19 Apr 2018 12:12:38 -0400 (EDT) Mikulas Patocka wrote: > The kvmalloc function tries to use kmalloc and falls back to vmalloc if > kmalloc fails. > > Unfortunatelly, some kernel code has bugs - it uses kvmalloc and then > uses DMA-API on the returned memory or

Re: [PATCH net-next 0/8] net/ipv6: followup to fib6_info change

2018-04-19 Thread David Miller
From: David Ahern Date: Wed, 18 Apr 2018 15:38:58 -0700 > Followup to fib change for IPv6. > > First 2 patches rename fib6_info struct elements to match its name, > and rename addrconf_dst_alloc to match what it returns. > > Patches 3-7 refactor the code to remove the need

Re: [PATCH bpf-next v5 00/10] BTF: BPF Type Format

2018-04-19 Thread Arnaldo Carvalho de Melo
Em Wed, Apr 18, 2018 at 03:55:56PM -0700, Martin KaFai Lau escreveu: > This patch introduces BPF Type Format (BTF). > > BTF (BPF Type Format) is the meta data format which describes > the data types of BPF program/map. Hence, it basically focus > on the C programming language which the modern

Re: [PATCH net 2/3] net: sched: ife: handle malformed tlv length

2018-04-19 Thread David Miller
From: Alexander Aring Date: Wed, 18 Apr 2018 17:35:33 -0400 > @@ -92,12 +92,43 @@ struct meta_tlvhdr { > __be16 len; > }; > > +static inline bool __ife_tlv_meta_valid(const unsigned char *skbdata, > + const unsigned char

Re: [PATCH net-next] lan78xx: Add support to dump lan78xx registers

2018-04-19 Thread David Miller
From: Raghuram Chary J Date: Wed, 18 Apr 2018 21:27:35 +0530 > + /* Read Device/MAC registers */ > + for (i = 0, j = 0; i < (sizeof(lan78xx_regs) / sizeof(u32)); i++, j++) > + lan78xx_read_reg(dev, lan78xx_regs[i], [j]); There is no

[Patch net] llc: delete timers synchronously in llc_sk_free()

2018-04-19 Thread Cong Wang
The connection timers of an llc sock could be still flying after we delete them in llc_sk_free(), and even possibly after we free the sock. We could just wait synchronously here in case of troubles. Note, I leave other call paths as they are, since they may not have to wait, at least we can

Re: [PATCH] docs: ip-sysctl.txt: fix name of some ipv6 variables

2018-04-19 Thread David Miller
From: Olivier Gayot Date: Wed, 18 Apr 2018 22:03:06 +0200 > The name of the following proc/sysctl entries were incorrectly > documented: > > /proc/sys/net/ipv6/conf//max_dst_opts_number > /proc/sys/net/ipv6/conf//max_hbt_opts_number >

Re: simplify procfs code for seq_file instances

2018-04-19 Thread Alexey Dobriyan
> git://git.infradead.org/users/hch/misc.git proc_create I want to ask if it is time to start using poorman function overloading with _b_c_e(). There are millions of allocation functions for example, all slightly difference, and people will add more. Seeing /proc interfaces doubled like this

Re: WARNING in refcount_dec

2018-04-19 Thread Willem de Bruijn
On Thu, Apr 19, 2018 at 2:32 AM, DaeRyong Jeong wrote: > Hello. > We have analyzed the cause of the crash in v4.16-rc3, WARNING in refcount_dec, > which is found by RaceFuzzer (a modified version of Syzkaller). > > Since struct packet_sock's member variables, running,

Re: [PATCH 03/39] proc: introduce proc_create_seq_private

2018-04-19 Thread Alexey Dobriyan
On Thu, Apr 19, 2018 at 02:41:04PM +0200, Christoph Hellwig wrote: > Variant of proc_create_data that directly take a struct seq_operations > --- a/fs/proc/internal.h > +++ b/fs/proc/internal.h > @@ -45,6 +45,7 @@ struct proc_dir_entry { > const struct inode_operations *proc_iops; >

Re: [PATCH 14/39] proc: introduce proc_create_net_single

2018-04-19 Thread Alexey Dobriyan
On Thu, Apr 19, 2018 at 02:41:15PM +0200, Christoph Hellwig wrote: > Variant of proc_create_data that directly take a seq_file show > +struct proc_dir_entry *proc_create_net_single(const char *name, umode_t mode, > + struct proc_dir_entry *parent, > + int (*show)(struct

Re: [PATCH 02/39] proc: introduce proc_create_seq{,_data}

2018-04-19 Thread Alexey Dobriyan
On Thu, Apr 19, 2018 at 02:41:03PM +0200, Christoph Hellwig wrote: > Variants of proc_create{,_data} that directly take a struct seq_operations > argument and drastically reduces the boilerplate code in the callers. > +static int proc_seq_open(struct inode *inode, struct file *file) > +{ > +

Re: [RFC] vhost: introduce mdev based hardware vhost backend

2018-04-19 Thread Michael S. Tsirkin
On Tue, Apr 10, 2018 at 03:25:45PM +0800, Jason Wang wrote: > > > > One problem is that, different virtio ring compatible devices > > > > may have different device interfaces. That is to say, we will > > > > need different drivers in QEMU. It could be troublesome. And > > > > that's what this

Re: [bisected] Stack overflow after fs: "switch the IO-triggering parts of umount to fs_pin" (was net namespaces kernel stack overflow)

2018-04-19 Thread Alexander Aring
Hi, On Thu, Apr 19, 2018 at 12:56 PM, Kirill Tkhai wrote: > On 19.04.2018 19:44, Al Viro wrote: >> On Thu, Apr 19, 2018 at 04:34:48PM +0100, Al Viro wrote: >> >>> IOW, we only get there if our vfsmount was an MNT_INTERNAL one. >>> So we have mnt->mnt_umount of some

Re: [PATCH] kvmalloc: always use vmalloc if CONFIG_DEBUG_VM

2018-04-19 Thread Vlastimil Babka
On 04/19/2018 06:12 PM, Mikulas Patocka wrote: > From: Mikulas Patocka > Subject: [PATCH] kvmalloc: always use vmalloc if CONFIG_DEBUG_VM > > The kvmalloc function tries to use kmalloc and falls back to vmalloc if > kmalloc fails. > > Unfortunatelly, some kernel code has

Re: [PATCH net-next] net: pskb_trim_rcsum() and CHECKSUM_COMPLETE are friends

2018-04-19 Thread Alexander Duyck
On Wed, Apr 18, 2018 at 11:43 AM, Eric Dumazet wrote: > After working on IP defragmentation lately, I found that some large > packets defeat CHECKSUM_COMPLETE optimization because of NIC adding > zero paddings on the last (small) fragment. > > While removing the padding with

[PATCH v2 3/3] ath10k: Support ethtool gstats2 API.

2018-04-19 Thread greearb
From: Ben Greear Skip a firmware stats update when calling code indicates the stats refresh is not needed. Signed-off-by: Ben Greear --- v2: Convert to new flag name, attempt to fix build when there is not DEBUGFS enabled for ath10k.

[PATCH v2 1/3] ethtool: Support ETHTOOL_GSTATS2 command.

2018-04-19 Thread greearb
From: Ben Greear This is similar to ETHTOOL_GSTATS, but it allows you to specify flags. These flags can be used by the driver to decrease the amount of stats refreshed. In particular, this helps with ath10k since getting the firmware stats can be slow. Signed-off-by:

[PATCH v2 2/3] mac80211: Add support for ethtool gstats2 API.

2018-04-19 Thread greearb
From: Ben Greear This enables users to request fewer stats to be refreshed in cases where firmware does not need to be probed. Signed-off-by: Ben Greear --- v2: No changes. include/net/mac80211.h| 6 ++ net/mac80211/driver-ops.h |

Re: [PATCH iproute2 net-next] vxlan: fix ttl inherit behavior

2018-04-19 Thread David Ahern
On 4/17/18 11:05 PM, Hangbin Liu wrote: > Like kernel net-next commit 72f6d71e491e6 ("vxlan: add ttl inherit support"), > vxlan ttl inherit should means inherit the inner protocol's ttl value. > > But currently when we add vxlan with "ttl inherit", we only set ttl 0, > which is actually use

Re: [Xen-devel] [PATCH] xen-netfront: Fix hang on device removal

2018-04-19 Thread Jason Andryuk
On Thu, Apr 19, 2018 at 2:10 PM, Simon Gaiser wrote: > Jason Andryuk: >> A toolstack may delete the vif frontend and backend xenstore entries >> while xen-netfront is in the removal code path. In that case, the >> checks for xenbus_read_driver_state would return

Re: [Xen-devel] [PATCH] xen-netfront: Fix hang on device removal

2018-04-19 Thread Simon Gaiser
Jason Andryuk: > A toolstack may delete the vif frontend and backend xenstore entries > while xen-netfront is in the removal code path. In that case, the > checks for xenbus_read_driver_state would return XenbusStateUnknown, and > xennet_remove would hang indefinitely. This hang prevents system

[PATCH] net: Work around crash in ipv6 fib-walk-continue

2018-04-19 Thread greearb
From: Ben Greear This keeps us from crashing in certain test cases where we bring up many (1000, for instance) mac-vlans with IPv6 enabled in the kernel. This bug has been around for a very long time. Until a real fix is found (and for stable), maybe it is better to

Re: [PATCH net] vmxnet3: fix incorrect dereference when rxvlan is disabled

2018-04-19 Thread David Miller
From: Ronak Doshi Date: Wed, 18 Apr 2018 12:48:04 -0700 > vmxnet3_get_hdr_len() is used to calculate the header length which in > turn is used to calculate the gso_size for skb. When rxvlan offload is > disabled, vlan tag is present in the header and the function references >

Re: [Patch net] llc: hold llc_sap before release_sock()

2018-04-19 Thread David Miller
From: Cong Wang Date: Wed, 18 Apr 2018 11:51:56 -0700 > @@ -199,9 +200,15 @@ static int llc_ui_release(struct socket *sock) > llc->laddr.lsap, llc->daddr.lsap); > if (!llc_send_disc(sk)) > llc_ui_wait_for_disc(sk, sk->sk_rcvtimeo); > +

Re: [PATCH net-next] net: pskb_trim_rcsum() and CHECKSUM_COMPLETE are friends

2018-04-19 Thread David Miller
From: Eric Dumazet Date: Wed, 18 Apr 2018 11:43:15 -0700 > After working on IP defragmentation lately, I found that some large > packets defeat CHECKSUM_COMPLETE optimization because of NIC adding > zero paddings on the last (small) fragment. > > While removing the padding

Re: [PATCH RFC net-next 00/11] udp gso

2018-04-19 Thread David Miller
From: Willem de Bruijn Date: Wed, 18 Apr 2018 14:12:40 -0400 > Actually, yes, I should be able to relax that constraint with > segmentation. > > It is there in case a corked packet may grow to the point of > having to be fragmented. But segmentation already

  1   2   3   4   >