Re: general protection fault in rds_ib_get_mr

2018-05-13 Thread santosh.shilim...@oracle.com
On 5/13/18 2:10 PM, Eric Biggers wrote: On Wed, Mar 21, 2018 at 09:00:01AM -0700, syzbot wrote: [...] Still reproducible on Linus' tree (commit 66e1c94db3cd4) and linux-next (next-20180511). Here's a simplified reproducer: Thanks for the test case !! Regards, Santosh

Re: [PATCH RESEND net-next v2 1/8] dt-bindings: net: dwmac-sun8i: Clean up clock delay chain descriptions

2018-05-13 Thread Icenowy Zheng
于 2018年5月14日 GMT+08:00 下午12:59:22, Chen-Yu Tsai 写到: >On Sun, May 13, 2018 at 1:29 PM, Andrew Lunn wrote: >> On Sun, May 13, 2018 at 01:11:08PM -0700, Chen-Yu Tsai wrote: >>> On Sun, May 13, 2018 at 1:05 PM, Andrew Lunn wrote: >>> >> > Hi Chen-Yu

Re: [PATCH RESEND net-next v2 1/8] dt-bindings: net: dwmac-sun8i: Clean up clock delay chain descriptions

2018-05-13 Thread Chen-Yu Tsai
On Sun, May 13, 2018 at 1:29 PM, Andrew Lunn wrote: > On Sun, May 13, 2018 at 01:11:08PM -0700, Chen-Yu Tsai wrote: >> On Sun, May 13, 2018 at 1:05 PM, Andrew Lunn wrote: >> >> > Hi Chen-Yu >> >> > >> >> > Are these delays the MAC applies? Not the PHY. It would be

Re: WARNING: suspicious RCU usage in tipc_bearer_find

2018-05-13 Thread Eric Biggers
On Fri, Feb 09, 2018 at 12:00:01PM -0800, syzbot wrote: > syzbot has found reproducer for the following crash on net-next commit > 617aebe6a97efa539cc4b8a52adccd89596e6be0 (Sun Feb 4 00:25:42 2018 +) > Merge tag 'usercopy-v4.16-rc1' of > git://git.kernel.org/pub/scm/linux/kernel/git/kees/linux

[PATCH v2] Revert "alx: remove WoL support"

2018-05-13 Thread AceLan Kao
This reverts commit bc2bebe8de8ed4ba6482c9cc370b0dd72ffe8cd2. The WoL feature is a must to pass Energy Star 6.1 and above, the power consumption will be measured during S3 with WoL is enabled. Reverting "alx: remove WoL support", and will try to fix the unintentional wake up issue when WoL is

Re: RTL8723BE performance regression

2018-05-13 Thread Pkshih
On Wed, 2018-05-09 at 13:33 -0700, João Paulo Rechi Vita wrote: > On Tue, May 8, 2018 at 1:37 AM, Pkshih wrote: > > On Mon, 2018-05-07 at 14:49 -0700, João Paulo Rechi Vita wrote: > >> On Tue, May 1, 2018 at 10:58 PM, Pkshih wrote: > >> > On Wed,

Why ebt_dnat.c doesn't need to re-search fdb after changing dmac?

2018-05-13 Thread Yi Li
Hi List, As the subject stated, I didn't find the clue. If we add dnat into NF_BR_LOCAL_OUT, and change the destination mac of our locally generated packets. In theory , we need to re-search the fdb hash with new dmac as parameter, in order to get the right bridge port to send packets

linux-next: manual merge of the bpf-next tree with the bpf tree

2018-05-13 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the bpf-next tree got a conflict in: tools/lib/bpf/libbpf.c between commit: 3597683c9da6 ("tools: bpf: handle NULL return in bpf_prog_load_xattr()") from the bpf tree and commit: 17387dd5ac2c ("tools: bpf: don't complain about no kernel version for

Re: [PATCH 2/2] alx: add disable_wol paramenter

2018-05-13 Thread AceLan Kao
Okay, I'll submit a new patch with some more description of why we need this feature. Thanks. 2018-05-10 20:34 GMT+08:00 Andrew Lunn : > On Thu, May 10, 2018 at 01:58:24PM +0800, AceLan Kao wrote: >> Hi Andrew, >> >> We have some machines using Qualcomm Atheros Killer E2400

Re: [PATCH net V2] tun: fix use after free for ptr_ring

2018-05-13 Thread Jason Wang
On 2018年05月12日 01:39, Cong Wang wrote: On Thu, May 10, 2018 at 7:49 PM, Jason Wang wrote: static void __tun_detach(struct tun_file *tfile, bool clean) { struct tun_file *ntfile; @@ -736,7 +727,8 @@ static void __tun_detach(struct tun_file *tfile, bool clean)

Re:Re: Re: Re: [PATCH net] net: Correct wrong skb_flow_limit check when enable RPS

2018-05-13 Thread Gao Feng
At 2018-05-11 22:56:04, "Willem de Bruijn" wrote: >On Fri, May 11, 2018 at 10:44 AM, Gao Feng wrote: >> At 2018-05-11 21:23:55, "Willem de Bruijn" >> wrote: >>>On Fri, May 11, 2018 at 2:20 AM, Gao Feng

Re: pull-request: bpf 2018-05-14

2018-05-13 Thread David Miller
From: Daniel Borkmann Date: Mon, 14 May 2018 02:47:10 +0200 > The following pull-request contains BPF updates for your *net* tree. > > The main changes are: > > 1) Fix nfp to allow zero-length BPF capabilities, meaning the nfp >capability parsing loop will otherwise

Re: [PATCH bpf-next 2/6] bpf, sparc: remove unused variable

2018-05-13 Thread David Miller
From: Daniel Borkmann Date: Mon, 14 May 2018 02:26:08 +0200 > Since fe83963b7c38 ("bpf, sparc64: remove ld_abs/ld_ind") it's not > used anymore therefore remove it. > > Signed-off-by: Daniel Borkmann Acked-by: David S. Miller

Re: [PATCH 00/15] Netfilter/IPVS fixes for net

2018-05-13 Thread David Miller
From: Pablo Neira Ayuso Date: Mon, 14 May 2018 00:36:41 +0200 > The following patchset contains Netfilter/IPVS fixes for your net tree, > they are: ... > You can pull these changes from: > > git://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf.git Pulled, thanks.

pull-request: bpf 2018-05-14

2018-05-13 Thread Daniel Borkmann
Hi David, The following pull-request contains BPF updates for your *net* tree. The main changes are: 1) Fix nfp to allow zero-length BPF capabilities, meaning the nfp capability parsing loop will otherwise exit early if the last capability is zero length and therefore driver will fail to

Re: [PATCH] net: ipv4: ipconfig: fix unused variable

2018-05-13 Thread David Miller
From: Anders Roxell Date: Sun, 13 May 2018 21:48:30 +0200 > When CONFIG_PROC_FS isn't set, variable ipconfig_dir isn't used. > net/ipv4/ipconfig.c:167:31: warning: ‘ipconfig_dir’ defined but not used > [-Wunused-variable] > static struct proc_dir_entry *ipconfig_dir;

Re: [PATCH net] qede: Fix ref-cnt usage count

2018-05-13 Thread David Miller
From: Michal Kalderon Date: Sun, 13 May 2018 20:54:06 +0300 > Rebooting while qedr is loaded with a VLAN interface present > results in unregister_netdevice waiting for the usage count > to become free. > The fix is that rdma devices should be removed before

[PATCH bpf-next 2/6] bpf, sparc: remove unused variable

2018-05-13 Thread Daniel Borkmann
Since fe83963b7c38 ("bpf, sparc64: remove ld_abs/ld_ind") it's not used anymore therefore remove it. Signed-off-by: Daniel Borkmann --- arch/sparc/net/bpf_jit_comp_64.c | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/sparc/net/bpf_jit_comp_64.c

[PATCH bpf-next 3/6] bpf, x64: clean up retpoline emission slightly

2018-05-13 Thread Daniel Borkmann
Make the RETPOLINE_{RA,ED}X_BPF_JIT() a bit more readable by cleaning up the macro, aligning comments and spacing. Signed-off-by: Daniel Borkmann --- arch/x86/include/asm/nospec-branch.h | 29 ++--- 1 file changed, 14 insertions(+), 15 deletions(-)

[PATCH bpf-next 4/6] bpf, arm32: save 4 bytes of unneeded stack space

2018-05-13 Thread Daniel Borkmann
The extra skb_copy_bits() buffer is not used anymore, therefore remove the extra 4 byte stack space requirement. Signed-off-by: Daniel Borkmann --- arch/arm/net/bpf_jit_32.c | 13 +++-- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git

[PATCH bpf-next 5/6] bpf, arm64: save 4 bytes of unneeded stack space

2018-05-13 Thread Daniel Borkmann
Follow-up to 816d9ef32a8b ("bpf, arm64: remove ld_abs/ld_ind") in that the extra 4 byte JIT scratchpad is not needed anymore since it was in ld_abs/ld_ind as stack buffer for bpf_load_pointer(). Signed-off-by: Daniel Borkmann --- arch/arm64/net/bpf_jit_comp.c | 7 ++-

[PATCH bpf-next 1/6] bpf, mips: remove unused function

2018-05-13 Thread Daniel Borkmann
The ool_skb_header_pointer() and size_to_len() is unused same as tmp_offset, therefore remove all of them. Signed-off-by: Daniel Borkmann --- arch/mips/net/ebpf_jit.c | 26 -- 1 file changed, 26 deletions(-) diff --git a/arch/mips/net/ebpf_jit.c

[PATCH bpf-next 0/6] Minor follow-up cleanups in BPF JITs and optimized imm emission

2018-05-13 Thread Daniel Borkmann
This series follows up mostly with with some minor cleanups on top of 'Move ld_abs/ld_ind to native BPF' as well as implements better 32/64 bit immediate load into register for the arm64 JIT. For details please see individual patches. Thanks! Daniel Borkmann (6): bpf, mips: remove unused

[PATCH bpf-next 6/6] bpf, arm64: optimize 32/64 immediate emission

2018-05-13 Thread Daniel Borkmann
Improve the JIT to emit 64 and 32 bit immediates, the current algorithm is not optimal and we often emit more instructions than actually needed. arm64 has movz, movn, movk variants but for the current 64 bit immediates we only use movz with a series of movk when needed. For example loading

Re: [PATCH] 3c59x: convert to generic DMA API

2018-05-13 Thread David Miller
From: Christoph Hellwig Date: Sat, 12 May 2018 12:16:50 +0200 > This driver supports EISA devices in addition to PCI devices, and relied > on the legacy behavior of the pci_dma* shims to pass on a NULL pointer > to the DMA API, and the DMA API being able to handle that. When the >

Re: [PATCH net] xfrm6: avoid potential infinite loop in _decode_session6()

2018-05-13 Thread David Miller
From: Eric Dumazet Date: Sat, 12 May 2018 02:49:30 -0700 > syzbot found a way to trigger an infinitie loop by overflowing > @offset variable that has been forced to use u16 for some very > obscure reason in the past. > > We probably want to look at NEXTHDR_FRAGMENT handling

Re: [PATCH net-next v2 3/8] sctp: move the flush of ctrl chunks into its own function

2018-05-13 Thread Marcelo Ricardo Leitner
On Sat, May 12, 2018 at 07:21:01PM -0300, Marcelo Ricardo Leitner wrote: > Named sctp_outq_flush_ctrl and, with that, keep the contexts contained. Trinity triggered a panic on this patch. I'm debugging it.

Re: [PATCH net] packet: in packet_snd start writing at link layer allocation

2018-05-13 Thread David Miller
From: Willem de Bruijn Date: Fri, 11 May 2018 13:24:25 -0400 > From: Willem de Bruijn > > Packet sockets allow construction of packets shorter than > dev->hard_header_len to accommodate protocols with variable length > link layer headers.

Re: [PATCH net V2] tun: fix use after free for ptr_ring

2018-05-13 Thread David Miller
From: Jason Wang Date: Fri, 11 May 2018 10:49:25 +0800 > We used to initialize ptr_ring during TUNSETIFF, this is because its > size depends on the tx_queue_len of netdevice. And we try to clean it > up when socket were detached from netdevice. A race were spotted when >

Re: [PATCH] [PATCH net v3] ipv6: remove min MTU check for ipsec tunnels

2018-05-13 Thread David Miller
From: Ashwanth Goli Date: Thu, 10 May 2018 23:15:44 +0530 > With 749439bfac "fix udpv6 sendmsg crash caused by too small MTU" > ipsec tunnels that report a MTU less than IPV6_MIN_MTU are broken > even for packets that are smaller than IPV6_MIN_MTU. > > According to

Re: [PATCH net-next v8 0/3] kernel: add support to collect hardware logs in crash recovery kernel

2018-05-13 Thread David Miller
I'm deferring this patch series. If we can't get a reasonable review from an interested party in 10+ days, that is not reasonable. Resubmit this once someone reviews it properly. Thank you.

Re: [PATCH net-next v9 1/7] sched: Add Common Applications Kept Enhanced (cake) qdisc

2018-05-13 Thread David Miller
From: Toke Høiland-Jørgensen Date: Tue, 08 May 2018 16:34:19 +0200 > +struct cake_flow { > + /* this stuff is all needed per-flow at dequeue time */ > + struct sk_buff*head; > + struct sk_buff*tail; Please do not invent your own SKB list handling mechanism.

[PATCH] net/smc: check for missing nlattrs in SMC_PNETID messages

2018-05-13 Thread Eric Biggers
From: Eric Biggers It's possible to crash the kernel in several different ways by sending messages to the SMC_PNETID generic netlink family that are missing the expected attributes: - Missing SMC_PNETID_NAME => null pointer dereference when comparing names. - Missing

[PATCH v2] net/mlx4_core: Fix error handling in mlx4_init_port_info.

2018-05-13 Thread Tarick Bedeir
Avoid exiting the function with a lingering sysfs file (if the first call to device_create_file() fails while the second succeeds), and avoid calling devlink_port_unregister() twice. In other words, either mlx4_init_port_info() succeeds and returns zero, or it fails, returns non-zero, and

[PATCH] net: ethernet: ti: Use ERR_CAST instead of ERR_PTR(PTR_ERR())

2018-05-13 Thread Hernán Gonzalez
Use ERR_CAST inlined function instead of ERR_PTR(PTR_ERR(...)). drivers/net/ethernet/ti/cpts.c:567:9-16: WARNING: ERR_CAST can be used with cpts->refclk Generated by: scripts/coccinelle/api/err_cast.cocci Signed-off-by: Hernán Gonzalez ---

[PATCH 03/15] netfilter: nf_tables: skip synchronize_rcu if transaction log is empty

2018-05-13 Thread Pablo Neira Ayuso
From: Florian Westphal After processing the transaction log, the remaining entries of the log need to be released. However, in some cases no entries remain, e.g. because the transaction did not remove anything. Signed-off-by: Florian Westphal Signed-off-by:

[PATCH 01/15] netfilter: Fix handling simultaneous open in TCP conntrack

2018-05-13 Thread Pablo Neira Ayuso
From: Jozsef Kadlecsik Dominique Martinet reported a TCP hang problem when simultaneous open was used. The problem is that the tcp_conntracks state table is not smart enough to handle the case. The state table could be fixed by introducing a new state, but that would

[PATCH 05/15] netfilter: nf_tables: nft_compat: fix refcount leak on xt module

2018-05-13 Thread Pablo Neira Ayuso
From: Florian Westphal Taehee Yoo reported following bug: iptables-compat -I OUTPUT -m cpu --cpu 0 iptables-compat -F lsmod |grep xt_cpu xt_cpu 16384 1 Quote: "When above command is given, a netlink message has two expressions that are the cpu

[PATCH 02/15] netfilter: x_tables: check name length in find_match/target, too

2018-05-13 Thread Pablo Neira Ayuso
From: Florian Westphal ebtables uses find_match() rather than find_request_match in one case (see bcf4934288402be3464110109a4dae3bd6fb3e93, "netfilter: ebtables: Fix extension lookup with identical name"), so extend the check on name length to those functions too.

[PATCH 06/15] ipvs: fix refcount usage for conns in ops mode

2018-05-13 Thread Pablo Neira Ayuso
From: Julian Anastasov Connections in One-packet scheduling mode (-o, --ops) are removed with refcnt=0 because they are not hashed in conn table. To avoid refcount_dec reporting this as error, change them to be removed with refcount_dec_if_one as all other connections. refcount_t

[PATCH 04/15] netfilter: bridge: stp fix reference to uninitialized data

2018-05-13 Thread Pablo Neira Ayuso
From: Stephen Hemminger The destination mac (destmac) is only valid if EBT_DESTMAC flag is set. Fix by changing the order of the comparison to look for the flag first. Reported-by: syzbot+5c06e318fc558cc27...@syzkaller.appspotmail.com Signed-off-by: Stephen Hemminger

[PATCH 10/15] netfilter: x_tables: add module alias for icmp matches

2018-05-13 Thread Pablo Neira Ayuso
From: Florian Westphal The icmp matches are implemented in ip_tables and ip6_tables, respectively, so for normal iptables they are always available: those modules are loaded once iptables calls getsockopt() to fetch available module revisions. In iptables-over-nftables case

[PATCH 11/15] netfilter: nf_tables: don't assume chain stats are set when jumplabel is set

2018-05-13 Thread Pablo Neira Ayuso
From: Florian Westphal nft_chain_stats_replace() and all other spots assume ->stats can be NULL, but nft_update_chain_stats does not. It must do this check, just because the jump label is set doesn't mean all basechains have stats assigned. Signed-off-by: Florian Westphal

[PATCH 08/15] netfilter: core: add missing __rcu annotation

2018-05-13 Thread Pablo Neira Ayuso
From: Florian Westphal removes following sparse error: net/netfilter/core.c:598:30: warning: incorrect type in argument 1 (different address spaces) net/netfilter/core.c:598:30:expected struct nf_hook_entries **e net/netfilter/core.c:598:30:got struct nf_hook_entries

[PATCH 12/15] netfilter: nft_compat: prepare for indirect info storage

2018-05-13 Thread Pablo Neira Ayuso
From: Florian Westphal Next patch will make it possible for *info to be stored in a separate allocation instead of the expr private area. This removes the 'expr priv area is info blob' assumption from the match init/destroy/eval functions. Signed-off-by: Florian Westphal

[PATCH 09/15] netfilter: prefer nla_strlcpy for dealing with NLA_STRING attributes

2018-05-13 Thread Pablo Neira Ayuso
From: Florian Westphal fixes these warnings: 'nfnl_cthelper_create' at net/netfilter/nfnetlink_cthelper.c:237:2, 'nfnl_cthelper_new' at net/netfilter/nfnetlink_cthelper.c:450:9: ./include/linux/string.h:246:9: warning: '__builtin_strncpy' specified bound 16 equals destination

[PATCH 07/15] ipvs: fix stats update from local clients

2018-05-13 Thread Pablo Neira Ayuso
From: Julian Anastasov Local clients are not properly synchronized on 32-bit CPUs when updating stats (3.10+). Now it is possible estimation_timer (timer), a stats reader, to interrupt the local client in the middle of write_seqcount_{begin,end} sequence leading to loop (DEADLOCK).

[PATCH 15/15] netfilter: nf_tables: fix memory leak on error exit return

2018-05-13 Thread Pablo Neira Ayuso
From: Colin Ian King Currently the -EBUSY error return path is not free'ing resources allocated earlier, leaving a memory leak. Fix this by exiting via the error exit label err5 that performs the necessary resource clean up. Detected by CoverityScan, CID#1432975

[PATCH 13/15] netfilter: nft_compat: fix handling of large matchinfo size

2018-05-13 Thread Pablo Neira Ayuso
From: Florian Westphal currently matchinfo gets stored in the expression, but some xt matches are very large. To handle those we either need to switch nft core to kvmalloc and increase size limit, or allocate the info blob of large matches separately. This does the latter, this

[PATCH 14/15] netfilter: nf_tables: bogus EBUSY in chain deletions

2018-05-13 Thread Pablo Neira Ayuso
When removing a rule that jumps to chain and such chain in the same batch, this bogusly hits EBUSY. Add activate and deactivate operations to expression that can be called from the preparation and the commit/abort phases. Signed-off-by: Pablo Neira Ayuso ---

[PATCH 00/15] Netfilter/IPVS fixes for net

2018-05-13 Thread Pablo Neira Ayuso
Hi David, The following patchset contains Netfilter/IPVS fixes for your net tree, they are: 1) Fix handling of simultaneous open TCP connection in conntrack, from Jozsef Kadlecsik. 2) Insufficient sanitify check of xtables extension names, from Florian Westphal. 3) Skip unnecessary

Proposal

2018-05-13 Thread Zeliha Omer Faruk
-- Hello Greetings to you please i have a business proposal for you contact me for more detailes asap thanks. Best Regards, Miss.Zeliha ömer faruk Esentepe Mahallesi Büyükdere Caddesi Kristal Kule Binasi No:215 Sisli - Istanbul, Turkey

linux-next: Signed-off-by missing for commit in the net-next tree

2018-05-13 Thread Stephen Rothwell
Hi all, Commit 9cd00a8aa42e ("net: phy: phylink: Poll link GPIOs") is missing a Signed-off-by from its author. -- Cheers, Stephen Rothwell pgpi5UnW2Prac.pgp Description: OpenPGP digital signature

Re: [PATCH net-next v2 2/3] sctp: add asoc and packet to sctp_flush_ctx

2018-05-13 Thread Marcelo Ricardo Leitner
On Sat, May 12, 2018 at 07:21:51PM -0300, Marcelo Ricardo Leitner wrote: > @@ -1043,20 +1038,17 @@ static bool sctp_outq_flush_rtx(struct sctp_flush_ctx > *ctx, > static void sctp_outq_flush_data(struct sctp_flush_ctx *ctx, >int rtx_timeout) > { > - struct

Re: general protection fault in rds_ib_get_mr

2018-05-13 Thread Eric Biggers
On Wed, Mar 21, 2018 at 09:00:01AM -0700, syzbot wrote: > Hello, > > syzbot hit the following crash on upstream commit > 3215b9d57a2c75c4305a3956ca303d7004485200 (Wed Mar 21 00:44:27 2018 +) > Merge tag 'clk-fixes-for-linus' of > git://git.kernel.org/pub/scm/linux/kernel/git/clk/linux >

[PATCH net-next] sched: cls: enable verbose logging

2018-05-13 Thread Marcelo Ricardo Leitner
Currently, when the rule is not to be exclusively executed by the hardware, extack is not passed along and offloading failures don't get logged. The idea was that hardware failures are okay because the rule will get executed in software then and this way it doesn't confuse unware users. But this

[PATCH iproute2-next] tc: flower: add support for verbose logging

2018-05-13 Thread Marcelo Ricardo Leitner
From: Marcelo Ricardo Leitner Currently there is no way to log offloading errors if the rule is not explicitly marked as skip_sw, making it hard for other applications such as Open vSwitch to log why a given could not be offloaded. This patch adds support for signaling the

Re: [PATCH RESEND net-next v2 1/8] dt-bindings: net: dwmac-sun8i: Clean up clock delay chain descriptions

2018-05-13 Thread Andrew Lunn
On Sun, May 13, 2018 at 01:11:08PM -0700, Chen-Yu Tsai wrote: > On Sun, May 13, 2018 at 1:05 PM, Andrew Lunn wrote: > >> > Hi Chen-Yu > >> > > >> > Are these delays the MAC applies? Not the PHY. It would be good to > >> > make it clear here these are MAC imposed delays. > >> > >>

Re: [PATCH RESEND net-next v2 1/8] dt-bindings: net: dwmac-sun8i: Clean up clock delay chain descriptions

2018-05-13 Thread Andrew Lunn
On Mon, May 14, 2018 at 04:10:58AM +0800, Icenowy Zheng wrote: > > > 于 2018年5月14日 GMT+08:00 上午4:05:29, Andrew Lunn 写到: > >> > Hi Chen-Yu > >> > > >> > Are these delays the MAC applies? Not the PHY. It would be good to > >> > make it clear here these are MAC imposed delays. > >>

Re: [PATCH RESEND net-next v2 1/8] dt-bindings: net: dwmac-sun8i: Clean up clock delay chain descriptions

2018-05-13 Thread Icenowy Zheng
于 2018年5月14日 GMT+08:00 上午4:05:29, Andrew Lunn 写到: >> > Hi Chen-Yu >> > >> > Are these delays the MAC applies? Not the PHY. It would be good to >> > make it clear here these are MAC imposed delays. >> >> Yes these are applied on the MAC side. Being described in the device >>

Re: [PATCH RESEND net-next v2 1/8] dt-bindings: net: dwmac-sun8i: Clean up clock delay chain descriptions

2018-05-13 Thread Chen-Yu Tsai
On Sun, May 13, 2018 at 1:05 PM, Andrew Lunn wrote: >> > Hi Chen-Yu >> > >> > Are these delays the MAC applies? Not the PHY. It would be good to >> > make it clear here these are MAC imposed delays. >> >> Yes these are applied on the MAC side. Being described in the device >> tree

Re: [PATCH RESEND net-next v2 1/8] dt-bindings: net: dwmac-sun8i: Clean up clock delay chain descriptions

2018-05-13 Thread Andrew Lunn
> > Hi Chen-Yu > > > > Are these delays the MAC applies? Not the PHY. It would be good to > > make it clear here these are MAC imposed delays. > > Yes these are applied on the MAC side. Being described in the device > tree bindings for the MAC, I thought this was implied to be the case? > Are

Re: INFO: trying to register non-static key in del_timer_sync

2018-05-13 Thread Eric Biggers
On Sun, Jan 28, 2018 at 10:58:01AM -0800, syzbot wrote: > Hello, > > syzbot hit the following crash on upstream commit > c4e0ca7fa24137e372d6135fe16e8df8e123f116 (Fri Jan 26 23:10:50 2018 +) > Merge tag 'riscv-for-linus-4.15-maintainers' of >

Re: [PATCH RESEND net-next v2 1/8] dt-bindings: net: dwmac-sun8i: Clean up clock delay chain descriptions

2018-05-13 Thread Chen-Yu Tsai
On Sun, May 13, 2018 at 12:49 PM, Andrew Lunn wrote: > On Mon, May 14, 2018 at 03:14:18AM +0800, Chen-Yu Tsai wrote: >> The clock delay chains found in the glue layer for dwmac-sun8i are only >> used with RGMII PHYs. They are not intended for non-RGMII PHYs, such as >> MII

[PATCH] net: ipv4: ipconfig: fix unused variable

2018-05-13 Thread Anders Roxell
When CONFIG_PROC_FS isn't set, variable ipconfig_dir isn't used. net/ipv4/ipconfig.c:167:31: warning: ‘ipconfig_dir’ defined but not used [-Wunused-variable] static struct proc_dir_entry *ipconfig_dir; ^~~~ Move the declaration of ipconfig_dir inside the

Re: [PATCH RESEND net-next v2 1/8] dt-bindings: net: dwmac-sun8i: Clean up clock delay chain descriptions

2018-05-13 Thread Andrew Lunn
On Mon, May 14, 2018 at 03:14:18AM +0800, Chen-Yu Tsai wrote: > The clock delay chains found in the glue layer for dwmac-sun8i are only > used with RGMII PHYs. They are not intended for non-RGMII PHYs, such as > MII external PHYs or the internal PHY. Also, a recent SoC has a smaller > range of

Re: [PATCH net-next v2 15/15] arm64: dts: allwinner: a64: add SRAM controller device tree node

2018-05-13 Thread Chen-Yu Tsai
On Wed, May 2, 2018 at 4:54 AM, Maxime Ripard wrote: > On Wed, May 02, 2018 at 06:19:51PM +0800, Icenowy Zheng wrote: >> >> >> 于 2018年5月2日 GMT+08:00 下午5:53:21, Chen-Yu Tsai 写到: >> >On Wed, May 2, 2018 at 5:51 PM, Maxime Ripard >>

[PATCH RESEND net-next v2 1/8] dt-bindings: net: dwmac-sun8i: Clean up clock delay chain descriptions

2018-05-13 Thread Chen-Yu Tsai
The clock delay chains found in the glue layer for dwmac-sun8i are only used with RGMII PHYs. They are not intended for non-RGMII PHYs, such as MII external PHYs or the internal PHY. Also, a recent SoC has a smaller range of possible values for the delay chain. This patch reformats the delay

[PATCH RESEND net-next v2 2/8] dt-bindings: net: dwmac-sun8i: Sort syscon compatibles by alphabetical order

2018-05-13 Thread Chen-Yu Tsai
The A83T syscon compatible was appended to the syscon compatibles list, instead of inserted in to preserve the ordering. Move it to the proper place to keep the list sorted. Signed-off-by: Chen-Yu Tsai Reviewed-by: Rob Herring Acked-by: Maxime Ripard

[PATCH RESEND net-next v2 5/8] net: stmmac: dwmac-sun8i: Use regmap_field for syscon register access

2018-05-13 Thread Chen-Yu Tsai
On the Allwinner R40, the "GMAC clock" register is located in the CCU block, at a different register address than the other SoCs that have it in the "system control" block. This patch converts the use of regmap to regmap_field for mapping and accessing the syscon register, so we can have the

[PATCH RESEND net-next v2 0/8] net: stmmac: dwmac-sun8i: Support R40

2018-05-13 Thread Chen-Yu Tsai
This is a resend of the patches for net-next split out from my R40 Ethernet support v2 series, as requested by David Miller. The arm-soc bits will follow, once I rework the A64 system controller compatible. Patches 1, 2, and 3 clean up the dwmac-sun8i binding. Patch 4 adds device tree binding

[PATCH RESEND net-next v2 6/8] net: stmmac: dwmac-sun8i: Allow getting syscon regmap from external device

2018-05-13 Thread Chen-Yu Tsai
On the Allwinner R40 SoC, the "GMAC clock" register is in the CCU address space. Using a standard syscon to access it provides no coordination with the CCU driver for register access. Neither does it prevent this and other drivers from accessing other, maybe critical, clock control registers. On

[PATCH RESEND net-next v2 8/8] net: stmmac: dwmac-sun8i: Add support for GMAC on Allwinner R40 SoC

2018-05-13 Thread Chen-Yu Tsai
The Allwinner R40 SoC has the EMAC controller supported by dwmac-sun8i. It is named "GMAC", while EMAC refers to the 10/100 Mbps Ethernet controller supported by sun4i-emac. The controller is the same, but the R40 has the glue layer controls in the clock control unit (CCU), with a reduced RX delay

[PATCH RESEND net-next v2 4/8] dt-bindings: net: dwmac-sun8i: Add binding for GMAC on Allwinner R40 SoC

2018-05-13 Thread Chen-Yu Tsai
The Allwinner R40 SoC has the EMAC controller supported by dwmac-sun8i. It is named "GMAC", while EMAC refers to the 10/100 Mbps Ethernet controller supported by sun4i-emac. The controller is the same, but the R40 has the glue layer controls in the clock control unit (CCU), with a reduced RX delay

[PATCH RESEND net-next v2 3/8] dt-bindings: net: dwmac-sun8i: simplify description of syscon property

2018-05-13 Thread Chen-Yu Tsai
The syscon property is used to point to the device that holds the glue layer control register known as the "EMAC (or GMAC) clock register". We do not need to explicitly list what compatible strings are needed, as this information is readily available in the user manuals. Also the "syscon" device

[PATCH RESEND net-next v2 7/8] net: stmmac: dwmac-sun8i: Support different ranges for TX/RX delay chains

2018-05-13 Thread Chen-Yu Tsai
On the R40 SoC, the RX delay chain only has a range of 0~7 (hundred picoseconds), instead of 0~31. Also the TX delay chain is completely absent. This patch adds support for different ranges by adding per-compatible maximum values in the variant data. A maximum of 0 indicates that the delay chain

Re: [PATCH bpf v3] x86/cpufeature: bpf hack for clang not supporting asm goto

2018-05-13 Thread Thomas Gleixner
On Sun, 13 May 2018, Alexei Starovoitov wrote: > On Sat, May 12, 2018 at 10:30:02PM +0200, Thomas Gleixner wrote: > > But yes, the situation is slightly different here because tools which > > create trace event magic _HAVE_ to pull in kernel headers. At the same time > > these tools depend on a

[PATCH net] qede: Fix ref-cnt usage count

2018-05-13 Thread Michal Kalderon
Rebooting while qedr is loaded with a VLAN interface present results in unregister_netdevice waiting for the usage count to become free. The fix is that rdma devices should be removed before unregistering the netdevice, to assure all references to ndev are decreased. Fixes: cee9fbd8e2e9 ("qede:

Re: [PATCH bpf v3] x86/cpufeature: bpf hack for clang not supporting asm goto

2018-05-13 Thread Alexei Starovoitov
On Sat, May 12, 2018 at 10:30:02PM +0200, Thomas Gleixner wrote: > On Sat, 12 May 2018, Alexei Starovoitov wrote: > > On Thu, May 10, 2018 at 10:58 AM, Alexei Starovoitov > > wrote: > > > I see no option, but to fix the kernel. > > > Regardless whether it's called

[PATCH] [RFC] bpf: tracing: new helper bpf_get_current_cgroup_ino

2018-05-13 Thread Alban Crequy
From: Alban Crequy bpf_get_current_cgroup_ino() allows BPF trace programs to get the inode of the cgroup where the current process resides. My use case is to get statistics about syscalls done by a specific Kubernetes container. I have a tracepoint on raw_syscalls/sys_enter

KMSAN: uninit-value in tipc_conn_rcv_sub

2018-05-13 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:74ee2200b89f kmsan: bump .config.example to v4.17-rc3 git tree: https://github.com/google/kmsan.git/master console output: https://syzkaller.appspot.com/x/log.txt?x=12ab863780 kernel config:

WARNING in iov_iter_revert

2018-05-13 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:427fbe89261d Merge branch 'next' of git://git.kernel.org/p.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=16b3347780 kernel config: https://syzkaller.appspot.com/x/.config?x=fcce42b221691ff9

Re: [PATCH v2] {net, IB}/mlx5: Use 'kvfree()' for memory allocated by 'kvzalloc()'

2018-05-13 Thread Eric Dumazet
On 05/13/2018 12:00 AM, Christophe JAILLET wrote: > When 'kvzalloc()' is used to allocate memory, 'kvfree()' must be used to > free it. > > Signed-off-by: Christophe JAILLET > --- > v1 -> v2: More places to update have been added to the patch Please add

Re: INFO: rcu detected stall in kfree_skbmem

2018-05-13 Thread Marcelo Ricardo Leitner
On Sun, May 13, 2018 at 03:52:01PM +0200, Dmitry Vyukov wrote: > On Fri, May 11, 2018 at 10:42 PM, Marcelo Ricardo Leitner > wrote: > > On Fri, May 11, 2018 at 12:08:33PM -0700, Eric Dumazet wrote: > >> > >> > >> On 05/11/2018 11:41 AM, Marcelo Ricardo Leitner wrote: >

Re: INFO: rcu detected stall in kfree_skbmem

2018-05-13 Thread Dmitry Vyukov
On Fri, May 11, 2018 at 10:42 PM, Marcelo Ricardo Leitner wrote: > On Fri, May 11, 2018 at 12:08:33PM -0700, Eric Dumazet wrote: >> >> >> On 05/11/2018 11:41 AM, Marcelo Ricardo Leitner wrote: >> >> > But calling ip6_xmit with rcu_read_lock is expected. tcp stack also

Re: [PATCH v1 iproute2-next 2/3] rdma: print driver resource attributes

2018-05-13 Thread Leon Romanovsky
On Mon, May 07, 2018 at 08:53:16AM -0700, Steve Wise wrote: > This enhancement allows printing rdma device-specific state, if provided > by the kernel. This is done in a generic manner, so rdma tool doesn't Double space between "." and "This". > need to know about the details of every type of

Re: safe skb resetting after decapsulation and encapsulation

2018-05-13 Thread Jason A. Donenfeld
On Sat, May 12, 2018 at 4:07 AM, Md. Islam wrote: > I'm not an expert on this, but it looks about right. Really? Even zeroing between headers_start and headers_end? With the latest RHEL 7.5 kernel's i40e driver, doing this results in a crash in kfree. It's possible redhat is

Re: [PATCH v1 iproute2-next 1/3] rdma: update rdma_netlink.h to get driver attrs

2018-05-13 Thread Leon Romanovsky
On Mon, May 07, 2018 at 08:53:10AM -0700, Steve Wise wrote: > Signed-off-by: Steve Wise > --- > rdma/include/uapi/rdma/rdma_netlink.h | 37 > ++- > 1 file changed, 36 insertions(+), 1 deletion(-) Please write in commit message

Re: [PATCH v1 iproute2-next 2/3] rdma: print driver resource attributes

2018-05-13 Thread Leon Romanovsky
On Thu, May 10, 2018 at 08:20:51AM -0600, David Ahern wrote: > On 5/10/18 8:19 AM, Steve Wise wrote: > > > > On 5/9/2018 11:08 PM, David Ahern wrote: > >> On 5/7/18 9:53 AM, Steve Wise wrote: > >>> @@ -152,7 +153,10 @@ int main(int argc, char **argv) > >>> pretty_output = true; >

Kernel panic on kernel-3.10.0-693.21.1.el7 in ndisc.h

2018-05-13 Thread Roman Makhov
Hello, We have a problem with Kernel panic after upgrade from CentOS 7.3 (kernel-3.10.0-514.el7) to CentOS 7.4 (kernel-3.10.0-693.21.1.el7). It occurs when we have the incoming traffic from other nodes and we are performing the re-configuration of IPv6 interfaces. It is high-availability system

[RFC PATCH] net: Remove a confusing comment of macro SIOCDEVPRIVATE

2018-05-13 Thread Jian-Hong Pan
I have been reading the NET related header files recently. I found there is a macro "#define SIOCDEVPRIVATE 0x89F0" defined in include/uapi/linux/sockios.h which is useful for private controls of net devices. When I read this section: /* Device private ioctl calls */ /* * These 16 ioctls

Re: [PATCH V2] mlx4_core: allocate ICM memory in page size chunks

2018-05-13 Thread Tariq Toukan
On 11/05/2018 10:23 PM, Qing Huang wrote: When a system is under memory presure (high usage with fragments), the original 256KB ICM chunk allocations will likely trigger kernel memory management to enter slow path doing memory compact/migration ops in order to complete high order memory

Re: [PATCH] dt-bindings: net: ravb: Add support for r8a77990 SoC

2018-05-13 Thread Simon Horman
On Fri, May 11, 2018 at 03:59:42PM -0400, David Miller wrote: > From: Yoshihiro Shimoda > Date: Fri, 11 May 2018 12:18:56 +0900 > > > Add documentation for r8a77990 compatible string to renesas ravb device > > tree bindings documentation. > > > > Signed-off-by:

Re: [PATCH] net/mlx4_core: Fix error handling in mlx4_init_port_info.

2018-05-13 Thread Tariq Toukan
On 02/05/2018 4:31 PM, Tariq Toukan wrote: On 27/04/2018 6:20 PM, Tarick Bedeir wrote: Avoid exiting the function with a lingering sysfs file (if the first call to device_create_file() fails while the second succeeds), and avoid calling devlink_port_unregister() twice. In other words,

[PATCH v2] {net, IB}/mlx5: Use 'kvfree()' for memory allocated by 'kvzalloc()'

2018-05-13 Thread Christophe JAILLET
When 'kvzalloc()' is used to allocate memory, 'kvfree()' must be used to free it. Signed-off-by: Christophe JAILLET --- v1 -> v2: More places to update have been added to the patch --- drivers/infiniband/hw/mlx5/cq.c| 2 +-

Re: [Intel-wired-lan] [PATCH] e1000e: Ignore TSYNCRXCTL when getting I219 clock attributes

2018-05-13 Thread Neftin, Sasha
On 5/10/2018 21:42, Keller, Jacob E wrote: -Original Message- From: Benjamin Poirier [mailto:bpoir...@suse.com] Sent: Thursday, May 10, 2018 12:29 AM To: Kirsher, Jeffrey T Cc: Keller, Jacob E ; Achim Mildenberger

Re: BUG: unable to handle kernel paging request in cgroup_mt_destroy_v1

2018-05-13 Thread Eric Biggers
On Wed, Jan 31, 2018 at 05:58:01PM -0800, syzbot wrote: > Hello, > > syzbot hit the following crash on upstream commit > 3da90b159b146672f830bcd2489dd3a1f4e9e089 (Wed Jan 31 03:07:32 2018 +) > Merge tag 'f2fs-for-4.16-rc1' of > git://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs > >