[PATCH bpf-next v2 1/7] perf/core: add perf_get_event() to return perf_event given a struct file

2018-05-17 Thread Yonghong Song
A new extern function, perf_get_event(), is added to return a perf event given a struct file. This function will be used in later patches. Signed-off-by: Yonghong Song --- include/linux/perf_event.h | 5 + kernel/events/core.c | 8 2 files changed, 13

Re: [PATCH v3 1/2] media: rc: introduce BPF_PROG_RAWIR_EVENT

2018-05-17 Thread Y Song
On Thu, May 17, 2018 at 2:45 PM, Sean Young wrote: > Hi, > > Again thanks for a thoughtful review. This will definitely will improve > the code. > > On Thu, May 17, 2018 at 10:02:52AM -0700, Y Song wrote: >> On Wed, May 16, 2018 at 2:04 PM, Sean Young wrote: >> >

[RFC PATCH net-next] tcp: tcp_rack_reo_wnd() can be static

2018-05-17 Thread kbuild test robot
Fixes: 20b654dfe1be ("tcp: support DUPACK threshold in RACK") Signed-off-by: kbuild test robot --- tcp_recovery.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/ipv4/tcp_recovery.c b/net/ipv4/tcp_recovery.c index 30cbfb6..71593e4 100644 ---

[net-next:master 1200/1233] net/ipv4/tcp_recovery.c:24:5: sparse: symbol 'tcp_rack_reo_wnd' was not declared. Should it be static?

2018-05-17 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master head: 538e2de104cfb4ef1acb35af42427bff42adbe4d commit: 20b654dfe1beaca60ab51894ff405a049248433d [1200/1233] tcp: support DUPACK threshold in RACK reproduce: # apt-get install sparse git checkout

[PATCH bpf-next v2 2/7] bpf: introduce bpf subcommand BPF_TASK_FD_QUERY

2018-05-17 Thread Yonghong Song
Currently, suppose a userspace application has loaded a bpf program and attached it to a tracepoint/kprobe/uprobe, and a bpf introspection tool, e.g., bpftool, wants to show which bpf program is attached to which tracepoint/kprobe/uprobe. Such attachment information will be really useful to

[PATCH bpf-next v2 4/7] tools/bpf: add ksym_get_addr() in trace_helpers

2018-05-17 Thread Yonghong Song
Given a kernel function name, ksym_get_addr() will return the kernel address for this function, or 0 if it cannot find this function name in /proc/kallsyms. This function will be used later when a kernel address is used to initiate a kprobe perf event. Signed-off-by: Yonghong Song

[PATCH bpf-next v2 0/7] bpf: implement BPF_TASK_FD_QUERY

2018-05-17 Thread Yonghong Song
Currently, suppose a userspace application has loaded a bpf program and attached it to a tracepoint/kprobe/uprobe, and a bpf introspection tool, e.g., bpftool, wants to show which bpf program is attached to which tracepoint/kprobe/uprobe. Such attachment information will be really useful to

[PATCH bpf-next v2 7/7] tools/bpftool: add perf subcommand

2018-05-17 Thread Yonghong Song
The new command "bpftool perf [show | list]" will traverse all processes under /proc, and if any fd is associated with a perf event, it will print out related perf event information. Documentation is also added. Below is an example to show the results using bcc commands. Running the following 4

[PATCH bpf-next v2 3/7] tools/bpf: sync kernel header bpf.h and add bpf_trace_event_query in libbpf

2018-05-17 Thread Yonghong Song
Sync kernel header bpf.h to tools/include/uapi/linux/bpf.h and implement bpf_trace_event_query() in libbpf. The test programs in samples/bpf and tools/testing/selftests/bpf, and later bpftool will use this libbpf function to query kernel. Signed-off-by: Yonghong Song ---

[PATCH bpf-next v2 5/7] samples/bpf: add a samples/bpf test for BPF_TASK_FD_QUERY

2018-05-17 Thread Yonghong Song
This is mostly to test kprobe/uprobe which needs kernel headers. Signed-off-by: Yonghong Song --- samples/bpf/Makefile | 4 + samples/bpf/task_fd_query_kern.c | 19 ++ samples/bpf/task_fd_query_user.c | 379 +++ 3 files changed,

[PATCH bpf-next v2 6/7] tools/bpf: add two BPF_TASK_FD_QUERY tests in test_progs

2018-05-17 Thread Yonghong Song
The new tests are added to query perf_event information for raw_tracepoint and tracepoint attachment. For tracepoint, both syscalls and non-syscalls tracepoints are queries as they are treated slightly differently inside the kernel. Signed-off-by: Yonghong Song ---

Re: [PATCH bpf 5/6] tools: bpftool: resolve calls without using imm field

2018-05-17 Thread Sandipan Das
Hi Jakub, On 05/18/2018 12:21 AM, Jakub Kicinski wrote: > On Thu, 17 May 2018 12:05:47 +0530, Sandipan Das wrote: >> Currently, we resolve the callee's address for a JITed function >> call by using the imm field of the call instruction as an offset >> from __bpf_call_base. If bpf_jit_kallsyms is

Re: [PATCH net-next v12 3/7] sch_cake: Add optional ACK filter

2018-05-17 Thread Cong Wang
On Thu, May 17, 2018 at 4:23 AM, Toke Høiland-Jørgensen wrote: > Eric Dumazet writes: > >> On 05/16/2018 01:29 PM, Toke Høiland-Jørgensen wrote: >>> The ACK filter is an optional feature of CAKE which is designed to improve >>> performance on links with very

Re: [RFC PATCH bpf-next 12/12] i40e: implement Tx zero-copy

2018-05-17 Thread Björn Töpel
2018-05-17 23:31 GMT+02:00 Jesper Dangaard Brouer : > > On Tue, 15 May 2018 21:06:15 +0200 Björn Töpel wrote: > >> From: Magnus Karlsson >> >> Here, the zero-copy ndo is implemented. As a shortcut, the existing >> XDP Tx rings

Re: [net-next PATCH v2 0/4] Symmetric queue selection using XPS for Rx queues

2018-05-17 Thread Tom Herbert
On Tue, May 15, 2018 at 6:26 PM, Amritha Nambiar wrote: > This patch series implements support for Tx queue selection based on > Rx queue(s) map. This is done by configuring Rx queue(s) map per Tx-queue > using sysfs attribute. If the user configuration for Rx queues

Re: [Cake] [PATCH net-next v12 3/7] sch_cake: Add optional ACK filter

2018-05-17 Thread Eric Dumazet
On 05/17/2018 07:36 PM, Ryan Mounce wrote: > On 17 May 2018 at 22:41, Toke Høiland-Jørgensen wrote: >> Eric Dumazet writes: >> >>> On 05/17/2018 04:23 AM, Toke Høiland-Jørgensen wrote: >>> We don't do full parsing of SACKs, no; we were trying to

Re: [net-next PATCH v2 1/4] net: Refactor XPS for CPUs and Rx queues

2018-05-17 Thread Tom Herbert
On Tue, May 15, 2018 at 6:26 PM, Amritha Nambiar wrote: > Refactor XPS code to support Tx queue selection based on > CPU map or Rx queue map. > > Signed-off-by: Amritha Nambiar > --- > include/linux/cpumask.h | 11 ++ >

Re: [net-next PATCH v2 2/4] net: Enable Tx queue selection based on Rx queues

2018-05-17 Thread Tom Herbert
On Tue, May 15, 2018 at 6:26 PM, Amritha Nambiar wrote: > This patch adds support to pick Tx queue based on the Rx queue map > configuration set by the admin through the sysfs attribute > for each Tx queue. If the user configuration for receive > queue map does not

Re: [PATCH bpf-next v3 00/15] Introducing AF_XDP support

2018-05-17 Thread Alexei Starovoitov
On 5/16/18 11:46 PM, Björn Töpel wrote: 2018-05-04 1:38 GMT+02:00 Alexei Starovoitov : On Fri, May 04, 2018 at 12:49:09AM +0200, Daniel Borkmann wrote: On 05/02/2018 01:01 PM, Björn Töpel wrote: From: Björn Töpel This patch set introduces

Re: pull-request: bpf 2018-05-18

2018-05-17 Thread David Miller
From: Daniel Borkmann Date: Fri, 18 May 2018 02:26:17 +0200 > The following pull-request contains BPF updates for your *net* tree. > > The main changes are: ... > Please consider pulling these changes from: > > git://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf.git

[PATCH v2] net: qcom/emac: Allocate buffers from local node

2018-05-17 Thread Hemanth Puranik
Currently we use non-NUMA aware allocation for TPD and RRD buffers, this patch modifies to use NUMA friendly allocation. Signed-off-by: Hemanth Puranik --- Change since v1: - Addressed comments related to ordering drivers/net/ethernet/qualcomm/emac/emac-mac.c | 6

[net-next:master 1230/1233] arch/sparc/include/asm/io_64.h:177:20: note: in expansion of macro 'writel'

2018-05-17 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master head: 538e2de104cfb4ef1acb35af42427bff42adbe4d commit: 2652113ff043ca2ce1cb3be529b5ca9270c421d4 [1230/1233] net: ethernet: ti: Allow most drivers with COMPILE_TEST config: sparc64-allyesconfig (attached as

Re: [Cake] [PATCH net-next v12 3/7] sch_cake: Add optional ACK filter

2018-05-17 Thread Ryan Mounce
On 17 May 2018 at 22:41, Toke Høiland-Jørgensen wrote: > Eric Dumazet writes: > >> On 05/17/2018 04:23 AM, Toke Høiland-Jørgensen wrote: >> >>> >>> We don't do full parsing of SACKs, no; we were trying to keep things >>> simple... We do detect the presence

Re: [patch net-next RFC 04/12] dsa: set devlink port attrs for dsa ports

2018-05-17 Thread Andrew Lunn
> >>> ds = dsa_switch_alloc(>dev, DSA_MAX_PORTS); > >>> > >>> It is allocating a switch with 12 ports. However only 4 of them have > >>> names. So the core only creates slave devices for those 4. > >>> > >>> This is a useful test. Real hardware often has unused ports. A WiFi AP > >>> with

[for-next 11/15] net/mlx5e: Add ingress/egress indication for offloaded TC flows

2018-05-17 Thread Saeed Mahameed
From: Or Gerlitz When an e-switch TC rule is offloaded through the egdev (egress device) mechanism, we treat this as egress, all other cases (NIC and e-switch) are considred ingress. This is preparation step that will allow us to identify "wrong" stat/del offload calls

[for-next 14/15] net/mlx5e: Ignore attempts to offload multiple times a TC flow

2018-05-17 Thread Saeed Mahameed
From: Or Gerlitz For VF->VF and uplink->VF rules, the TC core (cls_api) attempts to offload the same flow multiple times into the driver, b/c we registered to the egdev callback. Use the flow cookie to ignore attempts to add such flows, we can't reject them (return

[for-next 12/15] net/mlx5e: Prepare for shared table to keep TC eswitch flows

2018-05-17 Thread Saeed Mahameed
From: Or Gerlitz This is a refactoring step to be able and store the hash table which keeps track of offloaded TC flows in a different location for NIC vs e-switch rules. Signed-off-by: Or Gerlitz Signed-off-by: Jiri Pirko

[pull request][for-next 00/15] Mellanox, mlx5 core and netdev updates 2018-05-17

2018-05-17 Thread Saeed Mahameed
Hi Dave and Doug, Below you can find two pull requests, 1. mlx5 core updates to be shared for both netdev and RDMA, (patches 1..9) which is based on the last mlx5-next pull request The following changes since commit a8408f4e6db775e245f20edf12b13fd58cc03a1c: net/mlx5: fix spelling mistake:

[for-next 09/15] net/mlx5e: Explicitly set source e-switch in offloaded TC rules

2018-05-17 Thread Saeed Mahameed
From: Shahar Klein Set a specific source e-switch when setting a rule that matches on the ingress port. Signed-off-by: Shahar Klein Reviewed-by: Or Gerlitz Reviewed-by: Roi Dayan Signed-off-by: Saeed

[for-next 03/15] IB/mlx5: Use 'kvfree()' for memory allocated by 'kvzalloc()'

2018-05-17 Thread Saeed Mahameed
From: Christophe JAILLET When 'kvzalloc()' is used to allocate memory, 'kvfree()' must be used to free it. Fixes: 1cbe6fc86ccfe ("IB/mlx5: Add support for CQE compressing") Signed-off-by: Christophe JAILLET Acked-by: Jason Gunthorpe

[for-next 04/15] net/mlx5: Add merged e-switch cap

2018-05-17 Thread Saeed Mahameed
From: Roi Dayan When merged e-switch is supported, the per-port e-switch is logically merged into one e-switch that spans both physical ports and all the VFs. Under merged eswitch, both the matching on source vport and setting destination vport can have a 2nd attribute which

[for-next 05/15] net/mlx5: Properly handle a vport destination when setting FTE

2018-05-17 Thread Saeed Mahameed
From: Shahar Klein When creating FTE, properly distinguish between destination being vport or tir. The previous code just worked accidentally b/c of both dest being in the same offset within a union. Signed-off-by: Shahar Klein Reviewed-by: Or

[for-next 15/15] net/mlx5e: Add HW vport counters to representor ethtool stats

2018-05-17 Thread Saeed Mahameed
From: Or Gerlitz Currently the representor only report the SW (slow-path) traffic counters. Add packet/bytes reporting of the HW counters, which account for the total amount of traffic that was handled by the vport, both slow and fast (offloaded) paths. The newly exposed

[for-next 07/15] net/mlx5e: Explicitly set destination e-switch in FDB rules

2018-05-17 Thread Saeed Mahameed
From: Rabie Loulou Set a specific destination e-switch when setting a destination vport. Signed-off-by: Rabie Loulou Reviewed-by: Or Gerlitz Reviewed-by: Roi Dayan Reviewed-by: Shahar Klein

[for-next 13/15] net/mlx5e: Use shared table for offloaded TC eswitch flows

2018-05-17 Thread Saeed Mahameed
From: Or Gerlitz Currently, each representor netdev use their own hash table to keep the mapping from TC flow (f->cookie) to the driver offloaded instance. The table is the one which originally was added for offloading TC NIC (not eswitch) rules. This scheme breaks when

[for-next 01/15] net/mlx5: Vport, Use 'kvfree()' for memory allocated by 'kvzalloc()'

2018-05-17 Thread Saeed Mahameed
From: Christophe JAILLET When 'kvzalloc()' is used to allocate memory, 'kvfree()' must be used to free it. Fixes: 9efa75254593d ("net/mlx5_core: Introduce access functions to query vport RoCE fields") Signed-off-by: Christophe JAILLET

[for-next 02/15] net/mlx5: Eswitch, Use 'kvfree()' for memory allocated by 'kvzalloc()'

2018-05-17 Thread Saeed Mahameed
From: Christophe JAILLET When 'kvzalloc()' is used to allocate memory, 'kvfree()' must be used to free it. Fixes: fed9ce22bf8ae ("net/mlx5: E-Switch, Add API to create vport rx rules") Signed-off-by: Christophe JAILLET

[for-next 08/15] net/mlx5: Add source e-switch owner

2018-05-17 Thread Saeed Mahameed
From: Shahar Klein The source e-switch owner allows a vport on one e-switch port be associated with a rule defined on the second port e-switch. The role of the source eswitch owner valid bit in the flow group is to allow the firmware fail driver attempts to wild card the

[for-next 06/15] net/mlx5: Add destination e-switch owner

2018-05-17 Thread Saeed Mahameed
From: Shahar Klein The destination e-switch owner allows a rule in namespace of one e-switch owner to point to a vport that is natively associated with another e-switch owner. Signed-off-by: Shahar Klein Reviewed-by: Or Gerlitz

[for-next 10/15] net/mlx5e: Offload TC eswitch rules for VFs belonging to different PFs

2018-05-17 Thread Saeed Mahameed
From: Rabie Loulou When the merged eswitch capability is supported, allow offloading rules between VFs which belong to different PFs (and hence have different eswitch affinity). Signed-off-by: Rabie Loulou Reviewed-by: Or Gerlitz

RE: [PATCH net-next v3 2/3] net: ethernet: freescale: Allow FEC with COMPILE_TEST

2018-05-17 Thread Andy Duan
From: Florian Fainelli Sent: 2018年5月18日 4:08 > The Freescale FEC driver builds fine with COMPILE_TEST, so make that > possible. > > Signed-off-by: Florian Fainelli Acked-by: Fugang Duan > --- >

Re: [PATCH net-next ] net: mscc: Add SPDX identifier

2018-05-17 Thread Joe Perches
On Thu, 2018-05-17 at 21:39 +0200, Alexandre Belloni wrote: > On 17/05/2018 12:28:59-0700, Joe Perches wrote: > > On Thu, 2018-05-17 at 21:23 +0200, Alexandre Belloni wrote: > > > ocelot_qsys.h is missing the SPDX identfier, fix that. > > > > > > Signed-off-by: Alexandre Belloni

Re: [PATCH bpf-next 3/3] bpf: Add mtu checking to FIB forwarding helper

2018-05-17 Thread David Ahern
On 5/17/18 4:22 PM, Daniel Borkmann wrote: > On 05/17/2018 06:09 PM, David Ahern wrote: >> Add check that egress MTU can handle packet to be forwarded. If >> the MTU is less than the packet lenght, return 0 meaning the >> packet is expected to continue up the stack for help - eg., >> fragmenting

pull-request: bpf 2018-05-18

2018-05-17 Thread Daniel Borkmann
Hi David, The following pull-request contains BPF updates for your *net* tree. The main changes are: 1) Fix two bugs in sockmap, a use after free in sockmap's error path from sock_map_ctx_update_elem() where we mistakenly drop a reference we didn't take prior to that, and in the same

Re: [PATCH iproute2] ip link: Do not call ll_name_to_index when creating a new link

2018-05-17 Thread David Ahern
On 5/17/18 4:36 PM, Stephen Hemminger wrote: > On Thu, 17 May 2018 16:22:37 -0600 > dsah...@kernel.org wrote: > >> From: David Ahern >> >> Using iproute2 to create a bridge and add 4094 vlans to it can take from >> 2 to 3 *minutes*. The reason is the extraneous call to

[PATCH net v2] net: dsa: Do not register devlink for unused ports

2018-05-17 Thread Florian Fainelli
Even if commit 1d27732f411d ("net: dsa: setup and teardown ports") indicated that registering a devlink instance for unused ports is not a problem, and this is true, this can be confusing nonetheless, so let's not do it. Fixes: 1d27732f411d ("net: dsa: setup and teardown ports") Reported-by: Jiri

[net-next:master 1230/1233] arch/mips/include/asm/io.h:422:1: note: in expansion of macro '__BUILD_MEMORY_SINGLE'

2018-05-17 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master head: 538e2de104cfb4ef1acb35af42427bff42adbe4d commit: 2652113ff043ca2ce1cb3be529b5ca9270c421d4 [1230/1233] net: ethernet: ti: Allow most drivers with COMPILE_TEST config: mips-allyesconfig (attached as .config)

Re: [PATCH bpf-next 2/7] bpf: introduce bpf subcommand BPF_PERF_EVENT_QUERY

2018-05-17 Thread kbuild test robot
Hi Yonghong, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on bpf-next/master] url: https://github.com/0day-ci/linux/commits/Yonghong-Song/bpf-implement-BPF_PERF_EVENT_QUERY-for-perf-event-query/20180518-060508 base:

Greetings

2018-05-17 Thread Miss.Zeliha Omer Faruk
Hello Greetings to you please i have a business proposal for you contact me for more detailes asap thanks. Best Regards, Miss.Zeliha ömer faruk Esentepe Mahallesi Büyükdere Caddesi Kristal Kule Binasi No:215 Sisli - Istanbul, Turkey

[PATCH iproute2] tc: allow 0% for percent options

2018-05-17 Thread Stephen Hemminger
Allowing 0% is sometimes useful for example in netem loss and drop or perhaps dropping all traffic in a HTB bin. Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=199745 Reported-by: stuartmars...@gmail.com Fixes: 927e3cfb52b5 ("tc: B.W limits can now be specified in %.") Signed-off-by:

Re: [PATCH v3 net-next 3/6] tcp: add SACK compression

2018-05-17 Thread Toke Høiland-Jørgensen
Eric Dumazet writes: > When TCP receives an out-of-order packet, it immediately sends > a SACK packet, generating network load but also forcing the > receiver to send 1-MSS pathological packets, increasing its > RTX queue length/depth, and thus processing time. > > Wifi

Re: [PATCH] ath10k: transmit queued frames after waking queues

2018-05-17 Thread Adrian Chadd
On Thu, 17 May 2018 at 16:16, Niklas Cassel wrote: > diff --git a/drivers/net/wireless/ath/ath10k/txrx.c b/drivers/net/wireless/ath/ath10k/txrx.c > index cda164f6e9f6..1d3b2d2c3fee 100644 > --- a/drivers/net/wireless/ath/ath10k/txrx.c > +++

Regression bisected to: softirq: Let ksoftirqd do its job

2018-05-17 Thread Ben Greear
One of my out-of-tree patches is a network impairment tool that acts a lot like an Ethernet bridge with latency, jitter, etc. We noticed recently that we were seeing igb adapter errors when testing with our emulator at high speeds. For whatever reason, it is only easily reproduced when we add

[PATCH] ath10k: transmit queued frames after waking queues

2018-05-17 Thread Niklas Cassel
The following problem was observed when running iperf: [ 3] 0.0- 1.0 sec 2.00 MBytes 16.8 Mbits/sec [ 3] 1.0- 2.0 sec 3.12 MBytes 26.2 Mbits/sec [ 3] 2.0- 3.0 sec 3.25 MBytes 27.3 Mbits/sec [ 3] 3.0- 4.0 sec 655 KBytes 5.36 Mbits/sec [ 3] 4.0- 5.0 sec 0.00 Bytes 0.00 bits/sec

Re: [PATCH bpf] bpf: fix truncated jump targets on heavy expansions

2018-05-17 Thread Alexei Starovoitov
On Thu, May 17, 2018 at 01:44:11AM +0200, Daniel Borkmann wrote: > Recently during testing, I ran into the following panic: > > Therefore it becomes necessary to detect and reject any such occasions > in a generic way for native eBPF and cBPF to eBPF migrations. For > the latter we can simply

Re: [PATCH ghak81 V3 3/3] audit: collect audit task parameters

2018-05-17 Thread Paul Moore
On Wed, May 16, 2018 at 7:55 AM, Richard Guy Briggs wrote: > The audit-related parameters in struct task_struct should ideally be > collected together and accessed through a standard audit API. > > Collect the existing loginuid, sessionid and audit_context together in a > new

Re: [PATCH ghak81 V3 1/3] audit: use new audit_context access funciton for seccomp_actions_logged

2018-05-17 Thread Paul Moore
On Wed, May 16, 2018 at 7:55 AM, Richard Guy Briggs wrote: > On the rebase of the following commit on the new seccomp actions_logged > function, one audit_context access was missed. > > commit cdfb6b341f0f2409aba24b84f3b4b2bba50be5c5 > ("audit: use inline function to get audit

Re: [PATCH ghak81 V3 2/3] audit: normalize loginuid read access

2018-05-17 Thread Paul Moore
On Wed, May 16, 2018 at 7:55 AM, Richard Guy Briggs wrote: > Recognizing that the loginuid is an internal audit value, use an access > function to retrieve the audit loginuid value for the task rather than > reaching directly into the task struct to get it. > > Signed-off-by:

Re: [patch net-next RFC 04/12] dsa: set devlink port attrs for dsa ports

2018-05-17 Thread Florian Fainelli
On 05/17/2018 03:40 PM, Andrew Lunn wrote: > On Thu, May 17, 2018 at 03:06:36PM -0700, Florian Fainelli wrote: >> On 05/17/2018 02:08 PM, Andrew Lunn wrote: >>> On Thu, May 17, 2018 at 10:48:55PM +0200, Jiri Pirko wrote: Thu, May 17, 2018 at 09:14:32PM CEST, f.faine...@gmail.com wrote: >

Re: [net-next PATCH v2 3/4] net-sysfs: Add interface for Rx queue map per Tx queue

2018-05-17 Thread Nambiar, Amritha
On 5/17/2018 12:05 PM, Florian Fainelli wrote: > On 05/15/2018 06:26 PM, Amritha Nambiar wrote: >> Extend transmit queue sysfs attribute to configure Rx queue map >> per Tx queue. By default no receive queues are configured for the >> Tx queue. >> >> - /sys/class/net/eth0/queues/tx-*/xps_rxqs > >

Re: [patch net-next RFC 04/12] dsa: set devlink port attrs for dsa ports

2018-05-17 Thread Andrew Lunn
On Thu, May 17, 2018 at 03:06:36PM -0700, Florian Fainelli wrote: > On 05/17/2018 02:08 PM, Andrew Lunn wrote: > > On Thu, May 17, 2018 at 10:48:55PM +0200, Jiri Pirko wrote: > >> Thu, May 17, 2018 at 09:14:32PM CEST, f.faine...@gmail.com wrote: > >>> On 05/17/2018 10:39 AM, Jiri Pirko wrote: >

Re: [PATCH iproute2] ip link: Do not call ll_name_to_index when creating a new link

2018-05-17 Thread Stephen Hemminger
On Thu, 17 May 2018 16:22:37 -0600 dsah...@kernel.org wrote: > From: David Ahern > > Using iproute2 to create a bridge and add 4094 vlans to it can take from > 2 to 3 *minutes*. The reason is the extraneous call to ll_name_to_index. > ll_name_to_index results in an

Re: [bpf PATCH v2 1/2] bpf: sockmap update rollback on error can incorrectly dec prog refcnt

2018-05-17 Thread Daniel Borkmann
On 05/17/2018 11:06 PM, John Fastabend wrote: > If the user were to only attach one of the parse or verdict programs > then it is possible a subsequent sockmap update could incorrectly > decrement the refcnt on the program. This happens because in the > rollback logic, after an error, we have to

Re: [PATCH net] net: dsa: Do not register devlink for unused ports

2018-05-17 Thread Florian Fainelli
On 05/17/2018 03:16 PM, Florian Fainelli wrote: > Even if commit 1d27732f411d ("net: dsa: setup and teardown ports") indicated > that registering a devlink instance for unused ports is not a problem, and > this > is true, this can be confusing nonetheless, so let's not do it. > > Fixes:

Re: [PATCH bpf-next 3/3] bpf: Add mtu checking to FIB forwarding helper

2018-05-17 Thread Daniel Borkmann
On 05/17/2018 06:09 PM, David Ahern wrote: > Add check that egress MTU can handle packet to be forwarded. If > the MTU is less than the packet lenght, return 0 meaning the > packet is expected to continue up the stack for help - eg., > fragmenting the packet or sending an ICMP. > > Signed-off-by:

[PATCH iproute2] ip link: Do not call ll_name_to_index when creating a new link

2018-05-17 Thread dsahern
From: David Ahern Using iproute2 to create a bridge and add 4094 vlans to it can take from 2 to 3 *minutes*. The reason is the extraneous call to ll_name_to_index. ll_name_to_index results in an ioctl(SIOCGIFINDEX) call which in turn invokes dev_load. If the index does not

[PATCH net] net: dsa: Do not register devlink for unused ports

2018-05-17 Thread Florian Fainelli
Even if commit 1d27732f411d ("net: dsa: setup and teardown ports") indicated that registering a devlink instance for unused ports is not a problem, and this is true, this can be confusing nonetheless, so let's not do it. Fixes: 1d27732f411d ("net: dsa: setup and teardown ports") Reported-by: Jiri

Proposal

2018-05-17 Thread Miss Zeliha Omer Faruk
Hello Greetings to you please i have a business proposal for you contact me for more detailes asap thanks. Best Regards, Miss.Zeliha ömer faruk Esentepe Mahallesi Büyükdere Caddesi Kristal Kule Binasi No:215 Sisli - Istanbul, Turkey

Re: [PATCH v3 net-next 3/6] tcp: add SACK compression

2018-05-17 Thread Yuchung Cheng
On Thu, May 17, 2018 at 2:57 PM, Neal Cardwell wrote: > On Thu, May 17, 2018 at 5:47 PM Eric Dumazet wrote: > >> When TCP receives an out-of-order packet, it immediately sends >> a SACK packet, generating network load but also forcing the >> receiver to

Re: [patch net-next RFC 04/12] dsa: set devlink port attrs for dsa ports

2018-05-17 Thread Florian Fainelli
On 05/17/2018 02:08 PM, Andrew Lunn wrote: > On Thu, May 17, 2018 at 10:48:55PM +0200, Jiri Pirko wrote: >> Thu, May 17, 2018 at 09:14:32PM CEST, f.faine...@gmail.com wrote: >>> On 05/17/2018 10:39 AM, Jiri Pirko wrote: >> That is compiled inside "fixed_phy", isn't it? > > It matches

Re: [PATCH v3 net-next 6/6] tcp: add tcp_comp_sack_nr sysctl

2018-05-17 Thread Neal Cardwell
On Thu, May 17, 2018 at 5:47 PM Eric Dumazet wrote: > This per netns sysctl allows for TCP SACK compression fine-tuning. > This limits number of SACK that can be compressed. > Using 0 disables SACK compression. > Signed-off-by: Eric Dumazet > ---

Re: [PATCH v3 net-next 5/6] tcp: add tcp_comp_sack_delay_ns sysctl

2018-05-17 Thread Neal Cardwell
On Thu, May 17, 2018 at 5:47 PM Eric Dumazet wrote: > This per netns sysctl allows for TCP SACK compression fine-tuning. > Its default value is 1,000,000, or 1 ms to meet TSO autosizing period. > Signed-off-by: Eric Dumazet > --- Acked-by: Neal

[net PATCH] net: Fix a bug in removing queues from XPS map

2018-05-17 Thread Amritha Nambiar
While removing queues from the XPS map, the individual CPU ID alone was used to index the CPUs map, this should be changed to also factor in the traffic class mapping for the CPU-to-queue lookup. Fixes: 184c449f91fe ("net: Add support for XPS with QoS via traffic classes") Signed-off-by: Amritha

Re: [PATCH v3 net-next 3/6] tcp: add SACK compression

2018-05-17 Thread Neal Cardwell
On Thu, May 17, 2018 at 5:47 PM Eric Dumazet wrote: > When TCP receives an out-of-order packet, it immediately sends > a SACK packet, generating network load but also forcing the > receiver to send 1-MSS pathological packets, increasing its > RTX queue length/depth, and thus

Re: [RFC PATCH ghak32 V2 01/13] audit: add container id

2018-05-17 Thread Richard Guy Briggs
On 2018-05-17 17:00, Steve Grubb wrote: > On Fri, 16 Mar 2018 05:00:28 -0400 > Richard Guy Briggs wrote: > > > Implement the proc fs write to set the audit container ID of a > > process, emitting an AUDIT_CONTAINER record to document the event. > > > > This is a write from the

Re: [PATCH net 0/7] net: ip6_gre: Fixes in headroom handling

2018-05-17 Thread Petr Machata
David Miller writes: > Luckily for you, your Fixes: tags went out before I pushed, so I could > actually fix up the commit messages and add the tags. I was hoping that would be the case. Thanks, Petr

[PATCH v3 net-next 2/6] tcp: do not force quickack when receiving out-of-order packets

2018-05-17 Thread Eric Dumazet
As explained in commit 9f9843a751d0 ("tcp: properly handle stretch acks in slow start"), TCP stacks have to consider how many packets are acknowledged in one single ACK, because of GRO, but also because of ACK compression or losses. We plan to add SACK compression in the following patch, we must

[PATCH v3 net-next 1/6] tcp: use __sock_put() instead of sock_put() in tcp_clear_xmit_timers()

2018-05-17 Thread Eric Dumazet
Socket can not disappear under us. Signed-off-by: Eric Dumazet Acked-by: Neal Cardwell --- include/net/tcp.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/net/tcp.h b/include/net/tcp.h index

Re: [PATCH v3 1/2] media: rc: introduce BPF_PROG_RAWIR_EVENT

2018-05-17 Thread Sean Young
Hi, Again thanks for a thoughtful review. This will definitely will improve the code. On Thu, May 17, 2018 at 10:02:52AM -0700, Y Song wrote: > On Wed, May 16, 2018 at 2:04 PM, Sean Young wrote: > > Add support for BPF_PROG_RAWIR_EVENT. This type of BPF program can call > >

[PATCH v3 net-next 3/6] tcp: add SACK compression

2018-05-17 Thread Eric Dumazet
When TCP receives an out-of-order packet, it immediately sends a SACK packet, generating network load but also forcing the receiver to send 1-MSS pathological packets, increasing its RTX queue length/depth, and thus processing time. Wifi networks suffer from this aggressive behavior, but

[PATCH v3 net-next 5/6] tcp: add tcp_comp_sack_delay_ns sysctl

2018-05-17 Thread Eric Dumazet
This per netns sysctl allows for TCP SACK compression fine-tuning. Its default value is 1,000,000, or 1 ms to meet TSO autosizing period. Signed-off-by: Eric Dumazet --- Documentation/networking/ip-sysctl.txt | 7 +++ include/net/netns/ipv4.h | 1 +

[PATCH v3 net-next 6/6] tcp: add tcp_comp_sack_nr sysctl

2018-05-17 Thread Eric Dumazet
This per netns sysctl allows for TCP SACK compression fine-tuning. This limits number of SACK that can be compressed. Using 0 disables SACK compression. Signed-off-by: Eric Dumazet --- Documentation/networking/ip-sysctl.txt | 6 ++ include/net/netns/ipv4.h

[PATCH v3 net-next 4/6] tcp: add TCPAckCompressed SNMP counter

2018-05-17 Thread Eric Dumazet
This counter tracks number of ACK packets that the host has not sent, thanks to ACK compression. Sample output : $ nstat -n;sleep 1;nstat|egrep "IpInReceives|IpOutRequests|TcpInSegs|TcpOutSegs|TcpExtTCPAckCompressed" IpInReceives123250 0.0 IpOutRequests

[PATCH v3 net-next 0/6] tcp: implement SACK compression

2018-05-17 Thread Eric Dumazet
When TCP receives an out-of-order packet, it immediately sends a SACK packet, generating network load but also forcing the receiver to send 1-MSS pathological packets, increasing its RTX queue length/depth, and thus processing time. Wifi networks suffer from this aggressive behavior, but

Re: [PATCH v3] mlx4_core: allocate ICM memory in page size chunks

2018-05-17 Thread Qing Huang
On 5/17/2018 2:14 PM, Eric Dumazet wrote: On 05/17/2018 01:53 PM, Qing Huang wrote: When a system is under memory presure (high usage with fragments), the original 256KB ICM chunk allocations will likely trigger kernel memory management to enter slow path doing memory compact/migration ops in

Re: [RFC PATCH ghak32 V2 03/13] audit: log container info of syscalls

2018-05-17 Thread Richard Guy Briggs
On 2018-05-17 17:09, Steve Grubb wrote: > On Fri, 16 Mar 2018 05:00:30 -0400 > Richard Guy Briggs wrote: > > > Create a new audit record AUDIT_CONTAINER_INFO to document the > > container ID of a process if it is present. > > As mentioned in a previous email, I think

Re: [RFC PATCH bpf-next 12/12] i40e: implement Tx zero-copy

2018-05-17 Thread Jesper Dangaard Brouer
On Tue, 15 May 2018 21:06:15 +0200 Björn Töpel wrote: > From: Magnus Karlsson > > Here, the zero-copy ndo is implemented. As a shortcut, the existing > XDP Tx rings are used for zero-copy. This means that and XDP program > cannot redirect to

Re: [PATCH bpf] bpf: fix truncated jump targets on heavy expansions

2018-05-17 Thread Martin KaFai Lau
On Thu, May 17, 2018 at 01:44:11AM +0200, Daniel Borkmann wrote: > Recently during testing, I ran into the following panic: > > [ 207.892422] Internal error: Accessing user space memory outside > uaccess.h routines: 9604 [#1] SMP > [ 207.901637] Modules linked in: binfmt_misc [...] >

Re: [PATCH net 0/7] net: ip6_gre: Fixes in headroom handling

2018-05-17 Thread David Miller
From: Petr Machata Date: Fri, 18 May 2018 00:03:58 +0300 > David Miller writes: > >> Series applied, thank you. > > Hi David, I forgot to add Fixes lines to the individual patches. I > replied to the e-mails with those. Let me know if you want me to

[bpf-next PATCH v2 2/2] bpf: add sk_msg prog sk access tests to test_verifier

2018-05-17 Thread John Fastabend
Add tests for BPF_PROG_TYPE_SK_MSG to test_verifier for read access to new sk fields. Signed-off-by: John Fastabend Acked-by: Martin KaFai Lau --- tools/include/uapi/linux/bpf.h |8 ++ tools/testing/selftests/bpf/test_verifier.c | 115

[bpf-next PATCH v2 1/2] bpf: allow sk_msg programs to read sock fields

2018-05-17 Thread John Fastabend
Currently sk_msg programs only have access to the raw data. However, it is often useful when building policies to have the policies specific to the socket endpoint. This allows using the socket tuple as input into filters, etc. This patch adds ctx access to the sock fields. Signed-off-by: John

[bpf-next PATCH v2 0/2] SK_MSG programs: read sock fields

2018-05-17 Thread John Fastabend
In this series we add the ability for sk msg programs to read basic sock information about the sock they are attached to. The second patch adds the tests to the selftest test_verifier. One obseration that I had from writing this seriess is lots of the ./net/core/filter.c code is almost duplicated

Re: [PATCH v3] mlx4_core: allocate ICM memory in page size chunks

2018-05-17 Thread Eric Dumazet
On 05/17/2018 01:53 PM, Qing Huang wrote: > When a system is under memory presure (high usage with fragments), > the original 256KB ICM chunk allocations will likely trigger kernel > memory management to enter slow path doing memory compact/migration > ops in order to complete high order memory

Re: [PATCH net-next v3 0/3] net: Allow more drivers with COMPILE_TEST

2018-05-17 Thread David Miller
From: Florian Fainelli Date: Thu, 17 May 2018 13:07:42 -0700 > Hi David, > > This patch series includes more drivers to be build tested with COMPILE_TEST > enabled. This helps cover some of the issues I just ran into with missing > a driver *sigh*. > > Chanves in v3: > >

Re: [PATCH 0/2] bpf: sockmap, fix uninitialized variable and double-free

2018-05-17 Thread Gustavo A. R. Silva
Hi Daniel, On 05/17/2018 03:51 PM, Daniel Borkmann wrote: On 05/17/2018 04:04 PM, Gustavo A. R. Silva wrote: This patchset aims to fix an uninitialized variable issue and a double-free issue in __sock_map_ctx_update_elem. Both issues were reported by Coverity. Thanks. Gustavo A. R. Silva

Re: [RFC PATCH ghak32 V2 03/13] audit: log container info of syscalls

2018-05-17 Thread Steve Grubb
On Fri, 16 Mar 2018 05:00:30 -0400 Richard Guy Briggs wrote: > Create a new audit record AUDIT_CONTAINER_INFO to document the > container ID of a process if it is present. As mentioned in a previous email, I think AUDIT_CONTAINER is more suitable for the container record. One

Re: [PATCH net-next] vlan: Add extack messages for link create

2018-05-17 Thread David Miller
From: David Ahern Date: Thu, 17 May 2018 12:29:47 -0700 > Add informative messages for error paths related to adding a > VLAN to a device. > > Signed-off-by: David Ahern Applied, thanks David.

Re: [patch net-next RFC 04/12] dsa: set devlink port attrs for dsa ports

2018-05-17 Thread Andrew Lunn
On Thu, May 17, 2018 at 10:48:55PM +0200, Jiri Pirko wrote: > Thu, May 17, 2018 at 09:14:32PM CEST, f.faine...@gmail.com wrote: > >On 05/17/2018 10:39 AM, Jiri Pirko wrote: > That is compiled inside "fixed_phy", isn't it? > >>> > >>> It matches what CONFIG_FIXED_PHY is, so if it's built-in it

Re: [PATCH net-next 1/1] qede: Add build_skb() support.

2018-05-17 Thread David Miller
From: Manish Chopra Date: Thu, 17 May 2018 12:05:00 -0700 > This patch makes use of build_skb() throughout in driver's receieve > data path [HW gro flow and non HW gro flow]. With this, driver can > build skb directly from the page segments which are already mapped > to

Re: [PATCH net v2] net: test tailroom before appending to linear skb

2018-05-17 Thread David Miller
From: Willem de Bruijn Date: Thu, 17 May 2018 13:13:29 -0400 > From: Willem de Bruijn > > Device features may change during transmission. In particular with > corking, a device may toggle scatter-gather in between allocating > and writing to

  1   2   3   4   >